Re: [GEDI] [PATCH 07/17] gluster: Drop useless has_zero_init callback

2020-02-17 Thread Niels de Vos
On Fri, Jan 31, 2020 at 11:44:26AM -0600, Eric Blake wrote: > block.c already defaults to 0 if we don't provide a callback; there's > no need to write a callback that always fails. > > Signed-off-by: Eric Blake Reviewed-by: Niels de Vos > --- > block/gluster.c | 14 -- > 1 file ch

Re: [PATCH 1/2] s390x: fix memleaks in cpu_finalize

2020-02-17 Thread David Hildenbrand
On 15.02.20 11:28, Philippe Mathieu-Daudé wrote: > Hi Pan, > > On 2/15/20 9:32 AM, pannengy...@huawei.com wrote: >> From: Pan Nengyuan >> >> This patch fix memleaks when we call tests/qtest/cpu-plug-test on s390x. The >> leak stack is as follow: >> >> Direct leak of 48 byte(s) in 1 object(s) all

Re: [GEDI] [PATCH 12/17] gluster: Support BDRV_ZERO_OPEN

2020-02-17 Thread Niels de Vos
On Fri, Jan 31, 2020 at 11:44:31AM -0600, Eric Blake wrote: > Since gluster already copies file-posix for lseek usage in block > status, it also makes sense to copy it for learning if the image > currently reads as all zeroes. > > Signed-off-by: Eric Blake > --- > block/gluster.c | 20 ++

Re: QAPI schema for desired state of LUKS keyslots

2020-02-17 Thread Maxim Levitsky
On Mon, 2020-02-17 at 07:45 +0100, Markus Armbruster wrote: > Maxim Levitsky writes: > > > On Sat, 2020-02-15 at 15:51 +0100, Markus Armbruster wrote: > > > Review of this patch led to a lengthy QAPI schema design discussion. > > > Let me try to condense it into a concrete proposal. > > > > > >

Re: [PATCH RFC 00/16] Implement Microvm for aarch64 architecture

2020-02-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1581925888-103620-1-git-send-email-xuyando...@huawei.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST S

Re: [PATCH v2 0/3] arm: allwinner: Wire up USB ports

2020-02-17 Thread Gerd Hoffmann
On Fri, Feb 14, 2020 at 04:12:45PM -0800, Guenter Roeck wrote: > Instantiate EHCI and OHCI controllers on Allwinner A10. > > The first patch in the series moves the declaration of EHCISysBusState > from hcd-ohci.c to hcd-ohci.h. This lets us add the structure to > AwA10State. Similar, TYPE_SYSBUS_

Re: [PATCH v2 0/2] hw/arm/xilinx_zynq: Fix USB port instantiation

2020-02-17 Thread Gerd Hoffmann
On Sat, Feb 15, 2020 at 04:23:52AM -0800, Guenter Roeck wrote: > USB ports on Xilinx Zync must be instantiated as TYPE_CHIPIDEA to work. > Linux expects and checks various chipidea registers, which do not exist > with the basic ehci emulation. This patch series fixes the problem. > > The first pat

Re: [PATCH 1/3] block/qcow2-bitmap: Remove unneeded variable assignment

2020-02-17 Thread Vladimir Sementsov-Ogievskiy
15.02.2020 19:15, Philippe Mathieu-Daudé wrote: Fix warning reported by Clang static code analyzer: CC block/qcow2-bitmap.o block/qcow2-bitmap.c:650:5: warning: Value stored to 'ret' is never read ret = -EINVAL; ^ ~~~ Reported-by: Clang Static Analyzer Signed-

Re: [PATCH 1/8] tests/acceptance/boot_linux_console: Use raspi console model as key

2020-02-17 Thread Luc Michel
On 2/15/20 8:22 PM, Philippe Mathieu-Daudé wrote: > Python dictionary are not that expensive. Use a key makes the > code easier to review. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Luc Michel > --- > tests/acceptance/boot_linux_console.py | 8 > 1 file changed, 4 inserti

Re: [PATCH 2/8] tests/acceptance/boot_linux_console: Add raspi version=2 parameter

2020-02-17 Thread Luc Michel
On 2/15/20 8:22 PM, Philippe Mathieu-Daudé wrote: > We want to tests different Raspberry Pi machines. Refactor to > take the board version as argument. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Luc Michel > --- > tests/acceptance/boot_linux_console.py | 21 +++-- >

Re: [PATCH 3/8] tests/acceptance/boot_linux_console: Test the raspi1 console

2020-02-17 Thread Luc Michel
On 2/15/20 8:22 PM, Philippe Mathieu-Daudé wrote: > $ avocado --show=app,console run -t machine:raspi1 tests/acceptance/ > JOB ID : c49310d4a21444f03789cd2c443d8c54a29ffd0a > JOB LOG: avocado/job-results/job-2020-02-05T23.52-c49310d/job.log >(1/1) > tests/acceptance/boot_linux_co

Re: [PATCH 6/8] tests/boot_linux_console: Test booting U-Boot on the Raspberry Pi 2

2020-02-17 Thread Luc Michel
On 2/15/20 8:22 PM, Philippe Mathieu-Daudé wrote: > This test runs U-Boot on the Raspberry Pi 2. > It is very simple and fast: > > $ avocado --show=app,console run -t raspi2 -t u-boot tests/acceptance/ > JOB LOG: avocado/job-results/job-2020-01-20T23.40-2424777/job.log >(1/1) > tests/

Re: [PATCH 4/8] tests/acceptance/boot_linux_console: Test the raspi0 console

2020-02-17 Thread Luc Michel
On 2/15/20 8:22 PM, Philippe Mathieu-Daudé wrote: > $ avocado --show=app,console run -t machine:raspi0 tests/acceptance/ > JOB ID : af8e017486290758bff39c986934134199af3556 > JOB LOG: avocado/job-results/job-2020-02-05T23.53-af8e017/job.log >(1/1) > tests/acceptance/boot_linux_co

Re: [PATCH 5/8] tests/acceptance/boot_linux_console: Test the raspi1 AUX console

2020-02-17 Thread Luc Michel
On 2/15/20 8:22 PM, Philippe Mathieu-Daudé wrote: > $ avocado --show=app,console run -t device:bcm2835_aux tests/acceptance/ > JOB ID : a8846d69d52da701681b1d17f80ef299009fd078 > JOB LOG: avocado/job-results/job-2020-02-05T23.44-a8846d6/job.log >(1/3) > tests/acceptance/boot_linu

Re: [PATCH 7/8] tests/boot_linux_console: Test booting U-Boot on the Raspberry Pi 3

2020-02-17 Thread Luc Michel
On 2/15/20 8:22 PM, Philippe Mathieu-Daudé wrote: > This test runs U-Boot on the Raspberry Pi 3. > It is very simple and fast: > > $ avocado --show=app,console run -t raspi3 -t u-boot tests/acceptance/ > JOB LOG: avocado/job-results/job-2020-01-20T23.40-2424777/job.log >(1/1) > tests/

Re: BIOS updates

2020-02-17 Thread Gerd Hoffmann
on > > https://git.qemu.org/git/SLOF.git? This is the correct one: > > > > 42228d763f1f (tag: qemu-slof-20200217, github/master) version: update to > > 20200217 > > > > https://github.com/aik/SLOF/commits/qemu-slof-20200217 > > Huh, this one got resolved, was it a script or a person? :) The repo is in "git clone --mirror" mode I guess ... cheers, Gerd

Re: [PATCH 8/8] tests/acceptance: Count Raspberry Pi logos displayed on framebuffer

2020-02-17 Thread Luc Michel
On 2/15/20 8:22 PM, Philippe Mathieu-Daudé wrote: > Add a test that verifies that each core properly displays the > Raspberry Pi logo on the framebuffer device. > > We simply follow the OpenCV "Template Matching with Multiple Objects" > tutorial, replacing Lionel Messi by a raspberrry: > https://d

Re: [PATCH v4 0/4] Implements the NetBSD Virtual Machine Monitor accelerator

2020-02-17 Thread Kamil Rytarowski
Ping? On 06.02.2020 22:32, Kamil Rytarowski wrote: > Hello QEMU Community! > > Over the past year the NetBSD team has been working hard on a new user-mode > API > for our hypervisor that will be released as part of the upcoming NetBSD 9.0. > This new API adds user-mode capabilities to create and

Re: [PATCH] net: tulip: check frame size and r/w data length

2020-02-17 Thread P J P
+-- On Sat, 15 Feb 2020, Sven Schnelle wrote --+ | > +if (!len1 || !len2 || !s->rx_frame_len) { | > +return; | | I haven't tested the patch yet, but would that work if the guest OS passes | only one buffer to the card? I.e. len1 = x, and len2 = 0 because only | buffer 1 is available?

Re: [RFC v2 2/6] tpm: Use TPMState as a common struct

2020-02-17 Thread Philippe Mathieu-Daudé
Hi Eric, On 2/14/20 7:37 PM, Eric Auger wrote: As we plan to introdce a SysBus TPM TIS device, let's make the TPMState a common struct usable by both the ISADevice and the SysBusDevice. TPMStateISA embeds the struct and inherits from the ISADevice. The prototype of functions bound to be used by

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

2020-02-17 Thread Philippe Mathieu-Daudé
tags/qemu-slof-20200217 for you to fetch changes up to ea9a03e5aa023c5391bab5259898475d0298aac2: pseries: Update SLOF firmware image (2020-02-17 13:08:59 +1100) Alexey Kardashevskiy (1): pseries: Update SLOF firmware image

Re: [PATCH 0/2] aspeed/scu: Implement chip id register

2020-02-17 Thread Cédric Le Goater
On 1/21/20 2:33 AM, Joel Stanley wrote: > This implements the chip id register in the SCU for the ast2500 and > ast2600. The first patch is a cleanup to separate out ast2400 and > ast2500 functionality. > > Joel Stanley (2): > aspeed/scu: Create separate write callbacks > aspeed/scu: Implement

[PULL 1/9] linux-user: alpha: Update syscall numbers to kernel 5.5 level

2020-02-17 Thread Laurent Vivier
From: Aleksandar Markovic Update alpha syscall numbers based on Linux kernel v5.5. CC: Richard Henderson Signed-off-by: Aleksandar Markovic Reviewed-by: Laurent Vivier Message-Id: <1581596954-2305-2-git-send-email-aleksandar.marko...@rt-rk.com> Signed-off-by: Laurent Vivier --- linux-user/a

[PULL 6/9] linux-user: sh4: Update syscall numbers to kernel 5.5 level

2020-02-17 Thread Laurent Vivier
From: Aleksandar Markovic Update sh4 syscall numbers based on Linux kernel v5.5. CC: Aurelien Jarno Signed-off-by: Aleksandar Markovic Reviewed-by: Laurent Vivier Message-Id: <1581596954-2305-7-git-send-email-aleksandar.marko...@rt-rk.com> Signed-off-by: Laurent Vivier --- linux-user/sh4/sy

[PULL 0/9] Linux user for 5.0 patches

2020-02-17 Thread Laurent Vivier
The following changes since commit 971b2a1e5b1a8cc8f597ac5d7016908f9fa880de: Merge remote-tracking branch 'remotes/palmer/tags/riscv-for-master-5.0-sf2' into staging (2020-02-14 18:37:11 +) are available in the Git repository at: git://github.com/vivier/qemu.git tags/linux-user-for-5.0-

[PULL 4/9] linux-user: microblaze: Update syscall numbers to kernel 5.5 level

2020-02-17 Thread Laurent Vivier
From: Aleksandar Markovic Update microblaze syscall numbers based on Linux kernel v5.5. CC: Edgar E. Iglesias Signed-off-by: Aleksandar Markovic Reviewed-by: Laurent Vivier Message-Id: <1581596954-2305-5-git-send-email-aleksandar.marko...@rt-rk.com> Signed-off-by: Laurent Vivier --- linux-u

[PULL 8/9] linux-user: xtensa: Update syscall numbers to kernel 5.5 level

2020-02-17 Thread Laurent Vivier
From: Aleksandar Markovic Update xtensa syscall numbers based on Linux kernel v5.5. CC: Max Filippov Acked-by: Max Filippov Signed-off-by: Aleksandar Markovic Reviewed-by: Laurent Vivier Message-Id: <1581596954-2305-9-git-send-email-aleksandar.marko...@rt-rk.com> Signed-off-by: Laurent Vivie

[PULL 9/9] linux-user: xtensa: Remove unused constant TARGET_NR_syscall_count

2020-02-17 Thread Laurent Vivier
From: Aleksandar Markovic Currently, there is no usage of TARGET_NR_syscall_count for target xtensa, and there is no obvious indication if there is some planned usage in future. CC: Max Filippov Acked-by: Max Filippov Signed-off-by: Aleksandar Markovic Reviewed-by: Laurent Vivier Message-Id:

[PULL 2/9] linux-user: arm: Update syscall numbers to kernel 5.5 level

2020-02-17 Thread Laurent Vivier
From: Aleksandar Markovic Update arm syscall numbers based on Linux kernel v5.5. CC: Peter Maydell Signed-off-by: Aleksandar Markovic Reviewed-by: Laurent Vivier Message-Id: <1581596954-2305-3-git-send-email-aleksandar.marko...@rt-rk.com> Signed-off-by: Laurent Vivier --- linux-user/arm/sys

[PULL 3/9] linux-user: m68k: Update syscall numbers to kernel 5.5 level

2020-02-17 Thread Laurent Vivier
From: Aleksandar Markovic Update m68k syscall numbers based on Linux kernel v5.5. CC: Laurent Vivier Signed-off-by: Aleksandar Markovic Reviewed-by: Laurent Vivier Message-Id: <1581596954-2305-4-git-send-email-aleksandar.marko...@rt-rk.com> Signed-off-by: Laurent Vivier --- linux-user/m68k/

Re: [PATCH 2/3] tools/virtiofsd/passthrough_ll: Remove unneeded variable assignment

2020-02-17 Thread Philippe Mathieu-Daudé
On 2/16/20 10:23 PM, Ján Tomko wrote: On Sat, Feb 15, 2020 at 05:07:15PM +0100, Philippe Mathieu-Daudé wrote: Fix warning reported by Clang static code analyzer:    CC  tools/virtiofsd/passthrough_ll.o  tools/virtiofsd/passthrough_ll.c:925:9: warning: Value stored to 'newfd' is never read

[PULL 5/9] linux-user: mips: Update syscall numbers to kernel 5.5 level

2020-02-17 Thread Laurent Vivier
From: Aleksandar Markovic Update mips syscall numbers based on Linux kernel tag v5.5. CC: Aurelien Jarno CC: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Reviewed-by: Laurent Vivier Message-Id: <1581596954-2305-6-git-send-email-aleksandar.marko...@rt-rk.com> Signed-off-by: Laurent Vi

[PULL 7/9] linux-user: x86_64: Update syscall numbers to kernel 5.5 level

2020-02-17 Thread Laurent Vivier
From: Aleksandar Markovic Update x86_64 syscall numbers based on Linux kernel v5.5. CC: Paolo Bonzini CC: Richard Henderson CC: Eduardo Habkost Signed-off-by: Aleksandar Markovic Reviewed-by: Laurent Vivier Message-Id: <1581596954-2305-8-git-send-email-aleksandar.marko...@rt-rk.com> Signed-

[PATCH v2 2/3] tools/virtiofsd/passthrough_ll: Remove unneeded variable assignment

2020-02-17 Thread Philippe Mathieu-Daudé
Fix warning reported by Clang static code analyzer: CC tools/virtiofsd/passthrough_ll.o tools/virtiofsd/passthrough_ll.c:925:9: warning: Value stored to 'newfd' is never read newfd = -1; ^ ~~ tools/virtiofsd/passthrough_ll.c:942:9: warning: Value stored to '

[PATCH v2 0/3] tools/virtiofsd: Fix warning reported by Clang static code analyzer

2020-02-17 Thread Philippe Mathieu-Daudé
Since v1: - Addressed Ján Tomko review comment - Added Ján Tomko R-b tag Philippe Mathieu-Daudé (3): tools/virtiofsd/passthrough_ll: Remove unneeded variable assignment tools/virtiofsd/passthrough_ll: Remove unneeded variable assignment tools/virtiofsd/fuse_lowlevel: Fix fuse_out_header::err

[PATCH v2 1/3] tools/virtiofsd/passthrough_ll: Remove unneeded variable assignment

2020-02-17 Thread Philippe Mathieu-Daudé
Fix warning reported by Clang static code analyzer: CC tools/virtiofsd/passthrough_ll.o tools/virtiofsd/passthrough_ll.c:1083:5: warning: Value stored to 'saverr' is never read saverr = ENOMEM; ^~~ Fixes: 7c6b66027 Reported-by: Clang Static Analyzer Reviewed-by

[RFC PATCH v2 3/3] tools/virtiofsd/fuse_lowlevel: Fix fuse_out_header::error value

2020-02-17 Thread Philippe Mathieu-Daudé
Fix warning reported by Clang static code analyzer: CC tools/virtiofsd/fuse_lowlevel.o tools/virtiofsd/fuse_lowlevel.c:195:9: warning: Value stored to 'error' is never read error = -ERANGE; ^ ~~~ Fixes: 2de121f01e Reported-by: Clang Static Analyzer Review

Re: [PATCH v2 1/2] s390x: fix memleaks in cpu_finalize

2020-02-17 Thread Philippe Mathieu-Daudé
On 2/17/20 4:21 AM, pannengy...@huawei.com wrote: From: Pan Nengyuan This patch fix memleaks when we call tests/qtest/cpu-plug-test on s390x. The leak stack is as follow: Direct leak of 48 byte(s) in 1 object(s) allocated from: #0 0x7fb43c7cd970 in __interceptor_calloc (/lib64/libasan.so

Re: [PATCH v2 1/2] tcg/arm: Split out tcg_out_epilogue

2020-02-17 Thread Philippe Mathieu-Daudé
On 2/16/20 10:41 AM, Richard Henderson wrote: From: Richard Henderson We will shortly use this function from tcg_out_op as well. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.inc.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/tcg/arm/tc

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

2020-02-17 Thread Cédric Le Goater
com:aik/qemu.git tags/qemu-slof-20200217 > > for you to fetch changes up to ea9a03e5aa023c5391bab5259898475d0298aac2: > > pseries: Update SLOF firmware image (2020-02-17 13:08:59 +1100) > > > Alexey Kardashevs

Re: [RFC PATCH 0/2] Enable hardfloat for PPC

2020-02-17 Thread Peter Maydell
On Mon, 17 Feb 2020 at 02:43, BALATON Zoltan wrote: > > Hello, > > This is an RFC series to start exploring the possibility of enabling > hardfloat for PPC target that haven't progressed in the last two years. > Hopefully we can work out something now. Previously I've explored this > here: > > htt

Re: QEMU Sockets Networking Backend Multicast Networking Fix

2020-02-17 Thread Jason Wang
On 2020/2/15 下午6:39, Markus Armbruster wrote: Jason, please have a look. Faisal Al-Humaimidi writes: Hello QEMU developers, I have noticed a bug in the `mcast` option of the `socket` networking backend, where I simply cannot join a multicast group (tested in Windows 10 with QEMU 4.2.0 rele

Re: [PATCH RFC 00/16] Implement Microvm for aarch64 architecture

2020-02-17 Thread Peter Maydell
On Mon, 17 Feb 2020 at 07:42, Xu Yandong wrote: > > Implement Microvm for aarch64 architecture > > This series attempts to implement microvm for aarch64 > architecture. > > Just like how Sergio Lopez does for implementing microvm > for x86 architecture. We remove parts of emulate devices which > a

Re: [PULL 00/18] QAPI patches for 2020-02-15

2020-02-17 Thread Peter Maydell
On Sat, 15 Feb 2020 at 11:42, Markus Armbruster wrote: > > The following changes since commit 517c84cef759a453cfb8f51498aebc909a5f3b39: > > Merge remote-tracking branch > 'remotes/kraxel/tags/vga-20200213-pull-request' into staging (2020-02-13 > 18:55:57 +) > > are available in the Git rep

Re: [PATCH 1/7] qapi: Document meaning of 'ignore' BlockdevOnError for jobs

2020-02-17 Thread Kevin Wolf
Am 16.02.2020 um 22:44 hat Ján Tomko geschrieben: > On Fri, Feb 14, 2020 at 09:08:06PM +0100, Kevin Wolf wrote: > > It is not obvious what 'ignore' actually means for block jobs: It could > > be continuing the job and returning success in the end despite the error > > (no block job does this). It c

[PATCH v2] configure: Avoid compiling system tools on user build by default

2020-02-17 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé User-mode does not need the sytem tools. Do not build them by default if user specified --disable-system. This disables building the following binary on a user-only build: - elf2dmp - qemu-edid - qemu-ga - qemu-img - qemu-io - qemu-nbd - ivshmem-client - ivshmem-ser

Re: [PULL 0/5] Monitor patches for 2020-02-15

2020-02-17 Thread Peter Maydell
On Sat, 15 Feb 2020 at 13:08, Markus Armbruster wrote: > > The following changes since commit b29c3e23f64938784c42ef9fca896829e3c19120: > > Merge remote-tracking branch > 'remotes/juanquintela/tags/pull-migration-pull-request' into staging > (2020-02-14 17:57:15 +) > > are available in the

Re: [PATCH v2] configure: Avoid compiling system tools on user build by default

2020-02-17 Thread Laurent Vivier
Le 17/02/2020 à 10:59, Philippe Mathieu-Daudé a écrit : > From: Philippe Mathieu-Daudé > > User-mode does not need the sytem tools. Do not build them by > default if user specified --disable-system. > > This disables building the following binary on a user-only build: > > - elf2dmp > - qemu-edi

Re: QEMU Sockets Networking Backend Multicast Networking Fix

2020-02-17 Thread Faisal Al-Humaimidi
Hello Jason, But, the local address is not meant to be added to the group, rather we listen to it, hence we bind to the local address. The multicast group is a higher layer that would be requested to join to by the listening host. Here's a similar example in multicasting that demonstrates this ide

Re: [PATCH v2 3/3] arm: allwinner: Wire up USB ports

2020-02-17 Thread Peter Maydell
On Sat, 15 Feb 2020 at 00:12, Guenter Roeck wrote: > > Instantiate EHCI and OHCI controllers on Allwinner A10. OHCI ports are > modeled as companions of the respective EHCI ports. > > With this patch applied, USB controllers are discovered and instantiated > when booting the cubieboard machine wit

[PATCH] hw/net/rocker: Report unimplemented feature with qemu_log_mask(UNIMP)

2020-02-17 Thread Philippe Mathieu-Daudé
Fix warnings reported by Clang static code analyzer: CC hw/net/rocker/rocker.o hw/net/rocker/rocker.c:213:9: warning: Value stored to 'tx_tso_mss' is never read tx_tso_mss = rocker_tlv_get_le16(tlvs[ROCKER_TLV_TX_TSO_MSS]); ^~

Re: [PATCH] hw/misc/iotkit-secctl: Fix writing to 'PPC Interrupt Clear' register

2020-02-17 Thread Peter Maydell
On Sat, 15 Feb 2020 at 16:19, Philippe Mathieu-Daudé wrote: > > Fix warning reported by Clang static code analyzer: > > CC hw/misc/iotkit-secctl.o > hw/misc/iotkit-secctl.c:343:9: warning: Value stored to 'value' is never > read > value &= 0x00f000f3; > ^~~~

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

2020-02-17 Thread Philippe Mathieu-Daudé
in the Git repository at:    g...@github.com:aik/qemu.git tags/qemu-slof-20200217 for you to fetch changes up to ea9a03e5aa023c5391bab5259898475d0298aac2:    pseries: Update SLOF firmware image (2020-02-17 13:08:59 +1100) Alexey Kardas

Re: [PATCH 0/2] aspeed/scu: Implement chip id register

2020-02-17 Thread Peter Maydell
On Mon, 17 Feb 2020 at 09:29, Cédric Le Goater wrote: > > On 1/21/20 2:33 AM, Joel Stanley wrote: > > This implements the chip id register in the SCU for the ast2500 and > > ast2600. The first patch is a cleanup to separate out ast2400 and > > ast2500 functionality. > > > > Joel Stanley (2): > >

[PATCH v2] tests/boot_linux_console: Boot Trusted Firmware-A on the Raspberry Pi 3

2020-02-17 Thread Philippe Mathieu-Daudé
This test runs Trusted Firmware-A on the Raspberry Pi 3. We deliberately stop the boot process when the EDK2 UEFI version is displayed. The binary is build on AppVeyor CI using Pete Batard repository [1]. ATF v2.1 binary are used (see [2]). Extra documentation in [3]. It is very simple and fast:

Re: QAPI schema for desired state of LUKS keyslots (was: [PATCH 02/13] qcrypto-luks: implement encryption key management)

2020-02-17 Thread Kevin Wolf
Am 15.02.2020 um 15:51 hat Markus Armbruster geschrieben: > Review of this patch led to a lengthy QAPI schema design discussion. > Let me try to condense it into a concrete proposal. > > This is about the QAPI schema, and therefore about QMP. The > human-friendly interface is out of scope. Not b

[PATCH v2] hw/misc/iotkit-secctl: Fix writing to 'PPC Interrupt Clear' register

2020-02-17 Thread Philippe Mathieu-Daudé
Fix warning reported by Clang static code analyzer: CC hw/misc/iotkit-secctl.o hw/misc/iotkit-secctl.c:343:9: warning: Value stored to 'value' is never read value &= 0x00f000f3; ^~~ Fixes: b3717c23e1c Reported-by: Clang Static Analyzer Signed-off-by:

Re: [PATCH] hw/misc/iotkit-secctl: Fix writing to 'PPC Interrupt Clear' register

2020-02-17 Thread Philippe Mathieu-Daudé
On Mon, Feb 17, 2020 at 11:22 AM Peter Maydell wrote: > > On Sat, 15 Feb 2020 at 16:19, Philippe Mathieu-Daudé wrote: > > > > Fix warning reported by Clang static code analyzer: > > > > CC hw/misc/iotkit-secctl.o > > hw/misc/iotkit-secctl.c:343:9: warning: Value stored to 'value' is ne

Re: [PATCH 2/4] tcg: Tidy tcg-runtime-gvec.c types

2020-02-17 Thread Philippe Mathieu-Daudé
On 2/17/20 3:59 AM, Richard Henderson wrote: Partial cleanup from the CONFIG_VECTOR16 removal. Replace the vec* types with their scalar expansions. Signed-off-by: Richard Henderson --- accel/tcg/tcg-runtime-gvec.c | 270 +-- 1 file changed, 130 insertions(+),

Re: [PATCH 1/3] block/qcow2-bitmap: Remove unneeded variable assignment

2020-02-17 Thread Kevin Wolf
Am 15.02.2020 um 17:15 hat Philippe Mathieu-Daudé geschrieben: > Fix warning reported by Clang static code analyzer: > > CC block/qcow2-bitmap.o > block/qcow2-bitmap.c:650:5: warning: Value stored to 'ret' is never read > ret = -EINVAL; > ^ ~~~ > > Reported-by: Clan

Re: [PATCH 3/4] tcg: Tidy tcg-runtime-gvec.c DUP*

2020-02-17 Thread Philippe Mathieu-Daudé
On 2/17/20 3:59 AM, Richard Henderson wrote: Partial cleanup from the CONFIG_VECTOR16 removal. Replace the DUP* expansions with the scalar argument. Signed-off-by: Richard Henderson --- accel/tcg/tcg-runtime-gvec.c | 50 +++- 1 file changed, 15 insertions(+),

Re: QAPI schema for desired state of LUKS keyslots (was: [PATCH 02/13] qcrypto-luks: implement encryption key management)

2020-02-17 Thread Maxim Levitsky
On Mon, 2020-02-17 at 11:37 +0100, Kevin Wolf wrote: > Am 15.02.2020 um 15:51 hat Markus Armbruster geschrieben: > > Review of this patch led to a lengthy QAPI schema design discussion. > > Let me try to condense it into a concrete proposal. > > > > This is about the QAPI schema, and therefore abo

Re: [PATCH v4 3/4] qmp: Move dispatcher to a coroutine

2020-02-17 Thread Markus Armbruster
This is the hairy one. Please bear with me while I try to grok it. Kevin Wolf writes: > This moves the QMP dispatcher to a coroutine and runs all QMP command > handlers that declare 'coroutine': true in coroutine context so they > can avoid blocking the main loop while doing I/O or waiting for

[RFC v2 0/1] pci_expander_brdige:acpi:Support pxb-pcie for ARM

2020-02-17 Thread Yubo Miao
From: miaoyubo Currently pxb-pcie is not supported by arm and only one main host bridge is described in acpi tables, which means it is not impossible to present different io numas for different devices. This series of patches make arm to support PXB-PCIE. Users can configure pxb-pcie with certai

[RFC v2 1/1] arm: acpi: pci-expender-bus: Make arm to support PXB-PCIE

2020-02-17 Thread Yubo Miao
From: miaoyubo Currently virt machine is not supported by pxb-pcie, and only one main host bridge described in ACPI tables. Under this circumstance, different io numas for differnt devices is not possible, in order to present io numas to the guest, especially for host pssthrough devices. PXB-PCIE

Re: [RFC PATCH 0/2] Enable hardfloat for PPC

2020-02-17 Thread BALATON Zoltan
On Mon, 17 Feb 2020, Peter Maydell wrote: On Mon, 17 Feb 2020 at 02:43, BALATON Zoltan wrote: Hello, This is an RFC series to start exploring the possibility of enabling hardfloat for PPC target that haven't progressed in the last two years. Hopefully we can work out something now. Previously

Re: [PATCH v2] hw/misc/iotkit-secctl: Fix writing to 'PPC Interrupt Clear' register

2020-02-17 Thread Peter Maydell
On Mon, 17 Feb 2020 at 10:57, Philippe Mathieu-Daudé wrote: > > Fix warning reported by Clang static code analyzer: > > CC hw/misc/iotkit-secctl.o > hw/misc/iotkit-secctl.c:343:9: warning: Value stored to 'value' is never > read > value &= 0x00f000f3; > ^~~~

Re: [PATCH v2 3/3] savevm: check RAM is pagesize aligned

2020-02-17 Thread Marc-André Lureau
Hi Juan On Wed, Jan 8, 2020 at 2:08 PM Juan Quintela wrote: > > Marc-André Lureau wrote: > n> Check the host pointer is correctly aligned, otherwise we may fail > > during migration in ram_block_discard_range(). > > > > Signed-off-by: Marc-André Lureau > > Reviewed-by: Juan Quintela > > queued

[Bug 1863601] [NEW] unable to type "|" character in french keyboard.

2020-02-17 Thread Aditya prakash
Public bug reported: Unable to type "|" character when using french keyboard. It is displaying "<" instead of "|" while pressing AltGr+6 from my keyboard. ** Affects: qemu Importance: Undecided Status: New ** Description changed: Unable to type "|" character when using french ke

Re: [PATCH v2 1/3] tools/virtiofsd/passthrough_ll: Remove unneeded variable assignment

2020-02-17 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > Fix warning reported by Clang static code analyzer: > > CC tools/virtiofsd/passthrough_ll.o > tools/virtiofsd/passthrough_ll.c:1083:5: warning: Value stored to 'saverr' > is never read > saverr = ENOMEM; > ^~

[PATCH v2] net: tulip: check frame size and r/w data length

2020-02-17 Thread P J P
From: Prasad J Pandit Tulip network driver while copying tx/rx buffers does not check frame size against r/w data length. This may lead to OOB buffer access. Add check to avoid it. Reported-by: Li Qiang Reported-by: Ziming Zhang Signed-off-by: Prasad J Pandit --- hw/net/tulip.c | 19

Re: [PATCH v2 2/3] tools/virtiofsd/passthrough_ll: Remove unneeded variable assignment

2020-02-17 Thread Ján Tomko
On Mon, Feb 17, 2020 at 10:42:39AM +0100, Philippe Mathieu-Daudé wrote: Fix warning reported by Clang static code analyzer: CC tools/virtiofsd/passthrough_ll.o tools/virtiofsd/passthrough_ll.c:925:9: warning: Value stored to 'newfd' is never read newfd = -1; ^ ~

Re: [PATCH 2/3] COLO: Migrate dirty pages during the gap of checkpointing

2020-02-17 Thread Eric Blake
On 2/16/20 7:20 PM, Hailiang Zhang wrote: We can migrate some dirty pages during the gap of checkpointing, by this way, we can reduce the amount of ram migrated during checkpointing. Signed-off-by: Hailiang Zhang --- +++ b/qapi/migration.json @@ -977,12 +977,14 @@ # # @vmstate-loaded: VM

[PATCH v2 02/13] hw/arm/raspi: Avoid using TypeInfo::class_data pointer

2020-02-17 Thread Philippe Mathieu-Daudé
Using class_data pointer to create a MachineClass is not the recommended way anymore. The correct way is to open-code the MachineClass::fields in the class_init() method. We can not use TYPE_RASPI_MACHINE::class_base_init() because it is called *before* each machine class_init(), therefore the boa

[PATCH v2 00/13] hw/arm: Add raspi0 and raspi1 machines

2020-02-17 Thread Philippe Mathieu-Daudé
This series addresses suggestions from Igor and Peter on the raspi machines, then add the raspi0 and raspi1. Since v1: - Use more specific machine names Philippe Mathieu-Daudé (13): hw/arm/raspi: Remove ignore_memory_transaction_failures on the raspi2 hw/arm/raspi: Avoid using TypeInfo::class

[PATCH v2 03/13] hw/arm/raspi: Use more specific machine names

2020-02-17 Thread Philippe Mathieu-Daudé
Now that we can instantiate different machines based on their board_rev register value, we can have various raspi2 and raspi3. In commit fc78a990ec103 we corrected the machine description. Correct the machine names too. For backward compatibility, add an alias to the previous generic name. Signed

[PATCH v2 01/13] hw/arm/raspi: Remove ignore_memory_transaction_failures on the raspi2

2020-02-17 Thread Philippe Mathieu-Daudé
Commit 1c3db49d39 added the raspi3, which uses the same peripherals than the raspi2 (but with different ARM cores). The raspi3 was introduced without the ignore_memory_transaction_failures flag. Almost 2 years later, the machine is usable running U-Boot and Linux. In commit 00cbd5bd74 we mapped a l

[PATCH v2 10/13] hw/arm/bcm2836: Split out common realize() code

2020-02-17 Thread Philippe Mathieu-Daudé
The realize() function is clearly composed of two parts, each described by a comment: void realize() { /* common peripherals from bcm2835 */ ... /* bcm2836 interrupt controller (and mailboxes, etc.) */ ... } Split the two part, so we can reuse the common part with other

[PATCH v2 04/13] hw/arm/raspi: Introduce RaspiProcessorId enum

2020-02-17 Thread Philippe Mathieu-Daudé
As we only support a reduced set of the REV_CODE_PROCESSOR id encoded in the board revision, define the PROCESSOR_ID values as an enum. We can simplify the board_soc_type and cores_count methods. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/raspi.c | 45 +-

[PATCH v2 05/13] hw/arm/raspi: Remove use of the 'version' value in the board code

2020-02-17 Thread Philippe Mathieu-Daudé
We expected the 'version' ID to match the board processor ID, but this is not always true (for example boards with revision id 0xa02042/0xa22042 are Raspberry Pi 2 with a BCM2837 SoC). This was not important because we were not modelling them, but since the recent refactor now allow to model these

[PATCH v2 06/13] hw/arm/bcm2836: Restrict BCM283XClass declaration to C source

2020-02-17 Thread Philippe Mathieu-Daudé
No code out of bcm2836.c uses (or requires) this declarations. Move it locally to the C source file. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/arm/bcm2836.h | 12 hw/arm/bcm2836.c | 14 ++ 2 files changed, 14 insertions(+), 12 deletions(-) diff --git

[PATCH v2 12/13] hw/arm/raspi: Add the Raspberry Pi B+ machine

2020-02-17 Thread Philippe Mathieu-Daudé
$ qemu-system-arm -M raspi1b -serial stdio \ -kernel raspberrypi/firmware/boot/kernel.img \ -dtb raspberrypi/firmware/boot/bcm2708-rpi-b.dtb \ -append 'printk.time=0 earlycon=pl011,0x20201000 console=ttyAMA0' [0.00] Booting Linux on physical CPU 0x0 [0.00] Li

[PATCH v2 07/13] hw/arm/bcm2836: QOM'ify more by adding class_init() to each SoC type

2020-02-17 Thread Philippe Mathieu-Daudé
Remove usage of TypeInfo::class_data. Instead fill the fields in the corresponding class_init(). Cc: Igor Mammedov Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/bcm2836.c | 109 ++- 1 file changed, 51 insertions(+), 58 deletions(-) diff --git a/hw

[PATCH v2 08/13] hw/arm/bcm2836: Introduce BCM283XClass::core_count

2020-02-17 Thread Philippe Mathieu-Daudé
The BCM2835 has only one core. Introduce the core_count field to be able to use values different than BCM283X_NCPUS (4). Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/bcm2836.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/arm/bcm2836.c b/hw/arm/bcm2836.c index

Re: [PATCH v6 01/25] qmp: constify QmpCommand and list

2020-02-17 Thread Marc-André Lureau
Hi Markus, Can you review/queue this patch? thanks On Fri, Nov 8, 2019 at 5:52 PM Damien Hedde wrote: > > > > On 11/8/19 4:00 PM, Marc-André Lureau wrote: > > Since 0b69f6f72ce47a37a749b056b6d5ec64c61f11e8 "qapi: remove > > qmp_unregister_command()", the command list can be declared const. > >

Re: [PATCH v2] tests/acceptance/machine_sparc_leon3: Do not run HelenOS test by default

2020-02-17 Thread KONRAD Frederic
Le 2/12/20 à 9:36 PM, Philippe Mathieu-Daudé a écrit : The www.helenos.org server is slow and downloading the Leon3 binary takes too long [*]. Do not include this test in the default suite. Similarly to commit 471c97a69b: Currently the Avocado framework does not distinct the time spent

[PATCH v2 09/13] hw/arm/bcm2836: Only provide "enabled-cpus" property to multicore SoCs

2020-02-17 Thread Philippe Mathieu-Daudé
It makes no sense to set enabled-cpus=0 on single core SoCs. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/bcm2836.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/hw/arm/bcm2836.c b/hw/arm/bcm2836.c index 3b95ad11e9..caaa4b625e 100644 --- a/hw/arm/bcm2836

[PATCH v2 11/13] hw/arm/bcm2836: Introduce the BCM2835 SoC

2020-02-17 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- include/hw/arm/bcm2836.h | 1 + hw/arm/bcm2836.c | 40 hw/arm/raspi.c | 2 ++ 3 files changed, 43 insertions(+) diff --git a/include/hw/arm/bcm2836.h b/include/hw/arm/bcm2836.h index acc75bf553

[PATCH v2 13/13] hw/arm/raspi: Add the Raspberry Pi Zero machine

2020-02-17 Thread Philippe Mathieu-Daudé
Add a Raspberry Pi Zero machine. $ qemu-system-arm -M raspi0w -serial stdio \ -kernel raspberrypi/firmware/boot/kernel.img \ -dtb raspberrypi/firmware/boot/bcm2708-rpi-zero-w.dtb \ -append 'printk.time=0 earlycon=pl011,0x20201000 console=ttyAMA0' [0.00] Booting Linux

Re: [PATCH v2 2/7] block/block-copy: use block_status

2020-02-17 Thread Max Reitz
On 08.02.20 13:25, Vladimir Sementsov-Ogievskiy wrote: > 07.02.2020 20:46, Max Reitz wrote: >> On 27.11.19 19:08, Vladimir Sementsov-Ogievskiy wrote: >>> Use bdrv_block_status_above to chose effective chunk size and to handle >>> zeroes effectively. >>> >>> This substitutes checking for just being

Re: [GEDI] [PATCH 07/17] gluster: Drop useless has_zero_init callback

2020-02-17 Thread Eric Blake
On 2/17/20 2:06 AM, Niels de Vos wrote: On Fri, Jan 31, 2020 at 11:44:26AM -0600, Eric Blake wrote: block.c already defaults to 0 if we don't provide a callback; there's no need to write a callback that always fails. Signed-off-by: Eric Blake Reviewed-by: Niels de Vos Per your other mess

Re: [PATCH v2 2/3] tools/virtiofsd/passthrough_ll: Remove unneeded variable assignment

2020-02-17 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > Fix warning reported by Clang static code analyzer: > > CC tools/virtiofsd/passthrough_ll.o > tools/virtiofsd/passthrough_ll.c:925:9: warning: Value stored to 'newfd' is > never read > newfd = -1; > ^ ~~ >

Re: [GEDI] [PATCH 07/17] gluster: Drop useless has_zero_init callback

2020-02-17 Thread Eric Blake
On 2/17/20 6:03 AM, Eric Blake wrote: > > Creation or truncation should behave just as on a file on a local > filesystem. So maybe qemu_gluster_known_zeroes is not needed at all? Which version of gluster first required a regular filesystem backing for all gluster files?  Does qemu support o

Re: QAPI schema for desired state of LUKS keyslots

2020-02-17 Thread Markus Armbruster
Kevin Wolf writes: > Am 15.02.2020 um 15:51 hat Markus Armbruster geschrieben: >> Review of this patch led to a lengthy QAPI schema design discussion. >> Let me try to condense it into a concrete proposal. >> >> This is about the QAPI schema, and therefore about QMP. The >> human-friendly inter

Re: [PATCH v4 3/4] qmp: Move dispatcher to a coroutine

2020-02-17 Thread Kevin Wolf
Am 17.02.2020 um 12:08 hat Markus Armbruster geschrieben: > This is the hairy one. Please bear with me while I try to grok it. > > Kevin Wolf writes: > > > This moves the QMP dispatcher to a coroutine and runs all QMP command > > handlers that declare 'coroutine': true in coroutine context so t

Re: [PATCH v2] configure: Avoid compiling system tools on user build by default

2020-02-17 Thread Aleksandar Markovic
11:00 AM Pon, 17.02.2020. Philippe Mathieu-Daudé је написао/ла: > > From: Philippe Mathieu-Daudé > > User-mode does not need the sytem tools. system > Do not build them by > default if user specified --disable-system. specifies > > This disables building the following binary on a user-only bu

Re: QAPI schema for desired state of LUKS keyslots

2020-02-17 Thread Eric Blake
On 2/17/20 6:28 AM, Markus Armbruster wrote: Proposal: { 'enum': 'LUKSKeyslotState', 'data': [ 'active', 'inactive' ] } { 'struct': 'LUKSKeyslotActive', 'data': { 'secret': 'str', '*iter-time': 'int } } { 'struct': 'LUKSKeyslotInactive', 'd

Re: [RFC v2 1/1] arm: acpi: pci-expender-bus: Make arm to support PXB-PCIE

2020-02-17 Thread Michael S. Tsirkin
On Mon, Feb 17, 2020 at 07:18:18PM +0800, Yubo Miao wrote: > From: miaoyubo > > Currently virt machine is not supported by pxb-pcie, > and only one main host bridge described in ACPI tables. > Under this circumstance, different io numas for differnt devices > is not possible, in order to present

[PATCH v24 01/10] acpi: nvdimm: change NVDIMM_UUID_LE to a common macro

2020-02-17 Thread Dongjiu Geng
The little end UUID is used in many places, so make NVDIMM_UUID_LE to a common macro to convert the UUID to a little end array. Signed-off-by: Dongjiu Geng Reviewed-by: Xiang Zheng --- hw/acpi/nvdimm.c| 8 ++-- include/qemu/uuid.h | 5 + 2 files changed, 7 insertions(+), 6 deletions

[PATCH v24 02/10] hw/arm/virt: Introduce a RAS machine option

2020-02-17 Thread Dongjiu Geng
RAS Virtualization feature is not supported now, so add a RAS machine option and disable it by default. Reviewed-by: Peter Maydell Signed-off-by: Dongjiu Geng Signed-off-by: Xiang Zheng Reviewed-by: Jonathan Cameron --- hw/arm/virt.c | 23 +++ include/hw/arm/virt.h

  1   2   3   4   5   >