Re: [PATCH 0/5] hw/display/artist: Fix Coverity 1419388 & 1419389

On 2/13/20 4:12 PM, Philippe Mathieu-Daudé wrote: > Another easy Coverity fix. > > Philippe Mathieu-Daudé (5): > hw/display/artist: Move trace event to draw_line() > hw/display/artist: Remove pointless initialization > hw/display/artist: Delay some variables initialization > hw/display/art

Re: [PATCH 0/2] hw: Delay timer_new() from init to realize to avoid memleaks

On 2/15/20 7:47 AM, Philippe Mathieu-Daudé wrote: > Philippe Mathieu-Daudé (2): > hw/ipmi/bmc: Delay timer_new_ns() from init to realize to avoid > memleaks > hw/sd/sd: Delay timer_new_ns() from init to realize to avoid memleaks Reviewed-by: Richard Henderson r~

Re: [PATCH 1/3] block/qcow2-bitmap: Remove unneeded variable assignment

On 2/15/20 8:15 AM, Philippe Mathieu-Daudé wrote: > Fix warning reported by Clang static code analyzer: > > CC block/qcow2-bitmap.o > block/qcow2-bitmap.c:650:5: warning: Value stored to 'ret' is never read > ret = -EINVAL; > ^ ~~~ > > Reported-by: Clang Static Anal

Re: [PATCH 2/3] hw/display/qxl: Remove unneeded variable assignment

On 2/15/20 8:15 AM, Philippe Mathieu-Daudé wrote: > Fix warning reported by Clang static code analyzer: > > hw/display/qxl.c:1634:14: warning: Value stored to 'orig_io_port' during > its initialization is never read > uint32_t orig_io_port = io_port; >^~~~ ~~

Re: [PATCH 3/3] hw/block/pflash_cfi02: Remove unneeded variable assignment

On 2/15/20 8:15 AM, Philippe Mathieu-Daudé wrote: > Fix warning reported by Clang static code analyzer: > > CC hw/block/pflash_cfi02.o > hw/block/pflash_cfi02.c:311:5: warning: Value stored to 'ret' is never read > ret = -1; > ^ ~~ > > Reported-by: Clang Static Analyzer

Re: [PATCH] configure: Avoid compiling system tools on user build by default

On 2/15/20 8:23 AM, Philippe Mathieu-Daudé wrote: > User-mode does not need the sytem tools. Do not build them by > default if user specified --disable-system. > > Signed-off-by: Philippe Mathieu-Daudé > --- > configure | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-) Reviewe

Re: [PATCH 01/12] hw/arm/raspi: Remove ignore_memory_transaction_failures on the raspi2

On 2/15/20 11:15 AM, Philippe Mathieu-Daudé wrote: > Commit 1c3db49d39 added the raspi3, which uses the same peripherals > than the raspi2 (but with different ARM cores). The raspi3 was > introduced without the ignore_memory_transaction_failures flag. > Almost 2 years later, the machine is usable r

Re: [PATCH 02/12] hw/arm/raspi: Avoid using TypeInfo::class_data pointer

On 2/15/20 11:15 AM, Philippe Mathieu-Daudé wrote: > Using class_data pointer to create a MachineClass is not > the recommended way anymore. The correct way is to open-code > the MachineClass::fields in the class_init() method. > > This partly reverts commit a03bde3674e. > > Suggested-by: Igor Ma

Re: [PATCH v2] compiler.h: Don't use compile-time assert when __NO_INLINE__ is defined

On 2/5/20 6:15 AM, Zenghui Yu wrote: > Our robot reported the following compile-time warning while compiling > Qemu with -fno-inline cflags: > > In function 'load_memop', > inlined from 'load_helper' at /qemu/accel/tcg/cputlb.c:1578:20, > inlined from 'full_ldub_mmu' at /qemu/accel/tcg/cpu

Re: [PATCH v3 1/2] target/arm: Support SError injection

On 2/13/20 9:59 PM, Gavin Shan wrote: > diff --git a/target/arm/cpu.c b/target/arm/cpu.c > index b0762a76c4..180e29fb83 100644 > --- a/target/arm/cpu.c > +++ b/target/arm/cpu.c > @@ -78,7 +78,7 @@ static bool arm_cpu_has_work(CPUState *cs) > && cs->interrupt_request & > (CPU_INTER

[Bug 1863445] Re: assertion failed at translate-all.c:2523 with version 3.1.1

Please try again with 4.2; there have been changes in this function. ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1863445 Title: assertion fai

Re: [PATCH] MAINTAINERS: Orphan MIPS KVM CPUs

On Thu, Feb 13, 2020 at 01:34:57AM +0100, Aleksandar Markovic wrote: > On Wed, Feb 12, 2020 at 7:44 PM Philippe Mathieu-Daudé > wrote: > > > > Cc'ing qemu-trivial@ & Paolo. > > > > We are in the process of handling this within the company, and this > patch should go via MIPS tree, not trivial tre

Re: hw/net/rocker: Dubious code in tx_consume()

Sat, Feb 15, 2020 at 02:15:22PM CET, phi...@redhat.com wrote: >Hi Jiri, > >I am trying to understand this code Scott Feldman added in commit >dc488f88806: > > 157 static int tx_consume(Rocker *r, DescInfo *info) > 158 { > ... > 212 if (tlvs[ROCKER_TLV_TX_TSO_MSS]) { > 213 tx_tso_mss = r

Re: [PATCH v2 1/2] target/arm: Fix select for aa64_va_parameters_both

On 2/13/20 5:25 AM, Peter Maydell wrote: > On Thu, 13 Feb 2020 at 13:12, Peter Maydell wrote: >> >> On Tue, 11 Feb 2020 at 19:42, Richard Henderson >> wrote: >>> >>> Select should always be 0 for a regime with one range. >>> >>> Signed-off-by: Richard Henderson >> >> This change makes sense, and

[Bug 1863445] Re: assertion failed at translate-all.c:2523 with version 3.1.1

indeed, works fine with 4.2 thanks -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1863445 Title: assertion failed at translate-all.c:2523 with version 3.1.1 Status in QEMU: Incomplete Bug descri

Re: [PATCH] MAINTAINERS: Orphan MIPS KVM CPUs

On 16/02/20 07:57, James Hogan wrote: >> We are in the process of handling this within the company, and this >> patch should go via MIPS tree, not trivial tree - will be updated when >> the opinions are crystallized, and all consultations with others were >> done. There is no rush. > Hi Aleksandar,

<    1   2