The recent cmd646 discussions reminded me of this patch I've had sitting in an
old branch for a while.
The DP264 machine is the last remaining user of the deprecated
pci_cmd646_ide_init() init function. Switch it over to using qdev via
pci_create()
and then remove the now-unused pci_cmd646_ide_in
Remove the call to pci_cmd646_ide_init() since global device init functions
are deprecated in preference of using qdev directly.
Signed-off-by: Mark Cave-Ayland
---
hw/alpha/dp264.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/hw/alpha/dp264.c b/hw/alpha/dp264.c
ind
Signed-off-by: Mark Cave-Ayland
---
hw/ide/cmd646.c | 12
include/hw/ide.h | 2 --
2 files changed, 14 deletions(-)
diff --git a/hw/ide/cmd646.c b/hw/ide/cmd646.c
index 335c060673..d953932104 100644
--- a/hw/ide/cmd646.c
+++ b/hw/ide/cmd646.c
@@ -317,18 +317,6 @@ static void pci_c
In a few places we report errno formatted as a negative integer.
This is not as user friendly as it can be. Use strerror() and/or
error_setg_errno() instead.
Signed-off-by: Michal Privoznik
---
hw/vfio/common.c| 2 +-
util/vfio-helpers.c | 6 +++---
2 files changed, 4 insertions(+), 4 deleti
Juan Quintela writes:
> Markus Armbruster wrote:
>> "Dr. David Alan Gilbert" writes:
>>
>>> * Juan Quintela (quint...@redhat.com) wrote:
Signed-off-by: Juan Quintela
---
migration/migration.c | 15 +++
monitor/hmp-cmds.c| 4
qapi/migration.json
On Fri, Feb 14, 2020 at 09:47:39AM +0100, Michal Privoznik wrote:
In a few places we report errno formatted as a negative integer.
This is not as user friendly as it can be. Use strerror() and/or
error_setg_errno() instead.
Signed-off-by: Michal Privoznik
---
hw/vfio/common.c| 2 +-
util/vfi
On 13.02.20 21:56, Peter Xu wrote:
> On Thu, Feb 13, 2020 at 08:42:23PM +0100, David Hildenbrand wrote:
>> On 13.02.20 19:32, Peter Xu wrote:
>>> On Thu, Feb 13, 2020 at 06:20:16PM +0100, David Hildenbrand wrote:
Resizing while migrating is dangerous and does not work as expected.
The who
On 13/02/20 23:50, Alex Bennée wrote:
> This is mainly to help with reasoning what the test is trying to do.
> We can move rcu_stress_idx to a local variable as there is only ever
> one updater thread. I've also added an assert to catch the case where
> we end up updating the current structure to i
On 2/14/20 9:47 AM, Michal Privoznik wrote:
In a few places we report errno formatted as a negative integer.
This is not as user friendly as it can be. Use strerror() and/or
error_setg_errno() instead.
Signed-off-by: Michal Privoznik
---
hw/vfio/common.c| 2 +-
util/vfio-helpers.c | 6 ++
On Fri, 14 Feb 2020 at 06:33, Markus Armbruster wrote:
>
> Does not work out of the box on my Fedora 30 build host, where
> sphinx-build gives me sphinx-build-2. I have to specify
> --sphinx-build=/usr/bin/sphinx-build-3 to unbreak it. Which of course
> breaks things when I try to build anything
On Fri, 14 Feb 2020 at 06:05, Guenter Roeck wrote:
>
> USB ports must be instantiated as TYPE_CHIPIDEA to work.
> Linux expects and checks various chipidea registers, which
> do not exist with the basic ehci emulation.
Hi; I didn't see a cover letter email for this series (sorry if
I missed it).
On Fri, 14 Feb 2020 09:47:39 +0100
Michal Privoznik wrote:
> In a few places we report errno formatted as a negative integer.
> This is not as user friendly as it can be. Use strerror() and/or
> error_setg_errno() instead.
>
> Signed-off-by: Michal Privoznik
> ---
> hw/vfio/common.c| 2 +-
Thanks for your review. I will fix these errors in the next version(V3).
Due to migration data transfer using RDMA WRITE operation, we don't need to
receive data in the destination.
We only need to poll the CQE in the destination, so multifd_recv_thread() can't
be used directly.
-Original M
On 2/14/20 10:47 AM, Cornelia Huck wrote:
On Fri, 14 Feb 2020 09:47:39 +0100
Michal Privoznik wrote:
In a few places we report errno formatted as a negative integer.
This is not as user friendly as it can be. Use strerror() and/or
error_setg_errno() instead.
Signed-off-by: Michal Privoznik
-
In a few places we report errno formatted as a negative integer.
This is not as user friendly as it can be. Use strerror() and/or
error_setg_errno() instead.
Signed-off-by: Michal Privoznik
---
v1 posted here:
https://lists.nongnu.org/archive/html/qemu-devel/2020-02/msg03623.html
diff to v1:
> ehci-platform 1c1c000.usb: new USB bus registered, assigned bus number 2
> ehci-platform 1c1c000.usb: irq 31, io mem 0x01c1c000
> ehci-platform 1c1c000.usb: USB 2.0 started, EHCI 1.00
> +for (i = 0; i < ARRAY_SIZE(s->ehci); i++) {
> +object_property_set_bool(OBJECT(&s->ehci[i
On Fri, Feb 14, 2020 at 10:55:19AM +0100, Michal Privoznik wrote:
In a few places we report errno formatted as a negative integer.
This is not as user friendly as it can be. Use strerror() and/or
error_setg_errno() instead.
Signed-off-by: Michal Privoznik
---
v1 posted here:
https://lists.non
* Juan Quintela (quint...@redhat.com) wrote:
> It will be used later.
>
> Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
>
> ---
>
> No comp value needs to be zero.
> ---
> migration/migration.c | 9 ++
> migration/migration.h | 1 +
> migration/multifd.c | 185 +
On Sat, 8 Feb 2020 01:12:28 +0530
Kirti Wankhede wrote:
(...)
Minor wording nits:
> +/*
> + * Structure vfio_device_migration_info is placed at 0th offset of
"...at the 0th offset..."
> + * VFIO_REGION_SUBTYPE_MIGRATION region to get/set VFIO device related
> migration
> + * information. Fie
On Thu, 13 Feb 2020 at 09:07, Gerd Hoffmann wrote:
>
> The following changes since commit e18e5501d8ac692d32657a3e1ef545b14e72b730:
>
> Merge remote-tracking branch
> 'remotes/dgilbert-gitlab/tags/pull-virtiofs-20200210' into staging
> (2020-02-10 18:09:14 +)
>
> are available in the Git r
On Fri, Feb 14, 2020 at 07:25:43AM +, miaoyubo wrote:
>
> > -Original Message-
> > From: Daniel P. Berrangé [mailto:berra...@redhat.com]
> > Sent: Thursday, February 13, 2020 9:52 PM
> > To: miaoyubo
> > Cc: peter.mayd...@linaro.org; shannon.zha...@gmail.com;
> > imamm...@redhat.com;
* David Hildenbrand (da...@redhat.com) wrote:
> Resizing while migrating is dangerous and does not work as expected.
> The whole migration code works on the usable_length of ram blocks and does
> not expect this to change at random points in time.
>
> Precopy: The ram block size must not change on
On Thu, Feb 13, 2020 at 10:08:59PM +0100, Juan Quintela wrote:
> Daniel P. Berrangé wrote:
> > On Wed, Jan 29, 2020 at 12:56:53PM +0100, Juan Quintela wrote:
> >> Signed-off-by: Juan Quintela
> >> Reviewed-by: Dr. David Alan Gilbert
> >> ---
> >> configure | 30 ++
>
On 14.02.20 11:25, Dr. David Alan Gilbert wrote:
> * David Hildenbrand (da...@redhat.com) wrote:
>> Resizing while migrating is dangerous and does not work as expected.
>> The whole migration code works on the usable_length of ram blocks and does
>> not expect this to change at random points in tim
On Fri, 14 Feb 2020 10:55:19 +0100
Michal Privoznik wrote:
> In a few places we report errno formatted as a negative integer.
> This is not as user friendly as it can be. Use strerror() and/or
> error_setg_errno() instead.
>
> Signed-off-by: Michal Privoznik
> ---
>
> v1 posted here:
>
> http
* David Hildenbrand (da...@redhat.com) wrote:
> On 14.02.20 11:25, Dr. David Alan Gilbert wrote:
> > * David Hildenbrand (da...@redhat.com) wrote:
> >> Resizing while migrating is dangerous and does not work as expected.
> >> The whole migration code works on the usable_length of ram blocks and doe
On 14.02.20 11:42, Dr. David Alan Gilbert wrote:
> * David Hildenbrand (da...@redhat.com) wrote:
>> On 14.02.20 11:25, Dr. David Alan Gilbert wrote:
>>> * David Hildenbrand (da...@redhat.com) wrote:
Resizing while migrating is dangerous and does not work as expected.
The whole migration c
* David Hildenbrand (da...@redhat.com) wrote:
> On 14.02.20 11:42, Dr. David Alan Gilbert wrote:
> > * David Hildenbrand (da...@redhat.com) wrote:
> >> On 14.02.20 11:25, Dr. David Alan Gilbert wrote:
> >>> * David Hildenbrand (da...@redhat.com) wrote:
> Resizing while migrating is dangerous a
On 14.02.20 12:02, Dr. David Alan Gilbert wrote:
> * David Hildenbrand (da...@redhat.com) wrote:
>> On 14.02.20 11:42, Dr. David Alan Gilbert wrote:
>>> * David Hildenbrand (da...@redhat.com) wrote:
On 14.02.20 11:25, Dr. David Alan Gilbert wrote:
> * David Hildenbrand (da...@redhat.com) w
Hi Michal,
On 2/14/20 10:55 AM, Michal Privoznik wrote:
> In a few places we report errno formatted as a negative integer.
> This is not as user friendly as it can be. Use strerror() and/or
> error_setg_errno() instead.
>
> Signed-off-by: Michal Privoznik
Reviewed-by: Eric Auger
Thanks
Eric
>
On Sat, 8 Feb 2020 at 12:58, Richard Henderson
wrote:
>
> Include definitions for all of the bits in ID_MMFR3.
> We already have a definition for ID_AA64MMFR1.PAN.
>
> Reviewed-by: Alex Bennée
> Reviewed-by: Peter Maydell
> Signed-off-by: Richard Henderson
> @@ -3443,6 +3452,16 @@ static inli
* Muhui Jiang (jiangmu...@gmail.com) wrote:
> Dear All
>
> I am recently using qemu-system-arm to boot a linux uImage.
>
> I would like to do some dynamic instrumentation on the uncompressed kernel.
> It seems that I need to focus on two key points.
>
> Firstly, I need to know when the kernel is
On 2/13/20 9:27 PM, Keqian Zhu wrote:
At the tail stage of throttle, VM is very sensitive to
CPU percentage. We just throttle 30% of remaining CPU
when throttle is more than 80 percentage.
This doesn't conflict with cpu_throttle_increment.
This may make migration time longer, and is disabled
by
Hi Mark,
On Fri, Feb 14, 2020 at 9:48 AM Mark Cave-Ayland
wrote:
>
> Remove the call to pci_cmd646_ide_init() since global device init functions
> are deprecated in preference of using qdev directly.
>
> Signed-off-by: Mark Cave-Ayland
> ---
> hw/alpha/dp264.c | 8 +++-
> 1 file changed, 7
On Fri, 14 Feb 2020 13:29:00 +1100
David Gibson wrote:
> On Mon, Feb 03, 2020 at 11:36:22PM +0100, Greg Kurz wrote:
> > Hot unplugging a device is an asynchronous operation. If the guest is
> > migrated after the event was sent but before it could release the
> > device with RTAS, the destination
On Fri, Feb 14, 2020 at 10:20 AM Michal Privoznik wrote:
> On 2/14/20 9:47 AM, Michal Privoznik wrote:
> > In a few places we report errno formatted as a negative integer.
> > This is not as user friendly as it can be. Use strerror() and/or
> > error_setg_errno() instead.
> >
> > Signed-off-by: Mi
On Fri, Feb 14, 2020 at 10:56 AM Michal Privoznik wrote:
>
> In a few places we report errno formatted as a negative integer.
> This is not as user friendly as it can be. Use strerror() and/or
> error_setg_errno() instead.
>
> Signed-off-by: Michal Privoznik
> ---
Reviewed-by: Philippe Mathieu-D
On 14.02.20 12:08, David Hildenbrand wrote:
> On 14.02.20 12:02, Dr. David Alan Gilbert wrote:
>> * David Hildenbrand (da...@redhat.com) wrote:
>>> On 14.02.20 11:42, Dr. David Alan Gilbert wrote:
* David Hildenbrand (da...@redhat.com) wrote:
> On 14.02.20 11:25, Dr. David Alan Gilbert wro
On Thu, Feb 13, 2020 at 11:51 PM Alex Bennée wrote:
>
> This still seems to be a problem for Travis.
>
> Signed-off-by: Alex Bennée
> ---
> .travis.yml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index 0612998958b..f4020dcc6c8 100644
>
Peter Maydell writes:
> On Fri, 14 Feb 2020 at 06:33, Markus Armbruster wrote:
>>
>> Does not work out of the box on my Fedora 30 build host, where
>> sphinx-build gives me sphinx-build-2. I have to specify
>> --sphinx-build=/usr/bin/sphinx-build-3 to unbreak it. Which of course
>> breaks thin
* Keqian Zhu (zhukeqi...@huawei.com) wrote:
> At the tail stage of throttle, VM is very sensitive to
> CPU percentage. We just throttle 30% of remaining CPU
> when throttle is more than 80 percentage.
This is a bit unusual; all of the rest of the throttling has no
fixed constants; all values are
Peter Maydell writes:
> The texinfo doc generation doesn't care much about indentation
Let's spell Texinfo with a capital T.
> levels, but we would like to add a rST backend, and rST does care
> about indentation.
Nitpick: an rST *backend* should not care about the doc generator's
*input* form
Keqian Zhu wrote:
> At the tail stage of throttle, VM is very sensitive to
> CPU percentage. We just throttle 30% of remaining CPU
> when throttle is more than 80 percentage.
Why?
If we really think that this is better that current approarch, just do
this _always_. And throothre 30% of remainin
On Fri, 14 Feb 2020 at 12:20, Markus Armbruster wrote:
>
> Peter Maydell writes:
> >> # Default objcc to clang if available, otherwise use CC
> >> @@ -4803,7 +4816,7 @@ has_sphinx_build() {
> >> # sphinx-build doesn't exist at all or if it is too old.
> >> mkdir -p "$TMPDIR1/sphinx"
>
On Fri, 14 Feb 2020 at 12:36, Markus Armbruster wrote:
>
> Peter Maydell writes:
>
> > The texinfo doc generation doesn't care much about indentation
>
> Let's spell Texinfo with a capital T.
>
> > levels, but we would like to add a rST backend, and rST does care
> > about indentation.
>
> Nitpic
Peter Maydell writes:
> rST format requires a blank line before the start of a bulleted
> or enumerated list. Two places in qapi-schema.json were missing
> this blank line.
Relies on the previous commit message's "we would like to add a rST
backend" to establish context. Suggest:
We would li
David Hildenbrand wrote:
I agree with the removed bits.
> diff --git a/migration/ram.c b/migration/ram.c
> index ed23ed1c7c..f86f32b453 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -52,6 +52,7 @@
> #include "migration/colo.h"
> #include "block.h"
> #include "sysemu/sysemu.h"
>
Am 13.02.2020 um 18:16 hat Alberto Garcia geschrieben:
> I/O requests to encrypted media should be aligned to the sector size
> used by the underlying encryption method, not to BDRV_SECTOR_SIZE.
> Fortunately this doesn't break anything at the moment because
> both existing QCRYPTO_BLOCK_*_SECTOR_S
Peter Maydell writes:
> The ascii-art graph in the BlockLatencyHistogramInfo documentation
> doesn't render correctly, because the whitespace is collapsed.
>
> Use the '|' format that emits a literal 'example' block so the graph
> is displayed correctly.
>
> Strictly the texinfo generated is stil
Peter Maydell writes:
> Some qapi doc comments have forgotten the ':' after the
> @argument, like this:
>
> # @filename Filename for the new image file
> # @size Size of the virtual disk in bytes
>
> The result is that these are parsed as part of the body
> text and appear as
* David Hildenbrand (da...@redhat.com) wrote:
> On 12.02.20 14:42, David Hildenbrand wrote:
> > We already allow resizable ram blocks for anonymous memory, however, they
> > are not actually resized. All memory is mmaped() R/W, including the memory
> > exceeding the used_length, up to the max_lengt
Am 09.02.2020 um 18:51 hat Hikaru Nishida geschrieben:
> Before this commit, BDRVVVFATState.qcow is unrefed in write_target_close
> on closing backing bdrv of vvfat. However, qcow bdrv is opend as a child
> of vvfat in enable_write_target() so it will be also unrefed on closing
> vvfat itself. This
Peter Maydell writes:
> On Fri, 7 Feb 2020 at 08:33, Markus Armbruster wrote:
>>
>> Peter Maydell writes:
>>
>> > rST format requires a blank line before the start of a bulleted
>> > or enumerated list. Two places in qapi-schema.json were missing
>> > this blank line.
>> >
>> > Some places were
Public bug reported:
On AArch64 CPU with SVE register, there seems to be a bug in the
operation when executing EXT instruction to V registers. Bits above the
128 bits of the SVE register must be cleared to 0, but qemu-aarch64
seems to hold the value.
Example
ext v0.16b, v1.16b v2.16b, 8
After ex
This patch series implements the mask for un-implemented priority bits
in arm-gic. Which will return the expected number of priority bits on
read.
Sai Pavan Boddu (3):
arm_gic: Mask the un-supported priority bits
cpu/a9mpcore: Add num priority bits property
arm/xilinx_zynq: Set number of pri
Priority bits implemented in arm-gic can 8 to 4, un-implemented bits
are read as zeros(RAZ).
Signed-off-by: Sai Pavan Boddu
---
hw/intc/arm_gic.c| 9 ++---
hw/intc/arm_gic_common.c | 1 +
include/hw/intc/arm_gic_common.h | 1 +
3 files changed, 8 insertions(+), 3 dele
Set number of priority bits property of gic as guided by machine
configuration.
Signed-off-by: Sai Pavan Boddu
---
hw/cpu/a9mpcore.c | 2 ++
include/hw/cpu/a9mpcore.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/hw/cpu/a9mpcore.c b/hw/cpu/a9mpcore.c
index 1f8bc8a..eb1e752 100644
Make sure that it compiles OK with RDMA compiled out; I think this is a
windows cross build that's failing, but more generally even a Linux box
with no-RDMA libraries.
Dave
* no-re...@patchew.org (no-re...@patchew.org) wrote:
> Patchew URL:
> https://patchew.org/QEMU/20200213093755.370-1-fengzhi
Arm GIC in Zynq SOC implements 5 priority bits i.e bits 7..3.
Signed-off-by: Sai Pavan Boddu
---
hw/arm/xilinx_zynq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c
index 3a0fa5b..7aa43ad 100644
--- a/hw/arm/xilinx_zynq.c
+++ b/hw/arm/xilinx_zynq.
Am 11.02.2020 um 10:48 hat Kevin Wolf geschrieben:
> Kevin Wolf (3):
> qcow2: update_refcount(): Reset old_table_index after
> qcow2_cache_put()
> qcow2: Fix qcow2_alloc_cluster_abort() for external data file
> iotests: Test copy offloading with external data file
Applied to the block br
Hi Marc-Andre,
On Tue, 2020-02-11 at 22:24 +0100, Marc-André Lureau wrote:
> Hi
>
> On Tue, Feb 11, 2020 at 4:24 PM Boeuf, Sebastien
> wrote:
> > From c073d528b8cd7082832fd1825dc33dd65b305aa2 Mon Sep 17 00:00:00
> > 2001
> > From: Sebastien Boeuf
> > Date: Tue, 11 Feb 2020 16:01:22 +0100
> > Su
This series implements the QEMU virtio-iommu device.
This matches the v0.12 spec (voted) and the corresponding
virtio-iommu driver upstreamed in 5.3. All kernel dependencies
are resolved for DT integration. The virtio-iommu can be
instantiated in ARM virt using:
"-device virtio-iommu-pci".
Non D
This patch adds the command payload decoding and
introduces the functions that will do the actual
command handling. Those functions are not yet implemented.
Signed-off-by: Eric Auger
Reviewed-by: Jean-Philippe Brucker
Reviewed-by: Peter Xu
Reviewed-by: Michael S. Tsirkin
---
v11 -> v12:
- AD
This patch implements the translate callback
Signed-off-by: Eric Auger
Reviewed-by: Jean-Philippe Brucker
Reviewed-by: Michael S. Tsirkin
---
v11 -> v12:
- Added Jean's R-b
- s/qemu_log_mask/error_report_once
v10 -> v11:
- take into account the new value struct and use
g_tree_lookup_extend
The event queue allows to report asynchronous errors.
The translate function now injects faults when relevant.
Signed-off-by: Eric Auger
Reviewed-by: Peter Xu
Reviewed-by: Michael S. Tsirkin
---
v13 -> v14:
- remove loop
- add Peter's R-b
v12 -> v13:
- return on virtio_error()
v11 -> v12:
-
This patch implements the endpoint attach/detach to/from
a domain.
Domain and endpoint internal datatypes are introduced.
Both are stored in RB trees. The domain owns a list of
endpoints attached to it. Also helpers to get/put
end points and domains are introduced.
As for the IOMMU memory regions
This patchs adds the skeleton for the virtio-iommu device.
Signed-off-by: Eric Auger
Reviewed-by: Peter Xu
Reviewed-by: Michael S. Tsirkin
---
v13 -> v14:
- use device_class_set_props
- updated copyright's year
v12 -> v13
- removed IOMMU_PCI_BUS_MAX and IOMMU_PCI_DEVFN_MAX
v11 -> v12:
- rem
This patch implements virtio_iommu_map/unmap.
Signed-off-by: Eric Auger
Reviewed-by: Peter Xu
Reviewed-by: Michael S. Tsirkin
---
v11 -> v12:
- check unmanaged managed flags on map
- removed 2 qemu_log_mask in unmap()
- fix leak
v10 -> v11:
- revisit the implementation of unmap according to
Markus Armbruster writes:
> Peter Maydell writes:
>
>> Some qapi doc comments have forgotten the ':' after the
>> @argument, like this:
>>
>> # @filename Filename for the new image file
>> # @size Size of the virtual disk in bytes
>>
>> The result is that these are parsed as
Add Migration support. We rely on recently added gtree and qlist
migration. We only migrate the domain gtree. The endpoint gtree
is re-constructed in a post-load operation.
Signed-off-by: Eric Auger
Acked-by: Peter Xu
Reviewed-by: Juan Quintela
Reviewed-by: Michael S. Tsirkin
---
v15 -> v16:
This patch adds virtio-iommu-pci, which is the pci proxy for
the virtio-iommu device.
Currently non DT integration is not yet supported by the kernel.
So the machine must implement a hotplug handler for the
virtio-iommu-pci device that creates the device tree iommu-map
bindings as documented in ke
Add a new "virtio-iommu" section with the new files
related to this device.
Signed-off-by: Eric Auger
---
MAINTAINERS | 6 ++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index c7717df720..b7a7a18737 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1623,6 +1623,12 @@
Adds the "virtio,pci-iommu" node in the host bridge node and
the RID mapping, excluding the IOMMU RID.
This is done in the virtio-iommu-pci hotplug handler which
gets called only if no firmware is loaded or if -no-acpi is
passed on the command line. As non DT integration is
not yet supported by th
Peter Maydell writes:
> The texinfo doc generation doesn't care much about indentation
> levels, but we would like to add a rST backend, and rST does care
> about indentation.
>
> Make the doc comments more strongly consistent about indentation
> for multiline constructs like:
>
> @arg: descripti
>> diff --git a/migration/ram.c b/migration/ram.c
>> index ed23ed1c7c..f86f32b453 100644
>> --- a/migration/ram.c
>> +++ b/migration/ram.c
>> @@ -52,6 +52,7 @@
>> #include "migration/colo.h"
>> #include "block.h"
>> #include "sysemu/sysemu.h"
>> +#include "sysemu/runstate.h"
>> #include "save
Hi
On Fri, Feb 14, 2020 at 2:24 PM Boeuf, Sebastien
wrote:
>
> Hi Marc-Andre,
>
> On Tue, 2020-02-11 at 22:24 +0100, Marc-André Lureau wrote:
> > Hi
> >
> > On Tue, Feb 11, 2020 at 4:24 PM Boeuf, Sebastien
> > wrote:
> > > From c073d528b8cd7082832fd1825dc33dd65b305aa2 Mon Sep 17 00:00:00
> > > 2
Peter Maydell writes:
> A JSON block comment like this:
> Returns: nothing on success
> If @node is not a valid block device, DeviceNotFound
> If @name is not found, GenericError with an explanation
>
> renders like this:
>
> Returns: nothing on success If node is not a vali
On Fri, Feb 14, 2020 at 03:00:34PM +0100, Marc-André Lureau wrote:
> Hi
>
> On Fri, Feb 14, 2020 at 2:24 PM Boeuf, Sebastien
> wrote:
> >
> > Hi Marc-Andre,
> >
> > On Tue, 2020-02-11 at 22:24 +0100, Marc-André Lureau wrote:
> > > Hi
> > >
> > > On Tue, Feb 11, 2020 at 4:24 PM Boeuf, Sebastien
>
Peter Maydell writes:
> A JSON block comment like this:
> Returns: nothing on success
> If @node is not a valid block device, DeviceNotFound
> If @name is not found, GenericError with an explanation
>
> renders like this:
>
> Returns: nothing on success If no
Peter Maydell writes:
> On Fri, 14 Feb 2020 at 12:36, Markus Armbruster wrote:
>>
>> Peter Maydell writes:
>>
>> > The texinfo doc generation doesn't care much about indentation
>>
>> Let's spell Texinfo with a capital T.
>>
>> > levels, but we would like to add a rST backend, and rST does care
On 2/14/20 2:08 AM, Gerd Hoffmann wrote:
ehci-platform 1c1c000.usb: new USB bus registered, assigned bus number 2
ehci-platform 1c1c000.usb: irq 31, io mem 0x01c1c000
ehci-platform 1c1c000.usb: USB 2.0 started, EHCI 1.00
+for (i = 0; i < ARRAY_SIZE(s->ehci); i++) {
+object_
On Fri, 14 Feb 2020 at 14:23, Markus Armbruster wrote:
> What's the rationale for the split between
>
> [PATCH v2 13/30] qapi/block-core.json: Use explicit bulleted lists
> [PATCH v2 14/30] qapi/ui.json: Use explicit bulleted lists
> [PATCH v2 15/30] qapi/{block, misc, tmp, net}.json:
** Tags added: tcg
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1863025
Title:
Use-after-free after flush in TCG accelerator
Status in QEMU:
Confirmed
Bug description:
I believe I found a UA
Markus Armbruster writes:
> Peter Maydell writes:
>
>> rST format requires a blank line before the start of a bulleted
>> or enumerated list. Two places in qapi-schema.json were missing
>> this blank line.
>
> Relies on the previous commit message's "we would like to add a rST
> backend" to esta
Peter Maydell writes:
> rST insists on a blank line before and after a bulleted list,
> but our texinfo doc generator did not. Add some extra blank
> lines in the doc comments so they're acceptable rST input.
>
> Signed-off-by: Peter Maydell
> Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: M
Peter Maydell writes:
> The MigrationInfo::setup-time documentation is the only place where
> we use _this_ inline markup for emphasis, commonly rendered in
> italics. rST doesn't recognize that markup and emits literal
> underscores.
>
> Switch to *this* instead. Changes markup to strong empha
** Changed in: qemu
Assignee: (unassigned) => Alex Bennée (ajbennee)
** Changed in: qemu
Status: New => Confirmed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1863025
Title:
Use-after
The bug describes a race whereby cpu_exec_step_atomic can acquire a TB
which is invalidated by a tb_flush before we execute it. This doesn't
affect the other cpu_exec modes as a tb_flush by it's nature can only
occur on a quiescent system. The race was described as:
B2. tcg_cpu_exec => cpu_exec
This series adds a new migration test through RDMA and provides new
functions to it.
The last update by mistake was not provided a full scenario to the EXEC
migration test. One of patch fixed it.
Oksana Vohchana (4):
Acceptance test: add address as param
Acceptance test: EXEC migration
Accep
Adds functions to check if service RDMA is enabled and gets the interface
where it was configured
Signed-off-by: Oksana Vohchana
---
tests/acceptance/migration.py | 17 +
1 file changed, 17 insertions(+)
diff --git a/tests/acceptance/migration.py b/tests/acceptance/migration.py
Improves EXEC migration to run whole test stage
Signed-off-by: Oksana Vohchana
---
tests/acceptance/migration.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/acceptance/migration.py b/tests/acceptance/migration.py
index e4c39b85a1..8209dcf71d 100644
--- a/tests/acceptance/migratio
Provides param address in _get_free_port()
because by default it takes free port only on the localhost
Signed-off-by: Oksana Vohchana
---
tests/acceptance/migration.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/acceptance/migration.py b/tests/acceptance/migrati
Adds test for RDMA migration check
Signed-off-by: Oksana Vohchana
---
tests/acceptance/migration.py | 8
1 file changed, 8 insertions(+)
diff --git a/tests/acceptance/migration.py b/tests/acceptance/migration.py
index bbd88f8dda..c0a3031e67 100644
--- a/tests/acceptance/migration.py
++
I've attached a variant of the suggested patch which simply expands the
exclusive period. It's hard to test extensively as not many things use
the EXCP_ATOMIC mechanism. Can I ask how you found the bug and if you
can re-test with the suggested patch?
--
You received this bug notification because
We currently don't support hotplug of devices between boot and CAS. If
this happens a CAS reboot is triggered. We detect this during CAS using
the spapr_drc_needed() function which is essentially a VMStateDescription
.needed callback. Even if the condition for CAS reboot happens to be the
same as f
While working on getting rid of CAS reboot, I realized that we currently
don't handle device hot unplug properly in the following situations:
1) if the device is unplugged between boot and CAS, SLOF doesn't handle
the even, which is a known limitation. The device hence stays around
forever (
On 2/14/20 1:26 AM, Peter Maydell wrote:
On Fri, 14 Feb 2020 at 06:05, Guenter Roeck wrote:
USB ports must be instantiated as TYPE_CHIPIDEA to work.
Linux expects and checks various chipidea registers, which
do not exist with the basic ehci emulation.
Hi; I didn't see a cover letter email fo
We already detect if a device is being hot plugged before CAS to trigger
a CAS reboot and during migration to migrate the state of the associated
DRC. But hot unplugging a device is also an asynchronous operation that
requires the guest to take action. This means that if the guest is migrated
after
Markus Armbruster writes:
> Peter Maydell writes:
>
>> A handful of QAPI doc comments include lines like
>> "ppcemb: dropped in 3.1". The doc comment parser will just
>> put these into whatever the preceding section was; sometimes
>> that's "Notes", and sometimes it's some random other section,
* David Hildenbrand (da...@redhat.com) wrote:
>
> >> diff --git a/migration/ram.c b/migration/ram.c
> >> index ed23ed1c7c..f86f32b453 100644
> >> --- a/migration/ram.c
> >> +++ b/migration/ram.c
> >> @@ -52,6 +52,7 @@
> >> #include "migration/colo.h"
> >> #include "block.h"
> >> #include "sysem
1 - 100 of 270 matches
Mail list logo
