Re: [PATCH] qapi: Expand documentation for LostTickPolicy

2020-02-13 Thread Andrew Jones
On Tue, Feb 11, 2020 at 07:37:44PM +0100, Andrea Bolognani wrote: > The current documentation is fairly terse and not easy to decode > for someone who's not intimately familiar with the inner workings > of timer devices. Expand on it by providing a somewhat verbose > description of what behavior ea

Re: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback

2020-02-13 Thread David Hildenbrand
On 13.02.20 17:38, Shameerali Kolothum Thodi wrote: > > >> -Original Message- >> From: David Hildenbrand [mailto:da...@redhat.com] >> Sent: 12 February 2020 18:21 >> To: Shameerali Kolothum Thodi ; >> Igor Mammedov >> Cc: peter.mayd...@linaro.org; xiaoguangrong.e...@gmail.com; >> m...@re

Re: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback

2020-02-13 Thread David Hildenbrand
On 13.02.20 17:59, David Hildenbrand wrote: > On 13.02.20 17:38, Shameerali Kolothum Thodi wrote: >> >> >>> -Original Message- >>> From: David Hildenbrand [mailto:da...@redhat.com] >>> Sent: 12 February 2020 18:21 >>> To: Shameerali Kolothum Thodi ; >>> Igor Mammedov >>> Cc: peter.mayd...@

[PATCH] qcow2: Fix alignment checks in encrypted images

2020-02-13 Thread Alberto Garcia
I/O requests to encrypted media should be aligned to the sector size used by the underlying encryption method, not to BDRV_SECTOR_SIZE. Fortunately this doesn't break anything at the moment because both existing QCRYPTO_BLOCK_*_SECTOR_SIZE have the same value as BDRV_SECTOR_SIZE. The checks in qco

[PATCH RFC] memory: Don't allow to resize RAM while migrating

2020-02-13 Thread David Hildenbrand
Resizing while migrating is dangerous and does not work as expected. The whole migration code works on the usable_length of ram blocks and does not expect this to change at random points in time. Precopy: The ram block size must not change on the source, after ram_save_setup(), so as long as the g

Re: [PULL 0/2] Usb 20200212 patches

2020-02-13 Thread Peter Maydell
On Wed, 12 Feb 2020 at 21:00, Gerd Hoffmann wrote: > > The following changes since commit e18e5501d8ac692d32657a3e1ef545b14e72b730: > > Merge remote-tracking branch > 'remotes/dgilbert-gitlab/tags/pull-virtiofs-20200210' into staging > (2020-02-10 18:09:14 +) > > are available in the Git r

Mapping between Host virtual address and guest physical address

2020-02-13 Thread Muhui Jiang
Dear All I am recently using qemu-system-arm to boot a linux uImage. I would like to do some dynamic instrumentation on the uncompressed kernel. It seems that I need to focus on two key points. Firstly, I need to know when the kernel is uncompressed, which means the compression process is finish

Re: [PATCH] qcow2: Fix alignment checks in encrypted images

2020-02-13 Thread Daniel P . Berrangé
On Thu, Feb 13, 2020 at 06:16:46PM +0100, Alberto Garcia wrote: > I/O requests to encrypted media should be aligned to the sector size > used by the underlying encryption method, not to BDRV_SECTOR_SIZE. > Fortunately this doesn't break anything at the moment because > both existing QCRYPTO_BLOCK_*

[PATCH v2 00/30] Convert QAPI doc comments to generate rST instead of texinfo

2020-02-13 Thread Peter Maydell
This series switches all our QAPI doc comments over from texinfo format to rST. Changes v1->v2: * rebased (a few minor conflicts fixed) * I have fixed the failures to pass "make check" * minor tweaks to commit messages etc (noted in individual patches) * the old patch 12 ('qapi: Explicitly p

[PATCH v2 01/30] configure: Allow user to specify sphinx-build binary

2020-02-13 Thread Peter Maydell
Currently we insist on using 'sphinx-build' from the $PATH; allow the user to specify the binary to use. This will be more useful as we become pickier about the capabilities we require (eg needing a Python 3 sphinx-build). Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée Reviewed-by: Wainer

[PATCH v2 10/30] qapi: Remove hardcoded tabs

2020-02-13 Thread Peter Maydell
There are some stray hardcoded tabs in some of our json files; remove them. Signed-off-by: Peter Maydell Reviewed-by: Markus Armbruster --- Most of the hardcoded tabs got removed in passing in fixing the indent in lines that they were in, but these are not part of doc comments. --- qapi/block-c

[PATCH v2 02/30] configure: Check that sphinx-build is using Python 3

2020-02-13 Thread Peter Maydell
Currently configure's has_sphinx_build() check simply runs a dummy sphinx-build and either passes or fails. This means that "no sphinx-build at all" and "sphinx-build exists but is too old" are both reported the same way. Further, we want to assume that all the Python we write is running with at

[PATCH v2 03/30] Makefile: Fix typo in dependency list for interop manpages

2020-02-13 Thread Peter Maydell
Fix a typo in the dependency list for the manpages built from the 'interop' manual, which meant we were accidentally not including the .hx file in the dependency list. Fixes: e13c59fa4414215500e6 Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé --- Makefile | 2 +- 1 file change

[PATCH v2 11/30] qapi/ui.json: Put input-send-event body text in the right place

2020-02-13 Thread Peter Maydell
In the doc comment for input-send-event, there is a multi-line chunk of text ("The @device...take precedence") which is intended to be the main body text describing the event. However it has been placed after the arguments and Returns: section, which means that the parser actually thinks that this

[PATCH v2 07/30] qapi/block-core.json: Use literal block for ascii art

2020-02-13 Thread Peter Maydell
The ascii-art graph in the BlockLatencyHistogramInfo documentation doesn't render correctly, because the whitespace is collapsed. Use the '|' format that emits a literal 'example' block so the graph is displayed correctly. Strictly the texinfo generated is still wrong because each line goes into

[PATCH v2 04/30] qga/qapi-schema.json: Fix missing '-' in GuestDiskBusType doc comment

2020-02-13 Thread Peter Maydell
The doc comment for GuestDiskBusType doesn't match up with the enumeration because of a missing hyphen in 'file-backed-virtual'. This means the docs are rendered wrongly: "virtual" Win virtual bus type "file-backed" virtual: Win file-backed bus type "file-backed-virtual"

[PATCH v2 05/30] qga/qapi-schema.json: Fix indent level on doc comments

2020-02-13 Thread Peter Maydell
The texinfo doc generation doesn't care much about indentation levels, but we would like to add a rST backend, and rST does care about indentation. Make the doc comments more strongly consistent about indentation for multiline constructs like: @arg: description line 1 description line 2 Re

[PATCH v2 12/30] qapi/ui.json: Avoid `...' texinfo style quoting

2020-02-13 Thread Peter Maydell
Avoid texinfo style quoting with `...', because rST treats it as a syntax error. Use '...' instead, as we do in other doc comments. This looks OK in texinfo, and rST formats it as paired-quotation-marks. Signed-off-by: Peter Maydell Reviewed-by: Markus Armbruster --- qapi/ui.json | 24 +

[PATCH v2 15/30] qapi/{block, misc, tmp, net}.json: Use explicit bulleted lists

2020-02-13 Thread Peter Maydell
A JSON block comment like this: Returns: nothing on success If @node is not a valid block device, DeviceNotFound If @name is not found, GenericError with an explanation renders like this: Returns: nothing on success If node is not a valid block device, D

[PATCH v2 14/30] qapi/ui.json: Use explicit bulleted lists

2020-02-13 Thread Peter Maydell
A JSON block comment like this: Returns: nothing on success If @node is not a valid block device, DeviceNotFound If @name is not found, GenericError with an explanation renders like this: Returns: nothing on success If node is not a valid block device, DeviceNotFound If nam

[PATCH v2 08/30] qapi: Use ':' after @argument in doc comments

2020-02-13 Thread Peter Maydell
Some qapi doc comments have forgotten the ':' after the @argument, like this: # @filename Filename for the new image file # @size Size of the virtual disk in bytes The result is that these are parsed as part of the body text and appear as a run-on line: filename Filename for

[PATCH v2 19/30] qapi/qapi-schema.json: Put headers in their own doc-comment blocks

2020-02-13 Thread Peter Maydell
Our current QAPI doc-comment markup allows section headers (introduced with a leading '=' or '==') anywhere in any documentation comment. This works for texinfo because the texi generator simply prints a texinfo heading directive at that point in the output stream. For rST generation, since we're

[PATCH v2 25/30] docs/interop: Convert qemu-ga-ref to rST

2020-02-13 Thread Peter Maydell
Convert qemu-ga-ref to rST format. This includes dropping the plain-text, pdf and info format outputs for this document; as with all our other Sphinx-based documentation, we provide HTML and manpage only. The qemu-ga-ref.rst is somewhat more stripped down than the .texi was, because we do not (cur

[PATCH v2 18/30] qapi: Delete all the "foo: dropped in n.n" notes

2020-02-13 Thread Peter Maydell
A handful of QAPI doc comments include lines like "ppcemb: dropped in 3.1". The doc comment parser will just put these into whatever the preceding section was; sometimes that's "Notes", and sometimes it's some random other section, as with "NetClientDriver" where the "'dump': dropped in 2.12" line

[PATCH v2 06/30] qga/qapi-schema.json: minor format fixups for rST

2020-02-13 Thread Peter Maydell
rST format requires a blank line before the start of a bulleted or enumerated list. Two places in qapi-schema.json were missing this blank line. Some places were using an indented line as a sort of single-item bulleted list, which in the texinfo output comes out all run onto a single line; use a r

[PATCH v2 27/30] qapi: Use rST markup for literal blocks

2020-02-13 Thread Peter Maydell
There are exactly two places in our json doc comments where we use the markup accepted by the texi doc generator where a '|' in the first line of a doc comment means the line should be emitted as a literal block (fixed-width font, whitespace preserved). Since we use this syntax so rarely, instead

[PATCH v2 21/30] tests/qapi/doc-good.json: Clean up markup

2020-02-13 Thread Peter Maydell
doc-good.json tests some oddities of markup that we don't want to accept. Make them match the more restrictive rST syntax: * in a single list the bullet types must all match * lists must have leading and following blank lines * indentation is important * the '|' example syntax is going to go

[PATCH v2 28/30] qga/qapi-schema.json: Add some headings

2020-02-13 Thread Peter Maydell
Add some section headings to the QGA json; this is purely so that we have some H1 headings, as otherwise each command ends up being visible in the interop/ manual's table of contents. In an ideal world there might be a proper 'Introduction' section the way there is in qapi/qapi-schema.json. Signe

[PATCH v2 29/30] scripts/qapi: Remove texinfo generation support

2020-02-13 Thread Peter Maydell
We no longer use the generated texinfo format documentation, so delete the code that generates it, and the test case for the generation. Signed-off-by: Peter Maydell --- Makefile| 1 - tests/Makefile.include | 15 +- scripts/qapi-gen.py | 2 - sc

[PATCH v2 13/30] qapi/block-core.json: Use explicit bulleted lists

2020-02-13 Thread Peter Maydell
A JSON block comment like this: Returns: nothing on success If @node is not a valid block device, DeviceNotFound If @name is not found, GenericError with an explanation renders like this: Returns: nothing on success If node is not a valid block device, DeviceNotFound If nam

[PATCH v2 09/30] qapi: Fix indent level on doc comments in json files

2020-02-13 Thread Peter Maydell
The texinfo doc generation doesn't care much about indentation levels, but we would like to add a rST backend, and rST does care about indentation. Make the doc comments more strongly consistent about indentation for multiline constructs like: @arg: description line 1 description line 2 Re

[PATCH v2 23/30] scripts/qapi/parser.py: improve doc comment indent handling

2020-02-13 Thread Peter Maydell
Make the handling of indentation in doc comments more sophisticated, so that when we see a section like: Notes: some text some more text indented line 3 we save it for the doc-comment processing code as: some text some more text indented line 3 and when we see a section with

[PATCH v2 16/30] qapi: Add blank lines before bulleted lists

2020-02-13 Thread Peter Maydell
rST insists on a blank line before and after a bulleted list, but our texinfo doc generator did not. Add some extra blank lines in the doc comments so they're acceptable rST input. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé --- qapi/block-core.json | 1 + qapi/char.json

[PATCH v2 24/30] docs/sphinx: Add new qapi-doc Sphinx extension

2020-02-13 Thread Peter Maydell
Some of our documentation is auto-generated from documentation comments in the JSON schema. For Sphinx, rather than creating a file to include, the most natural way to handle this is to have a small custom Sphinx extension which processes the JSON file and inserts documentation into the rST file b

[PATCH v2 17/30] qapi/migration.json: Replace _this_ with *this*

2020-02-13 Thread Peter Maydell
The MigrationInfo::setup-time documentation is the only place where we use _this_ inline markup for emphasis, commonly rendered in italics. rST doesn't recognize that markup and emits literal underscores. Switch to *this* instead. Changes markup to strong emphasis with Texinfo, commonly rendered

[PATCH v2 26/30] docs/interop: Convert qemu-qmp-ref to rST

2020-02-13 Thread Peter Maydell
Convert qemu-qmp-ref to rST format. This includes dropping the plain-text, pdf and info format outputs for this document; as with all our other Sphinx-based documentation, we provide HTML and manpage only. The qemu-qmp-ref.rst is somewhat more stripped down than the .texi was, because we do not (c

[PATCH v4 01/16] hw/i386: Rename X86CPUTopoInfo structure to X86CPUTopoIDs

2020-02-13 Thread Babu Moger
Rename few data structures related to X86 topology. X86CPUTopoIDs will have individual arch ids. Next patch introduces X86CPUTopoInfo which will have all topology information(like cores, threads etc..). Signed-off-by: Babu Moger Reviewed-by: Eduardo Habkost --- hw/i386/pc.c | 4

[PATCH v4 03/16] hw/i386: Consolidate topology functions

2020-02-13 Thread Babu Moger
Now that we have all the parameters in X86CPUTopoInfo, we can just pass the structure to calculate the offsets and width. Signed-off-by: Babu Moger Reviewed-by: Igor Mammedov --- include/hw/i386/topology.h | 64 ++-- target/i386/cpu.c | 23 ++

[PATCH v2 22/30] scripts/qapi: Move doc-comment whitespace stripping to doc.py

2020-02-13 Thread Peter Maydell
As we accumulate lines from doc comments when parsing the JSON, the QAPIDoc class generally strips leading and trailing whitespace using line.strip() when it calls _append_freeform(). This is fine for texinfo, but for rST leading whitespace is significant. We'd like to move to having the text in

[PATCH v2 30/30] docs/devel/qapi-code-gen.txt: Update to new rST backend conventions

2020-02-13 Thread Peter Maydell
Update the documentation of QAPI document comment syntax to match the new rST backend requirements. The principal changes are: * whitespace is now significant, and multiline definitions must have their second and subsequent lines indented to match the first line * general rST format markup

[PATCH v2 20/30] qapi/machine.json: Escape a literal '*' in doc comment

2020-02-13 Thread Peter Maydell
For rST, '*' is a kind of inline markup (for emphasis), so "*-softmmu" is a syntax error because of the missing closing '*'. Escape the '*' with a '\'. The texinfo document generator will leave the '\' in the output, which is not ideal, but that generator is going to go away in a subsequent commit

[PATCH v4 00/16] APIC ID fixes for AMD EPYC CPU model

2020-02-13 Thread Babu Moger
This series fixes APIC ID encoding problem reported on AMD EPYC cpu model. https://bugzilla.redhat.com/show_bug.cgi?id=1728166 Currently, the APIC ID is decoded based on the sequence sockets->dies->cores->threads. This works for most standard AMD and other vendors' configurations, but this decodin

[PATCH v4 04/16] hw/i386: Introduce init_topo_info to initialize X86CPUTopoInfo

2020-02-13 Thread Babu Moger
Initialize all the parameters in one function init_topo_info. Move the data structure X86CPUTopoIDs and X86CPUTopoInfo into x86.h. Signed-off-by: Babu Moger Reviewed-by: Eduardo Habkost --- hw/i386/pc.c |4 +--- hw/i386/x86.c | 14 +++--- include/hw/i38

[PATCH v4 05/16] machine: Add SMP Sockets in CpuTopology

2020-02-13 Thread Babu Moger
Store the smp sockets in CpuTopology. The socket information required to build the apic id in EPYC mode. Right now socket information is not passed to down when decoding the apic id. Add the socket information here. Signed-off-by: Babu Moger Reviewed-by: Eduardo Habkost --- hw/core/machine.c

[PATCH v4 06/16] hw/i386: Update structures for nodes_per_pkg

2020-02-13 Thread Babu Moger
Update structures X86CPUTopoIDs and CPUX86State to hold the nodes_per_pkg. This is required to build EPYC mode topology. Signed-off-by: Babu Moger --- hw/i386/pc.c |1 + hw/i386/x86.c |2 ++ include/hw/i386/topology.h |2 ++ include/hw/i386/x86.h |

Re: [PATCH] pc-bios/s390x: Pack ResetInfo struct

2020-02-13 Thread Jason J. Herne
On 2/6/20 5:09 AM, Christian Borntraeger wrote: On 05.02.20 19:21, Jason J. Herne wrote: This fixes vfio-ccw when booting non-Linux operating systems. Without this struct being packed, a few extra bytes of low core memory get overwritten when we assign a value to memory address 0 in jump_to_I

[PATCH v4 07/16] hw/i386: Rename apicid_from_topo_ids to x86_apicid_from_topo_ids

2020-02-13 Thread Babu Moger
For consistancy rename apicid_from_topo_ids to x86_apicid_from_topo_ids. No functional change. Signed-off-by: Babu Moger --- hw/i386/pc.c |2 +- include/hw/i386/topology.h |6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c

[PATCH v4 02/16] hw/i386: Introduce X86CPUTopoInfo to contain topology info

2020-02-13 Thread Babu Moger
This is an effort to re-arrange few data structure for better readability. Add X86CPUTopoInfo which will have all the topology informations required to build the cpu topology. There is no functional changes. Signed-off-by: Babu Moger Reviewed-by: Igor Mammedov --- hw/i386/pc.c |

[PATCH v4 08/16] hw/386: Add EPYC mode topology decoding functions

2020-02-13 Thread Babu Moger
These functions add support for building EPYC mode topology given the smp details like numa nodes, cores, threads and sockets. The new apic id decoding is mostly similar to current apic id decoding except that it adds a new field llc_id when numa configured. Removes all the hardcoded values. Subse

[PATCH v4 09/16] target/i386: Cleanup and use the EPYC mode topology functions

2020-02-13 Thread Babu Moger
Use the new functions from topology.h and delete the unused code. Given the sockets, nodes, cores and threads, the new functions generate apic id for EPYC mode. Removes all the hardcoded values. Signed-off-by: Babu Moger --- target/i386/cpu.c | 162 +++---

[PATCH v4 10/16] hw/i386: Introduce apicid functions inside X86MachineState

2020-02-13 Thread Babu Moger
Introduce model specific apicid functions inside X86MachineState. These functions will be loaded from X86CPUDefinition. Signed-off-by: Babu Moger --- include/hw/i386/x86.h |9 + 1 file changed, 9 insertions(+) diff --git a/include/hw/i386/x86.h b/include/hw/i386/x86.h index 38c2d279

[PATCH v4 11/16] target/i386: Load apicid model specific handlers from X86CPUDefinition

2020-02-13 Thread Babu Moger
Load the model specific handlers if available or else default handlers will be loaded. Add the model specific handlers if apicid decoding differs from the standard sequential numbering. Signed-off-by: Babu Moger --- target/i386/cpu.c | 38 ++ target/i386/cpu

[PATCH v4 12/16] hw/i386: Use the apicid handlers from X86MachineState

2020-02-13 Thread Babu Moger
Check and Load the apicid handlers from X86CPUDefinition if available. Update the calling convention for the apicid handlers. Signed-off-by: Babu Moger --- hw/i386/pc.c |6 +++--- hw/i386/x86.c | 27 +++ 2 files changed, 26 insertions(+), 7 deletions(-) diff --git

[PATCH v4 13/16] target/i386: Add EPYC model specific handlers

2020-02-13 Thread Babu Moger
Add the new EPYC model specific handlers to fix the apicid decoding. The APIC ID is decoded based on the sequence sockets->dies->cores->threads. This works fine for most standard AMD and other vendors' configurations, but this decoding sequence does not follow that of AMD's APIC ID enumeration str

[PATCH v4 15/16] i386: Fix pkg_id offset for EPYC cpu models

2020-02-13 Thread Babu Moger
If the system is numa configured the pkg_offset needs to be adjusted for EPYC cpu models. Fix it calling the model specific handler. Signed-off-by: Babu Moger --- hw/i386/pc.c |1 + hw/i386/x86.c |4 target/i386/cpu.c |4 ++-- target/i386/cpu.h |1 + 4 files changed

Re: [PATCH 2/2] util: add util function buffer_zero_avx512()

2020-02-13 Thread Richard Henderson
On 2/12/20 11:52 PM, Robert Hoo wrote: > And initialize buffer_is_zero() with it, when Intel AVX512F is > available on host. > > This function utilizes Intel AVX512 fundamental instructions which > perform over previous AVX2 instructions. Is it not still true that any AVX512 insn will cause the e

[PATCH v4 14/16] hw/i386: Move arch_id decode inside x86_cpus_init

2020-02-13 Thread Babu Moger
Apicid calculation depends on knowing the total number of numa nodes for EPYC cpu models. Right now, we are calculating the arch_id while parsing the numa(parse_numa). At this time, it is not known how many total numa nodes are configured in the system. Move the arch_id inside x86_cpus_init. At th

[PATCH v4 16/16] tests: Update the Unit tests

2020-02-13 Thread Babu Moger
Since the topology routines have changed, update the unit tests to use the new APIs. Signed-off-by: Babu Moger --- tests/test-x86-cpuid.c | 115 1 file changed, 68 insertions(+), 47 deletions(-) diff --git a/tests/test-x86-cpuid.c b/tests/test-x

Re: [PATCH] pc-bios/s390x: Pack ResetInfo struct

2020-02-13 Thread Christian Borntraeger
On 13.02.20 19:02, Jason J. Herne wrote: > On 2/6/20 5:09 AM, Christian Borntraeger wrote: >> >> >> On 05.02.20 19:21, Jason J. Herne wrote: >>> This fixes vfio-ccw when booting non-Linux operating systems. Without this >>> struct being packed, a few extra bytes of low core memory get overwritten

Re: [PATCH v2 25/35] target/riscv: Only set TB flags with FP status if enabled

2020-02-13 Thread Palmer Dabbelt
On Fri, 31 Jan 2020 17:02:41 PST (-0800), Alistair Francis wrote: Signed-off-by: Alistair Francis --- target/riscv/cpu.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h index 5b889a0065..aa04e5cca7 100644 --- a/target/riscv/cpu.h +

Re: [PATCH RFC] memory: Don't allow to resize RAM while migrating

2020-02-13 Thread Peter Xu
On Thu, Feb 13, 2020 at 06:20:16PM +0100, David Hildenbrand wrote: > Resizing while migrating is dangerous and does not work as expected. > The whole migration code works on the usable_length of ram blocks and does > not expect this to change at random points in time. > > Precopy: The ram block si

Re: [PATCH v2 2/2] docs: rstfy vfio-ap documentation

2020-02-13 Thread Pierre Morel
On 2020-02-13 17:29, Cornelia Huck wrote: Move to system/, as this is mostly about configuring vfio-ap. Signed-off-by: Cornelia Huck --- MAINTAINERS | 2 +- docs/system/index.rst| 1 + docs/{vfio-ap.txt => system/vfio-ap.rst} | 796 +++

Re: [PATCH v2 26/35] target/riscv: Disable guest FP support based on virtual status

2020-02-13 Thread Palmer Dabbelt
On Fri, 31 Jan 2020 17:02:44 PST (-0800), Alistair Francis wrote: When the Hypervisor extension is in use we only enable floating point support when both status and vsstatus have enabled floating point support. Signed-off-by: Alistair Francis --- target/riscv/cpu_helper.c | 3 +++ 1 file chang

Re: [PATCH v2 27/35] target/riscv: Mark both sstatus and msstatus_hs as dirty

2020-02-13 Thread Palmer Dabbelt
On Fri, 31 Jan 2020 17:02:46 PST (-0800), Alistair Francis wrote: Mark both sstatus and vsstatus as dirty (3). Signed-off-by: Alistair Francis --- target/riscv/translate.c | 12 1 file changed, 12 insertions(+) diff --git a/target/riscv/translate.c b/target/riscv/translate.c inde

Re: [PATCH v2 2/2] docs: rstfy vfio-ap documentation

2020-02-13 Thread Peter Maydell
On Thu, 13 Feb 2020 at 18:38, Pierre Morel wrote:> However it may be because I do not use the right tools. > Did not find which one I am suppose to use. > Currently using: > rst2latex vfio-ap.rst > vfio-ap.tex && pdflatex vfio-ap.tex The only supported way to build the docs is with Sphinx. Optio

Re: [PULL 0/3] tcg patch queue

2020-02-13 Thread Peter Maydell
On Thu, 13 Feb 2020 at 00:23, Richard Henderson wrote: > > The following changes since commit e18e5501d8ac692d32657a3e1ef545b14e72b730: > > Merge remote-tracking branch > 'remotes/dgilbert-gitlab/tags/pull-virtiofs-20200210' into staging > (2020-02-10 18:09:14 +) > > are available in the G

Re: [PATCH v2 20/30] qapi/machine.json: Escape a literal '*' in doc comment

2020-02-13 Thread Philippe Mathieu-Daudé
On 2/13/20 6:56 PM, Peter Maydell wrote: For rST, '*' is a kind of inline markup (for emphasis), so "*-softmmu" is a syntax error because of the missing closing '*'. Escape the '*' with a '\'. The texinfo document generator will leave the '\' in the output, which is not ideal, but that generator

Re: [PATCH v2 17/30] qapi/migration.json: Replace _this_ with *this*

2020-02-13 Thread Philippe Mathieu-Daudé
On 2/13/20 6:56 PM, Peter Maydell wrote: The MigrationInfo::setup-time documentation is the only place where we use _this_ inline markup for emphasis, commonly rendered in italics. rST doesn't recognize that markup and emits literal underscores. Switch to *this* instead. Changes markup to stro

Re: [PATCH RFC] memory: Don't allow to resize RAM while migrating

2020-02-13 Thread Juan Quintela
David Hildenbrand wrote: > Resizing while migrating is dangerous and does not work as expected. > The whole migration code works on the usable_length of ram blocks and does > not expect this to change at random points in time. > > Precopy: The ram block size must not change on the source, after >

Re: [PATCH v5 1/8] multifd: Add multifd-method parameter

2020-02-13 Thread Juan Quintela
Daniel P. Berrangé wrote: > On Wed, Jan 29, 2020 at 12:56:48PM +0100, Juan Quintela wrote: >> This will store the compression method to use. We start with none. >> >> Signed-off-by: Juan Quintela >> Reviewed-by: Markus Armbruster >> Reviewed-by: Dr. David Alan Gilbert >> --- >> hw/core/qdev-

Re: [PATCH RFC] memory: Don't allow to resize RAM while migrating

2020-02-13 Thread David Hildenbrand
On 13.02.20 20:09, Juan Quintela wrote: > David Hildenbrand wrote: >> Resizing while migrating is dangerous and does not work as expected. >> The whole migration code works on the usable_length of ram blocks and does >> not expect this to change at random points in time. >> >> Precopy: The ram blo

Re: [PATCH v5 2/8] migration: Add support for modules

2020-02-13 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> So we don't have to compile everything in, or have ifdefs >> >> Signed-off-by: Juan Quintela > > As far as I can tell this matches the way all the rest of the module > stuff works, so: > > Reviewed-by: Dr. David Al

Re: [PATCH RFC] memory: Don't allow to resize RAM while migrating

2020-02-13 Thread David Hildenbrand
On 13.02.20 19:32, Peter Xu wrote: > On Thu, Feb 13, 2020 at 06:20:16PM +0100, David Hildenbrand wrote: >> Resizing while migrating is dangerous and does not work as expected. >> The whole migration code works on the usable_length of ram blocks and does >> not expect this to change at random points

Re: [PATCH v12 Kernel 4/7] vfio iommu: Implementation of ioctl to for dirty pages tracking.

2020-02-13 Thread Kirti Wankhede
+static int vfio_iova_dirty_bitmap(struct vfio_iommu *iommu, dma_addr_t iova, + size_t size, uint64_t pgsize, + unsigned char __user *bitmap) +{ + struct vfio_dma *dma; + dma_addr_t i = iova, iova_limit; + u

Re: [PATCH] tests/acceptance: Add boot tests for sh4 and mips64 QEMU advent calendar images

2020-02-13 Thread Wainer dos Santos Moschetta
On 2/11/20 7:42 AM, Thomas Huth wrote: Now that we can select the second serial console in the acceptance tests (see commit 746f244d9720 "Allow to use other serial consoles than default"), we can also test the sh4 image from the QEMU advent calendar 2018. And another recent commit (ec860426dfb

Re: [PATCH] tests/acceptance/ppc_prep_40p: Do not run NetBSD test by default

2020-02-13 Thread Wainer dos Santos Moschetta
On 2/11/20 11:19 AM, Philippe Mathieu-Daudé wrote: The ftp.netbsd.org server is slow and downloading the NetBSD ISO takes too long. Do not include this test in the default suite. Similarly to commit 471c97a69b: Currently the Avocado framework does not distinct the time spent downloading

Re: [PATCH] tests/acceptance/ppc_prep_40p: Use cdn.netbsd.org hostname

2020-02-13 Thread Wainer dos Santos Moschetta
On 2/11/20 11:45 AM, Philippe Mathieu-Daudé wrote: Use NetBSD content delivery network to get faster downloads. Suggested-by: Kamil Rytarowski Signed-off-by: Philippe Mathieu-Daudé --- tests/acceptance/ppc_prep_40p.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) LGTM. Rev

Re: [PATCH v5 5/8] multifd: Add zlib compression multifd support

2020-02-13 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> Signed-off-by: Juan Quintela >> --- >> hw/core/qdev-properties.c| 2 +- >> migration/Makefile.objs | 1 + >> migration/migration.c| 9 + >> migration/migration.h| 1 + >> migration/

Re: [PATCH v2] tests/acceptance/machine_sparc_leon3: Do not run HelenOS test by default

2020-02-13 Thread Wainer dos Santos Moschetta
On 2/12/20 6:36 PM, Philippe Mathieu-Daudé wrote: The www.helenos.org server is slow and downloading the Leon3 binary takes too long [*]. Do not include this test in the default suite. Similarly to commit 471c97a69b: Currently the Avocado framework does not distinct the time spent downl

Re: [PATCH v5 8/8] multifd: Add zstd compression multifd support

2020-02-13 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> Signed-off-by: Juan Quintela >> --- >> hw/core/qdev-properties.c| 2 +- >> migration/Makefile.objs | 1 + >> migration/migration.c| 9 + >> migration/migration.h| 1 + >> migration/

Re: [PATCH] qemu-doc: Clarify extent of build platform support

2020-02-13 Thread Eduardo Habkost
On Thu, Feb 13, 2020 at 09:43:34AM +0100, Markus Armbruster wrote: > Supporting a build platform beyond its end of life makes no sense. > Spell that out just to be clear. > > Signed-off-by: Markus Armbruster Thanks! Reviewed-by: Eduardo Habkost > --- > qemu-doc.texi | 9 + > 1 file c

Re: [PATCH v2 00/30] Convert QAPI doc comments to generate rST instead of texinfo

2020-02-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200213175647.17628-1-peter.mayd...@linaro.org/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGI

Re: [PATCH RFC] memory: Don't allow to resize RAM while migrating

2020-02-13 Thread Peter Xu
On Thu, Feb 13, 2020 at 08:42:23PM +0100, David Hildenbrand wrote: > On 13.02.20 19:32, Peter Xu wrote: > > On Thu, Feb 13, 2020 at 06:20:16PM +0100, David Hildenbrand wrote: > >> Resizing while migrating is dangerous and does not work as expected. > >> The whole migration code works on the usable_

Re: [PATCH v5 6/8] configure: Enable test and libs for zstd

2020-02-13 Thread Juan Quintela
Daniel P. Berrangé wrote: > On Wed, Jan 29, 2020 at 12:56:53PM +0100, Juan Quintela wrote: >> Signed-off-by: Juan Quintela >> Reviewed-by: Dr. David Alan Gilbert >> --- >> configure | 30 ++ >> 1 file changed, 30 insertions(+) > > This is adding a new 3rd party libra

[PATCH v6 1/8] multifd: Add multifd-compression parameter

2020-02-13 Thread Juan Quintela
This will store the compression method to use. We start with none. Signed-off-by: Juan Quintela Acked-by: Markus Armbruster Reviewed-by: Dr. David Alan Gilbert --- Rename multifd-method to multifd-compression --- hw/core/qdev-properties.c| 13 + include/hw/qdev-properties.h

[PATCH v6 0/8] Multifd Migration Compression

2020-02-13 Thread Juan Quintela
Based-on: <20200213132030.57757-1-quint...@redhat.com> [v6] - rebase to latest pull request - move functions that read parameters to the parameters patechs (dave) - require zstd on travis/docker/... (please review) - rename multifd_method to multifd_compression - improve documentation Please revi

[PATCH v6 2/8] migration: Add support for modules

2020-02-13 Thread Juan Quintela
So we don't have to compile everything in, or have ifdefs Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- include/qemu/module.h | 2 ++ vl.c | 1 + 2 files changed, 3 insertions(+) diff --git a/include/qemu/module.h b/include/qemu/module.h index 65ba596e46

Re: [PATCH] uapi: fix userspace breakage, use __BITS_PER_LONG for swap

2020-02-13 Thread Yury Norov
On Thu, Feb 13, 2020 at 03:21:47PM +0100, Christian Borntraeger wrote: > QEMU has a funny new build error message when I use the upstream kernel > headers: > > CC block/file-posix.o > In file included from /home/cborntra/REPOS/qemu/include/qemu/timer.h:4, > from > /home/c

[PATCH v6 3/8] multifd: Make no compression operations into its own structure

2020-02-13 Thread Juan Quintela
It will be used later. Signed-off-by: Juan Quintela --- No comp value needs to be zero. --- migration/migration.c | 9 ++ migration/migration.h | 1 + migration/multifd.c | 185 -- migration/multifd.h | 26 ++ migration/ram.c | 1 +

[PATCH v6 8/8] multifd: Add zstd compression multifd support

2020-02-13 Thread Juan Quintela
Signed-off-by: Juan Quintela Acked-by: Markus Armbruster Reviewed-by: Dr. David Alan Gilbert --- hw/core/qdev-properties.c| 2 +- migration/Makefile.objs | 1 + migration/multifd-zstd.c | 339 +++ migration/multifd.h | 1 + migration/r

[PATCH v6 7/8] multifd: Add multifd-zstd-level parameter

2020-02-13 Thread Juan Quintela
This parameter specifies the zstd compression level. The next patch will put it to use. Signed-off-by: Juan Quintela Acked-by: Markus Armbruster --- migration/migration.c | 24 migration/migration.h | 1 + monitor/hmp-cmds.c| 4 qapi/migration.json | 29 +++

[PATCH v6 4/8] multifd: Add multifd-zlib-level parameter

2020-02-13 Thread Juan Quintela
This parameter specifies the zlib compression level. The next patch will put it to use. Signed-off-by: Juan Quintela Acked-by: Markus Armbruster Reviewed-by: Dr. David Alan Gilbert --- migration/migration.c | 24 migration/migration.h | 1 + monitor/hmp-cmds.c| 4

[PATCH v6 6/8] configure: Enable test and libs for zstd

2020-02-13 Thread Juan Quintela
Add it to several build systems to make testing good. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- .gitlab-ci.yml| 1 + .travis.yml | 1 + configure | 30 +

[PATCH v6 5/8] multifd: Add zlib compression multifd support

2020-02-13 Thread Juan Quintela
Signed-off-by: Juan Quintela Acked-by: Markus Armbruster --- hw/core/qdev-properties.c| 2 +- migration/Makefile.objs | 1 + migration/multifd-zlib.c | 325 +++ migration/multifd.c | 6 + migration/multifd.h | 4 + qapi/migra

Re: [PATCH] migration/postcopy: not necessary to discard all RAM at the beginning

2020-02-13 Thread Wei Yang
On Thu, Feb 13, 2020 at 10:17:04AM +, Dr. David Alan Gilbert wrote: >* Wei Yang (richardw.y...@linux.intel.com) wrote: >> ram_discard_range() unmap page for specific range. To be specific, this >> clears related page table entries so that userfault would be triggered. >> But this step is not ne

Re: [PATCH v2 2/2] tests/tcg/multiarch: Add tests for implemented alsa sound timer ioctls

2020-02-13 Thread Aleksandar Markovic
3:26 PM Čet, 13.02.2020. Filip Bozuta је написао/ла: > > +int main(int argc, char **argv) > +{ > +char ioctls[15][35] = {"SNDRV_TIMER_IOCTL_PVERSION", > + "SNDRV_TIMER_IOCTL_INFO", > + "SNDRV_TIMER_IOCTL_NEXT_DEVICE", > +

[PATCH v2 02/19] tests/rcutorture: update usage hint

2020-02-13 Thread Alex Bennée
Although documented in the comments we don't display all the various invocations we can in the usage. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé --- tests/rcutorture.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/rcutorture.c b/tests/rcutorture

[PATCH v2 00/19] testing and plugin updates

2020-02-13 Thread Alex Bennée
Hi, I've ended up combining my accumulated testing fixes with the plugin fixes as there is some cross-over between the two. On the testing side I still haven't seen rcutorture trip up on my branches but the final patch that light re-factors it needs to be reviewed. I've also added some fixes for p

[PATCH v2 06/19] travis.yml: Fix Travis YAML configuration warnings

2020-02-13 Thread Alex Bennée
From: Wainer dos Santos Moschetta This fixes the following warnings Travis has detected on the YAML configuration: - 'on root: missing os, using the default "linux"' - 'on root: the key matrix is an alias for jobs, using jobs' - 'on jobs.include.python: unexpected sequence, using the first value

[PATCH v2 01/19] tests/tcg: include a skip runner for pauth3 with plugins

2020-02-13 Thread Alex Bennée
If we have plugins enabled we still need to have built the test to be able to run it. Signed-off-by: Alex Bennée --- tests/tcg/aarch64/Makefile.softmmu-target | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/tcg/aarch64/Makefile.softmmu-target b/tests/tcg/aarch64/Makefile.softmmu-tar

<    1   2   3   4   >