Re: [RFC PATCH 24/66] Hexagon generator phase 2 - op_attribs_generated.h

2020-02-11 Thread Philippe Mathieu-Daudé
On 2/11/20 1:40 AM, Taylor Simpson wrote: Lists all the attributes associated with each instruction Signed-off-by: Taylor Simpson --- target/hexagon/do_qemu.py | 13 + 1 file changed, 13 insertions(+) diff --git a/target/hexagon/do_qemu.py b/target/hexagon/do_qemu.py index 54399

Re: [RFC PATCH 28/66] Hexagon generater phase 4 - Decode tree

2020-02-11 Thread Philippe Mathieu-Daudé
On 2/11/20 8:37 AM, Philippe Mathieu-Daudé wrote: On 2/11/20 1:40 AM, Taylor Simpson wrote: Python script that emits the decode tree in dectree_generated.h. Signed-off-by: Taylor Simpson ---   target/hexagon/dectree.py | 354 ++   1 file changed, 35

Re: [PATCH v2] hw/arm: ast2600: Wire up EHCI controllers

2020-02-11 Thread Philippe Mathieu-Daudé
On 2/7/20 11:48 PM, Guenter Roeck wrote: On Fri, Feb 07, 2020 at 02:04:09PM -0800, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20200207174548.9087-1-li...@roeck-us.net/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and thei

Re: [PULL 0/6] 9p patches 2020-02-08

2020-02-11 Thread Christian Schoenebeck
On Montag, 10. Februar 2020 18:08:38 CET Peter Maydell wrote: > On Sat, 8 Feb 2020 at 10:45, Greg Kurz wrote: > > The following changes since commit 42ccca1bd9456568f996d5646b2001faac96944b: > > Merge remote-tracking branch > > 'remotes/berrange/tags/misc-fixes-pull-request' into staging > >

Re: [RFC 1/2] tpm: Let the TPM TIS device be usable on ARM

2020-02-11 Thread Philippe Mathieu-Daudé
On 2/10/20 2:15 PM, Eric Auger wrote: Implement support for TPM on aarch64 by using the TPM TIS MMIO frontend. Instead of being an ISA device, the TPM TIS device becomes a sysbus device on ARM. It is bound to be dynamically instantiated. Signed-off-by: Eric Auger --- I am aware such kind of #

Re: [PATCH] gitlab-ci.yml: Add .gitlab-ci.d directory for GitLab specific files

2020-02-11 Thread Thomas Huth
On 11/02/2020 07.50, Philippe Mathieu-Daudé wrote: > As we plan to let maintainers managing their own GitLab CI jobs, > add a single directory to contain all the new files (to keep the > root directory cleaner). The title and description is a little bit confusing, since the directory is already th

[PATCH] migration-test: fix some memleaks in migration-test

2020-02-11 Thread pannengyuan
From: Pan Nengyuan spotted by asan, 'check-qtest-aarch64' runs fail if sanitizers is enabled. Reported-by: Euler Robot Signed-off-by: Pan Nengyuan --- tests/qtest/migration-test.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/tests/qtest/migration-test.c

Re: [PATCH] tests/migration: Add some slack to auto converge

2020-02-11 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > There's an assert in autoconverge that checks that we quit the > iteration when we go below the expected threshold. Philippe > saw a case where this assert fired with the measured value > slightly over the threshold. (abo

Re: [RFC 1/2] tpm: Let the TPM TIS device be usable on ARM

2020-02-11 Thread Auger Eric
Hi Philippe, On 2/11/20 9:25 AM, Philippe Mathieu-Daudé wrote: > On 2/10/20 2:15 PM, Eric Auger wrote: >> Implement support for TPM on aarch64 by using the >> TPM TIS MMIO frontend. Instead of being an ISA device, >> the TPM TIS device becomes a sysbus device on ARM. It is >> bound to be dynamical

Re: [PULL 0/6] 9p patches 2020-02-08

2020-02-11 Thread Greg Kurz
On Tue, 11 Feb 2020 09:15:41 +0100 Christian Schoenebeck wrote: > On Montag, 10. Februar 2020 18:08:38 CET Peter Maydell wrote: > > On Sat, 8 Feb 2020 at 10:45, Greg Kurz wrote: > > > The following changes since commit > 42ccca1bd9456568f996d5646b2001faac96944b: > > > Merge remote-tracking br

RE: [PATCH V4 0/5] Introduce Advanced Watch Dog module

2020-02-11 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Monday, January 20, 2020 10:57 AM > To: Zhang, Chen ; Paolo Bonzini > ; Philippe Mathieu-Daudé ; > qemu-dev > Cc: Zhang Chen > Subject: Re: [PATCH V4 0/5] Introduce Advanced Watch Dog module > > > On 2020/1/19 下午5:10, Zhang, Chen wrote:

Re: [PATCH] migration/rdma: rdma_accept_incoming_migration fix error handling

2020-02-11 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Mon, Feb 10, 2020 at 07:44:59PM +, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > rdma_accept_incoming_migration is called from an fd handler and > > can't return an Error * anywhere. > > Currently it's leaking Error's

Re: [PATCH v2 0/5] virtio mmio specification enhancement

2020-02-11 Thread Chao Peng
On Mon, Feb 10, 2020 at 06:44:50AM -0500, Michael S. Tsirkin wrote: > On Mon, Feb 10, 2020 at 05:05:16PM +0800, Zha Bin wrote: > > We have compared the number of files and the lines of code between > > virtio-mmio and virio-pci. > > > > Virtio-PCI Virtio-MMIO

[PATCH] tests/acceptance: Add boot tests for sh4 and mips64 QEMU advent calendar images

2020-02-11 Thread Thomas Huth
Now that we can select the second serial console in the acceptance tests (see commit 746f244d9720 "Allow to use other serial consoles than default"), we can also test the sh4 image from the QEMU advent calendar 2018. And another recent commit (ec860426dfbe "Fix handling of LL/SC instructions") fix

[PATCH 3/3] iotests: Test copy offloading with external data file

2020-02-11 Thread Kevin Wolf
This adds a test for 'qemu-img convert' with copy offloading where the target image has an external data file. If the test hosts supports it, it tests both the case where copy offloading is supported and the case where it isn't (otherwise we just test unsupported twice). More specifically, the cas

[PATCH 0/3] qcow2: Fix write/copy error path with data file

2020-02-11 Thread Kevin Wolf
Kevin Wolf (3): qcow2: update_refcount(): Reset old_table_index after qcow2_cache_put() qcow2: Fix qcow2_alloc_cluster_abort() for external data file iotests: Test copy offloading with external data file block/qcow2-cluster.c | 7 +-- block/qcow2-refcount.c | 1 + tests/q

[PATCH 2/3] qcow2: Fix qcow2_alloc_cluster_abort() for external data file

2020-02-11 Thread Kevin Wolf
For external data file, cluster allocations return an offset in the data file and are not refcounted. In this case, there is nothing to do for qcow2_alloc_cluster_abort(). Freeing the same offset in the qcow2 file is wrong and causes crashes in the better case or image corruption in the worse case.

[PATCH 1/3] qcow2: update_refcount(): Reset old_table_index after qcow2_cache_put()

2020-02-11 Thread Kevin Wolf
In the case that update_refcount() frees a refcount block, it evicts it from the metadata cache. Before doing so, however, it returns the currently used refcount block to the cache because it might be the same. Returning the refcount block early means that we need to reset old_table_index so that w

[PATCH v2] gitlab-ci: Move EDK2 YAML config to .gitlab-ci.d directory

2020-02-11 Thread Philippe Mathieu-Daudé
We plan to let maintainers managing their own GitLab CI jobs. The .gitlab-ci.d directory will contain all the new GitLab files, to keep the root directory cleaner. The EDK2 job was introduced before .gitlab-ci.d was suggested as a common directory. Move the YAML file, update its references. Sugge

Re: [PATCH 1/2] tests/acceptance: Extract boot_integratorcp() from test_integratorcp()

2020-02-11 Thread Philippe Mathieu-Daudé
On 2/1/20 8:06 AM, Thomas Huth wrote: On 31/01/2020 22.11, Philippe Mathieu-Daudé wrote: As we want to re-use this code, extract it as a new function. Since we are using the PL011 serial console, add a Avocado tag to ease filtering of tests. Signed-off-by: Philippe Mathieu-Daudé --- tests/ac

Re: [PATCH v2 7/7] tests/bios-tables-test: Update arm/virt memhp test

2020-02-11 Thread Michael S. Tsirkin
On Fri, Jan 17, 2020 at 05:45:22PM +, Shameer Kolothum wrote: > Since we now have both pc-dimm and nvdimm support, update > test_acpi_virt_tcg_memhp() to include those. > > Signed-off-by: Shameer Kolothum And you can add a last patch on top updating the expected files and blowing out the all

Re: [PATCH v1 2/4] virtio: increase virtuqueue size for virtio-scsi and virtio-blk

2020-02-11 Thread Michael S. Tsirkin
On Mon, Feb 10, 2020 at 06:34:15PM +0300, Denis Plotnikov wrote: > > > On 09.02.2020 10:49, Michael S. Tsirkin wrote: > > On Fri, Feb 07, 2020 at 11:48:05AM +0300, Denis Plotnikov wrote: > > > > > > On 05.02.2020 14:19, Stefan Hajnoczi wrote: > > > > On Tue, Feb 04, 2020 at 12:59:04PM +0300, Den

[PATCH] tests/acceptance/virtio_check_params: Only disable the test on CI

2020-02-11 Thread Philippe Mathieu-Daudé
Commit 2d6a6e238a incorrectly totally disabled this test. The original intention was to only disable on continuous integration. Signed-off-by: Philippe Mathieu-Daudé --- tests/acceptance/virtio_check_params.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/acceptan

Re: [PATCH v2 1/5] virtio-mmio: add notify feature for per-queue

2020-02-11 Thread Michael S. Tsirkin
On Mon, Feb 10, 2020 at 05:05:17PM +0800, Zha Bin wrote: > From: Liu Jiang > > The standard virtio-mmio devices use notification register to signal > backend. This will cause vmexits and slow down the performance when we > passthrough the virtio-mmio devices to guest virtual machines. > We propos

Re: [PATCH] tests/acceptance/virtio_check_params: Only disable the test on CI

2020-02-11 Thread Cornelia Huck
On Tue, 11 Feb 2020 11:49:38 +0100 Philippe Mathieu-Daudé wrote: > Commit 2d6a6e238a incorrectly totally disabled this test. > The original intention was to only disable on continuous integration. > > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/acceptance/virtio_check_params.py | 4 ++-

Re: [GSoC/Outreachy] Arduino complete setup visualization and emulation

2020-02-11 Thread Stefan Hajnoczi
On Mon, Feb 10, 2020 at 08:58:28PM +0100, Philippe Mathieu-Daudé wrote: Cool, thanks for proposing this idea! > [*] Goal: > > Be able to use a visual virtual arduino board, and program it with > the Arduino IDE. The result should be easily usable by newcomers to > the Arduino world. Out of curi

Re: [PATCH v5 2/8] migration: Add support for modules

2020-02-11 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > So we don't have to compile everything in, or have ifdefs > > Signed-off-by: Juan Quintela As far as I can tell this matches the way all the rest of the module stuff works, so: Reviewed-by: Dr. David Alan Gilbert (Although I wish it was documente

Re: [RFC 1/2] tpm: Let the TPM TIS device be usable on ARM

2020-02-11 Thread Peter Maydell
On Tue, 11 Feb 2020 at 08:35, Auger Eric wrote: > > Hi Philippe, > > On 2/11/20 9:25 AM, Philippe Mathieu-Daudé wrote: > > You don't need much to remove the RFC tag: > > > > - rename TYPE_TPM_TIS as TYPE_TPM_TIS_ISA > > - rename TPMState as TPMCommonState, add an abstract TYPE_TPM_TIS > > parent,

Re: [PATCH v2 0/5] virtio mmio specification enhancement

2020-02-11 Thread Michael S. Tsirkin
On Tue, Feb 11, 2020 at 04:05:41PM +, Chao Peng wrote: > On Mon, Feb 10, 2020 at 06:44:50AM -0500, Michael S. Tsirkin wrote: > > On Mon, Feb 10, 2020 at 05:05:16PM +0800, Zha Bin wrote: > > > We have compared the number of files and the lines of code between > > > virtio-mmio and virio-pci. > >

Re: [qemu-web PATCH] Force background color

2020-02-11 Thread Thomas Huth
On 08/02/2020 01.46, athurh wrote: > Browsers can have a different default background color defined. > Setting the background image overwrites other background definitions. > --- > assets/css/style-desktop.css | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/assets/css/style-desktop.css

Re: [PATCH] tests/acceptance: Add boot tests for sh4 and mips64 QEMU advent calendar images

2020-02-11 Thread Thomas Huth
On 11/02/2020 10.42, Thomas Huth wrote: > Now that we can select the second serial console in the acceptance tests > (see commit 746f244d9720 "Allow to use other serial consoles than default"), > we can also test the sh4 image from the QEMU advent calendar 2018. > > And another recent commit (ec86

Re: [PATCH] migration/rdma: rdma_accept_incoming_migration fix error handling

2020-02-11 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > rdma_accept_incoming_migration is called from an fd handler and > can't return an Error * anywhere. > Currently it's leaking Error's in errp/local_err - there's > no point putting them in there unless we can report them. >

[PATCH] tracing: only allow -trace to override -D if set

2020-02-11 Thread Alex Bennée
Otherwise any -D settings the user may have made get ignored. Signed-off-by: Alex Bennée --- trace/control.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/trace/control.c b/trace/control.c index 6c775e68eba..2ffe0008184 100644 --- a/trace/control.c +++ b/trace/c

Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support

2020-02-11 Thread Michael S. Tsirkin
On Mon, Feb 10, 2020 at 05:05:20PM +0800, Zha Bin wrote: > From: Liu Jiang > > Userspace VMMs (e.g. Qemu microvm, Firecracker) take advantage of using > virtio over mmio devices as a lightweight machine model for modern > cloud. The standard virtio over MMIO transport layer only supports one > le

Re: [PATCH v2 5/5] x86: virtio-mmio: support virtio-mmio with MSI for x86

2020-02-11 Thread Michael S. Tsirkin
On Mon, Feb 10, 2020 at 05:05:21PM +0800, Zha Bin wrote: > From: Liu Jiang > > virtio-mmio supports a generic MSI irq domain for all archs. This > patch adds the x86 architecture support. > > Signed-off-by: Liu Jiang > Co-developed-by: Zha Bin > Signed-off-by: Zha Bin > Co-developed-by: Jing

Re: [PATCH] migration/rdma: rdma_accept_incoming_migration fix error handling

2020-02-11 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > rdma_accept_incoming_migration is called from an fd handler and > > can't return an Error * anywhere. > > Currently it's leaking Error's in errp/local_err - there's > >

[PATCH v2] tests/acceptance: Add boot tests for sh4 and mips64 QEMU advent calendar images

2020-02-11 Thread Thomas Huth
Now that we can select the second serial console in the acceptance tests (see commit 746f244d9720 "Allow to use other serial consoles than default"), we can also test the sh4 image from the QEMU advent calendar 2018. And another recent commit (ec860426dfbe "Fix handling of LL/SC instructions") fix

Re: [PATCH v2 3/5] virtio-mmio: create a generic MSI irq domain

2020-02-11 Thread Michael S. Tsirkin
On Mon, Feb 10, 2020 at 05:05:19PM +0800, Zha Bin wrote: > From: Liu Jiang > > Create a generic irq domain for all architectures which > supports virtio-mmio. The device offering VIRTIO_F_MMIO_MSI > feature bit can use this irq domain. > > Signed-off-by: Liu Jiang > Co-developed-by: Zha Bin >

Re: [PATCH v2 2/5] virtio-mmio: refactor common functionality

2020-02-11 Thread Michael S. Tsirkin
On Mon, Feb 10, 2020 at 05:05:18PM +0800, Zha Bin wrote: > From: Liu Jiang > > Common functionality is refactored into virtio_mmio_common.h > in order to MSI support in later patch set. > > Signed-off-by: Liu Jiang > Co-developed-by: Zha Bin > Signed-off-by: Zha Bin > Co-developed-by: Jing Li

Re: [PATCH v5 3/8] multifd: Make no compression operations into its own structure

2020-02-11 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> It will be used later. >> >> Signed-off-by: Juan Quintela > >> diff --git a/migration/multifd.h b/migration/multifd.h >> index d8b0205977..c7fea4914c 100644 >> --- a/migration/multifd.h >> +++ b/migration/multifd.h

Re: [virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support

2020-02-11 Thread Michael S. Tsirkin
On Tue, Feb 11, 2020 at 11:35:43AM +0800, Liu, Jing2 wrote: > > On 2/11/2020 11:17 AM, Jason Wang wrote: > > > > On 2020/2/10 下午5:05, Zha Bin wrote: > > > From: Liu Jiang > > > > > > Userspace VMMs (e.g. Qemu microvm, Firecracker) take advantage of using > > > virtio over mmio devices as a light

Re: [PATCH v2 1/5] virtio-mmio: add notify feature for per-queue

2020-02-11 Thread Michael S. Tsirkin
On Mon, Feb 10, 2020 at 05:05:17PM +0800, Zha Bin wrote: > From: Liu Jiang > > The standard virtio-mmio devices use notification register to signal > backend. This will cause vmexits and slow down the performance when we > passthrough the virtio-mmio devices to guest virtual machines. > We propos

Re: [virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support

2020-02-11 Thread Michael S. Tsirkin
On Tue, Feb 11, 2020 at 03:40:23PM +0800, Jason Wang wrote: > > On 2020/2/11 下午2:02, Liu, Jing2 wrote: > > > > > > On 2/11/2020 12:02 PM, Jason Wang wrote: > > > > > > On 2020/2/11 上午11:35, Liu, Jing2 wrote: > > > > > > > > On 2/11/2020 11:17 AM, Jason Wang wrote: > > > > > > > > > > On 2020/

Re: [virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support

2020-02-11 Thread Jason Wang
On 2020/2/11 下午7:58, Michael S. Tsirkin wrote: On Tue, Feb 11, 2020 at 03:40:23PM +0800, Jason Wang wrote: On 2020/2/11 下午2:02, Liu, Jing2 wrote: On 2/11/2020 12:02 PM, Jason Wang wrote: On 2020/2/11 上午11:35, Liu, Jing2 wrote: On 2/11/2020 11:17 AM, Jason Wang wrote: On 2020/2/10 下午5:05, Z

Re: [virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support

2020-02-11 Thread Michael S. Tsirkin
On Tue, Feb 11, 2020 at 08:04:24PM +0800, Jason Wang wrote: > > On 2020/2/11 下午7:58, Michael S. Tsirkin wrote: > > On Tue, Feb 11, 2020 at 03:40:23PM +0800, Jason Wang wrote: > > > On 2020/2/11 下午2:02, Liu, Jing2 wrote: > > > > On 2/11/2020 12:02 PM, Jason Wang wrote: > > > > > On 2020/2/11 上午11:3

[Bug 1862167] Re: Variation of SVE register size (qemu-user-aarch64)

2020-02-11 Thread Laurent Vivier
This is already managed by a cpu property. 0df9142d27d5 ("target/arm/cpu64: max cpu: Introduce sve properties") See docs/arm-cpu-features.rst Try "-cpu max,sve512=on". -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.la

Re: [virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support

2020-02-11 Thread Jason Wang
On 2020/2/11 下午8:08, Michael S. Tsirkin wrote: On Tue, Feb 11, 2020 at 08:04:24PM +0800, Jason Wang wrote: On 2020/2/11 下午7:58, Michael S. Tsirkin wrote: On Tue, Feb 11, 2020 at 03:40:23PM +0800, Jason Wang wrote: On 2020/2/11 下午2:02, Liu, Jing2 wrote: On 2/11/2020 12:02 PM, Jason Wang wrot

[Bug 1862167] Re: Variation of SVE register size (qemu-user-aarch64)

2020-02-11 Thread Peter Maydell
Note also that the vector length in SVE is not fixed -- you should be writing your guest code to support arbitrary vector lengths, because otherwise it will not run on all SVE-supporting CPUs. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

Re: KVM call for agenda for 2020-02-11

2020-02-11 Thread Juan Quintela
Juan Quintela wrote: > Hi As there are no topics, call gets cancelled. Have a good week. > > Please, send any topic that you are interested in covering. > > At the end of Monday I will send an email with the agenda or the > cancellation of the call, so hurry up. > > After discussions on the QEM

KVM call for agenda for 2020-02-25

2020-02-11 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. At the end of Monday I will send an email with the agenda or the cancellation of the call, so hurry up. After discussions on the QEMU Summit, we are going to have always open a KVM call where you can add topics. Call details: B

[Bug 1862167] Re: Variation of SVE register size (qemu-user-aarch64)

2020-02-11 Thread Alex Bennée
** Tags added: arm ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1862167 Title: Variation of SVE register size (qemu-user-aarch64) Status in QEMU

[PATCH] tests/acceptance/ppc_prep_40p: Do not run NetBSD test by default

2020-02-11 Thread Philippe Mathieu-Daudé
The ftp.netbsd.org server is slow and downloading the NetBSD ISO takes too long. Do not include this test in the default suite. Similarly to commit 471c97a69b: Currently the Avocado framework does not distinct the time spent downloading assets vs. the time spent running a test. With big ass

Re: [RFC 1/2] tpm: Let the TPM TIS device be usable on ARM

2020-02-11 Thread Auger Eric
Hi Peter, On 2/11/20 11:56 AM, Peter Maydell wrote: > On Tue, 11 Feb 2020 at 08:35, Auger Eric wrote: >> >> Hi Philippe, >> >> On 2/11/20 9:25 AM, Philippe Mathieu-Daudé wrote: >>> You don't need much to remove the RFC tag: >>> >>> - rename TYPE_TPM_TIS as TYPE_TPM_TIS_ISA >>> - rename TPMState a

Re: [PATCH] tests/acceptance/ppc_prep_40p: Do not run NetBSD test by default

2020-02-11 Thread Kamil Rytarowski
Please use cdn.netbsd.org always. On 11.02.2020 14:19, Philippe Mathieu-Daudé wrote: > The ftp.netbsd.org server is slow and downloading the NetBSD ISO > takes too long. Do not include this test in the default suite. > > Similarly to commit 471c97a69b: > > Currently the Avocado framework does

Re: [PULL 0/6] 9p patches 2020-02-08

2020-02-11 Thread Christian Schoenebeck
On Dienstag, 11. Februar 2020 09:42:01 CET Greg Kurz wrote: > On Tue, 11 Feb 2020 09:15:41 +0100 > > Christian Schoenebeck wrote: > > On Montag, 10. Februar 2020 18:08:38 CET Peter Maydell wrote: > > > On Sat, 8 Feb 2020 at 10:45, Greg Kurz wrote: > > > > The following changes since commit > >

Re: [PATCH v2] gitlab-ci: Move EDK2 YAML config to .gitlab-ci.d directory

2020-02-11 Thread Wainer dos Santos Moschetta
On 2/11/20 7:50 AM, Philippe Mathieu-Daudé wrote: We plan to let maintainers managing their own GitLab CI jobs. The .gitlab-ci.d directory will contain all the new GitLab files, to keep the root directory cleaner. The EDK2 job was introduced before .gitlab-ci.d was suggested as a common direct

[PATCH] block: make BlockConf.*_size properties 32-bit

2020-02-11 Thread Roman Kagan
Devices (virtio-blk, scsi, etc.) and the block layer are happy to use 32-bit for logical_block_size, physical_block_size, and min_io_size. However, the properties in BlockConf are defined as uint16_t limiting the values to 32768. This appears unnecessary tight, and we've seen bigger block sizes ha

Requesting review about optimizing large guest start up time

2020-02-11 Thread 陈蒙蒙
From c882b155466313fcd85ac330a45a573e608b0d74 Mon Sep 17 00:00:00 2001 From: bauerchen Date: Tue, 11 Feb 2020 17:10:35 +0800 Subject: [PATCH] Optimize: large guest start-up in mem-prealloc MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit [desc]:     Large

[PATCH] tests/acceptance/ppc_prep_40p: Use cdn.netbsd.org hostname

2020-02-11 Thread Philippe Mathieu-Daudé
Use NetBSD content delivery network to get faster downloads. Suggested-by: Kamil Rytarowski Signed-off-by: Philippe Mathieu-Daudé --- tests/acceptance/ppc_prep_40p.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/acceptance/ppc_prep_40p.py b/tests/acceptance/ppc_

Re: [PATCH] migration/rdma: rdma_accept_incoming_migration fix error handling

2020-02-11 Thread Peter Xu
On Tue, Feb 11, 2020 at 09:22:00AM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Mon, Feb 10, 2020 at 07:44:59PM +, Dr. David Alan Gilbert (git) > > wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > rdma_accept_incoming_migration is called from an

Re: [PATCH v15 0/9] VIRTIO-IOMMU device

2020-02-11 Thread Michael S. Tsirkin
On Sat, Feb 08, 2020 at 01:00:13PM +0100, Eric Auger wrote: > This series implements the QEMU virtio-iommu device. > > This matches the v0.12 spec (voted) and the corresponding > virtio-iommu driver upstreamed in 5.3. All kernel dependencies > are resolved for DT integration. The virtio-iommu can

Re: [virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support

2020-02-11 Thread Michael S. Tsirkin
On Tue, Feb 11, 2020 at 08:18:54PM +0800, Jason Wang wrote: > > On 2020/2/11 下午8:08, Michael S. Tsirkin wrote: > > On Tue, Feb 11, 2020 at 08:04:24PM +0800, Jason Wang wrote: > > > On 2020/2/11 下午7:58, Michael S. Tsirkin wrote: > > > > On Tue, Feb 11, 2020 at 03:40:23PM +0800, Jason Wang wrote: >

[PATCH] pc: remove erroneous seg_max_adjust setting for vhost-blk-device

2020-02-11 Thread Denis Plotnikov
vhost-blk-device isn't a part of qemu.git Signed-off-by: Denis Plotnikov --- hw/core/machine.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/core/machine.c b/hw/core/machine.c index d8e30e4895..2501b540ec 100644 --- a/hw/core/machine.c +++ b/hw/core/machine.c @@ -31,7 +31,6 @@ GlobalProp

[PATCH v2] virtio: increase virtuqueue size for virtio-scsi and virtio-blk

2020-02-11 Thread Denis Plotnikov
The goal is to reduce the amount of requests issued by a guest on 1M reads/writes. This rises the performance up to 4% on that kind of disk access pattern. The maximum chunk size to be used for the guest disk accessing is limited with seg_max parameter, which represents the max amount of pices in

[Bug 1663079] Re: socket network not working

2020-02-11 Thread Thomas Huth
Works for me with the current QEMU master branch... can you still reproduce the issue with the latest version of QEMU (either v4.2 or the master branch)? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which i

[Bug 1657538] Re: qemu 2.7.x 2.8 softmmu dont work on BE machine

2020-02-11 Thread Thomas Huth
Looking through old bug tickets ... can you still reproduce the issue with the latest version of QEMU (v4.2) and a more recent Linux distribution? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subsc

[PATCH v1 2/2] tests/acceptance/virtio_check_params: prepare to check different params

2020-02-11 Thread Denis Plotnikov
Signed-off-by: Denis Plotnikov --- tests/acceptance/virtio_check_params.py | 38 ++--- 1 file changed, 22 insertions(+), 16 deletions(-) diff --git a/tests/acceptance/virtio_check_params.py b/tests/acceptance/virtio_check_params.py index deec89bf86..e578952a97 100644 --- a/t

[PATCH v1 1/2] tests/acceptance/virtio_check_params: remove excluded machine types carefully

2020-02-11 Thread Denis Plotnikov
Before, the test failed if an excluded machine type was absent in the machine types lists. Signed-off-by: Denis Plotnikov --- tests/acceptance/virtio_check_params.py | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/tests/acceptance/virtio_check_params.py b/tes

[PATCH v1 0/2] Improve virtio_check_params test

2020-02-11 Thread Denis Plotnikov
* fixed failing on non-existed machine type removal * the test refactored to add more parameters to check Gereral questions left: How to restric test for using: 1. on a set of target OS-es 2. on a set target architectures Denis Plotnikov (2): tests/acceptance/virtio_check_params: re

Re: [RFC 1/2] tpm: Let the TPM TIS device be usable on ARM

2020-02-11 Thread Stefan Berger
On 2/11/20 5:56 AM, Peter Maydell wrote: On Tue, 11 Feb 2020 at 08:35, Auger Eric wrote: Hi Philippe, On 2/11/20 9:25 AM, Philippe Mathieu-Daudé wrote: You don't need much to remove the RFC tag: - rename TYPE_TPM_TIS as TYPE_TPM_TIS_ISA - rename TPMState as TPMCommonState, add an abstract TY

Re: Cross-project NBD extension proposal: NBD_INFO_INIT_STATE

2020-02-11 Thread Eric Blake
On 2/10/20 4:52 PM, Richard W.M. Jones wrote: On Mon, Feb 10, 2020 at 04:29:53PM -0600, Eric Blake wrote: On 2/10/20 4:12 PM, Richard W.M. Jones wrote: On Mon, Feb 10, 2020 at 03:37:20PM -0600, Eric Blake wrote: For now, only 2 of those 16 bits are defined: NBD_INIT_SPARSE (the image has at le

RE: [RFC PATCH 55/66] Hexagon HVX import instruction encodings

2020-02-11 Thread Taylor Simpson
Hi Philippe, Thanks for all your feedback. I' get your comments addressed soon. I'm sorry you had trouble applying this patch. The target/hexagon/imported/encode.def should have been created by patch 17. Did you apply that one? Taylor > -Original Message- > From: Philippe Mathieu

Re: [PATCH v1 0/2] Improve virtio_check_params test

2020-02-11 Thread Philippe Mathieu-Daudé
Hi Denis, On 2/11/20 3:25 PM, Denis Plotnikov wrote: * fixed failing on non-existed machine type removal * the test refactored to add more parameters to check Gereral questions left: How to restric test for using: 1. on a set of target OS-es 2. on a set target architectures De

Re: [RFC PATCH 55/66] Hexagon HVX import instruction encodings

2020-02-11 Thread Philippe Mathieu-Daudé
On 2/11/20 3:35 PM, Taylor Simpson wrote: Hi Philippe, Thanks for all your feedback. I' get your comments addressed soon. I'm sorry you had trouble applying this patch. No problem. The target/hexagon/imported/encode.def should have been created by patch 17. Did you apply that one? Ah,

[Bug 1661815] Re: Stack address is returned from function translate_one

2020-02-11 Thread Thomas Huth
Fixed here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=344a7f656e8d211cdd6e ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1661815 Title:

Re: [RFC PATCH 55/66] Hexagon HVX import instruction encodings

2020-02-11 Thread Philippe Mathieu-Daudé
On Tue, Feb 11, 2020 at 3:40 PM Philippe Mathieu-Daudé wrote: > > On 2/11/20 3:35 PM, Taylor Simpson wrote: > > Hi Philippe, > > > > Thanks for all your feedback. I' get your comments addressed soon. > > > > I'm sorry you had trouble applying this patch. > > No problem. > > > The target/hexagon/i

Re: [PATCH v1 0/2] Improve virtio_check_params test

2020-02-11 Thread Denis Plotnikov
On 11.02.2020 17:37, Philippe Mathieu-Daudé wrote: Hi Denis, On 2/11/20 3:25 PM, Denis Plotnikov wrote: * fixed failing on non-existed machine type removal * the test refactored to add more parameters to check Gereral questions left:     How to restric test for using:     1. on a set of tar

[Bug 1661386] Re: Assertion `ret == cpu->kvm_msr_buf->nmsrs' failed

2020-02-11 Thread Thomas Huth
There was a fix for this assertion message wrt PMU registers in December 2017 already: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=0b368a10c71af96f6cf Thus, can you still reproduce this issue with the latest version of QEMU, or is the problem gone now? ** Changed in: qemu Status: New

[Bug 1665389] Re: Nested kvm guest fails to start on a emulated Westmere CPU guest under a Broadwell CPU host

2020-02-11 Thread Thomas Huth
Can you still reproduce this issue with the latest version of QEMU (v4.2)? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1665389 Title: Nested

[Bug 1649040] Re: Ubuntu 16.04.1 Grub Splash Doesn't Appear

2020-02-11 Thread Thomas Huth
Does this still happen with a newer version of Ubuntu and the latest version of QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1649040 Title

Re: [PATCH v15 8/9] hw/arm/virt: Add the virtio-iommu device tree mappings

2020-02-11 Thread Peter Maydell
On Sat, 8 Feb 2020 at 12:01, Eric Auger wrote: > > Adds the "virtio,pci-iommu" node in the host bridge node and > the RID mapping, excluding the IOMMU RID. > > This is done in the virtio-iommu-pci hotplug handler which > gets called only if no firmware is loaded or if -no-acpi is > passed on the c

Re: [PATCH v15 0/9] VIRTIO-IOMMU device

2020-02-11 Thread Peter Maydell
On Tue, 11 Feb 2020 at 13:56, Michael S. Tsirkin wrote: > > On Sat, Feb 08, 2020 at 01:00:13PM +0100, Eric Auger wrote: > > This series implements the QEMU virtio-iommu device. > > > > This matches the v0.12 spec (voted) and the corresponding > > virtio-iommu driver upstreamed in 5.3. All kernel d

Re: [PATCH 1/7] migration/block-dirty-bitmap: refactor incoming state to be one struct

2020-02-11 Thread Vladimir Sementsov-Ogievskiy
24.01.2020 13:56, Juan Quintela wrote: Vladimir Sementsov-Ogievskiy wrote: Move enabled_bitmaps and finish_lock, which are part of incoming state to DirtyBitmapLoadState, and make static global variable to store state instead of static local one. Signed-off-by: Vladimir Sementsov-Ogievskiy --

[Bug 1853826] Re: ELF loader fails to load shared object on ThunderX2 running RHEL7

2020-02-11 Thread Thomas Huth
** Bug watch removed: github.com/DynamoRIO/dynamorio/issues #3385 https://github.com/DynamoRIO/dynamorio/issues/3385 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1853826 Title: ELF loader fails

Re: [PATCH 4/7] migration/block-dirty-bitmap: keep bitmap state for all bitmaps

2020-02-11 Thread Vladimir Sementsov-Ogievskiy
24.01.2020 14:01, Juan Quintela wrote: Vladimir Sementsov-Ogievskiy wrote: Keep bitmap state for disabled bitmaps too. Keep the state until the end of the process. It's needed for the following commit to implement bitmap postcopy canceling. Signed-off-by: Vladimir Sementsov-Ogievskiy - -

Re: [PATCH 4/7] migration/block-dirty-bitmap: keep bitmap state for all bitmaps

2020-02-11 Thread Vladimir Sementsov-Ogievskiy
22.01.2020 16:23, Vladimir Sementsov-Ogievskiy wrote: Keep bitmap state for disabled bitmaps too. Keep the state until the end of the process. It's needed for the following commit to implement bitmap postcopy canceling. Signed-off-by: Vladimir Sementsov-Ogievskiy --- migration/block-dirty-bit

Re: [RFC PATCH 33/66] Hexagon TCG generation helpers - step 1

2020-02-11 Thread Philippe Mathieu-Daudé
On 2/11/20 1:40 AM, Taylor Simpson wrote: Helpers for reading and writing registers Helpers for getting and setting parts of values (e.g., set bit) Signed-off-by: Taylor Simpson --- target/hexagon/genptr_helpers.h | 323 1 file changed, 323 insertions

docs: Update vhost-user spec regarding backend program conventions

2020-02-11 Thread Boeuf, Sebastien
From c073d528b8cd7082832fd1825dc33dd65b305aa2 Mon Sep 17 00:00:00 2001 From: Sebastien Boeuf Date: Tue, 11 Feb 2020 16:01:22 +0100 Subject: [PATCH] docs: Update vhost-user spec regarding backend program conventions The vhost-user specification is not clearly stating the expected behavior from a

Re: [PATCH v2 01/33] block: Add BlockDriver.is_format

2020-02-11 Thread Alberto Garcia
On Tue 04 Feb 2020 06:08:16 PM CET, Max Reitz wrote: > We want to unify child_format and child_file at some point. One of the > important things that set format drivers apart from other drivers is > that they do not expect other format nodes under them (except in the > backing chain). That means

Re: [RFC PATCH 10/66] Hexagon register fields

2020-02-11 Thread Philippe Mathieu-Daudé
On 2/11/20 1:39 AM, Taylor Simpson wrote: Declare bitfields within registers such as user status register (USR) Signed-off-by: Taylor Simpson --- target/hexagon/reg_fields.c | 28 +++ target/hexagon/reg_fields.h | 40 +++ target/hexagon/reg_fields_def.h | 109 +

Re: [PATCH v2 02/33] block: Rename BdrvChildRole to BdrvChildClass

2020-02-11 Thread Alberto Garcia
On Tue 04 Feb 2020 06:08:17 PM CET, Max Reitz wrote: > This structure nearly only contains parent callbacks for child state > changes. It cannot really reflect a child's role, because different > roles may overlap (as we will see when real roles are introduced), and > because parents can have cust

Re: [RFC PATCH 00/66] Hexagon patch series

2020-02-11 Thread Philippe Mathieu-Daudé
Hi Taylor, On 2/11/20 1:39 AM, Taylor Simpson wrote: This series adds support for the Hexagon processor with Linux user support [...]> MAINTAINERS |8 + configure|9 + default-configs/hexagon-linux-user.mak

Re: [kvm-unit-tests PATCH v2 4/9] arm: pmu: Check Required Event Support

2020-02-11 Thread Peter Maydell
On Thu, 30 Jan 2020 at 11:25, Eric Auger wrote: > > If event counters are implemented check the common events > required by the PMUv3 are implemented. > > Some are unconditionally required (SW_INCR, CPU_CYCLES, > either INST_RETIRED or INST_SPEC). Some others only are > required if the implementat

Re: [PATCH v2 03/33] block: Add BdrvChildRole

2020-02-11 Thread Eric Blake
On 2/6/20 4:49 AM, Max Reitz wrote: + +    /* Filtered child */ +    BDRV_CHILD_FILTERED = (1 << 2), I'm not sure this comment does justice for what the flag represents, but am not sure of what longer comment to put in its place. You’re right. I thought I could just rely on our .is_filt

Re: [PATCH v2 04/33] block: Add BdrvChildRole to BdrvChild

2020-02-11 Thread Eric Blake
On 2/6/20 4:53 AM, Max Reitz wrote: +++ b/block.c @@ -2381,6 +2381,7 @@ static void bdrv_replace_child(BdrvChild *child, BlockDriverState *new_bs)   BdrvChild *bdrv_root_attach_child(BlockDriverState *child_bs,     const char *child_name,   

Re: [PATCH v2 15/33] block: Pull out bdrv_default_perms_for_backing()

2020-02-11 Thread Eric Blake
On 2/6/20 5:19 AM, Max Reitz wrote: On 05.02.20 21:56, Eric Blake wrote: On 2/4/20 11:08 AM, Max Reitz wrote: Signed-off-by: Max Reitz Rather light on the commit message. But looks like straightforward refactoring (with the previous patch making it easier to follow). Would this work: Righ

Re: [PATCH v2 22/33] block: Make backing files child_of_bds children

2020-02-11 Thread Eric Blake
On 2/6/20 5:33 AM, Max Reitz wrote: On 05.02.20 23:45, Eric Blake wrote: On 2/4/20 11:08 AM, Max Reitz wrote: Signed-off-by: Max Reitz Another sparse commit message (a recurring theme of this series). The subject line says 'what', and the patch appears to be faithful to that, but if a future

Re: [PATCH v2 0/4] linux-user: fix use of SIGRTMIN

2020-02-11 Thread Laurent Vivier
Peter, do you have any comment on this way to fix the SIGRTMIN problem we have now for years? Thanks, Laurent Le 04/02/2020 à 18:10, Laurent Vivier a écrit : > This series fixes the problem of the first real-time signals already > in use by the glibc that are not available for the target glibc.

Re: [PATCH v2 03/33] block: Add BdrvChildRole

2020-02-11 Thread Alberto Garcia
On Tue 04 Feb 2020 06:08:18 PM CET, Max Reitz wrote: > +/* Child to COW from (backing child) */ > +BDRV_CHILD_COW = (1 << 3), Without the comment in brackets I'm not sure that I would have understood that this is meant for backing files. This is the "child that contains the data

Re: [PATCH v2 27/33] tests: Use child_of_bds instead of child_file

2020-02-11 Thread Eric Blake
On 2/4/20 11:08 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- Another sparse commit message. tests/test-bdrv-drain.c | 29 + tests/test-bdrv-graph-mod.c | 6 -- 2 files changed, 21 insertions(+), 14 deletions(-) Just touches the tests - so if t

  1   2   3   >