From: Richard Henderson
Tested-by: Alex Bennée
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
Message-id: 20200206105448.4726-32-richard.hender...@linaro.org
Signed-off-by: Peter Maydell
---
target/arm/helper.c | 25 ++---
1 file changed, 18 insertions(+), 7
From: Alex Bennée
According to ARM ARM we should only trap from the EL1&0 regime.
Tested-by: Alex Bennée
Reviewed-by: Peter Maydell
Signed-off-by: Alex Bennée
Signed-off-by: Richard Henderson
Message-id: 20200206105448.4726-35-richard.hender...@linaro.org
Signed-off-by: Peter Maydell
---
t
From: Richard Henderson
This is part of a reorganization to the set of mmu_idx.
The EL3 regime only has a single stage translation, and
is always secure.
Tested-by: Alex Bennée
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
Message-id: 20200206105448.4726-14-richard.hender...@linar
From: Richard Henderson
When VHE is enabled, the exception level below EL2 is not EL1,
but EL0, and so to identify the entry vector offset for exceptions
targeting EL2 we need to look at the width of EL0, not of EL1.
Tested-by: Alex Bennée
Reviewed-by: Peter Maydell
Signed-off-by: Richard Hend
From: Richard Henderson
Replace the magic numbers with the relevant ARM_MMU_IDX_M_* constants.
Keep the definitions short by referencing previous symbols.
Tested-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
Message-id: 20200206105448.4726-19-richard.hen
From: Richard Henderson
Tested-by: Alex Bennée
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
Message-id: 20200206105448.4726-38-richard.hender...@linaro.org
Signed-off-by: Peter Maydell
---
target/arm/cpu64.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/target/arm/cpu64.
From: Richard Henderson
Return the indexes for the EL2&0 regime when the appropriate bits
are set within HCR_EL2.
Tested-by: Alex Bennée
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
Message-id: 20200206105448.4726-22-richard.hender...@linaro.org
Signed-off-by: Peter Maydell
---
From: Richard Henderson
Avoid redundant computation of cpu state by passing it in
from the caller, which has already computed it for itself.
Tested-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
Message-id: 20200206105448.4726-40-richard.hender...@linaro.
From: Richard Henderson
We had completely run out of TBFLAG bits.
Split A- and M-profile bits into two overlapping buckets.
This results in 4 free bits.
We used to initialize all of the a32 and m32 fields in DisasContext
by assignment, in arm_tr_init_disas_context. Now we only initialize
either
From: Rene Stange
TD (two dimensions) DMA mode did not work, because the xlen variable
has not been re-initialized before each additional ylen run through
in bcm2835_dma_update(). Fix it.
Signed-off-by: Rene Stange
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Peter Maydell
---
hw/dma/b
From: Richard Henderson
The comment that we don't support EL2 is somewhat out of date.
Update to include checks against HCR_EL2.TDZ.
Tested-by: Alex Bennée
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
Message-id: 20200206105448.4726-24-richard.hender...@linaro.org
Signed-off-by:
From: Richard Henderson
Use the correct sctlr for EL2&0 regime. Due to header ordering,
and where arm_mmu_idx_el is declared, we need to move the function
out of line. Use the function in many more places in order to
select the correct control.
Tested-by: Alex Bennée
Reviewed-by: Alex Bennée
From: Richard Henderson
This inline function has one user in cpu.c, and need not be exposed
otherwise. Code movement only, with fixups for checkpatch.
Tested-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
Message-id: 20200206105448.4726-39-richard.hender
Hi
On Fri, Jan 31, 2020 at 4:45 PM Igor Mammedov wrote:
>
> Function will report error that will mention global mem_path,
> which was valid the only if legacy -mem-path was used and
> only in case of main RAM.
>
> However it doesn't work with hostmem backends
> (for example:
> "
> qemu: -object
From: Richard Henderson
Tested-by: Alex Bennée
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
Message-id: 20200206105448.4726-26-richard.hender...@linaro.org
Signed-off-by: Peter Maydell
---
target/arm/cpu-qom.h | 1 +
target/arm/cpu.h | 11 +
target/arm/cpu.c |
From: Richard Henderson
Several of the EL1/0 registers are redirected to the EL2 version when in
EL2 and HCR_EL2.E2H is set. Many of these registers have side effects.
Link together the two ARMCPRegInfo structures after they have been
properly instantiated. Install common dispatch routines to a
From: Richard Henderson
The value computed is fully boolean; using int8_t is odd.
Tested-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
Message-id: 20200206105448.4726-41-richard.hender...@linaro.org
Signed-off-by: Peter Maydell
---
target/arm/cpu.c | 6
Currently 9pfs is only taken care of by Greg. Since I am actively working
on 9pfs and already became quite used to the code base, it makes sense to
volunteer as reviewer for 9pfs related patches.
Signed-off-by: Christian Schoenebeck
Cc: Greg Kurz
---
MAINTAINERS | 1 +
1 file changed, 1 inserti
From: Richard Henderson
Tested-by: Alex Bennée
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
Message-id: 20200206105448.4726-27-richard.hender...@linaro.org
Signed-off-by: Peter Maydell
---
target/arm/helper.c | 102 +++-
1 file changed, 81
From: Richard Henderson
The fall through organization of this function meant that we
would raise an interrupt, then might overwrite that with another.
Since interrupt prioritization is IMPLEMENTATION DEFINED, we
can recognize these in any order we choose.
Unify the code to raise the interrupt in
From: Richard Henderson
When TGE+E2H are both set, CPACR_EL1 is ignored.
Tested-by: Alex Bennée
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
Message-id: 20200206105448.4726-34-richard.hender...@linaro.org
Signed-off-by: Peter Maydell
---
target/arm/helper.c | 53 +
From: Richard Henderson
The EL2&0 translation regime is affected by Load Register (unpriv).
The code structure used here will facilitate later changes in this
area for implementing UAO and NV.
Tested-by: Alex Bennée
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
Message-id: 2020
From: Pan Nengyuan
There is a memory leak when we call 'device_list_properties' with typename =
stellaris-gptm. It's easy to reproduce as follow:
virsh qemu-monitor-command vm1 --pretty '{"execute":
"device-list-properties", "arguments": {"typename": "stellaris-gptm"}}'
This patch delay tim
From: Rene Stange
In TD (two dimensions) DMA mode ylen has to be increased by one after
reading it from the TXFR_LEN register, because a value of zero has to
result in one run through of the ylen loop. This has been tested on a
real Raspberry Pi 3 Model B+. In the previous implementation the ylen
On 2/7/20 7:55 AM, Daniel P. Berrangé wrote:
When initializing the LUKS header the size with default encryption
parameters will currently be 2068480 bytes. This is rounded up to
a multiple of the cluster size, 2081792, with 64k sectors. If the
end of the header is not the same as the end of the c
On 29/01/2020 21:23, Philippe Mathieu-Daudé wrote:
Add a helper to query the list of accelerators built into a
QEMU binary.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Liam Merwick
---
python/qemu/binutils.py | 10 ++
tests/acceptance/core_scripts.py | 10 +
Il ven 7 feb 2020, 15:32 Eric Blake ha scritto:
> But when I spent a mere 30 minutes seeing
> what it would take, I quickly learned that there is enough arcane
> Makefile magic going on in building from subdirectories that it wasn't
> worth my time to figure out how, especially if all that magic
From: Philippe Mathieu-Daudé
The bold text sounds like 'knock knock'. Only bolding the
second 'not' makes it easier to read.
Fixes: dea101a1ae
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Andrew Jones
Message-id: 20200206225148.23923-1-phi...@redhat.com
Signed-off-by: Peter Maydell
---
On 07.02.20 13:07, Vladimir Sementsov-Ogievskiy wrote:
> 07.02.2020 13:33, Max Reitz wrote:
>> On 04.02.20 15:23, Eric Blake wrote:
>>> On 2/4/20 7:59 AM, Vladimir Sementsov-Ogievskiy wrote:
>>>
> I understand that it is safer to have restrictions now and lift them
> later, than to allow us
From: Pan Nengyuan
There is a memory leak when we call 'device_list_properties' with typename =
armv7m_systick. It's easy to reproduce as follow:
virsh qemu-monitor-command vm1 --pretty '{"execute":
"device-list-properties", "arguments": {"typename": "armv7m_systick"}}'
This patch delay tim
Hi Zoltan,
On 2/6/20 1:21 PM, BALATON Zoltan wrote:
On Thu, 6 Feb 2020, Philippe Mathieu-Daudé wrote:
When booting without device tree, the Linux kernels uses the $R1
register to determine the machine type. The list of values is
registered at [1].
There are two entries for the Raspberry Pi:
-
From: Pan Nengyuan
There is a memory leak when we call 'device_list_properties' with typename =
stm32f2xx_timer. It's easy to reproduce as follow:
virsh qemu-monitor-command vm1 --pretty '{"execute":
"device-list-properties", "arguments": {"typename": "stm32f2xx_timer"}}'
This patch delay
07.02.2020 17:41, Max Reitz wrote:
On 07.02.20 13:07, Vladimir Sementsov-Ogievskiy wrote:
07.02.2020 13:33, Max Reitz wrote:
On 04.02.20 15:23, Eric Blake wrote:
On 2/4/20 7:59 AM, Vladimir Sementsov-Ogievskiy wrote:
I understand that it is safer to have restrictions now and lift them
later,
Tested-by: Michael Rolnik
On Fri, Feb 7, 2020 at 3:58 AM Aleksandar Markovic <
aleksandar.marko...@rt-rk.com> wrote:
> From: Michael Rolnik
>
> This includes definitions of various basic parameters needed
> for integration of a new platform into QEMU.
>
> [AM: Split a larger AVR introduction pa
On 2/7/20 4:17 AM, Gerd Hoffmann wrote:
When specified just set null_cursor to NULL so we get the default
pointer instead of a blank pointer.
Signed-off-by: Gerd Hoffmann
---
ui/gtk.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/ui/gtk.c b/ui/gtk.c
index d188
On 07.02.20 15:53, Vladimir Sementsov-Ogievskiy wrote:
> 07.02.2020 17:41, Max Reitz wrote:
>> On 07.02.20 13:07, Vladimir Sementsov-Ogievskiy wrote:
>>> 07.02.2020 13:33, Max Reitz wrote:
On 04.02.20 15:23, Eric Blake wrote:
> On 2/4/20 7:59 AM, Vladimir Sementsov-Ogievskiy wrote:
>
>
On 29/01/2020 21:23, Philippe Mathieu-Daudé wrote:
Instead of parsing the process help output, use the
binary_get_accels() helper which queries the list of
accelerators over a QMP socket.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Liam Merwick
---
python/qemu/accel.py | 26
The counting code here should use the local variable n_nodes_local.
Otherwise, the variable n_nodes is counting incorrectly, causing the
counting logic of the code to be wrong.
Signed-off-by: Tianjia Zhang
---
tests/test-rcu-list.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --gi
From: "Emilio G. Cota"
Reported-by: Robert Henry
Signed-off-by: Emilio G. Cota
Message-Id: <20200105072940.32204-1-c...@braap.org>
---
plugins/core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/plugins/core.c b/plugins/core.c
index 9e1b9e7a915..ed863011baf 100644
--- a/plugins/core.c
+
Peter Maydell writes:
> On Fri, 7 Feb 2020 at 10:24, Kevin Wolf wrote:
>>
>> Am 07.02.2020 um 10:28 hat Markus Armbruster geschrieben:
>> > Peter Maydell writes:
>> > > @@ -4703,7 +4703,7 @@
>> > > #
>> > > # Options for creating an image format on a given node.
>> > > #
>> > > -# @driver
On 07.02.20 15:43, Markus Armbruster wrote:
[...]
> # @file:
> # Node to create the image format on
> #
> # @size:
> # Size of the virtual disk in bytes
> #
> # @log-size:
> # Log size in bytes, must be a multiple of 1 MB (default: 1 MB)
> #
> # @block-size
Hi,
A few bits and pieces for plugin cleanup. The most major thing in this
series is tweaking the riscv decoder to only load the instruction
bytes it needs.
Alex Bennée (3):
docs/devel: document query handle lifetimes
target/riscv: progressively load the instruction during decode
tests/plug
Initialize EHCI controllers on AST2600 using the existing
TYPE_PLATFORM_EHCI. After this change, booting ast2600-evb
into Linux successfully instantiates a USB interface after
the necessary changes are made to its devicetree files.
ehci_hcd: USB 2.0 'Enhanced' Host Controller (EHCI) Driver
ehci-pl
On 29/01/2020 21:23, Philippe Mathieu-Daudé wrote:
Since QEMU binaries can be built with various configurations,
the list of devices linked in can vary.
Add a helper to query the list of devices built into a
QEMU binary.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Liam Merwick
---
From: Chen Qun
According to the glibc function requirements, we need initialise
the variable. Otherwise there will be compilation warnings:
glib-autocleanups.h:28:3: warning: ‘out’ may be
used uninitialized in this function [-Wmaybe-uninitialized]
g_free (*pp);
^~~~
Reported-by:
On 2/7/20 8:41 AM, Max Reitz wrote:
I could imagine a user creating a qcow2 image on some block device with
preallocation where we cannot verify that the result will be zero. But
they want qemu not to zero the device, so they would specify
--target-is-zero.
If user create image, setting --tar
The plugin system would throw up a harmless warning when it detected
that a disassembly of an instruction didn't use all it's bytes. Fix
the riscv decoder to only load the instruction bytes it needs as it
needs them.
This drops opcode from the ctx in favour if passing the appropriately
sized opcod
The following changes since commit 863d2ed5823f90c42dcd481687cc99cbc9c4a17c:
Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2020-02-06'
into staging (2020-02-06 16:22:05 +)
are available in the Git repository at:
https://gitlab.com/philmd/qemu.git tags/pytho
I forgot to document the lifetime of handles in the developer
documentation. Do so now.
Signed-off-by: Alex Bennée
---
docs/devel/tcg-plugins.rst | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/docs/devel/tcg-plugins.rst b/docs/devel/tcg-plugins.rst
index 718ee
>
> are available in the Git repository at:
>
> git://git.kraxel.org/qemu tags/audio-20200207-pull-request
>
> for you to fetch changes up to ed2a4a794184df3dbd5ee4cc06e86fe220663faf:
>
> audio: proper support for f
TCG plugins are responsible for their own memory usage and although
the plugin_exit is tied to the end of execution in this case it is
still poor practice. Ensure we delete the hash table and related data
when we are done to be a good plugin citizen.
Signed-off-by: Alex Bennée
---
tests/plugin/h
On 07.02.20 15:57, Eric Blake wrote:
> On 2/7/20 8:41 AM, Max Reitz wrote:
>
I could imagine a user creating a qcow2 image on some block device with
preallocation where we cannot verify that the result will be zero. But
they want qemu not to zero the device, so they would specify
>
Use the program search path to find the Python 3 interpreter.
Patch created mechanically by running:
$ sed -i "s,^#\!/usr/bin/\(env\ \)\?python$,#\!/usr/bin/env python3," \
$(git grep -lF '#!/usr/bin/env python' \
| xargs grep -L 'if __name__.*__main__')
Reported-by: Vladimir Semen
07.02.2020 18:03, Max Reitz wrote:
On 07.02.20 15:53, Vladimir Sementsov-Ogievskiy wrote:
07.02.2020 17:41, Max Reitz wrote:
On 07.02.20 13:07, Vladimir Sementsov-Ogievskiy wrote:
07.02.2020 13:33, Max Reitz wrote:
On 04.02.20 15:23, Eric Blake wrote:
On 2/4/20 7:59 AM, Vladimir Sementsov-Og
On Fri, 7 Feb 2020 12:05:09 +
Peter Maydell wrote:
> On Tue, 28 Jan 2020 at 19:36, Cornelia Huck wrote:
> >
> > While at it, also fix the numbering in 'What QEMU does'.
> >
> > Signed-off-by: Cornelia Huck
> > ---
>
> > diff --git a/docs/devel/s390-dasd-ipl.txt b/docs/devel/s390-dasd-ipl
* Peter Maydell (peter.mayd...@linaro.org) wrote:
> So far we've been converting docs to Sphinx and assigning them
> to manuals according to the division originally set out by
> Paolo on the wiki: https://wiki.qemu.org/Features/Documentation
>
> * QEMU User-mode Emulation User's Guide (docs/user)
On Fri, 7 Feb 2020 at 14:43, Markus Armbruster wrote:
> Here's a style I'd dislike less:
>
> # @file: Node to create the image format on
> #
> # @size: Size of the virtual disk in bytes
> #
> # @log-size: Log size in bytes, must be a multiple of 1 MB
> # (default: 1 M
On 07.02.20 14:55, Daniel P. Berrangé wrote:
> When initializing the LUKS header the size with default encryption
> parameters will currently be 2068480 bytes. This is rounded up to
> a multiple of the cluster size, 2081792, with 64k sectors. If the
> end of the header is not the same as the end of
07.02.2020 18:12, Max Reitz wrote:
On 07.02.20 15:57, Eric Blake wrote:
On 2/7/20 8:41 AM, Max Reitz wrote:
I could imagine a user creating a qcow2 image on some block device with
preallocation where we cannot verify that the result will be zero. But
they want qemu not to zero the device, so
* David Hildenbrand (da...@redhat.com) wrote:
>
>
> > Am 06.02.2020 um 21:11 schrieb Dr. David Alan Gilbert :
> >
> > * David Hildenbrand (da...@redhat.com) wrote:
> >> We already allow resizable ram blocks for anonymous memory, however, they
> >> are not actually resized. All memory is mmaped(
On 07.02.20 16:16, Vladimir Sementsov-Ogievskiy wrote:
> 07.02.2020 18:03, Max Reitz wrote:
>> On 07.02.20 15:53, Vladimir Sementsov-Ogievskiy wrote:
>>> 07.02.2020 17:41, Max Reitz wrote:
On 07.02.20 13:07, Vladimir Sementsov-Ogievskiy wrote:
> 07.02.2020 13:33, Max Reitz wrote:
>> On
On Fri, 7 Feb 2020 12:43:03 +
Peter Maydell wrote:
> On Tue, 28 Jan 2020 at 19:39, Cornelia Huck wrote:
> >
> > Move to system/, as this is mostly about configuring vfio-ap.
> >
> > Signed-off-by: Cornelia Huck
>
> > diff --git a/docs/vfio-ap.txt b/docs/system/vfio-ap.rst
> > similarity
Peter Maydell writes:
> Our current QAPI doc-comment markup allows section headers
> (introduced with a leading '=' or '==') anywhere in any documentation
> comment. This works for texinfo because the texi generator simply
> prints a texinfo heading directive at that point in the output
> stream
Am 07.02.2020 um 16:01 hat Max Reitz geschrieben:
> On 07.02.20 15:43, Markus Armbruster wrote:
>
> [...]
>
> > # @file:
> > # Node to create the image format on
> > #
> > # @size:
> > # Size of the virtual disk in bytes
> > #
> > # @log-size:
> > # Log size in byt
On 2/7/20 3:49 PM, Guenter Roeck wrote:
> Initialize EHCI controllers on AST2600 using the existing
> TYPE_PLATFORM_EHCI. After this change, booting ast2600-evb
> into Linux successfully instantiates a USB interface after
> the necessary changes are made to its devicetree files.
>
> ehci_hcd: USB
On 2/7/20 3:49 PM, Guenter Roeck wrote:
> Initialize EHCI controllers on AST2600 using the existing
> TYPE_PLATFORM_EHCI. After this change, booting ast2600-evb
> into Linux successfully instantiates a USB interface after
> the necessary changes are made to its devicetree files.
>
> ehci_hcd: USB
On 2/7/20 12:43 PM, Taylor Simpson wrote:
>
>> -Original Message-
>> From: Richard Henderson
>>
>> But I encourage you to re-think your purely mechanical approach to the
>> hexagon port. It seems to me that you should be doing much more during
>> the translation phase so that you can mi
On Fri, 7 Feb 2020 00:40:31 +0100
Paolo Bonzini wrote:
> On 07/02/20 00:24, Alex Williamson wrote:
> > Hey Paolo,
> >
> > My Windows 10 VM boot loops with this :-\ It seems to be related to
> > the CPU model. Now fails (host-passthrough):
> >
> > -cpu
> > host,hv-time,hv-relaxed,hv-vapic,hv-
> -Original Message-
> From: David Hildenbrand [mailto:da...@redhat.com]
> Sent: 06 February 2020 14:55
> To: Shameerali Kolothum Thodi ;
> Igor Mammedov
> Cc: peter.mayd...@linaro.org; xiaoguangrong.e...@gmail.com;
> m...@redhat.com; shannon.zha...@gmail.com; qemu-devel@nongnu.org;
> xu
Kevin Wolf writes:
> Am 07.02.2020 um 15:01 hat Markus Armbruster geschrieben:
>> Philippe Mathieu-Daudé writes:
>>
>> > List this file in the proper section, so maintainers get
>> > notified when it is modified.
>> >
>> > Signed-off-by: Philippe Mathieu-Daudé
>> > ---
>> > Cc: Kevin Wolf
>>
On Fri, Feb 07, 2020 at 11:48:05AM +0300, Denis Plotnikov wrote:
>
>
> On 05.02.2020 14:19, Stefan Hajnoczi wrote:
> > On Tue, Feb 04, 2020 at 12:59:04PM +0300, Denis Plotnikov wrote:
> > >
> > > On 30.01.2020 17:58, Stefan Hajnoczi wrote:
> > > > On Wed, Jan 29, 2020 at 05:07:00PM +0300, Denis
backup-top "supports" write-unchanged, by skipping CBW operation in
backup_top_co_pwritev. But it forgets to do the same in
backup_top_co_pwrite_zeroes, as well as declare support for
BDRV_REQ_WRITE_UNCHANGED.
Fix this, and, while being here, declare also support for flags
supported by source chil
On Fri, 7 Feb 2020 at 15:35, Markus Armbruster wrote:
>
> Peter Maydell writes:
>
> > Our current QAPI doc-comment markup allows section headers
> > (introduced with a leading '=' or '==') anywhere in any documentation
> > comment. This works for texinfo because the texi generator simply
> > pri
Peter Maydell writes:
> Currently configure's has_sphinx_build() check simply runs a dummy
> sphinx-build and either passes or fails. This means that "no
> sphinx-build at all" and "sphinx-build exists but is too old" are
> both reported the same way.
>
> Further, we want to assume that all the
Cleanup after reviewing "ppc: function to setup latest class options":
https://www.mail-archive.com/qemu-devel@nongnu.org/msg677709.html
Since v3:
- addressed Laurent & Michael comments
Philippe Mathieu-Daudé (3):
hw: Do not initialize MachineClass::is_default to 0
hw: Make MachineClass::is_d
There's no good reason for it to be type int, change it to bool.
Suggested-by: Richard Henderson
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Philippe Mathieu-Daudé
---
v4:
- fixed incorrect changes to max_cpus (Laurent)
- describe field
---
include/hw/boards.h | 4 +++-
It would be confusing to have multiple default machines.
Abort if this ever occurs.
Signed-off-by: Philippe Mathieu-Daudé
---
v2: Use assert() instead of human friendly message (Marc-André)
v3: Move the check to find_machine() (Michael)
Cc: Marc-André Lureau
Cc: Laurent Vivier
Cc: Michael S. T
The MachineClass is already zeroed on creation.
Note: The code setting is_default=0 in hw/i386/pc_piix.c is
different (related to compat options). When adding a
new versioned machine, we want it to be the new default,
so we have to mark the previous one as not default.
Signed-of
On Fri, 7 Feb 2020 at 08:37, Thomas Huth wrote:
> Question to Peter/Alex/Stefan/Howevermergespullreqsinthefuture:
>
> Should the above jobs really be skipped for pull requests, or would it
> be ok to include them there, too? (in the latter case, the above changes
> could just be dropped)
I don't
On 2/7/20 5:07 PM, Markus Armbruster wrote:
Kevin Wolf writes:
Am 07.02.2020 um 15:01 hat Markus Armbruster geschrieben:
Philippe Mathieu-Daudé writes:
List this file in the proper section, so maintainers get
notified when it is modified.
Signed-off-by: Philippe Mathieu-Daudé
---
Cc: Kev
Document the virtiofsd(1) program and its command-line options. This
man page is a rST conversion of the original texi documentation that I
wrote.
Reviewed-by: Liam Merwick
Signed-off-by: Stefan Hajnoczi
---
v3:
* Dropped old -o vhost_user_socket=PATH option [dgilbert]
v2:
* Fix mount -t virt
On 07.02.20 17:12, Vladimir Sementsov-Ogievskiy wrote:
> backup-top "supports" write-unchanged, by skipping CBW operation in
> backup_top_co_pwritev. But it forgets to do the same in
> backup_top_co_pwrite_zeroes, as well as declare support for
> BDRV_REQ_WRITE_UNCHANGED.
>
> Fix this, and, while
On Thu, Feb 06, 2020 at 11:39:43AM +, Dr. David Alan Gilbert wrote:
> > + * vhost_user_socket=PATH -
> > +Listen on vhost-user UNIX domain socket at PATH.
>
> Isn't that the old one?
Thanks, will fix in v3.
Stefan
signature.asc
Description: PGP signature
On Fri, 7 Feb 2020 at 16:18, Markus Armbruster wrote:
>
> Peter Maydell writes:
>
> > Currently configure's has_sphinx_build() check simply runs a dummy
> > sphinx-build and either passes or fails. This means that "no
> > sphinx-build at all" and "sphinx-build exists but is too old" are
> > both
On Fri, Feb 7, 2020 at 5:21 PM Philippe Mathieu-Daudé wrote:
>
> It would be confusing to have multiple default machines.
> Abort if this ever occurs.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> v2: Use assert() instead of human friendly message (Marc-André)
> v3: Move the check to find_mac
Hi,
On Fri, 7 Feb 2020 at 10:01, Alex Bennée wrote:
> -static void decode_RV32_64C0(DisasContext *ctx)
> +static void decode_RV32_64C0(DisasContext *ctx, uint16_t opcode)
> {
> -uint8_t funct3 = extract32(ctx->opcode, 13, 3);
> -uint8_t rd_rs2 = GET_C_RS2S(ctx->opcode);
> -uint8_t rs1
On Fri, Feb 7, 2020 at 5:21 PM Philippe Mathieu-Daudé wrote:
>
> There's no good reason for it to be type int, change it to bool.
>
> Suggested-by: Richard Henderson
> Reviewed-by: Michael S. Tsirkin
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Marc-André Lureau
> ---
> v4:
> - fixe
On Fri, Feb 07, 2020 at 11:04:03AM +0100, Igor Mammedov wrote:
> On Fri, 7 Feb 2020 10:00:50 +0100
> Igor Kotrasiński wrote:
>
> > On 2/5/20 3:49 PM, Jan Kiszka wrote:
> > > On 05.02.20 15:39, Stefan Hajnoczi wrote:
> > >> On Tue, Feb 04, 2020 at 12:30:42PM +0100,
> > >> i.kotrasi...@partner.s
On Fri, 7 Feb 2020 at 10:01, Alex Bennée wrote:
>
> I forgot to document the lifetime of handles in the developer
> documentation. Do so now.
>
> Signed-off-by: Alex Bennée
Reviewed-by: Robert Foley
Regards,
-Rob
> ---
> docs/devel/tcg-plugins.rst | 13 +++--
> 1 file changed, 11 inser
On Mon, 3 Feb 2020 at 03:28, Cleber Rosa wrote
>>>> Testing process:
>>>>
>>>> * I get an email which is a pull request, and I run the
>>>>"apply-pullreq" script, which takes the GIT URL and tag/branch name
>>>>to test.
>>>> * apply-pullreq performs the merge into
* Stefan Hajnoczi (stefa...@redhat.com) wrote:
> Document the virtiofsd(1) program and its command-line options. This
> man page is a rST conversion of the original texi documentation that I
> wrote.
>
> Reviewed-by: Liam Merwick
> Signed-off-by: Stefan Hajnoczi
Reviewed-by: Dr. David Alan Gil
07.02.2020 19:30, Max Reitz wrote:
On 07.02.20 17:12, Vladimir Sementsov-Ogievskiy wrote:
backup-top "supports" write-unchanged, by skipping CBW operation in
backup_top_co_pwritev. But it forgets to do the same in
backup_top_co_pwrite_zeroes, as well as declare support for
BDRV_REQ_WRITE_UNCHANG
On Thu, Feb 06, 2020 at 07:42:45PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> Commit 7a3f542fbd "block/io: refactor padding" occasionally dropped
> aligning for zero-length request: bdrv_init_padding() blindly return
> false if bytes == 0, like there is nothing to align.
>
> This leads the follo
Robert Foley writes:
> Hi,
> On Fri, 7 Feb 2020 at 10:01, Alex Bennée wrote:
>> -static void decode_RV32_64C0(DisasContext *ctx)
>> +static void decode_RV32_64C0(DisasContext *ctx, uint16_t opcode)
>> {
>> -uint8_t funct3 = extract32(ctx->opcode, 13, 3);
>> -uint8_t rd_rs2 = GET_C_RS2
On Fri, Feb 07, 2020 at 01:14:04AM +0100, Philippe Mathieu-Daudé wrote:
> Commit ed65fd1a2750 ("virtio-blk: switch off scsi-passthrough by
> default") changed the default value of the 'scsi' property of
> virtio-blk, which is only available on Linux hosts. It also added
> an unconditional compat en
Robert Foley writes:
> This is version 1 of the patch series to
> add support for 2 aarch64 VMs.
> - Ubuntu 18.04 aarch64 VM
> - CentOS 8 aarch64 VM
Testing under TCG with:
make vm-build-ubuntu.aarch64 V=1 QEMU=aarch64-softmmu/qemu-system-aarch64
I'm seeing it hang:
DEBUG:root:ssh_
07.02.2020 19:47, Stefan Hajnoczi wrote:
On Thu, Feb 06, 2020 at 07:42:45PM +0300, Vladimir Sementsov-Ogievskiy wrote:
Commit 7a3f542fbd "block/io: refactor padding" occasionally dropped
aligning for zero-length request: bdrv_init_padding() blindly return
false if bytes == 0, like there is nothi
ranch 'remotes/maxreitz/tags/pull-block-2020-02-06'
> into staging (2020-02-06 16:22:05 +)
>
> are available in the Git repository at:
>
> https://gitlab.com/philmd/qemu.git tags/python-next-20200207
>
> for you to fetch changes up to 66e7dde18cc4085ca47124be4ca08
Peter Maydell writes:
> The MigrationInfo::setup-time documentation is the only place where
> we use _this_ inline markup to mean italics.
Nitpick: _this_ does not mean italics, it means emphasis. See
qapi-code-gen.txt section "Documentation markup". doc.py maps it to
@emph{this}, which Texinf
On Fri, 7 Feb 2020 at 16:54, Markus Armbruster wrote:
>
> Peter Maydell writes:
>
> > The MigrationInfo::setup-time documentation is the only place where
> > we use _this_ inline markup to mean italics.
>
> Nitpick: _this_ does not mean italics, it means emphasis. See
> qapi-code-gen.txt section
201 - 300 of 378 matches
Mail list logo
