Re: [PATCH v2 0/6] ui: rework -show-cursor option

2020-02-07 Thread Erik Skultety
On Thu, Feb 06, 2020 at 02:20:02PM +0100, Gerd Hoffmann wrote: > On Thu, Feb 06, 2020 at 11:52:05AM +, Peter Maydell wrote: > > On Thu, 6 Feb 2020 at 11:29, Gerd Hoffmann wrote: > > > > > > > > > > This cover letter is missing a description of what the patchset does... > > > > The closest thin

Re: [PATCH 04/29] qga/qapi-schema.json: Fix missing '-' in GuestDiskBusType doc comment

2020-02-07 Thread Markus Armbruster
Peter Maydell writes: > The doc comment for GuestDiskBusType doesn't match up with the > enumeration because of a missing hyphen in 'file-backed-virtual'. > This means the docs are rendered wrongly: >"virtual" >Win virtual bus type "file-backed" virtual: Win file-backed bus >

Re: [PATCH] hw/arm: ast2400/ast2500: Wire up EHCI controllers

2020-02-07 Thread Cédric Le Goater
On 2/6/20 7:34 PM, Guenter Roeck wrote: > Initialize EHCI controllers on AST2400 and AST2500 using the existing > TYPE_PLATFORM_EHCI. After this change, booting ast2500-evb into Linux > successfully instantiates a USB interface. > > ehci-platform 1e6a3000.usb: EHCI Host Controller > ehci-platform

Re: [PATCH v2 2/2] target/arm: kvm: Handle DABT with no valid ISS

2020-02-07 Thread Andrew Jones
On Thu, Feb 06, 2020 at 09:48:05PM +, Beata Michalska wrote: > On Wed, 5 Feb 2020 at 16:57, Andrew Jones wrote: > > > > On Wed, Jan 29, 2020 at 08:24:41PM +, Beata Michalska wrote: > > > On ARMv7 & ARMv8 some load/store instructions might trigger a data abort > > > exception with no valid

Re: [PATCH 05/29] qga/qapi-schema.json: Fix indent level on doc comments

2020-02-07 Thread Markus Armbruster
Peter Maydell writes: > The texinfo doc generation doesn't care much about indentation > levels, but we would like to add a rST backend, and rST does care > about indentation. > > Make the doc comments more strongly consistent about indentation > for multiline constructs like: > > @arg: descripti

Re: [PATCH 05/29] qga/qapi-schema.json: Fix indent level on doc comments

2020-02-07 Thread Markus Armbruster
Markus Armbruster writes: > Peter Maydell writes: > >> The texinfo doc generation doesn't care much about indentation >> levels, but we would like to add a rST backend, and rST does care >> about indentation. >> >> Make the doc comments more strongly consistent about indentation >> for multiline

Re: [PATCH] tests/qemu_iotests: Minimize usage of used ports

2020-02-07 Thread Max Reitz
On 06.02.20 19:33, Lukáš Doktor wrote: > Dne 06. 02. 20 v 17:59 Max Reitz napsal(a): >> On 06.02.20 17:48, Eric Blake wrote: >>> On 2/6/20 10:37 AM, Max Reitz wrote: [...] OTOH, would it work if we just did a %s/localhost/127.0.0.1/ in the test?  We have specific cases for IPv6, so I th

Re: [PATCH v2] docs/arm-cpu-features: Make kvm-no-adjvtime comment clearer

2020-02-07 Thread Andrew Jones
On Thu, Feb 06, 2020 at 11:51:48PM +0100, Philippe Mathieu-Daudé wrote: > The bold text sounds like 'knock knock'. Only bolding the Who's there? > second 'not' makes it easier to read. > > Fixes: dea101a1ae > Signed-off-by: Philippe Mathieu-Daudé > --- > v2: Removed unrelated hunk > --- > docs

[Bug 1852781] Re: qemu s390x on focal - applications breaking

2020-02-07 Thread Christian Ehrhardt 
FYI - Focal now contains 4.2 which might (or not) have the bits you need. You most likely get further, but I can't give guarantees if enough of march=z13 is supported to work for a full Focal (not sure on vector instructions for example) including all of userspace. Marking it incomplete - if som

Re: [PATCH 06/29] qga/qapi-schema.json: minor format fixups for rST

2020-02-07 Thread Markus Armbruster
Peter Maydell writes: > rST format requires a blank line before the start of a bulleted > or enumerated list. Two places in qapi-schema.json were missing > this blank line. > > Some places were using an indented line as a sort of single-item > bulleted list, which in the texinfo output comes out

Re: [RFC PATCH 2/2] GitLab CI: crude mapping of PMM's scripts to jobs

2020-02-07 Thread Thomas Huth
On 03/02/2020 04.23, Cleber Rosa wrote: > This is a crude and straightforward mapping of Peter's > "remake-merge-builds" and "pull-buildtest" scripts. > > Some characteristics were removed for simplicity sake (but eventually > will), including: > * number of simultaneous make jobs > * make's syn

Re: [PATCH] ppc: function to setup latest class options

2020-02-07 Thread Laurent Vivier
On 07/02/2020 07:48, Michael S. Tsirkin wrote: > We are going to add more init for the latest machine, so move the setup > to a function so we don't have to change the DEFINE_SPAPR_MACHINE macro > each time. > > Signed-off-by: Michael S. Tsirkin > --- > hw/ppc/spapr.c | 9 +++-- > 1 file cha

Re: [PATCH v1 2/4] virtio: increase virtuqueue size for virtio-scsi and virtio-blk

2020-02-07 Thread Denis Plotnikov
On 05.02.2020 14:19, Stefan Hajnoczi wrote: On Tue, Feb 04, 2020 at 12:59:04PM +0300, Denis Plotnikov wrote: On 30.01.2020 17:58, Stefan Hajnoczi wrote: On Wed, Jan 29, 2020 at 05:07:00PM +0300, Denis Plotnikov wrote: The goal is to reduce the amount of requests issued by a guest on 1M rea

Re: [PATCH 07/29] qapi/block-core.json: Use literal block for ascii art

2020-02-07 Thread Markus Armbruster
Peter Maydell writes: > The ascii-art graph in the BlockLatencyHistogramInfo > documentation doesn't render correctly in either the HTML > or the manpage output, because in both cases the whitespace > is collapsed. Plain text and PDF output is just as bad. Suggest "doesn't render correctly, bec

Re: [PATCH] Add support for a helper with 7 arguments

2020-02-07 Thread Richard Henderson
On 2/7/20 4:46 AM, Taylor Simpson wrote: >> I think that we can do the store immediately -- I give specifics above. Do >> you >> have a counter-example? Admittedly I'm new to browsing the architecture, >> but I >> don't see a legal packet for which you can't just Store Now. > > You can have two

Re: [RFC 0/9] Add an interVM memory sharing device

2020-02-07 Thread Igor Kotrasiński
On 2/5/20 3:49 PM, Jan Kiszka wrote: On 05.02.20 15:39, Stefan Hajnoczi wrote: On Tue, Feb 04, 2020 at 12:30:42PM +0100, i.kotrasi...@partner.samsung.com wrote: From: Igor Kotrasinski This patchset adds a "memory exposing" device that allows two QEMU instances to share arbitrary memory region

Re: [PATCH 07/29] qapi/block-core.json: Use literal block for ascii art

2020-02-07 Thread Peter Maydell
On Fri, 7 Feb 2020 at 08:50, Markus Armbruster wrote: > > Peter Maydell writes: > > > The ascii-art graph in the BlockLatencyHistogramInfo > > documentation doesn't render correctly in either the HTML > > or the manpage output, because in both cases the whitespace > > is collapsed. > > Plain text

Re: [PATCH 08/29] qapi: Use ':' after @argument in doc comments

2020-02-07 Thread Markus Armbruster
Peter Maydell writes: > Some qapi doc comments have forgotten the ':' after the > @argument, like this: > > # @filename Filename for the new image file > # @size Size of the virtual disk in bytes > > The result is that these are parsed as part of the body > text and appear as

Re: [PATCH 09/29] qapi: Fix indent level on doc comments in json files

2020-02-07 Thread Markus Armbruster
Peter Maydell writes: > The texinfo doc generation doesn't care much about > indentation levels, but we would like to add a rST > backend, and rST does care about indentation. > > Make the doc comments more strongly consistent about indentation > for multiline constructs like: > > @arg: descripti

[PATCH v14 01/11] virtio-iommu: Add skeleton

2020-02-07 Thread Eric Auger
This patchs adds the skeleton for the virtio-iommu device. Signed-off-by: Eric Auger Reviewed-by: Peter Xu --- v13 -> v14: - use device_class_set_props - updated copyright's year v12 -> v13 - removed IOMMU_PCI_BUS_MAX and IOMMU_PCI_DEVFN_MAX v11 -> v12: - remove s_by_bus_num - drop set_featu

[PATCH v14 00/11] VIRTIO-IOMMU device

2020-02-07 Thread Eric Auger
This series implements the QEMU virtio-iommu device. This matches the v0.12 spec (voted) and the corresponding virtio-iommu driver upstreamed in 5.3. All kernel dependencies are resolved for DT integration. The virtio-iommu can be instantiated in ARM virt using: "-device virtio-iommu-pci,x-dt-bin

[PATCH v14 05/11] virtio-iommu: Implement translate

2020-02-07 Thread Eric Auger
This patch implements the translate callback Signed-off-by: Eric Auger Reviewed-by: Jean-Philippe Brucker --- v11 -> v12: - Added Jean's R-b - s/qemu_log_mask/error_report_once v10 -> v11: - take into account the new value struct and use g_tree_lookup_extended - switched to error_report_onc

[PATCH v14 10/11] virtio-iommu: Support migration

2020-02-07 Thread Eric Auger
Add Migration support. We rely on recently added gtree and qlist migration. We only migrate the domain gtree. The endpoint gtree is re-constructed in a post-load operation. Signed-off-by: Eric Auger Acked-by: Peter Xu --- v11 -> v12: - do not migrate the endpoint gtree but reconstruct it from

Re: [PATCH 10/29] qapi: Remove hardcoded tabs

2020-02-07 Thread Markus Armbruster
Peter Maydell writes: > There are some stray hardcoded tabs in some of our json files; > remove them. > > Signed-off-by: Peter Maydell > --- > Most of the hardcoded tabs got removed in passing in > fixing the indent in lines that they were in, but > these are not part of doc comments. Reviewed-

[PATCH v14 09/11] hw/arm/virt: Add the virtio-iommu device tree mappings

2020-02-07 Thread Eric Auger
Adds the "virtio,pci-iommu" node in the host bridge node and the RID mapping, excluding the IOMMU RID. Signed-off-by: Eric Auger Reviewed-by: Jean-Philippe Brucker --- v11 -> v12: - Added Jean's R-b v10 -> v11: - remove msi_bypass v8 -> v9: - disable msi-bypass property - addition of the sub

[PATCH v14 06/11] virtio-iommu: Implement fault reporting

2020-02-07 Thread Eric Auger
The event queue allows to report asynchronous errors. The translate function now injects faults when relevant. Signed-off-by: Eric Auger Reviewed-by: Peter Xu --- v13 -> v14: - remove loop - add Peter's R-b v12 -> v13: - return on virtio_error() v11 -> v12: - reporting the addr associated wit

[PATCH v14 02/11] virtio-iommu: Decode the command payload

2020-02-07 Thread Eric Auger
This patch adds the command payload decoding and introduces the functions that will do the actual command handling. Those functions are not yet implemented. Signed-off-by: Eric Auger Reviewed-by: Jean-Philippe Brucker Reviewed-by: Peter Xu --- v11 -> v12: - ADded Jean and Peter's R-b v10 ->

[PATCH v14 03/11] virtio-iommu: Implement attach/detach command

2020-02-07 Thread Eric Auger
This patch implements the endpoint attach/detach to/from a domain. Domain and endpoint internal datatypes are introduced. Both are stored in RB trees. The domain owns a list of endpoints attached to it. Also helpers to get/put end points and domains are introduced. As for the IOMMU memory regions

Re: [PATCH 08/29] qapi: Use ':' after @argument in doc comments

2020-02-07 Thread Max Reitz
On 07.02.20 10:28, Markus Armbruster wrote: [...] > Loses the visual alignment. I'm okay with that, but the folks who took > the trouble to align the text may have different ideas. Cc'ing Kevin > and Max. I certainly don’t mind. Max signature.asc Description: OpenPGP digital signature

[PATCH v14 07/11] virtio-iommu-pci: Add virtio iommu pci support

2020-02-07 Thread Eric Auger
This patch adds virtio-iommu-pci, which is the pci proxy for the virtio-iommu device. Signed-off-by: Eric Auger Reviewed-by: Jean-Philippe Brucker --- v13 -> v14: - add device_class_set_props v11 -> v12: - added Jean's R-b - remove the array of intervals. Will be introduced later? v10 -> v11

[PATCH v14 04/11] virtio-iommu: Implement map/unmap

2020-02-07 Thread Eric Auger
This patch implements virtio_iommu_map/unmap. Signed-off-by: Eric Auger Reviewed-by: Peter Xu --- v11 -> v12: - check unmanaged managed flags on map - removed 2 qemu_log_mask in unmap() - fix leak v10 -> v11: - revisit the implementation of unmap according to Peter's suggestion - removed virt

[PATCH v14 11/11] tests: Add virtio-iommu test

2020-02-07 Thread Eric Auger
This adds the framework to test the virtio-iommu-pci device and tests exercising the attach/detach, map/unmap API. To run the tests: make tests/qtest/qos-test QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 tests/qtest/qos-test V=1 Signed-off-by: Eric Auger --- v13 -> v14: - changed copyri

[PATCH v14 08/11] virtio-iommu-pci: Introduce the x-dt-binding option

2020-02-07 Thread Eric Auger
At the moment, the kernel only supports device tree integration of the virtio-iommu. DT bindings between the PCI root complex and the IOMMU must be created by the machine in conformance to: Documentation/devicetree/bindings/virtio/iommu.txt. To make sure the end-user is aware of this, force him t

Re: [PATCH 11/29] qapi/ui.json: Put input-send-event body text in the right place

2020-02-07 Thread Markus Armbruster
Peter Maydell writes: > In the doc comment for input-send-event, there is a multi-line > chunk of text ("The @device...take precedence") which is intended > to be the main body text describing the event. However it has > been placed after the arguments and Returns: section, which > means that the

Re: [PATCH] travis.yml: Test the s390-ccw build, too

2020-02-07 Thread Cornelia Huck
On Thu, 6 Feb 2020 21:25:43 +0100 Thomas Huth wrote: > Since we can now use a s390x host on Travis, we can also build and > test the s390-ccw bios images there. For this we have to make sure > that roms/SLOF is checked out, too, and then move the generated *.img > files to the right location bef

[PATCH v2 2/2] virtiofsd: add it to the tools list

2020-02-07 Thread Laurent Vivier
it will be built only when tools are enabled (always enabled by default) Signed-off-by: Laurent Vivier Reviewed-by: Dr. David Alan Gilbert --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 23342a433e11..484fbb737858 100644 --- a/Makef

[PATCH v2 1/2] tests/vhost-user-bridge: move to contrib/

2020-02-07 Thread Laurent Vivier
vhost-user-bridge is not a test. Move it to contrib/ and add it to the tools list. It will be built only if tools (--enable-tools) and vhost-user (--enable-vhost-user) are enabled (both are set by default). Suggested-by: Dr. David Alan Gilbert Signed-off-by: Laurent Vivier Reviewed-by: Philippe

Re: [PATCH] travis.yml: Test the s390-ccw build, too

2020-02-07 Thread Thomas Huth
On 07/02/2020 10.47, Cornelia Huck wrote: > On Thu, 6 Feb 2020 21:25:43 +0100 > Thomas Huth wrote: > >> Since we can now use a s390x host on Travis, we can also build and >> test the s390-ccw bios images there. For this we have to make sure >> that roms/SLOF is checked out, too, and then move th

[PATCH] i.MX: Fix inverted register bits in wdt code.

2020-02-07 Thread Roman Kapl
Documentation says for WDA '0: Assert WDOG output.' and for SRS '0: Assert system reset signal.'. Signed-off-by: Roman Kapl --- hw/misc/imx2_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/imx2_wdt.c b/hw/misc/imx2_wdt.c index e47e442592..c8944729c4 100644 --- a

[PATCH] i.MX: Add support for WDT on i.MX6

2020-02-07 Thread Roman Kapl
Uses the i.MX2 rudimentary watchdog driver. Signed-off-by: Roman Kapl --- hw/arm/fsl-imx6.c | 21 + include/hw/arm/fsl-imx6.h | 4 2 files changed, 25 insertions(+) diff --git a/hw/arm/fsl-imx6.c b/hw/arm/fsl-imx6.c index 7b7b97f74c..f2adaca1c5 100644 --- a/hw/

Re: [RFC 0/9] Add an interVM memory sharing device

2020-02-07 Thread Igor Mammedov
On Fri, 7 Feb 2020 10:00:50 +0100 Igor Kotrasiński wrote: > On 2/5/20 3:49 PM, Jan Kiszka wrote: > > On 05.02.20 15:39, Stefan Hajnoczi wrote: > >> On Tue, Feb 04, 2020 at 12:30:42PM +0100, > >> i.kotrasi...@partner.samsung.com wrote: > >>> From: Igor Kotrasinski > >>> > >>> This patchset a

Re: [PATCH v14 08/11] virtio-iommu-pci: Introduce the x-dt-binding option

2020-02-07 Thread Jean-Philippe Brucker
Hi Eric, On Fri, Feb 07, 2020 at 10:32:00AM +0100, Eric Auger wrote: > At the moment, the kernel only supports device tree > integration of the virtio-iommu. DT bindings between the > PCI root complex and the IOMMU must be created by the machine > in conformance to: > > Documentation/devicetree/b

Re: [RFC PATCH 2/2] GitLab CI: crude mapping of PMM's scripts to jobs

2020-02-07 Thread Thomas Huth
On 07/02/2020 09.37, Thomas Huth wrote: > On 03/02/2020 04.23, Cleber Rosa wrote: >> This is a crude and straightforward mapping of Peter's >> "remake-merge-builds" and "pull-buildtest" scripts. >> >> Some characteristics were removed for simplicity sake (but eventually >> will), including: >> * n

Re: [PATCH 12/29] qapi: Explicitly put "foo: dropped in n.n" notes into Notes section

2020-02-07 Thread Markus Armbruster
Peter Maydell writes: > A handful of QAPI doc comments include lines like > "ppcemb: dropped in 3.1". The doc comment parser will just > put these into whatever the preceding section was; sometimes > that's "Notes", and sometimes it's some random other section, > as with "NetClientDriver" where t

Re: [PATCH v2] qapi: Allow getting flat output from 'query-named-block-nodes'

2020-02-07 Thread Max Reitz
On 20.01.20 09:50, Peter Krempa wrote: > When a management application manages node names there's no reason to > recurse into backing images in the output of query-named-block-nodes. > > Add a parameter to the command which will return just the top level > structs. > > Signed-off-by: Peter Krempa

Re: [PATCH 17/29] qapi: Add blank lines before bulleted lists

2020-02-07 Thread Philippe Mathieu-Daudé
On 2/6/20 6:30 PM, Peter Maydell wrote: rST insists on a blank line before and after a bulleted list, but our texinfo doc generator did not. Add some extra blank lines in the doc comments so they're acceptable rST input. Signed-off-by: Peter Maydell --- qapi/block-core.json | 1 + qapi/char.

Re: [PATCH v14 00/11] VIRTIO-IOMMU device

2020-02-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200207093203.3788-1-eric.au...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN =

Re: [PATCH 13/29] qapi/ui.json: Avoid `...' texinfo style quoting

2020-02-07 Thread Markus Armbruster
Peter Maydell writes: > Avoid texinfo style quoting with `...', because rST treats it > as a syntax error. Use '...' instead, as we do in other > doc comments. This looks OK in texinfo, and rST formats it as > paired-quotation-marks. It's kind of wrong in TexInfo; results in "Right single quotat

Re: [PATCH] ppc: function to setup latest class options

2020-02-07 Thread Greg Kurz
On Fri, 7 Feb 2020 01:48:02 -0500 "Michael S. Tsirkin" wrote: > We are going to add more init for the latest machine, so move the setup > to a function so we don't have to change the DEFINE_SPAPR_MACHINE macro > each time. > Not sure about the meaning of "change the DEFINE_SPAPR_MACHINE macro"

[PATCH v3 0/7] ui: rework -show-cursor option

2020-02-07 Thread Gerd Hoffmann
Add -display {sdl,gtk,cocoa},show-cursor=on as replacement for -show-cursor. sdl + cocoa are switched over (no change in behavior), gtk support is added. Gerd Hoffmann (7): ui: add show-cursor option ui: wire up legacy -show-cursor option ui/sdl: switch to new show-cursor option ui/cocoa:

[PATCH v3 2/7] ui: wire up legacy -show-cursor option

2020-02-07 Thread Gerd Hoffmann
Set new show-cursor display option when legacy -show-cursor is specified on the command line. Signed-off-by: Gerd Hoffmann --- vl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/vl.c b/vl.c index 7dcb0879c497..5419b3d68200 100644 --- a/vl.c +++ b/vl.c @@ -3554,6 +3554,8 @@ int main(int a

[PATCH v3 7/7] ui: deprecate legacy -show-cursor option

2020-02-07 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Ján Tomko --- vl.c | 2 ++ qemu-deprecated.texi | 5 + 2 files changed, 7 insertions(+) diff --git a/vl.c b/vl.c index 62efcd15c0bf..001be469c2e9 100644 --- a/vl.c +++ b/vl.c @@ -3562,6 +3562,8 @@ int main(int argc, char **argv, char

[PATCH v3 3/7] ui/sdl: switch to new show-cursor option

2020-02-07 Thread Gerd Hoffmann
Use DisplayOpts settings instead of cursor_hide global variable. Also make "-display sdl,show-cursor=on" work. Signed-off-by: Gerd Hoffmann --- ui/sdl2.c | 16 vl.c | 10 ++ 2 files changed, 18 insertions(+), 8 deletions(-) diff --git a/ui/sdl2.c b/ui/sdl2.c index

[PATCH v3 5/7] ui/gtk: implement show-cursor option

2020-02-07 Thread Gerd Hoffmann
When specified just set null_cursor to NULL so we get the default pointer instead of a blank pointer. Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index d18892d1de61..a685d1ae0848 100644 --- a/ui/gtk.c +

Re: [PATCH v14 08/11] virtio-iommu-pci: Introduce the x-dt-binding option

2020-02-07 Thread Auger Eric
Hi Jean, On 2/7/20 11:05 AM, Jean-Philippe Brucker wrote: > Hi Eric, > > On Fri, Feb 07, 2020 at 10:32:00AM +0100, Eric Auger wrote: >> At the moment, the kernel only supports device tree >> integration of the virtio-iommu. DT bindings between the >> PCI root complex and the IOMMU must be created

[PATCH v3 6/7] ui: drop curor_hide global variable.

2020-02-07 Thread Gerd Hoffmann
No users left. Signed-off-by: Gerd Hoffmann --- include/sysemu/sysemu.h | 1 - vl.c| 2 -- 2 files changed, 3 deletions(-) diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h index 6358a324a711..7956e9054ade 100644 --- a/include/sysemu/sysemu.h +++ b/include/sysem

[PATCH v3 1/7] ui: add show-cursor option

2020-02-07 Thread Gerd Hoffmann
When enabled, this forces showing the mouse cursor, i.e. do not hide the pointer on mouse grabs. Defaults to off. Signed-off-by: Gerd Hoffmann --- qapi/ui.json | 3 +++ 1 file changed, 3 insertions(+) diff --git a/qapi/ui.json b/qapi/ui.json index e04525d8b44b..b9df7fe7b5cb 100644 --- a/qapi/ui

[PATCH v3 4/7] ui/cocoa: switch to new show-cursor option

2020-02-07 Thread Gerd Hoffmann
Use DisplayOpts settings to set the new file-global cursor_hide variable, stop using the qemu-global cursor_hide variable. Signed-off-by: Gerd Hoffmann --- ui/cocoa.m | 4 1 file changed, 4 insertions(+) diff --git a/ui/cocoa.m b/ui/cocoa.m index fbb5b1b45f81..f7b323044582 100644 --- a/ui/

Re: [PATCH v14 08/11] virtio-iommu-pci: Introduce the x-dt-binding option

2020-02-07 Thread Michael S. Tsirkin
On Fri, Feb 07, 2020 at 10:32:00AM +0100, Eric Auger wrote: > At the moment, the kernel only supports device tree > integration of the virtio-iommu. DT bindings between the > PCI root complex and the IOMMU must be created by the machine > in conformance to: > > Documentation/devicetree/bindings/vi

Re: [kvm-unit-tests PATCH v3 05/14] arm/arm64: ITS: Introspection tests

2020-02-07 Thread Andrew Jones
On Tue, Jan 28, 2020 at 11:34:50AM +0100, Eric Auger wrote: > Detect the presence of an ITS as part of the GICv3 init > routine, initialize its base address and read few registers > the IIDR, the TYPER to store its dimensioning parameters. > Also parse the BASER registers. > > This is our first IT

Re: [PATCH 08/29] qapi: Use ':' after @argument in doc comments

2020-02-07 Thread Kevin Wolf
Am 07.02.2020 um 10:28 hat Markus Armbruster geschrieben: > Peter Maydell writes: > > @@ -4703,7 +4703,7 @@ > > # > > # Options for creating an image format on a given node. > > # > > -# @driver block driver to create the image format > > +# @driver: block driver to create the image f

Re: [PATCH v14 08/11] virtio-iommu-pci: Introduce the x-dt-binding option

2020-02-07 Thread Michael S. Tsirkin
On Fri, Feb 07, 2020 at 11:05:40AM +0100, Jean-Philippe Brucker wrote: > Hi Eric, > > On Fri, Feb 07, 2020 at 10:32:00AM +0100, Eric Auger wrote: > > At the moment, the kernel only supports device tree > > integration of the virtio-iommu. DT bindings between the > > PCI root complex and the IOMMU

[PATCH 0/3] MAINTAINERS: Cover orphean qapi/json files

2020-02-07 Thread Philippe Mathieu-Daudé
Few orphean files noticed while looking at Peter series: "Convert QAPI doc comments to generate rST instead of texinfo" https://www.mail-archive.com/qemu-devel@nongnu.org/msg677500.html Philippe Mathieu-Daudé (3): MAINTAINERS: Cover qapi/rocker.json in 'Rocker' section MAINTAINERS: Cover qapi/

[PATCH 3/3] MAINTAINERS: Cover qapi/trace.json in 'Tracing' section

2020-02-07 Thread Philippe Mathieu-Daudé
List this file in the proper section, so maintainers get notified when it is modified. Signed-off-by: Philippe Mathieu-Daudé --- Cc: Stefan Hajnoczi --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index e269e9092c..d3f8e2eb6c 100644 --- a/MAINTAINER

[PATCH 1/3] MAINTAINERS: Cover qapi/rocker.json in 'Rocker' section

2020-02-07 Thread Philippe Mathieu-Daudé
List this file in the proper section, so maintainers get notified when it is modified. Signed-off-by: Philippe Mathieu-Daudé --- Cc: Jiri Pirko Cc: Jason Wang --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index e72b5e5f69..903831e0a4 100644 --- a

Re: [PATCH 16/29] qapi/{block, misc, tmp}.json: Use explicit bulleted lists

2020-02-07 Thread Philippe Mathieu-Daudé
On 2/6/20 6:30 PM, Peter Maydell wrote: A JSON block comment like this: Returns: nothing on success If @node is not a valid block device, DeviceNotFound If @name is not found, GenericError with an explanation renders in the HTML and manpage like this: R

Re: [PATCH v14 08/11] virtio-iommu-pci: Introduce the x-dt-binding option

2020-02-07 Thread Auger Eric
Hi On 2/7/20 11:24 AM, Michael S. Tsirkin wrote: > On Fri, Feb 07, 2020 at 11:05:40AM +0100, Jean-Philippe Brucker wrote: >> Hi Eric, >> >> On Fri, Feb 07, 2020 at 10:32:00AM +0100, Eric Auger wrote: >>> At the moment, the kernel only supports device tree >>> integration of the virtio-iommu. DT bi

[PATCH 2/3] MAINTAINERS: Cover qapi/block{-core}.json in 'Block layer core' section

2020-02-07 Thread Philippe Mathieu-Daudé
List this file in the proper section, so maintainers get notified when it is modified. Signed-off-by: Philippe Mathieu-Daudé --- Cc: Kevin Wolf Cc: Max Reitz Cc: qemu-bl...@nongnu.org --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 903831e0

Re: [PATCH v3 1/1] qemu-img: Add --target-is-zero to convert

2020-02-07 Thread Max Reitz
On 04.02.20 15:23, Eric Blake wrote: > On 2/4/20 7:59 AM, Vladimir Sementsov-Ogievskiy wrote: > >>> I understand that it is safer to have restrictions now and lift them >>> later, than to allow use of the option at any time and leave room for >>> the user to shoot themselves in the foot with no wa

Re: [PATCH] ppc: function to setup latest class options

2020-02-07 Thread Philippe Mathieu-Daudé
On 2/7/20 7:48 AM, Michael S. Tsirkin wrote: We are going to add more init for the latest machine, so move the setup to a function so we don't have to change the DEFINE_SPAPR_MACHINE macro each time. Signed-off-by: Michael S. Tsirkin --- hw/ppc/spapr.c | 9 +++-- 1 file changed, 7 insert

[PATCH v2] virtio: gracefully handle invalid region caches

2020-02-07 Thread Stefan Hajnoczi
The virtqueue code sets up MemoryRegionCaches to access the virtqueue guest RAM data structures. The code currently assumes that VRingMemoryRegionCaches is initialized before device emulation code accesses the virtqueue. An assertion will fail in vring_get_region_caches() when this is not true.

Re: qmp-shell for GSoC/Outreachy?

2020-02-07 Thread Kevin Wolf
Am 06.02.2020 um 19:26 hat Dr. David Alan Gilbert geschrieben: > * Kevin Wolf (kw...@redhat.com) wrote: > > Am 06.02.2020 um 10:40 hat Markus Armbruster geschrieben: > > > >> On 2/5/20 8:09 AM, Kevin Wolf wrote: > > > >> > Am 28.01.2020 um 11:59 hat Kevin Wolf geschrieben: > > > >> The other p

Re: [PATCH v14 08/11] virtio-iommu-pci: Introduce the x-dt-binding option

2020-02-07 Thread Auger Eric
Hi, On 2/7/20 11:23 AM, Michael S. Tsirkin wrote: > On Fri, Feb 07, 2020 at 10:32:00AM +0100, Eric Auger wrote: >> At the moment, the kernel only supports device tree >> integration of the virtio-iommu. DT bindings between the >> PCI root complex and the IOMMU must be created by the machine >> in

Re: [RFC v2 00/14] Add SDEI support for arm64

2020-02-07 Thread James Morse
Hi guys, On 06/02/2020 17:30, Marc Zyngier wrote: > On 2020-02-06 01:20, Heyi Guo wrote: >> On 2020/2/5 21:15, Marc Zyngier wrote: >>> My concern is that SDEI implies having EL3. EL3 not being virtualizable >>> with KVM, you end-up baking SDEI in *hardware*. Of course, this hardware >>> is actuall

Re: [PATCH v4 1/1] qemu-img: Add --target-is-zero to convert

2020-02-07 Thread Max Reitz
On 05.02.20 12:02, David Edmondson wrote: > In many cases the target of a convert operation is a newly provisioned > target that the user knows is blank (reads as zero). In this situation > there is no requirement for qemu-img to wastefully zero out the entire > device. > > Add a new option, --tar

Re: [PATCH 2/3] MAINTAINERS: Cover qapi/block{-core}.json in 'Block layer core' section

2020-02-07 Thread Max Reitz
On 07.02.20 11:30, Philippe Mathieu-Daudé wrote: > List this file in the proper section, so maintainers get > notified when it is modified. > > Signed-off-by: Philippe Mathieu-Daudé > --- > Cc: Kevin Wolf > Cc: Max Reitz > Cc: qemu-bl...@nongnu.org > --- > MAINTAINERS | 2 ++ > 1 file changed,

[PATCH] vl: Abort if multiple machines are registered as default

2020-02-07 Thread Philippe Mathieu-Daudé
It would be confusing to have multiple default machines. Abort if this ever occurs. Signed-off-by: Philippe Mathieu-Daudé --- vl.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/vl.c b/vl.c index 7dcb0879c4..da828188eb 100644 --- a/vl.c +++ b/vl.c @@ -2354,6 +2354,8 @@ static Machine

Re: [PATCH] travis.yml: Test the s390-ccw build, too

2020-02-07 Thread Christian Borntraeger
On 07.02.20 10:56, Thomas Huth wrote: > On 07/02/2020 10.47, Cornelia Huck wrote: >> On Thu, 6 Feb 2020 21:25:43 +0100 >> Thomas Huth wrote: >> >>> Since we can now use a s390x host on Travis, we can also build and >>> test the s390-ccw bios images there. For this we have to make sure >>> that

Re: [PATCH 08/29] qapi: Use ':' after @argument in doc comments

2020-02-07 Thread Peter Maydell
On Fri, 7 Feb 2020 at 10:24, Kevin Wolf wrote: > > Am 07.02.2020 um 10:28 hat Markus Armbruster geschrieben: > > Peter Maydell writes: > > > @@ -4703,7 +4703,7 @@ > > > # > > > # Options for creating an image format on a given node. > > > # > > > -# @driver block driver to create the

Re: [RFC PATCH 2/2] GitLab CI: crude mapping of PMM's scripts to jobs

2020-02-07 Thread Alex Bennée
Thomas Huth writes: > On 03/02/2020 04.23, Cleber Rosa wrote: >> This is a crude and straightforward mapping of Peter's >> "remake-merge-builds" and "pull-buildtest" scripts. > > Thanks for doing this! The patch looks basically fine to me, but some > comments below... > > > Question to Peter/

Re: [RFC v2 00/14] Add SDEI support for arm64

2020-02-07 Thread Peter Maydell
On Fri, 7 Feb 2020 at 10:52, James Morse wrote: > Is there an established pattern for how Qemu 'gets' things that are done in > secure-world? > For PSCI the kernel does it, but this obviously doesn't scale to something > like OP-TEE. The answer broadly is "it doesn't get them", the same way tha

Re: [PATCH] vl: Abort if multiple machines are registered as default

2020-02-07 Thread Laurent Vivier
Le 07/02/2020 à 12:02, Philippe Mathieu-Daudé a écrit : > It would be confusing to have multiple default machines. > Abort if this ever occurs. > > Signed-off-by: Philippe Mathieu-Daudé > --- > vl.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/vl.c b/vl.c > index 7dcb0879c4..

Re: [PULL 0/3] NBD patches through 2020-02-06

2020-02-07 Thread Peter Maydell
On Thu, 6 Feb 2020 at 13:06, Eric Blake wrote: > > The following changes since commit 7bd9d0a9e26c7a3c67c0f174f0009ba19969b158: > > Merge remote-tracking branch > 'remotes/huth-gitlab/tags/pull-request-2020-02-04' into staging (2020-02-04 > 16:12:31 +) > > are available in the Git reposito

Re: [PATCH] vl: Abort if multiple machines are registered as default

2020-02-07 Thread Marc-André Lureau
Hi On Fri, Feb 7, 2020 at 12:03 PM Philippe Mathieu-Daudé wrote: > > It would be confusing to have multiple default machines. > Abort if this ever occurs. > > Signed-off-by: Philippe Mathieu-Daudé > --- > vl.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/vl.c b/vl.c > index 7

Re: [PATCH] ppc: function to setup latest class options

2020-02-07 Thread Greg Kurz
On Fri, 7 Feb 2020 11:35:47 +0100 Philippe Mathieu-Daudé wrote: > On 2/7/20 7:48 AM, Michael S. Tsirkin wrote: > > We are going to add more init for the latest machine, so move the setup > > to a function so we don't have to change the DEFINE_SPAPR_MACHINE macro > > each time. > > > > Signed-off

Re: [PATCH v2 1/2] tests/vhost-user-bridge: move to contrib/

2020-02-07 Thread Juan Quintela
Laurent Vivier wrote: > vhost-user-bridge is not a test. Move it to contrib/ and > add it to the tools list. > > It will be built only if tools (--enable-tools) and > vhost-user (--enable-vhost-user) are enabled (both are set > by default). > > Suggested-by: Dr. David Alan Gilbert > Signed-off-by

Re: [PATCH v2 2/2] virtiofsd: add it to the tools list

2020-02-07 Thread Juan Quintela
Laurent Vivier wrote: > it will be built only when tools are enabled (always enabled by default) > > Signed-off-by: Laurent Vivier > Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela

Re: [PATCH v14 08/11] virtio-iommu-pci: Introduce the x-dt-binding option

2020-02-07 Thread Jean-Philippe Brucker
On Fri, Feb 07, 2020 at 11:51:55AM +0100, Auger Eric wrote: > Hi, > > On 2/7/20 11:23 AM, Michael S. Tsirkin wrote: > > On Fri, Feb 07, 2020 at 10:32:00AM +0100, Eric Auger wrote: > >> At the moment, the kernel only supports device tree > >> integration of the virtio-iommu. DT bindings between the

Re: [PATCH] travis.yml: Test the s390-ccw build, too

2020-02-07 Thread Alex Bennée
Thomas Huth writes: > Since we can now use a s390x host on Travis, we can also build and > test the s390-ccw bios images there. For this we have to make sure > that roms/SLOF is checked out, too, and then move the generated *.img > files to the right location before running the tests. > > Signe

[PATCH] !fixup "target/avr: Add defintions of AVR core types"

2020-02-07 Thread Philippe Mathieu-Daudé
These cores have unresolved review comment: https://www.mail-archive.com/qemu-devel@nongnu.org/msg674105.html https://www.mail-archive.com/qemu-devel@nongnu.org/msg674259.html and: https://www.mail-archive.com/qemu-devel@nongnu.org/msg676046.html As we don't want a bad start with this architecture

Re: [PATCH] vl: Abort if multiple machines are registered as default

2020-02-07 Thread Philippe Mathieu-Daudé
On 2/7/20 12:08 PM, Laurent Vivier wrote: Le 07/02/2020 à 12:02, Philippe Mathieu-Daudé a écrit : It would be confusing to have multiple default machines. Abort if this ever occurs. Signed-off-by: Philippe Mathieu-Daudé --- vl.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/vl.

[PATCH v2] vl: Abort if multiple machines are registered as default

2020-02-07 Thread Philippe Mathieu-Daudé
It would be confusing to have multiple default machines. Abort if this ever occurs. Signed-off-by: Philippe Mathieu-Daudé --- v2: Use assert() instead of human friendly message (Marc-André) Cc: Marc-André Lureau Cc: Laurent Vivier --- vl.c | 4 1 file changed, 4 insertions(+) diff --git

Re: [PATCH] pc-bios/s390x: Pack ResetInfo struct

2020-02-07 Thread Christian Borntraeger
Jason, can you run objdump -Sdr on jump2ipl.o on a broken variant? On 06.02.20 12:00, Thomas Huth wrote: > On 06/02/2020 11.09, Christian Borntraeger wrote: >> >> >> On 05.02.20 19:21, Jason J. Herne wrote: >>> This fixes vfio-ccw when booting non-Linux operating systems. Without this >>> struct

Re: [PATCH] vl: Abort if multiple machines are registered as default

2020-02-07 Thread Laurent Vivier
Le 07/02/2020 à 12:25, Philippe Mathieu-Daudé a écrit : > On 2/7/20 12:08 PM, Laurent Vivier wrote: >> Le 07/02/2020 à 12:02, Philippe Mathieu-Daudé a écrit : >>> It would be confusing to have multiple default machines. >>> Abort if this ever occurs. >>> >>> Signed-off-by: Philippe Mathieu-Daudé >

Re: [PATCH] vl: Abort if multiple machines are registered as default

2020-02-07 Thread Laurent Vivier
Le 07/02/2020 à 12:28, Laurent Vivier a écrit : > Le 07/02/2020 à 12:25, Philippe Mathieu-Daudé a écrit : >> On 2/7/20 12:08 PM, Laurent Vivier wrote: >>> Le 07/02/2020 à 12:02, Philippe Mathieu-Daudé a écrit : It would be confusing to have multiple default machines. Abort if this ever oc

[PATCH v1 1/5] tests/tcg: include a skip runner for pauth3 with plugins

2020-02-07 Thread Alex Bennée
If we have plugins enabled we still need to have built the test to be able to run it. Signed-off-by: Alex Bennée --- tests/tcg/aarch64/Makefile.softmmu-target | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/tcg/aarch64/Makefile.softmmu-target b/tests/tcg/aarch64/Makefile.softmmu-tar

[PATCH v1 0/5] testing/next (rcutorture and misc tweaks)

2020-02-07 Thread Alex Bennée
Hi, The current state of testing/next is mostly a rubber duck exercise as I tried to figure out what might cause the rcutorture test to fail. The only real practical change is asserting we are never about to reset and existing active RCU structure. So far I haven't seen the rcutorture crash occur

[PATCH v1 3/5] tests/rcutorture: better document locking of stats

2020-02-07 Thread Alex Bennée
This is pure code motion with no functional effect. Signed-off-by: Alex Bennée --- tests/rcutorture.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/tests/rcutorture.c b/tests/rcutorture.c index e8b2169e7dd..256d24ed5ba 100644 --- a/tests/rcutorture.c +++ b

[PATCH v1 2/5] tests/rcutorture: update usage hint

2020-02-07 Thread Alex Bennée
Although documented in the comments we don't display all the various invocations we can in the usage. Signed-off-by: Alex Bennée --- tests/rcutorture.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/rcutorture.c b/tests/rcutorture.c index 49311c82ea4..e8b2169e7dd 100

[PATCH v1 4/5] tests/rcutorture: mild documenting refactor of update thread

2020-02-07 Thread Alex Bennée
This is mainly to help with reasoning what the test is trying to do. We can move rcu_stress_idx to a local variable as there is only ever one updater thread. I've also added an assert to catch the case where we end up updating the current structure to itself which is the only way I can see the mber

  1   2   3   4   >