Re: Making QEMU easier for management tools and applications

2020-01-28 Thread Gerd Hoffmann
> > Consider chardev-add. Example: > > > > {"execute": "chardev-add", > > "arguments": {"id": "bar", > >"backend": {"type": "file", > >"data": {"out": "/tmp/bar.log" > Well, first of all: Do we need compatibility? Well, libvirt us

Re: [PATCH rc3 01/30] target/avr: Add basic parameters for new AVR platform

2020-01-28 Thread Aleksandar Markovic
On Tuesday, January 28, 2020, Michael Rolnik wrote: > Hi all. > > I am totally lost in the email. > Are there any action items for me / someone else ? > > Regards, > Michael Rolnik > > I think it would be helpful if we have rc4 with two action items: - remove CONFIG_USER_ONLY references, and

Re: [question] hw/arm/virt: about the default gic-version in accelerated mode

2020-01-28 Thread Auger Eric
Hi, On 1/28/20 1:41 PM, Andrew Jones wrote: > On Tue, Jan 28, 2020 at 01:34:06PM +0100, Auger Eric wrote: >> Hi Drew, >> >> On 1/28/20 1:29 PM, Andrew Jones wrote: >>> On Tue, Jan 28, 2020 at 10:52:50AM +, Peter Maydell wrote: On Tue, 28 Jan 2020 at 10:47, Auger Eric wrote: > When ar

Re: [PATCH] tests/acceptance: Add a test for the canon-a1100 machine

2020-01-28 Thread Wainer dos Santos Moschetta
On 1/28/20 10:16 AM, Thomas Huth wrote: On 27/01/2020 21.56, Philippe Mathieu-Daudé wrote: Hey Wainer, On 1/27/20 6:45 PM, Wainer dos Santos Moschetta wrote: On 1/27/20 1:41 PM, Philippe Mathieu-Daudé wrote: On 1/27/20 4:39 PM, Thomas Huth wrote: On 27/01/2020 16.18, Philippe Mathieu-Daudé

[PATCH v2 0/4] Implements the NetBSD Virtual Machine Monitor accelerator

2020-01-28 Thread Kamil Rytarowski
Hello QEMU Community! Over the past year the NetBSD team has been working hard on a new user-mode API for our hypervisor that will be released as part of the upcoming NetBSD 9.0. This new API adds user-mode capabilities to create and manage virtual machines, configure memory mappings for guest mac

[PATCH v2 2/4] Add the NetBSD Virtual Machine Monitor accelerator.

2020-01-28 Thread Kamil Rytarowski
From: Maxime Villard Introduces the configure support for the new NetBSD Virtual Machine Monitor that allows for hypervisor acceleration from usermode components on the NetBSD platform. Signed-off-by: Maxime Villard Signed-off-by: Kamil Rytarowski Reviewed-by: Sergio Lopez --- configure

[PATCH v2 4/4] Add the NVMM acceleration enlightenments

2020-01-28 Thread Kamil Rytarowski
From: Maxime Villard Implements the NVMM accelerator cpu enlightenments to actually use the nvmm-all accelerator on NetBSD platforms. Signed-off-by: Maxime Villard Signed-off-by: Kamil Rytarowski Reviewed-by: Sergio Lopez --- cpus.c| 58 +++

[PATCH v2 1/4] Add the NVMM vcpu API

2020-01-28 Thread Kamil Rytarowski
From: Maxime Villard Adds support for the NetBSD Virtual Machine Monitor (NVMM) stubs and introduces the nvmm.h sysemu API for managing the vcpu scheduling and management. Signed-off-by: Maxime Villard Signed-off-by: Kamil Rytarowski Reviewed-by: Sergio Lopez --- accel/stubs/Makefile.objs |

[PATCH v2 3/4] Introduce the NVMM impl

2020-01-28 Thread Kamil Rytarowski
From: Maxime Villard Implements the NetBSD Virtual Machine Monitor (NVMM) target. Which acts as a hypervisor accelerator for QEMU on the NetBSD platform. This enables QEMU much greater speed over the emulated x86_64 path's that are taken on NetBSD today. Signed-off-by: Maxime Villard Signed-off

Re: [GSoC/Outreachy QEMU proposal] Extend support for ioctls in QEMU linux-user mode

2020-01-28 Thread Laurent Vivier
Le 27/01/2020 à 17:30, Aleksandar Markovic a écrit : > > > On Mon, Jan 27, 2020 at 10:30 AM Stefan Hajnoczi > wrote: >> >> On Thu, Jan 23, 2020 at 02:34:01PM +0100, Aleksandar Markovic wrote: >> > *Extend support for ioctls in QEMU linux-user mode* >> > >> > >> > >> >

Re: [PATCH v6 2/2] s390: diagnose 318 info reset and migration support

2020-01-28 Thread Collin Walling
On 1/28/20 6:24 AM, Cornelia Huck wrote: > On Mon, 27 Jan 2020 18:05:36 -0500 > Collin Walling wrote: > >> On 1/27/20 12:35 PM, Cornelia Huck wrote: >>> On Mon, 27 Jan 2020 11:39:02 -0500 >>> Collin Walling wrote: >>> On 1/27/20 6:47 AM, Cornelia Huck wrote: > On Fri, 24 Jan 2020 1

Re: [PATCH v6 2/2] s390: diagnose 318 info reset and migration support

2020-01-28 Thread Collin Walling
On 1/27/20 12:35 PM, Cornelia Huck wrote: > On Mon, 27 Jan 2020 11:39:02 -0500 > Collin Walling wrote: > >> On 1/27/20 6:47 AM, Cornelia Huck wrote: >>> On Fri, 24 Jan 2020 17:14:04 -0500 >>> Collin Walling wrote: >>> DIAGNOSE 0x318 (diag318) is a privileged s390x instruction that must >

Re: [GSoC/Outreachy QEMU proposal] Extend support for ioctls in QEMU linux-user mode

2020-01-28 Thread Peter Maydell
On Thu, 23 Jan 2020 at 15:33, Aleksandar Markovic wrote: > PART III: > > a) Develop unit tests for selected ioctls that are already supported in > QEMU. These should probably just be part of the external Linux Test Project test suite. Incidentally a related topic would be to look at recent ne

Re: [PATCH v22 5/9] ACPI: Record the Generic Error Status Block address

2020-01-28 Thread Igor Mammedov
On Wed, 8 Jan 2020 19:32:19 +0800 Dongjiu Geng wrote: in addition to comments of others: > Record the GHEB address via fw_cfg file, when recording > a error to CPER, it will use this address to find out > Generic Error Data Entries and write the error. > > Make the HEST GHES to a GED device. I

Re: [PATCH] Handling SIGSETXID used by glibc NPTL setuid/setgid

2020-01-28 Thread Laurent Vivier
Le 28/01/2020 à 13:45, Peter Maydell a écrit : > On Tue, 28 Jan 2020 at 12:33, Taylor Simpson wrote: >> >> I proposed a similar patch guarded by #ifdef TARGET_HEXAGON. I understand >> we don't want to break things that are working, and we don't want to open >> the door for a bunch of #ifdef's h

Re: [PATCH v2 1/4] linux-user: Use `qemu_log' for non-strace logging

2020-01-28 Thread Laurent Vivier
Le 17/01/2020 à 20:28, Josh Kunz a écrit : > Since most calls to `gemu_log` are actually logging unimplemented features, > this change replaces most non-strace calls to `gemu_log` with calls to > `qemu_log_mask(LOG_UNIMP, ...)`. This allows the user to easily log to > a file, and to mask out these

Re: [question] hw/arm/virt: about the default gic-version in accelerated mode

2020-01-28 Thread Andrew Jones
On Tue, Jan 28, 2020 at 02:53:25PM +0100, Auger Eric wrote: > Hi, > > On 1/28/20 1:41 PM, Andrew Jones wrote: > > On Tue, Jan 28, 2020 at 01:34:06PM +0100, Auger Eric wrote: > >> Hi Drew, > >> > >> On 1/28/20 1:29 PM, Andrew Jones wrote: > >>> On Tue, Jan 28, 2020 at 10:52:50AM +, Peter Maydel

Re: [PATCH v2 2/4] linux-user: Use `qemu_log' for strace

2020-01-28 Thread Laurent Vivier
Le 17/01/2020 à 20:28, Josh Kunz a écrit : > This change switches linux-user strace logging to use the newer `qemu_log` > logging subsystem rather than the older `gemu_log` (notice the "g") > logger. `qemu_log` has several advantages, namely that it allows logging > to a file, and provides a more u

Re: [PATCH v2 3/4] linux-user: remove gemu_log from the linux-user tree

2020-01-28 Thread Laurent Vivier
Le 17/01/2020 à 20:28, Josh Kunz a écrit : > Now that all uses have been migrated to `qemu_log' it is no longer > needed. > > Signed-off-by: Josh Kunz > --- > linux-user/main.c | 9 - > linux-user/qemu.h | 1 - > 2 files changed, 10 deletions(-) > > diff --git a/linux-user/main.c b/linu

Re: [PATCH v6 2/2] s390: diagnose 318 info reset and migration support

2020-01-28 Thread Cornelia Huck
On Tue, 28 Jan 2020 09:37:46 -0500 Collin Walling wrote: > On 1/27/20 12:35 PM, Cornelia Huck wrote: > > On Mon, 27 Jan 2020 11:39:02 -0500 > > Collin Walling wrote: > > > >> On 1/27/20 6:47 AM, Cornelia Huck wrote: > >>> On Fri, 24 Jan 2020 17:14:04 -0500 > >>> Collin Walling wrote: > >>>

Re: [PATCH rc3 01/30] target/avr: Add basic parameters for new AVR platform

2020-01-28 Thread Michael Rolnik
Sounds good to me. On Tue, Jan 28, 2020 at 3:49 PM Aleksandar Markovic < aleksandar.m.m...@gmail.com> wrote: > > > On Tuesday, January 28, 2020, Michael Rolnik wrote: > >> Hi all. >> >> I am totally lost in the email. >> Are there any action items for me / someone else ? >> >> Regards, >> Michae

[PATCH 0/2] mirror: Fix hang (operation waiting for itself)

2020-01-28 Thread Kevin Wolf
Kevin Wolf (2): mirror: Store MirrorOp.co for debuggability mirror: Don't let an operation wait for itself block/mirror.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) -- 2.20.1

[PATCH 2/2] mirror: Don't let an operation wait for itself

2020-01-28 Thread Kevin Wolf
mirror_wait_for_free_in_flight_slot() just picks a random operation to wait for. However, when mirror_co_read() waits for free slots, its MirrorOp is already in s->ops_in_flight, so if not enough slots are immediately available, an operation can end up waiting for itself to complete, which results

[PATCH 1/2] mirror: Store MirrorOp.co for debuggability

2020-01-28 Thread Kevin Wolf
If a coroutine is launched, but the coroutine pointer isn't stored anywhere, debugging any problems inside the coroutine is quite hard. Let's store the coroutine pointer of a mirror operation in MirrorOp to have it available in the debugger. Signed-off-by: Kevin Wolf --- block/mirror.c | 2 ++ 1

Re: [PATCH v22 7/9] ACPI: Record Generic Error Status Block(GESB) table

2020-01-28 Thread Igor Mammedov
On Wed, 8 Jan 2020 19:32:21 +0800 Dongjiu Geng wrote: > kvm_arch_on_sigbus_vcpu() error injection uses source_id as > index in etc/hardware_errors to find out Error Status Data > Block entry corresponding to error source. So supported source_id > values should be assigned here and not be changed

Re: [PATCH v2 0/7] ARM virt: Add NVDIMM support

2020-01-28 Thread Auger Eric
Hi Shameer, On 1/17/20 6:45 PM, Shameer Kolothum wrote: > This series adds NVDIMM support to arm/virt platform. > The series reuses some of the patches posted by Eric > in his earlier attempt here[1]. > > Patch #1 is a fix to the Guest reboot issue on NVDIMM > hot add case described here[2] and p

Re: Making QEMU easier for management tools and applications

2020-01-28 Thread Markus Armbruster
Cc: Eric for netdev_add QAPIfication. Kevin Wolf writes: > Am 28.01.2020 um 11:16 hat Daniel P. Berrangé geschrieben: >> On Mon, Jan 27, 2020 at 11:38:49PM +0100, Paolo Bonzini wrote: >> > Il lun 27 gen 2020, 21:11 John Snow ha scritto: >> > >> > > >> > > > ./qemu-core <> > > { >> > > "mac

python3 script header and rhel8

2020-01-28 Thread Vladimir Sementsov-Ogievskiy
Hi all! Hmm Qemu dropped support for python2, and anyway python2 is not supported now at all. Still, we have a lot of "#!/usr/bin/env python" headings in our scripts, which is unsupported by rhel8 by default. So, for example, because of such line in tests/qemu-iotests/nbd-fault-injector.py, iot

Re: [PATCH v3 02/18] hw/i386: Introduce X86CPUTopoInfo to contain topology info

2020-01-28 Thread Igor Mammedov
On Tue, 03 Dec 2019 18:37:08 -0600 Babu Moger wrote: > This is an effort to re-arrange few data structure for better readability. > Add X86CPUTopoInfo which will have all the topology informations required > to build the cpu topology. There is no functional changes. > > Signed-off-by: Babu Moger

Re: [PATCH v3 03/18] hw/i386: Consolidate topology functions

2020-01-28 Thread Igor Mammedov
On Tue, 03 Dec 2019 18:37:15 -0600 Babu Moger wrote: > Now that we have all the parameters in X86CPUTopoInfo, we can just pass the > structure to calculate the offsets and width. > > Signed-off-by: Babu Moger Reviewed-by: Igor Mammedov > --- > include/hw/i386/topology.h | 64 > ++

Re: [PATCH v3 04/18] hw/i386: Introduce initialize_topo_info to initialize X86CPUTopoInfo

2020-01-28 Thread Igor Mammedov
On Tue, 03 Dec 2019 18:37:21 -0600 Babu Moger wrote: > Initialize all the parameters in one function initialize_topo_info. > > Signed-off-by: Babu Moger > Reviewed-by: Eduardo Habkost > --- > hw/i386/pc.c | 28 +++- > 1 file changed, 15 insertions(+), 13 deletions(-)

Re: [PATCH v4 0/4] Improve default object property_add uint helpers

2020-01-28 Thread Marc-André Lureau
Hi Felipe, On Fri, Jan 24, 2020 at 11:49 AM Felipe Franciosi wrote: > > Hi Marc-Andre and Paolo, > > > On Dec 20, 2019, at 3:15 PM, Marc-André Lureau > > wrote: > > > > Hi > > > > On Thu, Dec 19, 2019 at 10:02 PM Felipe Franciosi > > wrote: > >> > >> This improves the family of object_propert

Re: [PATCH 00/11] target/hppa patch queue

2020-01-28 Thread Peter Maydell
On Mon, 27 Jan 2020 at 19:01, Richard Henderson wrote: > > Version 4 fixes trivial conflicts with > > commit 4f67d30b5e74e060b8dbe10528829b47345cd6e8 > Author: Marc-André Lureau > Date: Fri Jan 10 19:30:32 2020 +0400 > > qdev: set properties with device_class_set_props() > > > r~ > > > The

Re: python3 script header and rhel8

2020-01-28 Thread Philippe Mathieu-Daudé
On 1/28/20 4:44 PM, Vladimir Sementsov-Ogievskiy wrote: Hi all! Hmm Qemu dropped support for python2, and anyway python2 is not supported now at all. Still, we have a lot of "#!/usr/bin/env python" headings in our scripts, which is unsupported by rhel8 by default. So, for example, because of

Re: python3 script header and rhel8

2020-01-28 Thread Daniel P . Berrangé
On Tue, Jan 28, 2020 at 03:44:04PM +, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > Hmm Qemu dropped support for python2, and anyway python2 is not supported now > at all. > > Still, we have a lot of "#!/usr/bin/env python" headings in our scripts, > which is > unsupported by rhel8 by d

Re: [PATCH v22 5/9] ACPI: Record the Generic Error Status Block address

2020-01-28 Thread Igor Mammedov
On Tue, 28 Jan 2020 15:41:10 +0100 Igor Mammedov wrote: > On Wed, 8 Jan 2020 19:32:19 +0800 > Dongjiu Geng wrote: > > in addition to comments of others: > > > Record the GHEB address via fw_cfg file, when recording > > a error to CPER, it will use this address to find out > > Generic Error Dat

Re: [PATCH 1/2] mirror: Store MirrorOp.co for debuggability

2020-01-28 Thread Eric Blake
On 1/28/20 9:17 AM, Kevin Wolf wrote: If a coroutine is launched, but the coroutine pointer isn't stored anywhere, debugging any problems inside the coroutine is quite hard. Let's store the coroutine pointer of a mirror operation in MirrorOp to have it available in the debugger. Signed-off-by: K

[Bug 1859656] Re: [2.6] Unable to reboot s390x KVM machine after initial deploy

2020-01-28 Thread Frank Heimes
I doubled check today again with sfeole and he confirmed that it worked for him as well (and not only for me) when he just started using MAAS KVM on s390x and had his initial setup... Anyway, I'm now sure on how much effort we should spent on recreating the old situation (I may try some old qemu/

Re: [PATCH 2/2] mirror: Don't let an operation wait for itself

2020-01-28 Thread Eric Blake
On 1/28/20 9:17 AM, Kevin Wolf wrote: mirror_wait_for_free_in_flight_slot() just picks a random operation to wait for. However, when mirror_co_read() waits for free slots, its MirrorOp is already in s->ops_in_flight, so if not enough slots are immediately available, an operation can end up waitin

Re: [PATCH v3 07/18] machine: Add a new function init_apicid_fn in MachineClass

2020-01-28 Thread Igor Mammedov
On Tue, 03 Dec 2019 18:37:42 -0600 Babu Moger wrote: > Add a new function init_apicid_fn in MachineClass to initialize the mode > specific handlers to decode the apic ids. > > Signed-off-by: Babu Moger > --- > include/hw/boards.h |1 + > vl.c|3 +++ > 2 files changed, 4

Re: [PATCH v3 06/18] hw/core: Add core complex id in X86CPU topology

2020-01-28 Thread Igor Mammedov
On Tue, 03 Dec 2019 18:37:35 -0600 Babu Moger wrote: > Introduce last level cache id(llc_id) in x86CPU topology. This information is > required to build the topology in EPIC mode. can you add a reference to spec here so one could look for detailed information about this? > Signed-off-by: Babu

Re: [PATCH v2 5/7] hw/arm/virt: Add nvdimm hotplug support

2020-01-28 Thread Auger Eric
Hi Shameer, On 1/17/20 6:45 PM, Shameer Kolothum wrote: > This adds support for nvdimm hotplug events through GED > and enables nvdimm for the arm/virt. Now Guests with ACPI > can have both cold and hot plug of nvdimms. > > Hot removal functionality is not yet supported. > > Signed-off-by: Shamee

Re: [PATCH v3 06/18] hw/core: Add core complex id in X86CPU topology

2020-01-28 Thread Eric Blake
On 12/3/19 6:37 PM, Babu Moger wrote: Introduce last level cache id(llc_id) in x86CPU topology. This information is required to build the topology in EPIC mode. Signed-off-by: Babu Moger --- +++ b/qapi/machine.json @@ -646,9 +646,11 @@ # @node-id: NUMA node ID the CPU belongs to # @sock

Re: [PATCH v2 7/7] tests/bios-tables-test: Update arm/virt memhp test

2020-01-28 Thread Auger Eric
Hi Shameer, On 1/17/20 6:45 PM, Shameer Kolothum wrote: > Since we now have both pc-dimm and nvdimm support, update > test_acpi_virt_tcg_memhp() to include those. > > Signed-off-by: Shameer Kolothum > --- > tests/data/acpi/virt/NFIT.memhp | 0 > tests/data/acpi/virt/SSDT.memhp | 0 Is it normal

[Bug 1861161] Re: qemu-arm-static stuck with 100% CPU when cross-compiling emacs

2020-01-28 Thread Philippe Vaucher
** Summary changed: - qemu-arm-static 100% CPU when cross-compiling emacs on alpine + qemu-arm-static stuck with 100% CPU when cross-compiling emacs ** Description changed: Hello, I'm trying to build multi-arch docker images for https://hub.docker.com/r/silex/emacs. Here is the mac

[Bug 1861161] [NEW] qemu-arm-static 100% CPU when cross-compiling emacs on alpine

2020-01-28 Thread Philippe Vaucher
Public bug reported: Hello, I'm trying to build multi-arch docker images for https://hub.docker.com/r/silex/emacs. Here is the machine I'm building on (hetzner cloud machine): root@ubuntu-4gb-fsn1-1:~# lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description:Ubuntu 18

Re: [PATCH v3 04/18] hw/i386: Introduce initialize_topo_info to initialize X86CPUTopoInfo

2020-01-28 Thread Babu Moger
Igor, On 1/28/20 9:49 AM, Igor Mammedov wrote: > On Tue, 03 Dec 2019 18:37:21 -0600 > Babu Moger wrote: > >> Initialize all the parameters in one function initialize_topo_info. >> >> Signed-off-by: Babu Moger >> Reviewed-by: Eduardo Habkost >> --- >> hw/i386/pc.c | 28 +++---

Re: [PATCH v3 06/18] hw/core: Add core complex id in X86CPU topology

2020-01-28 Thread Babu Moger
On 1/28/20 10:27 AM, Igor Mammedov wrote: > On Tue, 03 Dec 2019 18:37:35 -0600 > Babu Moger wrote: > >> Introduce last level cache id(llc_id) in x86CPU topology. This information >> is >> required to build the topology in EPIC mode. > can you add a reference to spec here so one could look fo

Re: [PATCH v3 06/18] hw/core: Add core complex id in X86CPU topology

2020-01-28 Thread Babu Moger
On 1/28/20 10:31 AM, Eric Blake wrote: > On 12/3/19 6:37 PM, Babu Moger wrote: >> Introduce last level cache id(llc_id) in x86CPU topology.  This >> information is >> required to build the topology in EPIC mode. >> >> Signed-off-by: Babu Moger >> --- > >> +++ b/qapi/machine.json >> @@ -646,9 +

Re: [PATCH v3 00/13] RFC: [for 5.0]: HMP monitor handlers cleanups

2020-01-28 Thread Dr. David Alan Gilbert
* John Snow (js...@redhat.com) wrote: > > > On 1/27/20 3:43 PM, Peter Krempa wrote: > > On Mon, Jan 27, 2020 at 14:39:02 -0500, John Snow wrote: > >> > >> > >> On 1/27/20 5:36 AM, Maxim Levitsky wrote: > >>> This patch series is bunch of cleanups > >>> to the hmp monitor code. > >>> > >>> This se

Re: [PATCH v2 1/4] linux-user: Use `qemu_log' for non-strace logging

2020-01-28 Thread Alex Bennée
Laurent Vivier writes: > Le 17/01/2020 à 20:28, Josh Kunz a écrit : >> Since most calls to `gemu_log` are actually logging unimplemented features, >> this change replaces most non-strace calls to `gemu_log` with calls to >> `qemu_log_mask(LOG_UNIMP, ...)`. This allows the user to easily log to

[Bug 1861161] Re: qemu-arm-static stuck with 100% CPU when cross-compiling emacs

2020-01-28 Thread Peter Maydell
Given the presence of getdents64 in the strace, I wonder if you are running into LP:1805913. You could test this theory by running the test with a host filesystem that is not ext4. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https

Re: [PATCH v3 03/13] monitor/hmp: rename device-hotplug.c to block/monitor/block-hmp-cmds.c

2020-01-28 Thread Dr. David Alan Gilbert
* Maxim Levitsky (mlevi...@redhat.com) wrote: > These days device-hotplug.c only contains the hmp_drive_add > In the next patch, rest of hmp_drive* functions will be moved > there. > > Also change the license of that file to GPL2+ since most > of the code that will be moved there is under that lic

Re: [PATCH 01/13] qcrypto: add generic infrastructure for crypto options amendment

2020-01-28 Thread Daniel P . Berrangé
On Tue, Jan 14, 2020 at 09:33:38PM +0200, Maxim Levitsky wrote: > This will be used first to implement luks keyslot management. > > block_crypto_amend_opts_init will be used to convert > qemu-img cmdline to QCryptoBlockAmendOptions > > Signed-off-by: Maxim Levitsky > --- > block/crypto.c

Re: [PATCH v2 1/4] linux-user: Use `qemu_log' for non-strace logging

2020-01-28 Thread Laurent Vivier
Le 28/01/2020 à 17:53, Alex Bennée a écrit : > > Laurent Vivier writes: > >> Le 17/01/2020 à 20:28, Josh Kunz a écrit : >>> Since most calls to `gemu_log` are actually logging unimplemented features, >>> this change replaces most non-strace calls to `gemu_log` with calls to >>> `qemu_log_mask(LO

Re: [PULL 00/19] 10 next patches

2020-01-28 Thread Peter Maydell
On Mon, 27 Jan 2020 at 22:34, Juan Quintela wrote: > > The following changes since commit 105b07f1ba462ec48b27e5cb74ddf81c6a79364c: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20200127' into > staging (2020-01-27 13:02:36 +) > > are available in the Git repository at: > >

Re: [PATCH v2 2/7] hw/acpi/nvdimm: Fix for NVDIMM incorrect DSM output buffer length

2020-01-28 Thread Auger Eric
Hi Shameer, On 1/17/20 6:45 PM, Shameer Kolothum wrote: > As per ACPI spec 6.3, Table 19-419 Object Conversion Rules, if > the Buffer Field <= to the size of an Integer (in bits), it will > be treated as an integer. Moreover, the integer size depends on > DSDT tables revision number. If revision nu

Re: [PATCH 02/13] qcrypto-luks: implement encryption key management

2020-01-28 Thread Daniel P . Berrangé
On Tue, Jan 21, 2020 at 03:13:01PM +0200, Maxim Levitsky wrote: > On Tue, 2020-01-21 at 08:54 +0100, Markus Armbruster wrote: > > > > > > +## > > > +# @LUKSKeyslotUpdate: > > > +# > > > +# @keyslot: If specified, will update only keyslot with this > > > index > > > +# > > > +# @old-secr

Re: [PATCH 02/13] qcrypto-luks: implement encryption key management

2020-01-28 Thread Daniel P . Berrangé
On Tue, Jan 14, 2020 at 09:33:39PM +0200, Maxim Levitsky wrote: > Next few patches will expose that functionality > to the user. > > Signed-off-by: Maxim Levitsky > --- > crypto/block-luks.c | 374 +++- > qapi/crypto.json| 50 +- > 2 files changed

Re: [PATCH 04/13] block: amend: separate amend and create options for qemu-img

2020-01-28 Thread Daniel P . Berrangé
On Tue, Jan 14, 2020 at 09:33:41PM +0200, Maxim Levitsky wrote: > Some options are only useful for creation > (or hard to be amended, like cluster size for qcow2), while some other > options are only useful for amend, like upcoming keyslot management > options for luks > > Since currently only qco

Re: [PATCH v2 0/5] linux-user: Implement x86_64 vsyscalls

2020-01-28 Thread Laurent Vivier
Le 16/01/2020 à 20:43, Richard Henderson a écrit : > Changes since v2: > > * Add /proc/self/maps line > > I'm not sure this is really necessary. The linux kernel > self-test checks for it, and modifies the set of tests that > it runs based on it. But otherwise I think it's u

Re: [PATCH 06/13] block/crypto: implement the encryption key management

2020-01-28 Thread Daniel P . Berrangé
On Tue, Jan 14, 2020 at 09:33:43PM +0200, Maxim Levitsky wrote: > This implements the encryption key management using the generic code in > qcrypto layer and exposes it to the user via qemu-img > > This code adds another 'write_func' because the initialization > write_func works directly on the un

Re: [PATCH 07/13] qcow2: extend qemu-img amend interface with crypto options

2020-01-28 Thread Daniel P . Berrangé
On Tue, Jan 14, 2020 at 09:33:44PM +0200, Maxim Levitsky wrote: > Now that we have all the infrastructure in place, > wire it in the qcow2 driver and expose this to the user. > > Signed-off-by: Maxim Levitsky > --- > block/qcow2.c | 101 +++--- > 1 fil

Re: [GSoC/Outreachy QEMU proposal] Extend support for ioctls in QEMU linux-user mode

2020-01-28 Thread Aleksandar Markovic
15:28 Uto, 28.01.2020. Laurent Vivier је написао/ла: > > Le 27/01/2020 à 17:30, Aleksandar Markovic a écrit : > > > > > > On Mon, Jan 27, 2020 at 10:30 AM Stefan Hajnoczi > > wrote: > >> > >> On Thu, Jan 23, 2020 at 02:34:01PM +0100, Aleksandar Markovic wrote: > >> > *

Re: [PATCH 02/13] qcrypto-luks: implement encryption key management

2020-01-28 Thread Daniel P . Berrangé
On Tue, Jan 28, 2020 at 05:11:16PM +, Daniel P. Berrangé wrote: > On Tue, Jan 21, 2020 at 03:13:01PM +0200, Maxim Levitsky wrote: > > On Tue, 2020-01-21 at 08:54 +0100, Markus Armbruster wrote: > > > > > > > > > > +## > > > > +# @LUKSKeyslotUpdate: > > > > +# > > > > +# @keyslot: If

Re: [GSoC/Outreachy QEMU proposal] Extend support for ioctls in QEMU linux-user mode

2020-01-28 Thread Laurent Vivier
Le 28/01/2020 à 18:32, Aleksandar Markovic a écrit : > 15:28 Uto, 28.01.2020. Laurent Vivier > је написао/ла: >> >> Le 27/01/2020 à 17:30, Aleksandar Markovic a écrit : >> > >> > >> > On Mon, Jan 27, 2020 at 10:30 AM Stefan Hajnoczi > mailto:stefa...@redhat.com> >> >

Re: [PATCH 08/13] iotests: filter few more luks specific create options

2020-01-28 Thread Daniel P . Berrangé
On Tue, Jan 14, 2020 at 09:33:45PM +0200, Maxim Levitsky wrote: > This allows more tests to be able to have same output on both qcow2 luks > encrypted images > and raw luks images > > Signed-off-by: Maxim Levitsky > --- > tests/qemu-iotests/087.out | 6 +++--- > tests/qemu-iotests/134.out

Re: [PATCH 11/13] block/crypto: implement blockdev-amend

2020-01-28 Thread Daniel P . Berrangé
On Tue, Jan 14, 2020 at 09:33:48PM +0200, Maxim Levitsky wrote: > Signed-off-by: Maxim Levitsky > --- > block/crypto.c | 70 > qapi/block-core.json | 14 - > 2 files changed, 64 insertions(+), 20 deletions(-) > > diff --git a/block/crypt

Re: [PATCH 12/13] block/qcow2: implement blockdev-amend

2020-01-28 Thread Daniel P . Berrangé
On Tue, Jan 14, 2020 at 09:33:49PM +0200, Maxim Levitsky wrote: > Currently the implementation only supports amending the encryption > options, unlike the qemu-img version > > Signed-off-by: Maxim Levitsky > --- > block/qcow2.c| 39 +++ > qapi/block-co

Re: [PATCH v3 04/13] monitor/hmp: move hmp_drive_del and hmp_commit to block-hmp-cmds.c

2020-01-28 Thread Dr. David Alan Gilbert
* Maxim Levitsky (mlevi...@redhat.com) wrote: > Signed-off-by: Maxim Levitsky Reviewed-by: Dr. David Alan Gilbert (It's easier to compare if you keep the function order the same) > --- > block/monitor/block-hmp-cmds.c | 97 +- > blockdev.c

Re: [GSoC/Outreachy QEMU proposal] Extend support for ioctls in QEMU linux-user mode

2020-01-28 Thread Aleksandar Markovic
15:38 Uto, 28.01.2020. Peter Maydell је написао/ла: > > On Thu, 23 Jan 2020 at 15:33, Aleksandar Markovic > wrote: > > PART III: > > > > a) Develop unit tests for selected ioctls that are already supported in QEMU. > > These should probably just be part of the external Linux Test Project > test

[PATCH v2 2/4] qapi: Create module 'control'

2020-01-28 Thread Kevin Wolf
misc.json contains definitions that are related to the system emulator, so it can't be used for other tools like the storage daemon. This patch moves basic functionality that is shared between all tools (and mostly related to the monitor itself) into a new control.json, which could be used in tools

[PATCH 002/142] optionrom: simplify Makefile

2020-01-28 Thread Paolo Bonzini
From: Marc-André Lureau Make it independent from the rules.mak, and clean up to use pattern rules. Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- pc-bios/optionrom/Makefile | 67 +++--- 1 file changed, 41 insertions(+), 26 deletions(-) diff

Re: [PATCH 0/8] tests/vm: Add support for aarch64 VMs

2020-01-28 Thread Alex Bennée
Robert Foley writes: > This patch adds support for 2 aarch64 VMs. > - Ubuntu 18.04 aarch64 VM > - CentOS 8 aarch64 VM Another failure to note - under TCG: make vm-build-ubuntu.aarch64 V=1 QEMU=aarch64-softmmu/qemu-system-aarch64 Gives: Not run: 172 186 192 220 Failures: 001 002 003 0

[PATCH v2 0/4] monitor: Refactoring in preparation for qemu-storage-daemon

2020-01-28 Thread Kevin Wolf
This series creates a QAPI module 'control' that can be used from tools outside the system emulator and moves some monitor initialisation code from vl.c to monitor code. It is split from the series to introduce qemu-storage-daemon because these refactorings make sense on their own as cleanups. v2

[RFC PATCH v4 000/142] Proof of concept for Meson integration

2020-01-28 Thread Paolo Bonzini
Changes since https://patchew.org/QEMU/1576155176-2464-1-git-send-email-pbonz...@redhat.com/: - updated to upstream commit b0b74e1f17508cb8cef8afd698558db1bd8999cc ("Merge remote-tracking branch 'remotes/ehabkost/tags/python-next-pull-request' into staging", 2020-01-06) - includes the test() dri

[PATCH 001/142] minikconf: accept alnum identifiers

2020-01-28 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- scripts/minikconf.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/minikconf.py b/scripts/minikconf.py index 40ae1989e1..febd9a479f 100644 --- a/scripts/minikconf.py +++ b/sc

[PATCH v2 1/4] monitor: Move monitor option parsing to monitor/monitor.c

2020-01-28 Thread Kevin Wolf
Both the system emulators and tools with QMP support (specifically, the planned storage daemon) will need to parse monitor options, so move that code to monitor/monitor.c, which can be linked into binaries that aren't a system emulator. Signed-off-by: Kevin Wolf Reviewed-by: Markus Armbruster --

[PATCH 004/142] build-sys hack: ensure target directory is there

2020-01-28 Thread Paolo Bonzini
From: Marc-André Lureau By removing some unnest-vars calls, we miss some directory creation that may be required by some/dir/object.d. This will go away once everything is converted to Meson. Signed-off-by: Marc-André Lureau --- rules.mak | 1 + 1 file changed, 1 insertion(+) diff --git a/ru

[PATCH 010/142] meson: enable pie

2020-01-28 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index b4f36820da..a9ab67bf26 100755 --- a/configure +++ b/configure @@ -2103,7 +2103,6 @@ EOF if compile_prog "-fPIE -DPIE" "-pie

[PATCH v2 3/4] monitor: Create monitor/qmp-cmds-control.c

2020-01-28 Thread Kevin Wolf
Move all of the QMP commands handlers to implement the 'control' module (qapi/control.json) that can be shared between the system emulator and tools such as a storage daemon to a new file monitor/qmp-cmds-control.c. Signed-off-by: Kevin Wolf --- monitor/misc.c | 110 -

[PATCH 005/142] configure: do not include $(...) variables in config-host.mak

2020-01-28 Thread Paolo Bonzini
This ensures that Meson will be able to reuse the results of the tests that are performed in the configure script. Signed-off-by: Paolo Bonzini --- configure | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/configure b/configure index 747d3

[PATCH 006/142] configure: expand path variables for meson configure

2020-01-28 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- configure | 35 --- 1 file changed, 20 insertions(+), 15 deletions(-) diff --git a/configure b/configure index e85c8bc515..a9d0b92a55 100755 --- a/configure +++ b/configur

[PATCH 011/142] meson: use coverage option

2020-01-28 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- Makefile | 14 -- Makefile.target| 16 configure | 10 ++ docs/devel/testing.rst | 7 +++ 4 files changed, 5 insertions(+), 42 deletions(-) diff --git a/Mak

[PATCH v2 4/4] monitor: Move qmp_query_qmp_schema to qmp-cmds-control.c

2020-01-28 Thread Kevin Wolf
monitor/misc.c contains code that works only in the system emulator, so it can't be linked to tools like a storage daemon. In order to make schema introspection available for tools, move the function to monitor/qmp-cmds-control.c, which can be linked into the storage daemon. Signed-off-by: Kevin W

[PATCH 009/142] build-sys: add meson submodule

2020-01-28 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- .gitmodules | 3 +++ configure | 45 +++ meson | 1 + scripts/archive-source.sh | 3 ++- 4 files changed, 47 insertions(+), 5 deletions(-) creat

[PATCH 034/142] meson: generate shader headers

2020-01-28 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile | 19 --- meson.build | 1 + ui/meson.build| 2 ++ ui/shader/meson.build | 15 +++ 4 files changed, 18 insertions(+), 19 deletions(-)

[PATCH 008/142] configure: generate Meson cross file

2020-01-28 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- configure | 41 + 1 file changed, 41 insertions(+) diff --git a/configure b/configure index e3533b3290..cdc71631e0 100755 --- a/configure +++ b/configure @@ -8035,

[PATCH 016/142] contrib/libvhost-user: convert to Meson

2020-01-28 Thread Paolo Bonzini
Since libqemuutil.a has been converted to Meson, the conversion is straightforward. Signed-off-by: Paolo Bonzini --- Makefile| 14 -- Makefile.objs | 1 - contrib/libvhost-user/Makefile.objs | 1 - contrib/libvhost-user/meson.build

[PATCH 040/142] meson: convert authz directory to Meson

2020-01-28 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile| 1 - Makefile.objs | 8 +++- Makefile.target | 2 +- authz/Makefile.objs | 7 --- authz/meson.build | 18 ++ meson.build | 5 + 6

[PATCH 007/142] configure: integrate Meson in the build system

2020-01-28 Thread Paolo Bonzini
The Meson build system is integrated in the existing configure/make steps by invoking Meson from the configure script and converting Meson's build.ninja rules to an included Makefile. build.ninja already provides tags/ctags/cscope rules, so they are removed. Signed-off-by: Paolo Bonzini --- Mak

[PATCH 003/142] pc-bios/s390-ccw: simplify Makefile

2020-01-28 Thread Paolo Bonzini
Make it independent from the rules.mak, and clean up to use pattern rules. Signed-off-by: Paolo Bonzini --- pc-bios/s390-ccw/Makefile| 103 --- pc-bios/s390-ccw/netboot.mak | 61 - 2 files changed, 82 insertions(+), 82 deletions(-) delete

[PATCH 015/142] meson: add version.o

2020-01-28 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- meson.build | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index d22c0c93d3..94727e8dfb 100644 --- a/meson.build +++ b/meson.build @@ -23,8 +23,14 @@

[PATCH 017/142] contrib/vhost-user-blk: convert to Meson

2020-01-28 Thread Paolo Bonzini
The GLib pkg-config information is extracted from config-host.mak and used to link vhost-user-blk. Signed-off-by: Paolo Bonzini --- Makefile | 3 --- Makefile.objs | 1 - contrib/vhost-user-blk/meson.build | 3 +++ meson.build

[PATCH 037/142] meson: uncompress edk2 bios

2020-01-28 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile| 7 --- meson.build | 2 ++ pc-bios/meson.build | 23 +++ 3 files changed, 25 insertions(+), 7 deletions(-) create mode 100644 pc-bios/meson.build

[PATCH 012/142] meson: add testsuite Makefile generator

2020-01-28 Thread Paolo Bonzini
Rules to execute tests are generated by a simple Python program that integrates into the existing "make check" mechanism. This provides familiarity for developers, and also allows piecewise conversion of the testsuite Makefiles to meson. The generated rules are based on QEMU's existing test harne

[PATCH 013/142] libqemuutil: convert to meson

2020-01-28 Thread Paolo Bonzini
This shows how to do some "computations" in meson.build using its array and dictionary data structures, and also a basic usage of the sourceset module for conditional compilation. Overall the look of the meson.build code is quite good, however Meson doesn't enjoy the same flexibility we have with

[PATCH 018/142] contrib/vhost-user-scsi: convert to Meson

2020-01-28 Thread Paolo Bonzini
The libiscsi pkg-config information is extracted from config-host.mak and used to link vhost-user-blk. Signed-off-by: Paolo Bonzini --- Makefile | 3 --- Makefile.objs | 3 --- contrib/vhost-user-scsi/Makefile.objs | 1 - contrib/vhost-user-sc

[PATCH 052/142] meson: convert chardev directory to Meson (emulator part)

2020-01-28 Thread Paolo Bonzini
Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile.objs | 1 - Makefile.target | 2 ++ chardev/Makefile.objs | 6 -- chardev/meson.build | 4 configure | 2 ++ meson.build | 14 ++ 6 files changed, 22 inserti

[PATCH 014/142] meson: add remaining generated tcg trace helpers

2020-01-28 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile | 51 --- trace/meson.build | 14 + 2 files changed, 14 insertions(+), 51 deletions(-) diff --git a/Makefile b/Makefile index d1e

<    1   2   3   4   5   >