Re: [PATCH rc3 02/30] target/avr: Introduce AVR CPU class object

On 1/27/20 3:39 AM, Aleksandar Markovic wrote: +static void avr_cpu_initfn(Object *obj) +{ +AVRCPU *cpu = AVR_CPU(obj); + +cpu_set_cpustate_pointers(cpu); + +#ifndef CONFIG_USER_ONLY +/* Set the number of interrupts supported by the CPU. */ +qdev_init_gpio_in(DEVICE(cpu), avr_cpu_

Re: [PATCH rc2 20/25] hw/avr: Add some ATmega microcontrollers

08:59 Pon, 27.01.2020. Philippe Mathieu-Daudé је написао/ла: > > On 1/26/20 3:46 PM, Aleksandar Markovic wrote: > > On Friday, January 24, 2020, Philippe Mathieu-Daudé > > wrote: > > > > Add some microcontrollers from the megaAVR family (ATmega series): > > > > - m

Re: [PATCH rc3 23/30] hw/core/loader: Let load_elf populate the processor-specific flags

On 1/26/20 11:55 PM, Aleksandar Markovic wrote: From: Philippe Mathieu-Daudé Some platforms (like AVR) need to determine cpu type by reading the ELF flags (field e_flags oin ELF header). This patch enables discovery of the content of that flag while using following functions: - load_elf()

[PATCH v3.1 74/80] exec: cleanup qemu_minrampagesize()/qemu_maxrampagesize()

Since all RAM is backed by hostmem backends, drop global -mem-path invariant and simplify code. Signed-off-by: Igor Mammedov --- v4: * fix access to uninitialized pagesize/hpsize (David Gibson ) CC: th...@redhat.com CC: a...@ozlabs.ru CC: mdr...@linux.vnet.ibm.com CC: da...@gibson.dropbear

Re: [PATCH v2 2/8] hxtool: Support SRST/ERST directives

On 1/24/20 5:26 PM, Peter Maydell wrote: We want to add support for including rST document fragments in our .hx files, in the same way we currently have texinfo fragments. These will be delimited by SRST and ERST directives, in the same way the texinfo is delimited by STEXI/ETEXI. The rST fragmen

Tooling to help humans use JSON (was: Making QEMU easier for management tools and applications)

Daniel P. Berrangé writes: > On Thu, Jan 23, 2020 at 04:07:09PM -0500, John Snow wrote: >> >> >> On 1/23/20 2:01 PM, Daniel P. Berrangé wrote: [...] >> Well, sure. The context of this email was qmp-shell though, which is >> meant to help facilitate the entry of JSON commands so that you *can* >

Re: [PATCH] bcm2835_dma: Fix TD mode

Hi Rene, On 1/24/20 6:55 PM, Rene Stange wrote: TD (two dimensions) DMA mode did not work, because the xlen variable has not been re-initialized before each additional ylen run through in bcm2835_dma_update(). Furthermore ylen has to be increased by one after reading it from the TXFR_LEN registe

Re: Making QEMU easier for management tools and applications

Hi, > We build a "configuration" struct in QAPI, and extend from there. > > (2) We offer "--config myconfig.yaml" as an option for specifying > options. Yes. > This precludes the use of *any* traditional command line flags. Hmm. Given that the transition effort will probably take a while I

[Bug 1849644] Re: QEMU VNC websocket proxy requires non-standard 'binary' subprotocol

Ok, thanks! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1849644 Title: QEMU VNC websocket proxy requires non-standard 'binary' subprotocol Status in QEMU: New Bug description: When running

Re: [PATCH rc3 02/30] target/avr: Introduce AVR CPU class object

09:03 Pon, 27.01.2020. Philippe Mathieu-Daudé је написао/ла: > > On 1/27/20 3:39 AM, Aleksandar Markovic wrote: > >> +static void avr_cpu_initfn(Object *obj) > >> +{ > >> +AVRCPU *cpu = AVR_CPU(obj); > >> + > >> +cpu_set_cpustate_pointers(cpu); > >> + > >> +#ifndef CONFIG_USER_ONLY > >> +

Re: [PATCH 2/8] tests/vm: increased max timeout for vm boot.

On 1/24/20 8:00 PM, Robert Foley wrote: Hi Phil, I once suggested "When using TCG, wait longer for a VM to start" https://www.mail-archive.com/qemu-devel@nongnu.org/msg550610.html Thanks for the pointer. This increase in timeout under TCG seems just right for the case we saw. I will incorpo

Re: [PATCH rc3 02/30] target/avr: Introduce AVR CPU class object

Hi all. As for now I have no plans to add support for AVR 32 bit CPU. If there are requests I might consider it. When I started to implement AVR 8 bit CPU I added that `#ifndef CONFIG_USER_ONLY` as other CPUs did, so I guess they could be removed. Regards, Michael Rolnik On Mon, Jan 27, 2020 at

Re: [PATCH rc3 01/30] target/avr: Add basic parameters for new AVR platform

Thanks for you help guys. On Mon, Jan 27, 2020 at 12:55 AM Aleksandar Markovic < aleksandar.marko...@rt-rk.com> wrote: > From: Michael Rolnik > > This includes definitions of various basic parameters needed > for integration of a new platform into QEMU. > > Co-developed-by: Michael Rolnik > Co-

Re: [PATCH rc2 01/25] target/avr: Add outward facing interfaces and core CPU logic

Hi Joaquin. `AVR_FEATURE_1_BYTE_PC` is used in `gen_push_ret` function (target/avr/translate.c) Regards, Michael Rolnik On Sun, Jan 26, 2020 at 2:15 PM Joaquin de Andres wrote: > Hi! In this mail I only checked the general code and one of the listed > features for the different types of avr. I

Re: Making QEMU easier for management tools and applications

Daniel P. Berrangé writes: > On Thu, Jan 23, 2020 at 04:07:09PM -0500, John Snow wrote: >> >> >> On 1/23/20 2:01 PM, Daniel P. Berrangé wrote: [...] >> > I guess my point is that with a scrap & startover view point, we >> > should arguably completely ignore the design question of how to >> > fl

Re: [PATCH v2] hw/i386: disable smbus migration for xenfv

Am Mon, 20 Jan 2020 11:18:41 + schrieb Paul Durrant : > On Fri, 17 Jan 2020 at 13:06, Olaf Hering wrote: > > What would future domUs lose if 'xenfv' would be locked to 'pc-i440fx-3.0'? > I guess eventually that pc type would be removed and then we'd have a > compat issue. Ideally I think lib

Re: [PATCH 2/2] virtio-balloon: Reject qmp_balloon during hot-unplug

On 23.01.20 16:46, Julia Suvorova wrote: > On Thu, Jan 23, 2020 at 3:17 PM David Hildenbrand wrote: >> >> On 23.01.20 15:08, Julia Suvorova wrote: >>> On Thu, Jan 16, 2020 at 1:36 PM David Hildenbrand wrote: On 15.01.20 23:40, Julia Suvorova wrote: > Hot-unplug takes some time due t

Re: [PATCH v3.1 74/80] exec: cleanup qemu_minrampagesize()/qemu_maxrampagesize()

On Mon, Jan 27, 2020 at 09:06:48AM +0100, Igor Mammedov wrote: > Since all RAM is backed by hostmem backends, drop > global -mem-path invariant and simplify code. > > Signed-off-by: Igor Mammedov > --- > v4: > * fix access to uninitialized pagesize/hpsize > (David Gibson ) Reviewed-by: Dav

Re: [PATCH rc2 01/25] target/avr: Add outward facing interfaces and core CPU logic

Sorry, I was thinking in one and put the other, I mean 'AVR_FEATURE_1_BYTE_SP'. --joa On 1/27/20 9:53 AM, Michael Rolnik wrote: > Hi Joaquin. > > `AVR_FEATURE_1_BYTE_PC` is used in `gen_push_ret` function > (target/avr/translate.c) > > Regards, > Michael Rolnik > > On Sun, Jan 26, 2020 at 2:15

Re: [GSoC/Outreachy QEMU proposal] Extend support for ioctls in QEMU linux-user mode

On Thu, Jan 23, 2020 at 02:34:01PM +0100, Aleksandar Markovic wrote: > *Extend support for ioctls in QEMU linux-user mode* > > > > *PLANNED ACTIVITIES* > > BACKGROUND > > There is currently 2500+ ioctls defined in Linux kernel. QEMU linux-user > currently supports only several hundred. There i

Re: Making QEMU easier for management tools and applications

Paolo Bonzini writes: > Il mer 15 gen 2020, 10:21 Markus Armbruster ha scritto: > >> > We don’t want the QAPI to let arbitrary fields of a QOM object >> > be modified, do we? >> >> We already do: QMP command qom-set. If it breaks your guest, you get to >> keep the pieces. >> > > That's not true

Re: [PATCH v3 4/4] travis.yml: Enable acceptance KVM tests

On 24/01/2020 22.15, Wainer dos Santos Moschetta wrote: > > On 1/22/20 7:22 AM, Thomas Huth wrote: >> On 22/01/2020 02.27, Wainer dos Santos Moschetta wrote: >>> Some acceptance tests require KVM or they are skipped. Travis >>> enables nested virtualization by default with Ubuntu >>> 18.04 (Bionic

Re: [PATCH v2] hw/i386: disable smbus migration for xenfv

On 20/01/20 12:18, Paul Durrant wrote: >> >> What would future domUs lose if 'xenfv' would be locked to 'pc-i440fx-3.0'? > > I guess eventually that pc type would be removed and then we'd have a > compat issue. That's years away, so ideally libxl would have migrated away from xenfv before that. F

Re: [PATCH v3 4/4] travis.yml: Enable acceptance KVM tests

On 1/24/20 8:55 PM, Wainer dos Santos Moschetta wrote: On 1/24/20 7:54 AM, Philippe Mathieu-Daudé wrote: On 1/24/20 10:44 AM, Thomas Huth wrote: On 24/01/2020 10.38, Philippe Mathieu-Daudé wrote: On 1/22/20 2:27 AM, Wainer dos Santos Moschetta wrote: Some acceptance tests require KVM or they

Re: [PATCH v2 0/4] virtio-pci: enable blk and scsi multi-queue by default

On Fri, Jan 24, 2020 at 10:01:55AM +, Stefan Hajnoczi wrote: > v2: > * Let the virtio-DEVICE-pci device select num-queues because the optimal >multi-queue configuration may differ between virtio-pci, virtio-mmio, and >virtio-ccw [Cornelia] > > Enabling multi-queue on virtio-pci storag

Re: [qemu-web PATCH v2] Add "Security Process" information to the main website

On 23/01/2020 20.43, Eric Blake wrote: > On 1/23/20 11:11 AM, Thomas Huth wrote: >> One reporter of a security issue recently complained that it might not >> be the best idea to store our "Security Process" in the Wiki. Well, while >> the page in the Wiki is protected (so that only some few people

Re: Making QEMU easier for management tools and applications

On Mon, Jan 27, 2020 at 10:06:45AM +0100, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > * qemu-system-$TARGET > > > > The current binaries that exist today. > > > > qemu-system-$TARGET should not be part of our formal > > stability promise. We won't gratuitously / knowing

Re: Making QEMU easier for management tools and applications

On Sat, Jan 25, 2020 at 12:52:30PM +0100, Paolo Bonzini wrote: > On 24/01/20 10:50, Daniel P. Berrangé wrote: > > * qemu-launcher-$TARGET > > > > A binary that is able to launch qemu-runtime-$TARGET > > with jailers active. > > > > This has no command line arguments except for a pai

Re: Making QEMU easier for management tools and applications

On Sat, Jan 25, 2020 at 11:18:41AM +0100, Markus Armbruster wrote: > Kevin Wolf writes: > > > Am 24.01.2020 um 11:27 hat Daniel P. Berrangé geschrieben: > >> So if we allowed YAML instead of JSON, now we get... > >> > >> $ cat qemu.yaml > >> --- > >> arguments: > >> - arg: object > >>

Re: [PATCH v2] qemu-cpu-models: Document -noTSX, mds-no, taa-no, and tsx-ctrl

On Wed, Jan 22, 2020 at 06:20:51PM +0100, Paolo Bonzini wrote: > On 21/01/20 19:49, Kashyap Chamarthy wrote: > > Question: How can a user validate that TSX is indeed disabled for the > > guest? > > Look for rtm in /proc/cpuinfo, or look at the TAA entry in the sysfs > vulnerabilities dir

[PATCH v3 00/13] RFC: [for 5.0]: HMP monitor handlers cleanups

This patch series is bunch of cleanups to the hmp monitor code. This series only touched blockdev related hmp handlers. No functional changes expected other that light error message changes by the last patch. This was inspired by this bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1719169

[PATCH v3 01/13] usb/dev-storage: remove unused include

Signed-off-by: Maxim Levitsky --- hw/usb/dev-storage.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c index 8545193488..50d12244ab 100644 --- a/hw/usb/dev-storage.c +++ b/hw/usb/dev-storage.c @@ -19,7 +19,6 @@ #include "hw/scsi/scsi.h" #include "u

[PATCH v3 03/13] monitor/hmp: rename device-hotplug.c to block/monitor/block-hmp-cmds.c

These days device-hotplug.c only contains the hmp_drive_add In the next patch, rest of hmp_drive* functions will be moved there. Also change the license of that file to GPL2+ since most of the code that will be moved there is under that license Also add block-hmp-commands.h to contain prototypes

[PATCH v3 02/13] monitor/hmp: uninline add_init_drive

This is only used by hmp_drive_add. The code is just a bit shorter this way. No functional changes Signed-off-by: Maxim Levitsky Reviewed-by: Markus Armbruster --- device-hotplug.c | 31 --- 1 file changed, 12 insertions(+), 19 deletions(-) diff --git a/device-hotp

[PATCH v3 07/13] monitor/hmp: move hmp_snapshot_* to block-hmp-cmds.c

Signed-off-by: Maxim Levitsky --- block/monitor/block-hmp-cmds.c | 47 ++ include/block/block-hmp-commands.h | 4 +++ include/monitor/hmp.h | 3 -- monitor/hmp-cmds.c | 47 -- 4 files changed, 51 insertions

[PATCH v3 08/13] monitor/hmp: move hmp_nbd_server* to block-hmp-cmds.c

Signed-off-by: Maxim Levitsky --- block/monitor/block-hmp-cmds.c | 88 ++ include/block/block-hmp-commands.h | 5 ++ include/monitor/hmp.h | 4 -- monitor/hmp-cmds.c | 87 - 4 files changed, 93 insertions(+

[PATCH v3 04/13] monitor/hmp: move hmp_drive_del and hmp_commit to block-hmp-cmds.c

Signed-off-by: Maxim Levitsky --- block/monitor/block-hmp-cmds.c | 97 +- blockdev.c | 95 - include/block/block-hmp-commands.h | 3 + include/sysemu/blockdev.h | 4 -- 4 files changed, 99 insertions(+)

[PATCH v3 05/13] monitor/hmp: move hmp_drive_mirror and hmp_drive_backup to block-hmp-cmds.c

Signed-off-by: Maxim Levitsky --- block/monitor/block-hmp-cmds.c | 64 ++ include/block/block-hmp-commands.h | 3 ++ include/monitor/hmp.h | 2 - monitor/hmp-cmds.c | 58 --- 4 files changed, 67 insertions(+),

[PATCH v3 06/13] monitor/hmp: move hmp_block_job* to block-hmp-cmds.c

Signed-off-by: Maxim Levitsky --- block/monitor/block-hmp-cmds.c | 52 ++ include/block/block-hmp-commands.h | 6 include/monitor/hmp.h | 5 --- monitor/hmp-cmds.c | 52 -- 4 files changed, 58 insertio

[PATCH v3 10/13] monitor/hmp: move hmp_info_block* to block-hmp-cmds.c

Signed-off-by: Maxim Levitsky --- block/monitor/block-hmp-cmds.c | 388 + include/block/block-hmp-commands.h | 4 + include/monitor/hmp.h | 4 - monitor/hmp-cmds.c | 388 - 4 files changed, 392 insertions

[PATCH v3 09/13] monitor/hmp: move remaining hmp_block* functions to block-hmp-cmds.c

Signed-off-by: Maxim Levitsky --- block/monitor/block-hmp-cmds.c | 138 + include/block/block-hmp-commands.h | 9 ++ include/monitor/hmp.h | 6 -- monitor/hmp-cmds.c | 137 4 files changed, 147 insertion

[PATCH v3 11/13] monitor: Move hmp_drive_add_node to block-hmp-cmds.c

Signed-off-by: Maxim Levitsky --- block/monitor/block-hmp-cmds.c | 30 blockdev.c | 42 +++--- include/block/block_int.h | 5 ++-- 3 files changed, 41 insertions(+), 36 deletions(-) diff --git a/block/monitor/block-hm

Re: [PATCH rc2 01/25] target/avr: Add outward facing interfaces and core CPU logic

On 1/27/20 10:48 AM, Michael Rolnik wrote: > Not used. it's there just for clarity. to follow the pattern like PC > > AVR_FEATURE_1_BYTE_PC, > AVR_FEATURE_2_BYTE_PC, > AVR_FEATURE_3_BYTE_PC, > > AVR_FEATURE_1_BYTE_SP, > AVR_FEATURE_2_BYTE_SP, > > To show that there is no

[PATCH v3 13/13] monitor/hmp: Prefer to use hmp_handle_error for error reporting in block hmp commands

This way they all will be prefixed with 'Error:' which some parsers (e.g libvirt) need Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1719169 Signed-off-by: Maxim Levitsky --- block/monitor/block-hmp-cmds.c | 35 -- 1 file changed, 21 insertions(+), 14 del

Re: [PATCH] tests/acceptance: Add boot tests for some of the QEMU advent calendar images

On 25/01/2020 19.38, Philippe Mathieu-Daudé wrote: > On 1/25/20 5:43 PM, Thomas Huth wrote: >> On 24/01/2020 22.28, Wainer dos Santos Moschetta wrote: >>> >>> On 1/24/20 3:03 PM, Thomas Huth wrote: The 2018 edition of the QEMU advent calendar 2018 featured Linux images for various non-x86

Re: [PATCH v3 01/13] usb/dev-storage: remove unused include

On 1/27/20 11:36 AM, Maxim Levitsky wrote: Signed-off-by: Maxim Levitsky --- hw/usb/dev-storage.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c index 8545193488..50d12244ab 100644 --- a/hw/usb/dev-storage.c +++ b/hw/usb/dev-storage.c @@ -19,7 +

Re: [PATCH 2/2] virtio-balloon: Reject qmp_balloon during hot-unplug

On Thu, Jan 23, 2020 at 04:46:18PM +0100, Julia Suvorova wrote: > On Thu, Jan 23, 2020 at 3:17 PM David Hildenbrand wrote: > > > > On 23.01.20 15:08, Julia Suvorova wrote: > > > On Thu, Jan 16, 2020 at 1:36 PM David Hildenbrand > > > wrote: > > >> > > >> On 15.01.20 23:40, Julia Suvorova wrote:

Re: [PATCH v3 00/13] RFC: [for 5.0]: HMP monitor handlers cleanups

Patchew URL: https://patchew.org/QEMU/20200127103647.17761-1-mlevi...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20200127103647.17761-1-mlevi...@redhat.com Subject: [PATCH v3 00/13] RFC: [for 5.0]: HMP

Re: [PATCH v3 00/13] RFC: [for 5.0]: HMP monitor handlers cleanups

On Mon, 2020-01-27 at 02:55 -0800, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20200127103647.17761-1-mlevi...@redhat.com/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: All of these errors are either fr

Re: [PATCH 1/9] monitor: uninline add_init_drive

On Wed, 2019-11-27 at 08:13 +0100, Markus Armbruster wrote: > Maxim Levitsky writes: > > > This is only used by hmp_drive_add. > > The code is just a bit shorter this way. > > > > No functional changes > > > > Signed-off-by: Maxim Levitsky > > --- > > device-hotplug.c | 33 +--

Re: [PATCH 3/9] monitor: move hmp_drive_del and hmp_commit to blockdev-hmp-cmds.c

On Wed, 2019-11-27 at 08:50 +0100, Markus Armbruster wrote: > Maxim Levitsky writes: > > > Signed-off-by: Maxim Levitsky > > --- > > blockdev-hmp-cmds.c | 97 - > > blockdev.c | 95 > > 2 files cha

Re: [PATCH 3/9] monitor: move hmp_drive_del and hmp_commit to blockdev-hmp-cmds.c

On Wed, 2019-11-27 at 08:29 +0100, Markus Armbruster wrote: > Maxim Levitsky writes: > > > Signed-off-by: Maxim Levitsky > > --- > > blockdev-hmp-cmds.c | 97 - > > blockdev.c | 95 > > 2 files cha

Re: [PATCH 4/9] monitor: move hmp_drive_mirror and hmp_drive_backup to blockdev-hmp-cmds.c

On Wed, 2019-11-27 at 08:22 +0100, Markus Armbruster wrote: > Maxim Levitsky writes: > > > Signed-off-by: Maxim Levitsky > > --- > > blockdev-hmp-cmds.c | 61 + > > monitor/hmp-cmds.c | 58 -- > > 2 files chang

Re: [PATCH 5/9] monitor: move hmp_block_job* to blockdev-hmp-cmd.c

On Wed, 2019-11-27 at 08:24 +0100, Markus Armbruster wrote: > Maxim Levitsky writes: > > > Signed-off-by: Maxim Levitsky > > --- > > blockdev-hmp-cmds.c | 52 + > > monitor/hmp-cmds.c | 52 - > > 2 files ch

Re: [PATCH 9/9] monitor/hmp: Prefer to use hmp_handle_error for error reporting in block hmp commands

On Wed, 2019-11-27 at 09:38 +0100, Markus Armbruster wrote: > Title is too long. blockdev-hmp-cmds.c will become > block/monitor/block-hmp-cmds.c in v2. With this in mind, suggest > > block/monitor: Prefer to use hmp_handle_error() to report HMP errors > > Maxim Levitsky writes: > > > Thi

Re: [PATCH 8/9] monitor: move hmp_info_block* to blockdev-hmp-cmds.c

On Wed, 2019-11-27 at 09:08 +0100, Markus Armbruster wrote: > I think it makes sense to collect *all* block HMP stuff here. > > Left in monitor/hmp-cmds.c: hmp_eject(), hmp_nbd_server_start(), ... > > I guess hmp_change() has to stay there, because it's both block and ui. > > Left in blockdev.c:

Re: [PATCH 3/8] tests/vm: change wait_ssh to optionally wait for root.

Robert Foley writes: > Allow wait_ssh to wait for root user to be ready. > This solves the issue where we perform a wait_ssh() > successfully, but the root user is not yet ready > to be logged in. So in the case it's the root user we care about... > Signed-off-by: Robert Foley > Reviewed-by:

Re: [PULL v4 00/58] Misc (x86 and QOM) patches for 2020-01-23

On Fri, 24 Jan 2020 at 20:19, Paolo Bonzini wrote: > > The following changes since commit 3e08b2b9cb64bff2b73fa9128c0e49bfcde0dd40: > > Merge remote-tracking branch > 'remotes/philmd-gitlab/tags/edk2-next-20200121' into staging (2020-01-21 > 15:29:25 +) > > are available in the git reposit

Re: [PATCH v6 2/2] s390: diagnose 318 info reset and migration support

[...] > @@ -0,0 +1,85 @@ > +/* > + * DIAGNOSE 0x318 functions for reset and migration > + * > + * Copyright IBM, Corp. 2019 Should be 2020 now. [...] > +static void s390_diag318_reset(DeviceState *dev) > +{ > +if (kvm_enabled()) > +kvm_s390_set_diag318_info(0); > +} > + > +static void

Re: [PATCH] bcm2835_dma: Fix TD mode

Hi Philippe, I'm running an example program for my Circle bare metal framework for the Raspberry Pi using the LittlevGL graphics library. It uses the TD DMA mode to transfer pixel data to the screen buffer (10 lines at a time). Without the given patch applied to QEMU only the first pixel line of e

Re: [PULL v3 00/11] target/hppa patch queue

On Fri, 24 Jan 2020 at 23:20, Richard Henderson wrote: > > Version 3 fixes printf formatting errors, and some indentation > errors, in artist.c, lasips2.c, and i82596.c. > > > r~ > > > The following changes since commit ba2ed84fe6a78f64b2da441750fc6e925d94106a: > > Merge remote-tracking branch '

Re: [PATCH v6 2/2] s390: diagnose 318 info reset and migration support

On 24/01/2020 23.14, Collin Walling wrote: > DIAGNOSE 0x318 (diag318) is a privileged s390x instruction that must > be intercepted by SIE and handled via KVM. Let's introduce some > functions to communicate between QEMU and KVM via ioctls. These > will be used to get/set the diag318 information. >

Re: [PATCH v6 2/2] s390: diagnose 318 info reset and migration support

On Fri, 24 Jan 2020 17:14:04 -0500 Collin Walling wrote: > DIAGNOSE 0x318 (diag318) is a privileged s390x instruction that must > be intercepted by SIE and handled via KVM. Let's introduce some > functions to communicate between QEMU and KVM via ioctls. These > will be used to get/set the diag318

Re: [PATCH] migration: Simplify get_qlist

Eric Auger wrote: > Instead of inserting read elements at the head and > then reversing the list, it is simpler to add > each element after the previous one. Introduce > QLIST_RAW_INSERT_AFTER helper and use it in > get_qlist(). > > Signed-off-by: Eric Auger > Suggested-by: Juan Quintela Review

[PATCH 1/2] NetRxPkt: Introduce support for additional hash types

Add support for following hash types: IPV6 TCP with extension headers IPV4 UDP IPV6 UDP IPV6 UDP with extension headers Signed-off-by: Yuri Benditovich --- hw/net/net_rx_pkt.c | 42 ++ hw/net/net_rx_pkt.h | 6 +- hw/net/trace-events | 4 3 files

[PATCH 2/2] NetRxPkt: fix hash calculation of IPV6 TCP

When requested to calculate the hash for TCPV6 packet, ignore overrides of source and destination addresses in in extension headers. Use these overrides when new hash type NetPktRssIpV6TcpEx requested. Use this type in e1000e hash calculation for IPv6 TCP, which should take in account overrides of

Re: Making QEMU easier for management tools and applications

Am 25.01.2020 um 11:18 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 24.01.2020 um 11:27 hat Daniel P. Berrangé geschrieben: > >> This is finally something I'd consider to be on a par with the > >> original QEMU syntax, before we added hierarchical data. You > >> have the minim

Re: [qemu-web PATCH v2] Add "Security Process" information to the main website

On Mon, Jan 27, 2020 at 11:00:29AM +0100, Thomas Huth wrote: > On 23/01/2020 20.43, Eric Blake wrote: > > On 1/23/20 11:11 AM, Thomas Huth wrote: > >> One reporter of a security issue recently complained that it might not > >> be the best idea to store our "Security Process" in the Wiki. Well, whil

Re: [PULL 016/111] virtiofsd: Add options for virtio

Dr. David Alan Gilbert (git) writes: > From: "Dr. David Alan Gilbert" > > Add options to specify parameters for virtio-fs paths, i.e. > >./virtiofsd -o vhost_user_socket=/tmp/vhostqemu Shouldn't that be --socket-path=/tmp/vhostqemu now? > > Signed-off-by: Dr. David Alan Gilbert > Reviewe

Re: Making QEMU easier for management tools and applications

On Mon, 27 Jan 2020 at 11:56, Kevin Wolf wrote: > If you have a long-lived production VM that you always run with the same > configuration, then yes, having a config file for it in the file system > is what you probably want. Currently, for this case, people directly > using QEMU tend to write a s

Re: Making QEMU easier for management tools and applications

Am 27.01.2020 um 09:35 hat Gerd Hoffmann geschrieben: > Hi, > > > We build a "configuration" struct in QAPI, and extend from there. > > > > (2) We offer "--config myconfig.yaml" as an option for specifying > > options. > > Yes. > > > This precludes the use of *any* traditional command line fl

[PATCH v3] qemu-cpu-models: Document -noTSX, mds-no, taa-no, and tsx-ctrl

- Add the '-noTSX' variants for CascadeLake and SkyLake. - Document the three MSR bits: 'mds-no', 'taa-no', and 'tsx-ctrl' Two confusing about 'mds-no' (and the first point applies to the other two MSRs too): (1) The 'mds-no' will _not_ show up in the guest's /proc/cpuinfo. Rather it

[PULL 00/15] s390x update

The following changes since commit 760df0d121a836dcbf3726b80b820115aef21b30: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2020-01-27 09:44:04 +) are available in the Git repository at: https://github.com/cohuck/qemu tags/s390x-20200127

[PULL 01/15] s390x/sclp.c: remove unneeded label in sclp_service_call()

From: Daniel Henrique Barboza 'out' label can be replaced by 'return' with the appropriate value. The 'r' integer, which is used solely to set the return value for this label, can also be removed. CC: Cornelia Huck CC: Halil Pasic CC: Christian Borntraeger Signed-off-by: Daniel Henrique Barbo

[PULL 02/15] intc/s390_flic_kvm.c: remove unneeded label in kvm_flic_load()

From: Daniel Henrique Barboza 'out' label can be replaced by 'return' with the appropriate value that is set by 'r' right before the jump. Cc: Christian Borntraeger Signed-off-by: Daniel Henrique Barboza Message-Id: <20200106182425.20312-42-danielhb...@gmail.com> Reviewed-by: Thomas Huth Sign

[PULL 15/15] s390x: sigp: Fix sense running reporting

From: Janosch Frank The logic was inverted and reported running if the cpu was stopped. Let's fix that. Signed-off-by: Janosch Frank Fixes: d1b468bc8869 ("s390x/tcg: implement SIGP SENSE RUNNING STATUS") Reviewed-by: David Hildenbrand Message-Id: <20200124134818.9981-1-fran...@linux.ibm.com> S

[PULL 03/15] s390x/event-facility.c: remove unneeded labels

From: Daniel Henrique Barboza 'out' label from write_event_mask() and write_event_data() can be replaced by 'return'. The 'out' label from read_event_data() can also be replaced. However, as suggested by Cornelia Huck, instead of simply replacing the 'out' label, let's also change the code flow

[PULL 04/15] s390x: adapter routes error handling

If the kernel irqchip has been disabled, we don't want the {add,release}_adapter_routes routines to call any kvm_irqchip_* interfaces, as they may rely on an irqchip actually having been created. Just take a quick exit in that case instead. If you are trying to use irqfd without a kernel irqchip, w

[PULL 07/15] docs/devel: fix stable process doc formatting

Enumeration of stable criteria needs proper bullet points. Message-Id: <20200113103023.31255-1-coh...@redhat.com> Reviewed-by: Stefan Hajnoczi Signed-off-by: Cornelia Huck --- docs/devel/stable-process.rst | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/devel/stab

[PULL 10/15] target/s390x: Remove DisasFields argument from callbacks

From: Richard Henderson The DisasFields data is available from DisasContext. We do not need to pass a separate argument. Signed-off-by: Richard Henderson Message-Id: <20200123232248.1800-3-richard.hender...@linaro.org> Reviewed-by: Thomas Huth Signed-off-by: Cornelia Huck --- target/s390x/tr

[PULL 05/15] s390x/event-facility: fix error propagation

We currently check (by error) if the passed-in Error pointer errp is non-null and return after realizing the first child of the event facility in that case. Symptom is that 'virsh shutdown' does not work, as the sclpquiesce device is not realized. Fix this by (correctly) checking the local Error e

[PULL 09/15] target/s390x: Move struct DisasFields definition earlier

From: Richard Henderson We will want to include the struct in DisasContext. Signed-off-by: Richard Henderson Message-Id: <20200123232248.1800-2-richard.hender...@linaro.org> Reviewed-by: Thomas Huth Signed-off-by: Cornelia Huck --- target/s390x/translate.c | 164 -

[PULL 12/15] target/s390x: Move DisasFields into DisasContext

From: Richard Henderson I believe that the separate allocation of DisasFields from DisasContext was meant to limit the places from which we could access fields. But that plan did not go unchanged, and since DisasContext contains a pointer to fields, the substructure is accessible everywhere. By

[PULL 13/15] target/s390x: Remove DisasFields argument from extract_insn

From: Richard Henderson The separate pointer is now redundant. Signed-off-by: Richard Henderson Message-Id: <20200123232248.1800-6-richard.hender...@linaro.org> Reviewed-by: Thomas Huth Signed-off-by: Cornelia Huck --- target/s390x/translate.c | 19 --- 1 file changed, 8 inse

[PULL 06/15] target/s390x: Remove duplicated ifdef macro

From: Philippe Mathieu-Daudé Commit ae71ed8610 replaced the use of global max_cpus variable with a machine property, but introduced a unnecessary ifdef, as this block is already in the 'not CONFIG_USER_ONLY' branch part: 86 #if defined(CONFIG_USER_ONLY) 87 ... 106 #else /* !CONFIG_USER

[PULL 14/15] hw/s390x: Add a more verbose comment about get_machine_class() and the wrappers

From: Thomas Huth While working on the "Enable adapter interruption suppression again" recently, I had to discover that the meaning of get_machine_class() and the related *_allowed() wrappers is not very obvious. Add a more verbose comment here to clarify how these should be used. Signed-off-by:

[PULL 08/15] target/s390x/kvm: Enable adapter interruption suppression again

From: Thomas Huth The AIS feature has been disabled late in the v2.10 development cycle since there were some issues with migration (see commit 3f2d07b3b01ea61126b - "s390x/ais: for 2.10 stable: disable ais facility"). We originally wanted to enable it again for newer machine types, but apparentl

Re: [PATCH 4/8] tests/vm: Add configuration to basevm.py

Robert Foley writes: > Added use of a configuration to tests/vm/basevm.py. > The configuration provides parameters used to configure a VM. > This allows for providing alternate configurations to the VM being > created/launched. cpu, machine, memory, and NUMA configuration are all > examples of

[PULL 11/15] target/s390x: Pass DisasContext to get_field and have_field

From: Richard Henderson All callers pass s->fields, so we might as well pass s directly. Signed-off-by: Richard Henderson Message-Id: <20200123232248.1800-4-richard.hender...@linaro.org> Reviewed-by: Thomas Huth Signed-off-by: Cornelia Huck --- target/s390x/translate.c| 534 +

Re: [PATCH 5/8] tests/vm: Added configuration file support

Robert Foley writes: > Changes to tests/vm/basevm.py to allow accepting a configuration file > as a parameter. Allows for specifying VM options such as > cpu, machine, memory, and arbitrary qemu arguments for specifying options > such as NUMA configuration. > Also added an example config_exampl

Re: [PULL 111/111] virtiofsd: add some options to the help message

Dr. David Alan Gilbert (git) writes: > From: Masayoshi Mizuma > > Add following options to the help message: > - cache > - flock|no_flock > - norace > - posix_lock|no_posix_lock > - readdirplus|no_readdirplus > - timeout > - writeback|no_writeback > - xattr|no_xattr > > Signed-off-by: Masayoshi

Re: [PATCH] iotests/279: Fix for non-qcow2 formats

On 19/12/2019 15.42, Max Reitz wrote: > First, driver=qcow2 will not work so well with non-qcow2 formats (and > this test claims to support qcow, qed, and vmdk). > > Second, vmdk will always report the backing file format to be vmdk. > Filter that out so the output looks like for all other formats

Re: Making QEMU easier for management tools and applications

Daniel P. Berrangé writes: > On Sat, Jan 25, 2020 at 11:18:41AM +0100, Markus Armbruster wrote: >> Kevin Wolf writes: >> >> > Am 24.01.2020 um 11:27 hat Daniel P. Berrangé geschrieben: >> >> So if we allowed YAML instead of JSON, now we get... >> >> >> >> $ cat qemu.yaml [...] >> >> This is

Re: [PATCH 6/8] tests/vm: add --boot-console switch

Robert Foley writes: > Added ability to view console during boot via > --boot-console switch. This helps debug issues that occur > during the boot sequence. > > Signed-off-by: Robert Foley > Reviewed-by: Peter Puhov > --- > tests/vm/basevm.py | 6 ++ > 1 file changed, 6 insertions(+) >

Re: [PATCH v2 1/4] virtio-scsi: introduce a constant for fixed virtqueues

On Fri, 24 Jan 2020 10:01:56 + Stefan Hajnoczi wrote: > The event and control virtqueues are always present, regardless of the > multi-queue configuration. Define a constant so that virtqueue number > calculations are easier to read. > > Signed-off-by: Stefan Hajnoczi > --- > hw/scsi/vhos

Re: [PATCH 3/8] tests/vm: change wait_ssh to optionally wait for root.

On Mon, 27 Jan 2020 at 06:06, Alex Bennée wrote: > > Allow wait_ssh to wait for root user to be ready. > > This solves the issue where we perform a wait_ssh() > > successfully, but the root user is not yet ready > > to be logged in. > > So in the case it's the root user we care about... We care ab

Re: [PATCH v2 2/4] virtio-scsi: default num_queues to -smp N

On Fri, 24 Jan 2020 10:01:57 + Stefan Hajnoczi wrote: > Automatically size the number of request virtqueues to match the number "If the pci transport is used, ..." ? > of vCPUs. This ensures that completion interrupts are handled on the > same vCPU that submitted the request. No IPI is ne

Re: [PATCH v2 3/4] virtio-blk: default num_queues to -smp N

On Fri, 24 Jan 2020 10:01:58 + Stefan Hajnoczi wrote: > Automatically size the number of request virtqueues to match the number > of vCPUs. This ensures that completion interrupts are handled on the > same vCPU that submitted the request. No IPI is necessary to complete > an I/O request and

Re: [PATCH v2 4/4] vhost-user-blk: default num_queues to -smp N

On Fri, 24 Jan 2020 10:01:59 + Stefan Hajnoczi wrote: > Automatically size the number of request virtqueues to match the number > of vCPUs. This ensures that completion interrupts are handled on the > same vCPU that submitted the request. No IPI is necessary to complete > an I/O request and

Re: [PATCH] tests/acceptance: Add boot tests for some of the QEMU advent calendar images

On 1/25/20 2:43 PM, Thomas Huth wrote: On 24/01/2020 22.28, Wainer dos Santos Moschetta wrote: On 1/24/20 3:03 PM, Thomas Huth wrote: The 2018 edition of the QEMU advent calendar 2018 featured Linux images for various non-x86 machines. We can use them for a boot tests in our acceptance test s

  1   2   3   >