Re: [PATCH v2 85/86] numa: make exit() usage consistent

2020-01-17 Thread Philippe Mathieu-Daudé
Hi Thomas, On 1/16/20 5:43 PM, Thomas Huth wrote: On 15/01/2020 16.07, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- CC: ehabk...@redhat.com --- hw/core/numa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/core/numa.c b/hw/core/numa.c index 3177066..47d5

Re: [PATCH v2 3/5] a standone-alone tool to directly share disk image file via vhost-user protocol

2020-01-17 Thread Coiby Xu
Excellent! I will add an option (or object property) for vhost-user-blk server oject which will tell the daemon process to exit when the client disconnects, thus "make check-qtest" will not get held by this daemon process. After that since Kevin's qemu-storage-daemon support "-object" option (https

Re: [PATCH v3 4/4] block: Mark 'block_resize' as coroutine

2020-01-17 Thread Markus Armbruster
Kevin Wolf writes: > Am 16.01.2020 um 10:45 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> > block_resize is safe to run in a coroutine, so use it as an example for >> > the new 'coroutine': true annotation in the QAPI schema. >> > >> > Signed-off-by: Kevin Wolf >> > Reviewed-by: M

[BUG Report] Got a use-after-free error while start arm64 VM with lots of pci controllers

2020-01-17 Thread Pan Nengyuan
Hi, We got a use-after-free report in our Euler Robot Test, it is can be reproduced quite easily, It can be reproduced by start VM with lots of pci controller and virtio-scsi devices. You can find the full qemu log from attachment. We have analyzed the log and got the rough process how it happen

Re: [BUG Report] Got a use-after-free error while start arm64 VM with lots of pci controllers

2020-01-17 Thread Pan Nengyuan
Cc: euler.ro...@huawei.com On 1/17/2020 4:18 PM, Pan Nengyuan wrote: > Hi, > > We got a use-after-free report in our Euler Robot Test, it is can be > reproduced quite easily, > It can be reproduced by start VM with lots of pci controller and virtio-scsi > devices. > You can find the full qemu l

Re: [PATCH v2 85/86] numa: make exit() usage consistent

2020-01-17 Thread Thomas Huth
On 17/01/2020 09.06, Philippe Mathieu-Daudé wrote: > Hi Thomas, > > On 1/16/20 5:43 PM, Thomas Huth wrote: >> On 15/01/2020 16.07, Igor Mammedov wrote: >>> Signed-off-by: Igor Mammedov >>> --- >>> CC: ehabk...@redhat.com >>> --- >>>   hw/core/numa.c | 4 ++-- >>>   1 file changed, 2 insertions(+),

Re: [PATCH v2 85/86] numa: make exit() usage consistent

2020-01-17 Thread Thomas Huth
On 17/01/2020 09.26, Thomas Huth wrote: > On 17/01/2020 09.06, Philippe Mathieu-Daudé wrote: >> Hi Thomas, >> >> On 1/16/20 5:43 PM, Thomas Huth wrote: >>> On 15/01/2020 16.07, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- CC: ehabk...@redhat.com ---   hw/core/numa

Re: [PATCH 094/104] virtiofsd: do not always set FUSE_FLOCK_LOCKS

2020-01-17 Thread Misono Tomohiro
> From: Peng Tao > > Right now we always enable it regardless of given commandlines. > Fix it by setting the flag relying on the lo->flock bit. > > Signed-off-by: Peng Tao I think we should remove LL_SET_DEFAULT for flock/posix_lock in do_init() but that can be done in another patch. Reviewed

Re: [PATCH] spapr: Fail CAS if option vector table cannot be parsed

2020-01-17 Thread Greg Kurz
On Fri, 17 Jan 2020 15:46:57 +1000 David Gibson wrote: > On Thu, Jan 16, 2020 at 04:34:06PM +0100, Philippe Mathieu-Daudé wrote: > > Hi Greg, > > > > On 1/16/20 4:05 PM, Greg Kurz wrote: > > > Most of the option vector helpers have assertions to check their > > > arguments aren't null. The guest

Re: [PATCH v2 4/4] qcow2: Use BDRV_SECTOR_SIZE instead of the hardcoded value

2020-01-17 Thread Max Reitz
On 17.01.20 00:26, Alberto Garcia wrote: > On Tue 14 Jan 2020 03:15:48 PM CET, Max Reitz wrote: >>> @@ -219,7 +219,7 @@ static int l2_load(BlockDriverState *bs, uint64_t >>> offset, >>> * Writes one sector of the L1 table to the disk (can't update single >>> entries >>> * and we really don't

Re: [PATCH v3 4/4] block: Mark 'block_resize' as coroutine

2020-01-17 Thread Kevin Wolf
Am 17.01.2020 um 09:13 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 16.01.2020 um 10:45 hat Markus Armbruster geschrieben: > >> Kevin Wolf writes: > >> > block_resize is safe to run in a coroutine, so use it as an example for > >> > the new 'coroutine': true annotation in the

[PATCH v3] spapr: Fail CAS if option vector table cannot be parsed

2020-01-17 Thread Greg Kurz
Most of the option vector helpers have assertions to check their arguments aren't null. The guest can provide an arbitrary address for the CAS structure that would result in such null arguments. Fail CAS with H_PARAMETER and print a warning instead of aborting QEMU. Signed-off-by: Greg Kurz Revie

Re: [PATCH v2] hw/i386: disable smbus migration for xenfv

2020-01-17 Thread Olaf Hering
Am Thu, 16 Jan 2020 19:26:39 +0100 schrieb Paolo Bonzini : > My understanding is that Xen is able to use "-M > pc-i440fx-VERSION,accel=xen". The presence of the version in the > machine type guarantees that the migration stream is compatible and that > the hardware exposed to the guest is the sam

Re: [PATCH v19 0/7]target-ppc/spapr: Add FWNMI support in QEMU for PowerKM guests

2020-01-17 Thread Ganesh
On 1/16/20 10:09 PM, Ganesh Goudar wrote: This patch set adds support for FWNMI in PowerKVM guests. System errors such as SLB multihit and memory errors that cannot be corrected by hardware is passed on to the kernel for handling by raising machine check exception (an NMI). Upon such machine

Re: [PATCH v3 4/4] block: Mark 'block_resize' as coroutine

2020-01-17 Thread Kevin Wolf
Am 17.01.2020 um 06:44 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 16.01.2020 um 16:13 hat Markus Armbruster geschrieben: > >> Kevin Wolf writes: > >> > >> > Am 16.01.2020 um 10:45 hat Markus Armbruster geschrieben: > >> >> Kevin Wolf writes: > >> >> > block_resize is safe

Re: [PATCH 085/104] virtiofsd: Support remote posix locks

2020-01-17 Thread Dr. David Alan Gilbert
* Vivek Goyal (vgo...@redhat.com) wrote: > On Wed, Jan 15, 2020 at 06:38:31PM -0500, Masayoshi Mizuma wrote: > > [..] > > > +/* Should be called with inode->plock_mutex held */ > > > +static struct lo_inode_plock *lookup_create_plock_ctx(struct lo_data *lo, > > > +

[Bug 1859920] Re: daemoniz not working on MacOS

2020-01-17 Thread Thomas Huth
Have you tried to disable the GUI with "-display none" already? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1859920 Title: daemoniz not worki

Re: [PATCH] qapi: Fix code generation with Python 3.5

2020-01-17 Thread Thomas Huth
On 16/01/2020 21.25, Markus Armbruster wrote: > Recent commit 3e7fb5811b "qapi: Fix code generation for empty modules" > modules" switched QAPISchema.visit() from > > for entity in self._entity_list: > > effectively to > > for mod in self._module_dict.values(): > for entity in mo

[PATCH v20 0/7]target-ppc/spapr: Add FWNMI support in QEMU for PowerKVM guests

2020-01-17 Thread Ganesh Goudar
This patch set adds support for FWNMI in PowerKVM guests. System errors such as SLB multihit and memory errors that cannot be corrected by hardware is passed on to the kernel for handling by raising machine check exception (an NMI). Upon such machine check exceptions, if the address in error belon

[PATCH v20 1/7] Wrapper function to wait on condition for the main loop mutex

2020-01-17 Thread Ganesh Goudar
From: Aravinda Prasad Introduce a wrapper function to wait on condition for the main loop mutex. This function atomically releases the main loop mutex and causes the calling thread to block on the condition. This wrapper is required because qemu_global_mutex is a static variable. Signed-off-by:

[PATCH v20 6/7] migration: Include migration support for machine check handling

2020-01-17 Thread Ganesh Goudar
From: Aravinda Prasad This patch includes migration support for machine check handling. Especially this patch blocks VM migration requests until the machine check error handling is complete as these errors are specific to the source hardware and is irrelevant on the target hardware. Signed-off-b

[PATCH v20 7/7] ppc: spapr: Activate the FWNMI functionality

2020-01-17 Thread Ganesh Goudar
From: Aravinda Prasad This patch sets the default value of SPAPR_CAP_FWNMI_MCE to SPAPR_CAP_ON for machine type 4.2. Signed-off-by: Aravinda Prasad Signed-off-by: Ganesh Goudar --- hw/ppc/spapr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spa

[PATCH v20 2/7] ppc: spapr: Introduce FWNMI capability

2020-01-17 Thread Ganesh Goudar
From: Aravinda Prasad Introduce fwnmi an spapr capability and add a helper function which tries to enable it, which would be used by following patch of the series. This patch by itself does not change the existing behavior. Signed-off-by: Aravinda Prasad [eliminate cap_ppc_fwnmi, add fwnmi cap

Re: [PATCH v3 1/4] qapi: Add a 'coroutine' flag for commands

2020-01-17 Thread Kevin Wolf
Am 17.01.2020 um 08:57 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 16.01.2020 um 14:00 hat Markus Armbruster geschrieben: > >> Kevin Wolf writes: > >> > I have no idea if we will eventually get a case where the command wants > >> > to behave different between the two modes a

Re: [PATCH 046/104] virtiofsd: use /proc/self/fd/ O_PATH file descriptor

2020-01-17 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > On 12/12/19 5:38 PM, Dr. David Alan Gilbert (git) wrote: > > From: Stefan Hajnoczi > > > > Sandboxing will remove /proc from the mount namespace so we can no > > longer build string paths into "/proc/self/fd/...". > > > > Keep an O_PATH file

[PATCH v20 3/7] target/ppc: Handle NMI guest exit

2020-01-17 Thread Ganesh Goudar
From: Aravinda Prasad Memory error such as bit flips that cannot be corrected by hardware are passed on to the kernel for handling. If the memory address in error belongs to guest then the guest kernel is responsible for taking suitable action. Patch [1] enhances KVM to exit guest with exit reaso

[PATCH v20 4/7] target/ppc: Build rtas error log upon an MCE

2020-01-17 Thread Ganesh Goudar
From: Aravinda Prasad Upon a machine check exception (MCE) in a guest address space, KVM causes a guest exit to enable QEMU to build and pass the error to the guest in the PAPR defined rtas error log format. This patch builds the rtas error log, copies it to the rtas_addr and then invokes the gu

Re: [PATCH v2] hw/arm: Adjust some coding styles about memory hotplug

2020-01-17 Thread Igor Mammedov
On Fri, 17 Jan 2020 14:38:22 +0800 Keqian Zhu wrote: > From: zhukeqian > > There is extra indent in ACPI GED plug cb. And we can use > existing helper function to trigger hotplug handler plug. > > Reviewed-by: Igor Mammedov > Signed-off-by: Keqian Zhu > --- > > v1->v2: > - Add Igor's R-b

[PATCH v20 5/7] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2020-01-17 Thread Ganesh Goudar
From: Aravinda Prasad This patch adds support in QEMU to handle "ibm,nmi-register" and "ibm,nmi-interlock" RTAS calls. The machine check notification address is saved when the OS issues "ibm,nmi-register" RTAS call. This patch also handles the case when multiple processors experience machine ch

Re: [PATCH v3 18/86] arm:kzm: drop RAM size fixup

2020-01-17 Thread Igor Mammedov
On Thu, 16 Jan 2020 19:22:08 +0100 Philippe Mathieu-Daudé wrote: > On 1/16/20 6:26 PM, Igor Mammedov wrote: > > If the user provided too large a RAM size, the code used to > > complain and trim it to the max size. Now tht RAM is allocated by > > generic code, that's no longer possible, so genera

Re: [PATCH v2 4/4] qcow2: Use BDRV_SECTOR_SIZE instead of the hardcoded value

2020-01-17 Thread Kevin Wolf
Am 17.01.2020 um 10:12 hat Max Reitz geschrieben: > On 17.01.20 00:26, Alberto Garcia wrote: > > On Tue 14 Jan 2020 03:15:48 PM CET, Max Reitz wrote: > >>> @@ -219,7 +219,7 @@ static int l2_load(BlockDriverState *bs, uint64_t > >>> offset, > >>> * Writes one sector of the L1 table to the disk (c

[Bug 1859989] Re: qemu-img has broken output with large snapshot names

2020-01-17 Thread Max Reitz
Hi, When did this work last for you? I tried every .0 release down to 2.12.0, and all showed this kind of broken output. (I wasn’t able to compile 2.11.0 and earlier.) Here was my test case: $ ./qemu-img create -f qcow2 foo.qcow2 64M Formatting 'foo.qcow2', fmt=qcow2 size=67108864 cluster_size

Re: [PATCH v22 8/9] target-arm: kvm64: handle SIGBUS signal from kernel or KVM

2020-01-17 Thread gengdongjiu
On 2020/1/17 0:28, Peter Maydell wrote: > On Wed, 8 Jan 2020 at 11:33, Dongjiu Geng wrote: > >> +void kvm_arch_on_sigbus_vcpu(CPUState *c, int code, void *addr) >> +{ >> +ram_addr_t ram_addr; >> +hwaddr paddr; >> + >> +assert(code == BUS_MCEERR_AR || code == BUS_MCEERR_AO); >> + >> +

Re: [PATCH v2 3/5] a standone-alone tool to directly share disk image file via vhost-user protocol

2020-01-17 Thread Kevin Wolf
Am 17.01.2020 um 09:12 hat Coiby Xu geschrieben: > Excellent! I will add an option (or object property) for > vhost-user-blk server oject which will tell the daemon process to exit > when the client disconnects, thus "make check-qtest" will not get held > by this daemon process. After that since Ke

Re: [PATCH 0/4] linux-user: Fix some issues in termbits.h files

2020-01-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1579227117-6310-1-git-send-email-aleksandar.marko...@rt-rk.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 1579227117-6310-1-git-send-email-aleksandar.marko...@rt-rk.com Type: series Subjec

Re: [PATCH v22 9/9] MAINTAINERS: Add ACPI/HEST/GHES entries

2020-01-17 Thread gengdongjiu
On 2020/1/17 15:22, Philippe Mathieu-Daudé wrote: > Hi Peter, > > On 1/16/20 5:46 PM, Peter Maydell wrote: >> On Wed, 8 Jan 2020 at 11:32, Dongjiu Geng wrote: >>> >>> I and Xiang are willing to review the APEI-related patches and >>> volunteer as the reviewers for the HEST/GHES part. >>> >>> Sign

Re: [PATCH 072/104] virtiofsd: passthrough_ll: fix refcounting on remove/rename

2020-01-17 Thread Miklos Szeredi
On Thu, Jan 16, 2020 at 5:45 PM Dr. David Alan Gilbert wrote: > > * Misono Tomohiro (misono.tomoh...@jp.fujitsu.com) wrote: > > > From: Miklos Szeredi > > > > > > Signed-off-by: Miklos Szeredi > > > > I'm not familiar with qemu convention but shouldn't we put > > at least one line of description

[Bug 1859989] Re: qemu-img has broken output with large snapshot names

2020-01-17 Thread Max Reitz
I’ve just seen that launchpad collapses the spaces in the snapshot... All I can say is that diff tells me the output from 2.12.0 and 4.1.1 is exactly the same, with only one difference: 2.12.0 prints the VM SIZE as “0” (without a unit), whereas 4.1.1 prints “0 B”. But now I just realized you proba

Re: [PATCH v3 02/11] 9pfs: require msize >= 4096

2020-01-17 Thread Greg Kurz
On Thu, 16 Jan 2020 22:39:19 +0100 Christian Schoenebeck wrote: > On Donnerstag, 16. Januar 2020 19:07:48 CET Greg Kurz wrote: > > > The point here was that there must be some kind of absolute minimum msize, > > > > Then the absolute minimum size is 7, the size of the header part that is > > com

Re: [PATCH v2] hw/i386: disable smbus migration for xenfv

2020-01-17 Thread Paolo Bonzini
On 17/01/20 10:22, Olaf Hering wrote: > Am Thu, 16 Jan 2020 19:26:39 +0100 > schrieb Paolo Bonzini : > >> My understanding is that Xen is able to use "-M >> pc-i440fx-VERSION,accel=xen". The presence of the version in the >> machine type guarantees that the migration stream is compatible and that

Re: Bug? qemu-img convert to preallocated image makes it sparse

2020-01-17 Thread David Edmondson
On Thursday, 2020-01-16 at 15:37:22 +01, Max Reitz wrote: > So I suppose the best idea I can come up with is indeed a > --target-is-zero flag for qemu-img convert -n. Would that work for you? I was looking at adding this for a slightly different reason (converting sparse images to newly provisio

Re: [PATCH v22 5/9] ACPI: Record the Generic Error Status Block address

2020-01-17 Thread gengdongjiu
On 2020/1/17 0:44, Peter Maydell wrote: >> .minimum_version_id = 1, >> .fields = (VMStateField[]) { >> -VMSTATE_STRUCT(ged_state, AcpiGedState, 1, vmstate_ged_state, >> GEDState), >> +VMSTATE_STRUCT(ged_state, AcpiGedState, 1, >> + vmstate_ged_state,

Re: [PATCH] target/s390x/kvm: Enable adapter interruption suppression again

2020-01-17 Thread Thomas Huth
On 16/01/2020 21.26, Cornelia Huck wrote: > On Thu, 16 Jan 2020 15:19:13 -0500 > Matthew Rosato wrote: > >> On 1/16/20 7:20 AM, Thomas Huth wrote: >>> The AIS feature has been disabled late in the v2.10 development >>> cycle since there were some issues with migration (see commit >>> 3f2d07b3b01e

[PATCH] qemu-img: Add --target-is-zero to convert

2020-01-17 Thread David Edmondson
In many cases the target of a convert operation is a newly provisioned target that the user knows is blank (filled with zeroes). In this situation there is no requirement for qemu-img to wastefully zero out the entire device. Add a new option, --target-is-zero, allowing the user to indicate that a

Re: [PATCH v3 1/4] qapi: Add a 'coroutine' flag for commands

2020-01-17 Thread Markus Armbruster
Kevin Wolf writes: > Am 17.01.2020 um 08:57 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Am 16.01.2020 um 14:00 hat Markus Armbruster geschrieben: >> >> Kevin Wolf writes: >> >> > I have no idea if we will eventually get a case where the command wants >> >> > to behave diff

Re: [PATCH v2 66/86] ppc/{ppc440_bamboo,sam460x}: drop RAM size fixup

2020-01-17 Thread Igor Mammedov
On Wed, 15 Jan 2020 22:33:46 +0100 (CET) BALATON Zoltan wrote: > Subject line is still wrong, it's sam460ex not sam460x. Also you change > ppc:whatever to ppc/whatever here but left : as path separator in all > other patches. This is not consistent with other commits where the tag in > the tit

Re: [PATCH v3 4/4] block: Mark 'block_resize' as coroutine

2020-01-17 Thread Markus Armbruster
Kevin Wolf writes: > Am 17.01.2020 um 06:44 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Am 16.01.2020 um 16:13 hat Markus Armbruster geschrieben: >> >> Kevin Wolf writes: >> >> >> >> > Am 16.01.2020 um 10:45 hat Markus Armbruster geschrieben: [...] >> >> >> Pardon my igno

Re: [PATCH v22 5/9] ACPI: Record the Generic Error Status Block address

2020-01-17 Thread gengdongjiu
On 2020/1/17 15:39, Philippe Mathieu-Daudé wrote: >>     table_offsets = g_array_new(false, true /* clear */, >>   sizeof(uint32_t)); >> @@ -831,7 +832,9 @@ void virt_acpi_build(VirtMachineState *vms, >> AcpiBuildTables *tables) >>   acpi_add_tabl

Re: [PATCH] qapi: Fix code generation with Python 3.5

2020-01-17 Thread Markus Armbruster
Thomas Huth writes: > On 16/01/2020 21.25, Markus Armbruster wrote: >> Recent commit 3e7fb5811b "qapi: Fix code generation for empty modules" >> modules" switched QAPISchema.visit() from >> >> for entity in self._entity_list: >> >> effectively to >> >> for mod in self._module_dict.valu

[Bug 1859989] Re: qemu-img has broken output with large snapshot names

2020-01-17 Thread pevogam
Hi Max, It last worked in (previous version we used): [root@c15 ~]# qemu-img --version qemu-img version 3.1.1 (qemu-3.1.1-2.fc30) Copyright (c) 2003-2018 Fabrice Bellard and the QEMU Project developers Yes, unfortunately Launchpad doesn't seem to support any literal formatting which is why I trie

[PATCH 1/2] block: Fix VM size field width in snapshot dump

2020-01-17 Thread Max Reitz
When printing the snapshot list (e.g. with qemu-img snapshot -l), the VM size field is only seven characters wide. As of de38b5005e9, this is not necessarily sufficient: We generally print three digits, and this may require a decimal point. Also, the unit field grew from something as plain as "M"

[PATCH 0/2] block: Fix VM size field width in snapshot dump

2020-01-17 Thread Max Reitz
Hi, https://bugs.launchpad.net/qemu/+bug/1859989 reports that fields in "qemu-img snapshot -l"s output are not always separated by spaces in 4.1.1. Fix that. Branch: https://github.com/XanClic/qemu.git lp-1859989-v1 Branch: https://git.xanclic.moe/XanClic/qemu.git lp-1859989-v1 Max Reitz (2):

[PATCH 2/2] iotests: Test snapshot -l field separation

2020-01-17 Thread Max Reitz
Add a test that all fields in "qemu-img snapshot -l"s output are separated by spaces. Signed-off-by: Max Reitz --- tests/qemu-iotests/284 | 76 ++ tests/qemu-iotests/284.out | 8 tests/qemu-iotests/group | 1 + 3 files changed, 85 insertions(+) c

Re: [PATCH v2 4/4] qcow2: Use BDRV_SECTOR_SIZE instead of the hardcoded value

2020-01-17 Thread Max Reitz
On 17.01.20 10:55, Kevin Wolf wrote: > Am 17.01.2020 um 10:12 hat Max Reitz geschrieben: >> On 17.01.20 00:26, Alberto Garcia wrote: >>> On Tue 14 Jan 2020 03:15:48 PM CET, Max Reitz wrote: > @@ -219,7 +219,7 @@ static int l2_load(BlockDriverState *bs, uint64_t > offset, > * Writes o

Re: [PATCH] target/s390x/kvm: Enable adapter interruption suppression again

2020-01-17 Thread Christian Borntraeger
On 17.01.20 11:38, Thomas Huth wrote: > On 16/01/2020 21.26, Cornelia Huck wrote: >> On Thu, 16 Jan 2020 15:19:13 -0500 >> Matthew Rosato wrote: >> >>> On 1/16/20 7:20 AM, Thomas Huth wrote: The AIS feature has been disabled late in the v2.10 development cycle since there were some is

Re: [PATCH v2] hw/arm: Adjust some coding styles about memory hotplug

2020-01-17 Thread Peter Maydell
On Fri, 17 Jan 2020 at 06:41, Keqian Zhu wrote: > > From: zhukeqian > > There is extra indent in ACPI GED plug cb. And we can use > existing helper function to trigger hotplug handler plug. > > Reviewed-by: Igor Mammedov > Signed-off-by: Keqian Zhu > --- > > v1->v2: > - Add Igor's R-b > > Cc:

[PULL 0/4] qtests and gitlab-CI

2020-01-17 Thread Thomas Huth
Hi Peter, the following changes since commit fee0ec1fd11a6fb960517e18201ed8a686a0d7e8: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2020-01-14 14:11:34 +) are available in the Git repository at: https://gitlab.com/huth/qemu.git tags/pull-reques

[PULL 3/4] tests/qtest/vhost-user-test: Fix memory leaks

2020-01-17 Thread Thomas Huth
Do not allocate resources in case we return early, and make sure to free dest_cmdline at the end. Reported-by: Euler Robot Reported-by: Pan Nengyuan Message-Id: <20200116140736.9498-1-th...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- tests/qtest/vhost-user-t

[PULL 2/4] migration-test: ppc64: fix FORTH test program

2020-01-17 Thread Thomas Huth
From: Laurent Vivier Commit e51e711b1bef has moved the initialization of start_address and end_address after the definition of the command line argument, where the nvramrc is initialized, and thus the loop is between 0 and 0 rather than 1 MiB and 100 MiB. It doesn't affect the result of the test

[PULL 1/4] tests: acpi: update path in rebuild-expected-aml

2020-01-17 Thread Thomas Huth
From: Shameer Kolothum Since commit 1e8a1fae7464("test: Move qtests to a separate directory") qtests are now placed in a separate folder and this breaks the script used to rebuild the expected ACPI tables for bios-tables-test. Update the script with correct path. Fixes: 1e8a1fae7464("test: Move

Re: [PATCH v3 1/4] qapi: Add a 'coroutine' flag for commands

2020-01-17 Thread Kevin Wolf
Am 17.01.2020 um 11:43 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 17.01.2020 um 08:57 hat Markus Armbruster geschrieben: > >> Kevin Wolf writes: > >> > >> > Am 16.01.2020 um 14:00 hat Markus Armbruster geschrieben: > >> >> Kevin Wolf writes: > >> >> > I have no idea if we

[PULL 4/4] gitlab-ci.yml: Run tcg test with tci

2020-01-17 Thread Thomas Huth
Since commit 2f160e0f9797c7522bfd0d09218d0c9340a5137c ("tci: Add implementation for INDEX_op_ld16u_i64") has been included now, we can also run the TCG tests with tci, so let's enable them in our Gitlab CI now. Message-Id: <20191127155105.3784-1-th...@redhat.com> Signed-off-by: Thomas Huth --- .

[PATCH v2] s390x: adapter routes error handling

2020-01-17 Thread Cornelia Huck
If the kernel irqchip has been disabled, we don't want the {add,release}_adapter_routes routines to call any kvm_irqchip_* interfaces, as they may rely on an irqchip actually having been created. Just take a quick exit in that case instead. Also initialize routes->gsi[] with -1 in the virtio-ccw h

Re: [PATCH v22 9/9] MAINTAINERS: Add ACPI/HEST/GHES entries

2020-01-17 Thread Peter Maydell
On Fri, 17 Jan 2020 at 07:22, Philippe Mathieu-Daudé wrote: > > Hi Peter, > > On 1/16/20 5:46 PM, Peter Maydell wrote: > > On Wed, 8 Jan 2020 at 11:32, Dongjiu Geng wrote: > >> > >> I and Xiang are willing to review the APEI-related patches and > >> volunteer as the reviewers for the HEST/GHES pa

Re: [PATCH v2 83/86] tests:numa-test: make top level args dynamic and g_autofree(cli) cleanups

2020-01-17 Thread Thomas Huth
On 16/01/2020 18.06, Igor Mammedov wrote: > On Thu, 16 Jan 2020 17:35:32 +0100 > Thomas Huth wrote: > >> On 15/01/2020 16.07, Igor Mammedov wrote: >>> Use GString to pass argument to make_cli() so that it would be easy >>> to dynamically change test case arguments from main(). The follow up >>> p

Re: [PATCH v2] s390x: adapter routes error handling

2020-01-17 Thread Thomas Huth
On 17/01/2020 12.11, Cornelia Huck wrote: > If the kernel irqchip has been disabled, we don't want the > {add,release}_adapter_routes routines to call any kvm_irqchip_* > interfaces, as they may rely on an irqchip actually having been > created. Just take a quick exit in that case instead. > > Als

Re: [PATCH v22 5/9] ACPI: Record the Generic Error Status Block address

2020-01-17 Thread Philippe Mathieu-Daudé
On 1/17/20 11:47 AM, gengdongjiu wrote: On 2020/1/17 15:39, Philippe Mathieu-Daudé wrote:     table_offsets = g_array_new(false, true /* clear */,   sizeof(uint32_t)); @@ -831,7 +832,9 @@ void virt_acpi_build(VirtMachineState *vms, AcpiBuildTables *

[Bug 1859989] Re: qemu-img has broken output with large snapshot names

2020-01-17 Thread Max Reitz
Sent a patch: https://lists.nongnu.org/archive/html/qemu- block/2020-01/msg00376.html -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1859989 Title: qemu-img has broken output with large snapshot nam

Re: [PATCH v22 9/9] MAINTAINERS: Add ACPI/HEST/GHES entries

2020-01-17 Thread Philippe Mathieu-Daudé
On 1/17/20 12:09 PM, Peter Maydell wrote: On Fri, 17 Jan 2020 at 07:22, Philippe Mathieu-Daudé wrote: Hi Peter, On 1/16/20 5:46 PM, Peter Maydell wrote: On Wed, 8 Jan 2020 at 11:32, Dongjiu Geng wrote: I and Xiang are willing to review the APEI-related patches and volunteer as the reviewe

Re: [PATCH v2] s390x: adapter routes error handling

2020-01-17 Thread Christian Borntraeger
On 17.01.20 12:11, Cornelia Huck wrote: > If the kernel irqchip has been disabled, we don't want the > {add,release}_adapter_routes routines to call any kvm_irqchip_* > interfaces, as they may rely on an irqchip actually having been > created. Just take a quick exit in that case instead. > > Al

Re: [PATCH 000/104] virtiofs daemon [all]

2020-01-17 Thread Dr. David Alan Gilbert
Hi, Here's a summary of the review status of this set, Total: 109 Reviewed: 81 New: 5 changed/rr: 8 The first column is: 'blank' - no change 'D' - some diff from the original patch - from a simple diff script 'N' - a new patch The second column is: 'R' - has a Reviewed-by

Re: [PATCH v2] s390x: adapter routes error handling

2020-01-17 Thread Cornelia Huck
On Fri, 17 Jan 2020 12:22:45 +0100 Christian Borntraeger wrote: > On 17.01.20 12:11, Cornelia Huck wrote: > > If the kernel irqchip has been disabled, we don't want the > > {add,release}_adapter_routes routines to call any kvm_irqchip_* > > interfaces, as they may rely on an irqchip actually havi

Re: [PATCH v2] s390x: adapter routes error handling

2020-01-17 Thread Christian Borntraeger
On 17.01.20 12:33, Cornelia Huck wrote: > On Fri, 17 Jan 2020 12:22:45 +0100 > Christian Borntraeger wrote: > >> On 17.01.20 12:11, Cornelia Huck wrote: >>> If the kernel irqchip has been disabled, we don't want the >>> {add,release}_adapter_routes routines to call any kvm_irqchip_* >>> interf

Re: [PATCH 072/104] virtiofsd: passthrough_ll: fix refcounting on remove/rename

2020-01-17 Thread Dr. David Alan Gilbert
* Miklos Szeredi (mszer...@redhat.com) wrote: > On Thu, Jan 16, 2020 at 5:45 PM Dr. David Alan Gilbert > wrote: > > > > * Misono Tomohiro (misono.tomoh...@jp.fujitsu.com) wrote: > > > > From: Miklos Szeredi > > > > > > > > Signed-off-by: Miklos Szeredi > > > > > > I'm not familiar with qemu conv

Re: [PATCH 0/4] target/arm: Fix ComputePAC (LP 1859713)

2020-01-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200116230809.19078-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200116230809.19078-1-richard.hender...@linaro.org Type: series Subject: [PATCH 0/4] target/

Re: [PATCH] spapr: Migrate CAS reboot flag

2020-01-17 Thread Greg Kurz
On Wed, 15 Jan 2020 19:26:18 +0100 Laurent Vivier wrote: > On 15/01/2020 19:10, Laurent Vivier wrote: > > Hi, > > > > On 15/01/2020 18:48, Greg Kurz wrote: > >> Migration can potentially race with CAS reboot. If the migration thread > >> completes migration after CAS has set spapr->cas_reboot bu

Re: [PATCH v1 1/2] target/arm: detect 64 bit overflow caused by high cval + voff

2020-01-17 Thread Peter Maydell
On Thu, 16 Jan 2020 at 18:45, Peter Maydell wrote: > There's something odd going on with this code. Adding a bit of context: > > uint64_t offset = timeridx == GTIMER_VIRT ? > cpu->env.cp15.cntvoff_el2 : 0; > uint64_t count = gt_get_countervalue

Re: [PATCH v2 4/4] qcow2: Use BDRV_SECTOR_SIZE instead of the hardcoded value

2020-01-17 Thread Kevin Wolf
Am 17.01.2020 um 12:01 hat Max Reitz geschrieben: > On 17.01.20 10:55, Kevin Wolf wrote: > > Am 17.01.2020 um 10:12 hat Max Reitz geschrieben: > >> On 17.01.20 00:26, Alberto Garcia wrote: > >>> On Tue 14 Jan 2020 03:15:48 PM CET, Max Reitz wrote: > > @@ -219,7 +219,7 @@ static int l2_load(Bloc

Re: [PATCH v2 0/4] vl: Fixes for cleanups to -accel

2020-01-17 Thread Paolo Bonzini
On 16/01/20 22:05, Richard Henderson wrote: > Running qemu-system-foo with no options should not generate > a warning for "invalid accelerator bar". > > Changes in v2: > * Rebase on master, getting the free accel_list fix from upstream. > Re-word the resulting patch 2 to merely reduce the sc

Re: [PATCH v3 02/11] 9pfs: require msize >= 4096

2020-01-17 Thread Christian Schoenebeck
On Freitag, 17. Januar 2020 11:24:21 CET Greg Kurz wrote: > On Thu, 16 Jan 2020 22:39:19 +0100 > > Christian Schoenebeck wrote: > > On Donnerstag, 16. Januar 2020 19:07:48 CET Greg Kurz wrote: > > > > The point here was that there must be some kind of absolute minimum > > > > msize, > > > > > >

Re: [PULL 00/30] Migration pull patches (take 4)

2020-01-17 Thread Peter Maydell
On Tue, 14 Jan 2020 at 12:53, Juan Quintela wrote: > > The following changes since commit 3c8a6575985b1652b45bfa670b5e1907d642cfa0: > > Merge remote-tracking branch > 'remotes/kraxel/tags/usb-20200113-pull-request' into staging (2020-01-13 > 14:19:57 +) > > are available in the Git reposit

Re: [PATCH v2 0/2] target/arm: Fix ISSIs16Bit

2020-01-17 Thread Peter Maydell
On Fri, 17 Jan 2020 at 00:46, Richard Henderson wrote: > > Changes in v2: > - Include the merge_syn_data_abort fix, as a self-contained patch. > > > r~ > Applied to target-arm.next, thanks. (I didn't cc stable since it turns out this has been a bug since forever rather than a new regression in

Re: [Qemu-devel] [PATCH v3] RISC-V: Select FPU gdb xml file based on the supported extensions

2020-01-17 Thread Alistair Francis
On Tue, Jan 7, 2020 at 10:21 PM Alex Bennée wrote: > > > Georg Kotheimer writes: > > > The size of the FPU registers depends solely on the floating point > > extensions supported by the target architecture. > > However, in the previous implementation the floating point register > > size was deriv

Re: [PATCH] spapr: Migrate CAS reboot flag

2020-01-17 Thread Laurent Vivier
On 17/01/2020 12:49, Greg Kurz wrote: > On Wed, 15 Jan 2020 19:26:18 +0100 > Laurent Vivier wrote: > >> On 15/01/2020 19:10, Laurent Vivier wrote: >>> Hi, >>> >>> On 15/01/2020 18:48, Greg Kurz wrote: Migration can potentially race with CAS reboot. If the migration thread completes migr

Re: [PULL 0/5] 9p patches 2020-01-14

2020-01-17 Thread Peter Maydell
On Tue, 14 Jan 2020 at 16:02, Greg Kurz wrote: > > The following changes since commit 3c8a6575985b1652b45bfa670b5e1907d642cfa0: > > Merge remote-tracking branch > 'remotes/kraxel/tags/usb-20200113-pull-request' into staging (2020-01-13 > 14:19:57 +) > > are available in the Git repository

Re: qemu-4.0.1: vhost_region_add_section:Section rounded to 0 prior to previous a0000

2020-01-17 Thread Peter Lieven
Am 16.01.20 um 21:26 schrieb Dr. David Alan Gilbert: > * Peter Lieven (p...@kamp.de) wrote: >> Am 16.01.20 um 13:47 schrieb Peter Lieven: >>> Am 13.01.20 um 17:25 schrieb Peter Lieven: Am 09.01.20 um 19:44 schrieb Dr. David Alan Gilbert: > * Peter Lieven (p...@kamp.de) wrote: >> Am 08.

Re: [PATCH v22 9/9] MAINTAINERS: Add ACPI/HEST/GHES entries

2020-01-17 Thread Michael S. Tsirkin
On Fri, Jan 17, 2020 at 11:09:07AM +, Peter Maydell wrote: > On Fri, 17 Jan 2020 at 07:22, Philippe Mathieu-Daudé > wrote: > > > > Hi Peter, > > > > On 1/16/20 5:46 PM, Peter Maydell wrote: > > > On Wed, 8 Jan 2020 at 11:32, Dongjiu Geng wrote: > > >> > > >> I and Xiang are willing to review

Re: [PATCH v3 3/4] qmp: Move dispatcher to a coroutine

2020-01-17 Thread Markus Armbruster
Kevin Wolf writes: > This moves the QMP dispatcher to a coroutine and runs all QMP command > handlers that declare 'coroutine': true in coroutine context so they > can avoid blocking the main loop while doing I/O or waiting for other > events. > > For commands that are not declared safe to run in

Re: [PULL 00/30] Migration pull patches (take 4)

2020-01-17 Thread Juan Quintela
Peter Maydell wrote: > On Tue, 14 Jan 2020 at 12:53, Juan Quintela wrote: >> >> The following changes since commit 3c8a6575985b1652b45bfa670b5e1907d642cfa0: >> >> Merge remote-tracking branch >> 'remotes/kraxel/tags/usb-20200113-pull-request' into staging >> (2020-01-13 14:19:57 +) >> >> ar

Re: [PATCH 1/2] target/ppc: Add privileged message send facilities

2020-01-17 Thread David Gibson
On Thu, Jan 09, 2020 at 05:33:45PM +0100, Cédric Le Goater wrote: > The Processor Control facility POWER8 processors and later provides > a mechanism for the hypervisor to send messages to other threads > in the system (msgsnd instruction) and cause hypervisor-level > exceptions. Privileged non-hyp

Re: [PATCH v6 2/3] kvm-all: Introduce kvm_set_singlestep

2020-01-17 Thread David Gibson
On Fri, Jan 10, 2020 at 12:13:43PM -0300, Fabiano Rosas wrote: > For single stepping (via KVM) of a guest vcpu to work, KVM needs not > only to support the SET_GUEST_DEBUG ioctl but to also recognize the > KVM_GUESTDBG_SINGLESTEP bit in the control field of the > kvm_guest_debug struct. > > This p

[PATCH] tests/vhost-user-bridge: Fix build

2020-01-17 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" vhost-user-bridge isn't actually a test, it's just a helper (that should probably move somewhere else) - but the build was broken in the qtest move. Fixes: 833884f37adc9f125fa2 Signed-off-by: Dr. David Alan Gilbert --- tests/Makefile.include | 1 + tests/qt

Re: [PATCH v6 1/3] target/ppc: Clarify the meaning of return values in kvm_handle_debug

2020-01-17 Thread David Gibson
On Fri, Jan 10, 2020 at 12:13:42PM -0300, Fabiano Rosas wrote: > The kvm_handle_debug function can return 0 to go back into the guest > or return 1 to notify the gdbstub thread and pass control to GDB. > > Signed-off-by: Fabiano Rosas Good change regardless of the rest of the series. Applied to

Re: [PATCH 2/2] target/ppc: add support for Hypervisor Facility Unavailable Exception

2020-01-17 Thread David Gibson
On Thu, Jan 09, 2020 at 05:33:46PM +0100, Cédric Le Goater wrote: > The privileged message send and clear instructions (msgsndp & msgclrp) > are privileged, but will generate a hypervisor facility unavailable > exception if not enabled in the HFSCR and executed in privileged > non-hypervisor state.

Re: [PATCH] tests/vhost-user-bridge: Fix build

2020-01-17 Thread Thomas Huth
On 17/01/2020 13.26, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > vhost-user-bridge isn't actually a test, it's just a helper > (that should probably move somewhere else) - but the build was > broken in the qtest move. > > Fixes: 833884f37adc9f125fa2 > Signed-off-by:

Re: [PATCH] spapr: Migrate CAS reboot flag

2020-01-17 Thread David Gibson
On Thu, Jan 16, 2020 at 07:29:02PM +0100, Greg Kurz wrote: > On Thu, 16 Jan 2020 13:14:35 +0100 > Greg Kurz wrote: > > > On Thu, 16 Jan 2020 11:37:24 +0100 > > Laurent Vivier wrote: > > > > > On 16/01/2020 09:48, Greg Kurz wrote: > > > > On Wed, 15 Jan 2020 19:10:37 +0100 > > > > Laurent Vivier

Re: [PATCH v6 2/3] kvm-all: Introduce kvm_set_singlestep

2020-01-17 Thread David Gibson
On Fri, Jan 17, 2020 at 07:27:48PM +1000, David Gibson wrote: > On Fri, Jan 10, 2020 at 12:13:43PM -0300, Fabiano Rosas wrote: > > For single stepping (via KVM) of a guest vcpu to work, KVM needs not > > only to support the SET_GUEST_DEBUG ioctl but to also recognize the > > KVM_GUESTDBG_SINGLESTEP

Re: [PATCH v2 0/3] exclude hyperv synic sections from vhost

2020-01-17 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > On 13/01/20 18:36, Dr. David Alan Gilbert (git) wrote: > > > > Hyperv's synic (that we emulate) is a feature that allows the guest > > to place some magic (4k) pages of RAM anywhere it likes in GPA. > > This confuses vhost's RAM section merging when t

Re: [PULL 00/30] Migration pull patches (take 4)

2020-01-17 Thread Juan Quintela
Juan Quintela wrote: > Peter Maydell wrote: >> On Tue, 14 Jan 2020 at 12:53, Juan Quintela wrote: >> >> I think you need to find a system which has 32-bit ram_addr_t >> and test this, because this is about the fourth time round >> for this patchset failing on this configuration. > > That is arm3

Re: [PATCH 1/2] target/ppc: Add privileged message send facilities

2020-01-17 Thread Cédric Le Goater
On 1/17/20 10:46 AM, David Gibson wrote: > On Thu, Jan 09, 2020 at 05:33:45PM +0100, Cédric Le Goater wrote: >> The Processor Control facility POWER8 processors and later provides >> a mechanism for the hypervisor to send messages to other threads >> in the system (msgsnd instruction) and cause hyp

  1   2   3   >