Re: [PATCH] vl: Don't mismatch g_strsplit()/g_free()

Le 10/01/2020 à 04:16, pannengy...@huawei.com a écrit : > From: Pan Nengyuan > > It's a mismatch between g_strsplit and g_free, it will cause a memory leak as > follow: > > [root@localhost]# ./aarch64-softmmu/qemu-system-aarch64 -accel help > Accelerators supported in QEMU binary: > tcg > kvm >

Re: [PATCH] vl: Don't mismatch g_strsplit()/g_free()

On 1/10/2020 3:59 PM, Laurent Vivier wrote: > Le 10/01/2020 à 04:16, pannengy...@huawei.com a écrit : >> From: Pan Nengyuan >> >> It's a mismatch between g_strsplit and g_free, it will cause a memory leak >> as follow: >> >> [root@localhost]# ./aarch64-softmmu/qemu-system-aarch64 -accel help >

[PATCH 1/3] select gdb fpu xml by single or double float extension

There is no reason why RISCV32 can't use RVD extension, or RISCV64 can't just use RVF extension. And gdb will check flen according to RVD or RVF feature in elf header. Signed-off-by: LIU Zhiwei --- configure | 4 ++-- target/riscv/gdbstub.c | 14 ++ 2 files changed, 8 i

[PATCH 2/3] RISC-V: use FIELD macro to define tb flags

FIELD is more unified to define tb flags. It is easier to add new filed to tb flags. Signed-off-by: LIU Zhiwei --- target/riscv/cpu.h | 15 +-- target/riscv/translate.c | 5 +++-- 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/target/riscv/cpu.h b/target/riscv

[PATCH 3/3] remove redundant check for fpu csr read and write interface

The read or write interface must be called after the predicate fs return 0. And the predicate will check (!env->debugger && !riscv_cpu_fp_enabled(env)), S0 no need to check again. Signed-off-by: LIU Zhiwei --- target/riscv/csr.c | 24 1 file changed, 24 deletions(-) dif

Re: [PATCH 4/4] Makefile: Remove unhelpful comment

On 09/01/2020 16.39, Philippe Mathieu-Daudé wrote: > It is pointless to keep qapi/ object separate from the other > common-objects. Drop the comment. > > Signed-off-by: Philippe Mathieu-Daudé > --- > Makefile.objs | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/Ma

Re: [PATCH 2/4] Makefile: Clarify all the codebase requires qom/ objects

On 09/01/2020 16.39, Philippe Mathieu-Daudé wrote: > QEMU user-mode also requires the qom/ objects, it is not only > used by "system emulation and qemu-img". As we will use a big > if() block, move it upper in the "Common libraries for tools > and emulators" section. > > Signed-off-by: Philippe Ma

Re: [PATCH 3/4] Makefile: Restrict system emulation and tools objects

On 09/01/2020 16.39, Philippe Mathieu-Daudé wrote: > Restrict all the system emulation and tools objects with a > Makefile IF (CONFIG_SOFTMMU OR CONFIG_TOOLS) check. > > Using the same description over and over is not very helpful. > Use it once, just before the if() block. > > Signed-off-by: Phi

Re: [PATCH 3/4] Makefile: Restrict system emulation and tools objects

Le ven. 10 janv. 2020 09:18, Thomas Huth a écrit : > On 09/01/2020 16.39, Philippe Mathieu-Daudé wrote: > > Restrict all the system emulation and tools objects with a > > Makefile IF (CONFIG_SOFTMMU OR CONFIG_TOOLS) check. > > > > Using the same description over and over is not very helpful. > >

Re: [PATCH 3/4] Makefile: Restrict system emulation and tools objects

On 10/01/2020 09.25, Philippe Mathieu-Daudé wrote: > Le ven. 10 janv. 2020 09:18, Thomas Huth > a écrit : > > On 09/01/2020 16.39, Philippe Mathieu-Daudé wrote: > > Restrict all the system emulation and tools objects with a > > Makefile IF (CONFIG_SOFTMMU OR C

Re: [PATCH 0/4] buildsys: Build quicker (mostly tools and linux-user)

Le 09/01/2020 à 16:39, Philippe Mathieu-Daudé a écrit : > In some configuration (linux-user, tools) we can ignore building > various objects (and the libfdt). > > Philippe Mathieu-Daudé (4): > configure: Do not build libfdt is not required > Makefile: Clarify all the codebase requires qom/ obj

[Bug 1841491] Re: floating point emulation can fail to set FE_UNDERFLOW

Ok, thanks for the pointer to the other bug! So I'm closing this one now. ** Changed in: qemu Status: Confirmed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1841491 Title:

Re: [PATCH] virtio: Prevent double swap due to target pre 1.0 VirtIO

On Thu, 9 Jan 2020 18:18:57 -0300 André Silva wrote: > Hi Greg, > Hi André, > Thanks for the commit info. > But I'm testing in this scenario, that is, a ppc64le host with a ppc64 > BE guest, and without my patch I can't get virtio to work. The patch What are the symptoms without your patch ?

Re: [PATCH 0/4] buildsys: Build quicker (mostly tools and linux-user)

Le ven. 10 janv. 2020 09:36, Laurent Vivier a écrit : > Le 09/01/2020 à 16:39, Philippe Mathieu-Daudé a écrit : > > In some configuration (linux-user, tools) we can ignore building > > various objects (and the libfdt). > > > > Philippe Mathieu-Daudé (4): > > configure: Do not build libfdt is no

[PATCH v2 2/2] qga/main: Don't mismatch g_strsplit/g_free in split_list()

From: Pan Nengyuan fix a mismatch between g_strsplit and g_free Reported-by: Laurent Vivier Signed-off-by: Pan Nengyuan --- Changes v2 to v1: - fix a mismatch in qga/main.c --- qga/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/main.c b/qga/main.c index c35c2a2

[PATCH v2 0/2] fix mismatches between g_strsplit and g_free

From: Pan Nengyuan v1: fix a mismatch in vl.c v2: fix mismatch in vl.c and qga/main.c Pan Nengyuan (2): vl: Don't mismatch g_strsplit()/g_free() qga/main: Don't mismatch g_strsplit/g_free in split_list() qga/main.c | 2 +- vl.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)

[PATCH] migration/multifd: fix nullptr access in multifd_send_terminate_threads

If the multifd_send_threads is not created when migration is failed, multifd_save_cleanup would be called twice. In this senario, the multifd_send_state is accessed after it has been released, the result is that the source VM is crashing down. Here is the coredump stack: Program received signa

[PATCH v2 1/2] vl: Don't mismatch g_strsplit()/g_free()

From: Pan Nengyuan It's a mismatch between g_strsplit and g_free, it will cause a memory leak as follow: [root@localhost]# ./aarch64-softmmu/qemu-system-aarch64 -accel help Accelerators supported in QEMU binary: tcg kvm = ==1207900

[PATCH] target/riscv: Set mstatus.DS & FS correctly

It was found that running libquantum on riscv-linux qemu produced an incorrect result. After investigation, FP registers are not saved during context switch due to incorrect mstatus.FS. Because ctx->mstatus_fs changes dynamically during runtime, we should remove the mstatus_fs check at the transla

Re: [PATCH 092/104] virtiofsd: add man page

On Thu, Jan 09, 2020 at 08:02:13PM +, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > On Thu, Dec 12, 2019 at 04:38:52PM +, Dr. David Alan Gilbert (git) > > wrote: > > > From: Stefan Hajnoczi > > > > > > Signed-off-by: Stefan Hajnoczi > > > --- > >

Re: [PATCH 04/15] hw/ppc/spapr_rtas: Restrict variables scope to single switch case

On 1/9/20 6:43 PM, Greg Kurz wrote: On Thu, 9 Jan 2020 16:21:22 +0100 Philippe Mathieu-Daudé wrote: We only access these variables in RTAS_SYSPARM_SPLPAR_CHARACTERISTICS case, restrict their scope to avoid unnecessary initialization. I guess a decent compiler can be smart enough detect tha

Re: [PATCH] crypto: fix getter of a QCryptoSecret's property

On Thu, Jan 09, 2020 at 12:09:58PM -0800, Tong Ho wrote: > This fixes the condition-check done by the "loaded" property > getter, such that the property returns true even when the > secret is loaded by the 'file' option. > > Signed-off-by: Tong Ho > --- > Pre-existing getter returns true only wh

Re: [PATCH v2 0/2] fix mismatches between g_strsplit and g_free

Patchew URL: https://patchew.org/QEMU/20200110091710.53424-1-pannengy...@huawei.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

[Bug 1657841] Re: QEMU Intel HAX Windows

Which version were you exactly using? Can you still reproduce the problem with the latest version of QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.ne

Re: [PATCH v2 2/2] qga/main: Don't mismatch g_strsplit/g_free in split_list()

Hi On Fri, Jan 10, 2020 at 1:18 PM wrote: > > From: Pan Nengyuan > > fix a mismatch between g_strsplit and g_free > > Reported-by: Laurent Vivier > Signed-off-by: Pan Nengyuan NACK, the elements are added to the returned list. > --- > Changes v2 to v1: > - fix a mismatch in qga/main.c > ---

Re: Does ppc target support for MTTCG are stable?

罗勇刚(Yonggang Luo) writes: > I enabled it and working, but I don't know if there any other issue are > still not resolved.. Support for MTTCG for ppc64 guests has been enabled for a while. While there is a lot of shared infrastructure in target/ppc between the 32 and 64 bit implementations I'm

Re: [PATCH v2 2/2] qga/main: Don't mismatch g_strsplit/g_free in split_list()

Le 10/01/2020 à 10:41, Marc-André Lureau a écrit : > Hi > > On Fri, Jan 10, 2020 at 1:18 PM wrote: >> >> From: Pan Nengyuan >> >> fix a mismatch between g_strsplit and g_free >> >> Reported-by: Laurent Vivier >> Signed-off-by: Pan Nengyuan > > NACK, the elements are added to the returned list

[Bug 1832281] Re: tcg bug master / 4.0.0 v8 operation >>> and |=

Patch had been included here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=1e8a98b53867f61da9c ** Changed in: qemu Status: In Progress => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.n

[Bug 1653577] Re: Ability to set umask for 9pfs

** Changed in: qemu Importance: Undecided => Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1653577 Title: Ability to set umask for 9pfs Status in QEMU: New Bug description: We sho

[Bug 1657010] Re: RFE: Please implement -cpu best or a CPU fallback option

As far as I can see, we have "-cpu max" now for x86, arm, ppc and s390x ... is that enough, so that we can close this bug now? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https

[Bug 1656927] Re: Network (TCP) access regression

Looking through old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribe

Re: [PATCH 066/104] virtiofsd: passthrough_ll: add renameat2 support

* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Thu, Dec 12, 2019 at 04:38:26PM +, Dr. David Alan Gilbert (git) wrote: > > From: Miklos Szeredi > > > > No glibc support yet, so use syscall(). > > It exists in glibc in my Fedora 31 install. > > Presumably this is related to an older v

Re: [PATCH 04/15] hw/ppc/spapr_rtas: Restrict variables scope to single switch case

On Fri, 10 Jan 2020 10:34:07 +0100 Philippe Mathieu-Daudé wrote: > On 1/9/20 6:43 PM, Greg Kurz wrote: > > On Thu, 9 Jan 2020 16:21:22 +0100 > > Philippe Mathieu-Daudé wrote: > > > >> We only access these variables in RTAS_SYSPARM_SPLPAR_CHARACTERISTICS > >> case, restrict their scope to avoid

Re: [PATCH] vl: Don't mismatch g_strsplit()/g_free()

Le 10/01/2020 à 04:16, pannengy...@huawei.com a écrit : > From: Pan Nengyuan > > It's a mismatch between g_strsplit and g_free, it will cause a memory leak as > follow: > > [root@localhost]# ./aarch64-softmmu/qemu-system-aarch64 -accel help > Accelerators supported in QEMU binary: > tcg > kvm >

Re: [PATCH v3 00/15] io_uring: add Linux io_uring AIO engine

On Wed, Dec 18, 2019 at 04:32:13PM +, Stefan Hajnoczi wrote: > v12: > * Reword BlockdevAioOptions QAPI schema commit description [Markus] > * Increase QAPI "Since: 4.2" to "Since: 5.0" > * Explain rationale for io_uring stubs in commit description [Kevin] > * Tried to use file.aio=io_uring

Re: [PATCH 01/15] target/arm/kvm: Use CPUState::kvm_state in kvm_arm_pmu_supported()

On Thu, Jan 9, 2020 at 11:22 PM Philippe Mathieu-Daudé wrote: > > KVMState is already accessible via CPUState::kvm_state, use it. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > target/arm/kvm.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(

Re: [PATCH 1/4] configure: Do not build libfdt is not required

On Thu, Jan 9, 2020 at 11:40 PM Philippe Mathieu-Daudé wrote: > > We only require libfdt for system emulation, in a small set > of architecture: > > 4077 # fdt support is mandatory for at least some target architectures, > 4078 # so insist on it if we're building those system emulators. > 4079

[PATCH 0/2] implement crashloaded event for pvpanic

Guest may handle panic by itself, then just reboot without pvpanic notification. Then We can't separate the abnormal reboot from normal operation. Declear bit 1 for pvpanic as crashloaded event. It should work with guest kernel side. Link: https://lkml.org/lkml/2019/12/14/265 Before running kexec,

[PATCH 1/2] pvpanic: introduce crashloaded for pvpanic

Add bit 1 for pvpanic. This bit means that guest hits a panic, but guest wants to handle error by itself. Typical case: Linux guest runs kdump in panic. It will help us to separate the abnormal reboot from normal operation. Signed-off-by: zhenwei pi --- docs/specs/pvpanic.txt | 8 ++-- 1 fil

[PATCH 2/2] pvpanic: implement crashloaded event handling

Handle bit 1 write, then post event to monitor. Suggested by Paolo, declear a new event, using GUEST_PANICKED could cause upper layers to react by shutting down or rebooting the guest. In advance for extention, add GuestPanicInformation in event message. Signed-off-by: zhenwei pi --- hw/misc/p

[Bug 1657010] Re: RFE: Please implement -cpu best or a CPU fallback option

** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1657010 Title: RFE: Please implement -cpu best or a CPU fallback option Status in QEMU:

Re: [PATCH 2/5] hw/arm: ast2600: Wire up the eMMC controller

On 1/7/20 9:25 AM, Philippe Mathieu-Daudé wrote: > On 1/7/20 8:34 AM, Cédric Le Goater wrote: >> From: Andrew Jeffery >> >> Initialise another SDHCI model instance for the AST2600's eMMC >> controller and use the SDHCI's num_slots value introduced previously to >> determine whether we should creat

Re: [PATCH 4/5] hw/arm/aspeed: add a 'execute-in-place' property to boot directly from CE0

On 1/7/20 9:34 AM, Philippe Mathieu-Daudé wrote: > On 1/7/20 8:34 AM, Cédric Le Goater wrote: >> The overhead for the OpenBMC firmware images using the a custom U-Boot >> is around 2 seconds, which is fine, but with a U-Boot from mainline, >> it takes an extra 50 seconds or so to reach Linux. A qui

Re: Difference between 'current_machine' vs MACHINE(qdev_get_machine())

On 1/9/20 4:24 PM, Like Xu wrote: On 2020/1/9 20:01, Paolo Bonzini wrote: On 09/01/20 12:23, Philippe Mathieu-Daudé wrote: current_machine = MACHINE(object_new_with_class(OBJECT_CLASS(machine_class))); object_property_add_child(object_get_root(), "machine",  

Re: [PATCH 3/5] ftgmac100: check RX and TX buffer alignment

On 1/7/20 9:36 AM, Cédric Le Goater wrote: On 1/7/20 9:27 AM, Philippe Mathieu-Daudé wrote: On 1/7/20 8:34 AM, Cédric Le Goater wrote: These buffers should be aligned on 16 bytes. Signed-off-by: Cédric Le Goater ---   hw/net/ftgmac100.c | 13 +   1 file changed, 13 insertions(+)

[PATCH v2 0/5] aspeed: extensions and fixes

Hi, Here is a short series adding : - a new eMMC controller model for the AST2600 SoC (Andrew) - accessors to control the led state of the pca9552 device (Joel) - a 'execute-in-place' property to boot directly from CE0 Thanks, C. Changes since v1: - removed ternary operator from sdhci_at

[PATCH v2 2/5] hw/arm: ast2600: Wire up the eMMC controller

From: Andrew Jeffery Initialise another SDHCI model instance for the AST2600's eMMC controller and use the SDHCI's num_slots value introduced previously to determine whether we should create an SD card instance for the new slot. Signed-off-by: Andrew Jeffery Reviewed-by: Cédric Le Goater Revie

[PATCH v2 4/5] hw/arm/aspeed: add a 'execute-in-place' property to boot directly from CE0

The overhead for the OpenBMC firmware images using the a custom U-Boot is around 2 seconds, which is fine, but with a U-Boot from mainline, it takes an extra 50 seconds or so to reach Linux. A quick survey on the number of reads performed on the flash memory region gives the following figures :

[PATCH v2 1/5] hw/sd: Configure number of slots exposed by the ASPEED SDHCI model

From: Andrew Jeffery The AST2600 includes a second cut-down version of the SD/MMC controller found in the AST2500, named the eMMC controller. It's cut down in the sense that it only supports one slot rather than two, but it brings the total number of slots supported by the AST2600 to three. The

[PATCH v2 3/5] ftgmac100: check RX and TX buffer alignment

These buffers should be aligned on 16 bytes. Signed-off-by: Cédric Le Goater --- hw/net/ftgmac100.c | 13 + 1 file changed, 13 insertions(+) diff --git a/hw/net/ftgmac100.c b/hw/net/ftgmac100.c index 86ac25894a89..051f7b7af2d6 100644 --- a/hw/net/ftgmac100.c +++ b/hw/net/ftgmac100.c

[PATCH v2 5/5] misc/pca9552: Add qom set and get

From: Joel Stanley Following the pattern of the work recently done with the ASPEED GPIO model, this adds support for inspecting and modifying the PCA9552 LEDs from the monitor. (qemu) qom-set /machine/unattached/device[17] led0 on (qemu) qom-set /machine/unattached/device[17] led0 off (qemu

Re: [PULL 00/37] qom-ify serial and remove QDEV_PROP_PTR

On Tue, 7 Jan 2020 at 15:04, Marc-André Lureau wrote: > > The following changes since commit cdbc5c51c8755e4e9ce964fc92ba755e1c71a914: > > Merge remote-tracking branch 'remotes/xtensa/tags/20200106-xtensa' into > staging (2020-01-07 10:31:07 +) > > are available in the Git repository at: >

Re: [PATCH/RFC 0/1] Vhost User Cross Cable: Intro

Hi On Wed, Jan 8, 2020 at 5:57 AM V. wrote: > > Hi List, > > For my VM setup I tend to use a lot of VM to VM single network links to do > routing, switching and bridging in VM's instead of the host. > Also stemming from a silly fetish to sometimes use some OpenBSD VMs as > firewall, but that is

Re: How to tell DMA controller in qemu to terminate transfer ?

On Wed, 8 Jan 2020 at 18:36, Guenter Roeck wrote: > > Hi, > > I am trying to fix DMA support with Exynos4210. The original commit > 59520dc65e ("hw/arm/exynos4210: Add DMA support for the Exynos4210") doesn't > really work, primarily because it assigns wrong interrupt lines (no idea > how I though

Re: Priority of -accel (was: [PATCH] tests/qemu-iotests: Update tests to recent desugarized -accel option)

On Wed, 8 Jan 2020 at 11:00, Peter Maydell wrote: > > On Wed, 8 Jan 2020 at 10:40, Alex Bennée wrote: > > Thomas Huth writes: > > > What about "-accel any" or "-accel fastest" or something similar? > > > > "any" is just ambiguous, "fastest" is just begging for me to find a > > micro-benchmark th

[Bug 1653577] Re: Ability to set umask for 9pfs

Cannot this be addressed by adjusting the umask in the host before starting QEMU ? And maybe also by adjusting the umask inside the guest if using the "passthrough" or "none" security model of the "local" fsdev backend ? -- You received this bug notification because you are a member of qemu- deve

Re: [PATCH v2 0/5] aspeed: extensions and fixes

Patchew URL: https://patchew.org/QEMU/20200110102518.4233-1-...@kaod.org/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/

[PATCH] xhci: Fix memory leak in xhci_kick_epctx when poweroff GuestOS

From: Chen Qun start vm with libvirt, when GuestOS running, enter poweroff command using the xhci keyboard, then ASAN shows memory leak stack： Direct leak of 80 byte(s) in 5 object(s) allocated from: #0 0xfffd1e6431cb in __interceptor_malloc (/lib64/libasan.so.4+0xd31cb) #1 0xfffd1e10716

Re: [PATCH 092/104] virtiofsd: add man page

* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Thu, Jan 09, 2020 at 08:02:13PM +, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > On Thu, Dec 12, 2019 at 04:38:52PM +, Dr. David Alan Gilbert (git) > > > wrote: > > > > From: Stefan Hajnoczi

Re: [PATCH v2 0/5] aspeed: extensions and fixes

On 1/10/20 11:53 AM, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20200110102518.4233-1-...@kaod.org/ attempt to add duplicate property 'emmc' to object (type 'ast2600-a0') Broken pipe /tmp/qemu-test/src/tests/libqtest.c:149: kill_qemu() detected QEMU death from signal 6 (A

[PATCH v3 1/1] block/rbd: Add support for ceph namespaces

Starting from ceph Nautilus, RBD has support for namespaces, allowing for finer grain ACLs on images inside a pool, and tenant isolation. In the rbd cli tool documentation, the new image-spec and snap-spec are : - [pool-name/[namespace-name/]]image-name - [pool-name/[namespace-name/]]image-name@

[PATCH v3 0/1] block/rbd: Add support for ceph namespaces

Fixed the white space issue, no changes other than that. Florian Florensa (1): block/rbd: Add support for ceph namespaces block/rbd.c | 44 +++- qapi/block-core.json | 4 2 files changed, 35 insertions(+), 13 deletions(-) -- 2.24.1

Re: [PULL v2 6/9] configure: add GDBUS_CODEGEN

On Tue, 7 Jan 2020 at 16:40, Marc-André Lureau wrote: > > Hi > > On Tue, Jan 7, 2020 at 8:14 PM Peter Maydell wrote: > > I've just noticed that this seems to cause problems for > > the NetBSD VM, because pkg-config reports a value for > > gdbus_codegen which isn't an installed binary: > > > > loc

Re: [PULL 0/8] qtests and docs

On Tue, 7 Jan 2020 at 19:08, Thomas Huth wrote: > > Hi! > > The following changes since commit f4d8cf148e43d942ef1202071e0cd66ce40322e0: > > Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2020-01-06' > into staging (2020-01-06 17:44:22 +) > > are available in the Git reposi

[PATCH] configure: check for gdbus-codegen presence

Some distros ship gdbus-codegen separately for gio headers/pc... Reported-by: Peter Maydell Signed-off-by: Marc-André Lureau --- configure | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configure b/configure index 0ce2c0354a..28ee2a254f 100755 --- a/configure +++ b/configure @@ -3702,6

Re: [PATCH 2/5] hw/arm: ast2600: Wire up the eMMC controller

>> + >> +    sysbus_init_child_obj(obj, "emmc", OBJECT(&s->emmc), sizeof(s->emmc), >> +  TYPE_ASPEED_SDHCI); >> + >> +    object_property_set_int(OBJECT(&s->emmc), 1, "num-slots", &error_abort); >> + >> +    sysbus_init_child_obj(obj, "emmc[*]", OBJECT(&s->emmc.slots[0]), >

Re: [PATCH] virtio: Prevent double swap due to target pre 1.0 VirtIO

> What are the symptoms without your patch ? What's the QEMU version ? If using virtio for networking, guest vtnet0 interface appears with 'status: no carrier'. Applying the patch the interface appears as 'status: active' and works normally. I tested with branches stable-4.1 and master. > Do you

Re: [PATCH v2 2/9] 9pfs: validate count sent by client with T_readdir

On Donnerstag, 9. Januar 2020 00:53:35 CET Greg Kurz wrote: > > My idea was to "handle it as an error" immediately when server receives a > > T_version request with a "msize" argument transmitted by client that would > > be way too small for anything. > > > > Because if client sends T_version with

Re: [PATCH v2 4/9] tests/virtio-9p: added readdir test

On Donnerstag, 9. Januar 2020 00:55:45 CET Greg Kurz wrote: > > diff --git a/tests/virtio-9p-test.c b/tests/virtio-9p-test.c > > index 06263edb53..48c0eca292 100644 > > --- a/tests/virtio-9p-test.c > > +++ b/tests/virtio-9p-test.c > > @@ -68,6 +68,11 @@ static void v9fs_memread(P9Req *req, void *ad

Re: [PATCH v2 3/4] qcow2: Tighten cluster_offset alignment assertions

On Thu 09 Jan 2020 08:13:01 PM CET, Alberto Garcia wrote: > -assert((cluster_offset & 511) == 0); > +assert(QEMU_IS_ALIGNED(cluster_offset, s->cluster_size)); On second thoughts this patch could also use the (probably more efficient) offset_into_cluster() call instead. I can resen

Re: plugin order of registration and order of callback

Robert Henry writes: > The documentation on the new plugin capabilities of qemu is silent > about the order call back registration should be done, and is also > silent on the order in which call backs are fired. Call-back order is based on the events themselves not the order of registration. T

[PATCH] vhost-user-blk: reset the device if supported

As the vhost-user-scsi did in f04724, if the vhost-user-blk backend supports the VHOST_USER_F_RESET_DEVICE protocol feature, then the device can be reset when requested. If this feature is not supported, this reset will directly return. Signed-off-by: Yang Zhong --- hw/block/vhost-user-blk.c |

Re: How to tell DMA controller in qemu to terminate transfer ?

Hi Peter, On 1/10/20 2:36 AM, Peter Maydell wrote: On Wed, 8 Jan 2020 at 18:36, Guenter Roeck wrote: Hi, I am trying to fix DMA support with Exynos4210. The original commit 59520dc65e ("hw/arm/exynos4210: Add DMA support for the Exynos4210") doesn't really work, primarily because it assigns

Re: [PATCH 032/104] virtiofsd: passthrough_ll: create new files in caller's context

* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Mon, Jan 06, 2020 at 07:08:43PM +, Dr. David Alan Gilbert wrote: > > * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > > On Thu, Dec 12, 2019 at 04:37:52PM +, Dr. David A

Re: [PATCH] xhci: Fix memory leak in xhci_kick_epctx when poweroff GuestOS

On 1/10/20 11:58 AM, kuhn.chen...@huawei.com wrote: From: Chen Qun start vm with libvirt, when GuestOS running, enter poweroff command using the xhci keyboard, then ASAN shows memory leak stack： Direct leak of 80 byte(s) in 5 object(s) allocated from: #0 0xfffd1e6431cb in __interceptor_ma

Re: [PATCH 099/104] virtiofsd: use fuse_buf_writev to replace fuse_buf_write for better performance

* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Thu, Dec 12, 2019 at 04:38:59PM +, Dr. David Alan Gilbert (git) wrote: > > From: piaojun > > > > fuse_buf_writev() only handles the normal write in which src is buffer > > and dest is fd. Specially if src buffer represents guest physical

Re: [PATCH] configure: check for gdbus-codegen presence

On Fri, 10 Jan 2020 at 11:27, Marc-André Lureau wrote: > > Some distros ship gdbus-codegen separately for gio headers/pc... > > Reported-by: Peter Maydell > Signed-off-by: Marc-André Lureau > --- > configure | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/configure b/configure > ind

Re: [PATCH v3 1/1] block/rbd: Add support for ceph namespaces

On Fri, Jan 10, 2020 at 12:15:13PM +0100, Florian Florensa wrote: > Starting from ceph Nautilus, RBD has support for namespaces, allowing > for finer grain ACLs on images inside a pool, and tenant isolation. > > In the rbd cli tool documentation, the new image-spec and snap-spec are : > - [pool-n

Re: [PATCH] Bug #1829242 correction

- - wrote: > Bug #1829242 correction. Added type conversions to ram_addr_t > before all left shifts of page indexes to TARGET_PAGE_BITS, to correct > overflows when the page address was 4Gb and more. > > Signed-off-by: Alexey Romko Reviewed-by: Juan Quintela I have to "redo" the patch, as it i

Re: [PATCH 0/4] buildsys: Build quicker (mostly tools and linux-user)

Le 10/01/2020 à 10:17, Philippe Mathieu-Daudé a écrit : > Le ven. 10 janv. 2020 09:36, Laurent Vivier > a écrit : > > Le 09/01/2020 à 16:39, Philippe Mathieu-Daudé a écrit : > > In some configuration (linux-user, tools) we can ignore building > > various obje

Re: [PATCH V2] vhost-user-test: fix a memory leak

On 20/12/2019 02.26, pannengy...@huawei.com wrote: > From: Pan Nengyuan > > Spotted by ASAN. > > Reported-by: Euler Robot > Signed-off-by: Pan Nengyuan > --- > Changes V2 to V1: > - use a "goto cleanup", instead of duplicating the "free" functions. > - free "dest_cmdline" at the end. > --- >

Re: [PULL v2 00/14] testing fixes and semihosting console support

On Thu, 9 Jan 2020 at 14:19, Alex Bennée wrote: > > The following changes since commit 035eed4c0d257c905a556fa0f4865a0c077b4e7f: > > Merge remote-tracking branch > 'remotes/vivier/tags/q800-for-5.0-pull-request' into staging (2020-01-07 > 17:08:21 +) > > are available in the Git repository

Re: [PATCH v3 1/1] block/rbd: Add support for ceph namespaces

On Fri, Jan 10, 2020 at 6:15 AM Florian Florensa wrote: > > Starting from ceph Nautilus, RBD has support for namespaces, allowing > for finer grain ACLs on images inside a pool, and tenant isolation. > > In the rbd cli tool documentation, the new image-spec and snap-spec are : > - [pool-name/[nam

Re: [kvm-unit-tests PATCH 08/16] arm/arm64: ITS: Init the command queue

Hi Zenghui, On 12/20/19 8:10 AM, Zenghui Yu wrote: > Hi Eric, > > On 2019/12/16 22:02, Eric Auger wrote: >> Allocate the command queue and initialize related registers: >> CBASER, CREADR, CWRITER. >> >> The command queue is 64kB. This aims at not bothing with fullness. >> >> Signed-off-by: Eric A

Re: [PATCH v10 Kernel 1/5] vfio: KABI for migration interface for device state

On Wed, 8 Jan 2020 15:44:28 -0700 Alex Williamson wrote: > On Thu, 9 Jan 2020 02:11:11 +0530 > Kirti Wankhede wrote: > > > On 1/9/2020 12:01 AM, Alex Williamson wrote: > > > On Wed, 8 Jan 2020 15:59:55 +0100 > > > Cornelia Huck wrote: > > >> I think one thing we could do is start to tie the

Re: [kvm-unit-tests PATCH 11/16] arm/arm64: ITS: Device and collection Initialization

Hi Zenghui, On 12/20/19 8:25 AM, Zenghui Yu wrote: > Hi Eric, > > On 2019/12/16 22:02, Eric Auger wrote: >> Introduce an helper functions to register >> - a new device, characterized by its device id and the >>    max number of event IDs that dimension its ITT (Interrupt >>    Translation Table).

Re: [PATCH] virtio: Prevent double swap due to target pre 1.0 VirtIO

On Fri, 10 Jan 2020 09:00:50 -0300 André Silva wrote: > > What are the symptoms without your patch ? What's the QEMU version ? > > If using virtio for networking, guest vtnet0 interface appears with > 'status: no carrier'. Applying the patch the interface appears as > 'status: active' and works

[kvm-unit-tests PATCH v2 03/16] arm/arm64: gic: Introduce setup_irq() helper

ipi_enable() code would be reusable for other interrupts than IPI. Let's rename it setup_irq() and pass an interrupt handler pointer. We also export it to use it in other tests such as the PMU's one. Signed-off-by: Eric Auger --- arm/gic.c | 24 +++- lib/arm/asm/gic.h

[kvm-unit-tests PATCH v2 00/16] arm/arm64: Add ITS tests

This series is a revival of an RFC series sent in Dec 2016 [1]. Given the amount of code and the lack of traction at that time, I haven't respinned until now. However a recent bug found related to the ITS migration convinced me that this work may deserve to be respinned and enhanced. Tests exercis

[kvm-unit-tests PATCH v2 01/16] libcflat: Add other size defines

Introduce additional SZ_256, SZ_8K, SZ_16K macros that will be used by ITS tests. Signed-off-by: Eric Auger Reviewed-by: Thomas Huth --- lib/libcflat.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/libcflat.h b/lib/libcflat.h index ea19f61..7092af2 100644 --- a/lib/libcflat.h +++ b

[kvm-unit-tests PATCH v2 05/16] arm/arm64: ITS: Introspection tests

Detect the presence of an ITS as part of the GICv3 init routine, initialize its base address and read few registers the IIDR, the TYPER to store its dimensioning parameters. This is our first ITS test, belonging to a new "its" group. Signed-off-by: Eric Auger --- v1 -> v2: - clean GITS_TYPER m

[kvm-unit-tests PATCH v2 04/16] arm/arm64: gicv3: Add some re-distributor defines

PROPBASER, PENDBASE and GICR_CTRL will be used for LPI management. Signed-off-by: Eric Auger --- lib/arm/asm/gic-v3.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/arm/asm/gic-v3.h b/lib/arm/asm/gic-v3.h index 6beeab6..ffb2e26 100644 --- a/lib/arm/asm/gic-v3.h +++ b/lib/arm/asm/g

[kvm-unit-tests PATCH v2 06/16] arm/arm64: ITS: Test BASER

Add helper routines to parse and set up BASER registers. Add a new test dedicated to BASER accesses. Signed-off-by: Eric Auger --- v2 -> v3: - remove everything related to memory attributes - s/dev_baser/coll_baser/ in report_info - add extra line - removed index filed in its_baser --- arm/gic

[kvm-unit-tests PATCH v2 07/16] arm/arm64: ITS: Set the LPI config and pending tables

Allocate the LPI configuration and per re-distributor pending table. Set redistributor's PROPBASER and PENDBASER. The LPIs are enabled by default in the config table. Also introduce a helper routine that allows to set the pending table bit for a given LPI. Signed-off-by: Eric Auger --- v1 -> v

[kvm-unit-tests PATCH v2 15/16] arm/arm64: ITS: migration tests

This test maps LPIs (populates the device table, the collection table, interrupt translation tables, configuration table), migrates and make sure the translation is correct on the destination. Signed-off-by: Eric Auger --- arm/gic.c| 55 +--- a

[kvm-unit-tests PATCH v2 10/16] arm/arm64: ITS: its_enable_defaults

its_enable_defaults() is the top init function that allocates all the requested tables (device, collection, lpi config and pending tables), enable LPIs at distributor level and ITS level. gicv3_enable_defaults must be called before. Signed-off-by: Eric Auger --- lib/arm/asm/gic-v3-its.h | 1 +

[kvm-unit-tests PATCH v2 02/16] arm: gic: Provide per-IRQ helper functions

From: Andre Przywara A common theme when accessing per-IRQ parameters in the GIC distributor is to set fields of a certain bit width in a range of MMIO registers. Examples are the enabled status (one bit per IRQ), the level/edge configuration (2 bits per IRQ) or the priority (8 bits per IRQ). Ad

[kvm-unit-tests PATCH v2 14/16] arm/run: Allow Migration tests

Let's link getchar.o to use puts and getchar from the tests. Then allow tests belonging to the migration group to trigger the migration from the test code by putting "migrate" into the uart. Then the code can wait for the migration completion by using getchar(). The __getchar implement is minimal

[kvm-unit-tests PATCH v2 11/16] arm/arm64: ITS: Device and collection Initialization

Introduce an helper functions to register - a new device, characterized by its device id and the max number of event IDs that dimension its ITT (Interrupt Translation Table). The function allocates the ITT. - a new collection, characterized by its ID and the target processing engine (PE).

[kvm-unit-tests PATCH v2 08/16] arm/arm64: ITS: Init the command queue

Allocate the command queue and initialize related registers: CBASER, CREADR, CWRITER. The command queue is 64kB. This aims at not bothing with fullness. Signed-off-by: Eric Auger --- v2 -> v3: - removed readr --- lib/arm/asm/gic-v3-its.h | 6 ++ lib/arm/gic-v3-its.c | 22

  1   2   3   >