On 09/01/2020 03.17, Richard Henderson wrote:
> We allocate the list with g_strsplit, so free it too.
> This freeing was lost during one of the rearrangements.
>
> Fixes: 6f6e1698a68c
> Signed-off-by: Richard Henderson
> ---
> vl.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>
On 09/01/2020 09:18, Thomas Huth wrote:
> On 09/01/2020 03.17, Richard Henderson wrote:
>> We allocate the list with g_strsplit, so free it too.
>> This freeing was lost during one of the rearrangements.
>>
>> Fixes: 6f6e1698a68c
>> Signed-off-by: Richard Henderson
>> ---
>> vl.c | 4 +++-
>> 1 f
On 08/01/2020 23.49, Alex Bennée wrote:
> The idea of this is split the build across stages so any failure in
> one stage will save time running later stages. So far I have have
> arbitrarily chosen:
>
> canary: up-front quick to build and run
> platforms: common build configurations
> rest:
On Wed, Jan 08, 2020 at 05:55:52PM +0100, Auger Eric wrote:
> Hi Jean-Philippe, Peter,
>
> On 1/7/20 11:10 AM, Jean-Philippe Brucker wrote:
> > On Mon, Jan 06, 2020 at 12:58:50PM -0500, Peter Xu wrote:
> >> On Mon, Jan 06, 2020 at 06:06:34PM +0100, Jean-Philippe Brucker wrote:
> >>> On Fri, Dec 20
Hi Jean,
On 1/9/20 9:47 AM, Jean-Philippe Brucker wrote:
> On Wed, Jan 08, 2020 at 05:55:52PM +0100, Auger Eric wrote:
>> Hi Jean-Philippe, Peter,
>>
>> On 1/7/20 11:10 AM, Jean-Philippe Brucker wrote:
>>> On Mon, Jan 06, 2020 at 12:58:50PM -0500, Peter Xu wrote:
On Mon, Jan 06, 2020 at 06:06
On 09/01/20 03:17, Richard Henderson wrote:
> Running qemu-system-foo with no options should not generate
> a warning for "invalid accelerator bar".
>
> Also, fix some mistakes made while moving the code from accel/accel.c.
>
>
> r~
>
>
> Richard Henderson (4):
> vl: Remove unused variable i
Jason Wang writes:
> On 2020/1/8 下午9:53, Dr. David Alan Gilbert (git) wrote:
>> From: "Dr. David Alan Gilbert"
>>
>> Hyperv's synic (that we emulate) is a feature that allows the guest
>> to place some magic (4k) pages of RAM anywhere it likes in GPA.
>> This confuses vhost's RAM section merging
Wei Yang wrote:
> In this case, page_buffer content would not be used.
>
> Skip this to save some time.
>
> Signed-off-by: Wei Yang
> Reviewed-by: Dr. David Alan Gilbert
Acked-by: Juan Quintela
Wei Yang wrote:
> Compress is not supported with postcopy, it is safe to wait for
> decompress thread just in precopy.
>
> This is a preparation for later patch.
>
> Signed-off-by: Wei Yang
> Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Juan Quintela
Wei Yang wrote:
> In postcopy, it requires to place whole host page instead of target
> page.
>
> Currently, it relies on the page offset to decide whether this is the
> last target page. We also can count the target page number during the
> iteration. When the number of target page equals
> (host
Wei Yang wrote:
> For the first target page, all_zero is set to true for this round check.
>
> After target_pages introduced, we could leverage this variable instead
> of checking the address offset.
>
> Signed-off-by: Wei Yang
> Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Juan Quintela
Wei Yang wrote:
> After using number of target page received to track one host page, we
> could have the capability to handle random order target page arrival in
> one host page.
>
> This is a preparation for enabling compress during postcopy.
>
> Signed-off-by: Wei Yang
>
> ---
> v2:
>* use
On PC systems, system memory is organized like this:
- priority -1 is the PCI BARs
- priority 0 is the RAM
- priority 1 pokes holes in RAM whenever PCI BARs should appear instead
(for example due to SMRAM or PAM configuration), plus it contains RAM
regions in RAM mode (again toggled by PAM c
Wei Yang wrote:
> postcopy requires to place a whole host page, while migration thread
> migrate memory in target page size. This makes postcopy need to collect
> all target pages in one host page before placing via userfaultfd.
>
> To enable compress during postcopy, there are two problems to sol
Wei Yang wrote:
> On Mon, Dec 16, 2019 at 10:35:39AM +0800, Wei Yang wrote:
>>Would this one be picked up this time?
>
> Happy new year to all.
>
> Can I ask the plan for this patch set?
queued
>
>>
>>On Sat, Oct 26, 2019 at 07:19:58AM +0800, Wei Yang wrote:
>>>We don't support multifd during po
Python 2 support has been removed, so we should now also remove
the announcement text for the deprecation.
Signed-off-by: Thomas Huth
---
qemu-deprecated.texi | 8
1 file changed, 8 deletions(-)
diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi
index 7033e531de..8b23e98474 10064
cenjiahui wrote:
> From: Jiahui Cen
>
> One multifd channel will shutdown all the other multifd's IOChannel when it
> fails to receive an IOChannel. In this senario, if some multifds had not
> received its IOChannel yet, it would try to shutdown its IOChannel which could
> cause nullptr access at
On Thu, 9 Jan 2020 02:45:58 +
"Zengtao (B)" wrote:
> > -Original Message-
> > From: Igor Mammedov [mailto:imamm...@redhat.com]
> > Sent: Thursday, January 09, 2020 12:39 AM
> > To: Zengtao (B)
> > Cc: Michael S. Tsirkin; qemu-devel@nongnu.org; qemu-triv...@nongnu.org;
> > Shannon Zhao
From: fengzhimin
We need to call the 'migration_incoming_setup' function in migration/rdma.c,
so it has to be changed to a global function.
Signed-off-by: fengzhimin
---
migration/migration.c | 11 ++-
migration/migration.h | 2 ++
2 files changed, 12 insertions(+), 1 deletion(-)
dif
From: fengzhimin
register memory for multiRDMA channels and transmit the destination
the keys to source to use including the virtual addresses.
Signed-off-by: fengzhimin
---
migration/rdma.c | 192 ++-
1 file changed, 190 insertions(+), 2 deletions(-
From: fengzhimin
Signed-off-by: fengzhimin
---
migration/migration.c | 11 +++
migration/migration.h | 1 +
qapi/migration.json | 4 +++-
3 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/migration/migration.c b/migration/migration.c
index 354ad072fa..e98e236ef9 100644
From: fengzhimin
Indicates the number of RDMA threads that we would create.
By default we create 2 threads for RDMA migration.
Signed-off-by: fengzhimin
---
migration/migration.c | 32
migration/migration.h | 1 +
monitor/hmp-cmds.c| 7 +++
qapi/migra
From: fengzhimin
Signed-off-by: fengzhimin
---
migration/rdma.c | 109 +--
1 file changed, 105 insertions(+), 4 deletions(-)
diff --git a/migration/rdma.c b/migration/rdma.c
index 36261f1fc8..0a150099e2 100644
--- a/migration/rdma.c
+++ b/migration/r
From: fengzhimin
Signed-off-by: fengzhimin
---
migration/rdma.c | 23 +++
1 file changed, 23 insertions(+)
diff --git a/migration/rdma.c b/migration/rdma.c
index 6ecc870844..425dfa709d 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -439,6 +439,10 @@ struct {
M
From: fengzhimin
Transmit initial package through the multiRDMA channels,
so that we can identify the main channel and multiRDMA channels.
Signed-off-by: fengzhimin
---
migration/rdma.c | 114 ---
1 file changed, 107 insertions(+), 7 deletions(-)
di
From: fengzhimin
We need to build all multiRDMA channels before we start migration.
Signed-off-by: fengzhimin
---
migration/rdma.c | 44 ++--
1 file changed, 42 insertions(+), 2 deletions(-)
diff --git a/migration/rdma.c b/migration/rdma.c
index db75a43
From: fengzhimin
In both sides. We still don't transmit anything through them,
and we only build the RDMA connections.
Signed-off-by: fengzhimin
---
migration/rdma.c | 253 +--
1 file changed, 223 insertions(+), 30 deletions(-)
diff --git a/migratio
From: fengzhimin
Send the RAM block through MultiRDMA channels for using rdma-pin-all option,
and we choose the channel to send data through polling the MultiRDMA thread.
Signed-off-by: fengzhimin
---
migration/rdma.c | 66 +---
1 file changed, 63 in
From: fengzhimin
Creation of the RDMA threads, nothing inside yet.
Signed-off-by: fengzhimin
---
migration/migration.c | 1 +
migration/migration.h | 2 +
migration/rdma.c | 283 ++
3 files changed, 286 insertions(+)
diff --git a/migration/migr
From: fengzhimin
Currently there is a single channel for RDMA migration, this causes
the problem that the network bandwidth is not fully utilized for
25Gigabit NIC. Inspired by the Multifd, we use two RDMA channels to
send RAM pages, which we call MultiRDMA.
We compare the migration performance
From: fengzhimin
The virt-ram block is sent by MultiRDMA, so we only register it for
MultiRDMA channels and main channel don't register the virt-ram block.
Signed-off-by: fengzhimin
---
migration/rdma.c | 140 +--
1 file changed, 112 insertions(+), 2
cenjiahui wrote:
> From: Jiahui Cen
>
> One multifd will lock all the other multifds' IOChannel mutex to inform them
> to quit by setting p->quit or shutting down p->c. In this senario, if some
> multifds had already been terminated and
> multifd_load_cleanup/multifd_save_cleanup
> had destroyed
On Wed, 8 Jan 2020 19:14:24 +0100
Philippe Mathieu-Daudé wrote:
> The hardware expects DIMM slots of 1 or 2 GB, allowing up to
> 4 GB of memory. Accept the same amount of memory the hardware
> can deal with.
>
> The CPU doesn't have access to the RAM mapped in the
> [0xf000 - 0xf100] ra
On Thu, 9 Jan 2020 00:31:38 +0100
Philippe Mathieu-Daudé wrote:
> The smbios_get_tables() function has access the a machine state.
> Use the field instead of accessing the global ram_size variable.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Igor Mammedov
> ---
> hw/smbios/smbios
On Wed, Jan 08, 2020 at 04:16:09AM -0800, no-re...@patchew.org wrote:
> === TEST SCRIPT BEGIN ===
> #! /bin/bash
> export ARCH=x86_64
> make docker-image-fedora V=1 NETWORK=1
> time make docker-test-mingw@fedora J=14 NETWORK=1
> === TEST SCRIPT END ===
>
> CC io/channel-websock.o
> CC
Patchew URL:
https://patchew.org/QEMU/20200109045922.904-1-fengzhim...@huawei.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ==
On Thu, Jan 09, 2020 at 09:58:49AM +0100, Auger Eric wrote:
> >> I share Peter's concern about having a different default policy than x86.
> >
> > Yes I'd say just align with whatever policy is already in place. Do you
> > think we could add a command-line option to let people disable
> > default-
On Wed, Jan 08, 2020 at 01:16:18PM -0300, Andre Silva wrote:
> Remove the bswap function calls after reading and before writing
> memory bytes in virtio_pci_config_read and virtio_pci_config_write
> because they are reverting back an already swapped bytes.
>
> Consider the table below in the conte
Hi,
On 1/9/20 11:40 AM, Jean-Philippe Brucker wrote:
> On Thu, Jan 09, 2020 at 09:58:49AM +0100, Auger Eric wrote:
I share Peter's concern about having a different default policy than x86.
>>>
>>> Yes I'd say just align with whatever policy is already in place. Do you
>>> think we could add a
Richard Henderson writes:
> The accel_initialised variable no longer has any setters.
>
> Fixes: 6f6e1698a68c
> Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
> ---
> vl.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index 86474a55c9..
Richard Henderson writes:
> We allocate the list with g_strsplit, so free it too.
> This freeing was lost during one of the rearrangements.
>
> Fixes: 6f6e1698a68c
> Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
> ---
> vl.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deleti
Richard Henderson writes:
> The result of g_strsplit is never NULL.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
> ---
> vl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/vl.c b/vl.c
> index c9329fe699..887dbfbb5d 100644
> --- a/vl.c
> +++ b/vl.
On 1/9/20 11:15 AM, Igor Mammedov wrote:
On Wed, 8 Jan 2020 19:14:24 +0100
Philippe Mathieu-Daudé wrote:
The hardware expects DIMM slots of 1 or 2 GB, allowing up to
4 GB of memory. Accept the same amount of memory the hardware
can deal with.
The CPU doesn't have access to the RAM mapped in
v2:
* Fix uint64_t <-> size_t type mismatch in block_crypto_measure() so that
32-bit builds pass
This patch series adds qemu-img measure support to the "luks" block driver. We
just need to take into account the LUKS header when sizing the image.
Stefan Hajnoczi (4):
luks: extract block_cry
Add qemu-img measure support in the "luks" block driver.
Signed-off-by: Stefan Hajnoczi
---
block/crypto.c | 82 ++
1 file changed, 82 insertions(+)
diff --git a/block/crypto.c b/block/crypto.c
index ed32202fa2..51f37bb1f6 100644
--- a/block/crypt
The qcow2 .bdrv_measure() code calculates the crypto payload offset.
This logic really belongs in block/crypto.c where it can be reused by
other image formats.
The "luks" block driver will need this same logic in order to implement
.bdrv_measure(), so extract the block_crypto_calculate_payload_off
This test exercises the block/crypto.c "luks" block driver
.bdrv_measure() code.
Signed-off-by: Stefan Hajnoczi
---
tests/qemu-iotests/282 | 93 ++
tests/qemu-iotests/282.out | 30
tests/qemu-iotests/group | 1 +
3 files changed, 124 insert
In most qemu-img sub-commands the --object option only makes sense when
there is a filename. qemu-img measure is an exception because objects
may be referenced from the image creation options instead of an existing
image file. Allow --object without a filename.
Signed-off-by: Stefan Hajnoczi
--
On Thu, Jan 09, 2020 at 12:01:26PM +0100, Auger Eric wrote:
> Hi,
>
> On 1/9/20 11:40 AM, Jean-Philippe Brucker wrote:
> > On Thu, Jan 09, 2020 at 09:58:49AM +0100, Auger Eric wrote:
> I share Peter's concern about having a different default policy than x86.
> >>>
> >>> Yes I'd say just align
Hi,
"hw/boards.h" declare current_machine, and vl.c defines it:
current_machine =
MACHINE(object_new_with_class(OBJECT_CLASS(machine_class)));
object_property_add_child(object_get_root(), "machine",
OBJECT(current_machine), &error_abort);
The bigger user
Nothing from "sysemu/cpus.h" is used by smbios.c, remove the include.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/smbios/smbios.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c
index ded5f1f4e2..1a0f461541 100644
--- a/hw/smbios/smbios.c
+++ b/hw/smbi
08.01.2020 1:01, Eric Blake wrote:
> On 12/26/19 2:15 AM, Vladimir Sementsov-Ogievskiy wrote:
>> Don't try to write zero-lenght strings.
>
> length
>
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy
>> ---
>> nbd/server.c | 16 ++--
>> 1 file changed, 10 insertions(+), 6 deletion
Hi Jean,
On 1/9/20 12:15 PM, Jean-Philippe Brucker wrote:
> On Thu, Jan 09, 2020 at 12:01:26PM +0100, Auger Eric wrote:
>> Hi,
>>
>> On 1/9/20 11:40 AM, Jean-Philippe Brucker wrote:
>>> On Thu, Jan 09, 2020 at 09:58:49AM +0100, Auger Eric wrote:
>> I share Peter's concern about having a differ
Hi Klaus,
On Thu, 19 Dec 2019 at 13:09, Klaus Jensen wrote:
>
> Handling DMA errors gracefully is required for the device to pass the
> block/011 test ("disable PCI device while doing I/O") in the blktests
> suite.
>
> With this patch the device passes the test by retrying "critical"
> transfers
On Thu, Jan 09, 2020 at 12:31:38AM +0100, Philippe Mathieu-Daudé wrote:
> The smbios_get_tables() function has access the a machine state.
the a -> the
> Use the field
the field -> the machine state field
> instead of accessing the global ram_size variable.
>
> Signed-off-by: Philippe Mathieu-
Richard Henderson writes:
> By choosing "tcg:kvm" when kvm is not enabled, we generate
> an incorrect warning: "invalid accelerator kvm".
>
> Presumably the inverse is also true with --disable-tcg.
>
> Fixes: 28a0961757fc
> Signed-off-by: Richard Henderson
> ---
> vl.c | 18 --
On Thu, Jan 09, 2020 at 12:25:04PM +0100, Philippe Mathieu-Daudé wrote:
> Nothing from "sysemu/cpus.h" is used by smbios.c, remove the include.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Michael S. Tsirkin
> ---
> hw/smbios/smbios.c | 1 -
> 1 file changed, 1 deletion(-)
>
> di
On Thu, 9 Jan 2020 12:09:26 +0100
Philippe Mathieu-Daudé wrote:
> On 1/9/20 11:15 AM, Igor Mammedov wrote:
> > On Wed, 8 Jan 2020 19:14:24 +0100
> > Philippe Mathieu-Daudé wrote:
> >
> >> The hardware expects DIMM slots of 1 or 2 GB, allowing up to
> >> 4 GB of memory. Accept the same amount
Hi Klaus,
On Thu, 19 Dec 2019 at 13:09, Klaus Jensen wrote:
>
> This refactors how the device issues asynchronous block backend
> requests. The NvmeRequest now holds a queue of NvmeAIOs that are
> associated with the command. This allows multiple aios to be issued for
> a command. Only when all r
Hi Klaus,
On Thu, 19 Dec 2019 at 13:09, Klaus Jensen wrote:
>
> For now, support the Data Block, Segment and Last Segment descriptor
> types.
>
> See NVM Express 1.3d, Section 4.4 ("Scatter Gather List (SGL)").
>
> Signed-off-by: Klaus Jensen
> Acked-by: Fam Zheng
> ---
> block/nvme.c
On Wed, Jan 08, 2020 at 01:53:52PM +, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert"
>
> Don't pass RAM blocks that are marked as ram devices to vhost.
> There's normally something special about them and they're not
> normally just shared memory.
>
> Signed-off-by: Dr.
On Wed, Jan 08, 2020 at 01:53:53PM +, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert"
>
> Mark the synic pages as ram_device so that they won't be visible
> to vhost.
>
> Signed-off-by: Dr. David Alan Gilbert
I think I disagree with this one.
* A RAM device represent
Am 23.12.2019 um 10:46 hat Pavel Dovgalyuk geschrieben:
> From: Pavel Dovgalyuk
>
> This patch introduces the icount field for saving within the snapshot.
> It is required for navigation between the snapshots in record/replay mode.
>
> Signed-off-by: Pavel Dovgalyuk
> Acked-by: Kevin Wolf
> d
On Wed, Jan 08, 2020 at 01:53:51PM +, Dr. David Alan Gilbert (git) wrote:
> Hyperv's synic (that we emulate) is a feature that allows the guest
> to place some magic (4k) pages of RAM anywhere it likes in GPA.
> This confuses vhost's RAM section merging when these pages
> land over the top of h
On Thu, Jan 09, 2020 at 06:45:24AM -0500, Michael S. Tsirkin wrote:
> On Wed, Jan 08, 2020 at 01:53:52PM +, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert"
> >
> > Don't pass RAM blocks that are marked as ram devices to vhost.
> > There's normally something special abou
On Thursday, January 9, 2020, Laurent Vivier wrote:
> On 09/01/2020 09:18, Thomas Huth wrote:
> > On 09/01/2020 03.17, Richard Henderson wrote:
> >> We allocate the list with g_strsplit, so free it too.
> >> This freeing was lost during one of the rearrangements.
> >>
> >> Fixes: 6f6e1698a68c
> >
Am 23.12.2019 um 10:47 hat Pavel Dovgalyuk geschrieben:
> From: Pavel Dovgalyuk
>
> Saving icount as a parameters of the snapshot allows navigation between
> them in the execution replay scenario.
> This information can be used for finding a specific snapshot for proceeding
> the recorded executi
On 09/01/20 12:23, Philippe Mathieu-Daudé wrote:
>
>
> current_machine =
> MACHINE(object_new_with_class(OBJECT_CLASS(machine_class)));
> object_property_add_child(object_get_root(), "machine",
> OBJECT(current_machine), &error_abort);
>
> The bigger user of
* Jason Wang (jasow...@redhat.com) wrote:
>
> On 2020/1/8 下午9:53, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert"
> >
> > Hyperv's synic (that we emulate) is a feature that allows the guest
> > to place some magic (4k) pages of RAM anywhere it likes in GPA.
> > This confus
On Fri, Nov 22, 2019 at 07:29:42PM +0100, Eric Auger wrote:
> The virtio-iommu-pci is instantiated through the -device QEMU
> option. However if instantiated it also requires an IORT ACPI table
> to describe the ID mappings between the root complex and the iommu.
>
> This patch adds the generation
Am 09.01.2020 um 07:13 hat Pavel Dovgalyuk geschrieben:
> Ping.
I think you have my Acked-by for the block-related patches in this
series now. If I missed something, please let me know.
Kevin
On Thursday, January 9, 2020, Richard Henderson <
richard.hender...@linaro.org> wrote:
> The accel_initialised variable no longer has any setters.
>
> Fixes: 6f6e1698a68c
> Signed-off-by: Richard Henderson
> ---
> vl.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>
Reviewed by: Al
On Thursday, January 9, 2020, Richard Henderson <
richard.hender...@linaro.org> wrote:
> The result of g_strsplit is never NULL.
>
> Signed-off-by: Richard Henderson
> ---
> vl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
Reviewed by: Aleksandar Markovic
> diff --git a/vl.c
Alan Hayward writes:
>> On 20 Dec 2019, at 13:18, Luis Machado wrote:
>>
>> On 12/20/19 10:14 AM, Alex Bennée wrote:
>>> Luis Machado writes:
On 12/19/19 4:15 PM, Alex Bennée wrote:
> Richard Henderson writes:
>
>> On 12/11/19 9:05 AM, Alex Bennée wrote:
>>> +static st
* Michael S. Tsirkin (m...@redhat.com) wrote:
> On Wed, Jan 08, 2020 at 01:53:53PM +, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert"
> >
> > Mark the synic pages as ram_device so that they won't be visible
> > to vhost.
> >
> > Signed-off-by: Dr. David Alan Gilbert
>
On Thursday, January 9, 2020, Alex Bennée wrote:
>
> Richard Henderson writes:
>
> > By choosing "tcg:kvm" when kvm is not enabled, we generate
> > an incorrect warning: "invalid accelerator kvm".
> >
> > Presumably the inverse is also true with --disable-tcg.
> >
> > Fixes: 28a0961757fc
> > Sig
> From: Kevin Wolf [mailto:kw...@redhat.com]
> Am 09.01.2020 um 07:13 hat Pavel Dovgalyuk geschrieben:
> > Ping.
>
> I think you have my Acked-by for the block-related patches in this
> series now. If I missed something, please let me know.
Thank you.
Pavel Dovgalyuk
Am 08.01.2020 um 20:46 hat Nir Soffer geschrieben:
> On Wed, Jan 8, 2020 at 7:52 PM Alberto Garcia wrote:
> >
> > The qcow2 header specifies the virtual size of the image in bytes, but
> > BlockDriverState stores it as a number of 512-byte sectors.
> >
> > If the user tries to create an image with
On Thu, Jan 09, 2020 at 12:02:16PM +, Dr. David Alan Gilbert wrote:
> * Jason Wang (jasow...@redhat.com) wrote:
> >
> > On 2020/1/8 下午9:53, Dr. David Alan Gilbert (git) wrote:
> > > From: "Dr. David Alan Gilbert"
> > >
> > > Hyperv's synic (that we emulate) is a feature that allows the guest
* Roman Kagan (rka...@virtuozzo.com) wrote:
> On Wed, Jan 08, 2020 at 01:53:51PM +, Dr. David Alan Gilbert (git) wrote:
> > Hyperv's synic (that we emulate) is a feature that allows the guest
> > to place some magic (4k) pages of RAM anywhere it likes in GPA.
> > This confuses vhost's RAM secti
Am 08.01.2020 um 18:49 hat Alberto Garcia geschrieben:
> This replaces all remaining instances in the qcow2 code.
>
> Signed-off-by: Alberto Garcia
> diff --git a/block/qcow2.c b/block/qcow2.c
> index e8ce966f7f..6427c75409 100644
> --- a/block/qcow2.c
> +++ b/block/qcow2.c
> @@ -2175,7 +2175,7
On Thu, Jan 09, 2020 at 12:08:20PM +, Dr. David Alan Gilbert wrote:
> * Michael S. Tsirkin (m...@redhat.com) wrote:
> > On Wed, Jan 08, 2020 at 01:53:53PM +, Dr. David Alan Gilbert (git)
> > wrote:
> > > From: "Dr. David Alan Gilbert"
> > >
> > > Mark the synic pages as ram_device so tha
On Thursday, December 12, 2019, Dr. David Alan Gilbert (git) <
dgilb...@redhat.com> wrote:
> From: "Dr. David Alan Gilbert"
>
> Mostly using a set like:
>
> indent -nut -i 4 -nlp -br -cs -ce --no-space-after-function-call-names
> file
> clang-format -style=file -i -- file
> clang-tidy -fix-errors
* Michael S. Tsirkin (m...@redhat.com) wrote:
> On Thu, Jan 09, 2020 at 12:08:20PM +, Dr. David Alan Gilbert wrote:
> > * Michael S. Tsirkin (m...@redhat.com) wrote:
> > > On Wed, Jan 08, 2020 at 01:53:53PM +, Dr. David Alan Gilbert (git)
> > > wrote:
> > > > From: "Dr. David Alan Gilbert"
On 1/9/20 3:17 AM, Richard Henderson wrote:
The accel_initialised variable no longer has any setters.
Fixes: 6f6e1698a68c
Signed-off-by: Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé
---
vl.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/vl.c b/vl.c
index
Pavel Dovgalyuk writes:
> From: Pavel Dovgalyuk
>
> This patch introduces 'info replay' monitor command and
> corresponding qmp request.
> These commands request the current record/replay mode, replay log file
> name, and the instruction count (number of recorded/replayed
> instructions). The
On 1/9/20 3:17 AM, Richard Henderson wrote:
The result of g_strsplit is never NULL.
Signed-off-by: Richard Henderson
---
vl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/vl.c b/vl.c
index c9329fe699..887dbfbb5d 100644
--- a/vl.c
+++ b/vl.c
@@ -2776,7 +2776,7 @@ static
Hi Michael!
Thanks for reviewing the patch!
> we always get LE values from memory subsystem,
> not target endian values:
I see. So do you think the patch is correct in eliminating the extra
swap (as virtio_config_readw for example already makes a swap)?
Thanks,
andré
On Thu, Jan 9, 2020 at 7:50
> From: Alex Bennée [mailto:alex.ben...@linaro.org]
> Pavel Dovgalyuk writes:
>
> > From: Pavel Dovgalyuk
> >
> > This patch introduces 'info replay' monitor command and
> > corresponding qmp request.
> > These commands request the current record/replay mode, replay log file
> > name, and the in
The default NIC model for QEMU varies per machine type, and is liable to
change across machine type versions. Documenting e1000 NIC as the
default for PC/i386 is thus misleading to users at best. In particular
the PC q35 machine type switched to use e1000e, but only in machine
type versions after 2
On Thu 09 Jan 2020 01:19:00 PM CET, Kevin Wolf wrote:
>> diff --git a/block/qcow2.c b/block/qcow2.c
>> index e8ce966f7f..6427c75409 100644
>> --- a/block/qcow2.c
>> +++ b/block/qcow2.c
>> @@ -2175,7 +2175,7 @@ static coroutine_fn int
>> qcow2_co_preadv_task(BlockDriverState *bs,
>>
On Wed 08 Jan 2020 08:46:11 PM CET, Nir Soffer wrote:
>> However when an image is opened the virtual size is rounded down,
>> which means that trying to access the last few advertised bytes will
>> result in an error. As seen above QEMU cannot create such images and
>> there's no good use case that
On Wed, Jan 08, 2020 at 01:53:52PM +, Dr. David Alan Gilbert (git) wrote:
> Don't pass RAM blocks that are marked as ram devices to vhost.
> There's normally something special about them and they're not
> normally just shared memory.
Does this something special about them, whatever it is, make
Add command for reporting devices on Windows guest. The intent is not so
much to report the devices but more importantly the driver (and its
version) that is assigned to the device. This gives caller the
information whether VirtIO drivers are installed and/or whether
inadequate driver is used on a
On Thu, Jan 09, 2020 at 09:25:42AM -0300, André Silva wrote:
> Hi Michael!
> Thanks for reviewing the patch!
>
> > we always get LE values from memory subsystem,
> > not target endian values:
>
> I see. So do you think the patch is correct in eliminating the extra
> swap (as virtio_config_readw f
On Thu, Jan 09, 2020 at 12:38:07PM +, Roman Kagan wrote:
> On Wed, Jan 08, 2020 at 01:53:52PM +, Dr. David Alan Gilbert (git) wrote:
> > Don't pass RAM blocks that are marked as ram devices to vhost.
> > There's normally something special about them and they're not
> > normally just shared
Am 09.01.2020 um 13:30 hat Alberto Garcia geschrieben:
> On Thu 09 Jan 2020 01:19:00 PM CET, Kevin Wolf wrote:
> >> diff --git a/block/qcow2.c b/block/qcow2.c
> >> index e8ce966f7f..6427c75409 100644
> >> --- a/block/qcow2.c
> >> +++ b/block/qcow2.c
> >> @@ -2175,7 +2175,7 @@ static coroutine_fn in
On Thursday, January 9, 2020, Daniel P. Berrangé
wrote:
> The default NIC model for QEMU varies per machine type, and is liable to
> change across machine type versions. Documenting e1000 NIC as the
> default for PC/i386 is thus misleading to users at best. In particular
> the PC q35 machine type
On Thursday, January 9, 2020, Thomas Huth wrote:
> Python 2 support has been removed, so we should now also remove
> the announcement text for the deprecation.
>
> Signed-off-by: Thomas Huth
> ---
> qemu-deprecated.texi | 8
> 1 file changed, 8 deletions(-)
>
>
Reviewed by: Aleksandar
On 09/01/2020 13.29, Daniel P. Berrangé wrote:
> The default NIC model for QEMU varies per machine type, and is liable to
> change across machine type versions. Documenting e1000 NIC as the
> default for PC/i386 is thus misleading to users at best. In particular
> the PC q35 machine type switched t
1 - 100 of 280 matches
Mail list logo
