[PULL 0/6] QAPI patches for 2019-12-17

2019-12-17 Thread Markus Armbruster
The following changes since commit cb88904a54903ef6ba21a68a61d9cd51e2166304: Merge remote-tracking branch 'remotes/amarkovic/tags/mips-queue-dec-16-2019' into staging (2019-12-16 14:07:56 +) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2019-12-

[PULL 3/6] qapi: Generate command registration stuff into separate files

2019-12-17 Thread Markus Armbruster
Having to include qapi-commands.h just for qmp_init_marshal() is suboptimal. Generate it into separate files. This lets monitor/misc.c, qga/main.c, and the generated qapi-commands-FOO.h include less. Signed-off-by: Markus Armbruster Message-Id: <20191120182551.23795-4-arm...@redhat.com> [Typos

[PULL 1/6] qapi: Tweak "command returns a nice type" check for clarity

2019-12-17 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Message-Id: <20191120182551.23795-2-arm...@redhat.com> Reviewed-by: Eric Blake --- scripts/qapi/schema.py | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/scripts/qapi/schema.py b/scripts/qapi/schema.py index cf0045f34e..cfb574c85d 100

[PULL 2/6] tests/Makefile.include: Fix missing test-qapi-emit-events.[ch]

2019-12-17 Thread Markus Armbruster
Commit 5d75648b56 "qapi: Generate QAPIEvent stuff into separate files" added tests/test-qapi-emit-events.[ch] to the set of generated files, but neglected to update tests/.gitignore and tests/Makefile.include. Commit a0af8cee3c "tests/.gitignore: ignore test-qapi-emit-events.[ch] for in-tree builds

[PULL 6/6] qapi: Simplify QAPISchemaModularCVisitor

2019-12-17 Thread Markus Armbruster
Since the previous commit, QAPISchemaVisitor.visit_module() is called just once. Simplify QAPISchemaModularCVisitor accordingly. Signed-off-by: Markus Armbruster Message-Id: <20191120182551.23795-7-arm...@redhat.com> Reviewed-by: Eric Blake --- scripts/qapi/commands.py | 2 +- scripts/qapi/ev

[PULL 5/6] qapi: Fix code generation for empty modules

2019-12-17 Thread Markus Armbruster
When a sub-module doesn't contain any definitions, we don't generate code for it, but we do generate the #include. We generate code only for modules that get visited. QAPISchema.visit() visits only modules that have definitions. It can visit modules multiple times. Clean this up as follows. Col

[PULL 4/6] qapi: Proper intermediate representation for modules

2019-12-17 Thread Markus Armbruster
Modules are represented only by their names so far. Introduce class QAPISchemaModule. So far, it merely wraps the name. The next patch will put it to more interesting use. Once again, arrays spice up the patch a bit. For any other type, @info points to the definition, which lets us map from @i

Re: [PATCH] Semihost SYS_READC implementation (v6)

2019-12-17 Thread Alex Bennée
Keith Packard writes: > Provides a blocking call to read a character from the console using > semihosting.chardev, if specified. This takes some careful command > line options to use stdio successfully as the serial ports, monitor > and semihost all want to use stdio. Here's a sample set of com

[PULL v2 00/10] Bluetooth removal, and qtest & misc patches

2019-12-17 Thread Thomas Huth
Hi! The following changes since commit cb88904a54903ef6ba21a68a61d9cd51e2166304: Merge remote-tracking branch 'remotes/amarkovic/tags/mips-queue-dec-16-2019' into staging (2019-12-16 14:07:56 +) are available in the Git repository at: https://gitlab.com/huth/qemu.git tags/pull-request

[PATCH v4 1/4] mem: move nvdimm_device_list to utilities

2019-12-17 Thread Shivaprasad G Bhat
nvdimm_device_list is required for parsing the list for devices in subsequent patches. Move it to common utility area. Signed-off-by: Shivaprasad G Bhat Reviewed-by: Igor Mammedov --- hw/acpi/nvdimm.c| 28 +--- include/qemu/nvdimm-utils.h |7 +++ ut

[PATCH v4 3/4] spapr: Add NVDIMM device support

2019-12-17 Thread Shivaprasad G Bhat
Add support for NVDIMM devices for sPAPR. Piggyback on existing nvdimm device interface in QEMU to support virtual NVDIMM devices for Power. Create the required DT entries for the device (some entries have dummy values right now). The patch creates the required DT node and sends a hotplug interrup

[PATCH v4 4/4] spapr: Add Hcalls to support PAPR NVDIMM device

2019-12-17 Thread Shivaprasad G Bhat
This patch implements few of the necessary hcalls for the nvdimm support. PAPR semantics is such that each NVDIMM device is comprising of multiple SCM(Storage Class Memory) blocks. The guest requests the hypervisor to bind each of the SCM blocks of the NVDIMM device using hcalls. There can be SCM

[PATCH v4 0/4] ppc: spapr: virtual NVDIMM support

2019-12-17 Thread Shivaprasad G Bhat
The patchset attempts to implement the virtual NVDIMM for pseries. PAPR semantics is such that each NVDIMM device is comprising of multiple SCM(Storage Class Memory) blocks. The hypervisor is expected to prepare the FDT for the NVDIMM device and send guest a hotplug interrupt with new type RTAS_LO

[PATCH v4 2/4] nvdimm: add uuid property to nvdimm

2019-12-17 Thread Shivaprasad G Bhat
For ppc64, PAPR requires the nvdimm device to have UUID property set in the device tree. Add an option to get it from the user. Signed-off-by: Shivaprasad G Bhat --- hw/mem/nvdimm.c | 40 include/hw/mem/nvdimm.h |7 +++ 2 files changed,

Re: [PATCH v3 2/6] hw/arm/smmuv3: Correct SMMU_BASE_ADDR_MASK value

2019-12-17 Thread Auger Eric
Hi Simon, On 12/16/19 4:15 PM, Simon Veith wrote: > There are two issues with the current value of SMMU_BASE_ADDR_MASK: > > - At the lower end, we are clearing bits [4:0]. Per the SMMUv3 spec, > we should also be treating bit 5 as zero in the base address. > - At the upper end, we are clearing

Re: [PATCH v3 3/6] hw/arm/smmuv3: Check stream IDs against actual table LOG2SIZE

2019-12-17 Thread Auger Eric
Hi Simon, On 12/16/19 4:15 PM, Simon Veith wrote: > When checking whether a stream ID is in range of the stream table, we > have so far been only checking it against our implementation limit > (SMMU_IDR1_SIDSIZE). However, the guest can program the > STRTAB_BASE_CFG.LOG2SIZE field to a size that i

Re: [PATCH] Semihost SYS_READC implementation (v6)

2019-12-17 Thread Paolo Bonzini
On 17/12/19 09:38, Alex Bennée wrote: > Thread 3 (Thread 0x7f8b1959e700 (LWP 14017)): > #0 0x7f8b2ada900c in futex_wait_cancelable (private=0, expected=0, > futex_word=0x56213f5482e8 ) at > ../sysdeps/unix/sysv/linux/futex-internal.h:88 > #1 0x7f8b2ada900c in __pthread_cond_wait_c

Re: [PATCH v10 Kernel 4/5] vfio iommu: Implementation of ioctl to for dirty pages tracking.

2019-12-17 Thread Kirti Wankhede
On 12/17/2019 10:45 AM, Yan Zhao wrote: On Tue, Dec 17, 2019 at 04:21:39AM +0800, Kirti Wankhede wrote: VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations: - Start unpinned pages dirty pages tracking while migration is active and device is running, i.e. during pre-copy phase. - Stop un

Re: [PATCH v3 4/6] hw/arm/smmuv3: Align stream table base address to table size

2019-12-17 Thread Auger Eric
Hi Simon, On 12/16/19 4:15 PM, Simon Veith wrote: > Per the specification, and as observed in hardware, the SMMUv3 aligns > the SMMU_STRTAB_BASE address to the size of the table by masking out the > respective least significant bits in the ADDR field. > > Apply this masking logic to our smmu_find

Re: [PATCH] Semihost SYS_READC implementation (v6)

2019-12-17 Thread Alex Bennée
Paolo Bonzini writes: > On 17/12/19 09:38, Alex Bennée wrote: >> Thread 3 (Thread 0x7f8b1959e700 (LWP 14017)): >> #0 0x7f8b2ada900c in futex_wait_cancelable (private=0, expected=0, >> futex_word=0x56213f5482e8 ) at >> ../sysdeps/unix/sysv/linux/futex-internal.h:88 >> #1 0x7f8b

Re: [PATCH v10 Kernel 4/5] vfio iommu: Implementation of ioctl to for dirty pages tracking.

2019-12-17 Thread Yan Zhao
On Tue, Dec 17, 2019 at 05:24:14PM +0800, Kirti Wankhede wrote: > > > On 12/17/2019 10:45 AM, Yan Zhao wrote: > > On Tue, Dec 17, 2019 at 04:21:39AM +0800, Kirti Wankhede wrote: > >> VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations: > >> - Start unpinned pages dirty pages tracking while mig

Re: [PATCH 0/2] target/s390x: Implement LOAD/STORE TO REAL ADDRESS inline

2019-12-17 Thread Cornelia Huck
On Wed, 11 Dec 2019 12:36:12 -0800 Richard Henderson wrote: > Found while working on other parts of cputlb, > this cleanup can be split out independently. > > > r~ > > > Richard Henderson (2): > target/s390x: Split out helper_per_store_real > target/s390x: Implement LOAD/STORE TO REAL ADD

Re: [PATCH v3 0/6] hw/arm/smmuv3: Correct stream ID and event address handling

2019-12-17 Thread Auger Eric
Hi, On 12/16/19 4:15 PM, Simon Veith wrote: > While working on the Linux SMMUv3 driver, I noticed a few cases where the QEMU > SMMUv3 behavior relating to stream tables was inconsistent with our hardware. > > Also, when debugging those differences, I found that the errors reported > through > th

Re: [PATCH] Semihost SYS_READC implementation (v6)

2019-12-17 Thread Paolo Bonzini
On 17/12/19 10:51, Alex Bennée wrote: >>> Secondly if the vCPU is paused (via console or gdbstub) we need to >>> unwind from our blocking position and be in a position to restart >>> cleanly. >> Perhaps if fifo8_is_empty(&c->fifo) the CPU could update the PC back to >> the SVC instruction and enter

Re: [PATCH] util/cutils: Expand do_strtosz parsing precision to 64 bits

2019-12-17 Thread Markus Armbruster
Tao Xu writes: > On 12/5/19 11:29 PM, Markus Armbruster wrote: >> Tao Xu writes: >> >>> Parse input string both as a double and as a uint64_t, then use the >>> method which consumes more characters. Update the related test cases. >>> >>> Signed-off-by: Tao Xu >>> --- >> [...] >>> diff --git a/u

Re: qemu-project git server not utf-8 clean?

2019-12-17 Thread Stefan Hajnoczi
On Mon, Dec 16, 2019 at 04:29:46PM +, Alex Bennée wrote: > > Hi, > > I was doing some housekeeping of the wiki links into the docs page and I > discovered my name getting corrupted for: > > > https://git.qemu.org/?p=qemu.git;a=blob_plain;f=docs/devel/tcg-plugins.rst;hb=HEAD > > Looking a

Re: [PATCH] virtio-blk: deprecate SCSI passthrough

2019-12-17 Thread Stefan Hajnoczi
On Fri, Dec 13, 2019 at 02:46:26PM +, Stefan Hajnoczi wrote: > The Linux virtio_blk.ko guest driver is removing legacy SCSI passthrough > support. Deprecate this feature in QEMU too. > > Signed-off-by: Stefan Hajnoczi > --- > qemu-deprecated.texi | 11 +++ > 1 file changed, 11 inser

Re: [PATCH] memory: Do not allow subregion out of the parent region range

2019-12-17 Thread Paolo Bonzini
On 16/12/19 18:46, Philippe Mathieu-Daudé wrote: >>> >> >> I think in some cases this could be intentional, for example if you have >> different models with different BAR sizes and you organize this with the >> same tree of MemoryRegion and different sizes for the parent. > > But if a child is out

Re: [PULL 00/62] Misc patches for 2019-12-16

2019-12-17 Thread Peter Maydell
On Mon, 16 Dec 2019 at 16:34, Paolo Bonzini wrote: > > The following changes since commit 084a398bf8aa7634738e6c6c0103236ee1b3b72f: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2019-12-13 18:14:07 +) > > are available in the git repository at:

Re: [PULL 00/62] Misc patches for 2019-12-16

2019-12-17 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Mon, 16 Dec 2019 at 16:34, Paolo Bonzini wrote: > > > > The following changes since commit 084a398bf8aa7634738e6c6c0103236ee1b3b72f: > > > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > > into staging (2019-12-1

Re: [PATCH RESEND v2] util/cutils: Expand do_strtosz parsing precision to 64 bits

2019-12-17 Thread Christophe de Dinechin
> On 9 Dec 2019, at 09:30, Tao Xu wrote: > > Parse input string both as a double and as a uint64_t, then use the > method which consumes more characters. Update the related test cases. > > Signed-off-by: Tao Xu > --- > > Changes in v2: >- Resend to use double small than DBL_MIN >- A

Re: [PATCH v10 Kernel 4/5] vfio iommu: Implementation of ioctl to for dirty pages tracking.

2019-12-17 Thread Kirti Wankhede
On 12/17/2019 3:21 PM, Yan Zhao wrote: On Tue, Dec 17, 2019 at 05:24:14PM +0800, Kirti Wankhede wrote: On 12/17/2019 10:45 AM, Yan Zhao wrote: On Tue, Dec 17, 2019 at 04:21:39AM +0800, Kirti Wankhede wrote: VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations: - Start unpinned pages dir

Re: [PULL 0/4] x86 queue, 2019-12-16

2019-12-17 Thread Peter Maydell
On Mon, 16 Dec 2019 at 19:38, Eduardo Habkost wrote: > > The following changes since commit 4148d142a8cbbce10bb77e560997ae6b482e5edf: > > Merge remote-tracking branch > 'remotes/dgilbert/tags/pull-virtiofs-20191213a' into staging (2019-12-13 > 15:58:54 +) > > are available in the Git repos

Re: [PATCH] memory: Do not allow subregion out of the parent region range

2019-12-17 Thread Christophe de Dinechin
> On 17 Dec 2019, at 11:51, Paolo Bonzini wrote: > > On 16/12/19 18:46, Philippe Mathieu-Daudé wrote: >>> >>> I think in some cases this could be intentional, for example if you have >>> different models with different BAR sizes and you organize this with the >>> same tree of MemoryRegi

Re: [PATCH] util/cutils: Expand do_strtosz parsing precision to 64 bits

2019-12-17 Thread Christophe de Dinechin
> On 5 Dec 2019, at 16:29, Markus Armbruster wrote: > > Tao Xu writes: > >> Parse input string both as a double and as a uint64_t, then use the >> method which consumes more characters. Update the related test cases. >> >> Signed-off-by: Tao Xu >> --- > [...] >> diff --git a/util/cutils.c

os_mem_prealloc questions

2019-12-17 Thread jack.chen
hello: I found os_mem_prealloc prealloc memory by multiple threads ,and max threads number is 16,I want do know the reason,why do not use smp_cpus? (in fact,I also found smp_cpus can not reduce more start time,I just want to know the reasion) thanks!

[RFC PATCH] semihosting: suspend recieving CPU when blocked (HACK, WIP)

2019-12-17 Thread Alex Bennée
Sleeping in the semihosting code is problematic as we deadlock the whole system. This includes issuing a "quit" via the HMP or presumably if gdbserver got involved. What we really want is to return to the main loop and gt woken up when there is data to process. We can then re-execute the instructio

Re: [RFC PATCH] semihosting: suspend recieving CPU when blocked (HACK, WIP)

2019-12-17 Thread Paolo Bonzini
On 17/12/19 13:14, Alex Bennée wrote: > [AJB: > > So this at least solves the hang of not being able to quit system > emulation while blocked. However there are two things we still need to > ensure: > > - the PC has not advanced until completion so we can redo the instruction > - we actually wa

Re: [PATCH v3 4/4] pc-bios/s390x: Fix reset psw mask

2019-12-17 Thread Thomas Huth
On 13/12/2019 13.06, Cornelia Huck wrote: > On Thu, 5 Dec 2019 11:12:39 +0100 > Cornelia Huck wrote: > >> On Tue, 3 Dec 2019 08:28:13 -0500 >> Janosch Frank wrote: >> >>> We need to set the short psw indication bit in the reset psw, as it is >>> a short psw. >>> >>> fixes: 9629823290 ("pc-bios/

[Bug 1851552] Re: since ubuntu 18 bionic release and latest, the ubuntu18 cloud image is unable to boot up on openstack instance

2019-12-17 Thread Launchpad Bug Tracker
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: cloud-init (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1851552 Title:

[Bug 1851552] Re: since ubuntu 18 bionic release and latest, the ubuntu18 cloud image is unable to boot up on openstack instance

2019-12-17 Thread Vasili
** Also affects: cloud-init Importance: Undecided Status: New ** Also affects: openstack-community Importance: Undecided Status: New ** Also affects: qemu Importance: Undecided Status: New ** Also affects: qemu-kvm Importance: Undecided Status: New ** Als

[Bug 1851552] Re: since ubuntu 18 bionic release and latest, the ubuntu18 cloud image is unable to boot up on openstack instance

2019-12-17 Thread Vasili
** Also affects: nova Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1851552 Title: since ubuntu 18 bionic release and latest, the ubuntu18 cloud image is

[PATCH V4 2/5] net/awd.c: Initailize input/output chardev

2019-12-17 Thread Zhang Chen
From: Zhang Chen Find and check the chardev awd_node and notification_node, The awd_node used for keep connect with outside(like VM client/other host/Remote server), and the notification_node used for do some operation when disconnect event occur. Signed-off-by: Zhang Chen --- net/awd.c | 37 +

[PATCH V4 4/5] vl.c: Make Advanced Watch Dog delayed initialization

2019-12-17 Thread Zhang Chen
From: Zhang Chen Advanced Watch Dog module needs chardev socket to initialize properly before running. Signed-off-by: Zhang Chen --- vl.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/vl.c b/vl.c index 6a65a64bfd..048fe458b9 100644 --- a/vl.c +++ b/vl.c @@ -2689,6 +2689,13 @@ stat

[PATCH V4 3/5] net/awd.c: Load advanced watch dog worker thread job

2019-12-17 Thread Zhang Chen
From: Zhang Chen This patch load pulse_timer and timeout_timer in the new iothread. The pulse timer will send pulse info to awd_node, and the timeout timer will check the reply pulse from awd_node. If timeout occur, it will send opt_script's data to the notification_node. Signed-off-by: Zhang Ch

[PATCH V4 0/5] Introduce Advanced Watch Dog module

2019-12-17 Thread Zhang Chen
From: Zhang Chen Advanced Watch Dog is an universal monitoring module on VMM side, it can be used to detect network down(VMM to guest, VMM to VMM, VMM to another remote server) and do previously set operation. Current AWD patch just accept any input as the signal to refresh the watchdog timer, an

[PATCH V4 5/5] docs/awd.txt: Add doc to introduce Advanced WatchDog(AWD) module

2019-12-17 Thread Zhang Chen
From: Zhang Chen Add docs to introduce Advanced WatchDog detail and usage. Signed-off-by: Zhang Chen --- docs/awd.txt | 88 1 file changed, 88 insertions(+) create mode 100644 docs/awd.txt diff --git a/docs/awd.txt b/docs/awd.txt new file

[PATCH V4 1/5] net/awd.c: Introduce Advanced Watch Dog module framework

2019-12-17 Thread Zhang Chen
From: Zhang Chen This patch introduce a new module named Advanced Watch Dog, and defined the input and output parameter. AWD use standard chardev as the way of communicationg with the outside world. If you want to use it, please add "--enable-awd" when configure qemu. Demo command: -object adva

Re: [virtio-dev] Re: guest / host buffer sharing ...

2019-12-17 Thread David Stevens
> > > Of course only virtio drivers would try step (2), other drivers (when > > > sharing buffers between intel gvt device and virtio-gpu for example) > > > would go straight to (3). > > > > For virtio-gpu as it is today, it's not clear to me that they're > > equivalent. As I read it, the virtio-gp

Re: [PULL 34/34] nbd: assert that Error** is not NULL in nbd_iter_channel_error

2019-12-17 Thread Eric Blake
On 12/17/19 12:26 AM, Markus Armbruster wrote: From: Vladimir Sementsov-Ogievskiy All callers of nbd_iter_channel_error() pass the address of a local_err variable, and only call this function if an error has already occurred, using this function to propagate that error. This is already implied

Re: [PATCH RFC] qapi: Allow getting flat output from 'query-named-block-nodes'

2019-12-17 Thread Eric Blake
On 12/17/19 1:36 AM, Markus Armbruster wrote: Un-snipping the QAPI schema change: Sorry about that... diff --git a/qapi/block-core.json b/qapi/block-core.json index 0cf68fea14..bd651106bd 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -1752,6 +1752,8 @@ # # Get the nam

Re: [PATCH] blockjob: Fix error message for negative speed

2019-12-17 Thread Max Reitz
On 26.11.19 14:42, Kevin Wolf wrote: > The error message for a negative speed uses QERR_INVALID_PARAMETER, > which implies that the 'speed' option doesn't even exist: > > {"error": {"class": "GenericError", "desc": "Invalid parameter 'speed'"}} > > Make it use QERR_INVALID_PARAMETER_VALUE ins

[Bug 1856706] [NEW] target/mips/op_helper.c:971:duplicated branches ?

2019-12-17 Thread dcb
Public bug reported: qemu-4.2.0/target/mips/op_helper.c:971:8: warning: this condition has identical branches [-Wduplicated-branches] Source code is if (other_tc == other->current_tc) { tccause = other->CP0_Cause; } else { tccause = other->CP0_Cause; } Possible cut'n'

Re: [RFC PATCH] semihosting: suspend recieving CPU when blocked (HACK, WIP)

2019-12-17 Thread Alex Bennée
Paolo Bonzini writes: > On 17/12/19 13:14, Alex Bennée wrote: >> [AJB: >> >> So this at least solves the hang of not being able to quit system >> emulation while blocked. However there are two things we still need to >> ensure: >> >> - the PC has not advanced until completion so we can redo

Re: [RFC PATCH] semihosting: suspend recieving CPU when blocked (HACK, WIP)

2019-12-17 Thread Paolo Bonzini
On 17/12/19 14:42, Alex Bennée wrote: >> Why do you need to set exception_index to something other than -1 (using >> cpu_loop_exit_noexc for example)? > If there is no exception to process we won't exit the main loop which we > need to do if we want to wait until there is data to read. Okay. >> U

Re: [PATCH] util/cutils: Expand do_strtosz parsing precision to 64 bits

2019-12-17 Thread Markus Armbruster
Christophe de Dinechin writes: >> On 5 Dec 2019, at 16:29, Markus Armbruster wrote: >> >> Tao Xu writes: >> >>> Parse input string both as a double and as a uint64_t, then use the >>> method which consumes more characters. Update the related test cases. >>> >>> Signed-off-by: Tao Xu >>> ---

Vote against removing the bluetooth subsystem from Quemu.

2019-12-17 Thread Andreas Scheucher
Hello,   I found following note in the Qemu documentation: This option and the whole bluetooth subsystem is considered as deprecated. If you still use it, please send a mail to qemu-devel@nongnu.org  where you describe your usecase.   Here I am :)   As GPU passt

Re: [PATCH] util/cutils: Expand do_strtosz parsing precision to 64 bits

2019-12-17 Thread Christophe de Dinechin
> On 17 Dec 2019, at 15:08, Markus Armbruster wrote: > > Christophe de Dinechin writes: > >>> On 5 Dec 2019, at 16:29, Markus Armbruster wrote: >>> >>> Tao Xu writes: >>> Parse input string both as a double and as a uint64_t, then use the method which consumes more characters.

bdrv_co_pwritev: Assertion `!waited || !use_local_qiov' failed.

2019-12-17 Thread Peter Lieven
Hi all, I have a vserver running Qemu 4.0 that seems to reproducibly hit the following assertion:  bdrv_co_pwritev: Assertion `!waited || !use_local_qiov' failed. I noticed that the padding code was recently reworked in commit 2e2ad02f2c. In the new code I cannot find a similar assertion. W

Re: Vote against removing the bluetooth subsystem from Quemu.

2019-12-17 Thread Peter Maydell
On Tue, 17 Dec 2019 at 14:13, Andreas Scheucher wrote: > I found following note in the Qemu documentation: This option and the whole > bluetooth subsystem is considered as deprecated. If you still use it, please > send a mail to qemu-devel@nongnu.org where you describe your usecase. > As GPU pa

Re: [RFC PATCH] semihosting: suspend recieving CPU when blocked (HACK, WIP)

2019-12-17 Thread Alex Bennée
Paolo Bonzini writes: > On 17/12/19 14:42, Alex Bennée wrote: >>> Why do you need to set exception_index to something other than -1 (using >>> cpu_loop_exit_noexc for example)? >> If there is no exception to process we won't exit the main loop which we >> need to do if we want to wait until the

Re: Vote against removing the bluetooth subsystem from Quemu.

2019-12-17 Thread Christophe de Dinechin
> On 17 Dec 2019, at 15:11, Andreas Scheucher > wrote: > > Hello, > > I found following note in the Qemu documentation: This option and the whole > bluetooth subsystem is considered as deprecated. If you still use it, please > send a mail to qemu-devel@nongnu.org where you describe your u

[PATCH] target/ppc: Handle AIL=0 in ppc_excp_vector_offset

2019-12-17 Thread Fabiano Rosas
The exception vector offset calculation was moved into a function but the case when AIL=0 was not checked. The reason we got away with this is that the sole caller of ppc_excp_vector_offset checks the AIL before calling the function: /* Handle AIL */ if (ail) { ... vector

Re: [PATCH v3 00/22] iotests: Allow ./check -o data_file

2019-12-17 Thread Max Reitz
On 07.11.19 17:36, Max Reitz wrote: > Hi, > > The cover letter from v1 (explaining the motivation behind this series > and the general structure) is here: > > https://lists.nongnu.org/archive/html/qemu-block/2019-09/msg01323.html > > > For v2, I’ve addressed more of Maxim’s comments: > - Patch

Re: [PULL 00/88] ppc-for-5.0 queue 20191217

2019-12-17 Thread Peter Maydell
> > are available in the Git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-5.0-20191217 > > for you to fetch changes up to a363e9ed8731f45674260932a340a0d81c4b0a6f: > > pseries: Update SLOF firmware image (2019-12-17 11:40:23 +1100) > >

Re: [RFC PATCH] semihosting: suspend recieving CPU when blocked (HACK, WIP)

2019-12-17 Thread Paolo Bonzini
On 17/12/19 15:18, Alex Bennée wrote: > > Paolo Bonzini writes: > >> On 17/12/19 14:42, Alex Bennée wrote: Why do you need to set exception_index to something other than -1 (using cpu_loop_exit_noexc for example)? >>> If there is no exception to process we won't exit the main loop whic

Re: [RFC PATCH] semihosting: suspend recieving CPU when blocked (HACK, WIP)

2019-12-17 Thread Paolo Bonzini
On 17/12/19 15:18, Alex Bennée wrote: > > Paolo Bonzini writes: > >> On 17/12/19 14:42, Alex Bennée wrote: Why do you need to set exception_index to something other than -1 (using cpu_loop_exit_noexc for example)? >>> If there is no exception to process we won't exit the main loop whic

[PATCH 1/3] block: Activate recursively even for already active nodes

2019-12-17 Thread Kevin Wolf
bdrv_invalidate_cache_all() assumes that all nodes in a given subtree are either active or inactive when it starts. Therefore, as soon as it arrives at an already active node, it stops. However, this assumption is wrong. For example, it's possible to take a snapshot of an inactive node, which resu

[PATCH 2/3] hmp: Allow using qdev ID for qemu-io command

2019-12-17 Thread Kevin Wolf
In order to issue requests on an existing BlockBackend with the 'qemu-io' HMP command, allow specifying the BlockBackend not only with a BlockBackend name, but also with a qdev ID/QOM path for a device that owns the (possibly anonymous) BlockBackend. Because qdev names could be conflicting with Bl

[PATCH 3/3] iotests: Test external snapshot with VM state

2019-12-17 Thread Kevin Wolf
This tests creating an external snapshot with VM state (which results in an active overlay over an inactive backing file, which is also the root node of an inactive BlockBackend), re-activating the images and performing some operations to test that the re-activation worked as intended. Signed-off-

Re: [PATCH] util/cutils: Expand do_strtosz parsing precision to 64 bits

2019-12-17 Thread Markus Armbruster
Christophe de Dinechin writes: >> On 17 Dec 2019, at 15:08, Markus Armbruster wrote: >> >> Christophe de Dinechin writes: >> On 5 Dec 2019, at 16:29, Markus Armbruster wrote: Tao Xu writes: > Parse input string both as a double and as a uint64_t, then use the >

[PATCH 0/3] block: Fix external snapshot with VM state

2019-12-17 Thread Kevin Wolf
This fixes bdrv_invalidate_cache_all() for some kinds of graphs where part of the nodes are active and others are inactive. This is a scenario that happens when libvirt takes an external snapshot with VM state. This was reported in: https://bugzilla.redhat.com/show_bug.cgi?id=1781637 ('qemu crashe

[PATCH v2] blockjob: Fix error message for negative speed

2019-12-17 Thread Kevin Wolf
The error message for a negative speed uses QERR_INVALID_PARAMETER, which implies that the 'speed' option doesn't even exist: {"error": {"class": "GenericError", "desc": "Invalid parameter 'speed'"}} Make it use QERR_INVALID_PARAMETER_VALUE instead: {"error": {"class": "GenericError", "d

[PATCH] tests/boot-sector: Fix the bad s390x assembler code

2019-12-17 Thread Thomas Huth
There are currently two bugs in s390x_code[]: First, the initial jump uses the wrong offset, so it was jumping to 0x1014 instead of 0x1010. Second, LHI only loads the lower 32-bit of the register. Everything worked fine as long as the s390-ccw bios code was jumping here with r3 containing zeroes i

Re: [PATCH v3 4/4] pc-bios/s390x: Fix reset psw mask

2019-12-17 Thread Thomas Huth
On 17/12/2019 13.36, Thomas Huth wrote: > On 13/12/2019 13.06, Cornelia Huck wrote: >> On Thu, 5 Dec 2019 11:12:39 +0100 >> Cornelia Huck wrote: >> >>> On Tue, 3 Dec 2019 08:28:13 -0500 >>> Janosch Frank wrote: >>> We need to set the short psw indication bit in the reset psw, as it is

Re: [PATCH RFC] qapi: Allow getting flat output from 'query-named-block-nodes'

2019-12-17 Thread Markus Armbruster
Eric Blake writes: > On 12/17/19 1:36 AM, Markus Armbruster wrote: > >> Un-snipping the QAPI schema change: > > Sorry about that... > >> diff --git a/qapi/block-core.json b/qapi/block-core.json index 0cf68fea14..bd651106bd 100644 --- a/qapi/block-core.json +++ b/qapi/block-cor

Re: [PATCH v3 0/6] hw/arm/smmuv3: Correct stream ID and event address handling

2019-12-17 Thread Peter Maydell
On Tue, 17 Dec 2019 at 10:04, Auger Eric wrote: > > Hi, > > On 12/16/19 4:15 PM, Simon Veith wrote: > > While working on the Linux SMMUv3 driver, I noticed a few cases where the > > QEMU > > SMMUv3 behavior relating to stream tables was inconsistent with our > > hardware. > > > > Also, when debu

Re: [PATCH v3 0/4] Expose GT CNTFRQ as a CPU property to support AST2600

2019-12-17 Thread Peter Maydell
On Fri, 13 Dec 2019 at 05:48, Andrew Jeffery wrote: > > Hello, > > This is a v3 of the belated follow-up from a few of my earlier attempts to fix > up the ARM generic timer for correct behaviour on the ASPEED AST2600 SoC. The > AST2600 clocks the generic timer at the rate of HPLL, which is configu

Re: [PULL 00/15] Python queue 2019-12-17

2019-12-17 Thread Peter Maydell
On Tue, 17 Dec 2019 at 05:15, Cleber Rosa wrote: > > The following changes since commit 856ffa6465ad38a31603223eb057a253114ceaea: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20191216-1' into staging (2019-12-16 > 13:04:34 +) > > are available in the Git reposi

Re: Vote against removing the bluetooth subsystem from Quemu.

2019-12-17 Thread Thomas Huth
On 17/12/2019 15.17, Peter Maydell wrote: > On Tue, 17 Dec 2019 at 14:13, Andreas Scheucher > wrote: >> I found following note in the Qemu documentation: This option and the whole >> bluetooth subsystem is considered as deprecated. If you still use it, please >> send a mail to qemu-devel@nongnu.

Re: [PATCH v1 03/16] travis.yml: Run tcg tests with tci

2019-12-17 Thread Richard Henderson
On 12/16/19 1:07 AM, Alex Bennée wrote: > From: Thomas Huth > > So far we only have compile coverage for tci. But since commit > 2f160e0f9797c7522bfd0d09218d0c9340a5137c ("tci: Add implementation > for INDEX_op_ld16u_i64") has been included now, we can also run the > "tcg" and "qtest" tests with

[Bug 1856724] [NEW] SB.PCI0.SMB0 device drivers unavailable

2019-12-17 Thread Rafal Kupiec
Public bug reported: QEMU 4.2 introduces new device with this code: static void build_smb0(Aml *table, I2CBus *smbus, int devnr, int func) { Aml *scope = aml_scope("_SB.PCI0"); Aml *dev = aml_device("SMB0"); aml_append(dev, aml_name_decl("_HID", aml_eisaid("APP0005"))); aml_appen

Re: [PULL 00/34] Error reporting patches for 2019-12-16

2019-12-17 Thread Peter Maydell
On Tue, 17 Dec 2019 at 06:33, Markus Armbruster wrote: > > The following changes since commit cb88904a54903ef6ba21a68a61d9cd51e2166304: > > Merge remote-tracking branch > 'remotes/amarkovic/tags/mips-queue-dec-16-2019' into staging (2019-12-16 > 14:07:56 +) > > are available in the Git rep

Re: bdrv_co_pwritev: Assertion `!waited || !use_local_qiov' failed.

2019-12-17 Thread Kevin Wolf
Am 17.12.2019 um 15:14 hat Peter Lieven geschrieben: > I have a vserver running Qemu 4.0 that seems to reproducibly hit the > following assertion: > >  bdrv_co_pwritev: Assertion `!waited || !use_local_qiov' failed. > > I noticed that the padding code was recently reworked in commit > 2e2ad02f2c.

Re: [PULL 0/6] QAPI patches for 2019-12-17

2019-12-17 Thread Peter Maydell
On Tue, 17 Dec 2019 at 08:16, Markus Armbruster wrote: > > The following changes since commit cb88904a54903ef6ba21a68a61d9cd51e2166304: > > Merge remote-tracking branch > 'remotes/amarkovic/tags/mips-queue-dec-16-2019' into staging (2019-12-16 > 14:07:56 +) > > are available in the Git rep

Re: [PATCH] target/arm: Display helpful message when hflags mismatch

2019-12-17 Thread Richard Henderson
On Mon, 9 Dec 2019 at 03:46, Philippe Mathieu-Daudé wrote: > > Instead of crashing in a confuse way, give some hint to the user > about why we aborted. He might report the issue without having > to use a debugger. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/arm/helper.c | 18 +++

Re: [PATCH v6 4/4] hw/arm: Add the Netduino Plus 2

2019-12-17 Thread Peter Maydell
On Sat, 14 Dec 2019 at 02:44, Alistair Francis wrote: > > Signed-off-by: Alistair Francis > --- > MAINTAINERS| 6 + > hw/arm/Kconfig | 3 +++ > hw/arm/Makefile.objs | 1 + > hw/arm/netduinoplus2.c | 52 ++ > 4 files changed, 62

Re: [PATCH] target/arm: Display helpful message when hflags mismatch

2019-12-17 Thread Peter Maydell
On Tue, 17 Dec 2019 at 16:02, Richard Henderson wrote: > > On Mon, 9 Dec 2019 at 03:46, Philippe Mathieu-Daudé wrote: > > > > Instead of crashing in a confuse way, give some hint to the user > > about why we aborted. He might report the issue without having > > to use a debugger. > > > > Signed-o

Re: [PATCH] target/arm: Display helpful message when hflags mismatch

2019-12-17 Thread Philippe Mathieu-Daudé
On 12/17/19 5:08 PM, Peter Maydell wrote: On Tue, 17 Dec 2019 at 16:02, Richard Henderson wrote: On Mon, 9 Dec 2019 at 03:46, Philippe Mathieu-Daudé wrote: Instead of crashing in a confuse way, give some hint to the user about why we aborted. He might report the issue without having to use

Re: [PATCH v2 06/10] arm/arm-powerctl: rebuild hflags after setting CP15 bits in arm_set_cpu_on()

2019-12-17 Thread Peter Maydell
Cc'ing Richard : this is one for you I think... (surely we need to rebuild the hflags from scratch when we power up a CPU anyway?) thanks -- PMM On Mon, 16 Dec 2019 at 23:44, Niek Linnenbank wrote: > > Hello Peter, > > In the previous version of this patch series I included the fix for setting

Re: [Bug 1856706] [NEW] target/mips/op_helper.c:971:duplicated branches ?

2019-12-17 Thread Thomas Huth
On 17/12/2019 14.25, dcb wrote: > Public bug reported: > > qemu-4.2.0/target/mips/op_helper.c:971:8: warning: this condition has > identical branches [-Wduplicated-branches] > > Source code is > >if (other_tc == other->current_tc) { > tccause = other->CP0_Cause; > } else { >

[Bug 1851552] Re: since ubuntu 18 bionic release and latest, the ubuntu18 cloud image is unable to boot up on openstack instance

2019-12-17 Thread Thomas Huth
** Project changed: qemu => qemu (Ubuntu) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1851552 Title: since ubuntu 18 bionic release and latest, the ubuntu18 cloud image is unable to boot up on

Re: [RFC v4 PATCH 00/49] Initial support of multi-process qemu - status update

2019-12-17 Thread Stefan Hajnoczi
On Mon, Dec 16, 2019 at 07:57:32PM +, Felipe Franciosi wrote: > > On 16 Dec 2019, at 20:47, Elena Ufimtseva > > wrote: > > On Fri, Dec 13, 2019 at 10:41:16AM +, Stefan Hajnoczi wrote: > >> Is there a work-in-progress muser patch series you can post to start the > >> discussion early? Th

Re: [PATCH] docs: fix rst syntax errors in unbuilt docs

2019-12-17 Thread Stefan Hajnoczi
On Mon, Nov 11, 2019 at 09:44:11AM +, Stefan Hajnoczi wrote: > The .rst files outside docs/{devel,interop,specs} aren't built yet and > therefore a few syntax errors have slipped through. Fix them. > > Signed-off-by: Stefan Hajnoczi > Reviewed-by: Daniel P. Berrangé > --- > Sent as a separa

Re: [PATCH v2] docs: build an index page for the HTML docs

2019-12-17 Thread Stefan Hajnoczi
On Mon, Nov 11, 2019 at 10:21:57AM +, Stefan Hajnoczi wrote: > There is no index.html start page for the QEMU HTML documentation. An > index page is needed so that documentation can be browsed easily on the > web. > > This patch adds an index.html.in template file where the QEMU version > num

[PATCH 00/14] chardev: Use QEMUChrEvent enum in IOEventHandler typedef

2019-12-17 Thread Philippe Mathieu-Daudé
Hi, After this chat on #qemu IRC: 13:20 so what is the difference between a IOReadHandler and IOEventHandler? 13:25 stsquad: one is in-band and the other out-of-band? 13:26 f4bug: ahh yes it seems so - connect/disconnect etc... 13:27 see QEMUChrEvent for IOEventHandler I thought it might be

Re: bdrv_co_pwritev: Assertion `!waited || !use_local_qiov' failed.

2019-12-17 Thread Peter Lieven
Am 17.12.19 um 16:52 schrieb Kevin Wolf: Am 17.12.2019 um 15:14 hat Peter Lieven geschrieben: I have a vserver running Qemu 4.0 that seems to reproducibly hit the following assertion:  bdrv_co_pwritev: Assertion `!waited || !use_local_qiov' failed. I noticed that the padding code was recently

[RFC PATCH 02/14] chardev/char: Explicit we ignore some QEMUChrEvent in IOEventHandler

2019-12-17 Thread Philippe Mathieu-Daudé
The Chardev events are listed in the QEMUChrEvent enum. To be able to use this enum in the IOEventHandler typedef, we need to explicit when frontends ignore some events, to silent GCC the following warnings: chardev/char.c: In function ‘qemu_chr_be_event’: chardev/char.c:65:5: error: enumerati

[RFC PATCH 04/14] virtio-console: Explicit we ignore some QEMUChrEvent in IOEventHandler

2019-12-17 Thread Philippe Mathieu-Daudé
The Chardev events are listed in the QEMUChrEvent enum. To be able to use this enum in the IOEventHandler typedef, we need to explicit when frontends ignore some events, to silent GCC the following warnings: CC hw/char/virtio-console.o hw/char/virtio-console.c: In function ‘chr_event’:

[RFC PATCH 03/14] vhost-user: Explicit we ignore some QEMUChrEvent in IOEventHandler

2019-12-17 Thread Philippe Mathieu-Daudé
The Chardev events are listed in the QEMUChrEvent enum. To be able to use this enum in the IOEventHandler typedef, we need to explicit when frontends ignore some events, to silent GCC the following warnings: CC backends/cryptodev-vhost-user.o backends/cryptodev-vhost-user.c: In function

  1   2   3   >