[PULL 21/34] 9pfs: make Error **errp const where it is appropriate

From: Vladimir Sementsov-Ogievskiy Mostly, Error ** is for returning error from the function, so the callee sets it. However error_append_security_model_hint and error_append_socket_sockfd_hint get already filled errp parameter. They don't change the pointer itself, only change the internal state

[PULL 29/34] hw/tpm: rename Error ** parameter to more common errp

From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Stefan Berger Message-Id: <20191205174635.18758-17-vsement...@virtuozzo.com> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Markus Armbruster --- hw/tpm/tpm_emulator.c | 8 1 file changed

[PULL 23/34] block/snapshot: rename Error ** parameter to more common errp

From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Message-Id: <20191205174635.18758-11-vsement...@virtuozzo.com> Signed-off-by: Markus Armbruster --- include/block/snapshot.h | 2 +- block/snapshot.c | 4 ++-- 2 files changed, 3 ins

[PULL 20/34] ppc: make Error **errp const where it is appropriate

From: Vladimir Sementsov-Ogievskiy Mostly, Error ** is for returning error from the function, so the callee sets it. However kvmppc_hint_smt_possible gets already filled errp parameter. It doesn't change the pointer itself, only change the internal state of referenced Error object. So we can make

[PULL 34/34] nbd: assert that Error** is not NULL in nbd_iter_channel_error

From: Vladimir Sementsov-Ogievskiy All callers of nbd_iter_channel_error() pass the address of a local_err variable, and only call this function if an error has already occurred, using this function to propagate that error. This is already implied by its name (local_err instead of the classic err

[PULL 17/34] hmp: drop Error pointer indirection in hmp_handle_error

From: Vladimir Sementsov-Ogievskiy We don't need Error **, as all callers pass local Error object, which isn't used after the call. Use Error * instead. Signed-off-by: Vladimir Sementsov-Ogievskiy Acked-by: Dr. David Alan Gilbert Reviewed-by: Markus Armbruster Message-Id: <20191205174635.1875

[PULL 30/34] hw/usb: rename Error ** parameter to more common errp

From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20191205174635.18758-18-vsement...@virtuozzo.com> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Markus Armbruster --- hw/usb/dev-network.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

Re: [PATCH 11/21] hw/ipmi: Fix latent realize() error handling bugs

Corey Minyard writes: > On Mon, Dec 16, 2019 at 10:20:04AM +0100, Markus Armbruster wrote: >> Corey Minyard writes: >> >> I've since posted v2 with a revamped commit message, and I'm ready to >> post a pull request. I really want the whole thing committed before the >> Christmas break, so Vlad

[PULL 27/34] hw/s390x: rename Error ** parameter to more common errp

From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Cornelia Huck Message-Id: <20191205174635.18758-15-vsement...@virtuozzo.com> Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: David Hildenbrand Signed-off-by: Markus Armbruster --- hw/s390x/event-fac

[PULL 25/34] qga: rename Error ** parameter to more common errp

From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20191205174635.18758-13-vsement...@virtuozzo.com> Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- qga/commands-posix.c | 2 +- qga/commands-win

Re: [PULL 51/88] ppc: well form kvmppc_hint_smt_possible error hint helper

David Gibson writes: > From: Vladimir Sementsov-Ogievskiy > > Make kvmppc_hint_smt_possible hint append helper well formed: > rename errp to errp_in, as it is IN-parameter here (which is unusual > for errp), rename function to be kvmppc_error_append_*_hint. > > Signed-off-by: Vladimir Sementsov-

Re: [PATCH RESEND v2] util/cutils: Expand do_strtosz parsing precision to 64 bits

Gentle ping. On 12/9/2019 4:30 PM, Xu, Tao3 wrote: Parse input string both as a double and as a uint64_t, then use the method which consumes more characters. Update the related test cases. Signed-off-by: Tao Xu --- Changes in v2: - Resend to use double small than DBL_MIN - Add more

Re: [PATCH] configure: Use lld --image-base for --disable-pie user mode binaries

On 2019-12-09, Fangrui Song wrote: On 2019-12-01, Fangrui Song wrote: Thanks for reviewing this patch! On 2019-12-01, Richard Henderson wrote: On 11/27/19 6:36 PM, Fangrui Song wrote: On 2019-11-20, Fangrui Song wrote: On 2019-11-15, Fangrui Song wrote: For lld, --image-base is the preferr

Re: [PATCH v10 Kernel 1/5] vfio: KABI for migration interface for device state

On Tue, Dec 17, 2019 at 02:28:44PM +0800, Kirti Wankhede wrote: > > > On 12/17/2019 4:14 AM, Alex Williamson wrote: > > On Tue, 17 Dec 2019 01:51:36 +0530 > > Kirti Wankhede wrote: > > > >> - Defined MIGRATION region type and sub-type. > >> > >> - Defined vfio_device_migration_info structure wh

Re: [PATCH v2 02/10] hw: arm: add Xunlong Orange Pi PC machine

Hi Niek, On 12/17/19 12:35 AM, Niek Linnenbank wrote: The Xunlong Orange Pi PC is an Allwinner H3 System on Chip based embedded computer with mainline support in both U-Boot and Linux. The board comes with a Quad Core Cortex A7 @ 1.3GHz, 512MB RAM, 100Mbit ethernet, USB, SD/MMC, USB, HDMI and va

Re: [PATCH RFC] qapi: Allow getting flat output from 'query-named-block-nodes'

Eric Blake writes: > On 12/13/19 8:11 AM, Peter Krempa wrote: >> When a management application manages node names there's no reason to >> recurse into backing images in the output of query-named-block-nodes. >> >> Add a parameter to the command which will return just the top level >> structs. > >

Re: [PATCH v2 08/10] arm: allwinner-h3: add Security Identifier device

Hi Niek, On 12/17/19 12:35 AM, Niek Linnenbank wrote: The Security Identifier device in Allwinner H3 System on Chip gives applications a per-board unique identifier. This commit adds support for the Allwinner H3 Security Identifier using a 128-bit UUID value as input. Signed-off-by: Niek Linnen

Re: [PULL 3/4] i386: Add new CPU model Cooperlake

On 12/17/19 3:26 AM, Xiaoyao Li wrote: On 12/17/2019 3:38 AM, Eduardo Habkost wrote: From: Cathy Zhang Cooper Lake is intel's successor to Cascade Lake, the new CPU model inherits features from Cascadelake-Server, while add one platform associated new feature: AVX512_BF16. Meanwhile, add STIBP

<    1   2   3   4   5   6