Re: [PATCH v1 0/5] target/arm/kvm: Provide an option to adjust virtual time

2019-12-11 Thread Guoheyi
在 2019/12/6 23:22, Peter Maydell 写道: On Wed, 16 Oct 2019 at 15:34, Andrew Jones wrote: v2: - move from RFC status to v1 - put kvm_arm_vm_state_change() in kvm.c to share among kvm32.c and kvm64.c - add r-b's from Richard This series is inspired by a series[1] posted by Bijan Mottahede

Re: [PATCH v3 2/3] spapr: Add NVDIMM device support

2019-12-11 Thread Igor Mammedov
On Wed, 11 Dec 2019 09:44:11 +0530 Shivaprasad G Bhat wrote: > On 12/06/2019 07:22 AM, David Gibson wrote: > > On Wed, Nov 27, 2019 at 09:50:54AM +0530, Bharata B Rao wrote: > >> On Fri, Nov 22, 2019 at 10:42 AM David Gibson > >> wrote: > >>> Ok. A number of queries about this. > >>> > >>>

Re: [bugfix ping2] Re: [PATCH v2 0/2] fix qcow2_can_store_new_dirty_bitmap

2019-12-11 Thread Vladimir Sementsov-Ogievskiy
10.12.2019 23:27, John Snow wrote: > > > On 12/10/19 8:24 AM, Max Reitz wrote: >> On 10.12.19 09:11, Max Reitz wrote: >>> On 09.12.19 23:03, Eric Blake wrote: On 12/9/19 11:58 AM, Max Reitz wrote: > On 09.12.19 17:30, Max Reitz wrote: >> On 02.12.19 15:09, Vladimir Sementsov-Ogievski

Insufficiently documented deprecated command arguments

2019-12-11 Thread Markus Armbruster
I went through the QAPI schema looking for deprecated stuff not mentioned in qemu-deprecated.texi. Here's what I found: Commit b33945cfff "block: Accept device model name for blockdev-open/close-tray" (v2.8.0) deprecated blockdev-open-tray, blockdev-close-tray argument @device. C

Re: [PATCH] vhost-user-test: fix a memory leak

2019-12-11 Thread Marc-André Lureau
Hi On Wed, Dec 11, 2019 at 11:57 AM Thomas Huth wrote: > > Hi! > > On 11/12/2019 01.55, pannengy...@huawei.com wrote: > [...] > > diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c > > index 91ea373..54be931 100644 > > --- a/tests/vhost-user-test.c > > +++ b/tests/vhost-user-test.c >

[PATCH 2/2] ppc/pnv: Fix OCC common area region mapping

2019-12-11 Thread Cédric Le Goater
The OCC common area is mapped at a unique address on the system and each OCC is assigned a segment to expose its sensor data : - | Start (Offset from | End | Size |Description| | BAR2 base addre

[PATCH 0/2] ppc/pnv: HOMER fixes and improvements

2019-12-11 Thread Cédric Le Goater
Hello, The first patch introduces a new XSCOM region for the PBA bridge unit (Power Bus Access) which connects the OCC (On Chip Controller) to the Power bus and System Memory. The PBA is used to gather sensor data, for power management, for sleep states, for initial boot, among other things. This

[PATCH 1/2] ppc/pnv: Introduce PBA registers

2019-12-11 Thread Cédric Le Goater
The PBA bridge unit (Power Bus Access) connects the OCC (On Chip Controller) to the Power bus and System Memory. The PBA is used to gather sensor data, for power management, for sleep states, for initial boot, among other things. The PBA logic provides a set of four registers PowerBus Access Base

Re: [PATCH v1 0/5] target/arm/kvm: Provide an option to adjust virtual time

2019-12-11 Thread Andrew Jones
On Wed, Dec 11, 2019 at 04:02:52PM +0800, Guoheyi wrote: > > 在 2019/12/6 23:22, Peter Maydell 写道: > > On Wed, 16 Oct 2019 at 15:34, Andrew Jones wrote: > > > v2: > > > - move from RFC status to v1 > > > - put kvm_arm_vm_state_change() in kvm.c to share among kvm32.c and > > > kvm64.c > > >

Re: guest / host buffer sharing ...

2019-12-11 Thread Gerd Hoffmann
Hi, > None of the proposals directly address the use case of sharing host > allocated buffers between devices, but I think they can be extended to > support it. Host buffers can be identified by the following tuple: > (transport type enum, transport specific device address, shmid, > offset). I t

Re: Insufficiently documented deprecated command arguments

2019-12-11 Thread Peter Krempa
On Wed, Dec 11, 2019 at 09:12:41 +0100, Markus Armbruster wrote: > I went through the QAPI schema looking for deprecated stuff not > mentioned in qemu-deprecated.texi. Here's what I found: > > Commit b33945cfff "block: Accept device model name for > blockdev-open/close-tray" (v2.8.0) depr

Re: Insufficiently documented deprecated command arguments

2019-12-11 Thread Kevin Wolf
Am 11.12.2019 um 10:33 hat Peter Krempa geschrieben: > On Wed, Dec 11, 2019 at 09:12:41 +0100, Markus Armbruster wrote: > > Commit 7a9877a026 "block: Accept device model name for > > block_set_io_throttle" (v2.8.0) deprecated block_set_io_throttle > > argument @device. > > This one is

[PATCH v2] hw/usb: Introduce Kconfig switches for the CCID card devices

2019-12-11 Thread Thomas Huth
In our downstream distribution of QEMU, we need more fine-grained control on the set of CCID card devices that we want to include. So let's introduce some proper Kconfig switches that it is easier to disable them without modifying the corresponding Makefile.objs. Signed-off-by: Thomas Huth --- v

Re: BeagleBone support, omap1, omap2, omap3, etc.

2019-12-11 Thread Esteban Bosse
Hello Niek and Philippe, Thank you very much for your support and all the information provided, I will create a new "roadmap" with all this excellent information and try again. Thank you again and best regards, Esteban Bosse El mar., 10 dic. 2019 a las 20:51, Niek Linnenbank (< nieklinnenb...@gm

Re: Insufficiently documented deprecated command arguments

2019-12-11 Thread Peter Krempa
On Wed, Dec 11, 2019 at 12:32:10 +, Daniel Berrange wrote: > On Wed, Dec 11, 2019 at 01:24:17PM +0100, Kevin Wolf wrote: > > Am 11.12.2019 um 11:51 hat Peter Krempa geschrieben: > > > On Wed, Dec 11, 2019 at 11:14:39 +0100, Kevin Wolf wrote: [...] > > > Well, in some specific cases we could d

Re: Insufficiently documented deprecated command arguments

2019-12-11 Thread Daniel P . Berrangé
On Wed, Dec 11, 2019 at 01:24:17PM +0100, Kevin Wolf wrote: > Am 11.12.2019 um 11:51 hat Peter Krempa geschrieben: > > On Wed, Dec 11, 2019 at 11:14:39 +0100, Kevin Wolf wrote: > > > Am 11.12.2019 um 10:33 hat Peter Krempa geschrieben: > > > > On Wed, Dec 11, 2019 at 09:12:41 +0100, Markus Armbrust

Re: [PATCH v4 00/37] Clean-ups: qom-ify serial and remove QDEV_PROP_PTR

2019-12-11 Thread Marc-André Lureau
Hi On Sun, Dec 1, 2019 at 2:19 PM Marc-André Lureau wrote: > > > - "chardev: generate an internal id when none given" > > As explained, this is necessary for qdev_prop_set_chr() ping > > - "serial: register vmsd with DeviceClass" > > This is standard qdev-ification, however it breaks backward m

Re: [PATCH v6 28/42] stream: Deal with filters

2019-12-11 Thread Max Reitz
On 16.09.19 11:52, Max Reitz wrote: > On 13.09.19 16:16, Kevin Wolf wrote: >> Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: >>> Because of the recent changes that make the stream job independent of >>> the base node and instead track the node above it, we have to split that >>> "bottom" node in

Re: qom device lifecycle interaction with hotplug/hotunplug ?

2019-12-11 Thread Damien Hedde
On 12/4/19 7:51 PM, Eduardo Habkost wrote: > On Wed, Dec 04, 2019 at 05:21:25PM +0100, Jens Freimann wrote: >> On Wed, Dec 04, 2019 at 11:35:37AM -0300, Eduardo Habkost wrote: >>> On Wed, Dec 04, 2019 at 10:18:24AM +0100, Jens Freimann wrote: On Tue, Dec 03, 2019 at 06:40:04PM -0300, Eduard

Re: [RFC PATCH 0/1] Removing RAMBlocks during migration

2019-12-11 Thread Dr. David Alan Gilbert
* Yury Kotov (yury-ko...@yandex-team.ru) wrote: > Hi, > > I found that it's possible to remove a RAMBlock during migration. > E.g. device hot-unplugging initiated by a guest (how to reproduce is below). > And I want to clarify whether RAMBlock removing (or even adding) during > migration is valid

Re: Insufficiently documented deprecated command arguments

2019-12-11 Thread Kevin Wolf
Am 11.12.2019 um 11:51 hat Peter Krempa geschrieben: > On Wed, Dec 11, 2019 at 11:14:39 +0100, Kevin Wolf wrote: > > Am 11.12.2019 um 10:33 hat Peter Krempa geschrieben: > > > On Wed, Dec 11, 2019 at 09:12:41 +0100, Markus Armbruster wrote: > > > > Commit 7a9877a026 "block: Accept device model

[PATCH] object: Improve documentation of interfaces

2019-12-11 Thread Greg Kurz
QOM interfaces allow a limited form of multiple inheritance, at the condition of being stateless. That is, they cannot be instantiated and a pointer to an interface shouldn't be dereferenceable in any way. This is achieved by making the QOM instance type an incomplete type, which is, as mentioned b

[Bug 1856027] [NEW] Suddenly no internet in guest system!

2019-12-11 Thread Tom Hanker
Public bug reported: I use Opensuse 15.1 i have installed androidx86_64 as a guest system, it runs for over 3 years. i had a internetconnection, i could use apps etc. but since yesterday i can´t connect to the internet with the guest system in the host system all works fine. What could be the r

Re: [PATCH] object: Improve documentation of interfaces

2019-12-11 Thread Marc-André Lureau
On Wed, Dec 11, 2019 at 5:33 PM Greg Kurz wrote: > > QOM interfaces allow a limited form of multiple inheritance, at the > condition of being stateless. That is, they cannot be instantiated > and a pointer to an interface shouldn't be dereferenceable in any way. > This is achieved by making the QO

[PATCH v6 0/8] Add dbus-vmstate

2019-12-11 Thread Marc-André Lureau
Hi, With external processes or helpers participating to the VM support, it becomes necessary to handle their migration. Various options exist to transfer their state: 1) as the VM memory, RAM or devices (we could say that's how vhost-user devices can be handled today, they are expected to re

[PATCH v6 1/8] vmstate: add qom interface to get id

2019-12-11 Thread Marc-André Lureau
Add an interface to get the instance id, instead of depending on Device and qdev_get_dev_path(). Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Acked-by: Dr. David Alan Gilbert --- MAINTAINERS | 2 ++ hw/core/Makefile.objs| 1 + hw/core/qdev.c

[PATCH v6 4/8] util: add dbus helper unit

2019-12-11 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- MAINTAINERS | 2 ++ include/qemu/dbus.h | 18 +++ util/Makefile.objs | 3 +++ util/dbus.c | 55 + 4 files changed, 78 insertions(+) create mode 100644 include/qemu/dbus.h create mode

[PATCH v6 3/8] docs: start a document to describe D-Bus usage

2019-12-11 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- MAINTAINERS| 5 +++ docs/interop/dbus.rst | 99 ++ docs/interop/index.rst | 1 + 3 files changed, 105 insertions(+) create mode 100644 docs/interop/dbus.rst diff --git a/MAINTAINERS b/MAINTAINERS index 5

[PATCH v6 2/8] vmstate: replace DeviceState with VMStateIf

2019-12-11 Thread Marc-André Lureau
Replace DeviceState dependency with VMStateIf on vmstate API. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Reviewed-by: Dr. David Alan Gilbert Acked-by: Halil Pasic --- hw/block/onenand.c | 2 +- hw/core/qdev.c | 7 --- hw/ide/cmd646.c

[PATCH v6 8/8] tests: add dbus-vmstate-test

2019-12-11 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- MAINTAINERS | 1 + tests/Makefile.include | 22 +- tests/dbus-vmstate-daemon.sh | 95 + tests/dbus-vmstate-test.c| 399 +++ tests/dbus-vmstate1.xml | 12 ++ 5 files changed, 528 inser

[PATCH v6 5/8] Add dbus-vmstate object

2019-12-11 Thread Marc-André Lureau
When instantiated, this object will connect to the given D-Bus bus "addr". During migration, it will take/restore the data from org.qemu.VMState1 instances. See documentation for details. Signed-off-by: Marc-André Lureau --- MAINTAINERS | 2 + backends/Makefile.objs|

Re: [PATCH v2] hw/usb: Introduce Kconfig switches for the CCID card devices

2019-12-11 Thread Philippe Mathieu-Daudé
On 12/11/19 11:20 AM, Thomas Huth wrote: In our downstream distribution of QEMU, we need more fine-grained control on the set of CCID card devices that we want to include. So let's introduce some proper Kconfig switches that it is easier to disable them without modifying the corresponding Makefil

Re: [PATCH v1 0/5] target/arm/kvm: Provide an option to adjust virtual time

2019-12-11 Thread Guoheyi
在 2019/12/11 17:00, Andrew Jones 写道: On Wed, Dec 11, 2019 at 04:02:52PM +0800, Guoheyi wrote: 在 2019/12/6 23:22, Peter Maydell 写道: On Wed, 16 Oct 2019 at 15:34, Andrew Jones wrote: v2: - move from RFC status to v1 - put kvm_arm_vm_state_change() in kvm.c to share among kvm32.c and kvm

[PATCH v6 6/8] configure: add GDBUS_CODEGEN

2019-12-11 Thread Marc-André Lureau
gdbus-codegen generated code requires gio-unix on Unix, so add it to GIO libs/cflags. Signed-off-by: Marc-André Lureau --- configure | 7 +++ 1 file changed, 7 insertions(+) diff --git a/configure b/configure index 6099be1d84..68a7705df7 100755 --- a/configure +++ b/configure @@ -3720,10 +3

Re: [PATCH v17 5/7] ppc: spapr: Handle "ibm,nmi-register" and "ibm,nmi-interlock" RTAS calls

2019-12-11 Thread Ganesh
On 12/5/19 10:25 AM, Ganesh wrote: On 11/19/19 8:09 AM, David Gibson wrote: On Thu, Oct 24, 2019 at 01:13:05PM +0530, Ganesh Goudar wrote: From: Aravinda Prasad This patch adds support in QEMU to handle "ibm,nmi-register" and "ibm,nmi-interlock" RTAS calls. The machine check notification

[PATCH v6 7/8] dockerfiles: add dbus-daemon to some of latest distributions

2019-12-11 Thread Marc-André Lureau
To get dbus-vmstate test covered. Signed-off-by: Marc-André Lureau --- tests/docker/dockerfiles/centos7.docker | 1 + tests/docker/dockerfiles/debian10.docker | 1 + tests/docker/dockerfiles/fedora.docker | 1 + tests/docker/dockerfiles/ubuntu.docker | 1 + 4 files changed, 4 insertions(+)

Re: Insufficiently documented deprecated command arguments

2019-12-11 Thread Peter Krempa
On Wed, Dec 11, 2019 at 11:14:39 +0100, Kevin Wolf wrote: > Am 11.12.2019 um 10:33 hat Peter Krempa geschrieben: > > On Wed, Dec 11, 2019 at 09:12:41 +0100, Markus Armbruster wrote: > > > Commit 7a9877a026 "block: Accept device model name for > > > block_set_io_throttle" (v2.8.0) deprecated

Re: [PATCH] gdbstub: change GDBState.last_packet to GByteArray

2019-12-11 Thread Damien Hedde
On 12/9/19 11:15 AM, Luc Michel wrote: > > > On 12/6/19 2:42 PM, Damien Hedde wrote: >> Remove the packet size upper limit by using a GByteArray >> instead of a statically allocated array for last_packet. >> Thus we can now send big packets. >> >> Also remove the last_packet_len field and use l

[PATCH] build-sys: build vhost-user-gpu only if CONFIG_TOOLS

2019-12-11 Thread Paolo Bonzini
From: Marc-André Lureau vhost-user-gpu is always built and installed, but it is not part of the emulator proper. Cut it if --disable-tools is specified. Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff

[PATCH] migration: fix stringop-truncation warning

2019-12-11 Thread Paolo Bonzini
From: Marc-André Lureau ../migration/global_state.c: In function ‘global_state_store_running’: ../migration/global_state.c:47:5: error: ‘strncpy’ specified bound 100 equals destination size [-Werror=stringop-truncation] 47 | strncpy((char *)global_state.runstate, | ^

[PATCH] vhost-user-scsi: fix printf format warning

2019-12-11 Thread Paolo Bonzini
From: Marc-André Lureau Fixes: ../contrib/vhost-user-scsi/vhost-user-scsi.c:118:57: error: format specifies type 'unsigned char' but the argument has type 'int' [-Werror,-Wformat] g_warning("Unable to determine cdb len (0x%02hhX)", cdb[0] >> 5); Signed-off-by: Marc-André Lureau Signed

[PATCH] configure: simplify vhost condition with Kconfig

2019-12-11 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Kconfig.host| 5 + hw/virtio/Kconfig | 3 +++ hw/virtio/Makefile.objs | 4 ++-- 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/Kconfig.host b/Kconfig.host index bb6e

[PATCH] migration: fix maybe-uninitialized warning

2019-12-11 Thread Paolo Bonzini
From: Marc-André Lureau ../migration/ram.c: In function ‘multifd_recv_thread’: /home/elmarco/src/qq/include/qapi/error.h:165:5: error: ‘block’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 165 | error_setg_internal((errp), __FILE__, __LINE__, __func__, \

[PATCH] build-sys: do not include Windows SLIRP dependencies in $LIBS

2019-12-11 Thread Paolo Bonzini
When including the internal SLIRP library, we should add all the libraries that it needs for the build. Right now they are all included by QEMU, but -liphlpapi is not needed without slirp. Move it from LIBS to slirp_libs. Based on a patch by Marc-André Lureau. Signed-off-by: Paolo Bonzini ---

[PATCH] glib: use portable g_setenv()

2019-12-11 Thread Paolo Bonzini
From: Marc-André Lureau We have a setenv() wrapper in os-win32.c that no one is actually using. Drop it and change to g_setenv() uniformly. Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- include/sysemu/os-win32.h| 2 -- os-win32.c | 22 ---

[PATCH] monitor: fix maybe-uninitialized

2019-12-11 Thread Paolo Bonzini
From: Marc-André Lureau ../monitor/misc.c: In function ‘mon_get_cpu_sync’: /home/elmarco/src/qq/include/sysemu/hw_accel.h:22:9: error: ‘cpu’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 22 | kvm_cpu_synchronize_state(cpu); | ^~

[PATCH] tests: use g_test_rand_int

2019-12-11 Thread Paolo Bonzini
g_test_rand_int provides a reproducible random integer number, using a different number seed every time but allowing reproduction using the --seed command line option. It is thus better suited to tests than g_random_int or random. Signed-off-by: Paolo Bonzini --- block/vhdx.c | 2 +- bl

[PATCH] ppc/pnv: Make PnvXScomInterface an incomplete type

2019-12-11 Thread Greg Kurz
PnvXScomInterface is an interface instance. It should never be dereferenced. Drop the dummy type definition for extra safety, which is the common practice with QOM interfaces. Signed-off-by: Greg Kurz --- include/hw/ppc/pnv_xscom.h |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) dif

[PATCH] tests: fix test-qga on macosx

2019-12-11 Thread Paolo Bonzini
From: Marc-André Lureau Fix Unix socket connection & skip commands that are not implemented. Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- tests/test-qga.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/tests/test-qga.c b/tes

[PATCH] os-posix: simplify os_find_datadir

2019-12-11 Thread Paolo Bonzini
From: Marc-André Lureau Use g_build_filename instead of sprintf, and g_autofree instead of manual freeing. Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- os-posix.c | 41 + 1 file changed, 13 insertions(+), 28 deletions(-) diff --git

[PATCH v2] ci: build out-of-tree

2019-12-11 Thread Paolo Bonzini
Most developers are using out-of-tree builds and it was discussed in the past to only allow those. To prepare for the transition, use out-of-tree builds in all continuous integration jobs. Based on a patch by Marc-André Lureau. Signed-off-by: Paolo Bonzini --- v1->v2: include all changes to .tr

[PATCH] tests: skip block layer tests if !CONFIG_TOOLS

2019-12-11 Thread Paolo Bonzini
From: Marc-André Lureau The block tests, as well as ahci-test needs qemu-img. Do not run them if it wasn't built. Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 4 1 file changed, 4 insertions(+) diff --git a/tests/Makefile.include b/tests/Ma

Re: [PATCH] build-sys: do not include Windows SLIRP dependencies in $LIBS

2019-12-11 Thread Samuel Thibault
Paolo Bonzini, le mer. 11 déc. 2019 15:23:23 +0100, a ecrit: > When including the internal SLIRP library, we should add all the libraries > that > it needs for the build. Right now they are all included by QEMU, but > -liphlpapi > is not needed without slirp. Move it from LIBS to slirp_libs. >

[PATCH] ci: build out-of-tree

2019-12-11 Thread Paolo Bonzini
Most developers are using out-of-tree builds and it was discussed in the past to only allow those. To prepare for the transition, use out-of-tree builds in all continuous integration jobs. Based on a patch by Marc-André Lureau. Signed-off-by: Paolo Bonzini --- .cirrus.yml| 8 ++-- .gi

Re: [PATCH] build-sys: build vhost-user-gpu only if CONFIG_TOOLS

2019-12-11 Thread Thomas Huth
On 11/12/2019 15.23, Paolo Bonzini wrote: > From: Marc-André Lureau > > vhost-user-gpu is always built and installed, but it is not part of the > emulator > proper. Cut it if --disable-tools is specified. > > Signed-off-by: Marc-André Lureau > Signed-off-by: Paolo Bonzini > --- > Makefile |

Re: [PATCH] build-sys: build vhost-user-gpu only if CONFIG_TOOLS

2019-12-11 Thread Daniel P . Berrangé
On Wed, Dec 11, 2019 at 03:23:22PM +0100, Paolo Bonzini wrote: > From: Marc-André Lureau > > vhost-user-gpu is always built and installed, but it is not part of the > emulator > proper. Cut it if --disable-tools is specified. I don't feel like this is something that people would really conside

Re: [PATCH] tests: skip block layer tests if !CONFIG_TOOLS

2019-12-11 Thread Thomas Huth
On 11/12/2019 15.24, Paolo Bonzini wrote: > From: Marc-André Lureau > > The block tests, as well as ahci-test needs qemu-img. Do not run > them if it wasn't built. > > Signed-off-by: Marc-André Lureau > Signed-off-by: Paolo Bonzini > --- > tests/Makefile.include | 4 > 1 file changed, 4

Re: [PATCH v2 1/6] linux-user: convert target_mprotect debug to tracepoint

2019-12-11 Thread Laurent Vivier
Le 05/12/2019 à 13:25, Alex Bennée a écrit : > It is a pain to re-compile when you need to debug and tracepoints are > a fairly low impact way to instrument QEMU. > > Signed-off-by: Alex Bennée > > --- > v2 > - don't both with ascii conversion > --- > linux-user/mmap.c | 10 ++ >

[PATCH] ff Signed-off-by: Paolo Bonzini

2019-12-11 Thread Paolo Bonzini
--- hw/ppc/e500.c | 1 - hw/ppc/spapr_irq.c | 8 2 files changed, 9 deletions(-) diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c index 928efaa..12b6a5b 100644 --- a/hw/ppc/e500.c +++ b/hw/ppc/e500.c @@ -793,7 +793,6 @@ static DeviceState *ppce500_init_mpic(PPCE500MachineState *pms,

Re: [PATCH v2 2/6] linux-user: convert target_mmap debug to tracepoint

2019-12-11 Thread Laurent Vivier
Le 05/12/2019 à 13:25, Alex Bennée a écrit : > It is a pain to re-compile when you need to debug and tracepoints are > a fairly low impact way to instrument QEMU. > > Signed-off-by: Alex Bennée > --- > linux-user/mmap.c | 27 +-- > linux-user/trace-events | 1 + >

[PATCH] build-sys: clean up flags included in the linker command line

2019-12-11 Thread Paolo Bonzini
Some of the CFLAGS that are discovered during configure, for example compiler warnings, are being included on the linker command line because QEMU_CFLAGS is added to it. Other flags, such as the -m32, appear twice because they are included in both QEMU_CFLAGS and LDFLAGS. All this leads to confus

Re: [PATCH] ci: build out-of-tree

2019-12-11 Thread Thomas Huth
On 11/12/2019 15.30, Paolo Bonzini wrote: > Most developers are using out-of-tree builds and it was discussed in the past > to only allow those. To prepare for the transition, use out-of-tree builds > in all continuous integration jobs. > > Based on a patch by Marc-André Lureau. > > Signed-off-b

Re: [PATCH v2 3/6] linux-user: add target_mmap_complete tracepoint

2019-12-11 Thread Laurent Vivier
Le 05/12/2019 à 13:25, Alex Bennée a écrit : > For full details we also want to see where the mmaps end up. > > Signed-off-by: Alex Bennée > Reviewed-by: Richard Henderson > --- > linux-user/mmap.c | 2 +- > linux-user/trace-events | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-)

Re: [PATCH] ci: build out-of-tree

2019-12-11 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1576074600-54759-1-git-send-email-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH] ci: build out-of-tree Type: series Message-id: 1576074600-54759-1-git-send-email-pbonz

Re: [PATCH v2 4/6] linux-user: log page table changes under -d page

2019-12-11 Thread Laurent Vivier
Le 05/12/2019 à 13:25, Alex Bennée a écrit : > The CPU_LOG_PAGE flag is woefully underused and could stand to do > extra duty tracking page changes. If the user doesn't want to see the > details as things change they still have the tracepoints available. > > We push the locking into log_page_dump

Re: [PATCH v2 5/6] linux-user: convert target_munmap debug to a tracepoint

2019-12-11 Thread Laurent Vivier
Le 05/12/2019 à 13:25, Alex Bennée a écrit : > Convert the final bit of DEBUG_MMAP to a tracepoint and remove the > last remanents of the #ifdef hackery. > > Signed-off-by: Alex Bennée > Reviewed-by: Richard Henderson > --- > linux-user/mmap.c | 9 ++--- > linux-user/trace-events | 1

Re: [PATCH 1/2] python/qemu: Add set_qmp_monitor() to QEMUMachine

2019-12-11 Thread Wainer dos Santos Moschetta
On 12/10/19 3:17 AM, Cleber Rosa wrote: On Tue, Nov 12, 2019 at 08:58:00AM -0500, Wainer dos Santos Moschetta wrote: The QEMUMachine VM has a monitor setup on which an QMP connection is always attempted on _post_launch() (executed by launch()). In case the QEMU process immediatly exits then th

RE: [Qemu-devel] [RFC PATCH 0/6] hw/arm/virt: Introduce cpu topology support

2019-12-11 Thread Zengtao (B)
Hi Andrew: Thanks for your reply. It 's fine for me if you are still tracking the thread. And I can help to test if needed ^_^. > -Original Message- > From: Andrew Jones [mailto:drjo...@redhat.com] > Sent: Tuesday, December 10, 2019 6:13 PM > To: Zengtao (B) > Cc: qemu-devel@nongnu.org;

[PATCH v2 0/6] hw/arm/smmuv3: Correct stream ID and event address handling

2019-12-11 Thread Simon Veith
While working on the Linux SMMUv3 driver, I noticed a few cases where the QEMU SMMUv3 behavior relating to stream tables was inconsistent with our hardware. Also, when debugging those differences, I found that the errors reported through the QEMU SMMUv3 event queue contained the address fields in

[PATCH v2 1/6] hw/arm/smmuv3: Apply address mask to linear strtab base address

2019-12-11 Thread Simon Veith
In the SMMU_STRTAB_BASE register, the stream table base address only occupies bits [51:6]. Other bits, such as RA (bit [62]), must be masked out to obtain the base address. The branch for 2-level stream tables correctly applies this mask by way of SMMU_BASE_ADDR_MASK, but the one for linear stream

Re: [PATCH] ff Signed-off-by: Paolo Bonzini

2019-12-11 Thread Daniel P . Berrangé
Missing commit message subject line :-) On Wed, Dec 11, 2019 at 03:46:33PM +0100, Paolo Bonzini wrote: > --- > hw/ppc/e500.c | 1 - > hw/ppc/spapr_irq.c | 8 > 2 files changed, 9 deletions(-) > > diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c > index 928efaa..12b6a5b 100644 > --- a/hw/

[PATCH v2 2/6] hw/arm/smmuv3: Correct SMMU_BASE_ADDR_MASK value

2019-12-11 Thread Simon Veith
There are two issues with the current value of SMMU_BASE_ADDR_MASK: - At the lower end, we are clearing bits [4:0]. Per the SMMUv3 spec, we should also be treating bit 5 as zero in the base address. - At the upper end, we are clearing bits [63:48]. Per the SMMUv3 spec, only bits [63:52] must b

Re: [PATCH] build-sys: do not include Windows SLIRP dependencies in $LIBS

2019-12-11 Thread Paolo Bonzini
On 11/12/19 15:37, Samuel Thibault wrote: > Paolo Bonzini, le mer. 11 déc. 2019 15:23:23 +0100, a ecrit: >> When including the internal SLIRP library, we should add all the libraries >> that >> it needs for the build. Right now they are all included by QEMU, but >> -liphlpapi >> is not needed wi

Re: [PATCH] ci: build out-of-tree

2019-12-11 Thread Paolo Bonzini
On 11/12/19 15:50, Thomas Huth wrote: > On 11/12/2019 15.30, Paolo Bonzini wrote: >> Most developers are using out-of-tree builds and it was discussed in the past >> to only allow those. To prepare for the transition, use out-of-tree builds >> in all continuous integration jobs. >> >> Based on a p

[PATCH v2 5/6] hw/arm/smmuv3: Use correct bit positions in EVT_SET_ADDR2 macro

2019-12-11 Thread Simon Veith
The bit offsets in the EVT_SET_ADDR2 macro do not match those specified in the ARM SMMUv3 Architecture Specification. In all events that use this macro, e.g. F_WALK_EABT, the faulting fetch address or IPA actually occupies the 32-bit words 6 and 7 in the event record contiguously, with the upper an

[PATCH v2 3/6] hw/arm/smmuv3: Check stream IDs against actual table LOG2SIZE

2019-12-11 Thread Simon Veith
When checking whether a stream ID is in range of the stream table, we have so far been only checking it against our implementation limit (SMMU_IDR1_SIDSIZE). However, the guest can program the STRTAB_BASE_CFG.LOG2SIZE field to a size that is smaller than this limit. Check the stream ID against thi

[PATCH v2 4/6] hw/arm/smmuv3: Align stream table base address to table size

2019-12-11 Thread Simon Veith
Per the specification, and as observed in hardware, the SMMUv3 aligns the SMMU_STRTAB_BASE address to the size of the table by masking out the respective least significant bits in the ADDR field. Apply this masking logic to our smmu_find_ste() lookup function per the specification. ref. ARM IHI 0

[PATCH v2 6/6] hw/arm/smmuv3: Report F_STE_FETCH fault address in correct word position

2019-12-11 Thread Simon Veith
The smmuv3_record_event() function that generates the F_STE_FETCH error uses the EVT_SET_ADDR macro to record the fetch address, placing it in 32-bit words 4 and 5. The correct position for this address is in words 6 and 7, per the SMMUv3 Architecture Specification. Update the function to use the

Re: [PATCH] ff Signed-off-by: Paolo Bonzini

2019-12-11 Thread Paolo Bonzini
On 11/12/19 16:02, Daniel P. Berrangé wrote: > Missing commit message subject line :-) I'm not fast enough at Ctrl-C, it seems! Paolo > On Wed, Dec 11, 2019 at 03:46:33PM +0100, Paolo Bonzini wrote: >> --- >> hw/ppc/e500.c | 1 - >> hw/ppc/spapr_irq.c | 8 >> 2 files changed, 9 de

Re: [PATCH] build-sys: build vhost-user-gpu only if CONFIG_TOOLS

2019-12-11 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Wed, Dec 11, 2019 at 03:23:22PM +0100, Paolo Bonzini wrote: > > From: Marc-André Lureau > > > > vhost-user-gpu is always built and installed, but it is not part of the > > emulator > > proper. Cut it if --disable-tools is specified. > > I

Re: How to extend QEMU's vhost-user tests after implementing vhost-user-blk device backend

2019-12-11 Thread Coiby Xu
Hi Stefan, I'm now writing the tests for vhost-user-blk device based on tests/virtio-blk-test.c. But block_resize command doesn't apply to vhost-user-blk device. After launching vhost-user backend server, I type the following command to connect to it (qemu) chardev-add socket,id=char1,path=/tmp/

Re: [PATCH] ppc/pnv: Make PnvXScomInterface an incomplete type

2019-12-11 Thread Cédric Le Goater
On 11/12/2019 15:32, Greg Kurz wrote: > PnvXScomInterface is an interface instance. It should never be > dereferenced. Drop the dummy type definition for extra safety, > which is the common practice with QOM interfaces. > > Signed-off-by: Greg Kurz > --- > include/hw/ppc/pnv_xscom.h |4 +---

Re: [PATCH 02/26] qdev: remove duplicated qdev_property_add_static() doc

2019-12-11 Thread Damien Hedde
On 12/1/19 12:15 PM, Marc-André Lureau wrote: > The function is already documented in the header. > > Signed-off-by: Marc-André Lureau > --- > hw/core/qdev.c | 10 -- > 1 file changed, 10 deletions(-) > > diff --git a/hw/core/qdev.c b/hw/core/qdev.c > index c7b3f0dec5..8b93b85727 100

Re: [PATCH v6 28/42] stream: Deal with filters

2019-12-11 Thread Kevin Wolf
Am 11.12.2019 um 13:52 hat Max Reitz geschrieben: > On 16.09.19 11:52, Max Reitz wrote: > > On 13.09.19 16:16, Kevin Wolf wrote: > >> Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: > >>> Because of the recent changes that make the stream job independent of > >>> the base node and instead track t

Re: [PATCH] ppc/pnv: Make PnvXScomInterface an incomplete type

2019-12-11 Thread Greg Kurz
On Wed, 11 Dec 2019 16:35:41 +0100 Cédric Le Goater wrote: > On 11/12/2019 15:32, Greg Kurz wrote: > > PnvXScomInterface is an interface instance. It should never be > > dereferenced. Drop the dummy type definition for extra safety, > > which is the common practice with QOM interfaces. > > > > S

Re: [PATCH] virtio: don't enable notifications during polling

2019-12-11 Thread Michael S. Tsirkin
On Mon, Dec 09, 2019 at 09:09:57PM +, Stefan Hajnoczi wrote: > Virtqueue notifications are not necessary during polling, so we disable > them. This allows the guest driver to avoid MMIO vmexits. > Unfortunately the virtio-blk and virtio-scsi handler functions re-enable > notifications, defeati

Re: [PATCH v8] Implement backend program convention command for vhost-user-blk

2019-12-11 Thread Michael S. Tsirkin
On Mon, Dec 09, 2019 at 09:53:31AM +0800, Micky Yun Chan(michiboo) wrote: > From: Micky Yun Chan > > This patch is to add standard commands defined in docs/interop/vhost-user.rst > For vhost-user-* program > > Signed-off-by: Micky Yun Chan (michiboo) Thanks! I'll queue it for merge after the r

Re: qom device lifecycle interaction with hotplug/hotunplug ?

2019-12-11 Thread Igor Mammedov
On Wed, 4 Dec 2019 15:51:06 -0300 Eduardo Habkost wrote: > On Wed, Dec 04, 2019 at 05:21:25PM +0100, Jens Freimann wrote: > > On Wed, Dec 04, 2019 at 11:35:37AM -0300, Eduardo Habkost wrote: > > > On Wed, Dec 04, 2019 at 10:18:24AM +0100, Jens Freimann wrote: > > > > On Tue, Dec 03, 2019 at 0

Re: [PATCH v2] virtio-pci: disable vring processing when bus-mastering is disabled

2019-12-11 Thread Michael S. Tsirkin
On Tue, Nov 19, 2019 at 06:50:03PM -0600, Michael Roth wrote: > Currently the SLOF firmware for pseries guests will disable/re-enable > a PCI device multiple times via IO/MEM/MASTER bits of PCI_COMMAND > register after the initial probe/feature negotiation, as it tends to > work with a single devic

[PATCH v2] ppc/pnv: Make PnvXScomInterface an incomplete type

2019-12-11 Thread Greg Kurz
PnvXScomInterface is an interface instance. It should never be dereferenced. Drop the dummy type definition for extra safety, which is the common practice with QOM interfaces. While here also convert the bogus OBJECT_CHECK() to INTERFACE_CHECK(). Signed-off-by: Greg Kurz --- v2: convert OBJECT_C

[PATCH v2 1/2] gdbstub: change GDBState.last_packet to GByteArray

2019-12-11 Thread Damien Hedde
Remove the packet size upper limit by using a GByteArray instead of a statically allocated array for last_packet. Thus we can now send big packets. Also remove the last_packet_len field and use last_packet->len instead. Signed-off-by: Damien Hedde Reviewed-by: Philippe Mathieu-Daudé --- gdbstu

Re: [PATCH] virtio-fs: fix MSI-X nvectors calculation

2019-12-11 Thread Michael S. Tsirkin
On Mon, Dec 09, 2019 at 11:07:59AM +, Stefan Hajnoczi wrote: > The following MSI-X vectors are required: > * VIRTIO Configuration Change > * hiprio virtqueue > * requests virtqueues > > Fix the calculation to reserve enough MSI-X vectors. Otherwise guest > drivers fall back to a sub-option

[PATCH v2 2/2] gdbstub: do not split gdb_monitor_write payload

2019-12-11 Thread Damien Hedde
Since we can now send packets of arbitrary length: simplify gdb_monitor_write() and send the whole payload in one packet. Suggested-by: Luc Michel Signed-off-by: Damien Hedde --- gdbstub.c | 23 +++ 1 file changed, 3 insertions(+), 20 deletions(-) diff --git a/gdbstub.c b/g

[PATCH v2 0/2] gdbstub: allow sending packet of arbitrary length

2019-12-11 Thread Damien Hedde
Hi All, This series is a follow-up of Alex's series about sve registers which introduces some GbyteArray/Gstring in the gdbstub. It removes the remaining barrier to send big packets. In consequence, we can slso simply gdb_monitor_write(). Based-on <20191130084602.10818-1-alex.ben...@linaro.org>

Re: [PATCH 25/26] qapi/qmp: add ObjectPropertyInfo.default-value

2019-12-11 Thread Eric Blake
On 12/1/19 5:15 AM, Marc-André Lureau wrote: Report the default value associated with a property. Signed-off-by: Marc-André Lureau --- qapi/qom.json | 7 ++- qom/qom-qmp-cmds.c | 4 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/qapi/qom.json b/qapi/qom.json in

Re: [PATCH] monitor: fix maybe-uninitialized

2019-12-11 Thread Markus Armbruster
Paolo Bonzini writes: > From: Marc-André Lureau > > ../monitor/misc.c: In function ‘mon_get_cpu_sync’: > /home/elmarco/src/qq/include/sysemu/hw_accel.h:22:9: error: ‘cpu’ may be used > uninitialized in this function [-Werror=maybe-uninitialized] >22 | kvm_cpu_synchronize_state(cpu);

Re: [PATCH v2] ppc/pnv: Make PnvXScomInterface an incomplete type

2019-12-11 Thread Philippe Mathieu-Daudé
On 12/11/19 5:04 PM, Greg Kurz wrote: PnvXScomInterface is an interface instance. It should never be dereferenced. Drop the dummy type definition for extra safety, which is the common practice with QOM interfaces. While here also convert the bogus OBJECT_CHECK() to INTERFACE_CHECK(). Signed-off

Re: [PATCH v6 28/42] stream: Deal with filters

2019-12-11 Thread Max Reitz
On 11.12.19 16:52, Kevin Wolf wrote: > Am 11.12.2019 um 13:52 hat Max Reitz geschrieben: >> On 16.09.19 11:52, Max Reitz wrote: >>> On 13.09.19 16:16, Kevin Wolf wrote: Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: > Because of the recent changes that make the stream job independent of

[PACTH v3 4/5] hw/ppc/Kconfig: Enable TPMDEV as part of PSERIES config

2019-12-11 Thread Stefan Berger
Signed-off-by: Stefan Berger --- hw/ppc/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig index f927ec9c74..99eaaf17a1 100644 --- a/hw/ppc/Kconfig +++ b/hw/ppc/Kconfig @@ -10,6 +10,7 @@ config PSERIES select XICS_SPAPR select XIVE_SPAPR sel

[PACTH v3 0/5] Add vTPM emulator supportfor ppc64 platform

2019-12-11 Thread Stefan Berger
The following series of patches adds vTPM emulator support for the ppc64 platform (pSeries). It can be tested as follows with swtpm/libtpms: mkdir /tmp/mytpm1 swtpm socket --tpmstate dir=/tmp/mytpm1 \ --ctrl type=unixio,path=/tmp/mytpm1/swtpm-sock \ --log level=20 If TPM 2 is desired, add -

  1   2   3   >