RE: [PATCH v2] Adding support for MAC filtering in the FEC IP implementation.

Yes thanks.. This makes sense.. Will incorporate these changes and send the patch again.. --Bilal -Original Message- From: Mark Cave-Ayland [mailto:mark.cave-ayl...@ilande.co.uk] Sent: Tuesday, December 10, 2019 2:19 AM To: bilalwasim...@gmail.com; qemu-devel@nongnu.org Cc: peter.mayd..

[PATCH] ppc: Drop useless extern annotation for functions

Signed-off-by: Greg Kurz --- include/hw/ppc/pnv_xscom.h | 22 +++--- include/hw/ppc/spapr_vio.h |6 +++--- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/include/hw/ppc/pnv_xscom.h b/include/hw/ppc/pnv_xscom.h index a40d2a2a2a98..1c1d76bf9be5 100644 --- a/i

Re: [bugfix ping2] Re: [PATCH v2 0/2] fix qcow2_can_store_new_dirty_bitmap

On 09.12.19 23:03, Eric Blake wrote: > On 12/9/19 11:58 AM, Max Reitz wrote: >> On 09.12.19 17:30, Max Reitz wrote: >>> On 02.12.19 15:09, Vladimir Sementsov-Ogievskiy wrote: Hi again! Still forgotten bug-fix :( Is it too late for 4.2? >>> >>> Sorry. :-/ >>> >>> Yes, I thin

Re: [PATCH] hw/usb: Introduce Kconfig switches for the CCID card devices

On 10/12/2019 08.43, Philippe Mathieu-Daudé wrote: > On 12/10/19 8:20 AM, Thomas Huth wrote: >> In our downstream distribution of QEMU, we need more fine-grained >> control on the set of CCID card devices that we want to include. >> So let's introduce some proper Kconfig switches that it is easier

Re: [PATCH 00/10] Add Allwinner H3 SoC and Orange Pi PC Machine

On 12/9/19 10:37 PM, Niek Linnenbank wrote: Hi Philippe, On Tue, Dec 3, 2019 at 9:47 AM Philippe Mathieu-Daudé > wrote: On 12/2/19 10:09 PM, Niek Linnenbank wrote: > Dear QEMU developers, > > Hereby I would like to contribute the following set of pa

Re: [PATCH 04/10] arm: allwinner-h3: add USB host controller

On Tue, Dec 10, 2019 at 08:56:02AM +0100, Philippe Mathieu-Daudé wrote: > On 12/2/19 10:09 PM, Niek Linnenbank wrote: > > The Allwinner H3 System on Chip contains multiple USB 2.0 bus > > connections which provide software access using the Enhanced > > Host Controller Interface (EHCI) and Open Host

Re: [PATCH 00/10] Add Allwinner H3 SoC and Orange Pi PC Machine

Cc'ing Alex. On 12/3/19 8:25 PM, Niek Linnenbank wrote: Hi Philippe, Thanks for your very quick response! I remember I have seen this error before while working on the patches, in particular on the SMP part. I'll try to reproduce this error with the 4.20 sunxi kernel you used and debug it.

Re: [PATCH 2/5] ppc/pnv: Introduce a POWER10 PnvChip and a powernv10 machine

On 10/12/2019 04:34, David Gibson wrote: >> +static inline bool pnv_chip_is_power10(const PnvChip *chip) >> +{ >> +return PNV_CHIP_GET_CLASS(chip)->chip_type == PNV_CHIP_POWER10; >> +} >> + >> +static inline bool pnv_is_power10(PnvMachineState *pnv) >> +{ >> +return pnv_chip_is_power10(pnv-

Re: [PATCH 0/2] hw/arm: ast2600: Wire up eMMC controller

On 10/12/2019 01:52, Andrew Jeffery wrote: > Hello, > > The AST2600 has an additional SDHCI intended for use as an eMMC boot source. Have you also considered booting the QEMU Aspeed AST2600 machine from the eMMC device ? C. > These two patches rework the existing ASPEED SDHCI model to accommod

Re: [PATCH 1/2] hw/sd: Configure number of slots exposed by the ASPEED SDHCI model

On 10/12/2019 01:52, Andrew Jeffery wrote: > The AST2600 includes a second cut-down version of the SD/MMC controller > found in the AST2500, named the eMMC controller. It's cut down in the > sense that it only supports one slot rather than two, but it brings the > total number of slots supported by

Re: [PATCH 02/10] hw: arm: add Xunlong Orange Pi PC machine

On 12/6/19 11:15 PM, Niek Linnenbank wrote: [...] >      > +static void orangepi_machine_init(MachineClass *mc) >      > +{ >      > +    mc->desc = "Orange Pi PC"; >      > +    mc->init = orangepi_init; >      > +    mc->units_per_default_bus = 1; >      > +    mc-

Re: [PATCH 01/10] hw: arm: add Allwinner H3 System-on-Chip

On 12/2/19 10:09 PM, Niek Linnenbank wrote: The Allwinner H3 is a System on Chip containing four ARM Cortex A7 processor cores. Features and specifications include DDR2/DDR3 memory, SD/MMC storage cards, 10/100/1000Mbit ethernet, USB 2.0, HDMI and various I/O modules. This commit adds support for

Re: [PATCH v8 21/21] nbd: assert that Error** is not NULL in nbd_iter_channel_error

Vladimir Sementsov-Ogievskiy writes: > 06.12.2019 18:58, Markus Armbruster wrote: >> Eric Blake writes: >> >>> On 12/5/19 11:46 AM, Vladimir Sementsov-Ogievskiy wrote: The local_err parameter is not here to return information about nbd_iter_channel_error failure. Instead it's assumed

Re: [PATCH] ppc: Drop useless extern annotation for functions

On 12/10/19 9:09 AM, Greg Kurz wrote: Signed-off-by: Greg Kurz --- include/hw/ppc/pnv_xscom.h | 22 +++--- include/hw/ppc/spapr_vio.h |6 +++--- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/include/hw/ppc/pnv_xscom.h b/include/hw/ppc/pnv_xscom.h inde

Re: [PATCH v4 04/40] target/arm: Add TTBR1_EL2

Hi Richard, On Tue, Dec 3, 2019 at 3:35 AM Richard Henderson wrote: > > At the same time, add writefn to TTBR0_EL2 and TCR_EL2. > A later patch will update any ASID therein. > > Reviewed-by: Alex Bennée > Signed-off-by: Richard Henderson > --- > target/arm/helper.c | 18 +- > 1

Re: [PATCH v26 00/21] Add RX archtecture support

Hi Richard, On 10/14/19 1:57 PM, Yoshinori Sato wrote: Hello. This patch series is added Renesas RX target emulation. If you are OK to take this series, few janitor tasks I noted while reviewing again: - Remove Message-Id in commit descriptions (various patches) - Remove version notes in co

Re: [PATCH v1 0/5] target/arm/kvm: Provide an option to adjust virtual time

On Fri, 2019-12-06 at 16:53 +0100, Andrew Jones wrote: > On Fri, Dec 06, 2019 at 03:22:58PM +, Peter Maydell wrote: > > On Wed, 16 Oct 2019 at 15:34, Andrew Jones wrote: > > > This series is inspired by a series[1] posted by Bijan Mottahedeh about > > > a year ago. The problem described in th

Re: BeagleBone support, omap1, omap2, omap3, etc.

Hi Esteban, On 12/3/19 4:24 PM, Esteban Bosse wrote: Ping El mié., 6 nov. 2019 16:04, Esteban Bosse > escribió: Hello! Some months ago I started to work trying to port the Beaglebone support from the old qemu-linaro fork to the new QEMU mainstream.

Re: [PATCH v2] s390x/tcg: clear local interrupts on reset normal

On Fri, 6 Dec 2019 14:54:04 +0100 Cornelia Huck wrote: > We neglected to clean up pending interrupts and emergency signals; > fix that. > > Signed-off-by: Cornelia Huck > --- > > v1->v2: > - rebased on top of my s390-next branch; we can now move the fields > to be reset instead of clearing

Re: [Qemu-devel] [RFC PATCH 0/6] hw/arm/virt: Introduce cpu topology support

On Mon, Dec 09, 2019 at 02:14:09AM +, Zengtao (B) wrote: > Hi Andrew: > > Any update for this patch series? I have met the same issue, and if the > topology guessed by linux MPIDR conflicts with qemu specified numa, it > will failed to boot (sched domain initialization will fall into deadloop

Re: [PATCH 2/2] analyze-migration.py: replace numpy with python 3.2

Hi On Tue, Dec 10, 2019 at 6:59 AM Eduardo Habkost wrote: > > On Fri, Dec 06, 2019 at 09:27:23AM -0500, Cleber Rosa wrote: > > On Wed, Nov 27, 2019 at 02:10:38PM +0400, Marc-André Lureau wrote: > > > Use int.from_bytes() from python 3.2 instead. > > > > > > Signed-off-by: Marc-André Lureau > > >

Re: [PATCH v1 0/5] target/arm/kvm: Provide an option to adjust virtual time

On Tue, 10 Dec 2019 at 09:51, Andrea Bolognani wrote: > > On Fri, 2019-12-06 at 16:53 +0100, Andrew Jones wrote: > > On Fri, Dec 06, 2019 at 03:22:58PM +, Peter Maydell wrote: > > > On Wed, 16 Oct 2019 at 15:34, Andrew Jones wrote: > > > > This series is inspired by a series[1] posted by Bija

Re: [PATCH 2/2] Add -mem-shared option

Eduardo Habkost writes: > +Markus > > On Tue, Dec 03, 2019 at 03:43:03PM +0100, Igor Mammedov wrote: >> On Tue, 3 Dec 2019 09:56:15 +0100 >> Thomas Huth wrote: >> >> > On 02/12/2019 22.00, Eduardo Habkost wrote: >> > > On Mon, Dec 02, 2019 at 08:39:48AM +0100, Igor Mammedov wrote: >> > >> On

Re: [PATCH 00/10] Add Allwinner H3 SoC and Orange Pi PC Machine

Le 12/2/19 à 10:09 PM, Niek Linnenbank a écrit : Dear QEMU developers, Hereby I would like to contribute the following set of patches to QEMU which add support for the Allwinner H3 System on Chip and the Orange Pi PC machine. The following features and devices are supported: * SMP (Quad Co

Re: [for-5.0 PATCH v2 1/3] cpu: Introduce CPUReset callback typedef

Greg Kurz writes: > Use it in include/hw/core/cpu.h and convert all targets to use it as > well with: > > perl -pi \ > -e 's/void\s+\(\*(parent_reset)\)\(CPUState\s+\*\w+\)/CPUReset \1/;' \ > $(git ls-files 'target/*.h') > > Signed-off-by: Greg Kurz > Acked-by: David Gibson > Reviewed-by: Ali

Re: [for-5.0 PATCH v2 0/3] cpu: Clarify overloading of reset QOM methods

On 09.12.19 18:55, Greg Kurz wrote: > Each cpu subclass overloads the reset method of its parent class with > its own. But since it needs to call the parent method as well, it keeps > a parent_reset pointer to do so. This causes the same not very explicit > boiler plate to be duplicated all around

Re: [for-5.0 PATCH v2 1/3] cpu: Introduce CPUReset callback typedef

On Tue, 10 Dec 2019 at 10:39, Markus Armbruster wrote: > > Greg Kurz writes: > > diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h > > index 77c6f0529903..047e3972ecaf 100644 > > --- a/include/hw/core/cpu.h > > +++ b/include/hw/core/cpu.h > > @@ -74,6 +74,8 @@ typedef struct CPUWatchpoin

Re: [for-5.0 PATCH] ppc: Make PPCVirtualHypervisor an incomplete type

Philippe Mathieu-Daudé writes: > On 12/9/19 2:28 PM, Greg Kurz wrote: >> PPCVirtualHypervisor is an interface instance. It should never be >> dereferenced. Drop the dummy type definition for extra safety, which >> is the common practice with QOM interfaces. > > This "common practice" is also refe

Re: [PATCH v1 0/5] target/arm/kvm: Provide an option to adjust virtual time

On Tue, Dec 10, 2019 at 10:29:22AM +, Peter Maydell wrote: > On Tue, 10 Dec 2019 at 09:51, Andrea Bolognani wrote: > > > > On Fri, 2019-12-06 at 16:53 +0100, Andrew Jones wrote: > > > On Fri, Dec 06, 2019 at 03:22:58PM +, Peter Maydell wrote: > > > > On Wed, 16 Oct 2019 at 15:34, Andrew Jo

Re: [PATCH 0/2] tests/acceptance: Add boot vmlinux test

Cleber Rosa writes: > On Fri, Dec 06, 2019 at 09:00:10AM -0500, Wainer dos Santos Moschetta wrote: >> This series add a new acceptance test: boot an uncompressed >> Linux kernel built with CONFIG_PVH, so checking the PVH >> capability introduced in QEMU 4.0 works. >> >> The test implementation

Re: [PATCH 1/2] net: Drop the legacy "name" parameter from the -net option

Thomas Huth writes: > It's been deprecated since QEMU v3.1, so it's time to finally > remove it. The "id" parameter can simply be used instead. > > Signed-off-by: Thomas Huth [...] > diff --git a/qapi/net.json b/qapi/net.json > index 335295be50..ff280ccd16 100644 > --- a/qapi/net.json > +++ b/qa

Re: [PATCH 2/2] net: Drop the NetLegacy structure, always use Netdev instead

Thomas Huth writes: > Now that the "name" parameter is gone, there is hardly any difference > between NetLegacy and Netdev anymore. Drop NetLegacy and always use > Netdev to simplify the code quite a bit. > > Signed-off-by: Thomas Huth Took me a minute to see the actual difference. Here's Netd

Re: [PATCH 1/2] tests/acceptance: Add PVH boot test

On 12/6/19 3:00 PM, Wainer dos Santos Moschetta wrote: QEMU 4.0 onward is able to boot an uncompressed kernel image by using the x86/HVM direct boot ABI. It needs Linux >= 4.21 built with CONFIG_PVH=y. This introduces an acceptance test which checks an uncompressed Linux kernel image boots prope

Re: [PATCH 1/2] net: Drop the legacy "name" parameter from the -net option

On 10/12/2019 12.06, Markus Armbruster wrote: > Thomas Huth writes: > >> It's been deprecated since QEMU v3.1, so it's time to finally >> remove it. The "id" parameter can simply be used instead. >> >> Signed-off-by: Thomas Huth > [...] >> diff --git a/qapi/net.json b/qapi/net.json >> index 3352

Re: [PATCH v1 0/5] target/arm/kvm: Provide an option to adjust virtual time

On Tue, 10 Dec 2019 at 11:05, Andrew Jones wrote: > x86 developers could easily add this feature if/when they need a way to > disable their current default behavior. But, since the kvm-adjvtime > default would likely be 'on' for them, then they'd probably prefer the > feature be named kvm-no-adjvt

Re: [PATCH v2 07/18] vl: introduce object_parse_property_opt

On 12/9/19 4:01 PM, Paolo Bonzini wrote: We will reuse the parsing loop of machine_set_property soon for "-accel", but we do not want the "_" -> "-" conversion since "-accel" can just standardize on dashes. We will also add a bunch of legacy option handling to keep the QOM machine object clean.

Re: [PATCH v2 03/18] tcg: move qemu_tcg_configure to accel/tcg/tcg-all.c

On 12/9/19 4:01 PM, Paolo Bonzini wrote: Move everything related to mttcg_enabled in accel/tcg/tcg-all.c, which will make even more sense when "thread" becomes a QOM property. For now, initializing mttcg_enabled in the instance_init function prepares for the next patch, which will only invoke qe

Re: [PATCH v2 04/18] vl: extract accelerator option processing to a separate function

On 12/9/19 4:01 PM, Paolo Bonzini wrote: As a first step towards supporting multiple "-accel" options, push the late processing of -icount and -accel into a new function, and use qemu_opts_foreach to retrieve -accel options instead of stashing them into globals. Signed-off-by: Paolo Bonzini R

Re: [PATCH v2 05/18] vl: merge -accel processing into configure_accelerators

On 12/9/19 4:01 PM, Paolo Bonzini wrote: The next step is to move the parsing of "-machine accel=..." into vl.c, unifying it with the configure_accelerators() function that has just been introduced. This way, we will be able to desugar it into multiple "-accel" options, without polluting accel/a

Re: [PATCH v2 06/18] accel: compile accel/accel.c just once

On 12/9/19 4:01 PM, Paolo Bonzini wrote: Now that accel/accel.c does not use CONFIG_TCG or CONFIG_KVM anymore, it need not be compiled once for every softmmu target. Signed-off-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daudé --- Makefile.objs | 1 + accel/Makefile.objs | 2 +

Re: [PATCH v2 16/18] kvm: convert "-machine kvm_shadow_mem" to an accelerator property

On 12/9/19 4:01 PM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini --- accel/kvm/kvm-all.c | 43 +++ hw/core/machine.c | 39 --- include/hw/boards.h | 2 -- qemu-options.hx | 6 +++--- target/i386/kvm.c

Re: [PATCH v2 17/18] kvm: introduce kvm_kernel_irqchip_* functions

On 12/9/19 4:01 PM, Paolo Bonzini wrote: The KVMState struct is opaque, so provide accessors for the fields that will be moved from current_machine to the accelerator. For now they just forward to the machine object, but this will change. Signed-off-by: Paolo Bonzini Reviewed-by: Philippe Ma

Re: [PATCH v3 4/4] qom/object: Use common get/set uint helpers

Hi > On Dec 2, 2019, at 6:31 AM, Alexey Kardashevskiy wrote: > > > > On 30/11/2019 04:46, Felipe Franciosi wrote: >> Several objects implemented their own uint property getters and setters, >> despite them being straightforward (without any checks/validations on >> the values themselves) and i

Re: [PATCH v2 18/18] kvm: convert "-machine kernel_irqchip" to an accelerator property

On 12/9/19 4:01 PM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini --- accel/kvm/kvm-all.c | 59 ++- hw/core/machine.c | 61 - include/hw/boards.h | 3 --- qemu-options.hx | 9

Re: [PATCH v2 03/18] tcg: move qemu_tcg_configure to accel/tcg/tcg-all.c

Hi On Mon, Dec 9, 2019 at 7:07 PM Paolo Bonzini wrote: > > Move everything related to mttcg_enabled in accel/tcg/tcg-all.c, > which will make even more sense when "thread" becomes a QOM property. > > For now, initializing mttcg_enabled in the instance_init function > prepares for the next patch,

Re: [PATCH v2 10/18] qom: introduce object_register_sugar_prop

Hi On Mon, Dec 9, 2019 at 7:10 PM Paolo Bonzini wrote: > > Similar to the existing "-rtc driftfix" option, we will convert some > legacy "-machine" command line options to global properties on accelerators. > Because accelerators are not devices, we cannot use qdev_prop_register_global. > Instead

Re: [PATCH 2/2] hw/arm: ast2600: Wire up the eMMC controller

On 10/12/2019 01:52, Andrew Jeffery wrote: > Initialise another SDHCI model instance for the AST2600's eMMC > controller and use the SDHCI's num_slots value introduced previously to > determine whether we should create an SD card instance for the new slot. > > Signed-off-by: Andrew Jeffery LGTM.

Re: [PATCH v2 14/18] tcg: add "-accel tcg, tb-size" and deprecate "-tb-size"

Hi On Mon, Dec 9, 2019 at 7:17 PM Paolo Bonzini wrote: > > -tb-size fits nicely in the new framework for accelerator-specific options. > It > is a very niche option, so insta-deprecate it. > > Signed-off-by: Paolo Bonzini > --- > accel/tcg/tcg-all.c| 40 +++

[PATCH v3 0/5] MAINTAINERS: Fine adjustment for (mostly mips) content

From: Aleksandar Markovic v2->v3: - changed patches 2, 3, 4 on Philippe's request - add a patch on including acceptance test in MIPS section v1->v2: - removed patch on new git infrastructure section - added a patch that adds two files in Malta section The goal of this series is to:

[PATCH v3 4/5] MAINTAINERS: Add three files to Malta section

From: Aleksandar Markovic Add two files that were recently introduced in a refactoring, that Malta emulation relies on. They are added by this patch to Malta section, but they are not added to the general MIPS section, since they are really not MIPS-specific, and there may be some non-MIPS hardwa

[PATCH v3 5/5] MAINTAINERS: Add a file to MIPS section

From: Aleksandar Markovic File tests/acceptance/linux_ssh_mips_malta.py is crucial for entire MIPS platform, so add it to the MIPS section. The maintainership will be shared with others. Signed-off-by: Aleksandar Markovic --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAIN

[PATCH v3 2/5] MAINTAINERS: Adjust maintainership for Fulong 2E board

From: Aleksandar Markovic Change the maintainership for Fulong 2E board to improve its quality. Signed-off-by: Aleksandar Markovic Acked-by: Philippe Mathieu-Daudé --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index ac686e2..8b05

[PATCH v3 1/5] MAINTAINERS: Add a section on UI translation

From: Aleksandar Markovic There should be a person who will quickly evaluate new UI translation, and find a way to update existing ones should something changes in UI. Signed-off-by: Aleksandar Markovic --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINT

[PATCH v3 3/5] MAINTAINERS: Adjust maintainership for Malta board

From: Aleksandar Markovic Change the maintainership for Malta board to improve its quality. Acked-by: Aurelien Jarno Signed-off-by: Aleksandar Markovic --- MAINTAINERS | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 8b059f4..7803fe7 100

Re: [PATCH v2 15/18] xen: convert "-machine igd-passthru" to an accelerator property

Hi On Mon, Dec 9, 2019 at 7:12 PM Paolo Bonzini wrote: > > The first machine property to fall is Xen's Intel integrated graphics > passthrough. The "-machine igd-passthru" option does not set anymore > a property on the machine object, but desugars to a GlobalProperty on > accelerator objects. >

Re: [PATCH 2/2] Add -mem-shared option

On Tue, 10 Dec 2019 11:34:32 +0100 Markus Armbruster wrote: > Eduardo Habkost writes: > > > +Markus > > > > On Tue, Dec 03, 2019 at 03:43:03PM +0100, Igor Mammedov wrote: > >> On Tue, 3 Dec 2019 09:56:15 +0100 > >> Thomas Huth wrote: > >> > >> > On 02/12/2019 22.00, Eduardo Habkost wrote:

Re: [PATCH v3 3/5] MAINTAINERS: Adjust maintainership for Malta board

On 12/10/19 1:55 PM, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Change the maintainership for Malta board to improve its quality. > > Acked-by: Aurelien Jarno > Signed-off-by: Aleksandar Markovic > --- > MAINTAINERS | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-)

Re: [PATCH v3 4/5] MAINTAINERS: Add three files to Malta section

On 12/10/19 1:55 PM, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Add two files that were recently introduced in a refactoring, > that Malta emulation relies on. They are added by this patch > to Malta section, but they are not added to the general MIPS > section, since they are rea

Re: [bugfix ping2] Re: [PATCH v2 0/2] fix qcow2_can_store_new_dirty_bitmap

On 10.12.19 09:11, Max Reitz wrote: > On 09.12.19 23:03, Eric Blake wrote: >> On 12/9/19 11:58 AM, Max Reitz wrote: >>> On 09.12.19 17:30, Max Reitz wrote: On 02.12.19 15:09, Vladimir Sementsov-Ogievskiy wrote: > Hi again! > > Still forgotten bug-fix :( > > Is it too late f

Re: [PATCH] hw/usb: Introduce Kconfig switches for the CCID card devices

On 12/10/19 9:11 AM, Thomas Huth wrote: On 10/12/2019 08.43, Philippe Mathieu-Daudé wrote: On 12/10/19 8:20 AM, Thomas Huth wrote: In our downstream distribution of QEMU, we need more fine-grained control on the set of CCID card devices that we want to include. So let's introduce some proper Kc

Re: [PATCH] hw/usb: Introduce Kconfig switches for the CCID card devices

On 10/12/19 14:27, Philippe Mathieu-Daudé wrote: > On 12/10/19 9:11 AM, Thomas Huth wrote: >> On 10/12/2019 08.43, Philippe Mathieu-Daudé wrote: >>> On 12/10/19 8:20 AM, Thomas Huth wrote: In our downstream distribution of QEMU, we need more fine-grained control on the set of CCID card de

Re: [PATCH v1 0/5] target/arm/kvm: Provide an option to adjust virtual time

On Tue, Dec 10, 2019 at 11:48:38AM +, Peter Maydell wrote: > On Tue, 10 Dec 2019 at 11:05, Andrew Jones wrote: > > x86 developers could easily add this feature if/when they need a way to > > disable their current default behavior. But, since the kvm-adjvtime > > default would likely be 'on' fo

Re: [PATCH v6 0/2] arm/acpi: simplify aml code and enable SHPC

On Mon, 9 Dec 2019 17:51:10 + Peter Maydell wrote: > On Mon, 9 Dec 2019 at 06:38, Heyi Guo wrote: > > > > After the introduction of generic PCIe root port and PCIe-PCI bridge, we > > will > > also have SHPC controller on ARM, and we don't support ACPI hot plug, so > > just > > enable SHPC

[PATCH 0/2] ppc/pnv: minor XSCOM fixes

Hello, Here are a couple of fixes/cleanups for the PowerNV XSCOM bus. Thanks, C. Cédric Le Goater (2): ppc/pnv: Loop on the whole hierarchy to populate the DT with the XSCOM nodes ppc/pnv: populate the DT with realized XSCOM devices hw/ppc/pnv_xscom.c | 12 ++-- 1 file change

[PATCH 1/2] ppc/pnv: Loop on the whole hierarchy to populate the DT with the XSCOM nodes

Some PnvXScomInterface objects lie a bit deeper (PnvPBCQState) than the first layer, so we need to loop on the whole object hierarchy to catch them. Signed-off-by: Cédric Le Goater --- hw/ppc/pnv_xscom.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/ppc/pnv_xscom.c

[PATCH 2/2] ppc/pnv: populate the DT with realized XSCOM devices

Some devices could be initialized in the instance_init handler but not realized for configuration reasons. Nodes should not be added in the DT for such devices. Signed-off-by: Cédric Le Goater --- hw/ppc/pnv_xscom.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/ppc/p

Re: [PATCH v6 0/2] arm/acpi: simplify aml code and enable SHPC

On Tue, 10 Dec 2019 at 13:49, Igor Mammedov wrote: > > On Mon, 9 Dec 2019 17:51:10 + > Peter Maydell wrote: > > > On Mon, 9 Dec 2019 at 06:38, Heyi Guo wrote: > > > > > > After the introduction of generic PCIe root port and PCIe-PCI bridge, we > > > will > > > also have SHPC controller on A

Re: 回复: 回复: 答复: [Qemu-devel] migrate_set_speed has no effect if the guest is using hugepages.

* Lin Ma (l...@suse.com) wrote: > Hi Dave, > > The patch fixed the issue, The rate limit with hugepages works well. > Thanks for your help! No problem; thank you for reporting and testing it. Dave > Lin > > > -邮件原件- > > 发件人: Dr. David Alan Gilbert > > 发送时间: 2019年12月5日 18:32 > > 收件人: L

[PATCH v3] net/imx_fec: Adding support for MAC filtering in the FEC IP implementation.

From: bwasim This addition ensures that the IP does NOT boot up in promiscuous mode by default, and so the software only receives the desired packets(Unicast, Broadcast, Unicast / Multicast hashed) by default. The software running on-top of QEMU can also modify these settings and disable receptio

Re: [PATCH v1 0/5] target/arm/kvm: Provide an option to adjust virtual time

On Tue, 2019-12-10 at 14:32 +0100, Andrew Jones wrote: > After having done this git mining, it looks more and more like we should > at least consider naming this feature 'kvm-no-adjvtime' and probably > also change arm's default. I agree with everything except the naming: why would kvm-no-adjvt

Re: [PATCH v1 0/5] target/arm/kvm: Provide an option to adjust virtual time

On Tue, Dec 10, 2019 at 03:21:02PM +0100, Andrea Bolognani wrote: > On Tue, 2019-12-10 at 14:32 +0100, Andrew Jones wrote: > > After having done this git mining, it looks more and more like we should > > at least consider naming this feature 'kvm-no-adjvtime' and probably > > also change arm's defa

Re: [PATCH] qapi: better document NVMe blockdev @device parameter

Am 06.12.2019 um 15:38 hat Daniel P. Berrangé geschrieben: > Mention that this is a PCI device address & give the format it is > expected it. Also mention that it must be first unbound from any > host kernel driver. > > Signed-off-by: Daniel P. Berrangé Thanks, applied to the block branch. Kevi

Re: [PATCH] qemu-img: fix info --backing-chain --image-opts

Am 05.12.2019 um 14:46 hat Stefan Hajnoczi geschrieben: > Only apply --image-opts to the topmost image when listing an entire > backing chain. It is incorrect to treat backing filenames as image > options. Assuming we have the backing chain t.IMGFMT.base <- > t.IMGFMT.mid <- t.IMGFMT, qemu-img in

Re: [PATCH v1 0/5] target/arm/kvm: Provide an option to adjust virtual time

On Tue, 10 Dec 2019 at 13:33, Andrew Jones wrote: > So the ins and outs of this particular timekeeping issue (to the best of > my knowledge) is that x86 has implemented this behavior since > 00f4d64ee76e ("kvmclock: clock should count only if vm is running"), which > was committed over six years a

Re: [PATCH v1 0/5] target/arm/kvm: Provide an option to adjust virtual time

On Tue, 2019-12-10 at 15:33 +0100, Andrew Jones wrote: > On Tue, Dec 10, 2019 at 03:21:02PM +0100, Andrea Bolognani wrote: > > I agree with everything except the naming: why would > > > > kvm-no-adjvtime=off vtime is adjusted (default) > > kvm-no-adjvtime=on vtime is not adjusted > >

Re: [PATCH v1 2/5] timer: arm: Introduce functions to get the host cntfrq

On Wed, 16 Oct 2019 at 15:34, Andrew Jones wrote: > > When acceleration like KVM is in use it's necessary to use the host's > counter frequency when converting ticks to or from time units. > > Signed-off-by: Andrew Jones > Reviewed-by: Richard Henderson > --- > include/qemu/timer.h | 16 +++

Re: [PATCH v1 3/5] target/arm/kvm: Implement cpu feature kvm-adjvtime

On Wed, 16 Oct 2019 at 15:34, Andrew Jones wrote: > > When kvm-adjvtime is enabled the guest's cntvct[_el0] won't count > the time when the VM is stopped. That time is skipped by updating > cntvoff[_el2] on each transition to vm_running using the current > QEMU_CLOCK_VIRTUAL time. QEMU_CLOCK_VIRTU

Re: [PATCH v1 0/5] target/arm/kvm: Provide an option to adjust virtual time

On Tue, Dec 10, 2019 at 04:47:49PM +0100, Andrea Bolognani wrote: > On Tue, 2019-12-10 at 15:33 +0100, Andrew Jones wrote: > > On Tue, Dec 10, 2019 at 03:21:02PM +0100, Andrea Bolognani wrote: > > > I agree with everything except the naming: why would > > > > > > kvm-no-adjvtime=off vtime is ad

Re: [PATCH v1 3/5] target/arm/kvm: Implement cpu feature kvm-adjvtime

On Tue, Dec 10, 2019 at 03:54:11PM +, Peter Maydell wrote: > On Wed, 16 Oct 2019 at 15:34, Andrew Jones wrote: > > > > When kvm-adjvtime is enabled the guest's cntvct[_el0] won't count > > the time when the VM is stopped. That time is skipped by updating > > cntvoff[_el2] on each transition to

Re: [PATCH v38 00/22] QEMU AVR 8 bit cores

On Sun, Dec 8, 2019 at 7:39 PM Michael Rolnik wrote: > > This series of patches adds 8bit AVR cores to QEMU. I get several strange messages about "new blank lines at EOF" while applying this series via patchwork: (check the last line of involved files) rtrk@rtrkw774-lin:~/Build/qemu-rolnik$ ~/pw

Re: [for-5.0 PATCH v2 1/3] cpu: Introduce CPUReset callback typedef

On Tue, 10 Dec 2019 11:39:00 +0100 Markus Armbruster wrote: > Greg Kurz writes: > > > Use it in include/hw/core/cpu.h and convert all targets to use it as > > well with: > > > > perl -pi \ > > -e 's/void\s+\(\*(parent_reset)\)\(CPUState\s+\*\w+\)/CPUReset \1/;' \ > > $(git ls-files 'target/*.

Re: [PATCH for-5.0 v11 02/20] virtio-iommu: Add skeleton

Hi Eric, On Fri, Nov 22, 2019 at 07:29:25PM +0100, Eric Auger wrote: > +typedef struct VirtIOIOMMU { > +VirtIODevice parent_obj; > +VirtQueue *req_vq; > +VirtQueue *event_vq; > +struct virtio_iommu_config config; > +uint64_t features; > +uint64_t acked_features; We already

Re: [PATCH for-5.0 v11 03/20] virtio-iommu: Decode the command payload

On Fri, Nov 22, 2019 at 07:29:26PM +0100, Eric Auger wrote: > This patch adds the command payload decoding and > introduces the functions that will do the actual > command handling. Those functions are not yet implemented. > > Signed-off-by: Eric Auger Reviewed-by: Jean-Philippe Brucker Which

Re: [PATCH v38 15/22] target/avr: Add example board configuration

On Mon, Dec 9, 2019 at 7:38 PM Michael Rolnik wrote: > > I will check again. > On my test bed: ... CC riscv32-softmmu/hw/virtio/virtio-serial-pci.o CC riscv32-softmmu/hw/riscv/boot.o /home/rtrk/Build/qemu-rolnik/hw/riscv/boot.c: In function ‘riscv_load_kernel’: /home/rtrk/Build/qe

Re: [for-5.0 PATCH v2 1/3] cpu: Introduce CPUReset callback typedef

On Tue, 10 Dec 2019 10:42:51 + Peter Maydell wrote: > On Tue, 10 Dec 2019 at 10:39, Markus Armbruster wrote: > > > > Greg Kurz writes: > > > diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h > > > index 77c6f0529903..047e3972ecaf 100644 > > > --- a/include/hw/core/cpu.h > > > +++ b

Re: [PATCH for-5.0 v11 04/20] virtio-iommu: Add the iommu regions

Two small things below, but looks good overall Reviewed-by: Jean-Philippe Brucker On Fri, Nov 22, 2019 at 07:29:27PM +0100, Eric Auger wrote: > +static AddressSpace *virtio_iommu_find_add_as(PCIBus *bus, void *opaque, > + int devfn) > +{ > +VirtIO

Re: [PATCH for-5.0 v11 05/20] virtio-iommu: Endpoint and domains structs and helpers

On Fri, Nov 22, 2019 at 07:29:28PM +0100, Eric Auger wrote: > +typedef struct viommu_domain { > +uint32_t id; > +GTree *mappings; > +QLIST_HEAD(, viommu_endpoint) endpoint_list; > +} viommu_domain; > + > +typedef struct viommu_endpoint { > +uint32_t id; > +viommu_domain *domain;

Re: [PATCH v3] qga: fence guest-set-time if hwclock not available

On 12/9/19 7:33 PM, Cornelia Huck wrote: On Fri, 06 Dec 2019 08:17:27 +0100 Markus Armbruster wrote: Cornelia Huck writes: On Thu, 5 Dec 2019 14:05:19 +0100 Philippe Mathieu-Daudé wrote: Hi Cornelia, On 12/5/19 12:53 PM, Cornelia Huck wrote: The Posix implementation of guest-set-time

Re: [RFC PATCH 4/9] vfio-pci: register default dynamic-trap-bar-info region

On Tue, 10 Dec 2019 02:44:44 -0500 Yan Zhao wrote: > On Tue, Dec 10, 2019 at 05:16:08AM +0800, Alex Williamson wrote: > > On Mon, 9 Dec 2019 01:22:12 -0500 > > Yan Zhao wrote: > > > > > On Fri, Dec 06, 2019 at 11:20:38PM +0800, Alex Williamson wrote: > > > > On Fri, 6 Dec 2019 01:04:07 -050

Re: [PATCH v1 2/5] timer: arm: Introduce functions to get the host cntfrq

On Tue, Dec 10, 2019 at 03:47:39PM +, Peter Maydell wrote: > On Wed, 16 Oct 2019 at 15:34, Andrew Jones wrote: > > > > When acceleration like KVM is in use it's necessary to use the host's > > counter frequency when converting ticks to or from time units. > > > > Signed-off-by: Andrew Jones >

Re: [PATCH for-5.0 v11 06/20] virtio-iommu: Implement attach/detach command

On Fri, Nov 22, 2019 at 07:29:29PM +0100, Eric Auger wrote: > diff --git a/hw/virtio/virtio-iommu.c b/hw/virtio/virtio-iommu.c > index 235bde2203..138d5b2a9c 100644 > --- a/hw/virtio/virtio-iommu.c > +++ b/hw/virtio/virtio-iommu.c > @@ -77,11 +77,12 @@ static gint interval_cmp(gconstpointer a, gcon

Re: [PATCH for-5.0 v11 07/20] virtio-iommu: Implement map/unmap

On Fri, Nov 22, 2019 at 07:29:30PM +0100, Eric Auger wrote: > @@ -238,10 +244,35 @@ static int virtio_iommu_map(VirtIOIOMMU *s, > uint64_t virt_start = le64_to_cpu(req->virt_start); > uint64_t virt_end = le64_to_cpu(req->virt_end); > uint32_t flags = le32_to_cpu(req->flags); > +v

Re: [PATCH for-5.0 v11 08/20] virtio-iommu: Implement translate

On Fri, Nov 22, 2019 at 07:29:31PM +0100, Eric Auger wrote: > This patch implements the translate callback > > Signed-off-by: Eric Auger Reviewed-by: Jean-Philippe Brucker

Re: [PATCH for-5.0 v11 09/20] virtio-iommu: Implement fault reporting

On Fri, Nov 22, 2019 at 07:29:32PM +0100, Eric Auger wrote: > @@ -443,6 +489,8 @@ static IOMMUTLBEntry > virtio_iommu_translate(IOMMUMemoryRegion *mr, hwaddr addr, > if (!ep) { > if (!bypass_allowed) { > error_report_once("%s sid=%d is not known!!", __func__, sid); > +

Re: [PATCH for-5.0 v11 10/20] virtio-iommu-pci: Add virtio iommu pci support

On Fri, Nov 22, 2019 at 07:29:33PM +0100, Eric Auger wrote: > This patch adds virtio-iommu-pci, which is the pci proxy for > the virtio-iommu device. > > Signed-off-by: Eric Auger Reviewed-by: Jean-Philippe Brucker

Re: [PATCH for-5.0 v11 14/20] virtio-iommu: Handle reserved regions in the translation process

On Fri, Nov 22, 2019 at 07:29:37PM +0100, Eric Auger wrote: > +for (i = 0; i < s->nb_reserved_regions; i++) { > +if (interval.low >= s->reserved_regions[i].low && > +interval.low <= s->reserved_regions[i].high) { > +switch (s->reserved_regions[i].type) { > +

Re: [PATCH for-5.0 v11 15/20] virtio-iommu-pci: Add array of Interval properties

On Fri, Nov 22, 2019 at 07:29:38PM +0100, Eric Auger wrote: > The machine may need to pass reserved regions to the > virtio-iommu-pci device (such as the MSI window on x86). > So let's add an array of Interval properties. > > Signed-off-by: Eric Auger Reviewed-by: Jean-Philippe Brucker

Re: [PATCH for-5.0 v11 18/20] virtio-iommu: Support migration

On Fri, Nov 22, 2019 at 07:29:41PM +0100, Eric Auger wrote: > +static const VMStateDescription vmstate_virtio_iommu_device = { > +.name = "virtio-iommu-device", > +.minimum_version_id = 1, > +.version_id = 1, > +.post_load = iommu_post_load, > +.fields = (VMStateField[]) { > +

Re: [PATCH for-5.0 v11 11/20] hw/arm/virt: Add the virtio-iommu device tree mappings

On Fri, Nov 22, 2019 at 07:29:34PM +0100, Eric Auger wrote: > diff --git a/hw/virtio/virtio-iommu-pci.c b/hw/virtio/virtio-iommu-pci.c > index 280230b31e..4cfae1f9df 100644 > --- a/hw/virtio/virtio-iommu-pci.c > +++ b/hw/virtio/virtio-iommu-pci.c > @@ -31,9 +31,6 @@ struct VirtIOIOMMUPCI { > > s

Re: [PATCH for-5.0 v11 16/20] hw/arm/virt-acpi-build: Introduce fill_iort_idmap helper

On Fri, Nov 22, 2019 at 07:29:39PM +0100, Eric Auger wrote: > build_iort(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms) > { > @@ -426,13 +437,12 @@ build_iort(GArray *table_data, BIOSLinker *linker, > VirtMachineState *vms) > smmu->gerr_gsiv = cpu_to_le32(irq + 2); >

  1   2   >