I think it makes sense to collect *all* block HMP stuff here.
Left in monitor/hmp-cmds.c: hmp_eject(), hmp_nbd_server_start(), ...
I guess hmp_change() has to stay there, because it's both block and ui.
Left in blockdev.c: hmp_drive_add_node().
Quick grep for possible files to check:
$ git-gre
On Wed, 27 Nov 2019 09:37:57 +0800
Xiang Zheng wrote:
> Hi Igor,
>
> Thanks for your review!
> Since the series of patches are going to be merged, we will address your
> comments by follow up patches.
Yes, I know it's quite frustrating to respin series multiple times,
but on the other hand it'
In ACPI 6.3 chapter 5.2.27 Heterogeneous Memory Attribute Table (HMAT),
The initiator represents processor which access to memory. And in 5.2.27.3
Memory Proximity Domain Attributes Structure, the attached initiator is
defined as where the memory controller responsible for a memory proximity
domain
This series of patches will build Heterogeneous Memory Attribute Table (HMAT)
according to the command line. The ACPI HMAT describes the memory attributes,
such as memory side cache attributes and bandwidth and latency details,
related to the Memory Proximity Domain.
The software is expected to use
From: Liu Jingqi
Add -numa hmat-lb option to provide System Locality Latency and
Bandwidth Information. These memory attributes help to build
System Locality Latency and Bandwidth Information Structure(s)
in ACPI Heterogeneous Memory Attribute Table (HMAT).
Signed-off-by: Liu Jingqi
Signed-off-
From: Liu Jingqi
Add -numa hmat-cache option to provide Memory Side Cache Information.
These memory attributes help to build Memory Side Cache Information
Structure(s) in ACPI Heterogeneous Memory Attribute Table (HMAT).
Reviewed-by: Igor Mammedov
Reviewed-by: Daniel Black
Signed-off-by: Liu J
From: Liu Jingqi
HMAT is defined in ACPI 6.3: 5.2.27 Heterogeneous Memory Attribute Table
(HMAT). The specification references below link:
http://www.uefi.org/sites/default/files/resources/ACPI_6_3_final_Jan30.pdf
It describes the memory attributes, such as memory side cache
attributes and bandw
From: Liu Jingqi
This structure describes the memory access latency and bandwidth
information from various memory access initiator proximity domains.
The latency and bandwidth numbers represented in this structure
correspond to rated latency and bandwidth for the platform.
The software could use
Check configuring HMAT usecase
Reviewed-by: Igor Mammedov
Suggested-by: Igor Mammedov
Signed-off-by: Tao Xu
---
Changes in v18:
- Rewrite the lines over 80 characters
Chenges in v17:
- Add some fail test cases (Igor)
---
tests/numa-test.c | 197 +++
From: Liu Jingqi
This structure describes memory side cache information for memory
proximity domains if the memory side cache is present and the
physical device forms the memory side cache.
The software could use this information to effectively place
the data in memory to maximize the performance
ACPI table HMAT has been introduced, QEMU now builds HMAT tables for
Heterogeneous Memory with boot option '-numa node'.
Add test cases on PC and Q35 machines with 2 numa nodes.
Because HMAT is generated when system enable numa, the
following tables need to be added for this test:
tests/data/a
Currently GPIOs can only be referred to by GPIO controller and offset in
GPIO lookup tables.
Add support for looking them up by line name.
Signed-off-by: Geert Uytterhoeven
---
If this is rejected, the GPIO Aggregator documentation and code must be
updated.
v3:
- New.
---
drivers/gpio/gpioli
Add a maintainership section for the GPIO Aggregator/Repeater, covering
documentation, Device Tree bindings, and driver source code.
Signed-off-by: Geert Uytterhoeven
---
Harish: Do you want to be listed as maintainer, too?
v3:
- New.
---
MAINTAINERS | 8
1 file changed, 8 insertions
Currently GPIO controllers can only be referred to by label in GPIO
lookup tables.
Add support for looking them up by "gpiochipN" name, with "N" either the
corresponding GPIO device's ID number, or the GPIO controller's first
GPIO number.
Signed-off-by: Geert Uytterhoeven
---
If this is rejected
Title is too long. blockdev-hmp-cmds.c will become
block/monitor/block-hmp-cmds.c in v2. With this in mind, suggest
block/monitor: Prefer to use hmp_handle_error() to report HMP errors
Maxim Levitsky writes:
> This way they all will be prefixed with 'Error:' which some parsers
> (e.g libv
The string literal "gpiochip" is used in several places.
Add a definition for it, and use it everywhere, to make sure everything
stays in sync.
Signed-off-by: Geert Uytterhoeven
---
v3:
- New.
---
drivers/gpio/gpiolib-sysfs.c | 7 +++
drivers/gpio/gpiolib.c | 4 ++--
drivers/gpio/gpi
Add Device Tree bindings for a GPIO repeater, with optional translation
of physical signal properties. This is useful for describing explicitly
the presence of e.g. an inverter on a GPIO line, and was inspired by the
non-YAML gpio-inverter bindings by Harish Jenny K N
[1].
Note that this is diffe
Hi all,
GPIO controllers are exported to userspace using /dev/gpiochip*
character devices. Access control to these devices is provided by
standard UNIX file system permissions, on an all-or-nothing basis:
either a GPIO controller is accessible for a user, or it is not.
Currently no mechan
Document the GPIO Aggregator/Repeater, and the three typical use-cases.
Signed-off-by: Geert Uytterhoeven
---
v3:
- New.
---
.../admin-guide/gpio/gpio-aggregator.rst | 111 ++
Documentation/admin-guide/gpio/index.rst | 1 +
2 files changed, 112 insertions(+)
create
GPIO controllers are exported to userspace using /dev/gpiochip*
character devices. Access control to these devices is provided by
standard UNIX file system permissions, on an all-or-nothing basis:
either a GPIO controller is accessible for a user, or it is not.
Currently no mechanism exists to con
On 25/11/2019 11.28, Alex Bennée wrote:
Alex Bennée writes:
Thomas Huth writes:
Travis recently added build hosts for arm64, ppc64le and s390x, so
this is a welcome addition to our Travis testing matrix.
Unfortunately, the builds are running in quite restricted LXD containers
there, for e
On Mon, 25 Nov 2019 07:58:16 +0100
Cédric Le Goater wrote:
> We will use it to resend missed interrupts when a vCPU context is
> pushed on a HW thread.
>
> Signed-off-by: Cédric Le Goater
> ---
> include/hw/ppc/xive.h | 1 +
> hw/intc/xive.c| 21 +++--
> 2 files change
Patchew URL: https://patchew.org/QEMU/20191127082613.22903-1-tao3...@intel.com/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#
On 2019-11-26 21:04, Richard Henderson wrote:
On 11/23/19 11:56 AM, Marc Zyngier wrote:
HCR_EL2.TID3 mandates that access from EL1 to a long list of id
registers traps to EL2, and QEMU has so far ignored this
requirement.
This breaks (among other things) KVM guests that have PtrAuth
enabled,
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote:
> On 11/26/19 10:19 AM, no-re...@patchew.org wrote:
> > Patchew URL:
> > https://patchew.org/QEMU/20191126085936.1689-1-pbonz...@redhat.com/
> >
> > This series failed the docker-quick@centos7 build test. Please find the
> > testing commands an
On Wed, Nov 27, 2019 at 09:14:01AM +, Dr. David Alan Gilbert wrote:
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote:
On 11/26/19 10:19 AM, no-re...@patchew.org wrote:
> Patchew URL:
https://patchew.org/QEMU/20191126085936.1689-1-pbonz...@redhat.com/
>
> This series failed the docker-quic
Yuri Benditovich writes:
> On Wed, Nov 27, 2019 at 8:36 AM Markus Armbruster wrote:
>>
>> Yuri Benditovich writes:
>>
>> > If the redirected device has this capability, Windows guest may
>> > place the device into D2 and expect it to wake when the device
>> > becomes active, but this will never
On Wed, Nov 27, 2019 at 09:36:21AM +0200, Yuri Benditovich wrote:
> On Wed, Nov 27, 2019 at 8:36 AM Markus Armbruster wrote:
> >
> > Yuri Benditovich writes:
> >
> > > If the redirected device has this capability, Windows guest may
> > > place the device into D2 and expect it to wake when the dev
Tao Xu writes:
> In ACPI 6.3 chapter 5.2.27 Heterogeneous Memory Attribute Table (HMAT),
> The initiator represents processor which access to memory. And in 5.2.27.3
> Memory Proximity Domain Attributes Structure, the attached initiator is
> defined as where the memory controller responsible for
Tao Xu writes:
> From: Liu Jingqi
>
> Add -numa hmat-lb option to provide System Locality Latency and
> Bandwidth Information. These memory attributes help to build
> System Locality Latency and Bandwidth Information Structure(s)
> in ACPI Heterogeneous Memory Attribute Table (HMAT).
Please men
On Tuesday, November 26, 2019, wrote:
> From: Aaron Dominick
>
> ---
Your commit message is poor. You should have clearly explained what do you
do in this cleanup, and why.
Aleksandar
> hw/display/atom-bits.h | 48 -
> hw/display/atom-names.h | 100 -
> hw/display/ato
Tao Xu writes:
> From: Liu Jingqi
>
> Add -numa hmat-cache option to provide Memory Side Cache Information.
> These memory attributes help to build Memory Side Cache Information
> Structure(s) in ACPI Heterogeneous Memory Attribute Table (HMAT).
Please mention this requires -machine hmat=on.
>
Hi,
The following 2 patches fix some error and deprecation warnings with
python 3. It drops usage of numpy and python 2 support.
Marc-André Lureau (2):
analyze-migration.py: fix find() type error
analyze-migration.py: replace numpy with python 3.2
scripts/analyze-migration.py | 39 +
Use int.from_bytes() from python 3.2 instead.
Signed-off-by: Marc-André Lureau
---
scripts/analyze-migration.py | 35 +++
1 file changed, 19 insertions(+), 16 deletions(-)
diff --git a/scripts/analyze-migration.py b/scripts/analyze-migration.py
index 2b835d9b70..
Traceback (most recent call last):
File "../scripts/analyze-migration.py", line 611, in
dump.read(desc_only = True)
File "../scripts/analyze-migration.py", line 513, in read
self.load_vmsd_json(file)
File "../scripts/analyze-migration.py", line 556, in load_vmsd_json
vmsd_json =
On Wed, 27 Nov 2019 09:40:14 +0800
Xiang Zheng wrote:
> Hi,
>
> On 2019/11/16 0:37, Igor Mammedov wrote:
> > On Mon, 11 Nov 2019 09:40:47 +0800
> > Xiang Zheng wrote:
> >
> >> From: Dongjiu Geng
> >>
> >> Add a SIGBUS signal handler. In this handler, it checks the SIGBUS type,
> >> translat
On Wed, Nov 27, 2019 at 11:40 AM Gerd Hoffmann wrote:
>
> On Wed, Nov 27, 2019 at 09:36:21AM +0200, Yuri Benditovich wrote:
> > On Wed, Nov 27, 2019 at 8:36 AM Markus Armbruster wrote:
> > >
> > > Yuri Benditovich writes:
> > >
> > > > If the redirected device has this capability, Windows guest
* Daniel Cho (daniel...@qnap.com) wrote:
> Hello everyone,
>
> Could we ssh to colo VM (means PVM & SVM are starting)?
>
Lets cc in Zhang Chen and Lukas Straub.
> SSH will connect to colo VM for a while, but it will disconnect with error
> *client_loop: send disconnect: Broken pipe*
>
> It see
On 2019/11/25 17:48, Igor Mammedov wrote:
>>>..
>>> bios_linker_loader_add_pointer(linker, ACPI_BUILD_TABLE_FILE,
>>> ACPI_GHES_ERROR_STATUS_ADDRESS_OFFSET(hest_start, source_id),
>>> sizeof(uint64_t), ACPI_GHES_ERRORS_FW_CFG_FILE,
>>> source_id * sizeof(uint64_t
* Eric Auger (eric.au...@redhat.com) wrote:
> Support QLIST migration using the same principle as QTAILQ:
> 94869d5c52 ("migration: migrate QTAILQ").
>
> The VMSTATE_QLIST_V macro has the same proto as VMSTATE_QTAILQ_V.
> The change mainly resides in QLIST RAW macros: QLIST_RAW_INSERT_HEAD
> and Q
Add a function to be called when a graphic update is done.
Declare the QXL renderer as async: render_update_cookie_num counts the
number of outstanding updates, and graphic_hw_update_done() is called
when it reaches none.
(note: this is preliminary work for asynchronous screendump support)
Signe
Hi,
The following patches have been extracted from the "[PATCH v6 00/25]
monitor: add asynchronous command type", as they are
reviewable/mergeable independantly.
They introduce some internal API changes, and fix
qemu_open()/qemu_close()/unlink() misusages which should be quite
harmless.
Marc-And
This will allow to pre-open the file before running the async finish
handler and avoid potential monitor fdset races.
(note: this is preliminary work for asynchronous screendump support)
Signed-off-by: Marc-André Lureau
---
ui/console.c| 45 ++---
ui/
Don't attempt to remove /dev/fdset files.
Signed-off-by: Marc-André Lureau
---
ui/console.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/console.c b/ui/console.c
index 587edf4ed4..e6ac462aa0 100644
--- a/ui/console.c
+++ b/ui/console.c
@@ -381,7 +381,7 @@ void qmp_scree
The file opened for ppm_save() may be a /dev/fdset, in which case a
dup fd is added to the fdset. It should be removed by calling
qemu_close(), instead of the implicit close() on fclose().
I don't see a convenient way to solve that with stdio streams, so I
switched the code to QIOChannel which use
Signed-off-by: Marc-André Lureau
---
include/qom/object.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/qom/object.h b/include/qom/object.h
index 128d00c77f..f96a44be64 100644
--- a/include/qom/object.h
+++ b/include/qom/object.h
@@ -1747,4 +1747,7 @@ Object *container_get(Object
Signed-off-by: Marc-André Lureau
---
include/ui/qemu-pixman.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/ui/qemu-pixman.h b/include/ui/qemu-pixman.h
index 0668109305..3b7cf70157 100644
--- a/include/ui/qemu-pixman.h
+++ b/include/ui/qemu-pixman.h
@@ -90,4 +90,6 @@ void qemu_pix
Add a helper function to match qemu_open() which may return files
under the /dev/fdset prefix. Those shouldn't be removed, since it's
only a qemu namespace.
Signed-off-by: Marc-André Lureau
---
include/qemu/osdep.h | 1 +
util/osdep.c | 15 +++
2 files changed, 16 insertions
Doing this allows running this test with e.g. -o compat=0.10 or
-o compat=refcount_bits=1.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/273 | 3 ++-
tests/qemu-iotests/273.out | 27 ---
2 files changed, 2 insertions(+), 28 deletions(-)
diff --git a/tests/qemu-iot
* Eric Auger (eric.au...@redhat.com) wrote:
> Add Migration support. We rely on recently added gtree and qlist
> migration. Besides, we have to fixup end point <-> domain link.
>
> Indeed each domain has a list of endpoints attached to it. And each
> endpoint has a pointer to its domain.
>
> Raw
Hi
On Mon, Nov 25, 2019 at 5:04 PM Philippe Mathieu-Daudé
wrote:
>
> On 11/25/19 1:54 PM, Philippe Mathieu-Daudé wrote:
> > On 11/25/19 12:26 PM, Philippe Mathieu-Daudé wrote:
> >> On 11/25/19 11:12 AM, Marc-André Lureau wrote:
> >>> Hi
> >>>
> >>> On Mon, Nov 25, 2019 at 2:07 PM Aleksandar Marko
On Wednesday, November 27, 2019, Marc-André Lureau <
marcandre.lur...@redhat.com> wrote:
> Hi
>
> On Mon, Nov 25, 2019 at 5:04 PM Philippe Mathieu-Daudé
> wrote:
> >
> > On 11/25/19 1:54 PM, Philippe Mathieu-Daudé wrote:
> > > On 11/25/19 12:26 PM, Philippe Mathieu-Daudé wrote:
> > >> On 11/25/19
On Wednesday, November 20, 2019, Marc-André Lureau <
marcandre.lur...@redhat.com> wrote:
> The function is specific to mipssim, let's inline it.
>
> Signed-off-by: Marc-André Lureau
> ---
> hw/char/serial.c | 16
> hw/mips/mips_mipssim.c | 15 ---
> include
On Wednesday, November 20, 2019, Marc-André Lureau <
marcandre.lur...@redhat.com> wrote:
> Register the memory region with sysbus_init_mmio() and look it up with
> sysbus_mmio_get_region() to avoid accessing internal device fields.
>
> Suggested-by: Peter Maydell
> Signed-off-by: Marc-André Lurea
Patchew URL:
https://patchew.org/QEMU/20191127115202.375107-1-marcandre.lur...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH 0/7] console: screendump improvements
Type: series
Message-id: 20191127115202.375107-1-ma
On Wednesday, November 20, 2019, Marc-André Lureau <
marcandre.lur...@redhat.com> wrote:
> Signed-off-by: Marc-André Lureau
> ---
> hw/mips/mips_mipssim.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>
I agree with the change, and with overall series in general, but please add
at
On 27.11.19 07:20, pannengy...@huawei.com wrote:
> From: PanNengyuan
>
> This avoid a memory leak when qom-set is called to set throttle_group
> limits, here is an easy way to reproduce:
>
> 1. run qemu-iotests as follow and check the result with asan:
>./check -qcow2 184
>
> Following
Stefan, thanks for answering.
When the packet is received, e1000 writes it to memory directrly
without any RCU.
The address of memory for writing is set by the driver from dpdk driver.
Driver writes to RDBA (RDBAH,RDBAL) base address of ring.
It turns out that MMIO RCU (mentioned from e1000_mmio_
Hi Beata,
Thanks for you review!
On 2019/11/22 23:47, Beata Michalska wrote:
> Hi,
>
> On Mon, 11 Nov 2019 at 01:48, Xiang Zheng wrote:
>>
>> From: Dongjiu Geng
>>
>> Add a SIGBUS signal handler. In this handler, it checks the SIGBUS type,
>> translates the host VA delivered by host to guest P
On Wed, 27 Nov 2019 20:47:15 +0800
Xiang Zheng wrote:
> Hi Beata,
>
> Thanks for you review!
>
> On 2019/11/22 23:47, Beata Michalska wrote:
> > Hi,
> >
> > On Mon, 11 Nov 2019 at 01:48, Xiang Zheng wrote:
> >>
> >> From: Dongjiu Geng
> >>
> >> Add a SIGBUS signal handler. In this handler,
On 25.11.19 18:43, Daniel P. Berrangé wrote:
> When initializing the LUKS header the size with default encryption
> parameters will currently be 2068480 bytes. This is rounded up to
> a multiple of the cluster size, 2081792, with 64k sectors. If the
> end of the header is not the same as the end of
Signed-off-by: Max Reitz
---
block.c | 22 --
block/backup-top.c | 3 ++-
block/blkdebug.c| 5 +++--
block/blklogwrites.c| 9 +
block/commit.c | 1 +
block/copy-on-read.c| 1 +
block/mirror.c
Based-on: <2019160216.197086-1-mre...@redhat.com>
(“block: Fix check_to_replace_node()”)
This is preliminary work for v7 of “Deal with filters”. As Kevin has
noted, there may be e.g. multiple storage children, and there should
probably be some way for drivers to signal what they use each chil
Any current user of child_file, child_format, and child_backing can and
should use this generic BdrvChildClass instead, as it can handle all of
these cases. However, to be able to do so, the users must pass the
appropriate BdrvChildRole when the child is created/attached. (The
following commits w
This enum will supplement BdrvChildClass when it comes to what role (or
combination of roles) a child takes for its parent.
Because empty enums are not allowed, let us just start with it filled.
Signed-off-by: Max Reitz
---
include/block/block.h | 38 ++
1 fi
For now, it is always set to 0. Later patches in this series will
ensure that all callers pass an appropriate combination of flags.
Signed-off-by: Max Reitz
---
block.c | 11 ---
block/backup-top.c | 3 ++-
block/blkdebug.c| 2 +-
block/blklogw
This structure nearly only contains parent callbacks for child state
changes. It cannot really reflect a child's role, because different
roles may overlap (as we will see when real roles are introduced), and
because parents can have custom callbacks even when the child fulfills a
standard role.
S
Signed-off-by: Max Reitz
---
block.c | 62 +
1 file changed, 40 insertions(+), 22 deletions(-)
diff --git a/block.c b/block.c
index eb282f0977..2771bc45ce 100644
--- a/block.c
+++ b/block.c
@@ -2256,6 +2256,44 @@ void bdrv_filter_default_pe
This should better be in BdrvChildRole so that parents can decide when
to and when not to keep the child node fixed.
Signed-off-by: Max Reitz
---
block.c | 2 +-
blockjob.c| 3 +--
include/block/block_int.h | 4
3 files changed, 2 insertions(+), 7 deletions
We can be less restrictive about pure data children than those with
metadata on them.
For bdrv_format_default_perms(), we keep the safe option of
bdrv_default_perms_for_metadata() (until we drop
bdrv_format_default_perms() altogether).
That means that bdrv_default_perms_for_data() is unused at th
Signed-off-by: Max Reitz
---
block.c | 40 +++
block/block-backend.c | 3 ++-
block/vvfat.c | 3 ++-
include/block/block_int.h | 3 ++-
4 files changed, 30 insertions(+), 19 deletions(-)
diff --git a/block.c b/block.c
index
This callback can be used by BDSs that use child_of_bds with the
appropriate BdrvChildRole for their children.
Also, make bdrv_format_default_perms() use it for child_of_bds children
(just a temporary solution until we can drop bdrv_format_default_perms()
altogether).
Signed-off-by: Max Reitz
--
bdrv_inherited_fmt_options() is used only by (pseudo-)filter drivers,
namely quorum and blkverify. Both should pass on BDRV_O_NO_IO to their
children. There is no reason to clear it in
bdrv_inherited_fmt_options().
Signed-off-by: Max Reitz
---
block.c | 2 +-
1 file changed, 1 insertion(+), 1
Signed-off-by: Max Reitz
---
block.c | 26 --
block/backup-top.c | 2 +-
block/vvfat.c | 3 ++-
tests/test-bdrv-drain.c | 13 +++--
4 files changed, 30 insertions(+), 14 deletions(-)
diff --git a/block.c b/block.c
index 4b8c33dccc.
Split raw_read_options() into one function that actually just reads the
options, and another that applies them. This will allow us to detect
whether the user has specified any options before attaching the file
child (so we can decide on its role based on the options).
Signed-off-by: Max Reitz
--
Make bdrv_child_cb_attach() call bdrv_backing_attach() for children with
a COW role (and drop the reverse call from bdrv_backing_attach()), so it
can be used for any child (with a proper role set).
Because so far no child has a proper role set, we need a temporary new
callback for child_backing.at
We can keep the logic for child_file, child_format, and child_backing in
a single function and differentiate based on the BdrvChildRole.
Signed-off-by: Max Reitz
---
block.c | 96 +++--
1 file changed, 60 insertions(+), 36 deletions(-)
diff --
Signed-off-by: Max Reitz
---
block.c | 62 +++
include/block/block_int.h | 1 -
2 files changed, 4 insertions(+), 59 deletions(-)
diff --git a/block.c b/block.c
index 63fe19fd73..0530c81c6d 100644
--- a/block.c
+++ b/block.c
@@ -1147,15 +114
Note that some filters have secondary children, namely blkverify (the
image to be verified) and blklogwrites (the log). This patch does not
touch those children.
Signed-off-by: Max Reitz
---
block/blkdebug.c | 4 +++-
block/blklogwrites.c | 3 ++-
block/blkverify.c| 5 -
block/copy-
Signed-off-by: Max Reitz
---
block.c | 28
include/block/block_int.h | 1 -
2 files changed, 29 deletions(-)
diff --git a/block.c b/block.c
index 5b38c7799a..4b8c33dccc 100644
--- a/block.c
+++ b/block.c
@@ -1104,34 +1104,6 @@ const BdrvChildClass
bdrv_format_default_perms() has one code path for backing files, and one
for storage files. We want to pull them out into own functions, so
make sure they are completely distinct before so the next patches will
be a bit cleaner.
Signed-off-by: Max Reitz
---
block.c | 19 +--
1 f
Commonly, they need to pass the BDRV_CHILD_IMAGE set as the
BdrvChildRole; but there are exceptions for drivers with external data
files (qcow2 and vmdk).
Signed-off-by: Max Reitz
---
block/bochs.c | 4 ++--
block/cloop.c | 4 ++--
block/crypto.c| 4 ++--
block/dmg.c | 4 ++
Replace child_file by child_of_bds in all remaining places (excluding
tests).
Signed-off-by: Max Reitz
---
block.c | 3 ++-
block/backup-top.c | 4 ++--
block/blklogwrites.c | 3 ++-
block/blkreplay.c| 5 +++--
block/raw-format.c | 16 ++--
5 files changed, 2
Signed-off-by: Max Reitz
---
block.c | 19 ---
include/block/block_int.h | 11 ---
2 files changed, 30 deletions(-)
diff --git a/block.c b/block.c
index b6c92ef283..3fcd56aaae 100644
--- a/block.c
+++ b/block.c
@@ -2294,25 +2294,6 @@ static void bdrv_def
Make bdrv_child_cb_detach() call bdrv_backing_detach() for children with
a COW role (and drop the reverse call from bdrv_backing_detach()), so it
can be used for any child (with a proper role set).
Because so far no child has a proper role set, we need a temporary new
callback for child_backing.de
These calls have no real use for the child role yet, but it will not
harm to give one.
Notably, the bdrv_root_attach_child() call in blockjob.c is left
unmodified because there is not much the generic BlockJob object wants
from its children.
Signed-off-by: Max Reitz
---
block/block-backend.c |
Signed-off-by: Max Reitz
---
tests/test-bdrv-drain.c | 29 +
tests/test-bdrv-graph-mod.c | 6 --
2 files changed, 21 insertions(+), 14 deletions(-)
diff --git a/tests/test-bdrv-drain.c b/tests/test-bdrv-drain.c
index 15393a0140..91567ca97d 100644
--- a/tests/
Signed-off-by: Max Reitz
---
block.c | 12 ++--
include/block/block_int.h | 10 --
2 files changed, 6 insertions(+), 16 deletions(-)
diff --git a/block.c b/block.c
index e800ce862e..b6c92ef283 100644
--- a/block.c
+++ b/block.c
@@ -2171,12 +2171,12 @@ int bdrv_c
Signed-off-by: Max Reitz
---
block.c | 71 +
1 file changed, 46 insertions(+), 25 deletions(-)
diff --git a/block.c b/block.c
index 2771bc45ce..4d4ccbacdf 100644
--- a/block.c
+++ b/block.c
@@ -2294,6 +2294,50 @@ static void
bdrv_default_p
bdrv_default_perms() can decide which permission profile to use based on
the BdrvChildRole, so block drivers do not need to select it explicitly.
The blkverify driver now no longer shares the WRITE permission for the
image to verify. We thus have to adjust two places in
test-block-iothread not to
Implementations should decide the necessary permissions based on @role.
Signed-off-by: Max Reitz
---
block.c | 45 -
block/backup-top.c | 3 +--
block/blkdebug.c| 3 +--
block/blklogwrites.c| 3 +--
block/com
Both users (quorum and blkverify) use child_format for
not-really-filtered children, so the appropriate BdrvChildRole in both
cases is DATA | FORMAT.
Signed-off-by: Max Reitz
---
block/blkverify.c | 5 +++--
block/quorum.c| 9 ++---
2 files changed, 9 insertions(+), 5 deletions(-)
diff
Signed-off-by: Max Reitz
---
block.c | 30 +-
include/block/block_int.h | 1 -
tests/test-bdrv-drain.c | 8 +++-
3 files changed, 4 insertions(+), 35 deletions(-)
diff --git a/block.c b/block.c
index 3fcd56aaae..b2dc05b028 100644
--- a/block.
It's broken so it's no longer helping. The latest Xcode is covered by
Cirrus.
Signed-off-by: Alex Bennée
---
.travis.yml | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index c09b6a00143..445b0646c18 100644
--- a/.travis.yml
+++ b/.travis.yml
Alex Kirillov writes:
>> What exactly goes wrong? Does the QMP command fail? Does it succeed
>> but the network backend incorrectly?
>
> QMP command succesfully creates Slirp backend, but ignore whole arguments:
> - `dnssearch`
> - `hostfwd`
> - `guestfwd`
You're right, QMP command netdev_add si
Le mer. 27 nov. 2019 14:51, Alex Bennée a écrit :
> It's broken so it's no longer helping. The latest Xcode is covered by
> Cirrus.
>
> Signed-off-by: Alex Bennée
>
Reviewed-by: Philippe Mathieu-Daudé
---
> .travis.yml | 8 +---
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff -
On 24/10/2019 13.14, Alex Bennée wrote:
Thomas Huth writes:
According to Max, it would be good to have a test for iothreads and
migration. 127 and 256 seem to be good candidates for iothreads. For
migration, let's enable 091, 181, and 203 (which also tests iothreads).
@@ -112,7 +112,7 @@
Hi
On Wed, 27 Nov 2019 at 12:47, Xiang Zheng wrote:
>
> Hi Beata,
>
> Thanks for you review!
>
YAW
> On 2019/11/22 23:47, Beata Michalska wrote:
> > Hi,
> >
> > On Mon, 11 Nov 2019 at 01:48, Xiang Zheng wrote:
> >>
> >> From: Dongjiu Geng
> >>
> >> Add a SIGBUS signal handler. In this handler,
On 26.11.19 15:43, Andrey Shinkevich wrote:
> Allow writing all the data compressed through the filter driver.
> The written data will be aligned by the cluster size.
> Based on the QEMU current implementation, that data can be written to
> unallocated clusters only. May be used for a backup job.
>
On Wed, 27 Nov 2019 at 13:03, Igor Mammedov wrote:
>
> On Wed, 27 Nov 2019 20:47:15 +0800
> Xiang Zheng wrote:
>
> > Hi Beata,
> >
> > Thanks for you review!
> >
> > On 2019/11/22 23:47, Beata Michalska wrote:
> > > Hi,
> > >
> > > On Mon, 11 Nov 2019 at 01:48, Xiang Zheng wrote:
> > >>
> > >> F
1 - 100 of 289 matches
Mail list logo
