[PULL 8/8] ppc/spapr_events: fix potential NULL pointer dereference in rtas_event_log_dequeue

2019-11-25 Thread David Gibson
From: PanNengyuan This fixes coverity issues 68911917: 360 CID 68911917: (NULL_RETURNS) 361. dereference: Dereferencing "source", which is known to be "NULL". 361if (source->mask & event_mask) { 362break; 363} R

[PULL 5/8] spapr: Handle irq backend changes with VFIO PCI devices

2019-11-25 Thread David Gibson
pseries machine type can have one of two different interrupt controllers in use depending on feature negotiation with the guest. Usually this is invisible to devices, because they route to a common set of qemu_irqs which in turn dispatch to the correct back end. VFIO passthrough devices, however,

[PULL 7/8] mos6522: update counters when timer interrupts are off

2019-11-25 Thread David Gibson
From: Laurent Vivier Even if the interrupts are off, counters must be updated because they are running anyway and kernel can try to read them (it's the case with g3beige kernel). Reported-by: Andrew Randrianasulu Signed-off-by: Laurent Vivier Message-Id: <20191125141414.5015-1-laur...@vivier.e

[PULL 2/8] kvm: Introduce KVM irqchip change notifier

2019-11-25 Thread David Gibson
Awareness of an in kernel irqchip is usually local to the machine and its top-level interrupt controller. However, in a few cases other things need to know about it. In particular vfio devices need this in order to accelerate interrupt delivery. If interrupt routing is changed, such devices may

[PULL 6/8] spapr: Work around spurious warnings from vfio INTx initialization

2019-11-25 Thread David Gibson
Traditional PCI INTx for vfio devices can only perform well if using an in-kernel irqchip. Therefore, vfio_intx_update() issues a warning if an in kernel irqchip is not available. We usually do have an in-kernel irqchip available for pseries machines on POWER hosts. However, because the platform

[PULL 1/8] pseries: fix migration-test and pxe-test

2019-11-25 Thread David Gibson
From: Laurent Vivier Commit 29cb4187497d ("spapr: Set VSMT to smp_threads by default") has introduced a new default value for VSMT that is not supported by old kernels (before 4.13 kernel) and this breaks "make check" on these kernels. To fix that, explicitly set in the involved tests the value

[PULL 3/8] vfio/pci: Split vfio_intx_update()

2019-11-25 Thread David Gibson
This splits the vfio_intx_update() function into one part doing the actual reconnection with the KVM irqchip (vfio_intx_update(), now taking an argument with the new routing) and vfio_intx_routing_notifier() which handles calls to the pci device intx routing notifier and calling vfio_intx_update()

Re: [PATCH v0 1/2] qdev-properties-system: extend set_pionter for unrealized devices

2019-11-25 Thread Denis Plotnikov
On 25.11.2019 18:30, Eduardo Habkost wrote: > On Fri, Nov 22, 2019 at 11:36:30AM +, Denis Plotnikov wrote: >> >> On 18.11.2019 21:54, Eduardo Habkost wrote: >>> On Sun, Nov 10, 2019 at 10:03:09PM +0300, Denis Plotnikov wrote: Some device's property can be changed if the device has been a

[RFC 7/8] R300 fixes

2019-11-25 Thread aaron . zakhrov
From: Aaron Dominick --- hw/display/r300.c | 9 + hw/display/r300.h | 6 ++ 2 files changed, 15 insertions(+) diff --git a/hw/display/r300.c b/hw/display/r300.c index 653474c3aa..074dbf5b2d 100644 --- a/hw/display/r300.c +++ b/hw/display/r300.c @@ -878,6 +878,15 @@ static void r300_

[RFC 3/8] R300 fixes

2019-11-25 Thread aaron . zakhrov
From: Aaron Dominick --- hw/display/r300.c | 9 + hw/display/r300.h | 6 ++ 2 files changed, 15 insertions(+) diff --git a/hw/display/r300.c b/hw/display/r300.c index 653474c3aa..074dbf5b2d 100644 --- a/hw/display/r300.c +++ b/hw/display/r300.c @@ -878,6 +878,15 @@ static void r300_

[RFC 4/8] Got GPU init working. Stops at probing display

2019-11-25 Thread aaron . zakhrov
From: Aaron Dominick --- hw/display/ati.c | 9 +- hw/display/r300.c | 571 +- hw/display/r300.h | 77 ++- 3 files changed, 544 insertions(+), 113 deletions(-) diff --git a/hw/display/ati.c b/hw/display/ati.c index db3b254316..1d36233163 100644

[RFC 2/8] Fix MC STATUS resgister

2019-11-25 Thread aaron . zakhrov
From: Aaron Dominick --- hw/display/r300.c | 15 --- hw/display/r300.h | 1 + 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/hw/display/r300.c b/hw/display/r300.c index 94e90b7a95..653474c3aa 100644 --- a/hw/display/r300.c +++ b/hw/display/r300.c @@ -278,6 +278,10 @

[RFC 0/8] ATI R300 emulated graphics card

2019-11-25 Thread aaron . zakhrov
From: Aaron Dominick Hello, I thought of working on an emulated R300 GPU for QEMU video acceleration on vintage operating systems (Windows 9x-XP) The following patch series contains the initial QEMU device and some register read/write operations. Testing it on an OpenSUSE Linux guest and the ke

[RFC 6/8] Fix MC STATUS resgister

2019-11-25 Thread aaron . zakhrov
From: Aaron Dominick --- hw/display/r300.c | 15 --- hw/display/r300.h | 1 + 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/hw/display/r300.c b/hw/display/r300.c index 94e90b7a95..653474c3aa 100644 --- a/hw/display/r300.c +++ b/hw/display/r300.c @@ -278,6 +278,10 @

[RFC 8/8] Got GPU init working. Stops at probing display

2019-11-25 Thread aaron . zakhrov
From: Aaron Dominick --- hw/display/ati.c | 9 +- hw/display/r300.c | 571 +- hw/display/r300.h | 77 ++- 3 files changed, 544 insertions(+), 113 deletions(-) diff --git a/hw/display/ati.c b/hw/display/ati.c index db3b254316..1d36233163 100644

Re: [QUESTION] What is the best license option for new files introduced in QEMU?

2019-11-25 Thread Thomas Huth
On 25/11/2019 18.49, Aleksandar Markovic wrote: I read LICENSE file, but I read also recent contributions, and it is not clear to me what version of GPL is best/recommended for new file just being introduced to QEMU: * GPL 2.0 * GPL 2.0 (or later at your option) * GPL 2.1 * GPL 2.1 (or later at

RE: [RFC v2 09/22] vfio/pci: add iommu_context notifier for pasid alloc/free

2019-11-25 Thread Liu, Yi L
Hi David, > From: David Gibson < da...@gibson.dropbear.id.au> > Sent: Wednesday, November 20, 2019 12:28 PM > To: Liu, Yi L > Subject: Re: [RFC v2 09/22] vfio/pci: add iommu_context notifier for pasid > alloc/free > > On Wed, Nov 06, 2019 at 12:14:50PM +, Liu, Yi L wrote: > > > From: David

Re: [PATCH 1/4] block/io: fix bdrv_co_block_status_above

2019-11-25 Thread Vladimir Sementsov-Ogievskiy
25.11.2019 19:00, Kevin Wolf wrote: > Am 16.11.2019 um 17:34 hat Vladimir Sementsov-Ogievskiy geschrieben: >> bdrv_co_block_status_above has several problems with handling short >> backing files: >> >> 1. With want_zeros=true, it may return ret with BDRV_BLOCK_ZERO but >> without BDRV_BLOCK_ALLOCAT

Re: [PATCH 0/4] fix & merge block_status_above and is_allocated_above

2019-11-25 Thread Vladimir Sementsov-Ogievskiy
25.11.2019 18:46, Kevin Wolf wrote: > Am 25.11.2019 um 11:08 hat Vladimir Sementsov-Ogievskiy geschrieben: >> Ping? >> >> Hi! Why so silent? Postpone this to 5.0? This is fixing the same >> problem with block commit, like Kevin's series, just commit not to mid >> but to base.. > > To be honest, I

Re: [PATCH v2 2/2] s390x/cpumodel: Introduce dynamic feature groups

2019-11-25 Thread Christian Borntraeger
On 25.11.19 18:20, David Hildenbrand wrote: > > As soon as dynamic feature groups are used, the CPU model becomes > migration-unsafe. Upper layers can expand these models to migration-safe > and static variants, allowing them to be migrated. I really dislike that. I am trying to get rid of the

<    1   2   3