Re: [PATCH v3 3/8] qcow2: Declare BDRV_REQ_NO_FALLBACK supported

2019-11-25 Thread Alberto Garcia
On Fri 22 Nov 2019 05:05:06 PM CET, Kevin Wolf wrote: > In the common case, qcow2_co_pwrite_zeroes() already only modifies > metadata case, so we're fine with or without BDRV_REQ_NO_FALLBACK set. > > The only exception is when using an external data file, where the > request is passed down to the b

Re: [PATCH] mos6522: update counters when timer interrupts are off

2019-11-25 Thread Laurent Vivier
Le 25/11/2019 à 15:37, Philippe Mathieu-Daudé a écrit : > On 11/25/19 3:14 PM, Laurent Vivier wrote: >> Even if the interrupts are off, counters must be updated because >> they are running anyway and kernel can try to read them >> (it's the case with g3beige kernel). >> >> Reported-by: Andrew Randr

Re: [PATCH-for-4.2] hw/mips: Deprecate the r4k machine

2019-11-25 Thread Philippe Mathieu-Daudé
On 11/25/19 3:45 PM, Aleksandar Markovic wrote: On Monday, November 25, 2019, Philippe Mathieu-Daudé > wrote: The r4k machine was introduced in 2005 (6af0bf9c7) and its last logical change was in 2005 (9542611a6). After we can count 164 maintenance commit

Re: [PATCH 3/4] virtiofsd: Specify size of notification buffer using config space

2019-11-25 Thread Vivek Goyal
On Fri, Nov 22, 2019 at 10:33:00AM +, Stefan Hajnoczi wrote: > On Fri, Nov 15, 2019 at 03:55:42PM -0500, Vivek Goyal wrote: > > diff --git a/contrib/virtiofsd/fuse_virtio.c > > b/contrib/virtiofsd/fuse_virtio.c > > index 44c9b3..982b6ad0bd 100644 > > --- a/contrib/virtiofsd/fuse_virtio.c >

Re: [PATCH] mos6522: update counters when timer interrupts are off

2019-11-25 Thread Philippe Mathieu-Daudé
On 11/25/19 3:56 PM, Laurent Vivier wrote: Le 25/11/2019 à 15:37, Philippe Mathieu-Daudé a écrit : On 11/25/19 3:14 PM, Laurent Vivier wrote: Even if the interrupts are off, counters must be updated because they are running anyway and kernel can try to read them (it's the case with g3beige kern

Re: [PULL 0/1] 9p fixes for QEMU 4.2-rc3

2019-11-25 Thread Peter Maydell
On Sat, 23 Nov 2019 at 16:59, Greg Kurz wrote: > > The following changes since commit 2061735ff09f9d5e67c501a96227b470e7de69b1: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2019-11-21 17:18:40 +) > > are available in the Git repository at: > > https

Re: [PATCH v3 2/8] block: Add no_fallback parameter to bdrv_co_truncate()

2019-11-25 Thread Alberto Garcia
On Fri 22 Nov 2019 05:05:05 PM CET, Kevin Wolf wrote: > @@ -3405,6 +3412,7 @@ typedef struct TruncateCo { > int64_t offset; > bool exact; > PreallocMode prealloc; > +bool no_fallback; > Error **errp; > int ret; > } TruncateCo; You add the 'no_fallback' field here...

Re: [PATCH-for-4.2] hw/mips: Deprecate the r4k machine

2019-11-25 Thread Aurelien Jarno
On 2019-11-25 11:41, Philippe Mathieu-Daudé wrote: > The r4k machine was introduced in 2005 (6af0bf9c7) and its last > logical change was in 2005 (9542611a6). After we can count 164 > maintenance commits (QEMU API changes) with the exception of > 1 fix in 2015 (memory leak, commit 3ad9fd5a). > > T

Re: [PATCH v0 1/2] qdev-properties-system: extend set_pionter for unrealized devices

2019-11-25 Thread Eduardo Habkost
On Fri, Nov 22, 2019 at 11:36:30AM +, Denis Plotnikov wrote: > > > On 18.11.2019 21:54, Eduardo Habkost wrote: > > On Sun, Nov 10, 2019 at 10:03:09PM +0300, Denis Plotnikov wrote: > >> Some device's property can be changed if the device has been already > >> realized. For example, it could be

Re: [PATCH 2/2] test-keyval: Tighten test of trailing crap after size

2019-11-25 Thread Markus Armbruster
Eric Blake writes: > On 11/25/19 7:38 AM, Markus Armbruster wrote: >> test_keyval_visit_size() should test for trailing crap after size with >> and without suffix. It does test the latter: "sz2=16Gi" has size >> "16G" followed by crap "i". It fails to test the former "sz1=16E" is >> a syntactic

[PATCH 3/4] ich9: Simplify ich9_lpc_initfn

2019-11-25 Thread Felipe Franciosi
Currently, ich9_lpc_initfn simply serves as a caller to ich9_lpc_add_properties. This simplifies the code a bit by eliminating ich9_lpc_add_properties altogether and executing its logic in the parent object initialiser function. Signed-off-by: Felipe Franciosi --- hw/isa/lpc_ich9.c | 19 +++-

[PATCH 2/4] ich9: fix getter type for sci_int property

2019-11-25 Thread Felipe Franciosi
When QOM APIs were added to ich9 in 6f1426ab, the getter for sci_int was written using uint32_t. However, the object property is uint8_t. This fixes the getter for correctness. Signed-off-by: Felipe Franciosi --- hw/isa/lpc_ich9.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[PATCH 0/4] Improve default object property_add uint helpers

2019-11-25 Thread Felipe Franciosi
This improves the family of object_property_add_uintXX_ptr helpers by enabling a default setter when desired. To prevent an API behavioural change (from clients that already used these helpers and did not want a setter), we add a "readonly" parameter that allow clients to only have a getter. Patch

[PATCH 4/4] qom/object: Use common get/set uint helpers

2019-11-25 Thread Felipe Franciosi
Several objects implemented their own uint property getters and setters, despite them being straightforward (without any checks/validations on the values themselves) and identical across objects. This makes use of an enhanced API for object_property_add_uintXX_ptr() which offers default setters. S

[PATCH 1/4] qom/object: enable setter for uint types

2019-11-25 Thread Felipe Franciosi
Traditionally, the uint-specific property helpers only offer getters. When adding object (or class) uint types, one must therefore use the generic property helper if a setter is needed. This enhances the uint-specific property helper APIs by adding a 'readonly' field and modifying all users of tha

Re: [PATCH v35 10/13] target/avr: Add limited support for USART and 16 bit timer peripherals

2019-11-25 Thread Sarah Harris
Hi Aleksandar, In avr_usart_receive(): The two assertions check that we get only what avr_usart_can_receive() asked for. It always requests zero or one byte and I must have assumed zero bytes isn't a valid read (so assert size==1). It only requests data when !usart->data_valid (so assert !usart-

Re: [Virtio-fs] [PATCH 4/4] virtiofsd: Implement blocking posix locks

2019-11-25 Thread Vivek Goyal
On Fri, Nov 22, 2019 at 10:53:24AM +, Stefan Hajnoczi wrote: > On Fri, Nov 15, 2019 at 03:55:43PM -0500, Vivek Goyal wrote: > > diff --git a/contrib/virtiofsd/fuse_lowlevel.c > > b/contrib/virtiofsd/fuse_lowlevel.c > > index d4a42d9804..f706e440bf 100644 > > --- a/contrib/virtiofsd/fuse_lowlev

[PULL 3/4] net/virtio: fix re-plugging of primary device

2019-11-25 Thread Jason Wang
From: Jens Freimann failover_replug_primary was returning true on failure which lead to re-plug not working when a migration failed. Fix this by returning success when hotplug worked. This is a bug that was missed in last round of testing but was tested succesfully with this version. Also make

[PULL 2/4] net/virtio: return early when failover primary alread added

2019-11-25 Thread Jason Wang
From: Jens Freimann Bail out when primary device was already added before. This avoids printing a wrong warning message during reboot. Fixes: 9711cd0dfc3f ("net/virtio: add failover support") Signed-off-by: Jens Freimann Reviewed-by: Michael S. Tsirkin Signed-off-by: Jason Wang --- hw/net/vi

[PULL 1/4] net/virtio: fix dev_unplug_pending

2019-11-25 Thread Jason Wang
From: Jens Freimann .dev_unplug_pending is set up by virtio-net code indepent of failover support was set for the device or not. This gives a wrong result when we check for existing primary devices in migration code. Fix this by actually calling dev_unplug_pending() instead of just checking if t

Re: [Virtio-fs] [PATCH 4/4] virtiofsd: Implement blocking posix locks

2019-11-25 Thread Vivek Goyal
On Fri, Nov 22, 2019 at 05:47:32PM +, Dr. David Alan Gilbert wrote: [..] > > +static int virtio_send_notify_msg(struct fuse_session *se, struct iovec > > *iov, > > + int count) > > +{ > > +struct fv_QueueInfo *qi; > > +VuDev *dev = &se->virtio_dev->dev; > >

[PULL 0/4] Net patches

2019-11-25 Thread Jason Wang
The following changes since commit 122e6d2a9c1bf8aa1d51409c15809a82621515b1: Merge remote-tracking branch 'remotes/gkurz/tags/9p-fix-2019-11-23' into staging (2019-11-25 13:39:45 +) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request for y

Re: [libvirt] [PATCH-for-4.2] hw/mips: Deprecate the r4k machine

2019-11-25 Thread Daniel P . Berrangé
On Mon, Nov 25, 2019 at 03:45:35PM +0100, Aleksandar Markovic wrote: > On Monday, November 25, 2019, Philippe Mathieu-Daudé > wrote: > > > The r4k machine was introduced in 2005 (6af0bf9c7) and its last > > logical change was in 2005 (9542611a6). After we can count 164 > > maintenance commits (QE

Re: [PULL 0/1] Miscellaneous patches for 2019-11-25

2019-11-25 Thread Peter Maydell
On Mon, 25 Nov 2019 at 06:06, Markus Armbruster wrote: > > The following changes since commit 2061735ff09f9d5e67c501a96227b470e7de69b1: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2019-11-21 17:18:40 +) > > are available in the Git repository at: > >

Re: Avocado notes from KVM forum 2019

2019-11-25 Thread Cleber Rosa
- Original Message - > From: "Gerd Hoffmann" > To: "Eduardo Habkost" > Cc: avocado-de...@redhat.com, "Philippe Mathieu-Daudé" , > "qemu-devel" , > "Wainer dos Santos Moschetta" , "Cleber Rosa" > > Sent: Monday, November 25, 2019 9:15:53 AM > Subject: Re: Avocado notes from KVM forum

[PULL 4/4] net/virtio: return error when device_opts arg is NULL

2019-11-25 Thread Jason Wang
From: Jens Freimann This fixes CID 1407222. Fixes: 9711cd0dfc3f ("net/virtio: add failover support") Signed-off-by: Jens Freimann Reviewed-by: Michael S. Tsirkin Signed-off-by: Jason Wang --- hw/net/virtio-net.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/

Re: [PATCH v3 4/5] s390x: Move clear reset

2019-11-25 Thread Cornelia Huck
On Mon, 25 Nov 2019 14:49:54 +0100 Janosch Frank wrote: > On 11/25/19 2:37 PM, Cornelia Huck wrote: > > On Mon, 25 Nov 2019 04:03:47 -0500 > > Janosch Frank wrote: > > > >> Let's also move the clear reset function into the reset handler. > >> > >> Signed-off-by: Janosch Frank > >> --- > >>

Re: [PATCH 0/5] ARM virt: Add NVDIMM support

2019-11-25 Thread Igor Mammedov
On Mon, 25 Nov 2019 13:20:02 + Shameerali Kolothum Thodi wrote: > Hi Eric/Igor, > > > -Original Message- > > From: Shameerali Kolothum Thodi > > Sent: 22 October 2019 15:05 > > To: 'Auger Eric' ; qemu-devel@nongnu.org; > > qemu-...@nongnu.org; imamm...@redhat.com > > Cc: peter.mayd..

Re: [libvirt] [PATCH-for-4.2] hw/mips: Deprecate the r4k machine

2019-11-25 Thread Eric Blake
On 11/25/19 9:40 AM, Daniel P. Berrangé wrote: Please don't start any deprecation process. This requires certain consultation within my company. Rest assured that everyone's opinion will be taken into account while doing consiltation. The idea of having a deprecation process is precisely to al

Re: [PATCH 0/4] fix & merge block_status_above and is_allocated_above

2019-11-25 Thread Kevin Wolf
Am 25.11.2019 um 11:08 hat Vladimir Sementsov-Ogievskiy geschrieben: > Ping? > > Hi! Why so silent? Postpone this to 5.0? This is fixing the same > problem with block commit, like Kevin's series, just commit not to mid > but to base.. To be honest, I think by now we've found so many problems arou

Re: [PATCH v35 10/13] target/avr: Add limited support for USART and 16 bit timer peripherals

2019-11-25 Thread Sarah Harris
Hi Aleksandar, I think returning immediately should be ok, it just happened to make sense to me to think in terms of this being a special case of a normal read. The else handles the case in which no data has been received, but the user's program reads the incoming buffer anyway. (As far as I'm a

Re: [PATCH v35 10/13] target/avr: Add limited support for USART and 16 bit timer peripherals

2019-11-25 Thread Sarah Harris
Hi Aleksandar, > - Is there a place in docs that explain its implementation in general? This implementation was based on the datasheet for the ATmega2560 ("ATmega640/1280/1281/2560/2561 datasheet" available from Microchip's website). (I'm not sure if posting a URL will trigger any spam filters, s

Re: [PATCH] qom/object: enable setter for uint types

2019-11-25 Thread Felipe Franciosi
> On Nov 19, 2019, at 10:06 AM, Stefan Hajnoczi wrote: > > On Sun, Nov 17, 2019 at 03:50:32PM +, Felipe Franciosi wrote: >> Traditionally, the uint-specific property helpers only offer getters. >> When adding object (or class) uint types, one must therefore use the >> generic property helpe

Re: [PATCH 1/4] block/io: fix bdrv_co_block_status_above

2019-11-25 Thread Kevin Wolf
Am 16.11.2019 um 17:34 hat Vladimir Sementsov-Ogievskiy geschrieben: > bdrv_co_block_status_above has several problems with handling short > backing files: > > 1. With want_zeros=true, it may return ret with BDRV_BLOCK_ZERO but > without BDRV_BLOCK_ALLOCATED flag, when actually short backing file

Re: [PATCH v3 2/8] block: Add no_fallback parameter to bdrv_co_truncate()

2019-11-25 Thread Kevin Wolf
Am 25.11.2019 um 16:06 hat Alberto Garcia geschrieben: > On Fri 22 Nov 2019 05:05:05 PM CET, Kevin Wolf wrote: > > > @@ -3405,6 +3412,7 @@ typedef struct TruncateCo { > > int64_t offset; > > bool exact; > > PreallocMode prealloc; > > +bool no_fallback; > > Error **errp; > >

Re: [PULL 4/4] net/virtio: return error when device_opts arg is NULL

2019-11-25 Thread Paolo Bonzini
On 25/11/19 16:40, Jason Wang wrote: > From: Jens Freimann > > This fixes CID 1407222. > > Fixes: 9711cd0dfc3f ("net/virtio: add failover support") > Signed-off-by: Jens Freimann > Reviewed-by: Michael S. Tsirkin > Signed-off-by: Jason Wang > --- > hw/net/virtio-net.c | 9 ++--- > 1 file

[PATCH] fence: introduce a file-based self-fence mechanism

2019-11-25 Thread Felipe Franciosi
This introduces a self-fence mechanism to Qemu, causing it to die if a heartbeat condition is not met. Currently, a file-based heartbeat is available and can be configured as follows: -object file-fence,id=ff0,file=/foo,qtimeout=20,ktimeout=25,signal=kill Qemu will watch 'file' for attribute chan

Re: [PATCH 2/4] block/io: bdrv_common_block_status_above: support include_base

2019-11-25 Thread Kevin Wolf
Am 16.11.2019 um 17:34 hat Vladimir Sementsov-Ogievskiy geschrieben: > In order to reuse bdrv_common_block_status_above in > bdrv_is_allocated_above, let's support include_base parameter. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Kevin Wolf

Re: [PATCH] target/arm: Honor HCR_EL2.TID3 trapping requirements

2019-11-25 Thread Peter Maydell
On Sat, 23 Nov 2019 at 11:56, Marc Zyngier wrote: > > HCR_EL2.TID3 mandates that access from EL1 to a long list of id > registers traps to EL2, and QEMU has so far ignored this requirement. > > This breaks (among other things) KVM guests that have PtrAuth enabled, > while the hypervisor doesn't wa

Re: [PATCH 3/4] block/io: bdrv_common_block_status_above: support bs == base

2019-11-25 Thread Kevin Wolf
Am 16.11.2019 um 17:34 hat Vladimir Sementsov-Ogievskiy geschrieben: > We are going to reuse bdrv_common_block_status_above in > bdrv_is_allocated_above. bdrv_is_allocated_above may be called with > include_base == false and still bs == base (for ex. from img_rebase()). > > So, support this corner

Re: [PULL 0/3] virtio, pc: fixes

2019-11-25 Thread Peter Maydell
On Mon, 25 Nov 2019 at 08:44, Michael S. Tsirkin wrote: > > The following changes since commit 2061735ff09f9d5e67c501a96227b470e7de69b1: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2019-11-21 17:18:40 +) > > are available in the Git repository at: >

Re: [PATCH 2/2] test-keyval: Tighten test of trailing crap after size

2019-11-25 Thread Eric Blake
On 11/25/19 9:31 AM, Markus Armbruster wrote: Eric Blake writes: On 11/25/19 7:38 AM, Markus Armbruster wrote: test_keyval_visit_size() should test for trailing crap after size with and without suffix. It does test the latter: "sz2=16Gi" has size "16G" followed by crap "i". It fails to test

RE: [PATCH 0/5] ARM virt: Add NVDIMM support

2019-11-25 Thread Shameerali Kolothum Thodi
Hi Igor, > -Original Message- > From: Igor Mammedov [mailto:imamm...@redhat.com] > Sent: 25 November 2019 15:46 > To: Shameerali Kolothum Thodi > Cc: Auger Eric ; qemu-devel@nongnu.org; > qemu-...@nongnu.org; peter.mayd...@linaro.org; > shannon.zha...@gmail.com; xuwei (O) ; > ler...@redha

Re: Avocado notes from KVM forum 2019

2019-11-25 Thread Cleber Rosa
On Mon, Nov 25, 2019 at 01:35:13PM +0100, Philippe Mathieu-Daudé wrote: > Hi Cleber, > > Here are my notes from talking about Avocado with various people during the > KVM forum in Lyon last month. > > All comments are QEMU oriented. > > > 1) Working offline > > Various people complained Avocad

[PULL 1/1] linux-user: fix translation of statx structures

2019-11-25 Thread Laurent Vivier
From: Ariadne Conill All timestamps were copied to atime instead of to their respective fields. Fixes: efa921845c03 ("linux-user: Add support for translation of statx() syscall") Signed-off-by: Ariadne Conill Reviewed-by: Aleksandar Markovic Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: L

[PULL 0/1] Linux user for 4.2 patches

2019-11-25 Thread Laurent Vivier
The following changes since commit 2061735ff09f9d5e67c501a96227b470e7de69b1: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2019-11-21 17:18:40 +) are available in the Git repository at: git://github.com/vivier/qemu.git tags/linux-user-for-4.2-pull-reques

Re: [PATCH 2/4] ich9: fix getter type for sci_int property

2019-11-25 Thread Philippe Mathieu-Daudé
On 11/25/19 4:36 PM, Felipe Franciosi wrote: When QOM APIs were added to ich9 in 6f1426ab, the getter for sci_int was written using uint32_t. However, the object property is uint8_t. This fixes the getter for correctness. Signed-off-by: Felipe Franciosi --- hw/isa/lpc_ich9.c | 6 +++--- 1 fi

Re: [virtio-dev] Re: guest / host buffer sharing ...

2019-11-25 Thread Liam Girdwood
On Wed, 2019-11-20 at 10:53 +0100, Gerd Hoffmann wrote: > Hi, > > > > > DSP FW has no access to userspace so we would need some > > > > additional > > > > API > > > > on top of DMA_BUF_SET_NAME etc to get physical hardware pages ? > > > > > > The dma-buf api currently can share guest memory sg-

Re: [PATCH for-4.2 2/2] i386: Add -noTSX aliases for hle=off, rtm=off CPU models

2019-11-25 Thread Kashyap Chamarthy
On Mon, Nov 25, 2019 at 11:21:10AM -0300, Eduardo Habkost wrote: > On Thu, Nov 21, 2019 at 03:12:45PM +0100, Kashyap Chamarthy wrote: > > On Wed, Nov 20, 2019 at 01:49:12PM -0300, Eduardo Habkost wrote: [...] > > - - - > > > > Should we (can do it, if you already don't have a patch W

Re: [PATCH] target/arm: Honor HCR_EL2.TID3 trapping requirements

2019-11-25 Thread Marc Zyngier
On 2019-11-25 16:21, Peter Maydell wrote: On Sat, 23 Nov 2019 at 11:56, Marc Zyngier wrote: HCR_EL2.TID3 mandates that access from EL1 to a long list of id registers traps to EL2, and QEMU has so far ignored this requirement. This breaks (among other things) KVM guests that have PtrAuth en

[PATCH v2 1/2] s390x/cpumodel: Factor out CPU feature dependencies

2019-11-25 Thread David Hildenbrand
Currently we check "if bit X is set, bit Y is required". We want to perform "if bit Y is not set, bit X must also not be set" when creating CPU models that will pass all consistency checks. Signed-off-by: David Hildenbrand --- target/s390x/cpu_models.c | 115 +++--

[PATCH v2 2/2] s390x/cpumodel: Introduce dynamic feature groups

2019-11-25 Thread David Hildenbrand
For a specific CPU model, we have a lot of feature variability depending on - The microcode version of the HW - The hypervisor we're running on (LPAR vs. KVM vs. z/VM) - The hypervisor version we're running on - The KVM version - KVM module parameters (especially, "nested=1") - The accelerator Our

[PATCH v2 0/2] s390x/cpumodel: Introduce dynamic feature group

2019-11-25 Thread David Hildenbrand
This thread was previously called: s390x/cpumodel: Introduce "best" model variants There was recently a discussion regarding CPU model versions. That concept does not fit s390x where we have a lot of feature variability. I proposed an alternative approach in [1], which might work for x86 as we

Re: [PATCH] target/arm: Honor HCR_EL2.TID3 trapping requirements

2019-11-25 Thread Peter Maydell
On Mon, 25 Nov 2019 at 17:08, Marc Zyngier wrote: > > On 2019-11-25 16:21, Peter Maydell wrote: > > Missing .accessfn for ID_AA4PFR2_EL1_RESERVED ? > > Indeed, I oversaw that one. I'll fix it and repost it together with > the extra patches to handle TID1 and TID2. Given that rc3 (last chance, mor

[PATCH] block: always fill entire LUKS header space with zeros

2019-11-25 Thread Daniel P . Berrangé
When initializing the LUKS header the size with default encryption parameters will currently be 2068480 bytes. This is rounded up to a multiple of the cluster size, 2081792, with 64k sectors. If the end of the header is not the same as the end of the cluster we fill the extra space with zeros. This

[QUESTION] What is the best license option for new files introduced in QEMU?

2019-11-25 Thread Aleksandar Markovic
I read LICENSE file, but I read also recent contributions, and it is not clear to me what version of GPL is best/recommended for new file just being introduced to QEMU: * GPL 2.0 * GPL 2.0 (or later at your option) * GPL 2.1 * GPL 2.1 (or later at your option) or something else. (The rest od word

Re: [PATCH] target/arm: Honor HCR_EL2.TID3 trapping requirements

2019-11-25 Thread Marc Zyngier
On 2019-11-25 17:27, Peter Maydell wrote: On Mon, 25 Nov 2019 at 17:08, Marc Zyngier wrote: On 2019-11-25 16:21, Peter Maydell wrote: > Missing .accessfn for ID_AA4PFR2_EL1_RESERVED ? Indeed, I oversaw that one. I'll fix it and repost it together with the extra patches to handle TID1 and TID2

Re: Avocado notes from KVM forum 2019

2019-11-25 Thread Cleber Rosa
On Mon, Nov 25, 2019 at 10:58:02AM -0300, Eduardo Habkost wrote: > Thank you, Philippe, those are great ideas. I have copied them > to the Avocado+QEMU Trello board so we don't forget about them: > https://trello.com/b/6Qi1pxVn/avocado-qemu > > Additional comments below: > > On Mon, Nov 25, 2019

[PATCH] target/i386: add two missing VMX features for Skylake and CascadeLake Server

2019-11-25 Thread Paolo Bonzini
They are present in client (Core) Skylake but pasted wrong into the server SKUs. Reported-by: Dr. David Alan Gilbert Signed-off-by: Paolo Bonzini --- target/i386/cpu.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 0f38c8290

Re: QEMU Licensing query

2019-11-25 Thread karina filer
Hi All, QEMU is used in Android Emulator and is licensed under GPLv2 . For one of our customer support we may have to modify QEMU. I have below queries, - *Case 1: No modification in Q

Re: [PATCH v35 10/13] target/avr: Add limited support for USART and 16 bit timer peripherals

2019-11-25 Thread Aleksandar Markovic
On Mon, Nov 25, 2019 at 4:07 PM Sarah Harris wrote: > > Hi Aleksandar, > > In avr_usart_receive(): > The two assertions check that we get only what avr_usart_can_receive() asked > for. > It always requests zero or one byte and I must have assumed zero bytes isn't > a valid read (so assert size==

Re: [PATCH v35 10/13] target/avr: Add limited support for USART and 16 bit timer peripherals

2019-11-25 Thread Aleksandar Markovic
On Mon, Nov 25, 2019 at 4:56 PM Sarah Harris wrote: > > Hi Aleksandar, > > I think returning immediately should be ok, it just happened to make sense to > me to think in terms of this being a special case of a normal read. > The else handles the case in which no data has been received, but the us

Re: API definition for LUKS key management [V2]

2019-11-25 Thread Max Reitz
On 22.11.19 15:22, Maxim Levitsky wrote: > Hi! > > This is the second version of the proposed QMP API for key management, > after discussion with Keven and Max. > > Will this work? > > Adding Peter Krempa to CC, to hear his opinion from the > libvirt side. > > Best regards, > Maxim Levit

virtiofsd: Where should it live?

2019-11-25 Thread Dr. David Alan Gilbert
Hi, There's been quite a bit of discussion about where virtiofsd, our implemenation of a virtiofs daemon, should live. I'd like to get this settled now, because I'd like to tidy it up for the next qemu cycle. For reference it's based on qemu's livhost-user+chunks of libfuse. It can't live in li

Re: [PATCH v36 01/17] target/avr: Add outward facing interfaces and core CPU logic

2019-11-25 Thread Thomas Huth
On 24/11/2019 16.17, Aleksandar Markovic wrote: > > > On Sunday, November 24, 2019, Michael Rolnik > wrote: > > This includes: > - CPU data structures > - object model classes and functions > - migration functions > - GDB hooks > > Co-developed

Re: QEMU Licensing query

2019-11-25 Thread Michal Suchánek
Hello, On Fri, Nov 22, 2019 at 03:57:07PM +0530, karina filer wrote: > Hi All, > > [1]QEMU is used in Android Emulator and is licensed under [2]GPLv2. > > For one of our customer support we may have to modify QEMU. > >  I have below queries, > > * Case 1: No modification in QEMU (QEMU delive

Re: [PATCH v35 10/13] target/avr: Add limited support for USART and 16 bit timer peripherals

2019-11-25 Thread Aleksandar Markovic
On Mon, Nov 25, 2019 at 4:57 PM Sarah Harris wrote: > > Hi Aleksandar, > > > - Is there a place in docs that explain its implementation in general? > This implementation was based on the datasheet for the ATmega2560 > ("ATmega640/1280/1281/2560/2561 datasheet" available from Microchip's > websit

Re: [PATCH v36 01/17] target/avr: Add outward facing interfaces and core CPU logic

2019-11-25 Thread Aleksandar Markovic
On Mon, Nov 25, 2019 at 7:51 PM Thomas Huth wrote: > > On 24/11/2019 16.17, Aleksandar Markovic wrote: > > > > > > On Sunday, November 24, 2019, Michael Rolnik > > wrote: > > > > This includes: > > - CPU data structures > > - object model classes and function

Re: [PATCH v4 17/37] mips: inline serial_init()

2019-11-25 Thread Marc-André Lureau
Hi On Mon, Nov 25, 2019 at 5:33 PM Aleksandar Markovic wrote: > > > > On Monday, November 25, 2019, Marc-André Lureau > wrote: >> >> Hi >> >> On Mon, Nov 25, 2019 at 2:12 PM Aleksandar Markovic >> wrote: >> > >> > >> > >> > On Wednesday, November 20, 2019, Marc-André Lureau >> > wrote: >> >>

Re: [QUESTION] What is the best license option for new files introduced in QEMU?

2019-11-25 Thread Aleksandar Markovic
On Mon, Nov 25, 2019 at 6:49 PM Aleksandar Markovic wrote: > > I read LICENSE file, but I read also recent contributions, and it is > not clear to me what version of GPL is best/recommended for new file > just being introduced to QEMU: > > * GPL 2.0 > * GPL 2.0 (or later at your option) > * GPL 2.

[Bug 1815889] Re: qemu-system-x86_64 crashed with signal 31 in __pthread_setaffinity_new()

2019-11-25 Thread Launchpad Bug Tracker
This bug was fixed in the package mesa - 19.2.4-1ubuntu1 --- mesa (19.2.4-1ubuntu1) focal; urgency=medium * Merge from Debian. * revert-set-full-thread-affinity.diff: Dropped, qemu is fixed now in eoan and up. (LP: #1815889) -- Timo Aaltonen Wed, 20 Nov 2019 20:17:00 +0200

Re: [PATCH v4 21/37] sm501: make SerialMM a child, export chardev property

2019-11-25 Thread Marc-André Lureau
On Thu, Nov 21, 2019 at 6:04 PM Peter Maydell wrote: > > On Wed, 20 Nov 2019 at 15:31, Marc-André Lureau > wrote: > > > > Embed the SerialMM sybus device, and re-export its "chardev" property. > > That way, we can get rid of PROP_PTR "chr-state" and better track > > devices relationship. > > > >

[Bug 1853898] [NEW] qemu/hw/scsi/lsi53c895a.c:417: lsi_soft_reset: Assertion `QTAILQ_EMPTY(&s->queue)' failed.

2019-11-25 Thread Tony Asleson
Public bug reported: While experimenting with blkdebug I can consistently hit this assertion in lsi53c895a.c. Using locally built from master, commit: 2061735ff09f9d5e67c501a96227b470e7de69b1 Steps to reproduce $ qemu-img create -f raw empty.raw 8G $ sudo losetup -f --show empty.raw $ sudo mkfs

[Bug 1853781] Re: Baremetal kernel built from assembly runs multiple times

2019-11-25 Thread Evan Rysdam
Ah, I've been missing out on a whole host of ARM instructions. I haven't tried it yet, but I should be able to get it working from here. Thanks so much for your help! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launch

Re: [PATCH] linux-user: Improve strace output for read() and getcwd()

2019-11-25 Thread Helge Deller
On 25.11.19 14:46, Aleksandar Markovic wrote: > On Sun, Nov 24, 2019 at 2:31 PM Aleksandar Markovic > wrote: >> >> >> >> On Sunday, November 24, 2019, Helge Deller wrote: >>> >>> On 24.11.19 13:10, Aleksandar Markovic wrote: On Sunday, November 24, 2019, Helge Deller >>>

Re: [PATCH v2] linux-user/strace: Improve strace output for read() and getcwd()

2019-11-25 Thread Helge Deller
On 24.11.19 13:38, no-re...@patchew.org wrote: > Patchew URL: https://patchew.org/QEMU/20191124115656.ga23...@ls3530.fritz.box/ > ... > This series seems to have some coding style problems. See output below for > more information: > > Subject: [PATCH v2] linux-user/strace: Improve strace output for

Re: [PATCH] linux-user: Improve strace output for read() and getcwd()

2019-11-25 Thread Aleksandar Markovic
On Mon, Nov 25, 2019 at 9:40 PM Helge Deller wrote: > > On 25.11.19 14:46, Aleksandar Markovic wrote: > > On Sun, Nov 24, 2019 at 2:31 PM Aleksandar Markovic > > wrote: > >> > >> > >> > >> On Sunday, November 24, 2019, Helge Deller wrote: > >>> > >>> On 24.11.19 13:10, Aleksandar Markovic wrote:

[PULL] RISC-V Patches for 4.2-rc3

2019-11-25 Thread Palmer Dabbelt
The following changes since commit 65e05c82bdc6d348155e301c9d87dba7a08a5701: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2019-11-25 15:47:44 +) are available in the Git repository at: g...@github.com:palmer-dabbelt/qemu.git tags/riscv-for-master-4.2-rc3 f

[PULL 1/2] RISC-V: virt: This is a "sifive,test1" test finisher

2019-11-25 Thread Palmer Dabbelt
From: Palmer Dabbelt The test finisher implements the reset command, which means it's a "sifive,test1" device. This is a backwards compatible change, so it's also a "sifive,test0" device. I copied the odd idiom for adding a two-string compatible field from the ARM virt board. Fixes: 9a2551ed6f

[PULL 2/2] hw/riscv: Add optional symbol callback ptr to riscv_load_kernel()

2019-11-25 Thread Palmer Dabbelt
From: "Zhuang, Siwei (Data61, Kensington NSW)" This patch adds an optional function pointer, "sym_cb", to riscv_load_kernel() which provides the possibility to access the symbol table during kernel loading. The pointer is ignored, if supplied with Image or uImage file. The Spike board requires

Re: [QUESTION] What is the best license option for new files introduced in QEMU?

2019-11-25 Thread Eric Blake
On 11/25/19 1:25 PM, Aleksandar Markovic wrote: Thomas pointed to me that I mixed up GPL and LGPL - which is true. Still, the question remains with these options: * GPL 2.0 Not good. It artificially limits who can reuse this code. * GPL 2.0 + wording "or later (at your option)" Matches w

Re: [PATCH 0/2] Minor integer parsing improvements

2019-11-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191125133846.27790-1-arm...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH 0/2] Minor integer parsing improvements Type: series Message-id: 20191125133846.27790-1-arm...@redhat

[PULL 0/1] vmstate-static-checker fix for 4.2

2019-11-25 Thread Eduardo Habkost
The following changes since commit 65e05c82bdc6d348155e301c9d87dba7a08a5701: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2019-11-25 15:47:44 +) are available in the Git repository at: git://github.com/ehabkost/qemu.git tags/python-next-pull-request for yo

[PULL 1/1] vmstate-static-checker: Fix for current python

2019-11-25 Thread Eduardo Habkost
From: "Dr. David Alan Gilbert" Python 3.7.5 on f31 doesn't seem to like the old type=file syntax on argparse. Signed-off-by: Dr. David Alan Gilbert Message-Id: <20191121185303.51685-1-dgilb...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Cleber Rosa Signed-off-by: Eduardo Habk

Re: [EXTERNAL]Re: [PATCH v2 2/5] MAINTAINERS: Adjust maintainership for Fulong 2E board

2019-11-25 Thread Philippe Mathieu-Daudé
Hi Zoltan, On 11/14/19 2:50 PM, Philippe Mathieu-Daudé wrote: On 11/14/19 2:08 PM, chen huacai wrote: Hi, all, On Thu, Nov 14, 2019 at 8:34 PM Aleksandar Markovic wrote: Hi, Philippe, From: Philippe Mathieu-Daudé Hi Aleksandar, On 11/13/19 2:47 PM, Aleksandar Markovic wrote: From: Ale

Re: [PATCH v2 0/2] s390x/cpumodel: Introduce dynamic feature group

2019-11-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191125172031.16282-1-da...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v2 0/2] s390x/cpumodel: Introduce dynamic feature group Type: series Message-id: 20191125172031.16282-

Re: [PATCH] mos6522: update counters when timer interrupts are off

2019-11-25 Thread David Gibson
On Mon, Nov 25, 2019 at 03:14:14PM +0100, Laurent Vivier wrote: > Even if the interrupts are off, counters must be updated because > they are running anyway and kernel can try to read them > (it's the case with g3beige kernel). > > Reported-by: Andrew Randrianasulu > Signed-off-by: Laurent Vivier

Re: [PATCH V2] ppc/spapr_events: fix potential NULL pointer dereference in rtas_event_log_dequeue

2019-11-25 Thread David Gibson
On Mon, Nov 25, 2019 at 08:34:51PM +0800, pannengy...@huawei.com wrote: > From: PanNengyuan > > This fixes coverity issues 68911917: > 360 > CID 68911917: (NULL_RETURNS) > 361. dereference: Dereferencing "source", which is known to be > "NULL". > 361

Re: [PATCH v36 17/17] target/avr: Update MAINTAINERS file

2019-11-25 Thread Aleksandar Markovic
On Sunday, November 24, 2019, Michael Rolnik wrote: > Include AVR maintaners in MAINTAINERS file > > Signed-off-by: Michael Rolnik > --- > MAINTAINERS | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 5e5e3e52d6..ad2d9dd04a 100644 > --- a/MAINTA

Re: [PATCH v36 00/17] QEMU AVR 8 bit cores

2019-11-25 Thread Aleksandar Markovic
On Sunday, November 24, 2019, Michael Rolnik wrote: > This series of patches adds 8bit AVR cores to QEMU. > All instruction, except BREAK/DES/SPM/SPMX, are implemented. Not fully > tested yet. > However I was able to execute simple code with functions. e.g fibonacci > calculation. > This series o

Re: [QUESTION] What is the best license option for new files introduced in QEMU?

2019-11-25 Thread Aleksandar Markovic
On Monday, November 25, 2019, Eric Blake wrote: > On 11/25/19 1:25 PM, Aleksandar Markovic wrote: > > Thomas pointed to me that I mixed up GPL and LGPL - which is true. >> >> Still, the question remains with these options: >> >> * GPL 2.0 >> > > Not good. It artificially limits who can reuse this

Re: [PATCH v9 Kernel 2/5] vfio iommu: Add ioctl defination to get dirty pages bitmap.

2019-11-25 Thread Yan Zhao
On Fri, Nov 15, 2019 at 05:06:25AM +0800, Alex Williamson wrote: > On Fri, 15 Nov 2019 00:26:07 +0530 > Kirti Wankhede wrote: > > > On 11/14/2019 1:37 AM, Alex Williamson wrote: > > > On Thu, 14 Nov 2019 01:07:21 +0530 > > > Kirti Wankhede wrote: > > > > > >> On 11/13/2019 4:00 AM, Alex Willi

Re: [PATCH v36 12/17] target/avr: Add example board configuration

2019-11-25 Thread Aleksandar Markovic
On Sunday, November 24, 2019, Michael Rolnik wrote: > A simple board setup that configures an AVR CPU to run a given firmware > image. > This is all that's useful to implement without peripheral emulation as AVR > CPUs include a lot of on-board peripherals. > > NOTE: this is not a real board

Re: [PATCH v36 10/17] target/avr: Add instruction disassembly function

2019-11-25 Thread Aleksandar Markovic
On Sunday, November 24, 2019, Michael Rolnik wrote: > Provide function disassembles executed instruction when `-d in_asm` is > provided > > Signed-off-by: Michael Rolnik > --- Richard, is this what you expected from Michael, or there are still some caveats? Thanks for the suggestion! Aleksan

Re: [PATCH v36 00/17] QEMU AVR 8 bit cores

2019-11-25 Thread Aleksandar Markovic
On Sunday, November 24, 2019, Michael Rolnik wrote: > This series of patches adds 8bit AVR cores to QEMU. > All instruction, except BREAK/DES/SPM/SPMX, are implemented. Not fully > tested yet. > However I was able to execute simple code with functions. e.g fibonacci > calculation. > This series o

Re: [PATCH v36 01/17] target/avr: Add outward facing interfaces and core CPU logic

2019-11-25 Thread Aleksandar Markovic
On Sunday, November 24, 2019, Michael Rolnik wrote: > This includes: > - CPU data structures > - object model classes and functions > - migration functions > - GDB hooks > > Co-developed-by: Michael Rolnik > Co-developed-by: Sarah Harris > Signed-off-by: Michael Rolnik > Signed-off-by: Sarah H

Re: [PATCH v36 17/17] target/avr: Update MAINTAINERS file

2019-11-25 Thread Cleber Rosa
- Original Message - > From: "Aleksandar Markovic" > To: "Michael Rolnik" , "Cleber Rosa" , > "Eduardo Habkost" > Cc: qemu-devel@nongnu.org, "richard henderson" > , phi...@redhat.com, th...@redhat.com, > dovga...@ispras.ru, imamm...@redhat.com > Sent: Monday, November 25, 2019 6:49:4

[PATCH v36 17/17] target/avr: Update MAINTAINERS file

2019-11-25 Thread Aleksandar Markovic
On Sunday, November 24, 2019, Michael Rolnik wrote: > Include AVR maintaners in MAINTAINERS file > > Signed-off-by: Michael Rolnik > --- > MAINTAINERS | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 5e5e3e52d6..ad2d9dd04a 100644 > --- a/MAINTA

[PULL 0/8] ppc-for-4.2 queue 20191126

2019-11-25 Thread David Gibson
The following changes since commit 65e05c82bdc6d348155e301c9d87dba7a08a5701: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2019-11-25 15:47:44 +) are available in the Git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-4.2-20191126 for you to

[PULL 4/8] vfio/pci: Respond to KVM irqchip change notifier

2019-11-25 Thread David Gibson
VFIO PCI devices already respond to the pci intx routing notifier, in order to update kernel irqchip mappings when routing is updated. However this won't handle the case where the irqchip itself is replaced by a different model while retaining the same routing. This case can happen on the pseries

<    1   2   3   >