Re: [PATCH v17 05/14] qapi: Add builtin type time

Tao Xu writes: > Add optional builtin type time, fallback is uint64. This type use > qemu_strtotime_ns() for pre-converting time suffix to numbers. > > Signed-off-by: Tao Xu > --- > > No changes in v17. > > Changes in v14: > - Drop time unit picosecond (Eric) > --- > include/qapi/visitor-im

Re: [PATCH] linux-user: fix translation of statx structures

Le 22/11/2019 à 18:40, Ariadne Conill a écrit : > All timestamps were copied to atime instead of to their respective > fields. > > Signed-off-by: Ariadne Conill > --- > linux-user/syscall.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/linux-user/syscall.

[PULL 0/3] virtio, pc: fixes

The following changes since commit 2061735ff09f9d5e67c501a96227b470e7de69b1: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2019-11-21 17:18:40 +) are available in the Git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream

[PULL 1/3] virtio-input: fix memory leak on unrealize

From: Marc-André Lureau Spotted by ASAN + minor stylistic change. Signed-off-by: Marc-André Lureau Reviewed-by: Michael S. Tsirkin Message-Id: <20191121095649.25453-1-marcandre.lur...@redhat.com> Signed-off-by: Michael S. Tsirkin Signed-off-by: Marc-André Lureau Reviewed-by: Michael S. Tsirk

[PULL 2/3] intel_iommu: refine SL-PEs reserved fields checking

From: "Qi, Yadong" 1. split the resevred fields arrays into two ones, 2. large page only effect for L2(2M) and L3(1G), so remove checking of L1 and L4 for large page. Signed-off-by: Zhang, Qi Signed-off-by: Qi, Yadong Message-Id: <20191125003321.5669-2-yadong...@intel.com> Reviewed-by: Pete

[PULL 3/3] intel_iommu: TM field should not be in reserved bits

From: "Qi, Yadong" When dt is supported, TM field should not be Reserved(0). Refer to VT-d Spec 9.8 Signed-off-by: Zhang, Qi Signed-off-by: Qi, Yadong Message-Id: <20191125003321.5669-3-yadong...@intel.com> Reviewed-by: Peter Xu Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsir

Re: [PATCH v36 00/17] QEMU AVR 8 bit cores

Cc'ing Joaquin who is implementing the ATmega328. On 11/24/19 6:02 AM, Michael Rolnik wrote: This series of patches adds 8bit AVR cores to QEMU. All instruction, except BREAK/DES/SPM/SPMX, are implemented. Not fully tested yet. However I was able to execute simple code with functions. e.g fibon

[Bug 1853781] Re: Baremetal kernel built from assembly runs multiple times

Hi Evan, Your suspicion is correct, the QEMU model starts with the four cores powered on, so your code is likely running on each core in simultaneous. The hardware booting process is described [1]: your code is loaded as the firmware loads kernel.img (the last step). The ARM maintainer suggested

[PATCH v3 0/5] s390x: Reset cleanup

Adding comments and reordering code for better readability in the diag308 and machine reset functions. v3: * Added user only afp set again * Added rev-by * Minor review cleanups Janosch Frank (5): s390x: Don't do a normal reset on the initial cpu s390x: Move reset norm

[PATCH v3 1/5] s390x: Don't do a normal reset on the initial cpu

The initiating cpu needs to be reset with an initial reset. While doing a normal reset followed by a initial reset is not wrong per se, the Ultravisor will only allow the correct reset to be performed. Signed-off-by: Janosch Frank Reviewed-by: David Hildenbrand --- hw/s390x/s390-virtio-ccw.c |

[PATCH v3 5/5] s390x: Beautify diag308 handling

Let's improve readability by: * Using constants for the subcodes * Moving parameter checking into a function * Removing subcode > 6 check as the default case catches that Signed-off-by: Janosch Frank Reviewed-by: Cornelia Huck Reviewed-by: Thomas Huth Reviewed-by: David Hildenbrand --- target

[PATCH v3 2/5] s390x: Move reset normal to shared reset handler

Let's start moving the cpu reset functions into a single function with a switch/case, so we can use fallthroughs and share more code between resets. This patch introduces the reset function by renaming cpu_reset() and cleaning up leftovers. Signed-off-by: Janosch Frank Reviewed-by: David Hildenb

[PATCH v3 3/5] s390x: Move initial reset

Let's move the intial reset into the reset handler and cleanup afterwards. Signed-off-by: Janosch Frank Reviewed-by: David Hildenbrand --- target/s390x/cpu-qom.h | 2 +- target/s390x/cpu.c | 44 -- target/s390x/cpu.h | 2 +- target/s390x/sigp.c

[PATCH v3 4/5] s390x: Move clear reset

Let's also move the clear reset function into the reset handler. Signed-off-by: Janosch Frank --- target/s390x/cpu-qom.h | 1 + target/s390x/cpu.c | 58 +- 2 files changed, 18 insertions(+), 41 deletions(-) diff --git a/target/s390x/cpu-qom.h b/targe

Re: [PATCH v17 06/14] tests: Add test for QAPI builtin type time

Tao Xu writes: > Add tests for time input such as zero, around limit of precision, > signed upper limit, actual upper limit, beyond limits, time suffixes, > and etc. > > Signed-off-by: Tao Xu > --- > > No changes in v17. > > Changes in v16: > - Update the test cases > > Changes in v14: >

[Bug 1853781] Re: Baremetal kernel built from assembly runs multiple times

Aha! So this is not a bug after all, but an intentional feature. Does "deal with handling all the secondary cores" basically mean "detecting what core I'm currently running on, and continuing only if it's the primary core"? If so, it's not clear to me how I could do this. I tried a few obvious ide

Re: [PATCH] virtio: fix IO request length in virtio SCSI/block #PSBM-78839

On 06.11.2019 15:03, Michael S. Tsirkin wrote: > On Thu, Oct 24, 2019 at 11:34:34AM +, Denis Lunev wrote: >> On 10/24/19 12:28 AM, Michael S. Tsirkin wrote: >>> On Fri, Oct 18, 2019 at 02:55:47PM +0300, Denis Plotnikov wrote: From: "Denis V. Lunev" Linux guests submit IO reque

Re: [RESEND PATCH v21 3/6] ACPI: Add APEI GHES table generation support

On Fri, 22 Nov 2019 15:42:52 + Beata Michalska wrote: > Hi Xiang, > > On Mon, 11 Nov 2019 at 01:48, Xiang Zheng wrote: > > > > From: Dongjiu Geng > > > > This patch implements APEI GHES Table generation via fw_cfg blobs. Now > > it only supports ARMv8 SEA, a type of GHESv2 error source. Af

Re: [RESEND PATCH v21 5/6] target-arm: kvm64: handle SIGBUS signal from kernel or KVM

On Fri, 22 Nov 2019 15:47:24 + Beata Michalska wrote: > Hi, > > On Fri, 15 Nov 2019 at 16:54, Igor Mammedov wrote: > > > > On Mon, 11 Nov 2019 09:40:47 +0800 > > Xiang Zheng wrote: > > > > > From: Dongjiu Geng > > > > > > Add a SIGBUS signal handler. In this handler, it checks the SIGBU

Re: [RESEND PATCH v21 3/6] ACPI: Add APEI GHES table generation support

On Mon, 18 Nov 2019 08:21:18 -0500 "Michael S. Tsirkin" wrote: > On Mon, Nov 18, 2019 at 09:18:01PM +0800, gengdongjiu wrote: > > On 2019/11/18 20:49, gengdongjiu wrote: > > >>> + */ > > >>> +build_append_int_noprefix(table_data, source_id, 2); > > >>> +/* Related Source Id */ > > >

Re: [PATCH v3 8/8] iotests: Test committing to short backing file

22.11.2019 19:05, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf Reviewed-by: Vladimir Sementsov-Ogievskiy Tested-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH v4 0/6] HPPA: i82596, PS/2 and graphics emulation

On 11/23/19 1:59 PM, Sven Schnelle wrote: > On Sun, Nov 03, 2019 at 09:56:01PM +0100, Sven Schnelle wrote: >> Hi, >> >> these series adds quite a lot to the HPPA emulation in QEMU: >> i82596 emulation from Helge, PS/2 and Artist graphics emulation. >> [..] > > Ping? :-) Version 1 missed the 4.2 c

[Bug 1852781] Re: qemu s390x on focal - applications breaking

** Tags added: qemu-20.04 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1852781 Title: qemu s390x on focal - applications breaking Status in QEMU: Incomplete Status in Ubuntu on IBM z Systems:

Re: [PATCH v4 18/37] mips: baudbase is 115200 by default

On Wednesday, November 20, 2019, Marc-André Lureau < marcandre.lur...@redhat.com> wrote: > Signed-off-by: Marc-André Lureau > --- > hw/mips/mips_mipssim.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/mips/mips_mipssim.c b/hw/mips/mips_mipssim.c > index bfafa4d7e9..3cd0e6eb33 100644

Re: [PATCH 0/4] fix & merge block_status_above and is_allocated_above

Ping? Hi! Why so silent? Postpone this to 5.0? This is fixing the same problem with block commit, like Kevin's series, just commit not to mid but to base.. 16.11.2019 19:34, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > I wanted to understand, what is the real difference between > bdrv_blo

Re: [PATCH v4 17/37] mips: inline serial_init()

On Wednesday, November 20, 2019, Marc-André Lureau < marcandre.lur...@redhat.com> wrote: > The function is specific to mipssim, let's inline it. > > Signed-off-by: Marc-André Lureau > --- > hw/char/serial.c | 16 > hw/mips/mips_mipssim.c | 15 --- > include

Re: [PATCH v4 18/37] mips: baudbase is 115200 by default

Hi On Mon, Nov 25, 2019 at 2:07 PM Aleksandar Markovic wrote: > > > > On Wednesday, November 20, 2019, Marc-André Lureau > wrote: >> >> Signed-off-by: Marc-André Lureau >> --- >> hw/mips/mips_mipssim.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/hw/mips/mips_mipssim.c b/hw/mips

Re: [PATCH v4 17/37] mips: inline serial_init()

Hi On Mon, Nov 25, 2019 at 2:12 PM Aleksandar Markovic wrote: > > > > On Wednesday, November 20, 2019, Marc-André Lureau > wrote: >> >> The function is specific to mipssim, let's inline it. >> >> Signed-off-by: Marc-André Lureau >> --- >> hw/char/serial.c | 16 >> hw/

Re: [PATCH v2 5/5] hvf: save away type as well as vector so we can reinject them

On 24/11/19 21:05, Cameron Esfahani wrote: > Save away type as well as vector in hvf_store_events() so we can > correctly reinject both in hvf_inject_interrupts(). > > Make sure to clear ins_len and has_error_code when ins_len isn't > valid and error_code isn't set. Do you have a testcase for thi

Re: [PATCH v2 0/5] hvf: stability fixes for HVF

On 24/11/19 21:05, Cameron Esfahani wrote: > The following patches fix stability issues with running QEMU on Apple > Hypervisor Framework (HVF): > - non-RAM, non-ROMD areas need to trap so accesses can be correctly > emulated. > - Current TSC synchronization implementation is insufficient: when >

Re: [PATCH 0/6] Enable Travis builds on arm64, ppc64le and s390x

Alex Bennée writes: > Thomas Huth writes: > >> Travis recently added build hosts for arm64, ppc64le and s390x, so >> this is a welcome addition to our Travis testing matrix. >> >> Unfortunately, the builds are running in quite restricted LXD containers >> there, for example it is not possible

[PATCH-for-4.2] hw/mips: Deprecate the r4k machine

The r4k machine was introduced in 2005 (6af0bf9c7) and its last logical change was in 2005 (9542611a6). After we can count 164 maintenance commits (QEMU API changes) with the exception of 1 fix in 2015 (memory leak, commit 3ad9fd5a). This machine was introduced as a proof of concept to run a MIPS

Re: [PATCH] target/arm: Honor HCR_EL2.TID3 trapping requirements

On 2019-11-25 10:40, Will Deacon wrote: On Sat, Nov 23, 2019 at 11:56:18AM +, Marc Zyngier wrote: HCR_EL2.TID3 mandates that access from EL1 to a long list of id registers traps to EL2, and QEMU has so far ignored this requirement. This breaks (among other things) KVM guests that have Ptr

Re: [PATCH 2/6] block: truncate: Don't make backing file data visible

Am 20.11.2019 um 19:01 hat Vladimir Sementsov-Ogievskiy geschrieben: > 20.11.2019 17:03, Kevin Wolf wrote: > > When extending the size of an image that has a backing file larger than > > its old size, make sure that the backing file data doesn't become > > visible in the guest, but the added area i

[Bug 1853826] [NEW] ELF loader fails to load shared object on ThunderX2 running RHEL7

Public bug reported: Simple test: hello.c include int main(int argc, char* argv[]) { { printf("Hello World... \n"); } return 0; } when compiled with : *Compiler https://developer.arm.com/tools-and-software/server-and-hpc/arm-architecture-tools/arm-allinea-studio/download Arm-Compile

Re: [PATCH v4 18/37] mips: baudbase is 115200 by default

On 11/25/19 11:12 AM, Marc-André Lureau wrote: Hi On Mon, Nov 25, 2019 at 2:07 PM Aleksandar Markovic wrote: On Wednesday, November 20, 2019, Marc-André Lureau wrote: Signed-off-by: Marc-André Lureau --- hw/mips/mips_mipssim.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/mi

[Bug 1853826] Re: ELF loader fails to load shared object on ThunderX2 running RHEL7

Could you invoke one of the failing and passing cases with -d page and post the results please. ** Tags added: arm linux-user -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1853826 Title: ELF load

Re: [PATCH v3 2/8] block: Add no_fallback parameter to bdrv_co_truncate()

On 22.11.19 17:05, Kevin Wolf wrote: > This adds a no_fallback parameter to bdrv_co_truncate(), bdrv_truncate() > and blk_truncate() in preparation for a fix that potentially needs to > zero-write the new area. no_fallback will use BDRV_REQ_NO_FALLBACK for > this operation and lets the truncate fai

[Bug 1848556] Re: qemu-img check failing on remote image in Eoan

Eoan - without fix -> hang With fix: qemu-img check http://10.193.37.117/cloud/eoan-server-cloudimg-amd64.img No errors were found on the image.

Re: [PATCH v3 3/8] qcow2: Declare BDRV_REQ_NO_FALLBACK supported

On 22.11.19 17:05, Kevin Wolf wrote: > In the common case, qcow2_co_pwrite_zeroes() already only modifies > metadata case, so we're fine with or without BDRV_REQ_NO_FALLBACK set. > > The only exception is when using an external data file, where the > request is passed down to the block driver of t

Re: [PATCH v17 03/14] util/cutils: refactor do_strtosz() to support suffixes list

On Mon, Nov 25, 2019 at 08:20:23AM +0100, Markus Armbruster wrote: > Tao Xu writes: > > > Add do_strtomul() to convert string according to different suffixes. > > > > Reviewed-by: Eduardo Habkost > > Signed-off-by: Tao Xu > > What's the actual change here? "Refactor" suggests the interfaces s

Re: [PATCH v3 8/8] iotests: Test committing to short backing file

On 22.11.19 17:05, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/274| 152 + > tests/qemu-iotests/274.out| 203 ++ > tests/qemu-iotests/group | 1 + > tests/qemu-iotests/iotests.py | 2 +- > 4

[Bug 1853781] Re: Baremetal kernel built from assembly runs multiple times

You can look at hw/arm/raspi.c::write_smpboot(): While the first core start booting the kernel, the other cores keep spinning until the 1st core configured the mailboxes: static const uint32_t smpboot[] = { 0xe1a0e00f, /*mov lr, pc */ 0xe3a0fe00 + (BOARDSETUP_ADDR >> 4), /* mov pc

Re: [PATCH v2 12/20] nvme: bump supported specification version to 1.3

On Mon, 18 Nov 2019 at 09:48, Klaus Birkelund wrote: > > On Tue, Nov 12, 2019 at 03:05:06PM +, Beata Michalska wrote: > > Hi Klaus, > > > > On Tue, 15 Oct 2019 at 11:52, Klaus Jensen wrote: > > > > > > +static uint16_t nvme_identify_ns_descr_list(NvmeCtrl *n, NvmeCmd *c) > > > +{ > > > +s

[PATCH] migration/ram: Yield periodically to the main loop

Usually, incoming migration coroutine yields to the main loop when it's IO-channel waits for data to receive. But there is a case when RAM migration and data receive have the same speed: VM with huge zeroed RAM. In this case, IO-channel won't read and thus the main loop is stuck and for example, it

Re: [PATCH v3 4/8] block: truncate: Don't make backing file data visible

On 22.11.19 17:05, Kevin Wolf wrote: > When extending the size of an image that has a backing file larger than > its old size, make sure that the backing file data doesn't become > visible in the guest, but the added area is properly zeroed out. > > Consider the following scenario where the overla

Re: [PATCH for-4.2? v3 0/8] block: Fix resize (extending) of short overlays

On 22.11.19 17:05, Kevin Wolf wrote: > See patch 4 for the description of the bug fixed. > > v3: > - Don't allow blocking the monitor for a zero write in block_resize > (even though we can already blockfor other reasons there). This is > mainly responsible for the increased complexity compared

Re: [PATCH for-4.2? v3 0/8] block: Fix resize (extending) of short overlays

On 22.11.19 17:41, Eric Blake wrote: > On 11/22/19 10:17 AM, Peter Maydell wrote: [...] >> Eyeballing of the diffstat plus the fact we're on v4 of >> the patchset already makes me a little uneasy about >> putting it into rc3, but if the bug we're fixing matters >> enough we can do it. > > In ter

Re: [PATCH] migration/ram: Yield periodically to the main loop

Yury Kotov wrote: > Usually, incoming migration coroutine yields to the main loop > when it's IO-channel waits for data to receive. But there is a case > when RAM migration and data receive have the same speed: VM with huge > zeroed RAM. In this case, IO-channel won't read and thus the main loop >

Re: [PATCH v4 18/37] mips: baudbase is 115200 by default

On Mon, Nov 25, 2019 at 12:26 PM Philippe Mathieu-Daudé wrote: > > On 11/25/19 11:12 AM, Marc-André Lureau wrote: > > Hi > > > > On Mon, Nov 25, 2019 at 2:07 PM Aleksandar Markovic > > wrote: > >> > >> > >> > >> On Wednesday, November 20, 2019, Marc-André Lureau > >> wrote: > >>> > >>> Signed-o

Avocado notes from KVM forum 2019

Hi Cleber, Here are my notes from talking about Avocado with various people during the KVM forum in Lyon last month. All comments are QEMU oriented. 1) Working offline Various people complained Avocado requires online access, and they would like to use it offline. Maintainer workflow e

[PATCH V2] ppc/spapr_events: fix potential NULL pointer dereference in rtas_event_log_dequeue

From: PanNengyuan This fixes coverity issues 68911917: 360 CID 68911917: (NULL_RETURNS) 361. dereference: Dereferencing "source", which is known to be "NULL". 361if (source->mask & event_mask) { 362break; 363} R

Re: [PATCH v2 09/20] nvme: add support for the asynchronous event request command

On Tue, 19 Nov 2019 at 19:51, Klaus Birkelund wrote: > > On Tue, Nov 12, 2019 at 03:04:59PM +, Beata Michalska wrote: > > Hi Klaus, > > > > On Tue, 15 Oct 2019 at 11:49, Klaus Jensen wrote: > > > @@ -1188,6 +1326,9 @@ static int nvme_start_ctrl(NvmeCtrl *n) > > > > > > nvme_set_timestamp

Re: [PATCH] migration/ram: Yield periodically to the main loop

Patchew URL: https://patchew.org/QEMU/20191125120548.13589-1-yury-ko...@yandex-team.ru/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BE

[Bug 1853826] Re: ELF loader fails to load shared object on ThunderX2 running RHEL7

Taishan 2280 Cortex-A72 Running 1)with -armpl flag with and without the docker armclang -armpl hello.c ./qemu/build/aarch64-linux-user/qemu-aarch64 -d page a.out host mmap_min_addr=0x8000 Reserved 0x21000 bytes of guest address space Relocating guest address space from 0x00400

[PATCH for-4.2 0/2] Fix bitmap migration

Hi all! We've faced a bug in rhev-2.12.0-33.el7-based Qemu. In upstream, bug introduced in 4.0 by 74da6b943565c45 "block/dirty-bitmaps: implement inconsistent bit" commit. At this commit we started to load inconsistent bitmap instead of silently ignoring them, and it now I see that it breaks migra

[PATCH 1/2] block/qcow2-bitmap: fix bitmap migration

Fix bitmap migration with dirty-bitmaps capability enabled and shared storage. We should ignore IN_USE bitmaps in the image on target, when migrating bitmaps through migration channel, see new comment below. Fixes: 74da6b943565c451 Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-bitm

[PATCH 2/2] iotests: add new test cases to bitmap migration

Add optional pre-shutdown: shutdown/launch vm before migration. This leads to storing persistent bitmap to the storage, which breaks migration with dirty-bitmaps capability enabled and shared storage until fixed by previous commit. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotes

Re: [PATCH v4 18/37] mips: baudbase is 115200 by default

On 11/25/19 12:26 PM, Philippe Mathieu-Daudé wrote: On 11/25/19 11:12 AM, Marc-André Lureau wrote: Hi On Mon, Nov 25, 2019 at 2:07 PM Aleksandar Markovic wrote: On Wednesday, November 20, 2019, Marc-André Lureau wrote: Signed-off-by: Marc-André Lureau ---   hw/mips/mips_mipssim.c | 1

Re: [PATCH v4 18/37] mips: baudbase is 115200 by default

On 11/25/19 1:54 PM, Philippe Mathieu-Daudé wrote: On 11/25/19 12:26 PM, Philippe Mathieu-Daudé wrote: On 11/25/19 11:12 AM, Marc-André Lureau wrote: Hi On Mon, Nov 25, 2019 at 2:07 PM Aleksandar Markovic wrote: On Wednesday, November 20, 2019, Marc-André Lureau wrote: Signed-off-by:

[PATCH 1/5] mips: jazz: Renovate coding style

The script checkpatch.pl located in scripts folder was used to detect all errors and warrnings in files: hw/mips/mips_jazz.c hw/display/jazz_led.c hw/dma/rc4030.c All these mips jazz machine files were edited and all the errors and warrings generated by the checkpatch.pl script were co

Re: [PATCH v6 2/9] hw/core/clock-vmstate: define a vmstate entry for clock state

On 9/4/19 2:55 PM, Damien Hedde wrote: Signed-off-by: Damien Hedde Reviewed-by: Philippe Mathieu-Daudé --- This was in the previous reviewed commit. But it can't be in the clock.c file in order to allow linux-user builds. --- hw/core/Makefile.objs | 1 + hw/core/clock-vmstate.c | 25 +

[PATCH 4/5] mips: r4000: Renovate coding style

The script checkpatch.pl located in scripts folder was used to detect all errors and warrnings in file: hw/mips/mips_r4k.c This mips r4000 machine file was edited and all the errors and warrings generated by the checkpatch.pl script were corrected and then the script was ran again to make sure

[PATCH 2/5] mips: malta: Renovate coding style

The script checkpatch.pl located in scripts folder was used to detect all errors and warrnings in files: hw/mips/mips_malta.c hw/mips/gt64xxx_pci.c tests/acceptance/linux_ssh_mips_malta.py All these mips malta machine files were edited and all the errors and warrings generated by the c

[PATCH 0/5] mips: machines: Renovate coding style

The scripts checkpatch.pl located in scripts folder was used to check for errors and warnings in fllowing mips machines: Jazz Malta Mipssim R4000 Fulong 2E Boston All generated errors and warnings were corrected and the script was ran again to make sure there are no more errors

[PATCH 3/5] mips: mipssim: Renovate coding style

The script checkpatch.pl located in scripts folder was used to detect all errors and warrnings in files: hw/mips/mips_mipssim.c hw/net/mipsnet.c All these mips mipssim machine files were edited and all the errors and warrings generated by the checkpatch.pl script were corrected and then th

Re: [PATCH v3 1/5] s390x: Don't do a normal reset on the initial cpu

On Mon, 25 Nov 2019 04:03:44 -0500 Janosch Frank wrote: > The initiating cpu needs to be reset with an initial reset. While > doing a normal reset followed by a initial reset is not wrong per se, > the Ultravisor will only allow the correct reset to be performed. > > Signed-off-by: Janosch Frank

[PATCH 5/5] mips: fulong 2e: Renovate coding style

The script checkpatch.pl located in scripts folder was used to detect all errors and warrnings in files: hw/mips/mips_fulong2e.c hw/isa/vt82c686.c hw/pci-host/bonito.c include/hw/isa/vt82c686.h These mips Fulong 2E machine files were edited and all the errors and warrings generated

Re: [PATCH for-5.0 v11 12/20] qapi: Introduce DEFINE_PROP_INTERVAL

Hi Dave, On 11/22/19 8:03 PM, Dr. David Alan Gilbert wrote: > * Eric Auger (eric.au...@redhat.com) wrote: >> Introduce a new property defining a labelled interval: >> ,,label. >> >> This will be used to encode reserved IOVA regions. The label >> is left undefined to ease reuse accross use cases. >

Re: [PATCH v6 1/9] hw/core/clock: introduce clock objects

On 9/4/19 2:55 PM, Damien Hedde wrote: Introduce clock objects: ClockIn and ClockOut. These objects may be used to distribute clocks from an object to several other objects. Each ClockIn object contains the current state of the clock: the frequency; it allows an object to migrate its input clock

Re: [PATCH for-4.2 v10 06/15] virtio-iommu: Endpoint and domains structs and helpers

Hi Jean, On 11/4/19 7:31 PM, Jean-Philippe Brucker wrote: > Hi Eric, > > On Tue, Jul 30, 2019 at 07:21:28PM +0200, Eric Auger wrote: >> static void virtio_iommu_device_unrealize(DeviceState *dev, Error **errp) >> { >> VirtIODevice *vdev = VIRTIO_DEVICE(dev); >> +VirtIOIOMMU *s = VIRTIO_

Re: [PATCH v3 2/5] s390x: Move reset normal to shared reset handler

On Mon, 25 Nov 2019 04:03:45 -0500 Janosch Frank wrote: > Let's start moving the cpu reset functions into a single function with > a switch/case, so we can use fallthroughs and share more code between > resets. > > This patch introduces the reset function by renaming cpu_reset() and > cleaning u

Re: [PATCH v2 13/20] nvme: refactor prp mapping

On Wed, 20 Nov 2019 at 09:39, Klaus Birkelund wrote: > > On Tue, Nov 12, 2019 at 03:23:43PM +, Beata Michalska wrote: > > Hi Klaus, > > > > On Tue, 15 Oct 2019 at 11:57, Klaus Jensen wrote: > > > > > > Instead of handling both QSGs and IOVs in multiple places, simply use > > > QSGs everywhere

RE: [PATCH 0/5] ARM virt: Add NVDIMM support

Hi Eric/Igor, > -Original Message- > From: Shameerali Kolothum Thodi > Sent: 22 October 2019 15:05 > To: 'Auger Eric' ; qemu-devel@nongnu.org; > qemu-...@nongnu.org; imamm...@redhat.com > Cc: peter.mayd...@linaro.org; shannon.zha...@gmail.com; xuwei (O) > ; ler...@redhat.com; Linuxarm > >

Re: [PATCH v6 3/9] qdev: add clock input&output support to devices.

Nitpick: remove trailing dot in patch subject On 9/4/19 2:55 PM, Damien Hedde wrote: Add functions to easily add input or output clocks to a device. A clock objects is added as a child of the device. ? The api is very similar the gpio's one. Maybe "This API is very similar to the QDEV GPIO

Re: [PATCH v4 17/37] mips: inline serial_init()

On Monday, November 25, 2019, Marc-André Lureau wrote: > Hi > > On Mon, Nov 25, 2019 at 2:12 PM Aleksandar Markovic > wrote: > > > > > > > > On Wednesday, November 20, 2019, Marc-André Lureau < > marcandre.lur...@redhat.com> wrote: > >> > >> The function is specific to mipssim, let's inline it.

[PATCH v2] migration/ram: Yield periodically to the main loop

Usually, incoming migration coroutine yields to the main loop while its IO-channel is waiting for data to receive. But there is a case when RAM migration and data receive have the same speed: VM with huge zeroed RAM. In this case, IO-channel won't read and thus the main loop is stuck and for instan

Re: [PATCH v3 4/5] s390x: Move clear reset

On Mon, 25 Nov 2019 04:03:47 -0500 Janosch Frank wrote: > Let's also move the clear reset function into the reset handler. > > Signed-off-by: Janosch Frank > --- > target/s390x/cpu-qom.h | 1 + > target/s390x/cpu.c | 58 +- > 2 files changed, 18 ins

Re: [PATCH v6 1/9] hw/core/clock: introduce clock objects

On 9/4/19 2:55 PM, Damien Hedde wrote: Introduce clock objects: ClockIn and ClockOut. These objects may be used to distribute clocks from an object to several other objects. Each ClockIn object contains the current state of the clock: the frequency; it allows an object to migrate its input clock

[PATCH 1/2] util/cutils: Turn FIXME comment into QEMU_BUILD_BUG_ON()

qemu_strtoi64() assumes int64_t is long long. This is marked FIXME. Replace by a QEMU_BUILD_BUG_ON() to avoid surprises. Same for qemu_strtou64(). Fix a typo in qemu_strtoul()'s contract while there. Signed-off-by: Markus Armbruster --- util/cutils.c | 8 +--- 1 file changed, 5 insertions

[PATCH 0/2] Minor integer parsing improvements

Not for 4.2, of course. Markus Armbruster (2): util/cutils: Turn FIXME comment into QEMU_BUILD_BUG_ON() test-keyval: Tighten test of trailing crap after size tests/test-keyval.c | 2 +- util/cutils.c | 8 +--- 2 files changed, 6 insertions(+), 4 deletions(-) -- 2.21.0

[PATCH 2/2] test-keyval: Tighten test of trailing crap after size

test_keyval_visit_size() should test for trailing crap after size with and without suffix. It does test the latter: "sz2=16Gi" has size "16G" followed by crap "i". It fails to test the former "sz1=16E" is a syntactically valid size that overflows uint64_t. Replace by "sz1=0Z". Signed-off-by: Ma

Re: [PATCH] target/arm: Honor HCR_EL2.TID3 trapping requirements

On Sat, Nov 23, 2019 at 11:56:18AM +, Marc Zyngier wrote: > HCR_EL2.TID3 mandates that access from EL1 to a long list of id > registers traps to EL2, and QEMU has so far ignored this requirement. > > This breaks (among other things) KVM guests that have PtrAuth enabled, > while the hypervisor

Re: [PATCH] linux-user: Improve strace output for read() and getcwd()

On Sun, Nov 24, 2019 at 2:31 PM Aleksandar Markovic wrote: > > > > On Sunday, November 24, 2019, Helge Deller wrote: >> >> On 24.11.19 13:10, Aleksandar Markovic wrote: >> > >> > >> > On Sunday, November 24, 2019, Helge Deller > > > wrote: >> > >> > On 23.11.19 12:34, Al

[PATCH] target/arm: Allow loading elf from aliased ROM regions

With this patch, we allow loading a ROM image at an aliased address, when it is located in a memory region for which an alias exists. Signed-off-by: Jean-Hugues Deschenes --- target/arm/cpu.c | 33 ++--- 1 file changed, 26 insertions(+), 7 deletions(-) diff --git a/t

Re: [PATCH v3 4/5] s390x: Move clear reset

On 11/25/19 2:37 PM, Cornelia Huck wrote: > On Mon, 25 Nov 2019 04:03:47 -0500 > Janosch Frank wrote: > >> Let's also move the clear reset function into the reset handler. >> >> Signed-off-by: Janosch Frank >> --- >> target/s390x/cpu-qom.h | 1 + >> target/s390x/cpu.c | 58 +---

Re: [PATCH for-4.2 0/2] Fix bitmap migration

On 25.11.19 13:52, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > We've faced a bug in rhev-2.12.0-33.el7-based Qemu. > In upstream, bug introduced in 4.0 by 74da6b943565c45 > "block/dirty-bitmaps: implement inconsistent bit" commit. > At this commit we started to load inconsistent bitmap inste

Re: Avocado notes from KVM forum 2019

Thank you, Philippe, those are great ideas. I have copied them to the Avocado+QEMU Trello board so we don't forget about them: https://trello.com/b/6Qi1pxVn/avocado-qemu Additional comments below: On Mon, Nov 25, 2019 at 01:35:13PM +0100, Philippe Mathieu-Daudé wrote: > Hi Cleber, > > Here are

Re: [PATCH v2 14/20] nvme: allow multiple aios per command

On Thu, 21 Nov 2019 at 11:57, Klaus Birkelund wrote: > > On Tue, Nov 12, 2019 at 03:25:06PM +, Beata Michalska wrote: > > Hi Klaus, > > > > On Tue, 15 Oct 2019 at 11:55, Klaus Jensen wrote: > > > @@ -341,19 +344,18 @@ static uint16_t nvme_dma_write_prp(NvmeCtrl *n, > > > uint8_t *ptr, uint32

Re: [PATCH for-4.2 0/2] Fix bitmap migration

25.11.2019 16:50, Max Reitz wrote: > On 25.11.19 13:52, Vladimir Sementsov-Ogievskiy wrote: >> Hi all! >> >> We've faced a bug in rhev-2.12.0-33.el7-based Qemu. >> In upstream, bug introduced in 4.0 by 74da6b943565c45 >> "block/dirty-bitmaps: implement inconsistent bit" commit. >> At this commit we

Re: [PATCH for-4.2 2/2] i386: Add -noTSX aliases for hle=off, rtm=off CPU models

On Thu, Nov 21, 2019 at 03:12:45PM +0100, Kashyap Chamarthy wrote: > On Wed, Nov 20, 2019 at 01:49:12PM -0300, Eduardo Habkost wrote: > > We have been trying to avoid adding new aliases for CPU model > > versions, but in the case of changes in defaults introduced by > > the TAA mitigation patches,

Re: [PATCH 1/2] util/cutils: Turn FIXME comment into QEMU_BUILD_BUG_ON()

On 11/25/19 2:38 PM, Markus Armbruster wrote: qemu_strtoi64() assumes int64_t is long long. This is marked FIXME. Replace by a QEMU_BUILD_BUG_ON() to avoid surprises. Same for qemu_strtou64(). Fix a typo in qemu_strtoul()'s contract while there. Signed-off-by: Markus Armbruster --- util/cu

[PATCH] mos6522: update counters when timer interrupts are off

Even if the interrupts are off, counters must be updated because they are running anyway and kernel can try to read them (it's the case with g3beige kernel). Reported-by: Andrew Randrianasulu Signed-off-by: Laurent Vivier --- hw/misc/mos6522.c | 8 ++-- 1 file changed, 6 insertions(+), 2 de

Re: Avocado notes from KVM forum 2019

> > 1) Working offline > > > > Various people complained Avocado requires online access, and they would > > like to use it offline. > > > > Maintainer workflow example is: > > > > - run avocado > > - hack QEMU, build > > - git pull > > - build > > - hack QEMU > > (go offline) > >

Re: [PATCH v2 15/20] nvme: add support for scatter gather lists

On Mon, 25 Nov 2019 at 06:21, Klaus Birkelund wrote: > > On Tue, Nov 12, 2019 at 03:25:18PM +, Beata Michalska wrote: > > Hi Klaus, > > > > On Tue, 15 Oct 2019 at 11:57, Klaus Jensen wrote: > > > +static uint16_t nvme_map_sgl(NvmeCtrl *n, QEMUSGList *qsg, > > > +NvmeSglDescriptor sgl, uin

[Bug 1853826] Re: ELF loader fails to load shared object on ThunderX2 running RHEL7

As it's taking longer to get the compiler up and running on my system could you attach the failing binary along with the extra .so libs from /scratch/arm-linux-compiler/* -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.la

Re: [PATCH 2/2] test-keyval: Tighten test of trailing crap after size

On 11/25/19 7:38 AM, Markus Armbruster wrote: test_keyval_visit_size() should test for trailing crap after size with and without suffix. It does test the latter: "sz2=16Gi" has size "16G" followed by crap "i". It fails to test the former "sz1=16E" is a syntactically valid size that overflows ui

QEMU Summit Minutes

As usual, we held a QEMU Summit meeting at KVM Forum. This is an invite-only meeting for the most active maintainers and submaintainers in the project, and we discuss various project-wide issues, usually process stuff. We then post the minutes of the meeting to the list as a jumping off point for w

Re: [PATCH] mos6522: update counters when timer interrupts are off

On 11/25/19 3:14 PM, Laurent Vivier wrote: Even if the interrupts are off, counters must be updated because they are running anyway and kernel can try to read them (it's the case with g3beige kernel). Reported-by: Andrew Randrianasulu Signed-off-by: Laurent Vivier --- hw/misc/mos6522.c | 8 +

Re: [PATCH-for-4.2] hw/mips: Deprecate the r4k machine

On Monday, November 25, 2019, Philippe Mathieu-Daudé wrote: > The r4k machine was introduced in 2005 (6af0bf9c7) and its last > logical change was in 2005 (9542611a6). After we can count 164 > maintenance commits (QEMU API changes) with the exception of > 1 fix in 2015 (memory leak, commit 3ad9fd

  1   2   3   >