Re: [RFC v4 PATCH 18/49] multi-process: create IOHUB object to handle irq

2019-11-21 Thread Stefan Hajnoczi
On Thu, Oct 24, 2019 at 05:08:59AM -0400, Jagannathan Raman wrote: I don't know the interrupt code well enough to decide whether it's necessary to do so much work and tie the protocol to the KVM API. The main QEMU process already has the KVM API code and the ability to deal with these things. I

Re: [PATCH v2] linux-user/strace: Add missing signal strings

2019-11-21 Thread Richard Henderson
On 11/20/19 3:55 PM, Helge Deller wrote: > Add the textual representations of some missing target signals. > > Signed-off-by: Helge Deller Reviewed-by: Richard Henderson r~

Re: [RFC v4 PATCH 19/49] multi-process: configure remote side devices

2019-11-21 Thread Stefan Hajnoczi
On Thu, Oct 24, 2019 at 05:09:00AM -0400, Jagannathan Raman wrote: > +static void set_remote_opts(PCIDevice *dev, QDict *qdict, unsigned int cmd) > +{ > +QString *qstr; > +MPQemuMsg msg; > +const char *str; > +PCIProxyDev *pdev; > + > +pdev = PCI_PROXY_DEV(dev); > + > +qstr

Re: [PATCH 11/15] RFC: s390x: Exit on vcpu reset error

2019-11-21 Thread David Hildenbrand
On 20.11.19 12:43, Janosch Frank wrote: If a vcpu is not properly reset it might be better to just end the VM. Signed-off-by: Janosch Frank --- target/s390x/kvm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c index 190400df55..0210b54157 100644

Re: [RFC v4 PATCH 20/49] multi-process: add qdev_proxy_add to create proxy devices

2019-11-21 Thread Stefan Hajnoczi
On Thu, Oct 24, 2019 at 05:09:01AM -0400, Jagannathan Raman wrote: > diff --git a/hw/proxy/qemu-proxy.c b/hw/proxy/qemu-proxy.c > index 3b84055..fc1c731 100644 > --- a/hw/proxy/qemu-proxy.c > +++ b/hw/proxy/qemu-proxy.c > @@ -337,7 +337,8 @@ static void init_proxy(PCIDevice *dev, char *command, >

Re: [PATCH] Fix incorrect int->float conversions caught by clang -Wimplicit-int-float-conversion

2019-11-21 Thread Richard Henderson
On 11/20/19 6:30 PM, Fangrui Song wrote: > On 2019-11-20, Juan Quintela wrote: >> Markus Armbruster wrote: >>> Fangrui Song writes: >>> The warning will be enabled by default in clang 10. It is not available for clang <= 9. qemu/migration/migration.c:2038:24: error: implicit c

Re: [PATCH 01/15] s390x: Cleanup cpu resets

2019-11-21 Thread Cornelia Huck
On Thu, 21 Nov 2019 12:32:38 +0100 Janosch Frank wrote: > On 11/21/19 12:10 PM, Cornelia Huck wrote: > > On Wed, 20 Nov 2019 06:43:20 -0500 > > Janosch Frank wrote: > > > >> Let's move the resets into one function and switch by type, so we can > >> use fallthroughs for shared reset actions.

Re: [RFC v4 PATCH 30/49] multi-process: send heartbeat messages to remote

2019-11-21 Thread Stefan Hajnoczi
On Wed, Nov 13, 2019 at 11:01:07AM -0500, Jag Raman wrote: > > > On 11/11/2019 11:27 AM, Stefan Hajnoczi wrote: > > On Thu, Oct 24, 2019 at 05:09:11AM -0400, Jagannathan Raman wrote: > > > +static void broadcast_msg(MPQemuMsg *msg, bool need_reply) > > > +{ > > > +PCIProxyDev *entry; > > > +

Re: [PATCH 11/15] RFC: s390x: Exit on vcpu reset error

2019-11-21 Thread Janosch Frank
On 11/21/19 1:14 PM, David Hildenbrand wrote: > On 20.11.19 12:43, Janosch Frank wrote: >> If a vcpu is not properly reset it might be better to just end the VM. >> >> Signed-off-by: Janosch Frank >> --- >> target/s390x/kvm.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/target/

Re: [PATCH 11/15] RFC: s390x: Exit on vcpu reset error

2019-11-21 Thread David Hildenbrand
On 21.11.19 13:19, Janosch Frank wrote: On 11/21/19 1:14 PM, David Hildenbrand wrote: On 20.11.19 12:43, Janosch Frank wrote: If a vcpu is not properly reset it might be better to just end the VM. Signed-off-by: Janosch Frank --- target/s390x/kvm.c | 2 ++ 1 file changed, 2 insertions(+)

Re: [PATCH v2 2/6] block: truncate: Don't make backing file data visible

2019-11-21 Thread Max Reitz
On 21.11.19 12:34, Kevin Wolf wrote: > Am 21.11.2019 um 09:59 hat Max Reitz geschrieben: >> On 20.11.19 19:44, Kevin Wolf wrote: >>> When extending the size of an image that has a backing file larger than >>> its old size, make sure that the backing file data doesn't become >>> visible in the guest

Re: [RFC v4 PATCH 32/49] multi-process: Use separate MMIO communication channel

2019-11-21 Thread Stefan Hajnoczi
On Wed, Nov 13, 2019 at 11:14:50AM -0500, Jag Raman wrote: > On 11/11/2019 11:21 AM, Stefan Hajnoczi wrote: > > On Thu, Oct 24, 2019 at 05:09:13AM -0400, Jagannathan Raman wrote: > > > Using a separate communication channel for MMIO helps > > > with improving Performance > > > > Why? > > Typical

Re: [RFC v4 PATCH 00/49] Initial support of multi-process qemu

2019-11-21 Thread Stefan Hajnoczi
On Thu, Oct 24, 2019 at 05:08:41AM -0400, Jagannathan Raman wrote: > Started with the presentation in October 2017 made by Marc-Andre (Red Hat) > and Konrad Wilk (Oracle) [1], and continued by Jag's BoF at KVM Forum 2018, > the multi-process project is now a prototype and presented in this patchset

Re: [PULL for rc3 0/5] a few doc and testing tweaks

2019-11-21 Thread Peter Maydell
On Wed, 20 Nov 2019 at 10:58, Alex Bennée wrote: > > The following changes since commit 39e2821077e6dcf788b7c2a9ef50970ec7995437: > > Update version for v4.2.0-rc2 release (2019-11-19 19:34:10 +) > > are available in the Git repository at: > > https://github.com/stsquad/qemu.git tags/pull-

Re: [PATCH 03/15] s390x: protvirt: Add diag308 subcodes 8 - 10

2019-11-21 Thread Cornelia Huck
On Wed, 20 Nov 2019 06:43:22 -0500 Janosch Frank wrote: > For diag308 subcodes 8 - 10 we have a new ipib of type 5. The ipib > holds the address and length of the secure execution header, as well > as a list of guest components. > > Each component is a block of memory, for example kernel or init

Re: QEMU HTML documentation now on qemu.org

2019-11-21 Thread Stefan Hajnoczi
On Fri, Nov 15, 2019 at 09:05:32AM -0500, G 3 wrote: > > You can now access the latest QEMU HTML documentation built from > > https://wiki.qemu.org/docs/qemu-doc.html > > > This is a welcome start. Could we add version support to the URL? > > What I mean is add the version number to the path of

Re: [qemu-web PATCH] Add device fuzzing blog post

2019-11-21 Thread Stefan Hajnoczi
On Tue, Nov 12, 2019 at 12:39:49PM +0100, Thomas Huth wrote: > On 07/11/2019 16.48, Stefan Hajnoczi wrote: > > On Thu, Nov 7, 2019 at 10:43 AM Thomas Huth wrote: > >> > >> - Original Message - > >>> From: "Stefan Hajnoczi" > >>> Sent: Thursday, November 7, 2019 10:11:36 AM > >>> > >>> Thi

Re: [PATCH 01/15] s390x: Cleanup cpu resets

2019-11-21 Thread Thomas Huth
On 20/11/2019 12.43, Janosch Frank wrote: > Let's move the resets into one function and switch by type, so we can > use fallthroughs for shared reset actions. > > Signed-off-by: Janosch Frank > --- > hw/s390x/s390-virtio-ccw.c | 3 + > target/s390x/cpu.c | 111 -

Re: [PATCH 04/15] Header sync protvirt

2019-11-21 Thread Cornelia Huck
On Wed, 20 Nov 2019 06:43:23 -0500 Janosch Frank wrote: > Let's sync all the protvirt header changes > > Signed-off-by: Janosch Frank > --- > linux-headers/asm-s390/kvm.h | 3 ++- > linux-headers/linux/kvm.h| 42 > 2 files changed, 44 insertions(+), 1

Re: [PATCH v2 6/6] iotests: Test committing to short backing file

2019-11-21 Thread Vladimir Sementsov-Ogievskiy
21.11.2019 14:39, Kevin Wolf wrote: > Am 21.11.2019 um 11:30 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 21.11.2019 13:28, Vladimir Sementsov-Ogievskiy wrote: >>> 20.11.2019 21:45, Kevin Wolf wrote: Signed-off-by: Kevin Wolf >>> >>> Hmm, allocating 7G will break tests on small disks, for

Re: [PATCH 01/15] s390x: Cleanup cpu resets

2019-11-21 Thread Janosch Frank
On 11/21/19 1:53 PM, Thomas Huth wrote: > On 20/11/2019 12.43, Janosch Frank wrote: >> Let's move the resets into one function and switch by type, so we can >> use fallthroughs for shared reset actions. >> >> Signed-off-by: Janosch Frank >> --- >> hw/s390x/s390-virtio-ccw.c | 3 + >> target/s39

Re: [PATCH 02/15] s390x: Beautify diag308 handling

2019-11-21 Thread Thomas Huth
On 21/11/2019 12.21, David Hildenbrand wrote: > On 20.11.19 12:43, Janosch Frank wrote: >> Let's improve readability by: >> * Using constants for the subcodes >> * Moving parameter checking into a function >> * Removing subcode > 6 check as the default case catches that >> >> Signed-off-by: Janosch

Re: [PATCH 04/15] Header sync protvirt

2019-11-21 Thread Janosch Frank
On 11/21/19 1:59 PM, Cornelia Huck wrote: > On Wed, 20 Nov 2019 06:43:23 -0500 > Janosch Frank wrote: > >> Let's sync all the protvirt header changes >> >> Signed-off-by: Janosch Frank >> --- >> linux-headers/asm-s390/kvm.h | 3 ++- >> linux-headers/linux/kvm.h| 42

Re: [PATCH 04/15] Header sync protvirt

2019-11-21 Thread Cornelia Huck
On Thu, 21 Nov 2019 14:12:21 +0100 Janosch Frank wrote: > On 11/21/19 1:59 PM, Cornelia Huck wrote: > > On Wed, 20 Nov 2019 06:43:23 -0500 > > Janosch Frank wrote: > > > >> Let's sync all the protvirt header changes > >> > >> Signed-off-by: Janosch Frank > >> --- > >> linux-headers/asm-s390

Re: [PATCH 01/15] s390x: Cleanup cpu resets

2019-11-21 Thread Thomas Huth
On 21/11/2019 14.11, Janosch Frank wrote: > On 11/21/19 1:53 PM, Thomas Huth wrote: >> On 20/11/2019 12.43, Janosch Frank wrote: >>> Let's move the resets into one function and switch by type, so we can >>> use fallthroughs for shared reset actions. [...] >>> +memset(env, 0, offsetof(CPUS39

Re: [PATCH 02/15] s390x: Beautify diag308 handling

2019-11-21 Thread Thomas Huth
On 20/11/2019 12.43, Janosch Frank wrote: > Let's improve readability by: > * Using constants for the subcodes > * Moving parameter checking into a function > * Removing subcode > 6 check as the default case catches that > > Signed-off-by: Janosch Frank > --- > target/s390x/diag.c | 54 +

[PATCH v2] target/i386: add VMX features to named CPU models

2019-11-21 Thread Paolo Bonzini
This allows using "-cpu Haswell,+vmx", which we did not really want to support in QEMU but was produced by Libvirt when using the "host-model" CPU model. This was produced from the output of scripts/kvm/vmxcap using the following very ugly Python script: bits = { 'INS/OUTS instruc

Re: [PATCH] target/arm: Fix handling of cortex-m FTYPE flag in EXCRET

2019-11-21 Thread Peter Maydell
On Thu, 21 Nov 2019 at 01:44, Jean-Hugues Deschênes wrote: > > According to the PushStack() pseudocode in the armv7m RM, > bit 4 of the LR should be set to NOT(CONTROL.PFCA) when > an FPU is present. Current implementation is doing it for > armv8, but not for armv7. This patch makes the existing >

Re: [PATCH 05/15] s390x: protvirt: Sync PV state

2019-11-21 Thread Cornelia Huck
On Wed, 20 Nov 2019 06:43:24 -0500 Janosch Frank wrote: > We do not always have the SIE intercept code handy at each place where > we do emulation. Unfortunately emulation for secure guests often > differ slightly from normal emulation and we need to make decisions > based on the protected state

Re: [PATCH v3 0/2] virtio: make seg_max virtqueue size dependent

2019-11-21 Thread Stefan Hajnoczi
On Tue, Nov 12, 2019 at 02:13:52PM +0300, Denis Plotnikov wrote: > v3: > * add property to set in machine type [MST] > * add min queue size check [Stefan] > * add avocado based test [Max, Stefan, Eduardo, Cleber] > > v2: > * the standalone patch to make seg_max virtqueue size dependent >

Re: [PATCH v2 3/6] iotests: Add qemu_io_log()

2019-11-21 Thread Alberto Garcia
On Wed 20 Nov 2019 07:44:58 PM CET, Kevin Wolf wrote: > Add a function that runs qemu-io and logs the output with the > appropriate filters applied. > > Signed-off-by: Kevin Wolf > Reviewed-by: Eric Blake > Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia Berto

Re: [PATCH v2 4/6] iotests: Fix timeout in run_job()

2019-11-21 Thread Alberto Garcia
On Wed 20 Nov 2019 07:44:59 PM CET, Kevin Wolf wrote: > run_job() accepts a wait parameter for a timeout, but it doesn't > actually use it. The only thing that is missing is passing it to > events_wait(), so do that now. > > Signed-off-by: Kevin Wolf > Reviewed-by: Eric Blake > Reviewed-by: Vladi

Re: [PATCH v2 5/6] iotests: Support job-complete in run_job()

2019-11-21 Thread Alberto Garcia
On Wed 20 Nov 2019 07:45:00 PM CET, Kevin Wolf wrote: > Automatically complete jobs that have a 'ready' state and need an > explicit job-complete. Without this, run_job() would hang for such > jobs. > > Signed-off-by: Kevin Wolf > Reviewed-by: Eric Blake > Reviewed-by: Vladimir Sementsov-Ogievski

Re: [PATCH v4 06/37] serial: initial qom-ification

2019-11-21 Thread Peter Maydell
On Wed, 20 Nov 2019 at 15:25, Marc-André Lureau wrote: > > Make SerialState a device (the following patches will introduce IO/MM > sysbus serial devices) > > None of the serial_{,mm}_init() callers actually free the returned > value (even if they did, it would be quite harmless), so we can change

Re: [PATCH v4 18/37] mips: baudbase is 115200 by default

2019-11-21 Thread Peter Maydell
On Wed, 20 Nov 2019 at 15:28, Marc-André Lureau wrote: > > Signed-off-by: Marc-André Lureau > --- > hw/mips/mips_mipssim.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/mips/mips_mipssim.c b/hw/mips/mips_mipssim.c > index bfafa4d7e9..3cd0e6eb33 100644 > --- a/hw/mips/mips_mipssim.c

Re: [PATCH v4 19/37] mips: use sysbus_add_io()

2019-11-21 Thread Peter Maydell
On Wed, 20 Nov 2019 at 15:28, Marc-André Lureau wrote: > > Signed-off-by: Marc-André Lureau > --- > hw/mips/mips_mipssim.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/hw/mips/mips_mipssim.c b/hw/mips/mips_mipssim.c > index 3cd0e6eb33..2c2c7f25b2 100644 > --- a/hw/m

Re: [PATCH 05/15] s390x: protvirt: Sync PV state

2019-11-21 Thread Janosch Frank
On 11/21/19 2:25 PM, Cornelia Huck wrote: > On Wed, 20 Nov 2019 06:43:24 -0500 > Janosch Frank wrote: > >> We do not always have the SIE intercept code handy at each place where >> we do emulation. Unfortunately emulation for secure guests often >> differ slightly from normal emulation and we nee

Re: [PATCH] vhost-user-fs: remove "vhostfd" property

2019-11-21 Thread Stefan Hajnoczi
On Sat, Nov 16, 2019 at 03:20:16PM +0400, Marc-André Lureau wrote: > The property doesn't make much sense for a vhost-user device. > > Signed-off-by: Marc-André Lureau > --- > hw/virtio/vhost-user-fs.c | 1 - > include/hw/virtio/vhost-user-fs.h | 1 - > 2 files changed, 2 deletions(-) I

Re: [PATCH v4 12/37] serial: start making SerialMM a sysbus device

2019-11-21 Thread Peter Maydell
On Wed, 20 Nov 2019 at 15:27, Marc-André Lureau wrote: > > Memory mapped serial device is in fact a sysbus device. The following > patches will make use of sysbus facilities for resource and > registration. In particular, "serial-mm: use sysbus facilities" will > move internal serial realization t

Re: [PATCH v4 20/37] mips: use sysbus_mmio_get_region() instead of internal fields

2019-11-21 Thread Peter Maydell
On Wed, 20 Nov 2019 at 15:28, Marc-André Lureau wrote: > > Register the memory region with sysbus_init_mmio() and look it up with > sysbus_mmio_get_region() to avoid accessing internal device fields. > > Suggested-by: Peter Maydell > Signed-off-by: Marc-André Lureau > --- > hw/char/serial.c

Re: [PATCH 07/15] s390x: protvirt: Handle diag 308 subcodes 0,1,3,4

2019-11-21 Thread Cornelia Huck
On Wed, 20 Nov 2019 06:43:26 -0500 Janosch Frank wrote: > Now that we know the protection state off the cpus, we can start > handling all diag 308 subcodes in the protected state. "As we now have access to the protection state of the cpus, we can implement special handling of diag 308 subcodes f

Re: [PATCH] vhost-user-input: use free(elem) instead of g_free(elem)

2019-11-21 Thread Stefan Hajnoczi
On Wed, Nov 20, 2019 at 11:48:56AM +, Daniel P. Berrangé wrote: > On Tue, Nov 19, 2019 at 11:16:26AM +, Stefan Hajnoczi wrote: > > The virtqueue element returned by vu_queue_pop() is allocated using > > malloc(3) by virtqueue_alloc_element(). Use the matching free(3) > > function instead o

Re: [Qemu-devel] [PATCH v2 1/2] net: assert that tx packets have nonzero size

2019-11-21 Thread Alexander Bulekov
On 191107 1221, Jason Wang wrote: > > On 2019/7/22 下午9:24, Oleinik, Alexander wrote: > > Virtual devices should not try to send zero-sized packets. The caller > > should check the size prior to calling qemu_sendv_packet_async. > > > > Signed-off-by: Alexander Oleinik > > --- > > v2: > >* Imp

Re: [PATCH v4 27/37] leon3: use qdev gpio facilities for the PIL

2019-11-21 Thread Peter Maydell
On Wed, 20 Nov 2019 at 15:30, Marc-André Lureau wrote: > > Signed-off-by: Marc-André Lureau > --- > hw/sparc/leon3.c | 6 -- > target/sparc/cpu.h | 1 - > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/hw/sparc/leon3.c b/hw/sparc/leon3.c > index cac987373e..1a89d44e57 10

Re: [PATCH 02/15] s390x: Beautify diag308 handling

2019-11-21 Thread Janosch Frank
On 11/21/19 2:20 PM, Thomas Huth wrote: > On 20/11/2019 12.43, Janosch Frank wrote: >> Let's improve readability by: >> * Using constants for the subcodes >> * Moving parameter checking into a function >> * Removing subcode > 6 check as the default case catches that >> >> Signed-off-by: Janosch Fra

Re: [qemu-web PATCH] Add a blog post about the QEMU-related presentation of KVM Forum 2019

2019-11-21 Thread Kashyap Chamarthy
On Thu, Nov 21, 2019 at 12:52:07PM +0100, Thomas Huth wrote: > There have been quite a lot of QEMU-related talks at KVM Forum this > year - let's provide a summary for the people who could not attend. > > Signed-off-by: Thomas Huth > --- > Note: For some talks it's hard to decide whether they re

[PATCH v4 0/5] blockdev: avoid acquiring AioContext lock twice at do_drive_backup and do_blockdev_backup

2019-11-21 Thread Sergio Lopez
do_drive_backup() acquires the AioContext lock of the corresponding BlockDriverState. This is not a problem when it's called from qmp_drive_backup(), but drive_backup_prepare() also acquires the lock before calling it. The same things happens with do_blockdev_backup() and blockdev_backup_prepare().

[PATCH v4 2/5] blockdev: unify qmp_drive_backup and drive-backup transaction paths

2019-11-21 Thread Sergio Lopez
Issuing a drive-backup from qmp_drive_backup takes a slightly different path than when it's issued from a transaction. In the code, this is manifested as some redundancy between do_drive_backup() and drive_backup_prepare(). This change unifies both paths, merging do_drive_backup() and drive_backup

[PATCH v4 1/5] blockdev: fix coding style issues in drive_backup_prepare

2019-11-21 Thread Sergio Lopez
Fix a couple of minor coding style issues in drive_backup_prepare. Signed-off-by: Sergio Lopez --- blockdev.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/blockdev.c b/blockdev.c index 8e029e9c01..553e315972 100644 --- a/blockdev.c +++ b/blockdev.c @@ -3620,7 +3620

[PATCH v4 5/5] iotests: fix 141 after qmp_drive_backup with transactions

2019-11-21 Thread Sergio Lopez
qmp_drive_backup now creates and starts a transactions, which implies that the job will transition to pause and running twice. Fix test 141 to be aware of this change. Signed-off-by: Sergio Lopez --- tests/qemu-iotests/141.out | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/qemu-iote

Re: [qemu-web PATCH] Add a blog post about the QEMU-related presentation of KVM Forum 2019

2019-11-21 Thread Eric Blake
On 11/21/19 5:52 AM, Thomas Huth wrote: There have been quite a lot of QEMU-related talks at KVM Forum this year - let's provide a summary for the people who could not attend. Signed-off-by: Thomas Huth --- Note: For some talks it's hard to decide whether they really fit the QEMU blog or no

[PATCH v4 3/5] blockdev: unify qmp_blockdev_backup and blockdev-backup transaction paths

2019-11-21 Thread Sergio Lopez
Issuing a blockdev-backup from qmp_blockdev_backup takes a slightly different path than when it's issued from a transaction. In the code, this is manifested as some redundancy between do_blockdev_backup() and blockdev_backup_prepare(). This change unifies both paths, merging do_blockdev_backup() a

Re: [PATCH v4 21/37] sm501: make SerialMM a child, export chardev property

2019-11-21 Thread Peter Maydell
On Wed, 20 Nov 2019 at 15:31, Marc-André Lureau wrote: > > Embed the SerialMM sybus device, and re-export its "chardev" property. > That way, we can get rid of PROP_PTR "chr-state" and better track > devices relationship. > > Signed-off-by: Marc-André Lureau > --- > hw/display/sm501.c | 33 +

[PATCH v4 4/5] blockdev: honor bdrv_try_set_aio_context() context requirements

2019-11-21 Thread Sergio Lopez
bdrv_try_set_aio_context() requires that the old context is held, and the new context is not held. Fix all the occurrences where it's not done this way. Suggested-by: Max Reitz Signed-off-by: Sergio Lopez --- blockdev.c | 67 ++ 1 file changed

Re: [PATCH 08/15] s390x: protvirt: KVM intercept changes

2019-11-21 Thread Cornelia Huck
On Wed, 20 Nov 2019 06:43:27 -0500 Janosch Frank wrote: > Secure guests no longer intercept with code 4 for an instruction > interception. Instead they have codes 104 and 108 for secure > instruction interception and secure instruction notification > respectively. > > The 104 mirrors the 4, but

Re: [PATCH 07/15] s390x: protvirt: Handle diag 308 subcodes 0,1,3,4

2019-11-21 Thread Janosch Frank
On 11/21/19 2:50 PM, Cornelia Huck wrote: > On Wed, 20 Nov 2019 06:43:26 -0500 > Janosch Frank wrote: > >> Now that we know the protection state off the cpus, we can start >> handling all diag 308 subcodes in the protected state. > > "As we now have access to the protection state of the cpus, we

Re: [PATCH 07/15] s390x: protvirt: Handle diag 308 subcodes 0,1,3,4

2019-11-21 Thread Janosch Frank
On 11/21/19 2:50 PM, Cornelia Huck wrote: > On Wed, 20 Nov 2019 06:43:26 -0500 > Janosch Frank wrote: > >> run_on_cpu(cs, s390_do_cpu_load_normal, RUN_ON_CPU_NULL); >> break; >> case S390_RESET_LOAD_NORMAL: /* Subcode 1*/ > > missing blank before */ (introduced in a previ

Re: [PATCH for-4.2? v2 0/6] block: Fix resize (extending) of short overlays

2019-11-21 Thread Stefan Hajnoczi
On Wed, Nov 20, 2019 at 07:44:55PM +0100, Kevin Wolf wrote: > See patch 2 for the description of the bug fixed. > > v2: > - Switched order of bs->total_sectors update and zero write [Vladimir] > - Fixed coding style [Vladimir] > - Changed the commit message to contain what was in the cover letter

Re: PCI memory sync question (kvm,dpdk,e1000,packet stalled)

2019-11-21 Thread Stefan Hajnoczi
On Wed, Nov 20, 2019 at 08:36:32PM +0300, ASM wrote: > I trying solve the problem, with packets stopping (e1000,tap,kvm). > My studies led to the following: > 1. From flatview_write_continue() I see, what e1000 writes the number > "7" to the STAT register. > 2. The driver from target OS reads STAT

Re: [PATCH for-4.2 2/2] i386: Add -noTSX aliases for hle=off, rtm=off CPU models

2019-11-21 Thread Kashyap Chamarthy
On Wed, Nov 20, 2019 at 01:49:12PM -0300, Eduardo Habkost wrote: > We have been trying to avoid adding new aliases for CPU model > versions, but in the case of changes in defaults introduced by > the TAA mitigation patches, the aliases might help avoid user > confusion when applying host software u

Re: [PATCH 09/15] s390x: protvirt: SCLP interpretation

2019-11-21 Thread Cornelia Huck
On Wed, 20 Nov 2019 06:43:28 -0500 Janosch Frank wrote: > SCLP for a protected guest is done over the SIDAD, so we need to use > the s390_cpu_virt_mem_* functions to access the SIDAD instead of guest > memory when reading/writing SCBs. > > To not confuse the sclp emulation, we set 0x42000 as the

Re: [PATCH v6] Implement backend program convention command for vhost-user-blk

2019-11-21 Thread Stefan Hajnoczi
On Thu, Nov 21, 2019 at 09:58:26AM +0800, Micky Yun Chan wrote: > diff --git a/docs/interop/vhost-user.json b/docs/interop/vhost-user.json > index da6aaf51c8..d25c3a957f 100644 > --- a/docs/interop/vhost-user.json > +++ b/docs/interop/vhost-user.json > @@ -54,6 +54,37 @@ >] > } > > +## > +#

Re: [PATCH 07/15] s390x: protvirt: Handle diag 308 subcodes 0,1,3,4

2019-11-21 Thread Cornelia Huck
On Thu, 21 Nov 2019 15:04:31 +0100 Janosch Frank wrote: > On 11/21/19 2:50 PM, Cornelia Huck wrote: > > On Wed, 20 Nov 2019 06:43:26 -0500 > > Janosch Frank wrote: > > > > >> run_on_cpu(cs, s390_do_cpu_load_normal, RUN_ON_CPU_NULL); > >> break; > >> case S390_RESET_L

[PATCH v3] target/i386: add VMX features to named CPU models

2019-11-21 Thread Paolo Bonzini
This allows using "-cpu Haswell,+vmx", which we did not really want to support in QEMU but was produced by Libvirt when using the "host-model" CPU model. This was produced from the output of scripts/kvm/vmxcap using the following very ugly Python script: bits = { 'INS/OUTS instruc

Re: [PATCH 07/15] s390x: protvirt: Handle diag 308 subcodes 0,1,3,4

2019-11-21 Thread Janosch Frank
On 11/21/19 3:17 PM, Cornelia Huck wrote: > On Thu, 21 Nov 2019 15:04:31 +0100 > Janosch Frank wrote: > >> On 11/21/19 2:50 PM, Cornelia Huck wrote: >>> On Wed, 20 Nov 2019 06:43:26 -0500 >>> Janosch Frank wrote: >> >>> run_on_cpu(cs, s390_do_cpu_load_normal, RUN_ON_CPU_NULL);

Re: [PATCH 06/15] s390x: protvirt: Support unpack facility

2019-11-21 Thread Janosch Frank
On 11/21/19 12:27 PM, David Hildenbrand wrote: > On 20.11.19 12:43, Janosch Frank wrote: >> @@ -357,6 +353,35 @@ static void s390_machine_reset(MachineState *machine) >> run_on_cpu(cs, s390_do_cpu_initial_reset, RUN_ON_CPU_NULL); >> run_on_cpu(cs, s390_do_cpu_load_normal, RUN_O

Re: [PATCH 09/15] s390x: protvirt: SCLP interpretation

2019-11-21 Thread Janosch Frank
On 11/21/19 3:11 PM, Cornelia Huck wrote: > On Wed, 20 Nov 2019 06:43:28 -0500 > Janosch Frank wrote: > >> SCLP for a protected guest is done over the SIDAD, so we need to use >> the s390_cpu_virt_mem_* functions to access the SIDAD instead of guest >> memory when reading/writing SCBs. >> >> To n

Re: [PATCH 06/15] s390x: protvirt: Support unpack facility

2019-11-21 Thread David Hildenbrand
On 21.11.19 15:25, Janosch Frank wrote: On 11/21/19 12:27 PM, David Hildenbrand wrote: On 20.11.19 12:43, Janosch Frank wrote: @@ -357,6 +353,35 @@ static void s390_machine_reset(MachineState *machine) run_on_cpu(cs, s390_do_cpu_initial_reset, RUN_ON_CPU_NULL); run_on_cp

Re: [PATCH 08/15] s390x: protvirt: KVM intercept changes

2019-11-21 Thread Janosch Frank
On 11/21/19 3:07 PM, Cornelia Huck wrote: > On Wed, 20 Nov 2019 06:43:27 -0500 > Janosch Frank wrote: > >> Secure guests no longer intercept with code 4 for an instruction >> interception. Instead they have codes 104 and 108 for secure >> instruction interception and secure instruction notificati

Re: [PATCH 06/15] s390x: protvirt: Support unpack facility

2019-11-21 Thread Christian Borntraeger
On 21.11.19 15:28, David Hildenbrand wrote: >> And please trim your emails. >> > > If you use Thunderbird I suggest QuoteCollapse ... because nobody got time > for that ;) neat.

Re: [PATCH] RISC-V: virt: This is a "sifive,test1" test finisher

2019-11-21 Thread Palmer Dabbelt
On Sun, 10 Nov 2019 13:10:33 PST (-0800), da...@gibson.dropbear.id.au wrote: On Fri, Nov 08, 2019 at 10:13:16AM -0800, Palmer Dabbelt wrote: On Fri, 08 Nov 2019 10:04:47 PST (-0800), Peter Maydell wrote: > On Fri, 8 Nov 2019 at 17:15, Alistair Francis wrote: > > > > On Fri, Nov 8, 2019 at 9:05

Re: [PATCH 06/15] s390x: protvirt: Support unpack facility

2019-11-21 Thread Janosch Frank
On 11/21/19 3:31 PM, Christian Borntraeger wrote: > > > On 21.11.19 15:28, David Hildenbrand wrote: >>> And please trim your emails. >>> >> >> If you use Thunderbird I suggest QuoteCollapse ... because nobody got time >> for that ;) > > neat. > Yeah, seems like I'm already too old-school for

Re: [PATCH v2 2/6] block: truncate: Don't make backing file data visible

2019-11-21 Thread Kevin Wolf
Am 21.11.2019 um 13:21 hat Max Reitz geschrieben: > On 21.11.19 12:34, Kevin Wolf wrote: > > Am 21.11.2019 um 09:59 hat Max Reitz geschrieben: > >> On 20.11.19 19:44, Kevin Wolf wrote: > >>> When extending the size of an image that has a backing file larger than > >>> its old size, make sure that t

Re: [PATCH 03/15] s390x: protvirt: Add diag308 subcodes 8 - 10

2019-11-21 Thread Thomas Huth
On 20/11/2019 12.43, Janosch Frank wrote: > For diag308 subcodes 8 - 10 we have a new ipib of type 5. The ipib > holds the address and length of the secure execution header, as well > as a list of guest components. > > Each component is a block of memory, for example kernel or initrd, > which need

Re: [PATCH 05/15] s390x: protvirt: Sync PV state

2019-11-21 Thread Thomas Huth
On 20/11/2019 12.43, Janosch Frank wrote: > We do not always have the SIE intercept code handy at each place where > we do emulation. Unfortunately emulation for secure guests often > differ slightly from normal emulation and we need to make decisions > based on the protected state of the VCPU. >

Re: [PATCH] Fix incorrect int->float conversions caught by clang -Wimplicit-int-float-conversion

2019-11-21 Thread Markus Armbruster
Richard Henderson writes: > On 11/20/19 6:30 PM, Fangrui Song wrote: >> On 2019-11-20, Juan Quintela wrote: >>> Markus Armbruster wrote: Fangrui Song writes: [...] > diff --git a/util/cutils.c b/util/cutils.c > index fd591cadf0..2b4484c015 100644 > --- a/util/cutils.c > +++

Re: [PATCH v2 1/1] ide: check DMA transfer size in ide_dma_cb() to prevent qemu DoS from quests

2019-11-21 Thread Kevin Wolf
Am 14.11.2019 um 18:25 hat Alexander Popov geschrieben: > The commit a718978ed58a from July 2015 introduced the assertion which > implies that the size of successful DMA transfers handled in ide_dma_cb() > should be multiple of 512 (the size of a sector). But guest systems can > initiate DMA transf

Re: [Qemu-devel] [PATCH v4 03/14] qapi: Introduce default values for struct members

2019-11-21 Thread Markus Armbruster
Max Reitz writes: > With this change, it is possible to give default values for struct > members, as follows: > > What you had to do so far: > > # @member: Some description, defaults to 42. > { 'struct': 'Foo', > 'data': { '*member': 'int' } } > > What you can do now: > > {

Re: [PATCH 08/15] s390x: protvirt: KVM intercept changes

2019-11-21 Thread Thomas Huth
On 20/11/2019 12.43, Janosch Frank wrote: > Secure guests no longer intercept with code 4 for an instruction > interception. Instead they have codes 104 and 108 for secure > instruction interception and secure instruction notification > respectively. > > The 104 mirrors the 4, but the 108 is a not

Re: [Qemu-devel] [PATCH v4 04/14] qapi: Allow optional discriminators

2019-11-21 Thread Markus Armbruster
Max Reitz writes: > Optional discriminators are fine, as long as there is a default value. > > Signed-off-by: Max Reitz > --- > scripts/qapi/common.py | 14 -- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py > index

Re: [PATCH v4 00/14] block: Try to create well-typed json:{} filenames

2019-11-21 Thread Markus Armbruster
Markus Armbruster writes: > Max Reitz writes: > >> On 13.09.19 13:49, Max Reitz wrote: >>> Another gentle ping. >> >> And another. > > Conflicts with the refactoring merged in commit 69717d0f890. Please > accept my apologies for the inconvenience caused by the excessive delay. > > I'll try to r

Re: [Qemu-devel] [PATCH v4 03/14] qapi: Introduce default values for struct members

2019-11-21 Thread Eric Blake
On 11/21/19 9:07 AM, Markus Armbruster wrote: Max Reitz writes: With this change, it is possible to give default values for struct members, as follows: What you had to do so far: # @member: Some description, defaults to 42. { 'struct': 'Foo', 'data': { '*member': 'int' }

Re: [PATCH v2 2/6] block: truncate: Don't make backing file data visible

2019-11-21 Thread Max Reitz
On 21.11.19 15:33, Kevin Wolf wrote: > Am 21.11.2019 um 13:21 hat Max Reitz geschrieben: >> On 21.11.19 12:34, Kevin Wolf wrote: >>> Am 21.11.2019 um 09:59 hat Max Reitz geschrieben: On 20.11.19 19:44, Kevin Wolf wrote: > When extending the size of an image that has a backing file larger t

Re: [PATCH v1 1/1] hw/arm: versal: Add the CRP as unimplemented

2019-11-21 Thread Edgar E. Iglesias
Hi Peter, Can we consider this patch for 4.2? Thanks, Edgar On Fri, Nov 15, 2019 at 04:47:34PM +0100, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Add the CRP as unimplemented thus avoiding bus errors when > guests access these registers. > > Signed-off-by: Edgar E. Iglesias > -

Re: [Qemu-devel] [PATCH 0/2] hw/timer/m48t59: Convert to trace events

2019-11-21 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > ping? Did this fall through the cracks? > On 6/26/19 2:20 PM, Philippe Mathieu-Daudé wrote: >> Another trivial cleanup series. >> >> Philippe Mathieu-Daudé (2): >> MAINTAINERS: Add missing m48t59 files to the PReP section >> hw/timer/m48t59: Convert debug p

Re: [PATCH v1 1/1] hw/arm: versal: Add the CRP as unimplemented

2019-11-21 Thread Peter Maydell
On Thu, 21 Nov 2019 at 15:28, Edgar E. Iglesias wrote: > > Hi Peter, > > Can we consider this patch for 4.2? Sure, it looks pretty safe. I've applied it to my queue for rc3. thanks -- PMM

Re: [PATCH] ppc/pnv: Create BMC devices at machine init

2019-11-21 Thread Corey Minyard
On Wed, Nov 20, 2019 at 09:05:07AM +1100, David Gibson wrote: > On Tue, Nov 19, 2019 at 07:49:33AM +0100, Cédric Le Goater wrote: > > On 19/11/2019 01:52, David Gibson wrote: > > > On Mon, Nov 18, 2019 at 10:22:22AM +0100, Cédric Le Goater wrote: > > >> The BMC of the OpenPOWER systems monitors the

Re: [qemu-web PATCH] Add a blog post about the QEMU-related presentation of KVM Forum 2019

2019-11-21 Thread Alex Bennée
Thomas Huth writes: > There have been quite a lot of QEMU-related talks at KVM Forum this > year - let's provide a summary for the people who could not attend. > > Signed-off-by: Thomas Huth > --- > Note: For some talks it's hard to decide whether they really fit the > QEMU blog or not. I've

Re: [PATCH] ppc/pnv: Create BMC devices at machine init

2019-11-21 Thread Corey Minyard
On Mon, Nov 18, 2019 at 10:22:22AM +0100, Cédric Le Goater wrote: > The BMC of the OpenPOWER systems monitors the machine state using > sensors, controls the power and controls the access to the PNOR flash > device containing the firmware image required to boot the host. > > QEMU models the power

[PULL 4/4] i386: Add -noTSX aliases for hle=off, rtm=off CPU models

2019-11-21 Thread Paolo Bonzini
From: Eduardo Habkost We have been trying to avoid adding new aliases for CPU model versions, but in the case of changes in defaults introduced by the TAA mitigation patches, the aliases might help avoid user confusion when applying host software updates. Signed-off-by: Eduardo Habkost Signed-o

[PULL 0/4] x86 updates for QEMU 4.2-rc

2019-11-21 Thread Paolo Bonzini
The following changes since commit 39e2821077e6dcf788b7c2a9ef50970ec7995437: Update version for v4.2.0-rc2 release (2019-11-19 19:34:10 +) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to fetch changes up to 02fa60d10137ed2ef17534718

[PULL 2/4] target/i386: add support for MSR_IA32_TSX_CTRL

2019-11-21 Thread Paolo Bonzini
The MSR_IA32_TSX_CTRL MSR can be used to hide TSX (also known as the Trusty Side-channel Extension). By virtualizing the MSR, KVM guests can disable TSX and avoid paying the price of mitigating TSX-based attacks on microarchitectural side channels. Reviewed-by: Eduardo Habkost Signed-off-by: Pao

[PULL 3/4] i386: Add new versions of Skylake/Cascadelake/Icelake without TSX

2019-11-21 Thread Paolo Bonzini
From: Eduardo Habkost One of the mitigation methods for TAA[1] is to disable TSX support on the host system. Linux added a mechanism to disable TSX globally through the kernel command line, and many Linux distributions now default to tsx=off. This makes existing CPU models that have HLE and RTM

[Bug 1848556] Re: qemu-img check failing on remote image in Eoan

2019-11-21 Thread Christian Ehrhardt 
This was tonight first accepted and then immediately rejected as it was surpassed by a security fix. => Rebased and uploaded 1:4.0+dfsg-0ubuntu9.2 to eoan-unapproved again. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs

[PULL 1/4] target/i386: add VMX features to named CPU models

2019-11-21 Thread Paolo Bonzini
This allows using "-cpu Haswell,+vmx", which we did not really want to support in QEMU but was produced by Libvirt when using the "host-model" CPU model. Without this patch, no VMX feature is _actually_ supported (only the basic instruction set extensions are) and KVM fails to load in the guest.

Re: [Qemu-devel] [PATCH v8 00/11] Measure Tiny Code Generation Quality

2019-11-21 Thread Markus Armbruster
vandersonmr writes: > This patch is part of Google Summer of Code (GSoC) 2019. > More about the project can be found in: > https://wiki.qemu.org/Internships/ProjectIdeas/TCGCodeQuality > > The goal of this patch is to add infrastructure to collect > execution and JIT statistics during the emulati

Re: [qemu-web PATCH] Add a blog post about the QEMU-related presentation of KVM Forum 2019

2019-11-21 Thread Paolo Bonzini
On 21/11/19 14:59, Eric Blake wrote: > On 11/21/19 5:52 AM, Thomas Huth wrote: >> There have been quite a lot of QEMU-related talks at KVM Forum this >> year - let's provide a summary for the people who could not attend. >> >> Signed-off-by: Thomas Huth >> --- >>   Note: For some talks it's hard t

Re: [PATCH] ppc/pnv: Create BMC devices at machine init

2019-11-21 Thread Cédric Le Goater
On 21/11/2019 16:36, Corey Minyard wrote: > On Mon, Nov 18, 2019 at 10:22:22AM +0100, Cédric Le Goater wrote: >> The BMC of the OpenPOWER systems monitors the machine state using >> sensors, controls the power and controls the access to the PNOR flash >> device containing the firmware image require

Re: [Qemu-devel] [PATCH 0/2] hw/timer/m48t59: Convert to trace events

2019-11-21 Thread Philippe Mathieu-Daudé
On 11/21/19 4:28 PM, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: ping? Did this fall through the cracks? Certainly =) Thanks for noticing. This now need a (trivial) rebase. I'll respin for 5.0. On 6/26/19 2:20 PM, Philippe Mathieu-Daudé wrote: Another trivial cleanup series.

[PATCH v2] ppc/pnv: Create BMC devices at machine init

2019-11-21 Thread Cédric Le Goater
The BMC of the OpenPOWER systems monitors the machine state using sensors, controls the power and controls the access to the PNOR flash device containing the firmware image required to boot the host. QEMU models the power cycle process, access to the sensors and access to the PNOR device. But, for

  1   2   3   >