Re: [PATCH 2/5] hw/ppc/pnv_xscom: PBA bar mask values are incorrect with homer/occ sizes

2019-11-20 Thread Greg Kurz
On Wed, 20 Nov 2019 08:46:51 +0530 Balamuruhan S wrote: > On Wed, Nov 20, 2019 at 08:31:03AM +0530, Balamuruhan S wrote: > > On Wed, Nov 20, 2019 at 09:02:26AM +1100, David Gibson wrote: > > > On Wed, Nov 20, 2019 at 09:00:32AM +1100, David Gibson wrote: > > > > On Wed, Nov 20, 2019 at 08:56:18AM

Re: [PATCH v3 15/33] serial-mm: add endianness property

2019-11-20 Thread Marc-André Lureau
On Mon, Nov 18, 2019 at 7:07 PM Peter Maydell wrote: > > On Wed, 23 Oct 2019 at 18:34, Marc-André Lureau > wrote: > > > > Add a qdev property for endianness, so memory region setup can be done > > in realize. > > > > Signed-off-by: Marc-André Lureau > > --- > > hw/char/serial.c | 2 ++ >

Re: [PATCH v3 1/3] mem: move nvdimm_device_list to utilities

2019-11-20 Thread Shivaprasad G Bhat
Hi Igor, On 11/19/2019 12:43 PM, Igor Mammedov wrote: On Mon, 14 Oct 2019 13:37:37 -0500 Shivaprasad G Bhat wrote: nvdimm_device_list is required for parsing the list for devices in subsequent patches. Move it to common utility area. Signed-off-by: Shivaprasad G Bhat --- hw/acpi/nvdimm.c

Re: [PATCH] Add minimal Hexagon target - First in a series of patches - linux-user changes + linux-user/hexagon + skeleton of target/hexagon - Files in target/hexagon/imported are from another project

2019-11-20 Thread Richard Henderson
On 11/20/19 6:15 AM, Taylor Simpson wrote: >> +const char * const hexagon_prednames[] = { >> + "p0 ", "p1 ", "p2 ", "p3 " >> +}; > > Inter-string spacing probably belongs to the format not the name. > [Taylor] Could you elaborate? Should I put spacing after the commas? "p0" not "p0 ". Typo on

Re: [PATCH] Hexagon: Swap SIGRGMAX-1 and SIGRTMIN+1

2019-11-20 Thread Laurent Vivier
Le 19/11/2019 à 20:31, Peter Maydell a écrit : > On Tue, 19 Nov 2019 at 19:07, Taylor Simpson wrote: >> >> Signed-off-by: Taylor Simpson >> --- >> linux-user/signal.c | 8 >> 1 file changed, 8 insertions(+) >> >> diff --git a/linux-user/signal.c b/linux-user/signal.c >> index 5ca6d62..c

Re: [PATCH] audio: fix audio recording

2019-11-20 Thread Gerd Hoffmann
On Tue, Nov 19, 2019 at 07:58:49AM +0100, Volker Rümelin wrote: > With current code audio recording with all audio backends > except PulseAudio and DirectSound is broken. The generic audio > recording buffer management forgot to update the current read > position after a read. > > Fixes: ff095e523

[Bug 1853083] Re: qemu ppc64 4.0 boot AIX5.1 hung

2019-11-20 Thread wzis
Tried POWER5, but got [root@192 emu]# ./aix51 qemu-system-ppc64: unable to find CPU model 'POWER5' -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1853083 Title: qemu ppc64 4.0 boot AIX5.1 hung Stat

[Bug 1853083] Re: qemu ppc64 4.0 boot AIX5.1 hung

2019-11-20 Thread wzis
[root@192 emu]# qemu-system-ppc64 --version QEMU emulator version 4.1.0 Copyright (c) 2003-2019 Fabrice Bellard and the QEMU Project developers [root@192 emu]# -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net

Re: [PATCH v3 16/33] serial-mm: use sysbus facilities

2019-11-20 Thread Marc-André Lureau
Hi On Mon, Nov 18, 2019 at 7:09 PM Peter Maydell wrote: > > On Wed, 23 Oct 2019 at 18:34, Marc-André Lureau > wrote: > > > > Make SerialMM a regular sysbus device, by registering the irq, and the > > mmio region. Reexport the internal serial properties. > > > > Signed-off-by: Marc-André Lureau

Re: [PATCH] Add minimal Hexagon target - First in a series of patches - linux-user changes + linux-user/hexagon + skeleton of target/hexagon - Files in target/hexagon/imported are from another project

2019-11-20 Thread Laurent Vivier
Le 20/11/2019 à 05:48, Taylor Simpson a écrit : > For the general DEBUG_HEX messages, I think the trace infrastructure isn't > quite what I'm looking for. > > Here's a sample of what it prints > Start packet: pc = 0x4002f0 > Packet committed: pc = 0x4002f0 > Regs written > r18 = -69420 (0

Re: [PATCH v4 17/19] spapr: Remove last pieces of SpaprIrq

2019-11-20 Thread Greg Kurz
On Wed, 20 Nov 2019 16:38:37 +1100 David Gibson wrote: [...] > > > > Hmmm... I had the impression that capability numbers would stay > > forever, even if at some point we may decide to not support some > > of them for newer machine types... Can you elaborate on a > > deprecating scenario that wo

Re: [PATCH for-5.0 v5 04/23] ppc/pnv: Dump the XIVE NVT table

2019-11-20 Thread Cédric Le Goater
On 19/11/2019 23:06, David Gibson wrote: > On Fri, Nov 15, 2019 at 05:24:17PM +0100, Cédric Le Goater wrote: >> This is useful to dump the saved contexts of the vCPUs : configuration >> of the base END index of the vCPU and the Interrupt Pending Buffer >> register, which is updated when an interrup

Re: [PATCH] Add minimal Hexagon target - First in a series of patches - linux-user changes + linux-user/hexagon + skeleton of target/hexagon - Files in target/hexagon/imported are from another project

2019-11-20 Thread Laurent Vivier
Le 20/11/2019 à 03:26, Aleksandar Markovic a écrit : > > > On Tuesday, November 19, 2019, Richard Henderson > mailto:richard.hender...@linaro.org>> wrote: > > On 11/19/19 6:22 PM, Taylor Simpson wrote: > > - Laurent suggested I split the patch into two parts: linux-user > and target/

Re: [PATCH v3 17/33] serial: make SerialIO a sysbus device

2019-11-20 Thread Marc-André Lureau
Hi On Mon, Nov 18, 2019 at 7:17 PM Peter Maydell wrote: > > On Wed, 23 Oct 2019 at 18:34, Marc-André Lureau > wrote: > > > > Make serial IO a proper sysbus device, similar to serial MM. > > > > Signed-off-by: Marc-André Lureau > > --- > > hw/char/serial.c | 58 +

[Bug 1853083] Re: qemu ppc64 4.0 boot AIX5.1 hung

2019-11-20 Thread wzis
With qemu-system-ppc64 -cpu power5+ -machine pseries -m 2048 -serial mon:stdio -hda aix-hdd.qcow2 -cdrom /Download/AIX5.1/VOLUME1.iso -prom-env boot-command='boot cdrom: -s verbose' got: VNC server running on ::1:5900 SLOF **

Re: [PATCH] spapr: Fix VSMT mode when it is not supported by the kernel

2019-11-20 Thread Laurent Vivier
On 20/11/2019 05:36, David Gibson wrote: > On Tue, Nov 19, 2019 at 04:45:26PM +0100, Greg Kurz wrote: >> On Tue, 19 Nov 2019 15:06:51 +0100 >> Laurent Vivier wrote: >> >>> On 19/11/2019 02:00, David Gibson wrote: On Fri, Nov 08, 2019 at 05:47:59PM +0100, Greg Kurz wrote: > On Fri, 8 Nov

Re: [PATCH] Add minimal Hexagon target - First in a series of patches - linux-user changes + linux-user/hexagon + skeleton of target/hexagon - Files in target/hexagon/imported are from another project

2019-11-20 Thread Richard Henderson
On 11/20/19 9:33 AM, Laurent Vivier wrote: > Le 20/11/2019 à 05:48, Taylor Simpson a écrit : >> For the general DEBUG_HEX messages, I think the trace infrastructure isn't >> quite what I'm looking for. >> >> Here's a sample of what it prints >> Start packet: pc = 0x4002f0 >> Packet committed: pc =

[PATCH] tests: acpi: always retain dumped ACPI tables in case of error

2019-11-20 Thread Igor Mammedov
If IASL wasn't able to parse expected file, test will just print warning "Warning! iasl couldn't parse the expected aml\n" and remove temporary table dumped from guest. Typically expected tables are always valid, with an exception when patchset introduces new tables. Make sure dumped tables are

Re: [PATCH v3 10/33] serial: add "instance-id" property

2019-11-20 Thread Marc-André Lureau
Hi On Wed, Oct 23, 2019 at 9:33 PM Marc-André Lureau wrote: > > This property will be used to move common vmstate registration to > device realize in following patch. > > Signed-off-by: Marc-André Lureau I realize adding a "instance-id" property instead of calling qdev_set_legacy_instance_id()

[PATCH for-5.0 1/4] hw/arm/nseries: Replace the bluetooth chardev with a "null" chardev

2019-11-20 Thread Thomas Huth
We are going to remove the bitrotten bluetooth backend, so we can not use it in the n800 and n810 machines anymore. Replace the chardev here with a "null" chardev and stop including the "hw/bt.h" header. I am not aware of a full working N8x0 environment that can be used to test these machines, but

[PATCH for-5.0 0/4] Remove the deprecated bluetooth subsystem

2019-11-20 Thread Thomas Huth
This patch series removes the bitrotten bluetooth subsystem. See the patch description of the third patch for the rationale. Thomas Huth (4): hw/arm/nseries: Replace the bluetooth chardev with a "null" chardev hw/usb: Remove the USB bluetooth dongle device Remove the core bluetooth code Re

[PATCH for-5.0 2/4] hw/usb: Remove the USB bluetooth dongle device

2019-11-20 Thread Thomas Huth
We are going to remove the bluetooth backend, so the USB bluetooth dongle can not work anymore. It's a completely optional device, no board depends on it, so let's simply remove it now. Signed-off-by: Thomas Huth --- hw/usb/Kconfig | 5 - hw/usb/Makefile.objs | 1 - hw/usb/dev-blue

[PATCH for-5.0 4/4] Remove libbluetooth / bluez from the CI tests

2019-11-20 Thread Thomas Huth
Since the bluetooth code has been removed, we don't need to test with this library anymore. Signed-off-by: Thomas Huth --- .gitlab-ci.yml | 2 +- tests/docker/dockerfiles/fedora.docker | 1 - tests/docker/dockerfiles/ubuntu.docker | 1 - tests/docker/dockerfil

Re: [PULL for-4.2-rc2 0/2] Tracing patches

2019-11-20 Thread Philippe Mathieu-Daudé
On 11/19/19 10:14 PM, Aleksandar Markovic wrote: On Tue, Nov 19, 2019 at 9:46 PM Stefan Hajnoczi wrote: The following changes since commit f086f22d6c068ba151b0f6e81e75a64f130df712: Merge remote-tracking branch 'remotes/awilliam/tags/vfio-fixes-20191118.0' into staging (2019-11-18 21:35:48

Re: [PULL for-4.2-rc2 0/2] Tracing patches

2019-11-20 Thread Philippe Mathieu-Daudé
On 11/19/19 10:35 PM, Aleksandar Markovic wrote: On Tue, Nov 19, 2019 at 10:14 PM Aleksandar Markovic wrote: On Tue, Nov 19, 2019 at 9:46 PM Stefan Hajnoczi wrote: The following changes since commit f086f22d6c068ba151b0f6e81e75a64f130df712: Merge remote-tracking branch 'remotes/awilliam

[Bug 1853083] Re: qemu ppc64 4.0 boot AIX5.1 hung

2019-11-20 Thread Greg Kurz
Answering comment #4: > What I don't understand is ppc64 for IBM machine emulation, but qemu ppc64 > can't support AIX most of the time, but can support Linux on power very well. QEMU doesn't implement the full PAPR specification. Historically we've only added the bits that are essential for a Lin

Re: [PATCH v3 1/3] mem: move nvdimm_device_list to utilities

2019-11-20 Thread Igor Mammedov
On Wed, 20 Nov 2019 13:31:34 +0530 Shivaprasad G Bhat wrote: > Hi Igor, > > > On 11/19/2019 12:43 PM, Igor Mammedov wrote: > > On Mon, 14 Oct 2019 13:37:37 -0500 > > Shivaprasad G Bhat wrote: > > > >> nvdimm_device_list is required for parsing the list for devices > >> in subsequent patches.

Re: [PATCH for-5.0 v5 08/23] ppc/xive: Introduce a XivePresenter interface

2019-11-20 Thread Greg Kurz
On Fri, 15 Nov 2019 17:24:21 +0100 Cédric Le Goater wrote: > When the XIVE IVRE sub-engine (XiveRouter) looks for a Notification > Virtual Target (NVT) to notify, it broadcasts a message on the > PowerBUS to find an XIVE IVPE sub-engine (Presenter) with the NVT > dispatched on one of its HW threa

Re: [libvirt] [PATCH for-5.0 2/4] hw/usb: Remove the USB bluetooth dongle device

2019-11-20 Thread Ján Tomko
On Wed, Nov 20, 2019 at 10:10:12AM +0100, Thomas Huth wrote: We are going to remove the bluetooth backend, so the USB bluetooth dongle can not work anymore. It's a completely optional device, no board depends on it, so let's simply remove it now. Signed-off-by: Thomas Huth --- hw/usb/Kconfig

Re: [PATCH] vhost-user-input: use free(elem) instead of g_free(elem)

2019-11-20 Thread Philippe Mathieu-Daudé
On 11/19/19 12:16 PM, Stefan Hajnoczi wrote: The virtqueue element returned by vu_queue_pop() is allocated using malloc(3) by virtqueue_alloc_element(). Use the matching free(3) function instead of glib's g_free(). Signed-off-by: Stefan Hajnoczi Fixes: 06914c97d3a ? Reviewed-by: Philippe Mat

Re: [libvirt] [PATCH for-5.0 3/4] Remove the core bluetooth code

2019-11-20 Thread Ján Tomko
On Wed, Nov 20, 2019 at 10:10:13AM +0100, Thomas Huth wrote: It's been deprecated since QEMU v3.1. We've explicitly asked in the deprecation message that people should speak up on qemu-devel in case they are still actively using the bluetooth part of QEMU, but nobody ever replied that they are re

Re: [PATCH v2 13/20] nvme: refactor prp mapping

2019-11-20 Thread Klaus Birkelund
On Tue, Nov 12, 2019 at 03:23:43PM +, Beata Michalska wrote: > Hi Klaus, > > On Tue, 15 Oct 2019 at 11:57, Klaus Jensen wrote: > > > > Instead of handling both QSGs and IOVs in multiple places, simply use > > QSGs everywhere by assuming that the request does not involve the > > controller mem

Re: [RFC v5 000/126] error: auto propagated local_err

2019-11-20 Thread Vladimir Sementsov-Ogievskiy
Okay... I think that: 1. A lot of efforts (not only my, I think reviewing is already exceeded generation efforts) are made, it would be sad to lose them. 2. It's safe enough to apply only part of generated patches: we just fix error_abort/error_fatal in more popular subsystems, what's wr

Re: [virtio-dev] Re: guest / host buffer sharing ...

2019-11-20 Thread Gerd Hoffmann
Hi, > > > DSP FW has no access to userspace so we would need some additional > > > API > > > on top of DMA_BUF_SET_NAME etc to get physical hardware pages ? > > > > The dma-buf api currently can share guest memory sg-lists. > > Ok, IIUC buffers can either be shared using the GPU proposed APIs

Re: [PATCH for-5.0 0/4] Remove the deprecated bluetooth subsystem

2019-11-20 Thread Paolo Bonzini
On 20/11/19 10:10, Thomas Huth wrote: > This patch series removes the bitrotten bluetooth subsystem. See > the patch description of the third patch for the rationale. Acked-by: Paolo Bonzini

[PULL 0/3] virtio, acpi: fixes

2019-11-20 Thread Michael S. Tsirkin
The following changes since commit 39e2821077e6dcf788b7c2a9ef50970ec7995437: Update version for v4.2.0-rc2 release (2019-11-19 19:34:10 +) are available in the Git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream for you to fetch changes up to 6c77aa90

[PULL 3/3] tests: acpi: always retain dumped ACPI tables in case of error

2019-11-20 Thread Michael S. Tsirkin
From: Igor Mammedov If IASL wasn't able to parse expected file, test will just print warning "Warning! iasl couldn't parse the expected aml\n" and remove temporary table dumped from guest. Typically expected tables are always valid, with an exception when patchset introduces new tables. Make s

[PULL 1/3] libvhost-user: Zero memory allocated for VuVirtqInflightDesc

2019-11-20 Thread Michael S. Tsirkin
From: Xie Yongji Use a zero-initialized VuVirtqInflightDesc struct to avoid that scan-build reports that vq->resubmit_list[0].counter may be garbage value in vu_check_queue_inflights(). Fixes: 5f9ff1eff ("libvhost-user: Support tracking inflight I/O in shared memory") Reported-by: Marc-André Lur

[PULL 2/3] vhost-user-input: use free(elem) instead of g_free(elem)

2019-11-20 Thread Michael S. Tsirkin
From: Stefan Hajnoczi The virtqueue element returned by vu_queue_pop() is allocated using malloc(3) by virtqueue_alloc_element(). Use the matching free(3) function instead of glib's g_free(). Signed-off-by: Stefan Hajnoczi Message-Id: <20191119111626.112206-1-stefa...@redhat.com> Reviewed-by:

Re: [PATCH v16 11/14] hmat acpi: Build System Locality Latency and Bandwidth Information Structure(s)

2019-11-20 Thread Igor Mammedov
On Fri, 15 Nov 2019 15:53:49 +0800 Tao Xu wrote: > From: Liu Jingqi > > This structure describes the memory access latency and bandwidth > information from various memory access initiator proximity domains. > The latency and bandwidth numbers represented in this structure > correspond to rated

Re: [RFC PATCH v1 1/8] vfio-ccw: Return IOINST_CC_NOT_OPERATIONAL for EIO

2019-11-20 Thread Cornelia Huck
On Tue, 19 Nov 2019 18:59:11 +0100 Halil Pasic wrote: > On Tue, 19 Nov 2019 13:02:20 +0100 > Cornelia Huck wrote: > > > On Tue, 19 Nov 2019 12:23:40 +0100 > > Halil Pasic wrote: > > > > > On Mon, 18 Nov 2019 19:13:34 +0100 > > > Cornelia Huck wrote: > > > > > > > > EIO is returned by vf

Re: guest / host buffer sharing ...

2019-11-20 Thread Tomasz Figa
Hi Stefan, On Mon, Nov 18, 2019 at 7:21 PM Stefan Hajnoczi wrote: > > On Sat, Nov 9, 2019 at 3:12 PM Tomasz Figa wrote: > > > > On Sat, Nov 9, 2019 at 9:08 PM Stefan Hajnoczi wrote: > > > > > > On Sat, Nov 9, 2019 at 12:17 PM Tomasz Figa wrote: > > > > On Sat, Nov 9, 2019 at 7:12 PM Stefan Haj

Re: [PATCH for-5.0 v5 09/23] ppc/xive: Implement the XivePresenter interface

2019-11-20 Thread Greg Kurz
On Fri, 15 Nov 2019 17:24:22 +0100 Cédric Le Goater wrote: > Each XIVE Router model, sPAPR and PowerNV, now implements the 'match_nvt' > handler of the XivePresenter QOM interface. This is simply moving code > and taking into account the new API. > > To be noted that the xive_router_get_tctx() h

Re: [PATCH 0/4] fix & merge block_status_above and is_allocated_above

2019-11-20 Thread Vladimir Sementsov-Ogievskiy
16.11.2019 19:34, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > I wanted to understand, what is the real difference between > bdrv_block_status_above > and bdrv_is_allocated_above, IMHO bdrv_is_allocated_above should work through > bdrv_block_status_above.. > > And I found the problem: bdrv_

Re: [PATCH v1 0/2] s390x/cpumodel: Introduce "best" model variants

2019-11-20 Thread David Hildenbrand
On 19.11.19 20:42, Eduardo Habkost wrote: On Tue, Nov 19, 2019 at 12:00:14PM +0100, David Hildenbrand wrote: On 19.11.19 11:36, Peter Maydell wrote: On Tue, 19 Nov 2019 at 09:59, David Hildenbrand wrote: On 19.11.19 10:22, Peter Maydell wrote: I don't hugely care about query-cpu-model-expan

Re: [RFC PATCH v1 4/8] vfio-ccw: Refactor cleanup of regions

2019-11-20 Thread Cornelia Huck
On Fri, 15 Nov 2019 04:34:33 +0100 Eric Farman wrote: > While we're at it, add a g_free() for the async_cmd_region that > is the last thing currently created. g_free() knows how to handle > NULL pointers, so this makes it easier to remember what cleanups > need to be performed when new regions a

Re: [PATCH] exynos4210_gic: Suppress gcc9 format-truncation warnings

2019-11-20 Thread Peter Maydell
On Wed, 20 Nov 2019 at 05:27, David Gibson wrote: > > On Mon, Oct 14, 2019 at 01:51:39PM +0100, Peter Maydell wrote: > > If we assert() that num_cpu is always <= EXYNOS4210_NCPUS > > is that sufficient to clue gcc in that the buffer can't overflow? > > Interestingly, assert(s->num_cpu <= EXYNOS$21

Re: [PATCH v3 13/33] serial: start making SerialMM a sysbus device

2019-11-20 Thread Peter Maydell
On Wed, 20 Nov 2019 at 07:34, Marc-André Lureau wrote: > > > +static void serial_mm_instance_init(Object *o) > > > +{ > > > +SerialMM *self = SERIAL_MM(o); > > > > 'self' is not idiomatic for the name of the variable containing > > the pointer to the object in QOM code ("git grep '\Wself\W' h

Re: [PATCH 1/4] net/virtio: fix dev_unplug_pending

2019-11-20 Thread Michael S. Tsirkin
On Thu, Nov 14, 2019 at 03:16:10PM +0100, Jens Freimann wrote: > .dev_unplug_pending is set up by virtio-net code indepent of whether > failover=on was set for the device or not. This gives a wrong result when > we check for existing primary devices in migration code. > > Fix this by actually call

Re: [PATCH 2/4] net/virtio: return early when failover primary alread added

2019-11-20 Thread Michael S. Tsirkin
On Thu, Nov 14, 2019 at 03:16:11PM +0100, Jens Freimann wrote: > Bail out when primary device was already added before. > This avoids printing a wrong warning message during reboot. > > Fixes: 9711cd0dfc3f ("net/virtio: add failover support") > Signed-off-by: Jens Freimann Reviewed-by: Michael S

Re: [PULL for-4.2-rc2 0/2] Tracing patches

2019-11-20 Thread Stefan Hajnoczi
On Wed, Nov 20, 2019 at 10:33:35AM +0100, Philippe Mathieu-Daudé wrote: > On 11/19/19 10:35 PM, Aleksandar Markovic wrote: > > On Tue, Nov 19, 2019 at 10:14 PM Aleksandar Markovic > > wrote: > > > > > > On Tue, Nov 19, 2019 at 9:46 PM Stefan Hajnoczi > > > wrote: > > > > > > > > The following

Re: [PATCH v3 13/33] serial: start making SerialMM a sysbus device

2019-11-20 Thread Marc-André Lureau
Hi On Wed, Nov 20, 2019 at 2:36 PM Peter Maydell wrote: > > On Wed, 20 Nov 2019 at 07:34, Marc-André Lureau > wrote: > > > > > +static void serial_mm_instance_init(Object *o) > > > > +{ > > > > +SerialMM *self = SERIAL_MM(o); > > > > > > 'self' is not idiomatic for the name of the variable c

Re: [PATCH v3 14/33] serial-mm: add "regshift" property

2019-11-20 Thread Peter Maydell
On Wed, 20 Nov 2019 at 07:54, Marc-André Lureau wrote: > > Hi > > On Mon, Nov 18, 2019 at 6:54 PM Peter Maydell > wrote: > > > > On Wed, 23 Oct 2019 at 18:34, Marc-André Lureau > > wrote: > > > +static Property serial_mm_properties[] = { > > > +DEFINE_PROP_UINT8("regshift", SerialMM, regshi

Re: [PATCH] Hexagon: Swap SIGRGMAX-1 and SIGRTMIN+1

2019-11-20 Thread Peter Maydell
On Wed, 20 Nov 2019 at 08:10, Laurent Vivier wrote: > For the moment we don't have a better solution, Josh Kunz tried to > rework [1] patches from Miloš Stojanović [2] but it doesn't seem to be > an easy task. > > So I agree we need a generic solution to fix this problem, but in the > meantime I t

Re: [PATCH 3/4] net/virtio: avoid passing NULL to qdev_set_parent_bus

2019-11-20 Thread Michael S. Tsirkin
On Thu, Nov 14, 2019 at 03:16:12PM +0100, Jens Freimann wrote: > Make sure no arguments for qdev_set_parent_bus are NULL. > This fixes CID 1407224. > > Fixes: 9711cd0dfc3f ("net/virtio: add failover support") > Signed-off-by: Jens Freimann > --- > hw/net/virtio-net.c | 14 ++ > 1 fil

Re: [PATCH for-5.0 v5 09/23] ppc/xive: Implement the XivePresenter interface

2019-11-20 Thread Cédric Le Goater
On 20/11/2019 11:18, Greg Kurz wrote: > On Fri, 15 Nov 2019 17:24:22 +0100 > Cédric Le Goater wrote: > >> Each XIVE Router model, sPAPR and PowerNV, now implements the 'match_nvt' >> handler of the XivePresenter QOM interface. This is simply moving code >> and taking into account the new API. >>

Re: [PATCH v3 16/33] serial-mm: use sysbus facilities

2019-11-20 Thread Peter Maydell
On Wed, 20 Nov 2019 at 08:30, Marc-André Lureau wrote: > > Hi > > On Mon, Nov 18, 2019 at 7:09 PM Peter Maydell > wrote: > > Otherwise > > Reviewed-by: Peter Maydell > > Does your r-b stands if I keep "self"? Or do you feel strongly about it? Yes, I do strongly think you need to change that (s

Re: [PATCH 4/4] net/virtio: return error when device_opts arg is NULL

2019-11-20 Thread Michael S. Tsirkin
On Thu, Nov 14, 2019 at 03:16:13PM +0100, Jens Freimann wrote: > device_opts could be NULL. Make sure we don't pass it to > qemu_opts_to_dict. When we made sure it can't be NULL we can also remove > it from the if condition. > This fixes CID 1407222. > > Fixes: 9711cd0dfc3f ("net/virtio: add failo

Re: [PATCH for-5.0 1/4] hw/arm/nseries: Replace the bluetooth chardev with a "null" chardev

2019-11-20 Thread Peter Maydell
On Wed, 20 Nov 2019 at 09:10, Thomas Huth wrote: > > We are going to remove the bitrotten bluetooth backend, so we can > not use it in the n800 and n810 machines anymore. Replace the chardev > here with a "null" chardev and stop including the "hw/bt.h" header. > > I am not aware of a full working

Re: [PATCH] Hexagon: Swap SIGRGMAX-1 and SIGRTMIN+1

2019-11-20 Thread Laurent Vivier
Le 20/11/2019 à 11:45, Peter Maydell a écrit : > On Wed, 20 Nov 2019 at 08:10, Laurent Vivier wrote: >> For the moment we don't have a better solution, Josh Kunz tried to >> rework [1] patches from Miloš Stojanović [2] but it doesn't seem to be >> an easy task. >> >> So I agree we need a generic s

[PULL 4/5] .travis.yml: drop 32 bit systems from MAIN_SOFTMMU_TARGETS

2019-11-20 Thread Alex Bennée
The older clangs are still struggling to build and run everything withing the 50 minute timeout so lets lighten the load a bit more. We still have coverage for GCC and hopefully no obscure 32 bit guest only breakages slip through the cracks. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth d

[PULL for rc3 0/5] a few doc and testing tweaks

2019-11-20 Thread Alex Bennée
The following changes since commit 39e2821077e6dcf788b7c2a9ef50970ec7995437: Update version for v4.2.0-rc2 release (2019-11-19 19:34:10 +) are available in the Git repository at: https://github.com/stsquad/qemu.git tags/pull-rc3-testing-and-tcg-201119-1 for you to fetch changes up to 22

[PULL 1/5] tests/vm: make --interactive (and therefore DEBUG=1) unconditional

2019-11-20 Thread Alex Bennée
While the concept of only dropping to ssh if a test fails is nice it is more useful for this to be unconditional. You usually just want to get the build up and running and then noodle around debugging or attempting to replicate. Cc: Peter Maydell Signed-off-by: Alex Bennée Reviewed-by: Thomas Hu

[PULL 5/5] tests/tcg: modify multiarch tests to work with clang

2019-11-20 Thread Alex Bennée
From: Taylor Simpson Signed-off-by: Taylor Simpson Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Message-Id: <1574032465-12186-1-git-send-email-tsimp...@quicinc.com> [AJB: tweak header line] Signed-off-by: Alex Bennée diff --git a/tests/tcg/multiarch/float_helpers.c b/tests/tcg/mu

[PULL 2/5] docs/devel: rename plugins.rst to tcg-plugins.rst

2019-11-20 Thread Alex Bennée
This makes it a bit clearer what this is about. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé diff --git a/docs/devel/index.rst b/docs/devel/index.rst index 2ff058bae38..c86a3cdff2f 100644 --- a/docs/devel/index.rst +++ b/docs/devel/index.rst @@ -22,4 +22,4 @@ Contents: dec

[PULL 3/5] docs/devel: update tcg-plugins.rst with API versioning details

2019-11-20 Thread Alex Bennée
While we are at it fix up the quoted code sections with the inline :: approach. Signed-off-by: Alex Bennée Reviewed-by: Robert Foley diff --git a/docs/devel/tcg-plugins.rst b/docs/devel/tcg-plugins.rst index b18fb6729e3..718eef00f22 100644 --- a/docs/devel/tcg-plugins.rst +++ b/docs/devel/tcg-p

Re: [PATCH v3 13/33] serial: start making SerialMM a sysbus device

2019-11-20 Thread Peter Maydell
On Wed, 20 Nov 2019 at 10:40, Marc-André Lureau wrote: > On Wed, Nov 20, 2019 at 2:36 PM Peter Maydell > wrote: > > There are two problems here: > > (1) "self" gives no hint at all about whether it's the Object*, > > the DeviceState*, or the SerialMM*. All of those are the > > object the method

Re: [PATCH] Hexagon: Swap SIGRGMAX-1 and SIGRTMIN+1

2019-11-20 Thread Peter Maydell
On Wed, 20 Nov 2019 at 10:54, Laurent Vivier wrote: > I understand your point, and I agree, but not allowing this will block > the merge of the hexagon target, and I don't see any fix for the > underlying problem coming soon. > > Other targets work without this change, and adding this change break

Re: [PATCH v3 13/33] serial: start making SerialMM a sysbus device

2019-11-20 Thread Marc-André Lureau
Hi On Wed, Nov 20, 2019 at 2:58 PM Peter Maydell wrote: > > On Wed, 20 Nov 2019 at 10:40, Marc-André Lureau > wrote: > > On Wed, Nov 20, 2019 at 2:36 PM Peter Maydell > > wrote: > > > There are two problems here: > > > (1) "self" gives no hint at all about whether it's the Object*, > > > the

Re: [PATCH] Fix incorrect int->float conversions caught by clang -Wimplicit-int-float-conversion

2019-11-20 Thread Juan Quintela
Markus Armbruster wrote: > Fangrui Song writes: > >> The warning will be enabled by default in clang 10. It is not >> available for clang <= 9. >> >> qemu/migration/migration.c:2038:24: error: implicit conversion from >> 'long' to 'double' changes value from 9223372036854775807 to >> 922337203685

Re: [RFC PATCH v1 5/8] vfio-ccw: Add support for the schib region

2019-11-20 Thread Cornelia Huck
On Fri, 15 Nov 2019 04:34:34 +0100 Eric Farman wrote: > From: Farhan Ali > > The schib region can be used to obtain the latest SCHIB from the host > passthrough subchannel. Since the guest SCHIB is virtualized, > we currently only update the path related information so that the > guest is aware

Re: [PATCH v3 18/33] mips: inline serial_init

2019-11-20 Thread Marc-André Lureau
Hi On Mon, Nov 18, 2019 at 7:25 PM Peter Maydell wrote: > > On Wed, 23 Oct 2019 at 18:34, Marc-André Lureau > wrote: > > > > The function is specific to mipssim, let's inline it. > > > > Signed-off-by: Marc-André Lureau > > --- > > hw/char/serial.c | 16 > > hw/mips/mi

Re: [PATCH] spapr: Fix VSMT mode when it is not supported by the kernel

2019-11-20 Thread Laurent Vivier
On 20/11/2019 10:00, Laurent Vivier wrote: > On 20/11/2019 05:36, David Gibson wrote: >> On Tue, Nov 19, 2019 at 04:45:26PM +0100, Greg Kurz wrote: >>> On Tue, 19 Nov 2019 15:06:51 +0100 >>> Laurent Vivier wrote: >>> On 19/11/2019 02:00, David Gibson wrote: > On Fri, Nov 08, 2019 at 05:47

Re: [PATCH] misc/pca9552: Add qom set and get

2019-11-20 Thread Dr. David Alan Gilbert
* Cédric Le Goater (c...@kaod.org) wrote: > On 18/11/2019 07:17, Joel Stanley wrote: > > Following the pattern of the work recently done with the ASPEED GPIO > > model, this adds support for inspecting and modifying the PCA9552 LEDs > > from the monitor. > > > > (qemu) qom-set /machine/unattache

Re: [RFC v5 000/126] error: auto propagated local_err

2019-11-20 Thread Greg Kurz
On Wed, 20 Nov 2019 09:50:54 + Vladimir Sementsov-Ogievskiy wrote: > Okay... > > I think that: > > 1. A lot of efforts (not only my, I think reviewing is already exceeded > generation efforts) >are made, it would be sad to lose them. > > 2. It's safe enough to apply only part of gener

Re: [PATCH] vhost-user-input: use free(elem) instead of g_free(elem)

2019-11-20 Thread Stefan Hajnoczi
On Wed, Nov 20, 2019 at 10:37:35AM +0100, Philippe Mathieu-Daudé wrote: > On 11/19/19 12:16 PM, Stefan Hajnoczi wrote: > > The virtqueue element returned by vu_queue_pop() is allocated using > > malloc(3) by virtqueue_alloc_element(). Use the matching free(3) > > function instead of glib's g_free(

Re: [PATCH] spapr: Fix VSMT mode when it is not supported by the kernel

2019-11-20 Thread David Gibson
On Wed, Nov 20, 2019 at 12:28:19PM +0100, Laurent Vivier wrote: > On 20/11/2019 10:00, Laurent Vivier wrote: > > On 20/11/2019 05:36, David Gibson wrote: > >> On Tue, Nov 19, 2019 at 04:45:26PM +0100, Greg Kurz wrote: > >>> On Tue, 19 Nov 2019 15:06:51 +0100 > >>> Laurent Vivier wrote: > >>> > >>>

[PATCH 05/15] s390x: protvirt: Sync PV state

2019-11-20 Thread Janosch Frank
We do not always have the SIE intercept code handy at each place where we do emulation. Unfortunately emulation for secure guests often differ slightly from normal emulation and we need to make decisions based on the protected state of the VCPU. Let's sync the protected state and make it available

[PATCH 09/15] s390x: protvirt: SCLP interpretation

2019-11-20 Thread Janosch Frank
SCLP for a protected guest is done over the SIDAD, so we need to use the s390_cpu_virt_mem_* functions to access the SIDAD instead of guest memory when reading/writing SCBs. To not confuse the sclp emulation, we set 0x42000 as the address, but ignore it for reading/writing the SCCB. Signed-off-by

[PATCH 00/15] s390x: Protected Virtualization support

2019-11-20 Thread Janosch Frank
Most of the QEMU changes for PV are related to the new IPL type with subcodes 8 - 10 and the execution of the necessary Ultravisor calls to IPL secure guests. Note that we can only boot into secure mode from normal mode, i.e. stfle 161 is not active in secure mode. The other changes related to dat

[PATCH 02/15] s390x: Beautify diag308 handling

2019-11-20 Thread Janosch Frank
Let's improve readability by: * Using constants for the subcodes * Moving parameter checking into a function * Removing subcode > 6 check as the default case catches that Signed-off-by: Janosch Frank --- target/s390x/diag.c | 54 +++-- 1 file changed, 32 i

[PATCH 12/15] s390x: protvirt: Set guest IPL PSW

2019-11-20 Thread Janosch Frank
Handling of CPU reset and setting of the IPL psw from guest storage at offset 0 is done by a Ultravisor call. Let's only fetch it if necessary. Signed-off-by: Janosch Frank --- hw/s390x/pv.c | 5 + hw/s390x/pv.h | 1 + hw/s390x/s390-virtio-ccw.c | 3 ++- linux-heade

[PATCH 15/15] s390x: protvirt: Handle SIGP store status correctly

2019-11-20 Thread Janosch Frank
Status storing is obviously not done by qemu anymore. Signed-off-by: Janosch Frank --- target/s390x/sigp.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/target/s390x/sigp.c b/target/s390x/sigp.c index 2ce22d4dc1..68634d694a 100644 --- a/target/s390x/sigp.c +++ b/targ

[PATCH 04/15] Header sync protvirt

2019-11-20 Thread Janosch Frank
Let's sync all the protvirt header changes Signed-off-by: Janosch Frank --- linux-headers/asm-s390/kvm.h | 3 ++- linux-headers/linux/kvm.h| 42 2 files changed, 44 insertions(+), 1 deletion(-) diff --git a/linux-headers/asm-s390/kvm.h b/linux-headers/a

[PATCH 07/15] s390x: protvirt: Handle diag 308 subcodes 0,1,3,4

2019-11-20 Thread Janosch Frank
Now that we know the protection state off the cpus, we can start handling all diag 308 subcodes in the protected state. For subcodes 0 and 1 we need to unshare all pages before continuing, so the guest doesn't accidently expose data when dumping. For subcode 3/4 we tear down the protected VM and

[PATCH 11/15] RFC: s390x: Exit on vcpu reset error

2019-11-20 Thread Janosch Frank
If a vcpu is not properly reset it might be better to just end the VM. Signed-off-by: Janosch Frank --- target/s390x/kvm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c index 190400df55..0210b54157 100644 --- a/target/s390x/kvm.c +++ b/target/s390x

[PATCH 01/15] s390x: Cleanup cpu resets

2019-11-20 Thread Janosch Frank
Let's move the resets into one function and switch by type, so we can use fallthroughs for shared reset actions. Signed-off-by: Janosch Frank --- hw/s390x/s390-virtio-ccw.c | 3 + target/s390x/cpu.c | 111 - 2 files changed, 52 insertions(+), 62 dele

[PATCH 08/15] s390x: protvirt: KVM intercept changes

2019-11-20 Thread Janosch Frank
Secure guests no longer intercept with code 4 for an instruction interception. Instead they have codes 104 and 108 for secure instruction interception and secure instruction notification respectively. The 104 mirrors the 4, but the 108 is a notification, that something happened and the hypervisor

[PATCH 03/15] s390x: protvirt: Add diag308 subcodes 8 - 10

2019-11-20 Thread Janosch Frank
For diag308 subcodes 8 - 10 we have a new ipib of type 5. The ipib holds the address and length of the secure execution header, as well as a list of guest components. Each component is a block of memory, for example kernel or initrd, which needs to be decrypted by the Ultravisor in order to run a

[PATCH 06/15] s390x: protvirt: Support unpack facility

2019-11-20 Thread Janosch Frank
When a guest has saved a ipib of type 5 and call diagnose308 with subcode 10, we have to setup the protected processing environment via Ultravisor calls. The calls are done by KVM and are exposed via an API. The following steps are necessary: 1. Create a VM (register it with the Ultravisor) 2. Cre

Re: guest / host buffer sharing ...

2019-11-20 Thread Tomasz Figa
Hi Frank, On Fri, Nov 8, 2019 at 12:10 AM Frank Yang wrote: > > So I'm not really sure why people are having issues sharing buffers that live > on the GPU. Doesn't that show up as some integer ID on the host, and some > $GuestFramework (dmabuf, gralloc) ID on the guest, and it all works out due

[PATCH 14/15] s390x: protvirt: Disable address checks for PV guest IO emulation

2019-11-20 Thread Janosch Frank
IO instruction data is routed through SIDAD for protected guests, so adresses do not need to be checked, as this is kernel memory. Signed-off-by: Janosch Frank --- target/s390x/ioinst.c | 46 +++ 1 file changed, 29 insertions(+), 17 deletions(-) diff --gi

Re: [PATCH] vhost-user-input: use free(elem) instead of g_free(elem)

2019-11-20 Thread Daniel P . Berrangé
On Tue, Nov 19, 2019 at 11:16:26AM +, Stefan Hajnoczi wrote: > The virtqueue element returned by vu_queue_pop() is allocated using > malloc(3) by virtqueue_alloc_element(). Use the matching free(3) > function instead of glib's g_free(). Just as an FYI, since glib 2.46 g_malloc is hardcoded t

[PATCH 10/15] s390x: protvirt: Add new VCPU reset functions

2019-11-20 Thread Janosch Frank
CPU resets for protected guests need to be done via Ultravisor calls. Hence we need a way to issue these calls for each reset. As we formerly had only one reset function and it was called for initial, as well as for the clear reset, we now need a new interface. Signed-off-by: Janosch Frank ---

Re: [PATCH 3/4] net/virtio: avoid passing NULL to qdev_set_parent_bus

2019-11-20 Thread Jens Freimann
On Wed, Nov 20, 2019 at 05:46:36AM -0500, Michael S. Tsirkin wrote: On Thu, Nov 14, 2019 at 03:16:12PM +0100, Jens Freimann wrote: Make sure no arguments for qdev_set_parent_bus are NULL. This fixes CID 1407224. Fixes: 9711cd0dfc3f ("net/virtio: add failover support") Signed-off-by: Jens Freima

Re: [PATCH 0/4] fix & merge block_status_above and is_allocated_above

2019-11-20 Thread Vladimir Sementsov-Ogievskiy
20.11.2019 14:44, Kevin Wolf wrote: > Am 20.11.2019 um 11:20 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 16.11.2019 19:34, Vladimir Sementsov-Ogievskiy wrote: >>> Hi all! >>> >>> I wanted to understand, what is the real difference between >>> bdrv_block_status_above >>> and bdrv_is_allocated_

[PATCH 13/15] s390x: protvirt: Move diag 308 data over SIDAD

2019-11-20 Thread Janosch Frank
For protected guests the IPIB is written/read to/from the sattelite block, so we need to make those accesses virtual to make them go through KBM mem ops. Signed-off-by: Janosch Frank --- target/s390x/diag.c | 26 +++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff -

Re: [PATCH 0/4] fix & merge block_status_above and is_allocated_above

2019-11-20 Thread Kevin Wolf
Am 20.11.2019 um 11:20 hat Vladimir Sementsov-Ogievskiy geschrieben: > 16.11.2019 19:34, Vladimir Sementsov-Ogievskiy wrote: > > Hi all! > > > > I wanted to understand, what is the real difference between > > bdrv_block_status_above > > and bdrv_is_allocated_above, IMHO bdrv_is_allocated_above sh

Re: [PATCH] vhost-user-input: use free(elem) instead of g_free(elem)

2019-11-20 Thread Michael S. Tsirkin
On Wed, Nov 20, 2019 at 11:41:32AM +, Stefan Hajnoczi wrote: > On Wed, Nov 20, 2019 at 10:37:35AM +0100, Philippe Mathieu-Daudé wrote: > > On 11/19/19 12:16 PM, Stefan Hajnoczi wrote: > > > The virtqueue element returned by vu_queue_pop() is allocated using > > > malloc(3) by virtqueue_alloc_el

Re: [PATCH 3/4] net/virtio: avoid passing NULL to qdev_set_parent_bus

2019-11-20 Thread Michael S. Tsirkin
On Wed, Nov 20, 2019 at 01:03:57PM +0100, Jens Freimann wrote: > On Wed, Nov 20, 2019 at 05:46:36AM -0500, Michael S. Tsirkin wrote: > > On Thu, Nov 14, 2019 at 03:16:12PM +0100, Jens Freimann wrote: > > > Make sure no arguments for qdev_set_parent_bus are NULL. > > > This fixes CID 1407224. > > >

  1   2   3   4   >