Re: [RFC][PATCH 2/3] docs/specs: Add specification of ivshmem device revision 2

On Mon, Nov 11, 2019 at 05:38:29PM +0100, Jan Kiszka wrote: > On 11.11.19 17:11, Michael S. Tsirkin wrote: > > On Mon, Nov 11, 2019 at 03:27:43PM +, Daniel P. Berrangé wrote: > > > On Mon, Nov 11, 2019 at 10:08:20AM -0500, Michael S. Tsirkin wrote: > > > > On Mon, Nov 11, 2019 at 02:59:07PM +01

Re: [PATCH] enable translating statx syscalls on more arches

On Tuesday, November 12, 2019, Andrew Kelley wrote: > ping > > On 10/16/19 5:01 PM, Andrew Kelley wrote: > > Signed-off-by: Andrew Kelley > > --- > > linux-user/aarch64/syscall_nr.h | 13 ++ > > linux-user/arm/syscall_nr.h | 38 > > linux-user/i386/sysca

Re: [PATCH] enable translating statx syscalls on more arches

On Tuesday, November 12, 2019, Aleksandar Markovic < aleksandar.m.m...@gmail.com> wrote: > > > On Tuesday, November 12, 2019, Andrew Kelley wrote: > >> ping >> >> On 10/16/19 5:01 PM, Andrew Kelley wrote: >> > Signed-off-by: Andrew Kelley >> > --- >> > linux-user/aarch64/syscall_nr.h | 13 +

Re: [RFC PATCH 15/18] qapi: Support empty modules

Kevin Wolf writes: > If you added an include file that doesn't contain any definitions, no > source files would be generated for it. However, in other source files, > you would still get an #include for the header files of the empty > module. Bug. Cause: we generate #include module.h always, an

Re: [PATCH qemu] scripts: Detect git worktrees for get_maintainer.pl --git

On Tue, Nov 12, 2019 at 02:45:32PM +1100, Alexey Kardashevskiy wrote: > Recent git versions support worktrees where .git is not a directory but > a file with a path to the .git repository; however the get_maintainer.pl > script only recognises the .git directory, let's fix it. > > Signed-off-by: A

Re: [PATCH qemu] scripts: Detect git worktrees for get_maintainer.pl --git

On Tue, 12 Nov 2019 14:45:32 +1100 Alexey Kardashevskiy wrote: > Recent git versions support worktrees where .git is not a directory but > a file with a path to the .git repository; however the get_maintainer.pl > script only recognises the .git directory, let's fix it. > > Signed-off-by: Alexey

Re: [PATCH v6 1/3] block: introduce compress filter driver

11.11.2019 23:47, Eric Blake wrote: > On 11/11/19 10:04 AM, Andrey Shinkevich wrote: >> Allow writing all the data compressed through the filter driver. >> The written data will be aligned by the cluster size. >> Based on the QEMU current implementation, that data can be written to >> unallocated c

Re: virtio,iommu_platform=on

On 11/12/19 04:53, Alexey Kardashevskiy wrote: > Hi! > > I am enabling IOMMU for virtio in the pseries firmware (SLOF) and seeing > problems, one of them is SLOF does SCSI bus scan, then it stops the > virtio-scsi by clearing MMIO|IO|BUSMASTER from PCI_COMMAND (as SLOF > stopped using the devices)

Re: API definition for LUKS key management

Am 11.11.2019 um 19:34 hat Daniel P. Berrangé geschrieben: > On Mon, Nov 11, 2019 at 05:58:20PM +0200, Maxim Levitsky wrote: > > One of the concerns that was raised during the review was that amend > > interface for luks that I propose is > > different from the amend inteface used currently for qc

Re: [PATCH qemu] scripts: Detect git worktrees for get_maintainer.pl --git

On 12/11/19 04:45, Alexey Kardashevskiy wrote: > Recent git versions support worktrees where .git is not a directory but > a file with a path to the .git repository; however the get_maintainer.pl > script only recognises the .git directory, let's fix it. > > Signed-off-by: Alexey Kardashevskiy >

Re: [PATCH] enable translating statx syscalls on more arches

Le 12/11/2019 à 09:27, Aleksandar Markovic a écrit : > > > On Tuesday, November 12, 2019, Aleksandar Markovic > mailto:aleksandar.m.m...@gmail.com>> wrote: > > > > On Tuesday, November 12, 2019, Andrew Kelley > wrote: > > ping > > On 10/16/

Re: [PATCH] Makefile: install bios-microvm like other binary blobs

Le 02/11/2019 à 12:43, Philippe Mathieu-Daudé a écrit : > From: Bruce Rogers > > Commit 0d5fae3e52e introduced bios-microvm.bin but forgot to add > it to the list of blobs being installed. > Add it to the list of BLOBS that get installed. > > Fixes: 0d5fae3e52e "roms: add microvm-bios (qboot) as

Re: [PATCH] qom: Fix error message in object_class_property_add()

Le 05/11/2019 à 15:05, Laurent Vivier a écrit : > Le 04/11/2019 à 14:23, Greg Kurz a écrit : >> The error message in object_class_property_add() was copied from >> object_property_add() in commit 16bf7f522a2ff. Clarify that it is >> about a class, not an object. >> >> While here, have the format st

Re: [PATCH] numa: Add missing \n to error message

Le 06/11/2019 à 13:46, Greg Kurz a écrit : > If memory allocation fails when using -mem-path, QEMU is supposed to print > out a message to indicate that fallback to anonymous RAM is deprecated. This > is done with error_printf() which does output buffering. As a consequence, > the message is only p

Re: [PATCH v2] ivshmem-server: Terminate also on SIGINT

Le 08/11/2019 à 16:15, Markus Armbruster a écrit : > Jan Kiszka writes: > >> On 03.08.19 15:22, Jan Kiszka wrote: >>> From: Jan Kiszka >>> >>> Allows to shutdown a foreground session via ctrl-c. >>> >>> Signed-off-by: Jan Kiszka >>> --- >>> >>> Changes in v2: >>> - adjust error message >>> >>

Re: [PATCH v2] ivshmem-server: Clean up shmem on shutdown

Le 08/11/2019 à 16:14, Markus Armbruster a écrit : > Jan Kiszka writes: > >> On 06.08.19 15:01, Claudio Fontana wrote: >>> On 8/5/19 7:54 AM, Jan Kiszka wrote: From: Jan Kiszka So far, the server leaves the posix shared memory object behind when terminating, requiring the use

Re: [PATCH v6 1/3] block: introduce compress filter driver

Am 11.11.2019 um 17:04 hat Andrey Shinkevich geschrieben: > Allow writing all the data compressed through the filter driver. > The written data will be aligned by the cluster size. > Based on the QEMU current implementation, that data can be written to > unallocated clusters only. May be used for a

Re: [RFC PATCH 16/18] qapi: Create 'pragma' module

Kevin Wolf writes: > We want to share the whitelists between the system emulator schema and > the storage daemon schema, so move all the pragmas from the main schema > file into a separate file that can be included from both. Confusing because the storage daemon schema doesn't exist at this poin

Re: [PATCH qemu-web] Add a blog post on "Micro-Optimizing KVM VM-Exits"

[Cc: Rich Jones, addressing his feedback on IRC, below.] On Fri, Nov 08, 2019 at 10:22:47AM +0100, Kashyap Chamarthy wrote: > This blog post summarizes the talk "Micro-Optimizing KVM VM-Exits"[1], > given by Andrea Arcangeli at the recently concluded KVM Forum 2019. > > [1] > https://kvmforum201

Re: [PATCH] i386: define the 'flush_l1d' CPUID feature bit (CVE-2018-3646)

On Tue, Nov 12, 2019 at 03:50:43AM +, Kyle Copperfield via wrote: > New microcode introduces the "Flush L1D Cache" CPUID feature bit. > This needs to be exposed to guest OS to allow them to protect against > CVE-2018-3646. My understanding was that this is only required in the L0 hypervisor, n

Re: [PATCH] qemu-coroutine-sleep: Silence Coverity warning

On Mon, 11 Nov 2019 at 20:35, Eric Blake wrote: > > Coverity warns that we store the address of a stack variable through a > pointer passed in by the caller, which would let the caller trivially > trigger use-after-free if that stored value is still present when we > finish execution. However, th

Re: [PATCH] virtio: fix IO request length in virtio SCSI/block #PSBM-78839

On Wed, Oct 23, 2019 at 05:28:17PM -0400, Michael S. Tsirkin wrote: > On Fri, Oct 18, 2019 at 02:55:47PM +0300, Denis Plotnikov wrote: > > From: "Denis V. Lunev" > > > > Linux guests submit IO requests no longer than PAGE_SIZE * max_seg > > field reported by SCSI controler. Thus typical sequentia

Re: API definition for LUKS key management

On Mon, Nov 11, 2019 at 05:58:20PM +0200, Maxim Levitsky wrote: > I will try to explain the interface with bunch of examples: I want to fill in equiv examples from cryptsetup for sake of comparison > # adds a new password, defined by qemu secret 'sec0' to first unused slot > # give user a error i

[PULL 3/5] numa: Add missing \n to error message

From: Greg Kurz If memory allocation fails when using -mem-path, QEMU is supposed to print out a message to indicate that fallback to anonymous RAM is deprecated. This is done with error_printf() which does output buffering. As a consequence, the message is only printed at the next flush, eg. whe

[PULL 0/5] Trivial branch patches

ll-request for you to fetch changes up to 5c62979ed5f75976ae215098566ebd93dfe4e22a: ivshmem-server: Terminate also on SIGINT (2019-11-12 10:37:20 +0100) Trivial fixes (20191112) ivshmem-server, error messages (numa, qom) and Make

[PULL 1/5] Makefile: install bios-microvm like other binary blobs

From: Bruce Rogers Commit 0d5fae3e52e introduced bios-microvm.bin but forgot to add it to the list of blobs being installed. Add it to the list of BLOBS that get installed. Fixes: 0d5fae3e52e "roms: add microvm-bios (qboot) as binary" Signed-off-by: Bruce Rogers [PMD: Reworded description] Sign

[PULL 2/5] qom: Fix error message in object_class_property_add()

From: Greg Kurz The error message in object_class_property_add() was copied from object_property_add() in commit 16bf7f522a2ff. Clarify that it is about a class, not an object. While here, have the format string in both functions to fit in a single line for better grep-ability, despite the check

[PULL 5/5] ivshmem-server: Terminate also on SIGINT

From: Jan Kiszka Allows to shutdown a foreground session via ctrl-c. Signed-off-by: Jan Kiszka Reviewed-by: Claudio Fontana Reviewed-by: Stefano Garzarella Message-Id: <99c1a7bd-1876-66a2-4b8e-d5bc86116...@web.de> Signed-off-by: Laurent Vivier --- contrib/ivshmem-server/main.c | 5 +++-- 1

Re: [PATCH] qemu-coroutine-sleep: Silence Coverity warning

11.11.2019 23:35, Eric Blake wrote: > Coverity warns that we store the address of a stack variable through a > pointer passed in by the caller, which would let the caller trivially > trigger use-after-free if that stored value is still present when we > finish execution. However, the way coroutine

Re: [PULL 10/14] net/virtio: add failover support

On Tue, 29 Oct 2019 at 23:01, Michael S. Tsirkin wrote: > > From: Jens Freimann > > This patch adds support to handle failover device pairs of a virtio-net > device and a (vfio-)pci device, where the virtio-net acts as the standby > device and the (vfio-)pci device as the primary. Hi; Coverity r

[PULL 4/5] ivshmem-server: Clean up shmem on shutdown

From: Jan Kiszka So far, the server leaves the posix shared memory object behind when terminating, requiring the user to explicitly remove it in order to start a new instance. Signed-off-by: Jan Kiszka Reviewed-by: Claudio Fontana Message-Id: Signed-off-by: Laurent Vivier --- contrib/ivshme

Re: [PATCH v6 1/3] block: introduce compress filter driver

On 12/11/2019 12:39, Kevin Wolf wrote: > Am 11.11.2019 um 17:04 hat Andrey Shinkevich geschrieben: >> Allow writing all the data compressed through the filter driver. >> The written data will be aligned by the cluster size. >> Based on the QEMU current implementation, that data can be written to >>

Re: [PULL v2 01/13] linux-user: Support for NETLINK socket options

On Wed, 6 Nov 2019 at 13:07, Laurent Vivier wrote: > > From: Josh Kunz > > This change includes support for all AF_NETLINK socket options up to about > kernel version 5.4 (5.4 is not formally released at the time of writing). > Socket options that were introduced in kernel versions before the old

Re: [PULL 11/14] vfio: unplug failover primary device before migration

On Tue, 29 Oct 2019 at 23:01, Michael S. Tsirkin wrote: > > From: Jens Freimann > > As usual block all vfio-pci devices from being migrated, but make an > exception for failover primary devices. This is achieved by setting > unmigratable to 0 but also add a migration blocker for all vfio-pci > de

Re: [PATCH] i386: define the 'flush_l1d' CPUID feature bit (CVE-2018-3646)

On 12/11/19 10:51, Daniel P. Berrangé wrote: > On Tue, Nov 12, 2019 at 03:50:43AM +, Kyle Copperfield via wrote: >> New microcode introduces the "Flush L1D Cache" CPUID feature bit. >> This needs to be exposed to guest OS to allow them to protect against >> CVE-2018-3646. > > My understanding

Re: [PULL 20/39] hw/i386: Introduce the microvm machine type

On Thu, 24 Oct 2019 at 16:19, Paolo Bonzini wrote: > > From: Sergio Lopez > > microvm is a machine type inspired by Firecracker and constructed > after its machine model. > > It's a minimalist machine type without PCI nor ACPI support, designed > for short-lived guests. microvm also establishes a

[Bug 1852196] [NEW] update edk2 submodule & binaries to edk2-stable201911

Public bug reported: edk2-stable201911 will be tagged soon: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release- Planning https://github.com/tianocore/edk2/releases/tag/edk2-stable201911 [upcoming link] It should be picked up by QEMU, after the v4.2.0 release. Relevant f

Re: [PULL 04/11] target/arm/cpu64: max cpu: Introduce sve properties

On Fri, 1 Nov 2019 at 08:51, Peter Maydell wrote: > > From: Andrew Jones > > Introduce cpu properties to give fine control over SVE vector lengths. > We introduce a property for each valid length up to the current > maximum supported, which is 2048-bits. The properties are named, e.g. > sve128, s

Re: [PATCH v6 1/3] block: introduce compress filter driver

12.11.2019 13:07, Andrey Shinkevich wrote: > On 12/11/2019 12:39, Kevin Wolf wrote: >> Am 11.11.2019 um 17:04 hat Andrey Shinkevich geschrieben: >>> Allow writing all the data compressed through the filter driver. >>> The written data will be aligned by the cluster size. >>> Based on the QEMU curre

Re: [PULL v2 01/13] linux-user: Support for NETLINK socket options

Le 12/11/2019 à 11:11, Peter Maydell a écrit : > On Wed, 6 Nov 2019 at 13:07, Laurent Vivier wrote: >> >> From: Josh Kunz >> >> This change includes support for all AF_NETLINK socket options up to about >> kernel version 5.4 (5.4 is not formally released at the time of writing). >> Socket options

Re: [PATCH v6 1/3] block: introduce compress filter driver

11.11.2019 19:04, Andrey Shinkevich wrote: > Allow writing all the data compressed through the filter driver. > The written data will be aligned by the cluster size. > Based on the QEMU current implementation, that data can be written to > unallocated clusters only. May be used for a backup job. >

Re: [PATCH qemu-web] Add a blog post on "Micro-Optimizing KVM VM-Exits"

On Fri, Nov 08, 2019 at 10:22:47AM +0100, Kashyap Chamarthy wrote: > +The proposal: "KVM Monolithic" > +-- > + > +Based on his investigation, Andrea proposed a patch series, ["KVM > +monolithc"](https://lwn.net/Articles/800870/), to get rid of the KVM s/monolithc/monoli

Re: API definition for LUKS key management

On 12.11.19 10:12, Kevin Wolf wrote: > Am 11.11.2019 um 19:34 hat Daniel P. Berrangé geschrieben: >> On Mon, Nov 11, 2019 at 05:58:20PM +0200, Maxim Levitsky wrote: >>> One of the concerns that was raised during the review was that amend >>> interface for luks that I propose is >>> different from

[PATCH] hw: add compat machines for 5.0

Add 5.0 machine types for arm/i440fx/q35/s390x/spapr. For i440fx and q35, unversioned cpu models are still translated to -v1; I'll leave changing this (if desired) to the respective maintainers. Signed-off-by: Cornelia Huck --- also pushed out to https://github.com/cohuck/qemu machine-5.0 x86

Re: [PATCH] qemu-coroutine-sleep: Silence Coverity warning

On Tue, 12 Nov 2019 at 10:08, Vladimir Sementsov-Ogievskiy wrote: > > 11.11.2019 23:35, Eric Blake wrote: > > Coverity warns that we store the address of a stack variable through a > > pointer passed in by the caller, which would let the caller trivially > > trigger use-after-free if that stored v

[PATCH] linux-user: fix missing break

Reported by Coverity (CID 1407221) Fixes: a2d866827bd8 ("linux-user: Support for NETLINK socket options") cc: Josh Kunz Signed-off-by: Laurent Vivier --- linux-user/syscall.c | 1 + 1 file changed, 1 insertion(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index ab9d933e53af..4e97b

Re: API definition for LUKS key management

On Tue, Nov 12, 2019 at 10:12:45AM +0100, Kevin Wolf wrote: > Am 11.11.2019 um 19:34 hat Daniel P. Berrangé geschrieben: > > On Mon, Nov 11, 2019 at 05:58:20PM +0200, Maxim Levitsky wrote: > > > One of the concerns that was raised during the review was that amend > > > interface for luks that I pr

[PATCH v3 1/2] virtio: make seg_max virtqueue size dependent

Before the patch, seg_max parameter was immutable and hardcoded to 126 (128 - 2) without respect to queue size. This has two negative effects: 1. when queue size is < 128, we have Virtio 1.1 specfication violation: (2.6.5.3.1 Driver Requirements) seq_max must be <= queue_size. This violation

[PATCH v3 0/2] virtio: make seg_max virtqueue size dependent

v3: * add property to set in machine type [MST] * add min queue size check [Stefan] * add avocado based test [Max, Stefan, Eduardo, Cleber] v2: * the standalone patch to make seg_max virtqueue size dependent * other patches are postponed v1: the initial series Denis Plotnikov (2):

[PATCH v3 2/2] tests: add virtio-scsi and virtio-blk seg_max_adjust test

It tests proper seg_max_adjust settings for all machine types except 'none', 'isapc', 'microvm' Signed-off-by: Denis Plotnikov --- tests/acceptance/virtio_seg_max_adjust.py | 135 ++ 1 file changed, 135 insertions(+) create mode 100755 tests/acceptance/virtio_seg_max_adjust.

Re: [PATCH] qemu-coroutine-sleep: Silence Coverity warning

Eric Blake writes: > Coverity warns that we store the address of a stack variable through a > pointer passed in by the caller, which would let the caller trivially > trigger use-after-free if that stored value is still present when we > finish execution. However, the way coroutines work is tha

[PATCH v3 1/8] blockdev: merge drive_backup_prepare with do_drive_backup

Consolidate drive_backup_prepare() with do_drive_backup() as a first step towards streamlining all functionality through transactions. Signed-off-by: Sergio Lopez --- blockdev.c | 58 +++--- 1 file changed, 16 insertions(+), 42 deletions(-) diff -

[PATCH v3 6/8] blockdev: place blockdev_backup_prepare with the other related transaction helpers

Move blockdev_backup_prepare() to be side by side with the other related transaction helper functions. Signed-off-by: Sergio Lopez --- blockdev.c | 70 +++--- 1 file changed, 35 insertions(+), 35 deletions(-) diff --git a/blockdev.c b/blockdev.c i

[PATCH v3 0/8] blockdev: avoid acquiring AioContext lock twice at do_drive_backup and do_blockdev_backup

do_drive_backup() acquires the AioContext lock of the corresponding BlockDriverState. This is not a problem when it's called from qmp_drive_backup(), but drive_backup_prepare() also acquires the lock before calling it. The same things happens with do_blockdev_backup() and blockdev_backup_prepare().

[PATCH v3 7/8] blockdev: change qmp_blockdev_backup to make use of transactions

Change qmp_blockdev_backup() to create and start a transaction instead of calling do_blockdev_backup() directly. Signed-off-by: Sergio Lopez --- blockdev.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/blockdev.c b/blockdev.c index f94aaa98f0..152a0f7454 100644

[PATCH v3 4/8] blockdev: change qmp_drive_backup to make use of transactions

Change qmp_drive_backup() to create and start a transaction instead of calling do_drive_backup directly. Signed-off-by: Sergio Lopez --- blockdev.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/blockdev.c b/blockdev.c index b32855f702..5e85fc042e 100644 --- a/

[PATCH v3 2/8] blockdev: fix coding style issues in drive_backup_prepare

Fix a couple of minor coding style issues in drive_backup_prepare. Signed-off-by: Sergio Lopez --- blockdev.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/blockdev.c b/blockdev.c index 5d30aff1e5..e8b673c5f3 100644 --- a/blockdev.c +++ b/blockdev.c @@ -3592,7 +3592

[PATCH v3 8/8] blockdev: honor bdrv_try_set_aio_context() context requirements

bdrv_try_set_aio_context() requires that the old context is held, and the new context is not held. Fix all the occurrences where it's not done this way. Suggested-by: Max Reitz Signed-off-by: Sergio Lopez --- blockdev.c | 67 ++ 1 file changed

[PATCH v3 5/8] blockdev: merge blockdev_backup_prepare with do_blockdev_backup

Consolidate blockdev_backup_prepare() with do_blockdev_backup() as a first step towards streamlining all functionality through transactions. Signed-off-by: Sergio Lopez --- blockdev.c | 64 +- 1 file changed, 15 insertions(+), 49 deletions(-)

[PATCH v3 3/8] blockdev: place drive_backup_prepare with the other related transaction functions

Move drive_backup_prepare() to be side by side with the other related transaction helper functions. Signed-off-by: Sergio Lopez --- blockdev.c | 247 +++-- 1 file changed, 125 insertions(+), 122 deletions(-) diff --git a/blockdev.c b/blockdev.c in

Re: [qemu-web PATCH] Add device fuzzing blog post

On 07/11/2019 16.48, Stefan Hajnoczi wrote: > On Thu, Nov 7, 2019 at 10:43 AM Thomas Huth wrote: >> >> - Original Message - >>> From: "Stefan Hajnoczi" >>> Sent: Thursday, November 7, 2019 10:11:36 AM >>> >>> This blog post covers the device fuzzing GSoC project that Alexander >>> Olenik

Re: [PATCH v3 0/2] virtio: make seg_max virtqueue size dependent

On Tue, Nov 12, 2019 at 02:13:52PM +0300, Denis Plotnikov wrote: > v3: > * add property to set in machine type [MST] > * add min queue size check [Stefan] > * add avocado based test [Max, Stefan, Eduardo, Cleber] > > v2: > * the standalone patch to make seg_max virtqueue size dependent >

Re: [PATCH] i386: define the 'flush_l1d' CPUID feature bit (CVE-2018-3646)

Patchew URL: https://patchew.org/QEMU/20191112035043.54600-1-kmcop...@danwin1210.me/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: [PULL 20/39] hw/i386: Introduce the microvm machine type

Peter Maydell writes: > On Thu, 24 Oct 2019 at 16:19, Paolo Bonzini wrote: >> >> From: Sergio Lopez >> >> microvm is a machine type inspired by Firecracker and constructed >> after its machine model. >> >> It's a minimalist machine type without PCI nor ACPI support, designed >> for short-live

Re: [PATCH] pl031: Expose RTCICR as proper WC register

On Tue, 12 Nov 2019 at 07:28, Alexander Graf wrote: > > Hey Peter, > > On 08.11.19 17:58, Peter Maydell wrote: > > Did you find this because you had a guest that assumed the > > other behaviour? This bug has been in QEMU for a very long time, > > and it seems odd for a guest to deliberately perfor

Re: [PATCH v2 00/11] RFC crypto/luks: encryption key managment using amend interface

On 08.11.19 16:07, Maxim Levitsky wrote: > On Fri, 2019-10-04 at 21:10 +0200, Max Reitz wrote: >> On 13.09.19 00:30, Maxim Levitsky wrote: >>> This patch series is continuation of my work to add encryption >>> key managment to luks/qcow2 with luks. >>> >>> This is second version of this patch set.

Re: [PATCH v2 00/11] RFC crypto/luks: encryption key managment using amend interface

On Tue, 2019-11-12 at 12:58 +0100, Max Reitz wrote: > On 08.11.19 16:07, Maxim Levitsky wrote: > > On Fri, 2019-10-04 at 21:10 +0200, Max Reitz wrote: > > > On 13.09.19 00:30, Maxim Levitsky wrote: > > > > This patch series is continuation of my work to add encryption > > > > key managment to luks/

Re: [qemu-web PATCH v3] documentation: link to nightly documentation

On 08/11/2019 11.54, Stefan Hajnoczi wrote: > Link to the documentation built from qemu.git/master once a day. > > Signed-off-by: Stefan Hajnoczi > --- > v3: > * Use a qemu.org URL, not a wiki.qemu.org URL [danpb] > v2: > * This revision was broken - please ignore! :) > --- > documentation.md

Re: [PULL 0/6] qtest and misc patches

On Tue, 12 Nov 2019 at 06:43, Thomas Huth wrote: > > Hi Peter, > > the following changes since commit 654efcb511d394c1d3f5292c28503d1d19e5b1d3: > > Merge remote-tracking branch 'remotes/vivier/tags/q800-branch-pull-request' > into staging (2019-11-11 09:23:46 +) > > are available in the Gi

[Bug 1852115] Re: qemu --static user build fails with fedora rawhide glibc-2.30.9000

We use stime() to implement the target stime syscall. We should probably switch to using clock_settime(CLOCK_REALTIME, ...) instead, as that's what glibc uses internally now to implement its stime(): https://sourceware.org/git/?p=glibc.git;a=blob;f=time/stime.c;h=6ea3b6dcc1a393b57b69ca24fbfe8023d9

Re: [RFC v5 015/126] hw/s390x: rename Error ** parameter to more common errp

On Fri, 11 Oct 2019 19:04:01 +0300 Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > hw/s390x/event-facility.c | 2 +- > hw/s390x/s390-stattrib.c | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) Does not hurt, I guess. Reviewed-by: Cornelia

Re: [PATCH 5/5] hw/arm/virt: Add nvdimm hotplug support

On Fri, 4 Oct 2019 16:53:02 +0100 Shameer Kolothum wrote: > This adds support for nvdimm hotplug events through GED > and enables nvdimm for the arm/virt. Now Guests with DT boot > can have nvdimm cold plug and with ACPI both cold/hot plug. > > Hot removal functionality is not yet supported. >

Re: [RFC v5 023/126] hw/vfio/ap: drop local_err from vfio_ap_realize

On Fri, 11 Oct 2019 19:04:09 +0300 Vladimir Sementsov-Ogievskiy wrote: > No reason for local_err here, use errp directly instead. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > hw/vfio/ap.c | 16 +++- > 1 file changed, 3 insertions(+), 13 deletions(-) > > diff --git a/hw/

Re: [RFC v5 026/126] python: add commit-per-subsystem.py

On Fri, 11 Oct 2019 19:04:12 +0300 Vladimir Sementsov-Ogievskiy wrote: > Add script to automatically commit tree-wide changes per-subsystem. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- I think this still needs some notes as to the supposed usage.

Re: [RFC v5 028/126] s390x: introduce ERRP_AUTO_PROPAGATE

On Fri, 11 Oct 2019 19:04:14 +0300 Vladimir Sementsov-Ogievskiy wrote: > If we want to add some info to errp (by error_prepend() or > error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. > Otherwise, this info will not be added when errp == &fatal_err > (the program will exit prior to

Re: [RFC v5 030/126] kvm: introduce ERRP_AUTO_PROPAGATE

On Fri, 11 Oct 2019 19:04:16 +0300 Vladimir Sementsov-Ogievskiy wrote: > If we want to add some info to errp (by error_prepend() or > error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. > Otherwise, this info will not be added when errp == &fatal_err > (the program will exit prior to

Re: [RFC v5 037/126] S390 Machines: introduce ERRP_AUTO_PROPAGATE

On Fri, 11 Oct 2019 19:04:23 +0300 Vladimir Sementsov-Ogievskiy wrote: > If we want to add some info to errp (by error_prepend() or > error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. > Otherwise, this info will not be added when errp == &fatal_err > (the program will exit prior to

Re: [RFC v5 051/126] vfio-ccw: introduce ERRP_AUTO_PROPAGATE

On Fri, 11 Oct 2019 19:04:37 +0300 Vladimir Sementsov-Ogievskiy wrote: > If we want to add some info to errp (by error_prepend() or > error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. > Otherwise, this info will not be added when errp == &fatal_err > (the program will exit prior to

Re: [RFC v5 056/126] virtio-ccw: introduce ERRP_AUTO_PROPAGATE

On Fri, 11 Oct 2019 19:04:42 +0300 Vladimir Sementsov-Ogievskiy wrote: > If we want to add some info to errp (by error_prepend() or > error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. > Otherwise, this info will not be added when errp == &fatal_err > (the program will exit prior to

Re: [PATCH] linux-user: fix missing break

On 11/12/19 11:50 AM, Laurent Vivier wrote: Reported by Coverity (CID 1407221) Fixes: a2d866827bd8 ("linux-user: Support for NETLINK socket options") cc: Josh Kunz Signed-off-by: Laurent Vivier --- linux-user/syscall.c | 1 + 1 file changed, 1 insertion(+) diff --git a/linux-user/syscall.c

Re: [RFC v5 000/126] error: auto propagated local_err

On Fri, 8 Nov 2019 22:57:25 +0400 Marc-André Lureau wrote: > Hi > > On Fri, Nov 8, 2019 at 7:31 PM Vladimir Sementsov-Ogievskiy > wrote: > > > > Finally, what is the plan? > > > > Markus what do you think? > > > > Now a lot of patches are reviewed, but a lot of are not. > > > > Is there any hop

Re: [PULL 0/5] Trivial branch patches

- > Trivial fixes (20191112) > ivshmem-server, error messages (numa, qom) and > Makefile (bios-microvm) fixes > > Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/4.2 for any user-visible changes. -- PMM

Re: [virtio-dev] Re: guest / host buffer sharing ...

On Mon, 2019-11-11 at 16:54 -0800, Gurchetan Singh wrote: > On Tue, Nov 5, 2019 at 2:55 AM Gerd Hoffmann > wrote: > > Each buffer also has some properties to carry metadata, some fixed > > (id, size, application), but > > also allow free form (name = value, framebuffers would have > > width/height

[PATCH 2/2] tests/acceptance: Makes linux_initrd and empty_cpu_model use QEMUMachine

On linux_initrd and empty_cpu_model tests the same effect of calling QEMU through run() to inspect the terminated process is achieved with a sequence of set_qmp_monitor() / launch() / wait() commands on an QEMUMachine object. This patch changes those tests to use QEMUMachine instead, so they follow

[PATCH 1/2] python/qemu: Add set_qmp_monitor() to QEMUMachine

The QEMUMachine VM has a monitor setup on which an QMP connection is always attempted on _post_launch() (executed by launch()). In case the QEMU process immediatly exits then the qmp.accept() (used to establish the connection) stalls until it reaches timeout and consequently an exception raises. T

[PATCH 0/2] tests/acceptance: Use QEMUMachine on tests that expect failure

The linux_initrd and empty_cpu_model tests assert that QEMU exit with failure on certain scenarios. Currently they are not able to use QEMUMachine object due to the QMP monitor connection which is tentatively established always. Instead they handle the QEMU binary directy, but ideally they should u

Re: [PATCH v7 6/8] Acceptance tests: add the build directory to the system PATH

On 11/11/19 8:49 PM, Cleber Rosa wrote: On Thu, Nov 07, 2019 at 05:46:13PM -0200, Wainer dos Santos Moschetta wrote: On 11/4/19 1:13 PM, Cleber Rosa wrote: So that when binaries such as qemu-img are searched for, those in the build tree will be favored. As a clarification, SRC_ROOT_DIR is de

Re: [RFC PATCH 18/18] qemu-storage-daemon: Add --monitor option

Kevin Wolf writes: > This adds and parses the --monitor option, so that a QMP monitor can be > used in the storage daemon. The monitor offers commands defined in the > QAPI schema at storage-daemon/qapi/qapi-schema.json. I feel we should explain the module sharing between the two QAPI schemata h

[PATCH] linux-user: remove host stime() syscall

stime() has been withdrawn from glibc (12cbde1dae6f "Use clock_settime to implement stime; withdraw stime.") Implement the target stime() syscall using host clock_settime(CLOCK_REALTIME, ...) as it is done internally in glibc. Tested qemu-ppc/x86_64 with: #include #include

Re: [PATCH] linux-user: remove host stime() syscall

On Tue, 12 Nov 2019 at 14:26, Laurent Vivier wrote: > > stime() has been withdrawn from glibc > (12cbde1dae6f "Use clock_settime to implement stime; withdraw stime.") > > Implement the target stime() syscall using host > clock_settime(CLOCK_REALTIME, ...) as it is done internally in glibc. > > Tes

Re: [PATCH 0/5] ARM virt: Add NVDIMM support

On Fri, 4 Oct 2019 16:52:57 +0100 Shameer Kolothum wrote: > This series adds NVDIMM support to arm/virt platform. > This has a dependency on [0] and make use of the GED > device for NVDIMM hotplug events. The series reuses > some of the patches posted by Eric in his earlier > attempt here[1]. >

Re: [PATCH] linux-user: remove host stime() syscall

On 11/12/19 9:25 AM, Laurent Vivier wrote: > stime() has been withdrawn from glibc > (12cbde1dae6f "Use clock_settime to implement stime; withdraw stime.") > > Implement the target stime() syscall using host > clock_settime(CLOCK_REALTIME, ...) as it is done internally in glibc. > > Tested qemu-p

Re: [PATCH V4] target/i386/kvm: Add Hyper-V direct tlb flush support

On Tue, Nov 12, 2019 at 11:34:27AM +0800, lantianyu1...@gmail.com wrote: > From: Tianyu Lan > > Hyper-V direct tlb flush targets KVM on Hyper-V guest. > Enable direct TLB flush for its guests meaning that TLB > flush hypercalls are handled by Level 0 hypervisor (Hyper-V) > bypassing KVM in Level

[PULL 5/8] tests: only run ipmi-bt-test if CONFIG_LINUX

This test has been unstable on NetBSD for awhile. It seems the mechanism used to listen to a random port is a Linux-ism (although a received wisdom Linux-ism rather than a well documented one). As working around would add more hard to test complexity to the test I've gone for the easier option of m

[PULL 0/8] testing and tcg plugin api ver

The following changes since commit 039e285e095c20a88e623b927654b161aaf9d914: Merge remote-tracking branch 'remotes/vivier2/tags/trivial-branch-pull-request' into staging (2019-11-12 12:09:19 +) are available in the Git repository at: https://github.com/stsquad/qemu.git tags/pull-testin

[PULL 2/8] tests/vm: add console_consume helper

From: Gerd Hoffmann Helper function to read all console output. Signed-off-by: Gerd Hoffmann Message-Id: <20191031085306.2-3-kra...@redhat.com> Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé diff --git a/tests/vm/basevm.py b/tests/vm/bas

[PULL 7/8] .travis.yml: don't run make check with multiple jobs

Let's challenge the convention that doing more at a time helps. It certainly doesn't tell you unambiguously where in the test cycle you were before the test hangs and exceeds the job time limit. Signed-off-by: Alex Bennée diff --git a/.travis.yml b/.travis.yml index 678e33decc2..b9a026c8eeb 1006

[PULL 1/8] tests/vm: netbsd autoinstall, using serial console

From: Gerd Hoffmann Instead of fetching the prebuilt image from patchew download the install iso and prepare the image locally. Install to disk, using the serial console. Create qemu user, configure ssh login. Install packages needed for qemu builds. Signed-off-by: Gerd Hoffmann Reviewed-by:

[PULL 3/8] tests/vm: use console_consume for netbsd

From: Gerd Hoffmann Use new helper to read all pending console output, not just a single char. Unblocks installer boot. Signed-off-by: Gerd Hoffmann Message-Id: <20191031085306.2-4-kra...@redhat.com> Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathi

[PULL 6/8] tests/vm: support sites with sha512 checksums

The NetBSD project uses SHA512 for its checksums so lets support that in the download helper. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py index 086bfb2c66d..91a9226026d 100755 --- a/tests/

  1   2   3   >