Re: [PATCH v14 03/11] tests: Add test for QAPI builtin type time

2019-11-08 Thread Markus Armbruster
Tao Xu writes: > On 11/7/2019 9:31 PM, Eduardo Habkost wrote: >> On Thu, Nov 07, 2019 at 02:24:52PM +0800, Tao Xu wrote: >>> On 11/7/2019 4:53 AM, Eduardo Habkost wrote: On Mon, Oct 28, 2019 at 03:52:12PM +0800, Tao Xu wrote: > Add tests for time input such as zero, around limit of preci

Re: [PATCH v21 3/6] ACPI: Add APEI GHES table generation support

2019-11-08 Thread gengdongjiu
On 2019/11/4 20:14, Xiang Zheng wrote: > From: Dongjiu Geng > > This patch implements APEI GHES Table generation via fw_cfg blobs. Now > it only supports ARMv8 SEA, a type of GHESv2 error source. Afterwards, > we can extend the supported types if needed. For the CPER section, > currently it is me

Re: [Qemu-devel] Exposing feature deprecation to machine clients

2019-11-08 Thread Max Reitz
On 07.11.19 20:13, Vladimir Sementsov-Ogievskiy wrote: > 07.11.2019 21:52, Philippe Mathieu-Daudé wrote: >> Hi Markus, >> >> On 8/15/19 7:40 PM, John Snow wrote: >>> On 8/15/19 10:16 AM, Markus Armbruster wrote: John Snow writes: >> [...] > I asked Markus this not too long ago; do we want

Re: QEMU HTML documentation now on qemu.org

2019-11-08 Thread Stefan Hajnoczi
On Thu, Nov 07, 2019 at 04:01:42PM +, Daniel P. Berrangé wrote: > On Thu, Nov 07, 2019 at 04:44:34PM +0100, Stefan Hajnoczi wrote: > > On Thu, Nov 7, 2019 at 11:07 AM Daniel P. Berrangé > > wrote: > > > > > > On Wed, Nov 06, 2019 at 05:19:28PM +0100, Stefan Hajnoczi wrote: > > > > Hi, > > > >

Re: [PATCH v14 03/11] tests: Add test for QAPI builtin type time

2019-11-08 Thread Igor Mammedov
On Fri, 08 Nov 2019 09:05:52 +0100 Markus Armbruster wrote: > Tao Xu writes: > > > On 11/7/2019 9:31 PM, Eduardo Habkost wrote: > >> On Thu, Nov 07, 2019 at 02:24:52PM +0800, Tao Xu wrote: > >>> On 11/7/2019 4:53 AM, Eduardo Habkost wrote: > On Mon, Oct 28, 2019 at 03:52:12PM +0800,

Re: [Qemu-devel] [Fail] tests/test-util-filemonitor fails

2019-11-08 Thread Miguel Arruga Vivas
Hello Daniel, Daniel P. Berrangé wrote: > This reported bug was already fixed in git master with > > commit bf9e0313c27d8e6ecd7f7de3d63e1cb25d8f6311 > Author: Daniel P. Berrangé > Date: Wed Aug 21 16:14:27 2019 +0100 > > tests: make filemonitor test more robust to event ordering T

[PATCH 0/2] block: Fix multiple blockdev-snapshot calls

2019-11-08 Thread Kevin Wolf
Kevin Wolf (2): block: Remove 'backing': null from bs->{explicit_,}options iotests: Test multiple blockdev-snapshot calls block.c| 2 + tests/qemu-iotests/273 | 76 + tests/qemu-iotests/273.out | 337 + tests/qemu-iotests/

[PATCH 1/2] block: Remove 'backing': null from bs->{explicit_, }options

2019-11-08 Thread Kevin Wolf
bs->options and bs->explicit_options shouldn't contain any options for child nodes. bdrv_open_inherited() takes care to remove any options that match a child name after opening the image and the same is done when reopening. However, we miss the case of 'backing': null, which is a child option, but

[PATCH 2/2] iotests: Test multiple blockdev-snapshot calls

2019-11-08 Thread Kevin Wolf
Test that doing a second blockdev-snapshot doesn't make the first overlay's backing file go away. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/273 | 76 + tests/qemu-iotests/273.out | 337 + tests/qemu-iotests/group | 1 + 3 files changed,

[PATCH] iotests: Fix "no qualified output" error path

2019-11-08 Thread Kevin Wolf
The variable for error messages to be displayed is $results, not $reason. Fix 'check' to print the "no qualified output" error message again instead of having a failure without any message telling the user why it failed. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/check | 2 +- 1 file chang

Re: [RFC PATCH 18/18] qemu-storage-daemon: Add --monitor option

2019-11-08 Thread Markus Armbruster
Quick observation: --help fails to mention --monitor.

Re: [RFC PATCH 04/18] stubs: Add blk_by_qdev_id()

2019-11-08 Thread Markus Armbruster
Kevin Wolf writes: > blockdev.c uses the blk_by_qdev_id() function, so before we can use the > file in tools (i.e. outside of the system emulator), we need to add a > stub for it. The function always returns an error. > > Signed-off-by: Kevin Wolf > --- > stubs/blk-by-qdev-id.c | 9 + >

Re: Looking for issues/features for my first contribution

2019-11-08 Thread Alex Bennée
Rajath Shashidhara writes: > On 07-11-2019 07:33, Aleksandar Markovic wrote: >> I did a quick Google search on datasheets of existing RTC >> implemtations, and the result is: >> DS1338: >> https://datasheets.maximintegrated.com/en/ds/DS1338-DS1338Z.pdf >> M41T80: https://www.st.com/resource/en/

Re: [PATCH v2] ivshmem-server: Clean up shmem on shutdown

2019-11-08 Thread Jan Kiszka
On 06.08.19 15:01, Claudio Fontana wrote: On 8/5/19 7:54 AM, Jan Kiszka wrote: From: Jan Kiszka So far, the server leaves the posix shared memory object behind when terminating, requiring the user to explicitly remove it in order to start a new instance. Signed-off-by: Jan Kiszka --- Change

[PATCH qemu-web] Add a blog post on "Micro-Optimizing KVM VM-Exits"

2019-11-08 Thread Kashyap Chamarthy
This blog post summarizes the talk "Micro-Optimizing KVM VM-Exits"[1], given by Andrea Arcangeli at the recently concluded KVM Forum 2019. [1] https://kvmforum2019.sched.com/event/Tmwr/micro-optimizing-kvm-vm-exits-andrea-arcangeli-red-hat-inc Signed-off-by: Kashyap Chamarthy --- ...019-11-06-

Re: [PATCH v2 07/11] block: add x-blockdev-amend qmp command

2019-11-08 Thread Maxim Levitsky
On Fri, 2019-10-04 at 20:53 +0200, Max Reitz wrote: > On 13.09.19 00:30, Maxim Levitsky wrote: > > Signed-off-by: Maxim Levitsky > > --- > > block/Makefile.objs | 2 +- > > block/amend.c | 116 ++ > > include/block/block_int.h | 23 ++--

Re: [PATCH v2 07/11] block: add x-blockdev-amend qmp command

2019-11-08 Thread Maxim Levitsky
On Fri, 2019-10-04 at 20:53 +0200, Max Reitz wrote: > On 13.09.19 00:30, Maxim Levitsky wrote: > > Signed-off-by: Maxim Levitsky > > --- > > block/Makefile.objs | 2 +- > > block/amend.c | 116 ++ > > include/block/block_int.h | 23 ++--

Re: [Qemu-devel] [PATCH v2 02/11] qcrypto-luks: extend the create options for upcoming encryption key management

2019-11-08 Thread Maxim Levitsky
On Mon, 2019-10-07 at 09:49 +0200, Markus Armbruster wrote: > Quick QAPI schema review only. > > Maxim Levitsky writes: > > > Now you can specify which slot to put the encryption key to > > Plus add 'active' option which will let user erase the key secret > > instead of adding it. > > Check tha

Re: [PATCH v2 11/11] iotests : add tests for encryption key management

2019-11-08 Thread Maxim Levitsky
On Fri, 2019-10-04 at 21:11 +0200, Max Reitz wrote: > On 13.09.19 00:30, Maxim Levitsky wrote: > > Note that currently I add tests 300-302, which are > > placeholders to ease the rebase. In final version > > of these patches I will update these. > > > > Signed-off-by: Maxim Levitsky > > --- > >

Re: [PATCH v2 02/11] qcrypto-luks: extend the create options for upcoming encryption key management

2019-11-08 Thread Maxim Levitsky
On Fri, 2019-10-04 at 19:42 +0200, Max Reitz wrote: > On 13.09.19 00:30, Maxim Levitsky wrote: > > Now you can specify which slot to put the encryption key to > > Plus add 'active' option which will let user erase the key secret > > instead of adding it. > > Check that active=true it when creating

Re: QEMU HTML documentation now on qemu.org

2019-11-08 Thread Paolo Bonzini
On 08/11/19 09:41, Stefan Hajnoczi wrote: >> If we're not storing the generated docs in git, then when >> pushing to qemu-web.git we need to ensure we preserve the >> extra /docs dir content in some manner. > For qemu.git/master the built docs might change every day. Committing > them to qemu-web.

Re: [PATCH v2 05/11] block/crypto: implement the encryption key management

2019-11-08 Thread Maxim Levitsky
On Fri, 2019-10-04 at 20:41 +0200, Max Reitz wrote: > On 13.09.19 00:30, Maxim Levitsky wrote: > > This implements the encryption key management > > using the generic code in qcrypto layer > > (currently only for qemu-img amend) > > > > This code adds another 'write_func' because the initializatio

Re: Deprecating stuff for 4.2

2019-11-08 Thread Vladimir Sementsov-Ogievskiy
08.11.2019 9:41, Markus Armbruster wrote: > Vladimir Sementsov-Ogievskiy writes: > >> 07.11.2019 21:52, Philippe Mathieu-Daudé wrote: > [...] >>> Pre-release period, time to deprecate some stuffs :) >>> >>> How should we proceed? Do you have something in mind? >>> >>> There are older threads abou

[PATCH 4/4 V2] scsi-disk: add FUA support for COMPARE_AND_WRITE

2019-11-08 Thread Yaowei Bai
It is implemented in the blk_aio_pwritev's callback function in a way similar to its emulation in scsi_write_do_fua function Signed-off-by: Yaowei Bai --- hw/scsi/scsi-disk.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index f9a0267..

[PATCH 1/4 V2] block: add SCSI COMPARE_AND_WRITE support

2019-11-08 Thread Yaowei Bai
Some storages(i.e. librbd) already have interfaces to handle some SCSI commands directly. This patch adds COMPARE_AND_WRITE command support through the write path in the block io layer by introducing a new element BDRV_REQ_COMPARE_AND_WRITE into BdrvRequestFlags which indicates a COMPARE_AND_WRITE

[PATCH 2/4 V2] block/rbd: implement bdrv_aio_compare_and_write interface

2019-11-08 Thread Yaowei Bai
This patch adds librbd's SCSI COMPARE_AND_WRITE command interface support with bdrv_aio_compare_and_write function pointer. Note currently when a miscompare happens a mismatch offset of 0 is always reported rather than the actual mismatch offset. This should not be a big issue contemporarily and wi

[PATCH 3/4 V2] hw/scsi: add SCSI COMPARE_AND_WRITE support

2019-11-08 Thread Yaowei Bai
This patch emulates COMPARE_AND_WRITE command with the BDRV_REQ_COMPARE_AND_WRITE flag introduced by last patch. It matches the SBC-4 standard except the FUA bit support, it'll be finished in the next patch. Note that cmd->xfer is set 2 * the number got by scsi_data_cdb_xfer so we could touch the

[PATCH 0/4 V2] SCSI COMPARE_AND_WRITE command support

2019-11-08 Thread Yaowei Bai
Recently ceph/librbd added several interfaces to handle SCSI commands like COMPARE_AND_WRITE directly. However they were only be used in special scenarios, i.e. ISCSI. That involves more software components which makes the IO path longer and could bring more potential issues. Actually we're maintai

Re: QEMU HTML documentation now on qemu.org

2019-11-08 Thread Daniel P . Berrangé
On Fri, Nov 08, 2019 at 09:41:30AM +0100, Stefan Hajnoczi wrote: > On Thu, Nov 07, 2019 at 04:01:42PM +, Daniel P. Berrangé wrote: > > On Thu, Nov 07, 2019 at 04:44:34PM +0100, Stefan Hajnoczi wrote: > > > On Thu, Nov 7, 2019 at 11:07 AM Daniel P. Berrangé > > > wrote: > > > > > > > > On Wed,

Re: [PATCH 00/55] Patch Round-up for stable 4.1.1, freeze on 2019-11-12

2019-11-08 Thread Max Reitz
On 05.11.19 21:51, Michael Roth wrote: > Hi everyone, > > The following new patches are queued for QEMU stable v4.1.1: > > https://github.com/mdroth/qemu/commits/stable-4.1-staging > > The release is tentatively planned for 2019-11-14: > > https://wiki.qemu.org/Planning/4.1 > > Please note

Re: Should QEMU's configure script check for bzip2 ?

2019-11-08 Thread Daniel P . Berrangé
On Thu, Nov 07, 2019 at 08:43:27PM +0100, Thomas Huth wrote: > > Hi, > > I just tried to compile QEMU on a freshly installed system. "configure" > finished without problems, but during "make" I hit this error: > > BUNZIP2 pc-bios/edk2-i386-secure-code.fd.bz2 > /bin/sh: bzip2: command not foun

Re: [PATCH v1 2/4] virtio: make seg_max virtqueue size dependent

2019-11-08 Thread Michael S. Tsirkin
On Fri, Nov 08, 2019 at 07:43:22AM +, Denis Plotnikov wrote: > The 1st patch from the series seems to be useless. The patch extending > queue length by adding machine type may break vm-s which use seabios > with max queue size = 128. > > Looks like only this patch doesn't break anything and

Re: [PATCH 0/3] Some memory leak fixes

2019-11-08 Thread Michael S. Tsirkin
On Thu, Nov 07, 2019 at 11:27:28PM +0400, Marc-André Lureau wrote: > Hi, > > Another bunch of fixes spotted by ASAN when running check-qtest-x86_64. So who's merging this? > Marc-André Lureau (3): > virtio-input: fix memory leak on unrealize > qtest: fix qtest_qmp_device_add leak > cpu-plu

Re: [PATCH 1/3] virtio-input: fix memory leak on unrealize

2019-11-08 Thread Michael S. Tsirkin
On Thu, Nov 07, 2019 at 11:27:29PM +0400, Marc-André Lureau wrote: > Spotted by ASAN + minor stylistic change. > > Signed-off-by: Marc-André Lureau Reviewed-by: Michael S. Tsirkin > --- > hw/input/virtio-input.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/hw/input/virtio-inpu

Re: [PATCH 2/3] qtest: fix qtest_qmp_device_add leak

2019-11-08 Thread Thomas Huth
On 07/11/2019 20.27, Marc-André Lureau wrote: Spotted by ASAN. Signed-off-by: Marc-André Lureau --- tests/libqtest.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/libqtest.c b/tests/libqtest.c index 3706bccd8d..91e9cb220c 100644 --- a/tests/libqtest.c +++ b/tests/libqtest.c @@ -1

Re: [PATCH v3 00/22] iotests: Allow ./check -o data_file

2019-11-08 Thread Max Reitz
On 07.11.19 22:10, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20191107163708.833192-1-mre...@redhat.com/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Subject: [PATCH v3 00/22] iotests: Allow ./che

Re: [PATCH 0/3] Some memory leak fixes

2019-11-08 Thread Thomas Huth
On 07/11/2019 22.57, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20191107192731.17330-1-marcandre.lur...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can

[PATCH 0/3] docs: build an index page for the HTML docs

2019-11-08 Thread Stefan Hajnoczi
This patch series switches to a single invocation of sphinx that builds docs/index.rst. This global index page links to all HTML documentation produced by "make html", even the non-rST manuals. This index page will be used as the entrypoint for documentation published on the qemu.org website. St

[PATCH 2/3] docs: build a global index page

2019-11-08 Thread Stefan Hajnoczi
Build docs/ in a single sphinx invocation instead of treating docs/{devel,interop,specs} separately. This allows us to build a global index page that links to documentation across the different manuals. Some documentation is built outside of sphinx and is not formatted as reStructuredText. Link

[PATCH 1/3] docs: fix rst syntax errors in unbuilt docs

2019-11-08 Thread Stefan Hajnoczi
The .rst files outside docs/{devel,interop,specs} aren't built yet and therefore a few syntax errors have slipped through. Fix them. Signed-off-by: Stefan Hajnoczi --- docs/arm-cpu-features.rst| 6 +++--- docs/virtio-net-failover.rst | 4 ++-- docs/virtio-pmem.rst | 19 ++-

[PATCH 3/3] docs: install CSS and Javascript files for HTML docs

2019-11-08 Thread Stefan Hajnoczi
Install the sphinx CSS/Javascript support files needed by the HTML documentation. The documentation looks ugly without this. The previous patch switched to only invoking sphinx once so there is only one _static/ directory that needs to be installed across all manual sections. Signed-off-by: Stef

Re: [PATCH] iotests: Fix "no qualified output" error path

2019-11-08 Thread Max Reitz
On 08.11.19 09:57, Kevin Wolf wrote: > The variable for error messages to be displayed is $results, not > $reason. Fix 'check' to print the "no qualified output" error message > again instead of having a failure without any message telling the user > why it failed. > > Signed-off-by: Kevin Wolf >

[qemu-web PATCH] documentation: link to nightly documentation

2019-11-08 Thread Stefan Hajnoczi
Link to the documentation built from qemu.git/master once a day. Signed-off-by: Stefan Hajnoczi --- This depends on qemu.git "[PATCH 0/3] docs: build an index page for the HTML docs". We need that in order to build index.html. documentation.md | 2 ++ 1 file changed, 2 insertions(+) diff --gi

Re: [PATCH v2 02/11] qcrypto-luks: extend the create options for upcoming encryption key management

2019-11-08 Thread Maxim Levitsky
On Thu, 2019-10-10 at 15:44 +0200, Kevin Wolf wrote: > Am 13.09.2019 um 00:30 hat Maxim Levitsky geschrieben: > > Now you can specify which slot to put the encryption key to > > Plus add 'active' option which will let user erase the key secret > > instead of adding it. > > Check that active=true i

Re: [PATCH v2] ivshmem-server: Terminate also on SIGINT

2019-11-08 Thread Jan Kiszka
On 03.08.19 15:22, Jan Kiszka wrote: From: Jan Kiszka Allows to shutdown a foreground session via ctrl-c. Signed-off-by: Jan Kiszka --- Changes in v2: - adjust error message contrib/ivshmem-server/main.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/contrib/i

[PATCH v2 1/2] qapi: add filter-node-name option to drive-mirror

2019-11-08 Thread Vladimir Sementsov-Ogievskiy
To correspond to blockdev-mirror command and make it possible to deprecate implicit filters in the next commit. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 7 +++ blockdev.c | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/qapi/block-

[PATCH v2 0/2] Deprecate implicit filters

2019-11-08 Thread Vladimir Sementsov-Ogievskiy
v2: Don't deprecate drive-backup, it is unrelated thing and will be resent in separate. Don't deprecate drive-mirror. Instead add filter-node-name to drive-mirror to behave like blockdev-mirror Fix all broken iotests. Vladimir Sementsov-Ogievskiy (2): qapi: add filter-node-name option to drive-m

[PATCH v2 2/2] qapi: deprecate implicit filters

2019-11-08 Thread Vladimir Sementsov-Ogievskiy
To get rid of implicit filters related workarounds in future let's deprecate them now. Deprecation warning breaks some bash iotests output, so fix it here too: in most of cases just add filter-node-name in test. In 161 add FIXME and deprecation warning into 161.out. In 249, the test case is chan

Re: [PATCH 0/3] Some memory leak fixes

2019-11-08 Thread Laurent Vivier
On 08/11/2019 10:57, Thomas Huth wrote: > On 07/11/2019 22.57, no-re...@patchew.org wrote: >> Patchew URL: >> https://patchew.org/QEMU/20191107192731.17330-1-marcandre.lur...@redhat.com/ >> >> >> Hi, >> >> This series failed the docker-quick@centos7 build test. Please find >> the testing commands a

Re: [PATCH 3/3] docs: install CSS and Javascript files for HTML docs

2019-11-08 Thread Daniel P . Berrangé
On Fri, Nov 08, 2019 at 10:59:42AM +0100, Stefan Hajnoczi wrote: > Install the sphinx CSS/Javascript support files needed by the HTML > documentation. The documentation looks ugly without this. > > The previous patch switched to only invoking sphinx once so there is > only one _static/ directory

Re: [PATCH 1/3] docs: fix rst syntax errors in unbuilt docs

2019-11-08 Thread Daniel P . Berrangé
On Fri, Nov 08, 2019 at 10:59:40AM +0100, Stefan Hajnoczi wrote: > The .rst files outside docs/{devel,interop,specs} aren't built yet and > therefore a few syntax errors have slipped through. Fix them. > > Signed-off-by: Stefan Hajnoczi > --- > docs/arm-cpu-features.rst| 6 +++--- > docs/v

Re: [PATCH 2/3] docs: build a global index page

2019-11-08 Thread Daniel P . Berrangé
On Fri, Nov 08, 2019 at 10:59:41AM +0100, Stefan Hajnoczi wrote: > Build docs/ in a single sphinx invocation instead of treating > docs/{devel,interop,specs} separately. This allows us to build a global > index page that links to documentation across the different manuals. > > Some documentation

Re: [PULL 0/1] Seabios 20191106 patches

2019-11-08 Thread Gerd Hoffmann
On Thu, Nov 07, 2019 at 11:56:03AM +, Peter Maydell wrote: > On Wed, 6 Nov 2019 at 12:26, Gerd Hoffmann wrote: > > > > The following changes since commit 36609b4fa36f0ac934874371874416f7533a5408: > > > > Merge remote-tracking branch > > 'remotes/palmer/tags/palmer-for-master-4.2-sf1' into s

[PULL 0/1] Seabios 20191108 patches

2019-11-08 Thread Gerd Hoffmann
The following changes since commit 59015778f3ec7c01202d46c5dbeeac8ab4225c52: Update version for v4.2.0-rc0 release (2019-11-07 18:17:31 +) are available in the Git repository at: git://git.kraxel.org/qemu tags/seabios-20191108-pull-request for you to fetch changes up to

Re: Should QEMU's configure script check for bzip2 ?

2019-11-08 Thread Philippe Mathieu-Daudé
On 11/8/19 10:48 AM, Daniel P. Berrangé wrote: On Thu, Nov 07, 2019 at 08:43:27PM +0100, Thomas Huth wrote: Hi, I just tried to compile QEMU on a freshly installed system. "configure" finished without problems, but during "make" I hit this error: BUNZIP2 pc-bios/edk2-i386-secure-code.fd.

[PATCH] configure: Check bzip2 is available

2019-11-08 Thread Philippe Mathieu-Daudé
The bzip2 tool is not included in default installations. On freshly installed systems, ./configure succeeds but 'make' might fail later: BUNZIP2 pc-bios/edk2-i386-secure-code.fd.bz2 /bin/sh: bzip2: command not found make: *** [Makefile:305: pc-bios/edk2-i386-secure-code.fd] Error 127 mak

Re: [PATCH] configure: Check bzip2 is available

2019-11-08 Thread Daniel P . Berrangé
On Fri, Nov 08, 2019 at 11:28:05AM +0100, Philippe Mathieu-Daudé wrote: > The bzip2 tool is not included in default installations. > On freshly installed systems, ./configure succeeds but 'make' > might fail later: > > BUNZIP2 pc-bios/edk2-i386-secure-code.fd.bz2 > /bin/sh: bzip2: command no

Re: [PATCH] configure: Check bzip2 is available

2019-11-08 Thread Thomas Huth
On 08/11/2019 11.28, Philippe Mathieu-Daudé wrote: The bzip2 tool is not included in default installations. On freshly installed systems, ./configure succeeds but 'make' might fail later: BUNZIP2 pc-bios/edk2-i386-secure-code.fd.bz2 /bin/sh: bzip2: command not found make: *** [Makefil

Re: [PATCH v2 07/11] block: add x-blockdev-amend qmp command

2019-11-08 Thread Max Reitz
On 08.11.19 10:26, Maxim Levitsky wrote: > On Fri, 2019-10-04 at 20:53 +0200, Max Reitz wrote: >> On 13.09.19 00:30, Maxim Levitsky wrote: >>> Signed-off-by: Maxim Levitsky >>> --- >>> block/Makefile.objs | 2 +- >>> block/amend.c | 116 ++ >

Re: [PATCH] configure: Check bzip2 is available

2019-11-08 Thread Philippe Mathieu-Daudé
On 11/8/19 11:34 AM, Thomas Huth wrote: On 08/11/2019 11.28, Philippe Mathieu-Daudé wrote: The bzip2 tool is not included in default installations. On freshly installed systems, ./configure succeeds but 'make' might fail later: BUNZIP2 pc-bios/edk2-i386-secure-code.fd.bz2    /bin/sh: bzip2

[PATCH] tests/migration: Print some debug on bad status

2019-11-08 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" We're seeing occasional asserts in 'wait_for_migraiton_fail', that I can't reliably reproduce, and where the cores don't have any useful state. Print the 'status' out, so we can see which unexpected state we're ending up in. Signed-off-by: Dr. David Alan Gilbert

Re: [qemu-web PATCH] documentation: link to nightly documentation

2019-11-08 Thread Thomas Huth
On 08/11/2019 11.05, Stefan Hajnoczi wrote: Link to the documentation built from qemu.git/master once a day. Signed-off-by: Stefan Hajnoczi --- This depends on qemu.git "[PATCH 0/3] docs: build an index page for the HTML docs". We need that in order to build index.html. documentation.md | 2

Re: [PATCH v2 02/11] qcrypto-luks: extend the create options for upcoming encryption key management

2019-11-08 Thread Max Reitz
On 08.11.19 10:28, Maxim Levitsky wrote: > On Fri, 2019-10-04 at 19:42 +0200, Max Reitz wrote: >> On 13.09.19 00:30, Maxim Levitsky wrote: >>> Now you can specify which slot to put the encryption key to >>> Plus add 'active' option which will let user erase the key secret >>> instead of adding it.

Re: [PATCH v2 05/11] block/crypto: implement the encryption key management

2019-11-08 Thread Max Reitz
On 08.11.19 10:30, Maxim Levitsky wrote: > On Fri, 2019-10-04 at 20:41 +0200, Max Reitz wrote: >> On 13.09.19 00:30, Maxim Levitsky wrote: >>> This implements the encryption key management >>> using the generic code in qcrypto layer >>> (currently only for qemu-img amend) >>> >>> This code adds ano

Re: [PATCH 2/3] docs: build a global index page

2019-11-08 Thread Peter Maydell
On Fri, 8 Nov 2019 at 09:59, Stefan Hajnoczi wrote: > > Build docs/ in a single sphinx invocation instead of treating > docs/{devel,interop,specs} separately. This allows us to build a global > index page that links to documentation across the different manuals. > > Some documentation is built ou

[qemu-web PATCH v2] documentation: link to nightly documentation

2019-11-08 Thread Stefan Hajnoczi
Link to the documentation built from qemu.git/master once a day. Signed-off-by: Stefan Hajnoczi --- v2: * Use a qemu.org URL, not a wiki.qemu.org URL [danpb] --- documentation.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/documentation.md b/documentation.md index f4ef9f4..662750c 100

[qemu-web PATCH v3] documentation: link to nightly documentation

2019-11-08 Thread Stefan Hajnoczi
Link to the documentation built from qemu.git/master once a day. Signed-off-by: Stefan Hajnoczi --- v3: * Use a qemu.org URL, not a wiki.qemu.org URL [danpb] v2: * This revision was broken - please ignore! :) --- documentation.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/documentat

Re: [PATCH 3/3] cpu-plug-test: fix leaks

2019-11-08 Thread Thomas Huth
On 07/11/2019 20.27, Marc-André Lureau wrote: Spotted by ASAN. Signed-off-by: Marc-André Lureau --- tests/cpu-plug-test.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/cpu-plug-test.c b/tests/cpu-plug-test.c index 058cef5ac1..30e514bbfb 100644 --- a/tests/cpu-plug-test.c +++ b/

Re: [PATCH 3/3] docs: install CSS and Javascript files for HTML docs

2019-11-08 Thread Peter Maydell
On Fri, 8 Nov 2019 at 10:00, Stefan Hajnoczi wrote: > > Install the sphinx CSS/Javascript support files needed by the HTML > documentation. The documentation looks ugly without this. > > The previous patch switched to only invoking sphinx once so there is > only one _static/ directory that needs

Re: [qemu-web PATCH v3] documentation: link to nightly documentation

2019-11-08 Thread Daniel P . Berrangé
On Fri, Nov 08, 2019 at 11:54:35AM +0100, Stefan Hajnoczi wrote: > Link to the documentation built from qemu.git/master once a day. > > Signed-off-by: Stefan Hajnoczi > --- > v3: > * Use a qemu.org URL, not a wiki.qemu.org URL [danpb] > v2: > * This revision was broken - please ignore! :) > ---

Re: [PATCH] configure: Check bzip2 is available

2019-11-08 Thread Laszlo Ersek
On 11/08/19 11:28, Philippe Mathieu-Daudé wrote: > The bzip2 tool is not included in default installations. > On freshly installed systems, ./configure succeeds but 'make' > might fail later: > > BUNZIP2 pc-bios/edk2-i386-secure-code.fd.bz2 > /bin/sh: bzip2: command not found > make: *** [

Re: [PATCH v2 05/11] block/crypto: implement the encryption key management

2019-11-08 Thread Maxim Levitsky
On Fri, 2019-11-08 at 11:49 +0100, Max Reitz wrote: > On 08.11.19 10:30, Maxim Levitsky wrote: > > On Fri, 2019-10-04 at 20:41 +0200, Max Reitz wrote: > > > On 13.09.19 00:30, Maxim Levitsky wrote: > > > > This implements the encryption key management > > > > using the generic code in qcrypto layer

Re: [PATCH] configure: Check bzip2 is available

2019-11-08 Thread Daniel P . Berrangé
On Fri, Nov 08, 2019 at 12:01:16PM +0100, Laszlo Ersek wrote: > On 11/08/19 11:28, Philippe Mathieu-Daudé wrote: > > The bzip2 tool is not included in default installations. > > On freshly installed systems, ./configure succeeds but 'make' > > might fail later: > > > > BUNZIP2 pc-bios/edk2-i38

[PATCH v1 2/2] s390x/cpumodel: Introduce "best" model variants

2019-11-08 Thread David Hildenbrand
For a specific CPU model, we have a lot of feature variability depending on - The microcode version of the HW - The hypervisor we're running on (LPAR vs. KVM vs. z/VM) - The hypervisor version we're running on - The KVM version - KVM module parameters (especially, "nested=1") - The accelerator Our

[PATCH v1 0/2] s390x/cpumodel: Introduce "best" model variants

2019-11-08 Thread David Hildenbrand
There was recently a discussion regarding CPU model versions. That concept does not fit s390x where we have a lot of feature variability. I proposed an alternative approach in [1], which might work for x86 as well (but I am not sure if x86 still can or wants to switch to that), and requires no real

[PATCH v1 1/2] s390x/cpumodels: Factor out CPU feature dependencies

2019-11-08 Thread David Hildenbrand
Currently we check "if bit X is set, bit Y is required". We want to perform "if bit Y is not set, bit X must also not be set" when creating CPU models that will pass all consistency checks. Signed-off-by: David Hildenbrand --- target/s390x/cpu_models.c | 115 +++--

Re: [PATCH v1 0/2] s390x/cpumodel: Introduce "best" model variants

2019-11-08 Thread Peter Maydell
On Fri, 8 Nov 2019 at 11:08, David Hildenbrand wrote: > > There was recently a discussion regarding CPU model versions. That concept > does not fit s390x where we have a lot of feature variability. I > proposed an alternative approach in [1], which might work for x86 as well > (but I am not sure i

Re: [RFC v4 PATCH 49/49] multi-process: add configure and usage information

2019-11-08 Thread Stefan Hajnoczi
On Thu, Nov 07, 2019 at 10:53:27AM -0500, Jag Raman wrote: > > > On 11/7/2019 9:39 AM, Daniel P. Berrangé wrote: > > On Thu, Nov 07, 2019 at 03:02:20PM +0100, Stefan Hajnoczi wrote: > > > On Thu, Oct 24, 2019 at 05:09:30AM -0400, Jagannathan Raman wrote: > > > > From: Elena Ufimtseva > > > > >

Re: [RFC v4 PATCH 49/49] multi-process: add configure and usage information

2019-11-08 Thread Stefan Hajnoczi
On Thu, Nov 07, 2019 at 09:33:45AM -0500, Michael S. Tsirkin wrote: > On Thu, Nov 07, 2019 at 03:02:20PM +0100, Stefan Hajnoczi wrote: > > This documentation suggests that QEMU spawns the remote processes. How > > do this work with unprivileged QEMU? Is there an additional step where > > QEMU dro

Re: [qemu-web PATCH] documentation: link to nightly documentation

2019-11-08 Thread Stefan Hajnoczi
On Fri, Nov 8, 2019 at 11:45 AM Thomas Huth wrote: > On 08/11/2019 11.05, Stefan Hajnoczi wrote: > > Link to the documentation built from qemu.git/master once a day. > > > > Signed-off-by: Stefan Hajnoczi > > --- > > This depends on qemu.git "[PATCH 0/3] docs: build an index page for the > > HTML

Re: [PATCH] iotests: Fix "no qualified output" error path

2019-11-08 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191108085713.27551-1-kw...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!

Re: [RFC v4 PATCH 49/49] multi-process: add configure and usage information

2019-11-08 Thread Daniel P . Berrangé
On Fri, Nov 08, 2019 at 12:17:41PM +0100, Stefan Hajnoczi wrote: > On Thu, Nov 07, 2019 at 09:33:45AM -0500, Michael S. Tsirkin wrote: > > On Thu, Nov 07, 2019 at 03:02:20PM +0100, Stefan Hajnoczi wrote: > > > This documentation suggests that QEMU spawns the remote processes. How > > > do this wor

Re: [PATCH 2/3] docs: build a global index page

2019-11-08 Thread Stefan Hajnoczi
On Fri, Nov 8, 2019 at 11:52 AM Peter Maydell wrote: > On Fri, 8 Nov 2019 at 09:59, Stefan Hajnoczi wrote: > > Build docs/ in a single sphinx invocation instead of treating > > docs/{devel,interop,specs} separately. This allows us to build a global > > index page that links to documentation acro

Re: [PATCH] configure: Check bzip2 is available

2019-11-08 Thread Laszlo Ersek
On 11/08/19 11:42, Philippe Mathieu-Daudé wrote: > On 11/8/19 11:34 AM, Thomas Huth wrote: >> On 08/11/2019 11.28, Philippe Mathieu-Daudé wrote: >>> The bzip2 tool is not included in default installations. >>> On freshly installed systems, ./configure succeeds but 'make' >>> might fail later: >>> >

Re: [PATCH v15 06/12] numa: Extend CLI to provide memory latency and bandwidth information

2019-11-08 Thread Igor Mammedov
On Thu, 7 Nov 2019 15:45:05 +0800 Tao Xu wrote: > From: Liu Jingqi > > Add -numa hmat-lb option to provide System Locality Latency and > Bandwidth Information. These memory attributes help to build > System Locality Latency and Bandwidth Information Structure(s) > in ACPI Heterogeneous Memory

[PATCH v2 0/2] configure: Only decompress EDK2 blobs and check for bzip2 for X86/ARM

2019-11-08 Thread Philippe Mathieu-Daudé
This series fixes a bug reported by Thomas: bzip2 is (only) required to decompress the EDK2 blobs, which target the ARM/X86 archs. First restrict the blobs decompression to their targets (we don't need to decompress them when not building X86/ARM). Then check bzip2 is available. Philippe Mathieu

[PATCH v2 2/2] configure: Check bzip2 is available

2019-11-08 Thread Philippe Mathieu-Daudé
The bzip2 tool is not included in default installations. On freshly installed systems, ./configure succeeds but 'make' might fail later: BUNZIP2 pc-bios/edk2-i386-secure-code.fd.bz2 /bin/sh: bzip2: command not found make: *** [Makefile:305: pc-bios/edk2-i386-secure-code.fd] Error 127 mak

[PATCH v2 1/2] configure: Only decompress EDK2 blobs for X86/ARM targets

2019-11-08 Thread Philippe Mathieu-Daudé
The EDK2 firmware blobs only target the X86/ARM architectures. Define the DECOMPRESS_EDK2_BLOBS variable and only decompress the blobs when the variable exists. Fixes: 536d2173b2b Suggested-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- v2: new --- Makefile | 2 ++ configure | 13 +

Re: [PATCH v2 1/2] configure: Only decompress EDK2 blobs for X86/ARM targets

2019-11-08 Thread Daniel P . Berrangé
On Fri, Nov 08, 2019 at 12:45:30PM +0100, Philippe Mathieu-Daudé wrote: > The EDK2 firmware blobs only target the X86/ARM architectures. > Define the DECOMPRESS_EDK2_BLOBS variable and only decompress > the blobs when the variable exists. > > Fixes: 536d2173b2b > Suggested-by: Thomas Huth > Signe

Re: [PATCH v2 02/11] qcrypto-luks: extend the create options for upcoming encryption key management

2019-11-08 Thread Maxim Levitsky
On Fri, 2019-11-08 at 11:48 +0100, Max Reitz wrote: > On 08.11.19 10:28, Maxim Levitsky wrote: > > On Fri, 2019-10-04 at 19:42 +0200, Max Reitz wrote: > > > On 13.09.19 00:30, Maxim Levitsky wrote: > > > > Now you can specify which slot to put the encryption key to > > > > Plus add 'active' option

Re: [PATCH v2 2/2] configure: Check bzip2 is available

2019-11-08 Thread Daniel P . Berrangé
On Fri, Nov 08, 2019 at 12:45:31PM +0100, Philippe Mathieu-Daudé wrote: > The bzip2 tool is not included in default installations. > On freshly installed systems, ./configure succeeds but 'make' > might fail later: > > BUNZIP2 pc-bios/edk2-i386-secure-code.fd.bz2 > /bin/sh: bzip2: command no

Re: [PATCH v2 1/2] configure: Only decompress EDK2 blobs for X86/ARM targets

2019-11-08 Thread Philippe Mathieu-Daudé
On 11/8/19 12:45 PM, Philippe Mathieu-Daudé wrote: The EDK2 firmware blobs only target the X86/ARM architectures. Define the DECOMPRESS_EDK2_BLOBS variable and only decompress the blobs when the variable exists. Fixes: 536d2173b2b Suggested-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé

Re: [PATCH] tests/migration: Print some debug on bad status

2019-11-08 Thread Thomas Huth
On 08/11/2019 11.43, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" We're seeing occasional asserts in 'wait_for_migraiton_fail', that I can't reliably reproduce, and where the cores don't have any useful state. Print the 'status' out, so we can see which unexpected state w

Re: [PATCH] configure: Check bzip2 is available

2019-11-08 Thread Philippe Mathieu-Daudé
On 11/8/19 12:01 PM, Laszlo Ersek wrote: On 11/08/19 11:28, Philippe Mathieu-Daudé wrote: The bzip2 tool is not included in default installations. On freshly installed systems, ./configure succeeds but 'make' might fail later: BUNZIP2 pc-bios/edk2-i386-secure-code.fd.bz2 /bin/sh: bzip2:

Re: [PATCH] configure: Check bzip2 is available

2019-11-08 Thread Thomas Huth
On 08/11/2019 12.54, Philippe Mathieu-Daudé wrote: On 11/8/19 12:01 PM, Laszlo Ersek wrote: On 11/08/19 11:28, Philippe Mathieu-Daudé wrote: The bzip2 tool is not included in default installations. On freshly installed systems, ./configure succeeds but 'make' might fail later: BUNZIP2 pc-

Re: [PATCH 2/3] docs: build a global index page

2019-11-08 Thread Peter Maydell
On Fri, 8 Nov 2019 at 11:39, Stefan Hajnoczi wrote: > > On Fri, Nov 8, 2019 at 11:52 AM Peter Maydell > wrote: > > So the reason I went for the odd "run sphinx multiple times" > > approach was because we don't want to ship 'devel' to users, > > and as far as I could tell there was no way to have

Re: [PATCH] configure: Check bzip2 is available

2019-11-08 Thread Philippe Mathieu-Daudé
On 11/8/19 12:39 PM, Laszlo Ersek wrote: On 11/08/19 11:42, Philippe Mathieu-Daudé wrote: On 11/8/19 11:34 AM, Thomas Huth wrote: On 08/11/2019 11.28, Philippe Mathieu-Daudé wrote: The bzip2 tool is not included in default installations. On freshly installed systems, ./configure succeeds but '

Re: [PATCH v2 0/2] Deprecate implicit filters

2019-11-08 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191108101655.10611-1-vsement...@virtuozzo.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGI

Re: [PATCH] tests/migration: Print some debug on bad status

2019-11-08 Thread Philippe Mathieu-Daudé
On 11/8/19 11:43 AM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" We're seeing occasional asserts in 'wait_for_migraiton_fail', that I can't reliably reproduce, and where the cores don't have any useful state. Print the 'status' out, so we can see which unexpected state w

Re: [PATCH] configure: Check bzip2 is available

2019-11-08 Thread Thomas Huth
On 08/11/2019 12.39, Laszlo Ersek wrote: On 11/08/19 11:42, Philippe Mathieu-Daudé wrote: On 11/8/19 11:34 AM, Thomas Huth wrote: On 08/11/2019 11.28, Philippe Mathieu-Daudé wrote: The bzip2 tool is not included in default installations. On freshly installed systems, ./configure succeeds but '

  1   2   3   >