Re: [PATCH for-4.2 v2 0/3] qcow2: Fix data corruption on XFS

2019-11-04 Thread Max Reitz
On 01.11.19 16:48, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20191101152510.11719-1-mre...@redhat.com/ > > > > Hi, > > This series failed the docker-quick@centos7 build test. Please find the > testing commands and > their output below. If you have Docker installed,

Re: [Qemu-devel] [PATCH 16/16] nvme: support multiple namespaces

2019-11-04 Thread Ross Lagerwall
On 8/23/19 9:10 AM, Klaus Birkelund wrote: > On Thu, Aug 22, 2019 at 02:18:05PM +0100, Ross Lagerwall wrote: >> On 7/5/19 8:23 AM, Klaus Birkelund Jensen wrote: >> >> I tried this patch series by installing Windows with a single NVME >> controller having two namespaces. QEMU crashed in get_feature

Re: [PATCH v2] q800: fix I/O memory map

2019-11-04 Thread Laurent Vivier
Le 03/11/2019 à 23:30, Philippe Mathieu-Daudé a écrit : > On 11/2/19 10:42 PM, Laurent Vivier wrote: >> Linux kernel 5.4 will introduce a new memory map for SWIM device. >> (aee6bff1c325 ("m68k: mac: Revisit floppy disc controller base >> addresses")) >> >> Until this release all MMIO are mapped be

[PULL 0/5] Block patches for 4.2-rc0

2019-11-04 Thread Max Reitz
The following changes since commit 36609b4fa36f0ac934874371874416f7533a5408: Merge remote-tracking branch 'remotes/palmer/tags/palmer-for-master-4.2-sf1' into staging (2019-11-02 17:59:03 +) are available in the Git repository at: https://github.com/XanClic/qemu.git tags/pull-block-2019

[PULL 3/5] block: Make wait/mark serialising requests public

2019-11-04 Thread Max Reitz
Make both bdrv_mark_request_serialising() and bdrv_wait_serialising_requests() public so they can be used from block drivers. Cc: qemu-sta...@nongnu.org Signed-off-by: Max Reitz Message-id: 20191101152510.11719-2-mre...@redhat.com Signed-off-by: Max Reitz --- include/block/block_int.h | 3 +++

[PULL 4/5] block: Add bdrv_co_get_self_request()

2019-11-04 Thread Max Reitz
Cc: qemu-sta...@nongnu.org Signed-off-by: Max Reitz Message-id: 20191101152510.11719-3-mre...@redhat.com Signed-off-by: Max Reitz --- include/block/block_int.h | 1 + block/io.c| 18 ++ 2 files changed, 19 insertions(+) diff --git a/include/block/block_int.h b/i

[PULL 2/5] block/block-copy: fix s->copy_size for compressed cluster

2019-11-04 Thread Max Reitz
From: Vladimir Sementsov-Ogievskiy 0e2402452f1f20429 allowed writes larger than cluster, but that's unsupported for compressed write. Fix it. Fixes: 0e2402452f1f20429 Signed-off-by: Vladimir Sementsov-Ogievskiy Message-id: 20191029150934.26416-1-vsement...@virtuozzo.com Signed-off-by: Max Reitz

[PULL 1/5] nvme: fix NSSRS offset in CAP register

2019-11-04 Thread Max Reitz
From: Klaus Jensen Fix the offset of the NSSRS field the CAP register. >From NVME 1.4, section 3 ("Controller Registers"), subsection 3.1.1 ("Offset 0h: CAP – Controller Capabilities") CAP_NSSRS_SHIFT is bit 36, not 33. Signed-off-by: Klaus Jensen Reported-by: Javier Gonzalez Message-id: 2019

[PULL 5/5] block/file-posix: Let post-EOF fallocate serialize

2019-11-04 Thread Max Reitz
The XFS kernel driver has a bug that may cause data corruption for qcow2 images as of qemu commit c8bb23cbdbe32f. We can work around it by treating post-EOF fallocates as serializing up until infinity (INT64_MAX in practice). Cc: qemu-sta...@nongnu.org Signed-off-by: Max Reitz Message-id: 201911

Re: [Qemu-devel] [PATCH 16/16] nvme: support multiple namespaces

2019-11-04 Thread Klaus Birkelund
On Mon, Nov 04, 2019 at 08:46:29AM +, Ross Lagerwall wrote: > On 8/23/19 9:10 AM, Klaus Birkelund wrote: > > On Thu, Aug 22, 2019 at 02:18:05PM +0100, Ross Lagerwall wrote: > >> On 7/5/19 8:23 AM, Klaus Birkelund Jensen wrote: > >> > >> I tried this patch series by installing Windows with a sin

Re: [PATCH for-4.2 v2 0/3] qcow2: Fix data corruption on XFS

2019-11-04 Thread Max Reitz
On 01.11.19 16:25, Max Reitz wrote: > Hi, > > As I reasoned here: > https://lists.nongnu.org/archive/html/qemu-block/2019-11/msg00027.html > I’m no longer convinced of reverting c8bb23cbdbe. I could see a > significant performance improvement from it on ext4 with aio=native in a > guest that does

Re: [Qemu-devel] [PATCH 16/16] nvme: support multiple namespaces

2019-11-04 Thread Ross Lagerwall
On 11/4/19 9:04 AM, Klaus Birkelund wrote: > On Mon, Nov 04, 2019 at 08:46:29AM +, Ross Lagerwall wrote: >> On 8/23/19 9:10 AM, Klaus Birkelund wrote: >>> On Thu, Aug 22, 2019 at 02:18:05PM +0100, Ross Lagerwall wrote: On 7/5/19 8:23 AM, Klaus Birkelund Jensen wrote: I tried this

Re: Sparc Solaris 10

2019-11-04 Thread Artyom Tarasenko
On Sun, Nov 3, 2019 at 10:01 PM Mark Cave-Ayland wrote: > > On 02/11/2019 19:56, Philippe Mathieu-Daudé wrote: > > > Cc'ing the SPARC maintainers. > > > > On 11/1/19 4:49 AM, Zainuddin AR wrote: > >> Hi, > >> > >> I like to find to find out if you have a working qemu on solaris 10 or 11. > >> I h

Re: [PATCH for-4.2 v2 0/3] qcow2: Fix data corruption on XFS

2019-11-04 Thread Stefan Hajnoczi
On Fri, Nov 01, 2019 at 04:25:07PM +0100, Max Reitz wrote: > Hi, > > As I reasoned here: > https://lists.nongnu.org/archive/html/qemu-block/2019-11/msg00027.html > I’m no longer convinced of reverting c8bb23cbdbe. I could see a > significant performance improvement from it on ext4 with aio=native

[PATCH] Makefile: Fix config-devices.mak not regenerated when Kconfig updated

2019-11-04 Thread Philippe Mathieu-Daudé
When hw/$DIR/Kconfig is changed, the corresponding generated hw/$DIR/config-devices.mak is not being updated. Fix this by including all the hw/*/Kconfig files to the prerequisite names of the rule generating the config-devices.mak files. Fixes: e0e312f3525a (build: switch to Kconfig) Reported-by:

Re: Wiki account

2019-11-04 Thread Daniel P . Berrangé
On Sun, Nov 03, 2019 at 11:27:33AM +0100, Esteban Bosse wrote: > Hello, > I would like to have an wiki account. > > Preferred user: estebanb I've created this account and sent password details off-list. Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberran

Re: [PATCH 3/3] dp8393x: fix receiving buffer exhaustion

2019-11-04 Thread Laurent Vivier
Le 02/11/2019 à 18:15, Laurent Vivier a écrit : > The card is not able to exit from exhaustion state, because > while the drive consumes the buffers, the RRP is incremented > (when the driver clears the ISR RBE bit), so it stays equal > to RWP, and while RRP == RWP, the card thinks it is always > i

[PATCH v3] q800: fix I/O memory map

2019-11-04 Thread Laurent Vivier
Linux kernel 5.4 will introduce a new memory map for SWIM device. (aee6bff1c325 ("m68k: mac: Revisit floppy disc controller base addresses")) Until this release all MMIO are mapped between 0x50f0 and 0x50f4, but it appears that for real hardware 0x50f0 is not the base address: the MMIO

Re: RFC: New device for zero-copy VM memory access

2019-11-04 Thread Gerd Hoffmann
Hi, > This new device, currently named `introspection` (which needs a more > suitable name, porthole perhaps?), provides a means of translating > guest physical addresses to host virtual addresses, and finally to the > host offsets in RAM for file-backed memory guests. It does this by > means of

Re: RFC: New device for zero-copy VM memory access

2019-11-04 Thread geoff
On 2019-11-04 21:26, Gerd Hoffmann wrote: Hi, This new device, currently named `introspection` (which needs a more suitable name, porthole perhaps?), provides a means of translating guest physical addresses to host virtual addresses, and finally to the host offsets in RAM for file-backed mem

Re: [PATCH v2 00/15] io_uring: add Linux io_uring AIO engine

2019-11-04 Thread Stefan Hajnoczi
On Fri, Oct 25, 2019 at 06:04:29PM +0200, Stefan Hajnoczi wrote: > v11: > * Drop fd registration because it breaks QEMU's file locking and will need to >be resolved in a separate patch series > * Drop line-wrapping changes that accidentally broke several qemu-iotests > > v10: > * Dropped ke

Re: Wiki account

2019-11-04 Thread Esteban Bosse
Thank you very much :) Estebanb El lun., 4 nov. 2019 11:10, Daniel P. Berrangé escribió: > On Sun, Nov 03, 2019 at 11:27:33AM +0100, Esteban Bosse wrote: > > Hello, > > I would like to have an wiki account. > > > > Preferred user: estebanb > > I've created this account and sent password details

Re: bitmaps -- copying allocation status into dirty bitmaps

2019-11-04 Thread Max Reitz
On 01.11.19 16:42, John Snow wrote: > Hi, in one of my infamously unreadable and long status emails, I > mentioned possibly wanting to copy allocation data into bitmaps as a way > to enable users to create (external) snapshots from outside of the > libvirt/qemu context. > > (That is: to repair che

Re: bitmaps -- copying allocation status into dirty bitmaps

2019-11-04 Thread Max Reitz
On 04.11.19 12:21, Max Reitz wrote: > On 01.11.19 16:42, John Snow wrote: >> Hi, in one of my infamously unreadable and long status emails, I >> mentioned possibly wanting to copy allocation data into bitmaps as a way >> to enable users to create (external) snapshots from outside of the >> libvirt/

Re: Feature Recommendations?

2019-11-04 Thread Alex Bennée
Dinah A Baum writes: > Hello all, > > I am a university student whose Virtualization course has tasked me with > contributing to an open source, virtualization related project. I have a > little more than a month to complete this. I was wondering if you could > recommend a feature you'd like ad

[Bug 1847793] Re: qemu 4.1.0 - Corrupt guest filesystem after new vm install

2019-11-04 Thread Wayne
Which filesystems does this apply to? Excludes ZFS? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1847793 Title: qemu 4.1.0 - Corrupt guest filesystem after new vm install Status in QEMU: New B

Re: RFC: New device for zero-copy VM memory access

2019-11-04 Thread Dr. David Alan Gilbert
* ge...@hostfission.com (ge...@hostfission.com) wrote: > > > On 2019-11-03 21:10, ge...@hostfission.com wrote: > > On 2019-11-01 02:52, Dr. David Alan Gilbert wrote: > > > * ge...@hostfission.com (ge...@hostfission.com) wrote: > > > > > > > > > > > > On 2019-11-01 01:52, Peter Maydell wrote: >

Re: [PATCH v5 08/13] hw/core: deprecate old reset functions and introduce new ones

2019-11-04 Thread Damien Hedde
On 11/1/19 12:35 AM, Philippe Mathieu-Daudé wrote: > On 10/18/19 5:06 PM, Damien Hedde wrote: >> Deprecate device_legacy_reset(), qdev_reset_all() and >> qbus_reset_all() to be replaced by new functions >> device_cold_reset() and bus_cold_reset() which uses resettable API. >> >> Also introduce r

Re: RFC: New device for zero-copy VM memory access

2019-11-04 Thread geoff
On 2019-11-04 22:55, Dr. David Alan Gilbert wrote: * ge...@hostfission.com (ge...@hostfission.com) wrote: On 2019-11-03 21:10, ge...@hostfission.com wrote: > On 2019-11-01 02:52, Dr. David Alan Gilbert wrote: > > * ge...@hostfission.com (ge...@hostfission.com) wrote: > > > > > > > > > On 20

Re: logfile issue

2019-11-04 Thread Alex Bennée
Robert Foley writes: > We hit an issue when trying to change the log file from the monitor > console. The root of the issue here is that the qemu_logfile handle > is not thread safe. So when we try to close the file, we end up with > a seg fault. The full analysis is below along with some po

Re: [PATCH v5 02/13] hw/core/qdev: add trace events to help with resettable transition

2019-11-04 Thread Damien Hedde
On 11/1/19 12:23 AM, Philippe Mathieu-Daudé wrote: > On 10/18/19 5:06 PM, Damien Hedde wrote: >> Adds trace events to reset procedure and when updating the parent >> bus of a device. >> >> Signed-off-by: Damien Hedde >> --- >>   hw/core/qdev.c   | 27 --- >>   hw/core/

[PATCH v21 4/6] KVM: Move hwpoison page related functions into kvm-all.c

2019-11-04 Thread Xiang Zheng
From: Dongjiu Geng kvm_hwpoison_page_add() and kvm_unpoison_all() will both be used by X86 and ARM platforms, so moving them into "accel/kvm/kvm-all.c" to avoid duplicate code. For architectures that don't use the poison-list functionality the reset handler will harmlessly do nothing, so let's r

[PATCH v21 6/6] MAINTAINERS: Add APCI/APEI/GHES entries

2019-11-04 Thread Xiang Zheng
From: Dongjiu Geng I and Xiang are willing to review the APEI-related patches and volunteer as the reviewers for the APEI/GHES part. Signed-off-by: Dongjiu Geng Signed-off-by: Xiang Zheng --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS in

[PATCH v21 3/6] ACPI: Add APEI GHES table generation support

2019-11-04 Thread Xiang Zheng
From: Dongjiu Geng This patch implements APEI GHES Table generation via fw_cfg blobs. Now it only supports ARMv8 SEA, a type of GHESv2 error source. Afterwards, we can extend the supported types if needed. For the CPER section, currently it is memory section because kernel mainly wants userspace

[PATCH v21 5/6] target-arm: kvm64: handle SIGBUS signal from kernel or KVM

2019-11-04 Thread Xiang Zheng
From: Dongjiu Geng Add a SIGBUS signal handler. In this handler, it checks the SIGBUS type, translates the host VA delivered by host to guest PA, then fills this PA to guest APEI GHES memory, then notifies guest according to the SIGBUS type. When guest accesses the poisoned memory, it will gener

[PATCH v21 2/6] docs: APEI GHES generation and CPER record description

2019-11-04 Thread Xiang Zheng
From: Dongjiu Geng Add APEI/GHES detailed design document Signed-off-by: Dongjiu Geng Signed-off-by: Xiang Zheng --- docs/specs/acpi_hest_ghes.rst | 95 +++ docs/specs/index.rst | 1 + 2 files changed, 96 insertions(+) create mode 100644 docs/specs/a

[PATCH v21 1/6] hw/arm/virt: Introduce a RAS machine option

2019-11-04 Thread Xiang Zheng
From: Dongjiu Geng RAS Virtualization feature is not supported now, so add a RAS machine option and disable it by default. Signed-off-by: Dongjiu Geng Signed-off-by: Xiang Zheng --- hw/arm/virt.c | 23 +++ include/hw/arm/virt.h | 1 + 2 files changed, 24 insertion

[PATCH v21 0/6] Add ARMv8 RAS virtualization support in QEMU

2019-11-04 Thread Xiang Zheng
In the ARMv8 platform, the CPU error types are synchronous external abort(SEA) and SError Interrupt (SEI). If exception happens in guest, sometimes it's better for guest to perform the recovery, because host does not know the detailed information of guest. For example, if an exception happens in a

Re: [RFC PATCH v2 11/26] qcow2: Add qcow2_get_subcluster_type()

2019-11-04 Thread Max Reitz
On 26.10.19 23:25, Alberto Garcia wrote: > This function returns the type of an individual subcluster. If an > image does not have subclusters then this returns the exact same value > as qcow2_get_cluster_type(). > > The information in standard and extended L2 entries is encoded in a > slightly di

Re: [PATCH v21 0/6] Add ARMv8 RAS virtualization support in QEMU

2019-11-04 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191104121458.29208-1-zhengxia...@huawei.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

[Bug 1846427] Re: 4.1.0: qcow2 corruption on savevm/quit/loadvm cycle

2019-11-04 Thread Laszlo Ersek (Red Hat)
My understanding is that Kevin has fixed this bug in (as yet unreleased) commit 5e9785505210 ("qcow2: Fix corruption bug in qcow2_detect_metadata_preallocation()", 2019-10-25). The patch had been posted as a part of the following sets: [PATCH 0/3] qcow2: Fix image corruption bug in 4.1 2019102315

Re: [RFC PATCH v2 12/26] qcow2: Handle QCOW2_CLUSTER_UNALLOCATED_SUBCLUSTER

2019-11-04 Thread Max Reitz
On 26.10.19 23:25, Alberto Garcia wrote: > In the previous patch we added a new QCow2ClusterType named > QCOW2_CLUSTER_UNALLOCATED_SUBCLUSTER. There is a couple of places > where this new value needs to be handled, and that is what this patch > does. > > Signed-off-by: Alberto Garcia > --- > blo

Re: [RFC PATCH v2 12/26] qcow2: Handle QCOW2_CLUSTER_UNALLOCATED_SUBCLUSTER

2019-11-04 Thread Alberto Garcia
On Mon 04 Nov 2019 01:57:42 PM CET, Max Reitz wrote: > On 26.10.19 23:25, Alberto Garcia wrote: >> In the previous patch we added a new QCow2ClusterType named >> QCOW2_CLUSTER_UNALLOCATED_SUBCLUSTER. There is a couple of places >> where this new value needs to be handled, and that is what this patc

Re: [PATCH] Makefile: install bios-microvm like other binary blobs

2019-11-04 Thread Sergio Lopez
Philippe Mathieu-Daudé writes: > From: Bruce Rogers > > Commit 0d5fae3e52e introduced bios-microvm.bin but forgot to add > it to the list of blobs being installed. > Add it to the list of BLOBS that get installed. > > Fixes: 0d5fae3e52e "roms: add microvm-bios (qboot) as binary" > Signed-off-b

Re: [RFC PATCH v2 12/26] qcow2: Handle QCOW2_CLUSTER_UNALLOCATED_SUBCLUSTER

2019-11-04 Thread Max Reitz
On 04.11.19 14:03, Alberto Garcia wrote: > On Mon 04 Nov 2019 01:57:42 PM CET, Max Reitz wrote: >> On 26.10.19 23:25, Alberto Garcia wrote: >>> In the previous patch we added a new QCow2ClusterType named >>> QCOW2_CLUSTER_UNALLOCATED_SUBCLUSTER. There is a couple of places >>> where this new value

[Bug 1851095] Re: [feature request] awareness of instructions that are well emulated

2019-11-04 Thread Laurent Desnogues
Can you please provide a binary (preferably statically built or with required shared libraries attached)? Thanks, Laurent -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1851095 Title: [feature req

[PATCH] tcg plugins: expose an API version concept

2019-11-04 Thread Alex Bennée
This is a very simple versioning API which allows the plugin infrastructure to check the API a plugin was built against. We also expose a min/cur API version to the plugin via the info block in case it wants to avoid using old deprecated APIs in the future. Signed-off-by: Alex Bennée --- include

[PATCH] qom: Fix error message in object_class_property_add()

2019-11-04 Thread Greg Kurz
The error message in object_class_property_add() was copied from object_property_add() in commit 16bf7f522a2ff. Clarify that it is about a class, not an object. While here, have the format string in both functions to fit in a single line for better grep-ability, despite the checkpatch warning. Si

[PATCH] pl031: Expose RTCICR as proper WC register

2019-11-04 Thread Alexander Graf
The current pl031 RTCICR register implementation always clears the IRQ pending status on a register write, regardless of the value it writes. To justify that behavior, it references the arm926e documentation (DDI0287B) and indicates that said document states that any write clears the internal IRQ

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-11-04 Thread Alberto Garcia
On Fri 25 Oct 2019 04:19:30 PM CEST, Max Reitz wrote: >>> So, it's obvious that c8bb23cbdbe32f5c326 is significant for 1M >>> cluster-size, even on rotational disk, which means that previous >>> assumption about calling handle_alloc_space() only for ssd is wrong, >>> we need smarter heuristics.. >>

Re: [PATCH] qom: Fix error message in object_class_property_add()

2019-11-04 Thread Laurent Vivier
Le 04/11/2019 à 14:23, Greg Kurz a écrit : > The error message in object_class_property_add() was copied from > object_property_add() in commit 16bf7f522a2ff. Clarify that it is > about a class, not an object. > > While here, have the format string in both functions to fit in a > single line for b

Re: [RFC PATCH v2 13/26] qcow2: Add subcluster support to calculate_l2_meta()

2019-11-04 Thread Max Reitz
On 26.10.19 23:25, Alberto Garcia wrote: > If an image has subclusters then there are more copy-on-write > scenarios that we need to consider. Let's say we have a write request > from the middle of subcluster #3 until the end of the cluster: > >- If the cluster is new, then subclusters #0 to #

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-11-04 Thread Max Reitz
On 04.11.19 15:03, Alberto Garcia wrote: > On Fri 25 Oct 2019 04:19:30 PM CEST, Max Reitz wrote: So, it's obvious that c8bb23cbdbe32f5c326 is significant for 1M cluster-size, even on rotational disk, which means that previous assumption about calling handle_alloc_space() only for ssd

Re: [PATCH v5 02/13] hw/core/qdev: add trace events to help with resettable transition

2019-11-04 Thread Philippe Mathieu-Daudé
On 11/4/19 1:16 PM, Damien Hedde wrote: On 11/1/19 12:23 AM, Philippe Mathieu-Daudé wrote: On 10/18/19 5:06 PM, Damien Hedde wrote: Adds trace events to reset procedure and when updating the parent bus of a device. Signed-off-by: Damien Hedde ---   hw/core/qdev.c   | 27 +

Re: [RFC PATCH v2 14/26] qcow2: Add subcluster support to qcow2_get_cluster_offset()

2019-11-04 Thread Max Reitz
On 26.10.19 23:25, Alberto Garcia wrote: > The logic of this function remains pretty much the same, except that > it uses count_contiguous_subclusters(), which combines the logic of > count_contiguous_clusters() / count_contiguous_clusters_unallocated() > and checks individual subclusters. > > Sig

Re: [RFC PATCH v2 11/26] qcow2: Add qcow2_get_subcluster_type()

2019-11-04 Thread Max Reitz
On 04.11.19 13:35, Max Reitz wrote: > On 26.10.19 23:25, Alberto Garcia wrote: >> This function returns the type of an individual subcluster. If an >> image does not have subclusters then this returns the exact same value >> as qcow2_get_cluster_type(). >> >> The information in standard and extende

Re: [RFC PATCH v2 15/26] qcow2: Add subcluster support to zero_in_l2_slice()

2019-11-04 Thread Max Reitz
On 26.10.19 23:25, Alberto Garcia wrote: > Setting the QCOW_OFLAG_ZERO bit of the L2 entry is forbidden if an > image has subclusters. Instead, the individual 'all zeroes' bits must > be used. > > Signed-off-by: Alberto Garcia > --- > block/qcow2-cluster.c | 14 ++ > 1 file changed,

Re: [RFC PATCH v2 16/26] qcow2: Add subcluster support to discard_in_l2_slice()

2019-11-04 Thread Max Reitz
On 26.10.19 23:25, Alberto Garcia wrote: > Setting the QCOW_OFLAG_ZERO bit of the L2 entry is forbidden if an > image has subclusters. Instead, the individual 'all zeroes' bits must > be used. > > Signed-off-by: Alberto Garcia > --- > block/qcow2-cluster.c | 6 +- > 1 file changed, 5 inserti

Re: [RFC PATCH v2 15/26] qcow2: Add subcluster support to zero_in_l2_slice()

2019-11-04 Thread Max Reitz
On 04.11.19 16:04, Max Reitz wrote: > On 26.10.19 23:25, Alberto Garcia wrote: >> Setting the QCOW_OFLAG_ZERO bit of the L2 entry is forbidden if an >> image has subclusters. Instead, the individual 'all zeroes' bits must >> be used. >> >> Signed-off-by: Alberto Garcia >> --- >> block/qcow2-clust

[PATCH] hw/arm/boot: Set NSACR.{CP11, CP10} in dummy SMC setup routine

2019-11-04 Thread Clement Deschamps
Set the NSACR CP11 and CP10 bits, to allow FPU access in Non-Secure state when using dummy SMC setup routine. Otherwise an AArch32 kernel will UNDEF as soon as it tries to use the FPU. This fixes kernel panic when booting raspbian on raspi2. Successfully tested with: 2017-01-11-raspbian-jessie-

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-11-04 Thread Alberto Garcia
On Mon 04 Nov 2019 03:25:12 PM CET, Max Reitz wrote: > So, it's obvious that c8bb23cbdbe32f5c326 is significant for 1M > cluster-size, even on rotational disk, which means that previous > assumption about calling handle_alloc_space() only for ssd is wrong, > we need smarter heuristi

[PATCH v7 0/8] Acceptance test: Add "boot_linux" acceptance test

2019-11-04 Thread Cleber Rosa
This acceptance test, validates that a full blown Linux guest can successfully boot in QEMU. In this specific case, the guest chosen is Fedora version 31. * x86_64, pc and q35 machine types, with and without kvm as an accellerator * aarch64 and virt machine type, with and without kvm as an

[PATCH v7 1/8] Acceptance test x86_cpu_model_versions: use default vm

2019-11-04 Thread Cleber Rosa
The default vm provided by the test, available as self.vm, serves the same purpose of the one obtained by self.get_vm(), but saves a line and matches the style of other tests. Signed-off-by: Cleber Rosa --- tests/acceptance/x86_cpu_model_versions.py | 100 ++--- 1 file changed, 4

[PATCH v7 3/8] Acceptance tests: use avocado tags for machine type

2019-11-04 Thread Cleber Rosa
The same way the arch tag is being used as a fallback for the arch parameter, let's do the same for QEMU's machine and avoid some boiler plate code. Signed-off-by: Cleber Rosa --- docs/devel/testing.rst | 18 tests/acceptance/avocado_qemu/__init__.py | 5 ++ tests/

[PATCH v7 2/8] Acceptance tests: introduce utility method for tags unique vals

2019-11-04 Thread Cleber Rosa
Currently a test can describe the target architecture binary that it should primarily be run with, be setting a single tag value. The same approach is expected to be done with other QEMU aspects to be tested, for instance, the machine type and accelerator, so let's generalize the logic into a util

[PATCH v7 5/8] Acceptance tests: keep a stable reference to the QEMU build dir

2019-11-04 Thread Cleber Rosa
This is related to the the differences in in-tree and out-of-tree builds in QEMU. For simplification, means my build directory. Currently, by running a `make check-acceptance` one gets (in tests/acceptance/avocado_qemu/__init__.py): SRC_ROOT_DIR: /tests/acceptance/avocado_qemu/../../.. This

[PATCH v7 4/8] Acceptance tests: use relative location for tests

2019-11-04 Thread Cleber Rosa
An Avocado Test ID[1] is composed by a number of components, but it starts with the Test Name, usually a file system location that was given to the loader. Because the source directory is being given as a prefix to the "tests/acceptance" directory containing the acceptance tests, the test names wi

[PATCH v7 6/8] Acceptance tests: add the build directory to the system PATH

2019-11-04 Thread Cleber Rosa
So that when binaries such as qemu-img are searched for, those in the build tree will be favored. As a clarification, SRC_ROOT_DIR is dependent on the location from where tests are executed, so they are equal to the build directory if one is being used. The original motivation is that Avocado lib

[PATCH v7 8/8] Acceptance test: add "boot_linux" tests

2019-11-04 Thread Cleber Rosa
This acceptance test, validates that a full blown Linux guest can successfully boot in QEMU. In this specific case, the guest chosen is Fedora version 31. * x86_64, pc and q35 machine types, with and without kvm as an accellerator * aarch64 and virt machine type, with and without kvm as an

[PATCH v7 7/8] Acceptance tests: depend on qemu-img

2019-11-04 Thread Cleber Rosa
Tests using the avocado.utils.vmimage library make use of qemu-img, and because it makes sense to use the version matching the rest of the source code, let's make sure it gets built. Its selection, instead of a possible qemu-img binary installed system wide, is already dealt with by the change tha

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-11-04 Thread Max Reitz
On 04.11.19 16:12, Alberto Garcia wrote: > On Mon 04 Nov 2019 03:25:12 PM CET, Max Reitz wrote: >> So, it's obvious that c8bb23cbdbe32f5c326 is significant for 1M >> cluster-size, even on rotational disk, which means that previous >> assumption about calling handle_alloc_space() only fo

Re: [PATCH v5 08/13] hw/core: deprecate old reset functions and introduce new ones

2019-11-04 Thread Philippe Mathieu-Daudé
On 11/4/19 1:01 PM, Damien Hedde wrote: On 11/1/19 12:35 AM, Philippe Mathieu-Daudé wrote: On 10/18/19 5:06 PM, Damien Hedde wrote: Deprecate device_legacy_reset(), qdev_reset_all() and qbus_reset_all() to be replaced by new functions device_cold_reset() and bus_cold_reset() which uses resettab

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-11-04 Thread Alberto Garcia
On Mon 04 Nov 2019 04:14:56 PM CET, Max Reitz wrote: >>> No, what I meant was that the original problem that led to >>> c8bb23cbdbe would go away. >> >> Ah, right. Not quite, according to my numbers: >> >> |--++-+-| >> | Cluster size | subc

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-11-04 Thread Max Reitz
On 04.11.19 16:49, Alberto Garcia wrote: > On Mon 04 Nov 2019 04:14:56 PM CET, Max Reitz wrote: > No, what I meant was that the original problem that led to c8bb23cbdbe would go away. >>> >>> Ah, right. Not quite, according to my numbers: >>> >>> |--++

Re: [PATCH] tcg plugins: expose an API version concept

2019-11-04 Thread Philippe Mathieu-Daudé
On 11/4/19 2:18 PM, Alex Bennée wrote: This is a very simple versioning API which allows the plugin infrastructure to check the API a plugin was built against. We also expose a min/cur API version to the plugin via the info block in case it wants to avoid using old deprecated APIs in the future.

Re: RFC: New device for zero-copy VM memory access

2019-11-04 Thread Dr. David Alan Gilbert
* ge...@hostfission.com (ge...@hostfission.com) wrote: > > > On 2019-11-04 22:55, Dr. David Alan Gilbert wrote: > > * ge...@hostfission.com (ge...@hostfission.com) wrote: > > > > > > > > > On 2019-11-03 21:10, ge...@hostfission.com wrote: > > > > On 2019-11-01 02:52, Dr. David Alan Gilbert wrot

Re: [PATCH v17 4/7] target/ppc: Build rtas error log upon an MCE

2019-11-04 Thread David Gibson
On Thu, Oct 24, 2019 at 01:13:04PM +0530, Ganesh Goudar wrote: > From: Aravinda Prasad > > Upon a machine check exception (MCE) in a guest address space, > KVM causes a guest exit to enable QEMU to build and pass the > error to the guest in the PAPR defined rtas error log format. > > This patch

Re: [PING] [PATCH 1/1] target/arm: Add support for cortex-m7 CPU

2019-11-04 Thread Christophe Lyon
ping? http://patchwork.ozlabs.org/patch/1183934/ On Fri, 25 Oct 2019 at 11:08, Christophe Lyon wrote: > > This is derived from cortex-m4 description, adding DP support and FPv5 > instructions with the corresponding flags in isar and mvfr2. > > Checked that it could successfully execute > vrinta.

Re: [RFC v2 14/22] vfio/pci: add iommu_context notifier for pasid bind/unbind

2019-11-04 Thread David Gibson
On Thu, Oct 24, 2019 at 08:34:35AM -0400, Liu Yi L wrote: > This patch adds notifier for pasid bind/unbind. VFIO registers this > notifier to listen to the dual-stage translation (a.k.a. nested > translation) configuration changes and propagate to host. Thus vIOMMU > is able to set its translation

Re: [PATCH 1/1] target/arm: Add support for cortex-m7 CPU

2019-11-04 Thread Alex Bennée
Christophe Lyon writes: > This is derived from cortex-m4 description, adding DP support and FPv5 > instructions with the corresponding flags in isar and mvfr2. > > Checked that it could successfully execute > vrinta.f32 s15, s15 > while cortex-m4 emulation rejects it with "illegal instruction".

Re: [RFC v2 13/22] intel_iommu: add PASID cache management infrastructure

2019-11-04 Thread Peter Xu
On Thu, Oct 24, 2019 at 08:34:34AM -0400, Liu Yi L wrote: > This patch adds a PASID cache management infrastructure based on > new added structure VTDPASIDAddressSpace, which is used to track > the PASID usage and future PASID tagged DMA address translation > support in vIOMMU. > > struct VTDP

Re: [RFC v2 00/22] intel_iommu: expose Shared Virtual Addressing to VM

2019-11-04 Thread Peter Xu
On Thu, Oct 24, 2019 at 08:34:21AM -0400, Liu Yi L wrote: > Shared virtual address (SVA), a.k.a, Shared virtual memory (SVM) on Intel > platforms allow address space sharing between device DMA and applications. > SVA can reduce programming complexity and enhance security. > This series is intended

[PULL 2/2] qga: Add "guest-get-memory-block-info" to blacklist

2019-11-04 Thread Michael Roth
From: Basil Salman Memory block commands are only supported for linux with sysfs, "guest-get-memory-block-info" was not in blacklist for other cases. Reported on: https://bugzilla.redhat.com/show_bug.cgi?id=1751431 Signed-off-by: Basil Salman Reviewed-by: Marc-André Lureau Signed-off-by: Mich

[PULL 0/2] qemu-ga patch queue for 4.2-rc0

2019-11-04 Thread Michael Roth
The following changes since commit 36609b4fa36f0ac934874371874416f7533a5408: Merge remote-tracking branch 'remotes/palmer/tags/palmer-for-master-4.2-sf1' into staging (2019-11-02 17:59:03 +) are available in the Git repository at: git://github.com/mdroth/qemu.git tags/qga-pull-2019-11-0

[PULL 1/2] qga-win: network-get-interfaces command name field bug fix

2019-11-04 Thread Michael Roth
From: Bishara AbuHattoum Network interface name is fetched as an encoded WCHAR array, (wide character), then it is decoded using the guest's CP_ACP Windows code page, which is the default code page as configure in the guest's Windows, then it is returned as a byte array, (char array). As stated

[PATCH v1 2/6] tests/vm: add console_consume helper

2019-11-04 Thread Alex Bennée
From: Gerd Hoffmann Helper function to read all console output. Signed-off-by: Gerd Hoffmann Message-Id: <20191031085306.2-3-kra...@redhat.com> Signed-off-by: Alex Bennée --- tests/vm/basevm.py | 19 +++ 1 file changed, 19 insertions(+) diff --git a/tests/vm/basevm.py b/t

[PATCH v1 0/6] testing/next (netbsd stuff)

2019-11-04 Thread Alex Bennée
Hi, As we approach hard-freeze I'm trying to temper what comes in through the testing/next tree. However it would be nice to get the NetBSD upto speed with the other NetBSDs. Although the serial install is working well for me this has had a rocky road so if others could also give it a good testing

[PATCH v1 3/6] tests/vm: use console_consume for netbsd

2019-11-04 Thread Alex Bennée
From: Gerd Hoffmann Use new helper to read all pending console output, not just a single char. Unblocks installer boot. Signed-off-by: Gerd Hoffmann Message-Id: <20191031085306.2-4-kra...@redhat.com> Signed-off-by: Alex Bennée --- tests/vm/netbsd | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v1 5/6] tests: only run ipmi-bt-test if CONFIG_LINUX

2019-11-04 Thread Alex Bennée
This test has been unstable on NetBSD for awhile. It seems the mechanism used to listen to a random port is a Linux-ism (although a received wisdom Linux-ism rather than a well documented one). As working around would add more hard to test complexity to the test I've gone for the easier option of m

[PATCH v1 1/6] tests/vm: netbsd autoinstall, using serial console

2019-11-04 Thread Alex Bennée
From: Gerd Hoffmann Instead of fetching the prebuilt image from patchew download the install iso and prepare the image locally. Install to disk, using the serial console. Create qemu user, configure ssh login. Install packages needed for qemu builds. Signed-off-by: Gerd Hoffmann Reviewed-by:

[PATCH v1 4/6] tests/vm: update netbsd to version 8.1

2019-11-04 Thread Alex Bennée
From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann Message-Id: <20191031085306.2-5-kra...@redhat.com> Signed-off-by: Alex Bennée --- tests/vm/netbsd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/vm/netbsd b/tests/vm/netbsd index d1bfd01..33779402dd1 100755 ---

Re: [PATCH v2 1/2] nbd: Don't send oversize strings

2019-11-04 Thread Maxim Levitsky
On Tue, 2019-10-15 at 16:16 +, Vladimir Sementsov-Ogievskiy wrote: > 15.10.2019 18:07, Eric Blake wrote: > > On 10/11/19 2:32 AM, Vladimir Sementsov-Ogievskiy wrote: > > > 11.10.2019 0:00, Eric Blake wrote: > > > > Qemu as server currently won't accept export names larger than 256 > > > > bytes

[PATCH v1 6/6] tests/vm: support sites with sha512 checksums

2019-11-04 Thread Alex Bennée
The NetBSD project uses SHA512 for its checksums so lets support that in the download helper. Signed-off-by: Alex Bennée --- tests/vm/basevm.py | 10 -- tests/vm/netbsd| 3 ++- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py in

Re: [PATCH v2 2/2] nbd: Allow description when creating NBD blockdev

2019-11-04 Thread Maxim Levitsky
On Thu, 2019-10-10 at 16:00 -0500, Eric Blake wrote: > Allow blockdevs to match the feature already present in qemu-nbd -D. > Enhance iotest 223 to cover it. > > Signed-off-by: Eric Blake > --- > qapi/block.json| 8 +--- > blockdev-nbd.c | 9 - > monitor/hmp-c

Re: [PATCH v2 0/2] block/nvme: add support for write zeros and discard

2019-11-04 Thread Maxim Levitsky
On Tue, 2019-10-29 at 09:33 -0400, John Snow wrote: > > On 10/28/19 6:35 AM, Max Reitz wrote: > > On 13.09.19 15:36, Maxim Levitsky wrote: > > > This is the second part of the patches I prepared > > > for this driver back when I worked on mdev-nvme. > > > > > > V2: addressed review feedback, no m

Re: [PATCH v7 1/8] Acceptance test x86_cpu_model_versions: use default vm

2019-11-04 Thread Philippe Mathieu-Daudé
On 11/4/19 4:13 PM, Cleber Rosa wrote: The default vm provided by the test, available as self.vm, serves the same purpose of the one obtained by self.get_vm(), but saves a line and matches the style of other tests. Signed-off-by: Cleber Rosa Reviewed-by: Philippe Mathieu-Daudé --- tests/

Questions about the VFIO BAR region

2019-11-04 Thread Li Qiang
Hello Alex, Auger and all, I have a question about the VFIO virtual device BAR. In vfio_region_setup, it initialize a ‘region->mem’ MR and set its ops to ‘vfio_regions_ops’. In ‘vfio_region_mmap’, it maps the physical device’s MMIO to QEMU’s virtual address space as a raw MR ‘region->mmaps[i]

Re: [PATCH v7 4/8] Acceptance tests: use relative location for tests

2019-11-04 Thread Philippe Mathieu-Daudé
On 11/4/19 4:13 PM, Cleber Rosa wrote: An Avocado Test ID[1] is composed by a number of components, but it starts with the Test Name, usually a file system location that was given to the loader. Because the source directory is being given as a prefix to the "tests/acceptance" directory containin

Re: The problems about COLO

2019-11-04 Thread Lukas Straub
On Thu, 31 Oct 2019 17:05:20 +0800 Daniel Cho wrote: > Hello all, > I have some questions about the COLO. > 1) Could we dynamic set fault tolerance feature on running VM? > In your document, the primary VM could not start first (if you start > primary VM, the secondary VM will need to start), i

Re: [PATCH v1 5/6] tests: only run ipmi-bt-test if CONFIG_LINUX

2019-11-04 Thread Corey Minyard
On Mon, Nov 04, 2019 at 05:36:53PM +, Alex Bennée wrote: > This test has been unstable on NetBSD for awhile. It seems the > mechanism used to listen to a random port is a Linux-ism (although a > received wisdom Linux-ism rather than a well documented one). As Hmm. I got reports of this issue

  1   2   >