Re: [PATCH v2] Makefile: Remove generated files when doing 'distclean' (and 'clean')

2019-10-23 Thread Thomas Huth
- Original Message - > From: "Aleksandar Markovic" > Sent: Tuesday, October 22, 2019 10:35:51 PM > > On Tuesday, October 8, 2019, Thomas Huth wrote: > > > When running "make distclean" we currently leave a lot of generated > > files in the build directory. These should be completely rem

Re: [PATCH V3 2/2] target/i386/kvm: Add Hyper-V direct tlb flush support

2019-10-23 Thread Paolo Bonzini
On 22/10/19 22:14, Roman Kagan wrote: > On Tue, Oct 22, 2019 at 07:04:11PM +0200, Paolo Bonzini wrote: >> On 16/10/19 15:07, lantianyu1...@gmail.com wrote: > > Somehow this patch never got through to me so I'll reply here. > >>> From: Tianyu Lan >>> >>> Hyper-V direct tlb flush targets KVM on Hy

Re: [PATCH v2] net: add tulip (dec21143) driver

2019-10-23 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191022155413.4619-1-sv...@stackframe.org/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH v1 07/19] cirrus.yml: reduce scope of MacOS build

2019-10-23 Thread Thomas Huth
- Original Message - > From: "Alex Bennée" > Sent: Tuesday, October 22, 2019 9:16:52 PM > > The MacOS build can time out on Cirrus running to almost an hour. > Reduce the scope to the historical MacOS architectures much the same > way we do on Travis. Oh, really? For me, the builds on Ci

Re: [PATCH for 4.2 v1 00/19] testing/next before softfreeze

2019-10-23 Thread Thomas Huth
- Original Message - > From: "Alex Bennée" > Sent: Tuesday, October 22, 2019 9:16:45 PM > > Hi, > > This is the current status of testing/next. I dropped the Travis arm64 > build due to stability concerns. As far as I can tell Thomas' latest > iotest updates are working fine. If there ar

[PATCH] nvme: fix NSSRS offset in CAP register

2019-10-23 Thread Klaus Jensen
Fix the offset of the NSSRS field the CAP register. Signed-off-by: Klaus Jensen Reported-by: Javier Gonzalez --- include/block/nvme.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/block/nvme.h b/include/block/nvme.h index 3ec8efcc435e..fa15b51c33bb 100644 --- a/inc

Re: [PATCH v2 0/4] apic: Fix migration breakage of >255 vcpus

2019-10-23 Thread Peter Xu
On Sat, Oct 19, 2019 at 11:41:53AM +0800, Peter Xu wrote: > On Wed, Oct 16, 2019 at 11:40:01AM -0300, Eduardo Habkost wrote: > > On Wed, Oct 16, 2019 at 10:29:29AM +0800, Peter Xu wrote: > > > v2: > > > - use uint32_t rather than int64_t [Juan] > > > - one more patch (patch 4) to check dup SaveStat

Re: [PATCH v4 3/3] tests/migration:fix unreachable path in stress test

2019-10-23 Thread Laurent Vivier
Le 04/10/2019 à 19:32, Mao Zhongyi a écrit : > If stressone() or stress() exits it's because of a failure > because the test runs forever otherwise, so change stressone > and stress type to void to make the exit_failure() as the exit > function of main(). > > Signed-off-by: Mao Zhongyi > --- > t

Re: [PATCH v2] net: add tulip (dec21143) driver

2019-10-23 Thread Sven Schnelle
On Tue, Oct 22, 2019 at 05:00:16PM +0100, Peter Maydell wrote: > > There are a couple of minor wrong-indent nits: > > > +static void tulip_update_ts(TULIPState *s, int state) > > +{ > > +s->csr[5] &= ~(CSR5_TS_MASK << CSR5_TS_SHIFT); > > +s->csr[5] |= (state & CSR5_TS_MASK) << CSR

Re: [PATCH v4] migration: Support QLIST migration

2019-10-23 Thread Juan Quintela
Eric Auger wrote: > Support QLIST migration using the same principle as QTAILQ: > 94869d5c52 ("migration: migrate QTAILQ"). > > The VMSTATE_QLIST_V macro has the same proto as VMSTATE_QTAILQ_V. > The change mainly resides in QLIST RAW macros: QLIST_RAW_INSERT_HEAD > and QLIST_RAW_REVERSE. > > Test

[Bug 1846427] Re: 4.1.0: qcow2 corruption on savevm/quit/loadvm cycle

2019-10-23 Thread Kevin Wolf
> So it's much more likely that is_zero_cow() has a side-effect that somehow > causes corruption later on even without handle_alloc_space() ever calling > bdrv_co_pwrite_zeroes(). Yes, looks like it. I think we have ruled out that a changing return value is the cause of the problems because the re

RE: [PATCH v6 1/4] block/replication.c: Ignore requests after failover

2019-10-23 Thread Zhang, Chen
> -Original Message- > From: Lukas Straub > Sent: Saturday, October 19, 2019 2:46 AM > To: qemu-devel > Cc: Zhang, Chen ; Jason Wang > ; Wen Congyang ; > Xie Changlong ; Kevin Wolf > ; Max Reitz ; qemu-block > > Subject: Re: [PATCH v6 1/4] block/replication.c: Ignore requests after >

[Bug 1192464] Re: udp checksum computed as 0 not converted to 0xffff, from guest os that share a common linux bridge among multiple guest os

2019-10-23 Thread Thomas Huth
Triaging old buck tickets ... can you still reproduce this issue with the latest version of QEMU? Is it only happening with e1000 or also with other NICs? What kind of network backend are you using (--netdev user ? tap ? ). Could you please provide the full command line that you use to run QEMU

[Bug 1192464] Re: udp checksum computed as 0 not converted to 0xffff, from guest os that share a common linux bridge among multiple guest os

2019-10-23 Thread Thomas Huth
Sorry, I meant "bug tickets", of course, not "buck tickets" ... need more coffee... -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1192464 Title: udp checksum computed as 0 not converted to 0x,

Re: [PATCH v2 0/4] apic: Fix migration breakage of >255 vcpus

2019-10-23 Thread Kevin Wolf
Am 23.10.2019 um 09:57 hat Peter Xu geschrieben: > On Sat, Oct 19, 2019 at 11:41:53AM +0800, Peter Xu wrote: > > On Wed, Oct 16, 2019 at 11:40:01AM -0300, Eduardo Habkost wrote: > > > On Wed, Oct 16, 2019 at 10:29:29AM +0800, Peter Xu wrote: > > > > v2: > > > > - use uint32_t rather than int64_t [J

[PATCH] audio: fix missing break

2019-10-23 Thread Paolo Bonzini
Reported by Coverity (CID 1406449). Signed-off-by: Paolo Bonzini --- audio/paaudio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/audio/paaudio.c b/audio/paaudio.c index df541a72d3..55a91f8980 100644 --- a/audio/paaudio.c +++ b/audio/paaudio.c @@ -385,6 +385,7 @@ static pa_stream *qpa_sim

[PATCH v5 01/11] qdev/qbus: add hidden device support

2019-10-23 Thread Jens Freimann
This adds support for hiding a device to the qbus and qdev APIs. The first user of this will be the virtio-net failover feature but the API introduced with this patch could be used to implement other features as well, for example hiding pci devices when a pci bus is powered off. qdev_device_add()

[PATCH v5 0/11] add failover feature for assigned network devices

2019-10-23 Thread Jens Freimann
This is implementing the host side of the net_failover concept (https://www.kernel.org/doc/html/latest/networking/net_failover.html) Changes since v4: * Patch 1, qdev, add comment to DeviceClass and qdev_should_hide_device function * Patch 2 pci, set flag that allows unplug during migr

[PATCH v5 03/11] pci: mark devices partially unplugged

2019-10-23 Thread Jens Freimann
Only the guest unplug request was triggered. This is needed for the failover feature. In case of a failed migration we need to plug the device back to the guest. Signed-off-by: Jens Freimann --- hw/pci/pcie.c| 3 +++ include/hw/pci/pci.h | 1 + 2 files changed, 4 insertions(+) diff --gi

[PATCH v5 07/11] migration: allow unplug during migration for failover devices

2019-10-23 Thread Jens Freimann
In "b06424de62 migration: Disable hotplug/unplug during migration" we added a check to disable unplug for all devices until we have figured out what works. For failover primary devices qdev_unplug() is called from the migration handler, i.e. during migration. This patch adds a flag to DeviceState

[PATCH v5 02/11] pci: add option for net failover

2019-10-23 Thread Jens Freimann
This patch adds a net_failover_pair_id property to PCIDev which is used to link the primary device in a failover pair (the PCI dev) to a standby (a virtio-net-pci) device. It only supports ethernet devices. Also currently it only supports PCIe devices. QEMU will exit with an error message otherwis

[PATCH v5 04/11] pci: mark device having guest unplug request pending

2019-10-23 Thread Jens Freimann
Set pending_deleted_event in DeviceState for failover primary devices that were successfully unplugged by the Guest OS. Signed-off-by: Jens Freimann --- hw/pci/pcie.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c index 19363ff8ce..08718188bb 100644 --- a/hw

Re: [PATCH v3 07/16] libqos: enforce Device Initialization order

2019-10-23 Thread Stefan Hajnoczi
On Tue, Oct 22, 2019 at 08:48:31PM +0200, Thomas Huth wrote: > On 22/10/2019 17.48, Stefan Hajnoczi wrote: > > On Mon, Oct 21, 2019 at 02:15:53PM +0200, Thomas Huth wrote: > >> On 19/10/2019 08.38, Stefan Hajnoczi wrote: > >>> According to VIRTIO 1.1 "3.1.1 Driver Requirements: Device > >>> Initial

[PATCH v5 09/11] libqos: tolerate wait-unplug migration state

2019-10-23 Thread Jens Freimann
Signed-off-by: Jens Freimann --- tests/libqos/libqos.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/libqos/libqos.c b/tests/libqos/libqos.c index d71557c5cb..f229eb2cb8 100644 --- a/tests/libqos/libqos.c +++ b/tests/libqos/libqos.c @@ -125,7 +125,8 @@ void migrate(Q

[Bug 1575561] Re: config qemu virtio_queue_size to 1024,create vm boot from network failed

2019-10-23 Thread Thomas Huth
Which version of QEMU were you using here? Can you still reproduce this issue with the latest version of QEMU? If so, please also provide the full command line parameters that you used to start QEMU. ** Changed in: qemu Status: New => Incomplete -- You received this bug notification becau

[PATCH v5 06/11] qapi: add failover negotiated event

2019-10-23 Thread Jens Freimann
This event is sent to let libvirt know that VIRTIO_NET_F_STANDBY feature was not negotiated during virtio feature negotiation. If this event is received it means any primary devices hotplugged before this were were never really added to QEMU devices. Signed-off-by: Jens Freimann --- qapi/net.jso

[PATCH v5 05/11] qapi: add unplug primary event

2019-10-23 Thread Jens Freimann
This event is emitted when we sent a request to unplug a failover primary device from the Guest OS and it includes the device id of the primary device. Signed-off-by: Jens Freimann --- qapi/migration.json | 19 +++ 1 file changed, 19 insertions(+) diff --git a/qapi/migration.jso

[PATCH v5 10/11] net/virtio: add failover support

2019-10-23 Thread Jens Freimann
This patch adds support to handle failover device pairs of a virtio-net device and a vfio-pci device, where the virtio-net acts as the standby device and the vfio-pci device as the primary. The general idea is that we have a pair of devices, a vfio-pci and a emulated (virtio-net) device. Before mi

[PATCH v5 08/11] migration: add new migration state wait-unplug

2019-10-23 Thread Jens Freimann
This patch adds a new migration state called wait-unplug. It is entered after the SETUP state if failover devices are present. It will transition into ACTIVE once all devices were succesfully unplugged from the guest. So if a guest doesn't respond or takes long to honor the unplug request the use

[Bug 1596579] Re: segfault upon reboot

2019-10-23 Thread Thomas Huth
Can you reproduce this problem with the latest upstream version of QEMU (currently version 4.1)? Or is it only reproducible in the qemu-kvm from your distribution? (In the latter case, please report this bug to your distro instead) ** Changed in: qemu Status: New => Incomplete -- You rece

[PATCH v5 11/11] vfio: unplug failover primary device before migration

2019-10-23 Thread Jens Freimann
As usual block all vfio-pci devices from being migrated, but make an exception for failover primary devices. This is achieved by setting unmigratable to 0 but also add a migration blocker for all vfio-pci devices except failover primary devices. These will be unplugged before migration happens by t

Re: [PATCH v3 09/16] libqos: access VIRTIO 1.0 vring in little-endian

2019-10-23 Thread Stefan Hajnoczi
On Tue, Oct 22, 2019 at 06:51:39PM +0200, Christophe de Dinechin wrote: > > Stefan Hajnoczi writes: > [...] > > +static uint16_t qvirtio_readw(QVirtioDevice *d, QTestState *qts, uint64_t > > addr) > > +{ > > +uint16_t val = qtest_readw(qts, addr); > > + > > +if (d->features & (1ull << VIR

Re: [PATCH v10 3/3] iotests: test nbd reconnect

2019-10-23 Thread Vladimir Sementsov-Ogievskiy
23.10.2019 4:31, Eric Blake wrote: > On 10/9/19 3:41 AM, Vladimir Sementsov-Ogievskiy wrote: >> Add test, which starts backup to nbd target and restarts nbd server >> during backup. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >>   tests/qemu-iotests/264    | 95 +++

[PATCH v3] net: add tulip (dec21143) driver

2019-10-23 Thread Sven Schnelle
This adds the basic functionality to emulate a Tulip NIC. Implemented are: - RX and TX functionality - Perfect Frame Filtering - Big/Little Endian descriptor support - 93C46 EEPROM support - LXT970 PHY Not implemented, mostly because i had no OS using these functions: - Imperfect frame filterin

Re: [PATCH v6 00/12] target/mips: Misc cleanups for September/October 2019

2019-10-23 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1571685097-15175-1-git-send-email-aleksandar.marko...@rt-rk.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v6 00/12] target/mips: Misc cleanups for September/October 2019 Type: series

[Bug 1192464] Re: udp checksum computed as 0 not converted to 0xffff, from guest os that share a common linux bridge among multiple guest os

2019-10-23 Thread Michal Suchanek
Question is where is this zero checksum observed which is not clear from the report. If in the guest it is certainly correct. If in the host it is correct so long as the bridge appears to have checksum offloading as well. If whatever interface the guest packets appear to come from is not set up w

Re: [PATCH] virtio: fix IO request length in virtio SCSI/block #PSBM-78839

2019-10-23 Thread Denis Plotnikov
On 21.10.2019 16:24, Stefan Hajnoczi wrote: > On Fri, Oct 18, 2019 at 02:55:47PM +0300, Denis Plotnikov wrote: >> From: "Denis V. Lunev" >> >> Linux guests submit IO requests no longer than PAGE_SIZE * max_seg >> field reported by SCSI controler. Thus typical sequential read with >> 1 MB size re

Re: [PATCH v4 1/3] tests/migration: mem leak fix

2019-10-23 Thread Laurent Vivier
Le 04/10/2019 à 19:32, Mao Zhongyi a écrit : > ‘data’ has the possibility of memory leaks, so use the > glib macros g_autofree recommended by CODING_STYLE.rst > to automatically release the memory that returned from > g_malloc(). > > Signed-off-by: Mao Zhongyi > Reviewed-by: Alex Bennée > --- >

Re: [PATCH 2/2] virtiofsd: move to a new pid namespace

2019-10-23 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@redhat.com) wrote: > virtiofsd needs access to /proc/self/fd. Let's move to a new pid > namespace so that a compromised process cannot see another other > processes running on the system. > > One wrinkle in this approach: unshare(CLONE_NEWPID) affects *child* > process

[Bug 1847232] Re: qemu TCG in s390x mode issue with calculating HASH

2019-10-23 Thread Ivan Warren via
Looks fixed to me ! The issue no longer shows even without specifying vx=off -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1847232 Title: qemu TCG in s390x mode issue with calculating HASH Status

[PATCH v4 04/16] virtio-scsi-test: add missing feature negotiation

2019-10-23 Thread Stefan Hajnoczi
VIRTIO Device Initialization requires feature negotiation. Currently virtio-scsi-test.c is non-compliant. libqos tests acknowledge all feature bits advertised by the device, except VIRTIO_F_BAD_FEATURE (which devices use to detect broken drivers!) and VIRTIO_RING_F_EVENT_IDX (which is not impleme

[PATCH v4 01/16] tests/virtio-blk-test: read config space after feature negotiation

2019-10-23 Thread Stefan Hajnoczi
The VIRTIO Configuration Space cannot be accessed before device feature bits have been read because a driver doesn't know the endianness until it has checked VIRTIO_F_VERSION_1. Fix this problem in preparation for VIRTIO 1.0 support. Signed-off-by: Stefan Hajnoczi Reviewed-by: Thomas Huth ---

[PATCH v4 00/16] libqos: add VIRTIO PCI 1.0 support

2019-10-23 Thread Stefan Hajnoczi
v4: * Introduce bool d->features_negotiated so that tests can negotiate a 0 feature bit set in Legacy mode [Thomas] * Make the FEATURES_OK code change in qvirtio_set_driver_ok() clearer and mention it in the commit description [Thomas] * Fix indentation in qvring_init() [Thomas] v3: * Now

[PATCH v4 02/16] libqos: read QVIRTIO_MMIO_VERSION register

2019-10-23 Thread Stefan Hajnoczi
There was no real virtio-mmio ABI change between Legacy and VIRTIO 1.0 except that the Version field was incremented from 1 to 2. However, QEMU does not allow Legacy drivers to perform VIRTIO 1.0 operations like accessing 64-bit feature bits. Since we will introduce 64-bit feature bit support we

[PATCH v4 05/16] tests/virtio-blk-test: set up virtqueue after feature negotiation

2019-10-23 Thread Stefan Hajnoczi
VIRTIO Device Initialization requires that feature negotiation has completed before virtqueues are set up. This makes sense because the driver must know whether it is operating in Legacy or VIRTIO 1.0 mode before it can access vring fields with the correct endianness. Signed-off-by: Stefan Hajnoc

[PATCH v4 15/16] libqos: extract Legacy virtio-pci.c code

2019-10-23 Thread Stefan Hajnoczi
The current libqos virtio-pci.c code implements the VIRTIO Legacy interface. Extract existing code in preparation for VIRTIO 1.0 support. Signed-off-by: Stefan Hajnoczi Reviewed-by: Sergio Lopez Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé --- tests/libqos/virtio-pci.h | 2 -

[PATCH v4 06/16] libqos: add missing virtio-9p feature negotiation

2019-10-23 Thread Stefan Hajnoczi
VIRTIO Device Initialization requires feature negotiation. The libqos virtio-9p driver lacks feature negotiation and is therefore non-compliant. libqos tests acknowledge all feature bits advertised by the device, except VIRTIO_F_BAD_FEATURE (which devices use to detect broken drivers!) and VIRTIO

[PATCH v4 07/16] libqos: enforce Device Initialization order

2019-10-23 Thread Stefan Hajnoczi
According to VIRTIO 1.1 "3.1.1 Driver Requirements: Device Initialization", configuration space and virtqueues cannot be accessed before features have been negotiated. Enforce this requirement. Signed-off-by: Stefan Hajnoczi --- v4: * Introduce bool d->features_negotiated so that tests can nego

[PATCH v4 03/16] libqos: extend feature bits to 64-bit

2019-10-23 Thread Stefan Hajnoczi
In VIRTIO 1.0 feature bits changed from 32-bit to 64-bit. (In fact, the transports allow even more feature bits but nothing uses more than 64 bits today.) Add 64-bit feature bit support to virtio-mmio and virtio-pci. This will be necessary for VIRTIO 1.0 support. Signed-off-by: Stefan Hajnoczi

[PATCH v4 09/16] libqos: access VIRTIO 1.0 vring in little-endian

2019-10-23 Thread Stefan Hajnoczi
VIRTIO 1.0 uses little-endian for the vring. Legacy VIRTIO uses guest endianness. Adjust the code to handle both. Note that qvirtio_readq() is not defined because it has no users. All the other accessors are really needed. Signed-off-by: Stefan Hajnoczi Reviewed-by: Thomas Huth --- v4: * Fi

Re: [PATCH for 4.2 v1 00/19] testing/next before softfreeze

2019-10-23 Thread Alex Bennée
Thomas Huth writes: > - Original Message - >> From: "Alex Bennée" >> Sent: Tuesday, October 22, 2019 9:16:45 PM >> >> Hi, >> >> This is the current status of testing/next. I dropped the Travis arm64 >> build due to stability concerns. As far as I can tell Thomas' latest >> iotest updat

[PATCH v4 08/16] libqos: implement VIRTIO 1.0 FEATURES_OK step

2019-10-23 Thread Stefan Hajnoczi
Device initialization has an extra step in VIRTIO 1.0. The FEATURES_OK status bit is set to indicate that feature negotiation has completed. The driver then reads the status register again to check that the device agrees with the final features. Implement this step as part of qvirtio_set_features

[PATCH v4 10/16] libqos: add iteration support to qpci_find_capability()

2019-10-23 Thread Stefan Hajnoczi
VIRTIO 1.0 PCI devices have multiple PCI_CAP_ID_VNDR capabilities so we need a way to iterate over them. Extend qpci_find_capability() to take the last address. Signed-off-by: Stefan Hajnoczi Reviewed-by: Thomas Huth -- v3: * Document qpci_find_capability() --- tests/libqos/pci.h | 2 +- tes

[PATCH v4 12/16] libqos: add MSI-X callbacks to QVirtioPCIDevice

2019-10-23 Thread Stefan Hajnoczi
The MSI-X vectors are programmed differently in the VIRTIO 1.0 and Legacy interfaces. Introduce callbacks so different implementations can be used depending on the interface version. Signed-off-by: Stefan Hajnoczi Reviewed-by: Sergio Lopez Reviewed-by: Thomas Huth --- tests/libqos/virtio-pci.

[PATCH v7 04/14] target/mips: msa: Split helpers for _A.

2019-10-23 Thread Aleksandar Markovic
From: Aleksandar Markovic Achieves clearer code and slightly better performance. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- target/mips/helper.h | 11 +++- target/mips/msa_helper.c | 163 ++- target/mips/translate.c

[PATCH v4 11/16] libqos: pass full QVirtQueue to set_queue_address()

2019-10-23 Thread Stefan Hajnoczi
Instead of just passing the vring page frame number, pass the full QVirtQueue. This will allow the VIRTIO 1.0 transport to program the fine-grained vring address registers in the future. Signed-off-by: Stefan Hajnoczi Reviewed-by: Sergio Lopez Reviewed-by: Thomas Huth Reviewed-by: Philippe Mat

Re: [PATCH v1 07/19] cirrus.yml: reduce scope of MacOS build

2019-10-23 Thread Alex Bennée
Thomas Huth writes: > - Original Message - >> From: "Alex Bennée" >> Sent: Tuesday, October 22, 2019 9:16:52 PM >> >> The MacOS build can time out on Cirrus running to almost an hour. >> Reduce the scope to the historical MacOS architectures much the same >> way we do on Travis. > > Oh

[PATCH v4 14/16] libqos: make the virtio-pci BAR index configurable

2019-10-23 Thread Stefan Hajnoczi
The Legacy virtio-pci interface always uses BAR 0. VIRTIO 1.0 may need to use a different BAR index, so make it configurable. Signed-off-by: Stefan Hajnoczi Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé --- v3: * Change uint8_t bar_idx to int [Thomas] --- tests/libqos/virtio-p

[PATCH v7 00/14] target/mips: Misc cleanups for September/October 2019

2019-10-23 Thread Aleksandar Markovic
From: Aleksandar Markovic Mostly cosmetic changes. v6->v7: - minor corrections in commit messages - added patches 13 and 14 v5->v6: - minor corrections (r-b, t-b marks) in commit messages - added patches 11 and 12 v4->v5: - minor correction in patch on helper.c - added patches 9

[PATCH v4 13/16] libqos: expose common virtqueue setup/cleanup functions

2019-10-23 Thread Stefan Hajnoczi
The VIRTIO 1.0 code will need to perform additional steps but it will reuse the common virtqueue setup/cleanup code. Make these functions public. Make sure to invoke callbacks via QVirtioBus instead of directly calling the virtio-pci Legacy versions of these functions. Signed-off-by: Stefan Hajn

[PATCH v4 16/16] libqos: add VIRTIO PCI 1.0 support

2019-10-23 Thread Stefan Hajnoczi
Implement the VIRTIO 1.0 virtio-pci interface. The main change here is that the register layout is no longer a fixed layout in BAR 0. Instead we have to iterate of PCI Capabilities to find descriptions of where various registers are located. The vring registers are also more fine-grained, allowi

Re: [Bug 1847232] Re: qemu TCG in s390x mode issue with calculating HASH

2019-10-23 Thread David Hildenbrand
On 23.10.19 11:37, Ivan Warren wrote: > Looks fixed to me ! The issue no longer shows even without specifying > vx=off > Nice, I suspect that there might be more issues when using golang (as it really makes excessive use of vector registers to my surprise). So in case you run into problems (and

[PATCH v7 05/14] target/mips: msa: Split helpers for _.

2019-10-23 Thread Aleksandar Markovic
From: Aleksandar Markovic Achieves clearer code and slightly better performance. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- target/mips/helper.h | 20 ++- target/mips/msa_helper.c | 320 ++- target/mips/translate.c |

Re: [PATCH v4 04/16] virtio-scsi-test: add missing feature negotiation

2019-10-23 Thread Thomas Huth
- Original Message - > From: "Stefan Hajnoczi" > Sent: Wednesday, October 23, 2019 12:04:13 PM > > VIRTIO Device Initialization requires feature negotiation. Currently > virtio-scsi-test.c is non-compliant. > > libqos tests acknowledge all feature bits advertised by the device, > except

[PATCH v7 10/14] target/mips: msa: Split helpers for PCK.

2019-10-23 Thread Aleksandar Markovic
From: Aleksandar Markovic Achieves clearer code and slightly better performance. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- target/mips/helper.h | 11 +- target/mips/msa_helper.c | 386 +-- target/mips/translate.c |

[PATCH] buildfix: update texinfo menu

2019-10-23 Thread Gerd Hoffmann
Build error message: qemu-doc.texi:34: node `Top' lacks menu item for `Recently removed features' despite being its Up target Fixes: 3264ffced3d0 ("dirty-bitmaps: remove deprecated autoload parameter") Signed-off-by: Gerd Hoffmann --- qemu-doc.texi | 1 + 1 file changed, 1 insertion(+) diff --

[PATCH v7 07/14] target/mips: msa: Split helpers for ADD<_A|S_A|S_S|S_U|V>.

2019-10-23 Thread Aleksandar Markovic
From: Aleksandar Markovic Achieves clearer code and slightly better performance. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- target/mips/helper.h | 30 +++- target/mips/msa_helper.c | 426 +-- target/mips/translate.c

Re: [PATCH] audio: fix missing break

2019-10-23 Thread Philippe Mathieu-Daudé
On 10/23/19 10:24 AM, Paolo Bonzini wrote: Reported by Coverity (CID 1406449). Gerd sent the same patch earlier: https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg05923.html But your description is better. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini --- audio

Re: [PATCH v4 06/16] libqos: add missing virtio-9p feature negotiation

2019-10-23 Thread Thomas Huth
- Original Message - > From: "Stefan Hajnoczi" > Sent: Wednesday, October 23, 2019 12:04:15 PM > > VIRTIO Device Initialization requires feature negotiation. The libqos > virtio-9p driver lacks feature negotiation and is therefore > non-compliant. > > libqos tests acknowledge all featur

[PATCH v7 13/14] target/mips: Add support for emulation of CRC32 group of instructions

2019-10-23 Thread Aleksandar Markovic
From: Aleksandar Markovic Add emulation of MIPS' CRC32 (Cyclic Redundancy Check) instructions. Reuse zlib crc32() and Linux crc32c(). Note that, at the time being, there is no MIPS CPU that supports CRC32 instructions (they are an optional part of MIPS64/32 R6 anf nanoMIPS ISAs). Signed-off-by:

[PATCH v7 14/14] target/mips: Demacro LMI decoder

2019-10-23 Thread Aleksandar Markovic
From: Aleksandar Markovic This makes searches for instances of opcode usages easier. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 247 +--- 1 file changed, 173 insertions(+), 74 deletions(-) diff --git a/target/mips/translate.c b

[PATCH v7 03/14] MAINTAINERS: Update mail address of Aleksandar Rikalo

2019-10-23 Thread Aleksandar Markovic
From: Aleksandar Markovic Aleksandar Rikalo wishes to change his primary mail address for QEMU. Some minor line order is corrected in .mailmap to be alphabetical, too. Reviewed-by: Aleksandar Rikalo Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Aleksanda

[PATCH v7 11/14] target/mips: msa: Split helpers for HSUB_.

2019-10-23 Thread Aleksandar Markovic
From: Aleksandar Markovic Achieves clearer code and slightly better performance. Signed-off-by: Aleksandar Markovic --- target/mips/helper.h | 10 - target/mips/msa_helper.c | 108 +-- target/mips/translate.c | 32 +++--- 3 files c

Re: [RFC PATCH 00/23] Add subcluster allocation to qcow2

2019-10-23 Thread Vladimir Sementsov-Ogievskiy
Hi! This is very interesting! Could you please export a branch to look at, as patches can't be applied on master now :( 15.10.2019 18:23, Alberto Garcia wrote: > Hi, > > this series adds a new feature to the qcow2 on-disk format called > "Extended L2 Entries", which allows us to do subcluster al

[PATCH v7 01/14] target/mips: Clean up helper.c

2019-10-23 Thread Aleksandar Markovic
From: Aleksandar Markovic Mostly fix errors and warnings reported by 'checkpatch.pl -f'. Cc: Markus Armbruster Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- target/mips/helper.c | 123 +++ 1 file changed, 74 insertions(+

Re: [PATCH v2 0/4] apic: Fix migration breakage of >255 vcpus

2019-10-23 Thread Peter Xu
On Sat, Oct 19, 2019 at 11:41:53AM +0800, Peter Xu wrote: > On Wed, Oct 16, 2019 at 11:40:01AM -0300, Eduardo Habkost wrote: > > On Wed, Oct 16, 2019 at 10:29:29AM +0800, Peter Xu wrote: > > > v2: > > > - use uint32_t rather than int64_t [Juan] > > > - one more patch (patch 4) to check dup SaveStat

[PATCH v7 06/14] target/mips: msa: Split helpers for ILV.

2019-10-23 Thread Aleksandar Markovic
From: Aleksandar Markovic Achieves clearer code and slightly better performance. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- target/mips/helper.h | 21 +- target/mips/msa_helper.c | 768 +-- target/mips/translate.c |

[PATCH v7 08/14] target/mips: msa: Split helpers for HADD_.

2019-10-23 Thread Aleksandar Markovic
From: Aleksandar Markovic Achieves clearer code and slightly better performance. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- target/mips/helper.h | 10 +++- target/mips/msa_helper.c | 131 ++- target/mips/translate.c

[PATCH v7 09/14] target/mips: msa: Split helpers for S.

2019-10-23 Thread Aleksandar Markovic
From: Aleksandar Markovic Achieves clearer code and slightly better performance. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- target/mips/helper.h | 30 +++- target/mips/msa_helper.c | 424 +-- target/mips/translate.c

Re: [PATCH v4 16/16] libqos: add VIRTIO PCI 1.0 support

2019-10-23 Thread Thomas Huth
- Original Message - > From: "Stefan Hajnoczi" > Sent: Wednesday, October 23, 2019 12:04:25 PM > > Implement the VIRTIO 1.0 virtio-pci interface. The main change here is > that the register layout is no longer a fixed layout in BAR 0. Instead > we have to iterate of PCI Capabilities to

[PATCH v7 12/14] target/mips: msa: Split helpers for ASUB_.

2019-10-23 Thread Aleksandar Markovic
From: Aleksandar Markovic Achieves clearer code and slightly better performance. Signed-off-by: Aleksandar Markovic --- target/mips/helper.h | 12 +++- target/mips/msa_helper.c | 169 ++- target/mips/translate.c | 38 +-- 3 files chang

Re: [RFC PATCH 1/4] net/awd.c: Introduce Advanced Watch Dog module framework

2019-10-23 Thread Philippe Mathieu-Daudé
Hi Chen, On 10/16/19 1:22 PM, Zhang Chen wrote: From: Zhang Chen This patch introduce a new module named Advanced Watch Dog, and defined the input and output parameter. AWD use standard chardev as the way of communicationg with the outside world. Demo command: -object advanced-watchdog,id=hea

Re: [Qemu-devel] [PATCH] pci_bridge: fix a typo in comment

2019-10-23 Thread Philippe Mathieu-Daudé
On 10/23/19 5:32 AM, maozy wrote: ping... I'm not sure qemu-trivial@ received this one because the email address looked odd (now fixed). On 11/8/18 9:12 PM, Philippe Mathieu-Daudé wrote: Cc'ing qemu-trivial@ On 8/11/18 13:21, Mao Zhongyi wrote: Signed-off-by: Mao Zhongyi Reviewed-by:

Re: [PATCH v5 5/7] ppc: Reset the interrupt presenter from the CPU reset handler

2019-10-23 Thread Philippe Mathieu-Daudé
On 10/22/19 6:38 PM, Cédric Le Goater wrote: On the sPAPR machine and PowerNV machine, the interrupt presenters are created by a machine handler at the core level and are reset independently. This is not consistent and it raises issues when it comes to handle hot-plugged CPUs. In that case, the p

[PATCH v7 02/14] target/mips: Clean up op_helper.c

2019-10-23 Thread Aleksandar Markovic
From: Aleksandar Markovic Mostly fix errors and warnings reported by 'checkpatch.pl -f'. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- target/mips/op_helper.c | 1010 +++ 1 file changed, 663 insertions(+), 347 deletions(-) d

Re: [PATCH v4 08/16] libqos: implement VIRTIO 1.0 FEATURES_OK step

2019-10-23 Thread Thomas Huth
- Original Message - > From: "Stefan Hajnoczi" > Sent: Wednesday, October 23, 2019 12:04:17 PM > > Device initialization has an extra step in VIRTIO 1.0. The FEATURES_OK > status bit is set to indicate that feature negotiation has completed. > The driver then reads the status register ag

Re: [PATCH v3 3/6] ps2: accept 'Set Key Make and Break' commands

2019-10-23 Thread Philippe Mathieu-Daudé
Hi Sven, (Please Cc reviewers who previously commented your patch) On 10/22/19 10:59 PM, Sven Schnelle wrote: HP-UX sends both the 'Set key make and break (0xfc) and 'Set all key typematic make and break' (0xfa). QEMU response with 'Resend' as it doesn't handle these commands. HP-UX than report

Re: [PATCH v5 6/7] ppc/pnv: Fix naming of routines realizing the CPUs

2019-10-23 Thread Philippe Mathieu-Daudé
On 10/22/19 6:38 PM, Cédric Le Goater wrote: The 'vcpu' suffix is inherited from the sPAPR machine. Use better names for PowerNV. Signed-off-by: Cédric Le Goater Reviewed-by: Greg Kurz --- hw/ppc/pnv_core.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/ppc/p

Re: [PATCH] i386/kvm: add NoNonArchitecturalCoreSharing Hyper-V enlightenment

2019-10-23 Thread Vitaly Kuznetsov
Eduardo Habkost writes: > On Mon, Oct 21, 2019 at 06:26:14PM +0200, Paolo Bonzini wrote: >> On 21/10/19 16:09, Vitaly Kuznetsov wrote: >> >>> +if (cpu->hyperv_no_nonarch_cs == ON_OFF_AUTO_ON) { >> >>> +env->features[FEAT_HV_RECOMM_EAX] |= HV_NO_NONARCH_CORESHARING; >> >>> +} else

[Bug 1847232] Re: qemu TCG in s390x mode issue with calculating HASH

2019-10-23 Thread Ivan Warren via
I will exercise this thoroughly ! The go application involved is itself a blockchain signing/verification application, so I suspect it will be a good exercise (codenotary.io) Thanks for looking into this and fixing this ! --Ivan -- You received this bug notification because you are a member of

RE: [RFC PATCH 1/4] net/awd.c: Introduce Advanced Watch Dog module framework

2019-10-23 Thread Zhang, Chen
> -Original Message- > From: Philippe Mathieu-Daudé > Sent: Wednesday, October 23, 2019 7:01 PM > To: Zhang, Chen ; Jason Wang > ; Paolo Bonzini ; qemu- > dev > Cc: Zhang Chen > Subject: Re: [RFC PATCH 1/4] net/awd.c: Introduce Advanced Watch Dog > module framework > > Hi Chen, > > On

Re: [PATCH v5 4/7] ppc/pnv: Add a PnvChip pointer to PnvCore

2019-10-23 Thread Philippe Mathieu-Daudé
On 10/22/19 6:38 PM, Cédric Le Goater wrote: We will use it to reset the interrupt presenter from the CPU reset handler. Signed-off-by: Cédric Le Goater Reviewed-by: Greg Kurz --- include/hw/ppc/pnv_core.h | 3 +++ hw/ppc/pnv_core.c | 3 ++- 2 files changed, 5 insertions(+), 1 dele

Re: [PATCH] buildfix: update texinfo menu

2019-10-23 Thread Philippe Mathieu-Daudé
Cc'ed trivial@ On 10/23/19 12:19 PM, Gerd Hoffmann wrote: Build error message: qemu-doc.texi:34: node `Top' lacks menu item for `Recently removed features' despite being its Up target Fixes: 3264ffced3d0 ("dirty-bitmaps: remove deprecated autoload parameter") Signed-off-by: Gerd Hoffmann Re

Re: [PATCH v4 07/16] libqos: enforce Device Initialization order

2019-10-23 Thread Thomas Huth
- Original Message - > From: "Stefan Hajnoczi" > Sent: Wednesday, October 23, 2019 12:04:16 PM > > According to VIRTIO 1.1 "3.1.1 Driver Requirements: Device > Initialization", configuration space and virtqueues cannot be accessed > before features have been negotiated. Enforce this requ

Re: [PATCH v10 3/3] iotests: test nbd reconnect

2019-10-23 Thread Eric Blake
On 10/23/19 3:33 AM, Vladimir Sementsov-Ogievskiy wrote: 23.10.2019 4:31, Eric Blake wrote: On 10/9/19 3:41 AM, Vladimir Sementsov-Ogievskiy wrote: Add test, which starts backup to nbd target and restarts nbd server during backup. Signed-off-by: Vladimir Sementsov-Ogievskiy --- +vm.qmp_log

Re: [PATCH v1 05/19] travis.yml: Fix the ccache lines

2019-10-23 Thread Philippe Mathieu-Daudé
On 10/22/19 9:16 PM, Alex Bennée wrote: From: Thomas Huth The "command -v ccache && ccache ..." likely were supposed to test the availability of ccache before running the program. But this shell construct causes Travis to abort if ccache is not available. Use an if-statement instead to fix this

Re: [PATCH v5 3/7] ppc/pnv: Introduce a PnvCore reset handler

2019-10-23 Thread Philippe Mathieu-Daudé
Hi Cédric, On 10/22/19 6:38 PM, Cédric Le Goater wrote: in which individual CPUs are reset. It will ease the introduction of future change reseting the interrupt presenter from the CPU reset handler. Signed-off-by: Cédric Le Goater Reviewed-by: Greg Kurz --- hw/ppc/pnv_core.c | 19 +

Re: [PATCH] i386/kvm: add NoNonArchitecturalCoreSharing Hyper-V enlightenment

2019-10-23 Thread Eduardo Habkost
On Wed, Oct 23, 2019 at 01:16:38PM +0200, Vitaly Kuznetsov wrote: > Eduardo Habkost writes: > > > On Mon, Oct 21, 2019 at 06:26:14PM +0200, Paolo Bonzini wrote: > >> On 21/10/19 16:09, Vitaly Kuznetsov wrote: > >> >>> +if (cpu->hyperv_no_nonarch_cs == ON_OFF_AUTO_ON) { > >> >>> +env->

RE: [Virtio-fs] [PATCH 0/2] virtiofsd: Two fix for xattr operation

2019-10-23 Thread misono.tomoh...@fujitsu.com
> -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > Sent: Monday, October 21, 2019 6:41 PM > To: Misono, Tomohiro/味曽野 智礼 > Cc: 'Miklos Szeredi' ; virtio...@redhat.com; > qemu-devel@nongnu.org > Subject: Re: [Virtio-fs] [PATCH 0/2] virtiofsd: Two fix for xattr opera

[Bug 1192464] Re: udp checksum computed as 0 not converted to 0xffff, from guest os that share a common linux bridge among multiple guest os

2019-10-23 Thread Philippe Mathieu-Daudé
Fixed: commit 0dacea92d26c31d453c58de2e99c178fee554166 Author: Ed Swierk Date: Thu Nov 16 06:06:06 2017 -0800 net: Transmit zero UDP checksum as 0x The checksum algorithm used by IPv4, TCP and UDP allows a zero value to be represented by either 0x and 0x. But per R

  1   2   3   4   >