[PATCH v11 06/15] hw/i386/pc: remove commented out code from x86_load_linux()

Follow checkpatch.pl recommendation and remove commented out code from x86_load_linux(). Signed-off-by: Sergio Lopez Reviewed-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 13 - 1 file changed, 13 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 90c2263a33..612bfe9c95 10

[PATCH v11 08/15] hw/i386: split PCMachineState deriving X86MachineState from it

Split up PCMachineState and PCMachineClass and derive X86MachineState and X86MachineClass from them. This allows sharing code with non-PC x86 machine types. Signed-off-by: Sergio Lopez Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin --- in

[PATCH v11 12/15] roms: add microvm-bios (qboot) as binary and git submodule

qboot is a minimalist x86 firmware for booting Linux kernels. It does the mininum amount of work required for the task, and it's able to boot both PVH images and bzImages without relying on option roms. This characteristics make it an ideal companion for the microvm machine type. Signed-off-by: S

[PATCH v11 13/15] docs/microvm.rst: document the new microvm machine type

Document the new microvm machine type. Signed-off-by: Sergio Lopez Reviewed-by: Michael S. Tsirkin Reviewed-by: Marc-André Lureau --- docs/microvm.rst | 108 +++ 1 file changed, 108 insertions(+) create mode 100644 docs/microvm.rst diff --git a/doc

[PATCH v11 11/15] hw/intc/apic: reject pic ints if isa_pic == NULL

In apic_accept_pic_intr(), reject PIC interruptions if a i8259 PIC has not been instantiated (isa_pic == NULL). Suggested-by: Paolo Bonzini Signed-off-by: Sergio Lopez Reviewed-by: Michael S. Tsirkin --- hw/intc/apic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/intc

[PATCH v11 15/15] MAINTAINERS: add microvm related files

Add a new "microvm" section under "X86 Machines" with the new files related to this machine type. Signed-off-by: Sergio Lopez Reviewed-by: Michael S. Tsirkin Reviewed-by: Philippe Mathieu-Daudé --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINE

Re: [PATCH] vhost-user-scsi: implement handle_output

> On Oct 18, 2019, at 3:59 AM, Yongji Xie wrote: > > On Fri, 18 Oct 2019 at 01:17, Felipe Franciosi wrote: >> >> Originally, vhost-user-scsi did not implement a handle_output callback >> as that didn't seem necessary. Turns out it is. >> >> Depending on which other devices are presented to

Re: [PATCH v32 04/13] target/avr: Add instruction translation - Registers definition

On Fri, Oct 18, 2019 at 11:52 AM Aleksandar Markovic < aleksandar.m.m...@gmail.com> wrote: > > > On Thursday, October 17, 2019, Michael Rolnik wrote: > >> On Thu, Oct 17, 2019 at 11:17 PM Aleksandar Markovic >> wrote: >> >> >> >> >> >> >> +static TCGv cpu_Cf; >> >> >> +static TCGv cpu_Zf; >> >>

Re: [PATCH v2 00/10] hw/arm/raspi: Add thermal/timer, improve multicore address space

Patchew URL: https://patchew.org/QEMU/20191017225800.6946-1-f4...@amsat.org/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/b

Re: [PATCH] Do not use %m in common code to print error messages

On 18/10/2019 12.57, Daniel P. Berrangé wrote: > On Fri, Oct 18, 2019 at 12:44:38PM +0200, Thomas Huth wrote: >> The %m format specifier is an extension from glibc - and when compiling >> QEMU for NetBSD, the compiler correctly complains, e.g.: >> >> /home/qemu/qemu-test.ELjfrQ/src/util/main-loop.c

Re: [PATCH] Do not use %m in common code to print error messages

On Fri, Oct 18, 2019 at 01:31:34PM +0200, Thomas Huth wrote: > On 18/10/2019 12.57, Daniel P. Berrangé wrote: > > On Fri, Oct 18, 2019 at 12:44:38PM +0200, Thomas Huth wrote: > >> The %m format specifier is an extension from glibc - and when compiling > >> QEMU for NetBSD, the compiler correctly co

Re: [PATCH] Do not use %m in common code to print error messages

On 18/10/2019 13.37, Daniel P. Berrangé wrote: > On Fri, Oct 18, 2019 at 01:31:34PM +0200, Thomas Huth wrote: >> On 18/10/2019 12.57, Daniel P. Berrangé wrote: >>> On Fri, Oct 18, 2019 at 12:44:38PM +0200, Thomas Huth wrote: The %m format specifier is an extension from glibc - and when compili

Re: iotest failure -- test possibly not using sufficiently unique temp filename?

On 18/10/2019 10.42, Max Reitz wrote: > On 18.10.19 08:20, Thomas Huth wrote: >> On 17/10/2019 18.41, Peter Maydell wrote: >>> On Fri, 27 Sep 2019 at 17:44, Max Reitz wrote: On 27.09.19 18:39, Peter Maydell wrote: > Hi; I just saw this iotest failure (on an s390x box, as it happens):

[PATCH] iotests: Skip read-only cases in 118 when run as root

Some tests in 118 use chmod to remove write permissions from the file and assume that the image can indeed not be opened read-write afterwards. This doesn't work when the test is run as root, because root can still open the file as writable even when the permission bit isn't set. Introduce a @skip

Re: [PULL 0/4] Ui 20191018 patches

ilable in the Git repository at: > > git://git.kraxel.org/qemu tags/ui-20191018-pull-request > > for you to fetch changes up to 707f75070a94c28889f887deef0ab4da09e25ddf: > > ui: fix keymap file search in input-barrier object (2019-10-18 10:40:46 > +0200) > > ---

Re: [PULL 1/4] ui: Fix hanging up Cocoa display on macOS 10.15 (Catalina)

Oops, just noticed that this patch should have been Cc: qemu-sta...@nongnu.org. Hopefully the stable team can pick it up anyway. thanks -- PMM On Fri, 18 Oct 2019 at 11:17, Gerd Hoffmann wrote: > > From: Hikaru Nishida > > macOS API documentation says that before applicationDidFinishLaunching

[PATCH] virtio: fix IO request length in virtio SCSI/block #PSBM-78839

From: "Denis V. Lunev" Linux guests submit IO requests no longer than PAGE_SIZE * max_seg field reported by SCSI controler. Thus typical sequential read with 1 MB size results in the following pattern of the IO from the guest: 8,16 115754 2.766095122 2071 D R 2095104 + 1008 [dd]

Re: [PATCH v1 0/5] target/arm/kvm: Provide an option to adjust virtual time

On Thu, Oct 17, 2019 at 05:17:59PM -0400, Masayoshi Mizuma wrote: > Hi Drew, > > Thank you for posting the patches, they seems to work well > because the softlockup is gone and the timestamp jump of > dmesg and ftrace record also disappeared after the guest > is virsh resume'ed. > > Let me add co

[PATCH v2] doc: Describe missing generic -blockdev options

We added more generic options after introducing -blockdev and forgot to update the documentation (man page and --help output) accordingly. Do that now. Signed-off-by: Kevin Wolf --- qemu-options.hx | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/qemu-op

RE: [for-4.2 PATCH 3/6] replay: update docs for record/replay with block devices

> From: Kevin Wolf [mailto:kw...@redhat.com] > Am 11.10.2019 um 08:10 hat Pavel Dovgalyuk geschrieben: > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > Am 25.09.2019 um 11:02 hat Pavel Dovgalyuk geschrieben: > > > > I started playing with -blockdev: added new blockdev for blkreplay and > > >

Re: [PATCH] block/backup: drop dead code from backup_job_create

Am 17.10.2019 um 16:21 hat Vladimir Sementsov-Ogievskiy geschrieben: > After commit 00e30f05de1d195, there is no more "goto error" points > after job creation, so after "error:" @job is always NULL and we don't > need roll-back job creation. > > Reported-by: Coverity (CID 1406402) > Signed-off-by:

Re: [PATCH v2] doc: Describe missing generic -blockdev options

On Fri, 18 Oct 2019 at 13:02, Kevin Wolf wrote: > > We added more generic options after introducing -blockdev and forgot to > update the documentation (man page and --help output) accordingly. Do > that now. > > Signed-off-by: Kevin Wolf > --- > qemu-options.hx | 22 +- > 1 f

[PATCH] blockdev: modify blockdev-change-medium to change non-removable device

The modification is useful to workaround exclusive file access restrictions, e.g. to implement VM migration with shared disk stored on a storage with the exclusive file opening model: a destination VM is started waiting for incomming migration with a fake image drive, and later, on the last migrati

[Bug 1847906] Re: Cocoa display hangs on macOS 10.15 (Catalina)

Hikaru's patch is now in master as commit dff742ad27efa4, and will be in the next QEMU release. ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/

Re: [PATCH v32 04/13] target/avr: Add instruction translation - Registers definition

resending. On Fri, Oct 18, 2019 at 2:27 PM Michael Rolnik wrote: > > > > On Fri, Oct 18, 2019 at 11:52 AM Aleksandar Markovic > wrote: >> >> >> >> On Thursday, October 17, 2019, Michael Rolnik wrote: >>> >>> On Thu, Oct 17, 2019 at 11:17 PM Aleksandar Markovic >>> wrote: >>> >> >>> >> >>> >>

Re: [PATCH v7 1/4] block: introducing 'bdrv_co_delete_file' interface

Am 03.09.2019 um 15:57 hat Daniel Henrique Barboza geschrieben: > Adding to Block Drivers the capability of being able to clean up > its created files can be useful in certain situations. For the > LUKS driver, for instance, a failure in one of its authentication > steps can leave files in the host

Re: [PATCH 3/4] target/arm: Convert PMULL.64 to gvec

Richard Henderson writes: > The gvec form will be needed for implementing SVE2. Hmm I'm seeing a failure against: aarch32-all-v80/insn_VMULL__INC.risu.bin From: https://fileserver.linaro.org/owncloud/index.php/s/hvEXM2eJ3uZVhlH https://fileserver.linaro.org/owncloud/index.php/s/hvEXM

Re: [PATCH v7 19/20] target/arm: Rebuild hflags for M-profile.

On Thu, 17 Oct 2019 at 19:51, Richard Henderson wrote: > > Continue setting, but not relying upon, env->hflags. > > Reviewed-by: Alex Bennée > Signed-off-by: Richard Henderson > --- > v7: Add rebuilds for v7m_msr and nvic_writel to v7m.ccr. > --- > hw/intc/armv7m_nvic.c | 1 + > target/arm/m_h

Re: [PATCH v7 17/20] target/arm: Rebuild hflags at MSR writes

On Thu, 17 Oct 2019 at 19:51, Richard Henderson wrote: > > Continue setting, but not relying upon, env->hflags. > > Reviewed-by: Alex Bennée > Signed-off-by: Richard Henderson > --- > target/arm/translate-a64.c | 13 +++-- > target/arm/translate.c | 28 +++- >

Re: [PATCH v7 2/4] block.c: adding bdrv_delete_file

Am 03.09.2019 um 15:57 hat Daniel Henrique Barboza geschrieben: > Using the new 'bdrv_co_delete_file' interface, bdrv_delete_file > can be used in a way similar of the existing bdrv_create_file to > to clean up a created file. > > The logic is also similar to what is already done in bdrv_create_fi

Re: [PATCH v7 3/4] crypto.c: cleanup created file when block_crypto_co_create_opts_luks fails

Am 03.09.2019 um 15:57 hat Daniel Henrique Barboza geschrieben: > When using a non-UTF8 secret to create a volume using qemu-img, the > following error happens: > > $ qemu-img create -f luks --object > secret,id=vol_1_encrypt0,file=vol_resize_pool.vol_1.secret.qzVQrI -o > key-secret=vol_1_encryp

Re: [PATCH v3] ssi: xilinx_spips: Skip spi bus update for few register writes

Hi Sai, On [2019 Oct 18] Fri 14:39:04, Sai Pavan Boddu wrote: > Few of the register writes need not update the spi bus state, so just > return after reg write. Added few more dummy register offsets which need > the same behaviour. > > Signed-off-by: Sai Pavan Boddu > --- > Changes for V2: >

Re: [PATCH] iotests: Skip read-only cases in 118 when run as root

Hi Kevin, On 10/18/19 1:51 PM, Kevin Wolf wrote: Some tests in 118 use chmod to remove write permissions from the file and assume that the image can indeed not be opened read-write afterwards. This doesn't work when the test is run as root, because root can still open the file as writable even w

Re: [PULL 1/4] ui: Fix hanging up Cocoa display on macOS 10.15 (Catalina)

On Freitag, 18. Oktober 2019 12:17:08 CEST Gerd Hoffmann wrote: > From: Hikaru Nishida > > macOS API documentation says that before applicationDidFinishLaunching > is called, any events will not be processed. However, some events are > fired before it is called in macOS Catalina. Even though fix

Re: [PULL 1/4] ui: Fix hanging up Cocoa display on macOS 10.15 (Catalina)

On Fri, 18 Oct 2019 at 14:01, Christian Schoenebeck wrote: > > On Freitag, 18. Oktober 2019 12:17:08 CEST Gerd Hoffmann wrote: > > From: Hikaru Nishida > > > > macOS API documentation says that before applicationDidFinishLaunching > > is called, any events will not be processed. However, some eve

[PATCH v2] Do not use %m in common code to print error messages

The %m format specifier is an extension from glibc - and when compiling QEMU for NetBSD, the compiler correctly complains, e.g.: /home/qemu/qemu-test.ELjfrQ/src/util/main-loop.c: In function 'sigfd_handler': /home/qemu/qemu-test.ELjfrQ/src/util/main-loop.c:64:13: warning: %m is only allowed in sy

Re: [PATCH 26/32] hw/pci-host/piix: Move RCR_IOPORT register definition

On Friday, October 18, 2019, Philippe Mathieu-Daudé wrote: > On 10/18/19 11:19 AM, Aleksandar Markovic wrote: > >> On Tuesday, October 15, 2019, Philippe Mathieu-Daudé > > wrote: >> >> From: Philippe Mathieu-Daudé mailto:f4...@amsat.org >> >> >> >> The RCR_IOPORT

[Bug 1846427] Re: 4.1.0: qcow2 corruption on savevm/quit/loadvm cycle

My qcow2 images also reside on an ext4 with features "has_journal ext_attr dir_index filetype needs_recovery extent 64bit flex_bg sparse_super large_file dir_nlink extra_isize metadata_csum" on a luks- encrypt(ed|ing) device mapper device backed by a partition on an NVMe SSD. The setup is rock soli

Re: [PATCH v2] Do not use %m in common code to print error messages

On Fri, Oct 18, 2019 at 03:07:16PM +0200, Thomas Huth wrote: > The %m format specifier is an extension from glibc - and when compiling > QEMU for NetBSD, the compiler correctly complains, e.g.: > > /home/qemu/qemu-test.ELjfrQ/src/util/main-loop.c: In function 'sigfd_handler': > /home/qemu/qemu-tes

RE: [Virtio-fs] [PATCH 0/2] virtiofsd: Two fix for xattr operation

> > Even simpler: allow O_PATH descriptors for f*xattr(). > > Attached patch. Will post shortly. > > However, I think it would make sense to fix virtiofsd as well, as this will > take time to percolate down, even if Al doesn't find > anything wrong with it. Thanks for you comments. Though I'm

Re: [PULL v3 00/19] Bitmaps patches

On Thu, 17 Oct 2019 at 22:54, John Snow wrote: > > The following changes since commit f22f553efffd083ff624be116726f843a39f1148: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20191013' into > staging (2019-10-17 16:48:56 +0100) > > are available in the Git repository at: > > http

Re: virtio-fs: Fix file ID collisions (was: 9p: Fix file ID collisions)

On Mittwoch, 16. Oktober 2019 15:44:09 CEST Dr. David Alan Gilbert wrote: > > > Unless I'm missing something, it seems that "virtio-fs" has the same > > > issue we had on 9pfs before Christian's patches... :-\ > > > > Is a fix for this desired for virtio-fs? > > Yes I think so; we had originally

Re: [PATCH v32 04/13] target/avr: Add instruction translation - Registers definition

On Friday, October 18, 2019, Michael Rolnik wrote: > > > On Fri, Oct 18, 2019 at 11:52 AM Aleksandar Markovic < > aleksandar.m.m...@gmail.com> wrote: > >> >> >> On Thursday, October 17, 2019, Michael Rolnik wrote: >> >>> On Thu, Oct 17, 2019 at 11:17 PM Aleksandar Markovic >>> wrote: >>> >> >>>

Re: [RFC 1/3] acpi: cpuhp: fix 'Command data' description is spec

On 10/17/19 17:41, Igor Mammedov wrote: > On Thu, 10 Oct 2019 14:33:19 +0200 > Laszlo Ersek wrote: > >> On 10/09/19 15:22, Igor Mammedov wrote: >>> QEMU returns 0, in case of erro or invalid value in 'Command field', >>> make spec match reality, i.e. >> >> Unfinished thought? > yep, I'll fix it

Re: [PATCH v5 4/5] tests/qapi-schema: Cover feature documentation comments

On 10/18/19 3:14 AM, Markus Armbruster wrote: Commit 8aa3a33e44 "tests/qapi-schema: Test for good feature lists in structs" neglected to cover documentation comments, and the previous commit followed its example. Make up for them. Signed-off-by: Markus Armbruster --- @@ -227,6 +241,14 @@ If

Re: [PATCH v2 01/23] iotests: Introduce $SOCK_DIR

On 10/18/19 4:03 AM, Max Reitz wrote:   -if [ ! -e "$TEST_DIR" ]; then -    mkdir "$TEST_DIR" +tmp_sock_dir=false +if [ -z "$SOCK_DIR" ]; then +    SOCK_DIR=$(mktemp -d) +    tmp_sock_dir=true   fi +mkdir -p "$SOCK_DIR" || _init_error 'Failed to create SOCK_DIR' Thinking about this again

[PATCH 0/4] mc146818rtc: Allow call object_initialize(MC146818_RTC) instead of rtc_init()

Four RTC146818 patches extracted from a bigger series: "hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge" https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg03685.html This step is required to be able to create a MC146818_RTC within a QOM object (which will be used in the "piix4:

[PATCH 1/4] mc146818rtc: move structure to header file

From: Hervé Poussineau We are now able to embed a timer in another object. Acked-by: Michael S. Tsirkin Acked-by: Paolo Bonzini Signed-off-by: Hervé Poussineau Message-Id: <20171216090228.28505-4-hpous...@reactos.org> Reviewed-by: Aleksandar Markovic Signed-off-by: Philippe Mathieu-Daudé --

[PATCH 3/4] mc146818rtc: Include mc146818rtc_regs.h directly in mc146818rtc.c

From: Philippe Mathieu-Daudé Devices/boards wanting to use the MC146818 RTC don't need the knowledge its internal registers. Move the "mc146818rtc_regs.h" inclusion to mc146818rtc.c where it is required. We can not move this file from include/hw/timer/ to hw/timer/ for local inclusion because th

[PATCH 2/4] mc146818rtc: Move RTC_ISA_IRQ definition

From: Philippe Mathieu-Daudé The ISA default number for the RTC devices is not related to its registers neither. Move this definition to "hw/timer/mc146818rtc.h". Signed-off-by: Philippe Mathieu-Daudé --- include/hw/timer/mc146818rtc.h | 2 ++ include/hw/timer/mc146818rtc_regs.h | 2 -- t

[PATCH 4/4] mc146818rtc: always register rtc to rtc list

From: Hervé Poussineau We are not required anymore to use rtc_init() function. Acked-by: Michael S. Tsirkin Acked-by: Paolo Bonzini Signed-off-by: Hervé Poussineau Message-Id: <20171216090228.28505-5-hpous...@reactos.org> [PMD: rebased, fix OBJECT() value] Signed-off-by: Philippe Mathieu-Daud

Re: [PATCH v7 1/2] docs: improve qcow2 spec about extending image header

On 10/18/19 4:27 AM, Vladimir Sementsov-Ogievskiy wrote: I would suggest a stronger requirement: header_length must be a multiple of 4, and must not land in the middle of any optional 8-byte field. Or maybe even add our compression type extension with 4 bytes of padding, so that we could go

Re: [PATCH 3/4] target/arm: Convert PMULL.64 to gvec

Alex Bennée writes: > Richard Henderson writes: > >> The gvec form will be needed for implementing SVE2. > > Hmm I'm seeing a failure against: > > aarch32-all-v80/insn_VMULL__INC.risu.bin I take it back, after monkey patching cortex-a53 into qemu-arm it passes. Reviewed-by: Alex Bennée Te

Re: [PATCH 2/4] target/arm: Convert PMUL.8 to gvec

Richard Henderson writes: > The gvec form will be needed for implementing SVE2. > > Extend the implementation to operate on uint64_t instead of uint32_t. > Use a counted inner loop instead of terminating when op1 goes to zero, > looking toward the required implementation for ARMv8.4-DIT. > > Si

Re: [PATCH v2] Do not use %m in common code to print error messages

On Fri, Oct 18, 2019 at 03:07:16PM +0200, Thomas Huth wrote: > The %m format specifier is an extension from glibc - and when compiling > QEMU for NetBSD, the compiler correctly complains, e.g.: > > /home/qemu/qemu-test.ELjfrQ/src/util/main-loop.c: In function 'sigfd_handler': > /home/qemu/qemu-tes

Re: [PATCH 04/32] mc146818rtc: Move RTC_ISA_IRQ definition

On Tuesday, October 15, 2019, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > The ISA default number for the RTC devices is not related to its > registers neither. Move this definition to "hw/timer/mc146818rtc.h". > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/ti

[PATCH v2 00/20] hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge

Changes since v1 [0]: - Removed patch reintroducing DO_UPCAST() use (thuth) - Took various patches out to reduce series (thuth) - Added review tags (thanks all for reviewing!) $ git backport-diff -u pc_split_i440fx_piix-v1 -r mc146818rtc_init.. Key: [] : patches are identical [] : number o

[PATCH v2 01/20] MAINTAINERS: Keep PIIX4 South Bridge separate from PC Chipsets

From: Philippe Mathieu-Daudé The PIIX4 Southbridge is not used by the PC machine, but by the Malta board (MIPS). Add a new section to keep it covered. Suggested-by: Michael S. Tsirkin Reviewed-by: Aleksandar Markovic Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 7 ++- 1 file c

[PATCH v2 04/20] Revert "irq: introduce qemu_irq_proxy()"

From: Philippe Mathieu-Daudé This function isn't used anymore. This reverts commit 22ec3283efba9ba0792790da786d6776d83f2a92. Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- hw/core/irq.c| 14 -- include/hw/irq.h | 5 - 2 files changed, 19 deletions(-)

[PATCH v2 02/20] piix4: Add the Reset Control Register

From: Hervé Poussineau The RCR I/O port (0xcf9) is used to generate a hard reset or a soft reset. Acked-by: Michael S. Tsirkin Acked-by: Paolo Bonzini Signed-off-by: Hervé Poussineau Message-Id: <20171216090228.28505-7-hpous...@reactos.org> Reviewed-by: Aleksandar Markovic [PMD: rebased, upd

[PATCH v2 03/20] piix4: Add a i8259 Interrupt Controller as specified in datasheet

From: Hervé Poussineau Add ISA irqs as piix4 gpio in, and CPU interrupt request as piix4 gpio out. Remove i8259 instanciated in malta board, to not have it twice. We can also remove the now unused piix4_init() function. Acked-by: Michael S. Tsirkin Acked-by: Paolo Bonzini Signed-off-by: Hervé

[PATCH v2 05/20] piix4: Rename PIIX4 object to piix4-isa

From: Hervé Poussineau Other piix4 parts are already named piix4-ide and piix4-usb-uhci. Reviewed-by: Philippe Mathieu-Daudé Acked-by: Michael S. Tsirkin Acked-by: Paolo Bonzini Signed-off-by: Hervé Poussineau Message-Id: <20171216090228.28505-15-hpous...@reactos.org> Reviewed-by: Aleksandar

[PATCH v2 10/20] hw/mips/mips_malta: Extract the PIIX4 creation code as piix4_create()

The Malta board instantiate a PIIX4 chipset doing various calls. Refactor all those related calls into a single function: piix4_create(). Reviewed-by: Aleksandar Markovic Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/mips_malta.c | 47 +++- 1 file cha

[PATCH v2 09/20] hw/mips/mips_malta: Create IDE hard drive array dynamically

In the next commit we'll refactor the PIIX4 code out of mips_malta_init(). As a preliminary step, add the 'ide_drives' variable and create the drive array dynamically. Reviewed-by: Aleksandar Markovic Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/mips_malta.c | 7 +-- 1 file changed, 5

Re: [PATCH v2] Do not use %m in common code to print error messages

On 18.10.2019 15:42, Stefano Garzarella wrote: > On Fri, Oct 18, 2019 at 03:07:16PM +0200, Thomas Huth wrote: >> The %m format specifier is an extension from glibc - and when compiling >> QEMU for NetBSD, the compiler correctly complains, e.g.: >> >> /home/qemu/qemu-test.ELjfrQ/src/util/main-loop.c

[PATCH v2 06/20] piix4: Add a i8257 DMA Controller as specified in datasheet

From: Hervé Poussineau Remove i8257 instantiated in malta board, to not have it twice. Acked-by: Michael S. Tsirkin Acked-by: Paolo Bonzini Signed-off-by: Hervé Poussineau Message-Id: <20171216090228.28505-9-hpous...@reactos.org> Reviewed-by: Aleksandar Markovic [PMD: rebased] Signed-off-by:

[PATCH v2 11/20] hw/isa/piix4: Move piix4_create() to hw/isa/piix4.c

From: Philippe Mathieu-Daudé Now that we properly refactored the piix4_create() function, let's move it to hw/isa/piix4.c where it belongs, so it can be reused on other places. Reviewed-by: Aleksandar Markovic Signed-off-by: Philippe Mathieu-Daudé --- hw/isa/piix4.c| 30 ++

[PATCH v2 08/20] piix4: Add a MC146818 RTC Controller as specified in datasheet

From: Philippe Mathieu-Daudé Remove mc146818rtc instanciated in malta board, to not have it twice. Acked-by: Michael S. Tsirkin Acked-by: Paolo Bonzini Signed-off-by: Hervé Poussineau Message-Id: <20171216090228.28505-13-hpous...@reactos.org> [PMD: rebased, set RTC base_year to 2000] Reviewed

[PATCH v2 14/20] hw/pci-host/piix: Move RCR_IOPORT register definition

From: Philippe Mathieu-Daudé The RCR_IOPORT register belongs to the PIIX chipset. Move the definition to "piix.h", and prepend the PIIX prefix. Reviewed-by: Aleksandar Markovic Signed-off-by: Philippe Mathieu-Daudé --- v2: prepend PIIX prefix (Aleksandar) --- hw/i386/acpi-build.c | 2

Re: Default CPU models on s390x and ppc64

On Thu, Oct 17, 2019 at 17:35:30 +0200, David Hildenbrand wrote: > On 17.10.19 17:31, David Hildenbrand wrote: > > On 17.10.19 17:18, David Hildenbrand wrote: > >> On 17.10.19 17:16, Jiri Denemark wrote: > >>> Hi David and David, > >>> > >>> I'm working on libvirt's support [1] for query-machines'

[PATCH v2 19/20] hw/pci-host: Rename incorrectly named 'piix' as 'i440fx'

From: Philippe Mathieu-Daudé We moved all the PIIX3 southbridge code out of hw/pci-host/piix.c, it now only contains i440FX northbridge code. Rename it to match the chipset modelled. Reviewed-by: Aleksandar Markovic Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS |

[PATCH v2 12/20] hw/i386: Remove obsolete LoadStateHandler::load_state_old handlers

These devices implemented their load_state_old() handler 10 years ago, previous to QEMU v0.12. Since commit cc425b5ddf removed the pc-0.10 and pc-0.11 machines, we can drop this code. Note: the mips_r4k machine started to use the i8254 device just after QEMU v0.5.0, but the MIPS machine types are

[PATCH 3/5] hw/i386/pc: Move gsi_state creation code

The code block related to IRQ starts few lines later. Move the comment and the pc_gsi_create() invocation where we start to use the IRQs. Signed-off-by: Philippe Mathieu-Daudé --- v2: reword comment (Aleksandar) --- hw/i386/pc_q35.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) di

[PATCH v2 18/20] hw/pci-host/piix: Extract PIIX3 functions to hw/isa/piix3.c

From: Philippe Mathieu-Daudé Move all the PIIX3 functions to a new file: hw/isa/piix3.c. Reviewed-by: Aleksandar Markovic Signed-off-by: Philippe Mathieu-Daudé --- Checkpatch warning: ERROR: spaces required around that '*' (ctx:VxV) #312: FILE: hw/isa/piix3.c:248: +.subsections = (cons

[PATCH v2 07/20] piix4: Add a i8254 PIT Controller as specified in datasheet

From: Hervé Poussineau Remove i8254 instanciated in malta board, to not have it twice. Acked-by: Michael S. Tsirkin Acked-by: Paolo Bonzini Signed-off-by: Hervé Poussineau Message-Id: <20171216090228.28505-10-hpous...@reactos.org> Reviewed-by: Aleksandar Markovic Signed-off-by: Philippe Math

[PATCH 4/5] hw/i386/pc: Extract pc_i8259_create()

The i8259 creation code is common to all PC machines, extract the common code. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 19 +++ hw/i386/pc_piix.c| 13 + hw/i386/pc_q35.c | 14 +- include/hw/i386/pc.h | 1 + 4 files changed,

Re: [PATCH v8 3/3] docs: qcow2: introduce compression type feature

On 10/18/19 4:47 AM, Vladimir Sementsov-Ogievskiy wrote: The patch add new additional field to qcow2 header: compression_type, which specifies compression type. If field is absent or zero, default compression type is set: ZLIB, which corresponds to current behavior. New compression type (ZSTD) i

[PATCH v2 20/20] hw/pci-host/i440fx: Remove the last PIIX3 traces

The PIIX3 is not tied to the i440FX and can even be used without it. Move its creation to the machine code (pc_piix.c). We have now removed the last trace of southbridge code in the i440FX northbridge. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc_piix.c| 8 +++- hw/pci-ho

Re: [PATCH v32 04/13] target/avr: Add instruction translation - Registers definition

On Fri, Oct 18, 2019 at 4:23 PM Aleksandar Markovic wrote: > > > > On Friday, October 18, 2019, Michael Rolnik wrote: >> >> >> >> On Fri, Oct 18, 2019 at 11:52 AM Aleksandar Markovic >> wrote: >>> >>> >>> >>> On Thursday, October 17, 2019, Michael Rolnik wrote: On Thu, Oct 17, 2019 a

[PATCH v2 13/20] hw/pci-host/piix: Extract piix3_create()

Extract the PIIX3 creation code from the i440fx_init() function. Reviewed-by: Aleksandar Markovic Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/piix.c | 51 -- 1 file changed, 31 insertions(+), 20 deletions(-) diff --git a/hw/pci-host/piix.c

[PATCH v2 15/20] hw/pci-host/piix: Define and use the PIIX IRQ Route Control Registers

The IRQ Route Control registers definitions belong to the PIIX chipset. We were only defining the 'A' register. Define the other B, C and D registers, and use them. Acked-by: Paul Durrant Reviewed-by: Aleksandar Markovic Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/xen/xen-hvm.c |

[PATCH 1/5] hw/i386/pc: Extract pc_gsi_create()

The GSI creation code is common to all PC machines, extract the common code. Reviewed-by: Aleksandar Markovic Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 15 +++ hw/i386/pc_piix.c| 9 + hw/i386/pc_q35.c | 9 +

[PATCH v2 16/20] hw/pci-host/piix: Move i440FX declarations to hw/pci-host/i440fx.h

From: Philippe Mathieu-Daudé The hw/pci-host/piix.c contains a mix of PIIX3 and i440FX chipsets functions. To be able to split it, we need to export some declarations first. Reviewed-by: Aleksandar Markovic Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + hw/acpi

Re: [PATCH v8 2/3] docs: define padding for qcow2 header

On 10/18/19 4:47 AM, Vladimir Sementsov-Ogievskiy wrote: Header extensions ends are already defined to be multiply of 8. Let's gently ask for header length to be a multiply of 8 too, when we have some additional fields. Requiring this may be considered as an incompatible change, so the padding is

[PATCH v2 17/20] hw/pci-host/piix: Fix code style issues

We will move this code, fix its style first. Reviewed-by: Aleksandar Markovic Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/piix.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c index 95b04122fa..1544c4726b 100644 --- a

Re: [PATCH v7 1/2] docs: improve qcow2 spec about extending image header

18.10.2019 16:39, Eric Blake wrote: > On 10/18/19 4:27 AM, Vladimir Sementsov-Ogievskiy wrote: > > I would suggest a stronger requirement: > > header_length must be a multiple of 4, and must not land in the middle of > any optional 8-byte field. > > Or maybe even add our c

Re: [PATCH] qemu-img.texi: Describe data_file and data_file_raw

[cc qemu-block] On 10/18/19 4:59 AM, Han Han wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1763105 Signed-off-by: Han Han --- qemu-img.texi | 10 ++ 1 file changed, 10 insertions(+) Reviewed-by: Eric Blake diff --git a/qemu-img.texi b/qemu-img.texi index b5156d6316..44596

[PATCH 0/5] hw/i386/pc: Extract pc_gsi_create() and pc_i8259_create()

These are few patches extracted from the previous too big series: hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg03685.html Dropped "Move kvm_i8259_init() declaration to sysemu/kvm.h" (thuth), no logical changes: $ git backport

Re: [for-4.2 PATCH 3/6] replay: update docs for record/replay with block devices

Am 18.10.2019 um 14:06 hat Pavel Dovgalyuk geschrieben: > > From: Kevin Wolf [mailto:kw...@redhat.com] > > Am 11.10.2019 um 08:10 hat Pavel Dovgalyuk geschrieben: > > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > > Am 25.09.2019 um 11:02 hat Pavel Dovgalyuk geschrieben: > > > > > I started p

[PATCH 2/5] hw/i386/pc: Reduce gsi_handler scope

pc_gsi_create() is the single function that uses gsi_handler. Make it a static variable. Reviewed-by: Aleksandar Markovic Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 2 +- include/hw/i386/pc.h | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-)

Re: [PATCH v8 1/3] docs: improve qcow2 spec about extending image header

On 10/18/19 4:47 AM, Vladimir Sementsov-Ogievskiy wrote: Make it more obvious how to add new fields to the version 3 header and how to interpret them. The specification is adjusted so for new defined optional fields: The specification is adjusted to make it clear that future fields are option

Re: Default CPU models on s390x and ppc64

On Thu, Oct 17, 2019 at 17:13:10 +0100, Peter Maydell wrote: > On Thu, 17 Oct 2019 at 17:09, David Hildenbrand wrote: > > The default model under KVM is "host", under TCG it's "qemu". We should > > not use "qemu" under KVM, although it might work on some setups ... > > Possibly a tangent, but on

Re: [PATCH 0/2] tests/acceptance: Add tests for the PA-RISC machine

ping? Sven since you tested this series, can I add your Tested-by tag? On Thu, Oct 10, 2019 at 2:21 PM Philippe Mathieu-Daudé wrote: > > This tests boot a HP-UX firmware CD-ROM which allow serial > console interaction. This exercise the PCI LSI53C895A SCSI > controller. > > I'm not adding it to

Re: [PULL 1/4] ui: Fix hanging up Cocoa display on macOS 10.15 (Catalina)

On Freitag, 18. Oktober 2019 15:02:49 CEST Peter Maydell wrote: > On Fri, 18 Oct 2019 at 14:01, Christian Schoenebeck > > wrote: > > On Freitag, 18. Oktober 2019 12:17:08 CEST Gerd Hoffmann wrote: > > > From: Hikaru Nishida > > > > > > macOS API documentation says that before applicationDidFini

Re: Default CPU models on s390x and ppc64

On Fri, 18 Oct 2019 at 15:02, Jiri Denemark wrote: > > On Thu, Oct 17, 2019 at 17:13:10 +0100, Peter Maydell wrote: > > On Thu, 17 Oct 2019 at 17:09, David Hildenbrand wrote: > > > The default model under KVM is "host", under TCG it's "qemu". We should > > > not use "qemu" under KVM, although it

Re: [PATCH] iotests: Skip read-only cases in 118 when run as root

Am 18.10.2019 um 14:59 hat Philippe Mathieu-Daudé geschrieben: > Hi Kevin, > > On 10/18/19 1:51 PM, Kevin Wolf wrote: > > Some tests in 118 use chmod to remove write permissions from the file > > and assume that the image can indeed not be opened read-write > > afterwards. This doesn't work when t

Re: Default CPU models on s390x and ppc64

I don't see how the default cpu model could not be "host" if qemu was started with "--enable-kvm" I guess the problem could be that QEMU capabilities probing in libvirt is done with -machine none. We first probe with KVM enabled and then for a few specific commands reprobe with TCG only. We coul

[PATCH] virtio-blk: Add blk_drain() to virtio_blk_device_unrealize()

QEMU does not wait for completed I/O requests, assuming that the guest driver will reset the device before calling unrealize(). This does not happen on Windows, and QEMU crashes in virtio_notify(), getting the result of a completed I/O request on hot-unplugged device. Signed-off-by: Julia Suvorova

Re: Python 2 and test/vm/netbsd

On Fri, Oct 18, 2019 at 12:44:39PM +0200, Gerd Hoffmann wrote: > Hi, > > > > Running with V=1, I see packages being downloaded at reasonable speeds, > > > but > > > there's a huge interval (of various minutes) between each package > > > download. > > > > I've found the cause for the slowness

[PATCH] hw/timer/exynos4210_mct: Initialize ptimer before starting it

From: Guenter Roeck When booting a recent Linux kernel, the qemu message "Timer with delta zero, disabling" is seen, apparently because a ptimer is started before being initialized. Fix the problem by initializing the offending ptimer before starting it. The bug is effectively harmless in the o

<    1   2   3   4   5   >