Re: [PATCH] target/arm: Fix sign-extension for SMLAL*

On Tue, 15 Oct 2019 at 00:42, Richard Henderson wrote: > > Ping. > > On 9/12/19 11:30 AM, Richard Henderson wrote: > > The 32-bit product should be sign-extended, not zero-extended. > > > > Fixes: ea96b374641b > > Reported-by: Laurent Desnogues > > Signed-off-by: Richard Henderson Applied to

Re: [PATCH] hw/timer/arm_mptimer.c: Undo accidental rename of arm_mptimer_init()

On 10/17/19 6:33 AM, Peter Maydell wrote: > In commit b01422622b we did an automated rename of the ptimer_init() > function to ptimer_init_with_bh(). Unfortunately this caught the > unrelated arm_mptimer_init() function. Undo that accidental > renaming. > > Fixes: b01422622b7c7293196fdaf1dbb4f49

[PATCH v6 27/54] target/hppa: fetch code with translator_ld

From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée --- target/hppa/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index c1b2822f60..2f8d407a82 100644

[PATCH v6 28/54] target/m68k: fetch code with translator_ld

From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée --- target/m68k/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index 24c1dd3408..fcdb7bc8e4 100644

Re: [PATCH 2/2] hw/timer/slavio_timer.c: Switch to transaction-based ptimer API

On 10/17/19 6:23 AM, Peter Maydell wrote: > Switch the slavio_timer code away from bottom-half based ptimers to > the new transaction-based ptimer API. This just requires adding > begin/commit calls around the various places that modify the ptimer > state, and using the new ptimer_init() function

[PATCH v6 38/54] plugin: add qemu_plugin_insn_disas helper

Give the plugins access to the QEMU dissasembler so they don't have to re-invent the wheel. We generate a warning when there are spare bytes in the decode buffer. This is usually due to the front end loading in more bytes than decoded. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson -

[PATCH v6 49/54] tests/plugin: add instruction execution breakdown

This gives a break down of instruction classes and individual instruction types. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v5 - add a bitmap guide to the comment ;-) v6 - init api update - merge updates --- tests/plugin/Makefile | 1 + tests/plugin/howvec.c | 352 +++

Re: [PATCH] sphinx: Use separate doctree directories for different builders

On Mon, 14 Oct 2019 at 16:01, Eduardo Habkost wrote: > > sphinx-build is buggy when multiple processes are using the same > doctree directory in parallel. See the 3-year-old Sphinx bug > report at: https://github.com/sphinx-doc/sphinx/issues/2946 > > Instead of avoiding parallel builds or adding

Re: [PATCH v2 5/7] libqos: expose common virtqueue setup/cleanup functions

On 11/10/2019 10.56, Stefan Hajnoczi wrote: > The VIRTIO 1.0 code will need to perform additional steps but it will > reuse the common virtqueue setup/cleanup code. Make these functions > public. > > Make sure to invoke callbacks via QVirtioBus instead of directly calling > the virtio-pci Legacy

Re: [PATCH 07/32] MAINTAINERS: Keep PIIX4 South Bridge separate from PC Chipsets

On Tuesday, October 15, 2019, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > The PIIX4 Southbridge is not used by the PC machine, > but by the Malta board (MIPS). Add a new section to > keep it covered. > > Suggested-by: Michael S. Tsirkin > Signed-off-by: Philippe Mathieu-Dau

Re: [PATCH v1] s390x/mmu: Remove duplicate check for MMU_DATA_STORE

On Thu, 17 Oct 2019 14:19:22 +0200 David Hildenbrand wrote: > No need to double-check if we have a write. > > Found by Coverity (CID: 1381016). > > Fixes: 31b59419069e ("target/s390x: Return exception from mmu_translate_real") > Cc: Peter Maydell > Signed-off-by: David Hildenbrand > --- > ta

Re: [PATCH v3 0/10] add failover feature for assigned network devices

On Thu, Oct 17, 2019 at 06:51:54AM -0600, Alex Williamson wrote: On Thu, 17 Oct 2019 12:33:47 +0200 Jens Freimann wrote: On Tue, Oct 15, 2019 at 01:03:17PM -0600, Alex Williamson wrote: >On Fri, 11 Oct 2019 13:20:05 +0200 >Jens Freimann wrote: > >> This is implementing the host side of the ne

Re: [PATCH 10/32] piix4: add a i8259 interrupt controller as specified in datasheet

On Tuesday, October 15, 2019, Philippe Mathieu-Daudé wrote: > From: Hervé Poussineau > > Add ISA irqs as piix4 gpio in, and CPU interrupt request as piix4 gpio out. > Remove i8259 instanciated in malta board, to not have it twice. > > We can also remove the now unused piix4_init() function. > >

[PATCH] hw/s390x: Emit a warning if user tried to enable USB

There is no USB on s390x, so running qemu-system-s390x with "-machine ...,usb=on" is certainly wrong. Emit a warning to make the users aware of their misconfiguration. Signed-off-by: Thomas Huth --- After a year or two, we could finally turn this into a hard error, but I think we should give th

Re: [PATCH 1/2] hw/timer/grlib_gptimer.c: Switch to transaction-based ptimer API

On 10/17/19 6:23 AM, Peter Maydell wrote: > Switch the grlib_gptimer code away from bottom-half based ptimers to > the new transaction-based ptimer API. This just requires adding > begin/commit calls around the various places that modify the ptimer > state, and using the new ptimer_init() function

Re: [PATCH] hw/s390x: Emit a warning if user tried to enable USB

On 17/10/2019 16.34, Cornelia Huck wrote: > On Thu, 17 Oct 2019 16:21:23 +0200 > Thomas Huth wrote: > >> There is no USB on s390x, so running qemu-system-s390x with >> "-machine ...,usb=on" is certainly wrong. Emit a warning to make >> the users aware of their misconfiguration. >> >> Signed-off-b

Re: [PATCH v12 09/11] hmat acpi: Build System Locality Latency and Bandwidth Information Structure(s)

On Tue, 15 Oct 2019 13:40:54 +0800 Tao Xu wrote: > On 10/15/2019 8:59 AM, Tao Xu wrote: > > On 10/14/2019 5:00 PM, Igor Mammedov wrote: > >> On Sat, 12 Oct 2019 11:04:03 +0800 > >> Tao Xu wrote: > >> > >>> On 10/11/2019 10:08 PM, Igor Mammedov wrote: > On Thu, 10 Oct 2019 14:53:56 +08

Re: [PATCH] hw/s390x: Emit a warning if user tried to enable USB

On Thu, 17 Oct 2019 16:21:23 +0200 Thomas Huth wrote: > There is no USB on s390x, so running qemu-system-s390x with > "-machine ...,usb=on" is certainly wrong. Emit a warning to make > the users aware of their misconfiguration. > > Signed-off-by: Thomas Huth > --- > After a year or two, we cou

[PATCH v2] Added hardfloat conversion from float32 to float64

Reintroduce float32_to_float64 that was removed here: https://lists.gnu.org/archive/html/qemu-devel/2018-04/msg00455.html - nbench test it not actually calling this function at all - SPECS 2006 significat number of tests impoved their runtime, just few of them showed small slowdown Signed-of

[PATCH] block/backup: drop dead code from backup_job_create

After commit 00e30f05de1d195, there is no more "goto error" points after job creation, so after "error:" @job is always NULL and we don't need roll-back job creation. Reported-by: Coverity (CID 1406402) Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/backup.c | 5 + 1 file changed, 1 i

Re: [PATCH 14/32] piix4: add a i8257 dma controller as specified in datasheet

On Tuesday, October 15, 2019, Philippe Mathieu-Daudé wrote: > From: Hervé Poussineau > > Remove i8257 instanciated in malta board, to not have it twice. > > Acked-by: Michael S. Tsirkin > Acked-by: Paolo Bonzini > Signed-off-by: Hervé Poussineau > Message-Id: <20171216090228.28505-9-hpous...@

Re: [PATCH 15/32] piix4: add a i8254 pit controller as specified in datasheet

On Tuesday, October 15, 2019, Philippe Mathieu-Daudé wrote: > From: Hervé Poussineau > > Remove i8254 instanciated in malta board, to not have it twice. > > Acked-by: Michael S. Tsirkin > Acked-by: Paolo Bonzini > Signed-off-by: Hervé Poussineau > Message-Id: <20171216090228.28505-10-hpous...

Re: [PATCH 1/8] hw/timer/puv3_ost.c: Switch to transaction-based ptimer API

On 10/17/19 6:28 AM, Peter Maydell wrote: > Switch the puv3_ost code away from bottom-half based ptimers to the > new transaction-based ptimer API. This just requires adding > begin/commit calls around the various places that modify the ptimer > state, and using the new ptimer_init() function to c

Re: [PATCH] hw/timer/arm_mptimer.c: Undo accidental rename of arm_mptimer_init()

On 10/17/19 3:33 PM, Peter Maydell wrote: In commit b01422622b we did an automated rename of the ptimer_init() function to ptimer_init_with_bh(). Unfortunately this caught the unrelated arm_mptimer_init() function. Undo that accidental renaming. Fixes: b01422622b7c7293196fdaf1dbb4f495af44ecf9

Re: [PATCH v2 6/7] libqos: make the virtio-pci BAR index configurable

On 11/10/2019 10.56, Stefan Hajnoczi wrote: > The Legacy virtio-pci interface always uses BAR 0. VIRTIO 1.0 may need > to use a different BAR index, so make it configurable. > > Signed-off-by: Stefan Hajnoczi > --- > tests/libqos/virtio-pci.h | 2 ++ > tests/libqos/virtio-pci.c | 3 ++- > 2 fil

[PATCH 0/2] spapr: interrupt presenter fixes

Hello, First add a cpu_intc_reset() handler to reset interrupt presenters which are not today and Introduce a 'os-cam' property which will be used to set the OS CAM line at reset. Thanks, C. Cédric Le Goater (2): spapr: Introduce a interrupt presenter reset handler spapr/xive: Set the OS CA

Re: [PATCH] hw/s390x: Emit a warning if user tried to enable USB

On 17.10.19 16:21, Thomas Huth wrote: > There is no USB on s390x, so running qemu-system-s390x with > "-machine ...,usb=on" is certainly wrong. Emit a warning to make > the users aware of their misconfiguration. > > Signed-off-by: Thomas Huth > --- > After a year or two, we could finally turn

Re: [PATCH 18/32] hw/mips/mips_malta: Extract the PIIX4 creation code as piix4_create()

On Tuesday, October 15, 2019, Philippe Mathieu-Daudé wrote: > The Malta board instantiate a PIIX4 chipset doing various > calls. Refactor all those related calls into a single > function: piix4_create(). > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/mips/mips_malta.c | 47 +++

[PATCH 2/2] spapr/xive: Set the OS CAM line at reset

When a Virtual Processor is scheduled to run on a HW thread, the hypervisor pushes its identifier in the OS CAM line. When running in TCG or kernel_irqchip=off, QEMU needs to emulate the same behavior. Introduce a 'os-cam' property which will be used to set the OS CAM line at reset and remove the

Re: [Virtio-fs] [PATCH 2/2] virtiofsd: move to a new pid namespace

On Wed, Oct 16, 2019 at 05:01:57PM +0100, Stefan Hajnoczi wrote: [..] > + /* > + * If the mounts have shared propagation then we want to opt out so our > + * mount changes don't affect the parent mount namespace. > + */ > + if (mount(NULL, "/", NULL, MS_REC|MS_SLAVE, NULL) <

Re: [PATCH 01/32] hw/i386: Remove obsolete LoadStateHandler::load_state_old handlers

On Tuesday, October 15, 2019, Philippe Mathieu-Daudé wrote: > These devices implemented their load_state_old() handler 10 years > ago, previous to QEMU v0.12. > Since commit cc425b5ddf removed the pc-0.10 and pc-0.11 machines, > we can drop this code. > > Note: the mips_r4k machine started to use

Re: [PATCH 19/32] hw/isa/piix4: Move piix4_create() to hw/isa/piix4.c

On Tuesday, October 15, 2019, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > Now that we properly refactored the piix4_create() function, let's > move it to hw/isa/piix4.c where it belongs, so it can be reused > on other places. > > Signed-off-by: Philippe Mathieu-Daudé > ---

Re: [PATCH 2/8] hw/timer/sh_timer: Switch to transaction-based ptimer API

On 10/17/19 6:28 AM, Peter Maydell wrote: > Switch the sh_timer code away from bottom-half based ptimers to the > new transaction-based ptimer API. This just requires adding > begin/commit calls around the various places that modify the ptimer > state, and using the new ptimer_init() function to c

Re: [PATCH 16/32] piix4: add a mc146818rtc controller as specified in datasheet

On Tuesday, October 15, 2019, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > Remove mc146818rtc instanciated in malta board, to not have it twice. > > Acked-by: Michael S. Tsirkin > Acked-by: Paolo Bonzini > Signed-off-by: Hervé Poussineau > Message-Id: <20171216090228.28505

Re: [PATCH v2 2/3] iotests: Include QMP input in .out files

On 10/17/19 7:59 AM, Max Reitz wrote: On 15.10.19 21:35, Eric Blake wrote: We generally include relevant HMP input in .out files, by virtue of the fact that HMP echoes its input. But QMP does not, so we have to explicitly inject it in the output stream, in order to make it easier to read .out f

Re: [PATCH 1/2] hw/timer/grlib_gptimer.c: Switch to transaction-based ptimer API

On 10/17/19 3:23 PM, Peter Maydell wrote: Switch the grlib_gptimer code away from bottom-half based ptimers to the new transaction-based ptimer API. This just requires adding begin/commit calls around the various places that modify the ptimer state, and using the new ptimer_init() function to

Re: [PATCH v2 7/7] libqos: add VIRTIO PCI 1.0 support

On 11/10/2019 10.56, Stefan Hajnoczi wrote: > Implement the VIRTIO 1.0 virtio-pci interface. The main change here is > that the register layout is no longer a fixed layout in BAR 0. Instead > we have to iterate of PCI Capabilities to find descriptions of where > various registers are located. Th

[PATCH 1/2] spapr: Introduce a interrupt presenter reset handler

The interrupt presenters are not reseted today. Extend the sPAPR IRQ backend with a new cpu_intc_reset() handler which will be called by the CPU reset handler. spapr_realize_vcpu() is modified to call the CPU reset only after the the intc presenter has been created. Signed-off-by: Cédric Le Goate

Re: [PATCH 2/2] hw/timer/slavio_timer.c: Switch to transaction-based ptimer API

Hi Peter, On 10/17/19 3:23 PM, Peter Maydell wrote: Switch the slavio_timer code away from bottom-half based ptimers to the new transaction-based ptimer API. This just requires adding begin/commit calls around the various places that modify the ptimer state, and using the new ptimer_init() func

Re: [PATCH 17/32] hw/mips/mips_malta: Create IDE hard drive array dynamically

On Tuesday, October 15, 2019, Philippe Mathieu-Daudé wrote: > In the next commit we'll refactor the PIIX4 code out of > mips_malta_init(). As a preliminary step, add the 'ide_drives' > variable and create the drive array dynamically. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/mips/mip

Re: [PATCH 12/32] piix4: rename PIIX4 object to piix4-isa

On Tuesday, October 15, 2019, Philippe Mathieu-Daudé wrote: > From: Hervé Poussineau > > Other piix4 parts are already named piix4-ide and piix4-usb-uhci. > > Reviewed-by: Philippe Mathieu-Daudé > Acked-by: Michael S. Tsirkin > Acked-by: Paolo Bonzini > Signed-off-by: Hervé Poussineau > Mess

Re: [PATCH v2 01/23] iotests: Introduce $SOCK_DIR

On 10/17/19 8:31 AM, Max Reitz wrote: Unix sockets generally have a maximum path length. Depending on your $TEST_DIR, it may be exceeded and then all tests that create and use Unix sockets there may fail. Circumvent this by adding a new scratch directory specifically for Unix socket files. It

Re: [PULL 00/23] tcg patch queue

On 10/13/19 3:25 PM, Richard Henderson wrote: > The following changes since commit 9e5319ca52a5b9e84d55ad9c36e2c0b317a122bb: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2019-10-04 18:32:34 +0100) > > are available in the Git repository at: > > https:

[PATCH 0/4] crypto: improve performance of ciphers in XTS mode

Currently QEMU uses its own XTS cipher mode, however, this has relatively poor performance. Gcrypt now includes its own XTS cipher which is at least x2 faster than what we get with QEMU's on Fedora/RHEL hosts. With gcrypt git master, a further x5-6 speed up is seen. This is essential for QEMU's L

Re: [PATCH 3/8] hw/timer/lm32_timer: Switch to transaction-based ptimer API

On 10/17/19 6:29 AM, Peter Maydell wrote: > Switch the lm32_timer code away from bottom-half based ptimers to the > new transaction-based ptimer API. This just requires adding > begin/commit calls around the various places that modify the ptimer > state, and using the new ptimer_init() function to

[PATCH 1/4] tests: allow filtering crypto cipher benchmark tests

Add support for specifying a cipher mode and chunk size as argv to filter which combinations are benchmarked. For example to only benchmark XTS mode with 512 byte chunks: ./tests/benchmark-crypto-cipher xts 512 Signed-off-by: Daniel P. Berrangé --- tests/benchmark-crypto-cipher.c | 13 +++

Re: [PATCH 2/3] hw/timer/xilinx_timer.c: Switch to transaction-based ptimer API

Hi Peter, On 10/17/19 3:21 PM, Peter Maydell wrote: Switch the xilinx_timer code away from bottom-half based ptimers to the new transaction-based ptimer API. This just requires adding begin/commit calls around the various places that modify the ptimer state, and using the new ptimer_init() func

[PATCH 4/4] crypto: add support for nettle's native XTS impl

Nettle 3.5.0 will add support for the XTS mode. Use this because long term we wish to delete QEMU's XTS impl to avoid carrying private crypto algorithm impls. Unfortunately this degrades nettle performance from 612 MB/s to 568 MB/s as nettle's XTS impl isn't so well optimized yet. Signed-off-by:

Re: [PATCH 4/8] hw/watchdog/milkymist-sysctl.c: Switch to transaction-based ptimer API

On 10/17/19 6:29 AM, Peter Maydell wrote: > Switch the milkymist-sysctl code away from bottom-half based > ptimers to the new transaction-based ptimer API. This just requires > adding begin/commit calls around the various places that modify the > ptimer state, and using the new ptimer_init() funct

Re: [PATCH v2 00/23] iotests: Add and use $SOCK_DIR

On 10/17/19 8:31 AM, Max Reitz wrote: Hi, Perhaps the main reason we cannot run important tests such as 041 in CI is that when they care Unix sockets in $TEST_DIR, the path may become too long to connect to them. To get by this problem, this series lets the check script create a new temporary d

Re: [PATCH 02/32] hw/i386/pc: Move kvm_i8259_init() declaration to sysemu/kvm.h

On Tuesday, October 15, 2019, Philippe Mathieu-Daudé wrote: > Move the KVM-related call to "sysemu/kvm.h". > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/i386/pc.h | 1 - > include/sysemu/kvm.h | 1 + > 2 files changed, 1 insertion(+), 1 deletion(-) > > Is there any other similar

Re: [PATCH 04/32] mc146818rtc: Move RTC_ISA_IRQ definition

On Tuesday, October 15, 2019, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > The ISA default number for the RTC devices is not related to its > registers neither. Move this definition to "hw/timer/mc146818rtc.h". > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/ti

[PATCH 2/4] tests: benchmark crypto with fixed data size, not time period

Currently the crypto benchmarks are processing data in varying chunk sizes, over a fixed time period. This turns out to be a terrible idea because with small chunk sizes the overhead of checking the elapsed time on each loop iteration masks the true performance. Benchmarking over a fixed data size

Re: [PATCH 1/3] hw/net/fsl_etsec/etsec.c: Switch to transaction-based ptimer API

On 10/17/19 3:21 PM, Peter Maydell wrote: Switch the fsl_etsec code away from bottom-half based ptimers to the new transaction-based ptimer API. This just requires adding begin/commit calls around the various places that modify the ptimer state, and using the new ptimer_init() function to create

[PATCH 3/4] crypto: add support for gcrypt's native XTS impl

Libgcrypt 1.8.0 added support for the XTS mode. Use this because long term we wish to delete QEMU's XTS impl to avoid carrying private crypto algorithm impls. As an added benefit, using this improves performance from 531 MB/sec to 670 MB/sec, since we are avoiding several layers of function call i

Re: [PATCH 02/32] hw/i386/pc: Move kvm_i8259_init() declaration to sysemu/kvm.h

On 15/10/2019 18.26, Philippe Mathieu-Daudé wrote: > Move the KVM-related call to "sysemu/kvm.h". > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/i386/pc.h | 1 - > include/sysemu/kvm.h | 1 + > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/hw/i386/pc.h b/

Re: [PATCH 6/8] hw/watchdog/etraxfs_timer.c: Switch to transaction-based ptimer API

On 10/17/19 6:29 AM, Peter Maydell wrote: > Switch the etraxfs_timer code away from bottom-half based ptimers to > the new transaction-based ptimer API. This just requires adding > begin/commit calls around the various places that modify the ptimer > state, and using the new ptimer_init() function

Re: [PATCH 2/2] hw/timer/slavio_timer.c: Switch to transaction-based ptimer API

On Thu, 17 Oct 2019 at 15:54, Philippe Mathieu-Daudé wrote: > > Hi Peter, > > On 10/17/19 3:23 PM, Peter Maydell wrote: > > Switch the slavio_timer code away from bottom-half based ptimers to > > the new transaction-based ptimer API. This just requires adding > > begin/commit calls around the var

Re: [PATCH 09/32] piix4: add Reset Control Register

On Tuesday, October 15, 2019, Philippe Mathieu-Daudé wrote: > From: Hervé Poussineau > > The RCR I/O port (0xcf9) is used to generate a hard reset or a soft reset. > > Acked-by: Michael S. Tsirkin > Acked-by: Paolo Bonzini > Signed-off-by: Hervé Poussineau > Message-Id: <20171216090228.28505-

Re: [PATCH 3/3] hw/dma/xilinx_axidma.c: Switch to transaction-based ptimer API

Hi Peter, On 10/17/19 3:21 PM, Peter Maydell wrote: Switch the xilinx_axidma code away from bottom-half based ptimers to the new transaction-based ptimer API. This just requires adding begin/commit calls around the various places that modify the ptimer state, and using the new ptimer_init() fun

Re: [PATCH 03/32] mc146818rtc: move structure to header file

On Tuesday, October 15, 2019, Philippe Mathieu-Daudé wrote: > From: Hervé Poussineau > > We are now able to embed a timer in another object. > > Acked-by: Michael S. Tsirkin > Acked-by: Paolo Bonzini > Signed-off-by: Hervé Poussineau > Message-Id: <20171216090228.28505-4-hpous...@reactos.org>

Re: [PATCH 13/32] piix4: convert reset function to QOM

On Tuesday, October 15, 2019, Philippe Mathieu-Daudé wrote: > From: Hervé Poussineau > > Acked-by: Michael S. Tsirkin > Acked-by: Paolo Bonzini > Signed-off-by: Hervé Poussineau > Message-Id: <20180106153730.30313-15-hpous...@reactos.org> > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/i

Re: [PATCH 2/3] hw/timer/xilinx_timer.c: Switch to transaction-based ptimer API

On Thu, 17 Oct 2019 at 15:57, Philippe Mathieu-Daudé wrote: > > Hi Peter, > > On 10/17/19 3:21 PM, Peter Maydell wrote: > > +/* Must be called inside ptimer transaction block */ > > static void timer_enable(struct xlx_timer *xt) > > { > > uint64_t count; > > @@ -174,8 +173,11 @@ timer_wr

Re: [PATCH 02/32] hw/i386/pc: Move kvm_i8259_init() declaration to sysemu/kvm.h

On 10/17/19 4:57 PM, Aleksandar Markovic wrote: On Tuesday, October 15, 2019, Philippe Mathieu-Daudé > wrote: Move the KVM-related call to "sysemu/kvm.h". Maybe s/call/function declaration/ Signed-off-by: Philippe Mathieu-Daudé mailto:phi...@redhat.co

Re: [PATCH 5/8] hw/timer/altera_timer.c: Switch to transaction-based ptimer API

On 10/17/19 6:29 AM, Peter Maydell wrote: > Switch the altera_timer code away from bottom-half based ptimers to > the new transaction-based ptimer API. This just requires adding > begin/commit calls around the various places that modify the ptimer > state, and using the new ptimer_init() function

Re: [PATCH 08/32] piix4: rename some variables in realize function

On 15/10/2019 18.26, Philippe Mathieu-Daudé wrote: > From: Hervé Poussineau > > PIIX4 structure is now 's' > PCI device is now 'pci_dev' > DeviceState is now 'dev' Why? Just for the sake of it? > Acked-by: Michael S. Tsirkin > Acked-by: Paolo Bonzini > Signed-off-by: Hervé Poussineau > Messa

Re: [PATCH 8/8] hw/m68k/mcf5208.c: Switch to transaction-based ptimer API

On 10/17/19 6:29 AM, Peter Maydell wrote: > Switch the mcf5208 code away from bottom-half based ptimers to > the new transaction-based ptimer API. This just requires adding > begin/commit calls around the various places that modify the ptimer > state, and using the new ptimer_init() function to cr

Re: [PATCH 7/8] hw/m68k/mcf5206.c: Switch to transaction-based ptimer API

On 10/17/19 6:29 AM, Peter Maydell wrote: > Switch the mcf5206 code away from bottom-half based ptimers to > the new transaction-based ptimer API. This just requires adding > begin/commit calls around the various places that modify the ptimer > state, and using the new ptimer_init() function to cr

Re: [PATCH 08/32] piix4: rename some variables in realize function

On Tuesday, October 15, 2019, Philippe Mathieu-Daudé wrote: > From: Hervé Poussineau > > PIIX4 structure is now 's' > PCI device is now 'pci_dev' > DeviceState is now 'dev' > > Acked-by: Michael S. Tsirkin > Acked-by: Paolo Bonzini > Signed-off-by: Hervé Poussineau > Message-Id: <201712160902

Re: [PATCH 21/32] hw/i386/pc: Reduce gsi_handler scope

On Tuesday, October 15, 2019, Philippe Mathieu-Daudé wrote: > pc_gsi_create() is the single function that uses gsi_handler. > Make it a static variable. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/i386/pc.c | 2 +- > include/hw/i386/pc.h | 2 -- > 2 files changed, 1 insertion(+

Re: [PATCH 20/32] hw/i386/pc: Extract pc_gsi_create()

On Tuesday, October 15, 2019, Philippe Mathieu-Daudé wrote: > The GSI creation code is common to all PC machines, extract the > common code. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/i386/pc.c | 15 +++ > hw/i386/pc_piix.c| 9 + > hw/i386/pc_q35.c

Default CPU models on s390x and ppc64

Hi David and David, I'm working on libvirt's support [1] for query-machines' default-cpu-type, which is supposed to return the type of the default CPU model that QEMU uses for each machine type. Rather than hard coding the default in libvirt (which we currently do on x86), we ask QEMU for the defa

Re: [PATCH 08/32] piix4: rename some variables in realize function

On Tuesday, October 15, 2019, Philippe Mathieu-Daudé wrote: > From: Hervé Poussineau > > PIIX4 structure is now 's' > PCI device is now 'pci_dev' > DeviceState is now 'dev' > > Acked-by: Michael S. Tsirkin > Acked-by: Paolo Bonzini > Signed-off-by: Hervé Poussineau > Message-Id: <201712160902

Re: Default CPU models on s390x and ppc64

On 17.10.19 17:16, Jiri Denemark wrote: Hi David and David, I'm working on libvirt's support [1] for query-machines' default-cpu-type, which is supposed to return the type of the default CPU model that QEMU uses for each machine type. Rather than hard coding the default in libvirt (which we curr

Re: [PATCH 2/3] hw/timer/xilinx_timer.c: Switch to transaction-based ptimer API

On 10/17/19 5:03 PM, Peter Maydell wrote: On Thu, 17 Oct 2019 at 15:57, Philippe Mathieu-Daudé wrote: Hi Peter, On 10/17/19 3:21 PM, Peter Maydell wrote: +/* Must be called inside ptimer transaction block */ static void timer_enable(struct xlx_timer *xt) { uint64_t count; @@ -17

Re: [PATCH 3/3] hw/dma/xilinx_axidma.c: Switch to transaction-based ptimer API

On Thu, 17 Oct 2019 at 16:01, Philippe Mathieu-Daudé wrote: > > Hi Peter, > > On 10/17/19 3:21 PM, Peter Maydell wrote: > > Switch the xilinx_axidma code away from bottom-half based ptimers to > > the new transaction-based ptimer API. This just requires adding > > begin/commit calls around the va

Re: [PATCH 14/32] piix4: add a i8257 dma controller as specified in datasheet

On 15/10/2019 18.26, Philippe Mathieu-Daudé wrote: > > Remove i8257 instanciated in malta board, to not have it twice. s/instanciated/instantiated/ Thomas

Re: [PATCH 3/3] hw/dma/xilinx_axidma.c: Switch to transaction-based ptimer API

On 10/17/19 5:06 PM, Peter Maydell wrote: On Thu, 17 Oct 2019 at 16:01, Philippe Mathieu-Daudé wrote: Hi Peter, On 10/17/19 3:21 PM, Peter Maydell wrote: Switch the xilinx_axidma code away from bottom-half based ptimers to the new transaction-based ptimer API. This just requires adding begi

Re: [PATCH 2/2] hw/timer/slavio_timer.c: Switch to transaction-based ptimer API

On 10/17/19 5:00 PM, Peter Maydell wrote: On Thu, 17 Oct 2019 at 15:54, Philippe Mathieu-Daudé wrote: Hi Peter, On 10/17/19 3:23 PM, Peter Maydell wrote: Switch the slavio_timer code away from bottom-half based ptimers to the new transaction-based ptimer API. This just requires adding begin

Re: [PATCH 04/32] mc146818rtc: Move RTC_ISA_IRQ definition

On 10/17/19 5:02 PM, Aleksandar Markovic wrote: On Tuesday, October 15, 2019, Philippe Mathieu-Daudé > wrote: From: Philippe Mathieu-Daudé mailto:f4...@amsat.org>> The ISA default number for the RTC devices is not related to its registers neither. Move t

Re: [PATCH 22/32] hw/i386/pc: Move gsi_state creation code

On Tuesday, October 15, 2019, Philippe Mathieu-Daudé wrote: > The block code related to IRQ start few lines later. Move block code -> code block start -> starts the comment and the pc_gsi_create() call where we start call -> invocation > to use the IRQs. > > Signed-off-by: Philippe Mathie

Re: [PATCH v6 00/20] target/arm: Reduce overhead of cpu_get_tb_cpu_state

On Fri, 11 Oct 2019 at 16:55, Richard Henderson wrote: > Richard Henderson (20): > target/arm: Split out rebuild_hflags_common > target/arm: Split out rebuild_hflags_a64 > target/arm: Split out rebuild_hflags_common_32 > target/arm: Split arm_cpu_data_is_big_endian > target/arm: Split ou

Re: [PATCH 2/2] hw/timer/slavio_timer.c: Switch to transaction-based ptimer API

On Thu, 17 Oct 2019 at 16:22, Philippe Mathieu-Daudé wrote: > On 10/17/19 5:00 PM, Peter Maydell wrote: > > ...because the commit should come after we have finished > > updating the timer state (t->run in this case), because > > the trigger callback slavio_timer_irq() otherwise sees > > inconsiste

Re: [Virtio-fs] [PATCH 0/2] virtiofsd: Two fix for xattr operation

On Thu, Oct 17, 2019 at 01:23:57PM +0200, Miklos Szeredi wrote: > On Thu, Oct 17, 2019 at 12:05 PM Stefan Hajnoczi wrote: > > > > On Wed, Oct 16, 2019 at 07:37:52PM +0900, Misono Tomohiro wrote: > > > Hello, > > > > > > I test xattr operation on virtiofs using xfstest generic/062 > > > (with -o xa

Re: Default CPU models on s390x and ppc64

On 17.10.19 17:18, David Hildenbrand wrote: On 17.10.19 17:16, Jiri Denemark wrote: Hi David and David, I'm working on libvirt's support [1] for query-machines' default-cpu-type, which is supposed to return the type of the default CPU model that QEMU uses for each machine type. Rather than hard

Re: ACPI table modifications

On Sat, 12 Oct 2019 00:17:10 +0530 Gautam Bhat wrote: > Hi, > > I want to add some I2C based temperature sensors to the -M Q35 machine. I > want to update the ACPI tables to add this device information. How can I go > about doing this? Process is described here: https://www.mail-archive.com

Re: [PATCH 11/32] Revert "irq: introduce qemu_irq_proxy()"

On 15/10/2019 18.26, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > This function isn't used anymore. > > This reverts commit 22ec3283efba9ba0792790da786d6776d83f2a92. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/core/irq.c| 14 -- > include/hw/irq.h

Re: [PATCH 21/32] hw/i386/pc: Reduce gsi_handler scope

On 10/17/19 5:16 PM, Aleksandar Markovic wrote: On Tuesday, October 15, 2019, Philippe Mathieu-Daudé > wrote: pc_gsi_create() is the single function that uses gsi_handler. Make it a static variable. Signed-off-by: Philippe Mathieu-Daudé mailto:phi...@redhat

Re: [RFC 1/3] acpi: cpuhp: fix 'Command data' description is spec

On Thu, 10 Oct 2019 14:33:19 +0200 Laszlo Ersek wrote: > On 10/09/19 15:22, Igor Mammedov wrote: > > QEMU returns 0, in case of erro or invalid value in 'Command field', > > make spec match reality, i.e. > > Unfinished thought? yep, I'll fix it up. [...] > > index ee219c8358..ac5903b2b1 10064

Re: [PATCH] hw/s390x: Emit a warning if user tried to enable USB

On Thu, 17 Oct 2019 16:40:56 +0200 Thomas Huth wrote: > On 17/10/2019 16.34, Cornelia Huck wrote: > > On Thu, 17 Oct 2019 16:21:23 +0200 > > Thomas Huth wrote: > > > >> There is no USB on s390x, so running qemu-system-s390x with > >> "-machine ...,usb=on" is certainly wrong. Emit a warning to

Re: [PATCH 7/8] hw/m68k/mcf5206.c: Switch to transaction-based ptimer API

On 10/17/19 3:29 PM, Peter Maydell wrote: Switch the mcf5206 code away from bottom-half based ptimers to the new transaction-based ptimer API. This just requires adding begin/commit calls around the various places that modify the ptimer state, and using the new ptimer_init() function to create t

Re: [PULL 00/19] virtio, vhost, acpi: features, fixes, tests

On Sat, 5 Oct 2019 at 22:58, Michael S. Tsirkin wrote: > > A couple of tweaks to the bios table test weren't > reviewed yet but as they are really helpful to > the arm tests I'm pushing, and affecting only the > test so fairly benign (dropped assert + a comment), > I cut a corner and pushed them s

Re: [PATCH 21/32] hw/i386/pc: Reduce gsi_handler scope

On 15/10/2019 18.26, Philippe Mathieu-Daudé wrote: > pc_gsi_create() is the single function that uses gsi_handler. > Make it a static variable. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/i386/pc.c | 2 +- > include/hw/i386/pc.h | 2 -- > 2 files changed, 1 insertion(+), 3 delet

Re: [Call for Presentations] FOSDEM 2020 Virtualization & IaaS Devroom

On Thu, Oct 17, 2019 at 09:20:05AM +0100, Stefan Hajnoczi wrote: > The FOSDEM open source developer conference is taking place in > Brussels, Belgium on February 1st & 2nd, 2020. The call for > virtualization presentations has been posted: > > https://lists.fosdem.org/pipermail/fosdem/2019q4/0028

Re: [PATCH 8/8] hw/m68k/mcf5208.c: Switch to transaction-based ptimer API

On 10/17/19 3:29 PM, Peter Maydell wrote: Switch the mcf5208 code away from bottom-half based ptimers to the new transaction-based ptimer API. This just requires adding begin/commit calls around the various places that modify the ptimer state, and using the new ptimer_init() function to create t

Re: [PATCH 02/32] hw/i386/pc: Move kvm_i8259_init() declaration to sysemu/kvm.h

On 10/17/19 5:04 PM, Thomas Huth wrote: On 15/10/2019 18.26, Philippe Mathieu-Daudé wrote: Move the KVM-related call to "sysemu/kvm.h". Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 1 - include/sysemu/kvm.h | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --g

Re: [PATCH v2 04/23] iotests: Filter $SOCK_DIR

On 17/10/2019 15.31, Max Reitz wrote: > Signed-off-by: Max Reitz > Reviewed-by: Eric Blake > --- > tests/qemu-iotests/common.filter | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) Reviewed-by: Thomas Huth

Re: [PATCH v2 21/23] iotests/240: Create socket in $SOCK_DIR

On 17/10/2019 15.31, Max Reitz wrote: > Signed-off-by: Max Reitz > Reviewed-by: Eric Blake > --- > tests/qemu-iotests/240 | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 20/32] hw/i386/pc: Extract pc_gsi_create()

On 15/10/2019 18.26, Philippe Mathieu-Daudé wrote: > The GSI creation code is common to all PC machines, extract the > common code. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/i386/pc.c | 15 +++ > hw/i386/pc_piix.c| 9 + > hw/i386/pc_q35.c | 9 +---

Re: [PATCH v2 23/23] iotests: Drop TEST_DIR filter from _filter_nbd

On 17/10/2019 15.31, Max Reitz wrote: > Sockets should be placed into $SOCK_DIR instead of $TEST_DIR, so remove > the $TEST_DIR filter from _filter_nbd. > > Signed-off-by: Max Reitz > Reviewed-by: Eric Blake > --- > tests/qemu-iotests/common.filter | 1 - > 1 file changed, 1 deletion(-) > > di

<    1   2   3   4   5   >