Re: [PATCH v3 10/10] vfio: unplug failover primary device before migration

2019-10-17 Thread Jens Freimann
On Wed, Oct 16, 2019 at 06:39:58PM -0600, Alex Williamson wrote: On Wed, 16 Oct 2019 22:18:47 +0200 Jens Freimann wrote: On Tue, Oct 15, 2019 at 07:52:12PM -0600, Alex Williamson wrote: >On Fri, 11 Oct 2019 13:20:15 +0200 >Jens Freimann wrote: > >> As usual block all vfio-pci devices from bei

Re: [PATCH] configure: Require Python >= 3.5

2019-10-17 Thread Thomas Huth
On 17/10/2019 00.48, John Snow wrote: > > > On 10/16/19 6:42 PM, Eduardo Habkost wrote: >> Python 3.5 is the oldest Python version available on our >> supported build platforms, and Python 2 end of life will be 3 >> weeks after the planned release date of QEMU 4.2.0. Drop Python >> 2 support fro

Re: [PATCH v3] migration: Support QLIST migration

2019-10-17 Thread Juan Quintela
Eric Auger wrote: > Support QLIST migration using the same principle as QTAILQ: > 94869d5c52 ("migration: migrate QTAILQ"). > > The VMSTATE_QLIST_V macro has the same proto as VMSTATE_QTAILQ_V. > The change mainly resides in QLIST_RAW_INSERT_TAIL implementation. > > Tests also are provided. > > Si

[Call for Presentations] FOSDEM 2020 Virtualization & IaaS Devroom

2019-10-17 Thread Stefan Hajnoczi
The FOSDEM open source developer conference is taking place in Brussels, Belgium on February 1st & 2nd, 2020. The call for virtualization presentations has been posted: https://lists.fosdem.org/pipermail/fosdem/2019q4/002889.html I just wanted to forward this because the CfP only went to qemu-di

Re: [PATCH] migration: savevm_state_insert_handler: constant-time element insertion

2019-10-17 Thread Juan Quintela
Scott Cheloha wrote: Hi > Registering a SaveStateEntry object via savevm_state_insert_handler() > is an O(n) operation because the list is a priority queue maintained by > walking the list from head to tail to find a suitable insertion point. > > This adds considerable overhead for VMs with many

Re: [RFC 5/5] spapr: Work around spurious warnings from vfio INTx initialization

2019-10-17 Thread Cédric Le Goater
On 17/10/2019 07:42, David Gibson wrote: > Traditional PCI INTx for vfio devices can only perform well if using > an in-kernel irqchip. Therefore, vfio_intx_update() issues a warning > if an in kernel irqchip is not available. > > We usually do have an in-kernel irqchip available for pseries mach

Re: [PATCH] configure: Require Python >= 3.5

2019-10-17 Thread Daniel P . Berrangé
On Wed, Oct 16, 2019 at 06:48:34PM -0400, John Snow wrote: > > > On 10/16/19 6:42 PM, Eduardo Habkost wrote: > > Python 3.5 is the oldest Python version available on our > > supported build platforms, and Python 2 end of life will be 3 > > weeks after the planned release date of QEMU 4.2.0. Drop

Re: [RFC 5/5] spapr: Work around spurious warnings from vfio INTx initialization

2019-10-17 Thread Greg Kurz
On Thu, 17 Oct 2019 10:43:11 +0200 Cédric Le Goater wrote: > On 17/10/2019 07:42, David Gibson wrote: > > Traditional PCI INTx for vfio devices can only perform well if using > > an in-kernel irqchip. Therefore, vfio_intx_update() issues a warning > > if an in kernel irqchip is not available. >

Re: [PATCH] ui: fix keymap file search in input-barrier object

2019-10-17 Thread Laurent Vivier
Ping? Le 24/09/2019 à 00:06, Laurent Vivier a écrit : > If we try to start QEMU with "-k en-us", qemu prints a message and exits > with: > > qemu-system-i386: could not read keymap file: 'en-us' > > It's because this function is called way too early, before > qemu_add_data_dir() is called, a

[Bug 1846427] Re: 4.1.0: qcow2 corruption on savevm/quit/loadvm cycle

2019-10-17 Thread Laszlo Ersek (Red Hat)
After reading the message of commit 69f47505ee66 ("block: avoid recursive block_status call if possible", 2019-06-04), I'm none the wiser. But, I can at least confirm that all my qcow2 images are pre-allocated, as a norm. I create them with the following command: qemu-img create \ -f qcow2 \ -

[Bug 1846427] Re: 4.1.0: qcow2 corruption on savevm/quit/loadvm cycle

2019-10-17 Thread Laszlo Ersek (Red Hat)
(See also / possible duplicate: .) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1846427 Title: 4.1.0: qcow2 corruption on savevm/quit/loadvm cycle St

[Bug 1847793] Re: qemu 4.1.0 - Corrupt guest filesystem after new vm install

2019-10-17 Thread Laszlo Ersek (Red Hat)
Hi Max, from my : I've seen corruption on ext4. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1847793 Title: qemu 4.1.0 - Corrupt guest file

Re: [Patch v2] checkpatch: sugguest to use qemu_real_host_page_size instead of getpagesize() or sysconf(_SC_PAGESIZE)

2019-10-17 Thread Stefan Hajnoczi
On Thu, Oct 17, 2019 at 08:46:33AM +0800, Wei Yang wrote: > Signed-off-by: Wei Yang > CC: Richard Henderson > CC: Stefan Hajnoczi > > --- > v2: add "\b" for better match, suggested by Richard Henderson > > --- > scripts/checkpatch.pl | 6 ++ > 1 file changed, 6 insertions(+) Reviewed-by

iotest 260 failure (linux host): "OSError: AF_UNIX path too long"

2019-10-17 Thread Peter Maydell
I just got this iotest 260 failure processing an unrelated merge on my x86-64 Ubuntu box. I assume it's an intermittent (have just kicked off a retry) but post the backtrace in case it's of interest: TESTiotest-qcow2: 260 [fail] QEMU -- "/home/petmay01/linaro/qemu-for-merges/build/

Re: [PATCH v10 13/15] docs/microvm.rst: document the new microvm machine type

2019-10-17 Thread Philippe Mathieu-Daudé
Hi Sergio, On 10/16/19 12:12 PM, Sergio Lopez wrote: +Supported devices +- + +The microvm machine type supports the following devices: + +- ISA bus +- i8259 PIC (optional) +- i8254 PIT (optional) +- MC146818 RTC (optional) +- One ISA serial port (optional) +- LAPIC +- IOAPIC (wit

Re: iotest 260 failure (linux host): "OSError: AF_UNIX path too long"

2019-10-17 Thread Max Reitz
On 17.10.19 11:51, Peter Maydell wrote: > I just got this iotest 260 failure processing an > unrelated merge on my x86-64 Ubuntu box. I assume > it's an intermittent (have just kicked off a retry) but > post the backtrace in case it's of interest: I hope it’s intermittent, although I presume it mi

Re: [PATCH 07/10] image-fuzzer: Use bytes constant for field values

2019-10-17 Thread Philippe Mathieu-Daudé
On 10/16/19 9:24 PM, Eduardo Habkost wrote: Field values are supposed to be bytes objects, not unicode strings. Change two constants that were declared as strings. Signed-off-by: Eduardo Habkost --- tests/image-fuzzer/qcow2/layout.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH 01/10] image-fuzzer: Open image files in binary mode

2019-10-17 Thread Philippe Mathieu-Daudé
On 10/16/19 9:24 PM, Eduardo Habkost wrote: This probably never caused problems because on Linux there's no actual newline conversion happening, but on Python 3 the binary/text distinction is stronger and we must explicitly open the image file in binary mode. Signed-off-by: Eduardo Habkost ---

Re: [PATCH 02/10] image-fuzzer: Write bytes instead of string to image file

2019-10-17 Thread Philippe Mathieu-Daudé
On 10/16/19 9:24 PM, Eduardo Habkost wrote: This is necessary for Python 3 compatibility. Signed-off-by: Eduardo Habkost --- tests/image-fuzzer/qcow2/layout.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/image-fuzzer/qcow2/layout.py b/tests/image-fuzzer/qcow2/l

s390x/qemu-user: TODO /home/dhildenb/git/qemu/tcg/tci.c:859: tcg_qemu_tb_exec()

2019-10-17 Thread David Hildenbrand
Hi, I'm currently trying to run Fedora 31 under qemu-user (https://github.com/fedora-cloud/docker-brew-fedora/tree/8a81f67271e959dfc8f8a888b161bbd540b7a83b/s390x) in order to debug a vector instruction issue. Strangely, when trying to chroot into above rootfs and running /bin/bash, I get

Re: iotest 260 failure (linux host): "OSError: AF_UNIX path too long"

2019-10-17 Thread Peter Maydell
On Thu, 17 Oct 2019 at 10:53, Max Reitz wrote: > > On 17.10.19 11:51, Peter Maydell wrote: > > I just got this iotest 260 failure processing an > > unrelated merge on my x86-64 Ubuntu box. I assume > > it's an intermittent (have just kicked off a retry) but > > post the backtrace in case it's of i

Re: [Virtio-fs] [PATCH 0/2] virtiofsd: Two fix for xattr operation

2019-10-17 Thread Stefan Hajnoczi
On Wed, Oct 16, 2019 at 07:37:52PM +0900, Misono Tomohiro wrote: > Hello, > > I test xattr operation on virtiofs using xfstest generic/062 > (with -o xattr option and XFS backend) and see some problems. > > These patches fixes the two of the problems. > > The remaining problems are: > 1. we can

[QEMU][PATCH v2] ssi: xilinx_spips: Skip update of cs and fifo releated to spips in gqspi

2019-10-17 Thread Sai Pavan Boddu
GQSPI handles chip selects and fifos in a different way compared to spips. So skip update of cs and fifos related to spips in gqspi mode. Signed-off-by: Sai Pavan Boddu --- Changes for V2: Just skip update of spips cs and fifos Update commit message accordingly hw/ssi/xilinx_spips.c | 7

[PATCH] runstate: ignore exit request in finish migrate state

2019-10-17 Thread Laurent Vivier
Trying to reboot a VM while a migration is running can move to the prelaunch state (because of the reset) while the runstate is in finish migrate state. As the logical step after the finish migrate is postmigrate, this can create an invalid state transition from prelaunch state to postmigrate state

Re: iotest 260 failure (linux host): "OSError: AF_UNIX path too long"

2019-10-17 Thread Max Reitz
On 17.10.19 12:04, Peter Maydell wrote: > On Thu, 17 Oct 2019 at 10:53, Max Reitz wrote: >> >> On 17.10.19 11:51, Peter Maydell wrote: >>> I just got this iotest 260 failure processing an >>> unrelated merge on my x86-64 Ubuntu box. I assume >>> it's an intermittent (have just kicked off a retry)

Re: [PATCH 5/5] aspeed/i2c: Add trace events

2019-10-17 Thread Philippe Mathieu-Daudé
Hi Cédric, On 10/16/19 10:50 AM, Cédric Le Goater wrote: Signed-off-by: Cédric Le Goater --- hw/i2c/aspeed_i2c.c | 93 ++--- hw/i2c/trace-events | 9 + 2 files changed, 89 insertions(+), 13 deletions(-) diff --git a/hw/i2c/aspeed_i2c.c b/hw/i2c/

Re: s390x/qemu-user: TODO /home/dhildenb/git/qemu/tcg/tci.c:859: tcg_qemu_tb_exec()

2019-10-17 Thread Philippe Mathieu-Daudé
Hi David, On 10/17/19 12:02 PM, David Hildenbrand wrote: Hi, I'm currently trying to run Fedora 31 under qemu-user (https://github.com/fedora-cloud/docker-brew-fedora/tree/8a81f67271e959dfc8f8a888b161bbd540b7a83b/s390x) in order to debug  a vector instruction issue. Strangely, when trying t

Re: [QEMU][PATCH v2] ssi: xilinx_spips: Skip update of cs and fifo releated to spips in gqspi

2019-10-17 Thread Philippe Mathieu-Daudé
Hi, On 10/17/19 12:17 PM, Sai Pavan Boddu wrote: GQSPI handles chip selects and fifos in a different way compared to spips. So skip update of cs and fifos related to spips in gqspi mode. Signed-off-by: Sai Pavan Boddu --- Changes for V2: Just skip update of spips cs and fifos Update

Re: [PATCH v3 0/10] add failover feature for assigned network devices

2019-10-17 Thread Jens Freimann
On Tue, Oct 15, 2019 at 01:03:17PM -0600, Alex Williamson wrote: On Fri, 11 Oct 2019 13:20:05 +0200 Jens Freimann wrote: This is implementing the host side of the net_failover concept (https://www.kernel.org/doc/html/latest/networking/net_failover.html) Changes since v2: * back out of creatin

Re: s390x/qemu-user: TODO /home/dhildenb/git/qemu/tcg/tci.c:859: tcg_qemu_tb_exec()

2019-10-17 Thread David Hildenbrand
On 17.10.19 12:25, Philippe Mathieu-Daudé wrote: Hi David, On 10/17/19 12:02 PM, David Hildenbrand wrote: Hi, I'm currently trying to run Fedora 31 under qemu-user (https://github.com/fedora-cloud/docker-brew-fedora/tree/8a81f67271e959dfc8f8a888b161bbd540b7a83b/s390x) in order to debug  a vect

Re: s390x/qemu-user: TODO /home/dhildenb/git/qemu/tcg/tci.c:859: tcg_qemu_tb_exec()

2019-10-17 Thread Philippe Mathieu-Daudé
On 10/17/19 12:35 PM, David Hildenbrand wrote: On 17.10.19 12:25, Philippe Mathieu-Daudé wrote: Hi David, On 10/17/19 12:02 PM, David Hildenbrand wrote: Hi, I'm currently trying to run Fedora 31 under qemu-user (https://github.com/fedora-cloud/docker-brew-fedora/tree/8a81f67271e959dfc8f8a888b

[Bug 1838569] Re: virtio-balloon change breaks post 4.0 upgrade

2019-10-17 Thread Launchpad Bug Tracker
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: qemu (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1838569 Title: virt

[Bug 1838569] Re: virtio-balloon change breaks post 4.0 upgrade

2019-10-17 Thread Daniel 'f0o' Preussker
With recent release of OpenStack Train this issue reappears... Upgrading from Stein to Train will require all VMs to be hard-rebooted to be migrated as a final step because Live Migration fails with: Oct 17 10:28:43 h2.1.openstack.r0cket.net libvirtd[1545]: Unable to read from monitor: Connectio

Re: [PATCH v10 13/15] docs/microvm.rst: document the new microvm machine type

2019-10-17 Thread Sergio Lopez
Philippe Mathieu-Daudé writes: > Hi Sergio, > > On 10/16/19 12:12 PM, Sergio Lopez wrote: >> +Supported devices >> +- >> + >> +The microvm machine type supports the following devices: >> + >> +- ISA bus >> +- i8259 PIC (optional) >> +- i8254 PIT (optional) >> +- MC146818 RTC (opt

Re: [PATCH v10 13/15] docs/microvm.rst: document the new microvm machine type

2019-10-17 Thread Philippe Mathieu-Daudé
On 10/17/19 12:45 PM, Sergio Lopez wrote: Philippe Mathieu-Daudé writes: Hi Sergio, On 10/16/19 12:12 PM, Sergio Lopez wrote: +Supported devices +- + +The microvm machine type supports the following devices: + +- ISA bus +- i8259 PIC (optional) +- i8254 PIT (optional) +- MC1

Re: [PATCH v10 13/15] docs/microvm.rst: document the new microvm machine type

2019-10-17 Thread Daniel P . Berrangé
On Wed, Oct 16, 2019 at 12:12:40PM +0200, Sergio Lopez wrote: > Document the new microvm machine type. > > Signed-off-by: Sergio Lopez > Reviewed-by: Michael S. Tsirkin > --- > docs/microvm.rst | 98 > 1 file changed, 98 insertions(+) > create m

Re: iotest 260 failure (linux host): "OSError: AF_UNIX path too long"

2019-10-17 Thread Peter Maydell
On Thu, 17 Oct 2019 at 11:20, Max Reitz wrote: > > On 17.10.19 12:04, Peter Maydell wrote: > > On Thu, 17 Oct 2019 at 10:53, Max Reitz wrote: > >> > >> On 17.10.19 11:51, Peter Maydell wrote: > >>> I just got this iotest 260 failure processing an > >>> unrelated merge on my x86-64 Ubuntu box. I a

Re: s390x/qemu-user: TODO /home/dhildenb/git/qemu/tcg/tci.c:859: tcg_qemu_tb_exec()

2019-10-17 Thread Thomas Huth
On 17/10/2019 12.02, David Hildenbrand wrote: > Hi, > > I'm currently trying to run Fedora 31 under qemu-user > (https://github.com/fedora-cloud/docker-brew-fedora/tree/8a81f67271e959dfc8f8a888b161bbd540b7a83b/s390x) > in order to debug  a vector instruction issue. > > Strangely, when trying to c

[Bug 1838569] Re: virtio-balloon change breaks post 4.0 upgrade

2019-10-17 Thread Dr. David Alan Gilbert
Dnaiel: That's a different problem; 'Bad config data: i=0x10 read: a1 device: 1 cmask: ff wmask: c0 w1cmask:0'; so should probably be a separate bug. I'd bet on this being the one fixed by 2bbadb08ce272d65e1f78621002008b07d1e0f03 -- You received this bug notification because you are a member of

Re: [PULL v2 00/19] Bitmaps patches

2019-10-17 Thread Peter Maydell
On Mon, 14 Oct 2019 at 20:29, John Snow wrote: > > The following changes since commit c760cb77e511eb05094df67c1b30029a952efa35: > > Merge remote-tracking branch > 'remotes/dgilbert/tags/pull-migration-20191011a' into staging (2019-10-14 > 16:09:52 +0100) > > are available in the Git repository

Re: [PATCH] configure: Require Python >= 3.5

2019-10-17 Thread Kevin Wolf
Am 17.10.2019 um 00:48 hat John Snow geschrieben: > > > On 10/16/19 6:42 PM, Eduardo Habkost wrote: > > Python 3.5 is the oldest Python version available on our > > supported build platforms, and Python 2 end of life will be 3 > > weeks after the planned release date of QEMU 4.2.0. Drop Python >

[PATCH v7 0/3] target/ppc: Optimize emulation of some Altivec instructions

2019-10-17 Thread Stefan Brankovic
Optimize emulation of ten Altivec instructions: lvsl, lvsr, vsl, vsr, vpkpx, vgbbd, vclzb, vclzh, vclzw, vclzd, vupkhpx and vupklpx. This series buils up on and complements recent work of Thomas Murta, Mark Cave-Ayland and Richard Henderson in the same area. It is based on devising TCG translation

[PATCH v7 2/3] target/ppc: Optimize emulation of vpkpx instruction

2019-10-17 Thread Stefan Brankovic
Optimize altivec instruction vpkpx (Vector Pack Pixel). Rearranges 8 pixels coded in 6-5-5 pattern (4 from each source register) into contigous array of bits in the destination register. In each iteration of outer loop, the instruction is to be done with the 6-5-5 pack for 2 pixels of each doublew

Re: [Bug 1847232] [NEW] qemu TCG in s390x mode issue with calculating HASH

2019-10-17 Thread David Hildenbrand
On 14.10.19 12:22, David Hildenbrand wrote: On 14.10.19 11:53, David Hildenbrand wrote: On 08.10.19 16:11, Ivan Warren wrote: On 10/8/2019 3:35 PM, David Hildenbrand wrote: On 08.10.19 14:11, Cornelia Huck wrote: On Tue, 08 Oct 2019 11:19:25 - Ivan Warren via wrote: Public bug reporte

[PATCH v7 1/3] target/ppc: Optimize emulation of vclzh and vclzb instructions

2019-10-17 Thread Stefan Brankovic
Optimize Altivec instruction vclzh (Vector Count Leading Zeros Halfword). This instruction counts the number of leading zeros of each halfword element in source register and places result in the appropriate halfword element of destination register. In each iteration of outer for loop count operati

[PATCH v7 3/3] target/ppc: Optimize emulation of vupkhpx and vupklpx instructions

2019-10-17 Thread Stefan Brankovic
'trans_vupkpx' function implements both vupkhpx and vupklpx instructions with argument 'high' determine which instruction is processed. Instructions are implemented in two 'for' loops. Outer 'for' loop repeats unpacking two times, since both doubleword elements of destination register are formed th

Re: [PATCH v2 1/3] iotests: Fix 173

2019-10-17 Thread Max Reitz
On 15.10.19 21:35, Eric Blake wrote: > This test has been broken since 3.0. It used TEST_IMG to influence > the name of a file created during _make_test_img, but commit 655ae6bb > changed things so that the wrong file name is being created, which > then caused _launch_qemu to fail. In the meantim

Re: [PATCH] s390x/cpumodel: Add missing visit_free

2019-10-17 Thread Cornelia Huck
On Wed, 16 Oct 2019 16:54:34 +0200 Andrew Jones wrote: > Beata Michalska noticed this missing visit_free() while reviewing > arm's implementation of qmp_query_cpu_model_expansion(), which is > modeled off this s390x implementation. > > Signed-off-by: Andrew Jones > --- > target/s390x/cpu_model

Re: [PATCH v2 1/3] iotests: Fix 173

2019-10-17 Thread Max Reitz
On 15.10.19 21:35, Eric Blake wrote: > This test has been broken since 3.0. It used TEST_IMG to influence > the name of a file created during _make_test_img, but commit 655ae6bb > changed things so that the wrong file name is being created, which > then caused _launch_qemu to fail. In the meantim

Re: [PATCH v10 13/15] docs/microvm.rst: document the new microvm machine type

2019-10-17 Thread Sergio Lopez
Daniel P. Berrangé writes: > On Wed, Oct 16, 2019 at 12:12:40PM +0200, Sergio Lopez wrote: >> Document the new microvm machine type. >> >> Signed-off-by: Sergio Lopez >> Reviewed-by: Michael S. Tsirkin >> --- >> docs/microvm.rst | 98 >> 1 fil

Re: [PATCH v10 13/15] docs/microvm.rst: document the new microvm machine type

2019-10-17 Thread Sergio Lopez
Philippe Mathieu-Daudé writes: > On 10/17/19 12:45 PM, Sergio Lopez wrote: >> >> Philippe Mathieu-Daudé writes: >> >>> Hi Sergio, >>> >>> On 10/16/19 12:12 PM, Sergio Lopez wrote: +Supported devices +- + +The microvm machine type supports the following device

Re: [PATCH 5/5] aspeed/i2c: Add trace events

2019-10-17 Thread Cédric Le Goater
Hello Philippe, On 17/10/2019 12:22, Philippe Mathieu-Daudé wrote: > Hi Cédric, > > On 10/16/19 10:50 AM, Cédric Le Goater wrote: >> Signed-off-by: Cédric Le Goater >> --- >>   hw/i2c/aspeed_i2c.c | 93 ++--- >>   hw/i2c/trace-events |  9 + >>   2 files

Re: [PULL 19/31] target/s390x: Return exception from mmu_translate_real

2019-10-17 Thread Peter Maydell
On Thu, 10 Oct 2019 at 12:35, David Hildenbrand wrote: > > From: Richard Henderson > > Do not raise the exception directly within mmu_translate_real, > but pass it back so that caller may do so. > > Reviewed-by: David Hildenbrand > Signed-off-by: Richard Henderson > Message-Id: <20191001171614.

Re: [PULL 33/36] block/backup: use backup-top instead of write notifiers

2019-10-17 Thread Peter Maydell
On Thu, 10 Oct 2019 at 12:44, Max Reitz wrote: > > From: Vladimir Sementsov-Ogievskiy > > Drop write notifiers and use filter node instead. Hi; after this change Coverity complains about dead code in backup_job_create() (CID 1406402): > @@ -382,6 +353,8 @@ BlockJob *backup_job_create(const char

Re: [PULL 19/31] target/s390x: Return exception from mmu_translate_real

2019-10-17 Thread Peter Maydell
On Thu, 17 Oct 2019 at 12:57, Peter Maydell wrote: > > On Thu, 10 Oct 2019 at 12:35, David Hildenbrand wrote: > > > > From: Richard Henderson > > > > Do not raise the exception directly within mmu_translate_real, > > but pass it back so that caller may do so. > > > > Reviewed-by: David Hildenbra

Re: [Qemu-devel] [PATCH 0/3] Audio: misc fixes for "Audio 20190821 patches", part two

2019-10-17 Thread Peter Maydell
Hi -- not sure what's happened with this patchset, but can we at least get the first patch (which fixes some coverity errors) in, even if the other two need more consideration? (cc'ing Gerd as audio maintainer.) thanks -- PMM On Wed, 11 Sep 2019 at 00:27, Kővágó, Zoltán wrote: > > Hi, > > This

Re: [PATCH v2 1/1] riscv/boot: Fix possible memory leak

2019-10-17 Thread Peter Maydell
Ping? It would be nice to see this patch get into master to silence the coverity errors. thanks -- PMM On Thu, 3 Oct 2019 at 18:05, Alistair Francis wrote: > > Coverity (CID 1405786) thinks that there is a possible memory leak as > we don't guarantee that the memory allocated from riscv_find_fir

Re: [PULL 19/31] target/s390x: Return exception from mmu_translate_real

2019-10-17 Thread David Hildenbrand
On 17.10.19 14:05, Peter Maydell wrote: On Thu, 17 Oct 2019 at 12:57, Peter Maydell wrote: On Thu, 10 Oct 2019 at 12:35, David Hildenbrand wrote: From: Richard Henderson Do not raise the exception directly within mmu_translate_real, but pass it back so that caller may do so. Reviewed-by:

Re: [PATCH v2 1/3] iotests: Fix 173

2019-10-17 Thread Max Reitz
On 17.10.19 13:46, Max Reitz wrote: > On 15.10.19 21:35, Eric Blake wrote: >> This test has been broken since 3.0. It used TEST_IMG to influence >> the name of a file created during _make_test_img, but commit 655ae6bb >> changed things so that the wrong file name is being created, which >> then ca

[PATCH v1] s390x/mmu: Remove duplicate check for MMU_DATA_STORE

2019-10-17 Thread David Hildenbrand
No need to double-check if we have a write. Found by Coverity (CID: 1381016). Fixes: 31b59419069e ("target/s390x: Return exception from mmu_translate_real") Cc: Peter Maydell Signed-off-by: David Hildenbrand --- target/s390x/mmu_helper.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)

Re: [PATCH v1] s390x/mmu: Remove duplicate check for MMU_DATA_STORE

2019-10-17 Thread David Hildenbrand
On 17.10.19 14:19, David Hildenbrand wrote: No need to double-check if we have a write. Found by Coverity (CID: 1381016). Copy and past error, it's 1406404. Fixes: 31b59419069e ("target/s390x: Return exception from mmu_translate_real") Cc: Peter Maydell Signed-off-by: David Hildenbrand --

Re: [Virtio-fs] [PATCH 0/2] virtiofsd: Two fix for xattr operation

2019-10-17 Thread Miklos Szeredi
On Thu, Oct 17, 2019 at 12:05 PM Stefan Hajnoczi wrote: > > On Wed, Oct 16, 2019 at 07:37:52PM +0900, Misono Tomohiro wrote: > > Hello, > > > > I test xattr operation on virtiofs using xfstest generic/062 > > (with -o xattr option and XFS backend) and see some problems. > > > > These patches fixes

[PATCH 0/1] BZ#1751431:guest-get-memory-block-info is not supported

2019-10-17 Thread Basil Salman
From: Basil Salman "guest-get-memory-block-info" is enabled according to "get-info" output, while the command is only supported for linux with sysfs. "guest-get-memory-block-info" command was added to blacklist. Basil Salman (1): qga: Add "guest-get-memory-block-info" to blacklist qga/comma

[PATCH 1/1] qga: Add "guest-get-memory-block-info" to blacklist

2019-10-17 Thread Basil Salman
From: Basil Salman Memory block commands are only supported for linux with sysfs, "guest-get-memory-block-info" was not in blacklist for other cases. Reported on: https://bugzilla.redhat.com/show_bug.cgi?id=1751431 Signed-off-by: Basil Salman --- qga/commands-posix.c | 3 ++- qga/commands-win

[Bug 1838569] Re: virtio-balloon change breaks post 4.0 upgrade

2019-10-17 Thread Christian Ehrhardt 
> I'd bet on this being the one fixed by > 2bbadb08ce272d65e1f78621002008b07d1e0f03 But wasn't the breakage this fixes only added in qemu 4.0? He reports his change is from qemu 2.10 to 2.11. Unfortunately 2bbadb08 doesn't have a "fixes" line, maybe Ubuntu has something backported that makes the

[PATCH] util/cacheinfo: fix crash when compiling with uClibc

2019-10-17 Thread casantos
From: Carlos Santos uClibc defines _SC_LEVEL1_ICACHE_LINESIZE and _SC_LEVEL1_DCACHE_LINESIZE but the corresponding sysconf calls returns -1, which is a valid result, meaning that the limit is indeterminate. Handle this situation using the fallback values instead of crashing due to an assertion f

Re: [PATCH] util/cacheinfo: fix crash when compiling with uClibc

2019-10-17 Thread Peter Maydell
On Thu, 17 Oct 2019 at 13:39, wrote: > > From: Carlos Santos > > uClibc defines _SC_LEVEL1_ICACHE_LINESIZE and _SC_LEVEL1_DCACHE_LINESIZE > but the corresponding sysconf calls returns -1, which is a valid result, > meaning that the limit is indeterminate. > > Handle this situation using the fallb

Re: [PATCH v7 0/9] linux-user: strace improvements

2019-10-17 Thread Philippe Mathieu-Daudé
ping ping? On 9/30/19 5:44 PM, Philippe Mathieu-Daudé wrote: On 9/15/19 11:39 PM, Philippe Mathieu-Daudé wrote: Hi Laurent, Few patches I'v been writting while trying to figure out this issue: http://lists.nongnu.org/archive/html/qemu-arm/2018-01/msg00514.html As usual with linux-user files,

[Bug 1838569] Re: virtio-balloon change breaks post 4.0 upgrade

2019-10-17 Thread Christian Ehrhardt 
> I'd bet on this being the one fixed by > 2bbadb08ce272d65e1f78621002008b07d1e0f03 But wasn't the breakage this fixes only added in qemu 4.0? He reports his change is from qemu 2.10 to 2.11. Unfortunately 2bbadb08 doesn't have a "fixes" line, maybe Ubuntu has something backported that makes the

[Bug 1838569] Re: virtio-balloon change breaks post 4.0 upgrade

2019-10-17 Thread Christian Ehrhardt 
I forked that new discussion into https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1848497 Please follow there and leave this bug here to the originally reported error signature. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. ht

Re: [PATCH v3 0/10] add failover feature for assigned network devices

2019-10-17 Thread Alex Williamson
On Thu, 17 Oct 2019 12:33:47 +0200 Jens Freimann wrote: > On Tue, Oct 15, 2019 at 01:03:17PM -0600, Alex Williamson wrote: > >On Fri, 11 Oct 2019 13:20:05 +0200 > >Jens Freimann wrote: > > > >> This is implementing the host side of the net_failover concept > >> (https://www.kernel.org/doc/html

Re: [PATCH 0/3] tests/acceptance: Add tests for the Leon3 board

2019-10-17 Thread Philippe Mathieu-Daudé
ping? On 6/27/19 1:53 PM, Philippe Mathieu-Daudé wrote: Quick tests worth to avoid regressions, idea from https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg04177.html "Maintainers, please tell us how to boot your machines" Regards, Phil. Philippe Mathieu-Daudé (3): tests/acceptance:

Re: [PATCH] Acceptance tests: refactor wait_for_console_pattern

2019-10-17 Thread Philippe Mathieu-Daudé
On 9/16/19 6:40 PM, Cleber Rosa wrote: The same utility method is already present in two different test files, so let's consolidate it into a single utility function. Signed-off-by: Cleber Rosa --- tests/acceptance/avocado_qemu/__init__.py | 26 + tests/acceptance/boot_linux_cons

Re: [PATCH v2 2/3] iotests: Include QMP input in .out files

2019-10-17 Thread Max Reitz
On 15.10.19 21:35, Eric Blake wrote: > We generally include relevant HMP input in .out files, by virtue of > the fact that HMP echoes its input. But QMP does not, so we have to > explicitly inject it in the output stream, in order to make it easier > to read .out files to see what behavior is bein

Re: [Virtio-fs] [PATCH 0/2] virtiofsd: Two fix for xattr operation

2019-10-17 Thread Miklos Szeredi
On Thu, Oct 17, 2019 at 1:23 PM Miklos Szeredi wrote: > I see why this is being done, and it's not easy to fix properly > without the ..at() versions of these syscalls. One idea is to fork() > + fchdir(lo->proc_self_fd) + ..xattr(). Another related idea is to do > a unshare(CLONE_FS) after each

[RFC PATCH 01/18] qemu-storage-daemon: Add barebone tool

2019-10-17 Thread Kevin Wolf
This adds a new binary qemu-storage-daemon that doesn't yet do more than some typical initialisation for tools and parsing the basic command options --version, --help and --trace. Signed-off-by: Kevin Wolf --- configure | 2 +- qemu-storage-daemon.c | 141 ++

[RFC PATCH 02/18] qemu-storage-daemon: Add --object option

2019-10-17 Thread Kevin Wolf
Add a command line option to create user-creatable QOM objects. Signed-off-by: Kevin Wolf --- qemu-storage-daemon.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/qemu-storage-daemon.c b/qemu-storage-daemon.c index a251dc255c..48d6af43a6 100644 --- a/qem

[RFC PATCH 03/18] stubs: Add arch_type

2019-10-17 Thread Kevin Wolf
blockdev.c uses the arch_type constant, so before we can use the file in tools (i.e. outside of the system emulator), we need to add a stub for it. A new QEMU_ARCH_NONE is introduced for this case. Signed-off-by: Kevin Wolf --- include/sysemu/arch_init.h | 2 ++ stubs/arch_type.c | 4 ++

[RFC PATCH 04/18] stubs: Add blk_by_qdev_id()

2019-10-17 Thread Kevin Wolf
blockdev.c uses the blk_by_qdev_id() function, so before we can use the file in tools (i.e. outside of the system emulator), we need to add a stub for it. The function always returns an error. Signed-off-by: Kevin Wolf --- stubs/blk-by-qdev-id.c | 9 + stubs/Makefile.objs| 1 + 2 fil

[RFC PATCH 00/18] Add qemu-storage-daemon

2019-10-17 Thread Kevin Wolf
This series adds a new tool 'qemu-storage-daemon', which can be used to export and perform operations on block devices. There is some overlap between qemu-img/qemu-nbd and the new qemu-storage-daemon, but there are a few important differences: * The qemu-storage-daemon has QMP support. The command

[RFC PATCH 06/18] qemu-storage-daemon: Add --nbd-server option

2019-10-17 Thread Kevin Wolf
Add a --nbd-server option to qemu-storage-daemon to start the built-in NBD server right away. It maps the arguments for nbd-server-start to the command line. Example (only with required options): --nbd-server addr.type=inet,addr.host=localhost,addr.port=10809 Signed-off-by: Kevin Wolf --- q

[RFC PATCH 05/18] qemu-storage-daemon: Add --blockdev option

2019-10-17 Thread Kevin Wolf
This adds a --blockdev option to the storage daemon that works the same as the -blockdev option of the system emulator. In order to be able to link with blockdev.o, we also need to change stream.o from common-obj to block-obj, which is where all other block jobs already are. Signed-off-by: Kevin

[RFC PATCH 08/18] qemu-storage-daemon: Add --export option

2019-10-17 Thread Kevin Wolf
Add a --export option to qemu-storage-daemon to export a block node. For now, only NBD exports are implemented. Apart from the 'type' option (which is the implied key), it maps the arguments for nbd-server-add to the command line. Example: --export nbd,device=disk,name=test-export,writable=on

[RFC PATCH 10/18] qemu-storage-daemon: Add --chardev option

2019-10-17 Thread Kevin Wolf
This adds a --chardev option to the storage daemon that works the same as the -chardev option of the system emulator. Signed-off-by: Kevin Wolf --- qemu-storage-daemon.c | 19 +++ Makefile | 2 +- 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/qemu-s

[RFC PATCH 11/18] monitor: Move monitor option parsing to monitor/monitor.c

2019-10-17 Thread Kevin Wolf
Both the system emulators and the storage daemon will need to parse monitor options, so move that code to monitor/monitor.c, which can be linked into binaries that aren't a system emulator. This patch moves the monitor option parsing from vl.c and adds an allow_hmp parameter so that callers can su

[RFC PATCH 15/18] qapi: Support empty modules

2019-10-17 Thread Kevin Wolf
If you added an include file that doesn't contain any definitions, no source files would be generated for it. However, in other source files, you would still get an #include for the header files of the empty module. The intended behaviour is that empty source files are created for empty modules. T

[RFC PATCH 07/18] blockdev-nbd: Boxed argument type for nbd-server-add

2019-10-17 Thread Kevin Wolf
Move the arguments of nbd-server-add to a new struct BlockExportNbd and convert the command to 'boxed': true. This makes it easier to share code with the storage daemon. Signed-off-by: Kevin Wolf --- qapi/block.json| 20 +++- blockdev-nbd.c | 25 -

[RFC PATCH 16/18] qapi: Create 'pragma' module

2019-10-17 Thread Kevin Wolf
We want to share the whitelists between the system emulator schema and the storage daemon schema, so move all the pragmas from the main schema file into a separate file that can be included from both. Signed-off-by: Kevin Wolf --- qapi/pragma.json | 24 qapi/qapi-sc

[RFC PATCH 12/18] stubs: Update monitor stubs for qemu-storage-daemon

2019-10-17 Thread Kevin Wolf
Before we can add the monitor to qemu-storage-daemon, we need to add a few monitor stubs, and we need to make sure that stubs that are actually implemented in the monitor core aren't linked so that we don't get linker errors because of duplicate symbols. Signed-off-by: Kevin Wolf --- stubs/monit

[RFC PATCH 14/18] monitor: Create monitor/qmp-cmds-monitor.c

2019-10-17 Thread Kevin Wolf
Move all of the QMP commands handlers to implement the 'monitor' module (qapi/monitor.json) that can be shared between the system emulator and the storage daemon to a new file monitor/qmp-cmds-monitor.c. Signed-off-by: Kevin Wolf --- monitor/misc.c | 110 -- m

[RFC PATCH 09/18] qemu-storage-daemon: Add main loop

2019-10-17 Thread Kevin Wolf
Instead of exiting after processing all command line options, start a main loop and keep processing events until exit is requested with a signal (e.g. SIGINT). Now qemu-storage-daemon can be used as an alternative for qemu-nbd that provides a few features that were previously only available from Q

[RFC PATCH 13/18] qapi: Create module 'monitor'

2019-10-17 Thread Kevin Wolf
misc.json contains definitions that are related to the system emulator, so it can't be used for the storage daemon. This patch moves basic functionality that is related to the monitor itself into a new monitor.json, which could be used in tools as well. Signed-off-by: Kevin Wolf --- qapi/misc.js

[RFC PATCH 18/18] qemu-storage-daemon: Add --monitor option

2019-10-17 Thread Kevin Wolf
This adds and parses the --monitor option, so that a QMP monitor can be used in the storage daemon. The monitor offers commands defined in the QAPI schema at storage-daemon/qapi/qapi-schema.json. Signed-off-by: Kevin Wolf --- storage-daemon/qapi/qapi-schema.json | 15 qemu-storage-d

[PATCH v6 04/54] translate-all: use cpu_in_exclusive_work_context() in tb_flush

2019-10-17 Thread Alex Bennée
From: "Emilio G. Cota" tb_flush will be called by the plugin module from a safe work environment. Prepare for that. Suggested-by: Alex Bennée Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- accel/tcg/translate-all.c | 9 +

[PATCH v6 03/54] cpu: introduce cpu_in_exclusive_context()

2019-10-17 Thread Alex Bennée
From: "Emilio G. Cota" Suggested-by: Alex Bennée Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota [AJB: moved inside start/end_exclusive fns + cleanup] Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v4 - -> cpu_in_exclusive_context - moved inside start/end exclusive

Re: [PATCH v2 3/3] tests: More iotest 223 improvements

2019-10-17 Thread Max Reitz
On 15.10.19 21:35, Eric Blake wrote: > Run the core of the test twice, once without iothreads, and again > with, for more coverage of both setups. > > Suggested-by: Nir Soffer > Signed-off-by: Eric Blake > --- > tests/qemu-iotests/223 | 16 ++- > tests/qemu-iotests/223.out | 85

[RFC PATCH 17/18] monitor: Move qmp_query_qmp_schema to qmp-cmds-monitor.c

2019-10-17 Thread Kevin Wolf
monitor/misc.c contains code that works only in the system emulator, so it can't be linked to the storage daemon. In order to make schema introspection available for the storage daemon, move the function to monitor/qmp-cmds-monitor.c, which can be linked into the storage daemon. Signed-off-by: Kev

[PATCH v6 12/54] tcg: add tcg_gen_st_ptr

2019-10-17 Thread Alex Bennée
From: "Emilio G. Cota" Will gain a user soon. Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée --- tcg/tcg-op.h | 5 + 1 file changed, 5 insertions(+) diff --git a/tcg/tcg-op.h b/tcg/tcg-op.h index e9cf172762..7c778f96f3 100644 --- a/tcg/tcg-op.h +

[PATCH v6 05/54] docs/devel: add plugins.rst design document

2019-10-17 Thread Alex Bennée
This is mostly extracted from Emilio's more verbose commit comments with some additional verbiage from me. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v4 - some rewording and tweaks - made non-atomicity of inline ops more explicit - expanded description of plugin unload v

[PATCH v6 01/54] trace: expand mem_info:size_shift to 4 bits

2019-10-17 Thread Alex Bennée
From: "Emilio G. Cota" This will allow us to trace 32k-long memory accesses (although our maximum is something like 256 bytes at the moment). Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota [AJB: expanded to 3->4 bits] Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v5

  1   2   3   4   5   >