Re: [PATCH v1] s390x/tcg: MVCL: Exit to main loop if there are pending interrupts

2019-10-02 Thread David Hildenbrand
On 01.10.19 23:59, Richard Henderson wrote: > On 10/1/19 12:47 PM, David Hildenbrand wrote: >> On 01.10.19 21:17, Richard Henderson wrote: >>> On 10/1/19 11:16 AM, David Hildenbrand wrote: +static inline bool should_interrupt_instruction(CPUState *cs) +{ +/* + * Somethin

Re: [PATCH v3 22/34] spapr, xics, xive: Move cpu_intc_create from SpaprIrq to SpaprInterruptController

2019-10-02 Thread Greg Kurz
On Wed, 2 Oct 2019 12:51:56 +1000 David Gibson wrote: > This method essentially represents code which belongs to the interrupt > controller, but needs to be called on all possible intcs, rather than > just the currently active one. The "dual" version therefore calls > into the xics and xive ver

[PATCH v2] virtio-net: prevent offloads reset on migration

2019-10-02 Thread Mikhail Sennikovsky
Hi all, This is the second version of the patch with the coding style problem fixed. Regards, Mikhail Mikhail Sennikovsky (1): virtio-net: prevent offloads reset on migration hw/display/virtio-gpu-base.c | 3 ++- hw/net/virtio-net.c | 5 +++-- hw/virtio/virtio.c | 11 +++

[PATCH v2] virtio-net: prevent offloads reset on migration

2019-10-02 Thread Mikhail Sennikovsky
Currently offloads disabled by guest via the VIRTIO_NET_CTRL_GUEST_OFFLOADS_SET command are not preserved on VM migration. Instead all offloads reported by guest features (via VIRTIO_PCI_GUEST_FEATURES) get enabled. What happens is: first the VirtIONet::curr_guest_offloads gets restored and offloa

Re: [PATCH v3 22/34] spapr, xics, xive: Move cpu_intc_create from SpaprIrq to SpaprInterruptController

2019-10-02 Thread Cédric Le Goater
On 02/10/2019 08:40, David Gibson wrote: > On Wed, Oct 02, 2019 at 08:13:55AM +0200, Cédric Le Goater wrote: @@ -527,6 +471,30 @@ static int spapr_irq_check(SpaprMachineState *spapr, Error **errp) /* * sPAPR IRQ frontend routines for devices */ +#define ALL_INTCS

Re: bitmap migration bug with -drive while block mirror runs

2019-10-02 Thread Peter Krempa
On Tue, Oct 01, 2019 at 17:26:13 +0200, Max Reitz wrote: > On 01.10.19 16:53, Vladimir Sementsov-Ogievskiy wrote: > > 01.10.2019 17:34, Max Reitz wrote: > >> On 01.10.19 16:27, Vladimir Sementsov-Ogievskiy wrote: > >>> 01.10.2019 17:13, Max Reitz wrote: > On 01.10.19 16:00, Vladimir Sementsov-

Re: [PATCH v3 23/34] spapr, xics, xive: Move irq claim and free from SpaprIrq to SpaprInterruptController

2019-10-02 Thread Greg Kurz
On Wed, 2 Oct 2019 12:51:57 +1000 David Gibson wrote: > These methods, like cpu_intc_create, really belong to the interrupt > controller, but need to be called on all possible intcs. > > Like cpu_intc_create, therefore, make them methods on the intc and > always call it for all existing intcs.

Re: Arch info lost in "info cpus"

2019-10-02 Thread Dr. David Alan Gilbert
* Eduardo Habkost (ehabk...@redhat.com) wrote: > On Mon, Sep 30, 2019 at 09:45:51AM +0100, Dr. David Alan Gilbert wrote: > > * Sergio Lopez (s...@redhat.com) wrote: > > > Hi, > > > > > > Commit 137b5cb6ab565cb3781d5337591e155932b4230e (hmp: change > > > hmp_info_cpus to use query-cpus-fast) update

Re: bitmap migration bug with -drive while block mirror runs

2019-10-02 Thread Kevin Wolf
Am 01.10.2019 um 18:07 hat John Snow geschrieben: > >> So the real back-resolution mechanism is: > > Amendment: >- If our local node-name N is well-formed, use this. >- Otherwise: > >> - Find the first non-filter ancestor, A > >> - if A is not a block-backend, we must use our node-local na

Re: [PATCH v1] s390x/tcg: MVCL: Exit to main loop if there are pending interrupts

2019-10-02 Thread David Hildenbrand
On 02.10.19 09:04, David Hildenbrand wrote: > On 01.10.19 23:59, Richard Henderson wrote: >> On 10/1/19 12:47 PM, David Hildenbrand wrote: >>> On 01.10.19 21:17, Richard Henderson wrote: On 10/1/19 11:16 AM, David Hildenbrand wrote: > +static inline bool should_interrupt_instruction(CPUSta

[PATCH v2] s390x/tcg: MVCL: Exit to main loop if requested

2019-10-02 Thread David Hildenbrand
MVCL is interruptible and we should check for interrupts and process them after writing back the variables to the registers. Let's check for any exit requests and exit to the main loop. When booting Fedora 30, I can see a handful of these exits and it seems to work reliable. (it never get's trigge

[PATCH] monitor/qmp: resume monitor when clearing its queue

2019-10-02 Thread Wolfgang Bumiller
When a monitor's queue is filled up in handle_qmp_command() it gets suspended. It's the dispatcher bh's job currently to resume the monitor, which it does after processing an event from the queue. However, it is possible for a CHR_EVENT_CLOSED event to be processed before before the bh is scheduled

[Bug 1618431] Re: windows hangs after live migration with virtio

2019-10-02 Thread ustcweizhou
** Information type changed from Public to Public Security -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1618431 Title: windows hangs after live migration with virtio Status in QEMU: Fix Release

Re: [RFC PATCH] configure: deprecate 32 bit build hosts

2019-10-02 Thread Daniel P . Berrangé
On Tue, Oct 01, 2019 at 11:02:14AM -0700, Richard Henderson wrote: > On 10/1/19 10:56 AM, Mark Cave-Ayland wrote: > > Just out of interest, which host/compiler combinations don't currently > > implement > > int128_t? > > GCC only implements int128_t for 64-bit targets. QEMU probes for that durin

Re: [PATCH v4 21/31] virtio-9p: Fix error_append_hint/error_prepend usage

2019-10-02 Thread Greg Kurz
On Tue, 1 Oct 2019 18:53:09 +0300 Vladimir Sementsov-Ogievskiy wrote: > If we want to add some info to errp (by error_prepend() or > error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. > Otherwise, this info will not be added when errp == &fatal_err > (the program will exit prior to

Re: [PATCH v3 23/34] spapr, xics, xive: Move irq claim and free from SpaprIrq to SpaprInterruptController

2019-10-02 Thread Cédric Le Goater
On 02/10/2019 04:51, David Gibson wrote: > These methods, like cpu_intc_create, really belong to the interrupt > controller, but need to be called on all possible intcs. > > Like cpu_intc_create, therefore, make them methods on the intc and > always call it for all existing intcs. > > Signed-off-

Re: [PATCH v3 30/34] spapr, xics, xive: Move SpaprIrq::reset hook logic into activate/deactivate

2019-10-02 Thread Greg Kurz
On Wed, 2 Oct 2019 12:52:04 +1000 David Gibson wrote: > It turns out that all the logic in the SpaprIrq::reset hooks (and some in > the SpaprIrq::post_load hooks) isn't really related to resetting the irq > backend (that's handled by the backends' own reset routines). Rather its > about getting

Re: [PATCH v7 00/22] tcg/ppc: Add vector opcodes

2019-10-02 Thread Aleksandar Markovic
01.10.2019. 23.21, "Mark Cave-Ayland" је написао/ла: > > On 30/09/2019 21:21, Richard Henderson wrote: > > > Changes since v6: > > * The have_foo tests have been split so that VSX is not > > combined with ISA revision. > > * The power{7,8,9} patches have been split by isa extension. > >

Re: [PATCH v3 22/34] spapr, xics, xive: Move cpu_intc_create from SpaprIrq to SpaprInterruptController

2019-10-02 Thread Cédric Le Goater
On 02/10/2019 04:51, David Gibson wrote: > This method essentially represents code which belongs to the interrupt > controller, but needs to be called on all possible intcs, rather than > just the currently active one. The "dual" version therefore calls > into the xics and xive versions confusingl

Re: [Qemu-devel] qemu_futex_wait() lockups in ARM64: 2 possible issues

2019-10-02 Thread Paolo Bonzini
On 02/10/19 11:23, Jan Glauber wrote: > I've tried to verify me theory with this patch and didn't run into the > issue for ~500 iterations (usually I would trigger the issue ~20 iterations). Awesome! That would be a compiler bug though, as atomic_add and atomic_sub are defined as sequentially con

Re: [PATCH v3 31/34] spapr, xics, xive: Move SpaprIrq::post_load hook to backends

2019-10-02 Thread Greg Kurz
On Wed, 2 Oct 2019 12:52:05 +1000 David Gibson wrote: > The remaining logic in the post_load hook really belongs to the interrupt > controller backends, and just needs to be called on the active controller > (after the active controller is set to the right thing based on the > incoming migration

Re: [PATCH 0/4] active-mirror: support unaligned guest operations

2019-10-02 Thread Vladimir Sementsov-Ogievskiy
ping 12.09.2019 18:13, Vladimir Sementsov-Ogievskiy wrote: > Commit 9adc1cb49af8d fixed a bug about unaligned (to dirty bitmap > granularity) guest writes (and discards) by simply requesting > corresponding alignment on mirror-top filter. However forcing large > alignment obviously decreases perfo

Re: [PATCH] virtio-net: prevent offloads reset on migration

2019-10-02 Thread Dr. David Alan Gilbert
Copying in Stefan, Jason and Michael who know the virtio details Dave * Mikhail Sennikovsky (mikhail.sennikovs...@cloud.ionos.com) wrote: > Currently offloads disabled by guest via the > VIRTIO_NET_CTRL_GUEST_OFFLOADS_SET > command are not preserved on VM migration. > Instead all offloads repor

Re: [PATCH v2] s390x/tcg: MVCL: Exit to main loop if requested

2019-10-02 Thread Alex Bennée
David Hildenbrand writes: > MVCL is interruptible and we should check for interrupts and process > them after writing back the variables to the registers. Let's check > for any exit requests and exit to the main loop. > > When booting Fedora 30, I can see a handful of these exits and it seems >

Re: [PATCH v4 04/31] error: auto propagated local_err

2019-10-02 Thread Roman Kagan
On Tue, Oct 01, 2019 at 06:52:52PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Here is introduced ERRP_AUTO_PROPAGATE macro, to be used at start of > functions with errp OUT parameter. > > It has three goals: > > 1. Fix issue with error_fatal & error_prepend/error_append_hint: user > can't see t

Re: [PATCH v3 34/34] spapr: Remove last pieces of SpaprIrq

2019-10-02 Thread Greg Kurz
On Wed, 2 Oct 2019 12:52:08 +1000 David Gibson wrote: > The only thing remaining in this structure are the flags to allow either > XICS or XIVE to be present. These actually make more sense as spapr > capabilities - that way they can take advantage of the existing > infrastructure to sanity che

[PATCH] accel/kvm: ensure ret always set

2019-10-02 Thread Alex Bennée
Some of the cross compilers rightly complain there are cases where ret may not be set. 0 seems to be the reasonable default unless particular slot explicitly returns -1. Signed-off-by: Alex Bennée --- accel/kvm/kvm-all.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/a

Re: [PATCH 4/6] qemu-nbd: add compression flag support

2019-10-02 Thread Vladimir Sementsov-Ogievskiy
01.10.2019 23:47, Eric Blake wrote: > On 10/1/19 2:27 PM, Andrey Shinkevich wrote: >> Added possibility to write compressed data by using the >> blk_write_compressed. This action has the limitations of the format >> driver. For example we can't write compressed data over other. >> > >> +++ b/block

Re: bitmap migration bug with -drive while block mirror runs

2019-10-02 Thread Peter Krempa
On Tue, Oct 01, 2019 at 12:07:54 -0400, John Snow wrote: > > > On 10/1/19 11:57 AM, Vladimir Sementsov-Ogievskiy wrote: > > 01.10.2019 17:10, John Snow wrote: > >> > >> > >> On 10/1/19 10:00 AM, Vladimir Sementsov-Ogievskiy wrote: > Otherwise: I have a lot of cloudy ideas on how to solve thi

Re: [PATCH 04/67] iotests.py: create_test_image, remove_test_image

2019-10-02 Thread Max Reitz
On 02.10.19 01:20, John Snow wrote: > > > On 10/1/19 3:46 PM, Max Reitz wrote: >> Python tests should use these two new functions instead of >> qemu_img('create', ...) + os.remove(), so that user-supplied image >> options are interpreted and handled correctly. >> >> Signed-off-by: Max Reitz >> -

Re: [PATCH] accel/kvm: ensure ret always set

2019-10-02 Thread Paolo Bonzini
On 02/10/19 12:22, Alex Bennée wrote: > Some of the cross compilers rightly complain there are cases where ret > may not be set. 0 seems to be the reasonable default unless particular > slot explicitly returns -1. > > Signed-off-by: Alex Bennée > --- > accel/kvm/kvm-all.c | 6 +++--- > 1 file ch

Re: [PATCH v13 1/9] esp: add pseudo-DMA as used by Macintosh

2019-10-02 Thread Philippe Mathieu-Daudé
On 9/27/19 11:04 AM, Laurent Vivier wrote: There is no DMA in Quadra 800, so the CPU reads/writes the data from the PDMA register (offset 0x100, ESP_PDMA in hw/m68k/q800.c) and copies them to/from the memory. There is a nice assembly loop in the kernel to do that, see linux/drivers/scsi/mac_esp.

Re: bitmap migration bug with -drive while block mirror runs

2019-10-02 Thread Kevin Wolf
Am 02.10.2019 um 12:46 hat Peter Krempa geschrieben: > On Tue, Oct 01, 2019 at 12:07:54 -0400, John Snow wrote: > > > > > > On 10/1/19 11:57 AM, Vladimir Sementsov-Ogievskiy wrote: > > > 01.10.2019 17:10, John Snow wrote: > > >> > > >> > > >> On 10/1/19 10:00 AM, Vladimir Sementsov-Ogievskiy wrot

Re: [Qemu-devel] [PATCH 18/19] hw/timer: Declare device little or big endian

2019-10-02 Thread Philippe Mathieu-Daudé
On 8/26/19 4:21 PM, Tony Nguyen wrote: For each device declared with DEVICE_NATIVE_ENDIAN, find the set of targets from the set of target/hw/*/device.o. If the set of targets are all little or all big endian, re-declare as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN respectively. Then, on inspect

[PATCH v5 00/10] Introduce the microvm machine type

2019-10-02 Thread Sergio Lopez
Microvm is a machine type inspired by Firecracker and constructed after the its machine model. It's a minimalist machine type without PCI nor ACPI support, designed for short-lived guests. Microvm also establishes a baseline for benchmarking and optimizing both QEMU and guest operating systems, si

Re: [Qemu-devel] [PATCH 12/19] hw/isa: Declare device little or big endian

2019-10-02 Thread Philippe Mathieu-Daudé
On 8/26/19 4:21 PM, Tony Nguyen wrote: For each device declared with DEVICE_NATIVE_ENDIAN, find the set of targets from the set of target/hw/*/device.o. If the set of targets are all little or all big endian, re-declare as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN respectively. Then, on inspect

[PATCH v5 01/10] hw/virtio: Factorize virtio-mmio headers

2019-10-02 Thread Sergio Lopez
Put QOM and main struct definition in a separate header file, so it can be accessed from other components. Signed-off-by: Sergio Lopez --- hw/virtio/virtio-mmio.c | 48 +- include/hw/virtio/virtio-mmio.h | 73 + 2 files changed, 74 inse

[PATCH v5 03/10] hw/i386/pc: move shared x86 functions to x86.c and export them

2019-10-02 Thread Sergio Lopez
Move x86 functions that will be shared between PC and non-PC machine types to x86.c, along with their helpers. Signed-off-by: Sergio Lopez --- hw/i386/Makefile.objs | 1 + hw/i386/pc.c | 582 +-- hw/i386/pc_piix.c | 1 + hw/i386/pc_q35.c |

[PATCH v5 02/10] hw/i386/pc: rename functions shared with non-PC machines

2019-10-02 Thread Sergio Lopez
load_linux -> x86_load_linux pc_new_cpu -> x86_new_cpu pc_cpus_init -> x86_cpus_init pc_cpu_index_to_props -> x86_cpu_index_to_props pc_get_default_cpu_node_id -> x86_get_default_cpu_node_id pc_possible_cpu_arch_ids -> x86_possible_cpu_arch_ids o

[PATCH v5 06/10] fw_cfg: add "modify" functions for all types

2019-10-02 Thread Sergio Lopez
This allows to alter the contents of an already added item. Signed-off-by: Sergio Lopez --- hw/nvram/fw_cfg.c | 29 +++ include/hw/nvram/fw_cfg.h | 42 +++ 2 files changed, 71 insertions(+) diff --git a/hw/nvram/fw_cfg.c b/hw/n

[PATCH v5 04/10] hw/i386: split PCMachineState deriving X86MachineState from it

2019-10-02 Thread Sergio Lopez
Split up PCMachineState and PCMachineClass and derive X86MachineState and X86MachineClass from them. This allows sharing code with non-PC x86 machine types. Signed-off-by: Sergio Lopez --- hw/acpi/cpu_hotplug.c | 10 +-- hw/i386/acpi-build.c | 29 --- hw/i386/amd_iommu.c | 3 +- hw/i3

[PATCH v5 07/10] hw/intc/apic: reject pic ints if isa_pic == NULL

2019-10-02 Thread Sergio Lopez
In apic_accept_pic_intr(), reject PIC interruptions if a i8259 PIC has not been instantiated (isa_pic == NULL). Suggested-by: Paolo Bonzini Signed-off-by: Sergio Lopez --- hw/intc/apic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/intc/apic.c b/hw/intc/apic.c index bc

[PATCH v5 09/10] docs/microvm.rst: document the new microvm machine type

2019-10-02 Thread Sergio Lopez
Document the new microvm machine type. Signed-off-by: Sergio Lopez --- docs/microvm.rst | 98 1 file changed, 98 insertions(+) create mode 100644 docs/microvm.rst diff --git a/docs/microvm.rst b/docs/microvm.rst new file mode 100644 index 00

[PATCH v5 08/10] roms: add microvm-bios (qboot) as binary and git submodule

2019-10-02 Thread Sergio Lopez
qboot is a minimalist x86 firmware for booting Linux kernels. It does the mininum amount of work required for the task, and it's able to boot both PVH images and bzImages without relying on option roms. This characteristics make it an ideal companion for the microvm machine type. Signed-off-by: S

[PATCH v5 05/10] hw/i386: make x86.c independent from PCMachineState

2019-10-02 Thread Sergio Lopez
As a last step into splitting PCMachineState and deriving X86MachineState from it, make the functions previously extracted from pc.c to x86.c independent from PCMachineState, using X86MachineState instead. Signed-off-by: Sergio Lopez --- hw/i386/pc.c | 13 +++- hw/i386/pc_piix.c

[PATCH v5 10/10] hw/i386: Introduce the microvm machine type

2019-10-02 Thread Sergio Lopez
Microvm is a machine type inspired by Firecracker and constructed after the its machine model. It's a minimalist machine type without PCI nor ACPI support, designed for short-lived guests. Microvm also establishes a baseline for benchmarking and optimizing both QEMU and guest operating systems, si

Re: [Qemu-devel] [PATCH 04/19] hw/core: Declare device little or big endian

2019-10-02 Thread Philippe Mathieu-Daudé
On 8/26/19 4:21 PM, Tony Nguyen wrote: For each device declared with DEVICE_NATIVE_ENDIAN, find the set of targets from the set of target/hw/*/device.o. If the set of targets are all little or all big endian, re-declare as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN respectively. Then, on inspect

Re: [Qemu-devel] [PATCH 00/19] Declare device little or big endian

2019-10-02 Thread Philippe Mathieu-Daudé
On 8/26/19 4:21 PM, Tony Nguyen wrote: This series is an attempt to re-declare devices with DEVICE_NATIVE_ENDIAN as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN. This clean up was split out from an earlier series which collapsed byte swaps along the I/O path. On Wed, 7 Aug 2019 at 12:42, Paolo Bon

RE: Qemu Dirty Bitmap backup to encrypted target

2019-10-02 Thread Craig Mull
Thanks to all who responded on this thread.   This bugzills appears to outline a procedure we can try .. https://bugzilla.redhat.com/show_bug.cgi?id=1662412 ___Craig MullVPC Storage Architectcm...@us.ibm.com      - Original message -From: Peter Krempa Sent by: "Q

Re: [PATCH v5 1/5] iotests: remove 'linux' from default supported platforms

2019-10-02 Thread Max Reitz
On 02.10.19 06:46, Thomas Huth wrote: > On 01/10/2019 20.44, Max Reitz wrote: > [...] >> As I have said, the conceptual problem is that the iotests now run as >> part of make check. As such, allowing auto tests to run on non-Linux >> platforms may introduce build failures that I cannot do anything

Re: [PATCH v2 2/2] qapi: Allow introspecting fix for savevm's cooperation with blockdev

2019-10-02 Thread Markus Armbruster
Eric Blake writes: > On 10/1/19 2:34 PM, Markus Armbruster wrote: >> Peter Krempa writes: >> >>> savevm was buggy as it considered all monitor owned block device nodes >> >> Recommend "monitor-owned block device nodes" or "block device nodes >> owned by a monitor" >> >>> for snapshot. With intro

Re: [PATCH v4 00/31] error: auto propagated local_err

2019-10-02 Thread Markus Armbruster
Reviewing this series is finally getting close to the head of my work queue. I apologize for the delay.

Re: [PATCH v5 00/10] Introduce the microvm machine type

2019-10-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191002113103.45023-1-...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/b

Re: [PATCH v5 10/10] hw/i386: Introduce the microvm machine type

2019-10-02 Thread Thomas Huth
On 02/10/2019 13.31, Sergio Lopez wrote: > Microvm is a machine type inspired by Firecracker and constructed > after the its machine model. > > It's a minimalist machine type without PCI nor ACPI support, designed > for short-lived guests. Microvm also establishes a baseline for > benchmarking and

Re: [PATCH v5 00/10] Introduce the microvm machine type

2019-10-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191002113103.45023-1-...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20191002113103.45023-1-...@redhat.com Subject: [PATCH v5 00/10] Introduce the microvm machine t

Re: bitmap migration bug with -drive while block mirror runs

2019-10-02 Thread Vladimir Sementsov-Ogievskiy
02.10.2019 14:11, Kevin Wolf wrote: > Am 02.10.2019 um 12:46 hat Peter Krempa geschrieben: >> On Tue, Oct 01, 2019 at 12:07:54 -0400, John Snow wrote: >>> >>> >>> On 10/1/19 11:57 AM, Vladimir Sementsov-Ogievskiy wrote: 01.10.2019 17:10, John Snow wrote: > > > On 10/1/19 10:00 AM,

Re: [Qemu-devel] qemu_futex_wait() lockups in ARM64: 2 possible issues

2019-10-02 Thread Jan Glauber
I've looked into this on ThunderX2. The arm64 code generated for the atomic_[add|sub] accesses of ctx->notify_me doesn't contain any memory barriers. It is just plain ldaxr/stlxr. >From my understanding this is not sufficient for SMP sync. If I read this comment correct: void aio_notify(AioC

Re: [Qemu-devel] qemu_futex_wait() lockups in ARM64: 2 possible issues

2019-10-02 Thread Jan Glauber
On Wed, Oct 02, 2019 at 11:45:19AM +0200, Paolo Bonzini wrote: > On 02/10/19 11:23, Jan Glauber wrote: > > I've tried to verify me theory with this patch and didn't run into the > > issue for ~500 iterations (usually I would trigger the issue ~20 > > iterations). > > Awesome! That would be a com

[Bug 1805256] Re: qemu-img hangs on rcu_call_ready_event logic in Aarch64 when converting images

2019-10-02 Thread Jan Glauber
Debug files for aio-posix generated on 18.04 on ThunderX2. Compiler: gcc version 7.4.0 (Ubuntu/Linaro 7.4.0-1ubuntu1~18.04.1) Distro: Ubuntu 18.04.3 LTS ** Attachment added: "aio-posix.tar.xz" https://bugs.launchpad.net/qemu/+bug/1805256/+attachment/5293619/+files/aio-posix.tar.xz -- You r

Re: [PATCH v13 1/9] esp: add pseudo-DMA as used by Macintosh

2019-10-02 Thread Laurent Vivier
Le 02/10/2019 à 13:10, Philippe Mathieu-Daudé a écrit : > On 9/27/19 11:04 AM, Laurent Vivier wrote: >> There is no DMA in Quadra 800, so the CPU reads/writes the data from the >> PDMA register (offset 0x100, ESP_PDMA in hw/m68k/q800.c) and copies them >> to/from the memory. >> >> There is a nice a

Re: [PATCH 15/22] mirror: Prevent loops

2019-10-02 Thread Max Reitz
On 26.09.19 15:08, Vladimir Sementsov-Ogievskiy wrote: > 20.09.2019 18:27, Max Reitz wrote: >> While bdrv_replace_node() will not follow through with it, a specific >> @replaces asks the mirror job to create a loop. >> >> For example, say both the source and the target share a child where the >> so

Re: [PATCH 17/22] iotests: Add VM.assert_block_path()

2019-10-02 Thread Max Reitz
On 26.09.19 16:07, Vladimir Sementsov-Ogievskiy wrote: > 20.09.2019 18:27, Max Reitz wrote: >> Signed-off-by: Max Reitz >> --- >> tests/qemu-iotests/iotests.py | 48 +++ >> 1 file changed, 48 insertions(+) >> >> diff --git a/tests/qemu-iotests/iotests.py b/tests/

Re: [PATCH 19/22] iotests: Use self.image_len in TestRepairQuorum

2019-10-02 Thread Max Reitz
On 26.09.19 16:13, Vladimir Sementsov-Ogievskiy wrote: > 20.09.2019 18:28, Max Reitz wrote: >> 041's TestRepairQuorum has its own image_len, no need to refer to >> TestSingleDrive. (This patch allows uncommenting TestSingleDrive to > > you mean commenting Ah, yes, I mean commenting out. :-) >>

Re: [PATCH 20/22] iotests: Add tests for invalid Quorum @replaces

2019-10-02 Thread Max Reitz
On 26.09.19 16:30, Vladimir Sementsov-Ogievskiy wrote: > 20.09.2019 18:28, Max Reitz wrote: >> Add two tests to see that you cannot replace a Quorum child with the >> mirror job while the child is in use by a different parent. >> >> Signed-off-by: Max Reitz >> --- >> tests/qemu-iotests/041 |

Re: [PATCH 22/22] iotests: Mirror must not attempt to create loops

2019-10-02 Thread Max Reitz
On 26.09.19 17:03, Vladimir Sementsov-Ogievskiy wrote: > 20.09.2019 18:28, Max Reitz wrote: >> Signed-off-by: Max Reitz >> --- >> tests/qemu-iotests/041 | 152 + >> tests/qemu-iotests/041.out | 4 +- >> 2 files changed, 154 insertions(+), 2 deletions(-

Re: [PATCH v4 21/31] virtio-9p: Fix error_append_hint/error_prepend usage

2019-10-02 Thread Vladimir Sementsov-Ogievskiy
02.10.2019 12:19, Greg Kurz wrote: > On Tue, 1 Oct 2019 18:53:09 +0300 > Vladimir Sementsov-Ogievskiy wrote: > >> If we want to add some info to errp (by error_prepend() or >> error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. >> Otherwise, this info will not be added when errp ==

Re: [PATCH v5 1/5] iotests: remove 'linux' from default supported platforms

2019-10-02 Thread Thomas Huth
On 02/10/2019 13.57, Max Reitz wrote: > On 02.10.19 06:46, Thomas Huth wrote: >> [...] >> Max, I can understand that you are a little bit annoyed that this "make >> check with iotests" caused some extra hurdles for you. But honestly, >> removing that again would be quite egoistic by you. Try to put

Re: [PATCH v4 21/31] virtio-9p: Fix error_append_hint/error_prepend usage

2019-10-02 Thread Vladimir Sementsov-Ogievskiy
02.10.2019 15:58, Vladimir Sementsov-Ogievskiy wrote: > 02.10.2019 12:19, Greg Kurz wrote: >> On Tue,  1 Oct 2019 18:53:09 +0300 >> Vladimir Sementsov-Ogievskiy wrote: >> >>> If we want to add some info to errp (by error_prepend() or >>> error_append_hint()), we must use the ERRP_AUTO_PROPAGATE ma

memory barriers and ATOMIC_SEQ_CST on aarch64 (was Re: [Qemu-devel] qemu_futex_wait() lockups in ARM64: 2 possible issues)

2019-10-02 Thread Paolo Bonzini
On 02/10/19 13:05, Jan Glauber wrote: > The arm64 code generated for the > atomic_[add|sub] accesses of ctx->notify_me doesn't contain any > memory barriers. It is just plain ldaxr/stlxr. > > From my understanding this is not sufficient for SMP sync. > >>> If I read this comment correct: >>> >>>

Re: [PATCH v5 09/10] docs/microvm.rst: document the new microvm machine type

2019-10-02 Thread Paolo Bonzini
On 02/10/19 13:31, Sergio Lopez wrote: > +- LAPIC (in userspace by default) Note that LAPIC should be in kernel by default. The userspace LAPIC is slow (cannot use APIC virtualization in recent Intel and AMD processors) and probably somewhat buggy. Paolo > +- IOAPIC (in userspace by default)

Re: [PATCH v5 10/10] hw/i386: Introduce the microvm machine type

2019-10-02 Thread Sergio Lopez
Thomas Huth writes: > On 02/10/2019 13.31, Sergio Lopez wrote: >> Microvm is a machine type inspired by Firecracker and constructed >> after the its machine model. >> >> It's a minimalist machine type without PCI nor ACPI support, designed >> for short-lived guests. Microvm also establishes a b

Re: [PATCH v5 1/5] iotests: remove 'linux' from default supported platforms

2019-10-02 Thread Max Reitz
On 02.10.19 15:11, Thomas Huth wrote: > On 02/10/2019 13.57, Max Reitz wrote: >> On 02.10.19 06:46, Thomas Huth wrote: >>> [...] >>> Max, I can understand that you are a little bit annoyed that this "make >>> check with iotests" caused some extra hurdles for you. But honestly, >>> removing that aga

Re: [PATCH v5 09/10] docs/microvm.rst: document the new microvm machine type

2019-10-02 Thread Sergio Lopez
Paolo Bonzini writes: > On 02/10/19 13:31, Sergio Lopez wrote: >> +- LAPIC (in userspace by default) > > Note that LAPIC should be in kernel by default. The userspace LAPIC is > slow (cannot use APIC virtualization in recent Intel and AMD processors) > and probably somewhat buggy. Thanks for c

Re: bitmap migration bug with -drive while block mirror runs

2019-10-02 Thread Peter Krempa
On Wed, Oct 02, 2019 at 13:11:47 +0200, Kevin Wolf wrote: > Am 02.10.2019 um 12:46 hat Peter Krempa geschrieben: [...] > > I'd like to re-iterate that the necessity to keep node names same on > > both sides of migration is unexpected, undocumented and in some cases > > impossible. > > I think th

Re: bitmap migration bug with -drive while block mirror runs

2019-10-02 Thread Peter Krempa
On Wed, Oct 02, 2019 at 12:22:01 +, Vladimir Sementsov-Ogievskiy wrote: > 02.10.2019 14:11, Kevin Wolf wrote: > > Am 02.10.2019 um 12:46 hat Peter Krempa geschrieben: > >> On Tue, Oct 01, 2019 at 12:07:54 -0400, John Snow wrote: > >>> > >>> > >>> On 10/1/19 11:57 AM, Vladimir Sementsov-Ogievski

Re: [PATCH 17/22] iotests: Add VM.assert_block_path()

2019-10-02 Thread Vladimir Sementsov-Ogievskiy
02.10.2019 15:40, Max Reitz wrote: > On 26.09.19 16:07, Vladimir Sementsov-Ogievskiy wrote: >> 20.09.2019 18:27, Max Reitz wrote: >>> Signed-off-by: Max Reitz >>> --- >>>tests/qemu-iotests/iotests.py | 48 +++ >>>1 file changed, 48 insertions(+) >>> >>> diff

Re: [PATCH v4 04/31] error: auto propagated local_err

2019-10-02 Thread Eric Blake
On 10/2/19 5:15 AM, Roman Kagan wrote: On Tue, Oct 01, 2019 at 06:52:52PM +0300, Vladimir Sementsov-Ogievskiy wrote: Here is introduced ERRP_AUTO_PROPAGATE macro, to be used at start of functions with errp OUT parameter. It has three goals: 1. Fix issue with error_fatal & error_prepend/error_a

Re: bitmap migration bug with -drive while block mirror runs

2019-10-02 Thread Vladimir Sementsov-Ogievskiy
02.10.2019 16:43, Peter Krempa wrote: > On Wed, Oct 02, 2019 at 13:11:47 +0200, Kevin Wolf wrote: >> Am 02.10.2019 um 12:46 hat Peter Krempa geschrieben: > > [...] > >>> I'd like to re-iterate that the necessity to keep node names same on >>> both sides of migration is unexpected, undocumented an

Re: target/ppc: bug in optimised vsl/vsr implementation?

2019-10-02 Thread Stefan Brankovic
Hi Mark, Thank you for reporting this bug. I was away from office for couple of days, so that's why I am answering you a bit late, sorry about that. I will start working on a solution and try to fix this problem in next couple of days. On 1.10.19. 20:24, Mark Cave-Ayland wrote: On 28/09/201

Re: [PATCH] spapr/xive: skip partially initialized vCPUs in presenter

2019-10-02 Thread Greg Kurz
On Wed, 2 Oct 2019 11:02:45 +1000 David Gibson wrote: > On Tue, Oct 01, 2019 at 06:56:28PM +0200, Greg Kurz wrote: > > On Tue, 1 Oct 2019 13:56:10 +0200 > > Cédric Le Goater wrote: > > > > > On 01/10/2019 13:06, Greg Kurz wrote: > > > > On Tue, 1 Oct 2019 10:57:22 +0200 > > > > Cédric Le Goate

[PATCH] iotests: Do not run the iotests during "make check" anymore

2019-10-02 Thread Thomas Huth
Running the iotests during "make check" is causing more headaches than benefits for the block layer maintainers, so let's disable the iotests during "make check" again. Signed-off-by: Thomas Huth --- tests/Makefile.include | 2 +- tests/qemu-iotests/group | 2 +- 2 files changed, 2 insertions(

[PATCH v2 4/6] block: support compressed write for copy-on-read

2019-10-02 Thread Andrey Shinkevich
Support the data compression during block-stream job over a backup backing chain implemented in the following patch 'block-stream: add compress option'. Signed-off-by: Anton Nefedov Signed-off-by: Denis V. Lunev Signed-off-by: Andrey Shinkevich --- block/io.c | 21 -

[PATCH v2 3/6] qemu-nbd: add compression flag support

2019-10-02 Thread Andrey Shinkevich
Added possibility to write compressed data by using the blk_write_compressed. This action has the limitations of the format driver. For example we can't write compressed data over other. $ ./qemu-img create -f qcow2 -o size=10G ./image.qcow2 $ sudo ./qemu-nbd -c /dev/nbd0 ./image.qcow2 $ sudo dd i

[PATCH v2 1/6] qcow2: Allow writing compressed data to multiple clusters

2019-10-02 Thread Andrey Shinkevich
QEMU currently supports writing compressed data of size less than or equal to one cluster. This patch allows writing QCOW2 compressed data that exceed one cluster. The implementation is simple, we split buffered data into separate clusters and write them using the existing functionality. For unalig

[PATCH v2 2/6] tests/qemu-iotests: add case of writing compressed data to multiple clusters

2019-10-02 Thread Andrey Shinkevich
Add the test case to the iotest #214 that checks possibility of writing compressed data to more than one cluster. Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/214 | 9 + tests/qemu-iotests/214.out | 6 ++ 2 files changed, 15 insertions(+) diff --git a/tests/qemu-iotes

[PATCH v2 5/6] block-stream: add compress option

2019-10-02 Thread Andrey Shinkevich
Allow data compression during block-stream job for backup backing chain. Signed-off-by: Anton Nefedov Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev Signed-off-by: Andrey Shinkevich --- block/stream.c| 19 +-- blockdev.c|

[PATCH v2 0/6] qcow2: advanced compression options

2019-10-02 Thread Andrey Shinkevich
New enhancements for writing compressed data to QCOW2 image. The preceding patches have been queued in the Max's block branch: Based-on: https://github.com/XanClic/qemu.git block v2: The number of parameters in nbd_export_new() has been reduced by the introduced flags for all the boolean

[PATCH v2 6/6] tests/qemu-iotests: add case for block-stream compress

2019-10-02 Thread Andrey Shinkevich
Add a test case to the iotest #030 that checks 'compress' option for a block-stream job. Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/030 | 49 +- tests/qemu-iotests/030.out | 4 ++-- 2 files changed, 50 insertions(+), 3 deletions(-) d

Re: [PATCH v5 1/5] iotests: remove 'linux' from default supported platforms

2019-10-02 Thread Thomas Huth
On 02/10/2019 15.36, Max Reitz wrote: [...] > Or can we have some middle ground? Something that runs on some CI > systems (and notifies me and others) but won’t result in pull requests > being rejected or cause make check failures? Yes, I think that might be an option... Since many developers are

Re: [PATCH 4/7] qapi: Speed up frontend tests

2019-10-02 Thread Markus Armbruster
Eric Blake writes: > On 10/1/19 2:15 PM, Markus Armbruster wrote: >> "make check-qapi-schema" takes around 10s user + system time for me. >> With -j, it takes a bit over 3s real time. We have worse tests. It's >> still annoying when you work on the QAPI generator. > > All true :) > > >> test-qa

Re: [PATCH] iotests: Do not run the iotests during "make check" anymore

2019-10-02 Thread Max Reitz
On 02.10.19 16:21, Thomas Huth wrote: > Running the iotests during "make check" is causing more headaches than > benefits for the block layer maintainers, so let's disable the iotests > during "make check" again. > > Signed-off-by: Thomas Huth > --- > tests/Makefile.include | 2 +- > tests/qem

Re: [PATCH] spapr/xive: skip partially initialized vCPUs in presenter

2019-10-02 Thread Cédric Le Goater
On 02/10/2019 16:21, Greg Kurz wrote: > On Wed, 2 Oct 2019 11:02:45 +1000 > David Gibson wrote: > >> On Tue, Oct 01, 2019 at 06:56:28PM +0200, Greg Kurz wrote: >>> On Tue, 1 Oct 2019 13:56:10 +0200 >>> Cédric Le Goater wrote: >>> On 01/10/2019 13:06, Greg Kurz wrote: > On Tue, 1 Oct 20

[PATCH] target/riscv: Expose "priv" register for GDB

2019-10-02 Thread Jonathan Behrens
This patch enables a debugger to read and write the current privilege level via a special "priv" register. When compiled with CONFIG_USER_ONLY the register is still visible but is hardwired to zero. Signed-off-by: Jonathan Behrens --- gdb-xml/riscv-32bit-cpu.xml | 1 + gdb-xml/riscv-64bit-cpu.x

Re: [PATCH 3/4] block/mirror: support unaligned write in active mirror

2019-10-02 Thread Max Reitz
On 12.09.19 17:13, Vladimir Sementsov-Ogievskiy wrote: > Prior 9adc1cb49af8d do_sync_target_write had a bug: it reset aligned-up > region in the dirty bitmap, which means that we may not copy some bytes > and assume them copied, which actually leads to producing corrupted > target. > > So 9adc1cb4

Re: [PATCH 1/4] block/mirror: simplify do_sync_target_write

2019-10-02 Thread Max Reitz
On 12.09.19 17:13, Vladimir Sementsov-Ogievskiy wrote: > do_sync_target_write is called from bdrv_mirror_top_do_write after > write/discard operation, all inside active_write/active_write_settle > protecting us from mirror iteration. So the whole area is dirty for > sure, no reason to examine dirty

Re: memory barriers and ATOMIC_SEQ_CST on aarch64 (was Re: [Qemu-devel] qemu_futex_wait() lockups in ARM64: 2 possible issues)

2019-10-02 Thread Torvald Riegel
On Wed, 2019-10-02 at 15:20 +0200, Paolo Bonzini wrote: > On 02/10/19 13:05, Jan Glauber wrote: > > The arm64 code generated for the > > atomic_[add|sub] accesses of ctx->notify_me doesn't contain any > > memory barriers. It is just plain ldaxr/stlxr. > > > > From my understanding this is not suff

Re: [PATCH 2/4] block/block-backend: add blk_co_pwritev_part

2019-10-02 Thread Max Reitz
On 12.09.19 17:13, Vladimir Sementsov-Ogievskiy wrote: > Add blk write function with qiov_offset parameter. It's needed for the > following commit. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/sysemu/block-backend.h | 4 > block/block-backend.c | 17

Re: [PATCH v13 1/9] esp: add pseudo-DMA as used by Macintosh

2019-10-02 Thread Philippe Mathieu-Daudé
On 10/2/19 2:33 PM, Laurent Vivier wrote: Le 02/10/2019 à 13:10, Philippe Mathieu-Daudé a écrit : On 9/27/19 11:04 AM, Laurent Vivier wrote: There is no DMA in Quadra 800, so the CPU reads/writes the data from the PDMA register (offset 0x100, ESP_PDMA in hw/m68k/q800.c) and copies them to/from

Re: [PATCH] iotests: Do not run the iotests during "make check" anymore

2019-10-02 Thread Daniel P . Berrangé
On Wed, Oct 02, 2019 at 04:21:46PM +0200, Thomas Huth wrote: > Running the iotests during "make check" is causing more headaches than > benefits for the block layer maintainers, so let's disable the iotests > during "make check" again. > > Signed-off-by: Thomas Huth > --- > tests/Makefile.includ

Re: [PATCH 3/4] block/mirror: support unaligned write in active mirror

2019-10-02 Thread Vladimir Sementsov-Ogievskiy
02.10.2019 17:57, Max Reitz wrote: > On 12.09.19 17:13, Vladimir Sementsov-Ogievskiy wrote: >> Prior 9adc1cb49af8d do_sync_target_write had a bug: it reset aligned-up >> region in the dirty bitmap, which means that we may not copy some bytes >> and assume them copied, which actually leads to produc

  1   2   3   >