Re: [Qemu-devel] [PATCH v12 2/2] block/backup: fix backup_cow_with_offload for last cluster

2019-09-19 Thread Vladimir Sementsov-Ogievskiy
18.09.2019 23:14, John Snow wrote: > > > On 9/17/19 12:07 PM, Vladimir Sementsov-Ogievskiy wrote: >> We shouldn't try to copy bytes beyond EOF. Fix it. >> >> Fixes: 9ded4a0114968e >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> Reviewed-by: Max Reitz >> --- >>   block/backup.c | 2 +- >>   1 f

[Qemu-devel] [PULL 2/4] vnc: fix websocket field in events

2019-09-19 Thread Gerd Hoffmann
Just need to fill VncClientInfo.websocket in vnc_client_cache_addr(). Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1748175 Signed-off-by: Gerd Hoffmann Reviewed-by: Stefan Hajnoczi Message-id: 20190904055250.22421-1-kra...@redhat.com --- ui/vnc.c | 1 + 1 file changed, 1 insertion(+) d

[Qemu-devel] [PULL 0/4] Ui 20190919 patches

2019-09-19 Thread Gerd Hoffmann
The following changes since commit 89ea03a7dc83ca36b670ba7f787802791fcb04b1: Merge remote-tracking branch 'remotes/huth-gitlab/tags/m68k-pull-2019-09-07' into staging (2019-09-09 09:48:34 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/ui-20190919-pu

[Qemu-devel] [PULL 1/4] ui/egl: fix framebuffer reads

2019-09-19 Thread Gerd Hoffmann
Fix egl_fb_read() to use the (destination) surface size instead of the (source) framebuffer source for glReadPixels. Pass the DisplaySurface instead of the pixeldata pointer to egl_fb_read() to make this possible. With that in place framebuffer reads work fine even if the surface and framebuffer

[Qemu-devel] [PULL 3/4] ui: add an embedded Barrier client

2019-09-19 Thread Gerd Hoffmann
From: Laurent Vivier This allows to receive mouse and keyboard events from a Barrier server. This is enabled by adding the following parameter on the command line ... -object input-barrier,id=$id,name=$name ... Where $name is the name declared in the screens section of barrier.conf The ba

[Qemu-devel] [PULL 4/4] vnc: fix memory leak when vnc disconnect

2019-09-19 Thread Gerd Hoffmann
From: Li Qiang Currently when qemu receives a vnc connect, it creates a 'VncState' to represent this connection. In 'vnc_worker_thread_loop' it creates a local 'VncState'. The connection 'VcnState' and local 'VncState' exchange data in 'vnc_async_encoding_start' and 'vnc_async_encoding_end'. In '

Re: [Qemu-devel] [Qemu-block] [PATCH] block/backup: install notifier during creation

2019-09-19 Thread Vladimir Sementsov-Ogievskiy
18.09.2019 23:31, John Snow wrote: > > > On 9/10/19 9:23 AM, John Snow wrote: >> >> >> On 9/10/19 4:19 AM, Stefan Hajnoczi wrote: >>> On Wed, Aug 21, 2019 at 04:01:52PM -0400, John Snow wrote: On 8/21/19 10:41 AM, Vladimir Sementsov-Ogievskiy wrote: > 09.08.2019 23:13, John Sno

Re: [Qemu-devel] vhost, iova, and dirty page tracking

2019-09-19 Thread Tian, Kevin
+Paolo to help clarify here. > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Thursday, September 19, 2019 2:32 PM > > > On 2019/9/19 下午2:17, Yan Zhao wrote: > > On Thu, Sep 19, 2019 at 02:09:53PM +0800, Jason Wang wrote: > >> On 2019/9/19 下午1:28, Yan Zhao wrote: > >>> On Thu, Sep 19, 201

Re: [Qemu-devel] [PULL 4/4] vnc: fix memory leak when vnc disconnect

2019-09-19 Thread Li Qiang
Gerd Hoffmann 于2019年9月19日周四 下午3:12写道: > From: Li Qiang > > Currently when qemu receives a vnc connect, it creates a 'VncState' to > represent this connection. In 'vnc_worker_thread_loop' it creates a > local 'VncState'. The connection 'VcnState' and local 'VncState' exchange > data in 'vnc_async

Re: [Qemu-devel] [RFC] error: auto propagated local_err

2019-09-19 Thread David Hildenbrand
On 18.09.19 15:02, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > Here is a proposal (three of them, actually) of auto propagation for > local_err, to not call error_propagate on every exit point, when we > deal with local_err. > > It also may help make Greg's series[1] about error_append_hint

Re: [Qemu-devel] [RFC] error: auto propagated local_err

2019-09-19 Thread Vladimir Sementsov-Ogievskiy
19.09.2019 10:32, David Hildenbrand wrote: > On 18.09.19 15:02, Vladimir Sementsov-Ogievskiy wrote: >> Hi all! >> >> Here is a proposal (three of them, actually) of auto propagation for >> local_err, to not call error_propagate on every exit point, when we >> deal with local_err. >> >> It also may

Re: [Qemu-devel] [RFC] error: auto propagated local_err

2019-09-19 Thread David Hildenbrand
On 19.09.19 09:41, Vladimir Sementsov-Ogievskiy wrote: > 19.09.2019 10:32, David Hildenbrand wrote: >> On 18.09.19 15:02, Vladimir Sementsov-Ogievskiy wrote: >>> Hi all! >>> >>> Here is a proposal (three of them, actually) of auto propagation for >>> local_err, to not call error_propagate on every

Re: [Qemu-devel] [RFC] error: auto propagated local_err

2019-09-19 Thread Vladimir Sementsov-Ogievskiy
19.09.2019 10:53, David Hildenbrand wrote: > On 19.09.19 09:41, Vladimir Sementsov-Ogievskiy wrote: >> 19.09.2019 10:32, David Hildenbrand wrote: >>> On 18.09.19 15:02, Vladimir Sementsov-Ogievskiy wrote: Hi all! Here is a proposal (three of them, actually) of auto propagation for >>

Re: [Qemu-devel] [RFC] error: auto propagated local_err

2019-09-19 Thread David Hildenbrand
On 19.09.19 10:20, Vladimir Sementsov-Ogievskiy wrote: > 19.09.2019 10:53, David Hildenbrand wrote: >> On 19.09.19 09:41, Vladimir Sementsov-Ogievskiy wrote: >>> 19.09.2019 10:32, David Hildenbrand wrote: On 18.09.19 15:02, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > Here is

Re: [Qemu-devel] [PATCH] iotests: Require Python 3.5 or later

2019-09-19 Thread Kevin Wolf
Am 18.09.2019 um 20:49 hat John Snow geschrieben: > > > On 9/18/19 4:55 AM, Kevin Wolf wrote: > > Running iotests is not required to build QEMU, so we can have stricter > > version requirements for Python here and can make use of new features > > and drop compatibility code earlier. > > > > This

[Qemu-devel] [PULL 00/26] Audio 20190919 patches

2019-09-19 Thread Gerd Hoffmann
The following changes since commit f8c3db33a5e863291182f8862ddf81618a7c6194: target/sparc: Switch to do_transaction_failed() hook (2019-09-17 12:01:00 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/audio-20190919-pull-request for you to fetch changes up to

[Qemu-devel] [PULL 17/26] paaudio: get/put_buffer functions

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán This lets us avoid some buffer copying when using mixeng. Signed-off-by: Kővágó, Zoltán Message-id: 4554ff54ad04f706ad0e9af87fe07650fd6d9ac1.1568574965.git.dirty.ice...@gmail.com Signed-off-by: Gerd Hoffmann --- audio/paaudio.c | 83 ++

[Qemu-devel] [PULL 03/26] coreaudio: port to the new audio backend api

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán Signed-off-by: Kővágó, Zoltán Message-id: 60d68c051ed180c7315f7cdd6084b58b6fc9bb6d.1568574965.git.dirty.ice...@gmail.com Signed-off-by: Gerd Hoffmann --- audio/coreaudio.c | 130 -- 1 file changed, 69 insertions(+), 61 deletions

Re: [Qemu-devel] [PATCH v2 2/3] audio: add -audiodev pa, in|out.latency= to documentation

2019-09-19 Thread Gerd Hoffmann
On Wed, Sep 18, 2019 at 10:53:34AM +0100, Stefan Hajnoczi wrote: > The "latency" parameter wasn't covered by the documentation. Doesn't apply cleanly (on top of the surround sound patch series). Picked the other two into the pull request. Please rebase & resend once this is merged. thanks, Gerd

[Qemu-devel] [PULL 05/26] noaudio: port to the new audio backend api

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán Signed-off-by: Kővágó, Zoltán Message-id: 066dc6dd54f4382d80de4376306f585b7fb47805.1568574965.git.dirty.ice...@gmail.com Signed-off-by: Gerd Hoffmann --- audio/noaudio.c | 39 +++ 1 file changed, 15 insertions(+), 24 deletions(-) diff

[Qemu-devel] [PULL 15/26] audio: add mixeng option (documentation)

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán This will allow us to disable mixeng when we use a decent backend. Disabling mixeng have a few advantages: * we no longer convert the audio output from one format to another, when the underlying audio system would just convert it to a third format. We no longer convert,

[Qemu-devel] [PULL 16/26] audio: make mixeng optional

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán Implementation of the previously added mixing-engine option. Signed-off-by: Kővágó, Zoltán Message-id: 0adb9ca41b5abad2e048e9e36137446e86d5905c.1568574965.git.dirty.ice...@gmail.com Signed-off-by: Gerd Hoffmann --- audio/audio_template.h | 20 audio/audio.c

[Qemu-devel] [PULL 20/26] audio: basic support for multichannel audio

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán Which currently only means removing some checks. Old code won't require more than two channels, but new code will need it. Signed-off-by: Kővágó, Zoltán Message-id: 00998152d6e1c25b3194b9b71e27f14c4d26f396.1568574965.git.dirty.ice...@gmail.com Signed-off-by: Gerd Hoffmann

[Qemu-devel] [PULL 08/26] sdlaudio: port to the new audio backend api

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán Signed-off-by: Kővágó, Zoltán Message-id: 3e95a57a0663f1f4464cd3515e252628791c971e.1568574965.git.dirty.ice...@gmail.com Signed-off-by: Gerd Hoffmann --- audio/sdlaudio.c | 87 +++- 1 file changed, 42 insertions(+), 45 deletions

[Qemu-devel] [PULL 10/26] wavaudio: port to the new audio backend api

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán Signed-off-by: Kővágó, Zoltán Message-id: fc447ed1336d60025485bbe6f3a4da52b1359077.1568574965.git.dirty.ice...@gmail.com Signed-off-by: Gerd Hoffmann --- audio/wavaudio.c | 54 1 file changed, 9 insertions(+), 45 deletions(

[Qemu-devel] [PULL 25/26] audio: fix buffer-length typo in documentation

2019-09-19 Thread Gerd Hoffmann
From: Stefan Hajnoczi Fixes: f0b3d811529 ("audio: -audiodev command line option: documentation") Signed-off-by: Stefan Hajnoczi Message-Id: <20190918095335.7646-2-stefa...@redhat.com> Signed-off-by: Gerd Hoffmann --- qemu-options.hx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) di

[Qemu-devel] [PULL 01/26] audio: api for mixeng code free backends

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán This will make it possible to skip mixeng with audio playback and recording, allowing us to free ourselves from the limitations of the current mixeng (stereo, int64 samples only). In this case, HW and SW voices will be essentially the same, for every SW voice we will create

[Qemu-devel] [PULL 02/26] alsaaudio: port to the new audio backend api

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán Signed-off-by: Kővágó, Zoltán Message-id: 3978a3642e68da4d0af61c7618fcaa4ee22b009f.1568574965.git.dirty.ice...@gmail.com Signed-off-by: Gerd Hoffmann --- audio/alsaaudio.c | 308 +- 1 file changed, 83 insertions(+), 225 deletion

[Qemu-devel] [PULL 06/26] ossaudio: port to the new audio backend api

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán Signed-off-by: Kővágó, Zoltán Message-id: 44f4e888975c1d94f5d89e945df9782c0f541582.1568574965.git.dirty.ice...@gmail.com Signed-off-by: Gerd Hoffmann --- audio/ossaudio.c | 288 +-- 1 file changed, 104 insertions(+), 184 deletio

[Qemu-devel] [PULL 13/26] audio: common rate control code for timer based outputs

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán This commit removes the ad-hoc rate-limiting code from noaudio and wavaudio, and replaces them with a (slightly modified) code from spiceaudio. This way multiple write calls (for example when the circular buffer wraps around) do not cause problems. Signed-off-by: Kővágó, Zo

[Qemu-devel] [PULL 09/26] spiceaudio: port to the new audio backend api

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán Signed-off-by: Kővágó, Zoltán Message-id: 71731ff2437028514284394de0f60d195d42e593.1568574965.git.dirty.ice...@gmail.com Signed-off-by: Gerd Hoffmann --- audio/spiceaudio.c | 116 - 1 file changed, 42 insertions(+), 74 deletions

[Qemu-devel] [PULL 04/26] dsoundaudio: port to the new audio backend api

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán Signed-off-by: Kővágó, Zoltán Message-id: 0019bfb5ae50b0750b839460b5dbc1b3073f02e7.1568574965.git.dirty.ice...@gmail.com Signed-off-by: Gerd Hoffmann --- audio/dsound_template.h | 47 +++--- audio/dsoundaudio.c | 329 ++-- 2 files

[Qemu-devel] [PULL 11/26] audio: remove remains of the old backend api

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán Signed-off-by: Kővágó, Zoltán Message-id: 3c160307074a29e5826a89994ab7cfdee7b8ccf8.1568574965.git.dirty.ice...@gmail.com Signed-off-by: Gerd Hoffmann --- audio/audio_int.h | 7 --- audio/audio.c | 42 ++ 2 files changed, 6

[Qemu-devel] [PULL 21/26] paaudio: channel-map option

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán Add an option to change the channel map used by pulseaudio. If not specified, falls back to an OSS compatible channel map. Signed-off-by: Kővágó, Zoltán Message-id: 66670d43bd932be0919668cec6a8cd172bfb8383.1568574965.git.dirty.ice...@gmail.com Signed-off-by: Gerd Hoffmann

Re: [Qemu-devel] [PATCH] chardev: Add RFC2217 support for telnet client mode

2019-09-19 Thread Marc-André Lureau
Hi Sylvain On Wed, Sep 18, 2019 at 5:05 AM Sylvain Munaut wrote: > > This allow remote control of the baudrate and other comms > parameters. > > Signed-off-by: Sylvain Munaut > --- > chardev/char-socket.c | 232 ++ > chardev/char.c| 6 ++ > qapi

[Qemu-devel] [PULL 24/26] usbaudio: change playback counters to 64 bit

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán With stereo playback, they need about 375 minutes of continuous audio playback to overflow, which is usually not a problem (as stopping and later resuming playback resets the counters). But with 7.1 audio, they only need about 95 minutes to overflow. After the overflow, the

[Qemu-devel] [PULL 22/26] usb-audio: do not count on avail bytes actually available

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán This assumption is no longer true when mixeng is turned off. Signed-off-by: Kővágó, Zoltán Message-id: 90b5ec62109a69ee7c28d95b367e40dc41ad658a.1568574965.git.dirty.ice...@gmail.com Signed-off-by: Gerd Hoffmann --- hw/usb/dev-audio.c | 30 ++

[Qemu-devel] [PULL 19/26] audio: replace shift in audio_pcm_info with bytes_per_frame

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán The bit shifting trick worked because the number of bytes per frame was always a power-of-two (since QEMU only supports mono, stereo and 8, 16 and 32 bit samples). But if we want to add support for surround sound, this no longer holds true. Signed-off-by: Kővágó, Zoltán Me

[Qemu-devel] [PULL 07/26] paaudio: port to the new audio backend api

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán Signed-off-by: Kővágó, Zoltán Message-id: f8f15e33739cd18305a3719270b52d61ece68bd5.1568574965.git.dirty.ice...@gmail.com Signed-off-by: Gerd Hoffmann --- configure| 5 - audio/audio_pt_int.h | 22 --- audio/audio_pt_int.c | 173 audio/p

[Qemu-devel] [PULL 26/26] audio: fix ALSA period-length typo in documentation

2019-09-19 Thread Gerd Hoffmann
From: Stefan Hajnoczi Fixes: f0b3d811529 ("audio: -audiodev command line option: documentation") Signed-off-by: Stefan Hajnoczi Message-Id: <20190918095335.7646-4-stefa...@redhat.com> Signed-off-by: Gerd Hoffmann --- qemu-options.hx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) di

[Qemu-devel] [PULL 23/26] usb-audio: support more than two channels of audio

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán This commit adds support for 5.1 and 7.1 audio playback. This commit adds a new property to usb-audio: * multi=on|off Whether to enable the 5.1 and 7.1 audio support. When off (default) it continues to emulate the old stereo-only device. When on, it emulates a sligh

Re: [Qemu-devel] [PATCH 10/17] s390x/css: Pass local error object pointer to error_append_hint()

2019-09-19 Thread Cornelia Huck
On Wed, 18 Sep 2019 12:46:42 -0500 Eric Blake wrote: > On 9/18/19 5:26 AM, Cornelia Huck wrote: > > On Tue, 17 Sep 2019 18:36:20 +0200 > > Greg Kurz wrote: > > > >> On Tue, 17 Sep 2019 13:24:12 +0200 > >> Cornelia Huck wrote: > >> > >>> On Tue, 17 Sep 2019 12:21:34 +0200 > >>> Greg Kurz w

[Qemu-devel] [PULL 18/26] audio: support more than two channels in volume setting

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán Signed-off-by: Kővágó, Zoltán Message-id: 4c938a46b760792319dbc2f61a442a41a36718d3.1568574965.git.dirty.ice...@gmail.com Signed-off-by: Gerd Hoffmann --- audio/audio.h | 10 ++ audio/audio_int.h | 4 ++-- audio/audio.c | 30 ++--

[Qemu-devel] [PULL 12/26] audio: unify input and output mixeng buffer management

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán Usage notes: hw->samples became hw->{mix,conv}_buf->size, except before initialization (audio_pcm_hw_alloc_resources_*), hw->samples gives the initial size of the STSampleBuffer. The next commit tries to fix this inconsistency. Signed-off-by: Kővágó, Zoltán Message-id: c7

Re: [Qemu-devel] Docker Tests

2019-09-19 Thread Alex Bennée
John Snow writes: > Hi, I'm having a regular trainwreck here w/ the Docker test suite and I > have a few questions; > > 1. Which tests should I expect to work by default? for instance, > make-debug doesn't but I think that might be normal. Is that the only > one? test-build is the only one tha

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Add xkbcommon configure options

2019-09-19 Thread Gerd Hoffmann
On Mon, Sep 16, 2019 at 10:15:15AM +0200, Laurent Vivier wrote: > Le 14/09/2019 à 16:51, James Le Cuirot a écrit : > > This dependency is currently "automagic", which is bad for distributions. > > > > Signed-off-by: James Le Cuirot > > --- > > configure | 5 + > > 1 file changed, 5 insertion

[Qemu-devel] [PULL 14/26] audio: split ctl_* functions into enable_* and volume_*

2019-09-19 Thread Gerd Hoffmann
From: Kővágó, Zoltán This way we no longer need vararg functions, improving compile time error detection. Also now it's possible to check actually what commands are supported, without needing to manually update ctl_caps. Signed-off-by: Kővágó, Zoltán Message-id: 7f40c7fff80879916356103cc05d14

Re: [Qemu-devel] [PATCH] docker: remove python2.7 from docker9-mxe

2019-09-19 Thread Alex Bennée
John Snow writes: > When it was based on docker8 which uses python-minimal, it needed this. > It no longer does. Queued to testing/next, thanks. > > Goodbye, python2.7. > > Signed-off-by: John Snow > --- > tests/docker/dockerfiles/debian9-mxe.docker | 3 +-- > 1 file changed, 1 insertion(+),

Re: [Qemu-devel] [RFC] error: auto propagated local_err

2019-09-19 Thread Max Reitz
On 18.09.19 15:02, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > Here is a proposal (three of them, actually) of auto propagation for > local_err, to not call error_propagate on every exit point, when we > deal with local_err. > > It also may help make Greg's series[1] about error_append_hint

Re: [Qemu-devel] [PATCH] tests/tcg: add simple record/replay smoke test for aarch64

2019-09-19 Thread Pavel Dovgalyuk
Thanks! This seem to correctly run record and replay command lines. When I break the replay correctness, then the test reports a timeout error. However, we need some kind of a manual for tcg testing. I had to dig through makefile and configure scripts to undestand that testing needs the cross co

Re: [Qemu-devel] [for-4.2 PATCH 3/6] replay: update docs for record/replay with block devices

2019-09-19 Thread Kevin Wolf
Am 18.09.2019 um 11:52 hat Pavel Dovgalyuk geschrieben: > > From: Kevin Wolf [mailto:kw...@redhat.com] > > Am 18.09.2019 um 11:37 hat Pavel Dovgalyuk geschrieben: > > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > > Am 18.09.2019 um 11:22 hat Pavel Dovgalyuk geschrieben: > > > > > > From: Kev

Re: [Qemu-devel] Discussion: vnc: memory leak in zrle_compress_data

2019-09-19 Thread Gerd Hoffmann
On Sun, Sep 01, 2019 at 10:43:42PM +0800, Li Qiang wrote: > fangying 于2019年9月1日周日 下午8:29写道: > > > Nice work, your patch does fix this issue in my test. > > > > I think we should make VncState.zlib to be a pointer type as well. > > > > Since we are going to use pointers instead of copy, we must ma

Re: [Qemu-devel] [RFC] error: auto propagated local_err

2019-09-19 Thread Greg Kurz
On Wed, 18 Sep 2019 16:02:44 +0300 Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > Here is a proposal (three of them, actually) of auto propagation for > local_err, to not call error_propagate on every exit point, when we > deal with local_err. > > It also may help make Greg's series[1] about

[Qemu-devel] [PULL 1/2] vga: move access helpers to separate include file

2019-09-19 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Message-id: 20190917111441.27405-2-kra...@redhat.com --- hw/display/vga-access.h | 49 hw/display/vga-helpers.h | 26 - hw/display/vga.c | 1 + 3 files changed,

Re: [Qemu-devel] [PATCH] docker: remove python2.7 from docker9-mxe

2019-09-19 Thread Philippe Mathieu-Daudé
On 9/19/19 12:25 AM, John Snow wrote: > When it was based on docker8 which uses python-minimal, it needed this. > It no longer does. Good catch, thanks! > Goodbye, python2.7. > > Signed-off-by: John Snow > --- > tests/docker/dockerfiles/debian9-mxe.docker | 3 +-- > 1 file changed, 1 insertion

[Qemu-devel] [PULL 2/2] ati: use vga_read_byte in ati_cursor_define

2019-09-19 Thread Gerd Hoffmann
This makes sure reads are confined to vga video memory. v3: use uint32_t, fix cut+paste bug. v2: fix ati_cursor_draw_line too. Reported-by: xu hang Signed-off-by: Gerd Hoffmann Reviewed-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daudé Message-id: 20190917111441.27405-3-kra...@redhat.com

[Qemu-devel] [PULL 0/2] Ati 20190919 patches

2019-09-19 Thread Gerd Hoffmann
The following changes since commit f8c3db33a5e863291182f8862ddf81618a7c6194: target/sparc: Switch to do_transaction_failed() hook (2019-09-17 12:01:00 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/ati-20190919-pull-request for you to fetch changes up to

Re: [Qemu-devel] [for-4.2 PATCH 3/6] replay: update docs for record/replay with block devices

2019-09-19 Thread Pavel Dovgalyuk
> From: Kevin Wolf [mailto:kw...@redhat.com] > > > > > > However, global -snapshot is just a convenient shortcut for specifying > > > snapshot=on for all -drive arguments. So if -snapshot is incompatible > > > with replay, shouldn't manually marking all drives as snapshot=on be > > > incompatible a

Re: [Qemu-devel] [RFC] error: auto propagated local_err

2019-09-19 Thread Vladimir Sementsov-Ogievskiy
19.09.2019 11:59, Max Reitz wrote: > On 18.09.19 15:02, Vladimir Sementsov-Ogievskiy wrote: >> Hi all! >> >> Here is a proposal (three of them, actually) of auto propagation for >> local_err, to not call error_propagate on every exit point, when we >> deal with local_err. >> >> It also may help mak

Re: [Qemu-devel] [RFC] error: auto propagated local_err

2019-09-19 Thread Kevin Wolf
Am 18.09.2019 um 19:10 hat Eric Blake geschrieben: > On 9/18/19 8:02 AM, Vladimir Sementsov-Ogievskiy wrote: > > + */ > > +#define MAKE_ERRP_SAFE(errp) \ > > +g_auto(ErrorPropagationStruct) (__auto_errp_prop) = {.errp = (errp)}; \ > > +if ((errp) == NULL || *(errp) == error_abort || *(errp) == erro

Re: [Qemu-devel] [PATCH v3 5/6] docs: start a document to describe D-Bus usage

2019-09-19 Thread Stefan Hajnoczi
On Mon, Sep 16, 2019 at 11:00:35AM +0100, Dr. David Alan Gilbert wrote: > (Copying in Stefan since he was looking at DBus for virtiofs) > > * Marc-André Lureau (marcandre.lur...@redhat.com) wrote: > > Signed-off-by: Marc-André Lureau > > --- > > docs/interop/dbus.rst | 73 ++

[Qemu-devel] [PATCH v1] tests/tcg: target/s390x: Test MVC

2019-09-19 Thread David Hildenbrand
Let's add a test that especially verifies that no data will be touched in case we cross page boundaries and one page access triggers a fault. Before the fault-safe handling fixes, the test failes with: TESTmvc on s390x data modified during a fault make[2]: *** [../Makefile.target

Re: [Qemu-devel] [RFC] error: auto propagated local_err

2019-09-19 Thread Vladimir Sementsov-Ogievskiy
19.09.2019 11:59, Greg Kurz wrote: > On Wed, 18 Sep 2019 16:02:44 +0300 > Vladimir Sementsov-Ogievskiy wrote: > >> Hi all! >> >> Here is a proposal (three of them, actually) of auto propagation for >> local_err, to not call error_propagate on every exit point, when we >> deal with local_err. >> >

Re: [Qemu-devel] [PULL 2/3] trace: Remove trailing newline in events

2019-09-19 Thread Stefan Hajnoczi
On Wed, Sep 18, 2019 at 05:51:16PM +0200, Philippe Mathieu-Daudé wrote: > On 9/18/19 3:21 PM, Stefan Hajnoczi wrote: > > Reviewed-by: John Snow > > Reviewed-by: Kevin Wolf > > Signed-off-by: Philippe Mathieu-Daudé > > Message-id: 20190916095121.29506-2-phi...@redhat.com > > Message-Id: <20190916

Re: [Qemu-devel] [RFC] error: auto propagated local_err

2019-09-19 Thread Max Reitz
On 19.09.19 11:14, Vladimir Sementsov-Ogievskiy wrote: > 19.09.2019 11:59, Max Reitz wrote: >> On 18.09.19 15:02, Vladimir Sementsov-Ogievskiy wrote: >>> Hi all! >>> >>> Here is a proposal (three of them, actually) of auto propagation for >>> local_err, to not call error_propagate on every exit poi

Re: [Qemu-devel] [PATCH] hw/arm: set machine 'virt' as default

2019-09-19 Thread Philippe Mathieu-Daudé
On 9/18/19 11:56 PM, Dan Streetman wrote: > On Wed, Sep 18, 2019 at 4:34 PM Alex Bennée wrote: >> >> Dan Streetman writes: >> >>> From: Dan Streetman >>> >>> There is currently no default machine type for arm so one must be specified >>> with --machine. This sets the 'virt' machine type as defa

Re: [Qemu-devel] vhost, iova, and dirty page tracking

2019-09-19 Thread Jason Wang
On 2019/9/19 下午2:32, Yan Zhao wrote: On Thu, Sep 19, 2019 at 02:29:54PM +0800, Yan Zhao wrote: On Thu, Sep 19, 2019 at 02:32:03PM +0800, Jason Wang wrote: On 2019/9/19 下午2:17, Yan Zhao wrote: On Thu, Sep 19, 2019 at 02:09:53PM +0800, Jason Wang wrote: On 2019/9/19 下午1:28, Yan Zhao wrote: O

Re: [Qemu-devel] vhost, iova, and dirty page tracking

2019-09-19 Thread Jason Wang
On 2019/9/19 下午3:16, Tian, Kevin wrote: +Paolo to help clarify here. From: Jason Wang [mailto:jasow...@redhat.com] Sent: Thursday, September 19, 2019 2:32 PM On 2019/9/19 下午2:17, Yan Zhao wrote: On Thu, Sep 19, 2019 at 02:09:53PM +0800, Jason Wang wrote: On 2019/9/19 下午1:28, Yan Zhao wrot

Re: [Qemu-devel] [PATCH v1] tests/tcg: target/s390x: Test MVC

2019-09-19 Thread David Hildenbrand
On 19.09.19 11:28, David Hildenbrand wrote: > Let's add a test that especially verifies that no data will be touched > in case we cross page boundaries and one page access triggers a fault. > > Before the fault-safe handling fixes, the test failes with: > TESTmvc on s390x > data modi

Re: [Qemu-devel] [PATCH] target/i386: Correct extra enter and spaces in comment

2019-09-19 Thread Philippe Mathieu-Daudé
Hi Tao, On 9/19/19 4:06 AM, Tao Xu wrote: > There is an extra line in comment of CPUID_8000_0008_EBX_WBNOINVD, > remove the extra enter and spaces. > > Signed-off-by: Tao Xu > --- > target/i386/cpu.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/target/i386/cpu.h b

Re: [Qemu-devel] vhost, iova, and dirty page tracking

2019-09-19 Thread Yan Zhao
On Thu, Sep 19, 2019 at 05:35:05PM +0800, Jason Wang wrote: > > On 2019/9/19 下午2:32, Yan Zhao wrote: > > On Thu, Sep 19, 2019 at 02:29:54PM +0800, Yan Zhao wrote: > >> On Thu, Sep 19, 2019 at 02:32:03PM +0800, Jason Wang wrote: > >>> On 2019/9/19 下午2:17, Yan Zhao wrote: > On Thu, Sep 19, 2019

[Qemu-devel] [Bug 1844644] [NEW] Compiler warnings using MSVC

2019-09-19 Thread Patrick van Logchem
Public bug reported: The following line of code results in an implicit truncation of an uint16_t value to an uint8_t variable, which triggers a compiler warning in MSVC : https://github.com/qemu/qemu/blob/f8c3db33a5e863291182f8862ddf81618a7c6194/hw/usb/dev-hub.c#L387 (Two lines down, the same th

Re: [Qemu-devel] [RFC] error: auto propagated local_err

2019-09-19 Thread Vladimir Sementsov-Ogievskiy
19.09.2019 12:17, Kevin Wolf wrote: > Am 18.09.2019 um 19:10 hat Eric Blake geschrieben: >> On 9/18/19 8:02 AM, Vladimir Sementsov-Ogievskiy wrote: >>> + */ >>> +#define MAKE_ERRP_SAFE(errp) \ >>> +g_auto(ErrorPropagationStruct) (__auto_errp_prop) = {.errp = (errp)}; \ >>> +if ((errp) == NULL || *(

Re: [Qemu-devel] [Qemu-trivial] [PATCH] cutils: Move size_to_str() from "qemu-common.h" to "qemu/cutils.h"

2019-09-19 Thread Laurent Vivier
Le 03/09/2019 à 14:05, Philippe Mathieu-Daudé a écrit : > "qemu/cutils.h" contains various qemu_strtosz_*() functions > useful to convert strings to size. It seems natural to have > the opposite usage (from size to string) there too. > > The function definition is already in util/cutils.c. > > Si

Re: [Qemu-devel] [PULL SUBSYSTEM s390x 00/29] s390x/tcg: mem_helper: Fault-safe handling

2019-09-19 Thread Cornelia Huck
On Wed, 18 Sep 2019 17:28:53 +0200 David Hildenbrand wrote: > This pull request is not for master. > > Hi Conny, > > The following changes since commit f8c3db33a5e863291182f8862ddf81618a7c6194: > > target/sparc: Switch to do_transaction_failed() hook (2019-09-17 12:01:00 > +0100) > > are a

Re: [Qemu-devel] [PATCH v3 01/22] softmmu: split off vl.c:main() into main.c

2019-09-19 Thread Stefan Hajnoczi
On Wed, Sep 18, 2019 at 11:19:28PM +, Oleinik, Alexander wrote: > diff --git a/vl.c b/vl.c > index 630f5c5e9c..327510c81f 100644 > --- a/vl.c > +++ b/vl.c > @@ -36,18 +36,6 @@ > #include "sysemu/seccomp.h" > #include "sysemu/tcg.h" > > -#ifdef CONFIG_SDL > -#if defined(__APPLE__) || defined

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Replace '-machine accel=xyz' with '-accel xyz'

2019-09-19 Thread Laurent Vivier
Le 04/09/2019 à 07:27, Thomas Huth a écrit : > We've got a separate option to configure the accelerator nowadays, which > is shorter to type and the preferred way of specifying an accelerator. > Use it in the source and examples to show that it is the favored option. > (However, do not touch the pl

Re: [Qemu-devel] [RFC] error: auto propagated local_err

2019-09-19 Thread Vladimir Sementsov-Ogievskiy
19.09.2019 12:33, Max Reitz wrote: > On 19.09.19 11:14, Vladimir Sementsov-Ogievskiy wrote: >> 19.09.2019 11:59, Max Reitz wrote: >>> On 18.09.19 15:02, Vladimir Sementsov-Ogievskiy wrote: Hi all! Here is a proposal (three of them, actually) of auto propagation for local_err, to

Re: [Qemu-devel] [PATCH v3 02/22] libqos: Rename i2c_send and i2c_recv

2019-09-19 Thread Stefan Hajnoczi
On Wed, Sep 18, 2019 at 11:19:29PM +, Oleinik, Alexander wrote: > The names i2c_send and i2c_recv collide with functions defined in > hw/i2c/core.c. This causes an error when linking against libqos and > softmmu simultaneously (for example when using qtest inproc). Rename the > libqos functions

Re: [Qemu-devel] [PULL SUBSYSTEM s390x 0/3] Minor fixes for the s390-ccw firmware

2019-09-19 Thread Cornelia Huck
On Wed, 18 Sep 2019 18:15:11 +0200 Thomas Huth wrote: > This pull request is not for master ! > > Hi Cornelia, > > the following changes since commit f8c3db33a5e863291182f8862ddf81618a7c6194: > > target/sparc: Switch to do_transaction_failed() hook (2019-09-17 12:01:00 > +0100) > > are av

Re: [Qemu-devel] vhost, iova, and dirty page tracking

2019-09-19 Thread Jason Wang
On 2019/9/19 下午2:29, Yan Zhao wrote: On Thu, Sep 19, 2019 at 02:32:03PM +0800, Jason Wang wrote: On 2019/9/19 下午2:17, Yan Zhao wrote: On Thu, Sep 19, 2019 at 02:09:53PM +0800, Jason Wang wrote: On 2019/9/19 下午1:28, Yan Zhao wrote: On Thu, Sep 19, 2019 at 09:05:12AM +0800, Jason Wang wrote:

Re: [Qemu-devel] [RFC] error: auto propagated local_err

2019-09-19 Thread Greg Kurz
On Thu, 19 Sep 2019 09:28:11 + Vladimir Sementsov-Ogievskiy wrote: > 19.09.2019 11:59, Greg Kurz wrote: > > On Wed, 18 Sep 2019 16:02:44 +0300 > > Vladimir Sementsov-Ogievskiy wrote: > > > >> Hi all! > >> > >> Here is a proposal (three of them, actually) of auto propagation for > >> local_e

Re: [Qemu-devel] [RFC] error: auto propagated local_err

2019-09-19 Thread Daniel P . Berrangé
On Thu, Sep 19, 2019 at 11:17:20AM +0200, Kevin Wolf wrote: > Am 18.09.2019 um 19:10 hat Eric Blake geschrieben: > > On 9/18/19 8:02 AM, Vladimir Sementsov-Ogievskiy wrote: > > > + */ > > > +#define MAKE_ERRP_SAFE(errp) \ > > > +g_auto(ErrorPropagationStruct) (__auto_errp_prop) = {.errp = (errp)};

Re: [Qemu-devel] [PATCH v3 03/22] fuzz: Add FUZZ_TARGET module type

2019-09-19 Thread Stefan Hajnoczi
On Wed, Sep 18, 2019 at 11:19:30PM +, Oleinik, Alexander wrote: > Signed-off-by: Alexander Oleinik > --- > include/qemu/module.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [Qemu-devel] [PATCH] tests/tcg: add simple record/replay smoke test for aarch64

2019-09-19 Thread Alex Bennée
Pavel Dovgalyuk writes: > Thanks! > > This seem to correctly run record and replay command lines. > When I break the replay correctness, then the test reports a timeout error. > > However, we need some kind of a manual for tcg testing. I had to dig through > makefile and configure > scripts to

Re: [Qemu-devel] [PATCH v3 04/22] qtest: add qtest_server_send abstraction

2019-09-19 Thread Stefan Hajnoczi
On Wed, Sep 18, 2019 at 11:19:31PM +, Oleinik, Alexander wrote: > qtest_server_send is a function pointer specifying the handler used to > transmit data to the qtest client. In the standard configuration, this > calls the CharBackend handler, but now it is possible for other types of > handlers

Re: [Qemu-devel] [Qemu-trivial] [PATCH] target/m68k/fpu_helper.c: rename the access arguments

2019-09-19 Thread Laurent Vivier
Le 12/09/2019 à 16:02, KONRAD Frederic a écrit : > The "access" arguments clash with a macro under Windows with MinGW: > CC m68k-softmmu/target/m68k/fpu_helper.o > target/m68k/fpu_helper.c: In function 'fmovem_predec': > target/m68k/fpu_helper.c:405:56: error: macro "access" passed 4 arg

Re: [Qemu-devel] [PULL 00/10] virtio, vhost, pc: features, fixes, cleanups.

2019-09-19 Thread Peter Maydell
On Tue, 17 Sep 2019 at 16:10, Michael S. Tsirkin wrote: > > The following changes since commit 138985c1ef8b66e4e5b383354e133e05d01d0b5f: > > Merge remote-tracking branch > 'remotes/amarkovic/tags/mips-queue-sep-12-2019' into staging (2019-09-13 > 16:04:46 +0100) > > are available in the Git re

Re: [Qemu-devel] vhost, iova, and dirty page tracking

2019-09-19 Thread Jason Wang
On 2019/9/19 下午5:36, Yan Zhao wrote: On Thu, Sep 19, 2019 at 05:35:05PM +0800, Jason Wang wrote: On 2019/9/19 下午2:32, Yan Zhao wrote: On Thu, Sep 19, 2019 at 02:29:54PM +0800, Yan Zhao wrote: On Thu, Sep 19, 2019 at 02:32:03PM +0800, Jason Wang wrote: On 2019/9/19 下午2:17, Yan Zhao wrote: O

Re: [Qemu-devel] [PULL 0/4] Ui 20190919 patches

2019-09-19 Thread Peter Maydell
> > are available in the Git repository at: > > git://git.kraxel.org/qemu tags/ui-20190919-pull-request > > for you to fetch changes up to 6bf21f3d83e95bcc4ba35a7a07cc6655e8b010b0: > > vnc: fix memory leak when vnc disconnect (2019-09-17 13:45:10 +0200) > > ---

[Qemu-devel] [Bug 1844644] Re: Compiler warnings using MSVC

2019-09-19 Thread Peter Maydell
Hi; MSVC is not a supported compiler for QEMU. We expect it to be built with either gcc or llvm. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/18446

Re: [Qemu-devel] [Qemu-trivial] [PATCH] kvm: Fix typo in header of kvm_device_access()

2019-09-19 Thread Laurent Vivier
Le 12/09/2019 à 15:57, Greg Kurz a écrit : > Signed-off-by: Greg Kurz > --- > include/sysemu/kvm.h |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h > index 909bcd77cf82..fd674772ab31 100644 > --- a/include/sysemu/kvm.h > +++

Re: [Qemu-devel] [PATCH 1/1] Fix cacheline detection on FreeBSD/powerpc.

2019-09-19 Thread Laurent Vivier
Le 21/08/2019 à 10:25, Laurent Vivier a écrit : > From: Justin Hibbits > > machdep.cacheline_size is an integer, not a long. Since PowerPC is > big-endian this causes sysctlbyname() to fill in the upper bits of the > argument, rather than the correct 'lower bits' of the word. Specify the > corr

Re: [Qemu-devel] [RFC] error: auto propagated local_err

2019-09-19 Thread Vladimir Sementsov-Ogievskiy
19.09.2019 13:09, Daniel P. Berrangé wrote: > On Thu, Sep 19, 2019 at 11:17:20AM +0200, Kevin Wolf wrote: >> Am 18.09.2019 um 19:10 hat Eric Blake geschrieben: >>> On 9/18/19 8:02 AM, Vladimir Sementsov-Ogievskiy wrote: + */ +#define MAKE_ERRP_SAFE(errp) \ +g_auto(ErrorPropagationStr

Re: [Qemu-devel] [PATCH] build: Don't ignore qapi-visit-core.c

2019-09-19 Thread Laurent Vivier
Le 13/09/2019 à 13:34, Eric Blake a écrit : > cc: qemu-trivial > > On 9/12/19 1:46 PM, Eric Blake wrote: >> This file is version-controlled, and not generated from a .json file. >> >> Fixes: bf582c3461b >> Reported-by: Thomas Huth >> Signed-off-by: Eric Blake >> --- >> .gitignore | 1 + >> 1 fi

Re: [Qemu-devel] [RFC v2 0/5] Move notdirty handling to cputlb

2019-09-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190918180251.32003-1-richard.hender...@linaro.org/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

Re: [Qemu-devel] vhost, iova, and dirty page tracking

2019-09-19 Thread Yan Zhao
On Thu, Sep 19, 2019 at 06:06:52PM +0800, Jason Wang wrote: > > On 2019/9/19 下午2:29, Yan Zhao wrote: > > On Thu, Sep 19, 2019 at 02:32:03PM +0800, Jason Wang wrote: > >> On 2019/9/19 下午2:17, Yan Zhao wrote: > >>> On Thu, Sep 19, 2019 at 02:09:53PM +0800, Jason Wang wrote: > On 2019/9/19 下午1:2

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Add xkbcommon configure options

2019-09-19 Thread Laurent Vivier
Le 19/09/2019 à 10:37, Gerd Hoffmann a écrit : > On Mon, Sep 16, 2019 at 10:15:15AM +0200, Laurent Vivier wrote: >> Le 14/09/2019 à 16:51, James Le Cuirot a écrit : >>> This dependency is currently "automagic", which is bad for distributions. >>> >>> Signed-off-by: James Le Cuirot >>> --- >>> con

Re: [Qemu-devel] [PATCH v3 08/22] module: check module wasn't already initialized

2019-09-19 Thread Stefan Hajnoczi
On Wed, Sep 18, 2019 at 11:19:35PM +, Oleinik, Alexander wrote: > The virtual-device fuzzer must initialize QOM, prior to running > vl:qemu_init, so that it can use the qos_graph to identify the arguments > required to initialize a guest for libqos-assisted fuzzing. This change > prevents error

Re: [Qemu-devel] [PATCH v3 05/22] libqtest: Add a layer of abstraciton to send/recv

2019-09-19 Thread Stefan Hajnoczi
On Wed, Sep 18, 2019 at 11:19:32PM +, Oleinik, Alexander wrote: > This makes it simple to swap the transport functions for qtest commands > to and from the qtest client. For example, now it is possible to > directly pass qtest commands to a server handler that exists within the > same process,

  1   2   3   4   5   >