Re: [Qemu-devel] [PATCH v3 5/6] docs: start a document to describe D-Bus usage

* Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > Hi > > On Mon, Sep 16, 2019 at 5:15 PM Dr. David Alan Gilbert > wrote: > > > > * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > > > Hi > > > > > > On Mon, Sep 16, 2019 at 2:02 PM Dr. David Alan Gilbert > > > wrote: > > > > > > >

[Qemu-devel] ping Re: [PATCH v8 0/3] NBD reconnect

ping 21.08.2019 19:52, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > Here is NBD reconnect. Previously, if connection failed all current > and future requests will fail. After the series, nbd-client driver > will try to reconnect unlimited times. During first @reconnect-delay > seconds of reconn

Re: [Qemu-devel] [PATCH v3 6/8] iotests: Test driver whitelisting in 093

On 13.09.19 20:30, John Snow wrote: > > > On 9/13/19 8:47 AM, Max Reitz wrote: >> On 20.08.19 23:32, John Snow wrote: >>> >>> >>> On 8/19/19 4:18 PM, Max Reitz wrote: null-aio may not be whitelisted. Skip all test cases that require it. Signed-off-by: Max Reitz --- tes

Re: [Qemu-devel] [PATCH v2 01/17] RISC-V: add vfp field in CPURISCVState

On 2019/9/11 下午10:51, Chih-Min Chao wrote: On Wed, Sep 11, 2019 at 2:35 PM liuzhiwei > wrote: From: LIU Zhiwei mailto:zhiwei_...@c-sky.com>> Signed-off-by: LIU Zhiwei mailto:zhiwei_...@c-sky.com>> ---  target/riscv/cpu.h | 28 +++

Re: [Qemu-devel] [PATCH v3 5/6] docs: start a document to describe D-Bus usage

Hi On Tue, Sep 17, 2019 at 12:12 PM Dr. David Alan Gilbert wrote: > > * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > > Hi > > > > On Mon, Sep 16, 2019 at 5:15 PM Dr. David Alan Gilbert > > wrote: > > > > > > * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > > > > Hi > > > > >

Re: [Qemu-devel] [PATCH v3 6/8] iotests: Test driver whitelisting in 093

On 17.09.19 10:18, Max Reitz wrote: > On 13.09.19 20:30, John Snow wrote: >> >> >> On 9/13/19 8:47 AM, Max Reitz wrote: >>> On 20.08.19 23:32, John Snow wrote: On 8/19/19 4:18 PM, Max Reitz wrote: > null-aio may not be whitelisted. Skip all test cases that require it. >

Re: [Qemu-devel] [PATCH v3 6/8] iotests: Test driver whitelisting in 093

On 17.09.19 10:29, Max Reitz wrote: > On 17.09.19 10:18, Max Reitz wrote: >> On 13.09.19 20:30, John Snow wrote: >>> >>> >>> On 9/13/19 8:47 AM, Max Reitz wrote: On 20.08.19 23:32, John Snow wrote: > > > On 8/19/19 4:18 PM, Max Reitz wrote: >> null-aio may not be whitelisted.

Re: [Qemu-devel] [PATCH v6 1/2] kvm: s390: split too big memory section on several memslots

On Mon, Sep 16, 2019 at 09:23:46AM -0400, Igor Mammedov wrote: > Max memslot size supported by kvm on s390 is 8Tb, > move logic of splitting RAM in chunks upto 8T to KVM code. > > This way it will hide KVM specific restrictions in KVM code > and won't affect board level design decisions. Which wou

Re: [Qemu-devel] [PATCH v3 6/8] iotests: Test driver whitelisting in 093

Am 17.09.2019 um 10:18 hat Max Reitz geschrieben: > On 13.09.19 20:30, John Snow wrote: > > > > > > On 9/13/19 8:47 AM, Max Reitz wrote: > >> On 20.08.19 23:32, John Snow wrote: > >>> > >>> > >>> On 8/19/19 4:18 PM, Max Reitz wrote: > null-aio may not be whitelisted. Skip all test cases tha

Re: [Qemu-devel] [PATCH] target/arm: fix CBAR register for AArch64 CPUs

On 9/13/19 9:26 AM, Luc Michel wrote: > Hi Peter, > > On 9/12/19 6:03 PM, Peter Maydell wrote: >> On Thu, 12 Sep 2019 at 12:01, Luc Michel wrote: >>> >>> For AArch64 CPUs with a CBAR register, we have two views for it: >>> - in AArch64 state, the CBAR_EL1 register (S3_1_C15_C3_0), returns the >

Re: [Qemu-devel] [PATCH v6 2/2] s390: do not call memory_region_allocate_system_memory() multiple times

On Mon, Sep 16, 2019 at 09:23:47AM -0400, Igor Mammedov wrote: > PS: > I don't have access to a suitable system to test it. Hmm I feel like it would be good to have series like this to be at least smoke tested somehow... How about manually setup a very small max memslot size and test it on x86?

Re: [Qemu-devel] [PATCH 3/3] tests/acceptance/migration: test to migrate will all machine types

On Mon, Sep 16, 2019 at 03:50:06PM +0100, Dr. David Alan Gilbert wrote: > * Balamuruhan S (bal...@linux.ibm.com) wrote: > > add migration test to query machine types supported by qemu binary > > and migrate vm will all supported type. > > > > Signed-off-by: Balamuruhan S > > Depending on the arc

Re: [Qemu-devel] [PATCH 1/3] tests/acceptance/migration: fix post migration check

On Mon, Sep 16, 2019 at 07:50:44PM +0100, Dr. David Alan Gilbert wrote: > * Balamuruhan S (bal...@linux.ibm.com) wrote: > > assert `query-migrate` in target doesn't give migration > > status and test errors even if migration succeeds. > > > > In target: > > {'execute': 'query-migrate'} > > {"retur

Re: [Qemu-devel] vhost, iova, and dirty page tracking

> From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Monday, September 16, 2019 4:33 PM > > > On 2019/9/16 上午9:51, Tian, Kevin wrote: > > Hi, Jason > > > > We had a discussion about dirty page tracking in VFIO, when vIOMMU > > is enabled: > > > > https://lists.nongnu.org/archive/html/qemu-deve

Re: [Qemu-devel] [PULL v2 00/29] Misc patches for 2019-09-16

Hi! 16.09.2019, 19:17, "Paolo Bonzini" : > The following changes since commit 138985c1ef8b66e4e5b383354e133e05d01d0b5f: > >   Merge remote-tracking branch > 'remotes/amarkovic/tags/mips-queue-sep-12-2019' into staging (2019-09-13 > 16:04:46 +0100) > > are available in the git repository at: > >

[Qemu-devel] [PATCH v4 2/7] iotests: Allow skipping test cases

case_notrun() does not actually skip the current test case. It just adds a "notrun" note and then returns to the caller, who manually has to skip the test. Generally, skipping a test case is as simple as returning from the current function, but not always: For example, this model does not allow s

[Qemu-devel] [PATCH v4 0/7] iotests: Selfish patches

Hi, Again, let me start with a link to an actually explanatory cover letter: https://lists.nongnu.org/archive/html/qemu-block/2019-06/msg01102.html v3: https://lists.nongnu.org/archive/html/qemu-block/2019-08/msg00950.html v4: - I merged the old patch 1 in the meantime - Patch 2: Adjusted the c

Re: [Qemu-devel] [PULL 00/16] Block patches

On Mon, 16 Sep 2019 at 15:22, Max Reitz wrote: > > The following changes since commit dd25f97c66a75d1508f1d4c6478ed2c95bec428f: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20190913' into staging (2019-09-16 > 10:15:15 +0100) > > are available in the Git repository

[Qemu-devel] [PATCH v4 1/7] iotests: Prefer null-co over null-aio

We use null-co basically everywhere in the iotests. Unless we want to test null-aio specifically, we should use it instead (for consistency). Signed-off-by: Max Reitz Reviewed-by: John Snow Reviewed-by: Thomas Huth --- tests/qemu-iotests/093 | 7 +++ tests/qemu-iotests/245 | 2 +- 2 files

[Qemu-devel] [PATCH v4 5/7] iotests: Test driver whitelisting in 093

null-aio may not be whitelisted. Skip all test cases that require it. (And skip the whole test if null-co is not whitelisted.) Signed-off-by: Max Reitz --- tests/qemu-iotests/093 | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/tests/qemu-iotests/093 b/tests/qem

[Qemu-devel] [PATCH v4 4/7] iotests: Let skip_if_unsupported accept a function

This lets tests use skip_if_unsupported() with a potentially variable list of required formats. Suggested-by: Kevin Wolf Signed-off-by: Max Reitz --- tests/qemu-iotests/iotests.py | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/q

[Qemu-devel] [PATCH v4 3/7] iotests: Use case_skip() in skip_if_unsupported()

skip_if_unsupported() should use the stronger variant case_skip(), because this allows it to be used even with setUp() (in a meaningful way). In the process, make it explicit what we expect the first argument of the func_wrapper to be (namely something derived of QMPTestCase). Signed-off-by: Max

[Qemu-devel] [PATCH v4 7/7] iotests: Cache supported_formats()

Signed-off-by: Max Reitz Reviewed-by: John Snow --- tests/qemu-iotests/iotests.py | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index a42702b6b9..b30044e1cc 100644 --- a/tests/qemu-iotests/iotests

Re: [Qemu-devel] [PATCH 1/2] virtio: add vhost-user-fs base device

* Stefan Hajnoczi (stefa...@redhat.com) wrote: > On Wed, Aug 21, 2019 at 08:11:18PM +0100, Dr. David Alan Gilbert wrote: > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > On Fri, Aug 16, 2019 at 03:33:20PM +0100, Dr. David Alan Gilbert (git) > > > wrote: > > > > +static void vuf_handle_outpu

[Qemu-devel] [PATCH v4 6/7] iotests: Test driver whitelisting in 136

null-aio may not be whitelisted. Skip all test cases that require it. Signed-off-by: Max Reitz --- tests/qemu-iotests/136 | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/tests/qemu-iotests/136 b/tests/qemu-iotests/136 index a46a7b7630..012ea111ac 100755 --- a

Re: [Qemu-devel] [PATCH v2 3/6] tests/acceptance: Test OpenBIOS on the PReP/40p

Cleber Rosa writes: > On Sun, Sep 15, 2019 at 11:19:37PM +0200, Philippe Mathieu-Daudé wrote: >> User case from: >> https://mail.coreboot.org/pipermail/openbios/2018-May/010360.html >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> tests/acceptance/ppc_prep_40p.py | 32 +++

Re: [Qemu-devel] [PATCH v5 0/5] qcow2: async handling of fragmented io

16.09.2019 20:53, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > Here is an asynchronous scheme for handling fragmented qcow2 > reads and writes. Both qcow2 read and write functions loops through > sequential portions of data. The series aim it to parallelize these > loops iterations. > It impr

Re: [Qemu-devel] [PATCH v2 2/6] tests/acceptance: Test Open Firmware on the PReP/40p

Cleber Rosa writes: > On Mon, Sep 16, 2019 at 01:59:22PM -0400, Cleber Rosa wrote: >> On Sun, Sep 15, 2019 at 11:19:36PM +0200, Philippe Mathieu-Daudé wrote: >> > User case from: >> > https://tyom.blogspot.com/2019/04/aixprep-under-qemu-how-to.html >> > >> > Signed-off-by: Philippe Mathieu-Daud

Re: [Qemu-devel] [PATCH v4 2/4] iotest 258: use script_main

12.09.2019 3:16, John Snow wrote: > Since this one is nicely factored to use a single entry point, > use script_main to run the tests. > > Signed-off-by: John Snow Reviewed-by: Vladimir Sementsov-Ogievskiy > --- > tests/qemu-iotests/258 | 8 ++-- > 1 file changed, 2 insertions(+), 6 del

Re: [Qemu-devel] [PATCH 1/3] tests/acceptance/migration: fix post migration check

* Balamuruhan S (bal...@linux.ibm.com) wrote: > On Mon, Sep 16, 2019 at 07:50:44PM +0100, Dr. David Alan Gilbert wrote: > > * Balamuruhan S (bal...@linux.ibm.com) wrote: > > > assert `query-migrate` in target doesn't give migration > > > status and test errors even if migration succeeds. > > > > >

Re: [Qemu-devel] [PATCH v2 2/6] tests/acceptance: Test Open Firmware on the PReP/40p

On Tue, Sep 17, 2019 at 11:33 AM Alex Bennée wrote: > > > Cleber Rosa writes: > > > On Mon, Sep 16, 2019 at 01:59:22PM -0400, Cleber Rosa wrote: > >> On Sun, Sep 15, 2019 at 11:19:36PM +0200, Philippe Mathieu-Daudé wrote: > >> > User case from: > >> > https://tyom.blogspot.com/2019/04/aixprep-und

Re: [Qemu-devel] [PATCH v2 3/6] tests/acceptance: Test OpenBIOS on the PReP/40p

On 9/17/19 11:31 AM, Alex Bennée wrote: > Cleber Rosa writes: >> On Sun, Sep 15, 2019 at 11:19:37PM +0200, Philippe Mathieu-Daudé wrote: >>> User case from: >>> https://mail.coreboot.org/pipermail/openbios/2018-May/010360.html >>> >>> Signed-off-by: Philippe Mathieu-Daudé >>> --- >>> tests/accep

Re: [Qemu-devel] [PATCH 3/3] tests/acceptance/migration: test to migrate will all machine types

* Balamuruhan S (bal...@linux.ibm.com) wrote: > On Mon, Sep 16, 2019 at 03:50:06PM +0100, Dr. David Alan Gilbert wrote: > > * Balamuruhan S (bal...@linux.ibm.com) wrote: > > > add migration test to query machine types supported by qemu binary > > > and migrate vm will all supported type. > > > > >

Re: [Qemu-devel] [PATCH v2 2/6] tests/acceptance: Test Open Firmware on the PReP/40p

On 9/17/19 11:42 AM, Artyom Tarasenko wrote: > On Tue, Sep 17, 2019 at 11:33 AM Alex Bennée wrote: >> Cleber Rosa writes: >>> On Mon, Sep 16, 2019 at 01:59:22PM -0400, Cleber Rosa wrote: On Sun, Sep 15, 2019 at 11:19:36PM +0200, Philippe Mathieu-Daudé wrote: > User case from: > https

Re: [Qemu-devel] [PATCH v4 3/4] iotests: specify protocol support via initialization info

12.09.2019 3:16, John Snow wrote: > Switch from verify_protocols to any one of: > iotests.main, iotests.script_main, iotests.script_initialize. Actually, only script_initialize used in the patch. Also, I think it all may be safely merged to 01 > > Signed-off-by: John Snow Still, Reviewed-by: V

[Qemu-devel] [PATCH] replay: don't synchronize memory operations in replay mode

Commit 9458a9a1df1a4c719e24512394d548c1fc7abd22 added synchronization of vCPU and migration operations through calling run_on_cpu operation. However, in replay mode this synchronization is unneeded, because I/O and vCPU threads are already synchronized. This patch disables such synchronization for

Re: [Qemu-devel] [PATCH v2 3/6] tests/acceptance: Test OpenBIOS on the PReP/40p

On Tue, Sep 17, 2019 at 11:44 AM Philippe Mathieu-Daudé wrote: > > On 9/17/19 11:31 AM, Alex Bennée wrote: > > Cleber Rosa writes: > >> On Sun, Sep 15, 2019 at 11:19:37PM +0200, Philippe Mathieu-Daudé wrote: > >>> User case from: > >>> https://mail.coreboot.org/pipermail/openbios/2018-May/010360.

Re: [Qemu-devel] [PATCH 07/12] qcrypto-luks: purge unused error codes from open callback

On Thu, Sep 12, 2019 at 12:17:05PM +0300, Maxim Levitsky wrote: > These values are not used by generic crypto code anyway > > Signed-off-by: Maxim Levitsky > --- > crypto/block-luks.c | 26 +- > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff --git a/crypto/bl

Re: [Qemu-devel] [PATCH 08/12] qcrypto-luks: extract store and load header

On Thu, Sep 12, 2019 at 12:17:06PM +0300, Maxim Levitsky wrote: > Signed-off-by: Maxim Levitsky > --- > crypto/block-luks.c | 158 ++-- > 1 file changed, 94 insertions(+), 64 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://be

Re: [Qemu-devel] [PATCH 03/13] hw: Move MC146818 device from hw/timer/ to hw/rtc/ subdirectory

On 9/17/19 7:07 AM, Thomas Huth wrote: > On 16/09/2019 17.48, Philippe Mathieu-Daudé wrote: >> The MC146818 is a Real Time Clock, not a timer. >> Move it under the hw/rtc/ subdirectory. >> >> Signed-off-by: Philippe Mathieu-Daudé > [...] >> diff --git a/include/hw/rtc/mc146818rtc.h b/include/hw/rt

Re: [Qemu-devel] [PATCH 09/12] qcrypto-luks: extract check and parse header

On Thu, Sep 12, 2019 at 12:17:07PM +0300, Maxim Levitsky wrote: > This is just to make qcrypto_block_luks_open more > reasonable in size. > > Signed-off-by: Maxim Levitsky > --- > crypto/block-luks.c | 235 > 1 file changed, 127 insertions(+), 108 del

Re: [Qemu-devel] [PATCH 04/13] hw: Move M48T59 device from hw/timer/ to hw/rtc/ subdirectory

On 9/17/19 4:25 AM, David Gibson wrote: > On Mon, Sep 16, 2019 at 05:48:38PM +0200, Philippe Mathieu-Daudé wrote: >> The M48T59 is a Real Time Clock, not a timer. >> Move it under the hw/rtc/ subdirectory. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> MAINTAINERS |

Re: [Qemu-devel] [PATCH 10/12] qcrypto-luks: extract store key function

On Thu, Sep 12, 2019 at 12:17:08PM +0300, Maxim Levitsky wrote: > This function will be used later to store > new keys to the luks metadata > > Signed-off-by: Maxim Levitsky > --- > crypto/block-luks.c | 304 ++-- > 1 file changed, 181 insertions(+), 123 d

Re: [Qemu-devel] [PATCH 12/12] qcrypto-luks: more rigorous header checking

On Thu, Sep 12, 2019 at 12:17:10PM +0300, Maxim Levitsky wrote: > Check that keyslots don't overlap with the data, > and check that keyslots don't overlap with each other. > (this is done using naive O(n^2) nested loops, > but since there are just 8 keyslots, this doesn't really matter. > > Signed

[Qemu-devel] [PATCH 02/17] block: Pass local error object pointer to error_append_hint()

Ensure that hints are added even if errp is &error_fatal or &error_abort. Signed-off-by: Greg Kurz --- block/backup.c |7 +-- block/dirty-bitmap.c |7 +-- block/file-posix.c | 20 +--- block/gluster.c | 23 +++ block/qcow.c

[Qemu-devel] [PATCH 03/17] char/spice: Pass local error object pointer to error_append_hint()

Ensure that hints are added even if errp is &error_fatal or &error_abort. Signed-off-by: Greg Kurz --- chardev/spice.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/chardev/spice.c b/chardev/spice.c index 241e2b7770eb..ed5996467c32 100644 --- a/chardev/spice.c +++

[Qemu-devel] [PATCH 04/17] ppc: Pass local error object pointer to error_append_hint()

Ensure that hints are added even if errp is &error_fatal or &error_abort. Signed-off-by: Greg Kurz --- hw/ppc/mac_newworld.c |7 +-- hw/ppc/spapr.c|7 +-- hw/ppc/spapr_pci.c|9 + target/ppc/kvm.c | 13 + 4 files changed, 24 insertions(+)

[Qemu-devel] [PATCH 00/17] Fix usage of error_append_hint()

A recent post unveiled a potential problem when passing errp to error_append_hint(): https://patchwork.ozlabs.org/patch/1162171/ The issue is that error_append_hint() may end up not being called at all if errp is equal to &error_fatal or &error_abort. It turns out that the only way to ensure erro

[Qemu-devel] [PATCH 01/17] error: Update error_append_hint()'s documentation

error_setg() and error_propagate(), as well as their variants, cause QEMU to terminate when called with &error_fatal or &error_abort. This prevents to add hints since error_append_hint() isn't even called in this case. It means that error_append_hint() should only be used with a local error object

[Qemu-devel] [PATCH 11/17] scsi: Pass local error object pointer to error_append_hint()

Ensure that hints are added even if errp is &error_fatal or &error_abort. Signed-off-by: Greg Kurz --- hw/scsi/scsi-disk.c|7 +-- hw/scsi/scsi-generic.c |7 +-- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 915

[Qemu-devel] [PATCH 09/17] hw/rdma: Fix missing conversion to rdma_error_report()

Commit 4d71b38ae8fa converted many error_setg() call sites to rdma_error_report(), but it forgot to convert a companion error_append_hint(). Since no guy doesn't set errp anymore in pvrdma_realize(), errp remains NULL and error_append_hint() does nothing. Also error_append_hint() was a poor choice

[Qemu-devel] [PATCH 07/17] virtio-pci: Pass local error object pointer to error_append_hint()

Ensure that hints are added even if errp is &error_fatal or &error_abort. Signed-off-by: Greg Kurz --- hw/virtio/virtio-pci.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index c6b47a9c7385..1e58822ba186 100

[Qemu-devel] [PATCH 05/17] arm: Pass local error object pointer to error_append_hint()

Ensure that hints are added even if errp is &error_fatal or &error_abort. Signed-off-by: Greg Kurz --- hw/arm/msf2-soc.c |5 +++-- hw/arm/virt.c | 14 ++ hw/intc/arm_gicv3_kvm.c |5 +++-- hw/misc/msf2-sysreg.c |6 -- 4 files changed, 20 insertions(

[Qemu-devel] [PATCH 14/17] ccid-card-emul: Pass local error object pointer to error_append_hint()

Ensure that hints are added even if errp is &error_fatal or &error_abort. Signed-off-by: Greg Kurz --- hw/usb/ccid-card-emulated.c |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/usb/ccid-card-emulated.c b/hw/usb/ccid-card-emulated.c index 291e41db8a1e..3bc397341

[Qemu-devel] [PATCH 12/17] migration: Pass local error object pointer to error_append_hint()

Ensure that hints are added even if errp is &error_fatal or &error_abort. Signed-off-by: Greg Kurz --- migration/migration.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index 01863a95f5fe..6724173ce34e 100644

[Qemu-devel] [PATCH 13/17] nbd: Pass local error object pointer to error_append_hint()

Ensure that hints are added even if errp is &error_fatal or &error_abort. Signed-off-by: Greg Kurz --- nbd/client.c | 24 +--- nbd/server.c |7 +-- 2 files changed, 18 insertions(+), 13 deletions(-) diff --git a/nbd/client.c b/nbd/client.c index b9dc829175f9..c6e6e

[Qemu-devel] [PATCH 06/17] vfio: Pass local error object pointer to error_append_hint()

Ensure that hints are added even if errp is &error_fatal or &error_abort. Signed-off-by: Greg Kurz --- hw/vfio/common.c | 14 ++ hw/vfio/pci.c| 12 2 files changed, 18 insertions(+), 8 deletions(-) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index 3e03c495d

[Qemu-devel] [PATCH 15/17] option: Pass local error object pointer to error_append_hint()

Ensure that hints are added even if errp is &error_fatal or &error_abort. Signed-off-by: Greg Kurz --- util/qemu-option.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/util/qemu-option.c b/util/qemu-option.c index 97172b5eaa7f..2a45dfa585d4 100644 --- a/ut

[Qemu-devel] [PATCH v2 0/7] target/i386: support VMX features in "-cpu"

This series adds support for VMX feature flags so that the user can enable and disable at will the flags. A separate series will also add VMX features to named CPU models, which will complete VMX live migration support. That's orthogonal and somewhat tedious. There are a few complications, which

Re: [Qemu-devel] [PATCH 12/17] migration: Pass local error object pointer to error_append_hint()

* Greg Kurz (gr...@kaod.org) wrote: > Ensure that hints are added even if errp is &error_fatal or &error_abort. > > Signed-off-by: Greg Kurz A bit painful, but if it solves the problem, Acked-by: Dr. David Alan Gilbert > --- > migration/migration.c | 14 ++ > 1 file changed, 1

[Qemu-devel] [PATCH 17/17] checkpatch: Warn when errp is passed to error_append_hint()

Passing errp from the argument list to error_append_hint() isn't recommended because it may cause unwanted behaviours when errp is equal to &error_fatal or &error_abort. First, error_append_hint() aborts QEMU when passed either of those. Second, consider the following: void foo(Error **errp)

[Qemu-devel] [PATCH 08/17] pcie_root_port: Pass local error object pointer to error_append_hint()

Ensure that hints are added even if errp is &error_fatal or &error_abort. Signed-off-by: Greg Kurz --- hw/pci-bridge/pcie_root_port.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/pci-bridge/pcie_root_port.c b/hw/pci-bridge/pcie_root_port.c index 012c2cb12c

[Qemu-devel] [PATCH 5/7] vmxcap: correct the name of the variables

The low bits are 1 if the control must be one, the high bits are 1 if the control can be one. Correct the variable names as they are very confusing. Signed-off-by: Paolo Bonzini --- scripts/kvm/vmxcap | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/scripts/kvm

[Qemu-devel] [PATCH 1/7] target/i386: handle filtered_features in a new function mark_unavailable_features

The next patch will add a different reason for filtering features, unrelated to host feature support. Extract a new function that takes care of disabling the features and optionally reporting them. Signed-off-by: Paolo Bonzini --- target/i386/cpu.c | 87 ++---

Re: [Qemu-devel] [PATCH 09/13] hw: Move Xilinx ZynqMP RTC from hw/timer/ to hw/rtc/ subdirectory

Hi Alistair, On 9/16/19 11:44 PM, Alistair Francis wrote: > On Mon, Sep 16, 2019 at 8:56 AM Philippe Mathieu-Daudé > wrote: >> >> Move RTC devices under the hw/rtc/ subdirectory. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> hw/rtc/Makefile.objs| 1 + >> hw/rtc/t

[Qemu-devel] [PATCH 10/17] s390x/css: Pass local error object pointer to error_append_hint()

Ensure that hints are added even if errp is &error_fatal or &error_abort. Signed-off-by: Greg Kurz --- hw/s390x/s390-ccw.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/s390x/s390-ccw.c b/hw/s390x/s390-ccw.c index 0c5a5b60bd6b..9566be800a3b 100644 --- a/hw/s390x

Re: [Qemu-devel] ELF load command alignment not page-aligned

On 17/09/2019 12:33, Philippe Mathieu-Daudé wrote: > Cc'ing PPC folks and Laurent. > > On 9/16/19 11:06 PM, Niccolò Belli wrote: >> Hi, >> I'm trying to use qemu-user-static to chroot into a foreign amd64 >> environment from my ppc64le host. >> The host has a 64k page size, while x86_64 uses 4k. >

[Qemu-devel] [PATCH 16/17] socket: Pass local error object pointer to error_append_hint()

Ensure that hints are added even if errp is &error_fatal or &error_abort. Signed-off-by: Greg Kurz --- util/qemu-sockets.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index 98ff3a1cce64..5da7b5f2fa0d 100644 --- a

[Qemu-devel] [PATCH 4/7] target/i386: add VMX definitions

These will be used to compile the list of VMX features for named CPU models, and/or by the code that sets up the VMX MSRs. Signed-off-by: Paolo Bonzini --- target/i386/cpu.h | 125 ++ 1 file changed, 125 insertions(+) diff --git a/target/i386/

Re: [Qemu-devel] ELF load command alignment not page-aligned

Cc'ing PPC folks and Laurent. On 9/16/19 11:06 PM, Niccolò Belli wrote: > Hi, > I'm trying to use qemu-user-static to chroot into a foreign amd64 > environment from my ppc64le host. > The host has a 64k page size, while x86_64 uses 4k. > I get those errors while loading shared libraries: "ELF load

Re: [Qemu-devel] [PATCH] replay: don't synchronize memory operations in replay mode

On 17/09/19 11:54, Pavel Dovgalyuk wrote: > Commit 9458a9a1df1a4c719e24512394d548c1fc7abd22 added synchronization > of vCPU and migration operations through calling run_on_cpu operation. > However, in replay mode this synchronization is unneeded, because > I/O and vCPU threads are already synchroni

[Qemu-devel] [PATCH 3/7] target/i386: expand feature words to 64 bits

VMX requires 64-bit feature words for the IA32_VMX_EPT_VPID_CAP and IA32_VMX_BASIC MSRs. (The VMX control MSRs are 64-bit wide but actually have only 32 bits of information). Signed-off-by: Paolo Bonzini --- include/sysemu/kvm.h | 2 +- target/i386/cpu.c| 71 +++

[Qemu-devel] [PATCH 6/7] target/i386: add VMX features

Add code to convert the VMX feature words back into MSR values, allowing the user to enable/disable VMX features as they wish. The same infrastructure enables support for limiting VMX features in named CPU models. Signed-off-by: Paolo Bonzini --- target/i386/cpu.c | 225

[Qemu-devel] [PATCH 2/7] target/i386: introduce generic feature dependency mechanism

Sometimes a CPU feature does not make sense unless another is present. In the case of VMX features, KVM does not even allow setting the VMX controls to some invalid combinations. Therefore, this patch adds a generic mechanism that looks for bits that the user explicitly cleared, and uses them to

Re: [Qemu-devel] [PATCH v4 1/7] iotests: Prefer null-co over null-aio

On 17/09/2019 12:19, Max Reitz wrote: > We use null-co basically everywhere in the iotests. Unless we want to > test null-aio specifically, we should use it instead (for consistency). > > Signed-off-by: Max Reitz > Reviewed-by: John Snow > Reviewed-by: Thomas Huth > --- > tests/qemu-iotest

[Qemu-devel] [PATCH 7/7] target/i386: work around KVM_GET_MSRS bug for secondary execution controls

Some secondary controls are automatically enabled/disabled based on the CPUID values that are set for the guest. However, they are still available at a global level and therefore should be present when KVM_GET_MSRS is sent to /dev/kvm. Unfortunately KVM forgot to include those, so fix that. Sign

Re: [Qemu-devel] vhost, iova, and dirty page tracking

On 2019/9/17 下午4:48, Tian, Kevin wrote: From: Jason Wang [mailto:jasow...@redhat.com] Sent: Monday, September 16, 2019 4:33 PM On 2019/9/16 上午9:51, Tian, Kevin wrote: Hi, Jason We had a discussion about dirty page tracking in VFIO, when vIOMMU is enabled: https://lists.nongnu.org/archive/h

Re: [Qemu-devel] [PULL v2 00/29] Misc patches for 2019-09-16

On 17/09/19 11:17, Yury Kotov wrote: > Sorry, it looks like that you've missed the 3rd patch in the > "High downtime with 95+ throttle pct" series: > tests/migration: Add a test for auto converge > > Or was there a reason for not adding it to PR? No, I just missed it. I will add it to the ne

Re: [Qemu-devel] [PATCH 17/17] checkpatch: Warn when errp is passed to error_append_hint()

On 9/17/19 12:22 PM, Greg Kurz wrote: > Passing errp from the argument list to error_append_hint() > isn't recommended because it may cause unwanted behaviours > when errp is equal to &error_fatal or &error_abort. > > First, error_append_hint() aborts QEMU when passed either of > those. > > Secon

Re: [Qemu-devel] [PATCH] target/arm: fix CBAR register for AArch64 CPUs

On Tue, 17 Sep 2019 at 09:43, Luc Michel wrote: > > On 9/13/19 9:26 AM, Luc Michel wrote: > > Hi Peter, > > > > On 9/12/19 6:03 PM, Peter Maydell wrote: > >> I think we need to check through the TRMs to confirm which CPUs use > >> which format for the CBAR, and have a different feature bit for the

Re: [Qemu-devel] [PULL v2 00/29] Misc patches for 2019-09-16

On Mon, 16 Sep 2019 at 17:19, Paolo Bonzini wrote: > > The following changes since commit 138985c1ef8b66e4e5b383354e133e05d01d0b5f: > > Merge remote-tracking branch > 'remotes/amarkovic/tags/mips-queue-sep-12-2019' into staging (2019-09-13 > 16:04:46 +0100) > > are available in the git reposit

Re: [Qemu-devel] [PATCH 00/17] Fix usage of error_append_hint()

For some reason your email client escaped incorrectly Daniel's email: "Daniel P. Berrangé\" Which makes my email client very unhappy (Thunderbird): There are non-ASCII characters in the local part of the recipient address "Daniel P. Berrangé , qemu-bl...@nongnu.org, qemu-...@nongnu.org, qemu-

[Qemu-devel] [PATCH 1/2] block/snapshot: Restrict set of snapshot nodes

Nodes involved in internal snapshots were those that were returned by bdrv_next(), inserted and not read-only. bdrv_next() in turn returns all nodes that are either the root node of a BlockBackend or monitor-owned nodes. With the typical -drive use, this worked well enough. However, in the typical

[Qemu-devel] [PATCH 0/2] block/snapshot: Restrict set of snapshot nodes

This fixes internal snapshots with separately defined protocol nodes (like libvirt will do with -blockdev). Kevin Wolf (2): block/snapshot: Restrict set of snapshot nodes iotests: Test internal snapshots with -blockdev block/snapshot.c | 26 +++-- tests/qemu-iotests/267

[Qemu-devel] [PATCH 2/2] iotests: Test internal snapshots with -blockdev

Signed-off-by: Kevin Wolf --- tests/qemu-iotests/267 | 165 tests/qemu-iotests/267.out | 182 +++ tests/qemu-iotests/common.filter | 5 +- tests/qemu-iotests/group | 1 + 4 files changed, 349 insertions(+), 4 del

Re: [Qemu-devel] [PATCH v3 6/8] iotests: Test driver whitelisting in 093

On 17.09.19 10:40, Kevin Wolf wrote: > Am 17.09.2019 um 10:18 hat Max Reitz geschrieben: >> On 13.09.19 20:30, John Snow wrote: >>> >>> >>> On 9/13/19 8:47 AM, Max Reitz wrote: On 20.08.19 23:32, John Snow wrote: > > > On 8/19/19 4:18 PM, Max Reitz wrote: >> null-aio may not be

[Qemu-devel] [PATCH v3 2/2] ati: use vga_read_byte in ati_cursor_define

This makes sure reads are confined to vga video memory. v3: use uint32_t, fix cut+paste bug. v2: fix ati_cursor_draw_line too. Reported-by: xu hang Signed-off-by: Gerd Hoffmann --- hw/display/ati.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/hw/disp

[Qemu-devel] [PATCH v3 0/2] ati: fix ati_cursor_define bug.

Gerd Hoffmann (2): vga: move access helpers to separate include file ati: use vga_read_byte in ati_cursor_define hw/display/vga-access.h | 49 hw/display/vga-helpers.h | 26 - hw/display/ati.c | 19 hw/d

Re: [Qemu-devel] ELF load command alignment not page-aligned

Il 2019-09-17 12:40 Laurent Vivier ha scritto: Which version of qemu do you use? Last time I tested that on my PoweMac G5 (ppc64, qemu-4.0), it worked. I'm using 4.1, but I also tried 3.1.1. I can get some binaries to work, but lots of them won't. Even debootstrapping a Debian system proves

[Qemu-devel] [PATCH v3 1/2] vga: move access helpers to separate include file

Signed-off-by: Gerd Hoffmann --- hw/display/vga-access.h | 49 hw/display/vga-helpers.h | 26 - hw/display/vga.c | 1 + 3 files changed, 50 insertions(+), 26 deletions(-) create mode 100644 hw/display/vga-access.h diff --git

Re: [Qemu-devel] [PATCH 01/17] error: Update error_append_hint()'s documentation

On Tue, 17 Sep 2019 12:20:37 +0200 Greg Kurz wrote: > error_setg() and error_propagate(), as well as their variants, cause > QEMU to terminate when called with &error_fatal or &error_abort. This > prevents to add hints since error_append_hint() isn't even called in > this case. > > It means that

Re: [Qemu-devel] [PATCH v3 6/8] iotests: Test driver whitelisting in 093

Am 17.09.2019 um 13:07 hat Max Reitz geschrieben: > On 17.09.19 10:40, Kevin Wolf wrote: > > Am 17.09.2019 um 10:18 hat Max Reitz geschrieben: > >> On 13.09.19 20:30, John Snow wrote: > >>> I'd still like to define func_wrapper with a nod to the type constraint > >>> it has: > >>> > >>> def func_wr

Re: [Qemu-devel] [PATCH 10/17] s390x/css: Pass local error object pointer to error_append_hint()

On Tue, 17 Sep 2019 12:21:34 +0200 Greg Kurz wrote: > Ensure that hints are added even if errp is &error_fatal or &error_abort. > > Signed-off-by: Greg Kurz > --- > hw/s390x/s390-ccw.c |6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Cornelia Huck Can also take

Re: [Qemu-devel] [PATCH 06/17] vfio: Pass local error object pointer to error_append_hint()

On Tue, 17 Sep 2019 12:21:08 +0200 Greg Kurz wrote: > Ensure that hints are added even if errp is &error_fatal or &error_abort. > > Signed-off-by: Greg Kurz > --- > hw/vfio/common.c | 14 ++ > hw/vfio/pci.c| 12 > 2 files changed, 18 insertions(+), 8 deletions(

Re: [Qemu-devel] [PATCH 17/17] checkpatch: Warn when errp is passed to error_append_hint()

On Tue, 17 Sep 2019 12:22:18 +0200 Greg Kurz wrote: > Passing errp from the argument list to error_append_hint() > isn't recommended because it may cause unwanted behaviours > when errp is equal to &error_fatal or &error_abort. > > First, error_append_hint() aborts QEMU when passed either of > t

Re: [Qemu-devel] [PATCH v4 4/4] iotests: use python logging for iotests.log()

12.09.2019 3:16, John Snow wrote: > We can turn logging on/off globally instead of per-function. > > Remove use_log from run_job, and use python logging to turn on > diffable output when we run through a script entry point. > > iotest 245 changes output order due to buffering reasons. > > Signed

Re: [Qemu-devel] ELF load command alignment not page-aligned

On 17/09/2019 13:09, Niccolò Belli wrote: > Il 2019-09-17 12:40 Laurent Vivier ha scritto: >> Which version of qemu do you use? >> >> Last time I tested that on my PoweMac G5 (ppc64, qemu-4.0), it worked. > > I'm using 4.1, but I also tried 3.1.1. > > I can get some binaries to work, but lots of

Re: [Qemu-devel] [PATCH v2 00/24] Audio: Mixeng-free 5.1/7.1 audio support

Hi, > * oss - works, but it looks like I have to specify both in.dev and out.dev > if the default /dev/dsp does not exist, otherwise I just get a generic > "Could not init `oss' audio driver". We need a better error message here > IMHO. Yes, we basically have to add a Error* arg to the init ca

Re: [Qemu-devel] ELF load command alignment not page-aligned

On Tue, 17 Sep 2019 at 11:49, Philippe Mathieu-Daudé wrote: > > Cc'ing PPC folks and Laurent. > > On 9/16/19 11:06 PM, Niccolò Belli wrote: > > Hi, > > I'm trying to use qemu-user-static to chroot into a foreign amd64 > > environment from my ppc64le host. > > The host has a 64k page size, while x8

Re: [Qemu-devel] [PATCH v3] ui: add an embedded Barrier client

On Fri, Sep 06, 2019 at 10:38:12AM +0200, Laurent Vivier wrote: > This allows to receive mouse and keyboard events from > a Barrier server. > > This is enabled by adding the following parameter on the > command line > > ... -object input-barrier,id=$id,name=$name ... > > Where $name is the n

  1   2   3   4   >