Re: [Qemu-devel] [PULL 00/16] Block patches

2019-09-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190916142246.31474-1-mre...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #

Re: [Qemu-devel] test-aio-multithread assertion

2019-09-16 Thread Stefan Hajnoczi
On Wed, Sep 04, 2019 at 12:50:21PM +0100, Peter Maydell wrote: > Hi; I've been seeing intermittently on the BSDs this assertion > running test-aio-multithread as part of 'make check': > > MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} > tests/test-aio-multithread -m=quick -k --ta

[Qemu-devel] [PATCH 04/13] hw: Move M48T59 device from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread Philippe Mathieu-Daudé
The M48T59 is a Real Time Clock, not a timer. Move it under the hw/rtc/ subdirectory. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 4 +- hw/ppc/ppc405_boards.c | 2 +- hw/ppc/prep.c | 2 +- hw/rtc/Kconfig

Re: [Qemu-devel] [PATCH v2 0/6] tests/acceptance: Add tests for the PReP/40p machine

2019-09-16 Thread Eduardo Habkost
On Mon, Sep 16, 2019 at 11:28:23AM +0200, Philippe Mathieu-Daudé wrote: > Hi David, > > On 9/16/19 2:42 AM, David Gibson wrote: > > On Sun, Sep 15, 2019 at 11:19:34PM +0200, Philippe Mathieu-Daudé wrote: > >> Quick tests worth to avoid regressions with the 40p machine. > >> idea from the "Maintain

[Qemu-devel] [PATCH 06/13] hw: Move sun4v hypervisor RTC from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread Philippe Mathieu-Daudé
Move RTC devices under the hw/rtc/ subdirectory. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 4 ++-- hw/rtc/Kconfig| 3 +++ hw/rtc/Makefile.objs | 1 + hw/{timer => rtc}/sun4v-rtc.c | 2 +- hw/rtc/trace-events | 4 hw/spa

[Qemu-devel] [PATCH 03/13] hw: Move MC146818 device from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread Philippe Mathieu-Daudé
The MC146818 is a Real Time Clock, not a timer. Move it under the hw/rtc/ subdirectory. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 4 +-- hw/alpha/dp264.c | 2 +- hw/hppa/machine.c| 2 +- hw/

[Qemu-devel] [PATCH v2 1/1] Handle /proc/self/exe in syscall execve

2019-09-16 Thread Olivier Dion
If not handled, QEMU will execve itself instead of the emulated process. The function do_openat already solves the /proc/self/exe problem, so we can use it to get the executable file descriptor. We then make a safe call to execveat. Note that safe_execve has been replaced by safe_execveat, since

[Qemu-devel] [PATCH 05/13] hw: Move M41T80 device from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread Philippe Mathieu-Daudé
The M41T80 is a Real Time Clock, not a timer. Move it under the hw/rtc/ subdirectory. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS| 2 +- hw/rtc/Kconfig | 4 hw/rtc/Makefile.objs | 1 + hw/{timer => rtc}/m41t80.c | 0 hw/timer/Kconfig | 4

[Qemu-devel] [PATCH 07/13] hw: Move TWL92230 device from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread Philippe Mathieu-Daudé
The TWL92230 is an "energy management device" companion with a RTC. Since we mostly model the RTC, move it under the hw/rtc/ subdirectory. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 2 +- hw/rtc/Kconfig | 4 hw/rtc/Makefile.objs | 1 + hw/

[Qemu-devel] [PATCH 08/13] hw: Move DS1338 device from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread Philippe Mathieu-Daudé
The DS1338 is a Real Time Clock, not a timer. Move it under the hw/rtc/ subdirectory. Signed-off-by: Philippe Mathieu-Daudé --- hw/rtc/Kconfig | 4 hw/rtc/Makefile.objs | 1 + hw/{timer => rtc}/ds1338.c | 0 hw/timer/Kconfig | 4 hw/timer/Makefile.objs |

Re: [Qemu-devel] [PATCH v2 1/2] trace: Remove trailing newline in events

2019-09-16 Thread John Snow
On 9/16/19 12:40 PM, Philippe Mathieu-Daudé wrote: > On 9/16/19 6:36 PM, Eric Blake wrote: >> On 9/16/19 4:51 AM, Philippe Mathieu-Daudé wrote: >>> While the tracing frawework does not forbid trailing newline in >> >> framework >> >>> events format string, using them lead to confuse output. >>>

[Qemu-devel] [PATCH 12/13] hw/rtc/mc146818: Include mc146818rtc_regs.h a bit less

2019-09-16 Thread Philippe Mathieu-Daudé
Only 2 source files require the "mc146818rtc_regs.h" header. Instead of having it processed 12 times, by all objects using "mc146818rtc.h", include it directly where used. Signed-off-by: Philippe Mathieu-Daudé --- hw/rtc/mc146818rtc.c | 1 + hw/timer/hpet.c | 1 + include/hw

Re: [Qemu-devel] [PATCH v2 1/2] trace: Remove trailing newline in events

2019-09-16 Thread Philippe Mathieu-Daudé
On 9/16/19 6:36 PM, Eric Blake wrote: > On 9/16/19 4:51 AM, Philippe Mathieu-Daudé wrote: >> While the tracing frawework does not forbid trailing newline in > > framework > >> events format string, using them lead to confuse output. >> It is the responsibility of the backend to properly end an ev

[Qemu-devel] [PATCH 13/13] hw/rtc/xlnx-zynqmp-rtc: Remove unused "ptimer.h" include

2019-09-16 Thread Philippe Mathieu-Daudé
The "hw/ptimer.h" header is not used, remove it. Signed-off-by: Philippe Mathieu-Daudé --- hw/rtc/xlnx-zynqmp-rtc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/rtc/xlnx-zynqmp-rtc.c b/hw/rtc/xlnx-zynqmp-rtc.c index f9f09b7296..2bcd14d779 100644 --- a/hw/rtc/xlnx-zynqmp-rtc.c +++ b/hw/r

[Qemu-devel] [PATCH v2 0/1] Handle /proc/self/exe in execve

2019-09-16 Thread Olivier Dion
* Changes from v1 - Introduce the patch as a bug fix, rather than a security fix - Use do_openat and safe_execveat instead of copying exec_path - Extensive test case example * Test case I will present a short program that demonstrated the bug, i.e. what is the expected behavior and w

Re: [Qemu-devel] [PATCH v2 1/6] tests/acceptance: Add test that runs NetBSD 4.0 installer on PRep/40p

2019-09-16 Thread Philippe Mathieu-Daudé
On 9/16/19 6:08 PM, Cleber Rosa wrote: > On Sun, Sep 15, 2019 at 11:19:35PM +0200, Philippe Mathieu-Daudé wrote: >> As of this commit, NetBSD 4.0 is very old. However it is enough to >> test the PRep/40p machine. >> >> User case from: >> http://mail-index.netbsd.org/port-prep/2017/04/11/msg000112.h

Re: [Qemu-devel] [PATCH v4 1/4] iotests: add script_initialize

2019-09-16 Thread John Snow
On 9/16/19 10:56 AM, Vladimir Sementsov-Ogievskiy wrote: > 12.09.2019 3:16, John Snow wrote: >> Like script_main, but doesn't require a single point of entry. >> Replace all existing initialization sections with this drop-in replacement. >> >> This brings debug support to all existing script-sty

Re: [Qemu-devel] [PATCH v2 1/2] trace: Remove trailing newline in events

2019-09-16 Thread Eric Blake
On 9/16/19 4:51 AM, Philippe Mathieu-Daudé wrote: > While the tracing frawework does not forbid trailing newline in framework > events format string, using them lead to confuse output. > It is the responsibility of the backend to properly end an event > line. Why just trailing newline? Should we

Re: [Qemu-devel] [PATCH v2 0/1] Handle /proc/self/exe in execve

2019-09-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190916155545.29928-1-olivier.d...@polymtl.ca/ Hi, This series failed build test on FreeBSD host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commi

Re: [Qemu-devel] [PATCH v2] util/hbitmap: strict hbitmap_reset

2019-09-16 Thread John Snow
On 9/16/19 4:00 AM, Kevin Wolf wrote: > Am 13.09.2019 um 20:49 hat John Snow geschrieben: >> On 9/12/19 4:20 AM, Vladimir Sementsov-Ogievskiy wrote: >>> Also, I'm not sure about "are" suggested by Max. "are" is for plural, but >>> here I meant >>> one object: sum of @start and @count. >>> >> >>

Re: [Qemu-devel] [PATCH v4 1/4] iotests: add script_initialize

2019-09-16 Thread Vladimir Sementsov-Ogievskiy
16.09.2019 19:32, John Snow wrote: > > > On 9/16/19 10:56 AM, Vladimir Sementsov-Ogievskiy wrote: >> 12.09.2019 3:16, John Snow wrote: >>> Like script_main, but doesn't require a single point of entry. >>> Replace all existing initialization sections with this drop-in replacement. >>> >>> This br

[Qemu-devel] [PATCH] Acceptance tests: refactor wait_for_console_pattern

2019-09-16 Thread Cleber Rosa
The same utility method is already present in two different test files, so let's consolidate it into a single utility function. Signed-off-by: Cleber Rosa --- tests/acceptance/avocado_qemu/__init__.py | 26 + tests/acceptance/boot_linux_console.py| 47 +++ tes

[Qemu-devel] [PATCH v2 2/2] ppc: Add support for 'mffsce' instruction

2019-09-16 Thread Paul A. Clarke
From: "Paul A. Clarke" ISA 3.0B added a set of Floating-Point Status and Control Register (FPSCR) instructions: mffsce, mffscdrn, mffscdrni, mffscrn, mffscrni, mffsl. This patch adds support for 'mffsce' instruction. 'mffsce' is identical to 'mffs', except that it also clears the exception enabl

[Qemu-devel] [PATCH v2 1/2] ppc: Add support for 'mffscrn', 'mffscrni' instructions

2019-09-16 Thread Paul A. Clarke
From: "Paul A. Clarke" ISA 3.0B added a set of Floating-Point Status and Control Register (FPSCR) instructions: mffsce, mffscdrn, mffscdrni, mffscrn, mffscrni, mffsl. This patch adds support for 'mffscrn' and 'mffscrni' instructions. 'mffscrn' and 'mffscrni' are similar to 'mffsl', except they d

Re: [Qemu-devel] [PATCH v8 18/32] riscv: sifive_u: Set the minimum number of cpus to 2

2019-09-16 Thread Alistair Francis
On Sun, Sep 15, 2019 at 6:07 AM Bin Meng wrote: > > Hi Palmer, > > On Sun, Sep 15, 2019 at 3:00 AM Palmer Dabbelt wrote: > > > > On Fri, 13 Sep 2019 08:25:21 PDT (-0700), bmeng...@gmail.com wrote: > > > Hi Palmer, > > > > > > On Fri, Sep 13, 2019 at 10:33 PM Palmer Dabbelt wrote: > > >> > > >> O

Re: [Qemu-devel] [PATCH v2] target/s390x/kvm: Officially require at least kernel 3.15

2019-09-16 Thread Cornelia Huck
On Fri, 13 Sep 2019 11:14:43 +0200 Thomas Huth wrote: Modified the subject, as suggested by David. > Since QEMU v2.10, the KVM acceleration does not work on older kernels > anymore since the code accidentally requires the KVM_CAP_DEVICE_CTRL > capability now - it should have been optional instea

Re: [Qemu-devel] [PATCH v4 1/4] iotests: add script_initialize

2019-09-16 Thread John Snow
On 9/16/19 12:39 PM, Vladimir Sementsov-Ogievskiy wrote: > 16.09.2019 19:32, John Snow wrote: >> >> >> On 9/16/19 10:56 AM, Vladimir Sementsov-Ogievskiy wrote: >>> 12.09.2019 3:16, John Snow wrote: Like script_main, but doesn't require a single point of entry. Replace all existing init

Re: [Qemu-devel] [PATCH 11/13] hw: Move Aspeed RTC from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread Cédric Le Goater
On 16/09/2019 17:48, Philippe Mathieu-Daudé wrote: > Move RTC devices under the hw/rtc/ subdirectory. > > Signed-off-by: Philippe Mathieu-Daudé I suppose the removal of the header files in "aspeed_rtc.h" is OK. Reviewed-by: Cédric Le Goater Thanks, C. > --- > hw/rtc/Makefile.objs

Re: [Qemu-devel] [PATCH 01/13] hw/timer: Compile devices not target-dependent as common object

2019-09-16 Thread Alistair Francis
On Mon, Sep 16, 2019 at 9:02 AM Philippe Mathieu-Daudé wrote: > > All these devices do not contain any target-specific. While most > of them are arch-specific, they are shared between different > targets of the same arch family (ARM and AArch64, MIPS32/MIPS64, > endianess, ...). > Put them into co

[Qemu-devel] [PATCH v5 2/5] block: introduce aio task pool

2019-09-16 Thread Vladimir Sementsov-Ogievskiy
Common interface for aio task loops. To be used for improving performance of synchronous io loops in qcow2, block-stream, copy-on-read, and may be other places. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- include/block/aio_task.h | 54 + block/aio_tas

[Qemu-devel] [PATCH v5 1/5] qemu-iotests: ignore leaks on failure paths in 026

2019-09-16 Thread Vladimir Sementsov-Ogievskiy
Upcoming asynchronous handling of sub-parts of qcow2 requests will change number of leaked clusters and even make it racy. As a preparation, ignore leaks on failure parts in 026. It's not trivial to just grep or substitute qemu-img output for such thing. Instead do better: 3 is a error code of qem

Re: [Qemu-devel] [PATCH 1/4] block/dirty-bitmap: drop meta

2019-09-16 Thread John Snow
On 9/16/19 10:19 AM, Vladimir Sementsov-Ogievskiy wrote: > Drop meta bitmaps, as they are unused. > > Signed-off-by: Vladimir Sementsov-Ogievskiy believe it or not, I had a local patch that does the same :) Reviewed-by: John Snow

[Qemu-devel] [PATCH v5 4/5] block/qcow2: refactor qcow2_co_pwritev_part

2019-09-16 Thread Vladimir Sementsov-Ogievskiy
Similarly to previous commit, prepare for parallelizing write-loop iterations. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block/qcow2.c | 154 +- 1 file changed, 90 insertions(+), 64 deletions(-) diff --git a/block/qco

[Qemu-devel] [PATCH v5 3/5] block/qcow2: refactor qcow2_co_preadv_part

2019-09-16 Thread Vladimir Sementsov-Ogievskiy
Further patch will run partial requests of iterations of qcow2_co_preadv in parallel for performance reasons. To prepare for this, separate part which may be parallelized into separate function (qcow2_co_preadv_task). While being here, also separate encrypted clusters reading to own function, like

Re: [Qemu-devel] [PATCH v2 2/6] tests/acceptance: Test Open Firmware on the PReP/40p

2019-09-16 Thread Cleber Rosa
On Sun, Sep 15, 2019 at 11:19:36PM +0200, Philippe Mathieu-Daudé wrote: > User case from: > https://tyom.blogspot.com/2019/04/aixprep-under-qemu-how-to.html > > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/acceptance/ppc_prep_40p.py | 21 + > 1 file changed, 21 inserti

[Qemu-devel] [PATCH v5 5/5] block/qcow2: introduce parallel subrequest handling in read and write

2019-09-16 Thread Vladimir Sementsov-Ogievskiy
It improves performance for fragmented qcow2 images. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.h | 3 ++ block/qcow2.c | 125 - block/trace-events | 1 + 3 files changed, 117 insertions(+), 12 deletions(-) diff --git a/

[Qemu-devel] [PATCH v5 0/5] qcow2: async handling of fragmented io

2019-09-16 Thread Vladimir Sementsov-Ogievskiy
Hi all! Here is an asynchronous scheme for handling fragmented qcow2 reads and writes. Both qcow2 read and write functions loops through sequential portions of data. The series aim it to parallelize these loops iterations. It improves performance for fragmented qcow2 images, I've tested it as desc

Re: [Qemu-devel] [PATCH 02/13] hw: Move PL031 device from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread Alistair Francis
On Mon, Sep 16, 2019 at 9:06 AM Philippe Mathieu-Daudé wrote: > > The PL031 is a Real Time Clock, not a timer. > Move it under the hw/rtc/ subdirectory. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > MAINTAINERS | 4 ++-- > Make

Re: [Qemu-devel] [PATCH 1/3] tests/acceptance/migration: fix post migration check

2019-09-16 Thread Dr. David Alan Gilbert
* Balamuruhan S (bal...@linux.ibm.com) wrote: > assert `query-migrate` in target doesn't give migration > status and test errors even if migration succeeds. > > In target: > {'execute': 'query-migrate'} > {"return": {}} On which version of qemu? On the current version I see: {"QMP": {"version":

Re: [Qemu-devel] [PATCH v2 2/6] tests/acceptance: Test Open Firmware on the PReP/40p

2019-09-16 Thread Cleber Rosa
On Mon, Sep 16, 2019 at 01:59:22PM -0400, Cleber Rosa wrote: > On Sun, Sep 15, 2019 at 11:19:36PM +0200, Philippe Mathieu-Daudé wrote: > > User case from: > > https://tyom.blogspot.com/2019/04/aixprep-under-qemu-how-to.html > > > > Signed-off-by: Philippe Mathieu-Daudé > > --- > > tests/acceptan

Re: [Qemu-devel] [PATCH v3 5/6] docs: start a document to describe D-Bus usage

2019-09-16 Thread Marc-André Lureau
Hi On Mon, Sep 16, 2019 at 5:15 PM Dr. David Alan Gilbert wrote: > > * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > > Hi > > > > On Mon, Sep 16, 2019 at 2:02 PM Dr. David Alan Gilbert > > wrote: > > > > > > (Copying in Stefan since he was looking at DBus for virtiofs) > > > > > > * Ma

Re: [Qemu-devel] [PATCH v2 3/6] tests/acceptance: Test OpenBIOS on the PReP/40p

2019-09-16 Thread Cleber Rosa
On Sun, Sep 15, 2019 at 11:19:37PM +0200, Philippe Mathieu-Daudé wrote: > User case from: > https://mail.coreboot.org/pipermail/openbios/2018-May/010360.html > > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/acceptance/ppc_prep_40p.py | 32 > 1 file changed

Re: [Qemu-devel] [PATCH] nbd/server: attach client channel to the export's AioContext

2019-09-16 Thread Eric Blake
On 9/12/19 1:37 AM, Sergio Lopez wrote: >> I tried to test this patch, but even with it applied, I still got an >> aio-context crasher by attempting an nbd-server-start, nbd-server-add, >> nbd-server-stop (intentionally skipping the nbd-server-remove step) on a >> domain using iothreads, with a ba

[Qemu-devel] ELF load command alignment not page-aligned

2019-09-16 Thread Niccolò Belli
Hi, I'm trying to use qemu-user-static to chroot into a foreign amd64 environment from my ppc64le host. The host has a 64k page size, while x86_64 uses 4k. I get those errors while loading shared libraries: "ELF load command alignment not page-aligned" Is there any way to fix this? I cannot sim

Re: [Qemu-devel] [PATCH 03/13] hw: Move MC146818 device from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread Alistair Francis
On Mon, Sep 16, 2019 at 9:31 AM Philippe Mathieu-Daudé wrote: > > The MC146818 is a Real Time Clock, not a timer. > Move it under the hw/rtc/ subdirectory. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > MAINTAINERS |

Re: [Qemu-devel] [PATCH 04/13] hw: Move M48T59 device from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread Alistair Francis
On Mon, Sep 16, 2019 at 9:26 AM Philippe Mathieu-Daudé wrote: > > The M48T59 is a Real Time Clock, not a timer. > Move it under the hw/rtc/ subdirectory. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > MAINTAINERS | 4 +- > hw

Re: [Qemu-devel] [PATCH 05/13] hw: Move M41T80 device from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread Alistair Francis
On Mon, Sep 16, 2019 at 9:35 AM Philippe Mathieu-Daudé wrote: > > The M41T80 is a Real Time Clock, not a timer. > Move it under the hw/rtc/ subdirectory. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > MAINTAINERS| 2 +- > hw/rtc/Kconf

Re: [Qemu-devel] [PATCH 06/13] hw: Move sun4v hypervisor RTC from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread Alistair Francis
On Mon, Sep 16, 2019 at 9:30 AM Philippe Mathieu-Daudé wrote: > > Move RTC devices under the hw/rtc/ subdirectory. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > MAINTAINERS | 4 ++-- > hw/rtc/Kconfig| 3 +++ > hw/

Re: [Qemu-devel] [PATCH v1] gdbstub: riscv: fix the fflags registers

2019-09-16 Thread Alistair Francis
On Tue, Sep 10, 2019 at 1:16 AM KONRAD Frederic wrote: > > While debugging an application with GDB the following might happen: > > (gdb) return > Make xxx return now? (y or n) y > Could not fetch register "fflags"; remote failure reply 'E14' > > This is because riscv_gdb_get_fpu calls riscv_csrrw_

Re: [Qemu-devel] [PATCH 07/13] hw: Move TWL92230 device from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread Alistair Francis
On Mon, Sep 16, 2019 at 9:37 AM Philippe Mathieu-Daudé wrote: > > The TWL92230 is an "energy management device" companion with > a RTC. Since we mostly model the RTC, move it under the hw/rtc/ > subdirectory. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > -

Re: [Qemu-devel] [PATCH 08/13] hw: Move DS1338 device from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread Alistair Francis
On Mon, Sep 16, 2019 at 9:39 AM Philippe Mathieu-Daudé wrote: > > The DS1338 is a Real Time Clock, not a timer. > Move it under the hw/rtc/ subdirectory. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/rtc/Kconfig | 4 > hw/rtc/Mak

Re: [Qemu-devel] [PATCH 09/13] hw: Move Xilinx ZynqMP RTC from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread Alistair Francis
On Mon, Sep 16, 2019 at 8:56 AM Philippe Mathieu-Daudé wrote: > > Move RTC devices under the hw/rtc/ subdirectory. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/rtc/Makefile.objs| 1 + > hw/rtc/trace-events | 3 +++ > hw/{timer => rtc}/xlnx-

Re: [Qemu-devel] [PATCH 10/13] hw: Move Exynos4210 RTC from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread Alistair Francis
On Mon, Sep 16, 2019 at 9:00 AM Philippe Mathieu-Daudé wrote: > > Move RTC devices under the hw/rtc/ subdirectory. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/rtc/Makefile.objs | 1 + > hw/{timer => rtc}/exynos4210_rtc.c | 0 > hw

Re: [Qemu-devel] [PATCH 12/13] hw/rtc/mc146818: Include mc146818rtc_regs.h a bit less

2019-09-16 Thread Alistair Francis
On Mon, Sep 16, 2019 at 9:42 AM Philippe Mathieu-Daudé wrote: > > Only 2 source files require the "mc146818rtc_regs.h" header. > Instead of having it processed 12 times, by all objects > using "mc146818rtc.h", include it directly where used. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by:

Re: [Qemu-devel] [PATCH 11/13] hw: Move Aspeed RTC from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread Alistair Francis
On Mon, Sep 16, 2019 at 9:17 AM Philippe Mathieu-Daudé wrote: > > Move RTC devices under the hw/rtc/ subdirectory. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/rtc/Makefile.objs | 1 + > hw/{timer => rtc}/aspeed_rtc.c |

Re: [Qemu-devel] [PATCH 13/13] hw/rtc/xlnx-zynqmp-rtc: Remove unused "ptimer.h" include

2019-09-16 Thread Alistair Francis
On Mon, Sep 16, 2019 at 9:46 AM Philippe Mathieu-Daudé wrote: > > The "hw/ptimer.h" header is not used, remove it. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/rtc/xlnx-zynqmp-rtc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/rtc/

Re: [Qemu-devel] [PATCH] nbd/server: attach client channel to the export's AioContext

2019-09-16 Thread Eric Blake
On 9/12/19 6:31 AM, Kevin Wolf wrote: >> >> Yes, I think locking the context during the "if (exp->blk) {" block at >> nbd/server.c:1646 should do the trick. That line number has moved over time; which function are you referring to? > > We need to be careful to avoid locking things twice, so may

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 0/6] tests/acceptance: Add tests for the PReP/40p machine

2019-09-16 Thread David Gibson
On Mon, Sep 16, 2019 at 11:56:06AM +0200, Philippe Mathieu-Daudé wrote: > On 9/16/19 11:52 AM, Alex Bennée wrote: > > > > Philippe Mathieu-Daudé writes: > > > >> Hi David, > >> > >> On 9/16/19 2:42 AM, David Gibson wrote: > >>> On Sun, Sep 15, 2019 at 11:19:34PM +0200, Philippe Mathieu-Daudé wro

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target/ppc: fix signal delivery for ppc64abi32

2019-09-16 Thread David Gibson
On Mon, Sep 16, 2019 at 08:22:42AM +0100, Alex Bennée wrote: > > David Gibson writes: > > > On Wed, Sep 11, 2019 at 10:33:45AM -0400, Richard Henderson wrote: > >> On 9/11/19 5:39 AM, Alex Bennée wrote: > >> > We were incorrectly setting NIP resulting in a segfault. This fixes > >> > linux-test

[Qemu-devel] [PATCH] nbd: Grab aio context lock in more places

2019-09-16 Thread Eric Blake
When iothreads are in use, the failure to grab the aio context results in an assertion failure when trying to unlock things during blk_unref, when trying to unlock a mutex that was not locked. In short, all calls to nbd_export_put need to done while within the correct aio context. But since nbd_e

Re: [Qemu-devel] [PATCH 03/13] hw: Move MC146818 device from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread David Gibson
On Mon, Sep 16, 2019 at 05:48:37PM +0200, Philippe Mathieu-Daudé wrote: > The MC146818 is a Real Time Clock, not a timer. > Move it under the hw/rtc/ subdirectory. > > Signed-off-by: Philippe Mathieu-Daudé ppc parts Acked-by: David Gibson > --- > MAINTAINERS

Re: [Qemu-devel] [PATCH 04/13] hw: Move M48T59 device from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread David Gibson
On Mon, Sep 16, 2019 at 05:48:38PM +0200, Philippe Mathieu-Daudé wrote: > The M48T59 is a Real Time Clock, not a timer. > Move it under the hw/rtc/ subdirectory. > > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 4 +- > hw/ppc/ppc405_boards.c |

Re: [Qemu-devel] [PATCH 01/13] hw/timer: Compile devices not target-dependent as common object

2019-09-16 Thread Thomas Huth
On 16/09/2019 17.48, Philippe Mathieu-Daudé wrote: > All these devices do not contain any target-specific. While most > of them are arch-specific, they are shared between different > targets of the same arch family (ARM and AArch64, MIPS32/MIPS64, > endianess, ...). > Put them into common-obj-y to

Re: [Qemu-devel] [PATCH 03/13] hw: Move MC146818 device from hw/timer/ to hw/rtc/ subdirectory

2019-09-16 Thread Thomas Huth
On 16/09/2019 17.48, Philippe Mathieu-Daudé wrote: > The MC146818 is a Real Time Clock, not a timer. > Move it under the hw/rtc/ subdirectory. > > Signed-off-by: Philippe Mathieu-Daudé [...] > diff --git a/include/hw/rtc/mc146818rtc.h b/include/hw/rtc/mc146818rtc.h > new file mode 100644 > index

<    1   2   3