On Wed, 11 Sep 2019 00:00:56 PDT (-0700), aleksandar.m.m...@gmail.com wrote:
11.09.2019. 08.35, "liuzhiwei" је написао/ла:
Features:
* support specification riscv-v-spec-0.7.1(
https://content.riscv.org/wp-content/uploads/2019/06/17.40-Vector_RISCV-20190611-Vectors.pdf
).
Hi, Zhivei.
The
On Wed, 11 Sep 2019 15:43:29 PDT (-0700), richard.hender...@linaro.org wrote:
On 9/11/19 2:25 AM, liuzhiwei wrote:
@@ -873,7 +925,12 @@ static riscv_csr_operations csr_ops[CSR_TABLE_SIZE] = {
[CSR_FFLAGS] = { fs, read_fflags, write_fflags },
[CSR_FRM] =
On 9/13/19 5:56 AM, Eric Auger wrote:
> Host kernels that expose the KVM_CAP_ARM_IRQ_LINE_LAYOUT_2 capability
> allow injection of interrupts along with vcpu ids larger than 255.
> Let's encode the vpcu id on 12 bits according to the upgraded KVM_IRQ_LINE
> ABI when needed.
>
> Given that we have
On 9/13/19 5:56 AM, Eric Auger wrote:
> Host kernel within [4.18, 5.3] report an erroneous KVM_MAX_VCPUS=512
> for ARM. The actual capability to instantiate more than 256 vcpus
> was fixed in 5.4 with the upgrade of the KVM_IRQ_LINE ABI to support
> vcpu id encoded on 12 bits instead of 8 and a red
On 9/12/19 8:54 AM, Paul A. Clarke wrote:
> +static void gen_helper_mffscrn(DisasContext *ctx, TCGv_i64 t1)
> +{
> +TCGv_i64 t0 = tcg_temp_new_i64();
> +TCGv_i32 mask = tcg_const_i32(0x0001);
> +
> +gen_reset_fpstatus();
> +tcg_gen_extu_tl_i64(t0, cpu_fpscr);
> +tcg_gen_andi_i64
On 9/14/19 10:58 AM, Richard Henderson wrote:
> On 9/12/19 8:54 AM, Paul A. Clarke wrote:
>> +static void gen_helper_mffscrn(DisasContext *ctx, TCGv_i64 t1)
>> +{
>> +TCGv_i64 t0 = tcg_temp_new_i64();
>> +TCGv_i32 mask = tcg_const_i32(0x0001);
>> +
>> +gen_reset_fpstatus();
>> +tcg_
On 9/13/19 9:49 AM, Alex Bennée wrote:
> +/* must be built with -O2 to generate fused op */
> +r = a * b + c;
I would prefer to use fmaf() or __builtin_fmaf() here.
Although you'll need to link with -lm just in case the
target doesn't support an instruction
Cover invalid 'if' in struct members, features, union and alternate
branches. Four out of four are broken. Mark FIXME.
Signed-off-by: Markus Armbruster
---
tests/Makefile.include| 4
.../alternate-branch-if-invalid.err | 0
.../alternate-branch-if-inval
check_keys() parameter expr_elem expects a dictionary with keys 'expr'
and 'info'. Passing the two values separately is simpler, so do that.
Signed-off-by: Markus Armbruster
---
scripts/qapi/common.py | 19 ---
1 file changed, 8 insertions(+), 11 deletions(-)
diff --git a/scrip
Here's the next batch of qapi patches, based on my "[PATCH v3 00/16]
qapi: Schema language cleanups & doc improvements". There's more in
the pipeline.
Based-on: <20190913201349.24332-1-arm...@redhat.com>
Markus Armbruster (19):
tests/qapi-schema: Cover unknown pragma
tests/qapi-schema: Delet
The error message for forgotten quotes around a name shows just the
name's first character, which isn't as nice as it could be. Same for
attempting to use a number.
Signed-off-by: Markus Armbruster
---
tests/Makefile.include | 1 +
tests/qapi-schema/bad-type-int.json | 2 +-
tests/
Commit 87adbbffd4..3e270dcacc "qapi: Add 'if' to (implicit
struct|union|alternate) members" (v4.0.0) neglected test coverage, and
promptly failed to check the conditions. Review fail.
Recent commit "tests/qapi-schema: Demonstrate insufficient 'if'
checking" added test coverage, demonstrating the
check_union() checks the discriminator exists in base and makes sense.
Two error messages mention the base. These are broken for anonymous
bases, as demonstrated by tests flat-union-invalid-discriminator and
flat-union-invalid-if-discriminator.err. The third one doesn't
bother.
First broken when
Signed-off-by: Markus Armbruster
---
tests/Makefile.include| 1 +
tests/qapi-schema/pragma-unknown.err | 1 +
tests/qapi-schema/pragma-unknown.exit | 1 +
tests/qapi-schema/pragma-unknown.json | 1 +
tests/qapi-schema/pragma-unknown.out | 0
5 files changed, 4 insertions(+)
cre
QAPISchemaObjectType.check() does nothing for types that have been
checked already. Except the "has been checked" predicate is broken
for empty types: self.members is [] then, which isn't true. The bug
is harmless, but fix it anyway: use self.member is not None instead.
Signed-off-by: Markus Arm
All callers pass a dict argument to @keys, except check_keys() passes
a dict's .keys(). Drop .keys() there, and rename parameter @keys to
@value.
Signed-off-by: Markus Armbruster
---
scripts/qapi/common.py | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/scripts/qapi/
When the union definition's base is an object, some error messages
show it as an OrderedDict. Oops. Mark FIXME.
Signed-off-by: Markus Armbruster
---
tests/qapi-schema/flat-union-invalid-discriminator.err | 2 +-
tests/qapi-schema/flat-union-invalid-discriminator.json| 6 ++
tests/q
Test flat-union-optional-discriminator declares its union tag as
'*switch': 'Enum', and points to it with 'discriminator': '*switch'.
This gets rejected as "discriminator of flat union 'MyUnion' uses
invalid name '*switch'". Correct; member 'discriminator' doesn't
accept a '*' prefix.
However, th
Entity checking goes back to commit ac88219a6c "qapi: New QAPISchema
intermediate representation", v2.5.0. It's designed to work as
follows: QAPISchema.check() calls .check() for all the schema's
entities. An entity's .check() recurses into another entity's
.check() only if the C struct generated
"'if': 'COND'" generates "#if COND". We reject empty COND because it
won't compile. Blank COND won't compile any better, so reject that,
too.
Signed-off-by: Markus Armbruster
---
scripts/qapi/common.py | 5 +++--
tests/qapi-schema/bad-if-list.err | 2 +-
tests/qapi-schema/bad-if-l
Show text up to next structural character, whitespace, or quote
character instead of just the first character.
Forgotten quotes now get reported like "Stray 'command'" instead of
"Stray 'c'".
Signed-off-by: Markus Armbruster
---
scripts/qapi/common.py | 6 +-
tests/qapi-schema/b
We normalize shorthand to longhand forms in check_expr(): enumeration
values with normalize_enum(), feature values with
normalize_features(), struct members, union branches and alternate
branches with normalize_members(). If conditions are an exception: we
normalize them in QAPISchemaEntity.check(
Easy since the previous commit provides .checked.
Signed-off-by: Markus Armbruster
---
scripts/qapi/common.py | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py
index c199a2b58c..b00caacca3 100644
--- a/scripts/qapi/com
Commit bceae7697f "qapi script: support enum type as discriminator in
union" made check_exprs() add the implicit enum types of simple unions
to global @enum_types. I'm not sure it was needed even then. It's
certainly not needed now. Delete it.
discriminator_find_enum_define() and add_name() par
We represent the parse tree as OrderedDict. We fetch optional dict
members with .get(). So far, so good.
We represent null literals as None. .get() returns None both for
"absent" and for "present, value is the null literal". Uh-oh.
Test features-if-invalid exposes this bug: "'if': null" is
mi
Tests duplicate-key and double-data test the same thing. The former
predates the latter, and it has a better name. Delete the latter, and
tweak the former's comment.
Tests include-format-err and include-extra-junk test the same thing.
The former predates the latter, but the latter has a better n
Consistently enclose error messages in double quotes. Use single
quotes within, except for one case of "'".
Signed-off-by: Markus Armbruster
---
scripts/qapi/common.py| 37 ++-
tests/qapi-schema/bad-type-int.err| 2 +-
tests/qapi-schema/doc-m
On 9/11/19 5:26 AM, Alex Bennée wrote:
>
> Aleksandar Markovic writes:
>
>> 10.09.2019. 21.34, "Alex Bennée" је написао/ла:
>>>
>>> This is preparatory for plugins which will want to report the
>>> architecture to plugins. Move the ELF_ARCH definition out of the
>>> loader and into its own head
On 9/12/19 8:54 AM, Paul A. Clarke wrote:
> From: "Paul A. Clarke"
>
> ISA 3.0B added a set of Floating-Point Status and Control Register (FPSCR)
> instructions: mffsce, mffscdrn, mffscdrni, mffscrn, mffscrni, mffsl.
> This patch adds support for 'mffsce' instruction.
>
> 'mffsce' is identical t
Richard Henderson writes:
> On 9/11/19 5:26 AM, Alex Bennée wrote:
>>
>> Aleksandar Markovic writes:
>>
>>> 10.09.2019. 21.34, "Alex Bennée" је написао/ла:
This is preparatory for plugins which will want to report the
architecture to plugins. Move the ELF_ARCH definition out of
Richard Henderson writes:
> On 9/13/19 9:49 AM, Alex Bennée wrote:
>> +/* must be built with -O2 to generate fused op */
>> +r = a * b + c;
>
> I would prefer to use fmaf() or __builtin_fmaf() here.
>
> Although you'll need to link with -lm just in case t
On 9/14/19 1:59 PM, Alex Bennée wrote:
>
> Richard Henderson writes:
>
>> On 9/13/19 9:49 AM, Alex Bennée wrote:
>>> +/* must be built with -O2 to generate fused op */
>>> +r = a * b + c;
>>
>> I would prefer to use fmaf() or __builtin_fmaf() here.
>>
>> A
On 9/11/19 4:20 AM, Alex Bennée wrote:
> Alex Bennée writes:
>
>> Lets keep all the Elf manipulation bits together. Also rename the file
>> to better reflect how it is used and add a little header to the file.
>>
>> Signed-off-by: Alex Bennée
>> ---
>> hw/core/loader.c
On 9/10/19 3:34 PM, Alex Bennée wrote:
> Most of the users of elf.h just want the standard Elf definitions. The
> couple that want more than that want an expansion based on ELF_CLASS
> which can be used for size agnostic code. The later is moved into
> elf/elf-types.inc.h to make it clearer what it
On 9/14/19 1:51 PM, Alex Bennée wrote:
> I think I'm going to stick with the gross TARGET for now. It mostly
> seems a way of avoiding building per-arch plugins. I assume most out of
> tree plugins will be targeted at a specific machine anyway.
Ok.
> Anyway I think that means I'll drop this serie
You neglected to cc: the maintainer (me). I spotted this anyway, more
or less by chance. Next time, please use scripts/get_maintainer.pl to
find people you might want to cc:.
Cyrill Gorcunov writes:
> We already have error_report_once and warn_report_once,
> thus lets add info_report_once to c
On Sat, Sep 14, 2019 at 08:40:40PM +0200, Markus Armbruster wrote:
> You neglected to cc: the maintainer (me). I spotted this anyway, more
> or less by chance. Next time, please use scripts/get_maintainer.pl to
> find people you might want to cc:.
Ah, sorry for that. Will do next time, thanks!
On Fri, 13 Sep 2019 08:25:21 PDT (-0700), bmeng...@gmail.com wrote:
Hi Palmer,
On Fri, Sep 13, 2019 at 10:33 PM Palmer Dabbelt wrote:
On Fri, 06 Sep 2019 09:20:05 PDT (-0700), bmeng...@gmail.com wrote:
> It is not useful if we only have one management CPU.
>
> Signed-off-by: Bin Meng
> Revie
On Fri, Sep 13, 2019 at 11:47:46PM +, Wei Yang wrote:
> On Tue, Jul 30, 2019 at 08:37:38AM +0800, Wei Yang wrote:
> >When we iterate the memory-device list to get the available range, it is not
> >necessary to iterate the whole list.
> >
> >1) no more overlap for hinted range if tmp exceed it
>
Greg Kurz writes:
> Option parsing fonctions are called with &error_fatal, which
functions
> causes error_setg() to call exit() and the hints are never
> printed.
>
> Use an intermediate error object so that exit() happens in
> error_propagate() after error_append_hint() could be called.
Hmm.
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1843133
Title:
Possibly incorrect branch in qemu-system-hppa
Status in QEMU:
Incomplete
Bug de
On Fri, 23 Aug 2019 16:38:21 PDT (-0700), Alistair Francis wrote:
Signed-off-by: Alistair Francis
---
target/riscv/cpu_helper.c | 21 ++---
1 file changed, 18 insertions(+), 3 deletions(-)
diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c
index 41d4368128..afb3
On Fri, 23 Aug 2019 16:38:23 PDT (-0700), Alistair Francis wrote:
To ensure our TLB isn't out-of-date we flush it on all virt mode
changes. Unlike priv mode this isn't saved in the mmu_idx as all
guests share V=1. The easiest option is just to flush on all changes.
Signed-off-by: Alistair Franci
On Fri, 23 Aug 2019 16:38:29 PDT (-0700), Alistair Francis wrote:
When the PLIC generates an interrupt ensure we always set it for the SIP
CSR that corresponds to the HS (V=0) register.
Signed-off-by: Alistair Francis
---
hw/riscv/sifive_plic.c | 12 +++-
1 file changed, 11 insertions(
On Fri, 23 Aug 2019 16:38:26 PDT (-0700), Alistair Francis wrote:
Signed-off-by: Alistair Francis
---
target/riscv/op_helper.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/target/riscv/op_helper.c b/target/riscv/op_helper.c
index d150551bc9..beb34e705b 100644
--- a/t
This test case works for me.
$ ./hppa-linux-user/qemu-hppa ~/a.out
$ echo $?
0
>From -d in_asm,cpu logs:
IN: main
0x000112d0: addb,*<,n r24,r23,0x112e4
IA_F 000112d3 IA_B 000112d7
PSW bf00 CB --
GR00 GR01 GR02 0001162b GR03 ff7fe9c0
GR04 00011b
This dependency is currently "automagic", which is bad for distributions.
Signed-off-by: James Le Cuirot
---
configure | 5 +
1 file changed, 5 insertions(+)
diff --git a/configure b/configure
index 30aad233d1..30544f52e6 100755
--- a/configure
+++ b/configure
@@ -1521,6 +1521,10 @@ for opt
On 2019-09-12 12:20, Gerd Hoffmann wrote:
On Sun, Sep 08, 2019 at 11:22:00PM +0200, Kővágó, Zoltán wrote:
Hi,
This is the v2 of my patch series that makes mixeng optional and enables
more than two audio channels.
Changes from v1:
* renamed "mixeng" option to "mixing-engine"
* dropped patch "a
[Expired for QEMU because there has been no activity for 60 days.]
** Changed in: qemu
Status: Incomplete => Expired
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1836430
Title:
Can't insta
49 matches
Mail list logo
