Re: [Qemu-devel] [PATCH v2 4/4] audio: paaudio: ability to specify stream name

2019-09-10 Thread Gerd Hoffmann
> Ping. > > If I understand the situation correctly, the current consensus is: > > * use VM name for PA server connection Yes (most important one IMHO). > * audiodev id is a good default for PA stream name Yes. > What is not clear whether we need a separate qapi option for stream name, or > j

Re: [Qemu-devel] [PATCH] ahci: enable pci bus master MemoryRegion before loading ahci engines

2019-09-10 Thread Michael S. Tsirkin
On Tue, Sep 10, 2019 at 01:18:37AM +0800, andychiu wrote: > If Windows 10 guests have enabled 'turn off hard disk after idle' > option in power settings, and the guest has a SATA disk plugged in, > the SATA disk will be turned off after a specified idle time. > If the guest is live migrated or save

Re: [Qemu-devel] [PATCH v2 00/16] qapi: Schema language cleanups & doc improvements

2019-09-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190910063724.28470-1-arm...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v2 00/16] qapi: Schema language cleanups & doc improvements Message-id: 20190910063724.

[Qemu-devel] [PATCH] qemu-io: Don't leak pattern file in error path

2019-09-10 Thread Kevin Wolf
qemu_io_alloc_from_file() needs to close the pattern file even if some error occurred. Setting f = NULL in the success path and checking it for NULL in the error path isn't strictly necessary at this point, but let's do it anyway in case someone later adds a 'goto error' after closing the file. C

[Qemu-devel] [PATCH v1 0/3] add Homer/OCC common area emulation for PowerNV

2019-09-10 Thread Balamuruhan S
Hi All, This is follow-up patch that implements HOMER and OCC SRAM device models to emulate homer memory and occ common area access for pstate table, occ sensors, runtime data and slw. This version addresses review comments in previous patchset and breaks it to have separate patch series for Home

[Qemu-devel] [PATCH v1 2/3] hw/ppc/pnv_occ: add sram device model for occ common area

2019-09-10 Thread Balamuruhan S
emulate occ common area region with occ sram device model which occ and skiboot uses it to communicate regarding sensors, slw and HWMON in PowerNV emulated host. Signed-off-by: Balamuruhan S --- hw/ppc/pnv.c | 8 + hw/ppc/pnv_occ.c | 78 ++

[Qemu-devel] [PATCH v1 1/3] hw/ppc/pnv_xscom: retrieve homer/occ base address from PBA BARs

2019-09-10 Thread Balamuruhan S
During PowerNV boot skiboot populates the device tree by retrieving base address of homer/occ common area from PBA BARs and prd ipoll mask by accessing xscom read/write accesses. Signed-off-by: Balamuruhan S --- hw/ppc/pnv_xscom.c | 34 ++ include/hw/ppc/pnv.h |

[Qemu-devel] [PATCH v1 3/3] hw/ppc/pnv_homer: add PowerNV homer device model

2019-09-10 Thread Balamuruhan S
add PnvHOMER device model to emulate homer memory access for pstate table, occ-sensors, slw, occ static and dynamic values for Power8 and Power9 chips. Fix few coding style warnings given by checkpatch.pl. Signed-off-by: Balamuruhan S --- hw/ppc/Makefile.objs | 1 + hw/ppc/pnv.c

Re: [Qemu-devel] [PATCH v1 1/3] hw/ppc/pnv_xscom: retrieve homer/occ base address from PBA BARs

2019-09-10 Thread Cédric Le Goater
On 10/09/2019 09:10, Balamuruhan S wrote: > During PowerNV boot skiboot populates the device tree by > retrieving base address of homer/occ common area from > PBA BARs and prd ipoll mask by accessing xscom read/write > accesses. > > Signed-off-by: Balamuruhan S LGTM, Reviewed-by: Cédric Le Goat

Re: [Qemu-devel] [PATCH v1 2/3] hw/ppc/pnv_occ: add sram device model for occ common area

2019-09-10 Thread Cédric Le Goater
On 10/09/2019 09:10, Balamuruhan S wrote: > emulate occ common area region with occ sram device model which > occ and skiboot uses it to communicate regarding sensors, slw > and HWMON in PowerNV emulated host. > > Signed-off-by: Balamuruhan S > --- > hw/ppc/pnv.c | 8 + > hw/ppc

Re: [Qemu-devel] [PULL v2 01/16] qemu-io: add pattern file for write command

2019-09-10 Thread Max Reitz
On 09.09.19 19:26, Peter Maydell wrote: > On Tue, 3 Sep 2019 at 14:35, Max Reitz wrote: >> >> From: Denis Plotnikov >> >> The patch allows to provide a pattern file for write >> command. There was no similar ability before. >> >> Signed-off-by: Denis Plotnikov >> Message-id: 20190820164616.4072-

Re: [Qemu-devel] [PATCH] ahci: enable pci bus master MemoryRegion before loading ahci engines

2019-09-10 Thread Andy via Qemu-devel
Hi John, Sorry I'm re-sending this mail due to format issue in the last one. This issue can only be reproduced on Windows 10. I've observed and compared the behavior of Windows 10 and Windows 7. It seems Windows 7 wouldn't disable the PCI_COMMAND_MASTER flag when disabling ahci devices. That's w

Re: [Qemu-devel] DMARC/DKIM and qemu-devel list settings

2019-09-10 Thread Stefan Hajnoczi
On Wed, Sep 4, 2019 at 4:30 PM Peter Maydell wrote: > > On Tue, 3 Sep 2019 at 20:11, Ian Kelling wrote: > > I don't know who has the Qemu-devel list admin password, but whoever has > > it can adopt the unmodified message fix by changing > > dmarc_moderation_action to Accept here: > > https://list

Re: [Qemu-devel] [Qemu-block] [PULL v2 01/16] qemu-io: add pattern file for write command

2019-09-10 Thread Kevin Wolf
Am 10.09.2019 um 09:19 hat Max Reitz geschrieben: > On 09.09.19 19:26, Peter Maydell wrote: > > On Tue, 3 Sep 2019 at 14:35, Max Reitz wrote: > >> > >> From: Denis Plotnikov > >> > >> The patch allows to provide a pattern file for write > >> command. There was no similar ability before. > >> > >>

Re: [Qemu-devel] [PATCH v10 04/14] block/backup: introduce BlockCopyState

2019-09-10 Thread Max Reitz
On 09.09.19 17:11, Vladimir Sementsov-Ogievskiy wrote: > 09.09.2019 17:24, Max Reitz wrote: >> On 09.09.19 16:12, Vladimir Sementsov-Ogievskiy wrote: >>> 09.09.2019 15:59, Max Reitz wrote: On 30.08.19 18:12, Vladimir Sementsov-Ogievskiy wrote: > Split copying code part from backup to "bloc

Re: [Qemu-devel] [PATCH] qemu-io: Don't leak pattern file in error path

2019-09-10 Thread Max Reitz
On 10.09.19 09:09, Kevin Wolf wrote: > qemu_io_alloc_from_file() needs to close the pattern file even if some > error occurred. > > Setting f = NULL in the success path and checking it for NULL in the > error path isn't strictly necessary at this point, but let's do it > anyway in case someone lat

Re: [Qemu-devel] [PATCH v1 3/3] hw/ppc/pnv_homer: add PowerNV homer device model

2019-09-10 Thread Cédric Le Goater
On 10/09/2019 09:10, Balamuruhan S wrote: > add PnvHOMER device model to emulate homer memory access > for pstate table, occ-sensors, slw, occ static and dynamic > values for Power8 and Power9 chips. Fix few coding style > warnings given by checkpatch.pl. These are valid changes. I would have put

Re: [Qemu-devel] [Qemu-block] [PATCH 2/6] curl: Keep *socket until the end of curl_sock_cb()

2019-09-10 Thread Max Reitz
On 09.09.19 22:09, John Snow wrote: > > > On 8/27/19 12:34 PM, Max Reitz wrote: >> This does not really change anything, but it makes the code a bit easier >> to follow once we use @socket as the opaque pointer for >> aio_set_fd_handler(). >> >> (Also, this change stops us from creating new CURLS

Re: [Qemu-devel] [Qemu-block] [PATCH 3/6] curl: Pass CURLSocket to curl_multi_{do, read}()

2019-09-10 Thread Max Reitz
On 09.09.19 22:10, John Snow wrote: > > > On 8/27/19 12:34 PM, Max Reitz wrote: >> curl_multi_do_locked() currently marks all sockets as ready. That is >> not only inefficient, but in fact unsafe (the loop is). A follow-up >> patch will change that, but to do so, curl_multi_do_locked() needs to

Re: [Qemu-devel] [Qemu-block] [PATCH 4/6] curl: Report only ready sockets

2019-09-10 Thread Max Reitz
On 09.09.19 22:16, John Snow wrote: > > > On 8/27/19 12:34 PM, Max Reitz wrote: >> Instead of reporting all sockets to cURL, only report the one that has >> caused curl_multi_do_locked() to be called. This lets us get rid of the >> QLIST_FOREACH_SAFE() list, which was actually wrong: SAFE foreac

Re: [Qemu-devel] [PULL 1/9] qapi: Add InetSocketAddress member keep-alive

2019-09-10 Thread Vladimir Sementsov-Ogievskiy
09.09.2019 20:32, Peter Maydell wrote: > On Thu, 15 Aug 2019 at 19:34, Eric Blake wrote: >> >> From: Vladimir Sementsov-Ogievskiy >> >> It's needed to provide keepalive for nbd client to track server >> availability. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> Message-Id: <2019072509493

Re: [Qemu-devel] [Qemu-block] [PULL v2 01/16] qemu-io: add pattern file for write command

2019-09-10 Thread Denis Plotnikov
On 10.09.2019 10:23, Kevin Wolf wrote: > Am 10.09.2019 um 09:19 hat Max Reitz geschrieben: >> On 09.09.19 19:26, Peter Maydell wrote: >>> On Tue, 3 Sep 2019 at 14:35, Max Reitz wrote: From: Denis Plotnikov The patch allows to provide a pattern file for write command. There was

[Qemu-devel] [PATCH] util/qemu-sockets: fix keep_alive handling in inet_connect_saddr

2019-09-10 Thread Vladimir Sementsov-Ogievskiy
In "if (saddr->keep_alive) {" we may already be on error path, with invalid sock < 0. Fix it by returning error earlier. Reported-by: Coverity (CID 1405300) Suggested-by: Peter Maydell Signed-off-by: Vladimir Sementsov-Ogievskiy --- util/qemu-sockets.c | 5 +++-- 1 file changed, 3 insertions(+)

Re: [Qemu-devel] [PATCH] util/qemu-sockets: fix keep_alive handling in inet_connect_saddr

2019-09-10 Thread Daniel P . Berrangé
On Tue, Sep 10, 2019 at 10:59:43AM +0300, Vladimir Sementsov-Ogievskiy wrote: > In "if (saddr->keep_alive) {" we may already be on error path, with > invalid sock < 0. Fix it by returning error earlier. > > Reported-by: Coverity (CID 1405300) > Suggested-by: Peter Maydell > Signed-off-by: Vladimi

Re: [Qemu-devel] [PULL 1/9] qapi: Add InetSocketAddress member keep-alive

2019-09-10 Thread Peter Maydell
On Tue, 10 Sep 2019 at 08:56, Vladimir Sementsov-Ogievskiy wrote: > > 09.09.2019 20:32, Peter Maydell wrote: > > On Thu, 15 Aug 2019 at 19:34, Eric Blake wrote: > >> > >> From: Vladimir Sementsov-Ogievskiy > >> > >> It's needed to provide keepalive for nbd client to track server > >> availabilit

Re: [Qemu-devel] [PATCH v10 04/14] block/backup: introduce BlockCopyState

2019-09-10 Thread Vladimir Sementsov-Ogievskiy
10.09.2019 10:42, Max Reitz wrote: > On 09.09.19 17:11, Vladimir Sementsov-Ogievskiy wrote: >> 09.09.2019 17:24, Max Reitz wrote: >>> On 09.09.19 16:12, Vladimir Sementsov-Ogievskiy wrote: 09.09.2019 15:59, Max Reitz wrote: > On 30.08.19 18:12, Vladimir Sementsov-Ogievskiy wrote: >> Sp

[Qemu-devel] [PATCH v1] gdbstub: riscv: fix the fflags registers

2019-09-10 Thread KONRAD Frederic
While debugging an application with GDB the following might happen: (gdb) return Make xxx return now? (y or n) y Could not fetch register "fflags"; remote failure reply 'E14' This is because riscv_gdb_get_fpu calls riscv_csrrw_debug with a wrong csr number (8). It should use the csr_register_map

Re: [Qemu-devel] [PATCH] linux-user: add memfd_create

2019-09-10 Thread Laurent Vivier
Le 16/08/2019 à 23:10, Shu-Chun Weng via Qemu-devel a écrit : > Add support for the memfd_create syscall. If the host does not have the > libc wrapper, translate to a direct syscall with NC-macro. > > Buglink: https://bugs.launchpad.net/qemu/+bug/1734792 > Signed-off-by: Shu-Chun Weng > --- > in

Re: [Qemu-devel] [Qemu-block] [PATCH 5/6] curl: Handle success in multi_check_completion

2019-09-10 Thread Max Reitz
On 09.09.19 22:30, John Snow wrote: > > > On 8/27/19 12:34 PM, Max Reitz wrote: >> Background: As of cURL 7.59.0, it verifies that several functions are >> not called from within a callback. Among these functions is >> curl_multi_add_handle(). >> >> curl_read_cb() is a callback from cURL and not

Re: [Qemu-devel] [PATCH 0/2] linux-user/arm: Adjust MAX_RESERVED_VA for M-profile

2019-09-10 Thread Laurent Vivier
Le 03/09/2019 à 15:35, Peter Maydell a écrit : > On Thu, 22 Aug 2019 at 19:59, Richard Henderson > wrote: >> >> This is inspired by the discussion in >> >>https://bugs.launchpad.net/qemu/+bug/1840922 >> >> Previously I suggested a new CPUClass hook, but when I went >> to implement that seemed

Re: [Qemu-devel] [Qemu-block] [PATCH] block/backup: install notifier during creation

2019-09-10 Thread Stefan Hajnoczi
On Wed, Aug 21, 2019 at 04:01:52PM -0400, John Snow wrote: > > > On 8/21/19 10:41 AM, Vladimir Sementsov-Ogievskiy wrote: > > 09.08.2019 23:13, John Snow wrote: > >> Backup jobs may yield prior to installing their handler, because of the > >> job_co_entry shim which guarantees that a job won't be

Re: [Qemu-devel] [PATCH] linux-user: Support gdb 'qOffsets' query for ELF

2019-09-10 Thread Laurent Vivier
Le 17/08/2019 à 01:34, Josh Kunz via Qemu-devel a écrit : > This is needed to support debugging PIE ELF binaries running under QEMU > user mode. Currently, `code_offset` and `data_offset` remain unset for > all ELF binaries, so GDB is unable to correctly locate the position of > the binary's text a

Re: [Qemu-devel] [PATCH v4] target/xtensa: linux-user: add call0 ABI support

2019-09-10 Thread Laurent Vivier
Le 06/09/2019 à 18:57, Max Filippov a écrit : > Xtensa binaries built for call0 ABI don't rotate register window on > function calls and returns. Invocation of signal handlers from the > kernel is therefore different in windowed and call0 ABIs. > There's currently no way to determine xtensa ELF bin

Re: [Qemu-devel] [PATCH] linux-user: drop redundant handling of environment variables

2019-09-10 Thread Laurent Vivier
Le 06/09/2019 à 18:57, Max Filippov a écrit : > QEMU_STRACE and QEMU_RAND_SEED are handled by the parse_args, no need to > do it again in main. > > Signed-off-by: Max Filippov > --- > linux-user/main.c | 7 --- > 1 file changed, 7 deletions(-) > > diff --git a/linux-user/main.c b/linux-user

Re: [Qemu-devel] [PATCH v2 1/2] linux-user: remove useless variable

2019-09-10 Thread Laurent Vivier
Le 08/09/2019 à 12:48, Laurent Vivier a écrit : > filename is only used to open the file if AT_EXECFD is not provided. > But exec_path already contains the path of the file to open. > Remove filename as it is only used in main.c whereas exec_path is > also used in syscall.c. > > Fixes: d088d664f20

Re: [Qemu-devel] [PATCH v6 3/8] linux-user/strace: Improve settimeofday()

2019-09-10 Thread Laurent Vivier
Le 08/09/2019 à 08:15, Philippe Mathieu-Daudé a écrit : > Signed-off-by: Philippe Mathieu-Daudé > Tested-By: Guido Günther > Reviewed-by: Laurent Vivier > --- > linux-user/strace.c| 13 + > linux-user/strace.list | 2 +- > 2 files changed, 14 insertions(+), 1 deletion(-) > > d

Re: [Qemu-devel] [PATCH] Fedora images: use URLs from stable "archives.fedoraproject.org"

2019-09-10 Thread Peter Maydell
On Wed, 4 Sep 2019 at 01:52, Cleber Rosa wrote: > > The LinuxInitrd.test_with_2gib_file_should_work_with_linux_v4_16 test, > from tests/acceptance/linux_initrd.py, is currently failing to fetch > the "vmlinuz" file. The reason for the failure is that the Fedora > project retires older versions fr

Re: [Qemu-devel] [PATCH v6 2/8] linux-user: Add support for RNDRESEEDCRNG ioctl

2019-09-10 Thread Laurent Vivier
Le 04/09/2019 à 14:59, Aleksandar Markovic a écrit : > From: Aleksandar Markovic > > RNDRESEEDCRNG is a newer ioctl (added in kernel 4.17), and an > "ifdef" guard is used for that reason in this patch. > > Signed-off-by: Aleksandar Markovic > Reviewed-by: Laurent Vivier > --- > linux-user/ioc

Re: [Qemu-devel] [PATCH v6 3/8] linux-user: Add support for FIOGETOWN and FIOSETOWN ioctls

2019-09-10 Thread Laurent Vivier
Le 04/09/2019 à 14:59, Aleksandar Markovic a écrit : > From: Aleksandar Markovic > > FIOGETOWN and FIOSETOWN ioctls have platform-specific definitions, > hence non-standard definition in QEMU too. > > Other than that, they both have a single integer argument, and their > functionality is emulate

[Qemu-devel] ANNOUNCE: emails from this mailing list will soon drop the [qemu-*] subject tag

2019-09-10 Thread Peter Maydell
Hi; this is an announcement to let you know that in future emails to all QEMU project mailing lists (including this one) will no longer have the [qemu-*] tag in their Subject line. We need to make this config change because having the mailing list server edit subject lines like this conflicts with

Re: [Qemu-devel] [PATCH] Fedora images: use URLs from stable "archives.fedoraproject.org"

2019-09-10 Thread Peter Maydell
On Tue, 10 Sep 2019 at 09:31, Peter Maydell wrote: > > On Wed, 4 Sep 2019 at 01:52, Cleber Rosa wrote: > > > > The LinuxInitrd.test_with_2gib_file_should_work_with_linux_v4_16 test, > > from tests/acceptance/linux_initrd.py, is currently failing to fetch > > the "vmlinuz" file. The reason for th

Re: [Qemu-devel] [PATCH v6 4/8] linux user: Add support for FDFLUSH ioctl

2019-09-10 Thread Laurent Vivier
Le 04/09/2019 à 14:59, Aleksandar Markovic a écrit : > From: Yunqiang Su > > FDFLUSH is used for flushing buffers of floppy drives. Support in > QEMU is needed because some of Debian packages use this ioctl while > running post-build tests. One such example is 'tar' package. > > Signed-off-by: Y

Re: [Qemu-devel] [PATCH v10 04/14] block/backup: introduce BlockCopyState

2019-09-10 Thread Max Reitz
On 10.09.19 10:12, Vladimir Sementsov-Ogievskiy wrote: > 10.09.2019 10:42, Max Reitz wrote: >> On 09.09.19 17:11, Vladimir Sementsov-Ogievskiy wrote: >>> 09.09.2019 17:24, Max Reitz wrote: On 09.09.19 16:12, Vladimir Sementsov-Ogievskiy wrote: > 09.09.2019 15:59, Max Reitz wrote: >> On

Re: [Qemu-devel] [PATCH v6 5/8] linux-user: Add support for FDMSGON and FDMSGOFF ioctls

2019-09-10 Thread Laurent Vivier
Le 04/09/2019 à 14:59, Aleksandar Markovic a écrit : > From: Aleksandar Markovic > > FDMSGON and FDMSGOFF switch informational messages of floppy drives > on and off. > > Signed-off-by: Aleksandar Markovic > Reviewed-by: Laurent Vivier > --- > linux-user/ioctls.h | 2 ++ > linux-user/sy

Re: [Qemu-devel] [PATCH v6 6/8] linux-user: Add support for FDRESET, FDRAWCMD, FDTWADDLE, and FDEJECT ioctls

2019-09-10 Thread Laurent Vivier
Le 04/09/2019 à 14:59, Aleksandar Markovic a écrit : > From: Aleksandar Markovic > > FDRESET, FDRAWCMD, FDTWADDLE, and FDEJECT ioctls are misc commands > for controlling a floppy drive. > > Signed-off-by: Aleksandar Markovic > --- > linux-user/ioctls.h | 4 > linux-user/syscall_defs

[Qemu-devel] [PULL 01/45] hw/misc: Mark most objects as "common" code to speed up compilation a litte bit

2019-09-10 Thread Alex Bennée
From: Thomas Huth Most of the code in hw/misc/ does not directly depend on CPU-specific code. Mark it as "common" so that the code can be shared between e.g. qemu-system-arm and qemu-system-aarch64, or between the various mips flavours, instead of recompiling it for each and every target again an

[Qemu-devel] [PULL 02/45] configure: clean-up container cross compile detect

2019-09-10 Thread Alex Bennée
The introduction of podman support inadvertently broke configure's detect of the container support as the configure probe didn't specify an engine type. To fix this in docker.py: - only (re)set USE_ENGINE if --engine is specified - enhance the output so docker is no longer just yes In the con

Re: [Qemu-devel] [PATCH v2 2/3] iotests: add protocol support to initialization info

2019-09-10 Thread Max Reitz
On 09.09.19 20:45, John Snow wrote: > > > On 9/9/19 6:09 AM, Max Reitz wrote: >> On 29.07.19 23:35, John Snow wrote: >>> This will add supported_protocols and unsupported_protocols to all of >>> iotests.main, iotests.script_main, and iotests.script_initialize. >>> >>> Signed-off-by: John Snow >>

Re: [Qemu-devel] [PATCH v2 1/3] iotests: add script_initialize

2019-09-10 Thread Max Reitz
On 09.09.19 20:25, John Snow wrote: > > > On 9/9/19 6:06 AM, Max Reitz wrote: >> On 29.07.19 23:35, John Snow wrote: >>> Like script_main, but doesn't require a single point of entry. >>> Replace all existing initialization sections with this drop-in replacement. >>> >>> This brings debug support

[Qemu-devel] [PULL 18/45] tests/docker: move our m68k cross compile to Buster

2019-09-10 Thread Alex Bennée
Now Buster is released we can stop relying on the movable feast that is Sid for our cross-compiler for building tests. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include ind

[Qemu-devel] [PULL 00/45] testing updates (fixes, upgrades, caching)

2019-09-10 Thread Alex Bennée
The following changes since commit 89ea03a7dc83ca36b670ba7f787802791fcb04b1: Merge remote-tracking branch 'remotes/huth-gitlab/tags/m68k-pull-2019-09-07' into staging (2019-09-09 09:48:34 +0100) are available in the Git repository at: https://github.com/stsquad/qemu.git tags/pull-testing-ne

[Qemu-devel] [PULL 04/45] tests/docker: fix "cc" command to work with podman

2019-09-10 Thread Alex Bennée
Podman requires a little bit of additional magic to the uid mapping which was already done for the normal RunCommand. We simplify the logic by pushing it directly into the Docker::run method to avoid instantiating an extra Docker() object and ensure the CC command always runs as the current user.

Re: [Qemu-devel] [PATCH] Fedora images: use URLs from stable "archives.fedoraproject.org"

2019-09-10 Thread Daniel P . Berrangé
On Tue, Sep 03, 2019 at 08:52:18PM -0400, Cleber Rosa wrote: > The LinuxInitrd.test_with_2gib_file_should_work_with_linux_v4_16 test, > from tests/acceptance/linux_initrd.py, is currently failing to fetch > the "vmlinuz" file. The reason for the failure is that the Fedora > project retires older v

[Qemu-devel] [PULL 05/45] tests/docker: handle missing encoding keyword for subprocess.check_output

2019-09-10 Thread Alex Bennée
This was only added in Python 3.6 and not all the build hosts have that recent a python3. However we still need to ensure everything is returns as a unicode string so checks higher up the call chain don't barf. Signed-off-by: Alex Bennée fixup! tests/docker: handle missing encoding keyword for s

[Qemu-devel] [PULL 13/45] tests/docker: add Buster to DOCKER_PARTIAL_IMAGES

2019-09-10 Thread Alex Bennée
We need to add additional packages to the base images to be able to build QEMU so lets avoid building with it. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index cf535cbd196..89881fb5f5d 100644 --- a/te

[Qemu-devel] [PULL 10/45] tests/tcg: add .gitignore for in source builds

2019-09-10 Thread Alex Bennée
This hides the new build artefacts from the re-organised TCG tests when you are doing an in-source build. Signed-off-by: Alex Bennée diff --git a/tests/tcg/.gitignore b/tests/tcg/.gitignore new file mode 100644 index 000..84d7541b286 --- /dev/null +++ b/tests/tcg/.gitignore @@ -0,0 +1,5

[Qemu-devel] [PULL 03/45] tests/docker: Use --userns=keep-id for podman

2019-09-10 Thread Alex Bennée
From: John Snow The workaround that attempts to accomplish the same result as --userns=keep-id does not appear to work well with UIDs much above 1000 (like mine, which is above 2.) Since we have official support for this "trick" now, use the supported method. Signed-off-by: John Snow Messa

[Qemu-devel] [PULL 07/45] tests/tcg: use EXTRA_CFLAGS everywhere

2019-09-10 Thread Alex Bennée
From: Paolo Bonzini For i386 specifically, this allows using the host GCC to compile the i386 tests. But, it should really be done for all targets, unless we want to pass $(EXTRA_CFLAGS) directly as part of $(CC). Signed-off-by: Paolo Bonzini Message-Id: <20190807143523.15917-2-pbonz...@redhat

[Qemu-devel] [PULL 19/45] tests/docker: move our sparc64 cross compile to Buster

2019-09-10 Thread Alex Bennée
Now Buster is released we can stop relying on the movable feast that is Sid for our cross-compiler for building tests. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include ind

[Qemu-devel] [PULL 08/45] tests/tcg: cleanup Makefile inclusions

2019-09-10 Thread Alex Bennée
From: Paolo Bonzini Rename Makefile.probe to Makefile.prereqs and make it actually define rules for the tests. Rename Makefile to Makefile.target, since it is not a toplevel makefile. Rename Makefile.include to Makefile.qemu and disentangle it from the QEMU Makefile.target, so that it is invoke

[Qemu-devel] [PULL 06/45] tests/docker: fix final missing .encode when parsing solibs

2019-09-10 Thread Alex Bennée
Signed-off-by: Alex Bennée diff --git a/tests/docker/docker.py b/tests/docker/docker.py index 417b0cdce13..29613afd489 100755 --- a/tests/docker/docker.py +++ b/tests/docker/docker.py @@ -111,7 +111,7 @@ def _get_so_libs(executable): libs = [] ldd_re = re.compile(r"(/.*/)(\S*)") tr

[Qemu-devel] [PULL 15/45] tests/docker: move our powerpc cross compile to Buster

2019-09-10 Thread Alex Bennée
Now Buster is released we can stop relying on the movable feast that is Sid for our cross-compiler for building tests. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include ind

[Qemu-devel] [PULL 44/45] Fedora images: use URLs from stable "archives.fedoraproject.org"

2019-09-10 Thread Alex Bennée
From: Cleber Rosa The LinuxInitrd.test_with_2gib_file_should_work_with_linux_v4_16 test, from tests/acceptance/linux_initrd.py, is currently failing to fetch the "vmlinuz" file. The reason for the failure is that the Fedora project retires older versions from the "dl.fedoraproject.org" URL, and

[Qemu-devel] [PULL 09/45] tests/tcg: move configuration to a sub-shell script

2019-09-10 Thread Alex Bennée
From: Paolo Bonzini Avoid the repeated inclusions of config-target.mak, which have risks of namespace pollution, and instead build minimal configuration files in a configuration script. The same configuration files can also be included in Makefile and Makefile.qemu Signed-off-by: Paolo Bonzini

[Qemu-devel] [PULL 16/45] tests/docker: move our Alpha cross compile to Buster

2019-09-10 Thread Alex Bennée
Now Buster is released we can stop relying on the movable feast that is Sid for our cross-compiler for building tests. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include ind

[Qemu-devel] [PULL 14/45] tests/docker: move our arm64 cross compile to Buster

2019-09-10 Thread Alex Bennée
Now Buster is released we can unify our cross build images for both QEMU and tests. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index 89881fb5f5d..48c22ae40c0 100644

[Qemu-devel] [PULL 37/45] .travis.yml: Cache Avocado cache

2019-09-10 Thread Alex Bennée
From: Philippe Mathieu-Daudé Avocado tests download artifacts from various sources. These sources sometime have network issues resulting in build failures. Cache Avocado cache to reduce build failure. See https://docs.travis-ci.com/user/caching/#arbitrary-directories Signed-off-by: Philippe Mat

[Qemu-devel] [PULL 32/45] tests/docker: --disable-libssh on ubuntu1804 builds

2019-09-10 Thread Alex Bennée
Currently this stops the mega: make docker-test-build from working. Once the source is patched to deal with the case this workaround can be removed. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé diff --git a/tests/docker/dockerfiles/ubuntu1804.docker b/tests/docker/dockerf

[Qemu-devel] [PULL 21/45] tests/docker: move our mips64 cross compile to Buster

2019-09-10 Thread Alex Bennée
Now Buster is released we can stop relying on the movable feast that is Sid for our cross-compiler for building tests. Signed-off-by: Alex Bennée Reviewed-by: Aleksandar Markovic Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé diff --git a/tests/docker/Makefile.include b

Re: [Qemu-devel] [PATCH v13 6/6] migration: Include migration support for machine check handling

2019-09-10 Thread Greg Kurz
Hi Aravinda, Sorry for not being able to review the whole series in one pass, and thus forcing you to poste more versions... but I have some more remarks about migration. On Mon, 09 Sep 2019 12:55:02 +0530 Aravinda Prasad wrote: > This patch includes migration support for machine check > handli

[Qemu-devel] [PULL 22/45] tests/docker: move our riscv64 cross compile to Buster

2019-09-10 Thread Alex Bennée
Now Buster is released we can stop relying on the movable feast that is Sid for our cross-compiler for building tests. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include ind

[Qemu-devel] [PULL 34/45] .travis.yml: Enable multiple caching features

2019-09-10 Thread Alex Bennée
From: Philippe Mathieu-Daudé Using the 'multiple caching features' means explode the YAML array, thus it eases the git workflow (it is easier to move patches around). See https://docs.travis-ci.com/user/caching#enabling-multiple-caching-features Signed-off-by: Philippe Mathieu-Daudé Reviewed-b

[Qemu-devel] [PULL 27/45] tests/docker: add debian9-mxe to DEBIAN_PARTIAL_IMAGES

2019-09-10 Thread Alex Bennée
Another image that can't be used directly to build QEMU. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index c57b74903e6..27a1cc0d833 100644 --- a/tests/docker/Makefile.include +++ b/tests/docker/Makefil

[Qemu-devel] [PULL 41/45] .travis.yml: Cache Linux/GCC 'debug profile' jobs together

2019-09-10 Thread Alex Bennée
From: Philippe Mathieu-Daudé These jobs build different components but use the same host features. Put them in the same cache bucket. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée diff --git a/.travis.yml b/.travis.yml index 51c7d19c071..d2da12580f3 100644 --- a/.travis.yml

[Qemu-devel] [PULL 42/45] .travis.yml: Cache Linux/GCC 'non-debug profile' jobs together

2019-09-10 Thread Alex Bennée
From: Philippe Mathieu-Daudé These jobs build different components but use the same host features. Put them in the same cache bucket. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée diff --git a/.travis.yml b/.travis.yml index d2da12580f3..74f10d352fe 100644 --- a/.travis.yml

[Qemu-devel] [PULL 45/45] travis.yml: Install libcap-dev for testing virito-9p

2019-09-10 Thread Alex Bennée
From: Thomas Huth So far we were not testing virtio-9p in Travis yet, since we forgot to install libcap-devel. Do it now to get some more test coverage. Signed-off-by: Thomas Huth Acked-by: Greg Kurz Tested-by: Greg Kurz Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190905113346.2473-1-

[Qemu-devel] [PULL 38/45] .travis.yml: Improve ccache use

2019-09-10 Thread Alex Bennée
From: Philippe Mathieu-Daudé Per https://ccache.dev/manual/latest.html: By default, ccache tries to give as few false cache hits as possible. However, in certain situations it’s possible that you know things that ccache can’t take for granted. [The CCACHE_SLOPINESS environment variable]

[Qemu-devel] [PULL 26/45] tests/docker: add debian-xtensa-cross to DEBIAN_PARTIAL_IMAGES

2019-09-10 Thread Alex Bennée
This should have been marked when the docker recipe was added to prevent it being used for cross compiling QEMU. Sort the DEBIAN_PARTIAL_IMAGE list while we are at it. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé diff --git a/tests/docker/Mak

[Qemu-devel] [PULL 11/45] tests/docker: move DEF_TARGET_LIST setting to common.rc

2019-09-10 Thread Alex Bennée
We might as well not repeat ourselves. At the same time allow it to be overridden which we will use later from docker targets. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé diff --git a/tests/docker/common.rc b/tests/docker/common.rc index 4011561587a..512202b0a19 100755 --- a/

[Qemu-devel] [PULL 20/45] tests/docker: move our sh4 cross compile to Buster

2019-09-10 Thread Alex Bennée
Now Buster is released we can stop relying on the movable feast that is Sid for our cross-compiler for building tests. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include ind

[Qemu-devel] [PULL 30/45] tests/docker: use --arch-only for installing deps

2019-09-10 Thread Alex Bennée
The Debian QEMU packages require a bunch of cross compilers for building firmware which aren't available on all host architectures. Using --arch-only skips this particular requirement and allows us to install just the dependencies we need. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-

Re: [Qemu-devel] [PATCH v6 3/8] linux-user/strace: Improve settimeofday()

2019-09-10 Thread Laurent Vivier
Le 10/09/2019 à 10:30, Laurent Vivier a écrit : > Le 08/09/2019 à 08:15, Philippe Mathieu-Daudé a écrit : >> Signed-off-by: Philippe Mathieu-Daudé >> Tested-By: Guido Günther >> Reviewed-by: Laurent Vivier >> --- >> linux-user/strace.c| 13 + >> linux-user/strace.list | 2 +- >>

Re: [Qemu-devel] [PATCH v6 2/8] linux-user/strace: Add print_timezone()

2019-09-10 Thread Laurent Vivier
Le 08/09/2019 à 08:15, Philippe Mathieu-Daudé a écrit : > Suggested-by: Laurent Vivier > Signed-off-by: Philippe Mathieu-Daudé > --- > checkpatch error: > ERROR: storage class should be at the beginning of the declaration > --- > linux-user/strace.c | 21 + > 1 file changed,

[Qemu-devel] [PULL 12/45] tests/docker: set DEF_TARGET_LIST for some containers

2019-09-10 Thread Alex Bennée
You can assume the failures most people are interested in are the cross-compile failures that are specific to the cross compile target. Set DEF_TARGET_LIST based on what we use for shippable, the user can always override by calling with TARGET_LIST set. Signed-off-by: Alex Bennée diff --git a/te

[Qemu-devel] [PULL 33/45] configure: check if --no-pie is supported first

2019-09-10 Thread Alex Bennée
For whatever reason this doesn't trigger normally but because compile_prog uses QEMU_CFLAGS we end up trying to build a -pie --no-pie build which confuses compilers on some non-x86 hosts. Signed-off-by: Alex Bennée diff --git a/configure b/configure index 7860bbc3121..30aad233d17 100755 --- a/co

[Qemu-devel] [PULL 36/45] .travis.yml: Cache Python PIP packages

2019-09-10 Thread Alex Bennée
From: Philippe Mathieu-Daudé We always install the same packages ever and ever, cache them. See https://docs.travis-ci.com/user/caching/#pip-cache Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée diff --git a/.travis.yml b/.travis.yml index 7ae55dc41d9..0e3c2b0021c 100644 ---

[Qemu-devel] [PULL 23/45] tests/docker: move our ppc64 cross compile to Buster

2019-09-10 Thread Alex Bennée
Now Buster is released we can stop relying on the movable feast that is Sid for our cross-compiler for building tests. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include ind

[Qemu-devel] [PULL 24/45] tests/docker: update Debian Sid image

2019-09-10 Thread Alex Bennée
While we are not currently using it we might as well keep the image for later usage. So: - update to a more recent snapshot - clean up verbiage in commentary - remove duplicate shell from a merge failure Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Reviewed-by: Philippe

[Qemu-devel] [PULL 25/45] tests/docker: pin powerpc-user-cross to a snapshot

2019-09-10 Thread Alex Bennée
Now Jessie has entered LTS the powerpc architecture has been dropped so we can no longer build the image from scratch. However we can use the snapshot archive to build the last working version. This now only lives on an example of setting up a user-cross image as at least on x86-64 we can use the

[Qemu-devel] [PULL 29/45] tests/docker: add debian-amd64-cross for non-x86 hosts

2019-09-10 Thread Alex Bennée
When building on a non-x86 host we need to setup the x86 build like any other cross compiler. Signed-off-by: Alex Bennée diff --git a/.shippable.yml b/.shippable.yml index f74a3de3ffd..bbc6f88510f 100644 --- a/.shippable.yml +++ b/.shippable.yml @@ -27,6 +27,8 @@ env: TARGET_LIST=ppc64-so

[Qemu-devel] [PATCH] util/ioc.c: try to reassure Coverity about qemu_iovec_init_extended

2019-09-10 Thread Vladimir Sementsov-Ogievskiy
Make it more obvious, that filling qiov corresponds to qiov allocation, which in turn corresponds to total_niov calculation, based on mid_niov (not mid_len). Still add an assertion to show that there should be no difference. Reported-by: Coverity (CID 1405302) Suggested-by: Peter Maydell Signed-o

[Qemu-devel] [PULL 35/45] .travis.yml: Increase cache timeout from 3min to 20min

2019-09-10 Thread Alex Bennée
From: Philippe Mathieu-Daudé We are going to cache few gigabytes, increase the cache timeout to avoid build failures when uploading our cache. See https://docs.travis-ci.com/user/caching/#setting-the-timeout Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée diff --git a/.travi

[Qemu-devel] [PULL 17/45] tests/docker: move our HPPA cross compile to Buster

2019-09-10 Thread Alex Bennée
Now Buster is released we can stop relying on the movable feast that is Sid for our cross-compiler for building tests. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include ind

[Qemu-devel] [PULL 43/45] .travis.yml: Cache Linux/Clang jobs together

2019-09-10 Thread Alex Bennée
From: Philippe Mathieu-Daudé These jobs build different components but use the same host features. Put them in the same cache bucket. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée diff --git a/.travis.yml b/.travis.yml index 74f10d352fe..1ff26205795 100644 --- a/.travis.yml

[Qemu-devel] [PULL 39/45] .travis.yml: Enable ccache on OSX

2019-09-10 Thread Alex Bennée
From: Philippe Mathieu-Daudé By default, ccache is not installed on macOS environments. See https://docs.travis-ci.com/user/caching/#ccache-on-macos Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée diff --git a/.travis.yml b/.travis.yml index 7d6c63a2803..3d1c7f0d7e0 100644 -

Re: [Qemu-devel] [PULL 44/45] Fedora images: use URLs from stable "archives.fedoraproject.org"

2019-09-10 Thread Daniel P . Berrangé
On Tue, Sep 10, 2019 at 09:43:48AM +0100, Alex Bennée wrote: > From: Cleber Rosa > > The LinuxInitrd.test_with_2gib_file_should_work_with_linux_v4_16 test, > from tests/acceptance/linux_initrd.py, is currently failing to fetch > the "vmlinuz" file. The reason for the failure is that the Fedora >

[Qemu-devel] [PULL 31/45] tests/docker: add more images to PARTIAL_IMAGES when not on x86_64

2019-09-10 Thread Alex Bennée
This prevents us trying to do builds which we can't complete. Signed-off-by: Alex Bennée diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index 7df8dbe1a17..50a400b573a 100644 --- a/tests/docker/Makefile.include +++ b/tests/docker/Makefile.include @@ -106,6 +106,15 @@ d

Re: [Qemu-devel] [PULL 01/12] util/iov: introduce qemu_iovec_init_extended

2019-09-10 Thread Vladimir Sementsov-Ogievskiy
09.09.2019 20:39, Peter Maydell wrote: > On Tue, 27 Aug 2019 at 21:16, Stefan Hajnoczi wrote: >> >> From: Vladimir Sementsov-Ogievskiy >> >> Introduce new initialization API, to create requests with padding. Will >> be used in the following patch. New API uses qemu_iovec_init_buf if >> resulting

[Qemu-devel] [PULL 40/45] .travis.yml: Document how the build matrix use caches

2019-09-10 Thread Alex Bennée
From: Philippe Mathieu-Daudé We will set the CACHE_NAME variable to improve the caching of various jobs using the same characteristics. Document it first. See https://docs.travis-ci.com/user/caching/#caches-and-build-matrices Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée d

[Qemu-devel] [PULL 28/45] tests/docker: avoid $SHELL invoke bash directly

2019-09-10 Thread Alex Bennée
On some images SHELL is pointing at a limited /bin/sh which doesn't understand noprofile/norc. Given the run script is running bash just invoke it directly. This fixes: $ make docker-test-build@IMAGE DEBUG=1 [...] + echo ' ./test-build' ./test-build + echo '* Hit Ctrl-D to continue, or

  1   2   3   4   5   >