Re: [Qemu-devel] [PATCH v1 2/4] s390x/tcg: Introduce probe_read_access()

2019-08-22 Thread David Hildenbrand
On 22.08.19 00:31, Richard Henderson wrote: > On 8/21/19 2:33 PM, David Hildenbrand wrote: >>> NOTDIRTY cannot fault at all. The associated rcu critical section is ugly >>> enough to make me not want to do anything except continue to go through the >>> regular MMIO path. >>> >>> In any case, so lo

Re: [Qemu-devel] [PATCH] block: gluster: Probe alignment limits

2019-08-22 Thread Niels de Vos
On Wed, Aug 21, 2019 at 07:04:17PM +0200, Max Reitz wrote: > On 17.08.19 23:21, Nir Soffer wrote: > > Implement alignment probing similar to file-posix, by reading from the > > first 4k of the image. > > > > Before this change, provisioning a VM on storage with sector size of > > 4096 bytes would

Re: [Qemu-devel] [PATCH] vfio: fix a typo

2019-08-22 Thread Li Qiang
Chen Zhang via Qemu-devel 于2019年8月22日周四 下午2:49写道: > Signed-off-by: Chen Zhang > Reviewed-by: Li Qiang > --- > hw/vfio/pci.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c > index dc3479c..c5e6fe6 100644 > --- a/hw/vfio/pci.c > ++

[Qemu-devel] [PULL 3/8] ati-vga: Fix GPIO_MONID register write

2019-08-22 Thread Gerd Hoffmann
From: BALATON Zoltan Also update bitbang_i2c state when output bits are changed while enable bits are set. This fixes EDID access by the ATI FCode ROM. Signed-off-by: BALATON Zoltan Message-id: 292e70a92b7fbfd9a4120d433dbdcfda4e5f6c3c.1565558093.git.bala...@eik.bme.hu Signed-off-by: Gerd Hoffm

[Qemu-devel] [PULL 0/8] Vga 20190822 patches

2019-08-22 Thread Gerd Hoffmann
The following changes since commit 17dc57990320edaad52ac9ea808be9719c91cea6: Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2019-08-20' into staging (2019-08-20 14:14:20 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/vga-201

[Qemu-devel] [PULL 5/8] ati-vga: Fix hardware cursor image offset

2019-08-22 Thread Gerd Hoffmann
From: BALATON Zoltan The crtc_offset is not needed, cur_offset is relative to the start of vram not the start of displayed area. This fixes broken pointer image with MacOS that uses non-0 crtc_offset. Signed-off-by: BALATON Zoltan Message-id: e6acb1fa3ca980dc948045443e5986e2aa79bf7c.1565558093

[Qemu-devel] [PULL 4/8] ati-vga: Fix cursor color with guest_hwcursor=true

2019-08-22 Thread Gerd Hoffmann
From: BALATON Zoltan Fixes: a38127414bd007c5b6ae64c664d9e8839393277e Signed-off-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daudé Message-id: d99f9e07923a74932dbb15e93dd50aa8d2816b19.1565558093.git.bala...@eik.bme.hu Signed-off-by: Gerd Hoffmann --- hw/display/ati.c | 2 +- 1 file chang

[Qemu-devel] [PULL 7/8] ati-vga: Add limited support for big endian frame buffer aperture

2019-08-22 Thread Gerd Hoffmann
From: BALATON Zoltan Set frame buffer endianness according to requested endianness for frame buffer apertures. We set frame buffer to big endian if any of the two apertures are set to big endian. Using different endianness for the two apertures is not implemented. This fixes inverted colors with

[Qemu-devel] [PULL 1/8] ati-vga: Add registers for getting apertures

2019-08-22 Thread Gerd Hoffmann
From: BALATON Zoltan Some drivers (e.g. Linux radeon drm and MacOS) access these to find apertures to access card. Try to implement these but not sure these are correct yet. Signed-off-by: BALATON Zoltan Message-id: b2df13655feecd63c0049ec45fd87d1026f67091.1565558093.git.bala...@eik.bme.hu Sig

[Qemu-devel] [PULL 6/8] ati-vga: Attempt to handle CRTC offset not exact multiple of stride

2019-08-22 Thread Gerd Hoffmann
From: BALATON Zoltan MacOS uses non-0 offset so it needs this and the resulting vbe_start_addr seems correct but picture is still broken with OpenBIOS after FCode runs but that maybe due to firmware problems now. After boot, picture is now correct. It also occured to me that these CRTC regs are

[Qemu-devel] [PULL 2/8] ati-vga: Add some register definitions for debugging

2019-08-22 Thread Gerd Hoffmann
From: BALATON Zoltan Add names for AMCGPIO regs to make it easier to identify these in trace output. This is where rage128p has the DDC from the DVI port among others but because we don't implement the flat panel controller we don't want to connect an EDID here to make sure drivers use the VGA ou

[Qemu-devel] [PULL 8/8] ati-vga: Implement dummy VBlank IRQ

2019-08-22 Thread Gerd Hoffmann
From: BALATON Zoltan The MacOS driver exits if the card does not have an interrupt. If we set PCI_INTERRUPT_PIN to 1 then it enables VBlank interrupts and it boots but the mouse pointer cannot be moved. This patch implements a dummy VBlank interrupt triggered by a 60 Hz timer. With this the point

Re: [Qemu-devel] QEMU as ISS (Instruction Set Simulator)

2019-08-22 Thread Aleksandar Markovic
On Tue, Aug 20, 2019 at 12:12 PM 立 wrote: > I am working on a project that requires me to modify the ISA of the MIPS > target. L., How is it going? Aleksandar > I have been staring at the source code for about a week, but found it > really difficult due to me being a young rookie and the s

Re: [Qemu-devel] [PATCH] vhost-user-scsi: prevent using uninitialized vqs

2019-08-22 Thread Paolo Bonzini
On 22/08/19 06:07, Raphael Norwitz wrote: > On Fri, Jun 14, 2019 at 10:18:41AM +0100, Stefan Hajnoczi wrote: >> On Tue, Jun 11, 2019 at 05:35:17PM -0700, Raphael Norwitz wrote: >>> Of the 3 virtqueues, seabios only sets cmd, leaving ctrl >>> and event without a physical address. This can cause >>>

Re: [Qemu-devel] [SeaBIOS] Re: Regression with floppy drive controller

2019-08-22 Thread Gerd Hoffmann
On Wed, Aug 21, 2019 at 09:31:48AM -0400, Kevin O'Connor wrote: > On Wed, Aug 21, 2019 at 08:42:08AM +0200, Gerd Hoffmann wrote: > > Hi, > > > > > Using the default QEMU config, we build SeaBIOS to use the TSC timer: > > > > > > builds/seabios-128k/.config:CONFIG_TSC_TIMER=y > > > builds/seabio

Re: [Qemu-devel] [SeaBIOS] Re: Regression with floppy drive controller

2019-08-22 Thread Gerd Hoffmann
Hi, > > Is the PIT not working for some reason in the original setup? (Any > > time I attempt to run with "-M isapc" I just get an "Unable to unlock > > ram - bridge not found" error.) > > Yep, that should be no problem, with isapc the ram is not locked in > the first place. Oh, and you need

Re: [Qemu-devel] [PATCH] vfio: fix a typo

2019-08-22 Thread Philippe Mathieu-Daudé
On 8/22/19 8:49 AM, Chen Zhang via Qemu-devel wrote: > Signed-off-by: Chen Zhang > --- > hw/vfio/pci.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c > index dc3479c..c5e6fe6 100644 > --- a/hw/vfio/pci.c > +++ b/hw/vfio/pci.c > @@ -44,7

Re: [Qemu-devel] [PATCH 1/2] virtio: add vhost-user-fs base device

2019-08-22 Thread Stefan Hajnoczi
On Wed, Aug 21, 2019 at 08:11:18PM +0100, Dr. David Alan Gilbert wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: > > On Fri, Aug 16, 2019 at 03:33:20PM +0100, Dr. David Alan Gilbert (git) > > wrote: > > > +static void vuf_handle_output(VirtIODevice *vdev, VirtQueue *vq) > > > +{ > > > +

Re: [Qemu-devel] [PATCH] vhost-user-scsi: prevent using uninitialized vqs

2019-08-22 Thread Philippe Mathieu-Daudé
Hi Raphael, Stefan, On 6/14/19 11:18 AM, Stefan Hajnoczi wrote: > On Tue, Jun 11, 2019 at 05:35:17PM -0700, Raphael Norwitz wrote: >> Of the 3 virtqueues, seabios only sets cmd, leaving ctrl >> and event without a physical address. This can cause >> vhost_verify_ring_part_mapping to return ENOMEM,

Re: [Qemu-devel] [Qemu-block] [PATCH 0/3] block/io_uring: fix EINTR and resubmit short reads

2019-08-22 Thread Stefan Hajnoczi
On Wed, Aug 21, 2019 at 06:20:39PM -0400, John Snow wrote: > > > On 7/15/19 4:19 PM, Stefan Hajnoczi wrote: > > Short reads are possible with cache=writeback (see Patch 3 for details). > > Handle this by resubmitting requests until the read is completed. > > > > Patch 1 adds trace events useful

Re: [Qemu-devel] [RFC v3] hw/sd/aspeed_sdhci: New device

2019-08-22 Thread Cédric Le Goater
On 20/08/2019 21:02, Eddie James wrote: > The Aspeed SOCs have two SD/MMC controllers. Add a device that > encapsulates both of these controllers and models the Aspeed-specific > registers and behavior. > > Tested by reading from mmcblk0 in Linux: > qemu-system-arm -machine romulus-bmc -nographic

Re: [Qemu-devel] [PATCH 1/2] virtio: add vhost-user-fs base device

2019-08-22 Thread Cornelia Huck
On Thu, 22 Aug 2019 09:52:37 +0100 Stefan Hajnoczi wrote: > On Wed, Aug 21, 2019 at 08:11:18PM +0100, Dr. David Alan Gilbert wrote: > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > On Fri, Aug 16, 2019 at 03:33:20PM +0100, Dr. David Alan Gilbert (git) > > > wrote: > > > > +static voi

Re: [Qemu-devel] [PATCH] vfio: fix a typo

2019-08-22 Thread Cornelia Huck
On Thu, 22 Aug 2019 14:49:09 +0800 Chen Zhang via Qemu-devel wrote: > Signed-off-by: Chen Zhang > --- > hw/vfio/pci.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c > index dc3479c..c5e6fe6 100644 > --- a/hw/vfio/pci.c > +++ b/hw/vfio

Re: [Qemu-devel] [PATCH v7 04/13] vfio: Add save and load functions for VFIO PCI devices

2019-08-22 Thread Dr. David Alan Gilbert
* Kirti Wankhede (kwankh...@nvidia.com) wrote: > Sorry for delay to respond. > > On 7/11/2019 5:37 PM, Dr. David Alan Gilbert wrote: > > * Kirti Wankhede (kwankh...@nvidia.com) wrote: > >> These functions save and restore PCI device specific data - config > >> space of PCI device. > >> Tested save

Re: [Qemu-devel] [PULL 00/14] Trivial branch patches

2019-08-22 Thread Peter Maydell
On Wed, 21 Aug 2019 at 12:20, Laurent Vivier wrote: > > The following changes since commit 17dc57990320edaad52ac9ea808be9719c91cea6: > > Merge remote-tracking branch > 'remotes/huth-gitlab/tags/pull-request-2019-08-20' into staging (2019-08-20 > 14:14:20 +0100) > > are available in the Git rep

Re: [Qemu-devel] [PATCH 1/2] xen-bus: Fix backend state transition on device reset

2019-08-22 Thread Anthony PERARD
On Wed, Aug 21, 2019 at 10:36:40AM +0100, Paul Durrant wrote: > > diff --git a/hw/xen/xen-bus.c b/hw/xen/xen-bus.c > > index e40500242d..982eca4533 100644 > > --- a/hw/xen/xen-bus.c > > +++ b/hw/xen/xen-bus.c > > @@ -540,9 +540,11 @@ static void xen_device_backend_changed(void *opaque) > > /*

Re: [Qemu-devel] [PATCH v6 08/10] Adding info [tb-list|tb|coverset] commands to HMP.

2019-08-22 Thread Dr. David Alan Gilbert
* vandersonmr (vanderson...@gmail.com) wrote: > These commands allow the exploration of TBs > generated by the TCG. Understand which one > hotter, with more guest/host instructions... > and examine their guest, host and IR code. > > The goal of this command is to allow the dynamic exploration > of

Re: [Qemu-devel] [PATCH 1/2] xen-bus: Fix backend state transition on device reset

2019-08-22 Thread Paul Durrant
> -Original Message- > From: Anthony PERARD > Sent: 22 August 2019 10:51 > To: Paul Durrant > Cc: qemu-devel@nongnu.org; qemu-sta...@nongnu.org; Stefano Stabellini > ; xen- > de...@lists.xenproject.org > Subject: Re: [PATCH 1/2] xen-bus: Fix backend state transition on device reset > >

Re: [Qemu-devel] [PATCH v6 09/10] monitor: adding new info cfg command

2019-08-22 Thread Dr. David Alan Gilbert
* vandersonmr (vanderson...@gmail.com) wrote: > Adding "info cfg id depth" commands to HMP. > This command allow the exploration a TB > neighbors by dumping [and opening] a .dot > file with the TB CFG neighbors colorized > by their hotness. > > The goal of this command is to allow the dynamic expl

[Qemu-devel] [PATCH v3] qapi: report the default CPU type for each machine

2019-08-22 Thread Daniel P . Berrangé
When user doesn't request any explicit CPU model with libvirt or QEMU, a machine type specific CPU model is picked. Currently there is no way to determine what this QEMU built-in default is, so libvirt cannot report this back to the user in the XML config. This extends the "query-machines" QMP com

[Qemu-devel] [PULL 3/5] target/tricore: Use translate_loop

2019-08-22 Thread Bastian Koppelmann
Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann --- target/tricore/translate.c | 118 +++-- 1 file changed, 74 insertions(+), 44 deletions(-) diff --git a/target/tricore/translate.c b/target/tricore/translate.c index 6b10ae5c47..5fb42abe35 100644

[Qemu-devel] [PULL 5/5] target/tricore: Fix tricore_tr_translate_insn

2019-08-22 Thread Bastian Koppelmann
we now fetch 2 bytes first, check whether we have a 32 bit insn, and only then fetch another 2 bytes. We also make sure that a 16 bit insn that still fits into the current page does not end up in the next page. Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann --- target/tricore/

[Qemu-devel] [PULL 0/5] tricore queue

2019-08-22 Thread Bastian Koppelmann
tags/pull-tricore-20190822-1 for you to fetch changes up to d4881da9b39df183f976349f223231ac1d81087b: target/tricore: Fix tricore_tr_translate_insn (2019-08-22 12:17:01 +0200) Converted target/tricore to tran

[Qemu-devel] [PULL 4/5] target/tricore: Implement a qemu excptions helper

2019-08-22 Thread Bastian Koppelmann
this helper is only used to raise qemu specific exceptions. We use this helper to raise it on breakpoints. Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann --- target/tricore/helper.h| 1 + target/tricore/op_helper.c | 7 +++ target/tricore/translate.c | 20 +++

[Qemu-devel] [PULL 1/5] target/tricore: Use DisasContextBase API

2019-08-22 Thread Bastian Koppelmann
this gets rid of the copied fields of TriCore's DisasContext and now uses the shared DisasContextBase, which is necessary for the conversion to translate_loop. Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann --- target/tricore/translate.c | 98 +-

Re: [Qemu-devel] [PATCH 2/2] xen-bus: Avoid rewriting identical values to xenstore

2019-08-22 Thread Anthony PERARD
On Wed, Aug 21, 2019 at 04:40:05PM +0100, Paul Durrant wrote: > > -Original Message- > > From: Anthony PERARD > > Sent: 21 August 2019 10:20 > > To: qemu-devel@nongnu.org > > Cc: Anthony Perard ; Stefano Stabellini > > ; Paul > > Durrant ; xen-de...@lists.xenproject.org > > Subject: [PATC

Re: [Qemu-devel] [PATCH 2/6] exec.c: remove an unnecessary assert on PHYS_MAP_NODE_NIL in phys_map_node_alloc()

2019-08-22 Thread Paolo Bonzini
On 21/03/19 09:25, Wei Yang wrote: > PHYS_MAP_NODE_NIL is assigned to PhysPageEntry.ptr in case this is not a > leaf entry, while map->nodes_nb range in [0, nodes_nb_alloc). > > Seems we are asserting on two different things, just remove it. The assertion checks that this "if" is not entered inco

[Qemu-devel] [PULL 2/5] target-tricore: Make env a member of DisasContext

2019-08-22 Thread Bastian Koppelmann
otherwise we have to pass env down through all functions which blocks the usage of translator_loop. Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann --- target/tricore/translate.c | 340 ++--- 1 file changed, 168 insertions(+), 172 deletions(-) d

Re: [Qemu-devel] [PATCH v4 00/15] hw/i386/pc: Do not restrict the fw_cfg functions to the PC machine

2019-08-22 Thread Paolo Bonzini
On 19/08/19 00:53, Philippe Mathieu-Daudé wrote: > Hi, > > This is my take at salvaging some NEMU good work. > Samuel worked in adding the fw_cfg device to the x86-virt NEMU machine. > This series is inspired by NEMU's commit 3cb92d080835 [0] and adapted > to upstream style. The result makes the u

Re: [Qemu-devel] [PATCH 0/6] Refine exec

2019-08-22 Thread Paolo Bonzini
On 19/08/19 05:06, Wei Yang wrote: > On Thu, Mar 21, 2019 at 04:25:49PM +0800, Wei Yang wrote: >> This serial refine exec a little. >> > > Ping again. Queued all except 2, thanks! Paolo >> Wei Yang (6): >> exec.c: replace hwaddr with uint64_t for better understanding >> exec.c: remove an unne

Re: [Qemu-devel] QEMU as ISS (Instruction Set Simulator)

2019-08-22 Thread ??
Hi Aleksandar, Thank you very much for your patient explanation in the previous post. And thank you for checking. Your and Peter's replies in the previous post certainly helped a lot. I am now looking at a git commit 7 years ago (bd277fa1966bc400f1b411f868f39125cda0c403), it was a Loongson Mul

Re: [Qemu-devel] [PATCH 03/13] qcrypto-luks: refactoring: extract load/store/check/parse header functions

2019-08-22 Thread Daniel P . Berrangé
On Thu, Aug 22, 2019 at 01:43:05AM +0300, Maxim Levitsky wrote: > On Tue, 2019-08-20 at 20:01 +0200, Max Reitz wrote: > > On 14.08.19 22:22, Maxim Levitsky wrote: > > > With upcoming key management, the header will > > > need to be stored after the image is created. > > > > > > Extracting load hea

Re: [Qemu-devel] [Qemu-block] [PATCH 02/13] qcrypto-luks: misc refactoring

2019-08-22 Thread Daniel P . Berrangé
On Thu, Aug 15, 2019 at 05:40:11PM -0400, John Snow wrote: > > > On 8/14/19 4:22 PM, Maxim Levitsky wrote: > > This is also a preparation for key read/write/erase functions > > > > This is a matter of taste and I am not usually reviewing LUKS patches > (So don't take me too seriously), but I wo

Re: [Qemu-devel] [PATCH 03/13] qcrypto-luks: refactoring: extract load/store/check/parse header functions

2019-08-22 Thread Daniel P . Berrangé
On Thu, Aug 22, 2019 at 01:43:05AM +0300, Maxim Levitsky wrote: > On Tue, 2019-08-20 at 20:01 +0200, Max Reitz wrote: > > On 14.08.19 22:22, Maxim Levitsky wrote: > > > With upcoming key management, the header will > > > need to be stored after the image is created. > > > > > > Extracting load hea

Re: [Qemu-devel] [PATCH 2/2] xen-bus: Avoid rewriting identical values to xenstore

2019-08-22 Thread Paul Durrant
> -Original Message- > From: Anthony PERARD > Sent: 22 August 2019 11:22 > To: Paul Durrant > Cc: qemu-devel@nongnu.org; Stefano Stabellini ; > xen-de...@lists.xenproject.org > Subject: Re: [PATCH 2/2] xen-bus: Avoid rewriting identical values to xenstore > > On Wed, Aug 21, 2019 at 04:

Re: [Qemu-devel] [PATCH 03/13] qcrypto-luks: refactoring: extract load/store/check/parse header functions

2019-08-22 Thread Daniel P . Berrangé
On Wed, Aug 14, 2019 at 11:22:09PM +0300, Maxim Levitsky wrote: > With upcoming key management, the header will > need to be stored after the image is created. > > Extracting load header isn't strictly needed, but > do this anyway for the symmetry. > > Also I extracted a function that does basic

Re: [Qemu-devel] [PULL 0/5] tricore queue

2019-08-22 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190822102046.8765-1-kbast...@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PULL 0/5] tricore queue Message-id: 20190822102046.8765-1-kbast...@m

Re: [Qemu-devel] [PATCH 04/13] qcrypto-luks: refactoring: simplify the math used for keyslot locations

2019-08-22 Thread Daniel P . Berrangé
On Wed, Aug 14, 2019 at 11:22:10PM +0300, Maxim Levitsky wrote: > Signed-off-by: Maxim Levitsky > --- > crypto/block-luks.c | 64 +++-- > 1 file changed, 38 insertions(+), 26 deletions(-) > > diff --git a/crypto/block-luks.c b/crypto/block-luks.c > index 6

Re: [Qemu-devel] [PATCH 05/13] qcrypto-luks: clear the masterkey and password before freeing them always

2019-08-22 Thread Daniel P . Berrangé
On Tue, Aug 20, 2019 at 08:12:51PM +0200, Max Reitz wrote: > On 14.08.19 22:22, Maxim Levitsky wrote: > > While there are other places where these are still stored in memory, > > this is still one less key material area that can be sniffed with > > various side channel attacks > > > > > > > > (

Re: [Qemu-devel] more automated/public CI for QEMU pullreqs

2019-08-22 Thread Stefan Hajnoczi
On Fri, Aug 16, 2019 at 07:16:55PM +0100, Peter Maydell wrote: > We had a conversation some months back about ways we might switch > away from the current handling of pull requests which I do via some > hand-curated scripts and personal access to machines, to a more > automated system that could be

[Qemu-devel] [PULL 2/3] crypto: define cleanup functions for use with g_autoptr

2019-08-22 Thread Daniel P . Berrangé
Allow crypto structs to be used with g_autoptr, avoiding the need to explicitly call XXX_free() functions when variables go out of scope on the stack. Reviewed-by: Marc-André Lureau Reviewed-by: Stefan Hajnoczi Signed-off-by: Daniel P. Berrangé --- include/crypto/block.h | 2 ++ include/c

Re: [Qemu-devel] QEMU as ISS (Instruction Set Simulator)

2019-08-22 Thread Aleksandar Markovic
On Thu, Aug 22, 2019 at 12:24 PM 立 wrote: > Hi Aleksandar, > > Thank you very much for your patient explanation in the previous post. And > thank you for checking. > Your and Peter's replies in the previous post certainly helped a lot. I am > now looking at a git commit 7 years ago ( > bd277fa196

[Qemu-devel] [PULL 0/3] crypto: autofree patches

2019-08-22 Thread Daniel P . Berrangé
The following changes since commit fe066b4848bab4f9365a419f3c8ba59ccecf67c0: Merge remote-tracking branch 'remotes/vivier2/tags/trivial-branch-pull-request' into staging (2019-08-21 16:59:22 +0100) are available in the Git repository at: https://github.com/berrange/qemu tags/autofree-pull-

[Qemu-devel] [PULL 1/3] glib: bump min required glib library version to 2.48

2019-08-22 Thread Daniel P . Berrangé
Per supported platforms doc[1], the various min glib on relevant distros is: RHEL-8: 2.56.1 RHEL-7: 2.50.3 Debian (Buster): 2.58.3 Debian (Stretch): 2.50.3 OpenBSD (Ports): 2.58.3 FreeBSD (Ports): 2.56.3 OpenSUSE Leap 15: 2.54.3 SLE12-SP2: 2.48.2 Ubuntu (Xenial): 2.48.0 macOS (

[Qemu-devel] [PULL 3/3] crypto: use auto cleanup for many stack variables

2019-08-22 Thread Daniel P . Berrangé
Simplify cleanup paths by using glib's auto cleanup macros for stack variables, allowing several goto jumps / labels to be eliminated. Reviewed-by: Marc-André Lureau Reviewed-by: Stefan Hajnoczi Signed-off-by: Daniel P. Berrangé --- crypto/afsplit.c | 28 +--- crypto/block-luk

Re: [Qemu-devel] [PATCH 05/13] qcrypto-luks: clear the masterkey and password before freeing them always

2019-08-22 Thread Maxim Levitsky
On Thu, 2019-08-22 at 11:49 +0100, Daniel P. Berrangé wrote: > On Tue, Aug 20, 2019 at 08:12:51PM +0200, Max Reitz wrote: > > On 14.08.19 22:22, Maxim Levitsky wrote: > > > While there are other places where these are still stored in memory, > > > this is still one less key material area that can b

Re: [Qemu-devel] [PATCH v2 2/2] Add dbus-vmstate object

2019-08-22 Thread Dr. David Alan Gilbert
* Marc-André Lureau (marcandre.lur...@redhat.com) wrote: > When instanciated, this object will connect to the given D-Bus > bus. During migration, it will take the data from org.qemu.VMState1 > instances. > > See documentation for further details. I'll leave the main review to someone who underst

Re: [Qemu-devel] [PATCH 03/13] qcrypto-luks: refactoring: extract load/store/check/parse header functions

2019-08-22 Thread Maxim Levitsky
On Thu, 2019-08-22 at 11:32 +0100, Daniel P. Berrangé wrote: > On Thu, Aug 22, 2019 at 01:43:05AM +0300, Maxim Levitsky wrote: > > On Tue, 2019-08-20 at 20:01 +0200, Max Reitz wrote: > > > On 14.08.19 22:22, Maxim Levitsky wrote: > > > > With upcoming key management, the header will > > > > need to

Re: [Qemu-devel] [PULL 0/5] tricore queue

2019-08-22 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190822102046.8765-1-kbast...@mail.uni-paderborn.de/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PULL 0/5] tricore queue Message-id: 20190822102046.8765-1-kbast...@m

[Qemu-devel] [Bug 1840920] Re: changelog 4.1 krenel typo

2019-08-22 Thread Peter Maydell
Thanks for this report -- I've just updated the changelog page to fix the typo. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1840920 Title:

Re: [Qemu-devel] [Qemu-block] [PATCH 02/13] qcrypto-luks: misc refactoring

2019-08-22 Thread Maxim Levitsky
On Thu, 2019-08-22 at 11:29 +0100, Daniel P. Berrangé wrote: > On Thu, Aug 15, 2019 at 05:40:11PM -0400, John Snow wrote: > > > > > > On 8/14/19 4:22 PM, Maxim Levitsky wrote: > > > This is also a preparation for key read/write/erase functions > > > > > > > This is a matter of taste and I am no

Re: [Qemu-devel] more automated/public CI for QEMU pullreqs

2019-08-22 Thread Peter Maydell
On Thu, 22 Aug 2019 at 11:50, Stefan Hajnoczi wrote: > One-off tasks: > > 1. Create CI runners that offer similar cross-architecture coverage to >Peter's current setup. qemu.org has some x86, ppc, and s390 server >resources available. I'm not sure about ARM and other architectures. Quic

Re: [Qemu-devel] [PATCH 06/13] qcrypto-luks: implement more rigorous header checking

2019-08-22 Thread Daniel P . Berrangé
On Wed, Aug 14, 2019 at 11:22:12PM +0300, Maxim Levitsky wrote: > Check that keyslots don't overlap with the data, > and check that keyslots don't overlap with each other. > (this is done using naive O(n^2) nested loops, > but since there are just 8 keyslots, this doens't really matter. > > Signed

Re: [Qemu-devel] [Qemu-block] [PATCH 02/13] qcrypto-luks: misc refactoring

2019-08-22 Thread Daniel P . Berrangé
On Thu, Aug 22, 2019 at 02:04:28PM +0300, Maxim Levitsky wrote: > On Thu, 2019-08-22 at 11:29 +0100, Daniel P. Berrangé wrote: > > On Thu, Aug 15, 2019 at 05:40:11PM -0400, John Snow wrote: > > > > > > > > > On 8/14/19 4:22 PM, Maxim Levitsky wrote: > > > > This is also a preparation for key read

[Qemu-devel] [PATCH] hw/net/vmxnet3: Fix leftover unregister_savevm

2019-08-22 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Commit 78dd48df3 reworked vmxnet3's live migration but left a straggling unregister_savevm call. Remove it, although it doesn't seem to have any bad effect. Signed-off-by: Dr. David Alan Gilbert --- hw/net/vmxnet3.c | 3 --- 1 file changed, 3 deletions(-) diff

Re: [Qemu-devel] [Qemu-block] [PATCH 02/13] qcrypto-luks: misc refactoring

2019-08-22 Thread Maxim Levitsky
On Thu, 2019-08-22 at 12:10 +0100, Daniel P. Berrangé wrote: > On Thu, Aug 22, 2019 at 02:04:28PM +0300, Maxim Levitsky wrote: > > On Thu, 2019-08-22 at 11:29 +0100, Daniel P. Berrangé wrote: > > > On Thu, Aug 15, 2019 at 05:40:11PM -0400, John Snow wrote: > > > > > > > > > > > > On 8/14/19 4:22

Re: [Qemu-devel] [PATCH 07/13] block: add manage-encryption command (qmp and blockdev)

2019-08-22 Thread Daniel P . Berrangé
On Tue, Aug 20, 2019 at 08:27:48PM +0200, Max Reitz wrote: > On 14.08.19 22:22, Maxim Levitsky wrote: > > This adds: > > > > * x-blockdev-update-encryption and x-blockdev-erase-encryption qmp commands > > Both commands take the QCryptoKeyManageOptions > > the x-blockdev-update-encryption is me

Re: [Qemu-devel] [PATCH 08/13] qcrypto: add the plumbing for encryption management

2019-08-22 Thread Daniel P . Berrangé
On Wed, Aug 14, 2019 at 11:22:14PM +0300, Maxim Levitsky wrote: > This adds qcrypto_block_manage_encryption, which > is thin wrapper around manage_encryption of the crypto driver > which is also added > > Signed-off-by: Maxim Levitsky > --- > crypto/block.c | 29 +++

Re: [Qemu-devel] more automated/public CI for QEMU pullreqs

2019-08-22 Thread Paolo Bonzini
On 22/08/19 13:04, Peter Maydell wrote: > On Thu, 22 Aug 2019 at 11:50, Stefan Hajnoczi wrote: >> One-off tasks: >> >> 1. Create CI runners that offer similar cross-architecture coverage to >>Peter's current setup. qemu.org has some x86, ppc, and s390 server >>resources available. I'm no

Re: [Qemu-devel] [PATCH 2/2] xen-bus: Avoid rewriting identical values to xenstore

2019-08-22 Thread Anthony PERARD
On Thu, Aug 22, 2019 at 11:36:32AM +0100, Paul Durrant wrote: > But, now I look at the code again without your patch applied I don't actually > see the problem it is trying to fix. The functions > xen_device_[back|front]end_set_state return early if the state being set > matches the existing sta

[Qemu-devel] [Bug 1840922] Re: qemu-arm for cortex-m33 aborts with unhandled CPU exception 0x8

2019-08-22 Thread Peter Maydell
The test for v8m magic return addresses is not too loose -- see the v8M pseudocode IsReturn(). Architecturally the whole range of these values is special, even though in fact the exception return address encoding currently doesn't use all the bits that are reserved in this manner. I would prefer n

Re: [Qemu-devel] [PATCH 2/2] xen-bus: Avoid rewriting identical values to xenstore

2019-08-22 Thread Paul Durrant
> -Original Message- > From: Anthony PERARD > Sent: 22 August 2019 12:18 > To: Paul Durrant > Cc: qemu-devel@nongnu.org; Stefano Stabellini ; > xen-de...@lists.xenproject.org > Subject: Re: [PATCH 2/2] xen-bus: Avoid rewriting identical values to xenstore > > On Thu, Aug 22, 2019 at 11:

Re: [Qemu-devel] Broken aarch64 by qcow2: skip writing zero buffers to empty COW areas [v2]

2019-08-22 Thread Lukáš Doktor
Dne 21. 08. 19 v 19:51 Max Reitz napsal(a): > On 21.08.19 16:14, Lukáš Doktor wrote: >> Hello guys, >> >> First attempt was rejected due to zip attachment, let's try it again with >> just Avocado-vt debug.log and serial console log files attached. >> >> I bisected a regression on aarch64 all the w

Re: [Qemu-devel] [PATCH 09/13] qcrypto-luks: implement the encryption key management

2019-08-22 Thread Daniel P . Berrangé
On Wed, Aug 14, 2019 at 11:22:15PM +0300, Maxim Levitsky wrote: > Signed-off-by: Maxim Levitsky > --- > crypto/block-luks.c | 374 +++- > 1 file changed, 373 insertions(+), 1 deletion(-) > > diff --git a/crypto/block-luks.c b/crypto/block-luks.c > index 19

Re: [Qemu-devel] [PATCH 10/13] block/crypto: implement the encryption key management

2019-08-22 Thread Daniel P . Berrangé
On Wed, Aug 14, 2019 at 11:22:16PM +0300, Maxim Levitsky wrote: > This implements the encryption key management > using the generic code in qcrypto layer > > This code adds another 'write_func' because the initialization > write_func works directly on the underlying file, > because during the crea

Re: [Qemu-devel] QEMU bitmap backup usability FAQ

2019-08-22 Thread Vladimir Sementsov-Ogievskiy
22.08.2019 0:19, John Snow wrote: > > > On 8/21/19 10:21 AM, Vladimir Sementsov-Ogievskiy wrote: >> [CC Nikolay] >> >> 21.08.2019 1:25, John Snow wrote: >>> Hi, downstream here at Red Hat I've been fielding some questions about >>> the usability and feature readiness of Bitmaps (and related featu

Re: [Qemu-devel] [PATCH] block: posix: Always allocate the first block

2019-08-22 Thread Nir Soffer
Max, did you have time to look at this? On Sat, Aug 17, 2019 at 12:21 AM Nir Soffer wrote: > When creating an image with preallocation "off" or "falloc", the first > block of the image is typically not allocated. When using Gluster > storage backed by XFS filesystem, reading this block using dir

Re: [Qemu-devel] [PATCH 12/13] qemu-img: implement key management

2019-08-22 Thread Daniel P . Berrangé
On Tue, Aug 20, 2019 at 08:29:55PM +0200, Max Reitz wrote: > On 14.08.19 22:22, Maxim Levitsky wrote: > > Signed-off-by: Maxim Levitsky > > --- > > block/crypto.c | 16 ++ > > block/crypto.h | 3 + > > qemu-img-cmds.hx | 13 + > > qemu-img.c | 140 +++

Re: [Qemu-devel] [PATCH 00/13] RFC: luks/encrypted qcow2 key management

2019-08-22 Thread Daniel P . Berrangé
On Wed, Aug 14, 2019 at 11:22:06PM +0300, Maxim Levitsky wrote: > Hi! > > This patch series implements key management for luks based encryption > It supports both raw luks images and qcow2 encrypted images. > > Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1731898 > > There are still sev

[Qemu-devel] [PATCH 01/26] target/mips: Clean up handling of CP0 register 0

2019-08-22 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 0. Signed-off-by: Aleksandar Markovic --- target/mips/cpu.h | 3 +++ target/mips/translate.c | 40 2 files changed, 23 insertions(+), 20 deletions(-) diff --git a/target/mips/cpu.h b/ta

[Qemu-devel] [PATCH 00/26] Clean up handling of configuration register CP0

2019-08-22 Thread Aleksandar Markovic
From: Aleksandar Markovic This series is a spin-off of a former "Misc MIPS fixes for 4.2" series. The goal of the series is to clean up CP0-related code, and prepare it for (near) future extensions and amendments. The series is mostly of refactoring nature, however it may contain simple fixes (

[Qemu-devel] [PATCH 09/26] target/mips: Clean up handling of CP0 register 10

2019-08-22 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 10. Signed-off-by: Aleksandar Markovic --- target/mips/cpu.h | 1 + target/mips/translate.c | 8 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/target/mips/cpu.h b/target/mips/cpu.h index c7fdf1d..5e08b7

Re: [Qemu-devel] [PATCH v2 2/2] Add dbus-vmstate object

2019-08-22 Thread Marc-André Lureau
Hi On Thu, Aug 22, 2019 at 2:56 PM Dr. David Alan Gilbert wrote: > > * Marc-André Lureau (marcandre.lur...@redhat.com) wrote: > > When instanciated, this object will connect to the given D-Bus > > bus. During migration, it will take the data from org.qemu.VMState1 > > instances. > > > > See docum

[Qemu-devel] [PATCH 10/26] target/mips: Clean up handling of CP0 register 11

2019-08-22 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 11. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index b376103..87257d7 100644 --- a/targe

[Qemu-devel] [PATCH 07/26] target/mips: Clean up handling of CP0 register 8

2019-08-22 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 8. Signed-off-by: Aleksandar Markovic --- target/mips/cpu.h | 1 + target/mips/translate.c | 32 2 files changed, 17 insertions(+), 16 deletions(-) diff --git a/target/mips/cpu.h b/target/mips/

[Qemu-devel] [PATCH 12/26] target/mips: Clean up handling of CP0 register 15

2019-08-22 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 15. Signed-off-by: Aleksandar Markovic --- target/mips/cpu.h | 1 + target/mips/translate.c | 20 ++-- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/target/mips/cpu.h b/target/mips/cpu.h index

[Qemu-devel] [PATCH 06/26] target/mips: Clean up handling of CP0 register 7

2019-08-22 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 7. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index cdcc1cc..abbb924 100644 --- a/target

[Qemu-devel] [PATCH 14/26] target/mips: Clean up handling of CP0 register 17

2019-08-22 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 17. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index 7878fcb.

[Qemu-devel] [PATCH 04/26] target/mips: Clean up handling of CP0 register 5

2019-08-22 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 5. Signed-off-by: Aleksandar Markovic --- target/mips/cpu.h | 6 + target/mips/translate.c | 64 - 2 files changed, 38 insertions(+), 32 deletions(-) diff --git a/target/mips

[Qemu-devel] [PATCH 03/26] target/mips: Clean up handling of CP0 register 2

2019-08-22 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 2. Signed-off-by: Aleksandar Markovic --- target/mips/cpu.h | 7 ++ target/mips/translate.c | 64 - 2 files changed, 39 insertions(+), 32 deletions(-) diff --git a/target/mip

[Qemu-devel] [PATCH 05/26] target/mips: Clean up handling of CP0 register 6

2019-08-22 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 6. Signed-off-by: Aleksandar Markovic --- target/mips/cpu.h | 6 ++ target/mips/translate.c | 56 - 2 files changed, 34 insertions(+), 28 deletions(-) diff --git a/target/mip

[Qemu-devel] [PATCH 16/26] target/mips: Clean up handling of CP0 register 19

2019-08-22 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 19. Signed-off-by: Aleksandar Markovic --- target/mips/cpu.h | 4 target/mips/translate.c | 64 - 2 files changed, 36 insertions(+), 32 deletions(-) diff --git a/target/mips

[Qemu-devel] [PATCH 02/26] target/mips: Clean up handling of CP0 register 1

2019-08-22 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 1. Signed-off-by: Aleksandar Markovic --- target/mips/cpu.h | 8 +++ target/mips/translate.c | 64 - 2 files changed, 40 insertions(+), 32 deletions(-) diff --git a/target/mi

[Qemu-devel] [PATCH 19/26] target/mips: Clean up handling of CP0 register 24

2019-08-22 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 24. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index 4272948..41392ab 100644 --- a/targe

[Qemu-devel] [PATCH 22/26] target/mips: Clean up handling of CP0 register 27

2019-08-22 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 27. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index f7e33f6..936c51c 1006

[Qemu-devel] [PATCH 13/26] target/mips: Clean up handling of CP0 register 16

2019-08-22 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 16. Signed-off-by: Aleksandar Markovic --- target/mips/cpu.h | 3 ++- target/mips/translate.c | 60 - 2 files changed, 32 insertions(+), 31 deletions(-) diff --git a/target/mips/

[Qemu-devel] [PATCH 08/26] target/mips: Clean up handling of CP0 register 9

2019-08-22 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 9. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index c046a10..f8ba

[Qemu-devel] [PATCH 21/26] target/mips: Clean up handling of CP0 register 26

2019-08-22 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 26. Signed-off-by: Aleksandar Markovic --- target/mips/cpu.h | 2 +- target/mips/translate.c | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/target/mips/cpu.h b/target/mips/cpu.h index c14afcd..80c89

Re: [Qemu-devel] [PATCH 08/13] qcrypto: add the plumbing for encryption management

2019-08-22 Thread Maxim Levitsky
On Thu, 2019-08-22 at 12:16 +0100, Daniel P. Berrangé wrote: > On Wed, Aug 14, 2019 at 11:22:14PM +0300, Maxim Levitsky wrote: > > This adds qcrypto_block_manage_encryption, which > > is thin wrapper around manage_encryption of the crypto driver > > which is also added > > > > Signed-off-by: Max

Re: [Qemu-devel] [PATCH 10/13] block/crypto: implement the encryption key management

2019-08-22 Thread Maxim Levitsky
On Thu, 2019-08-22 at 12:29 +0100, Daniel P. Berrangé wrote: > On Wed, Aug 14, 2019 at 11:22:16PM +0300, Maxim Levitsky wrote: > > This implements the encryption key management > > using the generic code in qcrypto layer > > > > This code adds another 'write_func' because the initialization > > wr

  1   2   3   4   >