[Qemu-devel] [PULL 02/36] target-i386: adds PV_SCHED_YIELD CPUID feature bit

2019-08-20 Thread Paolo Bonzini
From: Wanpeng Li Adds PV_SCHED_YIELD CPUID feature bit. Cc: Eduardo Habkost Cc: Paolo Bonzini Cc: Radim Krčmář Signed-off-by: Wanpeng Li Message-Id: <1562745771-8414-1-git-send-email-wanpen...@tencent.com> Signed-off-by: Paolo Bonzini --- target/i386/cpu.c | 2 +- 1 file changed, 1 inserti

[Qemu-devel] [PULL 00/36] QEMU patches for 2018-08-20

2019-08-20 Thread Paolo Bonzini
The following changes since commit 864ab314f1d924129d06ac7b571f105a2b76a4b2: Update version for v4.1.0-rc4 release (2019-08-06 17:05:21 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to fetch changes up to 6f93977075ae9971d73879ca8

[Qemu-devel] [PULL 08/36] block: fix NetBSD qemu-iotests failure

2019-08-20 Thread Paolo Bonzini
Opening a block device on NetBSD has an additional step compared to other OSes, corresponding to raw_normalize_devicepath. The error message in that function is slightly different from that in raw_open_common and this was causing spurious failures in qemu-iotests. However, in general it is not im

[Qemu-devel] [PULL 06/36] memory: assert on out of scope notification

2019-08-20 Thread Paolo Bonzini
From: Yan Zhao It is wrong for an entry to have parts out of scope of notifier's range. assert this condition. Out of scope mapping/unmapping would cause problem, as in below case: 1. initially there are two notifiers with ranges 0-0xfedf, 0xfef0-0x, IOVAs from 0x3c0

[Qemu-devel] [PULL 01/36] kvm: i386: halt poll control MSR support

2019-08-20 Thread Paolo Bonzini
From: Marcelo Tosatti Add support for halt poll control MSR: save/restore, migration and new feature name. The purpose of this MSR is to allow the guest to disable host halt poll. Signed-off-by: Marcelo Tosatti Message-Id: <20190603230408.ga7...@amt.cnet> [Do not enable by default, as pointed

[Qemu-devel] [PULL 13/36] i386/kvm: initialize struct at full before ioctl call

2019-08-20 Thread Paolo Bonzini
From: Andrey Shinkevich Not the whole structure is initialized before passing it to the KVM. Reduce the number of Valgrind reports. Signed-off-by: Andrey Shinkevich Message-Id: <1564502498-805893-4-git-send-email-andrey.shinkev...@virtuozzo.com> Signed-off-by: Paolo Bonzini --- target/i386/kv

[Qemu-devel] [PULL 03/36] loader: Handle memory-mapped ELFs

2019-08-20 Thread Paolo Bonzini
From: Stefano Garzarella This patch allows handling an ELF memory-mapped, taking care the reference count of the GMappedFile* passed through rom_add_elf_program(). In this case, the 'data' pointer is not heap-allocated, so we cannot free it. Suggested-by: Paolo Bonzini Signed-off-by: Stefano Ga

[Qemu-devel] [PULL 11/36] test-throttle: Fix uninitialized use of burst_length

2019-08-20 Thread Paolo Bonzini
From: Andrey Shinkevich ThrottleState::cfg of the static variable 'ts' is reassigned with the local one in the do_test_accounting() and then is passed to the throttle_account() with uninitialized member LeakyBucket::burst_length. Signed-off-by: Andrey Shinkevich Message-Id: <1564502498-805893-2

[Qemu-devel] [PULL 05/36] hw/i386/pc: Map into memory the initrd

2019-08-20 Thread Paolo Bonzini
From: Stefano Garzarella In order to reduce the memory footprint we map into memory the initrd using g_mapped_file_new() instead of reading it. In this way we can share the initrd pages between multiple instances of QEMU. Suggested-by: Paolo Bonzini Signed-off-by: Stefano Garzarella Message-Id

[Qemu-devel] [PULL 04/36] elf-ops.h: Map into memory the ELF to load

2019-08-20 Thread Paolo Bonzini
From: Stefano Garzarella In order to reduce the memory footprint we map into memory the ELF to load using g_mapped_file_new_from_fd() instead of reading each sections. In this way we can share the ELF pages between multiple instances of QEMU. Suggested-by: Dr. David Alan Gilbert Suggested-by: P

[Qemu-devel] [PULL 14/36] target/i386: Return 'indefinite integer value' for invalid SSE fp->int conversions

2019-08-20 Thread Paolo Bonzini
From: Peter Maydell The x86 architecture requires that all conversions from floating point to integer which raise the 'invalid' exception (infinities of both signs, NaN, and all values which don't fit in the destination integer) return what the x86 spec calls the "indefinite integer value", which

[Qemu-devel] [PULL 12/36] tests: Fix uninitialized byte in test_visitor_in_fuzz

2019-08-20 Thread Paolo Bonzini
From: Andrey Shinkevich One byte in the local buffer stays uninitialized, at least with the first iteration, because of the double decrement in the test_visitor_in_fuzz(). This is what Valgrind does not like and not critical for the test itself. So, reduce the number of the memory issues reports.

[Qemu-devel] [PULL 07/36] configure: Define target access alignment in configure

2019-08-20 Thread Paolo Bonzini
From: "tony.ngu...@bt.com" This patch moves the define of target access alignment earlier from target/foo/cpu.h to configure. Suggested in Richard Henderson's reply to "[PATCH 1/4] tcg: TCGMemOp is now accelerator independent MemOp" Signed-off-by: Tony Nguyen Message-Id: <11e818d38ebc40e986cf

[Qemu-devel] [PULL 10/36] target-i386: kvm: 'kvm_get_supported_msrs' cleanup

2019-08-20 Thread Paolo Bonzini
From: Li Qiang Function 'kvm_get_supported_msrs' is only called once now, get rid of the static variable 'kvm_supported_msrs'. Signed-off-by: Li Qiang Message-Id: <20190725151639.21693-1-liq...@163.com> Signed-off-by: Paolo Bonzini --- target/i386/kvm.c | 185 +++--

[Qemu-devel] [PULL 15/36] memory: fix race between TCG and accesses to dirty bitmap

2019-08-20 Thread Paolo Bonzini
There is a race between TCG and accesses to the dirty log: vCPU thread reader thread --- --- TLB check -> slow path notdirty_mem_write write to RAM set dirty flag

[Qemu-devel] [PULL 09/36] 9p: simplify source file selection

2019-08-20 Thread Paolo Bonzini
Express the complex conditions in Kconfig rather than Makefiles, since Kconfig is better suited at expressing dependencies and detecting contradictions. Cc: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Kconfig.host| 1 + fsdev/Makefile.objs | 2 +- hw/9pfs/Kconfig | 5 + 3

[Qemu-devel] [PULL 17/36] timer: Remove reset notifiers

2019-08-20 Thread Paolo Bonzini
From: "Dr. David Alan Gilbert" Remove the reset notifer from the core qemu-timer code. The only user was mc146818 and we've just remove it's use. Signed-off-by: Dr. David Alan Gilbert Message-Id: <20190724115823.4199-3-dgilb...@redhat.com> Signed-off-by: Paolo Bonzini --- include/qemu/timer.h

[Qemu-devel] [PULL 19/36] timer: last, remove last bits of last

2019-08-20 Thread Paolo Bonzini
From: "Dr. David Alan Gilbert" The reset notifiers kept a 'last' counter to notice jumps; now that we've remove the notifier we don't need to keep 'last'. Signed-off-by: Dr. David Alan Gilbert Message-Id: <20190724115823.4199-5-dgilb...@redhat.com> Signed-off-by: Paolo Bonzini --- include/qem

[Qemu-devel] [PULL 21/36] replay: add missing fix for internal function

2019-08-20 Thread Paolo Bonzini
From: Pavel Dovgalyuk This is a fix which was missed by patch 74c0b816adfc6aa1b01b4426fdf385e32e35cbac, which added current_step parameter to the replay_advance_current_step function. Signed-off-by: Pavel Dovgalyuk Message-Id: <156404425561.18669.13015037579222450241.stgit@pasha-Precision-3630

[Qemu-devel] [PULL 16/36] mc146818rtc: Remove reset notifiers

2019-08-20 Thread Paolo Bonzini
From: "Dr. David Alan Gilbert" The reset notifiers are unreliable and recalculating the offsets after boot causes problems with migration in cases where explicit base times are set on the destination. Signed-off-by: Dr. David Alan Gilbert Message-Id: <20190724115823.4199-2-dgilb...@redhat.com>

[Qemu-devel] [PULL 18/36] replay: Remove host_clock_last

2019-08-20 Thread Paolo Bonzini
From: "Dr. David Alan Gilbert" Now we're not using the 'last' field in the timer, remove it from replay. Bump the version number of the replay structure since we've removed the field. Signed-off-by: Dr. David Alan Gilbert Message-Id: <20190724115823.4199-4-dgilb...@redhat.com> Signed-off-by: P

[Qemu-devel] [PULL 20/36] kconfig: do not select VMMOUSE

2019-08-20 Thread Paolo Bonzini
Just make it a default device, so that it is automatically removed if VMPORT is not included in the binary (as is the case with --with-default-devices). Signed-off-by: Paolo Bonzini --- hw/i386/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig index 63

[Qemu-devel] [PULL 24/36] replay: fix replay shutdown

2019-08-20 Thread Paolo Bonzini
From: Pavel Dovgalyuk This patch fixes shutdown of the replay process, which is terminated with the assert when shutdown event is read from the log. replay_finish_event reads new data_kind and therefore the value of data_kind should be preserved to be valid at qemu_system_shutdown_request call.

[Qemu-devel] [PULL 31/36] kvm: vmxcap: Enhance with latest features

2019-08-20 Thread Paolo Bonzini
From: Jan Kiszka Based on SDM from May 2019. Signed-off-by: Jan Kiszka Signed-off-by: Paolo Bonzini --- scripts/kvm/vmxcap | 8 1 file changed, 8 insertions(+) diff --git a/scripts/kvm/vmxcap b/scripts/kvm/vmxcap index 99a8146..d8c7d6d 100755 --- a/scripts/kvm/vmxcap +++ b/scripts/k

[Qemu-devel] [PULL 25/36] replay: refine replay-time module

2019-08-20 Thread Paolo Bonzini
From: Pavel Dovgalyuk This patch removes refactoring artifacts from the replay/replay-time.c Signed-off-by: Pavel Dovgalyuk Message-Id: <156404427799.18669.8072341590511911277.stgit@pasha-Precision-3630-Tower> Signed-off-by: Paolo Bonzini --- replay/replay-time.c | 36 ---

[Qemu-devel] [PULL 33/36] migration: do not rom_reset() during incoming migration

2019-08-20 Thread Paolo Bonzini
From: Catherine Ho Commit 18269069c310 ("migration: Introduce ignore-shared capability") addes ignore-shared capability to bypass the shared ramblock (e,g, membackend + numa node). It does good to live migration. As told by Yury,this commit expectes that QEMU doesn't write to guest RAM until VM

[Qemu-devel] [PULL 30/36] cpus-common: assert BQL nesting within cpu-exclusive sections

2019-08-20 Thread Paolo Bonzini
From: Roman Kagan Assert that the cpu-exclusive sections are never entered/left with the BQL taken. Signed-off-by: Roman Kagan Message-Id: <20190523105440.27045-3-rka...@virtuozzo.com> --- cpus-common.c | 4 1 file changed, 4 insertions(+) diff --git a/cpus-common.c b/cpus-common.c index

[Qemu-devel] [PULL 23/36] util/qemu-timer: refactor deadline calculation for external timers

2019-08-20 Thread Paolo Bonzini
From: Pavel Dovgalyuk icount-based record/replay uses qemu_clock_deadline_ns_all to measure the period until vCPU may be interrupted. This function takes in account the virtual timers, because they belong to the virtual devices that may generate interrupt request or affect the virtual machine sta

[Qemu-devel] [PULL 22/36] replay: document development rules

2019-08-20 Thread Paolo Bonzini
From: Pavel Dovgalyuk This patch introduces docs/devel/replay.txt which describes the rules that should be followed to make virtual devices usable in record/replay mode. Signed-off-by: Pavel Dovgalyuk -- v9: fixed external virtual clock description (reported by Artem Pisarenko) Message-Id: <

[Qemu-devel] [PULL 28/36] icount: remove unnecessary gen_io_end calls

2019-08-20 Thread Paolo Bonzini
From: Pavel Dovgalyuk Prior patch resets can_do_io flag at the TB entry. Therefore there is no need in resetting this flag at the end of the block. This patch removes redundant gen_io_end calls. Signed-off-by: Pavel Dovgalyuk Message-Id: <156404429499.18669.13404064982854123855.stgit@pasha-Pre

[Qemu-devel] [PULL 26/36] replay: rename step-related variables and functions

2019-08-20 Thread Paolo Bonzini
From: Pavel Dovgalyuk This patch renames replay_get_current_step() and related variables to make these names consistent with existing 'icount' command line option and future record/replay hmp/qmp commands. Signed-off-by: Pavel Dovgalyuk Message-Id: <156404428377.18669.15476429889039912070.stgi

[Qemu-devel] [PULL 29/36] cpus-common: nuke finish_safe_work

2019-08-20 Thread Paolo Bonzini
From: Roman Kagan It was introduced in commit ab129972c8b41e15b0521895a46fd9c752b68a5e, with the following motivation: Because start_exclusive uses CPU_FOREACH, merge exclusive_lock with qemu_cpu_list_lock: together with a call to exclusive_idle (via cpu_exec_start/end) in cpu_list_add, th

[Qemu-devel] [PULL 36/36] x86: Intel AVX512_BF16 feature enabling

2019-08-20 Thread Paolo Bonzini
From: Jing Liu Intel CooperLake cpu adds AVX512_BF16 instruction, defining as CPUID.(EAX=7,ECX=1):EAX[bit 05]. The patch adds a property for setting the subleaf of CPUID leaf 7 in case that people would like to specify it. The release spec link as follows, https://software.intel.com/sites/defau

[Qemu-devel] [PULL 27/36] icount: clean up cpu_can_io at the entry to the block

2019-08-20 Thread Paolo Bonzini
From: Pavel Dovgalyuk Most of IO instructions can be executed only at the end of the block in icount mode. Therefore translator can set cpu_can_io flag when translating the last instruction. But when the blocks are chained, then this flag is not reset and may remain set at the beginning of the ne

[Qemu-devel] [PULL 34/36] test-bitmap: test set 1 bit case for bitmap_set

2019-08-20 Thread Paolo Bonzini
From: Wei Yang All current bitmap_set test cases set range across word, while the handle of a range within one word is different from that. Add case to set 1 bit as a represent for set range within one word. Signed-off-by: Wei Yang Signed-off-by: Paolo Bonzini --- tests/test-bitmap.c | 12 ++

Re: [Qemu-devel] [PATCH] iotests: Add more "skip_if_unsupported" statements to the python tests

2019-08-20 Thread Thomas Huth
On 8/19/19 9:13 PM, Max Reitz wrote: > On 19.08.19 11:21, Thomas Huth wrote: >> The python code already contains a possibility to skip tests if the >> corresponding driver is not available in the qemu binary - use it >> in more spots to avoid that the tests are failing if the driver has >> been dis

[Qemu-devel] [PULL 32/36] HACKING: Document 'struct' keyword usage

2019-08-20 Thread Paolo Bonzini
From: Eduardo Habkost Sometimes we use the 'struct' keyword in headers to help us reduce dependencies between header files. Document that practice. Signed-off-by: Paolo Bonzini Signed-off-by: Eduardo Habkost Signed-off-by: Paolo Bonzini --- HACKING | 14 +- 1 file changed, 13 in

[Qemu-devel] [PULL 35/36] scsi: lsi: exit infinite loop while executing script (CVE-2019-12068)

2019-08-20 Thread Paolo Bonzini
When executing script in lsi_execute_script(), the LSI scsi adapter emulator advances 's->dsp' index to read next opcode. This can lead to an infinite loop if the next opcode is empty. Move the existing loop exit after 10k iterations so that it covers no-op opcodes as well. Reported-by: Bugs SysSe

Re: [Qemu-devel] [PATCH] hw/ppc/spapr: Use the proper include that defines 'target_ulong'

2019-08-20 Thread David Gibson
On Mon, Aug 19, 2019 at 04:49:26PM +0200, Philippe Mathieu-Daudé wrote: > As its name implies, the Option/Architecture Vector is not target > (per cpu) specific but arch-related. > Use the proper arch-related header, allowing to use this header > with non cpu-specific objects. > > This fixes this

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc: Three floating point fixes

2019-08-20 Thread David Gibson
On Mon, Aug 19, 2019 at 12:13:34PM -0500, Paul Clarke wrote: > On 8/19/19 1:44 AM, Aleksandar Markovic wrote: > > 19.08.2019. 08.30, "David Gibson" је > > написао/ла: > >> > >> On Sun, Aug 18, 2019 at 10:59:01PM +0200, Aleksandar Markovic wrote: > >>> 18.08.2019. 10.10, "Richard Henderson" је > >

Re: [Qemu-devel] [PULL 00/36] QEMU patches for 2018-08-20

2019-08-20 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1566284395-30287-1-git-send-email-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PULL 00/36] QEMU patches for 2018-08-20 Message-id: 1566284395-3028

[Qemu-devel] [PULL 0/8] Improvements for the Kconfig switches and Makefiles

2019-08-20 Thread Thomas Huth
Hi Peter, the following changes since commit 50d69ee0d82378c7c21f482492dacfe0916b4863: Merge remote-tracking branch 'remotes/stsquad/tags/pull-softfloat-headers-190819-1' into staging (2019-08-19 15:58:01 +0100) are available in the Git repository at: https://gitlab.com/huth/qemu.git tag

[Qemu-devel] [PULL 3/8] hw/dma: Do not build the xlnx_dpdma device for the MicroBlaze machines

2019-08-20 Thread Thomas Huth
From: Philippe Mathieu-Daudé The xlnx_dpdma device is only used by the ZynqMP AArch64 machine (not the MicroBlaze PMU). Remove it from the ZynqMP generic objects. (Note, this entry was duplicated for the AArch64). Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20190427141459.19728-4-phi...@

[Qemu-devel] [PULL 2/8] hw/intc: Only build the xlnx-iomod-intc device for the MicroBlaze PMU

2019-08-20 Thread Thomas Huth
From: Philippe Mathieu-Daudé The Xilinx I/O Module Interrupt Controller is only used by the MicroBlaze PMU, not by the AArch64 machine. Move it from the generic ZynqMP object list to the PMU specific. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20190427141459.19728-3-phi...@redhat.com> R

[Qemu-devel] [PULL 4/8] hw/core: Add a config switch for the "register" device

2019-08-20 Thread Thomas Huth
The "register" device is only used by certain machines. Let's add a proper config switch for it so that it only gets compiled when we really need it. Message-Id: <20190817101931.28386-5-th...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Signed-off-by: Thomas Huth

[Qemu-devel] [PULL 8/8] hw/core: Add a config switch for the generic loader device

2019-08-20 Thread Thomas Huth
The generic loader device is completely optional. Let's add a proper config switch for it so that people can disable it if they don't need it and want to create a minimalistic QEMU binary. Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190817101931.28386-9-th...@redhat.com> Signed-off-by: Tho

[Qemu-devel] [PULL 1/8] hw/Kconfig: Move the generic XLNX_ZYNQMP to the root hw/Kconfig

2019-08-20 Thread Thomas Huth
From: Philippe Mathieu-Daudé The XLNX_ZYNQMP config is used in multiple subdirectories (timer, intc). Move it to the root hw/Kconfig. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20190427141459.19728-2-phi...@redhat.com> Reviewed-by: Alistair Francis Signed-off-by: Thomas Huth --- hw/K

[Qemu-devel] [PULL 6/8] hw/core: Add a config switch for the "split-irq" device

2019-08-20 Thread Thomas Huth
The "split-irq" device is currently only used by machines that use CONFIG_ARMSSE. Let's add a proper CONFIG_SPLIT_IRQ switch for this so that it only gets compiled when we really need it. Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190817101931.28386-7-th...@redhat.com> Signed-off-by: Thom

[Qemu-devel] [PULL 5/8] hw/core: Add a config switch for the "or-irq" device

2019-08-20 Thread Thomas Huth
The "or-irq" device is only used by certain machines. Let's add a proper config switch for it so that it only gets compiled when we really need it. Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190817101931.28386-6-th...@redhat.com> Signed-off-by: Thomas Huth --- hw/arm/Kconfig| 3

[Qemu-devel] [PULL 7/8] hw/misc: Add a config switch for the "unimplemented" device

2019-08-20 Thread Thomas Huth
The device is only used by some few boards. Let's use a proper Kconfig switch so that we only compile this code if we really need it. Message-Id: <20190817101931.28386-8-th...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- hw/arm/Kconfig| 11 +++

Re: [Qemu-devel] [PATCH v3 00/15] target/arm/kvm: enable SVE in guests

2019-08-20 Thread Andrew Jones
On Tue, Aug 20, 2019 at 06:08:04AM +, Zhang, Lei wrote: > Hi Andrew, > > I have tested your patch on kernel- 5.2.7 + QEMU (4.0.94 + patch). Thanks for the testing! I guess it's time for me to get back to this series and spin a v4 (so we can test some more :-) > > This patch series works fin

Re: [Qemu-devel] [kata-dev] [ANNOUNCE] virtio-fs v0.3 release

2019-08-20 Thread Dr. David Alan Gilbert
* Peng Tao (tao.p...@linux.alibaba.com) wrote: > > > On 2019/8/20 00:04, Stefan Hajnoczi wrote: > > I am delighted to announce the release of virtio-fs v0.3, a shared file > > system that lets virtual machines access a directory tree on the host. > > This release is based on QEMU 4.1.0 and Linux

[Qemu-devel] [PATCH v2 0/5] Fix multifd with big number of channels

2019-08-20 Thread Juan Quintela
Hi In this v2: - dropped the already included patches upstream - dropped the semaphore changes - add backlog listen parameter through all the call chain (danp suggestion) - also add the change for qio_channel_socket_async(), for consistency (it has zero users on tree anyways) - for "fd" case, I

[Qemu-devel] [PATCH v2 2/5] socket: Add num connections to qio_channel_socket_sync()

2019-08-20 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/io/channel-socket.h| 2 ++ io/channel-socket.c| 7 --- io/net-listener.c | 2 +- io/trace-events| 2 +- scsi/qemu-pr-helper.c | 2 +- tests/test-char.c | 4 ++-- tests/test-io-channel-s

[Qemu-devel] [PATCH v2 1/5] socket: Add backlog parameter to socket_listen

2019-08-20 Thread Juan Quintela
Current parameter was always one. We continue with that value for now in all callers. Signed-off-by: Juan Quintela --- include/qemu/sockets.h| 2 +- io/channel-socket.c | 2 +- qga/channel-posix.c | 2 +- tests/test-util-sockets.c | 12 ++-- util/qemu-sockets.c

[Qemu-devel] [PATCH v2 4/5] socket: Add num connections to qio_net_listener_open_sync()

2019-08-20 Thread Juan Quintela
Signed-off-by: Juan Quintela --- blockdev-nbd.c| 2 +- chardev/char-socket.c | 2 +- include/io/net-listener.h | 2 ++ io/net-listener.c | 3 ++- migration/socket.c| 2 +- qemu-nbd.c| 2 +- scsi/qemu-pr-helper.c | 3 ++- ui/vnc.c

[Qemu-devel] [PATCH v2 3/5] socket: Add num connections to qio_channel_socket_async()

2019-08-20 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/io/channel-socket.h| 2 ++ io/channel-socket.c| 30 +++--- io/trace-events| 2 +- tests/test-io-channel-socket.c | 2 +- 4 files changed, 27 insertions(+), 9 deletions(-) diff --git a/include/io/c

Re: [Qemu-devel] [PATCH 0/4] backup: fix skipping unallocated clusters

2019-08-20 Thread Vladimir Sementsov-Ogievskiy
16.08.2019 22:11, John Snow wrote: > > > On 8/14/19 12:54 PM, Vladimir Sementsov-Ogievskiy wrote: >> >> >> 14 авг. 2019 г. 17:43 пользователь Vladimir Sementsov-Ogievskiy >> написал: >> >> Hi all! >> >> There is a bug in not yet merged patch >> "block/backup: teach TOP to never co

[Qemu-devel] [PATCH v2 5/5] multifd: Use number of channels as listen backlog

2019-08-20 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/socket.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/migration/socket.c b/migration/socket.c index e63f5e1612..97c9efde59 100644 --- a/migration/socket.c +++ b/migration/socket.c @@ -178,10 +178,15 @@ static void socket_star

Re: [Qemu-devel] [PATCH v9 05/11] numa: Extend CLI to provide initiator information for numa nodes

2019-08-20 Thread Tao Xu
On 8/16/2019 10:57 PM, Igor Mammedov wrote: On Wed, 14 Aug 2019 19:31:27 -0700 Dan Williams wrote: On Wed, Aug 14, 2019 at 6:57 PM Tao Xu wrote: On 8/15/2019 5:29 AM, Dan Williams wrote: On Tue, Aug 13, 2019 at 10:14 PM Tao Xu wrote: On 8/14/2019 10:39 AM, Dan Williams wrote: On Tue, A

Re: [Qemu-devel] [PATCH v2 1/5] socket: Add backlog parameter to socket_listen

2019-08-20 Thread Daniel P . Berrangé
On Tue, Aug 20, 2019 at 10:24:55AM +0200, Juan Quintela wrote: > Current parameter was always one. We continue with that value for now > in all callers. > > Signed-off-by: Juan Quintela > --- > include/qemu/sockets.h| 2 +- > io/channel-socket.c | 2 +- > qga/channel-posix.c |

Re: [Qemu-devel] [PATCH v2 2/5] socket: Add num connections to qio_channel_socket_sync()

2019-08-20 Thread Daniel P . Berrangé
On Tue, Aug 20, 2019 at 10:24:56AM +0200, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > include/io/channel-socket.h| 2 ++ > io/channel-socket.c| 7 --- > io/net-listener.c | 2 +- > io/trace-events| 2 +- > scsi/qemu-pr-helper.c

Re: [Qemu-devel] [PATCH v2 3/5] socket: Add num connections to qio_channel_socket_async()

2019-08-20 Thread Daniel P . Berrangé
On Tue, Aug 20, 2019 at 10:24:57AM +0200, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > include/io/channel-socket.h| 2 ++ > io/channel-socket.c| 30 +++--- > io/trace-events| 2 +- > tests/test-io-channel-socket.c | 2 +- >

Re: [Qemu-devel] [PATCH v2 4/5] socket: Add num connections to qio_net_listener_open_sync()

2019-08-20 Thread Daniel P . Berrangé
On Tue, Aug 20, 2019 at 10:24:58AM +0200, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > blockdev-nbd.c| 2 +- > chardev/char-socket.c | 2 +- > include/io/net-listener.h | 2 ++ > io/net-listener.c | 3 ++- > migration/socket.c| 2 +- > qemu-nbd.c

Re: [Qemu-devel] [PATCH v2 5/5] multifd: Use number of channels as listen backlog

2019-08-20 Thread Daniel P . Berrangé
On Tue, Aug 20, 2019 at 10:24:59AM +0200, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > migration/socket.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com

Re: [Qemu-devel] [PATCH v3 00/15] target/arm/kvm: enable SVE in guests

2019-08-20 Thread Andrea Bolognani
On Tue, 2019-08-20 at 09:53 +0200, Andrew Jones wrote: > On Tue, Aug 20, 2019 at 06:08:04AM +, Zhang, Lei wrote: > > Hi Andrew, > > > > I have tested your patch on kernel- 5.2.7 + QEMU (4.0.94 + patch). > > Thanks for the testing! I guess it's time for me to get back to this > series and spin

Re: [Qemu-devel] [PATCH] nbd: Tolerate more errors to structured reply request

2019-08-20 Thread Vladimir Sementsov-Ogievskiy
19.08.2019 20:57, Eric Blake wrote: > A server may have a reason to reject a request for structured replies, > beyond just not recognizing them as a valid request. It doesn't hurt > us to continue talking to such a server; otherwise 'qemu-nbd --list' > of such a server fails to display all possibl

Re: [Qemu-devel] [PATCH] nbd: Advertise multi-conn for shared read-only connections

2019-08-20 Thread Vladimir Sementsov-Ogievskiy
17.08.2019 17:30, Eric Blake wrote: > On 8/16/19 5:47 AM, Vladimir Sementsov-Ogievskiy wrote: > +++ b/blockdev-nbd.c @@ -189,7 +189,7 @@ void qmp_nbd_server_add(const char *device, bool has_name, const char *name,   }   exp = nbd_export_new(bs, 0, len, name

Re: [Qemu-devel] [PATCH v2 1/5] socket: Add backlog parameter to socket_listen

2019-08-20 Thread Juan Quintela
Daniel P. Berrangé wrote: > On Tue, Aug 20, 2019 at 10:24:55AM +0200, Juan Quintela wrote: >> Current parameter was always one. We continue with that value for now >> in all callers. >> >> Signed-off-by: Juan Quintela >> @@ -309,7 +311,8 @@ static int inet_listen_saddr(InetSocketAddress *saddr

Re: [Qemu-devel] [PULL 0/3] decodetree improvements

2019-08-20 Thread Peter Maydell
On Mon, 19 Aug 2019 at 16:17, Richard Henderson wrote: > > The following changes since commit 3fbd3405d2b0604ea530fc7a1828f19da1e95ff9: > > Merge remote-tracking branch > 'remotes/huth-gitlab/tags/pull-request-2019-08-17' into staging (2019-08-19 > 14:14:09 +0100) > > are available in the Git

[Qemu-devel] [Bug 1819289] Re: Windows 95 and Windows 98 will not install or run

2019-08-20 Thread Dr. David Alan Gilbert
Yep, these types of bugs don't necessarily bisect cleanly if they're todo with code layout or dirty memory. Still, it's good to keep a note of the earliest patches that you find a failure on - because then we know it must be somewhere before that. I remember there was a problem reported booting

Re: [Qemu-devel] [PULL 00/36] QEMU patches for 2018-08-20

2019-08-20 Thread Peter Maydell
On Tue, 20 Aug 2019 at 08:02, Paolo Bonzini wrote: > > The following changes since commit 864ab314f1d924129d06ac7b571f105a2b76a4b2: > > Update version for v4.1.0-rc4 release (2019-08-06 17:05:21 +0100) > > are available in the git repository at: > > git://github.com/bonzini/qemu.git tags/for-u

[Qemu-devel] Difference between commit and rebase

2019-08-20 Thread lampahome
I want to remove snapshots and I found two ways: qemu-img commit qemu-img rebase I found they both can choose where to rebase(merge) the images. commit can truncate or not on specific image. rebase won't truncate rebased image. I found they have something similarity and I don't know what situatio

[Qemu-devel] [Bug 1840719] Re: win98se floppy fails to boot with isapc machine

2019-08-20 Thread Philippe Mathieu-Daudé
Apparently the bisection result from comment #1 comes from a different issue, the VGA display stays blank, can not test the floppy drive. Bisecting using the pcbios.bin from fd646122418~, the VGA display stops working at: 345c22aa80d1f6ddfe7898f721fd1be3bccb08f1 is the first bad commit commit 345

[Qemu-devel] [Bug 1840719] Re: win98se floppy fails to boot with isapc machine

2019-08-20 Thread Philippe Mathieu-Daudé
So finally, the commit that introduced this regression is not directly related to QEMU: 0b8f74488e50f98b04e63157f85fde8a13f8d6aa is the first bad commit commit 0b8f74488e50f98b04e63157f85fde8a13f8d6aa Author: Gerd Hoffmann Date: Tue Nov 6 12:23:53 2018 +0100 update seabios to master snapsh

Re: [Qemu-devel] [PATCH v4 2/2] char-socket: Lock tcp_chr_disconnect() and socket_reconnect_timeout()

2019-08-20 Thread Daniel P . Berrangé
On Mon, Aug 12, 2019 at 06:58:29PM +0300, Andrey Shinkevich wrote: > From: Alberto Garcia > > There's a race condition in which the tcp_chr_read() ioc handler can > close a connection that is being written to from another thread. > > Running iotest 136 in a loop triggers this problem and crashes

[Qemu-devel] [Bug 1840719] Re: win98se floppy fails to boot with isapc machine

2019-08-20 Thread Philippe Mathieu-Daudé
And the (SeaBIOS) winner is... 4a6dbcea3e412fe12effa2f812f50dd7eae90955 is the first bad commit commit 4a6dbcea3e412fe12effa2f812f50dd7eae90955 Author: Nikolay Nikolov Date: Sun Feb 4 17:27:01 2018 +0200 floppy: Use timer_check() in floppy_wait_irq() Use timer_check() instead of u

[Qemu-devel] QEMU as ISS (Instruction Set Simulator)

2019-08-20 Thread ??
I am working on a project that requires me to modify the ISA of the MIPS target. I have been staring at the source code for about a week, but found it really difficult due to me being a young rookie and the sparse comments. Specifically, I need to extend MIPS, by adding some new instructions and

Re: [Qemu-devel] QEMU as ISS (Instruction Set Simulator)

2019-08-20 Thread Peter Maydell
On Tue, 20 Aug 2019 at 11:12, 立 wrote: > > I am working on a project that requires me to modify the ISA of the MIPS > target. I have been staring at the source code for about a week, but found it > really difficult due to me being a young rookie and the sparse comments. > Specifically, I need to

[Qemu-devel] Regression with floppy drive controller

2019-08-20 Thread Philippe Mathieu-Daudé
[cross posting QEMU & SeaBIOS] Hello, I'v been looking at a QEMU bug report [1] which bisection resulted in a SeaBIOS commit: 4a6dbcea3e412fe12effa2f812f50dd7eae90955 is the first bad commit commit 4a6dbcea3e412fe12effa2f812f50dd7eae90955 Author: Nikolay Nikolov Date: Sun Feb 4 17:27:01 2018

Re: [Qemu-devel] Difference between commit and rebase

2019-08-20 Thread Philippe Mathieu-Daudé
Cc'ing qemu-block@ On 8/20/19 11:27 AM, lampahome wrote: > I want to remove snapshots and I found two ways: > qemu-img commit > qemu-img rebase > > I found they both can choose where to rebase(merge) the images. > commit can truncate or not on specific image. > rebase won't truncate rebased image

[Qemu-devel] [PATCH] i386/kvm: fix FEATURE_HYPERV_EDX value in hyperv_passthrough case

2019-08-20 Thread Zhenyu Wang
Fix typo to use correct edx value for FEATURE_HYPERV_EDX when hyperv_passthrough is enabled. Signed-off-by: Zhenyu Wang --- target/i386/kvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/i386/kvm.c b/target/i386/kvm.c index 2abc881324..101229bce4 100644 --- a/target

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc: Three floating point fixes

2019-08-20 Thread Peter Maydell
On Tue, 20 Aug 2019 at 08:36, David Gibson wrote: > On Mon, Aug 19, 2019 at 12:13:34PM -0500, Paul Clarke wrote: > > These issues were found while running Glibc's test suite for "math", > > and there are still a *LOT* of QEMU-only FAILs, so I may be back > > again with suggested fixes or questions

Re: [Qemu-devel] QEMU as ISS (Instruction Set Simulator)

2019-08-20 Thread Aleksandar Markovic
On Tue, Aug 20, 2019 at 12:12 PM 立 wrote: > I am working on a project that requires me to modify the ISA of the MIPS > target. I have been staring at the source code for about a week, but found > it really difficult due to me being a young rookie and the sparse comments. > Specifically, I need to

Re: [Qemu-devel] Machine specific option ROMs

2019-08-20 Thread BALATON Zoltan
On Tue, 20 Aug 2019, Gerd Hoffmann wrote: For example in qemu 1.5 the nic roms got EFI support and there is a compat property which switches the pc-i440fx-1.4 (and older) machine types to the non-efi versions. Grep for pxe-e1000.rom to find the code. Note that roms with a pci firmware standard

[Qemu-devel] [PATCH v3 1/5] socket: Add backlog parameter to socket_listen

2019-08-20 Thread Juan Quintela
Current parameter was always one. We continue with that value for now in all callers. Signed-off-by: Juan Quintela --- Moved trace to socket_listen --- include/qemu/sockets.h| 2 +- io/channel-socket.c | 2 +- qga/channel-posix.c | 2 +- tests/test-util-sockets.c | 12 ++

[Qemu-devel] [PATCH v3 2/5] socket: Add num connections to qio_channel_socket_sync()

2019-08-20 Thread Juan Quintela
Reviewed-by: Daniel P. Berrangé Signed-off-by: Juan Quintela --- include/io/channel-socket.h| 2 ++ io/channel-socket.c| 7 --- io/net-listener.c | 2 +- io/trace-events| 2 +- scsi/qemu-pr-helper.c | 3 ++- tests/test-char.c

[Qemu-devel] [PATCH v3 0/5] Fix multifd with big number of channels

2019-08-20 Thread Juan Quintela
Hi In this version: - updated to latest upstream - moved trace to suggested position (danp) Please review. Later, Juan. Juan Quintela (5): socket: Add backlog parameter to socket_listen socket: Add num connections to qio_channel_socket_sync() socket: Add num connections to qio_channel_so

[Qemu-devel] [PATCH v3 3/5] socket: Add num connections to qio_channel_socket_async()

2019-08-20 Thread Juan Quintela
Reviewed-by: Daniel P. Berrangé Signed-off-by: Juan Quintela --- include/io/channel-socket.h| 2 ++ io/channel-socket.c| 30 +++--- io/trace-events| 2 +- tests/test-io-channel-socket.c | 2 +- 4 files changed, 27 insertions(+), 9 deleti

[Qemu-devel] [PATCH v3 4/5] socket: Add num connections to qio_net_listener_open_sync()

2019-08-20 Thread Juan Quintela
Reviewed-by: Daniel P. Berrangé Signed-off-by: Juan Quintela --- blockdev-nbd.c| 2 +- chardev/char-socket.c | 2 +- include/io/net-listener.h | 2 ++ io/net-listener.c | 3 ++- migration/socket.c| 2 +- qemu-nbd.c| 2 +- ui/vnc.c

[Qemu-devel] [PATCH v3 5/5] multifd: Use number of channels as listen backlog

2019-08-20 Thread Juan Quintela
Reviewed-by: Daniel P. Berrangé Signed-off-by: Juan Quintela --- migration/socket.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/migration/socket.c b/migration/socket.c index e63f5e1612..97c9efde59 100644 --- a/migration/socket.c +++ b/migration/socket.c @@ -178,10 +

Re: [Qemu-devel] [PATCH v3 1/5] socket: Add backlog parameter to socket_listen

2019-08-20 Thread Daniel P . Berrangé
On Tue, Aug 20, 2019 at 12:48:32PM +0200, Juan Quintela wrote: > Current parameter was always one. We continue with that value for now > in all callers. > > Signed-off-by: Juan Quintela > > --- > Moved trace to socket_listen > --- > include/qemu/sockets.h| 2 +- > io/channel-socket.c

Re: [Qemu-devel] [PATCH v4 2/2] char-socket: Lock tcp_chr_disconnect() and socket_reconnect_timeout()

2019-08-20 Thread Andrey Shinkevich
On 20/08/2019 12:58, Daniel P. Berrangé wrote: > On Mon, Aug 12, 2019 at 06:58:29PM +0300, Andrey Shinkevich wrote: >> From: Alberto Garcia >> >> There's a race condition in which the tcp_chr_read() ioc handler can >> close a connection that is being written to from another thread. >> >> Running

Re: [Qemu-devel] [PATCH v3 1/5] socket: Add backlog parameter to socket_listen

2019-08-20 Thread Juan Quintela
Daniel P. Berrangé wrote: > On Tue, Aug 20, 2019 at 12:48:32PM +0200, Juan Quintela wrote: >> Current parameter was always one. We continue with that value for now >> in all callers. >> >> Signed-off-by: Juan Quintela >> >> --- >> Moved trace to socket_listen >> --- >> include/qemu/sockets.h

Re: [Qemu-devel] [PATCH v2 04/16] qcow2: Keep unknown extra snapshot data

2019-08-20 Thread Max Reitz
On 19.08.19 21:23, Eric Blake wrote: > On 8/19/19 1:55 PM, Max Reitz wrote: >> The qcow2 specification says to ignore unknown extra data fields in >> snapshot table entries. Currently, we discard it whenever we update the >> image, which is a bit different from "ignore". >> >> This patch makes the

Re: [Qemu-devel] [PATCH v2 04/16] qcow2: Keep unknown extra snapshot data

2019-08-20 Thread Max Reitz
On 19.08.19 21:34, Eric Blake wrote: > On 8/19/19 1:55 PM, Max Reitz wrote: >> The qcow2 specification says to ignore unknown extra data fields in >> snapshot table entries. Currently, we discard it whenever we update the >> image, which is a bit different from "ignore". >> >> This patch makes the

Re: [Qemu-devel] [PATCH v2 10/16] qcow2: Fix broken snapshot table entries

2019-08-20 Thread Max Reitz
On 19.08.19 21:37, Eric Blake wrote: > On 8/19/19 1:55 PM, Max Reitz wrote: >> The only case where we currently reject snapshot table entries is when >> they have too much extra data. Fix them with qemu-img check -r all by >> counting it as a corruption, reducing their extra_data_size, and then >>

Re: [Qemu-devel] [PATCH v2 16/16] iotests: Test qcow2's snapshot table handling

2019-08-20 Thread Max Reitz
On 19.08.19 22:25, Eric Blake wrote: > On 8/19/19 1:56 PM, Max Reitz wrote: >> Add a test how our qcow2 driver handles extra data in snapshot table >> entries, and how it repairs overly long snapshot tables. >> >> Signed-off-by: Max Reitz >> --- > >> +++ b/tests/qemu-iotests/261.out >> @@ -0,0 +1

Re: [Qemu-devel] [PATCH v2 12/16] qcow2: Fix overly long snapshot tables

2019-08-20 Thread Max Reitz
On 19.08.19 21:43, Eric Blake wrote: > On 8/19/19 1:55 PM, Max Reitz wrote: >> We currently refuse to open qcow2 images with overly long snapshot >> tables. This patch makes qemu-img check -r all drop all offending >> entries past what we deem acceptable. >> >> Signed-off-by: Max Reitz >> --- >>

Re: [Qemu-devel] [PATCH v2 13/16] qcow2: Repair snapshot table with too many entries

2019-08-20 Thread Max Reitz
On 19.08.19 21:45, Eric Blake wrote: > On 8/19/19 1:55 PM, Max Reitz wrote: >> Signed-off-by: Max Reitz >> --- > > Short on the reasoning why this isn't a problem in practice. (Again, > because we only do it via opt-in qemu-img -r; you can already learn if > qemu-img will have problem with your

  1   2   3   >