Re: [Qemu-devel] [PATCH] linux-user: add memfd_create

2019-08-19 Thread Marc-André Lureau
On Sat, Aug 17, 2019 at 1:28 AM Shu-Chun Weng via Qemu-devel wrote: > > Add support for the memfd_create syscall. If the host does not have the > libc wrapper, translate to a direct syscall with NC-macro. > > Buglink: https://bugs.launchpad.net/qemu/+bug/1734792 > Signed-off-by: Shu-Chun Weng Re

[Qemu-devel] [PATCH] iotests: Check for enabled drivers before testing them

2019-08-19 Thread Thomas Huth
It is possible to enable only a subset of the block drivers with the "--block-drv-rw-whitelist" option of the "configure" script. All other drivers are marked as unusable (or only included as read-only with the "--block-drv-ro-whitelist" option). If an iotest is now using such a disabled block driv

Re: [Qemu-devel] [PATCH for-4.2 v10 08/15] virtio-iommu: Implement map/unmap

2019-08-19 Thread Peter Xu
On Tue, Jul 30, 2019 at 07:21:30PM +0200, Eric Auger wrote: [...] > +mapping = g_tree_lookup(domain->mappings, (gpointer)(&interval)); > + > +while (mapping) { > +viommu_interval current; > +uint64_t low = mapping->virt_addr; > +uint64_t high = mapping->virt_addr

Re: [Qemu-devel] [PATCH] iotests: Check for enabled drivers before testing them

2019-08-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190819075348.4078-1-th...@redhat.com/ Hi, This series failed build test on s390x host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commit that has

Re: [Qemu-devel] [PATCH for-4.2 v10 09/15] virtio-iommu: Implement translate

2019-08-19 Thread Peter Xu
On Tue, Jul 30, 2019 at 07:21:31PM +0200, Eric Auger wrote: > @@ -464,19 +464,75 @@ static IOMMUTLBEntry > virtio_iommu_translate(IOMMUMemoryRegion *mr, hwaddr addr, > int iommu_idx) > { > IOMMUDevice *sdev = container_of(mr, IOMMUDevice, iommu_mr

[Qemu-devel] [PATCH V2 0/2] Add support for powerpc acceptance test

2019-08-19 Thread sathnaga
From: Satheesh Rajendran This series attempt to add support for avocado acceptance test for powerpc and adds linux console boot test. avocado run boot_linux_console.py:BootLinuxConsole.test_ppc64le_pseries version.py vnc.py JOB ID : ec1e09d8259bc0c79eacdb4353df6223be369b84 JOB LOG: /hom

[Qemu-devel] [PATCH V2 1/2] tests.acceptance.avocado_qemu: Add support for powerpc

2019-08-19 Thread sathnaga
From: Satheesh Rajendran Current acceptance test will not run properly in powerpc environment due qemu target is different from arch, this usually matches, except with bi-endian architectures like ppc64. uname would return `ppc64` or `ppc64le` based `big` or `little` endian but qemu `target` is a

Re: [Qemu-devel] [PATCH 3/6] migration: Make sure that all multifd channels have been created

2019-08-19 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> If we start the migration before all have been created, we have to >> handle the case that one channel still don't exist. This way it is >> easier. >> >> Signed-off-by: Juan Quintela >> @@ -3486,6 +3492,14 @@ stat

[Qemu-devel] [PATCH V2 2/2] tests.acceptance.boot_linux_console: Add pseries linux boot console test

2019-08-19 Thread sathnaga
From: Satheesh Rajendran Add pseries linux boot console test $avocado --show=console run -t arch:ppc64le boot_linux_console.py console: SLOF ** console: QEMU Starting console: Build Date = Jul 3 2019 12:26:14 console: FW Vers

Re: [Qemu-devel] [PATCH v2] x86: Intel AVX512_BF16 feature enabling

2019-08-19 Thread Jing Liu
Ping~ :) Thanks, Jing On 7/25/2019 2:14 PM, Jing Liu wrote: Intel CooperLake cpu adds AVX512_BF16 instruction, defining as CPUID.(EAX=7,ECX=1):EAX[bit 05]. The patch adds a property for setting the subleaf of CPUID leaf 7 in case that people would like to specify it. The release spec link as

[Qemu-devel] [PATCH] iotests: Add more "skip_if_unsupported" statements to the python tests

2019-08-19 Thread Thomas Huth
The python code already contains a possibility to skip tests if the corresponding driver is not available in the qemu binary - use it in more spots to avoid that the tests are failing if the driver has been disabled. Signed-off-by: Thomas Huth --- tests/qemu-iotests/030 | 3 +++ tests/qemu-iote

[Qemu-devel] [Bug 1772165] Re: arm raspi2/raspi3 emulation has no USB support

2019-08-19 Thread Peter Maydell
Thanks for digging those up. Unfortunately just the driver sources aren't really enough information for a good device model, and the other docs are just overviews without the level of detail we need. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscr

Re: [Qemu-devel] [PATCH 0/2] memory: Fix up coalesced_io_del not working for KVM

2019-08-19 Thread Peter Xu
On Sat, Aug 17, 2019 at 05:32:35PM +0800, Peter Xu wrote: > I can easily crash QEMU as long as KVM is used with e1000 and reboot > many times, then I hit this and QEMU aborts [1]: > > kvm_mem_ioeventfd_add: error adding ioeventfd: No space left on device (28) Reproducer: bin=x86_64-softmmu/qem

Re: [Qemu-devel] [PATCH v3 1/6] s390x/mmu: Trace the right value if setting/getting the storage key fails

2019-08-19 Thread Cornelia Huck
On Fri, 16 Aug 2019 10:47:03 +0200 David Hildenbrand wrote: > We want to trace the actual return value, not "0". > > Fixes: 0f5f669147b5 (s390x: Enable new s390-storage-keys device) Fixes: 0f5f669147b5 ("s390x: Enable new s390-storage-keys device") :) > Reviewed-by: Cornelia Huck > Reviewed-

Re: [Qemu-devel] [PATCH v3 3/6] s390x/tcg: Rework MMU selection for instruction fetches

2019-08-19 Thread Cornelia Huck
On Fri, 16 Aug 2019 10:47:05 +0200 David Hildenbrand wrote: > Instructions are always fetched from primary address space, except when > in home address mode. Perform the selection directly in cpu_mmu_index(). > > get_mem_index() is only used to perform data access, instructions are > fetched via

Re: [Qemu-devel] [PATCH v3 0/6] s390x/mmu: Storage key reference and change bit handling

2019-08-19 Thread Cornelia Huck
On Fri, 16 Aug 2019 10:47:02 +0200 David Hildenbrand wrote: > The first two patches are modified patches from: > [PATCH-for-4.2 v1 0/9] s390x: MMU changes and extensions > > This series primarily fixes minor things in the storage key handling code > in the MMU and implements fairly reliable

Re: [Qemu-devel] [RFC PATCH 0/7] qemu: CCIX pcie config space emulation

2019-08-19 Thread Jonathan Cameron
On Fri, 16 Aug 2019 13:59:02 +0100 Peter Maydell wrote: > On Tue, 25 Jun 2019 at 12:28, Jonathan Cameron > wrote: > > > > CCIX topologies are 'layered' on top of PCIe tree topologies. > > This is done primarily by allowing a single CCIX device to appear as > > multiple disjoint nodes in the PCIe

Re: [Qemu-devel] [PATCH 6/6] RFH: We lost "connect" events

2019-08-19 Thread Daniel P . Berrangé
On Wed, Aug 14, 2019 at 04:02:18AM +0200, Juan Quintela wrote: > When we have lots of channels, sometimes multifd migration fails > with the following error: > > (qemu) migrate -d tcp:0: > (qemu) qemu-system-x86_64: multifd_send_pages: channel 17 has already quit! > qemu-system-x86_64: multifd

Re: [Qemu-devel] [PATCH v3 0/6] s390x/mmu: Storage key reference and change bit handling

2019-08-19 Thread David Hildenbrand
On 19.08.19 11:46, Cornelia Huck wrote: > On Fri, 16 Aug 2019 10:47:02 +0200 > David Hildenbrand wrote: > >> The first two patches are modified patches from: >> [PATCH-for-4.2 v1 0/9] s390x: MMU changes and extensions >> >> This series primarily fixes minor things in the storage key handling

Re: [Qemu-devel] [qemu-s390x] linux-user: s390x issue on Fedora 30 (dynamic library loader?)

2019-08-19 Thread Laurent Vivier
Le 17/08/2019 à 18:51, David Hildenbrand a écrit : > On 17.08.19 18:22, Laurent Vivier wrote: >> Le 17/08/2019 à 18:14, David Hildenbrand a écrit : >>> On 17.08.19 17:59, David Hildenbrand wrote: Hi everybody, I was just trying to run qemu-s390x (linux-user) with a very simple b

Re: [Qemu-devel] [PATCH 6/6] RFH: We lost "connect" events

2019-08-19 Thread Juan Quintela
Daniel P. Berrangé wrote: > On Wed, Aug 14, 2019 at 04:02:18AM +0200, Juan Quintela wrote: >> When we have lots of channels, sometimes multifd migration fails >> with the following error: >> after some time, sending side decides to send another packet through >> that channel, and it is now whe

Re: [Qemu-devel] [PATCH 6/6] RFH: We lost "connect" events

2019-08-19 Thread Daniel P . Berrangé
On Mon, Aug 19, 2019 at 12:33:45PM +0200, Juan Quintela wrote: > Daniel P. Berrangé wrote: > > On Wed, Aug 14, 2019 at 04:02:18AM +0200, Juan Quintela wrote: > >> When we have lots of channels, sometimes multifd migration fails > >> with the following error: > >> after some time, sending side de

Re: [Qemu-devel] [PATCH 6/6] RFH: We lost "connect" events

2019-08-19 Thread Juan Quintela
Daniel P. Berrangé wrote: > On Wed, Aug 14, 2019 at 04:02:18AM +0200, Juan Quintela wrote: >> When we have lots of channels, sometimes multifd migration fails >> with the following error: >> >> Any good ideas? > > In inet_listen_saddr() we call > > if (!listen(slisten, 1)) { > > note the seco

Re: [Qemu-devel] [PATCH 6/6] RFH: We lost "connect" events

2019-08-19 Thread Juan Quintela
Daniel P. Berrangé wrote: > On Wed, Aug 14, 2019 at 04:02:18AM +0200, Juan Quintela wrote: >> When we have lots of channels, sometimes multifd migration fails >> with the following error: >> >> Any good ideas? > > In inet_listen_saddr() we call > > if (!listen(slisten, 1)) { > > note the seco

Re: [Qemu-devel] [PATCH 6/6] RFH: We lost "connect" events

2019-08-19 Thread Daniel P . Berrangé
On Mon, Aug 19, 2019 at 12:46:20PM +0200, Juan Quintela wrote: > Daniel P. Berrangé wrote: > > On Wed, Aug 14, 2019 at 04:02:18AM +0200, Juan Quintela wrote: > >> When we have lots of channels, sometimes multifd migration fails > >> with the following error: > >> > >> Any good ideas? > > > > In i

Re: [Qemu-devel] [PATCH 6/6] RFH: We lost "connect" events

2019-08-19 Thread Juan Quintela
Daniel P. Berrangé wrote: > On Mon, Aug 19, 2019 at 12:46:20PM +0200, Juan Quintela wrote: >> Daniel P. Berrangé wrote: >> > On Wed, Aug 14, 2019 at 04:02:18AM +0200, Juan Quintela wrote: >> >> When we have lots of channels, sometimes multifd migration fails >> >> with the following error: >> >>

[Qemu-devel] [Webpage PATCH] add support page

2019-08-19 Thread Alex Bennée
This is intended to be a useful page we can link to in the banner of the IRC channel explaining the various support options someone might have. Signed-off-by: Alex Bennée --- support.md | 37 + 1 file changed, 37 insertions(+) create mode 100644 support.md d

Re: [Qemu-devel] [PATCH 6/6] RFH: We lost "connect" events

2019-08-19 Thread Peter Maydell
On Mon, 19 Aug 2019 at 11:50, Daniel P. Berrangé wrote: > I don't think we want to expose this in the QAPI schema for the socket > address, since the correct value is really something that QEMU should > figure out based on usage context. > > Thus, I think we'll have to make it an explicit paramete

Re: [Qemu-devel] [PATCH 6/6] RFH: We lost "connect" events

2019-08-19 Thread Daniel P . Berrangé
On Mon, Aug 19, 2019 at 12:00:15PM +0100, Peter Maydell wrote: > On Mon, 19 Aug 2019 at 11:50, Daniel P. Berrangé wrote: > > I don't think we want to expose this in the QAPI schema for the socket > > address, since the correct value is really something that QEMU should > > figure out based on usag

Re: [Qemu-devel] [PATCH v3 4/6] s390x/tcg: Flush the TLB of all CPUs on SSKE and RRBE

2019-08-19 Thread Alex Bennée
David Hildenbrand writes: > Whenever we modify a storage key, we should flush the TLBs of all CPUs, > so the MMU fault handling code can properly consider the changed storage > key (to e.g., properly set the reference and change bit on the next > accesses). > > These functions are barely used i

Re: [Qemu-devel] [PATCH 5/6] migration: add some multifd traces

2019-08-19 Thread Philippe Mathieu-Daudé
On 8/14/19 4:02 AM, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > migration/ram.c| 3 +++ > migration/trace-events | 4 > 2 files changed, 7 insertions(+) > > diff --git a/migration/ram.c b/migration/ram.c > index f1aec95f83..25a211c3fb 100644 > --- a/migration/ram.c >

Re: [Qemu-devel] [PATCH 1/6] migration: Add traces for multifd terminate threads

2019-08-19 Thread Philippe Mathieu-Daudé
On 8/14/19 4:02 AM, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > migration/ram.c| 4 > migration/trace-events | 2 ++ > 2 files changed, 6 insertions(+) > > diff --git a/migration/ram.c b/migration/ram.c > index 889148dd84..ca11d43e30 100644 > --- a/migration/ram.c >

Re: [Qemu-devel] [PATCH 5/6] migration: add some multifd traces

2019-08-19 Thread Philippe Mathieu-Daudé
On 8/19/19 1:10 PM, Philippe Mathieu-Daudé wrote: > On 8/14/19 4:02 AM, Juan Quintela wrote: >> Signed-off-by: Juan Quintela >> --- >> migration/ram.c| 3 +++ >> migration/trace-events | 4 >> 2 files changed, 7 insertions(+) >> >> diff --git a/migration/ram.c b/migration/ram.c >> in

Re: [Qemu-devel] [PATCH v4 14/14] audio: fix memory leak reported by ASAN

2019-08-19 Thread Philippe Mathieu-Daudé
On 8/19/19 4:05 AM, Zoltán Kővágó wrote: > Hi, > > On 2019-08-19 01:25, Philippe Mathieu-Daudé wrote: >> Hi Zoltán, >> >> On 8/19/19 1:06 AM, Kővágó, Zoltán wrote: >>> Signed-off-by: Kővágó, Zoltán >>> --- >>> audio/audio.c | 6 ++ >>> 1 file changed, 6 insertions(+) >>> >>> diff --git a/aud

Re: [Qemu-devel] [PATCH] migrtion: define MigrationState/MigrationIncomingState.state as MigrationStatus

2019-08-19 Thread Dr. David Alan Gilbert
* Wei Yang (richardw.y...@linux.intel.com) wrote: > No functional change. Add default case to fix warning. I think the problem with this is that migrate_set_state uses an atomic_cmpxchg and so we have to be careful that the type we use is compatible with that. MigrationStatus is an enum and I thin

Re: [Qemu-devel] [PATCH] migrtion: define MigrationState/MigrationIncomingState.state as MigrationStatus

2019-08-19 Thread Dr. David Alan Gilbert
* Wei Yang (richardw.y...@linux.intel.com) wrote: > On Fri, Jun 21, 2019 at 10:27:39PM +0800, Wei Yang wrote: > >No functional change. Add default case to fix warning. > > > > Hi, David & Juan > > Do you like this? See other reply; but you are making patches a bit faster than I can review them!

Re: [Qemu-devel] [PULL 00/36] Bitmaps patches

2019-08-19 Thread Peter Maydell
On Sat, 17 Aug 2019 at 00:13, John Snow wrote: > > The following changes since commit afd760539308a5524accf964107cdb1d54a059e3: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20190816' into staging (2019-08-16 > 17:21:40 +0100) > > are available in the Git repository

Re: [Qemu-devel] [qemu-s390x] [PATCH-for-4.2 v1 3/9] s390x/mmu: DAT translation rewrite

2019-08-19 Thread Thomas Huth
On 8/5/19 5:29 PM, David Hildenbrand wrote: > Let's rewrite the DAT translation in a non-recursive way, similar to > arch/s390/kvm/gaccess.c:guest_translate() in KVM. This makes the > code much easier to read, compare and maintain. Ok, I just had another look at this patch, and even if I don't lik

[Qemu-devel] [Bug 1840648] [NEW] qemu-4.1.0/roms/edk2/MdeModulePkg/Universal/Disk/UdfDxe/FileName.c:161: logical fault ?

2019-08-19 Thread dcb
Public bug reported: qemu-4.1.0/roms/edk2/MdeModulePkg/Universal/Disk/UdfDxe/FileName.c:161:71: warning: Logical disjunction always evaluates to true: EXPR != '\\' || EXPR != '\0'. [incorrectLogicOperator] Source code is if ((*(FileName - 1) != L'\\') && ((*(FileName + 2) != L'\\') ||

[Qemu-devel] [Bug 1840646] [NEW] qemu-4.1.0/roms/SLOF/lib/libnet/ping.c:122: logical fault

2019-08-19 Thread dcb
Public bug reported: qemu-4.1.0/roms/SLOF/lib/libnet/ping.c:122:16: warning: Logical conjunction always evaluates to false: alen <= 0 && alen >= sizeof(args) - 1. [incorrectLogicOperator] Source code is if (alen <= 0 && alen >= sizeof(args) - 1) { Maybe better code: if (alen <= 0 || alen

Re: [Qemu-devel] [PATCH v3 4/8] hw/core: Add a config switch for the "register" device

2019-08-19 Thread Philippe Mathieu-Daudé
On 8/17/19 12:19 PM, Thomas Huth wrote: > The "register" device is only used by certain machines. Let's add > a proper config switch for it so that it only gets compiled when we > really need it. > > Signed-off-by: Thomas Huth > --- > hw/Kconfig| 1 + > hw/core/Kconfig | 3 +++

Re: [Qemu-devel] [qemu-s390x] linux-user: s390x issue on Fedora 30 (dynamic library loader?)

2019-08-19 Thread David Hildenbrand
On 19.08.19 12:32, Laurent Vivier wrote: > Le 17/08/2019 à 18:51, David Hildenbrand a écrit : >> On 17.08.19 18:22, Laurent Vivier wrote: >>> Le 17/08/2019 à 18:14, David Hildenbrand a écrit : On 17.08.19 17:59, David Hildenbrand wrote: > Hi everybody, > > I was just trying to run

Re: [Qemu-devel] [PATCH] linux-user: add memfd_create

2019-08-19 Thread Peter Maydell
On Fri, 16 Aug 2019 at 22:28, Shu-Chun Weng via Qemu-devel wrote: > > Add support for the memfd_create syscall. If the host does not have the > libc wrapper, translate to a direct syscall with NC-macro. > > Buglink: https://bugs.launchpad.net/qemu/+bug/1734792 > Signed-off-by: Shu-Chun Weng > ---

Re: [Qemu-devel] [qemu-s390x] [PATCH-for-4.2 v1 3/9] s390x/mmu: DAT translation rewrite

2019-08-19 Thread David Hildenbrand
On 19.08.19 13:40, Thomas Huth wrote: > On 8/5/19 5:29 PM, David Hildenbrand wrote: >> Let's rewrite the DAT translation in a non-recursive way, similar to >> arch/s390/kvm/gaccess.c:guest_translate() in KVM. This makes the >> code much easier to read, compare and maintain. > > Ok, I just had anot

Re: [Qemu-devel] [qemu-s390x] [PATCH-for-4.2 v1 3/9] s390x/mmu: DAT translation rewrite

2019-08-19 Thread Thomas Huth
On 8/19/19 1:58 PM, David Hildenbrand wrote: > On 19.08.19 13:40, Thomas Huth wrote: >> On 8/5/19 5:29 PM, David Hildenbrand wrote: >>> Let's rewrite the DAT translation in a non-recursive way, similar to >>> arch/s390/kvm/gaccess.c:guest_translate() in KVM. This makes the >>> code much easier to r

Re: [Qemu-devel] [qemu-s390x] linux-user: s390x issue on Fedora 30 (dynamic library loader?)

2019-08-19 Thread Laurent Vivier
Le 19/08/2019 à 13:55, David Hildenbrand a écrit : > On 19.08.19 12:32, Laurent Vivier wrote: >> Le 17/08/2019 à 18:51, David Hildenbrand a écrit : >>> On 17.08.19 18:22, Laurent Vivier wrote: Le 17/08/2019 à 18:14, David Hildenbrand a écrit : > On 17.08.19 17:59, David Hildenbrand wrote:

Re: [Qemu-devel] [qemu-s390x] [PATCH-for-4.2 v1 4/9] s390x/mmu: Add EDAT2 translation support

2019-08-19 Thread Thomas Huth
On 8/5/19 5:29 PM, David Hildenbrand wrote: > This only adds basic support to the DAT translation, but no EDAT2 support > for TCG. E.g., the gdbstub under kvm uses this function, too, to > translate virtual addresses. > > Signed-off-by: David Hildenbrand > --- > target/s390x/mmu_helper.c | 8 +++

Re: [Qemu-devel] [qemu-s390x] linux-user: s390x issue on Fedora 30 (dynamic library loader?)

2019-08-19 Thread David Hildenbrand
On 19.08.19 13:55, David Hildenbrand wrote: > On 19.08.19 12:32, Laurent Vivier wrote: >> Le 17/08/2019 à 18:51, David Hildenbrand a écrit : >>> On 17.08.19 18:22, Laurent Vivier wrote: Le 17/08/2019 à 18:14, David Hildenbrand a écrit : > On 17.08.19 17:59, David Hildenbrand wrote: >>

[Qemu-devel] [Bug 1840648] Re: qemu-4.1.0/roms/edk2/MdeModulePkg/Universal/Disk/UdfDxe/FileName.c:161: logical fault ?

2019-08-19 Thread Peter Maydell
This isn't QEMU code -- it's just the source for third-party ROMs that we ship with QEMU because we also ship the ROM binaries. Please report it to the upstream project. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- dev

[Qemu-devel] [Bug 1840646] Re: qemu-4.1.0/roms/SLOF/lib/libnet/ping.c:122: logical fault

2019-08-19 Thread Peter Maydell
(Anything in a git submodule will be third-party code that's not part of QEMU.) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1840646 Title: qemu-4.1.0/roms/SLOF/lib/libnet/ping.c:122: logical faul

[Qemu-devel] [Bug 1840646] Re: qemu-4.1.0/roms/SLOF/lib/libnet/ping.c:122: logical fault

2019-08-19 Thread Peter Maydell
This isn't QEMU code -- it's just the source for third-party ROMs that we ship with QEMU because we also ship the ROM binaries. Please report it to the upstream project. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- dev

Re: [Qemu-devel] [PATCH for-4.2 v10 10/15] virtio-iommu: Implement probe request

2019-08-19 Thread Peter Xu
On Tue, Jul 30, 2019 at 07:21:32PM +0200, Eric Auger wrote: [...] > +/* Fill the properties[] buffer with properties of type @type */ > +static int virtio_iommu_fill_property(int type, > + viommu_property_buffer *bufstate) > +{ > +int ret = -ENOSPC; > + >

[Qemu-devel] [PATCH v8 12/37] target/mips: Style improvements in cps.c

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Fixes mostly errors and warnings reported by 'checkpatch.pl -f'. Signed-off-by: Aleksandar Markovic --- hw/mips/cps.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/mips/cps.c b/hw/mips/cps.c index c84bc64..8fe2f47 100644 --- a/hw/mips/cp

[Qemu-devel] [PATCH v8 09/37] target/mips: Style improvements in machine.c

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Fixes mostly errors and warnings reported by 'checkpatch.pl -f'. Signed-off-by: Aleksandar Markovic Reviewed-by: Philippe Mathieu-Daudé --- target/mips/machine.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/mips/machine.c b/target/mi

[Qemu-devel] [PATCH v8 05/37] target/mips: Add support for emulation of CRC32 group of instructions

2019-08-19 Thread Aleksandar Markovic
From: Yongbok Kim Add emulation of MIPS' CRC32 (Cyclic Redundancy Check) instructions. Reuse zlib crc32() and Linux crc32c(). Note that, at the time being, there is no MIPS CPU that supports CRC32 instructions (they are an optional part of MIPS64/32 R6 anf nanoMIPS ISAs). Signed-off-by: Yongbok

[Qemu-devel] [PATCH v8 00/37] target/mips: Misc patches for 4.2

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic This series includes misc MIPS patches intended to be integrated after 4.1 release. v7->v8: - added several more patches on CP0 cleanup - added a patch on translate.c cleanup - other minor improvements v6->v7: - added four more patches on CP0 cleanup - othe

[Qemu-devel] [PATCH v8 16/37] target/mips: Style improvements in mips_mipssim.c

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Fixes mostly errors and warnings reported by 'checkpatch.pl -f'. Signed-off-by: Aleksandar Markovic --- hw/mips/mips_mipssim.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/hw/mips/mips_mipssim.c b/hw/mips/mips_mipssim.c inde

[Qemu-devel] [PATCH v8 08/37] target/mips: Style improvements in internal.h

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Fixes mostly errors and warnings reported by 'checkpatch.pl -f'. Signed-off-by: Aleksandar Markovic Reviewed-by: Philippe Mathieu-Daudé --- target/mips/internal.h | 57 +++--- 1 file changed, 35 insertions(+), 22 deletions(

[Qemu-devel] [PATCH v8 03/37] target/mips: Amend CP0 MemoryMapID register implementation

2019-08-19 Thread Aleksandar Markovic
From: Yongbok Kim Add migration support and fix preprocessor constant name for MemoryMapID register. Signed-off-by: Yongbok Kim Signed-off-by: Aleksandar Markovic --- target/mips/cpu.h | 2 +- target/mips/machine.c | 7 +-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH v8 30/37] target/mips: Clean up handling of CP0 register 20

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 20. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index ed6d567..0ef29b9 100644 --- a/targe

[Qemu-devel] [PATCH v8 13/37] target/mips: Style improvements in mips_fulong2e.c

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Fixes mostly errors and warnings reported by 'checkpatch.pl -f'. Signed-off-by: Aleksandar Markovic --- hw/mips/mips_fulong2e.c | 96 + 1 file changed, 58 insertions(+), 38 deletions(-) diff --git a/hw/mips/mips_fulong2

[Qemu-devel] [PATCH v8 02/37] target/mips: Amend CP0 WatchHi register implementation

2019-08-19 Thread Aleksandar Markovic
From: Yongbok Kim WatchHi is extended by the field MemoryMapID with the GINVT instruction. The field is accessible by MTHC0/MFHC0 in 32-bit architectures and DMTC0/ DMFC0 in 64-bit architectures. Signed-off-by: Yongbok Kim Signed-off-by: Aleksandar Markovic --- target/mips/cpu.h | 2 +-

[Qemu-devel] [PATCH v8 29/37] target/mips: Clean up handling of CP0 register 17

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 17. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index 729b84d.

[Qemu-devel] [PATCH v8 04/37] target/mips: Add support for emulation of GINVT instruction

2019-08-19 Thread Aleksandar Markovic
From: Yongbok Kim Implement emulation of GINVT instruction. As QEMU doesn't support caches and virtualization, this implementation covers only GINVT (Global Invalidate TLB) instruction among TLB-related instructions. Signed-off-by: Yongbok Kim Signed-off-by: Aleksandar Markovic --- disas/mips

[Qemu-devel] [PATCH v8 07/37] target/mips: Style improvements in cpu.c

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Fixes mostly errors and warnings reported by 'checkpatch.pl -f'. Signed-off-by: Aleksandar Markovic Reviewed-by: Philippe Mathieu-Daudé --- target/mips/cpu.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/target/mips/cpu.c b/ta

[Qemu-devel] [PATCH v8 01/37] target/mips: Add support for DSPRAM

2019-08-19 Thread Aleksandar Markovic
From: Yongbok Kim The optional Data Scratch Pad RAM (DSPRAM) block provides a general scratch pad RAM used for temporary storage of data. The DSPRAM provides a connection to on-chip memory or memory-mapped registers, which are accessed in parallel with the L1 data cache to minimize access laten

[Qemu-devel] [PATCH v8 20/37] target/mips: Clean up handling of CP0 register 5

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 5. Signed-off-by: Aleksandar Markovic --- target/mips/cpu.h | 6 + target/mips/translate.c | 64 - 2 files changed, 38 insertions(+), 32 deletions(-) diff --git a/target/mips

[Qemu-devel] [PATCH v8 14/37] target/mips: Style improvements in mips_int.c

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Fixes mostly errors and warnings reported by 'checkpatch.pl -f'. Signed-off-by: Aleksandar Markovic --- hw/mips/mips_int.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/mips/mips_int.c b/hw/mips/mips_int.c index f899f6c..4c731ab 100644 --- a

[Qemu-devel] [PATCH v8 10/37] target/mips: Style improvements in helper.c

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Fixes mostly errors and warnings reported by 'checkpatch.pl -f'. Signed-off-by: Aleksandar Markovic --- target/mips/helper.c | 98 1 file changed, 60 insertions(+), 38 deletions(-) diff --git a/target/mips/helper.c

[Qemu-devel] [PATCH v8 27/37] target/mips: Clean up handling of CP0 register 15

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 15. Signed-off-by: Aleksandar Markovic --- target/mips/cpu.h | 1 + target/mips/translate.c | 20 ++-- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/target/mips/cpu.h b/target/mips/cpu.h index

[Qemu-devel] [PATCH v8 25/37] target/mips: Clean up handling of CP0 register 11

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 11. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index ac86655..07251a4 100644 --- a/targe

[Qemu-devel] [PATCH v8 06/37] target/mips: Style improvements in cp0_timer.c

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Fixes mostly errors and warnings reported by 'checkpatch.pl -f'. Signed-off-by: Aleksandar Markovic Reviewed-by: Philippe Mathieu-Daudé --- target/mips/cp0_timer.c | 42 +++--- 1 file changed, 23 insertions(+), 19 deletions(-) dif

[Qemu-devel] [PATCH v8 18/37] target/mips: Clean up handling of CP0 register 1

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 1. Signed-off-by: Aleksandar Markovic --- target/mips/cpu.h | 8 +++ target/mips/translate.c | 64 - 2 files changed, 40 insertions(+), 32 deletions(-) diff --git a/target/mi

[Qemu-devel] [PATCH v8 23/37] target/mips: Clean up handling of CP0 register 8

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 8. Signed-off-by: Aleksandar Markovic --- target/mips/cpu.h | 1 + target/mips/translate.c | 32 2 files changed, 17 insertions(+), 16 deletions(-) diff --git a/target/mips/cpu.h b/target/mips/

[Qemu-devel] [PATCH v8 21/37] target/mips: Clean up handling of CP0 register 6

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 6. Signed-off-by: Aleksandar Markovic --- target/mips/cpu.h | 6 ++ target/mips/translate.c | 56 - 2 files changed, 34 insertions(+), 28 deletions(-) diff --git a/target/mip

[Qemu-devel] [PATCH v8 26/37] target/mips: Clean up handling of CP0 register 12

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 12. Signed-off-by: Aleksandar Markovic --- target/mips/cpu.h | 3 +++ target/mips/translate.c | 32 2 files changed, 19 insertions(+), 16 deletions(-) diff --git a/target/mips/cpu.h b/target/mi

[Qemu-devel] [PATCH v8 17/37] target/mips: Clean up handling of CP0 register 0

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 0. Signed-off-by: Aleksandar Markovic --- target/mips/cpu.h | 3 +++ target/mips/translate.c | 40 2 files changed, 23 insertions(+), 20 deletions(-) diff --git a/target/mips/cpu.h b/ta

[Qemu-devel] [PATCH v8 33/37] target/mips: Clean up handling of CP0 register 26

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 26. Signed-off-by: Aleksandar Markovic --- target/mips/cpu.h | 2 +- target/mips/translate.c | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/target/mips/cpu.h b/target/mips/cpu.h index 640..ef405

[Qemu-devel] [PATCH v8 24/37] target/mips: Clean up handling of CP0 register 10

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 10. Signed-off-by: Aleksandar Markovic --- target/mips/cpu.h | 1 + target/mips/translate.c | 8 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/target/mips/cpu.h b/target/mips/cpu.h index c7fdf1d..5e08b7

[Qemu-devel] [PATCH v8 19/37] target/mips: Clean up handling of CP0 register 2

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 2. Signed-off-by: Aleksandar Markovic --- target/mips/cpu.h | 7 ++ target/mips/translate.c | 64 - 2 files changed, 39 insertions(+), 32 deletions(-) diff --git a/target/mip

[Qemu-devel] [PATCH v8 22/37] target/mips: Clean up handling of CP0 register 7

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 7. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index cdcc1cc..abbb924 100644 --- a/target

[Qemu-devel] [PATCH v8 15/37] target/mips: Style improvements in mips_malta.c

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Fixes mostly errors and warnings reported by 'checkpatch.pl -f'. Signed-off-by: Aleksandar Markovic --- hw/mips/mips_malta.c | 216 ++- 1 file changed, 128 insertions(+), 88 deletions(-) diff --git a/hw/mips/mips_malta.

[Qemu-devel] [PATCH v8 32/37] target/mips: Clean up handling of CP0 register 24

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 24. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index 7e243f8..a3a9d34 100644 --- a/targe

[Qemu-devel] [PATCH v8 28/37] target/mips: Clean up handling of CP0 register 16

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 16. Signed-off-by: Aleksandar Markovic --- target/mips/cpu.h | 3 ++- target/mips/translate.c | 60 - 2 files changed, 32 insertions(+), 31 deletions(-) diff --git a/target/mips/

Re: [Qemu-devel] [qemu-s390x] linux-user: s390x issue on Fedora 30 (dynamic library loader?)

2019-08-19 Thread Peter Maydell
On Sat, 17 Aug 2019 at 17:14, David Hildenbrand wrote: > > On 17.08.19 17:59, David Hildenbrand wrote: > > Hi everybody, > > > > I was just trying to run qemu-s390x (linux-user) with a very simple > > binary (gzip + lib/ld64.so.1, compiled under Fedora 27). This used to > > work just fine a while

[Qemu-devel] [PATCH v8 36/37] target/mips: tests/tcg: Add optional printing of more detailed failure info

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic There is a need for printing input and output data for failure cases, for debugging purpose. This is achieved by this patch, and only if a preprocessor constant is manually set to 1. (Assumption is that the need for such printout is relatively rare.) Signed-off-by: Alek

[Qemu-devel] [PULL 08/12] fpu: make softfloat-macros "self-contained"

2019-08-19 Thread Alex Bennée
The macros use the "flags" type and to be consistent if anyone just needs the macros we should bring in the header we need. There is an outstanding TODO to audit the use of "flags" and replace with bool at which point this include could be dropped. Signed-off-by: Alex Bennée Acked-by: Richard Hen

[Qemu-devel] [PATCH v8 11/37] target/mips: Style improvements in translate.c

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Fixes mostly errors and warnings reported by 'checkpatch.pl -f'. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 608 1 file changed, 309 insertions(+), 299 deletions(-) diff --git a/target/mips/transl

[Qemu-devel] [PULL 06/12] fpu: remove the LIT64 macro

2019-08-19 Thread Alex Bennée
Now the rest of the code has been cleaned up we can remove this. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/include/fpu/softfloat.h b/include/fpu/softfloat.h index 3ff3fa52245..d9333eb65b8 100644 --- a/include/fpu/softfloat.h +++ b/include/fpu/softfloat.h @@ -82,8 +8

[Qemu-devel] [PATCH v8 34/37] target/mips: Clean up handling of CP0 register 30

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 30. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index 9025a50..a8bd08a 100644 --- a/targe

[Qemu-devel] [PATCH v8 31/37] target/mips: Clean up handling of CP0 register 23

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 23. Signed-off-by: Aleksandar Markovic --- target/mips/cpu.h | 6 +++ target/mips/translate.c | 126 +++- 2 files changed, 89 insertions(+), 43 deletions(-) diff --git a/target/mips

[Qemu-devel] [PULL 00/12] softfloat header updates

2019-08-19 Thread Alex Bennée
The following changes since commit afd760539308a5524accf964107cdb1d54a059e3: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20190816' into staging (2019-08-16 17:21:40 +0100) are available in the Git repository at: https://github.com/stsquad/qemu.git tags/pull-softfloat

Re: [Qemu-devel] [qemu-s390x] [PATCH-for-4.2 v1 5/9] s390x/mmu: Implement access-exception-fetch/store-indication facility

2019-08-19 Thread Thomas Huth
On 8/19/19 2:16 PM, Thomas Huth wrote: > On 8/5/19 5:29 PM, David Hildenbrand wrote: >> We always have to indicate whether it is a fetch or a store for all access >> exceptions. This is only missing for LAP exceptions. > > Do we really need this for LAP, too? If I get figure 3-5 "Enhanced > Suppre

[Qemu-devel] [PATCH v8 35/37] target/mips: Clean up handling of CP0 register 31

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 31. Signed-off-by: Aleksandar Markovic --- target/mips/cpu.h | 2 +- target/mips/translate.c | 56 - 2 files changed, 29 insertions(+), 29 deletions(-) diff --git a/target/mips/c

[Qemu-devel] [PULL 09/12] fpu: rename softfloat-specialize.h -> .inc.c

2019-08-19 Thread Alex Bennée
This is not a normal header and should only be included in the main softfloat.c file to bring in the various target specific specialisations. Indeed as it contains non-inlined C functions it is not even a legal header. Rename it to match our included C convention. Signed-off-by: Alex Bennée Revie

[Qemu-devel] [PULL 05/12] target/m68k: replace LIT64 with UINT64_C macros

2019-08-19 Thread Alex Bennée
In our quest to eliminate the home rolled LIT64 macro we fixup usage inside for m68k's many constants. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/target/m68k/softfloat.c b/target/m68k/softfloat.c index 591a6f1dcec..24c313ed690 100644 --- a/target/m68k/softfloat.c +++

Re: [Qemu-devel] [qemu-s390x] [PATCH-for-4.2 v1 5/9] s390x/mmu: Implement access-exception-fetch/store-indication facility

2019-08-19 Thread Thomas Huth
On 8/5/19 5:29 PM, David Hildenbrand wrote: > We always have to indicate whether it is a fetch or a store for all access > exceptions. This is only missing for LAP exceptions. Do we really need this for LAP, too? If I get figure 3-5 "Enhanced Suppression-on-Protection Results" right, these bits ar

[Qemu-devel] [PULL 11/12] target/riscv: rationalise softfloat includes

2019-08-19 Thread Alex Bennée
We should avoid including the whole of softfloat headers in cpu.h and explicitly include it only where we will be calling softfloat functions. We can use the -types.h and -helpers.h in cpu.h for the few bits that are global. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by:

[Qemu-devel] [PULL 12/12] targets (various): use softfloat-helpers.h where we can

2019-08-19 Thread Alex Bennée
Generally the cpu and non-FP helper files just want to manipulate the softfloat flags. For this they can just use the -helpers.h include which brings in a minimal number of inline helpers. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: David Hildenbrand Reviewed-by: Phil

Re: [Qemu-devel] [PATCH for-4.2 v10 13/15] virtio_iommu: Handle reserved regions in translation process

2019-08-19 Thread Peter Xu
On Tue, Jul 30, 2019 at 07:21:35PM +0200, Eric Auger wrote: > When translating an address we need to check if it belongs to > a reserved virtual address range. If it does, there are 2 cases: > > - it belongs to a RESERVED region: the guest should neither use > this address in a MAP not instruct

  1   2   3   4   >