[Qemu-devel] [Bug 1839807] [NEW] Snapshots freeze guest Sabrelite IMX.6 board

2019-08-12 Thread Al Sn
Public bug reported: Hello, I'm trying to take and restore a snapshot with the whole system state of the Sabrelite IMX.6 board running on QEMU with commands savevm/loadvm. It seems that I am able to take a snapshot but loading the snapshot fails. For comparison I checked out snapshots on 32bit

[Qemu-devel] [PATCH v4] spapr: quantify error messages regarding capability settings

2019-08-12 Thread Daniel Black
Its not immediately obvious how cap-X=Y setting need to be applied to the command line so, for spapr capability error messages, this has been clarified to: appending -machine cap-X=Y The wrong value messages have been left as is, as the user has found the right location. Reviewed-by: Greg Kurz

[Qemu-devel] [PATCH] Add git-publish profile for security bugs

2019-08-12 Thread Gerd Hoffmann
Simplifies sending security patches to all people listed in https://wiki.qemu.org/SecurityProcess. Should also make it harder to send a copy to the mailing list by accident. Signed-off-by: Gerd Hoffmann --- .gitpublish | 11 +++ 1 file changed, 11 insertions(+) diff --git a/.gitpublish

Re: [Qemu-devel] [PATCH-for-4.2 v1 1/9] s390x/mmu: Better ASC selection in s390_cpu_get_phys_page_debug()

2019-08-12 Thread Thomas Huth
On 8/5/19 5:29 PM, David Hildenbrand wrote: > Let's select the ASC before calling the function and use MMU_DATA_LOAD. > This is a preparation to: > - Remove the ASC magic depending on the access mode from mmu_translate > - Implement IEP support, where we could run into access exceptions > trying

Re: [Qemu-devel] [PATCH-for-4.2 v1 3/9] s390x/mmu: DAT translation rewrite

2019-08-12 Thread Thomas Huth
On 8/5/19 5:29 PM, David Hildenbrand wrote: > Let's rewrite the DAT translation in a non-recursive way, similar to > arch/s390/kvm/gaccess.c:guest_translate() in KVM. This makes the > code much easier to read, compare and maintain. > > Use better names for the region/section/page table entries and

[Qemu-devel] [PATCH] roms/Makefile: fix command for opensbi64-sifive_u

2019-08-12 Thread Andreas Schwab
Copy the correct firmware file Signed-off-by: Andreas Schwab --- roms/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/roms/Makefile b/roms/Makefile index dc70fb5aea..775c963f9d 100644 --- a/roms/Makefile +++ b/roms/Makefile @@ -183,7 +183,7 @@ opensbi64-sifive_u:

Re: [Qemu-devel] [PATCH-for-4.2 v1 3/9] s390x/mmu: DAT translation rewrite

2019-08-12 Thread David Hildenbrand
On 12.08.19 09:20, Thomas Huth wrote: > On 8/5/19 5:29 PM, David Hildenbrand wrote: >> Let's rewrite the DAT translation in a non-recursive way, similar to >> arch/s390/kvm/gaccess.c:guest_translate() in KVM. This makes the >> code much easier to read, compare and maintain. >> >> Use better names f

[Qemu-devel] [PATCH RFC 1/4] intel_iommu: Sanity check vfio-pci config on machine init done

2019-08-12 Thread Peter Xu
This check was previously only happened when the IOMMU is enabled in the guest. It was always too late because the enabling of IOMMU normally only happens during the boot of guest OS. It means that we can bail out and exit directly during the guest OS boots if the configuration of devices are not

[Qemu-devel] [PATCH RFC 4/4] intel_iommu: Remove the caching-mode check during flag change

2019-08-12 Thread Peter Xu
That's never a good place to stop QEMU process... Since now we have both the machine done sanity check and also the hotplug handler, we can safely remove this to avoid that. Signed-off-by: Peter Xu --- hw/i386/intel_iommu.c | 4 1 file changed, 4 deletions(-) diff --git a/hw/i386/intel_iom

[Qemu-devel] [PATCH RFC 3/4] pc/q35: Disallow vfio-pci hotplug without VT-d caching mode

2019-08-12 Thread Peter Xu
Instead of bailing out when trying to hotplug a vfio-pci device with below configuration: -device intel-iommu,caching-mode=off With this we can return a warning message to the user via QMP/HMP and the VM will continue to work after failing the hotplug: (qemu) device_add vfio-pci,bus=root.3,h

[Qemu-devel] [PATCH RFC 0/4] intel_iommu: Do sanity check of vfio-pci earlier

2019-08-12 Thread Peter Xu
This is a RFC series. The VT-d code has some defects, one of them is that we cannot detect the misuse of vIOMMU and vfio-pci early enough. For example, logically this is not allowed: -device intel-iommu,caching-mode=off \ -device vfio-pci,host=05:00.0 Because the caching mode is required to

[Qemu-devel] [PATCH RFC 2/4] qdev/machine: Introduce hotplug_allowed hook

2019-08-12 Thread Peter Xu
Introduce this new per-machine hook to give any machine class a chance to do a sanity check on the to-be-hotplugged device as a sanity test. This will be used for x86 to try to detect some illegal configuration of devices, e.g., possible conflictions between vfio-pci and x86 vIOMMU. Signed-off-by:

Re: [Qemu-devel] [PATCH-for-4.2 v1 1/9] s390x/mmu: Better ASC selection in s390_cpu_get_phys_page_debug()

2019-08-12 Thread David Hildenbrand
On 12.08.19 09:12, Thomas Huth wrote: > On 8/5/19 5:29 PM, David Hildenbrand wrote: >> Let's select the ASC before calling the function and use MMU_DATA_LOAD. >> This is a preparation to: >> - Remove the ASC magic depending on the access mode from mmu_translate >> - Implement IEP support, where we

Re: [Qemu-devel] [PATCH-for-4.2 v1 3/9] s390x/mmu: DAT translation rewrite

2019-08-12 Thread David Hildenbrand
On 12.08.19 09:43, David Hildenbrand wrote: > On 12.08.19 09:20, Thomas Huth wrote: >> On 8/5/19 5:29 PM, David Hildenbrand wrote: >>> Let's rewrite the DAT translation in a non-recursive way, similar to >>> arch/s390/kvm/gaccess.c:guest_translate() in KVM. This makes the >>> code much easier to re

Re: [Qemu-devel] [PATCH 0/6] net/eth: Remove duplicated tcp/udp_hdr structures

2019-08-12 Thread Dmitry Fleytman
Reviewed-by: Dmitry Fleytman > On 8 Aug 2019, at 17:34, Philippe Mathieu-Daudé wrote: > > This is a preparatory cleanup series. > > Commit 75020a70215 introduced 4 very equivalent structures: > - tcp_header and tcp_hdr, > - udp_header and udp_hdr. > > Choose the most widely use in the codebas

Re: [Qemu-devel] [FOR 4.1 PATCH] riscv: roms: Fix make rules for building sifive_u bios

2019-08-12 Thread Peter Maydell
On Sun, 11 Aug 2019 at 08:17, Bin Meng wrote: > > Hi Palmer, > > On Tue, Aug 6, 2019 at 1:04 AM Alistair Francis wrote: > > > > On Fri, Aug 2, 2019 at 11:08 PM Bin Meng wrote: > > > > > > Currently the make rules are wrongly using qemu/virt opensbi image > > > for sifive_u machine. Correct it. >

Re: [Qemu-devel] [PATCH] roms/Makefile: fix command for opensbi64-sifive_u

2019-08-12 Thread Peter Maydell
On Mon, 12 Aug 2019 at 08:20, Andreas Schwab wrote: > > Copy the correct firmware file > > Signed-off-by: Andreas Schwab > --- > roms/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/roms/Makefile b/roms/Makefile > index dc70fb5aea..775c963f9d 100644 > --- a/roms

Re: [Qemu-devel] [PATCH qemu] spapr_iommu: Fix xlate trace to print translated address

2019-08-12 Thread Philippe Mathieu-Daudé
Hi Alexey, On 8/12/19 7:42 AM, Alexey Kardashevskiy wrote: > Currently we basically print IO address twice, fix this. > > Fixes: 7e472264e9e2 ("PPC: spapr: iommu: rework traces") > Signed-off-by: Alexey Kardashevskiy > --- > hw/ppc/spapr_iommu.c | 2 +- > 1 file changed, 1 insertion(+), 1 delet

Re: [Qemu-devel] [PATCH 4/7] ati-vga: Fix cursor color with guest_hwcursor=true

2019-08-12 Thread Philippe Mathieu-Daudé
On 8/11/19 11:14 PM, BALATON Zoltan wrote: > Fixes: a38127414bd007c5b6ae64c664d9e8839393277e > Signed-off-by: BALATON Zoltan > --- > hw/display/ati.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/display/ati.c b/hw/display/ati.c > index 699f38223b..b849f5d510 100644

Re: [Qemu-devel] [PATCH v4 0/8] Support disabling TCG on ARM

2019-08-12 Thread Philippe Mathieu-Daudé
On 8/9/19 10:22 PM, Philippe Mathieu-Daudé wrote: > Hi Peter, Paolo, Alex, Thomas :) > > On 7/2/19 4:08 PM, Peter Maydell wrote: >> On Mon, 1 Jul 2019 at 20:49, Philippe Mathieu-Daudé >> wrote: > [...] >>> $ git backport-diff -u v3 -r target-arm.next..v4 >>> Key: >>> [] : patches are identic

Re: [Qemu-devel] [PATCH v3 04/33] make Device and Bus Resettable

2019-08-12 Thread Damien Hedde
On 8/7/19 4:41 PM, Peter Maydell wrote: > On Mon, 29 Jul 2019 at 15:58, Damien Hedde wrote: >> >> >> +/** >> + * device_reset: >> + * Resets the device @dev, @cold tell whether to do a cold or warm reset. >> + * Base behavior is to reset the device and its qdev/qbus subtree. > > What do you me

Re: [Qemu-devel] [PATCH qemu] spapr_iommu: Fix xlate trace to print translated address

2019-08-12 Thread David Gibson
On Mon, Aug 12, 2019 at 03:42:02PM +1000, Alexey Kardashevskiy wrote: > Currently we basically print IO address twice, fix this. > > Fixes: 7e472264e9e2 ("PPC: spapr: iommu: rework traces") > Signed-off-by: Alexey Kardashevskiy Applied to ppc-for-4.2, thanks. > --- > hw/ppc/spapr_iommu.c | 2 +

Re: [Qemu-devel] [PATCH v4] spapr: quantify error messages regarding capability settings

2019-08-12 Thread David Gibson
On Mon, Aug 12, 2019 at 05:10:44PM +1000, Daniel Black wrote: > Its not immediately obvious how cap-X=Y setting need to be applied > to the command line so, for spapr capability error messages, this > has been clarified to: > > appending -machine cap-X=Y > > The wrong value messages have been le

Re: [Qemu-devel] [PATCH v4 29/29] sysemu: Split sysemu/runstate.h off sysemu/sysemu.h

2019-08-12 Thread Alex Bennée
Markus Armbruster writes: > sysemu/sysemu.h is a rather unfocused dumping ground for stuff related > to the system-emulator. Evidence: > > * It's included widely: in my "build everything" tree, changing > sysemu/sysemu.h still triggers a recompile of some 1100 out of 6600 > objects (not co

Re: [Qemu-devel] [Virtio-fs] [PATCH 0/4] virtiofsd: multithreading preparation part 3

2019-08-12 Thread Stefan Hajnoczi
On Sun, Aug 11, 2019 at 10:26:18AM +0800, piaojun wrote: > On 2019/8/9 16:21, Stefan Hajnoczi wrote: > > On Thu, Aug 08, 2019 at 10:53:16AM +0100, Dr. David Alan Gilbert wrote: > >> * Stefan Hajnoczi (stefa...@redhat.com) wrote: > >>> On Wed, Aug 07, 2019 at 04:57:15PM -0400, Vivek Goyal wrote: > >

Re: [Qemu-devel] [PATCH v4 28/29] sysemu: Move the VMChangeStateEntry typedef to qemu/typedefs.h

2019-08-12 Thread Alex Bennée
Markus Armbruster writes: > In my "build everything" tree, changing sysemu/sysemu.h triggers a > recompile of some 1800 out of 6600 objects (not counting tests and > objects that don't depend on qemu/osdep.h, down from 5400 due to the > previous commit). > > Several headers include sysemu/sysem

Re: [Qemu-devel] [PATCH v4 27/29] Include sysemu/sysemu.h a lot less

2019-08-12 Thread Alex Bennée
Markus Armbruster writes: > In my "build everything" tree, changing sysemu/sysemu.h triggers a > recompile of some 5400 out of 6600 objects (not counting tests and > objects that don't depend on qemu/osdep.h). > > hw/qdev-core.h includes sysemu/sysemu.h since recent commit e965ffa70a > "qdev: a

Re: [Qemu-devel] [PATCH v4 26/29] Clean up inclusion of sysemu/sysemu.h

2019-08-12 Thread Alex Bennée
Markus Armbruster writes: > In my "build everything" tree, changing sysemu/sysemu.h triggers a > recompile of some 5400 out of 6600 objects (not counting tests and > objects that don't depend on qemu/osdep.h). > > Almost a third of its inclusions are actually superfluous. Delete > them. Downg

Re: [Qemu-devel] [PATCH 4/7] ati-vga: Fix cursor color with guest_hwcursor=true

2019-08-12 Thread BALATON Zoltan
On Mon, 12 Aug 2019, Philippe Mathieu-Daudé wrote: On 8/11/19 11:14 PM, BALATON Zoltan wrote: Fixes: a38127414bd007c5b6ae64c664d9e8839393277e Signed-off-by: BALATON Zoltan --- hw/display/ati.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/display/ati.c b/hw/display/ati

Re: [Qemu-devel] [PATCH 4/7] ati-vga: Fix cursor color with guest_hwcursor=true

2019-08-12 Thread Philippe Mathieu-Daudé
On 8/12/19 12:28 PM, BALATON Zoltan wrote: > On Mon, 12 Aug 2019, Philippe Mathieu-Daudé wrote: >> On 8/11/19 11:14 PM, BALATON Zoltan wrote: >>> Fixes: a38127414bd007c5b6ae64c664d9e8839393277e >>> Signed-off-by: BALATON Zoltan >>> --- >>>  hw/display/ati.c | 2 +- >>>  1 file changed, 1 insertion(

Re: [Qemu-devel] [PATCH v4 09/29] Include migration/qemu-file-types.h a lot less

2019-08-12 Thread Philippe Mathieu-Daudé
On 8/12/19 7:23 AM, Markus Armbruster wrote: > In my "build everything" tree, changing migration/qemu-file-types.h > triggers a recompile of some 2600 out of 6600 objects (not counting > tests and objects that don't depend on qemu/osdep.h). > > The culprit is again hw/hw.h, which supposedly includ

Re: [Qemu-devel] [PATCH v4 20/29] Include qemu/main-loop.h less

2019-08-12 Thread Alex Bennée
Markus Armbruster writes: > In my "build everything" tree, changing qemu/main-loop.h triggers a > recompile of some 5600 out of 6600 objects (not counting tests and > objects that don't depend on qemu/osdep.h). It includes block/aio.h, > which in turn includes qemu/event_notifier.h, qemu/notif

Re: [Qemu-devel] [PATCH v4 20/29] Include qemu/main-loop.h less

2019-08-12 Thread Philippe Mathieu-Daudé
On 8/12/19 7:23 AM, Markus Armbruster wrote: > In my "build everything" tree, changing qemu/main-loop.h triggers a > recompile of some 5600 out of 6600 objects (not counting tests and > objects that don't depend on qemu/osdep.h). It includes block/aio.h, > which in turn includes qemu/event_notifie

Re: [Qemu-devel] [PATCH 4/7] ati-vga: Fix cursor color with guest_hwcursor=true

2019-08-12 Thread BALATON Zoltan
On Mon, 12 Aug 2019, Philippe Mathieu-Daudé wrote: On 8/12/19 12:28 PM, BALATON Zoltan wrote: On Mon, 12 Aug 2019, Philippe Mathieu-Daudé wrote: On 8/11/19 11:14 PM, BALATON Zoltan wrote: Fixes: a38127414bd007c5b6ae64c664d9e8839393277e Signed-off-by: BALATON Zoltan --- ?hw/display/ati.c | 2 +

Re: [Qemu-devel] [PATCH v4 11/29] typedefs: Separate incomplete types and function types

2019-08-12 Thread Alex Bennée
Markus Armbruster writes: > While there, drop the obsolete file comment. > > Signed-off-by: Markus Armbruster > Reviewed-by: Philippe Mathieu-Daudé > Tested-by: Philippe Mathieu-Daudé > --- > include/qemu/typedefs.h | 12 > 1 file changed, 8 insertions(+), 4 deletions(-) > > di

Re: [Qemu-devel] [PATCH v6 25/42] mirror: Deal with filters

2019-08-12 Thread Vladimir Sementsov-Ogievskiy
09.08.2019 19:13, Max Reitz wrote: > This includes some permission limiting (for example, we only need to > take the RESIZE permission for active commits where the base is smaller > than the top). > > Signed-off-by: Max Reitz > --- > block/mirror.c | 117 ++--

[Qemu-devel] [PATCH-for-4.2 v1 1/6] s390x/mmu: ASC selection in s390_cpu_get_phys_page_debug()

2019-08-12 Thread David Hildenbrand
Let's select the ASC before calling the function. This is a prepararion to remove the ASC magic depending on the access mode from mmu_translate. There is currently no way to distinguish if we have code or data access. For now, we were using code access, because especially when debugging with the g

[Qemu-devel] [PATCH-for-4.2 v1 2/6] s390x/tcg: Rework MMU selection for instruction fetches

2019-08-12 Thread David Hildenbrand
Instructions are always fetched from primary address space, except when in home address mode. Perform the selection directly in cpu_mmu_index(). get_mem_index() is only used to perform data access, instructions are fetched via cpu_lduw_code(), which translates to cpu_mmu_index(env, true). We don'

[Qemu-devel] [PATCH-for-4.2 v1 4/6] s390x/mmu: Trace the right value if setting/getting the storage key fails

2019-08-12 Thread David Hildenbrand
We want to trace the actual return value, not "0". Signed-off-by: David Hildenbrand --- target/s390x/mmu_helper.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c index 2c9bb3acc0..227a822e42 100644 --- a/target/s390x

[Qemu-devel] [PATCH-for-4.2 v1 0/6] s390x/mmu: Storage key reference and change bit handling

2019-08-12 Thread David Hildenbrand
The first two patches are modified patches from: [PATCH-for-4.2 v1 0/9] s390x: MMU changes and extensions This series primarily fixes minor things in the storage key handling code in the MMU and implements fairly reliable reference and change bit handling for TCG. To track the reference and ch

[Qemu-devel] [PATCH-for-4.2 v1 3/6] s390x/tcg: Flush the TLB of all CPUs on SSKE and RRBE

2019-08-12 Thread David Hildenbrand
Whenever we modify a storage key, we shuld flush the TLBs of all CPUs, so the MMU fault handling code can properly consider the changed storage key (to e.g., properly set the reference and change bit on the next accesses). These functions are barely used in modern Linux guests, so the performance

[Qemu-devel] [PATCH-for-4.2 v1 5/6] s390x/mmu: Better storage key reference and change bit handling

2019-08-12 Thread David Hildenbrand
Any access sets the reference bit. In case we have a read-fault, we should not allow writes to the TLB entry if the change bit was not already set. This is a preparation for proper storage-key reference/change bit handling in TCG and a fix for KVM whereby read accesses would set the change bit (ol

[Qemu-devel] [PATCH-for-4.2 v1 6/6] s390x/mmu: Factor out storage key handling

2019-08-12 Thread David Hildenbrand
Factor it out, add a comment how it all works, and also use it in the REAL MMU. Signed-off-by: David Hildenbrand --- target/s390x/mmu_helper.c | 114 +++--- 1 file changed, 69 insertions(+), 45 deletions(-) diff --git a/target/s390x/mmu_helper.c b/target/s390x/mm

[Qemu-devel] [PATCH 0/2] hw/display: Compile various display devices as common object

2019-08-12 Thread Philippe Mathieu-Daudé
This series move various generic display devices to $(common-obj-y), so they are compiled once for all targets. 'make world' is reduced by 54 objects. Philippe Mathieu-Daudé (2): hw/display/sm501: Remove unused include hw/display: Compile various display devices as common object hw/display/

[Qemu-devel] [PATCH 1/2] hw/display/sm501: Remove unused include

2019-08-12 Thread Philippe Mathieu-Daudé
The "cpu.h" include makes devices target-specific. Since it is not used, remove it, so the device become generic (we can now compile it once for all targets). Signed-off-by: Philippe Mathieu-Daudé --- hw/display/sm501.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/display/sm501.c b/hw/d

[Qemu-devel] [PATCH 2/2] hw/display: Compile various display devices as common object

2019-08-12 Thread Philippe Mathieu-Daudé
Various display devices are not target-specific and can be compiled once for all the targets. After this commit, the 'make world' target is reduced by 54 objects Signed-off-by: Philippe Mathieu-Daudé --- hw/display/Makefile.objs | 18 +- 1 file changed, 9 insertions(+), 9 deletio

Re: [Qemu-devel] [PATCH 1/2] hw/display/sm501: Remove unused include

2019-08-12 Thread Thomas Huth
On 8/12/19 1:37 PM, Philippe Mathieu-Daudé wrote: > The "cpu.h" include makes devices target-specific. Since it > is not used, remove it, so the device become generic (we can > now compile it once for all targets). > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/display/sm501.c | 1 - > 1 f

Re: [Qemu-devel] [PATCH 2/2] hw/display: Compile various display devices as common object

2019-08-12 Thread Thomas Huth
On 8/12/19 1:37 PM, Philippe Mathieu-Daudé wrote: > Various display devices are not target-specific and can > be compiled once for all the targets. > After this commit, the 'make world' target is reduced by > 54 objectts Reviewed-by: Thomas Huth

Re: [Qemu-devel] [PATCH v6 28/42] stream: Deal with filters

2019-08-12 Thread Vladimir Sementsov-Ogievskiy
09.08.2019 19:13, Max Reitz wrote: > Because of the recent changes that make the stream job independent of > the base node and instead track the node above it, we have to split that > "bottom" node into two cases: The bottom COW node, and the node directly > above the base node (which may be an R/W

Re: [Qemu-devel] [PATCH 0/2] hw/display: Compile various display devices as common object

2019-08-12 Thread BALATON Zoltan
On Mon, 12 Aug 2019, Philippe Mathieu-Daudé wrote: This series move various generic display devices to $(common-obj-y), so they are compiled once for all targets. 'make world' is reduced by 54 objects. Philippe Mathieu-Daudé (2): hw/display/sm501: Remove unused include hw/display: Compile var

Re: [Qemu-devel] [Virtio-fs] [PATCH 0/4] virtiofsd: multithreading preparation part 3

2019-08-12 Thread piaojun
On 2019/8/12 18:05, Stefan Hajnoczi wrote: > On Sun, Aug 11, 2019 at 10:26:18AM +0800, piaojun wrote: >> On 2019/8/9 16:21, Stefan Hajnoczi wrote: >>> On Thu, Aug 08, 2019 at 10:53:16AM +0100, Dr. David Alan Gilbert wrote: * Stefan Hajnoczi (stefa...@redhat.com) wrote: > On Wed, Aug 07,

Re: [Qemu-devel] [PATCH v6 30/42] qemu-img: Use child access functions

2019-08-12 Thread Vladimir Sementsov-Ogievskiy
09.08.2019 19:13, Max Reitz wrote: > This changes iotest 204's output, because blkdebug on top of a COW node > used to make qemu-img map disregard the rest of the backing chain (the > backing chain was broken by the filter). With this patch, the > allocation in the base image is reported correctly

Re: [Qemu-devel] [PATCH 3/6] hw/arm: Use sysbus_init_child_obj for correct reference counting

2019-08-12 Thread Philippe Mathieu-Daudé
On 7/29/19 3:03 PM, Peter Maydell wrote: > On Mon, 1 Jul 2019 at 13:31, Philippe Mathieu-Daudé wrote: >> >> As explained in commit aff39be0ed97: >> >> Both functions, object_initialize() and object_property_add_child() >> increase the reference counter of the new object, so one of the >> ref

Re: [Qemu-devel] Is network backend netmap worth keeping?

2019-08-12 Thread Philippe Mathieu-Daudé
On 8/8/19 1:52 PM, Markus Armbruster wrote: > Giuseppe Lettieri writes: > >> Dear Markus, >> >> the netmap project is alive and well, if a bit understuffed. We have >> moved to github: >> >> https://github.com/luigirizzo/netmap >> >> We have users from FreeBSD, where it is part of the official ke

Re: [Qemu-devel] Is network backend netmap worth keeping?

2019-08-12 Thread Philippe Mathieu-Daudé
I forgot to Cc Thomas, who did a lot of directory refactoring in the past. On Mon, Aug 12, 2019 at 2:32 PM Philippe Mathieu-Daudé wrote: > On 8/8/19 1:52 PM, Markus Armbruster wrote: > > Giuseppe Lettieri writes: > > > >> Dear Markus, > >> > >> the netmap project is alive and well, if a bit unde

Re: [Qemu-devel] [PATCH 4/7] ati-vga: Fix cursor color with guest_hwcursor=true

2019-08-12 Thread Andrew Randrianasulu
В сообщении от Monday 12 August 2019 13:55:45 BALATON Zoltan написал(а): > On Mon, 12 Aug 2019, Philippe Mathieu-Daudé wrote: > > On 8/12/19 12:28 PM, BALATON Zoltan wrote: > >> On Mon, 12 Aug 2019, Philippe Mathieu-Daudé wrote: > >>> On 8/11/19 11:14 PM, BALATON Zoltan wrote: > Fixes: a381274

Re: [Qemu-devel] [PATCH 0/1] display/bochs: fix pcie support (qemu security issue)

2019-08-12 Thread Paolo Bonzini
On 12/08/19 08:52, Gerd Hoffmann wrote: > Just found while investigating > https://bugzilla.redhat.com/show_bug.cgi?id=1707118 > > Found PCIe extended config space filled with random crap due to > allocation being too small (conventional pci config space only). > > PCI(e) config space is guest

Re: [Qemu-devel] [PATCH v3 20/29] Include qemu/main-loop.h less

2019-08-12 Thread Philippe Mathieu-Daudé
On 8/10/19 9:34 PM, Markus Armbruster wrote: > > My failure: > > $ make -C bld docker-test-build > make: Entering directory '/work/armbru/qemu/bld' > BUILD centos7 > make[1]: Entering directory '/work/armbru/qemu/bld' > GEN /work/armbru/qemu/bld/docker-src.2019-08-10-07.29.32.8915/qemu.

Re: [Qemu-devel] [Virtio-fs] [PATCH 0/4] virtiofsd: multithreading preparation part 3

2019-08-12 Thread Dr. David Alan Gilbert
* piaojun (piao...@huawei.com) wrote: > > > On 2019/8/12 18:05, Stefan Hajnoczi wrote: > > On Sun, Aug 11, 2019 at 10:26:18AM +0800, piaojun wrote: > >> On 2019/8/9 16:21, Stefan Hajnoczi wrote: > >>> On Thu, Aug 08, 2019 at 10:53:16AM +0100, Dr. David Alan Gilbert wrote: > * Stefan Hajnoczi

Re: [Qemu-devel] [PATCH 0/1] display/bochs: fix pcie support (qemu security issue)

2019-08-12 Thread Philippe Mathieu-Daudé
On 8/12/19 2:45 PM, Paolo Bonzini wrote: > On 12/08/19 08:52, Gerd Hoffmann wrote: >> Just found while investigating >> https://bugzilla.redhat.com/show_bug.cgi?id=1707118 >> >> Found PCIe extended config space filled with random crap due to >> allocation being too small (conventional pci config

Re: [Qemu-devel] [PATCH v6 09/42] block: Include filters when freezing backing chain

2019-08-12 Thread Max Reitz
On 10.08.19 15:32, Vladimir Sementsov-Ogievskiy wrote: > 09.08.2019 19:13, Max Reitz wrote: >> In order to make filters work in backing chains, the associated >> functions must be able to deal with them and freeze all filter links, be >> they COW or R/W filter links. >> >> In the process, rename th

Re: [Qemu-devel] [PATCH v6 16/42] block: Flush all children in generic code

2019-08-12 Thread Max Reitz
On 10.08.19 17:36, Vladimir Sementsov-Ogievskiy wrote: > 09.08.2019 19:13, Max Reitz wrote: >> If the driver does not support .bdrv_co_flush() so bdrv_co_flush() >> itself has to flush the children of the given node, it should not flush >> just bs->file->bs, but in fact all children. >> >> In any c

Re: [Qemu-devel] [PATCH 1/1] display/bochs: fix pcie support

2019-08-12 Thread Alex Williamson
On Mon, 12 Aug 2019 08:52:21 +0200 Gerd Hoffmann wrote: > Set QEMU_PCI_CAP_EXPRESS unconditionally in init(), then clear it in > realize() in case the device is not connected to a PCIe bus. > > This makes sure the pci config space allocation is big enough, so > accessing the PCIe extended config

Re: [Qemu-devel] [PATCH-for-4.2 v1 4/6] s390x/mmu: Trace the right value if setting/getting the storage key fails

2019-08-12 Thread Cornelia Huck
On Mon, 12 Aug 2019 13:27:35 +0200 David Hildenbrand wrote: > We want to trace the actual return value, not "0". :) Nice find. > > Signed-off-by: David Hildenbrand > --- > target/s390x/mmu_helper.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Cornelia Huck

Re: [Qemu-devel] [PATCH v6 20/42] block/snapshot: Fix fallback

2019-08-12 Thread Max Reitz
On 10.08.19 18:34, Vladimir Sementsov-Ogievskiy wrote: > 09.08.2019 19:13, Max Reitz wrote: >> If the top node's driver does not provide snapshot functionality and we >> want to fall back to a node down the chain, we need to snapshot all >> non-COW children. For simplicity's sake, just do not fall

Re: [Qemu-devel] [PATCH v6 22/42] block: Fix bdrv_get_allocated_file_size's fallback

2019-08-12 Thread Max Reitz
On 10.08.19 18:41, Vladimir Sementsov-Ogievskiy wrote: > 09.08.2019 19:13, Max Reitz wrote: >> If the driver does not implement bdrv_get_allocated_file_size(), we >> should fall back to cumulating the allocated size of all non-COW >> children instead of just bs->file. >> >> Suggested-by: Vladimir S

Re: [Qemu-devel] backup bug or question

2019-08-12 Thread Kevin Wolf
Am 09.08.2019 um 15:18 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi! > > Hmm, hacking around backup I have a question: > > What prevents guest write request after job_start but before setting > write notifier? > > code path: > > qmp_drive_backup or transaction with backup > > job_sta

Re: [Qemu-devel] [PATCH v6 25/42] mirror: Deal with filters

2019-08-12 Thread Max Reitz
On 12.08.19 13:09, Vladimir Sementsov-Ogievskiy wrote: > 09.08.2019 19:13, Max Reitz wrote: >> This includes some permission limiting (for example, we only need to >> take the RESIZE permission for active commits where the base is smaller >> than the top). >> >> Signed-off-by: Max Reitz >> --- >>

Re: [Qemu-devel] [PATCH v6 30/42] qemu-img: Use child access functions

2019-08-12 Thread Max Reitz
On 12.08.19 14:14, Vladimir Sementsov-Ogievskiy wrote: > 09.08.2019 19:13, Max Reitz wrote: >> This changes iotest 204's output, because blkdebug on top of a COW node >> used to make qemu-img map disregard the rest of the backing chain (the >> backing chain was broken by the filter). With this pat

Re: [Qemu-devel] [PATCH-for-4.2 v1 2/6] s390x/tcg: Rework MMU selection for instruction fetches

2019-08-12 Thread David Hildenbrand
On 12.08.19 13:27, David Hildenbrand wrote: > Instructions are always fetched from primary address space, except when > in home address mode. Perform the selection directly in cpu_mmu_index(). > > get_mem_index() is only used to perform data access, instructions are > fetched via cpu_lduw_code(),

Re: [Qemu-devel] [PATCH v4 11/29] typedefs: Separate incomplete types and function types

2019-08-12 Thread Markus Armbruster
Alex Bennée writes: > Markus Armbruster writes: > >> While there, drop the obsolete file comment. >> >> Signed-off-by: Markus Armbruster >> Reviewed-by: Philippe Mathieu-Daudé >> Tested-by: Philippe Mathieu-Daudé >> --- >> include/qemu/typedefs.h | 12 >> 1 file changed, 8 inser

Re: [Qemu-devel] [PATCH 0/1] display/bochs: fix pcie support (qemu security issue)

2019-08-12 Thread Peter Maydell
On Mon, 12 Aug 2019 at 13:51, Philippe Mathieu-Daudé wrote: > > On 8/12/19 2:45 PM, Paolo Bonzini wrote: > > On 12/08/19 08:52, Gerd Hoffmann wrote: > >> Just found while investigating > >> https://bugzilla.redhat.com/show_bug.cgi?id=1707118 > >> > >> Found PCIe extended config space filled with

Re: [Qemu-devel] [PATCH-for-4.2 v1 1/9] s390x/mmu: Better ASC selection in s390_cpu_get_phys_page_debug()

2019-08-12 Thread Cornelia Huck
On Mon, 12 Aug 2019 09:52:56 +0200 David Hildenbrand wrote: > On 12.08.19 09:12, Thomas Huth wrote: > > On 8/5/19 5:29 PM, David Hildenbrand wrote: > >> Let's select the ASC before calling the function and use MMU_DATA_LOAD. > >> This is a preparation to: > >> - Remove the ASC magic depending o

Re: [Qemu-devel] [PATCH-for-4.2 v1 1/9] s390x/mmu: Better ASC selection in s390_cpu_get_phys_page_debug()

2019-08-12 Thread David Hildenbrand
On 12.08.19 15:40, Cornelia Huck wrote: > On Mon, 12 Aug 2019 09:52:56 +0200 > David Hildenbrand wrote: > >> On 12.08.19 09:12, Thomas Huth wrote: >>> On 8/5/19 5:29 PM, David Hildenbrand wrote: Let's select the ASC before calling the function and use MMU_DATA_LOAD. This is a preparat

Re: [Qemu-devel] [PATCH-for-4.2 v8 7/9] hw/arm/virt-acpi-build: Add PC-DIMM in SRAT

2019-08-12 Thread Igor Mammedov
On Fri, 9 Aug 2019 16:02:39 + Shameerali Kolothum Thodi wrote: > Hi Igor, > > > -Original Message- > > From: Qemu-devel > > [mailto:qemu-devel-bounces+shameerali.kolothum.thodi=huawei.com@nongn > > u.org] On Behalf Of Igor Mammedov > > Sent: 06 August 2019 14:22 > > To: Shameerali Ko

Re: [Qemu-devel] [Qemu-ppc] [GIT PULL for qemu-pseries REPOST] pseries: Update SLOF firmware image

2019-08-12 Thread David Gibson
On Mon, Aug 05, 2019 at 02:14:39PM +0530, Aravinda Prasad wrote: > Alexey/David, > > With the SLOF changes, QEMU cannot resize the RTAS blob. Resizing is > required for FWNMI support which extends the RTAS blob to include an > error log upon a machine check. > > The check to valid RTAS buffer fai

Re: [Qemu-devel] [PATCH v3 05/33] Switch to new api in qdev/bus

2019-08-12 Thread David Gibson
On Fri, Aug 09, 2019 at 01:39:46PM +0200, Cédric Le Goater wrote: > > >>> So.. is this change in the device_reset() signature really necessary? > >>> Even if there are compelling reasons to handle warm reset in the new > >>> API, that doesn't been you need to change device_reset() itself from > >>

Re: [Qemu-devel] [PATCH v3 04/33] make Device and Bus Resettable

2019-08-12 Thread David Gibson
On Wed, Aug 07, 2019 at 09:55:13AM +0200, Damien Hedde wrote: > > > On 8/6/19 2:35 AM, David Gibson wrote: > > On Wed, Jul 31, 2019 at 11:09:05AM +0200, Damien Hedde wrote: > >> > >> > >> On 7/31/19 7:56 AM, David Gibson wrote: > >>> On Mon, Jul 29, 2019 at 04:56:25PM +0200, Damien Hedde wrote: >

Re: [Qemu-devel] [PATCH v3 08/33] Add function to control reset with gpio inputs

2019-08-12 Thread David Gibson
On Fri, Aug 09, 2019 at 10:45:43AM +0200, Damien Hedde wrote: > > > On 8/9/19 7:51 AM, David Gibson wrote: > > On Wed, Aug 07, 2019 at 11:37:51AM +0100, Peter Maydell wrote: > >> On Wed, 31 Jul 2019 at 07:33, David Gibson > >> wrote: > >>> > >>> On Mon, Jul 29, 2019 at 04:56:29PM +0200, Damien

Re: [Qemu-devel] [PATCH v3 05/33] Switch to new api in qdev/bus

2019-08-12 Thread David Gibson
On Fri, Aug 09, 2019 at 12:08:43PM +0100, Peter Maydell wrote: > On Fri, 9 Aug 2019 at 01:10, David Gibson wrote: > > > > On Wed, Jul 31, 2019 at 01:31:28PM +0200, Philippe Mathieu-Daudé wrote: > > > On 7/31/19 11:29 AM, Damien Hedde wrote: > > > > On 7/31/19 8:05 AM, David Gibson wrote: > > > >>

Re: [Qemu-devel] [PATCH v3 09/33] add doc about Resettable interface

2019-08-12 Thread David Gibson
On Wed, Aug 07, 2019 at 05:01:42PM +0100, Peter Maydell wrote: > On Wed, 31 Jul 2019 at 07:33, David Gibson > wrote: > > > > On Mon, Jul 29, 2019 at 04:56:30PM +0200, Damien Hedde wrote: > > > Signed-off-by: Damien Hedde > > > +For Devices and Buses there is also the corresponding helpers: > > >

Re: [Qemu-devel] [PATCH v3 01/33] Create Resettable QOM interface

2019-08-12 Thread David Gibson
On Thu, Aug 01, 2019 at 11:35:20AM +0200, Damien Hedde wrote: > > > On 7/31/19 7:46 AM, David Gibson wrote: > > On Tue, Jul 30, 2019 at 04:08:59PM +0200, Damien Hedde wrote: > >> > >> On 7/30/19 3:59 PM, Peter Maydell wrote: > >>> On Tue, 30 Jul 2019 at 14:56, Cornelia Huck wrote: > >

Re: [Qemu-devel] [PATCH v4 28/29] sysemu: Move the VMChangeStateEntry typedef to qemu/typedefs.h

2019-08-12 Thread Markus Armbruster
Alex Bennée writes: > Markus Armbruster writes: > >> In my "build everything" tree, changing sysemu/sysemu.h triggers a >> recompile of some 1800 out of 6600 objects (not counting tests and >> objects that don't depend on qemu/osdep.h, down from 5400 due to the >> previous commit). >> >> Several

Re: [Qemu-devel] [PATCH-for-4.2 v1 1/9] s390x/mmu: Better ASC selection in s390_cpu_get_phys_page_debug()

2019-08-12 Thread Cornelia Huck
On Mon, 12 Aug 2019 15:45:25 +0200 David Hildenbrand wrote: > On 12.08.19 15:40, Cornelia Huck wrote: > > On Mon, 12 Aug 2019 09:52:56 +0200 > > David Hildenbrand wrote: > > > >> On 12.08.19 09:12, Thomas Huth wrote: > >>> On 8/5/19 5:29 PM, David Hildenbrand wrote: > Let's select

Re: [Qemu-devel] [PATCH 0/2] Move some machine core code to proper places

2019-08-12 Thread Markus Armbruster
Queued for 4.2.

Re: [Qemu-devel] [PATCH] qdev: Collect HMP handlers command handlers in qdev-monitor.c

2019-08-12 Thread Markus Armbruster
Markus Armbruster writes: > Move hmp_device_add(), hmp_device_del() from monitor/hmp-cmds.c to > qdev-monitor.c, where they are covered by MAINTAINERS section "QOM", > just like qapi/qdev.json. hmp_info_qtree() and hmp_info_qdm() are > already there. > > Signed-off-by: Markus Armbruster Queued

Re: [Qemu-devel] [PATCH] qapi: Make visit_next_list()'s comment less confusing

2019-08-12 Thread Markus Armbruster
Markus Armbruster writes: > visit_next_list() returns non-null on success, null on failure. The > comment's phrasing "until NULL return or error occurs" is needlessly > confusing. Scratch the "or error occurs" part. > > Signed-off-by: Markus Armbruster Queued for 4.2.

[Qemu-devel] [PATCH v3] riscv: hmp: Add a command to show virtual memory mappings

2019-08-12 Thread Bin Meng
This adds 'info mem' command for RISC-V, to show virtual memory mappings of each hart that aids debugging. Rather than showing every valid PTE, the command compacts the output by merging all contiguous physical address mappings into one block and only shows the merged block mapping details. Signe

Re: [Qemu-devel] [PATCH-for-4.2 v1 1/9] s390x/mmu: Better ASC selection in s390_cpu_get_phys_page_debug()

2019-08-12 Thread David Hildenbrand
On 12.08.19 15:58, Cornelia Huck wrote: > On Mon, 12 Aug 2019 15:45:25 +0200 > David Hildenbrand wrote: > >> On 12.08.19 15:40, Cornelia Huck wrote: >>> On Mon, 12 Aug 2019 09:52:56 +0200 >>> David Hildenbrand wrote: >>> On 12.08.19 09:12, Thomas Huth wrote: > On 8/5/19 5:29 PM, Da

Re: [Qemu-devel] [PATCH 0/1] display/bochs: fix pcie support (qemu security issue)

2019-08-12 Thread Philippe Mathieu-Daudé
On 8/12/19 3:39 PM, Peter Maydell wrote: > On Mon, 12 Aug 2019 at 13:51, Philippe Mathieu-Daudé > wrote: >> >> On 8/12/19 2:45 PM, Paolo Bonzini wrote: >>> On 12/08/19 08:52, Gerd Hoffmann wrote: Just found while investigating https://bugzilla.redhat.com/show_bug.cgi?id=1707118 >

Re: [Qemu-devel] [PATCH v2] block: posix: Handle undetectable alignment

2019-08-12 Thread Kevin Wolf
Am 11.08.2019 um 22:50 hat Nir Soffer geschrieben: > In some cases buf_align or request_alignment cannot be detected: > > - With Gluster, buf_align cannot be detected since the actual I/O is > done on Gluster server, and qemu buffer alignment does not matter. If it doesn't matter, the best valu

[Qemu-devel] [Bug 1796520] Re: autogen crashes on qemu-sh4-user after 61dedf2af7

2019-08-12 Thread Peter Maydell
On that hardware, at least, the user-space visible FPSCR value is indeed 0x00080. Execution of the 'frchg' insn either doesn't trap, or the trap is caught by the kernel and emulated. I think it is not being emulated because CONFIG_SH_FPU_EMU is not set. The comment at the top of arch/sh/kernel

[Qemu-devel] [PATCH] elf: Allow loading AArch64 ELF files

2019-08-12 Thread Aaron Lindsay OS via Qemu-devel
Treat EM_AARCH64 as a valid value when checking the ELF's machine-type header. Signed-off-by: Aaron Lindsay --- include/hw/elf_ops.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/hw/elf_ops.h b/include/hw/elf_ops.h index 690f9238c8..f12faa90a1 100644 --- a/include/hw/elf_ops.

Re: [Qemu-devel] [PATCH 1/3] vdi: Make block_status recurse for fixed images

2019-08-12 Thread Vladimir Sementsov-Ogievskiy
25.07.2019 18:55, Max Reitz wrote: > Suggested-by: Vladimir Sementsov-Ogievskiy > Fixes: 69f47505ee66afaa513305de0c1895a224e52c45 > Signed-off-by: Max Reitz Sorry for a delay, I thought that maintainers of the formats will approve these patches ;) Don't know vdi code, but it is what I suggeste

Re: [Qemu-devel] [PATCH v3 3/7] block/io: handle alignment and max_transfer for copy_range

2019-08-12 Thread Max Reitz
On 10.08.19 21:31, Vladimir Sementsov-Ogievskiy wrote: > copy_range ignores these limitations, let's improve it. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/io.c | 44 > 1 file changed, 36 insertions(+), 8 deletions(-) Reviewed-by:

Re: [Qemu-devel] [PATCH v2 0/9] add failover feature for assigned network devices

2019-08-12 Thread Michael S. Tsirkin
On Fri, Aug 02, 2019 at 05:05:56PM +0200, Jens Freimann wrote: > This is implementing the host side of the net_failover concept > (https://www.kernel.org/doc/html/latest/networking/net_failover.html) Virtio bits look fine. Anyone else wants to comment on management/migration aspects? Which tree sh

[Qemu-devel] [Bug 1796520] Re: autogen crashes on qemu-sh4-user after 61dedf2af7

2019-08-12 Thread Peter Maydell
(Edit to note that "that hardware" is an SH7785LCR with an SH7785 CPU.) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1796520 Title: autogen crashes on qemu-sh4-user after 61dedf2af7 Status in QEM

Re: [Qemu-devel] [PATCH] elf: Allow loading AArch64 ELF files

2019-08-12 Thread no-reply
Patchew URL: https://patchew.org/QEMU/2019081212.30027-1-aa...@os.amperecomputing.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] elf: Allow loading AArch64 ELF files Message-id: 2019081212.30027-1-aa.

Re: [Qemu-devel] [PATCH 2/3] vmdk: Make block_status recurse for flat extents

2019-08-12 Thread Vladimir Sementsov-Ogievskiy
25.07.2019 18:55, Max Reitz wrote: > Fixes: 69f47505ee66afaa513305de0c1895a224e52c45 > Signed-off-by: Max Reitz Again, don't know vmdk code, but briefly looking at it (and at vmdk spec) I see that "extents" are files, and flat extent is a raw file without any special format. And it is allocated b

Re: [Qemu-devel] [PATCH v4 28/29] sysemu: Move the VMChangeStateEntry typedef to qemu/typedefs.h

2019-08-12 Thread Alex Bennée
Markus Armbruster writes: > Alex Bennée writes: > >> Markus Armbruster writes: >> >>> In my "build everything" tree, changing sysemu/sysemu.h triggers a >>> recompile of some 1800 out of 6600 objects (not counting tests and >>> objects that don't depend on qemu/osdep.h, down from 5400 due to

  1   2   3   >