Re: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-07-30 Thread Stefan Hajnoczi
On Mon, Jul 29, 2019 at 02:57:55PM +0200, Sergio Lopez wrote: > @@ -162,12 +183,34 @@ static uint64_t virtio_mmio_read(void *opaque, hwaddr > offset, unsigned size) > } > return VIRTQUEUE_MAX_SIZE; > case VIRTIO_MMIO_QUEUE_PFN: > +if (proxy->modern) { > +

Re: [Qemu-devel] [PATCH v7 04/15] block/io_uring: implements interfaces for io_uring

2019-07-30 Thread Stefan Hajnoczi
On Mon, Jul 29, 2019 at 08:46:40PM +0530, Aarushi Mehta wrote: > +/** > + * luring_process_completions: > + * @s: AIO state > + * > + * Fetches completed I/O requests, consumes cqes and invokes their callbacks > + * The function is somewhat tricky because it supports nested event loops, > for > +

Re: [Qemu-devel] [Qemu-block] [PATCH v7 11/15] qemu-io: adds option to use aio engine

2019-07-30 Thread Stefan Hajnoczi
On Mon, Jul 29, 2019 at 08:46:47PM +0530, Aarushi Mehta wrote: > Signed-off-by: Aarushi Mehta > --- > qemu-io.c | 24 > 1 file changed, 20 insertions(+), 4 deletions(-) > > diff --git a/qemu-io.c b/qemu-io.c > index f64eca6940..6568f0c369 100644 > --- a/qemu-io.c > +++ b

Re: [Qemu-devel] [Qemu-block] [PATCH v7 12/15] qemu-img: adds option to use aio engine for benchmarking

2019-07-30 Thread Stefan Hajnoczi
On Mon, Jul 29, 2019 at 08:46:48PM +0530, Aarushi Mehta wrote: > Signed-off-by: Aarushi Mehta > --- > qemu-img.c| 10 +- > qemu-img.texi | 5 - > 2 files changed, 13 insertions(+), 2 deletions(-) > > diff --git a/qemu-img.c b/qemu-img.c > index 79983772de..3fc8dac0b1 100644 > --

Re: [Qemu-devel] [PATCH v7 13/15] qemu-nbd: adds option for aio engines

2019-07-30 Thread Stefan Hajnoczi
On Mon, Jul 29, 2019 at 08:46:49PM +0530, Aarushi Mehta wrote: > Signed-off-by: Aarushi Mehta > --- > qemu-nbd.c| 12 > qemu-nbd.texi | 4 ++-- > 2 files changed, 6 insertions(+), 10 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [Qemu-devel] [PATCH v2 2/2] memory-device: break the loop if tmp exceed the hinted range

2019-07-30 Thread David Hildenbrand
On 30.07.19 02:37, Wei Yang wrote: > The memory-device list built by memory_device_build_list is ordered by > its address, this means if the tmp range exceed the hinted range, all > the following range will not overlap with it. > > And this won't change default pc-dimm mapping and address assignme

Re: [Qemu-devel] [Qemu-block] [PATCH v7 14/15] tests/qemu-iotests: enable testing with aio options

2019-07-30 Thread Stefan Hajnoczi
On Mon, Jul 29, 2019 at 08:46:50PM +0530, Aarushi Mehta wrote: > Signed-off-by: Aarushi Mehta > --- > tests/qemu-iotests/check | 15 ++- > tests/qemu-iotests/common.rc | 14 ++ > tests/qemu-iotests/iotests.py | 9 - > 3 files changed, 36 insertions(+), 2 del

Re: [Qemu-devel] [Qemu-block] [PATCH v7 15/15] tests/qemu-iotests: use AIOMODE with various tests

2019-07-30 Thread Stefan Hajnoczi
On Mon, Jul 29, 2019 at 08:46:51PM +0530, Aarushi Mehta wrote: > Signed-off-by: Aarushi Mehta > --- > tests/qemu-iotests/028 | 3 ++- > tests/qemu-iotests/058 | 2 +- > tests/qemu-iotests/089 | 4 ++-- > tests/qemu-iotests/091 | 7 --- > tests/qemu-iotests/109 | 3 ++- > tests/qemu-iotes

[Qemu-devel] [Bug 1838312] Re: Qemu virt-manager Segmentation fault

2019-07-30 Thread Hans Peter
@ Christian Ehrhardt, I'm on Ubuntu Mate 19.04. Machine: AMD, 64 bit I done no configuration of 'libvirt' yet. I don't wanna install apport. I add installed package-list at attachment. I hope it will helps. ** Attachment added: "Installed package-list" https://bugs.launchpad.net/qemu/+bu

Re: [Qemu-devel] [PATCH for-4.1] scsi-cd: Fix inserting read-only media in empty drive

2019-07-30 Thread Kevin Wolf
Am 30.07.2019 um 08:31 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > scsi-disks decides whether it has a read-only device by looking at > > whether the BlockBackend specified as drive=... is read-only. In the > > case of an anonymous BlockBackend (with a node name specified in > >

Re: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-07-30 Thread Michael S. Tsirkin
On Mon, Jul 29, 2019 at 02:57:55PM +0200, Sergio Lopez wrote: > Implement the modern (v2) personality, according to the VirtIO 1.0 > specification. > > Support for v2 among guests is not as widespread as it'd be > desirable. While the Linux driver has had it for a while, support is > missing, at l

Re: [Qemu-devel] [PATCH] xen: cleanup IOREQ server on exit

2019-07-30 Thread Paul Durrant
> -Original Message- > From: Igor Druzhinin > Sent: 29 July 2019 20:29 > To: xen-de...@lists.xenproject.org; qemu-devel@nongnu.org > Cc: sstabell...@kernel.org; Anthony Perard ; Paul > Durrant > ; m...@redhat.com; Igor Druzhinin > > Subject: [PATCH] xen: cleanup IOREQ server on exit >

Re: [Qemu-devel] [PATCH 10/67] target/arm: Move test for AL into arm_skip_unless

2019-07-30 Thread Peter Maydell
On Tue, 30 Jul 2019 at 01:57, Richard Henderson wrote: > > On 7/29/19 7:32 AM, Peter Maydell wrote: > > On Fri, 26 Jul 2019 at 18:50, Richard Henderson > > wrote: > >> > >> We will shortly be calling this function much more often. > >> > >> Signed-off-by: Richard Henderson > >> --- > > > > In t

Re: [Qemu-devel] [PATCH-4.2 v1 4/6] target/riscv: Create function to test if FP is enabled

2019-07-30 Thread Christophe de Dinechin
Alistair Francis writes: > Let's creaate a function that tests if floating point support is Typo: create > enabled. We can then protect all floating point operations based on if > they are enabled. > > This patch so far doesn't change anything, it's just preparing for the > Hypervisor support

Re: [Qemu-devel] [PATCH for-4.1] scsi-cd: Fix inserting read-only media in empty drive

2019-07-30 Thread Christophe de Dinechin
Kevin Wolf writes: > scsi-disks decides whether it has a read-only device by looking at > whether the BlockBackend specified as drive=... is read-only. In the > case of an anonymous BlockBackend (with a node name specified in > drive=...), this is the read-only flag of the attached node. In the

Re: [Qemu-devel] [PATCH v8 02/11] numa: move numa global variable nb_numa_nodes into MachineState

2019-07-30 Thread Igor Mammedov
On Tue, 30 Jul 2019 08:53:36 +0800 Tao Xu wrote: > On 7/29/2019 9:09 PM, Igor Mammedov wrote: > > On Mon, 29 Jul 2019 14:31:18 +0800 > > Tao Xu wrote: > > > >> Add struct NumaState in MachineState and move existing numa global > >> nb_numa_nodes(renamed as "num_nodes") into NumaState. And add v

[Qemu-devel] [Bug 1837347] Re: guest userspace process core dump after raspi2 kernel boot

2019-07-30 Thread Peter Maydell
** Summary changed: - core dump after raspi2 kernel boot + guest userspace process core dump after raspi2 kernel boot ** Tags added: arm -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1837347 Title:

[Qemu-devel] x86 VMCS guest interruptibility state save/load

2019-07-30 Thread Hang Yuan
Hello all, When I read QEMU and KVM codes on saving/loading snapshot, I don't find the interruptibility state in x86 VMCS structure is saved and loaded in QEMU though KVM supports getting/setting this field from/into VMCS. (No "env.interrupt.shadow" in QEMU vmstate_x86_cpu.fields.) I understan

Re: [Qemu-devel] [PATCH v2 2/2] memory-device: break the loop if tmp exceed the hinted range

2019-07-30 Thread Igor Mammedov
On Tue, 30 Jul 2019 08:37:40 +0800 Wei Yang wrote: > The memory-device list built by memory_device_build_list is ordered by > its address, this means if the tmp range exceed the hinted range, all > the following range will not overlap with it. > > And this won't change default pc-dimm mapping an

[Qemu-devel] [PATCH 2/2] pcie_root_port: Disable ACS on older machines

2019-07-30 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" ACS got added in 4.0 unconditionally, that broke older<->4.0 migration where there was a PCIe root port. Fix this by turning it off for 3.1 and older machines; note this fixes compatibility for older QEMUs but breaks compatibility with 4.0 for older machine types.

[Qemu-devel] [for 4.1 PATCH 0/2] Disable PCIe ACS on older machines

2019-07-30 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" PCIe ACS (Access Control services) got added in 4.0 and broke migration to and from 3.1 and earlier. Fix it here for older machine types, at the cost of breaking that compatibility with 4.0. Signed-off-by: Dr. David Alan Gilbert Dr. David Alan Gilbert (2): pc

[Qemu-devel] [PATCH 1/2] pcie_root_port: Allow ACS to be disabled

2019-07-30 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" ACS was added in 4.0 unconditionally, this breaks migration compatibility. Allow ACS to be disabled by adding a property that's checked by pcie_root_port. Unfortunately pcie-root-port doesn't have any instance data, so there's no where for that flag to live, so stu

Re: [Qemu-devel] [PULL 0/3] virtio, pc: fixes

2019-07-30 Thread Peter Maydell
On Mon, 29 Jul 2019 at 22:16, Michael S. Tsirkin wrote: > > I'm sending this out now as these patches are ready, > but it seems likely we'll need another patch for pci, > and as it deals with migration compat it might be a blocker. > Will know more tomorrow :( > > > The following changes since com

Re: [Qemu-devel] [PATCH] virtio pmem: user document

2019-07-30 Thread Cornelia Huck
On Tue, 30 Jul 2019 12:16:57 +0530 Pankaj Gupta wrote: > This patch documents the steps to use virtio pmem. > It also documents other useful information about > virtio pmem e.g use-case, comparison with Qemu NVDIMM > backend and current limitations. > > Signed-off-by: Pankaj Gupta > --- > docs

[Qemu-devel] [Bug 1818937] Re: Crash with HV_ERROR on macOS host

2019-07-30 Thread Roman Bolshakov
It's not possible to allocate MSR bitmap in userspace because it requires a physical address to be stored in the VMCS field. However, the bitmap page is already allocated inside kernel part of Hypervisor.framework. The 4k bitmap region is aligned to page boundary. It's worth to continue inspection

Re: [Qemu-devel] [PATCH] Revert "ide/ahci: Check for -ECANCELED in aio callbacks"

2019-07-30 Thread Philippe Mathieu-Daudé
Hi John, On 7/30/19 12:36 AM, John Snow wrote: > This reverts commit 0d910cfeaf2076b116b4517166d5deb0fea76394. > > It's not correct to just ignore an error code in a callback; we need to > handle that error and possible report failure to the guest so that they > don't wait indefinitely for an ope

Re: [Qemu-devel] [PATCH for-4.1] scsi-cd: Fix inserting read-only media in empty drive

2019-07-30 Thread Max Reitz
On 30.07.19 10:29, Kevin Wolf wrote: > Am 30.07.2019 um 08:31 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >>> scsi-disks decides whether it has a read-only device by looking at >>> whether the BlockBackend specified as drive=... is read-only. In the >>> case of an anonymous BlockBa

Re: [Qemu-devel] [PATCH for-4.1] scsi-cd: Fix inserting read-only media in empty drive

2019-07-30 Thread Max Reitz
On 29.07.19 18:42, Kevin Wolf wrote: > scsi-disks decides whether it has a read-only device by looking at > whether the BlockBackend specified as drive=... is read-only. In the > case of an anonymous BlockBackend (with a node name specified in > drive=...), this is the read-only flag of the attache

[Qemu-devel] [Bug 1838312] Re: Qemu virt-manager Segmentation fault

2019-07-30 Thread Hans Peter
I found crash-report from python 3.7 similiar to this error: kernel: [ 2003.888116] virt-manager[16014]: segfault at 32d0 ip 32d0 sp 7ffeb09ac658 error 14 in python3.7[40+21000] kernel: [ 2003.888124] Code: Bad RIP value. look here: ProblemType: Crash Date: Fri Jul 26 15:03

[Qemu-devel] [Bug 1838312] Re: Qemu virt-manager Segmentation fault

2019-07-30 Thread Hans Peter
** Attachment added: "Crash.log of python3.7" https://bugs.launchpad.net/qemu/+bug/1838312/+attachment/528/+files/crash.log -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1838312 Title: Qemu

[Qemu-devel] [Bug 1838277] Re: qemu-system-aarch64: regression: msr vbar_el2, xN not working in EL2

2019-07-30 Thread Elouan Appéré
Right, so basically I was working on https://github.com/Atmosphere- NX/Atmosphere/tree/hyp/thermosphere (make PLATFORM=qemu qemudbg). This uses Arm Trusted Firmware. While gdb now reports $VBAR_EL2 correctly (as opposed to what the title says), I observed the following effects: - at least before

[Qemu-devel] [PATCH] Fix: fp-test uninitialized member floatX::exp

2019-07-30 Thread Andrey Shinkevich
Not all the paths in the functions, such as f16ToFloatX(), initialize the member 'exp' of the structure floatX. Signed-off-by: Andrey Shinkevich --- source/slowfloat.c | 4 1 file changed, 4 insertions(+) diff --git a/tests/fp/berkeley-testfloat-3/source/slowfloat.c b/tests/fp/berkeley-te

Re: [Qemu-devel] [PATCH v3 00/33] Multi-phase reset mechanism

2019-07-30 Thread Cornelia Huck
On Mon, 29 Jul 2019 16:56:21 +0200 Damien Hedde wrote: (...) > 2. old's device_reset > > There was a few call to this function, I renamed it *device_legacy_reset* to > handle the transition. This function allowed to reset only a given device > (and not its eventual qbus subtree). This behavior

[Qemu-devel] [Bug 1818937] Re: Crash with HV_ERROR on macOS host

2019-07-30 Thread Roman Bolshakov
During the inspection of Apple reference, I have noticed that Guest CR0 and CR0 Guest/Host Mask has incorrect value. Apple defines that Guest CR0 is writable only if: CR0.CD and CR0.NW are unset But hvf accel code follows Intel SDM "Table 9-1. IA-32 and Intel 64 Processor States Following Power-

Re: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-07-30 Thread Andrea Bolognani
On Mon, 2019-07-29 at 14:57 +0200, Sergio Lopez wrote: [...] > /* virtio-mmio device */ > > static Property virtio_mmio_properties[] = { > DEFINE_PROP_BOOL("format_transport_address", VirtIOMMIOProxy, > format_transport_address, true), > +DEFINE_PROP_BOOL("modern"

Re: [Qemu-devel] [PATCH 1/2] pcie_root_port: Allow ACS to be disabled

2019-07-30 Thread Igor Mammedov
On Tue, 30 Jul 2019 10:37:18 +0100 "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > ACS was added in 4.0 unconditionally, this breaks migration > compatibility. > Allow ACS to be disabled by adding a property that's > checked by pcie_root_port. > > Unfortunately pcie-

[Qemu-devel] [Bug 1838390] [NEW] vmx_write_mem: mmu_gva_to_gpa failed when using hvf

2019-07-30 Thread James Smart
Public bug reported: Installed qemu 4.0.0 by homebrew, used below commands: 1. qemu-img create -f raw arch-vm.img 100G 2. qemu-system-x86_64 -show-cursor -only-migratable -nodefaults -boot order=d -cdrom archlinux-2019.07.01-x86_64.iso -cpu host -device virtio-keyboard -device virtio-mouse -dev

[Qemu-devel] [Bug 1838277] Re: qemu-system-aarch64: regression: TCG sometimes using wrong values for VBAR_EL2 despite it being correctly reported to GDB

2019-07-30 Thread Peter Maydell
If you want me to investigate whatever the issue with 'mov sp, x8' crashing is you'll need to provide a binary that demonstrates that problem, not one with a workaround in it. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bu

[Qemu-devel] [Bug 1838277] Re: qemu-system-aarch64: regression: TCG sometimes using wrong values for VBAR_EL2 despite it being correctly reported to GDB

2019-07-30 Thread Peter Maydell
For me that test binary seems to work (with a QEMU built from upstream git commit 893dc8300c80e3dc32f3) : at least it boots and prints various messages ending with "Hello from Thermosphere!". -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

[Qemu-devel] When to use qemu/typedefs.h (was: [PATCH 23/28] numa: Don't include hw/boards.h into sysemu/numa.h)

2019-07-30 Thread Markus Armbruster
Cc'ing a few more people who might be interested. Eduardo Habkost writes: > On Fri, Jul 26, 2019 at 02:05:37PM +0200, Markus Armbruster wrote: >> sysemu/numa.h includes hw/boards.h just for the CPUArchId typedef, at >> the cost of pulling in more than two dozen extra headers indirectly. >> >> I

Re: [Qemu-devel] [PATCH 22/28] Include hw/boards.h a bit less

2019-07-30 Thread Markus Armbruster
Eduardo Habkost writes: > On Fri, Jul 26, 2019 at 02:05:36PM +0200, Markus Armbruster wrote: >> hw/boards.h pulls in almost 60 headers. The less we include it into >> headers, the better. As a first step, drop superfluous inclusions, >> and downgrade some more to what's actually needed. Gets r

Re: [Qemu-devel] [PATCH 2/2] linux-user: manage binfmt-misc preserve-arg[0] flag

2019-07-30 Thread John Paul Adrian Glaubitz
Hi! Sorry for the late reply! On 7/17/19 12:07 PM, Laurent Vivier wrote: > And I don't like to break existing things... > > What I can propose: > > 1- modify this patch to add a configure option: > >by default qemu will need the QEMU_ARGV0 but we will be able to > define at configure time

Re: [Qemu-devel] [PATCH 22/28] Include hw/boards.h a bit less

2019-07-30 Thread Markus Armbruster
Eduardo Habkost writes: > On Fri, Jul 26, 2019 at 02:05:36PM +0200, Markus Armbruster wrote: >> hw/boards.h pulls in almost 60 headers. The less we include it into >> headers, the better. As a first step, drop superfluous inclusions, >> and downgrade some more to what's actually needed. Gets r

Re: [Qemu-devel] [PATCH for-4.1] scsi-cd: Fix inserting read-only media in empty drive

2019-07-30 Thread Markus Armbruster
Max Reitz writes: > On 30.07.19 10:29, Kevin Wolf wrote: >> Am 30.07.2019 um 08:31 hat Markus Armbruster geschrieben: >>> Kevin Wolf writes: >>> scsi-disks decides whether it has a read-only device by looking at whether the BlockBackend specified as drive=... is read-only. In the

Re: [Qemu-devel] [PATCH 1/2] pcie_root_port: Allow ACS to be disabled

2019-07-30 Thread Dr. David Alan Gilbert
* Igor Mammedov (imamm...@redhat.com) wrote: > On Tue, 30 Jul 2019 10:37:18 +0100 > "Dr. David Alan Gilbert (git)" wrote: > > > From: "Dr. David Alan Gilbert" > > > > ACS was added in 4.0 unconditionally, this breaks migration > > compatibility. > > Allow ACS to be disabled by adding a property

Re: [Qemu-devel] [PATCH v4 17/20] console: make screendump asynchronous

2019-07-30 Thread Gerd Hoffmann
> > > +/* > > > + * FIXME: async save with coroutine? it would have to copy or > > > + * lock the surface. > > > + */ > > > +ppm_save(dump->filename, surface, &err); > > > > DisplaySurface is just a thin layer above pixman images these days. > > Pixman images

Re: [Qemu-devel] [PATCH 2/2] linux-user: manage binfmt-misc preserve-arg[0] flag

2019-07-30 Thread Peter Maydell
On Wed, 17 Jul 2019 at 11:07, Laurent Vivier wrote: > QEMU is not able to detect if it has been started by binfmt_misc with > the preserve-arg[0] enabled or not, so it can't adapt the args analysis > to get the correct list. If the kernel provided a more useful interface (for instance telling us

[Qemu-devel] [PULL 0/4] Block layer and multiboot test patches

2019-07-30 Thread Kevin Wolf
The following changes since commit ee9545ed1543020fba52fa5fb8f2b71c63e5389f: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2019-07-30 09:43:32 +0100) are available in the Git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you to fetch chan

[Qemu-devel] [PULL 1/4] tests/multiboot: Fix load address of test kernels

2019-07-30 Thread Kevin Wolf
While older toolchains produced binaries where the physical load address of ELF segments was the same as the virtual address, newer versions seem to choose a different physical address if it isn't specified explicitly. The means that the test kernel doesn't use the right addresses to access e.g. fo

[Qemu-devel] [PULL 4/4] scsi-cd: Fix inserting read-only media in empty drive

2019-07-30 Thread Kevin Wolf
scsi-disks decides whether it has a read-only device by looking at whether the BlockBackend specified as drive=... is read-only. In the case of an anonymous BlockBackend (with a node name specified in drive=...), this is the read-only flag of the attached node. In the case of an empty anonymous Blo

[Qemu-devel] [PULL 3/4] block/copy-on-read: Fix permissions for inactive node

2019-07-30 Thread Kevin Wolf
The copy-on-read drive must not request the WRITE_UNCHANGED permission for its child if the node is inactive, otherwise starting a migration destination with -incoming will fail because the child cannot provide write access yet: qemu-system-x86_64: -blockdev copy-on-read,file=img,node-name=cor:

[Qemu-devel] [Bug 1838277] Re: qemu-system-aarch64: regression: TCG sometimes using wrong values for VBAR_EL2 despite it being correctly reported to GDB

2019-07-30 Thread Elouan Appéré
> For me that test binary seems to work (with a QEMU built from upstream git commit 893dc8300c80e3dc32f3) : at least it boots and prints various messages ending with "Hello from Thermosphere!" my bad, I wasn't precise enough. Right now, test binary should display a crash dump (=> exceptions.c) fol

[Qemu-devel] [PULL 2/4] Fixes: add read-zeroes to 051.out

2019-07-30 Thread Kevin Wolf
From: Andrey Shinkevich The patch "iotests: Set read-zeroes on in null block driver for Valgrind" with the commit ID a6862418fec4072 needs the change in 051.out when compared against on the s390 system. Fixes: a6862418fec40727b392c86dc13d9ec980efcb15 Reported-by: Christian Borntraeger Signed-of

Re: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-07-30 Thread Cornelia Huck
On Tue, 30 Jul 2019 12:25:30 +0200 Andrea Bolognani wrote: > On Mon, 2019-07-29 at 14:57 +0200, Sergio Lopez wrote: > [...] > > /* virtio-mmio device */ > > > > static Property virtio_mmio_properties[] = { > > DEFINE_PROP_BOOL("format_transport_address", VirtIOMMIOProxy, > >

[Qemu-devel] [Bug 1838277] Re: qemu-system-aarch64: regression: TCG sometimes using wrong values for VBAR_EL2 despite it being correctly reported to GDB

2019-07-30 Thread Elouan Appéré
For the x20/mov sp, x8 crash, it happens on the previous commit, 511a9d86cd2de93f3a9956d248e54e46a89eabb9 (build attached). Workaround, not in the build, is to comment out start.s:45 (but not line 43). This time it goes into my exception handlers even before I set vbar_el2. Only one target "core"

Re: [Qemu-devel] [Qemu-block] [QEMU] [PATCH v5 0/8] Add Qemu to SeaBIOS LCHS interface

2019-07-30 Thread Gerd Hoffmann
Hi, [ just back from summer vacation, wading through my backlog ... ] > > I feel like it would be up to Gerd as the general SeaBIOS point of contact? > > > > ...ah, who is offline for vacation. > > We're in freeze right now anyway, so I would think that Gerd and/or > Kevin can work out who o

Re: [Qemu-devel] [PATCH] Revert "ide/ahci: Check for -ECANCELED in aio callbacks"

2019-07-30 Thread Paolo Bonzini
On 30/07/19 11:54, Philippe Mathieu-Daudé wrote: > Hi John, > > On 7/30/19 12:36 AM, John Snow wrote: >> This reverts commit 0d910cfeaf2076b116b4517166d5deb0fea76394. >> >> It's not correct to just ignore an error code in a callback; we need to >> handle that error and possible report failure to t

[Qemu-devel] [Bug 1838277] Re: qemu-system-aarch64: regression: TCG sometimes using wrong values for VBAR_EL2 despite it being correctly reported to GDB

2019-07-30 Thread Peter Maydell
Can you please provide clear and exact reproduction instructions and binaries for whatever the bugs you think you're seeing are? Bear in mind that I know nothing at all about your guest binary or how it is supposed to behave, and I am not going to build versions of your binary from source. If I nee

[Qemu-devel] [PATCH for-4.1?] nvme: Limit blkshift to 12 (for 4 kB blocks)

2019-07-30 Thread Max Reitz
Linux does not support blocks greater than 4 kB anyway, so we might as well limit blkshift to 12 and thus save us from some potential trouble. Reported-by: Peter Maydell Suggested-by: Maxim Levitsky Signed-off-by: Max Reitz --- I won't be around for too long today, so I thought I'd just write a

[Qemu-devel] [Bug 1838277] Re: qemu-system-aarch64: regression: TCG sometimes using wrong values for VBAR_EL2 despite it being correctly reported to GDB

2019-07-30 Thread Elouan Appéré
Sure. * For both: extract the archive in the same folder, chmod to it & run qemu-system-aarch64 -nographic -machine virt,secure=on,virtualization=on ,gic-version=2 -cpu cortex-a57 -smp 2 -m 1024 -bios bl1.bin -d unimp -semihosting-config enable,target=native -serial mon:stdio -s -S * In another

Re: [Qemu-devel] [PATCH for-4.1?] nvme: Limit blkshift to 12 (for 4 kB blocks)

2019-07-30 Thread Maxim Levitsky
On Tue, 2019-07-30 at 13:48 +0200, Max Reitz wrote: > Linux does not support blocks greater than 4 kB anyway, so we might as > well limit blkshift to 12 and thus save us from some potential trouble. Well in theory its not 4K but PAGE_SIZE, thus on some IBM machines that I heard have 64K page size

Re: [Qemu-devel] [PATCH 1/2] pcie_root_port: Allow ACS to be disabled

2019-07-30 Thread Igor Mammedov
On Tue, 30 Jul 2019 12:13:06 +0100 "Dr. David Alan Gilbert" wrote: > * Igor Mammedov (imamm...@redhat.com) wrote: > > On Tue, 30 Jul 2019 10:37:18 +0100 > > "Dr. David Alan Gilbert (git)" wrote: > > > > > From: "Dr. David Alan Gilbert" > > > > > > ACS was added in 4.0 unconditionally, this br

Re: [Qemu-devel] [PATCH 2/2] pcie_root_port: Disable ACS on older machines

2019-07-30 Thread Igor Mammedov
On Tue, 30 Jul 2019 10:37:19 +0100 "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > ACS got added in 4.0 unconditionally, that broke older<->4.0 migration > where there was a PCIe root port. > Fix this by turning it off for 3.1 and older machines; note this > fixes co

Re: [Qemu-devel] [PATCH] virtio pmem: user document

2019-07-30 Thread Pankaj Gupta
> On Tue, 30 Jul 2019 12:16:57 +0530 > Pankaj Gupta wrote: > > > This patch documents the steps to use virtio pmem. > > It also documents other useful information about > > virtio pmem e.g use-case, comparison with Qemu NVDIMM > > backend and current limitations. > > > > Signed-off-by: Pankaj

[Qemu-devel] [Bug 1838277] Re: qemu-system-aarch64: regression: TCG sometimes using wrong values for VBAR_EL2 despite it being correctly reported to GDB

2019-07-30 Thread Elouan Appéré
ie. there's x20 being wrongly used in start.s in some places, meaning #8 can be discarded, but this does not explain the vbar_el2 bug (the repro steps for which are above). qemu *did* correctly jump to 0x60001200 (synchronous exception from same EL with vbar_el2=0x60001000) in version 2.11, but no

Re: [Qemu-devel] [PATCH 24/28] Include sysemu/hostmem.h less

2019-07-30 Thread Igor Mammedov
On Fri, 26 Jul 2019 14:05:38 +0200 Markus Armbruster wrote: > Move the HostMemoryBackend typedef from sysemu/hostmem.h to > qemu/typedefs.h. This renders a few inclusions of sysemu/hostmem.h > superflouous; drop them. > > Cc: Eduardo Habkost > Cc: Igor Mammedov > Signed-off-by: Markus Armbrus

[Qemu-devel] [Bug 1838277] Re: qemu-system-aarch64: regression: TCG sometimes using wrong values for VBAR_EL2 despite it being correctly reported to GDB

2019-07-30 Thread Elouan Appéré
s/pstate is 0x3c5/pstate is whatever | 0x3c9, ie. qemu correctly reports the code is executing as EL2h -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1838277 Title: qemu-system-aarch64: regression:

Re: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-07-30 Thread Andrea Bolognani
On Tue, 2019-07-30 at 13:35 +0200, Cornelia Huck wrote: > On Tue, 30 Jul 2019 12:25:30 +0200 > Andrea Bolognani wrote: > > Can you please make sure virtio-mmio uses the existing interface > > instead of introducing a new one? > > FWIW, I really hate virtio-pci's disable-modern/disable-legacy... f

Re: [Qemu-devel] [PATCH] virtiofsd: fix compile error if 'F_OFD_GETLK' not defined

2019-07-30 Thread Liam Merwick
On 30/07/2019 01:27, piaojun wrote: Use F_GETLK for fcntl when F_OFD_GETLK not defined. Use F_GETLK/F_SETLK for fcntl when F_OFD_GETLK/F_OFD_SETLK not defined. Signed-off-by: Jun Piao --- contrib/virtiofsd/passthrough_ll.c | 9 + 1 file changed, 9 insertions(+) diff --git a/con

[Qemu-devel] [Bug 1838277] Re: qemu-system-aarch64: regression: TCG sometimes using wrong values for VBAR_EL2 despite it being correctly reported to GDB

2019-07-30 Thread Peter Maydell
Your example_x20_mov_sp_x8 binary performs an illegal-exception-return because it does an eret from EL2 to EL1 without having set HCR_EL2.RW to 1. That means that the CPU will continue execution from the exception- return "link address" in ELR_EL2 (and remain in EL2). That is 0, because we just loa

Re: [Qemu-devel] [PULL 0/4] Block layer and multiboot test patches

2019-07-30 Thread Peter Maydell
On Tue, 30 Jul 2019 at 12:24, Kevin Wolf wrote: > > The following changes since commit ee9545ed1543020fba52fa5fb8f2b71c63e5389f: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2019-07-30 09:43:32 +0100) > > are available in the Git repository at: > > git://re

[Qemu-devel] [Bug 1838277] Re: qemu-system-aarch64: regression: TCG sometimes using wrong values for VBAR_EL2 despite it being correctly reported to GDB

2019-07-30 Thread Peter Maydell
Thanks for your repro instructions of comment #10. Something weird is indeed going on: the -d int logging reports: Taking exception 7 [Breakpoint] ...from EL2 to EL1 ...with ESR 0x3c/0xf20003e8 ...with ELR 0x610c ...to EL1 PC 0x200 PSTATE 0x3c5 but an exception should *never* get taken from a

[Qemu-devel] [Bug 1838277] Re: qemu-system-aarch64: regression: TCG sometimes using wrong values for VBAR_EL2 despite it being correctly reported to GDB

2019-07-30 Thread Elouan Appéré
As I said, you should have ignored example_x20_mov_sp_x8 totally -- this was a bug on my end, which I fixed. What about https://bugs.launchpad.net/qemu/+bug/1838277/+attachment/5279996/+files/example.zip, the steps for which are in #10? This one does not return from exception, and executes a brk i

Re: [Qemu-devel] [PULL 3/3] pc-dimm: fix crash when invalid slot number is used

2019-07-30 Thread Igor Mammedov
On Mon, 29 Jul 2019 17:16:14 -0400 "Michael S. Tsirkin" wrote: Hi Michael, it seems tooling used for pull req is a bit broken * minor issue is CC list contains bogus addresses like: &l...@redhat.com, mamme...@redhat.com, * a bigger issie is that Message-Id is taken from original patch even th

[Qemu-devel] [Bug 1838277] Re: qemu-system-aarch64: regression: TCG sometimes using wrong values for VBAR_EL2 despite it being correctly reported to GDB

2019-07-30 Thread Elouan Appéré
Sorry, didn't saw #14 when I was posting #15. Thank you again for your patience. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1838277 Title: qemu-system-aarch64: regression: TCG sometimes using w

[Qemu-devel] [PATCH 2/3] tests/tcg: cleanup Makefile inclusions

2019-07-30 Thread Paolo Bonzini
Rename Makefile.probe to Makefile.prereqs and make it actually define rules for the tests. Rename Makefile to Makefile.target, since it is not a toplevel makefile. Rename Makefile.include to Makefile.qemu and disentangle it from the QEMU Makefile.target, so that it is invoked recursively by tests

[Qemu-devel] [PATCH 0/3] tests/tcg: disentangle makefiles

2019-07-30 Thread Paolo Bonzini
The tests/tcg rely a lot on per-target informations from the QEMU makefiles, but most of the definitions in there aren't really relevant to TCG tests. This series is just a cleanup, but it could also be a useful start in making it possible to compile tests/tcg out of QEMU's tree, and/or making it

[Qemu-devel] [PATCH 1/3] tests/tcg: use EXTRA_CFLAGS everywhere

2019-07-30 Thread Paolo Bonzini
For i386 specifically, this allows using the host GCC to compile the i386 tests. But, it should really be done for all targets, unless we want to pass $(EXTRA_CFLAGS) directly as part of $(CC). Signed-off-by: Paolo Bonzini --- tests/tcg/aarch64/Makefile.softmmu-target | 4 ++-- tests/tcg/alpha/

[Qemu-devel] [PATCH 3/3] tests/tcg: move configuration to a sub-shell script

2019-07-30 Thread Paolo Bonzini
Avoid the repeated inclusions of config-target.mak, which have risks of namespace pollution, and instead build minimal configuration files in a configuration script. The same configuration files can also be included in Makefile and Makefile.qemu Signed-off-by: Paolo Bonzini --- Makefile

Re: [Qemu-devel] [PATCH 1/2] pcie_root_port: Allow ACS to be disabled

2019-07-30 Thread Dr. David Alan Gilbert
* Igor Mammedov (imamm...@redhat.com) wrote: > On Tue, 30 Jul 2019 12:13:06 +0100 > "Dr. David Alan Gilbert" wrote: > > > * Igor Mammedov (imamm...@redhat.com) wrote: > > > On Tue, 30 Jul 2019 10:37:18 +0100 > > > "Dr. David Alan Gilbert (git)" wrote: > > > > > > > From: "Dr. David Alan Gilbert

Re: [Qemu-devel] [PATCH v3 25/50] translator: add translator_ld{ub, sw, uw, l, q}

2019-07-30 Thread Alex Bennée
Richard Henderson writes: > On 6/14/19 10:11 AM, Alex Bennée wrote: >> +#define GEN_TRANSLATOR_LD(fullname, name, type, swap_fn)\ >> +static inline type \ >> +fullname ## _swap(CPUArchState *env, abi_ptr pc, bool do_swap)

Re: [Qemu-devel] [PATCH 2/3] tests/tcg: cleanup Makefile inclusions

2019-07-30 Thread Philippe Mathieu-Daudé
On 7/30/19 2:37 PM, Paolo Bonzini wrote: [...] > Drop the usage of TARGET_BASE_ARCH, which is ignored by everything except > x86_64 and aarch64. Fix x86 tests by using -cpu max and, while > at it, standardize on QEMU_OPTS for aarch64 tests too. > > Signed-off-by: Paolo Bonzini > --- [...] > ---

[Qemu-devel] [Bug 1838277] Re: qemu-system-aarch64: regression: TCG sometimes using wrong values for VBAR_EL2 despite it being correctly reported to GDB

2019-07-30 Thread Peter Maydell
This bug is specific to our handling of the 'brk' insn (and other debug exceptions within the guest like singlestep or watchpoints or breakpoints) at EL2, so you can work around it for the moment by avoiding using hardcoded brk insns in your EL2 code. -- You received this bug notification because

Re: [Qemu-devel] [PATCH] Revert "ide/ahci: Check for -ECANCELED in aio callbacks"

2019-07-30 Thread Philippe Mathieu-Daudé
On 7/30/19 1:37 PM, Paolo Bonzini wrote: > On 30/07/19 11:54, Philippe Mathieu-Daudé wrote: >> Hi John, >> >> On 7/30/19 12:36 AM, John Snow wrote: >>> This reverts commit 0d910cfeaf2076b116b4517166d5deb0fea76394. >>> >>> It's not correct to just ignore an error code in a callback; we need to >>> h

Re: [Qemu-devel] [PATCH] Revert "ide/ahci: Check for -ECANCELED in aio callbacks"

2019-07-30 Thread John Snow
On 7/30/19 5:54 AM, Philippe Mathieu-Daudé wrote: > Hi John, > > On 7/30/19 12:36 AM, John Snow wrote: >> This reverts commit 0d910cfeaf2076b116b4517166d5deb0fea76394. >> >> It's not correct to just ignore an error code in a callback; we need to >> handle that error and possible report failure

Re: [Qemu-devel] [PATCH] tests: Set read-zeroes on for null-co driver

2019-07-30 Thread Thomas Huth
On 29/07/2019 14.46, Andrey Shinkevich wrote: > This patch is to reduce the number of Valgrind report messages about > using uninitialized memory with the null-co driver. It helps to filter > real memory issues and is the same work done for the iotests with the > commit ID a6862418fec4072. > > Sug

Re: [Qemu-devel] [PATCH 0/3] tests/tcg: disentangle makefiles

2019-07-30 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190730123759.21723-1-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH 0/3] tests/tcg: disentangle makefiles Message-id: 20190730123759.21723-1

Re: [Qemu-devel] [PATCH] tests: Set read-zeroes on for null-co driver

2019-07-30 Thread Thomas Huth
On 30/07/2019 14.52, Thomas Huth wrote: > On 29/07/2019 14.46, Andrey Shinkevich wrote: >> This patch is to reduce the number of Valgrind report messages about >> using uninitialized memory with the null-co driver. It helps to filter >> real memory issues and is the same work done for the iotests w

[Qemu-devel] [PULL 0/1] Block patches for 4.1.0-rc3

2019-07-30 Thread Max Reitz
The following changes since commit 6e9a6cbe7d56107f5e0d7711905dc19bb4d7e3f0: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2019-07-30 12:25:35 +0100) are available in the Git repository at: https://github.com/XanClic/qemu.git tags/pull-block-2019-07-30 for yo

[Qemu-devel] [PULL 1/1] nvme: Limit blkshift to 12 (for 4 kB blocks)

2019-07-30 Thread Max Reitz
Linux does not support blocks greater than 4 kB anyway, so we might as well limit blkshift to 12 and thus save us from some potential trouble. Reported-by: Peter Maydell Suggested-by: Maxim Levitsky Signed-off-by: Max Reitz Message-id: 20190730114812.10493-1-mre...@redhat.com Reviewed-by: Maxim

[Qemu-devel] [Bug 1838277] Re: qemu-system-aarch64: regression: TCG sometimes using wrong values for VBAR_EL2 despite it being correctly reported to GDB

2019-07-30 Thread Elouan Appéré
To be precise, as I was doing my own investigation, this only happens when *both* the following hold: - a breakpoint instruction is executed in EL2 (as you mentionned). - ELD is EL1. This does **not** happen **if ELD is EL2**, after setting e.g. MDCR_EL2.TDE to 1. As mentionned above, it's a reg

Re: [Qemu-devel] [PATCH v7 13/15] qemu-nbd: adds option for aio engines

2019-07-30 Thread Eric Blake
On 7/29/19 10:16 AM, Aarushi Mehta wrote: > Signed-off-by: Aarushi Mehta > --- > qemu-nbd.c| 12 > qemu-nbd.texi | 4 ++-- > 2 files changed, 6 insertions(+), 10 deletions(-) Acked-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3

Re: [Qemu-devel] [PATCH] virtiofsd: fix compile error if 'F_OFD_GETLK' not defined

2019-07-30 Thread piaojun
Hi Liam, On 2019/7/30 20:22, Liam Merwick wrote: > On 30/07/2019 01:27, piaojun wrote: >> Use F_GETLK for fcntl when F_OFD_GETLK not defined. > > > Use F_GETLK/F_SETLK for fcntl when F_OFD_GETLK/F_OFD_SETLK not defined. > >> >> Signed-off-by: Jun Piao >> --- >> contrib/virtiofsd/passthrough_

Re: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-07-30 Thread Cornelia Huck
On Tue, 30 Jul 2019 14:17:48 +0200 Andrea Bolognani wrote: > On Tue, 2019-07-30 at 13:35 +0200, Cornelia Huck wrote: > > On Tue, 30 Jul 2019 12:25:30 +0200 > > Andrea Bolognani wrote: > > > Can you please make sure virtio-mmio uses the existing interface > > > instead of introducing a new one?

Re: [Qemu-devel] When to use qemu/typedefs.h (was: [PATCH 23/28] numa: Don't include hw/boards.h into sysemu/numa.h)

2019-07-30 Thread Eric Blake
On 7/30/19 6:01 AM, Markus Armbruster wrote: > Cc'ing a few more people who might be interested. > > Eduardo Habkost writes: >> Why is it bad to require the inclusion of hw/boards.h just >> because of CPUArchId, but acceptable to require the inclusion of >> qapi-types-machine.h just to be able t

Re: [Qemu-devel] [PATCH] vhost-vsock: report QMP event when set running

2019-07-30 Thread Eric Blake
On 7/30/19 7:24 AM, N. B. wrote: > From: Ning Bo > > Report vsock running event so that the upper application can > control boot sequence. > see https://github.com/kata-containers/runtime/pull/1918 > > Signed-off-by: Ning Bo Your From: and S-o-b: differ from one another, which can make crawlin

Re: [Qemu-devel] [PATCH 2/3] tests/tcg: cleanup Makefile inclusions

2019-07-30 Thread Paolo Bonzini
On 30/07/19 14:44, Philippe Mathieu-Daudé wrote: > On 7/30/19 2:37 PM, Paolo Bonzini wrote: > [...] >> Drop the usage of TARGET_BASE_ARCH, which is ignored by everything except >> x86_64 and aarch64. Fix x86 tests by using -cpu max and, while >> at it, standardize on QEMU_OPTS for aarch64 tests to

Re: [Qemu-devel] [PATCH] tests: Set read-zeroes on for null-co driver

2019-07-30 Thread Andrey Shinkevich
On 30/07/2019 15:59, Thomas Huth wrote: > On 30/07/2019 14.52, Thomas Huth wrote: >> On 29/07/2019 14.46, Andrey Shinkevich wrote: >>> This patch is to reduce the number of Valgrind report messages about >>> using uninitialized memory with the null-co driver. It helps to filter >>> real memory is

Re: [Qemu-devel] [PATCH v3 25/50] translator: add translator_ld{ub, sw, uw, l, q}

2019-07-30 Thread Richard Henderson
On 7/30/19 5:41 AM, Alex Bennée wrote: > Do we ever need _code access that isn't part of the > translator loading instructions? We use it; I'm not sure that's the same as need. ;-) Lots of the uses that I examined should use a mechanism like arm does for recording syndrome data in the unwind slo

[Qemu-devel] [PATCH for-4.1?] target/arm: Deliver BKPT/BRK exceptions to correct exception level

2019-07-30 Thread Peter Maydell
Most Arm architectural debug exceptions (eg watchpoints) are ignored if the configured "debug exception level" is below the current exception level (so for example EL1 can't arrange to get debug exceptions for EL2 execution). Exceptions generated by the BRK or BPKT instructions are a special case -

  1   2   3   4   >