[Qemu-devel] [PATCH v2] NSIS: Add missing firmware blobs

2019-07-23 Thread Philippe Mathieu-Daudé
Various firmwares has been added in the pc-bios/ directory: - CCW (since commit 0c1fecdd523) - skiboot (since commit bcad45de6a0) - EDK2(since commit f7fa38b74c3) Since we install qemu-system able to run the architectures targetted by these firmware, include them in the NSIS exe. Reviewe

Re: [Qemu-devel] [PATCH v2 19/23] tests/docker: invoke the DEBUG shell with --noprofile/--norc

2019-07-23 Thread Philippe Mathieu-Daudé
On 7/17/19 3:43 PM, Alex Bennée wrote: > It's very confusing when things work in the debug shell because the > environment is different from what the test is running. Fix this by > ensuring we only have the inherited environment from the run shell. > > Signed-off-by: Alex Bennée > --- > tests/do

[Qemu-devel] [PATCH v3] block/rbd: add preallocation support

2019-07-23 Thread Stefano Garzarella
This patch adds the support of preallocation (off/full) for the RBD block driver. If rbd_writesame() is available and supports zeroed buffers, we use it to quickly fill the image when full preallocation is required. Signed-off-by: Stefano Garzarella --- v3: - rebased on master - filled with zer

[Qemu-devel] make vm-build-openbsd (was: Re: [PATCH v2 22/23] tests: Run the iotests during "make check" again)

2019-07-23 Thread Thomas Huth
On 22/07/2019 21.53, Philippe Mathieu-Daudé wrote: [...] > Since Gerd updated the OpenBSD image, do you know if we can run vm-test > again? I just tried it, but the OpenBSD build seems to be completely broken right now: $ nice make vm-build-openbsd VM-IMAGE openbsd ### Downloading install i

Re: [Qemu-devel] [PATCH-for-4.1 v3 5/6] virtio-balloon: Rework pbp tracking data

2019-07-23 Thread David Hildenbrand
On 23.07.19 04:54, David Gibson wrote: > On Mon, Jul 22, 2019 at 03:41:07PM +0200, David Hildenbrand wrote: >> Using the address of a RAMBlock to test for a matching pbp is not really >> safe. Instead, let's use the guest physical address of the base page >> along with the page size (via the number

Re: [Qemu-devel] [PATCH-for-4.1 v7 1/1] hw/block/pflash_cfi01: Add missing DeviceReset() handler

2019-07-23 Thread Laszlo Ersek
On 07/22/19 19:12, Peter Maydell wrote: > On Mon, 22 Jul 2019 at 17:51, Laszlo Ersek wrote: >> >> On 07/19/19 18:19, Philippe Mathieu-Daudé wrote: >>> Hi Laszlo, >>> >>> On 7/18/19 9:35 PM, Philippe Mathieu-Daudé wrote: On 7/18/19 8:38 PM, Laszlo Ersek wrote: > Regression-tested-by: Laszl

Re: [Qemu-devel] [PATCH qemu RFC 3/4] spapr: Advertise H_RTAS to the guest

2019-07-23 Thread Alexey Kardashevskiy
On 23/07/2019 16:14, David Gibson wrote: On Tue, Jul 23, 2019 at 03:48:34PM +1000, Alexey Kardashevskiy wrote: On 23/07/2019 13:53, David Gibson wrote: On Sat, Jul 20, 2019 at 11:28:49AM +1000, Alexey Kardashevskiy wrote: Since day 1 QEMU implemented RTAS as a custom hypercall wrapped int

[Qemu-devel] [PATCH] pcie: fix device hotplug failure at the meantime of VM boot

2019-07-23 Thread Zhangbo (Oscar)
If the PCI_EXP_LNKSTA_DLLLA capability is set by default, linux kernel will send PDC event to detect whether there is a device in pcie slot. If a device is pluged in the pcie-root-port at the same time, hot-plug device will send ABP + PDC events to the kernel. The VM kernel will wrongly unplug t

[Qemu-devel] [PATCH] pcie: fix device unplug timeout

2019-07-23 Thread Zhangbo (Oscar)
If the linux kernel only receives an ABP event during pcie unplug, it will sleep 5s to expect a PDC event, which will cause device unplug timeout. In the meanwhile, if the kernel only receives a PDC event during the unplug, it will wait for at least 1 second before checking card present as data

Re: [Qemu-devel] [qemu-s390x] [PATCH v2 01/20] tcg: Replace MO_8 with MO_UB alias

2019-07-23 Thread David Hildenbrand
On 22.07.19 17:38, tony.ngu...@bt.com wrote: > Preparation for splitting MO_8 out from TCGMemOp into new accelerator > independent MemOp. > > As MO_8 will be a value of MemOp, existing TCGMemOp comparisons and > coercions will trigger -Wenum-compare and -Wenum-conversion. > > Signed-off-by: Tony

Re: [Qemu-devel] [PATCH v3 3/4] hw/i386: Factorize PVH related functions

2019-07-23 Thread Liam Merwick
On 02/07/2019 13:11, Sergio Lopez wrote: Extract PVH related functions from pc.c, and put them in pvh.c, so they can be shared with other components. Signed-off-by: Sergio Lopez Refactoring LGTM Reviewed-by: Liam Merwick --- hw/i386/Makefile.objs | 1 + hw/i386/pc.c | 120

Re: [Qemu-devel] [PATCH v3 0/4] Introduce the microvm machine type

2019-07-23 Thread Sergio Lopez
Montes, Julio writes: > On Fri, 2019-07-19 at 16:09 +0100, Stefan Hajnoczi wrote: >> On Fri, Jul 19, 2019 at 2:48 PM Sergio Lopez wrote: >> > Stefan Hajnoczi writes: >> > > On Thu, Jul 18, 2019 at 05:21:46PM +0200, Sergio Lopez wrote: >> > > > Stefan Hajnoczi writes: >> > > > >> > > > > On T

Re: [Qemu-devel] [PATCH for-4.1 2/2] block: Only the main loop can change AioContexts

2019-07-23 Thread Kevin Wolf
Am 22.07.2019 um 15:30 hat Max Reitz geschrieben: > bdrv_set_aio_context_ignore() can only work in the main loop: > bdrv_drained_begin() only works in the main loop and the node's (old) > AioContext; and bdrv_drained_end() really only works in the main loop > and the node's (new) AioContext (contra

[Qemu-devel] [Bug 1696773] Re: golang calls to exec crash user emulation

2019-07-23 Thread Paweł Moll
Observed the same here... (details of the environment at the end of the post) Just building a hello world is good enough to crash go 3 times out of 4: --8<- ubuntu@qemu:~$ cat < hello.go > package main > > import "fmt" > > func

Re: [Qemu-devel] [PATCH v3 3/3] tests/migration: Add a test for auto converge

2019-07-23 Thread Yury Kotov
22.07.2019, 20:35, "Dr. David Alan Gilbert" : > * Yury Kotov (yury-ko...@yandex-team.ru) wrote: >>  Signed-off-by: Yury Kotov > > This looks OK to me, but have you tried it on a really really overloaded > host? > I worry that you might skip some of the percentage steps or not hit the > bandwidth o

Re: [Qemu-devel] make vm-build-openbsd (was: Re: [PATCH v2 22/23] tests: Run the iotests during "make check" again)

2019-07-23 Thread Thomas Huth
On 23/07/2019 09.20, Thomas Huth wrote: > On 22/07/2019 21.53, Philippe Mathieu-Daudé wrote: > [...] >> Since Gerd updated the OpenBSD image, do you know if we can run vm-test >> again? > > I just tried it, but the OpenBSD build seems to be completely broken right > now: > > $ nice make vm-build

[Qemu-devel] [Bug 1772165] Re: arm raspi2/raspi3 emulation has no USB support

2019-07-23 Thread Peter Maydell
I think the two main things we would need would be: (1) a proper data sheet for the pi2/pi3 USB controller. Last time I looked there wasn't one available; it's pretty hard to model the controller properly without it. (Perhaps one has been released since I last looked.) (2) somebody who cares ab

[Qemu-devel] [PATCH] ppc/pnv: Generate phandle for the "interrupt-parent" property

2019-07-23 Thread Cédric Le Goater
Devices such as the BT or serial devices require a valid "interrupt-parent" phandle in the device tree and it is currently empty (0x0). It was not a problem until now but since OpenFirmare started using a recent libdft (>= 1.4.7), petitboot fails to boot the system image with error : dtc_resize

[Qemu-devel] [PATCH 2/2] hw/i386/pc: Map into memory the initrd

2019-07-23 Thread Stefano Garzarella
In order to reduce the memory footprint we map into memory the initrd using g_mapped_file_new() instead of reading it. In this way we can share the initrd pages between multiple instances of QEMU. Suggested-by: Paolo Bonzini Signed-off-by: Stefano Garzarella --- hw/i386/pc.c | 15 +++---

[Qemu-devel] [PATCH 1/2] elf-ops.h: Map into memory the ELF to load

2019-07-23 Thread Stefano Garzarella
In order to reduce the memory footprint we map into memory the ELF to load using g_mapped_file_new_from_fd() instead of reading each sections. In this way we can share the ELF pages between multiple instances of QEMU. Suggested-by: Dr. David Alan Gilbert Suggested-by: Paolo Bonzini Signed-off-by

[Qemu-devel] [PATCH 0/2] pc: mmap kernel (ELF image) and initrd

2019-07-23 Thread Stefano Garzarella
In order to reduce the memory footprint when PVH kernel and initrd are used, we map them into memory instead of reading them. In this way we can share them between multiple instances of QEMU. These are the results using a PVH kernel and initrd (cpio): - memory footprint (using smem) [MB] Q

Re: [Qemu-devel] [PATCH] pcie: fix device hotplug failure at the meantime of VM boot

2019-07-23 Thread Philippe Mathieu-Daudé
Hi Oscar, On 7/23/19 9:47 AM, Zhangbo (Oscar) wrote: > If the PCI_EXP_LNKSTA_DLLLA capability is set by default, linux kernel will > send > PDC event to detect whether there is a device in pcie slot. If a device is > pluged > in the pcie-root-port at the same time, hot-plug device will send ABP

Re: [Qemu-devel] [Qemu-block] [PATCH v3] block/rbd: add preallocation support

2019-07-23 Thread Maxim Levitsky
On Tue, 2019-07-23 at 09:13 +0200, Stefano Garzarella wrote: > This patch adds the support of preallocation (off/full) for the RBD > block driver. > If rbd_writesame() is available and supports zeroed buffers, we use > it to quickly fill the image when full preallocation is required. > > Signed-of

Re: [Qemu-devel] [PATCH v2 22/23] tests: Run the iotests during "make check" again

2019-07-23 Thread Thomas Huth
On 22/07/2019 21.53, Philippe Mathieu-Daudé wrote: > On 7/17/19 3:43 PM, Alex Bennée wrote: >> From: Thomas Huth >> >> People often forget to run the iotests before submitting patches or pull >> requests - this is likely due to the fact that we do not run the tests >> during our mandatory "make ch

[Qemu-devel] [PATCH v2] pcie: fix device hotplug failure at the meantime of VM boot

2019-07-23 Thread Zhangbo (Oscar)
If the PCI_EXP_LNKSTA_DLLLA capability is set by default, linux kernel will send PDC event to detect whether there is a device in pcie slot. If a device is pluged in the pcie-root-port at the same time, hot-plug device will send ABP + PDC events to the kernel. The VM kernel will wrongly unplug t

Re: [Qemu-devel] [PATCH 1/2] elf-ops.h: Map into memory the ELF to load

2019-07-23 Thread Peter Maydell
On Tue, 23 Jul 2019 at 10:08, Stefano Garzarella wrote: > > In order to reduce the memory footprint we map into memory > the ELF to load using g_mapped_file_new_from_fd() instead of > reading each sections. In this way we can share the ELF pages > between multiple instances of QEMU. > > Suggested-

[Qemu-devel] [PATCH v2] pcie: fix device unplug timeout

2019-07-23 Thread Zhangbo (Oscar)
If the linux kernel only receives an ABP event during pcie unplug, it will sleep 5s to expect a PDC event, which will cause device unplug timeout. In the meanwhile, if the kernel only receives a PDC event during the unplug, it will wait for at least 1 second before checking card present as data

Re: [Qemu-devel] [PATCH] pcie: fix device hotplug failure at the meantime of VM boot

2019-07-23 Thread Zhangbo (Oscar)
>-Original Message- >From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com] >Sent: Tuesday, July 23, 2019 5:18 PM >To: Zhangbo (Oscar) ; qemu-devel@nongnu.org >Cc: fangying ; dengkai (A) ; >limingwang (A) ; m...@redhat.com >Subject: Re: [Qemu-devel] [PATCH] pcie: fix device hotplug failu

[Qemu-devel] [PULL v2 0/2] pflash-next patches for v4.1.0-rc2

2019-07-23 Thread Philippe Mathieu-Daudé
flash-next-20190723 for you to fetch changes up to 124e4cfaa42bb5a14eec33ea47d3502b5f46eb33: hw/block/pflash_cfi02: Rewrite a fall through comment (2019-07-23 11:31:07 +0200) One bugfix and silent a fallth

[Qemu-devel] [PULL v2 1/2] hw/block/pflash_cfi01: Add missing DeviceReset() handler

2019-07-23 Thread Philippe Mathieu-Daudé
To avoid incoherent states when the machine resets (see bug report below), add the device reset callback. A "system reset" sets the device state machine in READ_ARRAY mode and, after some delay, set the SR.7 READY bit. Since we do not model timings, we set the SR.7 bit directly. Fixes: https://b

[Qemu-devel] [PULL v2 2/2] hw/block/pflash_cfi02: Rewrite a fall through comment

2019-07-23 Thread Philippe Mathieu-Daudé
GCC9 is confused by this comment when building with CFLAG -Wimplicit-fallthrough=2: hw/block/pflash_cfi02.c: In function ‘pflash_write’: hw/block/pflash_cfi02.c:574:16: error: this statement may fall through [-Werror=implicit-fallthrough=] 574 | if (boff == 0x55 && cmd == 0x98

Re: [Qemu-devel] [PATCH for-4.1 2/2] block: Only the main loop can change AioContexts

2019-07-23 Thread Max Reitz
On 23.07.19 10:52, Kevin Wolf wrote: > Am 22.07.2019 um 15:30 hat Max Reitz geschrieben: >> bdrv_set_aio_context_ignore() can only work in the main loop: >> bdrv_drained_begin() only works in the main loop and the node's (old) >> AioContext; and bdrv_drained_end() really only works in the main loop

Re: [Qemu-devel] [PATCH 1/2] elf-ops.h: Map into memory the ELF to load

2019-07-23 Thread Stefano Garzarella
On Tue, Jul 23, 2019 at 10:32:34AM +0100, Peter Maydell wrote: > On Tue, 23 Jul 2019 at 10:08, Stefano Garzarella wrote: > > > > In order to reduce the memory footprint we map into memory > > the ELF to load using g_mapped_file_new_from_fd() instead of > > reading each sections. In this way we can

Re: [Qemu-devel] [PATCH] pcie: fix device hotplug failure at the meantime of VM boot

2019-07-23 Thread Michael S. Tsirkin
On Tue, Jul 23, 2019 at 07:47:51AM +, Zhangbo (Oscar) wrote: > If the PCI_EXP_LNKSTA_DLLLA capability is set by default, linux kernel will > send > PDC event to detect whether there is a device in pcie slot. If a device is > pluged > in the pcie-root-port at the same time, hot-plug device wi

Re: [Qemu-devel] [PATCH v4 00/18] bitmaps: introduce 'bitmap' sync mode

2019-07-23 Thread Fabian Grünbichler
On Mon, Jul 22, 2019 at 01:21:02PM -0400, John Snow wrote: > > > On 7/22/19 8:17 AM, Fabian Grünbichler wrote: > > On Tue, Jul 09, 2019 at 07:25:32PM -0400, John Snow wrote: > >> This series adds a new "BITMAP" sync mode that is meant to replace the > >> existing "INCREMENTAL" sync mode. > >> > >

Re: [Qemu-devel] [PATCH v3 0/4] Introduce the microvm machine type

2019-07-23 Thread Stefan Hajnoczi
On Tue, Jul 23, 2019 at 9:43 AM Sergio Lopez wrote: > Montes, Julio writes: > > > On Fri, 2019-07-19 at 16:09 +0100, Stefan Hajnoczi wrote: > >> On Fri, Jul 19, 2019 at 2:48 PM Sergio Lopez wrote: > >> > Stefan Hajnoczi writes: > >> > > On Thu, Jul 18, 2019 at 05:21:46PM +0200, Sergio Lopez wro

Re: [Qemu-devel] [PATCH 1/2] elf-ops.h: Map into memory the ELF to load

2019-07-23 Thread Paolo Bonzini
On 23/07/19 11:42, Stefano Garzarella wrote: > "If writable is TRUE, the mapped buffer may be modified, otherwise it is an > error to modify the mapped buffer. Modifications to the buffer are not visible > to other processes mapping the same file, and are not written back to the > file." > > I do

Re: [Qemu-devel] [PULL 0/5] Block patches for 4.1.0-rc2

2019-07-23 Thread Peter Maydell
On Mon, 22 Jul 2019 at 18:26, Max Reitz wrote: > > The following changes since commit 23da9e297b4120ca9702cabec91599a44255fe96: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20190722' into staging (2019-07-22 > 15:16:48 +0100) > > are available in the Git repository

Re: [Qemu-devel] [PATCH 1/2] elf-ops.h: Map into memory the ELF to load

2019-07-23 Thread Peter Maydell
On Tue, 23 Jul 2019 at 10:42, Stefano Garzarella wrote: > Reading the 'g_mapped_file_new_from_fd()' docs [1]: > "If writable is TRUE, the mapped buffer may be modified, otherwise it is an > error to modify the mapped buffer. Modifications to the buffer are not visible > to other processes mapping

Re: [Qemu-devel] [PATCH v3 0/4] Introduce the microvm machine type

2019-07-23 Thread Paolo Bonzini
On 23/07/19 11:47, Stefan Hajnoczi wrote: > fw_cfg could expose this information so guest kernels know when to > stop enumerating the PCI bus. This would make all PCI guests with new > kernels boot ~50 ms faster, regardless of machine type. The number of buses is determined by the firmware, not b

Re: [Qemu-devel] [PATCH for-4.1 2/2] block: Only the main loop can change AioContexts

2019-07-23 Thread Kevin Wolf
Am 23.07.2019 um 11:41 hat Max Reitz geschrieben: > On 23.07.19 10:52, Kevin Wolf wrote: > > Am 22.07.2019 um 15:30 hat Max Reitz geschrieben: > >> bdrv_set_aio_context_ignore() can only work in the main loop: > >> bdrv_drained_begin() only works in the main loop and the node's (old) > >> AioContex

Re: [Qemu-devel] [PATCH] pcie: fix device unplug timeout

2019-07-23 Thread Michael S. Tsirkin
On Tue, Jul 23, 2019 at 07:48:00AM +, Zhangbo (Oscar) wrote: > If the linux kernel only receives an ABP event during pcie unplug, it will > sleep 5s > to expect a PDC event, which will cause device unplug timeout. My understanding is that there's no timeout. Spec says: If present, th

Re: [Qemu-devel] [PATCH 1/2] elf-ops.h: Map into memory the ELF to load

2019-07-23 Thread Stefano Garzarella
On Tue, Jul 23, 2019 at 11:49:13AM +0200, Paolo Bonzini wrote: > On 23/07/19 11:42, Stefano Garzarella wrote: > > "If writable is TRUE, the mapped buffer may be modified, otherwise it is an > > error to modify the mapped buffer. Modifications to the buffer are not > > visible > > to other processe

Re: [Qemu-devel] [PATCH v2] pcie: fix device hotplug failure at the meantime of VM boot

2019-07-23 Thread Michael S. Tsirkin
On Tue, Jul 23, 2019 at 09:31:30AM +, Zhangbo (Oscar) wrote: > If the PCI_EXP_LNKSTA_DLLLA capability is set by default, linux kernel will > send > PDC event to detect whether there is a device in pcie slot. If a device is > pluged > in the pcie-root-port at the same time, hot-plug device wi

Re: [Qemu-devel] [PATCH v2] pcie: fix device unplug timeout

2019-07-23 Thread Michael S. Tsirkin
On Tue, Jul 23, 2019 at 09:33:43AM +, Zhangbo (Oscar) wrote: > If the linux kernel only receives an ABP event during pcie unplug, it will > sleep 5s > to expect a PDC event, which will cause device unplug timeout. > > In the meanwhile, if the kernel only receives a PDC event during the unplu

Re: [Qemu-devel] [PATCH 1/2] elf-ops.h: Map into memory the ELF to load

2019-07-23 Thread Stefano Garzarella
On Tue, Jul 23, 2019 at 10:50:24AM +0100, Peter Maydell wrote: > On Tue, 23 Jul 2019 at 10:42, Stefano Garzarella wrote: > > Reading the 'g_mapped_file_new_from_fd()' docs [1]: > > "If writable is TRUE, the mapped buffer may be modified, otherwise it is an > > error to modify the mapped buffer. Mo

[Qemu-devel] [PULL 1/2] target/mips: Add 'fall through' comments for handling nanoMips' SHXS, SWXS

2019-07-23 Thread Aleksandar Markovic
From: Aleksandar Markovic This was found by GCC 8.3 static analysis. Missed in commit fb32f8c8560. Signed-off-by: Aleksandar Markovic Reviewed-by: Aleksandar Rikalo Reviewed-by: Philippe Mathieu-Daudé Message-Id: <1563812573-30309-2-git-send-email-aleksandar.marko...@rt-rk.com> --- target/m

[Qemu-devel] [PULL 0/2] MIPS queue for July 23rd, 2019

2019-07-23 Thread Aleksandar Markovic
From: Aleksandar Markovic The following changes since commit 23da9e297b4120ca9702cabec91599a44255fe96: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20190722' into staging (2019-07-22 15:16:48 +0100) are available in the git repository at: https://github.com/AMarkovi

[Qemu-devel] [PULL 2/2] target/mips: Fix emulation of MSA pack instructions on big endian hosts

2019-07-23 Thread Aleksandar Markovic
From: Aleksandar Markovic Fix emulation of MSA pack instructions on big endian hosts. Signed-off-by: Aleksandar Markovic Reviewed-by: Aleksandar Rikalo Message-Id: <1563812573-30309-3-git-send-email-aleksandar.marko...@rt-rk.com> --- target/mips/msa_helper.c | 74 +

Re: [Qemu-devel] [PATCH for-4.1 2/2] block: Only the main loop can change AioContexts

2019-07-23 Thread Max Reitz
On 23.07.19 12:02, Kevin Wolf wrote: > Am 23.07.2019 um 11:41 hat Max Reitz geschrieben: >> On 23.07.19 10:52, Kevin Wolf wrote: >>> Am 22.07.2019 um 15:30 hat Max Reitz geschrieben: bdrv_set_aio_context_ignore() can only work in the main loop: bdrv_drained_begin() only works in the main

Re: [Qemu-devel] [PATCH v3 3/3] tests/migration: Add a test for auto converge

2019-07-23 Thread Dr. David Alan Gilbert
* Yury Kotov (yury-ko...@yandex-team.ru) wrote: > 22.07.2019, 20:35, "Dr. David Alan Gilbert" : > > * Yury Kotov (yury-ko...@yandex-team.ru) wrote: > >>  Signed-off-by: Yury Kotov > > > > This looks OK to me, but have you tried it on a really really overloaded > > host? > > I worry that you might

Re: [Qemu-devel] [PATCH v2] NSIS: Add missing firmware blobs

2019-07-23 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Various firmwares has been added in the pc-bios/ directory: > > - CCW (since commit 0c1fecdd523) > - skiboot (since commit bcad45de6a0) > - EDK2(since commit f7fa38b74c3) > > Since we install qemu-system able to run the architectures > targetted by these

[Qemu-devel] [PULL 03/23] tests/docker: Install Sphinx in the Ubuntu images

2019-07-23 Thread Alex Bennée
From: Philippe Mathieu-Daudé Since commit 5f71eac06e the Sphinx tool is required to build the rST documentation. This fixes: $ ./configure --enable-docs ERROR: User requested feature docs configure was not able to find it. Install texinfo, Perl/perl-podlators and python-sphin

[Qemu-devel] [PULL 01/23] archive-source: also create a stash for submodules

2019-07-23 Thread Alex Bennée
From: Marc-André Lureau "git archive" fails when a submodule has a modification, because "git stash create" doesn't handle submodules. Let's teach our archive-source.sh to handle modifications in submodules the same way as qemu tree, by creating a stash. Signed-off-by: Marc-André Lureau Message

[Qemu-devel] [PULL for 4.1-rc2 00/23] testing updates (green CI!)

2019-07-23 Thread Alex Bennée
The following changes since commit 23da9e297b4120ca9702cabec91599a44255fe96: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20190722' into staging (2019-07-22 15:16:48 +0100) are available in the Git repository at: https://github.com/stsquad/qemu.git tags/pull-testing-2

[Qemu-devel] [PULL 08/23] shippable: re-enable the windows cross builds

2019-07-23 Thread Alex Bennée
The pkg.mxe.cc repo has been restored. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé diff --git a/.shippable.yml b/.shippable.yml index f2ffef21d11..f74a3de3ffd 100644 --- a/.shippable.yml +++ b/.shippable.yml @@ -7,11 +7,10 @@ env: matrix:

[Qemu-devel] [PULL 04/23] tests/docker: Install Sphinx in the Fedora image

2019-07-23 Thread Alex Bennée
From: Philippe Mathieu-Daudé Since commit 5f71eac06e the Sphinx tool is required to build the rST documentation. This fixes: $ ./configure --enable-docs ERROR: User requested feature docs configure was not able to find it. Install texinfo, Perl/perl-podlators and python-sphin

[Qemu-devel] [PULL 02/23] tests/docker: add test-misc for building tools & docs

2019-07-23 Thread Alex Bennée
Add yet another test type so we cna quickly exercise the miscellaneous build products of the build system under various docer configurations. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé diff --git a/tests/docker/test-misc b/tests/docker/test

[Qemu-devel] [PULL 06/23] tests/migration-test: don't spam the logs when we fail

2019-07-23 Thread Alex Bennée
Quite often the information about which test failed is hidden by the wall of repeated failures for each page. Stop outputting the error after 10 bad pages and just summarise the total damage at the end. Signed-off-by: Alex Bennée Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Thomas Huth Revi

[Qemu-devel] [PULL 07/23] tests/dockerfiles: update the win cross builds to stretch

2019-07-23 Thread Alex Bennée
While fixing up pkg.mxe.cc they move the URLs around a bit and dropped Jessie support in favour of Stretch. We also need to update the keys used to verify the packages. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé diff --git a/tests/docker/Ma

[Qemu-devel] [PULL 11/23] tests/docker: Set the correct cross-PKG_CONFIG_PATH in the MXE images

2019-07-23 Thread Alex Bennée
From: Philippe Mathieu-Daudé This silents a bunch of warnings while compiling the Slirp objects: $ make [...] CC slirp/src/tftp.o Package glib-2.0 was not found in the pkg-config search path. Perhaps you should add the directory containing `glib-2.0.pc' to the PKG_CONFIG_PATH enviro

[Qemu-devel] [PULL 12/23] tests/docker: Install texinfo in the Fedora image

2019-07-23 Thread Alex Bennée
From: Philippe Mathieu-Daudé The 'makeinfo' is required to generate the documentation from the 'html' Makefile rule (called by 'install-doc'). The NSIS installer uses these files. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20190715174817.18981-6-phi...@redhat.com> Signed-off-by: Alex Be

[Qemu-devel] [PULL 23/23] gitlab-ci: Remove qcow2 tests that are handled by "make check" already

2019-07-23 Thread Alex Bennée
From: Thomas Huth Since most iotests are now run during "make check" already, we do not need to test them explicitly from the gitlab-ci.yml script anymore. And while we're at it, add some of the new non-auto tests >= 246 instead. Signed-off-by: Thomas Huth Message-Id: <20190717111947.30356-5-th

[Qemu-devel] [PULL 09/23] tests/docker: Install Sphinx in the Debian images

2019-07-23 Thread Alex Bennée
From: Philippe Mathieu-Daudé Since commit 5f71eac06e the Sphinx tool is required to build the rST documentation. This fixes: $ ./configure --enable-docs ERROR: User requested feature docs configure was not able to find it. Install texinfo, Perl/perl-podlators and python-sphin

[Qemu-devel] [PULL 05/23] tests/docker: Install Ubuntu images noninteractively

2019-07-23 Thread Alex Bennée
From: Philippe Mathieu-Daudé We correctly use the DEBIAN_FRONTEND environment variable on the Debian images, but forgot the Ubuntu ones are based on it. Since building docker images is not interactive, we need to inform the APT tools about it using the DEBIAN_FRONTEND environment variable (we al

[Qemu-devel] [PULL 10/23] tests/docker: Install the NSIS tools in the MinGW capable images

2019-07-23 Thread Alex Bennée
From: Philippe Mathieu-Daudé This fixes: $ make installer (cd /tmp/qemu-nsis; \ for i in qemu-system-*.exe; do \ arch=${i%.exe}; \ arch=${arch#qemu-system-}; \ echo Section \"$arch\" Section_$arch; \ echo SetOutPath \"\$INSTDIR\"

[Qemu-devel] [PULL 20/23] tests/qemu-iotests/check: Allow tests without groups

2019-07-23 Thread Alex Bennée
From: Thomas Huth The regular expressions in the "check" script currently expect that there is always a space after the test number in the group file, so you can't have a test in there without a group unless the line still ends with a space - which is quite error prone since some editors might re

[Qemu-devel] [PULL 14/23] buildsys: The NSIS Windows build requires qemu-nsis.bmp installed

2019-07-23 Thread Alex Bennée
From: Philippe Mathieu-Daudé The qemu-nsis.bmp file was not listed with the other blobs, thus not installed in the ${BINDIR} location. This fixes: $ make installer [...] (cd /tmp/qemu-nsis; \ for i in qemu-system-*.exe; do \ arch=${i%.exe}; \ arch=${ar

[Qemu-devel] [PULL 13/23] buildsys: The NSIS Windows build requires the documentation installed

2019-07-23 Thread Alex Bennée
From: Philippe Mathieu-Daudé This fixes: $ make installer [...] (cd /tmp/qemu-nsis; \ for i in qemu-system-*.exe; do \ arch=${i%.exe}; \ arch=${arch#qemu-system-}; \ echo Section \"$arch\" Section_$arch; \ echo SetOutPath \"\$I

[Qemu-devel] [PULL 17/23] hw/i386: also turn off VMMOUSE is VMPORT is disabled

2019-07-23 Thread Alex Bennée
Commit 97fd1ea8c1 broke the build for --without-default-devices as VMMOUSE depends on VMPORT. Fixes: 97fd1ea8c1 Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig index b9c96ac361e..6350438036f 100644 --- a/hw/

[Qemu-devel] [PULL 21/23] tests/qemu-iotests/group: Remove some more tests from the "auto" group

2019-07-23 Thread Alex Bennée
From: Thomas Huth Remove some more tests from the "auto" group that either have issues in certain environments (like macOS or FreeBSD, or on certain file systems like ZFS or tmpfs), do not work with the qcow2 format, or that are simply taking too much time. Reviewed-by: Max Reitz Signed-off-by:

[Qemu-devel] [PULL 19/23] tests/docker: invoke the DEBUG shell with --noprofile/--norc

2019-07-23 Thread Alex Bennée
It's very confusing when things work in the debug shell because the environment is different from what the test is running. Fix this by ensuring we only have the inherited environment from the run shell. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé diff --git a/tests/docker/ru

[Qemu-devel] [PULL 16/23] NSIS: Add missing firmware blobs

2019-07-23 Thread Alex Bennée
From: Philippe Mathieu-Daudé Various firmwares has been added in the pc-bios/ directory: - CCW (since commit 0c1fecdd523) - skiboot (since commit bcad45de6a0) - EDK2(since commit f7fa38b74c3) Since we install qemu-system able to run the architectures targetted by these firmware, include

[Qemu-devel] [PULL 18/23] travis: enable travis_retry for check phase

2019-07-23 Thread Alex Bennée
We have some flaky tests and usually the test passes on a retry. Enable travis_retry for the test phase and see if that helps keep things green. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé diff --git a/.travis.yml b/.travis.yml index 5d3d6ee1d32..caf0a1f8faf 100644 --- a/.tra

[Qemu-devel] [PULL 22/23] tests: Run the iotests during "make check" again

2019-07-23 Thread Alex Bennée
From: Thomas Huth People often forget to run the iotests before submitting patches or pull requests - this is likely due to the fact that we do not run the tests during our mandatory "make check" tests yet. Now that we've got a proper "auto" group of iotests that should be fine to run in every en

[Qemu-devel] [PULL 15/23] tests/docker: Let the test-mingw test generate a NSIS installer

2019-07-23 Thread Alex Bennée
From: Philippe Mathieu-Daudé The NSIS installer generates an executable suitable to install QEMU on Windows. Suggested-by: Alex Bennée Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20190715174817.18981-9-phi...@redhat.com> [AJB: also --enable-docs in configure step] Signed-off-by: Alex Be

Re: [Qemu-devel] [PULL v2 0/2] pflash-next patches for v4.1.0-rc2

2019-07-23 Thread Peter Maydell
00) > > are available in the Git repository at: > > https://gitlab.com/philmd/qemu.git tags/pflash-next-20190723 > > for you to fetch changes up to 124e4cfaa42bb5a14eec33ea47d3502b5f46eb33: > > hw/block/pflash_cfi02: Rewrite

[Qemu-devel] [PATCH v4 0/3] restrict bridge interface name to IFNAMSIZ

2019-07-23 Thread P J P
From: Prasad J Pandit Hello, Linux net_deivce defines network interface name to be of IFNAMSIZE(=16) bytes, including the terminating null('\0') byte. Qemu tap deivce, while invoking 'qemu-bridge-helper' tool to set up the network bridge interface, supplies bridge name of 16 characters, thus al

[Qemu-devel] [PATCH v4 1/3] qemu-bridge-helper: restrict interface name to IFNAMSIZ

2019-07-23 Thread P J P
From: Prasad J Pandit The network interface name in Linux is defined to be of size IFNAMSIZ(=16), including the terminating null('\0') byte. The same is applied to interface names read from 'bridge.conf' file to form ACL rules. If user supplied '--br=bridge' name is not restricted to the same len

[Qemu-devel] [PATCH v4 3/3] net: tap: replace snprintf with g_strdup_printf calls

2019-07-23 Thread P J P
From: Prasad J Pandit When invoking qemu-bridge-helper in 'net_bridge_run_helper', instead of using fixed sized buffers, use dynamically allocated ones initialised and returned by g_strdup_printf(). Signed-off-by: Prasad J Pandit --- net/tap.c | 19 +++ 1 file changed, 11 inser

[Qemu-devel] [PATCH v4 2/3] qemu-bridge-helper: move repeating code in parse_acl_file

2019-07-23 Thread P J P
From: Prasad J Pandit Move repeating error handling sequence in parse_acl_file routine to an 'err' label. Signed-off-by: Prasad J Pandit --- qemu-bridge-helper.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) Reviewed v3: -> https://lists.nongnu.org/archive/html/

Re: [Qemu-devel] [PATCH for-4.1 2/2] block: Only the main loop can change AioContexts

2019-07-23 Thread Kevin Wolf
Am 23.07.2019 um 12:21 hat Max Reitz geschrieben: > On 23.07.19 12:02, Kevin Wolf wrote: > > Am 23.07.2019 um 11:41 hat Max Reitz geschrieben: > >> On 23.07.19 10:52, Kevin Wolf wrote: > >>> Am 22.07.2019 um 15:30 hat Max Reitz geschrieben: > bdrv_set_aio_context_ignore() can only work in the

[Qemu-devel] [PATCH] tests/qemu-iotests: Don't use 'seq' in the iotests

2019-07-23 Thread Thomas Huth
The 'seq' command is not available by default on OpenBSD, so these iotests are currently failing there. It could be installed as 'gseq' from the coreutils package - but since it is using a different name there and we are running the iotests with the "bash" shell anyway, let's simply use the built-i

Re: [Qemu-devel] [PATCH] tests/qemu-iotests: Don't use 'seq' in the iotests

2019-07-23 Thread Philippe Mathieu-Daudé
Cc'ing Brad, the OpenBSD maintainer. On 7/23/19 1:12 PM, Thomas Huth wrote: > The 'seq' command is not available by default on OpenBSD, so these > iotests are currently failing there. It could be installed as 'gseq' > from the coreutils package - but since it is using a different name > there and

Re: [Qemu-devel] [PATCH v3 0/4] Introduce the microvm machine type

2019-07-23 Thread Stefano Garzarella
On Tue, Jul 23, 2019 at 10:47:39AM +0100, Stefan Hajnoczi wrote: > On Tue, Jul 23, 2019 at 9:43 AM Sergio Lopez wrote: > > Montes, Julio writes: > > > > > On Fri, 2019-07-19 at 16:09 +0100, Stefan Hajnoczi wrote: > > >> On Fri, Jul 19, 2019 at 2:48 PM Sergio Lopez wrote: > > >> > Stefan Hajnoczi

[Qemu-devel] [PATCH for 4.2] target/arm: generate a custom MIDR for -cpu max

2019-07-23 Thread Alex Bennée
While most features are now detected by probing the ID_* registers kernels can (and do) use MIDR_EL1 for working out of they have to apply errata. This can trip up warnings in the kernel as it tries to work out if it should apply workarounds to features that don't actually exist in the reported CPU

Re: [Qemu-devel] [PULL for 4.1-rc2 00/23] testing updates (green CI!)

2019-07-23 Thread Peter Maydell
On Tue, 23 Jul 2019 at 11:36, Alex Bennée wrote: > > The following changes since commit 23da9e297b4120ca9702cabec91599a44255fe96: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20190722' into staging (2019-07-22 > 15:16:48 +0100) > > are available in the Git reposito

Re: [Qemu-devel] [PULL for 4.1-rc2 00/23] testing updates (green CI!)

2019-07-23 Thread Alex Bennée
Peter Maydell writes: > On Tue, 23 Jul 2019 at 11:36, Alex Bennée wrote: >> >> The following changes since commit 23da9e297b4120ca9702cabec91599a44255fe96: >> >> Merge remote-tracking branch >> 'remotes/pmaydell/tags/pull-target-arm-20190722' into staging (2019-07-22 >> 15:16:48 +0100) >>

Re: [Qemu-devel] [PATCH for 4.2] target/arm: generate a custom MIDR for -cpu max

2019-07-23 Thread Peter Maydell
On Tue, 23 Jul 2019 at 12:33, Alex Bennée wrote: > > While most features are now detected by probing the ID_* registers > kernels can (and do) use MIDR_EL1 for working out of they have to > apply errata. This can trip up warnings in the kernel as it tries to > work out if it should apply workaroun

Re: [Qemu-devel] [PULL v2 1/2] hw/block/pflash_cfi01: Add missing DeviceReset() handler

2019-07-23 Thread Laszlo Ersek
On 07/23/19 11:35, Philippe Mathieu-Daudé wrote: > To avoid incoherent states when the machine resets (see bug report > below), add the device reset callback. > > A "system reset" sets the device state machine in READ_ARRAY mode > and, after some delay, set the SR.7 READY bit. > > Since we do not

[Qemu-devel] [PATCH] docs: correct kconfig option

2019-07-23 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- docs/devel/kconfig.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/devel/kconfig.rst b/docs/devel/kconfig.rst index d6f8eb0977..b7bca44704 100644 --- a/docs/devel/kconfig.rst +++ b/docs/devel/kconfig.rst @@ -267,7 +267,7 @@ the def

[Qemu-devel] [PATCH-for-4.2 1/2] target/riscv/pmp: Restrict priviledged PMP to system-mode emulation

2019-07-23 Thread Philippe Mathieu-Daudé
The RISC-V Physical Memory Protection is restricted to privileged modes. Restrict its compilation to QEMU system builds. Signed-off-by: Philippe Mathieu-Daudé --- target/riscv/Makefile.objs | 3 ++- target/riscv/pmp.c | 4 2 files changed, 2 insertions(+), 5 deletions(-) diff --git

[Qemu-devel] [PATCH-for-4.2 0/2] target/riscv/pmp: Convert to trace events

2019-07-23 Thread Philippe Mathieu-Daudé
Trivial convertion, suggested on https://lists.gnu.org/archive/html/qemu-devel/2019-07/msg04728.html Philippe Mathieu-Daudé (2): target/riscv/pmp: Restrict priviledged PMP to system-mode emulation target/riscv/pmp: Convert qemu_log_mask(LOG_TRACE) to trace events target/riscv/Makefile.objs |

[Qemu-devel] [PATCH-for-4.2 2/2] target/riscv/pmp: Convert qemu_log_mask(LOG_TRACE) to trace events

2019-07-23 Thread Philippe Mathieu-Daudé
Use the always-compiled trace events, remove the now unused RISCV_DEBUG_PMP definition. Note pmpaddr_csr_read() could previously do out-of-bound accesses passing addr_index >= MAX_RISCV_PMPS. Signed-off-by: Philippe Mathieu-Daudé --- target/riscv/pmp.c| 31 ++

Re: [Qemu-devel] [PATCH] docs: correct kconfig option

2019-07-23 Thread Philippe Mathieu-Daudé
On 7/23/19 2:08 PM, Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau > --- > docs/devel/kconfig.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/devel/kconfig.rst b/docs/devel/kconfig.rst > index d6f8eb0977..b7bca44704 100644 > --- a/docs/devel/kconfig

Re: [Qemu-devel] [PATCH v7 01/13] vfio: KABI for migration interface

2019-07-23 Thread Cornelia Huck
On Tue, 16 Jul 2019 14:56:32 -0600 Alex Williamson wrote: > On Tue, 9 Jul 2019 15:19:08 +0530 > Kirti Wankhede wrote: I'm still a bit unsure about the device_state bit handling as well. > > + * device_state: (read/write) > > + * To indicate vendor driver the state VFIO device should be >

[Qemu-devel] [PATCH] configure: remove AUTOCONF_HOST

2019-07-23 Thread Marc-André Lureau
This is a left-over from commit c12b6d70e384c769ca372e15ffd19b3e9f563662 ("pixman: drop submodule") Signed-off-by: Marc-André Lureau --- configure | 5 - 1 file changed, 5 deletions(-) diff --git a/configure b/configure index ad0b8582bf..82c65ab46a 100755 --- a/configure +++ b/configure @@

Re: [Qemu-devel] [PULL for 4.1-rc2 00/23] testing updates (green CI!)

2019-07-23 Thread Philippe Mathieu-Daudé
On 7/23/19 1:46 PM, Alex Bennée wrote: > > Peter Maydell writes: > >> On Tue, 23 Jul 2019 at 11:36, Alex Bennée wrote: >>> >>> The following changes since commit 23da9e297b4120ca9702cabec91599a44255fe96: >>> >>> Merge remote-tracking branch >>> 'remotes/pmaydell/tags/pull-target-arm-20190722

[Qemu-devel] [Bug 1696773] Re: golang calls to exec crash user emulation

2019-07-23 Thread Peter Maydell
The 'qemucrash' test case from this bug still crashes as of current head-of-git (4.1 rc1). ** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1696773 T

[Qemu-devel] [Bug 1818937] Re: Crash with HV_ERROR on macOS host

2019-07-23 Thread Gergely Kis
Hi Roman, thanks for the patch, we were able to reproduce this issue with our custom Android Cuttlefish based d VM (running 4.14 kernel): 2019-07-23T11:36:37.180753Z qemu-system-x86_64: warning: host doesn't support requested feature: CPUID.8001H:ECX.svm [bit 2] 2019-07-23T11:36:37.182517Z q

  1   2   3   >