On 6/19/19 9:40 PM, Max Reitz wrote:
> On 14.06.19 11:22, Vladimir Sementsov-Ogievskiy wrote:
>> 13.06.2019 19:03, Max Reitz wrote:
>>> [re-adding the original CCs, why not]
>>>
>>> On 13.06.19 16:30, Vladimir Sementsov-Ogievskiy wrote:
13.06.2019 17:21, Max Reitz wrote:
> On 13.06.19 16:1
On Tue, 16 Jul 2019 at 06:54, Joel Stanley wrote:
>
> Hi Peter,
>
> On Thu, 4 Jul 2019 at 12:26, Paolo Bonzini wrote:
> >
> > On 04/07/19 12:13, Stefan Hajnoczi wrote:
> > > On Thu, Jul 04, 2019 at 11:26:53AM +0200, Philippe Mathieu-Daudé wrote:
> > >> CC'ing Stefan & Paolo for a non-ARM view on
On 7/16/19 9:00 AM, Joel Stanley wrote:
> On Tue, 16 Jul 2019 at 06:54, Joel Stanley wrote:
>>
>> Hi Peter,
>>
>> On Thu, 4 Jul 2019 at 12:26, Paolo Bonzini wrote:
>>>
>>> On 04/07/19 12:13, Stefan Hajnoczi wrote:
On Thu, Jul 04, 2019 at 11:26:53AM +0200, Philippe Mathieu-Daudé wrote:
>
On 7/15/19 10:19 PM, Stefan Hajnoczi wrote:
> It is useful to follow individual requests as they are submitted. Add
> trace events that show details of each request.
>
> Signed-off-by: Stefan Hajnoczi
Reviewed-by: Philippe Mathieu-Daudé
> ---
> block/io_uring.c | 5 +
> block/trace-eve
for some devices to do live migration, it is needed to do something
immediately before vcpu stops. add a notification here.
Signed-off-by: Yan Zhao
---
cpus.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/cpus.c b/cpus.c
index b09b702..d5d4abe 100644
--- a/cpus.c
+++ b/cpus.c
@@ -1068,6 +1
ping
On Sat, Jun 15, 2019 at 8:17 AM Ramon Fried wrote:
>
> The RX ring descriptors control field is used for setting
> SOF and EOF (start of frame and end of frame).
> The SOF and EOF weren't cleared from the previous descriptors,
> causing inconsistencies in ring buffer.
> Fix that by clearing
All,
Submitting proposal :
Per Power ISA 3.02B Book III at pages 1029 and 1030, bit 15 of the
slbmfee and slbmfev instructions is now assigned to an implementation
specific bit and is no longer reserved - meaning it can be set to 1 but
can probably be safely ignored.
2.07B still indicates b
On 7/15/19 10:19 PM, Stefan Hajnoczi wrote:
> The io_uring API had unusual read behavior up until recently, where
> short reads could occur when the start of the file range was in the page
> cache and a later portion was not in the page cache. Normally read(2)
> does not expose this detail to appl
On 7/16/19 9:11 AM, Ramon Fried wrote:
> ping
>
> On Sat, Jun 15, 2019 at 8:17 AM Ramon Fried wrote:
>>
>> The RX ring descriptors control field is used for setting
>> SOF and EOF (start of frame and end of frame).
>> The SOF and EOF weren't cleared from the previous descriptors,
>> causing incon
Recently we found a behavior change after commit 6ade45f2ac93611
('char-pty: Print "char device redirected" message to stdout').
When we redirect output to a file, the message "char device redirected
to PTY_NAME (label LABEL)" would not be seen at the beginning of the
file. Instead, the message is
On Tue, Jul 16, 2019 at 03:10:42PM +0800, Yan Zhao wrote:
> for some devices to do live migration, it is needed to do something
> immediately before vcpu stops. add a notification here.
Hi, Yan,
Could I ask for a more detailed commit message here? E.g., what is
"some devices"? And, what's the p
On 15.07.19 18:12, Christian Borntraeger wrote:
>
>
> On 15.07.19 17:50, Christian Borntraeger wrote:
>>
>>
>> On 15.07.19 17:02, Thomas Huth wrote:
>>> On 15/07/2019 16.23, Christian Borntraeger wrote:
David suggested to keep everything in sync as 4.1 is not yet released.
This patch fi
On 16.07.19 09:24, David Hildenbrand wrote:
> On 15.07.19 18:12, Christian Borntraeger wrote:
>>
>>
>> On 15.07.19 17:50, Christian Borntraeger wrote:
>>>
>>>
>>> On 15.07.19 17:02, Thomas Huth wrote:
On 15/07/2019 16.23, Christian Borntraeger wrote:
> David suggested to keep everything
On 16/07/19 09:21, Wei Yang wrote:
> Recently we found a behavior change after commit 6ade45f2ac93611
> ('char-pty: Print "char device redirected" message to stdout').
>
> When we redirect output to a file, the message "char device redirected
> to PTY_NAME (label LABEL)" would not be seen at the b
On Tue, Jul 16, 2019 at 03:23:16PM +0800, Peter Xu wrote:
> On Tue, Jul 16, 2019 at 03:10:42PM +0800, Yan Zhao wrote:
> > for some devices to do live migration, it is needed to do something
> > immediately before vcpu stops. add a notification here.
>
> Hi, Yan,
>
> Could I ask for a more detaile
On 16/07/2019 06:56, Joel Stanley wrote:
> When booting with the default amount of RAM the powernv machine will
> load the initrd above the top of RAM and cause the Linux kernel to crash
> when it attempts to access the initrd:
>
> Linux/PowerPC load:
> Finalizing device tree... flat tree at 0
On 15.07.19 20:27, Paolo Bonzini wrote:
> On 15/07/19 19:23, Max Reitz wrote:
>> On 12.07.19 21:17, Andrey Shinkevich wrote:
>>> When tcp_chr_disconnect() is called, other thread may be still writing
>>> to the channel. This patch protects only read operations that initiate
>>> the disconnection.
>
UMONITOR, UMWAIT and TPAUSE are a set of user wait instructions.
UMONITOR arms address monitoring hardware using an address. A store
to an address within the specified address range triggers the
monitoring hardware to wake up the processor waiting in umwait.
UMWAIT instructs the processor to ente
UMWAIT and TPAUSE instructions use 32bits IA32_UMWAIT_CONTROL at MSR
index E1H to determines the maximum time in TSC-quanta that the processor
can reside in either C0.1 or C0.2.
This patch is to Add support for save/load IA32_UMWAIT_CONTROL MSR in
guest.
Co-developed-by: Jingqi Liu
Signed-off-by
UMONITOR, UMWAIT and TPAUSE are a set of user wait instructions.
This patch adds support for user wait instructions in KVM. Availability
of the user wait instructions is indicated by the presence of the CPUID
feature flag WAITPKG CPUID.0x07.0x0:ECX[5]. User wait instructions may
be executed at any
On Tue, Jul 16, 2019 at 03:29:19AM -0400, Yan Zhao wrote:
> On Tue, Jul 16, 2019 at 03:23:16PM +0800, Peter Xu wrote:
> > On Tue, Jul 16, 2019 at 03:10:42PM +0800, Yan Zhao wrote:
> > > for some devices to do live migration, it is needed to do something
> > > immediately before vcpu stops. add a no
Hi Fabiano,
On 05/22/2019 09:37 PM, Fabiano Rosas wrote:
Shivaprasad G Bhat writes:
+/* Create DT entries for cold plugged NVDIMM devices */
+dimms = nvdimm_get_device_list();
+for (; dimms; dimms = dimms->next) {
+NVDIMMDevice *nvdimm = dimms->data;
+
+spapr_popu
On Tue, Jul 16, 2019 at 03:38:09AM +, Oleinik, Alexander wrote:
> virtio-net checks that the "out" sg is longer than the guest header, but
> this check can be skipped if has_net_hdr is 0. Also perform this check
> if host_hdr_len != guest_hdr_len
This explanation is way less clear than what yo
On Tue, Jul 16, 2019 at 03:50:25PM +0800, Peter Xu wrote:
> On Tue, Jul 16, 2019 at 03:29:19AM -0400, Yan Zhao wrote:
> > On Tue, Jul 16, 2019 at 03:23:16PM +0800, Peter Xu wrote:
> > > On Tue, Jul 16, 2019 at 03:10:42PM +0800, Yan Zhao wrote:
> > > > for some devices to do live migration, it is ne
From: Shinichiro Kawasaki
When an error was passed down to the guest because it was recoverable,
the sense length was not copied from the SG_IO data. As a result,
the guest saw the CHECK CONDITION status but not the sense data.
Signed-off-by: Shinichiro Kawasaki
Signed-off-by: Paolo Bonzini
-
The following changes since commit 46cd24e7ed38191b5ab5c40a836d6c5b6b604f8a:
Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging
(2019-07-12 17:34:13 +0100)
are available in the git repository at:
git://github.com/bonzini/qemu.git tags/for-upstream
for you to fetch c
It's not really possible to fit all sense codes into errno codes,
especially in such a way that sense codes can be properly categorized as
either guest-recoverable or host-handled. Create a new function that
checks for guest recoverable sense, then scsi_sense_buf_to_errno only
needs to be called f
Now that scsi-disk is not using scsi_sense_to_errno to separate
guest-recoverable
sense codes, we can modify it to simplify iscsi's own sense handling.
Signed-off-by: Paolo Bonzini
---
block/iscsi.c | 29 ++---
scsi/utils.c | 5 ++---
2 files changed, 16 insertions(+),
From: Julio Montes
vmport device is not included when CONFIG_VMPORT is disabled, hence
QEMU fails with the following error:
`Unknown device 'vmport' for bus 'ISA': unknown.`
v2: imply VMPORT (Paolo Bonzini )
Signed-off-by: Julio Montes
Message-Id: <20190712160257.18270-1-julio.mon...@intel.co
From: Marc-André Lureau
../contrib/rdmacm-mux/main.c: In function ‘parse_args’:
../contrib/rdmacm-mux/main.c:118:13: error: ‘strncpy’ specified bound 3835
equals destination size [-Werror=stringop-truncation]
118 | strncpy(unix_socket_path, optarg, SOCKET_PATH_MAX);
Signed-off-by:
From: Marc-André Lureau
Left over from c2d63650d962612cfa1b21302782d4cd12142c74.
Signed-off-by: Marc-André Lureau
Message-Id: <20190712172743.17632-1-marcandre.lur...@redhat.com>
Signed-off-by: Paolo Bonzini
---
util/Makefile.objs | 1 -
1 file changed, 1 deletion(-)
diff --git a/util/Makefi
Copy and pasting from Thunderbird's "view source" window results in double
encoding of multibyte UTF-8 sequences. The appearance of those sequences is
very peculiar, so detect it and give an error despite the (low) possibility
of false positives.
As the major offender, I am also adding the same c
In this case, do_retry was set without calling aio_co_wake, thus never
waking up the coroutine.
Signed-off-by: Paolo Bonzini
---
block/iscsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index 267f160..6e238bf 100644
--- a/block/iscsi.c
+++ b
When running basic operations on zoned storage from the guest via
scsi-block, the following ASCs are reported for write or read commands
due to unexpected zone status or write pointer status:
21h 04h: UNALIGNED WRITE COMMAND
21h 05h: WRITE BOUNDARY VIOLATION
21h 06h: ATTEMPT TO READ
On Tue, Jul 16, 2019 at 12:47:22PM +1000, Nicholas Piggin wrote:
> Implement cpu_exec_enter/exit on ppc which calls into new methods of
> the same name in PPCVirtualHypervisorClass. These are used by spapr
> to implement these splpar elements, used in subsequent changes.
>
> Signed-off-by: Nichola
From: King Wang
The memory region reference is increased when insert a range
into flatview range array, then decreased by destroy flatview.
If some flat range merged by flatview_simplify, the memory region
reference can not be decreased by destroy flatview any more.
In this case, start virtual m
main-loop.c has a dependency on iohandler.c, and everything breaks
if that dependency is instead satisfied by stubs/iohandler.c.
Just put everything in the same file to avoid strange dependencies
on the order of files in util-obj-y.
Signed-off-by: Paolo Bonzini
Reviewed-by: Marc-André Lureau
Mes
From: Stefan Weil
Signed-off-by: Stefan Weil
Message-Id: <20190712132611.20411-1...@weilnetz.de>
Signed-off-by: Paolo Bonzini
---
target/i386/whpx-all.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/i386/whpx-all.c b/target/i386/whpx-all.c
index 31d4732..ed9510
From: Philippe Mathieu-Daudé
The Milkymist SoftUSB block provides the OHCI USB standard
(missed in 0858746b835).
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20190714124755.14356-1-phi...@redhat.com>
Signed-off-by: Paolo Bonzini
---
hw/lm32/Kconfig | 1 +
1 file changed, 1 insertion(+)
On Tue, Jul 16, 2019 at 03:38:00AM +, Oleinik, Alexander wrote:
> While fuzzing the virtio-net tx vq, I ran into an assertion failure due
> to iov_copy offsets larger than the total iov size. Though there is
> a check to cover this, it does not execute when !n->has_vnet_hdr. This
> patch tries
From: Philippe Mathieu-Daudé
The USB_EHCI entry currently include PCI code. Since the EHCI
implementation is already split in sysbus/PCI, add a new
USB_EHCI_PCI. There are no logical changes, but the Kconfig
dependencies tree is cleaner.
Signed-off-by: Philippe Mathieu-Daudé
Signed-off-by: Paol
CONFIG_TPM is defined to a rather weird $(CONFIG_SOFTMMU) so that it
expands to the right thing in hw/Makefile.objs. This however is not
needed anymore and it has a corresponding hack in create_config
to turn it into "#define CONFIG_TPM 1". Clean up.
Signed-off-by: Paolo Bonzini
---
configure
From: Alex Williamson
The commit referenced below skipped pinning ram device memory when
ram blocks are added, we need to do the same when they're removed.
Cc: Brijesh Singh
Cc: Paolo Bonzini
Fixes: cedc0ad539af ("target/i386: sev: Do not pin the ram device memory
region")
Signed-off-by: Alex
From: Wei Yang
Recently we found a behavior change after commit 6ade45f2ac93611
('char-pty: Print "char device redirected" message to stdout').
When we redirect output to a file, the message "char device redirected
to PTY_NAME (label LABEL)" would not be seen at the beginning of the
file. Instea
From: Philippe Mathieu-Daudé
TYPE_NEC_XHCI is child of TYPE_XHCI. Add the missing Kconfig
dependency.
Signed-off-by: Philippe Mathieu-Daudé
Signed-off-by: Paolo Bonzini
---
hw/usb/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig
index
The device directories must be included only for softmmu builds.
Instead of repeating $(CONFIG_SOFTMMU), use an "if".
Signed-off-by: Paolo Bonzini
---
hw/Makefile.objs | 61 +---
1 file changed, 32 insertions(+), 29 deletions(-)
diff --git a/h
preallocation=off and preallocation=metadata
both allocate luks header only, and preallocation=falloc/full
is passed to underlying file.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1534951
Signed-off-by: Maxim Levitsky
---
block/crypto.c | 29 ++---
qapi/blo
Patchew URL:
https://patchew.org/QEMU/1563264677-39718-1-git-send-email-pbonz...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PULL 00/19] Bugfix/cleanup patches for 2019-07-16
Type: series
Message-id: 15632
valgrind showed some memory leaks while running qemu-system-ppc64.
Fixing them in this patch.
Signed-off-by: Shivaprasad G Bhat
---
hw/ppc/spapr_caps.c |2 ++
hw/ppc/spapr_drc.c |5 -
hw/ppc/spapr_hcall.c |2 ++
target/ppc/kvm.c |3 ++-
4 files changed, 10 insertions(+
On Tue, 16 Jul 2019 09:25:42 +0200
Christian Borntraeger wrote:
> On 16.07.19 09:24, David Hildenbrand wrote:
> > We also have
> >
> > sortl vs. sort
> > vxe vs. vxeh
> > vxe2 vs. vxeh2
> >
> > So I tend to prefer "vxpde", or rather "vxpdeh".
> >
> > (all other enhancement facilities have "eh
On Mon, Jul 15, 2019 at 02:48:49PM +0100, Mark Rutland wrote:
> On Mon, Jul 15, 2019 at 02:41:00PM +0100, Dave Martin wrote:
[...]
> > So long as KVM_EXIT_HYPERCALL reports sufficient information so that
> > userspace can identify the cause as an SMC and retrieve the SMC
> > immediate field, this
On 2019/6/15 下午1:17, Ramon Fried wrote:
The RX ring descriptors control field is used for setting
SOF and EOF (start of frame and end of frame).
The SOF and EOF weren't cleared from the previous descriptors,
causing inconsistencies in ring buffer.
Fix that by clearing the control field of every
../block/nbd.c: In function 'nbd_co_request':
../block/nbd.c:745:8: error: 'local_reply.type' may be used uninitialized in
this function [-Werror=maybe-uninitialized]
if (chunk->type == NBD_REPLY_TYPE_NONE) {
^
../block/nbd.c:710:14: note: 'local_reply.type' was declared here
NBD
On 16/07/2019 10.30, Cornelia Huck wrote:
> On Tue, 16 Jul 2019 09:25:42 +0200
> Christian Borntraeger wrote:
>
>> On 16.07.19 09:24, David Hildenbrand wrote:
>
>>> We also have
>>>
>>> sortl vs. sort
>>> vxe vs. vxeh
>>> vxe2 vs. vxeh2
>>>
>>> So I tend to prefer "vxpde", or rather "vxpdeh".
>>
On Mon, Jul 15, 2019 at 03:44:46PM +0100, Mark Rutland wrote:
> On Mon, Jul 15, 2019 at 03:26:39PM +0100, James Morse wrote:
> > On 15/07/2019 14:48, Mark Rutland wrote:
> > > On Mon, Jul 15, 2019 at 02:41:00PM +0100, Dave Martin wrote:
> > >> One option (suggested to me by James Morse) would be to
On 16/07/2019 09:30, Dave Martin wrote:
> On Mon, Jul 15, 2019 at 02:48:49PM +0100, Mark Rutland wrote:
>> On Mon, Jul 15, 2019 at 02:41:00PM +0100, Dave Martin wrote:
>
> [...]
>
>>> So long as KVM_EXIT_HYPERCALL reports sufficient information so that
>>> userspace can identify the cause as an S
On Tue, Jul 16, 2019 at 12:47:25PM +1000, Nicholas Piggin wrote:
> This has been useful to modify and test the Linux pseries suspend
> code but it requires modification to the guest to call it (due to
> being gated by other unimplemented features). It is not otherwise
> used by Linux yet, but work
On Tue, Jul 16, 2019 at 09:39:36AM +0200, Cédric Le Goater wrote:
> On 16/07/2019 06:56, Joel Stanley wrote:
> > When booting with the default amount of RAM the powernv machine will
> > load the initrd above the top of RAM and cause the Linux kernel to crash
> > when it attempts to access the initr
On Tue, Jul 16, 2019 at 12:47:23PM +1000, Nicholas Piggin wrote:
> H_PROD is added, and H_CEDE is modified to test the prod bit
> according to PAPR.
>
> Signed-off-by: Nicholas Piggin
LGTM apart from the style issues the bot noted.
> ---
> hw/ppc/spapr_hcall.c | 29
On Tue, Jul 16, 2019 at 12:47:24PM +1000, Nicholas Piggin wrote:
> This does not do directed yielding and is not quite as strict as PAPR
> specifies in terms of precise dispatch behaviour. This generally will
> mean suboptimal performance, rather than guest misbehaviour. Linux
> does not rely on ex
On Tue, Jul 16, 2019 at 12:47:26PM +1000, Nicholas Piggin wrote:
> This has been useful to modify and test the Linux pseries suspend
> code but it requires modification to the guest to call it (due to
> being gated by other unimplemented features). It is not otherwise
> used by Linux yet, but work
Patchew URL:
https://patchew.org/QEMU/20190715134211.23063-1-peter.mayd...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Subject: [Qemu-devel] [PULL 00/10] target-arm queue
Message-id: 20190715134211.23063-1-peter.may
On 15/07/2019 19.17, Max Reitz wrote:
> On 15.07.19 17:18, Thomas Huth wrote:
>> On 15/07/2019 17.12, Eric Blake wrote:
>>> On 7/15/19 9:54 AM, Thomas Huth wrote:
Remove some more tests from the "auto" group that either have issues
in certain environments (like macOS or FreeBSD, or on cer
On 16.07.19 11:03, Thomas Huth wrote:
> On 15/07/2019 19.17, Max Reitz wrote:
>> On 15.07.19 17:18, Thomas Huth wrote:
>>> On 15/07/2019 17.12, Eric Blake wrote:
On 7/15/19 9:54 AM, Thomas Huth wrote:
> Remove some more tests from the "auto" group that either have issues
> in certain e
Signed-off-by: Anton Kuchin
---
hw/net/virtio-net.c| 3 +--
include/hw/virtio/virtio-net.h | 1 -
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index b9e1cd71cf..16d2ad5927 100644
--- a/hw/net/virtio-net.c
+++ b/hw/net/virtio-n
On 16.07.19 10:30, Cornelia Huck wrote:
> On Tue, 16 Jul 2019 09:25:42 +0200
> Christian Borntraeger wrote:
>
>> On 16.07.19 09:24, David Hildenbrand wrote:
>
>>> We also have
>>>
>>> sortl vs. sort
>>> vxe vs. vxeh
>>> vxe2 vs. vxeh2
>>>
>>> So I tend to prefer "vxpde", or rather "vxpdeh".
>
On Tue, Jul 16, 2019 at 12:08:39PM +0300, Anton Kuchin wrote:
> Signed-off-by: Anton Kuchin
Reviewed-by: Michael S. Tsirkin
> ---
> hw/net/virtio-net.c| 3 +--
> include/hw/virtio/virtio-net.h | 1 -
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/hw/net/virtio-
Hi Marc-André,
On 7/16/19 10:42 AM, Marc-André Lureau wrote:
> ../block/nbd.c: In function 'nbd_co_request':
> ../block/nbd.c:745:8: error: 'local_reply.type' may be used uninitialized in
> this function [-Werror=maybe-uninitialized]
> if (chunk->type == NBD_REPLY_TYPE_NONE) {
> ^
>
On 15/07/2019 16.23, Christian Borntraeger wrote:
> esort might not be available on all models.
>
> Fixes: caef62430fed6e73 ("s390x/cpumodel: add gen15 defintions")
> Signed-off-by: Christian Borntraeger
> ---
> target/s390x/gen-features.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a
On 15/07/2019 16.23, Christian Borntraeger wrote:
> The internal macro name VECTOR_BCD_ENH does not match the actual
> description. Fix this.
>
> Signed-off-by: Christian Borntraeger
> ---
> target/s390x/cpu_features_def.inc.h | 2 +-
> target/s390x/gen-features.c | 4 ++--
> 2 files cha
David Gibson's on July 16, 2019 5:34 pm:
> On Tue, Jul 16, 2019 at 12:47:22PM +1000, Nicholas Piggin wrote:
>> Implement cpu_exec_enter/exit on ppc which calls into new methods of
>> the same name in PPCVirtualHypervisorClass. These are used by spapr
>> to implement these splpar elements, used in s
On 7/15/19 5:22 PM, Philippe Mathieu-Daudé wrote:
> Amusingly Miroslav and myself hit this issue at the same time.
>
> Note now that "config-devices.h" exists (commit 6c22ea9d83) I could use
> #include "config-devices.h" to implement Alex's suggestion to avoid a stub:
> https://lists.gnu.org/archi
On Mon, 15 Jul 2019 16:23:01 +0200
Christian Borntraeger wrote:
> Some fallout of the gen15 cpu model. As this is new in 4.1
> it is still time to fixup some aspects.
>
> Christian Borntraeger (3):
> s390x/cpumodel: remove esort from the default model
> s390x/cpumodel: also change name of vx
On 22.02.19 14:46, Alberto Garcia wrote:
> There's a race condition in which the tcp_chr_read() ioc handler can
> close a connection that is being written to from another thread.
>
> Running iotest 136 in a loop triggers this problem and crashes QEMU.
>
> (gdb) bt
> #0 0x5558b842902d in ob
* Wei Yang (richardw.y...@linux.intel.com) wrote:
> Consolidate time information fill up into its function for better
> readability.
>
> Signed-off-by: Wei Yang
Reviewed-by: Dr. David Alan Gilbert
> ---
> migration/migration.c | 40 ++--
> 1 file changed, 2
* Markus Armbruster (arm...@redhat.com) wrote:
> "Kővágó, Zoltán" writes:
>
> > Signed-off-by: Kővágó, Zoltán
> > ---
> > ui/vnc.h| 2 ++
> > monitor/misc.c | 12 +++-
> > ui/vnc.c| 15 ++-
> > hmp-commands.hx | 13 -
> > qemu-options.hx | 6 ++
Hi
On Tue, Jul 16, 2019 at 1:19 PM Philippe Mathieu-Daudé
wrote:
>
> Hi Marc-André,
>
> On 7/16/19 10:42 AM, Marc-André Lureau wrote:
> > ../block/nbd.c: In function 'nbd_co_request':
> > ../block/nbd.c:745:8: error: 'local_reply.type' may be used uninitialized
> > in this function [-Werror=mayb
../contrib/rdmacm-mux/main.c: In function ‘parse_args’:
../contrib/rdmacm-mux/main.c:118:13: error: ‘strncpy’ specified bound 3835
equals destination size [-Werror=stringop-truncation]
118 | strncpy(unix_socket_path, optarg, SOCKET_PATH_MAX);
Signed-off-by: Marc-André Lureau
---
c
../block/nbd.c: In function 'nbd_co_request':
../block/nbd.c:745:8: error: 'local_reply.type' may be used uninitialized in
this function [-Werror=maybe-uninitialized]
if (chunk->type == NBD_REPLY_TYPE_NONE) {
^
../block/nbd.c:710:14: note: 'local_reply.type' was declared here
NBD
On Tue, Jul 16, 2019 at 2:07 PM Marc-André Lureau
wrote:
>
> ../contrib/rdmacm-mux/main.c: In function ‘parse_args’:
> ../contrib/rdmacm-mux/main.c:118:13: error: ‘strncpy’ specified bound 3835
> equals destination size [-Werror=stringop-truncation]
> 118 | strncpy(unix_socket_path,
On 16.07.19 02:01, John Snow wrote:
> Just kidding, this is easier to manage with a full class instead of a
> namedtuple.
>
> Signed-off-by: John Snow
> ---
> tests/qemu-iotests/257 | 58 +++---
> 1 file changed, 32 insertions(+), 26 deletions(-)
Reviewed-by:
On 16.07.19 02:01, John Snow wrote:
> Represent a bitmap with an object that we can mark and clear bits in.
> This makes it easier to manage partial writes when we don't write a
> full group's worth of patterns before an error.
>
> Signed-off-by: John Snow
> ---
> tests/qemu-iotests/257 | 124 ++
I was writing on your v1 "it might be worth commenting this is when
building with -O3"
This might be as easy as having the subject modified (by maintainer
taking this patch?) as:
"fix uninitialized variable warning [when building with -O3]"
On 7/16/19 12:07 PM, Marc-André Lureau wrote:
> ../bloc
On Mon, Jul 15, 2019 at 06:45:28PM +0200, Philippe Mathieu-Daudé wrote:
> On 7/13/19 4:33 PM, Marc-André Lureau wrote:
> > Signed-off-by: Marc-André Lureau
> > ---
> > tests/Makefile.include | 2 +-
> > tests/test-char.c | 17 +
> > 2 files changed, 14 insertions(+), 5 delet
David Gibson's on July 16, 2019 6:25 pm:
> On Tue, Jul 16, 2019 at 12:47:24PM +1000, Nicholas Piggin wrote:
>> This does not do directed yielding and is not quite as strict as PAPR
>> specifies in terms of precise dispatch behaviour. This generally will
>> mean suboptimal performance, rather than g
> From: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] On Behalf
> Of David Gibson
> Sent: Monday, July 15, 2019 10:55 AM
> To: Liu, Yi L
> Subject: Re: [RFC v1 05/18] vfio/pci: add pasid alloc/free implementation
>
> On Fri, Jul 05, 2019 at 07:01:38PM +0800, Liu Yi L wrote:
> > Thi
On 16.07.19 02:01, John Snow wrote:
> This test needs support for non-bitmap backups and missing or
> unspecified bitmap sync modes, so rewrite the helpers to be a little
> more generic.
>
> Signed-off-by: John Snow
> ---
> tests/qemu-iotests/257 | 56 ++-
> tests/qemu-iotests/257.o
On Tue, Jul 16, 2019 at 03:57:49AM -0400, Yan Zhao wrote:
> On Tue, Jul 16, 2019 at 03:50:25PM +0800, Peter Xu wrote:
> > On Tue, Jul 16, 2019 at 03:29:19AM -0400, Yan Zhao wrote:
> > > On Tue, Jul 16, 2019 at 03:23:16PM +0800, Peter Xu wrote:
> > > > On Tue, Jul 16, 2019 at 03:10:42PM +0800, Yan Z
On 16.07.19 02:01, John Snow wrote:
> Signed-off-by: John Snow
> ---
> tests/qemu-iotests/257 | 67 ++
> tests/qemu-iotests/257.out | 85 ++
> 2 files changed, 152 insertions(+)
Reviewed-by: Max Reitz
signature.asc
Descripti
On Mon, 15 Jul 2019 at 21:29, Aleksandar Markovic
wrote:
>
> From: Aleksandar Markovic
>
> The following changes since commit 5ea8ec2fcf57cb9af24ad2cf17b4d64adb03afdf:
>
> Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2019-07-15'
> into staging (2019-07-15 16:11:47 +0100)
>
>
Patchew URL:
https://patchew.org/QEMU/20190715142304.215018-1-borntrae...@de.ibm.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190715142304.215018-1-borntrae...@de.ibm.com
Type: series
Subject: [Qemu-devel] [PATCH 0/3] s390
On 16.07.19 02:01, John Snow wrote:
> When making backups based on bitmaps, the work estimate can be more
> accurate. Update iotests to reflect the new strategy.
>
> TOP work estimates are broken, but do not get worse with this commit.
> That issue is addressed in the following commits instead.
>
Philippe Mathieu-Daudé writes:
> Rebuilding the Fedora image is failing:
>
> $ make docker-image-fedora V=1
Broken build state? Just do:
make docker-image-fedora V=1 NOCACHE=1
> [...]
> Step 4/8 : RUN dnf install -y $PACKAGES
>---> Running in cef9615efafb
> Fedora Modular 30 -
On 16.07.19 02:01, John Snow wrote:
> Just a few housekeeping changes that keeps the following commit easier
> to read; perform the initial copy_bitmap initialization in one place.
>
> Signed-off-by: John Snow
> ---
> block/backup.c | 29 +++--
> 1 file changed, 15 insert
The RX ring descriptors control field is used for setting
SOF and EOF (start of frame and end of frame).
The SOF and EOF weren't cleared from the previous descriptors,
causing inconsistencies in ring buffer.
Fix that by clearing the control field of every descriptors we're
processing.
Signed-off-b
On Tue, Jul 16, 2019 at 10:19 AM Philippe Mathieu-Daudé
wrote:
>
> On 7/16/19 9:11 AM, Ramon Fried wrote:
> > ping
> >
> > On Sat, Jun 15, 2019 at 8:17 AM Ramon Fried wrote:
> >>
> >> The RX ring descriptors control field is used for setting
> >> SOF and EOF (start of frame and end of frame).
> >
On Tue, Jul 16, 2019 at 11:42 AM Jason Wang wrote:
>
>
> On 2019/6/15 下午1:17, Ramon Fried wrote:
> > The RX ring descriptors control field is used for setting
> > SOF and EOF (start of frame and end of frame).
> > The SOF and EOF weren't cleared from the previous descriptors,
> > causing inconsist
Philippe Mathieu-Daudé writes:
> Few more patches to be able to MXE-build the NSIS installers.
>
> The Fedora kludge is not meant for merge, but might be useful to
> test this series.
Queued to 2-9 to testing/next, thanks.
>
> Based-on: 20190712111849.9006-1-alex.ben...@linaro.org
> https://l
On 16.07.19 02:01, John Snow wrote:
> Modify the existing bdrv_is_unallocated_range to utilize the pnum return
> from bdrv_is_allocated; optionally returning a full number of clusters
> that share the same allocation status.
>
> This will be used to carefully toggle bits in the bitmap for sync=top
David Gibson's on July 16, 2019 6:30 pm:
> On Tue, Jul 16, 2019 at 12:47:26PM +1000, Nicholas Piggin wrote:
>> This has been useful to modify and test the Linux pseries suspend
>> code but it requires modification to the guest to call it (due to
>> being gated by other unimplemented features). It i
1 - 100 of 371 matches
Mail list logo
