[Qemu-devel] [PATCH 4/7] block: Generic file creation fallback

2019-07-12 Thread Max Reitz
If a protocol driver does not support image creation, we can see whether maybe the file exists already. If so, just truncating it will be sufficient. Signed-off-by: Max Reitz --- block.c | 83 - 1 file changed, 71 insertions(+), 12 deletio

[Qemu-devel] [PATCH 3/7] block: Use blk_truncate_for_formatting()

2019-07-12 Thread Max Reitz
Signed-off-by: Max Reitz --- block/parallels.c | 2 +- block/qcow.c | 2 +- block/qcow2.c | 2 +- block/qed.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/block/parallels.c b/block/parallels.c index 00fae125d1..a17b2d92f2 100644 --- a/block/parallels.c +++

[Qemu-devel] [PATCH 7/7] iotests: Add test for image creation fallback

2019-07-12 Thread Max Reitz
Signed-off-by: Max Reitz --- tests/qemu-iotests/259 | 61 ++ tests/qemu-iotests/259.out | 14 + tests/qemu-iotests/group | 1 + 3 files changed, 76 insertions(+) create mode 100755 tests/qemu-iotests/259 create mode 100644 tests/qemu-iotests/25

[Qemu-devel] [PATCH 6/7] iscsi: Drop iscsi_co_create_opts()

2019-07-12 Thread Max Reitz
The generic fallback implementation effectively does the same. Signed-off-by: Max Reitz --- block/iscsi.c | 56 --- 1 file changed, 56 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 267f160bf6..0e5729d335 100644 --- a/block/iscsi.c

[Qemu-devel] [PATCH 1/7] block/nbd: Fix hang in .bdrv_close()

2019-07-12 Thread Max Reitz
When nbd_close() is called from a coroutine, the connection_co never gets to run, and thus nbd_teardown_connection() hangs. This is because aio_co_enter() only puts the connection_co into the main coroutine's wake-up queue, so this main coroutine needs to yield and wait for connection_co to termin

[Qemu-devel] [PATCH 5/7] file-posix: Drop hdev_co_create_opts()

2019-07-12 Thread Max Reitz
The generic fallback implementation effectively does the same. Signed-off-by: Max Reitz --- block/file-posix.c | 67 -- 1 file changed, 67 deletions(-) diff --git a/block/file-posix.c b/block/file-posix.c index 4479cc7ab4..65bd6d 100644 --- a/bloc

Re: [Qemu-devel] [PATCH] build-sys: remove slirp cflags from main-loop.o

2019-07-12 Thread Philippe Mathieu-Daudé
Hi Marc-André, On 7/12/19 7:27 PM, Marc-André Lureau wrote: > Left over from c2d63650d962612cfa1b21302782d4cd12142c74. > > Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé > --- > util/Makefile.objs | 1 - > 1 file changed, 1 deletion(-)

Re: [Qemu-devel] [PATCH v7 00/13] Add migration support for VFIO device

2019-07-12 Thread Dr. David Alan Gilbert
* Kirti Wankhede (kwankh...@nvidia.com) wrote: > > > On 7/11/2019 9:53 PM, Dr. David Alan Gilbert wrote: > > * Yan Zhao (yan.y.z...@intel.com) wrote: > >> On Thu, Jul 11, 2019 at 06:50:12PM +0800, Dr. David Alan Gilbert wrote: > >>> * Yan Zhao (yan.y.z...@intel.com) wrote: > Hi Kirti, >

Re: [Qemu-devel] [PATCH v2] hw/i386: turn off vmport if CONFIG_VMPORT is disabled

2019-07-12 Thread Paolo Bonzini
On 12/07/19 18:02, Julio Montes wrote: > vmport device is not included when CONFIG_VMPORT is disabled, hence > QEMU fails with the following error: > > `Unknown device 'vmport' for bus 'ISA': unknown.` > > v2: imply VMPORT (Paolo Bonzini ) > > Signed-off-by: Julio Montes > --- > hw/i386/Kconfi

Re: [Qemu-devel] [PATCH] build-sys: remove slirp cflags from main-loop.o

2019-07-12 Thread Marc-André Lureau
Hi On Fri, Jul 12, 2019 at 9:37 PM Philippe Mathieu-Daudé wrote: > > Hi Marc-André, > > On 7/12/19 7:27 PM, Marc-André Lureau wrote: > > Left over from c2d63650d962612cfa1b21302782d4cd12142c74. > > > > Signed-off-by: Marc-André Lureau > > Reviewed-by: Philippe Mathieu-Daudé > Tested-by: Philipp

Re: [Qemu-devel] [PATCH] memory: unref the memory region in simplify flatview

2019-07-12 Thread Paolo Bonzini
On 12/07/19 08:52, Wang King wrote: > From: King Wang > > The memory region reference is increased when insert a range > into flatview range array, then decreased by destroy flatview. > If some flat range merged by flatview_simplify, the memory region > reference can not be decreased by destroy fl

Re: [Qemu-devel] [PATCH] build-sys: remove slirp cflags from main-loop.o

2019-07-12 Thread Paolo Bonzini
On 12/07/19 19:46, Marc-André Lureau wrote: > Hi > > On Fri, Jul 12, 2019 at 9:37 PM Philippe Mathieu-Daudé > wrote: >> >> Hi Marc-André, >> >> On 7/12/19 7:27 PM, Marc-André Lureau wrote: >>> Left over from c2d63650d962612cfa1b21302782d4cd12142c74. >>> >>> Signed-off-by: Marc-André Lureau >> >>

Re: [Qemu-devel] [PATCH for 4.1] Fix broken build with WHPX enabled

2019-07-12 Thread Paolo Bonzini
On 12/07/19 15:26, Stefan Weil wrote: > Signed-off-by: Stefan Weil > --- > target/i386/whpx-all.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target/i386/whpx-all.c b/target/i386/whpx-all.c > index 31d47320e4..ed95105eae 100644 > --- a/target/i386/whpx-all.c > ++

Re: [Qemu-devel] [PATCH] util: merge main-loop.c and iohandler.c

2019-07-12 Thread Marc-André Lureau
On Fri, Jul 12, 2019 at 9:34 PM Paolo Bonzini wrote: > > main-loop.c has a dependency on iohandler.c, and everything breaks > if that dependency is instead satisfied by stubs/iohandler.c. > Just put everything in the same file to avoid strange dependencies > on the order of files in util-obj-y. >

Re: [Qemu-devel] [PULL 00/19] Migration patches

2019-07-12 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Fri, 12 Jul 2019 at 15:32, Juan Quintela wrote: > > > > The following changes since commit a2a9d4adabe340617a24eb73a8b2a116d28a6b38: > > > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.1-2019

[Qemu-devel] [BUG] nanoMIPS support problem related to extract2 support for i386 TCG target

2019-07-12 Thread Aleksandar Markovic
Hello, Richard, Peter, and others. As a part of activities before 4.1 release, I tested nanoMIPS support in QEMU (which was officially fully integrated in 4.0, is currently limited to system mode only, and was tested in a similar fashion right prior to 4.0). This support appears to be broken now.

Re: [Qemu-devel] [BUG] nanoMIPS support problem related to extract2 support for i386 TCG target

2019-07-12 Thread Aleksandar Markovic
On Fri, Jul 12, 2019 at 8:09 PM Aleksandar Markovic wrote: > > Hello, Richard, Peter, and others. > > As a part of activities before 4.1 release, I tested nanoMIPS support > in QEMU (which was officially fully integrated in 4.0, is currently > limited to system mode only, and was tested in a simil

Re: [Qemu-devel] [Qemu-block] [PATCH] doc: Preallocation does not require writing zeroes

2019-07-12 Thread Max Reitz
On 12.07.19 12:27, Stefano Garzarella wrote: > On Thu, Jul 11, 2019 at 03:29:35PM +0200, Max Reitz wrote: >> When preallocating an encrypted qcow2 image, it just lets the protocol >> driver write data and then does not mark the clusters as zero. >> Therefore, reading this image will yield effective

Re: [Qemu-devel] [PATCH] gluster: fix .bdrv_reopen_prepare when backing file is a JSON object

2019-07-12 Thread Max Reitz
On 12.07.19 12:46, Stefano Garzarella wrote: > When the backing_file is specified as a JSON object, the > qemu_gluster_reopen_prepare() fails with this message: > invalid URI json:{"server.0.host": ...} > > In this case, we should call qemu_gluster_init() using the QDict > 'state->options' tha

Re: [Qemu-devel] [BUG] nanoMIPS support problem related to extract2 support for i386 TCG target

2019-07-12 Thread Aleksandar Markovic
On Fri, Jul 12, 2019 at 8:19 PM Aleksandar Markovic wrote: > > On Fri, Jul 12, 2019 at 8:09 PM Aleksandar Markovic > wrote: > > > > Hello, Richard, Peter, and others. > > > > As a part of activities before 4.1 release, I tested nanoMIPS support > > in QEMU (which was officially fully integrated i

[Qemu-devel] [PATCH] chardev: race condition with tcp_chr_disconnect

2019-07-12 Thread Andrey Shinkevich
When tcp_chr_disconnect() is called, other thread may be still writing to the channel. This patch protects only read operations that initiate the disconnection. Signed-off-by: Andrey Shinkevich --- The segmentation fault occurred because of the race condition when the write operation was interrup

Re: [Qemu-devel] Parallel make build fails on fast machine

2019-07-12 Thread Mark Cave-Ayland
On 11/07/2019 15:45, Markus Armbruster wrote: > Mark Cave-Ayland writes: > >> Something also looks a bit odd with distclean here on a fresh checkout: >> >> build@ezio:~/src/qemu/git/tmp/qemu$ make distclean >> LD recurse-clean.mo >> cc: fatal error: no input files >> compilation terminate

Re: [Qemu-devel] [PATCH for-4.1] Makefile: Fix "make install" when "make all" needs work

2019-07-12 Thread Mark Cave-Ayland
On 12/07/2019 06:59, Markus Armbruster wrote: > Until recently, target install used to recurse into target directories > in its recipe: it ran make install in a for-loop. Since target > install depends on target all, this trivially ensured we run the > sub-make install only after completing targe

Re: [Qemu-devel] RFC: Why does target/m68k RTE insn. use gen_exception

2019-07-12 Thread Lucien Murray-Pitts
On 7/10/19 4:04 AM, Richard Henderson wrote: On 7/9/19 6:58 PM, Lucien Murray-Pitts wrote: Any suggestions on how to obtain pc_next from the "m68k_cpu_do_interrupt( CPUState *cs)" ? test I did have a suggestion. It was fairly detailed. https://lists.gnu.org/archive/html/qemu-devel/2019-06/

[Qemu-devel] [Bug 1836430] [NEW] Can't install on Windows 10

2019-07-12 Thread Francesco Dainese
Public bug reported: Latest release (20190712) 64-bit doesn't install: The setup seems to work fine at first and actually extract all the files needed for qemu in the correct location, but after it has done that, it proceeds to delete every file and leaves no trace of qemu excep

Re: [Qemu-devel] [RFC v4 00/29] vSMMUv3/pSMMUv3 2 stage VFIO integration

2019-07-12 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190711172845.31035-1-eric.au...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash m

Re: [Qemu-devel] [PATCH for-4.1 0/2] Compatibility fixes for nettle 2.7 vs 3.0 vs 3.5

2019-07-12 Thread Amol Surati
On Fri, Jul 12, 2019 at 11:18:47AM +0100, Daniel P. Berrangé wrote: > This short series fixes a few compatibility issues around different > nettle versions. Thank you for the fix. The compilation with nettle 3.5.1 now succeeds without resorting to --disable-werror or --disable-nettle. -amol

<    1   2   3