Re: [Qemu-devel] [RFC v5 00/29] vSMMUv3/pSMMUv3 2 stage VFIO integration

2019-07-12 Thread Auger Eric
Hi, On 7/12/19 12:26 AM, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20190711173933.31203-1-eric.au...@redhat.com/ > > > > Hi, > > This series failed build test on s390x host. Please find the details below. > > === TEST SCRIPT BEGIN === > #!/bin/bash > # Testing scr

[Qemu-devel] [PATCH 1/3] virtio pmem: fix wrong mem region condition

2019-07-12 Thread Pankaj Gupta
Coverity reported memory region returns zero for non-null value. This is because of wrong arguments to '?:' , fixing this. Signed-off-by: Pankaj Gupta --- hw/virtio/virtio-pmem-pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/virtio-pmem-pci.c b/hw/virtio/virti

[Qemu-devel] [PATCH 0/3] virtio pmem: coverity fixes

2019-07-12 Thread Pankaj Gupta
This patch series two fixes for coverity and a transactional info removal patch. Pankaj Gupta (3): virtio pmem: fix wrong mem region condition virtio pmem: remove memdev null check virtio pmem: remove transational device info hw/virtio/virtio-pmem-pci.c | 4 +--- hw/virtio/virtio-pmem.c

[Qemu-devel] [PATCH 3/3] virtio pmem: remove transational device info

2019-07-12 Thread Pankaj Gupta
Remove transactional & non transactional device info for virtio pmem. Signed-off-by: Pankaj Gupta --- hw/virtio/virtio-pmem-pci.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/virtio/virtio-pmem-pci.c b/hw/virtio/virtio-pmem-pci.c index 0da6627469..fe2af00fa1 100644 --- a/hw/virtio/vi

[Qemu-devel] [PATCH 2/3] virtio pmem: remove memdev null check

2019-07-12 Thread Pankaj Gupta
Coverity reports that when we're assigning vi->size we handle the "pmem->memdev is NULL" case; but we then pass it into object_get_canonical_path(), which unconditionally dereferences it and will crash if it is NULL. If this pointer can be NULL then we need to do something else here. We are remo

Re: [Qemu-devel] [PATCH v2] pcie: consistent names for function args

2019-07-12 Thread Marcel Apfelbaum
On 7/11/19 11:28 PM, Michael S. Tsirkin wrote: The function declarations for pci_cap_slot_get and pci_cap_slot_write_config call the argument "slot_ctl", but the function definitions and all the call sites drop the 'o' and call it "slt_ctl". Let's be consistent. Reported-by: Peter Maydell Si

[Qemu-devel] [PATCH] hw/arm/virt: Fix non-secure flash mode

2019-07-12 Thread David Engraf
Using the whole 128 MiB flash in non-secure mode is not working because virt_flash_fdt() expects the same address for secure_sysmem and sysmem. This is not correctly handled by caller because it forwards NULL for secure_sysmem in non-secure flash mode. Fixed by using sysmem when secure_sysmem is N

Re: [Qemu-devel] [PATCH] xio3130_downstream: typo fix

2019-07-12 Thread Marcel Apfelbaum
On 7/11/19 10:25 PM, Michael S. Tsirkin wrote: slt ctl/status are passed in incorrect order. Fix this up. Signed-off-by: Michael S. Tsirkin Reported-by: Peter Maydell --- hw/pci-bridge/xio3130_downstream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci-bridge/

Re: [Qemu-devel] [PATCH v2] migration: Do not re-read the clock on pre_save in case of paused guest

2019-07-12 Thread David Gibson
On Thu, Jul 11, 2019 at 04:47:02PM -0300, Maxiwell S. Garcia wrote: > Re-read the timebase before migrate was ported from x86 commit: >6053a86fe7bd: kvmclock: reduce kvmclock difference on migration > > The clock move makes the guest knows about the paused time between > the stop and migrate c

Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/1] Don't obey the kernel block device max transfer len / max segments for raw block devices

2019-07-12 Thread Stefan Hajnoczi
On Thu, Jul 04, 2019 at 03:43:41PM +0300, Maxim Levitsky wrote: > Linux block devices, even in O_DIRECT mode don't have any user visible > limit on transfer size / number of segments, which underlying kernel block > device can have. > The kernel block layer takes care of enforcing these limits by

Re: [Qemu-devel] [PATCH v3] doc: document that the monitor console is a privileged control interface

2019-07-12 Thread Stefan Hajnoczi
On Fri, Jul 05, 2019 at 04:41:54PM +0100, Daniel P. Berrangé wrote: > A supposed exploit of QEMU was recently announced as CVE-2019-12928 > claiming that the monitor console was insecure because the "migrate" > command enabled arbitrary command execution for a remote attacker. > > To be a security

Re: [Qemu-devel] [Qemu-block] [PATCH] Fix Guest VM crash due to iSCSI Sense Key error

2019-07-12 Thread Stefan Hajnoczi
On Sun, Jul 07, 2019 at 07:55:03PM -0700, shaju.abra...@nutanix.com wrote: Reviewed-by: Stefan Hajnoczi CCing John Snow, IDE maintainer. You can use scripts/get_maintainer.pl -f hw/ide/core.c to find out who to send patches to. Stefan > From: Shaju Abraham > > During the IDE DMA transfer f

Re: [Qemu-devel] [PATCH] configure: fix sdl detection using sdl2-config

2019-07-12 Thread Thomas Huth
On 11/07/2019 00.55, Carlo Marcelo Arenas Belón wrote: > If SDL2 is requested but pkg-config doesn't have a module for it > configure should fallback to use sdl*-config, but wasn't able to > because and old variable (from SDL) was being used by mistake. > > Correct the variable name and complete o

[Qemu-devel] [PATCH] libvhost-user: Add missing GCC_FMT_ATTR and fix three format errors

2019-07-12 Thread Stefan Weil
Signed-off-by: Stefan Weil --- contrib/libvhost-user/libvhost-user.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/contrib/libvhost-user/libvhost-user.c b/contrib/libvhost-user/libvhost-user.c index 4b36e35a82..59b3202979 100644 --- a/contrib/libvhost-user/libvhost-

Re: [Qemu-devel] [PATCH for-4.1] Makefile: Fix "make install" when "make all" needs work

2019-07-12 Thread Daniel P . Berrangé
On Fri, Jul 12, 2019 at 07:59:35AM +0200, Markus Armbruster wrote: > Until recently, target install used to recurse into target directories > in its recipe: it ran make install in a for-loop. Since target > install depends on target all, this trivially ensured we run the > sub-make install only af

Re: [Qemu-devel] [PATCH-for-4.1] tests/docker: Install Sphinx in the Ubuntu images

2019-07-12 Thread Stefano Garzarella
On Thu, Jul 11, 2019 at 02:06:09PM +0200, Philippe Mathieu-Daudé wrote: > Since commit 5f71eac06e the Sphinx tool is required > to build the rST documentation. > > This fixes: > > $ ./configure --enable-docs > > ERROR: User requested feature docs > configure was not able to find it. >

Re: [Qemu-devel] [PATCH v2 0/1] Don't obey the kernel block device max transfer len / max segments for raw block devices

2019-07-12 Thread Pankaj Gupta
> Linux block devices, even in O_DIRECT mode don't have any user visible > limit on transfer size / number of segments, which underlying kernel block > device can have. > The kernel block layer takes care of enforcing these limits by splitting the > bios. > > By limiting the transfer sizes, we f

Re: [Qemu-devel] [PATCH] libvhost-user: Add missing GCC_FMT_ATTR and fix three format errors

2019-07-12 Thread Marc-André Lureau
On Fri, Jul 12, 2019 at 12:25 PM Stefan Weil wrote: > > Signed-off-by: Stefan Weil > --- > contrib/libvhost-user/libvhost-user.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/contrib/libvhost-user/libvhost-user.c > b/contrib/libvhost-user/libvhost-user.c > ind

Re: [Qemu-devel] [PATCH 1/3] virtio pmem: fix wrong mem region condition

2019-07-12 Thread Stefano Garzarella
On Fri, Jul 12, 2019 at 01:05:52PM +0530, Pankaj Gupta wrote: > Coverity reported memory region returns zero > for non-null value. This is because of wrong > arguments to '?:' , fixing this. > > Signed-off-by: Pankaj Gupta > --- > hw/virtio/virtio-pmem-pci.c | 2 +- > 1 file changed, 1 insertion

Re: [Qemu-devel] [PATCH for-4.1] Makefile: Fix "make install" when "make all" needs work

2019-07-12 Thread Stefano Garzarella
On Fri, Jul 12, 2019 at 07:59:35AM +0200, Markus Armbruster wrote: > Until recently, target install used to recurse into target directories > in its recipe: it ran make install in a for-loop. Since target > install depends on target all, this trivially ensured we run the > sub-make install only af

Re: [Qemu-devel] [PATCH v2 0/1] Don't obey the kernel block device max transfer len / max segments for raw block devices

2019-07-12 Thread Kevin Wolf
Am 04.07.2019 um 14:43 hat Maxim Levitsky geschrieben: > Linux block devices, even in O_DIRECT mode don't have any user visible > limit on transfer size / number of segments, which underlying kernel block > device can have. > The kernel block layer takes care of enforcing these limits by splitting

Re: [Qemu-devel] [RFC 1/5] block/nbd: Fix hang in .bdrv_close()

2019-07-12 Thread Kevin Wolf
Am 11.07.2019 um 21:58 hat Max Reitz geschrieben: > When nbd_close() is called from a coroutine, the connection_co never > gets to run, and thus nbd_teardown_connection() hangs. > > This is because aio_co_enter() only puts the connection_co into the main > coroutine's wake-up queue, so this main c

Re: [Qemu-devel] [PATCH v2 03/13] migration/ram: add support to send encrypted pages

2019-07-12 Thread Dr. David Alan Gilbert
* Singh, Brijesh (brijesh.si...@amd.com) wrote: > > > On 7/11/19 12:34 PM, Dr. David Alan Gilbert wrote: > > * Singh, Brijesh (brijesh.si...@amd.com) wrote: > >> When memory encryption is enabled, the guest memory will be encrypted with > >> the guest specific key. The patch introduces RAM_SAVE_F

Re: [Qemu-devel] [PATCH RFC] gpio: Add Virtual Aggregator GPIO Driver

2019-07-12 Thread Bartosz Golaszewski
wt., 9 lip 2019 o 17:59 Geert Uytterhoeven napisał(a): > > Hi Bartosz, > > On Tue, Jul 9, 2019 at 4:59 PM Bartosz Golaszewski > wrote: > > pon., 8 lip 2019 o 12:24 Geert Uytterhoeven > > napisał(a): > > > On Mon, Jul 8, 2019 at 11:45 AM Bartosz Golaszewski > > > wrote: > > > > pt., 5 lip 2019

Re: [Qemu-devel] [RFC 2/5] block: Generic truncation fallback

2019-07-12 Thread Kevin Wolf
Am 11.07.2019 um 21:58 hat Max Reitz geschrieben: > If a protocol driver does not support truncation, we call fall back to > effectively not doing anything if the new size is less than the actual > file size. This is what we have been doing for some host device drivers > already. Specifically, we

Re: [Qemu-devel] [PATCH v2 07/13] target/i386: sev: do not create launch context for an incoming guest

2019-07-12 Thread Dr. David Alan Gilbert
* Singh, Brijesh (brijesh.si...@amd.com) wrote: > The LAUNCH_START is used for creating an encryption context to encrypt > newly created guest, for an incoming guest the RECEIVE_START should be > used. > > Signed-off-by: Brijesh Singh Reviewed-by: Dr. David Alan Gilbert > --- > target/i386/se

Re: [Qemu-devel] [PATCH 1/3] virtio pmem: fix wrong mem region condition

2019-07-12 Thread Cornelia Huck
On Fri, 12 Jul 2019 13:05:52 +0530 Pankaj Gupta wrote: > Coverity reported memory region returns zero > for non-null value. This is because of wrong > arguments to '?:' , fixing this. > > Signed-off-by: Pankaj Gupta > --- > hw/virtio/virtio-pmem-pci.c | 2 +- > 1 file changed, 1 insertion(+),

Re: [Qemu-devel] [PATCH v2 08/13] misc.json: add migrate-set-sev-info command

2019-07-12 Thread Dr. David Alan Gilbert
* Singh, Brijesh (brijesh.si...@amd.com) wrote: > The command can be used by the hypervisor to specify the target Platform > Diffie-Hellman key (PDH) and certificate chain before starting the SEV > guest migration. The values passed through the command will be used while > creating the outgoing enc

Re: [Qemu-devel] [PATCH 2/3] virtio pmem: remove memdev null check

2019-07-12 Thread Cornelia Huck
On Fri, 12 Jul 2019 13:05:53 +0530 Pankaj Gupta wrote: > Coverity reports that when we're assigning vi->size we handle the > "pmem->memdev is NULL" case; but we then pass it into > object_get_canonical_path(), which unconditionally dereferences it > and will crash if it is NULL. If this pointer

Re: [Qemu-devel] [PATCH 3/3] virtio pmem: remove transational device info

2019-07-12 Thread Cornelia Huck
On Fri, 12 Jul 2019 13:05:54 +0530 Pankaj Gupta wrote: > Remove transactional & non transactional device info > for virtio pmem. s/device info/names/ ? > > Signed-off-by: Pankaj Gupta > --- > hw/virtio/virtio-pmem-pci.c | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Cornelia Huck

Re: [Qemu-devel] [PATCH 0/3] virtio pmem: coverity fixes

2019-07-12 Thread Cornelia Huck
On Fri, 12 Jul 2019 13:05:51 +0530 Pankaj Gupta wrote: > This patch series two fixes for coverity and a > transactional info removal patch. > > Pankaj Gupta (3): > virtio pmem: fix wrong mem region condition > virtio pmem: remove memdev null check > virtio pmem: remove transational device

Re: [Qemu-devel] [RFC 3/5] block: Fall back to fallback truncate function

2019-07-12 Thread Kevin Wolf
Am 11.07.2019 um 21:58 hat Max Reitz geschrieben: > file-posix does not need to basically duplicate our fallback truncate > implementation; and sheepdog can fall back to it for "shrinking" files. > > Signed-off-by: Max Reitz > --- > block/file-posix.c | 21 + > block/sheepdog

Re: [Qemu-devel] [PATCH 0/3] virtio pmem: coverity fixes

2019-07-12 Thread Pankaj Gupta
> > On Fri, 12 Jul 2019 13:05:51 +0530 > Pankaj Gupta wrote: > > > This patch series two fixes for coverity and a > > transactional info removal patch. > > > > Pankaj Gupta (3): > > virtio pmem: fix wrong mem region condition > > virtio pmem: remove memdev null check > > virtio pmem: re

Re: [Qemu-devel] [PATCH 3/3] virtio pmem: remove transational device info

2019-07-12 Thread Pankaj Gupta
> > On Fri, 12 Jul 2019 13:05:54 +0530 > Pankaj Gupta wrote: > > > Remove transactional & non transactional device info > > for virtio pmem. > > s/device info/names/ ? yes. > > > > > Signed-off-by: Pankaj Gupta > > --- > > hw/virtio/virtio-pmem-pci.c | 2 -- > > 1 file changed, 2 deleti

Re: [Qemu-devel] [PATCH v2 08/13] misc.json: add migrate-set-sev-info command

2019-07-12 Thread Daniel P . Berrangé
On Fri, Jul 12, 2019 at 11:00:22AM +0100, Dr. David Alan Gilbert wrote: > * Singh, Brijesh (brijesh.si...@amd.com) wrote: > > The command can be used by the hypervisor to specify the target Platform > > Diffie-Hellman key (PDH) and certificate chain before starting the SEV > > guest migration. The

Re: [Qemu-devel] [PATCH] libvhost-user: Add missing GCC_FMT_ATTR and fix three format errors

2019-07-12 Thread Philippe Mathieu-Daudé
On 7/12/19 10:19 AM, Stefan Weil wrote: > Signed-off-by: Stefan Weil > --- > contrib/libvhost-user/libvhost-user.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/contrib/libvhost-user/libvhost-user.c > b/contrib/libvhost-user/libvhost-user.c > index 4b36e35a82.

[Qemu-devel] [PATCH for-4.1 0/2] Compatibility fixes for nettle 2.7 vs 3.0 vs 3.5

2019-07-12 Thread Daniel P . Berrangé
This short series fixes a few compatibility issues around different nettle versions. Daniel P. Berrangé (2): crypto: switch to modern nettle AES APIs crypto: fix function signatures for nettle 2.7 vs 3 crypto/cipher-nettle.c | 218 ++--- crypto/hash-nettle

[Qemu-devel] [PATCH for-4.1 1/2] crypto: switch to modern nettle AES APIs

2019-07-12 Thread Daniel P . Berrangé
The aes_ctx struct and aes_* functions have been deprecated in nettle 3.5, in favour of keysize specific functions which were introduced first in nettle 3.0. Switch QEMU code to use the new APIs and add some backcompat defines such that it still builds on nettle 2.7 Signed-off-by: Daniel P. Berra

[Qemu-devel] [PATCH for-4.1 2/2] crypto: fix function signatures for nettle 2.7 vs 3

2019-07-12 Thread Daniel P . Berrangé
Nettle version 2.7.x used 'unsigned int' instead of 'size_t' for length parameters in functions. Use a local typedef so that we can build with the correct signature depending on nettle version, as we already do in the cipher code. Signed-off-by: Daniel P. Berrangé --- crypto/hash-nettle.c | 12 +

Re: [Qemu-devel] [Qemu-block] [PATCH] doc: Preallocation does not require writing zeroes

2019-07-12 Thread Stefano Garzarella
On Thu, Jul 11, 2019 at 03:29:35PM +0200, Max Reitz wrote: > When preallocating an encrypted qcow2 image, it just lets the protocol > driver write data and then does not mark the clusters as zero. > Therefore, reading this image will yield effectively random data. > > As such, we have not fulfille

Re: [Qemu-devel] [PATCH v2 09/13] target/i386: sev: add support to encrypt the outgoing page

2019-07-12 Thread Dr. David Alan Gilbert
* Singh, Brijesh (brijesh.si...@amd.com) wrote: > The sev_save_outgoing_page() provide the implementation to encrypt the > guest private pages during the transit. The routines uses the SEND_START > command to create the outgoing encryption context on the first call then > uses the SEND_UPDATE_DATA

[Qemu-devel] [PATCH] gluster: fix .bdrv_reopen_prepare when backing file is a JSON object

2019-07-12 Thread Stefano Garzarella
When the backing_file is specified as a JSON object, the qemu_gluster_reopen_prepare() fails with this message: invalid URI json:{"server.0.host": ...} In this case, we should call qemu_gluster_init() using the QDict 'state->options' that contains the parameters already parsed. Buglink: https

Re: [Qemu-devel] [RFC 1/5] block/nbd: Fix hang in .bdrv_close()

2019-07-12 Thread Max Reitz
On 12.07.19 11:24, Kevin Wolf wrote: > Am 11.07.2019 um 21:58 hat Max Reitz geschrieben: >> When nbd_close() is called from a coroutine, the connection_co never >> gets to run, and thus nbd_teardown_connection() hangs. >> >> This is because aio_co_enter() only puts the connection_co into the main >

Re: [Qemu-devel] [RFC 2/5] block: Generic truncation fallback

2019-07-12 Thread Max Reitz
On 12.07.19 11:49, Kevin Wolf wrote: > Am 11.07.2019 um 21:58 hat Max Reitz geschrieben: >> If a protocol driver does not support truncation, we call fall back to >> effectively not doing anything if the new size is less than the actual >> file size. This is what we have been doing for some host d

Re: [Qemu-devel] [RFC 1/5] block/nbd: Fix hang in .bdrv_close()

2019-07-12 Thread Kevin Wolf
Am 12.07.2019 um 12:47 hat Max Reitz geschrieben: > On 12.07.19 11:24, Kevin Wolf wrote: > > Am 11.07.2019 um 21:58 hat Max Reitz geschrieben: > >> When nbd_close() is called from a coroutine, the connection_co never > >> gets to run, and thus nbd_teardown_connection() hangs. > >> > >> This is beca

Re: [Qemu-devel] [PATCH v2 10/13] target/i386: sev: add support to load incoming encrypted page

2019-07-12 Thread Dr. David Alan Gilbert
* Singh, Brijesh (brijesh.si...@amd.com) wrote: > The sev_load_incoming_page() provide the implementation to read the > incoming guest private pages from the socket and load it into the guest > memory. The routines uses the RECEIVE_START command to create the > incoming encryption context on the fi

Re: [Qemu-devel] [RFC 3/5] block: Fall back to fallback truncate function

2019-07-12 Thread Max Reitz
On 12.07.19 12:04, Kevin Wolf wrote: > Am 11.07.2019 um 21:58 hat Max Reitz geschrieben: >> file-posix does not need to basically duplicate our fallback truncate >> implementation; and sheepdog can fall back to it for "shrinking" files. >> >> Signed-off-by: Max Reitz >> --- >> block/file-posix.c

Re: [Qemu-devel] [RFC 1/5] block/nbd: Fix hang in .bdrv_close()

2019-07-12 Thread Max Reitz
On 12.07.19 13:01, Kevin Wolf wrote: > Am 12.07.2019 um 12:47 hat Max Reitz geschrieben: >> On 12.07.19 11:24, Kevin Wolf wrote: >>> Am 11.07.2019 um 21:58 hat Max Reitz geschrieben: When nbd_close() is called from a coroutine, the connection_co never gets to run, and thus nbd_teardown_co

Re: [Qemu-devel] [PATCH RFC v5 1/3] tests: New make target check-source

2019-07-12 Thread Markus Armbruster
Richard Henderson writes: > On 7/11/19 2:28 PM, Markus Armbruster wrote: >> include/exec/cpu_ldst_template.h | 3 + >> include/exec/cpu_ldst_useronly_template.h | 3 + >> include/exec/cputlb.h | 3 + >> include/exec/exec-all.h | 3 + >> include/

Re: [Qemu-devel] [PULL 0/2] ppc-for-4.1 queue 20190712

2019-07-12 Thread Peter Maydell
ilable in the Git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-4.1-20190712 > > for you to fetch changes up to 38298611d5a87d2739d0a21d5f9e47ba43570c22: > > xics/kvm: Always set the MASKED bit if

Re: [Qemu-devel] [RFC 2/5] block: Generic truncation fallback

2019-07-12 Thread Kevin Wolf
Am 12.07.2019 um 12:58 hat Max Reitz geschrieben: > On 12.07.19 11:49, Kevin Wolf wrote: > > Am 11.07.2019 um 21:58 hat Max Reitz geschrieben: > >> If a protocol driver does not support truncation, we call fall back to > >> effectively not doing anything if the new size is less than the actual > >>

[Qemu-devel] [PATCH for 4.1? v1 0/7] testing/next (docker, win-cross)

2019-07-12 Thread Alex Bennée
Hi, This is my current queue for testing/next. I think they are all worth it for 4.1 but it would be nice to get the Windows cross builds up and running again. The following patches need review patch 0001/tests docker add test misc for building tools doc.patch patch 0005/tests migration test do

[Qemu-devel] [PATCH v1 4/7] tests/docker: Install Ubuntu images noninteractively

2019-07-12 Thread Alex Bennée
From: Philippe Mathieu-Daudé We correctly use the DEBIAN_FRONTEND environment variable on the Debian images, but forgot the Ubuntu ones are based on it. Since building docker images is not interactive, we need to inform the APT tools about it using the DEBIAN_FRONTEND environment variable (we al

[Qemu-devel] [PATCH v1 3/7] tests/docker: Install Sphinx in the Fedora image

2019-07-12 Thread Alex Bennée
From: Philippe Mathieu-Daudé Since commit 5f71eac06e the Sphinx tool is required to build the rST documentation. This fixes: $ ./configure --enable-docs ERROR: User requested feature docs configure was not able to find it. Install texinfo, Perl/perl-podlators and python-sphin

[Qemu-devel] [PATCH v1 1/7] tests/docker: add test-misc for building tools & docs

2019-07-12 Thread Alex Bennée
Add yet another test type so we cna quickly exercise the miscellaneous build products of the build system under various docer configurations. Signed-off-by: Alex Bennée --- tests/docker/test-misc | 22 ++ 1 file changed, 22 insertions(+) create mode 100755 tests/docker/test-

[Qemu-devel] [PATCH v1 2/7] tests/docker: Install Sphinx in the Ubuntu images

2019-07-12 Thread Alex Bennée
From: Philippe Mathieu-Daudé Since commit 5f71eac06e the Sphinx tool is required to build the rST documentation. This fixes: $ ./configure --enable-docs ERROR: User requested feature docs configure was not able to find it. Install texinfo, Perl/perl-podlators and python-sphin

[Qemu-devel] [PATCH v1 5/7] tests/migration-test: don't spam the logs when we fail

2019-07-12 Thread Alex Bennée
Quite often the information about which test failed is hidden by the wall of repeated failures for each page. Stop outputting the error after 10 bad pages and just summarise the total damage at the end. Signed-off-by: Alex Bennée --- tests/migration-test.c | 19 --- 1 file change

[Qemu-devel] [PATCH v1 7/7] shippable: re-enable the windows cross builds

2019-07-12 Thread Alex Bennée
The pkg.mxe.cc repo has been restored. Signed-off-by: Alex Bennée --- .shippable.yml | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/.shippable.yml b/.shippable.yml index f2ffef21d11..f74a3de3ffd 100644 --- a/.shippable.yml +++ b/.shippable.yml @@ -7,11 +7,10 @@ env:

[Qemu-devel] [PATCH v1 6/7] tests/dockerfiles: update the win cross builds to stretch

2019-07-12 Thread Alex Bennée
While fixing up pkg.mxe.cc they move the URLs around a bit and dropped Jessie support in favour of Stretch. We also need to update the keys used to verify the packages. Signed-off-by: Alex Bennée --- tests/docker/Makefile.include | 6 +++--- tests/docker/dockerfiles/debi

Re: [Qemu-devel] [PATCH v1 5/7] tests/migration-test: don't spam the logs when we fail

2019-07-12 Thread Laurent Vivier
On 12/07/2019 13:18, Alex Bennée wrote: > Quite often the information about which test failed is hidden by the > wall of repeated failures for each page. Stop outputting the error > after 10 bad pages and just summarise the total damage at the end. > > Signed-off-by: Alex Bennée > --- > tests/mi

Re: [Qemu-devel] [RFC 1/5] block/nbd: Fix hang in .bdrv_close()

2019-07-12 Thread Kevin Wolf
Am 12.07.2019 um 13:09 hat Max Reitz geschrieben: > On 12.07.19 13:01, Kevin Wolf wrote: > > Am 12.07.2019 um 12:47 hat Max Reitz geschrieben: > >> On 12.07.19 11:24, Kevin Wolf wrote: > >>> Am 11.07.2019 um 21:58 hat Max Reitz geschrieben: > When nbd_close() is called from a coroutine, the co

Re: [Qemu-devel] [PATCH v1 5/7] tests/migration-test: don't spam the logs when we fail

2019-07-12 Thread Thomas Huth
On 12/07/2019 13.18, Alex Bennée wrote: > Quite often the information about which test failed is hidden by the > wall of repeated failures for each page. Stop outputting the error > after 10 bad pages and just summarise the total damage at the end. > > Signed-off-by: Alex Bennée > --- > tests/mi

Re: [Qemu-devel] [PATCH v2 12/13] migration: add support to migrate page encryption bitmap

2019-07-12 Thread Dr. David Alan Gilbert
* Singh, Brijesh (brijesh.si...@amd.com) wrote: > When memory encryption is enabled, the hypervisor maintains a page > encryption bitmap which is referred by hypervisor during migratoin to check > if page is private or shared. The bitmap is built during the VM bootup and > must be migrated to the t

Re: [Qemu-devel] [PATCH v2 13/13] target/i386: sev: remove migration blocker

2019-07-12 Thread Dr. David Alan Gilbert
* Singh, Brijesh (brijesh.si...@amd.com) wrote: > Signed-off-by: Brijesh Singh Reviewed-by: Dr. David Alan Gilbert > --- > target/i386/sev.c | 12 > 1 file changed, 12 deletions(-) > > diff --git a/target/i386/sev.c b/target/i386/sev.c > index 93c6a90806..48336515a2 100644 > ---

[Qemu-devel] [PATCH for 4.1 0/4] target/mips: Fixes for 4.1

2019-07-12 Thread Aleksandar Markovic
From: Aleksandar Markovic At the moment, this includes fixes for problems in switch statements found by GCC 8.3 improved code analysis features. Aleksandar Markovic (4): target/mips: Add 'fall through' comments for handling nanoMips' SHXS, SWXS target/mips: Add missing 'break' for a case

[Qemu-devel] [PATCH for 4.1 2/4] target/mips: Add missing 'break' for a case of MTHC0 handling

2019-07-12 Thread Aleksandar Markovic
From: Aleksandar Markovic This was found by GCC 8.3 static analysis. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/mips/translate.c b/target/mips/translate.c index 2be5e2d..59d4acd 100644 --- a/target/mips/translate.c

[Qemu-devel] [PATCH for 4.1 3/4] target/mips: Add missing 'break' for certain cases of MFTR handling

2019-07-12 Thread Aleksandar Markovic
From: Aleksandar Markovic This was found by GCC 8.3 static analysis. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/mips/translate.c b/target/mips/translate.c index 59d4acd..b1cf5f0 100644 --- a/target/mips/translate.

[Qemu-devel] [PATCH for 4.1 1/4] target/mips: Add 'fall through' comments for handling nanoMips' SHXS, SWXS

2019-07-12 Thread Aleksandar Markovic
From: Aleksandar Markovic This was found by GCC 8.3 static analysis. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/mips/translate.c b/target/mips/translate.c index f96f141..2be5e2d 100644 --- a/target/mips/translate.

[Qemu-devel] [PATCH for 4.1 v2] linux-user: Fix structure target_ucontext for MIPS

2019-07-12 Thread Aleksandar Markovic
From: Aleksandar Markovic Structure ucontext for MIPS is defined in the following way in Linux kernel: (arch/mips/include/uapi/asm/ucontext.h, lines 54-64) struct ucontext { /* Historic fields matching asm-generic */ unsigned long uc_flags; struct ucontext *uc_link; st

[Qemu-devel] [PATCH for 4.1 4/4] target/mips: Add missing 'break' for certain cases of MTTR handling

2019-07-12 Thread Aleksandar Markovic
From: Aleksandar Markovic This was found by GCC 8.3 static analysis. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/mips/translate.c b/target/mips/translate.c index b1cf5f0..ca62800 100644 --- a/target/mips/translate.

Re: [Qemu-devel] [PATCH v1 5/7] tests/migration-test: don't spam the logs when we fail

2019-07-12 Thread Dr. David Alan Gilbert
* Alex Bennée (alex.ben...@linaro.org) wrote: > Quite often the information about which test failed is hidden by the > wall of repeated failures for each page. Stop outputting the error > after 10 bad pages and just summarise the total damage at the end. > > Signed-off-by: Alex Bennée Yep, occas

Re: [Qemu-devel] [RFC 1/5] block/nbd: Fix hang in .bdrv_close()

2019-07-12 Thread Max Reitz
On 12.07.19 13:23, Kevin Wolf wrote: > Am 12.07.2019 um 13:09 hat Max Reitz geschrieben: >> On 12.07.19 13:01, Kevin Wolf wrote: >>> Am 12.07.2019 um 12:47 hat Max Reitz geschrieben: On 12.07.19 11:24, Kevin Wolf wrote: > Am 11.07.2019 um 21:58 hat Max Reitz geschrieben: >> When nbd_cl

Re: [Qemu-devel] [RFC 2/5] block: Generic truncation fallback

2019-07-12 Thread Max Reitz
On 12.07.19 13:17, Kevin Wolf wrote: > Am 12.07.2019 um 12:58 hat Max Reitz geschrieben: >> On 12.07.19 11:49, Kevin Wolf wrote: >>> Am 11.07.2019 um 21:58 hat Max Reitz geschrieben: If a protocol driver does not support truncation, we call fall back to effectively not doing anything if t

[Qemu-devel] [PATCH for-4.1?] hw/arm/fsl-imx6ul.c: Remove dead SMP-related code

2019-07-12 Thread Peter Maydell
The i.MX6UL always has a single Cortex-A7 CPU (we set FSL_IMX6UL_NUM_CPUS to 1 in line with this). This means that all the code in fsl-imx6ul.c to handle multiple CPUs is dead code, and Coverity is now complaining that it is unreachable (CID 1403008, 1403011). Remove the unreachable code and the o

[Qemu-devel] [PATCH v2] libvhost-user: Add missing GCC_FMT_ATTR and fix three format errors

2019-07-12 Thread Stefan Weil
Reviewed-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Stefan Weil --- v2: - Show different value in "Guest says [...]" (suggested by Marc-André Lureau) - Fix more format errors for 32 bit builds (reported by Philippe Mathieu-Daudé)

[Qemu-devel] [PATCH for 4.1 v2 4/4] target/mips: Add missing 'break' for certain cases of MTTR handling

2019-07-12 Thread Aleksandar Markovic
From: Aleksandar Markovic This was found by GCC 8.3 static analysis. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/mips/translate.c b/target/mips/translate.c index b1cf5f0..ca62800 100644 --- a/target/mips/translate.

[Qemu-devel] [PATCH for 4.1 v2 1/4] target/mips: Add 'fall through' comments for handling nanoMips' SHXS, SWXS

2019-07-12 Thread Aleksandar Markovic
From: Aleksandar Markovic This was found by GCC 8.3 static analysis. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/mips/translate.c b/target/mips/translate.c index f96f141..2be5e2d 100644 --- a/target/mips/translate.

[Qemu-devel] [PATCH for 4.1 v2 3/4] target/mips: Add missing 'break' for certain cases of MFTR handling

2019-07-12 Thread Aleksandar Markovic
From: Aleksandar Markovic This was found by GCC 8.3 static analysis. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/mips/translate.c b/target/mips/translate.c index 59d4acd..b1cf5f0 100644 --- a/target/mips/translate.

[Qemu-devel] [PATCH for 4.1 v2 2/4] target/mips: Add missing 'break' for a case of MTHC0 handling

2019-07-12 Thread Aleksandar Markovic
From: Aleksandar Markovic This was found by GCC 8.3 static analysis. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/mips/translate.c b/target/mips/translate.c index 2be5e2d..59d4acd 100644 --- a/target/mips/translate.c

[Qemu-devel] [PATCH for 4.1 v2 0/4] target/mips: Fixes for 4.1 rc1

2019-07-12 Thread Aleksandar Markovic
From: Aleksandar Markovic At the moment, this includes fixes for problems in switch statements found by GCC 8.3 improved code analysis features. v1->v2: - excluded the patch on "ucontext" that will go into linux user queue Aleksandar Markovic (4): target/mips: Add 'fall through' comments f

Re: [Qemu-devel] [PATCH v26 1/7] target/avr: Add outward facing interfaces and core CPU logic

2019-07-12 Thread Igor Mammedov
On Fri, 12 Jul 2019 08:36:58 +0300 Michael Rolnik wrote: > From: Sarah Harris > > This includes: > - CPU data structures > - object model classes and functions > - migration functions > - GDB hooks > > Signed-off-by: Michael Rolnik looks fine to me from QOM point of view Acked-by: Igor Mamme

Re: [Qemu-devel] [PATCH for-4.1 1/2] crypto: switch to modern nettle AES APIs

2019-07-12 Thread Alex Bennée
Daniel P. Berrangé writes: > The aes_ctx struct and aes_* functions have been deprecated in nettle > 3.5, in favour of keysize specific functions which were introduced > first in nettle 3.0. > > Switch QEMU code to use the new APIs and add some backcompat defines > such that it still builds on

Re: [Qemu-devel] [PATCH for-4.1 2/2] crypto: fix function signatures for nettle 2.7 vs 3

2019-07-12 Thread Alex Bennée
Daniel P. Berrangé writes: > Nettle version 2.7.x used 'unsigned int' instead of 'size_t' for length > parameters in functions. Use a local typedef so that we can build with > the correct signature depending on nettle version, as we already do in > the cipher code. > > Signed-off-by: Daniel P.

Re: [Qemu-devel] [PATCH v4] linux-user: fix to handle variably sized SIOCGSTAMP with new kernels

2019-07-12 Thread Laurent Vivier
Le 11/07/2019 à 23:05, Arnd Bergmann a écrit : > On Thu, Jul 11, 2019 at 7:32 PM Laurent Vivier wrote: > >> >> Notes: >> v4: [lv] timeval64 and timespec64 are { long long , long } > >> >> +STRUCT(timeval64, TYPE_LONGLONG, TYPE_LONG) >> + >> +STRUCT(timespec64, TYPE_LONGLONG, TYPE_LONG) >> +

Re: [Qemu-devel] [RFC 1/5] block/nbd: Fix hang in .bdrv_close()

2019-07-12 Thread Kevin Wolf
Am 12.07.2019 um 13:44 hat Max Reitz geschrieben: > On 12.07.19 13:23, Kevin Wolf wrote: > > Am 12.07.2019 um 13:09 hat Max Reitz geschrieben: > >> On 12.07.19 13:01, Kevin Wolf wrote: > >>> Am 12.07.2019 um 12:47 hat Max Reitz geschrieben: > On 12.07.19 11:24, Kevin Wolf wrote: > > Am 11.

Re: [Qemu-devel] 答复: migrate_set_speed has no effect if the guest is using hugepages.

2019-07-12 Thread Dr. David Alan Gilbert
* Lin Ma (l...@suse.com) wrote: > > > > -邮件原件- > > 发件人: Dr. David Alan Gilbert > > 发送时间: 2019年7月11日 18:24 > > 收件人: Lin Ma > > 抄送: qemu-devel@nongnu.org > > 主题: Re: [Qemu-devel] migrate_set_speed has no effect if the guest is using > > hugepages. > > > > * Lin Ma (l...@suse.com) wrote:

Re: [Qemu-devel] [RISU PATCH v3 01/18] risugen_common: add helper functions insnv, randint

2019-07-12 Thread Alex Bennée
Jan Bobek writes: > insnv allows emitting variable-length instructions in little-endian or > big-endian byte order; it subsumes functionality of former insn16() > and insn32() functions. > > randint can reliably generate signed or unsigned integers of arbitrary > width. > > Signed-off-by: Jan B

Re: [Qemu-devel] [PATCH v4] linux-user: fix to handle variably sized SIOCGSTAMP with new kernels

2019-07-12 Thread Arnd Bergmann
On Fri, Jul 12, 2019 at 2:17 PM Laurent Vivier wrote: > > Le 11/07/2019 à 23:05, Arnd Bergmann a écrit : > > On Thu, Jul 11, 2019 at 7:32 PM Laurent Vivier wrote: > > > >> > >> Notes: > >> v4: [lv] timeval64 and timespec64 are { long long , long } > > > >> > >> +STRUCT(timeval64, TYPE_LONGLON

Re: [Qemu-devel] [PATCH v2] libvhost-user: Add missing GCC_FMT_ATTR and fix three format errors

2019-07-12 Thread Philippe Mathieu-Daudé
On 7/12/19 1:50 PM, Stefan Weil wrote: > Reviewed-by: Marc-André Lureau > Reviewed-by: Philippe Mathieu-Daudé > Tested-by: Philippe Mathieu-Daudé > Signed-off-by: Stefan Weil > --- > > v2: > - Show different value in "Guest says [...]" (suggested by Marc-André Lureau) > - Fix more format error

[Qemu-devel] [PATCH] Remove old global variable smp_cpus

2019-07-12 Thread Stefan Weil
Signed-off-by: Stefan Weil --- include/sysemu/sysemu.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h index 984c439ac9..9b849cb770 100644 --- a/include/sysemu/sysemu.h +++ b/include/sysemu/sysemu.h @@ -103,7 +103,6 @@ extern const char *keyboa

Re: [Qemu-devel] [PATCH v4] linux-user: fix to handle variably sized SIOCGSTAMP with new kernels

2019-07-12 Thread Laurent Vivier
Le 12/07/2019 à 14:47, Arnd Bergmann a écrit : > On Fri, Jul 12, 2019 at 2:17 PM Laurent Vivier wrote: >> >> Le 11/07/2019 à 23:05, Arnd Bergmann a écrit : >>> On Thu, Jul 11, 2019 at 7:32 PM Laurent Vivier wrote: >>> Notes: v4: [lv] timeval64 and timespec64 are { long long , l

[Qemu-devel] [PATCH for 4.1] Fix broken build with WHPX enabled

2019-07-12 Thread Stefan Weil
Signed-off-by: Stefan Weil --- target/i386/whpx-all.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/i386/whpx-all.c b/target/i386/whpx-all.c index 31d47320e4..ed95105eae 100644 --- a/target/i386/whpx-all.c +++ b/target/i386/whpx-all.c @@ -1396,7 +1396,7 @@ static

Re: [Qemu-devel] [PATCH for 4.1 v2] linux-user: Fix structure target_ucontext for MIPS

2019-07-12 Thread Laurent Vivier
Le 12/07/2019 à 13:37, Aleksandar Markovic a écrit : > From: Aleksandar Markovic > > Structure ucontext for MIPS is defined in the following way in > Linux kernel: > > (arch/mips/include/uapi/asm/ucontext.h, lines 54-64) > > struct ucontext { > /* Historic fields matching asm-generic */ >

Re: [Qemu-devel] [PATCH v2 05/13] doc: update AMD SEV API spec web link

2019-07-12 Thread Singh, Brijesh
On 7/11/19 1:06 PM, Dr. David Alan Gilbert wrote: > * Singh, Brijesh (brijesh.si...@amd.com) wrote: >> Signed-off-by: Brijesh Singh >> --- >> docs/amd-memory-encryption.txt | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/docs/amd-memory-encryption.txt b/docs/amd-me

Re: [Qemu-devel] [RISU PATCH v3 00/18] Support for generating x86 SIMD test images

2019-07-12 Thread Alex Bennée
Jan Bobek writes: > This is v3 of the patch series posted in [1] and [2]. Note that this > is the first fully-featured patch series implementing all desired > functionality, including (V)LDMXCSR and VSIB-based instructions like > VGATHER*. > > While implementing the last bits required in order

Re: [Qemu-devel] [PATCH v1 5/7] tests/migration-test: don't spam the logs when we fail

2019-07-12 Thread Alex Bennée
Laurent Vivier writes: > On 12/07/2019 13:18, Alex Bennée wrote: >> Quite often the information about which test failed is hidden by the >> wall of repeated failures for each page. Stop outputting the error >> after 10 bad pages and just summarise the total damage at the end. >> >> Signed-off-b

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Remove old global variable smp_cpus

2019-07-12 Thread Laurent Vivier
Le 12/07/2019 à 15:19, Stefan Weil a écrit : > Signed-off-by: Stefan Weil > --- > include/sysemu/sysemu.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h > index 984c439ac9..9b849cb770 100644 > --- a/include/sysemu/sysemu.h > +++ b/includ

Re: [Qemu-devel] [PATCH v4] linux-user: fix to handle variably sized SIOCGSTAMP with new kernels

2019-07-12 Thread Arnd Bergmann
On Fri, Jul 12, 2019 at 3:23 PM Laurent Vivier wrote: > > Le 12/07/2019 à 14:47, Arnd Bergmann a écrit : > > On Fri, Jul 12, 2019 at 2:17 PM Laurent Vivier wrote: > >> > >> Le 11/07/2019 à 23:05, Arnd Bergmann a écrit : > >>> On Thu, Jul 11, 2019 at 7:32 PM Laurent Vivier wrote: > >>> > > >

[Qemu-devel] [PATCH-for-4.1 2/7] hw/usb: Bluetooth HCI USB depends on USB & BLUETOOTH

2019-07-12 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/usb/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig index 564305e283..1b435ec002 100644 --- a/hw/usb/Kconfig +++ b/hw/usb/Kconfig @@ -82,7 +82,7 @@ config USB_NETWORK config USB_BLUETOOTH

[Qemu-devel] [PATCH-for-4.1? 0/7] vl: Allow building with CONFIG_BLUETOOTH disabled

2019-07-12 Thread Philippe Mathieu-Daudé
A series of obvious patches to build without the deprecated bluetooth devices. Still worth for 4.1 or too late? It is clearly not a bugfix. Regards, Phil. Philippe Mathieu-Daudé (7): hw/arm: Nokia N-series tablet requires Bluetooth hw/usb: Bluetooth HCI USB depends on USB & BLUETOOTH MAINT

  1   2   3   >