[Qemu-devel] in icount mode guest OS can't boot on qemu_x86 when shift value range in [0, 3]

2019-07-10 Thread Wu, Wentong
Hi all, I'm running a rtos on qemu_x86 with icount mode enabled, shift value located in [0, 3], there is very high possibility that the guest os(the rtos) can't boot up. Does anyone have any idea for this issue? And this issue blocked me long time, appreciate any input? Thanks

Re: [Qemu-devel] in icount mode guest OS can't boot on qemu_x86 when shift value range in [0, 3]

2019-07-10 Thread Wu, Wentong
Add more info: the qemu binary is qemu-system-i386 and it's TCG mode, not kvm. From: Wu, Wentong Sent: Wednesday, July 10, 2019 3:01 PM To: 'qemu-devel@nongnu.org' Subject: in icount mode guest OS can't boot on qemu_x86 when shift value range in [0, 3] Hi all, I'm running a rtos on qemu_x86

Re: [Qemu-devel] [PATCH v1 4/5] gdbstub: add some notes to the header comment

2019-07-10 Thread Richard Henderson
On 7/5/19 6:04 PM, Alex Bennée wrote: > Add a link to the remote protocol spec and an SPDX tag. > > Signed-off-by: Alex Bennée > --- > gdbstub.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/gdbstub.c b/gdbstub.c > index 8618e34311..ea3349d1aa 100644 > --- a/gdbstub.c > +++ b/g

Re: [Qemu-devel] [PATCH v1 5/5] gdbstub: revert to previous set_reg behaviour

2019-07-10 Thread Richard Henderson
On 7/5/19 6:04 PM, Alex Bennée wrote: > The refactoring of handle_set_reg missed the fact we previously had > responded with an empty packet when we were not using XML based > protocols. This broke the fallback behaviour for architectures that > don't have registers defined in QEMU's gdb-xml direct

Re: [Qemu-devel] [PATCH v1 3/5] tests/tcg: fix diff-out pass to properly report failure

2019-07-10 Thread Richard Henderson
On 7/5/19 6:04 PM, Alex Bennée wrote: > +diff-out = $(call quiet-command, diff -q $1.out $2 || \ > + (diff -u $1.out $2 | head -n 10 && false), \ What about (set -o pipefail; diff ... | head) ? I think we already rely on bash, right? r~

[Qemu-devel] [PATCH] target-i386: adds PV_SCHED_YIELD CPUID feature bit

2019-07-10 Thread Wanpeng Li
From: Wanpeng Li Adds PV_SCHED_YIELD CPUID feature bit. Cc: Eduardo Habkost Cc: Paolo Bonzini Cc: Radim Krčmář Signed-off-by: Wanpeng Li --- Note: kvm part is merged v1 -> v2: * use bit 13 instead of bit 12 since bit 12 has user now target/i386/cpu.c | 2 +- 1 file changed, 1 insertion(+)

Re: [Qemu-devel] [PATCH V2] net/colo-compare.c: Fix memory leak and code style issue.

2019-07-10 Thread Zhang, Chen
> -Original Message- > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Tuesday, July 9, 2019 10:48 PM > To: Zhang, Chen ; Li Zhijian ; > Peter Maydell ; qemu-dev de...@nongnu.org> > Cc: Zhang Chen > Subject: Re: [Qemu-devel] [PATCH V2] net/colo-compare.c: Fix memory leak > and cod

Re: [Qemu-devel] [PATCH] target-i386: adds PV_SCHED_YIELD CPUID feature bit

2019-07-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1562745044-7838-1-git-send-email-wanpen...@tencent.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/

[Qemu-devel] [PATCH RESEND v2] target-i386: adds PV_SCHED_YIELD CPUID feature bit

2019-07-10 Thread Wanpeng Li
From: Wanpeng Li Adds PV_SCHED_YIELD CPUID feature bit. Cc: Eduardo Habkost Cc: Paolo Bonzini Cc: Radim Krčmář Signed-off-by: Wanpeng Li --- Note: kvm part is merged v1 -> v2: * use bit 13 instead of bit 12 since bit 12 has user now target/i386/cpu.c | 2 +- 1 file changed, 1 insertion(+)

Re: [Qemu-devel] [PATCH] target-i386: adds PV_SCHED_YIELD CPUID feature bit

2019-07-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1562745044-7838-1-git-send-email-wanpen...@tencent.com/ Hi, This series failed build test on s390x host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a

[Qemu-devel] [PATCH] migration/postcopy: use static PostcopyDiscardState instead of allocating it for each block

2019-07-10 Thread Wei Yang
Even we need to do discard for each RAMBlock, we still can leverage the same memory space to store the information. By doing so, we avoid memory allocation and deallocation to the system and also avoid potential failure of memory allocation which breaks the migration. Signed-off-by: Wei Yang ---

Re: [Qemu-devel] [PATCH 3/3] Add dbus-vmstate object

2019-07-10 Thread Daniel P . Berrangé
On Wed, Jul 10, 2019 at 08:14:03AM +0200, Paolo Bonzini wrote: > On 08/07/19 09:24, Marc-André Lureau wrote: > > + > > +dstaddr = g_strsplit(g_test_dbus_get_bus_address(dstbus), ",", 2); > > +dst_qemu_args = > > +g_strdup_printf("-object dbus-vmstate,id=dv,addr=%s -incoming %s", > >

Re: [Qemu-devel] [qemu-s390x] [PATCH for-4.1 1/2] s390x/pci: add some fallthrough annotations

2019-07-10 Thread Cornelia Huck
On Tue, 9 Jul 2019 18:55:34 -0400 Collin Walling wrote: > On 7/8/19 9:23 AM, Christian Borntraeger wrote: > > > > > > On 08.07.19 14:54, Cornelia Huck wrote: > >> According to the comment, the bits are supposed to accumulate. > >> > >> Reported-by: Stefan Weil > >> Fixes: 5d1abf234462 ("s390

Re: [Qemu-devel] [PATCH v2 2/5] tests/docker: add podman support

2019-07-10 Thread Paolo Bonzini
On 09/07/19 21:43, Marc-André Lureau wrote: > With current podman, we have to use a uidmap trick in order to be able > to rw-share the ccache directory with the container user. > > With a user 1000, the default mapping is: > 1000 (host) -> 0 (container). Why not do this in docker.py (either as pa

Re: [Qemu-devel] [BUG] VM abort after migration

2019-07-10 Thread Longpeng (Mike)
在 2019/7/10 11:57, Jason Wang 写道: > > On 2019/7/10 上午11:36, Longpeng (Mike) wrote: >> 在 2019/7/10 11:25, Jason Wang 写道: >>> On 2019/7/8 下午5:47, Dr. David Alan Gilbert wrote: * longpeng (longpe...@huawei.com) wrote: > Hi guys, > > We found a qemu core in our testing environment, th

Re: [Qemu-devel] [PATCH v1 3/5] tests/tcg: fix diff-out pass to properly report failure

2019-07-10 Thread Alex Bennée
Richard Henderson writes: > On 7/5/19 6:04 PM, Alex Bennée wrote: >> +diff-out = $(call quiet-command, diff -q $1.out $2 || \ >> + (diff -u $1.out $2 | head -n 10 && false), \ > > What about (set -o pipefail; diff ... | head) ? > I think we already rely on bash, righ

Re: [Qemu-devel] [PATCH v2 2/5] tests/docker: add podman support

2019-07-10 Thread Marc-André Lureau
Hi On Wed, Jul 10, 2019 at 12:27 PM Paolo Bonzini wrote: > > On 09/07/19 21:43, Marc-André Lureau wrote: > > With current podman, we have to use a uidmap trick in order to be able > > to rw-share the ccache directory with the container user. > > > > With a user 1000, the default mapping is: > > 1

Re: [Qemu-devel] [PATCH v25 1/7] target/avr: Add outward facing interfaces and core CPU logic

2019-07-10 Thread Igor Mammedov
On Wed, 10 Jul 2019 00:36:45 +0300 Michael Rolnik wrote: > From: Sarah Harris > > This includes: > - CPU data structures > - object model classes and functions > - migration functions > - GDB hooks > > Signed-off-by: Michael Rolnik > --- > gdb-xml/avr-cpu.xml| 49 > target/avr/cpu-

Re: [Qemu-devel] [PATCH 0/3] Add dbus-vmstate

2019-07-10 Thread Paolo Bonzini
On 08/07/19 18:04, Daniel P. Berrangé wrote: > The downside of using the bus daemon is that we have to spawn a new > instance of dbus-daemon for every QEMU VM that's running on the host, > which is yet more memory overhead for each VM & another process to > manage, and yet another thing to go wrong

Re: [Qemu-devel] [PATCH 0/3] Add dbus-vmstate

2019-07-10 Thread Daniel P . Berrangé
On Wed, Jul 10, 2019 at 10:53:10AM +0200, Paolo Bonzini wrote: > On 08/07/19 18:04, Daniel P. Berrangé wrote: > > The downside of using the bus daemon is that we have to spawn a new > > instance of dbus-daemon for every QEMU VM that's running on the host, > > which is yet more memory overhead for e

Re: [Qemu-devel] [PATCH 0/3] Add dbus-vmstate

2019-07-10 Thread Daniel P . Berrangé
On Tue, Jul 09, 2019 at 02:47:32PM +0400, Marc-André Lureau wrote: > Hi > > On Tue, Jul 9, 2019 at 1:02 PM Daniel P. Berrangé wrote: > > > > On Tue, Jul 09, 2019 at 12:26:38PM +0400, Marc-André Lureau wrote: > > > Hi > > > > > > On Mon, Jul 8, 2019 at 8:04 PM Daniel P. Berrangé > > > wrote: > >

Re: [Qemu-devel] [PATCH v1 5/5] gdbstub: revert to previous set_reg behaviour

2019-07-10 Thread Aleksandar Markovic
On Jul 5, 2019 6:08 PM, "Alex Bennée" wrote: > > The refactoring of handle_set_reg missed the fact we previously had > responded with an empty packet when we were not using XML based > protocols. This broke the fallback behaviour for architectures that > don't have registers defined in QEMU's gdb-

Re: [Qemu-devel] [PATCH] tcg/aarch64: Fix output of extract2 opcodes

2019-07-10 Thread Aleksandar Markovic
On Jul 9, 2019 8:56 PM, "Richard Henderson" wrote: > > The aarch64 argument ordering for the operands is big-endian, > whereas the tcg argument ordering is little-endian. Use REG0 > so that we honor the rZ constraints. > > Fixes: 464c2969d5d > Reported-by: Peter Maydell > Signed-off-by: Richard

[Qemu-devel] [RFC PATCH 1/2] qemu-thread: Add qemu_cond_timedwait

2019-07-10 Thread Yury Kotov
Signed-off-by: Yury Kotov --- include/qemu/thread.h| 12 util/qemu-thread-posix.c | 40 util/qemu-thread-win32.c | 16 3 files changed, 56 insertions(+), 12 deletions(-) diff --git a/include/qemu/thread.h b/include/qemu/t

[Qemu-devel] [RFC PATCH 0/2] High downtime with 95+ throttle pct

2019-07-10 Thread Yury Kotov
Hi, I wrote a test for migration auto converge and found out a strange thing: 1. Enable auto converge 2. Set max-bandwidth 1Gb/s 3. Set downtime-limit 1ms 4. Run standard test (just writes a byte per page) 5. Wait for converge 6. It's converged with 99% throttle percentage 7. The result downtime w

[Qemu-devel] [RFC PATCH 2/2] cpus: Fix throttling during vm_stop

2019-07-10 Thread Yury Kotov
Throttling thread sleeps in VCPU thread. For high throttle percentage this sleep is more than 10ms. E.g. for 60% - 15ms, for 99% - 990ms. vm_stop() kicks all VCPUs and waits for them. It's called at the end of migration and because of the long sleep the migration downtime might be more than 100ms e

Re: [Qemu-devel] [PATCH] qdev: Collect HMP handlers command handlers in qdev-monitor.c

2019-07-10 Thread Philippe Mathieu-Daudé
On 7/9/19 8:59 PM, Markus Armbruster wrote: > Move hmp_device_add(), hmp_device_del() from monitor/hmp-cmds.c to > qdev-monitor.c, where they are covered by MAINTAINERS section "QOM", > just like qapi/qdev.json. hmp_info_qtree() and hmp_info_qdm() are > already there. > > Signed-off-by: Markus Ar

Re: [Qemu-devel] [PATCH] configure: remove obsoleted $sparc_cpu variable

2019-07-10 Thread Philippe Mathieu-Daudé
On 7/10/19 1:43 AM, Carlo Marcelo Arenas Belón wrote: > 9b9c37c364 ("tcg-sparc: Assume v9 cpu always, i.e. force v8plus in > 32-bit mode.", 2012-09-21) removed the need for this variable and > most of the references to it, but this one. > > Remove defunct code, no effect or functionality change ex

Re: [Qemu-devel] [PATCH v1 5/5] gdbstub: revert to previous set_reg behaviour

2019-07-10 Thread Alex Bennée
Aleksandar Markovic writes: > On Jul 5, 2019 6:08 PM, "Alex Bennée" wrote: >> >> The refactoring of handle_set_reg missed the fact we previously had >> responded with an empty packet when we were not using XML based >> protocols. This broke the fallback behaviour for architectures that >> don'

Re: [Qemu-devel] [PATCH v1 5/5] gdbstub: revert to previous set_reg behaviour

2019-07-10 Thread Aleksandar Markovic
On Jul 10, 2019 11:30 AM, "Alex Bennée" wrote: > > > Aleksandar Markovic writes: > > > On Jul 5, 2019 6:08 PM, "Alex Bennée" wrote: > >> > >> The refactoring of handle_set_reg missed the fact we previously had > >> responded with an empty packet when we were not using XML based > >> protocols. T

Re: [Qemu-devel] [PATCH v2 2/5] tests/docker: add podman support

2019-07-10 Thread Paolo Bonzini
On 10/07/19 10:39, Marc-André Lureau wrote: >> Why not do this in docker.py (either as part of patch 1 or separately)? >> Also, can you document in a comment why this is not needed with docker? > > Doing it in docker.py would probably mean parsing and tweaking > arguments given to Docker.run(). Si

Re: [Qemu-devel] [PATCH] tcg/aarch64: Fix output of extract2 opcodes

2019-07-10 Thread Richard Henderson
On Wed, 10 Jul 2019 at 11:22, Aleksandar Markovic wrote: > On Jul 9, 2019 8:56 PM, "Richard Henderson" > wrote: > > > > The aarch64 argument ordering for the operands is big-endian, > > whereas the tcg argument ordering is little-endian. Use REG0 > > so that we honor the rZ constraints. > > > >

Re: [Qemu-devel] [PATCH 0/3] Add dbus-vmstate

2019-07-10 Thread Paolo Bonzini
On 10/07/19 11:03, Daniel P. Berrangé wrote: >> Would it be possible to make QEMU the broker? That is, how hard would it >> be to embed a minimal DBus broker (which only takes care of connecting >> servers >> and clients---stuff like launching servers would be completely out of scope)? > What wou

Re: [Qemu-devel] [RFC PATCH 0/2] High downtime with 95+ throttle pct

2019-07-10 Thread Dr. David Alan Gilbert
* Yury Kotov (yury-ko...@yandex-team.ru) wrote: > Hi, > > I wrote a test for migration auto converge and found out a strange thing: > 1. Enable auto converge > 2. Set max-bandwidth 1Gb/s > 3. Set downtime-limit 1ms > 4. Run standard test (just writes a byte per page) > 5. Wait for converge > 6. It

Re: [Qemu-devel] [PATCH] tcg/aarch64: Fix output of extract2 opcodes

2019-07-10 Thread Aleksandar Markovic
On Jul 10, 2019 11:48 AM, "Richard Henderson" wrote: > > On Wed, 10 Jul 2019 at 11:22, Aleksandar Markovic > wrote: > > On Jul 9, 2019 8:56 PM, "Richard Henderson" < richard.hender...@linaro.org> wrote: > > > > > > The aarch64 argument ordering for the operands is big-endian, > > > whereas the tc

Re: [Qemu-devel] [PATCH v25 5/7] target/avr: Add limited support for USART and 16 bit timer peripherals

2019-07-10 Thread Philippe Mathieu-Daudé
Hi Michael, Sarah. Sorry for reviewing this series that late. On 7/9/19 11:36 PM, Michael Rolnik wrote: > From: Sarah Harris > > These were designed to facilitate testing but should provide enough function > to be useful in other contexts. > Only a subset of the functions of each peripheral is

Re: [Qemu-devel] [PATCH 0/4] virtio: handle zoned backing devices

2019-07-10 Thread Paolo Bonzini
On 09/07/19 22:38, Dmitry Fomichev wrote: > Currently, attaching zoned block devices (i.e. storage devices > compliant to ZAC/ZBC standards) using several virtio methods doesn't > work - the zoned devices appear as regular block devices at the guest. > This may cause unexpected i/o errors and, pote

Re: [Qemu-devel] [PATCH v25 6/7] target/avr: Add example board configuration

2019-07-10 Thread Philippe Mathieu-Daudé
On 7/9/19 11:36 PM, Michael Rolnik wrote: > From: Sarah Harris > > A simple board setup that configures an AVR CPU to run a given firmware image. > This is all that's useful to implement without peripheral emulation as AVR > CPUs include a lot of on-board peripherals. Why not model a tiny exist

Re: [Qemu-devel] [PATCH v2 3/5] tests: specify the address family when checking bind

2019-07-10 Thread Philippe Mathieu-Daudé
On 7/9/19 9:43 PM, Marc-André Lureau wrote: > getaddrinfo() may succeed with PF_UNSPEC, but fail when more specific. > > (this allows to skip some tests that would fail under podman) > > Signed-off-by: Marc-André Lureau > --- > tests/socket-helpers.c | 17 + > tests/socket-helpe

Re: [Qemu-devel] [RFC PATCH 0/2] High downtime with 95+ throttle pct

2019-07-10 Thread Yury Kotov
10.07.2019, 12:57, "Dr. David Alan Gilbert" : > * Yury Kotov (yury-ko...@yandex-team.ru) wrote: >>  Hi, >> >>  I wrote a test for migration auto converge and found out a strange thing: >>  1. Enable auto converge >>  2. Set max-bandwidth 1Gb/s >>  3. Set downtime-limit 1ms >>  4. Run standard test

Re: [Qemu-devel] [PATCH RFC] gpio: Add Virtual Aggregator GPIO Driver

2019-07-10 Thread Geert Uytterhoeven
Hi Phil, On Wed, Jul 10, 2019 at 4:00 AM Phil Reid wrote: > On 6/07/2019 00:05, Geert Uytterhoeven wrote: > > GPIO controllers are exported to userspace using /dev/gpiochip* > > character devices. Access control to these devices is provided by > > standard UNIX file system permissions, on an all

Re: [Qemu-devel] [PATCH] tcg/aarch64: Fix output of extract2 opcodes

2019-07-10 Thread Philippe Mathieu-Daudé
On 7/9/19 8:48 PM, Richard Henderson wrote: > The aarch64 argument ordering for the operands is big-endian, > whereas the tcg argument ordering is little-endian. Use REG0 > so that we honor the rZ constraints. > > Fixes: 464c2969d5d > Reported-by: Peter Maydell > Signed-off-by: Richard Henderson

[Qemu-devel] [PULL 2/4] tests/tcg: fix diff-out pass to properly report failure

2019-07-10 Thread Alex Bennée
A side effect of piping the output to head is squash the exit status of the diff command. Fix this by only doing the pipe if the diff failed and then ensuring the status is non-zero. Signed-off-by: Alex Bennée diff --git a/tests/tcg/Makefile b/tests/tcg/Makefile index 6fa63cc8d5..9f56768624 1006

[Qemu-devel] [PULL 3/4] gdbstub: add some notes to the header comment

2019-07-10 Thread Alex Bennée
Add a link to the remote protocol spec and an SPDX tag. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé diff --git a/gdbstub.c b/gdbstub.c index 687c02e598..8363683852 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1,6 +1,10 @@ /* * gdb server st

[Qemu-devel] [PULL 4/4] gdbstub: revert to previous set_reg behaviour

2019-07-10 Thread Alex Bennée
The refactoring of handle_set_reg missed the fact we previously had responded with an empty packet when we were not using XML based protocols. This broke the fallback behaviour for architectures that don't have registers defined in QEMU's gdb-xml directory. Revert to the previous behaviour and cle

[Qemu-devel] [PULL 1/4] tests/tcg: fix up test-i386-fprem.ref generation

2019-07-10 Thread Alex Bennée
We never shipped the reference data in the source tree because it's quite big (64M). As a result the only option is to generate it locally. Although we have a rule to generate the reference file we missed the dependency and location changes, probably because it's only run for SLOW test runs. Signe

[Qemu-devel] [PULL for 4.1 0/4] testing and gdbstub fixes

2019-07-10 Thread Alex Bennée
The following changes since commit 6df2cdf44a82426f7a59dcb03f0dd2181ed7fdfa: Update version for v4.1.0-rc0 release (2019-07-09 17:21:53 +0100) are available in the Git repository at: https://github.com/stsquad/qemu.git tags/pull-testing-and-gdbstub-100719-1 for you to fetch changes up to 94

Re: [Qemu-devel] [PATCH v25 6/7] target/avr: Add example board configuration

2019-07-10 Thread Michael Rolnik
Hi Philippe. My intension was to implement CPU only. I was not interested in modelling boards, I hoped other people would do it. that's why I stopped two years ago and did not proceed as there was no interest. however, it seems there is an interest as Sarah added some peripheral and fixed some bug

Re: [Qemu-devel] [PATCH v1 2/5] tests/tcg: fix up test-i386-fprem.ref generation

2019-07-10 Thread Philippe Mathieu-Daudé
On 7/5/19 6:04 PM, Alex Bennée wrote: > We never shipped the reference data in the source tree because it was > quite big (64M). As a result the only option is to generate it Can we fetch it (with hash verification) or store it compressed? $ du -ch pc-bios/edk2-*bz2 1.2Mpc-bios/edk2-aarch64-c

Re: [Qemu-devel] [PATCH] tcg/aarch64: Fix output of extract2 opcodes

2019-07-10 Thread Alex Bennée
Richard Henderson writes: > The aarch64 argument ordering for the operands is big-endian, > whereas the tcg argument ordering is little-endian. Use REG0 > so that we honor the rZ constraints. > > Fixes: 464c2969d5d > Reported-by: Peter Maydell > Signed-off-by: Richard Henderson Reviewed-by:

Re: [Qemu-devel] [PATCH v6 15/16] tcg/ppc: Update vector support to v2.07

2019-07-10 Thread Aleksandar Markovic
On Jul 2, 2019 4:26 PM, "Richard Henderson" wrote: > > On 7/1/19 1:41 PM, Aleksandar Markovic wrote: > > If we go back to my example, it appears to me that doubleword > > integer max/min Altivec instruction do not depend on VSX in any > > way, or, at least, I did not find anything in Altivec docs

Re: [Qemu-devel] [PATCH 0/4] virtio: handle zoned backing devices

2019-07-10 Thread Kevin Wolf
Am 10.07.2019 um 12:09 hat Paolo Bonzini geschrieben: > On 09/07/19 22:38, Dmitry Fomichev wrote: > > Currently, attaching zoned block devices (i.e. storage devices > > compliant to ZAC/ZBC standards) using several virtio methods doesn't > > work - the zoned devices appear as regular block devices

Re: [Qemu-devel] [RFC v1 03/18] hw/pci: introduce PCIPASIDOps to PCIDevice

2019-07-10 Thread Liu, Yi L
> From: Peter Xu [mailto:zh...@redhat.com] > Sent: Tuesday, July 9, 2019 10:12 AM > To: Liu, Yi L > Subject: Re: [RFC v1 03/18] hw/pci: introduce PCIPASIDOps to PCIDevice > > On Fri, Jul 05, 2019 at 07:01:36PM +0800, Liu Yi L wrote: > > +void pci_setup_pasid_ops(PCIDevice *dev, PCIPASIDOps *ops)

Re: [Qemu-devel] [PATCH v1 2/5] tests/tcg: fix up test-i386-fprem.ref generation

2019-07-10 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 7/5/19 6:04 PM, Alex Bennée wrote: >> We never shipped the reference data in the source tree because it was >> quite big (64M). As a result the only option is to generate it > > Can we fetch it (with hash verification) or store it compressed? Seems like a lo

Re: [Qemu-devel] [PATCH 0/4] virtio: handle zoned backing devices

2019-07-10 Thread Paolo Bonzini
On 10/07/19 13:02, Kevin Wolf wrote: > Hm... Actually, file-posix implements .bdrv_check_perm and could just > refuse attaching a parent there if it doesn't request a specific > permission like BLK_PERM_SUPPORT_ZONED. That should give us the > whitelist semantics through existing infrastructure. I

Re: [Qemu-devel] [RFC v1 06/18] intel_iommu: support virtual command emulation and pasid request

2019-07-10 Thread Liu, Yi L
> From: Peter Xu [mailto:zh...@redhat.com] > Sent: Tuesday, July 9, 2019 11:19 AM > Subject: Re: [RFC v1 06/18] intel_iommu: support virtual command emulation and > pasid request > > On Fri, Jul 05, 2019 at 07:01:39PM +0800, Liu Yi L wrote: > > This patch adds virtual command support to Intel vIOM

Re: [Qemu-devel] [RFC v1 04/18] intel_iommu: add "sm_model" option

2019-07-10 Thread Liu, Yi L
> From: Peter Xu [mailto:zh...@redhat.com] > Sent: Tuesday, July 9, 2019 10:16 AM > To: Liu, Yi L > Subject: Re: [RFC v1 04/18] intel_iommu: add "sm_model" option > > On Fri, Jul 05, 2019 at 07:01:37PM +0800, Liu Yi L wrote: > > Intel VT-d 3.0 introduces scalable mode, and it has a bunch of > > c

Re: [Qemu-devel] [RFC v1 05/18] vfio/pci: add pasid alloc/free implementation

2019-07-10 Thread Liu, Yi L
> From: Peter Xu [mailto:zh...@redhat.com] > Sent: Tuesday, July 9, 2019 10:24 AM > To: Liu, Yi L > Subject: Re: [RFC v1 05/18] vfio/pci: add pasid alloc/free implementation > > On Fri, Jul 05, 2019 at 07:01:38PM +0800, Liu Yi L wrote: > > This patch adds vfio implementation PCIPASIDOps.alloc_pas

Re: [Qemu-devel] [RFC v1 07/18] hw/pci: add pci_device_bind/unbind_gpasid

2019-07-10 Thread Liu, Yi L
Hi Eric, > From: Auger Eric [mailto:eric.au...@redhat.com] > Sent: Tuesday, July 9, 2019 4:38 PM > To: Liu, Yi L ; qemu-devel@nongnu.org; m...@redhat.com; > Subject: Re: [RFC v1 07/18] hw/pci: add pci_device_bind/unbind_gpasid > > Hi Liu, > > On 7/5/19 1:01 PM, Liu Yi L wrote: > > This patch add

Re: [Qemu-devel] [RFC v1 02/18] linux-headers: import vfio.h from kernel

2019-07-10 Thread Liu, Yi L
> From: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] On Behalf > Of Peter Xu > Sent: Tuesday, July 9, 2019 9:58 AM > To: Liu, Yi L > Subject: Re: [RFC v1 02/18] linux-headers: import vfio.h from kernel > > On Fri, Jul 05, 2019 at 07:01:35PM +0800, Liu Yi L wrote: > > This patch im

Re: [Qemu-devel] [RFC v1 08/18] vfio/pci: add vfio bind/unbind_gpasid implementation

2019-07-10 Thread Liu, Yi L
> From: Auger Eric [mailto:eric.au...@redhat.com] > Sent: Tuesday, July 9, 2019 4:38 PM > Subject: Re: [RFC v1 08/18] vfio/pci: add vfio bind/unbind_gpasid > implementation > > Hi Liu, > > On 7/5/19 1:01 PM, Liu Yi L wrote: > > This patch adds vfio implementation PCIPASIDOps.bind_gpasid/unbind_p

Re: [Qemu-devel] [RFC v1 02/18] linux-headers: import vfio.h from kernel

2019-07-10 Thread Liu, Yi L
> From: Auger Eric [mailto:eric.au...@redhat.com] > Sent: Tuesday, July 9, 2019 4:38 PM > To: Peter Xu ; Liu, Yi L > Subject: Re: [RFC v1 02/18] linux-headers: import vfio.h from kernel > > Hi Liu, > > On 7/9/19 3:58 AM, Peter Xu wrote: > > On Fri, Jul 05, 2019 at 07:01:35PM +0800, Liu Yi L wrot

Re: [Qemu-devel] [PATCH for-4.1] pl031: Correctly migrate state when using -rtc clock=host

2019-07-10 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > The PL031 RTC tracks the difference between the guest RTC > and the host RTC using a tick_offset field. For migration, > however, we currently always migrate the offset between > the guest and the vm_clock, even if the RTC clock is not > the same

Re: [Qemu-devel] [PATCH for-4.1] tcg: Fix constant folding of INDEX_op_extract2_i32

2019-07-10 Thread Christophe Lyon
On Tue, 9 Jul 2019 at 15:02, Alex Bennée wrote: > > > Richard Henderson writes: > > > On a 64-bit host, discard any replications of the 32-bit > > sign bit when performing the shift and merge. > > > > Fixes: https://bugs.launchpad.net/bugs/1834496 > > Signed-off-by: Richard Henderson > > Reviewe

[Qemu-devel] Can not relocate APIC registers address from 0xFEE00000 to self-defined physical addr

2019-07-10 Thread ddm
hi guys, I wrote a Small OS (based on linux0.11) support SMP, and it can run well on bochs, Now i want to migrate it to Qemu, i found that when i use wrmsr command to relocate the APIC regsiters addr to a new physical address, it can not work, i can not initial APIC timer to trigger timer in

Re: [Qemu-devel] [PATCH RFC] gpio: Add Virtual Aggregator GPIO Driver

2019-07-10 Thread Phil Reid
G'day Geert, On 6/07/2019 00:05, Geert Uytterhoeven wrote: GPIO controllers are exported to userspace using /dev/gpiochip* character devices. Access control to these devices is provided by standard UNIX file system permissions, on an all-or-nothing basis: either a GPIO controller is accessible

Re: [Qemu-devel] RFC: Why does target/m68k RTE insn. use gen_exception

2019-07-10 Thread Lucien Murray-Pitts
Hi Richard, I am so sorry, I was too naive when you suggested this and I misunderstood the meaning of what you were telling me. After spending most nights digging through the RTE/Exception process for the M68000 I now actually get what you were trying to tell me and its simply genius - I hope it

Re: [Qemu-devel] [PATCH v2 1/1] raw-posix.c - use max transfer length / max segement count only for SCSI passthrough

2019-07-10 Thread Maxim Levitsky
On Thu, 2019-07-04 at 15:43 +0300, Maxim Levitsky wrote: > Regular kernel block devices (/dev/sda*, /dev/nvme*, etc) don't have > max segment size/max segment count hardware requirements exposed > to the userspace, but rather the kernel block layer > takes care to split the incoming requests that >

[Qemu-devel] [Bug 1834496] Re: Regressions on arm target with some GCC tests

2019-07-10 Thread Alex Bennée
Fixed by: Subject: [PATCH for-4.1] tcg: Fix constant folding of INDEX_op_extract2_i32 Date: Tue, 9 Jul 2019 14:19:00 +0200 Message-Id: <20190709121900.25644-1-richard.hender...@linaro.org> ** Changed in: qemu Status: New => In Progress -- You received this bug notification because you

[Qemu-devel] [PATCH] virtio-balloon: fix QEMU 4.0 config size migration incompatibility

2019-07-10 Thread Stefan Hajnoczi
The virtio-balloon config size changed in QEMU 4.0 even for existing machine types. Migration from QEMU 3.1 to 4.0 can fail in some circumstances with the following error: qemu-system-x86_64: get_pci_config_device: Bad config data: i=0x10 read: a1 device: 1 cmask: ff wmask: c0 w1cmask:0 This

Re: [Qemu-devel] balloon config change seems to break live migration from 3.0.1 to 4.0

2019-07-10 Thread Stefan Hajnoczi
On Tue, Jul 9, 2019 at 4:23 PM Dr. David Alan Gilbert wrote: > * Wolfgang Bumiller (w.bumil...@proxmox.com) wrote: > > On Thu, Jun 27, 2019 at 03:12:52PM +0200, Wolfgang Bumiller wrote: > > With this changing compatibility options I'm not sure if this is a > > desired upstream change since 4.0 is

Re: [Qemu-devel] [PATCH v4 09/18] block/dirty-bitmap: add bdrv_dirty_bitmap_merge_internal

2019-07-10 Thread Max Reitz
On 10.07.19 01:25, John Snow wrote: > I'm surprised it didn't come up sooner, but sometimes we have a +busy > bitmap as a source. This is dangerous from the QMP API, but if we are > the owner that marked the bitmap busy, it's safe to merge it using it as > a read only source. > > It is not safe in

Re: [Qemu-devel] [PATCH v4 11/18] block/backup: upgrade copy_bitmap to BdrvDirtyBitmap

2019-07-10 Thread Max Reitz
On 10.07.19 01:25, John Snow wrote: > This simplifies some interface matters; namely the initialization and > (later) merging the manifest back into the sync_bitmap if it was > provided. > > Signed-off-by: John Snow > --- > block/backup.c | 81 ++ >

Re: [Qemu-devel] [PULL 22/25] target/i386: kvm: Add nested migration blocker only when kernel lacks required capabilities

2019-07-10 Thread Paolo Bonzini
On 08/07/19 20:31, Jan Kiszka wrote: >> -if (cpu_has_nested_virt(env) && !env->nested_state) { >> +if (kvm_enabled() && cpu_has_vmx(env) && !env->nested_state) { >> error_report("Guest enabled nested virtualization but kernel " >> "does not support saving of nested

Re: [Qemu-devel] [PATCH v4 17/18] iotests: add test 257 for bitmap-mode backups

2019-07-10 Thread Max Reitz
On 10.07.19 01:25, John Snow wrote: > Signed-off-by: John Snow > --- > tests/qemu-iotests/257 | 416 +++ > tests/qemu-iotests/257.out | 2247 > tests/qemu-iotests/group |1 + > 3 files changed, 2664 insertions(+) > create mode 100755 tests/qemu

Re: [Qemu-devel] [PATCH v4 00/18] bitmaps: introduce 'bitmap' sync mode

2019-07-10 Thread Max Reitz
On 10.07.19 01:25, John Snow wrote: > This series adds a new "BITMAP" sync mode that is meant to replace the > existing "INCREMENTAL" sync mode. So who’s going to take it? :-) get_maintainer.pl says I’m responsible for 14/18 patches, and you are for 9/18. But you did prefix the title with “bitma

[Qemu-devel] [PATCH] nvme: Set number of queues later in nvme_init()

2019-07-10 Thread Michal Privoznik
When creating the admin queue in nvme_init() the variable that holds the number of queues created is modified before actual queue creation. This is a problem because if creating the queue fails then the variable is left in inconsistent state. This was actually observed when I tried to hotplug a nvm

Re: [Qemu-devel] [PATCH 1/8] iotests/257: add Pattern class

2019-07-10 Thread Max Reitz
On 10.07.19 03:05, John Snow wrote: > Just kidding, this is easier to manage with a full class instead of a > namedtuple. > > Signed-off-by: John Snow > --- > tests/qemu-iotests/257 | 58 +++--- > 1 file changed, 32 insertions(+), 26 deletions(-) Reviewed-by:

[Qemu-devel] [Bug 1836078] Re: Regressions on arm-linux-gnueabihf target with some GCC tests

2019-07-10 Thread Alex Bennée
** Tags added: arm testcase ** Changed in: qemu Status: New => In Progress ** Changed in: qemu Assignee: (unassigned) => Alex Bennée (ajbennee) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/b

[Qemu-devel] [Bug 1836078] [NEW] Regressions on arm-linux-gnueabihf target with some GCC tests

2019-07-10 Thread Christophe Lyon
Public bug reported: Hi, After trying qemu master: commit 474f3938d79ab36b9231c9ad3b5a9314c2aeacde Merge: 68d7ff0 14f5d87 Author: Peter Maydell Date: Fri Jun 21 15:40:50 2019 +0100 even with the fix for https://bugs.launchpad.net/qemu/+bug/1834496, I've noticed several regressions compared to q

Re: [Qemu-devel] [PATCH] virtio-balloon: fix QEMU 4.0 config size migration incompatibility

2019-07-10 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@redhat.com) wrote: > The virtio-balloon config size changed in QEMU 4.0 even for existing > machine types. Migration from QEMU 3.1 to 4.0 can fail in some > circumstances with the following error: > > qemu-system-x86_64: get_pci_config_device: Bad config data: i=0x10

Re: [Qemu-devel] [PATCH v3] block/rbd: implement .bdrv_get_allocated_file_size callback

2019-07-10 Thread Stefano Garzarella
On Tue, Jul 09, 2019 at 09:42:14PM -0400, Jason Dillaman wrote: > On Tue, Jul 9, 2019 at 11:32 AM Max Reitz wrote: > > On 09.07.19 15:09, Stefano Garzarella wrote: > > > > > > Max, Jason, thanks for the details! > > > > > > If you agree, I'll try to implement something similar, iterating on all >

Re: [Qemu-devel] [PATCH v1 4/5] gdbstub: add some notes to the header comment

2019-07-10 Thread Alex Bennée
Richard Henderson writes: > On 7/5/19 6:04 PM, Alex Bennée wrote: >> Add a link to the remote protocol spec and an SPDX tag. >> >> Signed-off-by: Alex Bennée >> --- >> gdbstub.c | 6 ++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/gdbstub.c b/gdbstub.c >> index 8618e34311..ea3349

Re: [Qemu-devel] [PATCH] nvme: Set number of queues later in nvme_init()

2019-07-10 Thread Philippe Mathieu-Daudé
On 7/10/19 4:57 PM, Michal Privoznik wrote: > When creating the admin queue in nvme_init() the variable that > holds the number of queues created is modified before actual > queue creation. This is a problem because if creating the queue > fails then the variable is left in inconsistent state. This

Re: [Qemu-devel] [PATCH] tcg/aarch64: Fix output of extract2 opcodes

2019-07-10 Thread Peter Maydell
On Wed, 10 Jul 2019 at 10:22, Aleksandar Markovic wrote: > The commit message looks more like a list of some random items > than logical explanation of the code change. Improve it. Can you be less combative in your review comments, please? Providing constructive and specific suggestions for the i

Re: [Qemu-devel] Can not relocate APIC registers address from 0xFEE00000 to self-defined physical addr

2019-07-10 Thread Philippe Mathieu-Daudé
Cc'ing x86 ppl On 7/10/19 9:56 AM, ddm wrote: > hi guys, > > > I wrote a Small OS (based on linux0.11) support SMP, and it can run well on > bochs, > Now i want to migrate it to Qemu, i found that when i use wrmsr command to > relocate the APIC regsiters addr to a new physical address, > it

Re: [Qemu-devel] [PATCH 2/8] iotests/257: add EmulatedBitmap class

2019-07-10 Thread Max Reitz
On 10.07.19 03:05, John Snow wrote: > Represent a bitmap with an object that we can mark and clear bits in. > This makes it easier to manage partial writes when we don't write a > full group's worth of patterns before an error. > > Signed-off-by: John Snow > --- > tests/qemu-iotests/257 | 125 ++

[Qemu-devel] [Bug 1836078] Re: Regressions on arm-linux-gnueabihf target with some GCC tests

2019-07-10 Thread Alex Bennée
I bisected the failure for all but the IEEE6 test to: commit 602f6e42cfbfe9278be34e9b91d2ceb695837e02 Author: Peter Maydell Date: Thu Feb 28 10:55:16 2019 + target/arm: Use MVFR1 feature bits to gate A32/T32 FP16 instructions Instead of gating the A32/T32 FP16 conversion instructi

Re: [Qemu-devel] Can not relocate APIC registers address from 0xFEE00000 to self-defined physical addr

2019-07-10 Thread Paolo Bonzini
On 10/07/19 17:41, Philippe Mathieu-Daudé wrote: > > I wrote a Small OS (based on linux0.11) support SMP, and it can run > well on bochs, Now i want to migrate it to Qemu, i found that when i > use wrmsr command to relocate the APIC regsiters addr to a new > physical address, it can not work, i ca

Re: [Qemu-devel] [PULL 22/25] target/i386: kvm: Add nested migration blocker only when kernel lacks required capabilities

2019-07-10 Thread Jan Kiszka
On 10.07.19 16:40, Paolo Bonzini wrote: > On 08/07/19 20:31, Jan Kiszka wrote: >>> -if (cpu_has_nested_virt(env) && !env->nested_state) { >>> +if (kvm_enabled() && cpu_has_vmx(env) && !env->nested_state) { >>> error_report("Guest enabled nested virtualization but kernel " >>>

Re: [Qemu-devel] [PATCH 3/8] iotests/257: Refactor backup helpers

2019-07-10 Thread Max Reitz
On 10.07.19 03:05, John Snow wrote: > This test needs support for non-bitmap backups and missing or > unspecified bitmap sync modes, so rewrite the helpers to be a little > more generic. > > Signed-off-by: John Snow > --- > tests/qemu-iotests/257 | 46 + > tests/qemu-iotests/257.out

[Qemu-devel] [RFC PATCH v2 0/8] Proof of concept for Meson integration

2019-07-10 Thread Paolo Bonzini
The main change from v1 is that libqemuutil.a, and with it the tracetool and QAPI generated code, is now generated with meson. This shows how to do some "computations" in meson.build using its array and dictionary data structures. It is also a basic usage of the sourceset module for conditional c

[Qemu-devel] [PATCH 2/8] configure: set $PYTHON to a full path

2019-07-10 Thread Paolo Bonzini
This will make it possible to replace it in a shebang line. Signed-off-by: Paolo Bonzini --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index b0b8bdd..49cb3f3 100755 --- a/configure +++ b/configure @@ -918,7 +918,7 @@ for binary in "${PYTH

[Qemu-devel] [PATCH 8/8] rdmacm-mux: convert to Meson

2019-07-10 Thread Paolo Bonzini
We can use config-host.mak to decide whether the tool has to be built, apart from that the conversion is straightforward. Signed-off-by: Paolo Bonzini --- .gitignore | 1 + Makefile | 5 - Makefile.objs| 1 - contrib/rdmacm-mu

[Qemu-devel] [PATCH 6/8] vhost-user-blk: convert to Meson

2019-07-10 Thread Paolo Bonzini
The GLib pkg-config information is extracted from config-host.mak and used to link vhost-user-blk. Signed-off-by: Paolo Bonzini --- .gitignore | 2 +- Makefile | 3 --- Makefile.objs| 1 - configure

[Qemu-devel] [PATCH 5/8] libvhost-user: convert to Meson

2019-07-10 Thread Paolo Bonzini
Since libqemuutil.a has been converted to Meson, the conversion is straightforward. Signed-off-by: Paolo Bonzini --- Makefile| 14 -- Makefile.objs | 1 - contrib/libvhost-user/Makefile.objs | 1 - contrib/libvhost-user/meson.build

Re: [Qemu-devel] [PATCH 4/8] block/backup: hoist bitmap check into QMP interface

2019-07-10 Thread Max Reitz
On 10.07.19 03:05, John Snow wrote: > This is nicer to do in the unified QMP interface that we have now, > because it lets us use the right terminology back at the user. > > Signed-off-by: John Snow > --- > block/backup.c | 13 - > blockdev.c | 10 ++ > 2 files changed, 1

[Qemu-devel] [PATCH 1/8] configure: do not include $(...) variables in config-host.mak

2019-07-10 Thread Paolo Bonzini
This ensures that Meson will be able to reuse the results of the tests that are performed in the configure script. Signed-off-by: Paolo Bonzini --- configure | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/configure b/configure index 5c79145

[Qemu-devel] [PATCH 7/8] vhost-user-scsi: convert to Meson

2019-07-10 Thread Paolo Bonzini
The libiscsi pkg-config information is extracted from config-host.mak and used to link vhost-user-blk. Signed-off-by: Paolo Bonzini --- .gitignore| 2 +- Makefile | 3 --- Makefile.objs | 3 --- contrib/vhost-user-s

[Qemu-devel] [PATCH 4/8] convert libqemuutil to meson

2019-07-10 Thread Paolo Bonzini
This shows how to do some "computations" in meson.build using its array and dictionary data structures, and also a basic usage of the sourceset module for conditional compilation. Overall the look of the meson.build code is quite good, however Meson doesn't enjoy the same flexibility we have with

  1   2   3   >