[Qemu-devel] [PATCH 0/3] Add dbus-vmstate

2019-07-08 Thread Marc-André Lureau
Hi, With external processes or helpers participating to the VM support, it becomes necessary to handle their migration. Various options exist to transfer their state: 1) as the VM memory, RAM or devices (we could say that's how vhost-user devices can be handled today, they are expected to re

[Qemu-devel] [PATCH 1/3] qemu-file: move qemu_{get, put}_counted_string() declarations

2019-07-08 Thread Marc-André Lureau
Move migration helpers for strings under include/, so they can be used outside of migration/ Signed-off-by: Marc-André Lureau --- include/migration/qemu-file-types.h | 4 migration/qemu-file.h | 4 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/mig

[Qemu-devel] [PATCH 2/3] tests: add qtest_set_exit_status()

2019-07-08 Thread Marc-André Lureau
Modify the behaviour of qtest_quit() to check against the expected exit status value. The default remains 0. Signed-off-by: Marc-André Lureau --- tests/libqtest.c | 41 ++--- tests/libqtest.h | 9 + 2 files changed, 31 insertions(+), 19 deletions(-)

[Qemu-devel] [PATCH 3/3] Add dbus-vmstate object

2019-07-08 Thread Marc-André Lureau
When instanciated, this object will connect to the given D-Bus bus. During migration, it will take the data from org.qemu.VMState1 instances. See documentation for further details. Signed-off-by: Marc-André Lureau --- MAINTAINERS | 6 + backends/Makefile.objs| 4 +

[Qemu-devel] Use Case for Qemu BT

2019-07-08 Thread Sebastian Audet
So...this is not really a use-case per-say as it is actually a thing I would like to do but can't at present... Win 10 is lacking an ad2p sink and this means if I'm using it to play a windows-only game and want to stream from e.g. my phone to my computer, I can't (natively). Enter Linux, which mos

[Qemu-devel] [PATCH] Fix Guest VM crash due to iSCSI Sense Key error

2019-07-08 Thread shaju . abraham
From: Shaju Abraham During the IDE DMA transfer for a ISCSI target,when libiscsi encounters a SENSE KEY error, it sets the task->sense to the value "COMMAND ABORTED". The function iscsi_translate_sense() later translaters this error to -ECANCELED and this value is passed to the callback functio

Re: [Qemu-devel] [PATCH 0/3] Add dbus-vmstate

2019-07-08 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190708072437.3339-1-marcandre.lur...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/b

Re: [Qemu-devel] [PATCH 1/3] qemu-file: move qemu_{get, put}_counted_string() declarations

2019-07-08 Thread Juan Quintela
Marc-André Lureau wrote: > Move migration helpers for strings under include/, so they can be used > outside of migration/ > > Signed-off-by: Marc-André Lureau Reviewed-by: Juan Quintela Not that I am the biggest fan of exporting it, but we don't have anything better to offer.

Re: [Qemu-devel] [PATCH 2/3] tests: add qtest_set_exit_status()

2019-07-08 Thread Juan Quintela
Marc-André Lureau wrote: > Modify the behaviour of qtest_quit() to check against the expected > exit status value. The default remains 0. > > Signed-off-by: Marc-André Lureau Reviewed-by: Juan Quintela But I would like a review from anyone from qtest.

Re: [Qemu-devel] Handling of fall through code (was: [PATCH v8 04/87] target/mips: Mark switch fallthroughs with interpretable comments

2019-07-08 Thread Aleksandar Markovic
On Jul 7, 2019 10:26 PM, "Stefan Weil" wrote: > > Am 13.08.18 um 19:52 schrieb Aleksandar Markovic: > >> From: Aleksandar Markovic >> >> Mark switch fallthroughs with comments, in cases fallthroughs >> are intentional. > > > > This is a general problem all over the QEMU code. I usually compile wi

Re: [Qemu-devel] [PATCH 3/3] Add dbus-vmstate object

2019-07-08 Thread Juan Quintela
Marc-André Lureau wrote: > When instanciated, this object will connect to the given D-Bus > bus. During migration, it will take the data from org.qemu.VMState1 > instances. > > See documentation for further details. > > Signed-off-by: Marc-André Lureau > diff --git a/backends/Makefile.objs b/ba

Re: [Qemu-devel] Handling of fall through code (was: [PATCH v8 04/87] target/mips: Mark switch fallthroughs with interpretable comments

2019-07-08 Thread Peter Maydell
On Sun, 7 Jul 2019 at 21:26, Stefan Weil wrote: > This is a general problem all over the QEMU code. I usually compile with > nearly all warnings enabled and get now lots of errors with the latest > code and after updating to gcc-8.3.0 (Debian buster). It should be > reproducible by enabling -Werro

Re: [Qemu-devel] [PULL v2 0/2] Trivial branch patches

2019-07-08 Thread Peter Maydell
On Fri, 5 Jul 2019 at 16:16, Peter Maydell wrote: > > On Fri, 5 Jul 2019 at 16:10, Laurent Vivier wrote: > > > > Le 03/07/2019 à 20:46, no-re...@patchew.org a écrit : > > > Patchew URL: > > > https://patchew.org/QEMU/20190703152513.29166-1-laur...@vivier.eu/ > > > > > ... > > > =

Re: [Qemu-devel] [PATCH v5 6/8] hmat acpi: Build Memory Subsystem Address Range Structure(s) in ACPI HMAT

2019-07-08 Thread Igor Mammedov
On Tue, 2 Jul 2019 16:50:24 +0800 Tao Xu wrote: > On 7/1/2019 7:25 PM, Igor Mammedov wrote: > > On Fri, 14 Jun 2019 23:56:24 +0800 > > Tao Xu wrote: > > > ... > >> @@ -2710,6 +2711,8 @@ void acpi_build(AcpiBuildTables *tables, > >> MachineState *machine) > >> acpi_add_table(tab

[Qemu-devel] [PATCH v3 1/2] tests: acpi: do not require IASL for dumping AML blobs

2019-07-08 Thread Igor Mammedov
IASL isn't needed when dumping ACPI tables from guest for rebuild purposes. So move this part out from IASL branch. Makes rebuild-expected-aml.sh work without IASL installed on host. Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Eric Auger --- tests/bios-tables

[Qemu-devel] [PATCH v3 2/2] tests: acpi: do not skip tests when IASL is not installed

2019-07-08 Thread Igor Mammedov
tests do binary comparision so we can check tables without IASL. Move IASL condition right before decompilation step and skip it if IASL is not installed. Signed-off-by: Igor Mammedov Reviewed-by: Eric Auger Reviewed-by: Philippe Mathieu-Daudé --- v2: - fix typo in commit message Eric Aug

[Qemu-devel] [PATCH v3 0/2] tests: acpi: improve tests reproducability

2019-07-08 Thread Igor Mammedov
ChangeLog since v1: * fixup commit message in 2/2 * pickup Reviewed-bys and repost as v3 series should help to make tests more reproducable and not depend on IASL being installed. IASL will be required only is user needs to get textual diff of mismatching files. Igor Mammedov (2): tests: a

Re: [Qemu-devel] [PULL v6 00/42] Machine and x86 queue, 2019-07-05

2019-07-08 Thread Peter Maydell
On Fri, 5 Jul 2019 at 23:15, Eduardo Habkost wrote: > > Changes v5 -> v6: > * Rebase and solve conflicts with other pull requests > (for the 4th time) > * Included Cascadelake-Server-v2 update > > Changes v4 -> v5: > * Rebase and solve conflicts with commit 374f63f6810a ("Merge remote-tracking >

[Qemu-devel] [PATCH v2 3/3] qapi: make block histogram interface common

2019-07-08 Thread zhenwei pi
Modify command 'block-latency-histogram-set' to 'block-histogram-set' and modify struct 'BlockLatencyHistogramInfo' to struct 'BlockHistogramInfo', this makes block histogram interface common to use. Currently 'BlockHistogramType' supports 'latency', it works as same as the old command 'block-late

[Qemu-devel] [PATCH v2 1/3] block/accounting: rename struct BlockLatencyHistogram

2019-07-08 Thread zhenwei pi
Rename struct BlockLatencyHistogram to BlockHistogram, and rename related functions. Make this struct and functions be common, they can be used widely. Signed-off-by: zhenwei pi Reviewed-by: Vladimir Sementsov-Ogievskiy --- block/accounting.c | 44 +++

Re: [Qemu-devel] [RFC PATCH-for-4.2] tracing: Allow to tune tracing options via the environment

2019-07-08 Thread Daniel P . Berrangé
On Sat, Jul 06, 2019 at 06:02:18AM +0200, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > > > On 7/5/19 3:19 PM, Markus Armbruster wrote: > >> Philippe Mathieu-Daudé writes: > >>> On 7/5/19 10:07 AM, Stefan Hajnoczi wrote: > On Thu, Jul 04, 2019 at 11:28:37AM +0100, Daniel P. Be

[Qemu-devel] [PATCH v2 0/3] Add block size histogram qapi interface

2019-07-08 Thread zhenwei pi
Modify command 'block-latency-histogram-set' to make block histogram interface common to use. And support block size histogram. Thanks to Eric Blake&Vladimir Sementsov-Ogievskiy for the suggestions. This command has been tested for half year on QEMU-2.12, and we found that 3K+ virtual machines wri

Re: [Qemu-devel] [PATCH 0/3] Add dbus-vmstate

2019-07-08 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190708072437.3339-1-marcandre.lur...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/b

[Qemu-devel] [PATCH v2 2/3] block/accounting: introduce block size histogram

2019-07-08 Thread zhenwei pi
Introduce block size histogram statics for block devices. For read/write/flush operation type, the block size region [0, +inf) is divided into subregions by several points. It works like block latency histogram. Signed-off-by: zhenwei pi Reviewed-by: Vladimir Sementsov-Ogievskiy --- block/acco

Re: [Qemu-devel] [RFC v2 0/2] Add live migration support in the PVRDMA device

2019-07-08 Thread Daniel P . Berrangé
On Sat, Jul 06, 2019 at 10:04:55PM +0300, Marcel Apfelbaum wrote: > Hi Sukrit, > > On 7/6/19 7:09 AM, Sukrit Bhatnagar wrote: > > Changes in v2: > > > > * Modify load_dsr() such that dsr mapping is not performed if dsr value > >is non-NULL. Also move free_dsr() out of load_dsr() and call it r

Re: [Qemu-devel] Parallel make build fails on fast machine

2019-07-08 Thread Daniel P . Berrangé
On Sat, Jul 06, 2019 at 09:35:30PM +0100, Peter Maydell wrote: > On Sat, 6 Jul 2019 at 11:28, Mark Cave-Ayland > wrote: > > > > On 06/07/2019 11:16, Peter Maydell wrote: > > > If you just do 'make' rather than 'make install' does it fail the same > > > way? > > > > Interesting. A quick test shows

Re: [Qemu-devel] [BUG] VM abort after migration

2019-07-08 Thread Dr. David Alan Gilbert
* longpeng (longpe...@huawei.com) wrote: > Hi guys, > > We found a qemu core in our testing environment, the assertion > 'assert(bus->irq_count[i] == 0)' in pcibus_reset() was triggered and > the bus->irq_count[i] is '-1'. > > Through analysis, it was happened after VM migration and we think > it

Re: [Qemu-devel] Parallel make build fails on fast machine

2019-07-08 Thread Philippe Mathieu-Daudé
On 7/8/19 11:41 AM, Daniel P. Berrangé wrote: > On Sat, Jul 06, 2019 at 09:35:30PM +0100, Peter Maydell wrote: >> On Sat, 6 Jul 2019 at 11:28, Mark Cave-Ayland >> wrote: >>> >>> On 06/07/2019 11:16, Peter Maydell wrote: If you just do 'make' rather than 'make install' does it fail the same wa

Re: [Qemu-devel] Parallel make build fails on fast machine

2019-07-08 Thread Daniel P . Berrangé
On Mon, Jul 08, 2019 at 12:17:12PM +0200, Philippe Mathieu-Daudé wrote: > On 7/8/19 11:41 AM, Daniel P. Berrangé wrote: > > On Sat, Jul 06, 2019 at 09:35:30PM +0100, Peter Maydell wrote: > >> On Sat, 6 Jul 2019 at 11:28, Mark Cave-Ayland > >> wrote: > >>> > >>> On 06/07/2019 11:16, Peter Maydell w

Re: [Qemu-devel] [PATCH RFC] gpio: Add Virtual Aggregator GPIO Driver

2019-07-08 Thread Geert Uytterhoeven
Hi Bartosz, On Mon, Jul 8, 2019 at 11:45 AM Bartosz Golaszewski wrote: > pt., 5 lip 2019 o 18:05 Geert Uytterhoeven > napisał(a): > > GPIO controllers are exported to userspace using /dev/gpiochip* > > character devices. Access control to these devices is provided by > > standard UNIX file sys

Re: [Qemu-devel] [Qemu-ppc] [PATCH v10 2/6] ppc: spapr: Introduce FWNMI capability

2019-07-08 Thread Aravinda Prasad
On Friday 05 July 2019 06:53 PM, Greg Kurz wrote: > On Fri, 5 Jul 2019 16:49:17 +0530 > Aravinda Prasad wrote: > >> >> >> On Friday 05 July 2019 06:37 AM, David Gibson wrote: >>> On Thu, Jul 04, 2019 at 10:33:11AM +0530, Aravinda Prasad wrote: On Thursday 04 July 2019 06:37 AM,

Re: [Qemu-devel] [RFC PATCH-for-4.2] tracing: Allow to tune tracing options via the environment

2019-07-08 Thread Philippe Mathieu-Daudé
On 7/8/19 11:34 AM, Daniel P. Berrangé wrote: > On Sat, Jul 06, 2019 at 06:02:18AM +0200, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> On 7/5/19 3:19 PM, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: > On 7/5/19 10:07 AM, Stefan Hajnoczi wrote: >> On Th

Re: [Qemu-devel] [RFC PATCH-for-4.1 v4 3/3] hw/ssi/xilinx_spips: Avoid out-of-bound access to lqspi_buf[]

2019-07-08 Thread Philippe Mathieu-Daudé
On 7/6/19 12:24 AM, Francisco Iglesias wrote: > Hi Philippe, > > On [2019 Jul 05] Fri 22:25:00, Philippe Mathieu-Daudé wrote: >> Both lqspi_read() and lqspi_load_cache() expect a 32-bit >> aligned address. >> >> Set MemoryRegionOps.impl values to force 32-bit accesses, >> this way we are sure we d

Re: [Qemu-devel] [RFC PATCH-for-4.2] tracing: Allow to tune tracing options via the environment

2019-07-08 Thread Daniel P . Berrangé
On Mon, Jul 08, 2019 at 12:27:12PM +0200, Philippe Mathieu-Daudé wrote: > On 7/8/19 11:34 AM, Daniel P. Berrangé wrote: > > On Sat, Jul 06, 2019 at 06:02:18AM +0200, Markus Armbruster wrote: > >> Philippe Mathieu-Daudé writes: > >> > >>> On 7/5/19 3:19 PM, Markus Armbruster wrote: > Philippe

[Qemu-devel] [PATCH-for-4.1 v5 1/3] hw/ssi/xilinx_spips: Convert lqspi_read() to read_with_attrs

2019-07-08 Thread Philippe Mathieu-Daudé
In the next commit we will implement the write_with_attrs() handler. To avoid using different APIs, convert the read() handler first. Reviewed-by: Francisco Iglesias Signed-off-by: Philippe Mathieu-Daudé --- v4: Do not ignore lqspi_read() return value (Francisco) --- hw/ssi/xilinx_spips.c | 23

[Qemu-devel] [PATCH-for-4.1 v5 0/3] hw/ssi/xilinx_spips: Avoid NULL dereference and out-of-bound access

2019-07-08 Thread Philippe Mathieu-Daudé
v1: https://lists.gnu.org/archive/html/qemu-devel/2019-07/msg01238.html v2: https://lists.gnu.org/archive/html/qemu-devel/2019-07/msg01586.html v3: https://lists.gnu.org/archive/html/qemu-devel/2019-07/msg01657.html v4: https://lists.gnu.org/archive/html/qemu-devel/2019-07/msg01777.html v5: - addre

[Qemu-devel] [PATCH-for-4.1 v5 2/3] hw/ssi/xilinx_spips: Avoid AXI writes to the LQSPI linear memory

2019-07-08 Thread Philippe Mathieu-Daudé
Lei Sun found while auditing the code that a CPU write would trigger a NULL pointer dereference. >From UG1085 datasheet [*] AXI writes in this region are ignored and generates an AXI Slave Error (SLVERR). Fix by implementing the write_with_attrs() handler. Return MEMTX_ERROR when the region is ac

[Qemu-devel] [PATCH-for-4.1 v5 3/3] hw/ssi/xilinx_spips: Avoid out-of-bound access to lqspi_buf[]

2019-07-08 Thread Philippe Mathieu-Daudé
Both lqspi_read() and lqspi_load_cache() expect a 32-bit aligned address. >From UG1085 datasheet [*] Chapter 22: Quad-SPI Controller: Transfer Size Limitations Because of the 32-bit wide TX, RX, and generic FIFO, all APB/AXI transfers must be an integer multiple of 4-bytes. Shorter

Re: [Qemu-devel] [RFC 1/1] hw/pvrdma: Add live migration support

2019-07-08 Thread Dr. David Alan Gilbert
* Sukrit Bhatnagar (skrtbht...@gmail.com) wrote: > On Fri, 28 Jun 2019 at 16:56, Dr. David Alan Gilbert > wrote: > > > > * Yuval Shaia (yuval.sh...@oracle.com) wrote: > > > On Fri, Jun 21, 2019 at 08:15:41PM +0530, Sukrit Bhatnagar wrote: > > > > Define and register SaveVMHandlers pvrdma_save and

[Qemu-devel] [Bug 1835732] Re: GTK display zoom in, zooms infinitely

2019-07-08 Thread Alex Bennée
** Tags added: gtk ui -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1835732 Title: GTK display zoom in, zooms infinitely Status in QEMU: New Bug description: The zoom in feature in the "View"

[Qemu-devel] [Bug 1835732] Re: GTK display zoom in, zooms infinitely

2019-07-08 Thread Dr. David Alan Gilbert
This seems to work for me Can you confirm: a) Guest OS and version b) Guest desktop environment c) Host OS version d) Host desktop env e) The full command line you used for qemu. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QE

Re: [Qemu-devel] [PATCH] s390x/cpumodel: Set up CPU model for AQIC interception

2019-07-08 Thread Cornelia Huck
On Fri, 5 Jul 2019 17:32:49 +0200 Christian Borntraeger wrote: > From: Pierre Morel > > Let's add support for the AP-Queue interruption facility to the CPU > model. > > The S390_FEAT_AP_QUEUE_INTERRUPT_CONTROL, CPU facility indicates > whether the PQAP instruction with the AQIC command is ava

Re: [Qemu-devel] [PATCH v2 09/18] block/dirty-bitmap: add bdrv_dirty_bitmap_merge_internal

2019-07-08 Thread Max Reitz
On 05.07.19 18:45, John Snow wrote: > > > On 7/4/19 12:49 PM, Max Reitz wrote: >> On 03.07.19 23:55, John Snow wrote: [...] >>> + >>> +/** >>> + * bdrv_dirty_bitmap_merge_internal: merge src into dest. >>> + * Does NOT check bitmap permissions; not suitable for use as public API. >>> + * >>> +

Re: [Qemu-devel] [PULL 00/12] Misc bugfixes for QEMU hard freeze

2019-07-08 Thread Peter Maydell
On Fri, 5 Jul 2019 at 21:54, Paolo Bonzini wrote: > > The following changes since commit 39d1b92b810793e02558e05efa23059f67520bc9: > > Merge remote-tracking branch > 'remotes/bkoppelmann2/tags/pull-tricore-20190625' into staging (2019-07-01 > 13:47:21 +0100) > > are available in the git reposi

Re: [Qemu-devel] [PATCH v2 11/18] block/backup: upgrade copy_bitmap to BdrvDirtyBitmap

2019-07-08 Thread Max Reitz
On 05.07.19 18:52, John Snow wrote: > > > On 7/4/19 1:29 PM, Max Reitz wrote: [...] >> Which brings me to a question: Why is the copy bitmap assigned to the >> target in the first place? Wouldn’t it make more sense on the source? >> > > *cough*; > > the idea was that the target is *most like

Re: [Qemu-devel] Handling of fall through code (was: [PATCH v8 04/87] target/mips: Mark switch fallthroughs with interpretable comments

2019-07-08 Thread Stefan Weil
ough=2' The build process produced warnings for 79 fallthrough locations. See build protocol:     https://qemu.weilnetz.de/results/build-20190708.txt (116 MiB !) Sometimes the fallthrough comment is misplaced in the following case statement or followed by code, so the compiler (correctly) won&

Re: [Qemu-devel] Handling of fall through code (was: [PATCH v8 04/87] target/mips: Mark switch fallthroughs with interpretable comments

2019-07-08 Thread Daniel P . Berrangé
On Mon, Jul 08, 2019 at 02:04:27PM +0200, Stefan Weil wrote: > Am 08.07.2019 um 10:14 schrieb Aleksandar Markovic: > > > > On Jul 7, 2019 10:26 PM, "Stefan Weil" > > wrote: > > > - There is also fallthrough code which is obviously not correct > > (even in target/mips/trans

Re: [Qemu-devel] [PATCH v2 12/18] block/backup: add 'always' bitmap sync policy

2019-07-08 Thread Max Reitz
On 05.07.19 18:59, John Snow wrote: > > > On 7/4/19 2:05 PM, Max Reitz wrote: >> On 04.07.19 19:43, Max Reitz wrote: >>> On 03.07.19 23:55, John Snow wrote: This adds an "always" policy for bitmap synchronization. Regardless of if the job succeeds or fails, the bitmap is *always* synchr

Re: [Qemu-devel] [PATCH v3 1/6] block/nvme: don't touch the completion entries

2019-07-08 Thread Max Reitz
On 07.07.19 10:43, Maxim Levitsky wrote: > On Fri, 2019-07-05 at 13:03 +0200, Max Reitz wrote: >> On 03.07.19 17:59, Maxim Levitsky wrote: >>> Completion entries are meant to be only read by the host and written by the >>> device. >>> The driver is supposed to scan the completions from the last po

[Qemu-devel] [Bug 1835729] [NEW] GTK display does not support host scale factor

2019-07-08 Thread Tristan Van Berkom
Public bug reported: In the GNOME desktop environment, for HiDPI displays there is support to upscale everything. This can be set in "System Settings -> Displays -> Scale". I believe this affects GDK in the same way as setting the "GDK_SCALE" environment variable does. When launching `qemu-syst

[Qemu-devel] [Bug 1835732] [NEW] GTK display zoom in, zooms infinitely

2019-07-08 Thread Tristan Van Berkom
Public bug reported: The zoom in feature in the "View" menu of the gtk frontend (launch qemu with -display gtk), seems to be very broken. If I hit the zoom in feature, it first zooms in. Then, it zooms in again. Every subsequent second that passes, it zooms in again, until it eventually eats up

Re: [Qemu-devel] [PATCH RFC] gpio: Add Virtual Aggregator GPIO Driver

2019-07-08 Thread Bartosz Golaszewski
pt., 5 lip 2019 o 18:05 Geert Uytterhoeven napisał(a): > > GPIO controllers are exported to userspace using /dev/gpiochip* > character devices. Access control to these devices is provided by > standard UNIX file system permissions, on an all-or-nothing basis: > either a GPIO controller is accessi

Re: [Qemu-devel] [PULL v6 00/42] Machine and x86 queue, 2019-07-05

2019-07-08 Thread Igor Mammedov
On Mon, 8 Jul 2019 10:26:05 +0100 Peter Maydell wrote: > On Fri, 5 Jul 2019 at 23:15, Eduardo Habkost wrote: > > > > Changes v5 -> v6: > > * Rebase and solve conflicts with other pull requests > > (for the 4th time) > > * Included Cascadelake-Server-v2 update > > > > Changes v4 -> v5: > > * Re

Re: [Qemu-devel] [Qemu-riscv] [PULL 10/34] RISC-V: Fix a PMP check with the correct access size

2019-07-08 Thread Palmer Dabbelt
On Thu, 27 Jun 2019 11:23:20 PDT (-0700), richard.hender...@linaro.org wrote: On 6/27/19 7:44 PM, Jonathan Behrens wrote: I think this patch is slightly incorrect. If the PMP region is valid for the size of the access, but not the rest of the page then a few lines down in this function the entir

Re: [Qemu-devel] [PATCH v3 1/6] block/nvme: don't touch the completion entries

2019-07-08 Thread Maxim Levitsky
On Mon, 2019-07-08 at 14:23 +0200, Max Reitz wrote: > On 07.07.19 10:43, Maxim Levitsky wrote: > > On Fri, 2019-07-05 at 13:03 +0200, Max Reitz wrote: > > > On 03.07.19 17:59, Maxim Levitsky wrote: > > > > Completion entries are meant to be only read by the host and written by > > > > the device.

[Qemu-devel] [PATCH for-4.1 0/2] s390x: fallthrough annotations

2019-07-08 Thread Cornelia Huck
I looked through the build log linked to in <591d71a5-5b10-ab22-4751-01da8613d...@weilnetz.de> and came up with the following patches for s390x. I plan to queue them to my fixes branch for 4.1. Cornelia Huck (2): s390x/pci: add some fallthrough annotations s390x/tcg: move fallthrough annotatio

[Qemu-devel] [PATCH for-4.1 1/2] s390x/pci: add some fallthrough annotations

2019-07-08 Thread Cornelia Huck
According to the comment, the bits are supposed to accumulate. Reported-by: Stefan Weil Fixes: 5d1abf234462 ("s390x/pci: enforce zPCI state checking") Signed-off-by: Cornelia Huck --- hw/s390x/s390-pci-inst.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/s390x/s390-pci-inst.c b/hw/s3

[Qemu-devel] [PATCH for-4.1 2/2] s390x/tcg: move fallthrough annotation

2019-07-08 Thread Cornelia Huck
...so that the compiler properly recognizes it. Reported-by: Stefan Weil Fixes: f180da83c039 ("s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO") Signed-off-by: Cornelia Huck --- target/s390x/translate_vx.inc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target

Re: [Qemu-devel] [PATCH v3 1/6] block/nvme: don't touch the completion entries

2019-07-08 Thread Max Reitz
On 08.07.19 14:51, Maxim Levitsky wrote: > On Mon, 2019-07-08 at 14:23 +0200, Max Reitz wrote: >> On 07.07.19 10:43, Maxim Levitsky wrote: >>> On Fri, 2019-07-05 at 13:03 +0200, Max Reitz wrote: On 03.07.19 17:59, Maxim Levitsky wrote: > Completion entries are meant to be only read by the

Re: [Qemu-devel] [PATCH v3 1/6] block/nvme: don't touch the completion entries

2019-07-08 Thread Maxim Levitsky
On Mon, 2019-07-08 at 15:00 +0200, Max Reitz wrote: > On 08.07.19 14:51, Maxim Levitsky wrote: > > On Mon, 2019-07-08 at 14:23 +0200, Max Reitz wrote: > > > On 07.07.19 10:43, Maxim Levitsky wrote: > > > > On Fri, 2019-07-05 at 13:03 +0200, Max Reitz wrote: > > > > > On 03.07.19 17:59, Maxim Levits

Re: [Qemu-devel] [Qemu-block] question:about introduce a new feature named “I/O hang”

2019-07-08 Thread Maxim Levitsky
On Fri, 2019-07-05 at 09:50 +0200, Kevin Wolf wrote: > Am 04.07.2019 um 17:16 hat wangjie (P) geschrieben: > > Hi, everybody: > > > > I developed a feature named "I/O hang",my intention is to solve the problem > > like that: > > If the backend storage media of VM disk is far-end storage like IPSAN

Re: [Qemu-devel] [PATCH v6 05/14] numa: Extend CLI to provide initiator information for numa nodes

2019-07-08 Thread Eric Blake
On 7/7/19 9:29 AM, Tao Xu wrote: > In ACPI 6.3 chapter 5.2.27 Heterogeneous Memory Attribute Table (HMAT), > The initiator represents processor which access to memory. And in 5.2.27.3 > Memory Proximity Domain Attributes Structure, the attached initiator is > defined as where the memory controller

[Qemu-devel] [PULL 1/4] target/arm: Fix sve_zcr_len_for_el

2019-07-08 Thread Peter Maydell
From: Richard Henderson Off by one error in the EL2 and EL3 tests. Remove the test against EL3 entirely, since it must always be true. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-id: 20190702104732.31154-1-richard.hender...@linaro.org Signed-off-by: Peter Maydell ---

[Qemu-devel] [PULL 0/4] target-arm queue

2019-07-08 Thread Peter Maydell
ags/pull-target-arm-20190708 for you to fetch changes up to 85795187f416326f87177cabc39fae1911f04c50: target/arm/vfp_helper: Call set_fpscr_to_host before updating to FPSCR (2019-07-08 14:11:31 +0100) target-arm queue: * tests

[Qemu-devel] [PULL 2/4] tests/migration-test: Fix read off end of aarch64_kernel array

2019-07-08 Thread Peter Maydell
The test aarch64 kernel is in an array defined with unsigned char aarch64_kernel[] = { [...] } which means it could be any size; currently it's quite small. However we write it to a file using init_bootfile(), which writes exactly 512 bytes to the file. This will break if we ever end up with a ke

[Qemu-devel] [PULL 4/4] target/arm/vfp_helper: Call set_fpscr_to_host before updating to FPSCR

2019-07-08 Thread Peter Maydell
From: Philippe Mathieu-Daudé In commit e9d652824b0 we extracted the vfp_set_fpscr_to_host() function but failed at calling it in the correct place, we call it after xregs[ARM_VFP_FPSCR] is modified. Fix by calling this function before we update FPSCR. Reported-by: Laurent Desnogues Signed-off-

[Qemu-devel] [PULL 3/4] hw/arm/sbsa-ref: Remove unnecessary check for secure_sysmem == NULL

2019-07-08 Thread Peter Maydell
In the virt machine, we support TrustZone being either present or absent, and so the code must deal with the secure_sysmem pointer possibly being NULL. In the sbsa-ref machine, TrustZone is always present, but some code and comments copied from virt still treat it as possibly not being present. Th

Re: [Qemu-devel] [PATCH for-4.1 1/2] s390x/pci: add some fallthrough annotations

2019-07-08 Thread Christian Borntraeger
On 08.07.19 14:54, Cornelia Huck wrote: > According to the comment, the bits are supposed to accumulate. > > Reported-by: Stefan Weil > Fixes: 5d1abf234462 ("s390x/pci: enforce zPCI state checking") > Signed-off-by: Cornelia Huck This patch does not change behaviour, so it is certainly not w

Re: [Qemu-devel] [PATCH for-4.1 2/2] s390x/tcg: move fallthrough annotation

2019-07-08 Thread Stefan Weil
Am 08.07.2019 um 14:54 schrieb Cornelia Huck: > ...so that the compiler properly recognizes it. > > Reported-by: Stefan Weil > Fixes: f180da83c039 ("s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND > ZERO") > Signed-off-by: Cornelia Huck > --- > target/s390x/translate_vx.inc.c | 2 +- > 1 f

Re: [Qemu-devel] [PULL v6 29/42] qmp: Add deprecation information to query-machines

2019-07-08 Thread Eric Blake
On 7/5/19 5:14 PM, Eduardo Habkost wrote: > Export machine type deprecation status through the query-machines > QMP command. With this, libvirt and management software will be > able to show this information to users and/or suggest changes to > VM configuration to avoid deprecated machines. > > S

Re: [Qemu-devel] [PULL 0/4] target-arm queue

2019-07-08 Thread Peter Maydell
8 10:26:18 +0100) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20190708 > > for you to fetch changes up to 85795187f416326f87177cabc39fae1911f04c50: > > target/arm/vfp_h

Re: [Qemu-devel] pl031 time across vm save/reload

2019-07-08 Thread Peter Maydell
On Fri, 5 Jul 2019 at 10:48, Paolo Bonzini wrote: > You're right, the compatibility causes wrong behavior for the default > -rtc settings (the RC pauses across migration). The right thing to do > would be to store the base rather than the offset: that is, you store > the time at which LR was writ

Re: [Qemu-devel] [PATCH for-4.1] qcow2: Allow -o compat=v3 during qemu-img amend

2019-07-08 Thread Kevin Wolf
Am 05.07.2019 um 17:28 hat Eric Blake geschrieben: > Commit b76b4f60 allowed '-o compat=v3' as an alias for the > less-appealing '-o compat=1.1' for 'qemu-img create' since we want to > use the QMP form as much as possible, but forgot to do likewise for > qemu-img amend. Also, it doesn't help that

[Qemu-devel] [PULL 0/6] Block layer patches

2019-07-08 Thread Kevin Wolf
The following changes since commit df34fe314b5da628bc9a2664fb1b887bc0a6cc6d: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20190708' into staging (2019-07-08 14:23:32 +0100) are available in the Git repository at: git://repo.or.cz/qemu/kevin.git tags/for-ups

[Qemu-devel] [PULL 1/6] vl: add qemu_add_vm_change_state_handler_prio()

2019-07-08 Thread Kevin Wolf
From: Stefan Hajnoczi Add an API for registering vm change state handlers with a well-defined ordering. This is necessary when handlers depend on each other. Small coding style fixes are included to make checkpatch.pl happy. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- inclu

[Qemu-devel] [PULL 3/6] virtio-scsi: restart DMA after iothread

2019-07-08 Thread Kevin Wolf
From: Stefan Hajnoczi When the 'cont' command resumes guest execution the vm change state handlers are invoked. Unfortunately there is no explicit ordering between classic qemu_add_vm_change_state_handler() callbacks. When two layers of code both use vm change state handlers, we don't control w

[Qemu-devel] [PULL 5/6] MAINTAINERS: update RBD block maintainer

2019-07-08 Thread Kevin Wolf
From: Jason Dillaman Remove Josh as per his request since he is no longer the upstream RBD tech lead. Add myself as the maintainer since I am the current RBD tech lead. Signed-off-by: Jason Dillaman Reviewed-by: Josh Durgin Signed-off-by: Kevin Wolf --- MAINTAINERS | 2 +- 1 file changed, 1

[Qemu-devel] [PULL 2/6] qdev: add qdev_add_vm_change_state_handler()

2019-07-08 Thread Kevin Wolf
From: Stefan Hajnoczi Children sometimes depend on their parent's vm change state handler having completed. Add a vm change state handler API for devices that guarantees tree depth ordering. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- include/hw/qdev-core.h| 5 +

[Qemu-devel] [PULL 4/6] block/qcow: Improve error when opening qcow2 files as qcow

2019-07-08 Thread Kevin Wolf
From: John Snow Reported-by: radmehrsae...@gmail.com Fixes: https://bugs.launchpad.net/bugs/1832914 Signed-off-by: John Snow Reviewed-by: Maxim Levitsky Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- block/qcow.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PULL 6/6] qcow2: Allow -o compat=v3 during qemu-img amend

2019-07-08 Thread Kevin Wolf
From: Eric Blake Commit b76b4f60 allowed '-o compat=v3' as an alias for the less-appealing '-o compat=1.1' for 'qemu-img create' since we want to use the QMP form as much as possible, but forgot to do likewise for qemu-img amend. Also, it doesn't help that '-o help' doesn't list our new preferre

Re: [Qemu-devel] [PATCH-for-4.1 v5 3/3] hw/ssi/xilinx_spips: Avoid out-of-bound access to lqspi_buf[]

2019-07-08 Thread Francisco Iglesias
Hi Philippe, On [2019 Jul 08] Mon 12:47:50, Philippe Mathieu-Daudé wrote: > Both lqspi_read() and lqspi_load_cache() expect a 32-bit > aligned address. > > From UG1085 datasheet [*] Chapter 22: Quad-SPI Controller: s/22/24/ After above change: Reviewed-by: Francisco Iglesias Tested-by: Franc

[Qemu-devel] [PATCH] s390: cpumodel: fix name and description for the new vector facility

2019-07-08 Thread Christian Borntraeger
The new facility is called "Vector-Packed-Decimal-Enhancement Facility" and not "Vector BCD enhancements facility 1". Also fixup the short name to "vxp" to match the Linux kernel. Fixes: 54d65de0b525 ("s390x/cpumodel: vector enhancements") Signed-off-by: Christian Borntraeger --- target/s390x/cp

Re: [Qemu-devel] [PULL 0/4] target-arm queue

2019-07-08 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190708132237.7911-1-peter.mayd...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190708132237.7911-1-peter.mayd...@linaro.org Type: series Subject: [Qemu-devel] [PULL 0/4] targe

Re: [Qemu-devel] [PATCH] s390: cpumodel: fix name and description for the new vector facility

2019-07-08 Thread Christian Borntraeger
As this might have already sneaked into some distribution backports just fixing the description would be a "play-safe" variant. -DEF_FEAT(VECTOR_BCD_ENH, "vxbeh", STFL, 152, "Vector BCD enhancements facility 1") +DEF_FEAT(VECTOR_BCD_ENH, "vxbeh", STFL, 152, "Vector-Packed-Decimal-Enhancement Fa

Re: [Qemu-devel] [PULL v6 10/42] vl.c: Replace smp global variables with smp machine properties

2019-07-08 Thread Laurent Desnogues
Hi, On Sat, Jul 6, 2019 at 12:40 AM Eduardo Habkost wrote: > > From: Like Xu > > The global smp variables in vl.c are completely replaced with machine > properties. > > Form this commit, the smp_cpus/smp_cores/smp_threads/max_cpus are deprecated > and only machine properties within MachineState

Re: [Qemu-devel] [PATCH-for-4.1 v5 3/3] hw/ssi/xilinx_spips: Avoid out-of-bound access to lqspi_buf[]

2019-07-08 Thread Philippe Mathieu-Daudé
Hi Francisco, On 7/8/19 4:26 PM, Francisco Iglesias wrote: > Hi Philippe, > > On [2019 Jul 08] Mon 12:47:50, Philippe Mathieu-Daudé wrote: >> Both lqspi_read() and lqspi_load_cache() expect a 32-bit >> aligned address. >> >> From UG1085 datasheet [*] Chapter 22: Quad-SPI Controller: > > s/22/24/

[Qemu-devel] [Bug 1835793] [NEW] Running an edk2 based bios

2019-07-08 Thread Matthew Intriago
Public bug reported: This is not necessarily a bug, however I wasn't sure were to get help. I am currently working on using QEMU to run a BIOS my company has developed. In order to see if the software was working correctly, I was able to successfully run the edk2 bios using the following command

[Qemu-devel] [PATCH v2] s390: cpumodel: fix description for the new vector facility

2019-07-08 Thread Christian Borntraeger
The new facility is called "Vector-Packed-Decimal-Enhancement Facility" and not "Vector BCD enhancements facility 1". As the shortname might have already found its way into some backports lets keep vxbeh. Fixes: 54d65de0b525 ("s390x/cpumodel: vector enhancements") Signed-off-by: Christian Borntrae

Re: [Qemu-devel] [PULL 0/6] Block layer patches

2019-07-08 Thread Peter Maydell
On Mon, 8 Jul 2019 at 15:18, Kevin Wolf wrote: > > The following changes since commit df34fe314b5da628bc9a2664fb1b887bc0a6cc6d: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20190708' into staging (2019-07-08 > 14:23:32 +0100)

[Qemu-devel] Running an Edk2 based bios

2019-07-08 Thread Intriago, Matthew
Good morning to all, I am currently working on using QEMU to run a BIOS my company has developed. In order to see if the software was working correctly, I was able to successfully run the edk2 bios using the following command: qemu-system-x86_64.exe -bios "C:\Users\matthew.intriago\Desktop\ovm

[Qemu-devel] [Bug 1835793] Re: Running an edk2 based bios

2019-07-08 Thread Peter Maydell
"Guest has not initialized display" simply means that the guest code you're running has not done anything to the display device (VGA in this case). There are two main reasons for this: (1) the guest code isn't intended to output to the display -- perhaps it sends its output to the serial port ins

[Qemu-devel] [Bug 1794187] Re: improve error message, when using raspi3 and RAM>4G

2019-07-08 Thread Peter Maydell
Improved diagnostic message is now in master and will be in QEMU 4.1. ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1794187 Title:

[Qemu-devel] [Bug 1832353] Re: cpu_exec: Assertion !have_mmap_lock() failed

2019-07-08 Thread Peter Maydell
The fix for this bug is now in master and will be in QEMU 4.1. ** Changed in: qemu Status: In Progress => Won't Fix ** Changed in: qemu Status: Won't Fix => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU

[Qemu-devel] [Bug 1823998] Re: qemu-system-aarch64: support kernels bigger than 128MiB

2019-07-08 Thread Peter Maydell
Changes now in master, will be in 4.1. ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1823998 Title: qemu-system-aarch64: support ke

[Qemu-devel] [Bug 1825311] Re: mips_cpu_handle_mmu_fault renders all accessed pages executable

2019-07-08 Thread Peter Maydell
This bug should be fixed by commit 7353113fa482e697a77 now in QEMU master; it will be in the 4.1 release. ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.l

Re: [Qemu-devel] [PATCH v2] s390: cpumodel: fix description for the new vector facility

2019-07-08 Thread Cornelia Huck
On Mon, 8 Jul 2019 17:09:31 +0200 Christian Borntraeger wrote: > The new facility is called "Vector-Packed-Decimal-Enhancement Facility" > and not "Vector BCD enhancements facility 1". As the shortname might > have already found its way into some backports lets keep vxbeh. s/lets/let's/ > > F

Re: [Qemu-devel] [PATCH 0/3] Add dbus-vmstate

2019-07-08 Thread Dr. David Alan Gilbert
* Marc-André Lureau (marcandre.lur...@redhat.com) wrote: > Hi, > > With external processes or helpers participating to the VM support, it > becomes necessary to handle their migration. Various options exist to > transfer their state: > 1) as the VM memory, RAM or devices (we could say that's how >

Re: [Qemu-devel] [PATCH 0/3] Add dbus-vmstate

2019-07-08 Thread Daniel P . Berrangé
On Mon, Jul 08, 2019 at 11:24:34AM +0400, Marc-André Lureau wrote: > Hi, > > With external processes or helpers participating to the VM support, it > becomes necessary to handle their migration. Various options exist to > transfer their state: > 1) as the VM memory, RAM or devices (we could say th

Re: [Qemu-devel] [PATCH] hw/net: fix vmxnet3 live migration

2019-07-08 Thread Dr. David Alan Gilbert
* Marcel Apfelbaum (marcel.apfelb...@gmail.com) wrote: > > > On 7/5/19 2:14 PM, Sukrit Bhatnagar wrote: > > On Fri, 5 Jul 2019 at 16:29, Dmitry Fleytman > > wrote: > > > > > > > On 5 Jul 2019, at 4:07, Marcel Apfelbaum > > > > wrote: > > > > > > > > At some point vmxnet3 live migration stop

Re: [Qemu-devel] [PATCH-for-4.1 v5 3/3] hw/ssi/xilinx_spips: Avoid out-of-bound access to lqspi_buf[]

2019-07-08 Thread Francisco Iglesias
Hi Philippe, On [2019 Jul 08] Mon 16:58:29, Philippe Mathieu-Daudé wrote: > Hi Francisco, > > On 7/8/19 4:26 PM, Francisco Iglesias wrote: > > Hi Philippe, > > > > On [2019 Jul 08] Mon 12:47:50, Philippe Mathieu-Daudé wrote: > >> Both lqspi_read() and lqspi_load_cache() expect a 32-bit > >> alig

  1   2   3   >