Re: [Qemu-devel] [PATCH v2 0/7] target/mips: Misc improvements for 4.1

2019-07-03 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1562068213-11307-1-git-send-email-aleksandar.marko...@rt-rk.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGI

Re: [Qemu-devel] [PATCH v10 4/6] target/ppc: Build rtas error log upon an MCE

2019-07-03 Thread Aravinda Prasad
On Wednesday 03 July 2019 08:37 AM, David Gibson wrote: > On Tue, Jul 02, 2019 at 03:19:24PM +0530, Aravinda Prasad wrote: >> >> >> On Tuesday 02 July 2019 09:33 AM, David Gibson wrote: >>> On Wed, Jun 12, 2019 at 02:51:21PM +0530, Aravinda Prasad wrote: Upon a machine check exception (MCE)

Re: [Qemu-devel] [PATCH] monitor: increase amount of data for monitor to read

2019-07-03 Thread Denis Lunev
On 7/3/19 9:36 AM, Markus Armbruster wrote: > Did this fall through the cracks? > > Denis Plotnikov writes: > >> Right now QMP and HMP monitors read 1 byte at a time from the socket, which >> is very inefficient. With 100+ VMs on the host this easily reasults in >> a lot of unnecessary system call

Re: [Qemu-devel] [PULL 00/12] MIPS queue for July 2nd, 2019

2019-07-03 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1562085328-5126-1-git-send-email-aleksandar.marko...@rt-rk.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: [Qemu-devel] [Qemu-block] [PATCH v2] block/rbd: implement .bdrv_get_allocated_file_size callback

2019-07-03 Thread Stefano Garzarella
On Tue, Jul 02, 2019 at 11:09:14AM -0400, Jason Dillaman wrote: > On Fri, Jun 28, 2019 at 4:59 AM Stefano Garzarella > wrote: > > > > On Thu, Jun 27, 2019 at 03:43:04PM -0400, Jason Dillaman wrote: > > > On Thu, Jun 27, 2019 at 1:24 PM John Snow wrote: > > > > On 6/27/19 4:48 AM, Stefano Garzare

Re: [Qemu-devel] [PATCH] numa: Make deprecation warnings conditional on !qtest_enabled()

2019-07-03 Thread Igor Mammedov
On Tue, 2 Jul 2019 18:57:26 -0300 Eduardo Habkost wrote: > This will help us avoid spurious warnings during "make check". > > Note that this will silence the warnings generated by > tests/numa-test, but not the ones generated by > tests/bios-tables-test. We still need to change > tests/bios-ta

Re: [Qemu-devel] [PATCH] Add ati vgabios to INSTALL_BLOBS.

2019-07-03 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190703045212.31039-1-kra...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash make d

Re: [Qemu-devel] [PATCH] vfio/pci: Trace vfio_set_irq_signaling() failure in vfio_msix_vector_release()

2019-07-03 Thread Cornelia Huck
On Tue, 2 Jul 2019 19:18:16 +0200 Eric Auger wrote: > Report an error in case we fail to set a trigger action > on any VFIO_PCI_MSIX_IRQ_INDEX subindex. This might be > useful in debugging a device that is not working properly. > > Signed-off-by: Eric Auger > --- > hw/vfio/pci.c | 7 +-- >

Re: [Qemu-devel] qgraph

2019-07-03 Thread Natalia Fursova
Thank you! С уважением, Наталья -Original Message- From: Markus Armbruster [mailto:arm...@redhat.com] Sent: Tuesday, July 02, 2019 6:26 PM To: Natalia Fursova Cc: 'Paolo Bonzini'; 'Andreas Färber'; 'Паша'; qemu-devel@nongnu.org Subject: Re: [Qemu-devel] qgraph "Natalia Fursova" write

Re: [Qemu-devel] [PATCH] monitor: vnc: Fix compilation error if CONFIG_VNC is disable

2019-07-03 Thread Stefano Garzarella
On Tue, Jul 02, 2019 at 07:01:31PM +, Julio Montes wrote: > How to reproduce it? > === > > ``` > $ ./configure --disable-spice --disable-vte --disable-vnc \ > --disable-vnc-jpeg --disable-vnc-png --disable-vnc-sasl > $ make > ... > monitor/hmp-cmds.c: In function ‘hmp_change’: > monitor/hm

Re: [Qemu-devel] [PATCH] virtio-gpu: check if the resource already exists in virtio_gpu_load()

2019-07-03 Thread Marc-André Lureau
On Fri, Jun 28, 2019 at 8:53 PM Li Qiang wrote: > > While loading virtio-gpu, the data can be malicious, we > should check if the resource already exists. > > Signed-off-by: Li Qiang Reviewed-by: Marc-André Lureau > --- > hw/display/virtio-gpu.c | 5 + > 1 file changed, 5 insertions(+) >

Re: [Qemu-devel] [PULL 0/1] Audio 20190703 patches

2019-07-03 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190703065600.13535-1-kra...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash make d

Re: [Qemu-devel] [PATCH] vfio-ccw: Test vfio_set_irq_signaling() return value

2019-07-03 Thread Auger Eric
Hi On 7/2/19 9:41 PM, Alex Williamson wrote: > Coverity doesn't like that most callers of vfio_set_irq_signaling() check > the return value and doesn't understand the equivalence of testing the > error pointer instead. Test the return value consistently. > > Reported-by: Coverity (CID 1402783) >

Re: [Qemu-devel] [PULL v2 00/20] testing/next for 4.1

2019-07-03 Thread Alex Bennée
Peter Maydell writes: > On Tue, 2 Jul 2019 at 11:25, Alex Bennée wrote: >> >> The following changes since commit 7d0e02405fc02a181319b1ab8681d2f72246b7c6: >> >> Merge remote-tracking branch >> 'remotes/vivier2/tags/trivial-patches-pull-request' into staging (2019-07-01 >> 17:40:32 +0100) >

[Qemu-devel] [BUG] VM abort after migration

2019-07-03 Thread longpeng
Hi guys, We found a qemu core in our testing environment, the assertion 'assert(bus->irq_count[i] == 0)' in pcibus_reset() was triggered and the bus->irq_count[i] is '-1'. Through analysis, it was happened after VM migration and we think it was caused by the following sequence: *Migration Source

[Qemu-devel] [PULL 02/32] sifive_prci: Read and write PRCI registers

2019-07-03 Thread Palmer Dabbelt
From: Nathaniel Graff Writes to the SiFive PRCI registers are preserved while leaving the ready bits set for the HFX/HFR oscillators and the lock bit set for the PLL. Signed-off-by: Nathaniel Graff Reviewed-by: Michael Clark Signed-off-by: Palmer Dabbelt --- hw/riscv/sifive_prci.c |

[Qemu-devel] [PULL 01/32] target/riscv: Allow setting ISA extensions via CPU props

2019-07-03 Thread Palmer Dabbelt
From: Alistair Francis This patch allows us to enable/disable the RISC-V ISA extensions from the QEMU command line. This works with the rv32 and rv64 machines. The idea is that in the future we can now add extensions and leave them disabled by default until enabled by the user. Signed-off-by: Al

[Qemu-devel] [PULL] RISC-V Patches for the 4.1 Soft Freeze, Part 2 v3

2019-07-03 Thread Palmer Dabbelt
merged tag 'mips-queue-jun-21-2019' The following changes since commit 474f3938d79ab36b9231c9ad3b5a9314c2aeacde: Merge remote-tracking branch 'remotes/amarkovic/tags/mips-queue-jun-21-2019' into staging (2019-06-21 15:40:50 +0100) are available in the Git repository at: git://github.com/pal

[Qemu-devel] [PULL 05/32] RISC-V: Only Check PMP if MMU translation succeeds

2019-07-03 Thread Palmer Dabbelt
From: Hesham Almatary The current implementation unnecessarily checks for PMP even if MMU translation failed. This may trigger a wrong PMP access exception instead of a page exception. For example, the very first instruction fetched after the first satp write in S-Mode will trigger a PMP access

[Qemu-devel] [PULL 04/32] target/riscv: Implement riscv_cpu_unassigned_access

2019-07-03 Thread Palmer Dabbelt
From: Michael Clark This patch adds support for the riscv_cpu_unassigned_access call and will raise a load or store access fault. Signed-off-by: Michael Clark [Changes by AF: - Squash two patches and rewrite commit message - Set baddr to the access address ] Signed-off-by: Alistair Francis R

[Qemu-devel] [PULL 07/32] RISC-V: Check for the effective memory privilege mode during PMP checks

2019-07-03 Thread Palmer Dabbelt
From: Hesham Almatary The current PMP check function checks for env->priv which is not the effective memory privilege mode. For example, mstatus.MPRV could be set while executing in M-Mode, and in that case the privilege mode for the PMP check should be S-Mode rather than M-Mode (in env->priv) i

[Qemu-devel] [PULL 10/32] RISC-V: Fix a PMP check with the correct access size

2019-07-03 Thread Palmer Dabbelt
From: Hesham Almatary The PMP check should be of the memory access size rather than TARGET_PAGE_SIZE. Signed-off-by: Hesham Almatary Reviewed-by: Alistair Francis Signed-off-by: Palmer Dabbelt --- target/riscv/cpu_helper.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a

[Qemu-devel] [PULL 03/32] target/riscv: Fix PMP range boundary address bug

2019-07-03 Thread Palmer Dabbelt
From: Dayeol Lee A wrong address is passed to `pmp_is_in_range` while checking if a memory access is within a PMP range. Since the ending address of the pmp range (i.e., pmp_state.addr[i].ea) is set to the last address in the range (i.e., pmp base + pmp size - 1), memory accesses containg the las

[Qemu-devel] [PULL 08/32] RISC-V: Check PMP during Page Table Walks

2019-07-03 Thread Palmer Dabbelt
From: Hesham Almatary The PMP should be checked when doing a page table walk, and report access fault exception if the to-be-read PTE failed the PMP check. Suggested-by: Jonathan Behrens Signed-off-by: Hesham Almatary Reviewed-by: Palmer Dabbelt Signed-off-by: Palmer Dabbelt --- target/risc

[Qemu-devel] [PULL 09/32] RISC-V: Fix a PMP bug where it succeeds even if PMP entry is off

2019-07-03 Thread Palmer Dabbelt
From: Hesham Almatary The current implementation returns 1 (PMP check success) if the address is in range even if the PMP entry is off. This is a bug. For example, if there is a PMP check in S-Mode which is in range, but its PMP entry is off, this will succeed, which it should not. The patch fi

[Qemu-devel] [PULL 11/32] riscv: virt: Correct pci "bus-range" encoding

2019-07-03 Thread Palmer Dabbelt
From: Bin Meng The largest pci bus number should be calculated from ECAM size, instead of its base address. Signed-off-by: Bin Meng Reviewed-by: Alistair Francis Signed-off-by: Palmer Dabbelt --- hw/riscv/virt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/riscv/vir

[Qemu-devel] [PULL 06/32] RISC-V: Raise access fault exceptions on PMP violations

2019-07-03 Thread Palmer Dabbelt
From: Hesham Almatary Section 3.6 in RISC-V v1.10 privilege specification states that PMP violations report "access exceptions." The current PMP implementation has a bug which wrongly reports "page exceptions" on PMP violations. This patch fixes this bug by reporting the correct PMP access excep

[Qemu-devel] [PULL 14/32] target/riscv: Add the privledge spec version 1.11.0

2019-07-03 Thread Palmer Dabbelt
From: Alistair Francis Add support for the ratified RISC-V privledge spec. Signed-off-by: Alistair Francis Reviewed-by: Palmer Dabbelt Signed-off-by: Palmer Dabbelt --- target/riscv/cpu.h | 1 + target/riscv/insn_trans/trans_privileged.inc.c | 2 +- 2 files change

[Qemu-devel] [PULL 20/32] target/riscv: Add support for disabling/enabling Counters

2019-07-03 Thread Palmer Dabbelt
From: Alistair Francis Add support for disabling/enabling the "Counters" extension. Signed-off-by: Alistair Francis Reviewed-by: Palmer Dabbelt Signed-off-by: Palmer Dabbelt --- target/riscv/cpu.c | 1 + target/riscv/cpu.h | 1 + target/riscv/csr.c | 17 - 3 files changed,

[Qemu-devel] [PULL 12/32] RISC-V: Fix a memory leak when realizing a sifive_e

2019-07-03 Thread Palmer Dabbelt
Coverity pointed out a memory leak in riscv_sifive_e_soc_realize(), where a pair of recently added MemoryRegion instances would not be freed if there were errors elsewhere in the function. The fix here is to simply not use dynamic allocation for these instances: there's always one of each in SiFiv

[Qemu-devel] [PULL 18/32] target/riscv: Require either I or E base extension

2019-07-03 Thread Palmer Dabbelt
From: Alistair Francis Signed-off-by: Alistair Francis Reviewed-by: Palmer Dabbelt Signed-off-by: Palmer Dabbelt --- target/riscv/cpu.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index ba1325f43533..1689ffecf85f 100644 --- a/target/riscv/

[Qemu-devel] [PULL 13/32] target/riscv: Restructure deprecatd CPUs

2019-07-03 Thread Palmer Dabbelt
From: Alistair Francis Restructure the deprecated CPUs to make it clear in the code that these are depreated. They are already marked as deprecated in qemu-deprecated.texi. There are no functional changes. Signed-off-by: Alistair Francis Reviewed-by: Palmer Dabbelt Signed-off-by: Palmer Dabbel

[Qemu-devel] [PULL 17/32] qemu-deprecated.texi: Deprecate the RISC-V privledge spec 1.09.1

2019-07-03 Thread Palmer Dabbelt
From: Alistair Francis Deprecate the RISC-V privledge spec version 1.09.1 in favour of the new 1.10.0 and the ratified 1.11.0. Signed-off-by: Alistair Francis Signed-off-by: Palmer Dabbelt --- qemu-deprecated.texi | 8 1 file changed, 8 insertions(+) diff --git a/qemu-deprecated.tex

[Qemu-devel] [PULL 24/32] RISC-V: Update syscall list for 32-bit support.

2019-07-03 Thread Palmer Dabbelt
From: Jim Wilson 32-bit RISC-V uses _llseek instead of lseek as syscall number 62. Update syscall list from open-embedded build, primarily because 32-bit RISC-V requires statx support. Tested with cross gcc testsuite runs for rv32 and rv64, with the pending statx patch also applied. Signed-off-

[Qemu-devel] [PULL 15/32] target/riscv: Add the mcountinhibit CSR

2019-07-03 Thread Palmer Dabbelt
From: Alistair Francis 1.11 defines mcountinhibit, which has the same numeric CSR value as mucounteren from 1.09.1 but has different semantics. This patch enables the CSR for 1.11-based targets, which is trivial to implement because the counters in QEMU never tick (legal according to the spec).

[Qemu-devel] [PULL 21/32] RISC-V: Add support for the Zifencei extension

2019-07-03 Thread Palmer Dabbelt
fence.i has been split out of the base ISA as part of the ratification process. This patch adds a Zifencei argument, which disables the fence.i instruction. Signed-off-by: Palmer Dabbelt Reviewed-by: Alistair Francis --- target/riscv/cpu.c | 1 + target/riscv/cpu.h

[Qemu-devel] [PULL 22/32] RISC-V: Add support for the Zicsr extension

2019-07-03 Thread Palmer Dabbelt
The various CSR instructions have been split out of the base ISA as part of the ratification process. This patch adds a Zicsr argument, which disables all the CSR instructions. Signed-off-by: Palmer Dabbelt Reviewed-by: Alistair Francis --- target/riscv/cpu.c | 1 + target/riscv/cpu.h | 1 + t

[Qemu-devel] [PULL 28/32] riscv: sifive_u: Do not create hard-coded phandles in DT

2019-07-03 Thread Palmer Dabbelt
From: Bin Meng At present the cpu, plic and ethclk nodes' phandles are hard-coded to 1/2/3 in DT. If we configure more than 1 cpu for the machine, all cpu nodes' phandles conflict with each other as they are all 1. Fix it by removing the hardcode. Signed-off-by: Bin Meng Reviewed-by: Alistair F

[Qemu-devel] [PULL 2/4] virtio-gpu: check if the resource already exists in virtio_gpu_load()

2019-07-03 Thread Gerd Hoffmann
From: Li Qiang While loading virtio-gpu, the data can be malicious, we should check if the resource already exists. Signed-off-by: Li Qiang Reviewed-by: Marc-André Lureau Message-id: 20190628161358.10400-1-liq...@163.com Signed-off-by: Gerd Hoffmann --- hw/display/virtio-gpu.c | 5 + 1 f

[Qemu-devel] [PULL 16/32] target/riscv: Set privledge spec 1.11.0 as default

2019-07-03 Thread Palmer Dabbelt
From: Alistair Francis Set the priv spec version 1.11.0 as the default and allow selecting it via the command line. Signed-off-by: Alistair Francis Reviewed-by: Palmer Dabbelt Signed-off-by: Palmer Dabbelt --- target/riscv/cpu.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-)

Re: [Qemu-devel] [PATCH for-4.1] hw/i2c/bitbang_i2c: Use in-place rather than malloc'd bitbang_i2c_interface struct

2019-07-03 Thread Philippe Mathieu-Daudé
On 7/2/19 6:38 PM, Peter Maydell wrote: > Currently the bitbang_i2c_init() function allocates a > bitbang_i2c_interface struct which it returns. This is unfortunate > because it means that if the function is used from a DeviceState > init method then the memory will be leaked by an "init then dele

[Qemu-devel] [PULL 19/32] target/riscv: Remove user version information

2019-07-03 Thread Palmer Dabbelt
From: Alistair Francis Remove the user version information. This was never used and never publically exposed in a release of QEMU, so let's just remove it. In future to manage versions we can extend the extension properties to specify version. Signed-off-by: Alistair Francis Reviewed-by: Palmer

[Qemu-devel] [PULL 4/4] Add ati vgabios to INSTALL_BLOBS.

2019-07-03 Thread Gerd Hoffmann
Fixes: 0cca7e7bfd6c81cc3c29ec2b3a0a98954c4ba71a Reported-by: Bruce Rogers Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Gerd Hoffmann Message-id: 20190703045212.31039-1-kra...@redhat.com --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile in

Re: [Qemu-devel] [PATCH v2 10/21] aspeed/timer: Provide back-pressure information for short periods

2019-07-03 Thread Cédric Le Goater
On 01/07/2019 14:59, Peter Maydell wrote: > On Tue, 18 Jun 2019 at 17:54, Cédric Le Goater wrote: >> >> From: Andrew Jeffery >> >> First up: This is not the way the hardware behaves. >> >> However, it helps resolve real-world problems with short periods being >> used under Linux. Commit 4451d3f59

[Qemu-devel] [PULL 27/32] disas/riscv: Fix `rdinstreth` constraint

2019-07-03 Thread Palmer Dabbelt
From: "Wladimir J. van der Laan" The constraint for `rdinstreth` was comparing the csr number to 0xc80, which is `cycleh` instead. Fix this. Signed-off-by: Wladimir J. van der Laan Signed-off-by: Michael Clark Signed-off-by: Alistair Francis Reviewed-by: Palmer Dabbelt Signed-off-by: Palmer

Re: [Qemu-devel] [PATCH] net/colo-compare.c: Fix memory leak and code style issue.

2019-07-03 Thread Philippe Mathieu-Daudé
On 7/3/19 3:38 AM, Zhang Chen wrote: > From: Zhang Chen > > Address Peter's comments in patch "COLO-compare:Add colo-compare > remote notify support". This comment is not useful in the git history (no reference). You might reword him, use full coment, or simply: Reported-by: Coverity (CID 1402

[Qemu-devel] [PULL 3/4] hw/i2c/bitbang_i2c: Use in-place rather than malloc'd bitbang_i2c_interface struct

2019-07-03 Thread Gerd Hoffmann
From: Peter Maydell Currently the bitbang_i2c_init() function allocates a bitbang_i2c_interface struct which it returns. This is unfortunate because it means that if the function is used from a DeviceState init method then the memory will be leaked by an "init then delete" cycle, as used by the

Re: [Qemu-devel] [PATCH] vfio-ccw: Test vfio_set_irq_signaling() return value

2019-07-03 Thread Cornelia Huck
On Tue, 02 Jul 2019 13:41:34 -0600 Alex Williamson wrote: > Coverity doesn't like that most callers of vfio_set_irq_signaling() check > the return value and doesn't understand the equivalence of testing the > error pointer instead. Test the return value consistently. > > Reported-by: Coverity (

Re: [Qemu-devel] [PATCH] vfio-ccw: Test vfio_set_irq_signaling() return value

2019-07-03 Thread Philippe Mathieu-Daudé
On 7/2/19 9:41 PM, Alex Williamson wrote: > Coverity doesn't like that most callers of vfio_set_irq_signaling() check > the return value and doesn't understand the equivalence of testing the > error pointer instead. Test the return value consistently. > > Reported-by: Coverity (CID 1402783) > Sig

Re: [Qemu-devel] [PULL 00/12] MIPS queue for July 2nd, 2019

2019-07-03 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1562085328-5126-1-git-send-email-aleksandar.marko...@rt-rk.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

[Qemu-devel] [PULL 1/4] virtio-gpu: fix unmap in error path

2019-07-03 Thread Gerd Hoffmann
We land here in case not everything we've asked for could be mapped. So unmap only the bytes which have actually been mapped. Also we didn't access anything, so acces_len can be 0. Reported-by: Laszlo Ersek Signed-off-by: Gerd Hoffmann Reviewed-by: Laszlo Ersek Reviewed-by: Li Qiang Message-i

[Qemu-devel] [PULL 29/32] riscv: sifive_u: Update the plic hart config to support multicore

2019-07-03 Thread Palmer Dabbelt
From: Bin Meng At present the PLIC is instantiated to support only one hart, while the machine allows at most 4 harts to be created. When more than 1 hart is configured, PLIC needs to instantiated to support multicore, otherwise an SMP OS does not work. Signed-off-by: Bin Meng Reviewed-by: Alis

[Qemu-devel] [PULL 25/32] riscv: virt: Add cpu-topology DT node.

2019-07-03 Thread Palmer Dabbelt
From: Atish Patra Currently, there is no cpu topology defined in RISC-V. Define a device tree node that clearly describes the entire topology. This saves the trouble of scanning individual cache to figure out the topology. Here is the linux kernel patch series that enables topology for RISC-V.

Re: [Qemu-devel] [PATCH] migration/postcopy: fix document of postcopy_send_discard_bm_ram()

2019-07-03 Thread Philippe Mathieu-Daudé
On 7/3/19 3:12 AM, Wei Yang wrote: > Commit 6b6712efccd3 ('ram: Split dirty bitmap by RAMBlock') changes the > parameter of postcopy_send_discard_bm_ram(), while left the document > part untouched. > > This patch correct the document and fix one typo by hand. > > Signed-off-by: Wei Yang > --- >

Re: [Qemu-devel] [PATCH v10 6/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-07-03 Thread Aravinda Prasad
On Wednesday 03 July 2019 08:50 AM, David Gibson wrote: > On Tue, Jul 02, 2019 at 04:10:08PM +0530, Aravinda Prasad wrote: >> >> >> On Tuesday 02 July 2019 09:41 AM, David Gibson wrote: >>> On Wed, Jun 12, 2019 at 02:51:38PM +0530, Aravinda Prasad wrote: This patch adds support in QEMU to h

[Qemu-devel] [PULL 23/32] RISC-V: Clear load reservations on context switch and SC

2019-07-03 Thread Palmer Dabbelt
From: Joel Sing This prevents a load reservation from being placed in one context/process, then being used in another, resulting in an SC succeeding incorrectly and breaking atomics. Signed-off-by: Joel Sing Reviewed-by: Palmer Dabbelt Reviewed-by: Richard Henderson Signed-off-by: Palmer Dabb

Re: [Qemu-devel] [PATCH v2 3/6] hw/vfio/common: Do not replay IOMMU mappings in nested case

2019-07-03 Thread Auger Eric
Hi Peter, On 7/3/19 7:41 AM, Peter Xu wrote: > On Mon, Jul 01, 2019 at 11:30:31AM +0200, Eric Auger wrote: >> In nested mode, the stage 1 translation tables are owned by >> the guest and there is no caching on host side. So there is >> no need to replay the mappings. >> >> As of today, the SMMUv3

Re: [Qemu-devel] [PATCH v2 2/6] memory: Add IOMMU_ATTR_VFIO_NESTED IOMMU memory region attribute

2019-07-03 Thread Auger Eric
Hi Peter, On 7/3/19 7:42 AM, Peter Xu wrote: > On Mon, Jul 01, 2019 at 11:30:30AM +0200, Eric Auger wrote: >> We introduce a new IOMMU Memory Region attribute, >> IOMMU_ATTR_VFIO_NESTED that tells whether the virtual IOMMU >> requires physical nested stages for VFIO integration. >> >> Current Inte

[Qemu-devel] [PULL 31/32] hw/riscv: Add support for loading a firmware

2019-07-03 Thread Palmer Dabbelt
From: Alistair Francis Add support for loading a firmware file for the virt machine and the SiFive U. This can be run with the following command: qemu-system-riscv64 -machine virt -bios fw_jump.bin -kernel vmlinux Signed-off-by: Alistair Francis Reviewed-by: Bin Meng Tested-by: Bin Meng

Re: [Qemu-devel] [PATCH 0/4] libvhost-user: VHOST_USER_PROTOCOL_F_MQ support

2019-07-03 Thread Stefan Hajnoczi
On Fri, Jun 21, 2019 at 10:40:01AM +0100, Stefan Hajnoczi wrote: > Sebastien Boeuf pointed out that libvhost-user > doesn't advertise VHOST_USER_PROTOCOL_F_MQ. Today this prevents > vhost-user-net > multiqueue from working. > > In virtio-fs we also want to support multiqueue so I'm sending patc

Re: [Qemu-devel] [PATCH] vfio/pci: Trace vfio_set_irq_signaling() failure in vfio_msix_vector_release()

2019-07-03 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190702171816.11939-1-eric.au...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash m

[Qemu-devel] [PULL 32/32] hw/riscv: Extend the kernel loading support

2019-07-03 Thread Palmer Dabbelt
From: Alistair Francis Extend the RISC-V kernel loader to support Image and uImage files. A Linux kernel can now be booted with: qemu-system-riscv64 -machine virt -bios fw_jump.bin -kernel Image Signed-off-by: Alistair Francis Reviewed-by: Bin Meng Tested-by: Bin Meng Signed-off-by: Palm

[Qemu-devel] [PULL 26/32] disas/riscv: Disassemble reserved compressed encodings as illegal

2019-07-03 Thread Palmer Dabbelt
From: Michael Clark Due to the design of the disassembler, the immediate is not known during decoding of the opcode; so to handle compressed encodings with reserved immediate values (non-zero), we need to add an additional check during decompression to match reserved encodings with zero immediate

Re: [Qemu-devel] [RFC PATCH 0/5] FAULT INJECTION FRAMEWORK

2019-07-03 Thread Stefan Hajnoczi
On Mon, Jul 01, 2019 at 12:16:44PM +0200, Philippe Mathieu-Daudé wrote: > On 7/1/19 10:37 AM, Stefan Hajnoczi wrote: > > On Fri, Jun 28, 2019 at 02:45:29PM +0200, Damien Hedde wrote: > >> This series adds a python framework aiming to provide some ways to do fault > >> injection in a running vm. In

[Qemu-devel] [PULL 30/32] hw/riscv: Split out the boot functions

2019-07-03 Thread Palmer Dabbelt
From: Alistair Francis Split the common RISC-V boot functions into a seperate file. This allows us to share the common code. Signed-off-by: Alistair Francis Reviewed-by: Bin Meng Tested-by: Bin Meng Signed-off-by: Palmer Dabbelt --- hw/riscv/Makefile.objs | 1 + hw/riscv/boot.c |

Re: [Qemu-devel] [PATCH for-4.1] hw/i2c/bitbang_i2c: Use in-place rather than malloc'd bitbang_i2c_interface struct

2019-07-03 Thread Philippe Mathieu-Daudé
On 7/2/19 11:52 PM, BALATON Zoltan wrote: > On Tue, 2 Jul 2019, Peter Maydell wrote: >> Currently the bitbang_i2c_init() function allocates a >> bitbang_i2c_interface struct which it returns.  This is unfortunate >> because it means that if the function is used from a DeviceState >> init method the

Re: [Qemu-devel] [PATCH] Add ati vgabios to INSTALL_BLOBS.

2019-07-03 Thread Philippe Mathieu-Daudé
On 7/3/19 6:52 AM, Gerd Hoffmann wrote: > Fixes: 0cca7e7bfd6c81cc3c29ec2b3a0a98954c4ba71a > Reported-by: Bruce Rogers > Signed-off-by: Gerd Hoffmann > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index cfb18f152544..452f63dc8429 1

[Qemu-devel] [PULL 0/4] Vga 20190703 patches

2019-07-03 Thread Gerd Hoffmann
The following changes since commit 506179e42112be77bfd071f050b15762d3b2cd43: Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.1-20190702' into staging (2019-07-02 18:56:44 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/vga-20190703-pu

Re: [Qemu-devel] [PULL 0/3] Trivial branch patches

2019-07-03 Thread Philippe Mathieu-Daudé
On 7/2/19 8:05 PM, Laurent Vivier wrote: > Le 02/07/2019 à 19:05, no-re...@patchew.org a écrit : >> Patchew URL: >> https://patchew.org/QEMU/20190702123713.14396-1-laur...@vivier.eu/ > ... >> PASS 2 qmp-test /x86_64/qmp/oob >> PASS 3 qmp-test /x86_64/qmp/preconfig >> PASS 4 qmp-test /x86_64/qmp/mi

Re: [Qemu-devel] [PATCH v10 2/6] ppc: spapr: Introduce FWNMI capability

2019-07-03 Thread Aravinda Prasad
On Wednesday 03 July 2019 08:33 AM, David Gibson wrote: > On Tue, Jul 02, 2019 at 11:54:26AM +0530, Aravinda Prasad wrote: >> >> >> On Tuesday 02 July 2019 09:21 AM, David Gibson wrote: >>> On Wed, Jun 12, 2019 at 02:51:04PM +0530, Aravinda Prasad wrote: Introduce the KVM capability KVM_CAP

[Qemu-devel] [Bug 1818122] Re: QEMU 3.1 makes libxslt to crash on ppc64

2019-07-03 Thread DDoSolitary
@pmaydell I just tested the latest commit in git master and still got the same error. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1818122 Title: QEMU 3.1 makes libxslt to crash on ppc64 Status i

[Qemu-devel] [Bug 1834613] Re: Crypto related operations failing on Alpine Linux on QEMU 4.0

2019-07-03 Thread DDoSolitary
@laurent-vivier I just tested the binary built from git master and the error went away. Thanks. ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1

Re: [Qemu-devel] [Qemu-block] [PATCH 0/1] RFC: don't obey the block device max transfer len / max segments for block devices

2019-07-03 Thread Stefan Hajnoczi
On Sun, Jun 30, 2019 at 06:08:54PM +0300, Maxim Levitsky wrote: > It looks like Linux block devices, even in O_DIRECT mode don't have any user > visible > limit on transfer size / number of segments, which underlying block device > can have. > The block layer takes care of enforcing these limits

Re: [Qemu-devel] [PATCH v3 0/4] Introduce the microvm machine type

2019-07-03 Thread Stefan Hajnoczi
On Tue, Jul 02, 2019 at 02:11:02PM +0200, Sergio Lopez wrote: > Microvm is a machine type inspired by both NEMU and Firecracker, and > constructed after the machine model implemented by the latter. > > It's main purpose is providing users a KVM-only machine type with fast > boot times, minimal att

Re: [Qemu-devel] Should memory hotplug work with vhost-user backends?

2019-07-03 Thread Stefan Hajnoczi
On Tue, Jul 02, 2019 at 10:08:54PM +, Raphael Norwitz wrote: > For background I am trying to work around a ram slot limit imposed by the > vhost-user protocol. We are having trouble reconciling the comment here: > https://github.com/qemu/qemu/blob/master/hw/virtio/vhost-user.c#L333 that > “

Re: [Qemu-devel] [PATCH] net/colo-compare.c: Fix memory leak and code style issue.

2019-07-03 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190703013805.2722-1-chen.zh...@intel.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash mak

Re: [Qemu-devel] [PULL 0/4] Build system patches for 2019-07-02

2019-07-03 Thread Peter Maydell
On Wed, 3 Jul 2019 at 06:18, Markus Armbruster wrote: > > Peter Maydell writes: > > This seems to break the incremental builds (most hosts): > > > > make: Entering directory '/home/petmay01/qemu-for-merges/build/w64' > > make: *** No rule to make target 'subdir-slirp', needed by > > 'config-host.

Re: [Qemu-devel] [PATCH v2 3/6] hw/vfio/common: Do not replay IOMMU mappings in nested case

2019-07-03 Thread Peter Xu
On Wed, Jul 03, 2019 at 11:04:38AM +0200, Auger Eric wrote: > Hi Peter, Hi, Eric, > > On 7/3/19 7:41 AM, Peter Xu wrote: > > On Mon, Jul 01, 2019 at 11:30:31AM +0200, Eric Auger wrote: > >> In nested mode, the stage 1 translation tables are owned by > >> the guest and there is no caching on host

Re: [Qemu-devel] [PATCH] net/colo-compare.c: Fix memory leak and code style issue.

2019-07-03 Thread Peter Maydell
On Wed, 3 Jul 2019 at 02:42, Zhang Chen wrote: > > From: Zhang Chen > > Address Peter's comments in patch "COLO-compare:Add colo-compare > remote notify support". > > Signed-off-by: Zhang Chen > --- > net/colo-compare.c | 13 ++--- > 1 file changed, 6 insertions(+), 7 deletions(-) > > d

Re: [Qemu-devel] What's IOMMUMemoryRegion's super?

2019-07-03 Thread Markus Armbruster
Paolo Bonzini writes: > On 03/07/19 07:05, Markus Armbruster wrote: >> static const TypeInfo iommu_memory_region_info = { >> .parent = TYPE_MEMORY_REGION, >> .name = TYPE_IOMMU_MEMORY_REGION, >> .class_size = sizeof(IOMMUMemoryRegionCl

Re: [Qemu-devel] [PATCH v2 3/6] hw/vfio/common: Do not replay IOMMU mappings in nested case

2019-07-03 Thread Auger Eric
Hi Peter, On 7/3/19 12:21 PM, Peter Xu wrote: > On Wed, Jul 03, 2019 at 11:04:38AM +0200, Auger Eric wrote: >> Hi Peter, > > Hi, Eric, > >> >> On 7/3/19 7:41 AM, Peter Xu wrote: >>> On Mon, Jul 01, 2019 at 11:30:31AM +0200, Eric Auger wrote: In nested mode, the stage 1 translation tables are

Re: [Qemu-devel] [PATCH] vfio-ccw: Test vfio_set_irq_signaling() return value

2019-07-03 Thread no-reply
Patchew URL: https://patchew.org/QEMU/156209642116.14915.9598593247782519613.st...@gimli.home/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!

[Qemu-devel] [PATCH v1 1/3] qcow2: introduce compression type feature

2019-07-03 Thread Denis Plotnikov
The patch adds some preparation parts for incompatible compression type feature to QCOW2 header that indicates that *all* compressed clusters must be (de)compressed using a certain compression type. It is implied that the compression type is set on the image creation and can be changed only later

[Qemu-devel] [PATCH 0/3] Misc ati-vga fixes

2019-07-03 Thread BALATON Zoltan
These fix color and rendering problems with MorphOS although some more glitches are still remaining. BALATON Zoltan (3): ati-vga: Improve readability of ati_2d_blt function ati-vga: Fix frame buffer endianness for big endian target ati-vga: Fix reverse bit blts hw/display/ati.c| 1 +

[Qemu-devel] [PATCH v1 0/3] add zstd cluster compression

2019-07-03 Thread Denis Plotnikov
change log: v1: * extend qcow2 header instead of adding a new incompatible extension header specification re-written accordingly * enable zstd compression via config * fix zstd (de)compression functions * fix comments/description * fix function naming --- The goal of the

[Qemu-devel] [PATCH v1 3/3] qcow2: add zstd cluster compression

2019-07-03 Thread Denis Plotnikov
zstd significantly reduces cluster compression time. It provides better compression performance maintaining the same level of compression ratio in comparison with zlib, which, by the moment, has been the only compression method available. The performance test results: Test compresses and decompres

[Qemu-devel] [PATCH v1 2/3] qcow2: rework the cluster compression routine

2019-07-03 Thread Denis Plotnikov
The patch allow to process image compression type defined in the image header and choose an appropriate method for image clusters (de)compression. Signed-off-by: Denis Plotnikov --- block/qcow2.c | 93 --- 1 file changed, 73 insertions(+), 20 delet

[Qemu-devel] [PATCH 3/3] ati-vga: Fix reverse bit blts

2019-07-03 Thread BALATON Zoltan
The pixman library only supports blts with left to right, top to bottom order but the ATI VGA engine can also do different directions. Fix support for these via a temporary buffer for now. This fixes rendering issues related to such blts (such as moving windows) but some other glitches still remain

[Qemu-devel] [PATCH 1/3] ati-vga: Improve readability of ati_2d_blt function

2019-07-03 Thread BALATON Zoltan
Move common parts before the switch to remove code duplication and improve readibility. Signed-off-by: BALATON Zoltan --- hw/display/ati_2d.c | 80 ++--- 1 file changed, 33 insertions(+), 47 deletions(-) diff --git a/hw/display/ati_2d.c b/hw/displ

Re: [Qemu-devel] [PATCH for-4.1] hw/i2c/bitbang_i2c: Use in-place rather than malloc'd bitbang_i2c_interface struct

2019-07-03 Thread BALATON Zoltan
On Wed, 3 Jul 2019, Philippe Mathieu-Daudé wrote: On 7/2/19 11:52 PM, BALATON Zoltan wrote: On Tue, 2 Jul 2019, Peter Maydell wrote: Currently the bitbang_i2c_init() function allocates a bitbang_i2c_interface struct which it returns.? This is unfortunate because it means that if the function is

[Qemu-devel] [PATCH 2/3] ati-vga: Fix frame buffer endianness for big endian target

2019-07-03 Thread BALATON Zoltan
The extended mode frame buffer should be little endian even when emulating big endian machine (such as PPC). This fixes color problems with MorphOS. Signed-off-by: BALATON Zoltan --- hw/display/ati.c| 1 + hw/display/ati_2d.c | 10 +- 2 files changed, 6 insertions(+), 5 deletions(-)

Re: [Qemu-devel] [PULL 0/4] Build system patches for 2019-07-02

2019-07-03 Thread Markus Armbruster
Peter Maydell writes: > On Wed, 3 Jul 2019 at 06:18, Markus Armbruster wrote: >> >> Peter Maydell writes: >> > This seems to break the incremental builds (most hosts): >> > >> > make: Entering directory '/home/petmay01/qemu-for-merges/build/w64' >> > make: *** No rule to make target 'subdir-sli

Re: [Qemu-devel] [PULL 00/12] MIPS queue for July 2nd, 2019

2019-07-03 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1562085328-5126-1-git-send-email-aleksandar.marko...@rt-rk.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: [Qemu-devel] [PATCH 2/2] test: replace gtester with a TAP driver

2019-07-03 Thread Paolo Bonzini
On 01/07/19 16:42, Philippe Mathieu-Daudé wrote: > $ make check-qtest-x86_64 GTESTER_OPTIONS="-p /x86_64/acpi" > > But this commit removed the use of $GTESTER_OPTIONS, however it is > still documented: > > $ make check-help > [...] > The variable SPEED can be set to control the gtester speed sett

Re: [Qemu-devel] [PATCH 3/4] Makefile: Rename targets for make recursion

2019-07-03 Thread Markus Armbruster
Peter pointed out that this makes an incremental build without -k fail once. By "once", I mean it works fine when you retry. Squashing in the appended patch to avoid this inconvenience. diff --git a/Makefile b/Makefile index e68982bd99..34bbcfc590 100644 --- a/Makefile +++ b/Makefile @@ -500,6

[Qemu-devel] [PULL v2 4/4] Makefile: Reuse all's recursion machinery for clean and install

2019-07-03 Thread Markus Armbruster
Targets "clean" and "install" run make recursively in a for loop. This ignores -j and -k. Target "all" depends on SUBDIR/all to recurse into each SUBDIR. Behaves nicely with -j and -k. Put that to use for "clean" and "install": depend on SUBDIR/clean or SUBDIR/install, respectively, and delete t

[Qemu-devel] [PULL v2 1/4] Makefile: Remove code to smooth transition to config.status

2019-07-03 Thread Markus Armbruster
When commit bdf523e6923 made configure generate config.status, it added a fallback to Makefile to smooth the transition, with a TODO "code can be removed after QEMU 1.7." It's been more than five years. Remove it. Signed-off-by: Markus Armbruster Reviewed-by: Richard Henderson Reviewed-by: Phil

[Qemu-devel] [PULL v2 0/4] Build system patches for 2019-07-02

2019-07-03 Thread Markus Armbruster
The following changes since commit ab200dafc0e8a9925bb0ad0be478621f5f117c95: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2019-07-02 10:17:54 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-build-2019-07-02-v

[Qemu-devel] [PULL v2 2/4] Makefile: Drop bogus cleaning of $(ALL_SUBDIRS)/qemu-options.def

2019-07-03 Thread Markus Armbruster
When commit df2943ba3c7 moved "rm -f qemu-options.def" from distclean to clean, it also added "rm -f $$d/qemu-options.def" to the for d in $(ALL_SUBDIRS) loop. That file doesn't exist. Remove the mistaken rm. Signed-off-by: Markus Armbruster Reviewed-by: Richard Henderson Reviewed-by: Philippe

Re: [Qemu-devel] [PATCH 3/4] Makefile: Rename targets for make recursion

2019-07-03 Thread Philippe Mathieu-Daudé
On 7/3/19 1:24 PM, Markus Armbruster wrote: > Peter pointed out that this makes an incremental build without -k fail > once. By "once", I mean it works fine when you retry. Squashing in the > appended patch to avoid this inconvenience. > > > diff --git a/Makefile b/Makefile > index e68982bd99..

  1   2   3   4   >