[Qemu-devel] [PULL 30/49] target/ppc: introduce separate VSX_CMP macro for xvcmp* instructions

2019-07-02 Thread David Gibson
From: Mark Cave-Ayland Rather than perform the VSR register decoding within the helper itself, introduce a new VSX_CMP macro which performs the decode based upon xT, xA and xB at translation time. Subsequent commits will make the same changes for other instructions however the xvcmp* instruction

[Qemu-devel] [PULL 33/49] target/ppc: introduce GEN_VSX_HELPER_X2 macro to fpu_helper.c

2019-07-02 Thread David Gibson
From: Mark Cave-Ayland Rather than perform the VSR register decoding within the helper itself, introduce a new GEN_VSX_HELPER_X2 macro which performs the decode based upon xT and xB at translation time. With the previous change to the xscvqpdp generator and helper functions the opcode parameter

[Qemu-devel] [PULL 46/49] ppc/xive: Make the PIPR register readonly

2019-07-02 Thread David Gibson
From: Cédric Le Goater When the hypervisor (KVM) dispatches a vCPU on a HW thread, it restores its thread interrupt context. The Pending Interrupt Priority Register (PIPR) is computed from the Interrupt Pending Buffer (IPB) and stores should not be allowed to change its value. Fixes: 207d9fe9851

[Qemu-devel] [PULL 19/49] hw/ppc/prep: Drop useless CONFIG_KVM ifdefery

2019-07-02 Thread David Gibson
From: Greg Kurz kvm_enabled() expands to (0) when CONFIG_KVM is not defined. It is likely that the compiler will optimize the code out. And even if it doesn't, we have a stub for kvmppc_get_hypercall(). Signed-off-by: Greg Kurz Message-Id: <156051054630.224162.6140707722034383410.st...@bahia.la

Re: [Qemu-devel] [PATCH v1 1/1] hw/scsi: Report errors and sense to guests through scsi-block

2019-07-02 Thread Shinichiro Kawasaki
On 7/1/19 8:56 PM, Paolo Bonzini wrote: > On 01/07/19 12:14, Shinichiro Kawasaki wrote: >> I observe four of them listed below in sense data, >> when I ran basic operations to the zoned storage from the guest via >> scsi-block. >> >> 21h 04h: UNALIGNED WRITE COMMAND >> 21h 05h: WRITE B

[Qemu-devel] [PULL 47/49] ppc/pnv: Rework cache watch model of PnvXIVE

2019-07-02 Thread David Gibson
From: Cédric Le Goater When the software modifies the XIVE internal structures, ESB, EAS, END, NVT, it also must update the caches of the different XIVE sub-engines. HW offers a set of common interface for such purpose. The CWATCH_SPEC register defines the block/index of the target and a set of

[Qemu-devel] [PULL 27/49] ppc: Introduce kvmppc_set_reg_tb_offset() helper

2019-07-02 Thread David Gibson
From: Greg Kurz Introduce a KVM helper and its stub instead of guarding the code with CONFIG_KVM. Signed-off-by: Greg Kurz Message-Id: <156051055736.224162.11641594431517798715.st...@bahia.lan> Signed-off-by: David Gibson --- hw/ppc/ppc.c | 5 + target/ppc/kvm.c | 9 +

[Qemu-devel] [PULL 32/49] target/ppc: introduce separate generator and helper for xscvqpdp

2019-07-02 Thread David Gibson
From: Mark Cave-Ayland Rather than perform the VSR register decoding within the helper itself, introduce a new generator and helper function which perform the decode based upon xT and xB at translation time. The xscvqpdp helper is the only 2 parameter xT/xB implementation that requires the opcod

Re: [Qemu-devel] [PULL 57/60] target/ppc: add HV support for POWER9

2019-07-02 Thread Cédric Le Goater
On 02/07/2019 02:14, David Gibson wrote: > On Mon, Jul 01, 2019 at 11:45:23AM +0200, Philippe Mathieu-Daudé wrote: >> On 7/1/19 7:04 AM, David Gibson wrote: >>> On Fri, Jun 28, 2019 at 03:20:32PM +0200, Philippe Mathieu-Daudé wrote: Hi, On 3/12/19 8:58 PM, Cédric Le Goater wrote: >>>

[Qemu-devel] [PULL 49/49] spapr/xive: Add proper rollback to kvmppc_xive_connect()

2019-07-02 Thread David Gibson
From: Greg Kurz Make kvmppc_xive_disconnect() able to undo the changes of a partial execution of kvmppc_xive_connect() and use it to perform rollback. Signed-off-by: Greg Kurz Reviewed-by: Cédric Le Goater Message-Id: <156198735673.293938.7313195993600841641.stgit@bahia> Signed-off-by: David G

[Qemu-devel] [PULL 39/49] target/ppc: decode target register in VSX_VECTOR_LOAD_STORE_LENGTH at translation time

2019-07-02 Thread David Gibson
From: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Reviewed-by: Richard Henderson Message-Id: <20190616123751.781-14-mark.cave-ayl...@ilande.co.uk> Signed-off-by: David Gibson --- target/ppc/helper.h | 8 ++--- target/ppc/mem_helper.c | 6 ++-- target/ppc/tra

Re: [Qemu-devel] [PATCH v2 0/9] hw/block/pflash_cfi01: Add DeviceReset() handler

2019-07-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190702001301.4768-1-phi...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash make do

Re: [Qemu-devel] [Qemu-riscv] [PULL 33/34] roms: Add OpenSBI version 0.3

2019-07-02 Thread Anup Patel
On Tue, Jul 2, 2019 at 2:57 AM Alistair Francis wrote: > > On Mon, 2019-07-01 at 19:13 +0100, Peter Maydell wrote: > > On Mon, 1 Jul 2019 at 19:09, Alistair Francis < > > alistair.fran...@wdc.com> wrote: > > > On Mon, 2019-07-01 at 19:01 +0100, Peter Maydell wrote: > > > > On Mon, 1 Jul 2019 at 18

Re: [Qemu-devel] [PATCH v10 2/6] ppc: spapr: Introduce FWNMI capability

2019-07-02 Thread Aravinda Prasad
On Tuesday 02 July 2019 09:21 AM, David Gibson wrote: > On Wed, Jun 12, 2019 at 02:51:04PM +0530, Aravinda Prasad wrote: >> Introduce the KVM capability KVM_CAP_PPC_FWNMI so that >> the KVM causes guest exit with NMI as exit reason >> when it encounters a machine check exception on the >> addres

Re: [Qemu-devel] [PATCH v7 1/4] VirtIO-RNG: Update default entropy source to `/dev/urandom`

2019-07-02 Thread Laurent Vivier
Le 29/05/2019 à 16:31, Laurent Vivier a écrit : > From: Kashyap Chamarthy > > When QEMU exposes a VirtIO-RNG device to the guest, that device needs a > source of entropy, and that source needs to be "non-blocking", like > `/dev/urandom`. However, currently QEMU defaults to the problematic > `/de

Re: [Qemu-devel] [PULL 00/49] ppc-for-4.1 queue 20190702

2019-07-02 Thread no-reply
/49] ppc-for-4.1 queue 20190702 === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT

Re: [Qemu-devel] [PATCH v4 3/5] 9p: Added virtfs option "remap_inodes"

2019-07-02 Thread Greg Kurz
On Sat, 29 Jun 2019 12:20:49 +0200 Christian Schoenebeck wrote: > On Freitag, 28. Juni 2019 16:23:08 CEST Greg Kurz wrote: > > > > This feature applies to all backends IIUC. We don't really care for the > > > > synth backend since it generates non-colliding inode numbers by design, > > > > but th

Re: [Qemu-devel] [PATCH v2 2/4] hw/i386: Add an Intel MPTable generator

2019-07-02 Thread Gerd Hoffmann
On Mon, Jul 01, 2019 at 04:47:03PM +0200, Sergio Lopez wrote: > Add a helper function (mptable_generate) for generating an Intel > MPTable according to version 1.4 of the specification. > > This is needed for the microvm machine type implementation. Firmware should do this IMHO (qboot or seabios)

Re: [Qemu-devel] Question about bdrv_co_invalidate_cache

2019-07-02 Thread Kevin Wolf
Am 01.07.2019 um 18:42 hat Yury Kotov geschrieben: > Hi, > > I just want to clarify the purpose of bdrv_co_invalidate_cache callback. > IIUC on of the purposes of this callback is to "activate" BDRV (opposite of > the > bdrv_inactivate callback) on migration end, right? > > E.g, if we have a cus

Re: [Qemu-devel] [PATCH v3 3/3] net: tap: refactor net_bridge_run_helper routine

2019-07-02 Thread P J P
Hello Li, +-- On Mon, 1 Jul 2019, Li Qiang wrote --+ | You do two things here(avoid buffer formatting and get rid of calling | shell), I would suggest you split these into split patch. Both are related, 'helper_cmd' formatting was used with the shell invocation as: helper_cmd = "qemu-bridg

Re: [Qemu-devel] [Qemu-trivial] [PATCH] docs/devel/testing: Fix typo in dockerfile path

2019-07-02 Thread Laurent Vivier
Le 28/06/2019 à 15:08, Liam Merwick a écrit : > Signed-off-by: Liam Merwick > --- > docs/devel/testing.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst > index da2d0fc9646f..3ef50a61db4d 100644 > --- a/docs/devel/testing

Re: [Qemu-devel] [PATCH v2 4/4] hw/i386: Introduce the microvm machine type

2019-07-02 Thread Gerd Hoffmann
Hi, > Microvm only supports booting PVH-enabled Linux ELF images. Booting > other PVH-enabled kernels may be possible, but due to the lack of ACPI > and firmware, we're relying on the command line for specifying the > location of the virtio-mmio transports. If there's an interest on > using this

Re: [Qemu-devel] [PATCH 2/4] hw/virtio: Factorize virtio-mmio headers

2019-07-02 Thread Gerd Hoffmann
> > > I am not sure we want a new machine with 0.X mmio devices. > > > Especially considering that virtio-mmio does not have support for > > > transitional devices. > > > > What are the practical implications of that? > > On the plus side, this means we don't need to maintain a bunch of hacks > f

Re: [Qemu-devel] [PATCH v2 4/4] hw/i386: Introduce the microvm machine type

2019-07-02 Thread Stefano Garzarella
On Mon, Jul 01, 2019 at 04:47:05PM +0200, Sergio Lopez wrote: > Microvm is a machine type inspired by both NEMU and Firecracker, and > constructed after the machine model implemented by the latter. > > It's main purpose is providing users a KVM-only machine type with fast > boot times, minimal att

Re: [Qemu-devel] [PATCH v2 2/4] hw/i386: Add an Intel MPTable generator

2019-07-02 Thread Sergio Lopez
Gerd Hoffmann writes: > On Mon, Jul 01, 2019 at 04:47:03PM +0200, Sergio Lopez wrote: >> Add a helper function (mptable_generate) for generating an Intel >> MPTable according to version 1.4 of the specification. >> >> This is needed for the microvm machine type implementation. > > Firmware shou

Re: [Qemu-devel] [PATCH v2 4/4] hw/i386: Introduce the microvm machine type

2019-07-02 Thread Sergio Lopez
Gerd Hoffmann writes: > Hi, > >> Microvm only supports booting PVH-enabled Linux ELF images. Booting >> other PVH-enabled kernels may be possible, but due to the lack of ACPI >> and firmware, we're relying on the command line for specifying the >> location of the virtio-mmio transports. If the

Re: [Qemu-devel] [PATCH] migration: move port_attr inside CONFIG_LINUX

2019-07-02 Thread Philippe Mathieu-Daudé
On 7/1/19 6:47 PM, Alex Bennée wrote: > Otherwise the FreeBSD compiler complains about an unused variable. > > Signed-off-by: Alex Bennée > --- > migration/rdma.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/migration/rdma.c b/migration/rdma.c > index 74cb2aa9f9..3

Re: [Qemu-devel] [PATCH v2 4/4] hw/i386: Introduce the microvm machine type

2019-07-02 Thread Sergio Lopez
Stefano Garzarella writes: > On Mon, Jul 01, 2019 at 04:47:05PM +0200, Sergio Lopez wrote: >> Microvm is a machine type inspired by both NEMU and Firecracker, and >> constructed after the machine model implemented by the latter. >> >> It's main purpose is providing users a KVM-only machine type

Re: [Qemu-devel] [PATCH v24 1/7] target/avr: Add outward facing interfaces and core CPU logic

2019-07-02 Thread Igor Mammedov
On Mon, 1 Jul 2019 06:59:39 -0700 Michael Rolnik wrote: > should I use *-avr-cpu* suffix or can I do without it. i.e. *xyz* instead > of *xyz-avr-cpu* I think our convention for cpu types is: foo-target-cpu suffix. So I'd use *-avr-cpu form. Yes it will be a bit verbose on CLI but it really doe

Re: [Qemu-devel] [PATCH 00/10] hw/pci-host: Clean the GT64120 north bridge

2019-07-02 Thread Philippe Mathieu-Daudé
On 7/1/19 8:39 PM, Aleksandar Markovic wrote: > On Jul 1, 2019 7:46 PM, "Philippe Mathieu-Daudé" wrote: >> >> Hi Aleksandar, >> >> On 7/1/19 7:16 PM, Aleksandar Markovic wrote: >>> >>> On Jun 25, 2019 12:31 AM, "Philippe Mathieu-Daudé" >> > wrote: Hi, Th

Re: [Qemu-devel] [PATCH v5 6/8] hmat acpi: Build Memory Subsystem Address Range Structure(s) in ACPI HMAT

2019-07-02 Thread Tao Xu
On 7/1/2019 7:25 PM, Igor Mammedov wrote: On Fri, 14 Jun 2019 23:56:24 +0800 Tao Xu wrote: ... @@ -2710,6 +2711,8 @@ void acpi_build(AcpiBuildTables *tables, MachineState *machine) acpi_add_table(table_offsets, tables_blob); build_slit(tables_blob, tables->linker,

Re: [Qemu-devel] [PATCH v2 0/7] Qemu virtio pmem device

2019-07-02 Thread Wei Yang
On Wed, Jun 19, 2019 at 03:19:00PM +0530, Pankaj Gupta wrote: > This patch series has implementation for "virtio pmem" > device. "virtio pmem" is persistent memory(nvdimm) device in > guest which allows to bypass the guest page cache. This > also implements a VIRTIO based asynchronous flush mechan

Re: [Qemu-devel] [PATCH v2 5/7] hmp: Handle virtio-pmem when printing memory device infos

2019-07-02 Thread Wei Yang
On Wed, Jun 19, 2019 at 03:19:05PM +0530, Pankaj Gupta wrote: >From: David Hildenbrand > >Print the memory device info just like for PCDIMM/NVDIMM. > >Reviewed-by: Dr. David Alan Gilbert >Signed-off-by: David Hildenbrand This one not apply on latest code. Need to rebase it. >--- > hmp.c | 27 +

Re: [Qemu-devel] [PATCH] tests: Update DSDT ACPI table for arm/virt board with PCDIMM related changes

2019-07-02 Thread Philippe Mathieu-Daudé
Hi Eric, On 7/1/19 9:08 PM, Eric Auger wrote: > PCDIMM hotplug addition updated the DSDT. Update the reference table. Can you point the commit sha1 please? > Signed-off-by: Eric Auger > --- > tests/data/acpi/virt/DSDT | Bin 18476 -> 18493 bytes > 1 file changed, 0 insertions(+), 0 deletions(-

Re: [Qemu-devel] [PATCH v2 1/2] qdev: Add a no default uuid property

2019-07-02 Thread Philippe Mathieu-Daudé
Cc'ing Markus & Eric. On 7/1/19 8:30 PM, miny...@acm.org wrote: > From: Corey Minyard > > This is for IPMI, which will behave differently if the UUID is > not set. > > Signed-off-by: Corey Minyard > Cc: Fam Zheng > Cc: Michael S. Tsirkin > Cc: Marc-André Lureau > --- > include/hw/qdev-prop

Re: [Qemu-devel] [PATCH] tests: Update DSDT ACPI table for arm/virt board with PCDIMM related changes

2019-07-02 Thread Auger Eric
Hi Philippe, On 7/2/19 10:56 AM, Philippe Mathieu-Daudé wrote: > Hi Eric, > > On 7/1/19 9:08 PM, Eric Auger wrote: >> PCDIMM hotplug addition updated the DSDT. Update the reference table. > > Can you point the commit sha1 please? this follows Peter's make check failure report sent yesterday and

Re: [Qemu-devel] [PATCH v2 2/2] ipmi: Add a UUID device property

2019-07-02 Thread Philippe Mathieu-Daudé
On 7/1/19 8:31 PM, miny...@acm.org wrote: > From: Corey Minyard > > Using the UUID that qemu generates probably isn't the best thing > to do, allow it to be passed in via properties, and use QemuUUID > for the type. > > If the UUID is not set, return an unsupported command error. This > way we

Re: [Qemu-devel] [PULL 0/6] Vga 20190628 patches

2019-07-02 Thread Peter Maydell
On Fri, 28 Jun 2019 at 11:40, Gerd Hoffmann wrote: > > The following changes since commit 474f3938d79ab36b9231c9ad3b5a9314c2aeacde: > > Merge remote-tracking branch > 'remotes/amarkovic/tags/mips-queue-jun-21-2019' into staging (2019-06-21 > 15:40:50 +0100) > > are available in the Git reposit

Re: [Qemu-devel] [PATCH 1/6] m68k cpu instantiation comments improvements

2019-07-02 Thread Laurent Vivier
Le 16/06/2019 à 16:22, Lucien Murray-Pitts a écrit : > Improvement in comments for the instantiation functions. > This is to highlight what each cpu class, in the 68000 series, contains > in terms of instructions/features. > > Signed-off-by: Lucien Murray-Pitts > --- > target/m68k/cpu.c | 47 +++

Re: [Qemu-devel] [PULL 57/60] target/ppc: add HV support for POWER9

2019-07-02 Thread Philippe Mathieu-Daudé
On 7/2/19 8:13 AM, Cédric Le Goater wrote: > On 02/07/2019 02:14, David Gibson wrote: >> On Mon, Jul 01, 2019 at 11:45:23AM +0200, Philippe Mathieu-Daudé wrote: >>> On 7/1/19 7:04 AM, David Gibson wrote: On Fri, Jun 28, 2019 at 03:20:32PM +0200, Philippe Mathieu-Daudé wrote: > Hi, > >>

Re: [Qemu-devel] [PATCH v2 5/9] hw/block/pflash_cfi01: Add the DeviceReset() handler

2019-07-02 Thread Peter Maydell
On Tue, 2 Jul 2019 at 04:16, John Snow wrote: > Does reset always get called as part of realize, really? > > Or are we just trusting that the device is probably going to get reset > by the guest during bringup? Reset is not called "as part of realize", but it is guaranteed to be called after real

Re: [Qemu-devel] [PATCH v2 1/9] qmp: Add "alias-of" field to query-cpu-definitions

2019-07-02 Thread Daniel P . Berrangé
On Thu, Jun 27, 2019 at 09:28:36PM -0300, Eduardo Habkost wrote: > Management software will be expected to resolve CPU model name > aliases using the new field. > > Signed-off-by: Eduardo Habkost > --- > Changes v1 -> v2: > * (none) > > Cc: Eric Blake > Cc: Markus Armbruster > --- > qapi/targ

Re: [Qemu-devel] [PATCH 2/6] Cascade m68k_features by m680xx_cpu_initfn() to improve readability

2019-07-02 Thread Laurent Vivier
Le 16/06/2019 à 16:22, Lucien Murray-Pitts a écrit : > The m680XX_cpu_initfn functions have been rearranged to cascade starting from > the base 68000, so that the 68010 then inherits from this, and so on until the > 68060. > > This makes it simpler to track features since in most cases the m68k we

Re: [Qemu-devel] [PATCH v2 2/9] i386: Add x-force-features option for testing

2019-07-02 Thread Daniel P . Berrangé
On Thu, Jun 27, 2019 at 09:28:37PM -0300, Eduardo Habkost wrote: > Add a new option that can be used to disable feature flag > filtering. This will allow CPU model compatibility test cases to > work without host hardware dependencies. > > Signed-off-by: Eduardo Habkost > --- > Changes v1 -> v2:

Re: [Qemu-devel] [PATCH v2 3/9] i386: Get model-id from CPU object on "-cpu help"

2019-07-02 Thread Daniel P . Berrangé
On Thu, Jun 27, 2019 at 09:28:38PM -0300, Eduardo Habkost wrote: > When introducing versioned CPU models, the string at > X86CPUDefinition::model_id might not be the model-id we'll really > use. Instantiate a CPU object and check the model-id property on > "-cpu help" It would help understanding

Re: [Qemu-devel] [PATCH v2 2/4] hw/i386: Add an Intel MPTable generator

2019-07-02 Thread Gerd Hoffmann
On Tue, Jul 02, 2019 at 10:37:11AM +0200, Sergio Lopez wrote: > > Gerd Hoffmann writes: > > > On Mon, Jul 01, 2019 at 04:47:03PM +0200, Sergio Lopez wrote: > >> Add a helper function (mptable_generate) for generating an Intel > >> MPTable according to version 1.4 of the specification. > >> > >>

Re: [Qemu-devel] [PATCH v2 5/9] hw/block/pflash_cfi01: Add the DeviceReset() handler

2019-07-02 Thread Philippe Mathieu-Daudé
On 7/2/19 11:23 AM, Peter Maydell wrote: > On Tue, 2 Jul 2019 at 04:16, John Snow wrote: >> Does reset always get called as part of realize, really? >> >> Or are we just trusting that the device is probably going to get reset >> by the guest during bringup? > > Reset is not called "as part of rea

Re: [Qemu-devel] [PATCH v2 4/9] i386: Register versioned CPU models

2019-07-02 Thread Daniel P . Berrangé
On Thu, Jun 27, 2019 at 09:28:39PM -0300, Eduardo Habkost wrote: > Add support for registration of multiple versions of CPU models. > > The existing CPU models will be registered with a "-v1" suffix. > > The -noTSX, -IBRS, and -IBPB CPU model variants will become > versions of the original models

Re: [Qemu-devel] [PATCH v2 5/9] i386: Define -IBRS, -noTSX, -IBRS versions of CPU models

2019-07-02 Thread Daniel P . Berrangé
On Thu, Jun 27, 2019 at 09:28:40PM -0300, Eduardo Habkost wrote: > Add versions of CPU models that are equivalent to their -IBRS, > -noTSX and -IBRS variants. > > The separate variants will eventually be removed and become > aliases for these CPU versions. > > Signed-off-by: Eduardo Habkost > --

Re: [Qemu-devel] [PATCH v2 6/9] i386: Replace -noTSX, -IBRS, -IBPB CPU models with aliases

2019-07-02 Thread Daniel P . Berrangé
On Thu, Jun 27, 2019 at 09:28:41PM -0300, Eduardo Habkost wrote: > The old CPU models will be just aliases for specific versions of > the original CPU models. > > Signed-off-by: Eduardo Habkost > --- > (New patch, added to series in v2) > --- > target/i386/cpu.c | 601 ++-

Re: [Qemu-devel] [PATCH] tests: Update DSDT ACPI table for arm/virt board with PCDIMM related changes

2019-07-02 Thread Philippe Mathieu-Daudé
On 7/2/19 11:01 AM, Auger Eric wrote: > Hi Philippe, > On 7/2/19 10:56 AM, Philippe Mathieu-Daudé wrote: >> Hi Eric, >> >> On 7/1/19 9:08 PM, Eric Auger wrote: >>> PCDIMM hotplug addition updated the DSDT. Update the reference table. >> >> Can you point the commit sha1 please? > > this follows Pet

Re: [Qemu-devel] [PATCH 3/6] Improved comments on m68k_move_to/from helpers

2019-07-02 Thread Laurent Vivier
Le 16/06/2019 à 16:22, Lucien Murray-Pitts a écrit : > Added more detailed comments to each case of m68k_move_to/from helpers to list > the supported CPUs for that CR as they were wrong in some cases, and > missing some cpu classes in other cases. > > Signed-off-by: Lucien Murray-Pitts > --- > t

Re: [Qemu-devel] [PATCH v2 7/9] i386: Make unversioned CPU models be aliases

2019-07-02 Thread Daniel P . Berrangé
On Thu, Jun 27, 2019 at 09:28:42PM -0300, Eduardo Habkost wrote: > This will make unversioned CPU models behavior depend on the > machine type: > > * "pc-*-4.0" and older will not report them as aliases. > This is done to keep compatibility with older QEMU versions > after management software

Re: [Qemu-devel] [PATCH v10 4/6] target/ppc: Build rtas error log upon an MCE

2019-07-02 Thread Aravinda Prasad
On Tuesday 02 July 2019 09:33 AM, David Gibson wrote: > On Wed, Jun 12, 2019 at 02:51:21PM +0530, Aravinda Prasad wrote: >> Upon a machine check exception (MCE) in a guest address space, >> KVM causes a guest exit to enable QEMU to build and pass the >> error to the guest in the PAPR defined rta

Re: [Qemu-devel] [PATCH v2 8/9] docs: Deprecate CPU model runnability guarantees

2019-07-02 Thread Daniel P . Berrangé
On Thu, Jun 27, 2019 at 09:28:43PM -0300, Eduardo Habkost wrote: > Document that CPU model runnability guarantees won't apply to > unversioned CPU models anymore. > > Signed-off-by: Eduardo Habkost > --- > Changes v1 -> v2: > * (none) > > Cc: libvir-l...@redhat.com > --- > qemu-deprecated.texi

Re: [Qemu-devel] [PATCH v2 5/9] i386: Define -IBRS, -noTSX, -IBRS versions of CPU models

2019-07-02 Thread Daniel P . Berrangé
On Tue, Jul 02, 2019 at 10:40:00AM +0100, Daniel P. Berrangé wrote: > On Thu, Jun 27, 2019 at 09:28:40PM -0300, Eduardo Habkost wrote: > > Add versions of CPU models that are equivalent to their -IBRS, > > -noTSX and -IBRS variants. > > > > The separate variants will eventually be removed and beco

Re: [Qemu-devel] [PATCH] tests: Update DSDT ACPI table for arm/virt board with PCDIMM related changes

2019-07-02 Thread Auger Eric
Hi Philippe, On 7/2/19 11:43 AM, Philippe Mathieu-Daudé wrote: > On 7/2/19 11:01 AM, Auger Eric wrote: >> Hi Philippe, >> On 7/2/19 10:56 AM, Philippe Mathieu-Daudé wrote: >>> Hi Eric, >>> >>> On 7/1/19 9:08 PM, Eric Auger wrote: PCDIMM hotplug addition updated the DSDT. Update the reference t

Re: [Qemu-devel] [PATCH v2 9/9] i386: Add Cascadelake-Server-v2 CPU model

2019-07-02 Thread Daniel P . Berrangé
On Thu, Jun 27, 2019 at 09:28:44PM -0300, Eduardo Habkost wrote: > Add new version of Cascadelake-Server CPU model, setting > stepping=5 and enabling the IA32_ARCH_CAPABILITIES MSR > with some flags. > > The new feature will introduce a new host software requirement, > breaking our CPU model runna

Re: [Qemu-devel] [PATCH v3 3/3] net: tap: refactor net_bridge_run_helper routine

2019-07-02 Thread Daniel P . Berrangé
On Mon, Jul 01, 2019 at 06:05:58PM +0530, P J P wrote: > From: Prasad J Pandit > > Refactor 'net_bridge_run_helper' routine to avoid buffer > formatting to prepare 'helper_cmd' and using shell to invoke > helper command. Instead directly execute helper program with > due arguments. > > Signed-of

Re: [Qemu-devel] [PATCH 4/6] Add missing BUSCR/PCR CR defines, and BUSCR/PCR/CAAR CR to m68k_move_to/from

2019-07-02 Thread Laurent Vivier
Le 16/06/2019 à 16:23, Lucien Murray-Pitts a écrit : > The BUSCR/PCR CR defines were missing for 68060, and the move_to/from helper > functions were also missing a decode for the 68060 M68K_CR_CAAR CR register. > > Added missing defines, and respective decodes for all three CR registers to > the h

Re: [Qemu-devel] [PULL 0/1] Block patches

2019-07-02 Thread Peter Maydell
On Fri, 28 Jun 2019 at 14:13, Stefan Hajnoczi wrote: > > The following changes since commit 474f3938d79ab36b9231c9ad3b5a9314c2aeacde: > > Merge remote-tracking branch > 'remotes/amarkovic/tags/mips-queue-jun-21-2019' into staging (2019-06-21 > 15:40:50 +0100) > > are available in the Git repos

Re: [Qemu-devel] [PATCH v2 0/7] Qemu virtio pmem device

2019-07-02 Thread Pankaj Gupta
> > On Wed, Jun 19, 2019 at 03:19:00PM +0530, Pankaj Gupta wrote: > > This patch series has implementation for "virtio pmem" > > device. "virtio pmem" is persistent memory(nvdimm) device in > > guest which allows to bypass the guest page cache. This > > also implements a VIRTIO based asynchronou

Re: [Qemu-devel] [PULL 00/19] testing/next (tests/vm, Travis and hyperv build fix)

2019-07-02 Thread Philippe Mathieu-Daudé
On 7/1/19 5:58 PM, Alex Bennée wrote: > > Peter Maydell writes: > >> On Mon, 24 Jun 2019 at 14:43, Alex Bennée wrote: >>> >>> The following changes since commit 474f3938d79ab36b9231c9ad3b5a9314c2aeacde: >>> >>> Merge remote-tracking branch >>> 'remotes/amarkovic/tags/mips-queue-jun-21-2019'

Re: [Qemu-devel] [PATCH v2 4/4] hw/i386: Introduce the microvm machine type

2019-07-02 Thread Gerd Hoffmann
Hi, > > Can we get rid of the kernel command line hacking please? > > The virtio-mmio devices should be discoverable somehow. > > > > Device tree (as suggested by paolo) would work. > > Custom acpi device (simliar to fw_cfg) is another option. > > I'd tend to pick acpi, I wouldn't be surprised i

Re: [Qemu-devel] [PATCH v2 5/7] hmp: Handle virtio-pmem when printing memory device infos

2019-07-02 Thread Pankaj Gupta
> > On Wed, Jun 19, 2019 at 03:19:05PM +0530, Pankaj Gupta wrote: > >From: David Hildenbrand > > > >Print the memory device info just like for PCDIMM/NVDIMM. > > > >Reviewed-by: Dr. David Alan Gilbert > >Signed-off-by: David Hildenbrand > > This one not apply on latest code. Need to rebase i

Re: [Qemu-devel] [PATCH v2 0/9] hw/block/pflash_cfi01: Add DeviceReset() handler

2019-07-02 Thread Philippe Mathieu-Daudé
Cc'ing Marc-André, On 7/2/19 8:15 AM, no-re...@patchew.org wrote: > Patchew URL: https://patchew.org/QEMU/20190702001301.4768-1-phi...@redhat.com/ > > === TEST SCRIPT BEGIN === > #!/bin/bash > make docker-image-fedora V=1 NETWORK=1 > time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J

Re: [Qemu-devel] [PATCH v1 1/1] hw/scsi: Report errors and sense to guests through scsi-block

2019-07-02 Thread Paolo Bonzini
On 02/07/19 08:44, Shinichiro Kawasaki wrote: > On 7/1/19 8:56 PM, Paolo Bonzini wrote: >> On 01/07/19 12:14, Shinichiro Kawasaki wrote: >>> I observe four of them listed below in sense data, >>> when I ran basic operations to the zoned storage from the guest via >>> scsi-block. >>> >>> 21h

[Qemu-devel] [PULL v2 00/20] testing/next for 4.1

2019-07-02 Thread Alex Bennée
The following changes since commit 7d0e02405fc02a181319b1ab8681d2f72246b7c6: Merge remote-tracking branch 'remotes/vivier2/tags/trivial-patches-pull-request' into staging (2019-07-01 17:40:32 +0100) are available in the Git repository at: https://github.com/stsquad/qemu.git tags/pull-testi

Re: [Qemu-devel] [PULL 00/19] testing/next (tests/vm, Travis and hyperv build fix)

2019-07-02 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 7/1/19 5:58 PM, Alex Bennée wrote: >> >> Peter Maydell writes: >> >>> On Mon, 24 Jun 2019 at 14:43, Alex Bennée wrote: The following changes since commit 474f3938d79ab36b9231c9ad3b5a9314c2aeacde: Merge remote-tracking branch >>>

Re: [Qemu-devel] [PULL 00/19] testing/next (tests/vm, Travis and hyperv build fix)

2019-07-02 Thread Peter Maydell
On Tue, 2 Jul 2019 at 11:28, Alex Bennée wrote: > We could I guess. I'd prefer it if we could have the check for warnings > script in the source tree and documented so it's easier to see when we > trip up this stuff. Well, it's part of my ad-hoc testing scripts. If we can move to using gitlab run

Re: [Qemu-devel] balloon config change seems to break live migration from 3.0.1 to 4.0

2019-07-02 Thread Wolfgang Bumiller
On Thu, Jun 27, 2019 at 03:12:52PM +0200, Wolfgang Bumiller wrote: > While testing with 4.0 we've run into issues with live migration from > 3.0.1 to 4.0 when a balloon device was involved. > > We'd see the following error on the destination: > qemu-system-x86_64: get_pci_config_device: Bad conf

Re: [Qemu-devel] [PULL 33/34] roms: Add OpenSBI version 0.3

2019-07-02 Thread Paolo Bonzini
On 02/07/19 06:12, Markus Armbruster wrote: >> Yeah, if we're not building the apache-2.0 parts then I think >> we're OK, and as you say there's the question of whether QEMU's >> GPL affects what we ship as mere bios blobs to run as guest >> code anyway. But it's sufficiently not a "really obviousl

Re: [Qemu-devel] [PATCH v2 4/4] hw/i386: Introduce the microvm machine type

2019-07-02 Thread Paolo Bonzini
On 02/07/19 10:47, Sergio Lopez wrote: >> Could it be useful to support initrd as well? >> >> I'm thinking a possibility to a microvm to use only the initrd without a >> block device. > I agree, thanks for the suggestion. I'll add support for it. I'd like to take a look at adding firmware support

Re: [Qemu-devel] [PULL 3/3] vfio/common: Introduce vfio_set_irq_signaling helper

2019-07-02 Thread Peter Maydell
On Thu, 13 Jun 2019 at 22:51, Alex Williamson wrote: > > From: Eric Auger > > The code used to assign an interrupt index/subindex to an > eventfd is duplicated many times. Let's introduce an helper that > allows to set/unset the signaling for an ACTION_TRIGGER, > ACTION_MASK or ACTION_UNMASK acti

Re: [Qemu-devel] [PATCH v10 6/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-07-02 Thread Aravinda Prasad
On Tuesday 02 July 2019 09:41 AM, David Gibson wrote: > On Wed, Jun 12, 2019 at 02:51:38PM +0530, Aravinda Prasad wrote: >> This patch adds support in QEMU to handle "ibm,nmi-register" >> and "ibm,nmi-interlock" RTAS calls and sets the default >> value of SPAPR_CAP_FWNMI_MCE to SPAPR_CAP_ON for

Re: [Qemu-devel] [PATCH v2 2/4] m68k: Add NeXTcube keyboard device

2019-07-02 Thread Thomas Huth
On 29/06/2019 14.02, Philippe Mathieu-Daudé wrote: > On 6/28/19 8:15 PM, Thomas Huth wrote: >> It is likely still quite incomplete (e.g. mouse and interrupts are not >> implemented yet), but it is good enough for keyboard input at the firmware >> monitor. [...] >> + >> +static uint32_t kbd_read_wor

[Qemu-devel] [PULL 17/18] MAINTAINERS: Add Windows dump to section "Dump"

2019-07-02 Thread Markus Armbruster
Commit 2da91b54fe9 "dump: add Windows dump format to dump-guest-memory" neglected to update MAINTAINERS. Do it now. Cc: Marc-André Lureau Signed-off-by: Markus Armbruster Message-Id: <20190619201050.19040-17-arm...@redhat.com> Reviewed-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé ---

[Qemu-devel] [PULL 02/18] MAINTAINERS: Make section "QOM" cover qdev as well

2019-07-02 Thread Markus Armbruster
Suggested-by: Paolo Bonzini Signed-off-by: Markus Armbruster Reviewed-by: Daniel P. Berrangé --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 23a8c5ac0b..3d139b61ff 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2033,12 +2033,18 @@ M: Pao

[Qemu-devel] [PULL 04/18] hmp: Move hmp.h to include/monitor/

2019-07-02 Thread Markus Armbruster
Cc: "Dr. David Alan Gilbert" Signed-off-by: Markus Armbruster Message-Id: <20190619201050.19040-4-arm...@redhat.com> Reviewed-by: Daniel P. Berrangé Reviewed-by: Dr. David Alan Gilbert --- hmp.h => include/monitor/hmp.h | 0 monitor/hmp-cmds.c | 2 +- monitor/misc.c

[Qemu-devel] [PULL 13/18] qapi: Split machine-target.json off target.json and misc.json

2019-07-02 Thread Markus Armbruster
Move commands query-cpu-definitions, query-cpu-model-baseline, query-cpu-model-comparison, and query-cpu-model-expansion with their types from target.json to machine-target.json. Also move types CpuModelInfo, CpuModelExpansionType, and CpuModelCompareResult from misc.json there. Add machine-targe

[Qemu-devel] [PULL 03/18] Makefile: Don't add monitor/ twice to common-obj-y

2019-07-02 Thread Markus Armbruster
Both commit f1b3ccfaa68 "monitor: Move {hmp, qmp}.c to monitor/{hmp, qmp}-cmds.c" and commit 7e3c0deab1b "monitor: Split out monitor/qmp.c" added monitor/ to common-obj-y ifeq ($(CONFIG_SOFTMMU),y). Revert the second addition. Signed-off-by: Markus Armbruster Message-Id: <20190619201050.19040-3-

[Qemu-devel] [PULL 00/18] Monitor patches for 2019-07-02

2019-07-02 Thread Markus Armbruster
The following changes since commit 7d0e02405fc02a181319b1ab8681d2f72246b7c6: Merge remote-tracking branch 'remotes/vivier2/tags/trivial-patches-pull-request' into staging (2019-07-01 17:40:32 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-monitor-

[Qemu-devel] [PULL 01/18] MAINTAINERS: new maintainers for QOM

2019-07-02 Thread Markus Armbruster
From: Paolo Bonzini QOM is not a particularly active subsystem now: 51 commits in two years. But, we need active maintainers to review and merge patches, and Git shows the following top committers taking on QOM: Markus Armbruster Eduardo Habkost Paolo Bonzini Marc-André Lureau

[Qemu-devel] [PULL 15/18] qapi: Split dump.json off misc.json

2019-07-02 Thread Markus Armbruster
Move commands dump-guest-memory, query-dump, query-dump-guest-memory-capability with their types from misc.json to new dump.json. Add dump.json to MAINTAINERS section "Dump". Cc: Marc-André Lureau Signed-off-by: Markus Armbruster Message-Id: <20190619201050.19040-15-arm...@redhat.com> Reviewed-

[Qemu-devel] [PULL 07/18] qom: Move HMP command handlers to qom/

2019-07-02 Thread Markus Armbruster
Move the HMP command handlers related to QOM handlers from monitor/hmp-cmds.c and qdev-monitor.c to new qom/qom-hmp-cmds.c, where they are covered by MAINTAINERS section QOM. Cc: Paolo Bonzini Cc: "Daniel P. Berrange" Cc: Eduardo Habkost Cc: "Dr. David Alan Gilbert" Signed-off-by: Markus Armbr

[Qemu-devel] [PULL 10/18] hw/core: Move numa.c to hw/core/

2019-07-02 Thread Markus Armbruster
Cc: Eduardo Habkost Cc: Marcel Apfelbaum Signed-off-by: Markus Armbruster Message-Id: <20190619201050.19040-10-arm...@redhat.com> Reviewed-by: Daniel P. Berrangé --- MAINTAINERS | 2 +- Makefile.target | 2 +- hw/core/Makefile.objs| 2 ++ numa.c => hw/core/numa.c | 0

[Qemu-devel] [PULL 14/18] qapi: Rename target.json to misc-target.json

2019-07-02 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Message-Id: <20190619201050.19040-14-arm...@redhat.com> Reviewed-by: Daniel P. Berrangé --- hw/ppc/spapr_rtc.c | 2 +- hw/s390x/s390-skeys.c | 2 +- hw/timer/mc146818rtc.c | 4 ++-- qapi/Makefile.objs

[Qemu-devel] [PULL 12/18] hw/core: Collect HMP command handlers in hw/core/

2019-07-02 Thread Markus Armbruster
Move the HMP handlers related to qapi/machine.json to hw/core/machine-hmp-cmds.c, where they are covered by MAINTAINERS section "Machine core", just like qapi/machine.json. Cc: Eduardo Habkost Cc: Marcel Apfelbaum Cc: "Dr. David Alan Gilbert" Signed-off-by: Markus Armbruster Message-Id: <20190

[Qemu-devel] [PULL 08/18] MAINTAINERS: Merge sections CPU, NUMA into Machine core

2019-07-02 Thread Markus Armbruster
Suggested-by: Paolo Bonzini Cc: Eduardo Habkost Cc: Marcel Apfelbaum Signed-off-by: Markus Armbruster Message-Id: <20190619201050.19040-8-arm...@redhat.com> Reviewed-by: Daniel P. Berrangé --- MAINTAINERS | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/MA

[Qemu-devel] [PULL 11/18] hw/core: Collect QMP command handlers in hw/core/

2019-07-02 Thread Markus Armbruster
The handlers for qapi/machine.json's QMP commands are spread over cpus.c, hw/core/numa.c, monitor/misc.c, monitor/qmp-cmds.c, and vl.c. Move them all to new hw/core/machine-qmp-cmds.c, where they are covered by MAINTAINERS section "Machine core", just like qapi/machine.json. Cc: Eduardo Habkost C

[Qemu-devel] [PATCH for-4.1] target/arm: Fix sve_zcr_len_for_el

2019-07-02 Thread Richard Henderson
Off by one error in the EL2 and EL3 tests. Remove the test against EL3 entirely, since it must always be true. Signed-off-by: Richard Henderson --- This bug resulted in an infinite loop in the kernel's initialization of SVE with EL2 and VHE enabled. It's probably worth including in 4.1, even t

[Qemu-devel] [PULL 06/18] qom: Move QMP command handlers to qom/

2019-07-02 Thread Markus Armbruster
The handlers for qapi/qom.json's QMP commands are in monitor/qmp-cmds.c. Move them to new qom/qom-qmp-cmds.c, where they are covered by MAINTAINERS section QOM, just like qapi/qom.json. Move along qmp_device_list_properties() even though it's specified in qapi/qdev.json, because it's so similar t

[Qemu-devel] [PULL 05/18] qapi: Split qom.json and qdev.json off misc.json

2019-07-02 Thread Markus Armbruster
Move commands object-add, object-del, qom-get, qom-list, qom-list-properties, qom-list-types, and qom-set with their types from misc.json to new qom.json. Move commands device-list-properties, device_add, device-del, and event DEVICE_DELETED from misc.json to new qdev.json. Add both new files to

Re: [Qemu-devel] [PATCH v2 4/4] hw/i386: Introduce the microvm machine type

2019-07-02 Thread Sergio Lopez
Gerd Hoffmann writes: > Hi, > >> > Can we get rid of the kernel command line hacking please? >> > The virtio-mmio devices should be discoverable somehow. >> > >> > Device tree (as suggested by paolo) would work. >> > Custom acpi device (simliar to fw_cfg) is another option. >> > I'd tend to pi

Re: [Qemu-devel] [PATCH] tests: Update DSDT ACPI table for arm/virt board with PCDIMM related changes

2019-07-02 Thread Igor Mammedov
On Mon, 1 Jul 2019 21:08:19 +0200 Eric Auger wrote: > PCDIMM hotplug addition updated the DSDT. Update the reference table. > > Signed-off-by: Eric Auger checked ASL after applying it. Modulo minor issue with generated ASL (reference to non existing method when running without memory hotplug

[Qemu-devel] [PULL 09/18] qapi: Split machine.json off misc.json

2019-07-02 Thread Markus Armbruster
Move commands cpu-add, query-cpus, query-cpus-fast, query-current-machine, query-hotpluggable-cpus, query-machines, query-memdev, and set-numa-node with their types from misc.json to new machine.json. Also move types X86CPURegister32 and X86CPUFeatureWordInfo. Add machine.json to MAINTAINERS sect

[Qemu-devel] [PULL 18/18] dump: Move HMP command handlers to dump/

2019-07-02 Thread Markus Armbruster
Move the HMP handlers related to qapi/dump.json to dump/dump-hmp-cmds.c, where they are covered by MAINTAINERS section "Dump", just like qapi/dump.json. Cc: Marc-André Lureau Cc: "Dr. David Alan Gilbert" Signed-off-by: Markus Armbruster Message-Id: <20190619201050.19040-18-arm...@redhat.com> Re

Re: [Qemu-devel] [PATCH for-4.1] target/arm: Correct VMOV_imm_dp handling of short vectors

2019-07-02 Thread Richard Henderson
On 7/2/19 12:51 PM, Peter Maydell wrote: > Coverity points out (CID 1402195) that the loop in trans_VMOV_imm_dp() > that iterates over the destination registers in a short-vector VMOV > accidentally throws away the returned updated register number > from vfp_advance_dreg(). Add the missing assignme

[Qemu-devel] [PULL 16/18] dump: Move the code to dump/

2019-07-02 Thread Markus Armbruster
Cc: Marc-André Lureau Signed-off-by: Markus Armbruster Message-Id: <20190619201050.19040-16-arm...@redhat.com> Reviewed-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- MAINTAINERS | 2 +- Makefile.target | 3 +-- dump/Makefile.objs| 2 ++ d

Re: [Qemu-devel] [PATCH v5 2/2] s390: diagnose 318 info reset and migration support

2019-07-02 Thread Cornelia Huck
On Wed, 26 Jun 2019 10:07:39 -0400 Collin Walling wrote: > On 6/26/19 8:33 AM, Cornelia Huck wrote: > > On Tue, 25 Jun 2019 11:17:09 -0400 > > Collin Walling wrote: > > > >> DIAGNOSE 0x318 (diag318) is a privileged s390x instruction that must > >> be intercepted by SIE and handled via KVM. Le

  1   2   3   4   5   >