Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/2] nbd: enable keepalive

2019-06-26 Thread Eric Blake
On 6/26/19 4:18 PM, John Snow wrote: > > > On 6/5/19 12:18 PM, Vladimir Sementsov-Ogievskiy wrote: >> Hi all! >> >> Here is a suggestion to enable keepalive option to track server availablity. >> We suggest to enable it by default. If we need, we'll be able to add option >> to specify timeout by

Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/2] nbd: enable keepalive

2019-06-26 Thread John Snow
On 6/26/19 5:23 PM, Eric Blake wrote: > On 6/26/19 4:18 PM, John Snow wrote: >> >> >> On 6/5/19 12:18 PM, Vladimir Sementsov-Ogievskiy wrote: >>> Hi all! >>> >>> Here is a suggestion to enable keepalive option to track server availablity. >>> We suggest to enable it by default. If we need, we'll

Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/2] nbd: enable keepalive

2019-06-26 Thread Eric Blake
On 6/26/19 4:23 PM, Eric Blake wrote: > On 6/26/19 4:18 PM, John Snow wrote: >> >> >> On 6/5/19 12:18 PM, Vladimir Sementsov-Ogievskiy wrote: >>> Hi all! >>> >>> Here is a suggestion to enable keepalive option to track server availablity. >>> We suggest to enable it by default. If we need, we'll be

Re: [Qemu-devel] [Qemu-block] [PATCH V2 RESEND] block/replication.c: Fix crash issue after failover

2019-06-26 Thread John Snow
On 6/21/19 2:28 AM, Zhang Chen wrote: > From: Zhang Chen > > If we try to close replication after failover, it will crash here. > So we need check the block job on active disk before cancel the job. > > Signed-off-by: Zhang Chen > --- > block/replication.c | 4 +++- > 1 file changed, 3 inse

[Qemu-devel] [PATCH] block/qcow: Improve error when opening qcow2 files as qcow

2019-06-26 Thread John Snow
Reported-by: radmehrsae...@gmail.com Fixes: https://bugs.launchpad.net/bugs/1832914 Signed-off-by: John Snow --- block/qcow.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/block/qcow.c b/block/qcow.c index 6dee5bb792..a9cb6ae0bd 100644 --- a/block/qcow.c +++ b/block/qc

[Qemu-devel] [PATCH v1 1/1] hw/scsi: Report errors and sense to guests through scsi-block

2019-06-26 Thread Alistair Francis
From: Shin'ichiro Kawasaki When host block devices are bridged to a guest system through virtio-scsi-pci and scsi-block driver, scsi_handle_rw_error() in hw/scsi/scsi-disk.c checks the error number to judge which error to report to the guests. EIO and EINVAL are not reported and ignored. Once EIO

Re: [Qemu-devel] [PATCH] block/qcow: Improve error when opening qcow2 files as qcow

2019-06-26 Thread Eric Blake
On 6/26/19 4:53 PM, John Snow wrote: > Reported-by: radmehrsae...@gmail.com > Fixes: https://bugs.launchpad.net/bugs/1832914 > Signed-off-by: John Snow > --- > block/qcow.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) Yes, this is useful. Reviewed-by: Eric Blake Reminds me of

Re: [Qemu-devel] [GSoC] Help needed in implementing live migration

2019-06-26 Thread Sukrit Bhatnagar
On Tue, 25 Jun 2019 at 00:11, Dr. David Alan Gilbert wrote: > > * Sukrit Bhatnagar (skrtbht...@gmail.com) wrote: > > Hi David, > > > > I am Sukrit, GSoC participant working on PVRDMA live migration. > > We had a short chat about vmxnet3 migration about a week ago > > on the IRC channel. > > > > I

Re: [Qemu-devel] [Qemu-trivial] Fix cacheline size retrieval on FreeBSD/PowerPC(64)

2019-06-26 Thread Justin Hibbits
On Wed, Jun 26, 2019, 13:04 Justin Hibbits wrote: > On Wed, 26 Jun 2019 18:47:42 +0200 > Laurent Vivier wrote: > > > Le 26/06/2019 à 18:37, Justin Hibbits a écrit : > > > On Wed, 26 Jun 2019 18:16:36 +0200 > > > Laurent Vivier wrote: > > > > > >> Le 26/06/2019 à 18:14, Laurent Vivier a écrit :

Re: [Qemu-devel] [Qemu-trivial] Fix cacheline size retrieval on FreeBSD/PowerPC(64)

2019-06-26 Thread Laurent Vivier
Le 27/06/2019 à 02:02, Justin Hibbits a écrit : > > > On Wed, Jun 26, 2019, 13:04 Justin Hibbits > wrote: > > On Wed, 26 Jun 2019 18:47:42 +0200 > Laurent Vivier mailto:laur...@vivier.eu>> wrote: > > > Le 26/06/2019 à 18:37, Justin Hibbits a écrit : >

Re: [Qemu-devel] [Qemu-trivial] Fix cacheline size retrieval on FreeBSD/PowerPC(64)

2019-06-26 Thread Justin Hibbits
On Wed, Jun 26, 2019, 19:08 Laurent Vivier wrote: > Le 27/06/2019 à 02:02, Justin Hibbits a écrit : > > > > > > On Wed, Jun 26, 2019, 13:04 Justin Hibbits > > wrote: > > > > On Wed, 26 Jun 2019 18:47:42 +0200 > > Laurent Vivier mailto:laur...@vivier.eu>> wrot

Re: [Qemu-devel] [PATCH V2 4/5] COLO-compare: Add colo-compare remote notify support

2019-06-26 Thread Jason Wang
On 2019/6/10 上午12:44, Zhang Chen wrote: From: Zhang Chen This patch make colo-compare can send message to remote COLO frame(Xen) when occur checkpoint. Signed-off-by: Zhang Chen --- net/colo-compare.c | 54 +- 1 file changed, 44 insertions(+),

Re: [Qemu-devel] [PATCH v5 0/5] network announce; interface selection & IDs

2019-06-26 Thread Jason Wang
On 2019/6/21 上午2:47, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" Up until now, the 'announce' feature has mainly been used for migration where we announce on all interfaces. Another use for 'announce' is in cases of network topology changes. Since network topology cha

[Qemu-devel] [PATCH 0/3] migration/postcopy: cleanup function postcopy_send_discard_bm_ram

2019-06-26 Thread Wei Yang
Some cleanup of function postcopy_send_discard_bm_ram: * use a more restrict check for discard page * break the loop when no more page to discard * it is for sure discard_length is not 0 No functional change. Wei Yang (3): migration/postcopy: the valid condition is one less then end migratio

[Qemu-devel] [PATCH 3/3] migration/postcopy: discard_length must not be 0

2019-06-26 Thread Wei Yang
Since we break the loop when there is no more page to discard, we are sure the following process would find some page to discard. It is not necessary to check it again. Signed-off-by: Wei Yang --- migration/ram.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/migration/r

[Qemu-devel] [PATCH 2/3] migration/postcopy: break the loop when there is no more page to discard

2019-06-26 Thread Wei Yang
When one is equal or bigger then end, it means there is no page to discard. Just break the loop in this case instead of processing it. No functional change, just refactor it a little. Signed-off-by: Wei Yang --- migration/ram.c | 26 +- 1 file changed, 13 insertions(+),

[Qemu-devel] [PATCH 1/3] migration/postcopy: the valid condition is one less then end

2019-06-26 Thread Wei Yang
If one equals end, it means we have gone through the whole bitmap. Use a more restrict check to skip a unnecessary condition. Signed-off-by: Wei Yang --- migration/ram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/ram.c b/migration/ram.c index 908517fc2b..b7816

Re: [Qemu-devel] [PATCH v3 0/4] Clean ups in net/net.c

2019-06-26 Thread Jason Wang
On 2019/5/17 下午9:47, Stefano Garzarella wrote: This series contains some clean ups in net/net.c The patch 1 solves an assertion failure when ipv6-prefixlen is not a number, Following the Markus' advice, I modified the parsing of IPv6 prefix (patch 2) and IPv4 host:port (patch 3). Then I remov

Re: [Qemu-devel] [PATCH v4 0/5] virtio: fix some issues of "started" and "start_on_kick" flag

2019-06-26 Thread Yongji Xie
On Wed, 26 Jun 2019 at 18:43, Laurent Vivier wrote: > > On 26/06/2019 04:31, elohi...@gmail.com wrote: > > From: Xie Yongji > > Could you use the same address to send the series? > Or may be you need to add a Signed-off-by with your name and this address? > > I don't know what is the rule when so

Re: [Qemu-devel] [PATCH v4 1/5] virtio: add "use-started" property

2019-06-26 Thread Yongji Xie
On Wed, 26 Jun 2019 at 18:18, Greg Kurz wrote: > > On Wed, 26 Jun 2019 10:31:26 +0800 > elohi...@gmail.com wrote: > > > From: Xie Yongji > > > > In order to avoid migration issues, we introduce a "use-started" > > property to the base virtio device to indicate whether use > > "started" flag or no

[Qemu-devel] [Bug 1834399] [NEW] AArch64: branch out of range

2019-06-26 Thread Kai
Public bug reported: I build lib32-qemu which is a multilib variant for mips o32 on project Yocto with qemumips64. It finally runs command and fails: mips-wrsmllib32-linux-gcc -meb -mabi=32 -mhard-float -fstack-protector-strong -Wformat -Wformat-security -Werror=format-security --sysroot=/m

[Qemu-devel] [PATCH v23 0/7] QEMU AVR 8 bit cores

2019-06-26 Thread Michael Rolnik
This series of patches adds 8bit AVR cores to QEMU. All instruction, except BREAK/DES/SPM/SPMX, are implemented. Not fully tested yet. However I was able to execute simple code with functions. e.g fibonacci calculation. This series of patches include a non real, sample board. No fuses support yet

[Qemu-devel] [PATCH v23 3/7] target/avr: Add instruction decoding

2019-06-26 Thread Michael Rolnik
This includes: - encoding of all 16 bit instructions - encoding of all 32 bit instructions Signed-off-by: Michael Rolnik --- target/avr/insn.decode | 175 + 1 file changed, 175 insertions(+) create mode 100644 target/avr/insn.decode diff --git a/target/a

[Qemu-devel] [PATCH v23 7/7] target/avr: Register AVR support with the rest of QEMU, the build system, and the MAINTAINERS file

2019-06-26 Thread Michael Rolnik
From: Sarah Harris Signed-off-by: Michael Rolnik --- MAINTAINERS | 6 ++ arch_init.c | 2 ++ configure | 7 +++ default-configs/avr-softmmu.mak | 5 + include/disas/dis-asm.h | 6 ++ include/sysemu/arch_i

[Qemu-devel] [PATCH v23 5/7] target/avr: Add limited support for USART and 16 bit timer peripherals

2019-06-26 Thread Michael Rolnik
From: Sarah Harris These were designed to facilitate testing but should provide enough function to be useful in other contexts. Only a subset of the functions of each peripheral is implemented, mainly due to the lack of a standard way to handle electrical connections (like GPIO pins). Signed-o

[Qemu-devel] [PATCH v23 2/7] target/avr: Add instruction helpers

2019-06-26 Thread Michael Rolnik
From: Sarah Harris Stubs for unimplemented instructions and helpers for instructions that need to interact with QEMU. SPM and WDR are unimplemented because they require emulation of complex peripherals. The implementation of SLEEP is very limited due to the lack of peripherals to generate wake

[Qemu-devel] [PATCH v23 1/7] target/avr: Add outward facing interfaces and core CPU logic

2019-06-26 Thread Michael Rolnik
From: Sarah Harris This includes: - CPU data structures - object model classes and functions - migration functions - GDB hooks Signed-off-by: Michael Rolnik --- gdb-xml/avr-cpu.xml| 49 target/avr/cpu-param.h | 37 +++ target/avr/cpu.c | 599 +++

[Qemu-devel] [PATCH v23 6/7] target/avr: Add example board configuration

2019-06-26 Thread Michael Rolnik
From: Sarah Harris A simple board setup that configures an AVR CPU to run a given firmware image. This is all that's useful to implement without peripheral emulation as AVR CPUs include a lot of on-board peripherals. Signed-off-by: Michael Rolnik --- hw/Kconfig | 1 + hw/avr/Kconf

[Qemu-devel] [PATCH] console: fix cell overflow

2019-06-26 Thread Gerd Hoffmann
Linux terminal behavior (coming from vt100 I think) is somewhat strange when it comes to line wraps: When a character is printed to the last char cell of a line the cursor does NOT jump to the next line but stays where it is. The line feed happens when the next character is printed. So the valid

[Qemu-devel] [PATCH v23 4/7] target/avr: Add instruction translation

2019-06-26 Thread Michael Rolnik
This includes: - TCG translations for each instruction Signed-off-by: Michael Rolnik --- target/avr/translate.c | 2888 1 file changed, 2888 insertions(+) create mode 100644 target/avr/translate.c diff --git a/target/avr/translate.c b/target/avr/transla

Re: [Qemu-devel] [PATCH v2 10/14] target/arm/kvm64: Add kvm_arch_get/put_sve

2019-06-26 Thread Auger Eric
Hi, On 6/21/19 6:34 PM, Andrew Jones wrote: > These are the SVE equivalents to kvm_arch_get/put_fpsimd. Note, the > swabbing is different than it is for fpsmid because the vector format > is a little-endian stream of words. some cosmetic changes besides Richard's comments > > Signed-off-by: Andr

<    1   2   3