Re: [Qemu-devel] [PATCH v2 2/2] intel_iommu: Fix unexpected unmaps during global unmap

Hi Peter, On 6/24/19 11:18 AM, Peter Xu wrote: > This is an replacement work of Yan Zhao's patch: > > https://www.mail-archive.com/qemu-devel@nongnu.org/msg625340.html > > vtd_address_space_unmap() will do proper page mask alignment to make > sure each IOTLB message will have correct masks for n

Re: [Qemu-devel] [PATCH v10 6/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

On Tue, 25 Jun 2019 11:46:06 +0530 Aravinda Prasad wrote: > On Monday 24 June 2019 07:59 PM, Greg Kurz wrote: > > On Wed, 12 Jun 2019 14:51:38 +0530 > > Aravinda Prasad wrote: > > > >> This patch adds support in QEMU to handle "ibm,nmi-register" > >> and "ibm,nmi-interlock" RTAS calls and set

Re: [Qemu-devel] [PATCH 9/9] hw/misc/empty_slot: Pass the slot name as argument

On Tue, Jun 25, 2019 at 12:01 AM Philippe Mathieu-Daudé wrote: > > Use the slot name to have more meaningful tracing logs. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Artyom Tarasenko > --- > include/hw/misc/empty_slot.h | 3 ++- > hw/mips/mips_malta.c | 2 +- > hw/misc/emp

Re: [Qemu-devel] [PATCH 6/9] hw/misc/empty_slot: Convert debug printf()s to trace events

On Tue, Jun 25, 2019 at 12:01 AM Philippe Mathieu-Daudé wrote: > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Artyom Tarasenko > --- > hw/misc/empty_slot.c | 19 --- > hw/misc/trace-events | 4 > 2 files changed, 12 insertions(+), 11 deletions(-) > > diff --git a

Re: [Qemu-devel] [RFC PATCH 2/9] MAINTAINERS: Add the 'empty_slot' device with the 'unimp' one

On Tue, Jun 25, 2019 at 12:01 AM Philippe Mathieu-Daudé wrote: > > The EmptySlot and UnimplementedDevice are very similar, the only > difference is how they log guest accesses. > Maintain them altogether. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Artyom Tarasenko > --- > Peter, ar

Re: [Qemu-devel] [PATCH 3/9] hw/misc/empty_slot: Allow overide by device with higher priority

On Tue, Jun 25, 2019 at 12:01 AM Philippe Mathieu-Daudé wrote: > > The 'empty_slot' models a ChipEnable (or ChipSelect) MMIO device > pluggable on a bus. > The bus allow such slots to be not connected ('empty), thus no > bus errors are generated when this range is accessed. > > The device is mappe

Re: [Qemu-devel] [PATCH 5/9] hw/misc/empty_slot: Add a qdev property 'name'

On Tue, Jun 25, 2019 at 12:01 AM Philippe Mathieu-Daudé wrote: > > If few commits empty_slot_init() will take 'name' as argument. > Meanwhile, initialize it as 'empty-slot'. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Artyom Tarasenko > --- > hw/misc/empty_slot.c | 7 ++- > 1 f

Re: [Qemu-devel] [PATCH 1/9] hw/misc: Move the 'empty_slot' device to hw/misc/

On Tue, Jun 25, 2019 at 12:01 AM Philippe Mathieu-Daudé wrote: > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Artyom Tarasenko > --- > include/hw/empty_slot.h| 7 --- > include/hw/misc/empty_slot.h | 32 > hw/mips/mips_malta.c

Re: [Qemu-devel] [PATCH 4/9] hw/misc/empty_slot: Add a qdev property 'size'

On Tue, Jun 25, 2019 at 12:01 AM Philippe Mathieu-Daudé wrote: > > Add a qdev 'size' property, check the size is not zero in the > realize() function, simplify the empty_slot_init() logic. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Artyom Tarasenko > --- > hw/misc/empty_slot.c | 4

Re: [Qemu-devel] [PATCH 05/10] hw/mips/gt64xxx_pci: Use qemu_log_mask() instead of debug printf()

Hi Aleksandar, On 6/25/19 2:37 AM, Aleksandar Markovic wrote: > > This patch is not only mechanical replacement of printf(), but it also > improves existing log messages, and adds some new ones as well. Reflect > that in both commit message title and body. Perhaps there are more spots > that dese

Re: [Qemu-devel] [PATCH 8/9] hw/sparc/sun4m: Simplify the RAM creation

On Tue, Jun 25, 2019 at 12:01 AM Philippe Mathieu-Daudé wrote: > > Now than the empty_slot device can be overlapped, use it to cover > the maximum memory range. Whilie this is true for SS-5, the SS-20 does trap on missing RAM, so empty_slot_init must be conditional. nack. > We can simplify now t

Re: [Qemu-devel] [PATCH 7/9] hw/sparc/sun4m: Mark some devices as 'unimplemented'

On Tue, Jun 25, 2019 at 12:01 AM Philippe Mathieu-Daudé wrote: > > These devices are not slots on a bus, but real devices that > we do not implement. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Artyom Tarasenko > --- > hw/sparc/sun4m.c | 11 +++ > 1 file changed, 7 inserti

Re: [Qemu-devel] [Qemu-block] [RFC] nvme: how to support multiple namespaces

Am 24.06.2019 um 22:46 hat Laszlo Ersek geschrieben: > On 06/24/19 12:18, Kevin Wolf wrote: > > Am 24.06.2019 um 10:01 hat Klaus Birkelund geschrieben: > >> On Thu, Jun 20, 2019 at 05:37:24PM +0200, Laszlo Ersek wrote: > >>> On 06/17/19 10:12, Klaus Birkelund wrote: > Hi all, > > I'm

Re: [Qemu-devel] [PATCH v4] memory: assert on out of scope notification

Hi Yan, [ + Peter] On 6/25/19 5:21 AM, Yan Zhao wrote: > It is wrong for an entry to have parts out of scope of notifier's range. > assert this condition. > > Out of scope mapping/unmapping would cause problem, as in below case: > > 1. initially there are two notifiers with ranges > 0-0xfedfff

Re: [Qemu-devel] [PATCH 07/10] hw/mips/gt64xxx_pci: Align the pci0-mem size

On 6/25/19 2:43 AM, Aleksandar Markovic wrote: > > On Jun 25, 2019 12:44 AM, "Philippe Mathieu-Daudé" > wrote: >> >> One byte is missing, use an aligned size. >> >>     (qemu) info mtree >>     memory-region: pci0-mem >>       -fffe (prio 0, i/o

Re: [Qemu-devel] [PATCH v4] memory: assert on out of scope notification

On Tue, Jun 25, 2019 at 03:36:57PM +0800, Auger Eric wrote: > Hi Yan, > > [ + Peter] > > > On 6/25/19 5:21 AM, Yan Zhao wrote: > > It is wrong for an entry to have parts out of scope of notifier's range. > > assert this condition. > > > > Out of scope mapping/unmapping would cause problem, as i

Re: [Qemu-devel] [PATCH] ioapic: clear irq_eoi when updating the ioapic redirect table entry

On 24/06/19 17:16, Li Qiang wrote: > irq_eoi is used to count the number of irq injected during eoi > broadcast. It should be set to 0 when updating the ioapic's redirect > table entry. > > Suggested-by: Peter Xu > Signed-off-by: Li Qiang > --- > hw/intc/ioapic.c | 1 + > 1 file changed, 1 inse

[Qemu-devel] [PATCH] minikconf: do not include variables from MINIKCONF_ARGS in config-all-devices.mak

When minikconf writes config-devices.mak, it includes all variables including those from MINIKCONF_ARGS. This causes values from config-host.mak to "stick" to the ones used in generating config-devices.mak, because config-devices.mak is included after config-host.mak. Avoid this by omitting assi

Re: [Qemu-devel] [PATCH v2 7/7] iotests: new file to suppress Valgrind errors

Am 24.06.2019 um 18:55 hat Andrey Shinkevich geschrieben: > > > On 17/06/2019 14:45, Kevin Wolf wrote: > > Am 11.06.2019 um 20:02 hat Andrey Shinkevich geschrieben: > >> The Valgrind tool reports about an uninitialised memory usage when the > >> initialization is actually not needed. For example,

Re: [Qemu-devel] [PATCH 8/9] hw/sparc/sun4m: Simplify the RAM creation

On 6/25/19 9:14 AM, Artyom Tarasenko wrote: > On Tue, Jun 25, 2019 at 12:01 AM Philippe Mathieu-Daudé > wrote: >> >> Now than the empty_slot device can be overlapped, use it to cover >> the maximum memory range. > > Whilie this is true for SS-5, the SS-20 does trap on missing RAM, so > empty_slo

Re: [Qemu-devel] [RFC 0/1] Add live migration support to the PVRDMA device

Hi Sukrit On 6/21/19 5:45 PM, Sukrit Bhatnagar wrote: Hi, [...] This RFC is meant to request suggestions on the things which are working and for help on the things which are not. [...] What is not working: [...] * It seems that vmxnet3 migration itself is not working properly, at least

Re: [Qemu-devel] [PULL SUBSYSTEM s390x 0/3] s390x/tcg: pending patches

On Fri, 21 Jun 2019 15:43:35 +0200 David Hildenbrand wrote: > This pull request is not for master. > > Hi Conny, > > The following changes since commit 33d609990621dea6c7d056c86f707b8811320ac1: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2019-06-18 17:

Re: [Qemu-devel] [PATCH v4 04/10] block/pflash_cfi02: Implement intereleaved flash devices

Stephen Checkoway writes: >> On Jun 24, 2019, at 12:05, Philippe Mathieu-Daudé wrote: >> >>> On 6/22/19 2:25 PM, Philippe Mathieu-Daudé wrote: >>> Hi Stephen, >>> >>> This series haven't fall through the cracks, however it is taking me >>> longer than expected to review it. >>> On 4/26/1

Re: [Qemu-devel] [PATCH v2 1/1] qmp: Add deprecation information to query-machines

On 6/9/19 2:34 AM, Eduardo Habkost wrote: Export machine type deprecation status through the query-machines QMP command. With this, libvirt and management software will be able to show this information to users and/or suggest changes to VM configuration to avoid deprecated machines. Signed-o

Re: [Qemu-devel] [RFC 0/1] Add live migration support to the PVRDMA device

> On 25 Jun 2019, at 11:14, Marcel Apfelbaum wrote: > > Hi Sukrit > > On 6/21/19 5:45 PM, Sukrit Bhatnagar wrote: >> Hi, > [...] >> This RFC is meant to request suggestions on the things which are >> working and for help on the things which are not. >> > [...] >> What is not working: >> > [

Re: [Qemu-devel] [RFC 0/1] Add live migration support to the PVRDMA device

Hi Dmitry, On 6/25/19 11:39 AM, Dmitry Fleytman wrote: On 25 Jun 2019, at 11:14, Marcel Apfelbaum wrote: Hi Sukrit On 6/21/19 5:45 PM, Sukrit Bhatnagar wrote: Hi, [...] This RFC is meant to request suggestions on the things which are working and for help on the things which are not. [.

Re: [Qemu-devel] [PATCH] minikconf: do not include variables from MINIKCONF_ARGS in config-all-devices.mak

> On 25 Jun 2019, at 10:13, Paolo Bonzini wrote: > > When minikconf writes config-devices.mak, it includes all variables including > those from MINIKCONF_ARGS. This causes values from config-host.mak to > "stick" to > the ones used in generating config-devices.mak, because config-devices.mak

Re: [Qemu-devel] [PATCH 2/6] i386: Remove unused host_cpudef variable

* Eduardo Habkost (ehabk...@redhat.com) wrote: > The variable is completely unused, probably a leftover from > previous code clean up. > > Signed-off-by: Eduardo Habkost Reviewed-by: Dr. David Alan Gilbert > --- > target/i386/cpu.c | 6 -- > 1 file changed, 6 deletions(-) > > diff --git

Re: [Qemu-devel] [RFC 0/1] Add live migration support to the PVRDMA device

* Marcel Apfelbaum (marcel.apfelb...@gmail.com) wrote: > Hi Dmitry, > > On 6/25/19 11:39 AM, Dmitry Fleytman wrote: > > > > > On 25 Jun 2019, at 11:14, Marcel Apfelbaum > > > wrote: > > > > > > Hi Sukrit > > > > > > On 6/21/19 5:45 PM, Sukrit Bhatnagar wrote: > > > > Hi, > > > [...] > > > > T

Re: [Qemu-devel] [PATCH v1 3/5] hw/riscv: Extend the kernel loading support

On Tue, Jun 25, 2019 at 6:18 AM Alistair Francis wrote: > > Extend the RISC-V kernel loader to support Image and uImage files. > A Linux kernel can now be booted with: > > qemu-system-riscv64 -machine virt -bios fw_jump.bin -kernel Image > > Signed-off-by: Alistair Francis > --- > hw/riscv/b

Re: [Qemu-devel] [PATCH v1 2/5] hw/riscv: Add support for loading a firmware

On Tue, Jun 25, 2019 at 6:19 AM Alistair Francis wrote: > > Add support for loading a firmware file for the virt machine and the > SiFive U. This can be run with the following command: > > qemu-system-riscv64 -machine virt -bios fw_jump.bin -kernel vmlinux > > Signed-off-by: Alistair Francis

Re: [Qemu-devel] [PATCH v1 4/5] roms: Add OpenSBI version 0.3

On Tue, Jun 25, 2019 at 6:19 AM Alistair Francis wrote: > > Add OpenSBI version 0.3 as a git submodule and as a prebult binary. > > Signed-off-by: Alistair Francis > --- > .gitmodules | 3 ++ > Makefile | 5 +- > pc-bios/op

Re: [Qemu-devel] [PATCH v1 5/5] hw/riscv: Load OpenSBI as the default firmware

On Tue, Jun 25, 2019 at 6:23 AM Alistair Francis wrote: > > If the user hasn't specified a firmware to load (with -bios) or > specified no bios (with -bios none) then load OpenSBI by default. This > allows users to boot a RISC-V kernel with just -kernel. > > Signed-off-by: Alistair Francis > ---

[Qemu-devel] [PATCH] Fix build error when VNC is configured out

In hmp_change(), the variable hmp_mon is only used by code under #ifdef CONFIG_VNC. This results in a build error when VNC is configured out with the default of treating warnings as errors: monitor/hmp-cmds.c: In function ‘hmp_change’: monitor/hmp-cmds.c:1946:17: error: unused variable ‘hmp_mon’

Re: [Qemu-devel] [PATCH 4/6] i386: Infrastructure for versioned CPU models

* Eduardo Habkost (ehabk...@redhat.com) wrote: > Base code for versioned CPU models. This will register a "-4.1" > version of all existing CPU models, and make the unversioned CPU > models be an alias for the -4.1 versions on the pc-*-4.1 machine > types. > > On older machine types, the unversion

Re: [Qemu-devel] [PATCH v2 02/14] target/arm/cpu: Ensure we can use the pmu with kvm

Hi Drew, On 6/21/19 6:34 PM, Andrew Jones wrote: > We first convert the pmu property from a static property to one with > its own accessors. Then we use the set accessor to check if the PMU is > supported when using KVM. Indeed a 32-bit KVM host does not support > the PMU, so this check will catch

Re: [Qemu-devel] [PATCH v2 01/14] target/arm/cpu64: Ensure kvm really supports aarch64=off

Hi Drew, On 6/21/19 6:34 PM, Andrew Jones wrote: > If -cpu ,aarch64=off is used then KVM must also be used, and it > and the host must support running the vcpu in 32-bit mode. Also, if > -cpu ,aarch64=on is used, then it doesn't matter if kvm is > enabled or not. > > Signed-off-by: Andrew Jones

Re: [Qemu-devel] [PATCH v2 2/4] Adding an optional tb execution counter.

vandersonmr writes: > We collect the number of times each TB is executed > and store it in the its TBStatistics. > We also count the number of times the execution counter overflows. > > Signed-off-by: Vanderson M. do Rosario > --- > accel/tcg/tcg-runtime.c | 10 ++ > accel/tcg/tcg-r

Re: [Qemu-devel] [PATCH v17 02/10] ACPI: add some GHES structures and macros definition

On 2019/6/24 19:16, Igor Mammedov wrote: On 2019/6/20 20:10, Igor Mammedov wrote: >> + */ >> +struct AcpiGenericErrorStatus { >> +/* It is a bitmask composed of ACPI_GEBS_xxx macros */ >> +uint32_t block_status; >> +uint32_t raw_data_offset; >> +uin

Re: [Qemu-devel] [PATCH for 4.1 v3] target/riscv: Expose time CSRs when allowed by [m|s]counteren

On Mon, 24 Jun 2019 16:03:20 PDT (-0700), finte...@gmail.com wrote: Apparently my previous message didn't make it out onto the list (sorry about all these email glitches!). I've included the message again below. Hopefully either a patch like this one or something simpler that just hard codes mcou

Re: [Qemu-devel] [PATCH 06/10] hw/mips/gt64xxx_pci: Convert debug printf()s to trace events

Hi Aleksandar, On 6/25/19 2:40 AM, Aleksandar Markovic wrote: > > Philippe, can you hust clarify (explain) what is the criterium when to > use log message, and when to use trace event, which are bith present in > gt64xxx implementation. The criterium is rather generic. All those log/events are

Re: [Qemu-devel] [PATCH v3 5/5] tricore: add QSEED instruction

On 6/24/19 9:03 AM, David Brenken wrote: + +result = 0; +result = deposit32(result, 31, 1, new_S); +result = deposit32(result, 23, 8, new_E); +result = deposit32(result, 15, 8, new_M); +} + +if (float32_is_signaling_nan(arg1) || result == float32_sqrt_nan

Re: [Qemu-devel] [PATCH v3 0/5] tricore: adding new instructions and fixing

On 6/24/19 9:03 AM, David Brenken wrote: From: David Brenken Hello everyone, as discussed here is the third version of the patchset. - We finalized the implementation of QSEED according to Bastians annotations. - We do only sync ctx.hflags with tb->flags. Best regards David Andreas Konop

Re: [Qemu-devel] [PATCH v3 4/5] tricore: sync ctx.hflags with tb->flags

On 6/24/19 9:03 AM, David Brenken wrote: From: Georg Hofstetter Signed-off-by: Andreas Konopik Signed-off-by: David Brenken Signed-off-by: Georg Hofstetter Signed-off-by: Robert Rasche Signed-off-by: Lars Biermanski --- target/tricore/translate.c | 1 + 1 file changed, 1 insertion(+)

Re: [Qemu-devel] [PATCH v1 9/9] target/riscv: Add Zifencei and Zicsr as command line options

On Mon, 24 Jun 2019 16:16:30 PDT (-0700), alistai...@gmail.com wrote: On Mon, Jun 24, 2019 at 2:31 AM Palmer Dabbelt wrote: On Mon, 17 Jun 2019 18:31:25 PDT (-0700), Alistair Francis wrote: > For completeness let's add Zifencei and Zicsr as command line options, > even though they can't be dis

[Qemu-devel] [PATCH] RISC-V: Add support for the Zicsr extension

The various CSR instructions have been split out of the base ISA as part of the ratification process. This patch adds a Zicsr argument, which disables all the CSR instructions. Signed-off-by: Palmer Dabbelt --- target/riscv/cpu.c | 1 + target/riscv/cpu.h | 1 + target/riscv/csr.c | 5 + 3

[Qemu-devel] [PATCH] RISC-V: Add support for the Zifencei extension

fence.i has been split out of the base ISA as part of the ratification process. This patch adds a Zifencei argument, which disables the fence.i instruction. Signed-off-by: Palmer Dabbelt --- target/riscv/cpu.c | 1 + target/riscv/cpu.h | 1 + target/ris

[Qemu-devel] [PATCH 1/5] tests/acceptance: Rename avocado_qemu.Test as MachineTest

This class is used to test QEMU machines, rename it as MachineTest. This will allow us to add a UserTest class for qemu-user tests. Signed-off-by: Philippe Mathieu-Daudé --- docs/devel/testing.rst| 8 tests/acceptance/avocado_qemu/__init__.py | 7 ++- tests/accep

[Qemu-devel] [PATCH 3/5] tests/acceptance: Introduce LinuxUserTest base class

Similarly to the MachineTest base class, this class contains methods common to linux-user tests. Signed-off-by: Philippe Mathieu-Daudé --- tests/acceptance/avocado_qemu/__init__.py | 9 + 1 file changed, 9 insertions(+) diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acc

[Qemu-devel] [PATCH 4/5] tests/acceptance: Add bFLT loader linux-user test

From: Philippe Mathieu-Daudé Add a very quick test that runs a busybox binary in bFLT format: $ avocado --show=app run tests/acceptance/load_bflt.py JOB ID : db94d5960ce564c50904d666a7e259148c27e88f JOB LOG: ~/avocado/job-results/job-2019-06-25T10.52-db94d59/job.log (1/1) tests/

Re: [Qemu-devel] [PATCH] migration: Use RunState enum to save global state pre migrate

* Maxiwell S. Garcia (maxiw...@linux.ibm.com) wrote: > The GlobalState struct has two confusing fields: > - uint8_t runstate[100] > - RunState state > > The first field saves the 'current_run_state' from vl.c file before > migrate. The second field is filled in the post load func using the > 'runs

[Qemu-devel] [PATCH 0/5] tests/acceptance: Add bFLT loader linux-user test

Hi, This series refactor the current avocado_qemu Test class to allow MachineTest and LinuxUserTest classes. We can then add linux-user tests. A simple/quick one is added as example, it runs a STM32 busybox binary (in the bFLT format) on Travis-CI. The same test can be used to confirm LP bug 18336

Re: [Qemu-devel] [PATCH v2 0/4] Miscellaneous patches from the RISC-V fork

On Mon, 24 Jun 2019 16:42:27 PDT (-0700), Alistair Francis wrote: This should be the last series bringing the patches from the RISC-V fork into mainline QEMU. v2: - Add Wladimir's SOB line, after talking to them - Allow c.andi to have a 0 immediate Dayeol Lee (1): target/riscv: Fix PMP rang

[Qemu-devel] [PATCH 2/5] tests/acceptance: Make pick_default_qemu_bin() more generic

Make pick_default_qemu_bin() generic to find qemu-system or qemu-user binaries. Signed-off-by: Philippe Mathieu-Daudé --- tests/acceptance/avocado_qemu/__init__.py | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/

Re: [Qemu-devel] [PATCH v2] pc: fix possible NULL pointer dereference in pc_machine_get_device_memory_region_size()

On 6/24/19 11:02 AM, Igor Mammedov wrote: > QEMU will crash when device-memory-region-size property is read if > ms->device_memory > wasn't initialized yet. > > Crash can be reproduced with: > $QEMU -preconfig -qmp unix:qmp_socket,server,nowait & > ./scripts/qmp/qom-get -s qmp_socket /machine.d

[Qemu-devel] [PATCH 5/5] .travis.yml: Let the avocado job run linux-user tests

From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index aeb9b211cd..2ece761ac7 100644 --- a/.travis.yml +++ b/.travis.yml @@ -231,7 +231,7 @@ matrix: # Acceptanc

Re: [Qemu-devel] qemu-system-x86_64: hw/usb/core.c:720: usb_ep_get: Assertion `dev != NULL' failed

Cc'ing more people. On 6/24/19 8:01 PM, Guenter Roeck wrote: > Hi, > > I have seen the following problem several times recently. This is with > qemu-4.0. > > qemu-system-x86_64: hw/usb/core.c:720: usb_ep_get: Assertion `dev != NULL' > failed > > Backtrace gives me the following call path. >

Re: [Qemu-devel] [PATCH v2] riscv: virt: Add cpu-topology DT node.

On Mon, 24 Jun 2019 16:41:44 PDT (-0700), Atish Patra wrote: Currently, there is no cpu topology defined in RISC-V. Define a device tree node that clearly describes the entire topology. This saves the trouble of scanning individual cache to figure out the topology. Here is the linux kernel patch

Re: [Qemu-devel] [RFC 0/1] Add live migration support to the PVRDMA device

> On 25 Jun 2019, at 11:49, Marcel Apfelbaum wrote: > > Hi Dmitry, > > On 6/25/19 11:39 AM, Dmitry Fleytman wrote: >> >>> On 25 Jun 2019, at 11:14, Marcel Apfelbaum >>> wrote: >>> >>> Hi Sukrit >>> >>> On 6/21/19 5:45 PM, Sukrit Bhatnagar wrote: Hi, >>> [...] This RFC is meant

Re: [Qemu-devel] [PATCH v4 05/13] vfio: Add VM state change handler to know state of VM

* Kirti Wankhede (kwankh...@nvidia.com) wrote: > VM state change handler gets called on change in VM's state. This is used to > set > VFIO device state to _RUNNING. > VM state change handler, migration state change handler and log_sync listener > are called asynchronously, which sometimes lead to

Re: [Qemu-devel] [PATCH v2] i386/kvm: Fix build with -m32

On 6/24/19 9:39 PM, Max Reitz wrote: > find_next_bit() takes a pointer of type "const unsigned long *", but the > first argument passed here is a "uint64_t *". These types are > incompatible when compiling qemu with -m32. > > Just use ctz64() instead. > > Fixes: c686193072a47032d83cb4e131dc49ae3

Re: [Qemu-devel] [PATCH] riscv: virt: Add cpu-topology DT node.

On 6/25/19 1:24 AM, Alistair Francis wrote: > On Mon, Jun 24, 2019 at 3:57 PM Atish Patra wrote: >> >> Currently, there is no cpu topology defined in RISC-V. >> Define a device tree node that clearly describes the >> entire topology. This saves the trouble of scanning individual >> cache to figure

Re: [Qemu-devel] [PATCH v2 3/4] Introduce dump of hot TBs

vandersonmr writes: > Adding a function to dump the Nth hottest TBs. > The block PC, execution count and ops is dump to the log. > > Signed-off-by: Vanderson M. do Rosario > --- > accel/tcg/translate-all.c | 45 +++ > include/exec/exec-all.h | 2 ++ > 2

Re: [Qemu-devel] [PATCH] riscv: virt: Add cpu-topology DT node.

On Tue, Jun 25, 2019 at 12:36:35PM +0200, Philippe Mathieu-Daudé wrote: > On 6/25/19 1:24 AM, Alistair Francis wrote: > > On Mon, Jun 24, 2019 at 3:57 PM Atish Patra wrote: > >> > >> Currently, there is no cpu topology defined in RISC-V. > >> Define a device tree node that clearly describes the >

Re: [Qemu-devel] [PATCH] Fix build error when VNC is configured out

Cc: David Gilbert Christophe de Dinechin writes: > In hmp_change(), the variable hmp_mon is only used > by code under #ifdef CONFIG_VNC. This results in a build > error when VNC is configured out with the default of > treating warnings as errors: > > monitor/hmp-cmds.c: In function ‘hmp_change’:

Re: [Qemu-devel] [PATCH] ui: Correct icon install path

Hi Colin, On 6/25/19 5:21 AM, Colin Xu wrote: > The double slash in path will fail the installation on MINGW/MSYS. > > Fixes: a8260d387638 (ui: install logo icons to $prefix/share/icons) > > Signed-off-by: Colin Xu > --- > Makefile | 16 > 1 file changed, 8 insertions(+), 8 de

Re: [Qemu-devel] [PATCH] ui: Correct icon install path

On Tue, Jun 25, 2019 at 11:21:42AM +0800, Colin Xu wrote: > The double slash in path will fail the installation on MINGW/MSYS. > > Fixes: a8260d387638 (ui: install logo icons to $prefix/share/icons) > > Signed-off-by: Colin Xu > --- > Makefile | 16 > 1 file changed, 8 insertio

Re: [Qemu-devel] [Qemu-block] [PATCH v3] block/rbd: increase dynamically the image size

Ping. Thanks, Stefano On Tue, May 21, 2019 at 10:56 AM Stefano Garzarella wrote: > > Kindly ping. > > Thanks, > Stefano > > On Thu, May 09, 2019 at 04:59:27PM +0200, Stefano Garzarella wrote: > > RBD APIs don't allow us to write more than the size set with > > rbd_create() or rbd_resize(). > > I

Re: [Qemu-devel] [PATCH 0/5] tests/acceptance: Add bFLT loader linux-user test

Patchew URL: https://patchew.org/QEMU/20190625101524.13447-1-phi...@redhat.com/ Hi, This series failed build test on s390x host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commit that ha

Re: [Qemu-devel] [PATCH] minikconf: do not include variables from MINIKCONF_ARGS in config-all-devices.mak

On 6/25/19 10:13 AM, Paolo Bonzini wrote: > When minikconf writes config-devices.mak, it includes all variables including > those from MINIKCONF_ARGS. This causes values from config-host.mak to > "stick" to > the ones used in generating config-devices.mak, because config-devices.mak is > included

Re: [Qemu-devel] [PATCH] migration: Use RunState enum to save global state pre migrate

Hi Dave, On 6/25/19 12:18 PM, Dr. David Alan Gilbert wrote: > * Maxiwell S. Garcia (maxiw...@linux.ibm.com) wrote: >> The GlobalState struct has two confusing fields: >> - uint8_t runstate[100] >> - RunState state >> >> The first field saves the 'current_run_state' from vl.c file before >> migrate

Re: [Qemu-devel] [PATCH] Fix build error when VNC is configured out

Hi Christophe, On 6/25/19 11:24 AM, Christophe de Dinechin wrote: > In hmp_change(), the variable hmp_mon is only used > by code under #ifdef CONFIG_VNC. This results in a build > error when VNC is configured out with the default of > treating warnings as errors: > > monitor/hmp-cmds.c: In functi

Re: [Qemu-devel] [PATCH 0/5] tests/acceptance: Add bFLT loader linux-user test

On 6/25/19 12:47 PM, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20190625101524.13447-1-phi...@redhat.com/ > > This series failed build test on s390x host. Please find the details below. > > === TEST SCRIPT END === > > CC qapi/qmp-registry.o > CC qapi/qmp

Re: [Qemu-devel] [PATCH] minikconf: do not include variables from MINIKCONF_ARGS in config-all-devices.mak

On 6/25/19 12:52 PM, Philippe Mathieu-Daudé wrote: > On 6/25/19 10:13 AM, Paolo Bonzini wrote: >> When minikconf writes config-devices.mak, it includes all variables including >> those from MINIKCONF_ARGS. This causes values from config-host.mak to >> "stick" to >> the ones used in generating con

Re: [Qemu-devel] [PATCH 1/3] pcie: don't skip multi-mask events

On Fri, 21 Jun 2019 02:46:46 -0400 "Michael S. Tsirkin" wrote: > If we are trying to set multiple bits at once, testing that just one of > them is already set gives a false positive. As a result we won't > interrupt guest if e.g. presence detection change and attention button > press are both set

Re: [Qemu-devel] [PATCH] riscv: virt: Add cpu-topology DT node.

On 6/25/19 12:41 PM, Daniel P. Berrangé wrote: > On Tue, Jun 25, 2019 at 12:36:35PM +0200, Philippe Mathieu-Daudé wrote: >> On 6/25/19 1:24 AM, Alistair Francis wrote: >>> On Mon, Jun 24, 2019 at 3:57 PM Atish Patra wrote: Currently, there is no cpu topology defined in RISC-V. Defin

[Qemu-devel] [RFC PATCH 5/7] pci-bridge: CCIX capable PCIE/CCIX switch downstream port

Note that this is simply emulation of the configuration space. Has the same issue with cut and paste code as the upstream port driver. Solution likely to be the same. Signed-off-by: Jonathan Cameron --- hw/pci-bridge/Makefile.objs | 2 +- hw/pci-bridge/ccix_downstream.c | 222 +++

[Qemu-devel] [RFC PATCH 1/7] Temp: Add the PCI_EXT_ID_DVSEC definition to the qemu pci_regs.h copy.

This hasn't yet been added to the linux kernel tree, so for purposes of this RFC just add it locally. Signed-off-by: Jonathan Cameron --- include/standard-headers/linux/pci_regs.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/standard-headers/linux/pci_regs.h b/i

[Qemu-devel] [RFC PATCH 7/7] Temp: Add to ARM64 makefiles for testing

Signed-off-by: Jonathan Cameron --- default-configs/arm-softmmu.mak | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak index 3158e1a10a..d5d4c8ecf1 100644 --- a/default-configs/arm-softmmu.mak +++ b/default-confi

[Qemu-devel] [RFC PATCH 2/7] pci: Add Huawei vendor ID and Huawei Emulated CCIX Device IDs.

These device IDs have been allocated for emulated only devices, giving us more flexibility than would be possible by emulating real devices. They will be used for the CCIX PCIe configuration space emulation modules that follow. Signed-off-by: Jonathan Cameron --- include/hw/pci/pci_ids.h | 5 ++

[Qemu-devel] [RFC PATCH 4/7] pci-bridge: CCIX capable PCIE/CCIX switch upstream port.

Note that these occur as function 0 within CCIX devices that have many other elements in the PCIE topology. This driver has around 100 lines of code copied directly from the xio3130-upstream.c file. There are various options to avoid this: 1) Expose the xio3130 functions so this module can just c

[Qemu-devel] [RFC PATCH 0/7] qemu: CCIX pcie config space emulation

CCIX topologies are 'layered' on top of PCIe tree topologies. This is done primarily by allowing a single CCIX device to appear as multiple disjoint nodes in the PCIe tree. This layering is described via extensive PCIe DVSEC extended capabilities in PCIe config space across all the functions that

[Qemu-devel] [RFC PATCH 3/7] pci: CCIX config space emulation library.

The nature of the complex topologies supported by CCIX means that it will be sometime before it is possible to construct many of the interesting cases in hardware, and it will be extermely hard to exercise all of the combinations whilst developing firwmare and drivers. To that end, the intent of t

Re: [Qemu-devel] [PATCH] deprecate -mem-path fallback to anonymous RAM

On Mon, 24 Jun 2019 16:01:49 +0200 Markus Armbruster wrote: > Igor Mammedov writes: > > > On Mon, 24 Jun 2019 10:17:33 +0200 > > Markus Armbruster wrote: > > > >> Igor Mammedov writes: > >> > >> > Fallback might affect guest or worse whole host performance > >> > or functionality if back

[Qemu-devel] [RFC PATCH 6/7] misc: CCIX endpoint function

This handles the case where a given function is not also a PCIe topology upstream or downstream port. This include, non function 0 functions on upstream ports and any function on a device without a PCIe switch. Note that this doesn't exclude the possibility of this being the upstream port of a CC

Re: [Qemu-devel] [RFC 0/1] Add live migration support to the PVRDMA device

On 6/25/19 12:11 PM, Dr. David Alan Gilbert wrote: * Marcel Apfelbaum (marcel.apfelb...@gmail.com) wrote: Hi Dmitry, On 6/25/19 11:39 AM, Dmitry Fleytman wrote: On 25 Jun 2019, at 11:14, Marcel Apfelbaum wrote: Hi Sukrit On 6/21/19 5:45 PM, Sukrit Bhatnagar wrote: Hi, [...] This RFC i

Re: [Qemu-devel] icount mode

Hi Alex, If there is something wrong, please tell me. I really like to have some discusses with Qemu developers about icount mode. Thanks a lot! Wentong Wu -Original Message- From: Wu, Wentong Sent: Tuesday, June 25, 2019 4:44 AM To: 'Alex Bennée' ; qemu-devel@nongnu.org Subject: RE:

Re: [Qemu-devel] [PATCH v2 0/1] Export machine type deprecation info through QMP

Eduardo Habkost writes: > Any objections to this? I'm planning to merge it this week. No objection, in fact: Reviewed-by: Markus Armbruster The QAPI feature flags work, once finished, might render this redundant, but I'd rather not have my unfinished solution for a wider problem block your wo

Re: [Qemu-devel] [PATCH v17 05/10] acpi: add build_append_ghes_generic_status() helper for Generic Error Status Block

On 2019/6/20 20:42, Igor Mammedov wrote: > On Tue, 14 May 2019 04:18:18 -0700 > Dongjiu Geng wrote: > >> It will help to add Generic Error Status Block to ACPI tables >> without using packed C structures and avoid endianness >> issues as API doesn't need explicit conversion. >> >> Signed-off-b

Re: [Qemu-devel] [PATCH v2 4/4] adding -d hot_tbs:limit command line option

vandersonmr writes: > add option to dump the N most hot TB blocks. > -d hot_tbs:N > > Signed-off-by: vandersonmr > --- > include/qemu/log-for-trace.h | 2 ++ > linux-user/exit.c| 3 +++ > util/log.c | 9 + > 3 files changed, 14 insertions(+) > > diff --gi

[Qemu-devel] [PATCH v4 0/5] target/mips: Improve MSA TCG tests

From: Aleksandar Markovic This series contains various improvements and additions of MSA ASE TCG tests. v3->v4: - patches 1 and 2 from v3 got reviewed and integrated into upstream, so they are now removed in v4 - added tests for MSA int multiply instructions - added support for MSA bi

[Qemu-devel] [PATCH v4 2/5] tests/tcg: target/mips: Add tests for MSA move instructions

From: Aleksandar Markovic Add tests for MSA move instructions. Signed-off-by: Aleksandar Markovic --- tests/tcg/mips/include/wrappers_msa.h | 8 ++ tests/tcg/mips/user/ase/msa/move/test_msa_move_v.c | 149 + tests/tcg/mips/user/ase/msa/test_msa_compile.sh

[Qemu-devel] [PATCH v4 4/5] tests/tcg: target/mips: Amend tests for MSA int multiply instructions

From: Aleksandar Markovic Amend tests for MSA int multiply instructions. Signed-off-by: Aleksandar Markovic --- .../user/ase/msa/int-multiply/test_msa_maddv_d.c | 214 + tests/tcg/mips/user/ase/msa/test_msa_compile.sh| 16 ++ 2 files changed, 230 insertions(+) creat

[Qemu-devel] [PATCH v6 1/8] hw/acpi: Make ACPI IO address space configurable

This is in preparation for adding support for ARM64 platforms where it doesn't use port mapped IO for ACPI IO space. Also move few MEMORY_* definitions to header so that other memory hotplug event signalling mechanisms (eg. Generic Event Device on HW-reduced acpi platforms) can use the same from t

[Qemu-devel] [PATCH v4 1/5] tests/tcg: target/mips: Add tests for MSA bit move instructions

From: Aleksandar Markovic Add tests for MSA bit move instructions. Signed-off-by: Aleksandar Markovic --- tests/tcg/mips/include/wrappers_msa.h | 32 ++- .../mips/user/ase/msa/bit-move/test_msa_binsl_b.c | 214 + .../mips/user/ase/msa/bit-move/test_msa_binsl_

[Qemu-devel] [PATCH v6 3/8] hw/acpi: Add ACPI Generic Event Device Support

From: Samuel Ortiz The ACPI Generic Event Device (GED) is a hardware-reduced specific device[ACPI v6.1 Section 5.6.9] that handles all platform events, including the hotplug ones. This patch generates the AML code that defines GEDs. Platforms need to specify their own GED Event bitmap to describ

[Qemu-devel] [PATCH v6 0/8] ARM virt: ACPI memory hotplug support

This series is an attempt to provide device memory hotplug support on ARM virt platform. This is based on Eric's recent works here[1] and carries some of the pc-dimm related patches dropped from his series. The kernel support for arm64 memory hot add was added recently by Robin and hence the gues

[Qemu-devel] [PATCH v6 2/8] hw/acpi: Do not create memory hotplug method when handler is not defined

From: Samuel Ortiz With Hardware-reduced ACPI, the GED device will manage ACPI hotplug entirely. As a consequence, make the memory specific events AML generation optional. The code will only be added when the method name is not NULL. Signed-off-by: Samuel Ortiz Signed-off-by: Shameer Kolothum

[Qemu-devel] [PATCH v6 8/8] hw/arm: Use GED for system_powerdown event

Use GED for system_powerdown event instead of GPIO for ACPI. Guest boot with DT still uses GPIO. Signed-off-by: Shameer Kolothum Reviewed-by: Eric Auger --- hw/arm/virt-acpi-build.c | 37 + hw/arm/virt.c| 7 +++ 2 files changed, 4 insertions(

[Qemu-devel] [PATCH v6 5/8] hw/arm/virt: Enable device memory cold/hot plug with ACPI boot

This initializes the GED device with base memory and irq, configures ged memory hotplug event and builds the corresponding aml code. With this, both hot and cold plug of device memory is enabled now for Guest with ACPI boot. Memory cold plug support with Guest DT boot is not yet supported. Signed

  1   2   3   >